Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other

2015-01-26 Thread Chen Gang S
On 1/26/15 23:01, Peter Maydell wrote: On 26 January 2015 at 14:59, Chen Gang S gang.c...@sunrus.com.cn wrote: On 1/26/15 06:10, Peter Maydell wrote: I would just like the commit message to be clear about the scope of the work the patch covers. If the patch is just Fix mismatched lock/unlock

[Qemu-devel] [PATCH 1/2] sPAPR: reread boot_device on reset

2015-01-26 Thread dvaleev
From: Dinar Valeev dval...@suse.com Update boot_device on reset. This is required to have -boot once=X working. This patch is moving creating fdt qemu,boot-device entry from spapr_create_fdt_skel to spapr_finalize_fdt which is used on guest reset. Signed-off-by: Dinar Valeev dval...@suse.com

Re: [Qemu-devel] [PATCH v5 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp

2015-01-26 Thread Max Reitz
On 2015-01-16 at 03:46, Fam Zheng wrote: QMP command block_set_io_throttle expects underscores in parameters instead of dashes: {iops,bps}_{rd,wr,max}. Add optional argument conv_keys (defaults to True, backward compatible), it will be used in IO throttling test case. Reviewed-by: Benoit Canet

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Max Reitz
On 2015-01-26 at 15:40, Paolo Bonzini wrote: On 26/01/2015 20:27, Max Reitz wrote: However, this was wrong: With the NBD attached to some BB, it should stay attached until the NBD export is removed or the server stopped; medium ejection should have nothing to do with this (other than the NBD

Re: [Qemu-devel] [PATCH v5 5/5] qemu-iotests: Add 093 for IO throttling

2015-01-26 Thread Max Reitz
On 2015-01-16 at 03:46, Fam Zheng wrote: This case utilizes qemu-io command aio_{read,write} -q to verify the effectiveness of IO throttling options. It's implemented by driving the vm timer from qtest protocol, so the throttling timers are signaled with determinied time duration. Then we

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Paolo Bonzini
On 26/01/2015 21:43, Max Reitz wrote: If the NBD server is attached to the BDS, it should keep serving the BDS. The problem is that it is no longer attached to the BDS, but to the BB. That's not necessarily a problem. :) It is the cause of the problem though. Is it possible to attach two

Re: [Qemu-devel] [PATCH 04/21] block: Add bdrv_close_all() handlers

2015-01-26 Thread Paolo Bonzini
On 26/01/2015 22:13, Max Reitz wrote: An eject blocker would also break backwards-compatibility though. What about an eject notifier? Would that concept make sense? It does make sense (in that it is the way I would implement just do what we always did), but I just don't like it for the

Re: [Qemu-devel] [PATCH v4 02/17] spapr_drc: initial implementation of sPAPRDRConnector device

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-16 00:19:08) On Tue, Dec 23, 2014 at 06:30:16AM -0600, Michael Roth wrote: This device emulates a firmware abstraction used by pSeries guests to manage hotplug/dynamic-reconfiguration of host-bridges, PCI devices, memory, and CPUs. It is conceptually similar to

Re: [Qemu-devel] [PATCH v4 02/17] spapr_drc: initial implementation of sPAPRDRConnector device

2015-01-26 Thread Michael Roth
Quoting Bharata B Rao (2015-01-02 04:32:58) On Tue, Dec 23, 2014 at 6:00 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: This device emulates a firmware abstraction used by pSeries guests to manage hotplug/dynamic-reconfiguration of host-bridges, PCI devices, memory, and CPUs. It is

Re: [Qemu-devel] [PATCH v4 10/17] spapr_drc: add spapr_drc_populate_dt()

2015-01-26 Thread Michael Roth
Quoting David Gibson (2015-01-18 23:15:28) On Tue, Dec 23, 2014 at 06:30:24AM -0600, Michael Roth wrote: This function handles generation of ibm,drc-* array device tree properties to describe DRC topology to guests. This will by used by the guest to direct RTAS calls to manage any dynamic

<    1   2   3   4