Vladimir Sementsov-Ogievskiy writes:
> Hi there.. Can someone review my bug fix? I'll surely fix typos in
> description after it.
The file you patch has since moved. Suggest a quick rebase. Make sure
to cc: your v2 to migration maintainers.
$ scripts/get_maintainer.pl -f migration/block.c
Ke
Dinar Valeev writes:
> On 01/28/2015 02:48 AM, Gonglei wrote:
>> On 2015/1/27 18:49, Dinar Valeev wrote:
>>
>>> On 01/27/2015 10:18 AM, Gonglei wrote:
On 2015/1/27 16:57, Dinar Valeev wrote:
> On 01/27/2015 03:51 AM, Gonglei wrote:
>> On 2015/1/27 7:52, dval...@suse.de wrote:
>
On 2015/1/28 18:00, Igor Mammedov wrote:
> On Wed, 28 Jan 2015 09:56:26 +0200
> "Michael S. Tsirkin" wrote:
>
>>> I've tried redo series with passing alloc list as first argument,
>>> looks ugly as hell
>>
>> I tried too. Not too bad at all. See below:
>>
>> diff --git a/hw/i386/acpi-build.c b/hw
From: Gonglei
At present, the target is valued boot_tpgt, In addition,
channel and lun both are 0 for bootable vhost-scsi device.
Signed-off-by: Gonglei
Signed-off-by: Bo Su
---
hw/scsi/vhost-scsi.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost
From: Gonglei
Qemu haven't provide a bootindex property for vhost-scsi device.
So, we can not assign the boot order for it at present. But
Some clients/users have requirements for that in some scenarios.
This patch achieve the aim in Qemu side.
Because Qemu only accept an wwpn argument for vhost
From: Gonglei
Because Qemu only accept an wwpn argument for vhost-scsi, we
cannot assign a tpgt. That's say tpg is transparent for Qemu, Qemu
doesn't know which tpg can boot, but vhost-scsi driver module
doesn't know too for one assigned wwpn.
At present, we assume that the first tpg can boot on
From: Gonglei
Signed-off-by: Gonglei
---
hw/scsi/vhost-scsi.c | 9 +
hw/virtio/virtio-pci.c | 2 ++
include/hw/virtio/vhost-scsi.h | 1 +
3 files changed, 12 insertions(+)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index dcb2bc5..9c4f613 100644
--- a/hw/
From: Gonglei
commit 6b1566c (qdev: Introduce FWPathProvider interface) did a
good job for supproting to get firmware path on some different
architectures.
Moreover further more, we can use the interface to get firmware
path name for a device which isn't attached a specific bus,
such as virtio-b
From: Gonglei
In the way, we can make the bootindex property take effect.
At the meanwhile, the firmware path name of vhost-scsi is
"channel@channel/vhost-scsi@target,lun".
Signed-off-by: Gonglei
---
hw/scsi/vhost-scsi.c | 20
include/hw/virtio/vhost-scsi.h | 3
From: Mao Chuan Li
The tests for device type "ide_cd" are skipped for the s390 platform.
The default device id of hard disk on the s390 platform differs to that
of the x86 platform. A new variable device_id is defined and "virtio0"
set for the s390 platform. A s390 platform specific output file i
From: Mao Chuan Li
There is no such device 'ide-cd' defined on the s390 platform, so
test_medium_not_found() test is skipped.
Reviewed-by: Michael Mueller
Signed-off-by: Mao Chuan Li
---
tests/qemu-iotests/041 | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qemu-iotests/041
From: Mao Chuan Li
This patch adds qemu machine type support to the io test suite. Based on
the qemu default machine type the reference output file can now vary
from the default to a machine specific output file if necessary. That
shall allow all platforms to use this test suite.
Reviewed-by:
From: Mao Chuan Li
This patch fixes an io test suite issue that was introduced with the
commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only
a single "stdio" character device'. The option supresses the creation of
default devices.
Reviewed-by: Michael Mueller
Signed-off-by: M
From: Mao Chuan Li
There is no such device 'ide-cd' defined on the s390 platform, so
test_medium_not_found() test is skipped.
Reviewed-by: Michael Mueller
Signed-off-by: Mao Chuan Li
---
tests/qemu-iotests/055 | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qemu-iotests/055
From: Xiao Guang Chen
Due to no default floppy and cdrom for guests any more, output files for test
case 067, 071 and 087 should be editted to make the test pass.
Use virtio-blk instead of virtio-blk-pci as the device driver for test 067.
For virtio-blk-pci is equal to virt-blk as device driver
From: Xiao Guang Chen
v2:
1. Drop the patches for test 039 for it has been fixed in upstream.
2. Integrate patches for test 071, 067 and 087.
3. Keep the other patches.
v1:
1. updated the test suite to be default-machine-type-aware, from the previous
platform-aware
2. created a new patch "qemu-
On Thu, Jan 29, 2015 at 04:04:58PM +1100, Alexey Kardashevskiy wrote:
> Instead of tweaking a TCE table device by adding there a bypass flag,
> let's add an alias to RAM and IOMMU memory region, and enable/disable
> those according to the selected bypass mode.
> This way IOMMU memory region can hav
Instead of tweaking a TCE table device by adding there a bypass flag,
let's add an alias to RAM and IOMMU memory region, and enable/disable
those according to the selected bypass mode.
This way IOMMU memory region can have size of the actual window rather
than ram_size which is essential for upcomi
On Thu, Jan 29, 2015 at 11:48:46AM +1100, Alexey Kardashevskiy wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 01/29/2015 11:31 AM, David Gibson wrote:
> > On Wed, Jan 28, 2015 at 07:49:48PM +1100, Alexey Kardashevskiy wrote:
> >> On 01/28/2015 08:21 AM, Alexey Kardashevskiy wrote:
Hi,Michael S.Tsirkin
The vhost-user device will not work if there are two numa nodes in VM.
Should we fix this bug or ignore it ?
On 2014/12/18 13:06, Linhaifeng wrote:
>
>
> On 2014/12/17 14:02, haifeng@huawei.com wrote:
>> From: linhaifeng
>>
>> If we create VM with two or more numa nod
On 2015/1/29 8:42, Alexander Graf wrote:
>
>
> On 29.01.15 01:40, Gonglei wrote:
>> On 2015/1/26 17:35, Alexander Graf wrote:
>>
>>> On 01/26/2015 11:49 AM, Dinar Valeev wrote:
On 01/24/2015 12:04 AM, Alexander Graf wrote:
>
>
> On 23.01.15 23:51, dval...@suse.de wrote:
>> F
Any comments about this series?
If no, could anyone help to merge this?
Thanks.
Regards,
Zhu
On Wed, 2015-01-28 at 15:45 +0800, Zhu Guihua wrote:
> Memory and CPU hot unplug are both asynchronous procedures.
> When the unplug operation happens, unplug request cb is called first.
> And when guest
On 2015/1/29 10:21, Eric Blake wrote:
> On 01/28/2015 05:31 PM, Gonglei wrote:
>> On 2015/1/28 19:16, Markus Armbruster wrote:
>>
>>> I screwed up cc: qemu-trivial, my apologies.
>>>
>
Markus Armbruster (6):
onenand: g_malloc() can't fail, bury dead error handling
rtl8139: g_ma
On 01/28/2015 05:31 PM, Gonglei wrote:
> On 2015/1/28 19:16, Markus Armbruster wrote:
>
>> I screwed up cc: qemu-trivial, my apologies.
>>
>>> Markus Armbruster (6):
>>> onenand: g_malloc() can't fail, bury dead error handling
>>> rtl8139: g_malloc() can't fail, bury dead error handling
>>>
On Thu, 01/29 08:53, Fam Zheng wrote:
> On Wed, 01/28 11:22, Max Reitz wrote:
> > On 2015-01-27 at 21:28, Fam Zheng wrote:
> > >This case utilizes qemu-io command "aio_{read,write} -q" to verify the
> > >effectiveness of IO throttling options.
> > >
> > >It's implemented by driving the vm timer fro
On Mon, Jan 26, 2015 at 07:51:58PM +0530, Aneesh Kumar K.V wrote:
> We look at two sizes specified in ISA (4K, 64K). If not found matching,
> we consider it 16MB.
>
> Without this patch we would fail to lookup address above 16MB range.
> Below 16MB happened to work before because the kernel have a
On Thu, Jan 08, 2015 at 11:40:14AM +0530, Bharata B Rao wrote:
> PowerPC kernel adds or removes CPUs in core granularity and hence
> onlines/offlines all the SMT threads of a core during hot plug/unplug.
> Support this notion by starting all SMT threads of a core when a core
> is hotplugged.
>
> S
On Thu, Jan 08, 2015 at 11:40:17AM +0530, Bharata B Rao wrote:
> From: Gu Zheng
This needs a commit message, it's not at all clear from the 1-line description.
>
> Signed-off-by: Gu Zheng
> Signed-off-by: Bharata B Rao
>(added spapr bits)
> ---
> cpus.c | 44 +++
On Thu, Jan 08, 2015 at 11:40:11AM +0530, Bharata B Rao wrote:
> Move some CPU initialization code from machine init function to
> CPU realizefn so that it can be used from CPU hotplug path too.
>
> With the inclusion of ppc.h in translate_init.c, explicit *irq_init()
> function definitions aren't
On Thu, Jan 08, 2015 at 11:40:09AM +0530, Bharata B Rao wrote:
> Advertise CPU DR-capability to the guest via device tree.
>
> Signed-off-by: Bharata B Rao
> Signed-off-by: Michael Roth
>[spapr_drc_reset implementation]
Reviewed-by: David Gibson
--
David Gibson
On Thu, Jan 08, 2015 at 11:40:08AM +0530, Bharata B Rao wrote:
> From: Michael Roth
>
> Introduce an sPAPRMachineClass sub-class of MachineClass to
> handle sPAPR-specific machine configuration properties.
>
> The 'dr_phb[cpu,lmb]_enabled' field of that class can be set as
> part of machine-spec
On Thu, Jan 08, 2015 at 11:40:13AM +0530, Bharata B Rao wrote:
> Support CPU hotplug via device-add command. Use the exising EPOW event
> infrastructure to send CPU hotplug notification to the guest.
>
> Signed-off-by: Bharata B Rao
> ---
> hw/ppc/spapr.c | 205
> ++
On Thu, Jan 08, 2015 at 11:40:12AM +0530, Bharata B Rao wrote:
> Add support for ibm,lrdr-capacity since this is needed by the guest
> kernel to know about the possible hot-pluggable CPUs and Memory.
>
> Define minimum hotpluggable memory size as 256MB and start storing maximum
> possible memory f
On Thu, Jan 08, 2015 at 11:40:16AM +0530, Bharata B Rao wrote:
> Support hot removal of CPU for sPAPR guests.
>
> Signed-off-by: Bharata B Rao
> ---
> hw/ppc/spapr.c | 43 +++
> 1 file changed, 43 insertions(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spa
On Thu, Jan 08, 2015 at 11:40:10AM +0530, Bharata B Rao wrote:
> Use max_cpus instead of smp_cpus when intializating xics system. Also
> report max_cpus in ibm,interrupt-server-ranges device tree property of
> interrupt controller node.
>
> Signed-off-by: Bharata B Rao
Reviewed-by: David Gibson
On 1/29/15 06:36, Peter Maydell wrote:
> On 28 January 2015 at 22:09, Chen Gang S wrote:
>> - Is what I said above really correct (e.g. is linux-user really mainly
>>for cpu emulation)?.
>
> Not really. linux-user is mainly for running single Linux binaries.
> It has a secondary use for runn
On 01/28/15 19:05, Don Slutz wrote:
> On 01/28/15 14:32, Don Slutz wrote:
>> On 12/05/14 05:50, Paul Durrant wrote:
>>> The ioreq-server API added to Xen 4.5 offers better security than
>>> the existing Xen/QEMU interface because the shared pages that are
>>> used to pass emulation request/result
On Wed, 01/28 11:22, Max Reitz wrote:
> On 2015-01-27 at 21:28, Fam Zheng wrote:
> >This case utilizes qemu-io command "aio_{read,write} -q" to verify the
> >effectiveness of IO throttling options.
> >
> >It's implemented by driving the vm timer from qtest protocol, so the
> >throttling timers are
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 01/29/2015 11:31 AM, David Gibson wrote:
> On Wed, Jan 28, 2015 at 07:49:48PM +1100, Alexey Kardashevskiy wrote:
>> On 01/28/2015 08:21 AM, Alexey Kardashevskiy wrote:
>>> On 01/27/2015 05:13 PM, Alexey Kardashevskiy wrote:
> [snip]
diff --git
On 29.01.15 01:40, Gonglei wrote:
> On 2015/1/26 17:35, Alexander Graf wrote:
>
>> On 01/26/2015 11:49 AM, Dinar Valeev wrote:
>>> On 01/24/2015 12:04 AM, Alexander Graf wrote:
On 23.01.15 23:51, dval...@suse.de wrote:
> From: Dinar Valeev
>
> In order to have -boot o
On 2015/1/29 6:22, Dinar Valeev wrote:
> On 01/28/2015 02:48 AM, Gonglei wrote:
>> On 2015/1/27 18:49, Dinar Valeev wrote:
>>
>>> On 01/27/2015 10:18 AM, Gonglei wrote:
On 2015/1/27 16:57, Dinar Valeev wrote:
> On 01/27/2015 03:51 AM, Gonglei wrote:
>> On 2015/1/27 7:52, dval...@
On 2015/1/28 19:12, Wei Liu wrote:
On Wed, Jan 28, 2015 at 08:42:56AM +0800, Chen, Tiejun wrote:
On 2015/1/27 22:40, Ian Jackson wrote:
Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine
property to support IGD GFX passthrough"):
On 2015/1/23 8:43, Chen, Tiejun wro
On 2015/1/26 17:35, Alexander Graf wrote:
> On 01/26/2015 11:49 AM, Dinar Valeev wrote:
>> On 01/24/2015 12:04 AM, Alexander Graf wrote:
>>>
>>>
>>> On 23.01.15 23:51, dval...@suse.de wrote:
From: Dinar Valeev
In order to have -boot once=d functioning, it is required to have
q
Ping agraf,
Any word on merging this?
On Wed, Jan 14, 2015 at 01:33:39PM +1100, David Gibson wrote:
> pseries guests can have large numbers of PCI host bridges. To avoid the
> user having to specify a number of different configuration values for every
> one, the device supports an "index" proper
On 2015/1/28 19:16, Markus Armbruster wrote:
> I screwed up cc: qemu-trivial, my apologies.
>
> Markus Armbruster writes:
>
>> I'm routing these patches through qemu-trivial, even though some of
>> them touch actively maintained code, and could go through the
>> respective tree instead:
>>
>> *
On Tue, Jan 27, 2015 at 05:13:32PM +1100, Alexey Kardashevskiy wrote:
> Instead of tweaking a TCE table device by adding there a bypass flag,
> let's add an alias to RAM and IOMMU memory region, and enable/disable
> those according to the selected bypass mode.
> This way IOMMU memory region can hav
On Wed, Jan 28, 2015 at 07:49:48PM +1100, Alexey Kardashevskiy wrote:
> On 01/28/2015 08:21 AM, Alexey Kardashevskiy wrote:
> > On 01/27/2015 05:13 PM, Alexey Kardashevskiy wrote:
[snip]
> >> diff --git a/include/hw/ppc/spapr_vio.h b/include/hw/ppc/spapr_vio.h
> >> index 46edc2a..6ad55d1 100644
> >
On 2015/1/28 22:54, Markus Armbruster wrote:
> Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled
> and my "coverity: Model g_free() isn't necessarily free()" model patch
> applied.
>
> Signed-off-by: Markus Armbruster
> ---
> hw/usb/desc-msos.c | 2 +-
> 1 file changed, 1 ins
On 2015/1/28 22:54, Markus Armbruster wrote:
> Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled
> and my "coverity: Model g_free() isn't necessarily free()" model patch
> applied.
>
> Signed-off-by: Markus Armbruster
> ---
> util/qemu-option.c | 4 ++--
> 1 file changed, 2 i
On 2015/1/28 22:54, Markus Armbruster wrote:
> Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled
> and my "coverity: Model g_free() isn't necessarily free()" model patch
> applied.
>
> Signed-off-by: Markus Armbruster
> ---
> hw/ppc/spapr_vio.c | 2 +-
> 1 file changed, 1 ins
On 2015/1/28 22:54, Markus Armbruster wrote:
> get_opt_value() takes a write-only buffer, so zeroing it is pointless.
> We don't do it elsewhere, either.
>
> Signed-off-by: Markus Armbruster
> ---
> util/qemu-option.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Gon
On Wed, Jan 28, 2015 at 05:07:01PM +0100, Cornelia Huck wrote:
> On Thu, 22 Jan 2015 13:06:09 +1100
> David Gibson wrote:
>
> > On Thu, Dec 11, 2014 at 02:25:09PM +0100, Cornelia Huck wrote:
> > > For virtio-1 devices, we allow a more complex queue layout that doesn't
> > > require descriptor tab
On Wed, Jan 28, 2015 at 04:59:45PM +0100, Cornelia Huck wrote:
> On Thu, 22 Jan 2015 12:43:43 +1100
> David Gibson wrote:
>
> > On Thu, Dec 11, 2014 at 02:25:07PM +0100, Cornelia Huck wrote:
> > > With virtio-1, we support more than 32 feature bits. Let's extend both
> > > host and guest features
On 01/28/15 14:32, Don Slutz wrote:
> On 12/05/14 05:50, Paul Durrant wrote:
>> The ioreq-server API added to Xen 4.5 offers better security than
>> the existing Xen/QEMU interface because the shared pages that are
>> used to pass emulation request/results back and forth are removed
>> from the gue
On Mon, 26 Jan 2015, Leon Alrae wrote:
> Signed-off-by: Leon Alrae
> ---
Enthusiastically:
Reviewed-by: Maciej W. Rozycki
However...
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 635192c..77d89be 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translat
On 2015-01-28 at 17:05, Eric Blake wrote:
On 01/26/2015 02:22 PM, Paolo Bonzini wrote:
On 26/01/2015 22:13, Max Reitz wrote:
An eject blocker would also break backwards-compatibility though. What
about an eject notifier? Would that concept make sense?
It does make sense (in that it is the w
On 2015-01-28 at 17:44, Eric Blake wrote:
On 01/26/2015 12:27 PM, Max Reitz wrote:
Every time a reference to a BlockBackend is taken, a notifier for
bdrv_close_all() has to be deposited so the reference holder can
relinquish its reference when bdrv_close_all() is called. That notifier
should be
On 01/26/2015 12:27 PM, Max Reitz wrote:
> Every time a reference to a BlockBackend is taken, a notifier for
> bdrv_close_all() has to be deposited so the reference holder can
> relinquish its reference when bdrv_close_all() is called. That notifier
> should be revoked on a bdrv_unref() call.
>
I
On 28 January 2015 at 22:09, Chen Gang S wrote:
> - Is what I said above really correct (e.g. is linux-user really mainly
>for cpu emulation)?.
Not really. linux-user is mainly for running single Linux binaries.
It has a secondary use for running gcc test binaries which think
they are "bare
On 28 January 2015 at 21:57, Greg Bellows wrote:
> After getting through patch 9, I wonder if the TB NS bit can also be removed
> as it is implied in the MMU index.
No, because for a 32-bit EL3 we are always running under a Secure
translation regime (S1E3) but the TBFLAG_NS bit may be either 0 or
On 28 January 2015 at 21:37, Greg Bellows wrote:
>
>> +/* Return true if the translation regime is using LPAE format page tables
>> */
>> +static inline bool regime_using_lpae_format(CPUARMState *env,
>> +ARMMMUIdx mmu_idx)
>> +{
>> +int el = regime_
On 01/26/2015 12:27 PM, Max Reitz wrote:
> This adds a list of notifiers to be invoked on bdrv_close_all().
>
> Signed-off-by: Max Reitz
> ---
> block.c | 10 ++
> include/block/block.h | 2 ++
> 2 files changed, 12 insertions(+)
Reviewed-by: Eric Blake
--
Eric Blake
On 01/28/2015 02:48 AM, Gonglei wrote:
> On 2015/1/27 18:49, Dinar Valeev wrote:
>
>> On 01/27/2015 10:18 AM, Gonglei wrote:
>>> On 2015/1/27 16:57, Dinar Valeev wrote:
>>>
On 01/27/2015 03:51 AM, Gonglei wrote:
> On 2015/1/27 7:52, dval...@suse.de wrote:
>
>> From: Dinar Valeev
On 01/26/2015 12:27 PM, Max Reitz wrote:
> bdrv_unref() can lead to bdrv_close(), which in turn will result in
> bdrv_drain_all(). This function will later be called blk_drain_all() and
> iterate only over the BlockBackends for which blk_is_inserted() holds
> true; therefore, bdrv_is_inserted() and
On 01/26/2015 12:27 PM, Max Reitz wrote:
> There are cases where it is probably (!) not necessary to check whether
> the return value of blk_bs() is non-NULL, and those are places after
> blk_new_open(). In every other place, though, there has to be some check
> to make sure that the return value o
On 01/26/2015 02:22 PM, Paolo Bonzini wrote:
>
>
> On 26/01/2015 22:13, Max Reitz wrote:
>>> An eject blocker would also break backwards-compatibility though. What
>>> about an eject notifier? Would that concept make sense?
>>
>> It does make sense (in that it is the way I would implement
On 2015-01-28 at 16:57, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
Signed-off-by: Max Reitz
---
tests/qemu-iotests/118 | 649 +
tests/qemu-iotests/118.out | 5 +
tests/qemu-iotests/group | 1 +
3 files changed, 655 inser
Thank you for your work, too.
Next month, I shall start tile qemu, I guess, for coding, I shall start
from linux-user (which is mainly for cpu emulation).
- For each patch, I should make at least a valuable change, and pass
related test.
- Each month, I should make 3 patches at least.
-
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/118 | 649
> +
> tests/qemu-iotests/118.out | 5 +
> tests/qemu-iotests/group | 1 +
> 3 files changed, 655 insertions(+)
> create mode 100755 tes
On 01/28/2015 02:28 PM, Max Reitz wrote:
> On 2015-01-28 at 16:27, Eric Blake wrote:
>> On 01/27/2015 12:46 PM, Max Reitz wrote:
>>> This patch allows specifying the interface to be used for the drive, and
>>> makes specifying a path optional (if the path is None, the "file" option
>>> will be omit
On Fri, Jan 23, 2015 at 12:20 PM, Peter Maydell
wrote:
> We currently claim that for ARM the mmu_idx should simply be the current
> exception level. However this isn't actually correct -- secure EL0 and EL1
> should have separate indexes from non-secure EL0 and EL1 since their
> VA->PA mappings m
On Fri, Jan 23, 2015 at
12:20 PM, Peter Maydell wrote:
> Now we have the mmu_idx in get_phys_addr(), use it correctly to
> determine the behaviour of virtual to physical address translations,
> rather than using just an is_user flag and the current CPU state.
>
> Some TODO comments have been a
On 2015-01-28 at 16:27, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
This patch allows specifying the interface to be used for the drive, and
makes specifying a path optional (if the path is None, the "file" option
will be omitted, thus creating an empty drive).
Signed-off-by: Max
On 01/27/2015 12:46 PM, Max Reitz wrote:
> This patch allows specifying the interface to be used for the drive, and
> makes specifying a path optional (if the path is None, the "file" option
> will be omitted, thus creating an empty drive).
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests
On 2015-01-28 at 16:22, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
Expose the new read-only option of 'blockdev-change-medium' for the
'change' HMP command.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
---
hmp-commands.hx | 20 +---
hmp.c | 21
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Expose the new read-only option of 'blockdev-change-medium' for the
> 'change' HMP command.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Eric Blake
> ---
> hmp-commands.hx | 20 +---
> hmp.c | 21 -
> 2 file
On 2015-01-28 at 16:08, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
Add an option to qmp_blockdev_change_medium() which allows changing the
read-only status of the block device whose medium is changed.
Some drives do not have a inherently fixed read-only status; for
instance, flo
On 2015-01-28 at 16:01, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
Introduce a new QMP command 'blockdev-change-medium' which is intended
to replace the 'change' command for block devices. The existing function
qmp_change_blockdev() is accordingly renamed to
qmp_blockdev_change_m
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Add an option to qmp_blockdev_change_medium() which allows changing the
> read-only status of the block device whose medium is changed.
>
> Some drives do not have a inherently fixed read-only status; for
> instance, floppy disks can be set read-only or w
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Use separate code paths for the two overloaded functions of the 'change'
> HMP command, and invoke the 'blockdev-change-medium' QMP command if used
> on a block device (by calling qmp_blockdev_change_medium()).
>
> Signed-off-by: Max Reitz
> Reviewed-by:
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Introduce a new QMP command 'blockdev-change-medium' which is intended
> to replace the 'change' command for block devices. The existing function
> qmp_change_blockdev() is accordingly renamed to
> qmp_blockdev_change_medium().
>
> Signed-off-by: Max Reit
On 01/27/2015 12:46 PM, Max Reitz wrote:
> blk_dev_change_media_cb() is called for all potential tray movements;
> however, it is possible to request closing the tray but nothing actually
> happening (on a floppy disk drive without a medium).
>
> Thus, the actual tray status should be inquired bef
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Implement 'change' on block devices by calling blockdev-open-tray,
> blockdev-remove-medium, blockdev-insert-medium (a variation of that
> which does not need a node-name) and blockdev-close-tray.
>
> Signed-off-by: Max Reitz
> ---
> blockdev.c | 191
>
On 2015-01-28 at 14:58, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
Signed-off-by: Max Reitz
---
blockdev.c | 22 ++
qapi/block-core.json | 14 ++
qmp-commands.hx | 33 +
3 files changed, 69 inser
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Implement 'eject' by calling blockdev-open-tray and
> blockdev-remove-medium.
>
> Signed-off-by: Max Reitz
> ---
> blockdev.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Hmm. If you decide to enforce node-name only on the low-lev
On 2015-01-28 at 15:18, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
And a helper function for that which directly takes a pointer to the BDS
to be inserted instead of its node-name (which will be used for
implementing 'change' using blockdev-insert-medium).
Signed-off-by: Max Rei
On 01/27/2015 12:46 PM, Max Reitz wrote:
> And a helper function for that which directly takes a pointer to the BDS
> to be inserted instead of its node-name (which will be used for
> implementing 'change' using blockdev-insert-medium).
>
> Signed-off-by: Max Reitz
> ---
> blockdev.c |
On 28/01/15 23:07, Paolo Bonzini wrote:
On 28/01/2015 19:49, Denis V. Lunev wrote:
The following sequence
int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
for (i = 0; i < 10; i++)
write(fd, buf, 4096);
performs 10% better if buf is aligned to 4096 bytes rath
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> blockdev.c | 25 +
> qapi/block-core.json | 13 +
> qmp-commands.hx | 43 +++
> 3 files changed, 81 insertions(+)
>
>
> +void
On 28/01/2015 19:49, Denis V. Lunev wrote:
> The following sequence
> int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
> for (i = 0; i < 10; i++)
> write(fd, buf, 4096);
> performs 10% better if buf is aligned to 4096 bytes rather then to
> 512 bytes on HDD with
On 2015-01-28 at 14:56, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
Signed-off-by: Max Reitz
---
blockdev.c | 48
qapi/block-core.json | 21 +
qmp-commands.hx | 37
Ping.
On 01/09/15 11:21, Eric Blake wrote:
> On 01/09/2015 08:17 AM, Don Slutz wrote:
>> This is the same way vl.c handles this.
>>
>> Signed-off-by: Don Slutz
>> ---
>> qemu-img.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake
>
>>
>> diff --git a/qemu-i
On 28/01/15 21:49, Denis V. Lunev wrote:
The following sequence
int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
for (i = 0; i < 10; i++)
write(fd, buf, 4096);
performs 10% better if buf is aligned to 4096 bytes rather then to
512 bytes on HDD with 512/4096 lo
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> blockdev.c | 22 ++
> qapi/block-core.json | 14 ++
> qmp-commands.hx | 33 +
> 3 files changed, 69 insertions(+)
>
> +void qmp_blockdev_clo
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> blockdev.c | 48
> qapi/block-core.json | 21 +
> qmp-commands.hx | 37 +
> 3 files changed, 106 inse
On 01/27/2015 12:46 PM, Max Reitz wrote:
> This function removes the BlockDriverState associated with the given
> BlockBackend from that BB and sets the BDS pointer in the BB to NULL.
>
> Signed-off-by: Max Reitz
> ---
> block/block-backend.c | 22 +-
> include/sysem
** No longer affects: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1292234
Title:
qcow2 image corruption on non-extent filesystems (ext3)
Status in qemu package in Ubuntu:
In Progress
Bug
On 12/05/14 05:50, Paul Durrant wrote:
> The ioreq-server API added to Xen 4.5 offers better security than
> the existing Xen/QEMU interface because the shared pages that are
> used to pass emulation request/results back and forth are removed
> from the guest's memory space before any requests are
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Most of the options which blockdev_init() parses for both the
> BlockBackend and the root BDS are valid for just the root BDS as well
> (e.g. read-only). This patch allows specifying these options even if not
> creating a BlockBackend.
>
> Signed-off-by:
On 01/27/2015 12:46 PM, Max Reitz wrote:
> Extract some of the blockdev option extraction code from blockdev_init()
> into an own function. This simplifies blockdev_init() and will allow
s/an/its/
> reusing the code in a different function added in a follow-up patch.
>
> Signed-off-by: Max Reitz
1 - 100 of 276 matches
Mail list logo
