Am 11.02.2015 um 17:23 hat Kevin Wolf geschrieben:
This implements bdrv_co_get_status() for VHD images. This can
s/bdrv_co_get_status/bdrv_co_get_block_status/, obviously (in the
subject as well).
significantly speed up qemu-img convert operation because only with this
function implemented
Found by coverity.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
monitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/monitor.c b/monitor.c
index c3cc060..29d7e5b 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, const QDict
* Eric Blake (ebl...@redhat.com) wrote:
On 02/10/2015 09:47 AM, Daniel P. Berrange wrote:
On Tue, Feb 10, 2015 at 04:16:38PM +, Dr. David Alan Gilbert (git)
wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Once a qemu has been started with -incoming pause the
s/pause
+assert(vs);
return vnc_socket_local_addr(%s:%s, vs-lsock);
}
If you want, I can just silence the warning in Coverity.
I think in the source code is better, human readers might wonder too.
And in case the calling code ever changes behavior the assert will trap
it (even
This fixes a use-after-free if do_address_space_destroy is executed
too late.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
memory.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/memory.c b/memory.c
index 130152c..20f6d9e 100644
--- a/memory.c
+++ b/memory.c
@@ -1943,6 +1943,7
Always process them within half a second. Even though waiting a little
is useful, it is not okay to delay e.g. qemu_opts_del forever.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
util/rcu.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/util/rcu.c
Create a meta-device for PL330 DMA.
Add add_arm_pl330_fdt_node function, with multiple compatible string
and clocks support.
Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com
---
v2 - v3:
got to fail in case of apb_pclk missing
free nodename in fail case
---
hw/arm/sysbus-fdt.c
On 2015-02-09 at 20:35, John Snow wrote:
This allows to put the dirty bitmap into a disabled state where it is
read only. A disabled bitmap will ignore any attempts to set or reset
any of its bits, but can otherwise be renamed, deleted, or re-enabled.
It will be used before backup or writing to
From: Dr. David Alan Gilbert dgilb...@redhat.com
-incoming pause causes qemu to wait for an incoming migration
to be specified later. The monitor can be used to set migration
capabilities that may affect the incoming connection process.
Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com
Hi,
the patchset fixes two minor bugs and takes care of all the packed/fixed point
mac instructions. So far I only implemented all the multiply-add instructions,
since the multiply-sub instructions are similar and I don't want the reviewers
to find the same mistakes twice. Once these are reviewed
Add helpers:
* add64_ssov: adds two 64 bit values and saturates the result.
* addr_h/_ssov: adds two halfwords with two words in q-format with rounding
/ and saturates each result independetly.
Add microcode generator:
* gen_add64_d: adds two 64 bit values.
*
Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de
---
target-tricore/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-tricore/translate.c b/target-tricore/translate.c
index a73b700..cfd6a77 100644
--- a/target-tricore/translate.c
+++
Add helpers:
* madd64_q_ssov: multiply two 32 bit q-format number, add them with a
64 bit q-format number and saturate.
* madd32_q_add_ssov: add two 64 bit q-format numbers and return a 32 bit
result.
* maddr_q_ssov: multiplay two 32 bit
On 2015-02-11 at 05:37, Xiao Guang Chen wrote:
This patch fixes an io test suite issue that was introduced with the
commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only
a single stdio character device'. The option supresses the creation of
default devices such as the floopy
On 11/02/2015 17:37, Gerd Hoffmann wrote:
vnc_display_local_addr will not be called with an invalid display id.
Add assert() to silence coverity warning about a null pointer dereference.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
ui/vnc.c | 1 +
1 file changed, 1 insertion(+)
On 10 February 2015 at 11:50, Greg Bellows greg.bell...@linaro.org wrote:
Added support for running an AArch32 guest on a AArch64 KVM host. Support
has
only been added to the QEMU machvirt machine. The addition of CPU
properties
specifiable from the command line were added to allow
Found by coverity.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
---
monitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/monitor.c b/monitor.c
index c3cc060..2c37953 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1101,6 +1101,7 @@ static int
On 11/02/2015 17:44, Gerd Hoffmann wrote:
Found by coverity.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
monitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/monitor.c b/monitor.c
index c3cc060..29d7e5b 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1101,6 +1101,7 @@
On 02/11/2015 11:50 AM, Max Reitz wrote:
With the full stops and newlines removed (in all error_setg() calls in
this patch):
Habits, habits, habits.\n
Thanks.\n
Add VFIO_DEVICE_TYPE_AMBA.
Differentiate amba and platform devices according to compatible string.
Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com
---
v2 - v3:
add amba flag check in vfio_populate_device
---
hw/vfio/platform.c| 20 +++-
On 2015-02-11 at 11:23, Markus Armbruster wrote:
Max Reitz mre...@redhat.com writes:
On 2015-02-11 at 05:37, Xiao Guang Chen wrote:
The tests for device type ide_cd should only be tested for the pc platform.
The default device id of hard disk on the s390 platform differs to that
of the x86
Adapt arm,pl330 function to use the vfio device property API.
Clock apb-pclk is the default if a clock is needed by the device.
Three optional parameters are taken into account :
- #dma-cells
- #dma-channels
- #dma-requests
Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com
---
v1
This RFC shows the implementation on QEMU side of the device properties
interface
presented in kernel patch series:
[RFC PATCH v3 0/3] vfio: platform: return device properties for a platform
device
from branch vfio-device-properties-v3 on the repository:
Patch 1 avoids that RCU callbacks are delayed forever if there's
scarcity of them, which is bad because qemu_opts_del will be called in
a RCU callbacks.
Patches 2 avoids complications due to instance_finalize callbacks that
are not thread-safe. It's a big hammer and it is not handsome, but I
On 02/11/2015 09:46 AM, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Add migrate_incoming/migrate-incoming to start an incoming
migration.
Once a qemu has been started with
-incoming pause
the migration can be started by issuing:
This implements bdrv_co_get_status() for VHD images. This can
significantly speed up qemu-img convert operation because only with this
function implemented sparseness can be considered. (Before, converting a
1 TB empty image took several minutes for me, now it's instantaneous.)
Signed-off-by:
Creates set_interrupts_fdt_node and set_regions_fdt_node
for code reusability.
Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com
---
v2 - v3:
handle intermediate ret values in set_regions_fdt_node and
set_interrupts_fdt_node
---
hw/arm/sysbus-fdt.c | 129
If total_sectors is rounded to match the geometry, total_size needs to
be changed as well. Otherwise we end up with an image whose geometry
describes a disk larger than the image file, which doesn't end well.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/vpc.c | 10 +++---
1 file
The following series add VFIO support for AMBA devices.
It introduces multiple compatible string support to deal with arm,primecell
compatible string.
The VFIOPlatformDevice now checks for this string and performs amba specific
operations if it is present (change path of the device, add clock in
Add a function to handle ioctl VFIO_DEVICE_GET_DEV_PROPERTY
to retrieve properties from a VFIO device.
Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com
---
v1 - v2:
fix property-length initialization
---
hw/vfio/common.c | 32
Use the VFIO device property API to retrieve interrupt
information (type and flags) during device node creation.
Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com
---
v1 - v2:
check irq_prop-data size
add some comments
---
hw/arm/sysbus-fdt.c | 23 +--
1 file
vnc_display_local_addr will not be called with an invalid display id.
Add assert() to silence coverity warning about a null pointer dereference.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
ui/vnc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/vnc.c b/ui/vnc.c
index
* Juan Quintela (quint...@redhat.com) wrote:
Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Once a qemu has been started with -incoming pause the
migration can be started by issuing:
migrate -u uri
Signed-off-by: Dr.
This needs to go away sooner or later, but one complication is the
complex VFIO data structures that are modified in instance_finalize.
Take a shortcut for now.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
tests/Makefile | 2 +-
util/rcu.c | 5 +
2 files changed, 6 insertions(+),
Max Reitz mre...@redhat.com writes:
On 2015-02-11 at 05:37, Xiao Guang Chen wrote:
The tests for device type ide_cd should only be tested for the pc platform.
The default device id of hard disk on the s390 platform differs to that
of the x86 platform. A new variable device_id is defined and
Add VFIO device property constants
Signed-off-by: Baptiste Reynal b.rey...@virtualopensystems.com
---
linux-headers/linux/vfio.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h
index 58f549c..1d16c12 100644
On 02/10/2015 01:28 PM, Max Reitz wrote:
update_refcount() and qcow2_update_cluster_refcount() currently take a
signed addend. At least one caller passes a value directly derived from
an absolute refcount that should be reached (l2_refcount - 1 in
expand_zero_clusters_in_l1()). Therefore, the
From: Dr. David Alan Gilbert dgilb...@redhat.com
This patchset provides a way of setting options on an incoming
migration before the fd/process/socket has been created.
start qemu with -incoming pause
use the monitor to set whatever you need
migrate_incoming theuri
v2:
Create
From: Dr. David Alan Gilbert dgilb...@redhat.com
Document the various URI formats for -incoming, the previous
manpage and help text was wrong (out of date?)
Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com
Reviewed-by: Juan Quintela quint...@redhat.com
---
qemu-options.hx | 29
On 2015-02-09 at 20:35, John Snow wrote:
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to
be created just prior to a sensitive operation (e.g. Incremental Backup)
that can either succeed or fail, but during the course of which we still
want a bitmap tracking writes.
On
From: Dr. David Alan Gilbert dgilb...@redhat.com
Add migrate_incoming/migrate-incoming to start an incoming
migration.
Once a qemu has been started with
-incoming pause
the migration can be started by issuing:
migrate_incoming uri
Signed-off-by: Dr. David Alan Gilbert
On 02/10/2015 01:28 PM, Max Reitz wrote:
Refcounts may have a width of up to 64 bits, so qemu should use the same
width to represent refcount values internally.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2-cluster.c | 2 +-
block/qcow2-refcount.c | 40
On 02/11/2015 09:48 AM, Dr. David Alan Gilbert wrote:
Agree, a new command for QMP would be better (it serves as both the new
command to use, and the witness that the '-incoming pause:' command line
works). The HMP 'migrate -u' is just fine, though (it's fine to have a
single HMP command
On 11/02/2015 09:42, Frederic Konrad wrote:
On 11/02/2015 04:33, Alex Bennée wrote:
Frederic Konrad fred.kon...@greensocs.com writes:
Hi everybody,
In multithread tlb_flush is broken as CPUA can flush an other CPUB and
CPUB can be
executing code, and fixing this can be quite hard:
* We
On 11/02/2015 18:14, Paolo Bonzini wrote:
Always process them within half a second.
Actually, half a second is too much so I changed it to .05 seconds to
err on the safe side and still give time to the sending process to
register two-three callbacks in rapid succession.
Paolo
Even though
On 02/10/2015 01:28 PM, Max Reitz wrote:
Add a helper function for reallocating a refcount array, independent of
the refcount order. The newly allocated space is zeroed and the function
handles failed reallocations gracefully.
The helper function will always align the buffer size to a
\ It seems like Coverity Scan doesn't like the new model. Possibly the
fault of the third patch.
Works for me with a local 7.0.3 installation. Which I just realized is
outdated. I'll recheck with 7.6.0.
Will check (for now I'm still running scans
with the old
On 2015-02-09 at 20:35, John Snow wrote:
Adds the disabled and frozen status booleans.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: John Snow js...@redhat.com
---
block.c | 2 ++
qapi/block-core.json | 7 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff
On 02/11/2015 12:47 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
For dirty-bitmap sync mode, the block job will iterate through the
given dirty bitmap to decide if a sector needs backup (backup all the
dirty clusters and skip clean ones), just as allocation conditions of
top
Hi all,
I'm investigating the ways to improve the live migration performance in
libvirt. I have a question about the vm live storage migration. the
platform is libvirt + qemu + kvm
If we want to migrate a running vm with its virtual disk images to another
node.
we can use 'virsh migrate '
On 2015-02-11 at 12:54, John Snow wrote:
On 02/11/2015 12:47 PM, Max Reitz wrote:
Looks good to me in general, now I need to find out what the successor
bitmap is used for; but I guess I'll find that out by reviewing the rest
of this series.
Max
They don't really come up again, actually.
On 05/02/2015 17:24, Markus Armbruster wrote:
+
+char *g_strdup(const char *s)
+{
+char *dup;
+size_t i;
+
+if (!s) {
+return NULL;
+}
+
+__coverity_string_null_sink__(s);
+__coverity_string_size_sink__(s);
What's __coverity_string_size_sink__? It is
Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Add migrate_incoming/migrate-incoming to start an incoming
migration.
Once a qemu has been started with
-incoming pause
the migration can be started by issuing:
Eric Blake ebl...@redhat.com wrote:
On 02/11/2015 09:46 AM, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Add migrate_incoming/migrate-incoming to start an incoming
migration.
Once a qemu has been started with
-incoming pause
the migration
On 02/11/2015 01:28 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
Add bdrv_clear_dirty_bitmap and a matching QMP command,
qmp_block_dirty_bitmap_clear that enables a user to reset
the bitmap attached to a drive.
This allows us to reset a bitmap in the event of a full
drive
On 2015-02-09 at 20:35, John Snow wrote:
Signed-off-by: John Snow js...@redhat.com
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 3c0989c..e065694 100644
--- a/block.c
+++ b/block.c
@@ -60,11 +60,11 @@
* or enabled. A
On 02/11/2015 10:08 AM, Edward Young wrote:
Hi all,
[probably didn't need to cross-post to quite that wide of an audience,
oh well]
I'm investigating the ways to improve the live migration performance in
libvirt. I have a question about the vm live storage migration. the
platform is
On Wed, 11 Feb 2015 13:41:29 +0100
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Feb 09, 2015 at 09:47:20AM +0100, Cornelia Huck wrote:
Well, we do need the changes in way more than two places, as every host
or guest has to collect the definitions on its own, no?
This has nothing to
On 2015-02-11 at 13:57, John Snow wrote:
On 02/10/2015 05:03 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
This returns the granularity (in bytes) of dirty bitmap,
which matches the QMP interface and the existing query
interface.
Small adjustments are made to ensure that
On 02/10/2015 05:03 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
This returns the granularity (in bytes) of dirty bitmap,
which matches the QMP interface and the existing query
interface.
Small adjustments are made to ensure that granularity-- in bytes--
I guess these
On 2015-02-09 at 20:35, John Snow wrote:
For dirty-bitmap sync mode, the block job will iterate through the
given dirty bitmap to decide if a sector needs backup (backup all the
dirty clusters and skip clean ones), just as allocation conditions of
top sync mode.
Signed-off-by: Fam Zheng
* Juan Quintela (quint...@redhat.com) wrote:
Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Add migrate_incoming/migrate-incoming to start an incoming
migration.
Once a qemu has been started with
-incoming pause
the
On 02/11/2015 01:18 PM, Max Reitz wrote:
On 2015-02-11 at 12:54, John Snow wrote:
On 02/11/2015 12:47 PM, Max Reitz wrote:
Looks good to me in general, now I need to find out what the successor
bitmap is used for; but I guess I'll find that out by reviewing the rest
of this series.
Max
On 02/11/2015 02:10 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
Adds the disabled and frozen status booleans.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: John Snow js...@redhat.com
---
block.c | 2 ++
qapi/block-core.json | 7 ++-
2 files
On 2015-02-11 at 13:31, John Snow wrote:
On 02/11/2015 01:18 PM, Max Reitz wrote:
On 2015-02-11 at 12:54, John Snow wrote:
On 02/11/2015 12:47 PM, Max Reitz wrote:
Looks good to me in general, now I need to find out what the successor
bitmap is used for; but I guess I'll find that out by
On 02/10/2015 01:28 PM, Max Reitz wrote:
Since refcounts do not always have to be a uint16_t, all refcount blocks
and arrays in memory should not have a specific type (thus they become
pointers to void) and for accessing them, two helper functions are used
(a getter and a setter). Those
On 2015-02-09 at 20:35, John Snow wrote:
We often don't need the BlockDriverState for functions
that operate on bitmaps. Remove it.
Signed-off-by: John Snow js...@redhat.com
---
block.c | 13 ++---
block/backup.c| 2 +-
block/mirror.c| 23
On 2015-02-09 at 20:35, John Snow wrote:
Add bdrv_clear_dirty_bitmap and a matching QMP command,
qmp_block_dirty_bitmap_clear that enables a user to reset
the bitmap attached to a drive.
This allows us to reset a bitmap in the event of a full
drive backup.
Signed-off-by: John Snow
On 2015-02-09 at 20:35, John Snow wrote:
This adds four qmp commands to transactions.
Users can stop a dirty bitmap, start backup of it, and start another
dirty bitmap atomically, so that the dirty bitmap is tracked
incrementally and we don't miss any write.
For starting a new incremental
Paolo Bonzini pbonz...@redhat.com writes:
On 05/02/2015 18:11, Peter Maydell wrote:
On 5 February 2015 at 16:24, Markus Armbruster arm...@redhat.com wrote:
The following changes since commit ec6f25e788ef57ce1e9f734984ef8885172fd9e2:
Merge remote-tracking branch
Am 11.02.2015 um 15:39 hat Max Reitz geschrieben:
On 2015-02-11 at 06:08, Kevin Wolf wrote:
qemu-img converts already checks the block status of the next sectors to
copy and skips them if it knows that they don't need to be copied (e.g.
because they are zero and the destination is
Even when specifying -n to suppress image creation with qemu-img
convert, that function tried to verify that the target protocol and
driver are suited for image creation. This verification should be
suppressed, too (which is what the first patch in this series does, the
second one adds a test for
On 02/10/2015 03:18 PM, Bastian Koppelmann wrote:
Hi,
the patchset fixes two minor bugs and takes care of all the packed/fixed point
mac instructions. So far I only implemented all the multiply-add instructions,
since the multiply-sub instructions are similar and I don't want the reviewers
to
On Wed, Feb 11, 2015 at 01:29:53PM +, Peter Maydell wrote:
On 11 February 2015 at 12:33, Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Feb 11, 2015 at 02:12:35AM +, Peter Maydell wrote:
On 9 February 2015 at 19:56, Michael S. Tsirkin m...@redhat.com wrote:
+rm -rf
On 2015-02-11 at 06:08, Kevin Wolf wrote:
qemu-img converts already checks the block status of the next sectors to
copy and skips them if it knows that they don't need to be copied (e.g.
because they are zero and the destination is zero-initialised).
It doesn't, however, limit the number of
If -n is specified, it does not matter whether the output format and
protocol support image creation; building the creation options should
simply be skipped.
Signed-off-by: Max Reitz mre...@redhat.com
---
qemu-img.c | 50 ++
1 file changed, 26
Signed-off-by: Max Reitz mre...@redhat.com
---
tests/qemu-iotests/123 | 62 ++
tests/qemu-iotests/123.out | 9 +++
tests/qemu-iotests/group | 1 +
3 files changed, 72 insertions(+)
create mode 100755 tests/qemu-iotests/123
create mode
Add helpers helper_addsur_h/_ssov which adds one halfword and subtracts one
halfword, rounds / and saturates each half word independently.
Add microcode helper functions:
* gen_maddsu_h/sus_h: multiply two halfwords left justified and add to the
first one word and
On 2015-02-11 at 05:37, Xiao Guang Chen wrote:
The tests for device type ide_cd should only be tested for the pc platform.
The default device id of hard disk on the s390 platform differs to that
of the x86 platform. A new variable device_id is defined and virtio0
set for the s390 platform. A x86
On 02/10/2015 09:34 AM, Markus Armbruster wrote:
Tree-wide cleanup, but the tree-wide changes are mechanical. If
nobody objects, I'll route it through my own tree.
Depends on my [PATCH] vhost-scsi: Improve error reporting for invalid
vhostfd.
PATCH 01 is responsible for the bulk of the
On 02/10/2015 01:28 PM, Max Reitz wrote:
Add two new fields regarding refcount information (the bit width of
every entry and the maximum refcount value) to the BDRVQcowState.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2-refcount.c | 4 ++--
block/qcow2.c | 3 +++
Ping? Anything I can do to get review/motion on these patches?
Cheers,
Jeremy
On 01/20/2015 09:38 AM, Jeremy White wrote:
This differs from v1 by:
* checkpatch review
* Patch series, instead of one patch
* Remove internal queue in favor of relying on thread safety of pcsclite
*
Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de
---
target-tricore/translate.c | 149 +++
target-tricore/tricore-opcodes.h | 2 +-
2 files changed, 136 insertions(+), 15 deletions(-)
diff --git a/target-tricore/translate.c
On 02/11/2015 07:58 AM, Max Reitz wrote:
Even when specifying -n to suppress image creation with qemu-img
convert, that function tried to verify that the target protocol and
driver are suited for image creation. This verification should be
suppressed, too (which is what the first patch in this
If the signed result of the multiplication overflows, we would get a negative
value, which would result in a addition instead of a subtraction.
Now we do the overflow calculation and saturation by hand instead of using
suov32_neg.
Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de
On 02/10/2015 01:28 PM, Max Reitz wrote:
Refcounts can theoretically be of type uint64_t; in order to be able to
represent the full range, qcow2_get_refcount() cannot use a single
variable to represent both all refcount values and also keep some values
reserved for errors.
One solution
On 2015-02-09 at 20:35, John Snow wrote:
Signed-off-by: John Snow js...@redhat.com
---
tests/qemu-iotests/112 | 45 +
tests/qemu-iotests/112.out | 4 ++--
2 files changed, 47 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz
On Wed, Feb 11, 2015 at 07:10:22PM +0100, Cornelia Huck wrote:
On Wed, 11 Feb 2015 13:41:29 +0100
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Feb 09, 2015 at 09:47:20AM +0100, Cornelia Huck wrote:
Well, we do need the changes in way more than two places, as every host
or guest
On 02/11/2015 12:47 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
For dirty-bitmap sync mode, the block job will iterate through the
given dirty bitmap to decide if a sector needs backup (backup all the
dirty clusters and skip clean ones), just as allocation conditions of
top
On 2015-02-09 at 20:35, John Snow wrote:
Signed-off-by: John Snow js...@redhat.com
---
tests/qemu-iotests/112 | 89 ++
tests/qemu-iotests/112.out | 5 +++
tests/qemu-iotests/group | 1 +
3 files changed, 95 insertions(+)
create mode
On 02/11/2015 02:07 PM, Edward Young wrote:
What if this vm has a number of disk-only external snapshots? In the
current version, how can live migrate this vm?
Are the snapshots based on shared storage, or local-only storage?
Yes, I'm talking about the local-only storage.
Okay, glad I
Hi Eric,
Please see the blew:
On Wed, Feb 11, 2015 at 3:12 PM, Eric Blake ebl...@redhat.com wrote:
On 02/11/2015 02:07 PM, Edward Young wrote:
What if this vm has a number of disk-only external snapshots? In the
current version, how can live migrate this vm?
Are the snapshots based on
Quoting Paolo Bonzini (2015-02-11 11:14:31)
This needs to go away sooner or later, but one complication is the
complex VFIO data structures that are modified in instance_finalize.
Take a shortcut for now.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
tests/Makefile | 2 +-
Quoting Paolo Bonzini (2015-02-11 11:14:32)
This fixes a use-after-free if do_address_space_destroy is executed
too late.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Looks like this did the trick for me. Haven't been able to reproduce for
a couple hours. Thanks!
Reviewed-by: Michael
On 11/02/2015 21:26, Michael Roth wrote:
Quoting Paolo Bonzini (2015-02-11 11:14:31)
This needs to go away sooner or later, but one complication is the
complex VFIO data structures that are modified in instance_finalize.
Take a shortcut for now.
Signed-off-by: Paolo Bonzini
Hi Eric,
Thanks for your reply! I have the follow up questions blew.
On Wed, Feb 11, 2015 at 11:52 AM, Eric Blake ebl...@redhat.com wrote:
On 02/11/2015 10:08 AM, Edward Young wrote:
Hi all,
[probably didn't need to cross-post to quite that wide of an audience,
oh well]
I'm
On 2015-02-09 at 20:35, John Snow wrote:
Signed-off-by: John Snow js...@redhat.com
---
tests/qemu-iotests/112| 120 +-
tests/qemu-iotests/112.out| 4 +-
tests/qemu-iotests/iotests.py | 18 ---
3 files changed, 133 insertions(+), 9
On 2015-02-11 at 11:22, Kevin Wolf wrote:
If total_sectors is rounded to match the geometry, total_size needs to
be changed as well. Otherwise we end up with an image whose geometry
describes a disk larger than the image file, which doesn't end well.
Signed-off-by: Kevin Wolf kw...@redhat.com
On 02/11/2015 04:40 PM, Max Reitz wrote:
On 2015-02-09 at 20:35, John Snow wrote:
Signed-off-by: John Snow js...@redhat.com
---
tests/qemu-iotests/112| 120
+-
tests/qemu-iotests/112.out| 4 +-
tests/qemu-iotests/iotests.py | 18
On 2015-02-09 at 20:35, John Snow wrote:
Background:
The blkdebug scripts are currently engineered so that when a debug
event occurs, a prefilter browses a master list of parsed rules for a
certain event and adds them to an active list of rules to be used for
the forthcoming action, provided
1 - 100 of 283 matches
Mail list logo
