Re: [Qemu-devel] [PATCH v2 01/10] error: New convenience function error_report_err()

2015-02-13 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 02/12/2015 06:33 AM, Markus Armbruster wrote: I've typed error_report(%s, error_get_pretty(ERR)) too many times already, and I've fixed too many instances of qerror_report_err(ERR) to error_report(%s, error_get_pretty(ERR)) as well. Capture the

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-13 Thread Vladimir Sementsov-Ogievskiy
+ +blk_mig_reset_dirty_cursor(); +dirty_phase(f, false); + +QSIMPLEQ_FOREACH(dbms, dirty_bitmap_mig_state.dbms_list, entry) { +uint8_t flags = DIRTY_BITMAP_MIG_FLAG_DEVICE_NAME | +DIRTY_BITMAP_MIG_FLAG_BITMAP_NAME | +

Re: [Qemu-devel] Help on TLB Flush

2015-02-13 Thread Paolo Bonzini
On 12/02/2015 22:57, Peter Maydell wrote: The only requirement is that if the CPU that did the TLB maintenance op executes a DMB (barrier) then the TLB op must finish before the barrier completes execution. So you could split the kick off TLB invalidate and make sure all CPUs are done

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-13 Thread Paolo Bonzini
On 13/02/2015 02:21, Fam Zheng wrote: Could you just do set_aio_context for all devices when starting dataplane? For example with a new scsi_device_set_aio_context function (and a new method in SCSIDeviceClass). Maybe I'm missing the obvious. :) Per VQ IOThread stills needs it, in the

Re: [Qemu-devel] [PATCH v2] qtest: Fix deadloop by running main loop AIO context's timers

2015-02-13 Thread Stefan Hajnoczi
On Mon, Jan 19, 2015 at 05:51:43PM +0800, Fam Zheng wrote: qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't forget aio timer list groups. Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all the timergroups of this clock type, including aio tlg, but

Re: [Qemu-devel] Help on TLB Flush

2015-02-13 Thread Paolo Bonzini
On 13/02/2015 10:37, Mark Burton wrote: the memory barrier is on the cpu requesting the flush isn’t it (not on the CPU that is being flushed)? Oops, I misread Peter's explanation. In that case, perhaps DMB can be treated in a similar way as WFI, using cpu-halted. Queueing work on other CPUs

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-13 Thread Dr. David Alan Gilbert
* Alexander Graf (ag...@suse.de) wrote: On 13.02.15 01:29, Lucas Meneghel Rodrigues wrote: Copying Alex. OK, after bisecting, this is what I've got: 8118f0950fc77cce7873002a5021172dd6e040b5 is the first bad commit commit 8118f0950fc77cce7873002a5021172dd6e040b5 Author:

[Qemu-devel] [PATCH v5] sheepdog: selectable object size support

2015-02-13 Thread Teruaki Ishizaki
Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle VDI object size. When you start qemu, you don't need to specify additional command option. But when you create the VDI which doesn't have default object size with qemu-img command, you

Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview

2015-02-13 Thread Paolo Bonzini
On 13/02/2015 04:29, Matthew Rosato wrote: FYI, then this probably also affects the places you hit in d8d9581460 memory: convert memory_region_destroy to object_unparent, as that's what I modeled this approach on -- but I haven't tested any of them. Luckily not, because only real regions

Re: [Qemu-devel] Help on TLB Flush

2015-02-13 Thread Mark Burton
the memory barrier is on the cpu requesting the flush isn’t it (not on the CPU that is being flushed)? Cheers Mark. On 13 Feb 2015, at 10:34, Paolo Bonzini pbonz...@redhat.com wrote: On 12/02/2015 22:57, Peter Maydell wrote: The only requirement is that if the CPU that did the TLB

[Qemu-devel] [PULL 05/14] piix4: use PCI address space instead of system memory

2015-02-13 Thread Leon Alrae
From: Hervé Poussineau hpous...@reactos.org piix4 is only used on MIPS Malta board, which gives get_system_memory() to pci_register_bus(). Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Leon Alrae leon.al...@imgtec.com --- hw/isa/piix4.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 04/14] mips: remove isa_mem_base usage

2015-02-13 Thread Leon Alrae
From: Hervé Poussineau hpous...@reactos.org Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Leon Alrae leon.al...@imgtec.com --- hw/mips/mips_r4k.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c

[Qemu-devel] [PULL 03/14] jazz: remove usage of isa_mem_base

2015-02-13 Thread Leon Alrae
From: Hervé Poussineau hpous...@reactos.org Do assorted changes in memory-mapped rtc interface. Also fix size of ISA I/O memory region, which should be 0x1 bytes. Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Leon Alrae leon.al...@imgtec.com --- hw/mips/mips_jazz.c |

[Qemu-devel] [PULL 11/14] target-mips: use CP0EnLo_XI instead of magic number

2015-02-13 Thread Leon Alrae
Signed-off-by: Leon Alrae leon.al...@imgtec.com Reviewed-by: Maciej W. Rozycki ma...@linux-mips.org --- target-mips/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 205a433..6ab3763 100644 ---

[Qemu-devel] [PULL 09/14] target-mips: fix detection of the end of the page during translation

2015-02-13 Thread Leon Alrae
The test is supposed to terminate TB if the end of the page is reached. However, with current implementation it may never succeed for microMIPS or mips16. Reported-by: Richard Henderson r...@twiddle.net Signed-off-by: Leon Alrae leon.al...@imgtec.com Reviewed-by: Maciej W. Rozycki

[Qemu-devel] [PULL 07/14] isa: remove isa_mem_base variable

2015-02-13 Thread Leon Alrae
From: Hervé Poussineau hpous...@reactos.org Now that isa_mem_base variable is always 0, we can remove its usage. Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Leon Alrae leon.al...@imgtec.com --- hw/display/cirrus_vga.c | 2 +- hw/display/vga-isa.c| 2 +-

[Qemu-devel] [PULL 08/14] target-mips: Make CP0.Status.CU1 read-only for the 5Kc and 5KEc processors

2015-02-13 Thread Leon Alrae
From: Maciej W. Rozycki ma...@codesourcery.com Signed-off-by: Maciej W. Rozycki ma...@codesourcery.com Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/translate_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate_init.c

[Qemu-devel] [PATCH v4 01/10] cpu/apic: drop icc bus/bridge/

2015-02-13 Thread Zhu Guihua
From: Chen Fan chen.fan.f...@cn.fujitsu.com ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being hotplug was available only for BUS attached devices. Now this patch is to drop ICC bus impl, and switch to bus-less CPU+APIC hotplug, handling them in the

[Qemu-devel] [PATCH v4 00/10] cpu: add device_add foo-x86_64-cpu support

2015-02-13 Thread Zhu Guihua
This series is based on the previous patchset from Chen Fan: https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html We try to make cpu hotplug with device_add, and make -device foo-x86_64-cpu available, also we can set apic-id property with command line, if without setting apic-id

[Qemu-devel] [PATCH v4 06/10] qom/cpu: move apic vmstate register into x86_cpu_apic_realize

2015-02-13 Thread Zhu Guihua
From: Gu Zheng guz.f...@cn.fujitsu.com move apic vmstate register into x86_cpu_apic_realize, and use cc-get_arch_id as the instance id to avoid using the auto-id which will break the migration if we add device not in order. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Zhu

[Qemu-devel] [PATCH v4 04/10] cpu: introduce get_compat_arch_id() method and override it for X86CPU

2015-02-13 Thread Zhu Guihua
get_compat_arch_id() is introduced to handle cross version migration issue, it is to convert new 'apic-id' to old 'cpu_index'. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- include/qom/cpu.h | 3 +++ qom/cpu.c | 6 ++ target-i386/cpu.c | 10 ++

[Qemu-devel] [PATCH v3 6/7] cpu hotplug: implement function cpu_status_write() for vcpu ejection

2015-02-13 Thread Zhu Guihua
From: Chen Fan chen.fan.f...@cn.fujitsu.com When OS ejected a vcpu (like: echo 1 /sys/bus/acpi/devices/LNXCPUXX/eject), it would call acpi EJ0 method, the firmware need to write the new cpumap, QEMU would know which vcpu need to be ejected. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com

[Qemu-devel] [PATCH v3 7/7] cpus: reclaim allocated vCPU objects

2015-02-13 Thread Zhu Guihua
From: Gu Zheng guz.f...@cn.fujitsu.com After ACPI get a signal to eject a vCPU, the vCPU must be removed from CPU list,before the vCPU really removed, then release the all related vCPU objects. In order to deal well with the kvm vcpus (which can not be removed without any protection), we do not

[Qemu-devel] [PULL 06/14] gt64xxx: remove isa_mem_base usage

2015-02-13 Thread Leon Alrae
From: Hervé Poussineau hpous...@reactos.org Create a custom address space for PCI memory region and use it for the PCI bus. Dynamically handle PCI0 Mem0 and PCI0 Mem1 regions, as already done for PCI0 IO. Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Leon Alrae

[Qemu-devel] [PULL 00/14] target-mips queue

2015-02-13 Thread Leon Alrae
/tags/vfio-update-20150210.0' into staging (2015-02-11 05:14:41 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20150213 for you to fetch changes up to a6081232704fa32d16ad1dca3f34abff4bb6435e: linux-user: correct stat structure in MIPS N32 (2015-02-12

[Qemu-devel] [PULL 02/14] jazz: do not explode QEMUMachineInitArgs structure

2015-02-13 Thread Leon Alrae
From: Hervé Poussineau hpous...@reactos.org Also remove address_space and address_space_io parameters, which where always get_system_memory() and get_system_io(). Signed-off-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Leon Alrae leon.al...@imgtec.com --- hw/mips/mips_jazz.c | 21

[Qemu-devel] [PULL 12/14] target-mips: fix broken snapshotting

2015-02-13 Thread Leon Alrae
Recently added CP0.BadInstr and CP0.BadInstrP registers ended up in cpu_load() under different offset than in cpu_save(). These and all registers between were incorrectly restored. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/machine.c | 6 -- 1 file changed, 4

[Qemu-devel] [PULL 13/14] target-mips: pass 0 instead of -1 as rs in microMIPS LUI instruction

2015-02-13 Thread Leon Alrae
Using rs = -1 in gen_logic_imm() for microMIPS LUI instruction is dangerous and may bite us when implementing microMIPS R6 because in R6 AUI and LUI are distinguished by rs value. Therefore use 0 for safety. Reported-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Leon Alrae

[Qemu-devel] [PULL 10/14] target-mips: ll and lld cause AdEL exception for unaligned address

2015-02-13 Thread Leon Alrae
Signed-off-by: Leon Alrae leon.al...@imgtec.com Reviewed-by: Maciej W. Rozycki ma...@linux-mips.org --- target-mips/op_helper.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index ea7d95f..73a8e45 100644 ---

[Qemu-devel] [PULL 01/14] isa: add memory space parameter to isa_bus_new

2015-02-13 Thread Leon Alrae
From: Hervé Poussineau hpous...@reactos.org Currently, keep current behaviour by always using get_system_memory(). Also use QOM casts when possible. Signed-off-by: Hervé Poussineau hpous...@reactos.org Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Leon Alrae

[Qemu-devel] [PATCH v4 02/10] icc_bus: remove icc related files

2015-02-13 Thread Zhu Guihua
From: Chen Fan chen.fan.f...@cn.fujitsu.com ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- MAINTAINERS| 6 --

[Qemu-devel] [PATCH v4 07/10] monitor: use cc-get_arch_id as the cpu index

2015-02-13 Thread Zhu Guihua
From: Gu Zheng guz.f...@cn.fujitsu.com Use cc-get_arch_id as the cpu index to avoid the cpu index duplicated issue in the QMP/HMP command output. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- cpus.c| 4 +++- monitor.c | 4 +++- 2

[Qemu-devel] [PATCH v4 03/10] cpu: introduce CpuTopoInfo structure for argument simplification

2015-02-13 Thread Zhu Guihua
From: Chen Fan chen.fan.f...@cn.fujitsu.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- target-i386/topology.h | 33

[Qemu-devel] [PATCH v4 08/10] acpi: introduce acpi_send_gpe_event()

2015-02-13 Thread Zhu Guihua
acpi_send_gpe_event() is introduced to do a generic for acpi to send gpe event, and it can be reused by CPU and PCI hotplug. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- hw/acpi/core.c | 7 +++ include/hw/acpi/acpi.h | 3 +++ 2 files changed, 10 insertions(+) diff --git

[Qemu-devel] [PATCH v4 09/10] cpu: add device_add foo-x86_64-cpu support

2015-02-13 Thread Zhu Guihua
From: Chen Fan chen.fan.f...@cn.fujitsu.com Add support to device_add foo-x86_64-cpu, and additional checks of apic id are added into x86_cpuid_set_apic_id() to avoid duplicate. Besides, in order to support device/device_add foo-x86_64-cpu which without specified apic id, we assign cpuid_apic_id

[Qemu-devel] [PATCH v4 10/10] i386/cpu: add instance finalize callback

2015-02-13 Thread Zhu Guihua
From: Gu Zheng guz.f...@cn.fujitsu.com Add a func to finalize a cpu's instance. When cpu's device_add failed, and cpu's device_del executed, this func would be invoked. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- include/qom/cpu.h | 1

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-13 Thread Paolo Bonzini
On 13/02/2015 11:29, Fam Zheng wrote: I think we should avoid duplicate everything on both virtio-blk and virtio-scsi, so they will have differences. True, but there are also similarities. virtio-blk can also do per-VQ iothreads Why do you think Per VQ iothread is far away? Because per-VQ

[Qemu-devel] [PATCH v3 3/7] acpi, pc: add cpu hot unplug request callback support

2015-02-13 Thread Zhu Guihua
Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- hw/acpi/ich9.c | 9 +++-- hw/acpi/piix4.c | 2 ++ hw/i386/pc.c| 42 -- 3 files changed, 49 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v3 1/7] x86: add x86_cpu_unrealizefn() for cpu apic remove

2015-02-13 Thread Zhu Guihua
From: Chen Fan chen.fan.f...@cn.fujitsu.com Implement x86_cpu_unrealizefn() for corresponding x86_cpu_realizefn(), which is mostly used to clean the apic related allocation and vmstates at here. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com

Re: [Qemu-devel] [virtio] virtqueue request size

2015-02-13 Thread Vasile Catalin-B50542
I found out what was the problem. I was calling virtqueue_get_avail_bytes() after virtqueue_pop(). On 12.02.2015 15:52, Vasile Catalin-B50542 wrote: I'm trying to work out virtqueue from the virtio API. I've been able to send a message from guest to qemu, but there is something strange that I

Re: [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling

2015-02-13 Thread Stefan Hajnoczi
On Fri, Jan 30, 2015 at 10:49:41AM +0800, Fam Zheng wrote: v7: Remove any {iops,bps}_max in 093 completely. (Max) v6: Less resource demanding patch 5. (Max) Add rev-by of Max to other patches. v5: Rebase and improve the test. Please review again. Patch dependencies: This

[Qemu-devel] [PULL 14/14] linux-user: correct stat structure in MIPS N32

2015-02-13 Thread Leon Alrae
Simple hello world MIPS N32 userland program crashes with segfault due to incorrectly defined stat structure in QEMU. Correct target_stat definition to match kernel's stat64 as in MIPS N32 there are only plain stat syscalls using 64-bit structure. Reported-by: Daniel Sanders

[Qemu-devel] [PATCH v4 05/10] qom/cpu: move register_vmstate to common CPUClass.realizefn

2015-02-13 Thread Zhu Guihua
From: Gu Zheng guz.f...@cn.fujitsu.com Move cpu vmstate register from cpu_exec_init into cpu_common_realizefn, and use cc-get_arch_id as the instance id that suggested by Igor to fix the migration issue. Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Zhu Guihua

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-13 Thread Fam Zheng
On Fri, 02/13 10:38, Paolo Bonzini wrote: On 13/02/2015 02:21, Fam Zheng wrote: Could you just do set_aio_context for all devices when starting dataplane? For example with a new scsi_device_set_aio_context function (and a new method in SCSIDeviceClass). Maybe I'm missing the

[Qemu-devel] [PATCH v3 0/7] cpu: add i386 cpu hot remove support

2015-02-13 Thread Zhu Guihua
This series is based on chen fan's previous i386 cpu hot remove patchset: https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg04266.html Via implementing ACPI standard methods _EJ0 in ACPI table, after Guest OS remove one vCPU online, the fireware will store removed bitmap to QEMU, then

[Qemu-devel] [PATCH v3 2/7] acpi/cpu: add cpu hot unplug request callback function

2015-02-13 Thread Zhu Guihua
From: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- hw/acpi/cpu_hotplug.c | 37 -

[Qemu-devel] [PATCH v3 4/7] acpi/cpu: add cpu hot unplug callback function

2015-02-13 Thread Zhu Guihua
Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com --- cpus.c| 7 +++ hw/acpi/cpu_hotplug.c | 8 include/hw/acpi/cpu_hotplug.h | 3 +++ include/qom/cpu.h | 9 + 4 files changed, 27

[Qemu-devel] [PATCH v3 5/7] acpi, pc: add cpu hot unplug callback support

2015-02-13 Thread Zhu Guihua
From: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- hw/acpi/ich9.c | 8 ++-- hw/acpi/piix4.c | 10 -- hw/i386/pc.c| 26 -- 3 files changed, 38 insertions(+), 6

Re: [Qemu-devel] [virtio] virtqueue request size

2015-02-13 Thread Vasile Catalin-B50542
I found what was the problem. virtqueue_get_avail_bytes() must be called before virtqueue_pop(). On 12.02.2015 15:52, Vasile Catalin-B50542 wrote: I'm trying to work out virtqueue from the virtio API. I've been able to send a message from guest to qemu, but there is something strange that I

Re: [Qemu-devel] [PULL 00/12] target-arm queue

2015-02-13 Thread Peter Maydell
in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20150213 for you to fetch changes up to c2ebd862a54b7e12175d65c03ba259926cb2237a: target-arm: A64: Avoid signed shifts in disas_ldst_pair() (2015-02-13 05:46:09 +

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-13 Thread Lucas Meneghel Rodrigues
Alex, Dave: Virt-Test fd migration starts by sending a fd to the source vm 22:20:40 DEBUG| Send file descriptor migfd_28_1423786840 to source VM. 22:20:40 DEBUG| (monitor hmp1) Sending command 'getfd migfd_28_1423786840' later on... 22:20:42 INFO | Migrating to fd:migfd_28_1423786840

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-02-13 Thread Zhu Guihua
On Thu, 2015-02-12 at 19:49 +0800, Zhu Guihua wrote: On Tue, 2015-02-10 at 20:38 +0800, Zhi Yong Wu wrote: On Fri, Feb 6, 2015 at 3:54 PM, Zhu Guihua zhugh.f...@cn.fujitsu.com wrote: On Tue, 2015-02-03 at 16:41 +0800, Zhi Yong Wu wrote: HI, Can you push the patchset to a branch

Re: [Qemu-devel] [PATCH RFC v2 8/8] migration: add migration/dirty-bitmap.c

2015-02-13 Thread Vladimir Sementsov-Ogievskiy
On 11.02.2015 00:33, John Snow wrote: Peter Maydell: What's the right way to license a file as copied from a previous version? See below, please; Max, Markus: ctrl+f bdrv_get_device_name and let me know what you think, if you would. Juan, Amit, David: Copying migration maintainers. On

Re: [Qemu-devel] [PATCH v6 0/5] Geometry and blocksize detection for backing devices.

2015-02-13 Thread Christian Borntraeger
Am 13.02.2015 um 08:50 schrieb Kevin Wolf: Am 12.02.2015 um 17:42 hat Christian Borntraeger geschrieben: Am 12.02.2015 um 16:46 schrieb Stefan Hajnoczi: On Mon, Jan 19, 2015 at 03:34:56PM +0100, Ekaterina Tumanova wrote: Updates v5 - v6: Minor Updates according the last review from Stefan

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-13 Thread Alexander Graf
On 13.02.15 10:04, Dr. David Alan Gilbert wrote: * Alexander Graf (ag...@suse.de) wrote: On 13.02.15 01:29, Lucas Meneghel Rodrigues wrote: Copying Alex. OK, after bisecting, this is what I've got: 8118f0950fc77cce7873002a5021172dd6e040b5 is the first bad commit commit

Re: [Qemu-devel] [PATCH v4 02/16] block: Add blk_new_open()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:11PM -0500, Max Reitz wrote: blk_new_with_bs() creates a BlockBackend with an empty BlockDriverState attached to it. Empty BDSs are not nice, therefore add an alternative function which combines blk_new_with_bs() with bdrv_open(). Note: In contrast to

Re: [Qemu-devel] [PATCH 0/2] qemu-img: Fix qemu-img convert -n

2015-02-13 Thread Stefan Hajnoczi
On Wed, Feb 11, 2015 at 09:58:45AM -0500, Max Reitz wrote: Even when specifying -n to suppress image creation with qemu-img convert, that function tried to verify that the target protocol and driver are suited for image creation. This verification should be suppressed, too (which is what the

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-13 Thread Lucas Meneghel Rodrigues
On Fri, Feb 13, 2015 at 9:18 AM, Alexander Graf ag...@suse.de wrote: On 13.02.15 10:04, Dr. David Alan Gilbert wrote: * Alexander Graf (ag...@suse.de) wrote: On 13.02.15 01:29, Lucas Meneghel Rodrigues wrote: Copying Alex. OK, after bisecting, this is what I've got:

Re: [Qemu-devel] HEAD is failing virt-test on migration tests

2015-02-13 Thread Dr. David Alan Gilbert
* Alexander Graf (ag...@suse.de) wrote: On 13.02.15 10:04, Dr. David Alan Gilbert wrote: * Alexander Graf (ag...@suse.de) wrote: On 13.02.15 01:29, Lucas Meneghel Rodrigues wrote: Copying Alex. OK, after bisecting, this is what I've got:

Re: [Qemu-devel] [PATCH v4 01/16] block: Lift some BDS functions to the BlockBackend

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:10PM -0500, Max Reitz wrote: Create the blk_* counterparts for the following bdrv_* functions (which make sense to call on the BlockBackend level): - bdrv_co_write_zeroes() - bdrv_write_compressed() - bdrv_truncate() - bdrv_nb_sectors() - bdrv_discard() -

Re: [Qemu-devel] [PULL 00/12] target-arm queue

2015-02-13 Thread Peter Maydell
in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20150213 for you to fetch changes up to c2ebd862a54b7e12175d65c03ba259926cb2237a: target-arm: A64: Avoid signed shifts in disas_ldst_pair() (2015-02-13 05:46:09 +

[Qemu-devel] [PATCH v1 2/3] vhost-user:update the version to 0x6

2015-02-13 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com We not need the VHOST_USER_REPLY_MASK so the base version now is 0x5. - update the version to 0x6. - change the name form flag to version. Signed-off-by: Linhaifeng haifeng@huawei.com --- hw/virtio/vhost-user.c | 24 1

[Qemu-devel] [PATCH v1 0/3] vhost-user: support safe protocol

2015-02-13 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com Mostly the same as ioctl master need the return value to decided going on or not.So we add these patches for more safe communication. Linhaifeng (3): vhost-user: add reply let the portocol more safe. vhost-user:update the version to 0x6

Re: [Qemu-devel] [PATCH v4 07/16] qemu-img: Use blk_new_open() in img_open()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:16PM -0500, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com --- qemu-img.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com pgpIRJm6HuSOY.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH v4 11/16] qemu-io: Use blk_new_open() in openfile()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:20PM -0500, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com --- qemu-io.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com pgppsGtrhEu6u.pgp Description: PGP

[Qemu-devel] [PATCH v2 0/3] vhost-user: support safe protocol

2015-02-13 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com Mostly the same as ioctl master need the return value to decided going on or not.So we add these patches for more safe communication. change log: v1-v2: modify the annotate about slave's version. Linhaifeng (3): vhost-user: update the protocol.

Re: [Qemu-devel] [PATCH v4 03/16] block: Add Error parameter to bdrv_find_protocol()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:12PM -0500, Max Reitz wrote: The argument given to bdrv_find_protocol() is just a file name, which makes it difficult for the caller to reconstruct what protocol bdrv_find_protocol() was hoping to find. This patch adds an Error parameter to that function to solve

Re: [Qemu-devel] [PATCH v4 05/16] blockdev: Use blk_new_open() in blockdev_init()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:14PM -0500, Max Reitz wrote: Due to different error propagation, this breaks tests 051 and 087; fix their output. Signed-off-by: Max Reitz mre...@redhat.com --- blockdev.c | 92 +-

Re: [Qemu-devel] [PATCH v4 15/16] block: Remove growable from BDS

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:24PM -0500, Max Reitz wrote: Now that request clamping is done in the BlockBackend, the growable field can be removed from the BlockDriverState. All BDSs are now treated as being growable (that is, they are allowed to grow; they are not necessarily actually able

Re: [Qemu-devel] [PULL 0/8] Linked list for tcg ops

2015-02-13 Thread Peter Maydell
On 13 February 2015 at 05:43, Richard Henderson r...@twiddle.net wrote: Currently tcg ops are simply placed in a buffer in order. Which is fine until we want to actually do something with the opcode stream, such as optimize them. Note the horrible things like call opcodes needing their

Re: [Qemu-devel] [PULL 00/14] target-mips queue

2015-02-13 Thread Peter Maydell
449008f86418583a1f0fb946cf91ee7b4797317d: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150210.0' into staging (2015-02-11 05:14:41 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20150213 for you to fetch changes up

Re: [Qemu-devel] [PULL 06/37] target-ppc: VXSQRT Should Not Be Set for NaNs

2015-02-13 Thread Tom Musta
I agree that the comment is incorrect and should say sNaN square root. On Thu, Feb 12, 2015 at 4:21 PM, Maciej W. Rozycki ma...@linux-mips.org wrote: On Wed, 7 Jan 2015, Alexander Graf wrote: diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c index 7f74466..81db60f 100644 ---

[Qemu-devel] [PATCH v2 2/3] vhost-user:update the version to 0x6

2015-02-13 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com We not need the VHOST_USER_REPLY_MASK so the base version now is 0x5. - update the version to 0x6. - change the name form flag to version. Signed-off-by: Linhaifeng haifeng@huawei.com --- hw/virtio/vhost-user.c | 24 1

Re: [Qemu-devel] [PULL 00/14] target-mips queue

2015-02-13 Thread Leon Alrae
The following changes since commit 449008f86418583a1f0fb946cf91ee7b4797317d: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150210.0' into staging (2015-02-11 05:14:41 +) are available in the git repository at: git://github.com/lalrae/qemu.git tags/mips-20150213 for you

Re: [Qemu-devel] [PATCH v4 04/16] iotests: Add test for driver=qcow2, format=qcow2

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:13PM -0500, Max Reitz wrote: While specifying a different driver and format is obviously invalid, specifying the same driver once through driver and once through format is invalid as well. Add a test for it. Signed-off-by: Max Reitz mre...@redhat.com ---

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-13 Thread Paolo Bonzini
On 13/02/2015 13:42, Fam Zheng wrote: OK, thanks for elaborating. I think for the sake of single IO thread support we already started, the best option now is to go as you suggested - move bdrv_set_aio_context to virtio_scsi_dataplane_start and hotplug callbacks. Yes, no doubt the bug has

Re: [Qemu-devel] [PATCH v4 08/16] qemu-img: Use blk_new_open() in img_rebase()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:17PM -0500, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com --- qemu-img.c | 49 +++-- 1 file changed, 23 insertions(+), 26 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com pgpSvEClQxqWo.pgp

Re: [Qemu-devel] [PATCH v4 14/16] block: Clamp BlockBackend requests

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:23PM -0500, Max Reitz wrote: BlockBackend is used as the interface between the block layer and guest devices. It should therefore assure that all requests are clamped to the image size. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake

[Qemu-devel] [PATCH 1/3] pcie: remove mmconfig memory leak and wrap mmconfig update with transaction

2015-02-13 Thread Paolo Bonzini
This memory leak was introduced inadvertently by omitting object_unparent. A better fix is to use the new memory_region_set_size instead of destroying and recreating the MMIO region on the fly. Also, ensure that unmapping and remapping the region is done atomically. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 1/3] block: Forbid bdrv_set_aio_context outside BQL

2015-02-13 Thread Paolo Bonzini
On 12/02/2015 06:21, Fam Zheng wrote: Even if the caller has the old #AioContext, there can be a deadlock, due to the leading bdrv_drain_all: Suppose there are three io threads (a, b, c) with each owning a BDS (bds_a, bds_b, bds_c), and a and b want to move their own BDS to c at the same

Re: [Qemu-devel] Help on TLB Flush

2015-02-13 Thread Lluís Vilanova
Mark Burton writes: On 13 Feb 2015, at 08:24, Peter Maydell peter.mayd...@linaro.org wrote: On 13 February 2015 at 07:16, Mark Burton mark.bur...@greensocs.com wrote: If the kernel is doing this - then effectively - for X86, each CPU only flush’s it’s own TLB (from the perspective of Qemu)

[Qemu-devel] [PATCH v2 1/3] vhost-user: update the protocol.

2015-02-13 Thread linhaifeng
From: Linhaifeng haifeng@huawei.com Every messages need reply. This path just update the vhost-user.txt to version 0x6. Signed-off-by: Linhaifeng haifeng@huawei.com --- docs/specs/vhost-user.txt | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v4 16/16] block: Keep bdrv_check*_request()'s return value

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:25PM -0500, Max Reitz wrote: Do not throw away the value returned by bdrv_check_request() and bdrv_check_byte_request(). Fix up some coding style issues in the proximity of the affected hunks. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v4 06/16] block/xen: Use blk_new_open() in blk_connect()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:15PM -0500, Max Reitz wrote: As part of the required changes, this fixes a bug where specifying an invalid driver would result in the block layer probing the image format; now it will result in an error, unless unset is specified as the driver name. Fixing this

Re: [Qemu-devel] [PATCH v4 09/16] qemu-img: Use BlockBackend as far as possible

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:18PM -0500, Max Reitz wrote: Although qemu-img already creates BlockBackends, it does not do accesses to the images through them. This patch converts all of the bdrv_* calls for which this is currently possible to blk_* calls. Most of the remaining calls will

Re: [Qemu-devel] [PATCH v4 10/16] qemu-nbd: Use blk_new_open() in main()

2015-02-13 Thread Stefan Hajnoczi
On Thu, Feb 05, 2015 at 01:58:19PM -0500, Max Reitz wrote: Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- qemu-nbd.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] Help on TLB Flush

2015-02-13 Thread Mark Burton
Agreed Cheers Mark. On 13 Feb 2015, at 14:30, Lluís Vilanova vilan...@ac.upc.edu wrote: Mark Burton writes: On 13 Feb 2015, at 08:24, Peter Maydell peter.mayd...@linaro.org wrote: On 13 February 2015 at 07:16, Mark Burton mark.bur...@greensocs.com wrote: If the kernel is doing this -

[Qemu-devel] [PATCH 0/3] pci: fix memory region lifecycle issues, document the rules

2015-02-13 Thread Paolo Bonzini
While these patches were originally in part 3 of the RCU patches, it turns out that the semantics they enforce are already important now (reported by Alex Williamson and Matthew Rosato), so here they are! Patch 1 fixes a MemoryRegion leak (and fixes it the right way, so that the new lifecycle

[Qemu-devel] [PATCH 2/3] pci: split shpc_cleanup and shpc_free

2015-02-13 Thread Paolo Bonzini
object_unparent should not be called until the parent device is going to be destroyed. Only remove the capability and do memory_region_del_subregion at unrealize time. Freeing the data structures is left in shpc_free, to be called from the instance_finalize callback. shpc_free follows the same

[Qemu-devel] [PATCH 3/3] docs: clarify memory region lifecycle

2015-02-13 Thread Paolo Bonzini
Now that objects actually obey the rules, document them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/memory.txt | 74 - 1 file changed, 58 insertions(+), 16 deletions(-) diff --git a/docs/memory.txt b/docs/memory.txt index

[Qemu-devel] [vhost] link new devices

2015-02-13 Thread Vasile Catalin-B50542
How does the vhost API links with vhost devices? I don't see any *-net or *_net or even *net references in vhost API files, nor do I see any registering macros inside vhost-net device code.

[Qemu-devel] [PULL 31/65] libqos/ahci: add ahci command functions

2015-02-13 Thread Stefan Hajnoczi
From: John Snow js...@redhat.com This patch adds the AHCICommand structure, and a set of functions to operate on the structure. ahci_command_create - Initialize and create a new AHCICommand in memory ahci_command_free - Destroy this object. ahci_command_set_buffer - Set where the guest memory

[Qemu-devel] [PULL 44/65] qtest: Add scripts/qtest.py

2015-02-13 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com This adds scripts/qtest.py as a python library for qtest protocol. This is a skeleton with a basic cmd method to execute a command, reading and parsing of qtest output could be added later on demand. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Max Reitz

[Qemu-devel] [PULL 42/65] qtest: Fix deadloop by running main loop AIO context's timers

2015-02-13 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't forget aio timer list groups. Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all the timergroups of this clock type, including aio tlg, but we don't fire them, so they are

[Qemu-devel] [PULL 55/65] block/xen: Use blk_new_open() in blk_connect()

2015-02-13 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com As part of the required changes, this fixes a bug where specifying an invalid driver would result in the block layer probing the image format; now it will result in an error, unless unset is specified as the driver name. Fixing this would require further work on

[Qemu-devel] [PULL 64/65] block: Remove growable from BDS

2015-02-13 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com Now that request clamping is done in the BlockBackend, the growable field can be removed from the BlockDriverState. All BDSs are now treated as being growable (that is, they are allowed to grow; they are not necessarily actually able to). Signed-off-by: Max

[Qemu-devel] [PULL 59/65] qemu-nbd: Use blk_new_open() in main()

2015-02-13 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Message-id: 1423162705-32065-11-git-send-email-mre...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-nbd.c | 25 + 1 file changed,

[Qemu-devel] [PATCH 8/9] throttle: Update throttle infrastructure copyright

2015-02-13 Thread Alberto Garcia
From: Benoît Canet benoit.ca...@nodalink.com Signed-off-by: Benoit Canet benoit.ca...@nodalink.com Signed-off-by: Alberto Garcia be...@igalia.com --- include/qemu/throttle.h | 4 ++-- tests/test-throttle.c | 4 ++-- util/throttle.c | 4 ++-- 3 files changed, 6 insertions(+), 6

[Qemu-devel] [PATCH 9/9] throttle: add name of ThrottleGroup to BlockDeviceInfo

2015-02-13 Thread Alberto Garcia
Replace also throttle_group_compare() with throttle_group_get_name() Signed-off-by: Alberto Garcia be...@igalia.com --- block.c | 2 +- block/qapi.c| 5 + block/throttle-groups.c | 14 -- hmp.c | 6

[Qemu-devel] [PULL 43/65] qemu-io: Account IO by aio_read and aio_write

2015-02-13 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com This will enable accounting of aio requests issued from qemu-io aio read/write commands. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com Message-id: 1422586186-9925-2-git-send-email-f...@redhat.com Signed-off-by: Stefan Hajnoczi

  1   2   3   >