Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?

2015-02-15 Thread Markus Armbruster
Peter Maydell writes: > On 15 February 2015 at 03:02, David Gibson > wrote: >> Godammit. Have I mentioned lately how much it pisses me off that we >> have various config symbols and it's never clear which ones make it >> into C and which are only in make. > > That does seem confusing. Is there

[Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit

2015-02-15 Thread Michael Tokarev
Do not check for rdma->host being empty twice. This removes a large "if" block, so code indentation is changed. While at it, remove an ugly goto from the loop, replacing it with a cleaner if logic. And finally, there's no need to initialize `ret' variable since is always has a value. Signed-off

[Qemu-devel] vexpress: Horribly slow MMC emulation on ARM host

2015-02-15 Thread Jan Kiszka
Hi, this basically concludes my problems of getting KVM running on the Jetson TK1 board with QEMU: all fine now, provided I switch from qemu-system-arm -machine vexpress-a15 -sd disk.img ... to qemu-system-arm -machine vexpress-a15 \ -drive file=disk.img,if=none,id=disk \ -device vi

Re: [Qemu-devel] [RFC PATCH v1 11/13] spapr: Initialize hotplug memory address space

2015-02-15 Thread David Gibson
On Thu, Feb 12, 2015 at 11:09:14AM +0530, Bharata B Rao wrote: > On Thu, Feb 12, 2015 at 04:19:36PM +1100, David Gibson wrote: > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > > index 44405b2..9ff08ff 100644 > > > --- a/hw/ppc/spapr.c > > > +++ b/hw/ppc/spapr.c > > > @@ -120,6 +120,8 @@ struc

Re: [Qemu-devel] [PATCH v18 1/2] sPAPR: Implement EEH RTAS calls

2015-02-15 Thread Gavin Shan
On Mon, Feb 16, 2015 at 12:52:48PM +1100, David Gibson wrote: >On Mon, Feb 16, 2015 at 10:16:01AM +1100, Gavin Shan wrote: >> The emulation for EEH RTAS requests from guest isn't covered >> by QEMU yet and the patch implements them. >> >> The patch defines constants used by EEH RTAS calls and adds

Re: [Qemu-devel] [PATCH v18 2/2] sPAPR: Implement sPAPRPHBClass EEH callbacks

2015-02-15 Thread David Gibson
On Mon, Feb 16, 2015 at 10:16:02AM +1100, Gavin Shan wrote: > The patch implements sPAPRPHBClass EEH callbacks so that the EEH > RTAS requests can be routed to VFIO for further handling. > > Signed-off-by: Gavin Shan Reviewed-by: David Gibson -- David Gibson| I'll have my

Re: [Qemu-devel] [PATCH v18 1/2] sPAPR: Implement EEH RTAS calls

2015-02-15 Thread David Gibson
On Mon, Feb 16, 2015 at 10:16:01AM +1100, Gavin Shan wrote: > The emulation for EEH RTAS requests from guest isn't covered > by QEMU yet and the patch implements them. > > The patch defines constants used by EEH RTAS calls and adds > callbacks sPAPRPHBClass::{eeh_set_option, eeh_get_state, eeh_res

[Qemu-devel] [PATCH] virtio-blk: Remove the stale FIXME comment

2015-02-15 Thread Fam Zheng
By default, we have ioeventfd enabled, so the IO request processing is in IO thread; in the vcpu thread, guest mode is returned to as quickly as possible, and completion is delivered via irqfd. Therefore this comment from the initial implementation is barely relevant. Signed-off-by: Fam Zheng ---

[Qemu-devel] [PATCH 1/2] qemu-char: add cyrillic characters 'numerosign' to VNC keysyms

2015-02-15 Thread arei.gonglei
From: Wang Xin This patch adds missing cyrillic characters 'numerosign' to the VNC keysym table, it's need by Russian keyboard. And I get the keysym from '', the current keysym table in Qemu was generated from it. signed-off-by: Wang xin signed-off-by: Gonglei --- ui/vnc_keysym.h | 1 + 1 fil

[Qemu-devel] [PATCH 2/2] qemu-char: add cyrillic key 'numerosign' to Russian keymap

2015-02-15 Thread arei.gonglei
From: Wang Xin 'numerosign' is the numbersign key of Russian keyboard layout, we get this key with press 'shift + 3'. It's missing in current Russian keymap file, this patch fix it. signed-off-by: Wang Xin signed-off-by: Gonglei --- pc-bios/keymaps/ru | 1 + 1 file changed, 1 insertion(+) di

[Qemu-devel] [PATCH 0/2] Fix key 'numerosign' missing in Russian keyboard

2015-02-15 Thread arei.gonglei
From: Wang Xin Add the keysym and keycode of 'numerosign' in Russian keyboard layout to VNC keysyms table and keymap. Wang Xin (2): qemu-char: add cyrillic characters 'numerosign' to VNC keysyms qemu-char: add cyrillic key 'numerosign' to Russian keymap pc-bios/keymaps/ru | 1 + ui/vnc_key

Re: [Qemu-devel] [PATCH 1/5] target-tile: Firstly add to qemu with minimized features

2015-02-15 Thread Chen Gang S
Excuse me, I want to consult the related information about SPR. For SPRs (Special Purpose Register) under tilegx, I can not get related documents (I only got the tilepro related document for SPR). After read through the source code of Linux kernel for tile, I guess: - SPRs are in "arch/tile/incl

[Qemu-devel] [PATCH v4 1/2] bootdevice: check boot order argument validation before vm running

2015-02-15 Thread arei.gonglei
From: Gonglei Either 'once' option or 'order' option can take effect for -boot at the same time, that is say initial startup processing can check only one. And pc.c's set_boot_dev() fails when its boot order argument is invalid. This patch provide a solution fix this problem: 1. If "once" is gi

[Qemu-devel] [PATCH v4 2/2] bootdevice: add check in restore_boot_order()

2015-02-15 Thread arei.gonglei
From: Gonglei qemu_boot_set() can't fail in restore_boot_order(), then simply assert it doesn't fail, by passing &error_abort if boot_set_handler set. Suggested-by: Markus Armbruster Signed-off-by: Gonglei --- bootdevice.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH v4 0/2] bootdevice: fix two problems about parameters check

2015-02-15 Thread arei.gonglei
From: Gonglei Patch 1 check boot order arguments validation before vm running. Patch 2 passing &error_abort to restore_boot_order() because qemu_boot_set() can't fail in that scenario. v4 -> v3: - drop the original patch 1. (Markus) - rework patch 1 (remove local variable 'order') and patch 2.

Re: [Qemu-devel] [PATCH] target-arm: Add missing compatible property to A53

2015-02-15 Thread Alistair Francis
On Mon, Feb 16, 2015 at 12:17 AM, Ryota Ozaki wrote: > Signed-off-by: Ryota Ozaki The title of your patch is incorrect, you specified A53 when you really mean A57 > --- > target-arm/cpu64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c > index

[Qemu-devel] [PATCH v18 0/2] EEH Support for VFIO Devices

2015-02-15 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support, which was merged during 3.17 merge window. This patchset has been rebased to Alex Graf's QEMU repository: git://github.com/agraf/qemu.git (branch: ppc-next) The impleme

[Qemu-devel] [PATCH v18 2/2] sPAPR: Implement sPAPRPHBClass EEH callbacks

2015-02-15 Thread Gavin Shan
The patch implements sPAPRPHBClass EEH callbacks so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan --- hw/ppc/spapr_pci_vfio.c | 98 + hw/vfio/common.c| 1 + 2 files changed, 99 insertions(

[Qemu-devel] [PATCH v18 1/2] sPAPR: Implement EEH RTAS calls

2015-02-15 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callbacks sPAPRPHBClass::{eeh_set_option, eeh_get_state, eeh_reset, eeh_configure}, which are going to be used as follows: * RTAS c

[Qemu-devel] [PATCH] acpi-build: dirty memory on RSDP/linker update

2015-02-15 Thread Michael S. Tsirkin
This is required to make sure they are migrated correctly. Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 1dfdf35..fd6ef78 100644 --- a/

Re: [Qemu-devel] [PATCH v4 3/3] pc: acpi-build: migrate RSDP table

2015-02-15 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 01:59:55PM +, Igor Mammedov wrote: > Makes sure that RSDP stays the same > /i.e. matches ACPI tables blob in source/ > if guest is migrated during RSDP reading or > has been already shadowed by firmware. > > Fix applies only to new machine types starting > from 2.3, so

Re: [Qemu-devel] [PATCH v4 2/3] pc: acpi-build: update linker on guest access

2015-02-15 Thread Michael S. Tsirkin
On Mon, Feb 09, 2015 at 01:59:54PM +, Igor Mammedov wrote: > Linker table is build only once, so if later during > tables rebuild sizes of other ACPI tables change > pointers will be patched incorrectly due to wrong > offsets in linker. Resulting in guest not being able > to find ACPI tables. >

[Qemu-devel] slow speed for virtio-scsi since qemu 2.2

2015-02-15 Thread Stefan Priebe
Hi, while i get a constant random 4k i/o write speed of 20.000 iops with qemu 2.1.0 or 2.1.3. I get jumping speeds with qemu 2.2 (jumping between 500 iops and 15.000 iop/s). If i use virtio instead of virtio-scsi speed is the same between 2.2 and 2.1. Is there a known regression? Greets,

[Qemu-devel] [PATCH] target-arm: Add missing compatible property to A53

2015-02-15 Thread Ryota Ozaki
Signed-off-by: Ryota Ozaki --- target-arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 823c739..270bc2f 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -96,6 +96,7 @@ static void aarch64_a57_initfn(Object *obj) { ARMCP

Re: [Qemu-devel] [sheepdog] [PATCH v5] sheepdog: selectable object size support

2015-02-15 Thread Hitoshi Mitake
At Fri, 13 Feb 2015 18:20:53 +0900, Teruaki Ishizaki wrote: > > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle VDI object size. > > When you start qemu, you don't need to specify additional command option. > > But when you create t

Re: [Qemu-devel] [PATCH] block:Fix FIXED base vpc be probed to raw format

2015-02-15 Thread Xiaodong Gong
Sent the v2 version of this patch integrated in v9 verison of VHD_DEFFERING patch. Fixed this problem with backing_format. On Sat, Feb 14, 2015 at 10:13 AM, Xiaodong Gong wrote: > > > On Wed, Feb 11, 2015 at 9:39 PM, Stefan Hajnoczi > wrote: > >> On Tue, Feb 10, 2015 at 11:04:31PM +0800, Xiaodo

[Qemu-devel] [PATCH v9] Support vhd type VHD_DIFFERENCING

2015-02-15 Thread Xiaodong Gong
Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu can't read snapshot volume of vhd, and can't support other storage features of vhd file. This patch add read parent information in function "vpc_open", read bitmap in "vpc_read", and change bitmap in "vpc_write". Signed-off-by: Xi

[Qemu-devel] [PATCH v2 05/17] virtio-balloon: use standard headers

2015-02-15 Thread Michael S. Tsirkin
Drop code duplicated from standard headers. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-balloon.h | 35 ++- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h i

[Qemu-devel] [PATCH v2 09/17] virtio-rng: use standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-rng.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/hw/virtio/virtio-rng.h b/include/hw/virtio/virtio-rng.h index 14e85a5..b352733 100644 --- a/include/hw/virtio/virtio-rng.h +++

Re: [Qemu-devel] [PATCH v1] vhost-user: fix not send all hugepage files to vhost-user

2015-02-15 Thread Linhaifeng
On 2015/2/2 7:29, Paolo Bonzini wrote: > > > On 17/12/2014 07:02, haifeng@huawei.com wrote: >> From: linhaifeng >> >> If we create VM with two or more numa nodes qemu will create two >> or more hugepage files but qemu only send one hugepage file fd >> to vhost-user when VM's memory size is

[Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-scsi.h | 120 +++- hw/scsi/virtio-scsi.c | 1 + 2 files changed, 10 insertions(+), 111 deletions(-) diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virt

Re: [Qemu-devel] [PATCH v2 00/17] virtio: pull headers from linux

2015-02-15 Thread Peter Maydell
On 15 February 2015 at 11:38, Michael S. Tsirkin wrote: > This reuses virtio headers from files exported by linux. > The current situation is quite messy: for example we > have multiple copies of the virtio net packet structure, > and the virtio ring structure. > We already use some of them for li

[Qemu-devel] [PATCH v2 17/17] s390: use standard headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicated macros in favor of values from standard headers. Warning: untested. Signed-off-by: Michael S. Tsirkin --- hw/s390x/s390-virtio-bus.h | 36 +++- hw/s390x/s390-virtio.h | 7 ++- 2 files changed, 21 insertions(+), 22 deletions(-) diff --git

[Qemu-devel] [PATCH v2 16/17] standard-headers: add s390 virtio headers

2015-02-15 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- include/standard-headers/asm-s390/kvm_virtio.h | 64 ++ include/standard-headers/asm-s390/virtio-ccw.h | 21 + 2 files changed, 85 insertions(+) create mode 100644 include/standard-headers/asm-s390/kvm_virtio.h create mode 10

[Qemu-devel] [PATCH v2 12/17] update-linux-headers: use standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop the linux-specific virtio headers, use the copy from standard-headers instead. Signed-off-by: Michael S. Tsirkin --- scripts/update-linux-headers.sh | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh i

[Qemu-devel] [PATCH v2 13/17] linux-headers: use standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- linux-headers/linux/virtio_config.h | 58 + linux-headers/linux/virtio_ring.h | 164 +--- 2 files changed, 2 insertions(+), 220 deletions(-) diff --git a/linux-headers/linux/virtio_config.

[Qemu-devel] [PATCH v2 08/17] virtio-net, tap: use standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-net.h | 151 + include/net/tap.h | 24 +-- 2 files changed, 2 insertions(+), 173 deletions(-) diff --git a/include/hw/virtio/virtio-net.h b/include/hw/v

[Qemu-devel] [PATCH v2 15/17] scripts: add arch specific standard-headers

2015-02-15 Thread Michael S. Tsirkin
Move virtio header copying logic to a function, use that to copy arch specific virtio headers. Signed-off-by: Michael S. Tsirkin --- scripts/update-linux-headers.sh | 56 - 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/scripts/update-linu

[Qemu-devel] [PATCH v2 11/17] virtio-serial: switch to standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicate code. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-serial.h | 40 +-- hw/char/virtio-serial-bus.c | 1 + 2 files changed, 2 insertions(+), 39 deletions(-) diff --git a/include/hw/virtio/virtio-serial.h b/include/hw/vir

Re: [Qemu-devel] [PATCH v2 00/17] virtio: pull headers from linux

2015-02-15 Thread Michael S. Tsirkin
On Sun, Feb 15, 2015 at 11:41:03AM +, Peter Maydell wrote: > On 15 February 2015 at 11:38, Michael S. Tsirkin wrote: > > This reuses virtio headers from files exported by linux. > > The current situation is quite messy: for example we > > have multiple copies of the virtio net packet structure

[Qemu-devel] [PATCH v2 07/17] virtio-blk: switch to standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicated code. Minor codechanges were required as geometry is a sub-structure now. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-blk.h | 77 +- hw/block/virtio-blk.c | 8 ++--- 2 files changed, 5 insertions(+), 80 deletion

[Qemu-devel] [PATCH v2 06/17] virtio-9p: use standard headers

2015-02-15 Thread Michael S. Tsirkin
Drop code duplicated from standard headers. Signed-off-by: Michael S. Tsirkin --- hw/9pfs/virtio-9p.h | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h index 0776424..2b1fbdd 100644 --- a/hw/9pfs/virtio-9p.h +++ b/hw/9

[Qemu-devel] [PATCH v2 02/17] include: import virtio headers from linux 4.0

2015-02-15 Thread Michael S. Tsirkin
Add files imported from linux-next (what will become linux 4.0) using scripts/update-linux-headers.sh Signed-off-by: Michael S. Tsirkin --- include/standard-headers/sys/if_ether.h | 1 + include/standard-headers/sys/types.h | 2 + include/standard-headers/sys/virtio_9p.h

[Qemu-devel] [PATCH v2 14/17] virtio-pci: use standard headers

2015-02-15 Thread Michael S. Tsirkin
Drop duplicate code. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 54 +- 1 file changed, 5 insertions(+), 49 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index dde1d73..0466571 100644 --- a/hw/virtio/

[Qemu-devel] [PATCH v2 03/17] virtio: use standard virtio_ring.h

2015-02-15 Thread Michael S. Tsirkin
Switch to virtio_ring.h from standard headers. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/dataplane/vring.h | 2 +- include/hw/virtio/virtio_ring.h | 167 hw/net/vhost_net.c | 2 +- 3 files changed, 2 insertions(+), 169 d

[Qemu-devel] [PATCH v2 00/17] virtio: pull headers from linux

2015-02-15 Thread Michael S. Tsirkin
This reuses virtio headers from files exported by linux. The current situation is quite messy: for example we have multiple copies of the virtio net packet structure, and the virtio ring structure. We already use some of them for linux-specific code, reusing more widely gets rid of code duplication

[Qemu-devel] [PATCH v2 04/17] virtio: use standard-headers

2015-02-15 Thread Michael S. Tsirkin
Drop a bunch of code duplicated from virtio_config.h and virtio_ring.h. This makes us rename event index accessors which conflict, as reusing the ones from virtio_ring.h isn't trivial. Signed-off-by: Michael S. Tsirkin --- hw/9pfs/virtio-9p.h| 1 + include/hw/virtio/virtio.h | 48 ++

[Qemu-devel] [PATCH v2 01/17] scripts/update-linux-headers.sh: pull virtio hdrs

2015-02-15 Thread Michael S. Tsirkin
It doesn't make sense to copy values manually: the only issue with getting headers from linux seems to be dealing with linux/types, we can easily fix that automatically while importing. Signed-off-by: Michael S. Tsirkin --- scripts/update-linux-headers.sh | 33 +

Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del?

2015-02-15 Thread Peter Maydell
On 15 February 2015 at 03:02, David Gibson wrote: > Godammit. Have I mentioned lately how much it pisses me off that we > have various config symbols and it's never clear which ones make it > into C and which are only in make. That does seem confusing. Is there a reason we can't have a config-de

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-02-15 Thread Gerhard Wiesinger
On 14.01.2015 10:15, Gerhard Wiesinger wrote: On 14.01.2015 01:59, Laine Stump wrote: Take a look at the following kernel bug. It specifically deals with a hang in gettimeofday() in a KVM guest: https://bugzilla.redhat.com/show_bug.cgi?id=1178975 There is a link to a patched kernel you can tr