On Tue, 02/24 10:35, Max Reitz wrote:
> The only remaining user of the BDS close notifiers is NBD which uses
> them to determine when a BDS tree is being ejected. This patch removes
> the BDS-level close notifiers and adds a notifier list to the
> BlockBackend structure that is invoked whenever a B
On 2015/2/17 7:50, Eric Blake wrote:
On 02/11/2015 08:17 PM, zhanghailiang wrote:
The 'colo_nicname' should be assigned with network name,
for exmple, 'eth2'. It will be parameter of 'colo_script',
s/exmple/example/
'colo_script' should be assigned with an scirpt path.
s/an scirpt/a script
On 02/25/2015 03:04 PM, zhanghailiang wrote:
> On 2015/2/17 7:47, Eric Blake wrote:
>> On 02/11/2015 08:17 PM, zhanghailiang wrote:
>>> We leave users to use whatever heartbeat solution they want, if the
>>> heartbeat
>>> is lost, or other errors they detect, they can use command
>>> 'colo_lost_he
On 2015/2/16 19:02, Gerd Hoffmann wrote:
> On Mo, 2015-02-16 at 13:27 +0300, Michael Tokarev wrote:
>> 16.02.2015 13:18, Gerd Hoffmann wrote:
>> []
>>> But the russian keymap needs numerosign only, right?
>>> Or does a russian keyboard have *both*?
>>
>> Now maybe I don't understand how keymap work
在 02/25/2015 03:04 PM, zhanghailiang 写道:
On 2015/2/17 7:47, Eric Blake wrote:
On 02/11/2015 08:17 PM, zhanghailiang wrote:
We leave users to use whatever heartbeat solution they want, if the heartbeat
is lost, or other errors they detect, they can use command
'colo_lost_heartbeat' to tell COL
On Tue, 02/24 10:35, Max Reitz wrote:
> bdrv_unref() can lead to bdrv_close(), which in turn will result in
> bdrv_drain_all(). This function will later be called blk_drain_all() and
> iterate only over the BlockBackends for which blk_is_inserted() holds
> true; therefore, bdrv_is_inserted() and th
On 2015/2/17 7:47, Eric Blake wrote:
On 02/11/2015 08:17 PM, zhanghailiang wrote:
We leave users to use whatever heartbeat solution they want, if the heartbeat
is lost, or other errors they detect, they can use command
'colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations
ac
On Tue, 02/24 10:35, Max Reitz wrote:
> Redirecting qemu's stderr to stdout makes working with the stderr output
> difficult due to the other file descriptor magic performed in
> _launch_qemu ("ambiguous redirect").
>
> There is no harm in leaving stderr on stderr, so do it.
>
> Signed-off-by: Ma
On Tue, 02/24 10:35, Max Reitz wrote:
> _filter_nbd can be useful for other NBD tests, too, therefore it should
> reside in common.filter, and it should support URLs of the "nbd://"
> format and export names.
>
> The NBD log lines ("/your/source/dir/nbd.c:function():line: error")
> should not be c
On 2015/2/17 7:27, Eric Blake wrote:
On 02/11/2015 08:16 PM, zhanghailiang wrote:
Add a migrate state: MIG_STATE_COLO, enter this migration state
after the first live migration successfully finished.
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
Signed-off-by: Lai Jiangshan
---
inclu
You also should be able to do
aa-audit /usr/sbin/libvirtd
which should put informative messages into /var/log/syslog or
/var/log/audit/audit.log as well.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bu
Quoting Michael Roth (2015-02-24 23:17:24)
> Quoting David Gibson (2015-02-24 21:11:29)
> > On Mon, Feb 16, 2015 at 08:27:51AM -0600, Michael Roth wrote:
> > > This enables hotplug for PHB bridges. Upon hotplug we generate the
> >
> > "PCI Host Bridge bridges" :-p
> >
> > > OF-nodes required by P
On Thu, 02/19 08:48, Michael S. Tsirkin wrote:
> relink binary whenever config-devices.mak changes:
> this makes sense as we are adding/removing devices,
> so binary has to be relinked to be up to date.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> Makefile.target | 4 +++-
> 1 file changed, 3 i
On Thu, 02/19 08:48, Michael S. Tsirkin wrote:
> V=1 should show what's going on, it's not nice
> to silence things unconditionally.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 68
OK, I am trying to experiment with virtio 1.0 support using the
latest kernel and MST's qemu tree:
https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/?h=virtio-1.0
The first issue is that the device config endian was wrong (see
attached patch).
I'm now setting up a BE guest on my x86 lapt
On Mon, 02/23 17:58, Max Reitz wrote:
> s->blocker is really only used in hw/scsi/virtio-scsi.c; the only places
> where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is
> allocated and when it is freed. That does not make a whole lot of sense
> (and is actually wrong because this leads
On 2015/2/17 7:20, Eric Blake wrote:
On 02/11/2015 08:16 PM, zhanghailiang wrote:
We can know if we should go into COLO mode by the info that
has been migrated from PVM.
Signed-off-by: zhanghailiang
Signed-off-by: Yang Hongyang
Signed-off-by: Lai Jiangshan
Signed-off-by: Gonglei
---
inclu
I haven't seen an error like that, and cannot reproduce it here.
Another way to test that apparmor is causing the problem would be to add
/dev/** rw,
at the bottom of the file /etc/apparmor.d/abstractions/libvirt-qemu.
When you next start the vm apparmor should allow it full access to all
devic
On Fri, 02/20 17:26, Paolo Bonzini wrote:
> This is the first step in pushing down acquire/release, and will let
> rfifolock drop the contention callback feature.
>
> Signed-off-by: Paolo Bonzini
> ---
> aio-posix.c | 9 +
> aio-win32.c | 8
> include/block/aio
On 02/16/2015 09:11 PM, Dr. David Alan Gilbert wrote:
> * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
>> > This is the 3th version of COLO, it is only COLO frame part, include: VM
>> > checkpoint,
>> > failover, proxy API, block replication API, not include block replication.
>> > The bl
Quoting David Gibson (2015-02-24 21:11:29)
> On Mon, Feb 16, 2015 at 08:27:51AM -0600, Michael Roth wrote:
> > This enables hotplug for PHB bridges. Upon hotplug we generate the
>
> "PCI Host Bridge bridges" :-p
>
> > OF-nodes required by PAPR specification and IEEE 1275-1994
> > "PCI Bus Binding
Save the write protected flag and check before reopen.
Signed-off-by: Fam Zheng
---
block/iscsi.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 12ddbfb..00041bf 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -65,6
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/arm/digic_boards.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
index 2a4b872..7114c36 100644
--- a/hw/arm/digic_boards.c
+++ b/hw/arm/digic_boa
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/virtio/vhost-backend.c | 2 +-
net/vhost-user.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c
index ff4f200..4d68a27 100644
--- a
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/timer/a9gtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/a9gtimer.c b/hw/timer/a9gtimer.c
index 435142a..b087bbd 100644
--- a/hw/timer/a9gtimer.c
+++ b/hw/timer/a9gtimer.c
@@ -289,7
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/tpm/tpm_passthrough.c | 12 ++--
tpm.c| 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c
index 2bf3c6f..13ac1d2 100644
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/xtensa/sim.c| 2 +-
hw/xtensa/xtfpga.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c
index 37ea9ae..328d209 100644
--- a/hw/xtensa/sim.c
+++ b/hw/
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
exec.c | 2 +-
hw/ide/pci.c | 2 +-
hw/microblaze/boot.c | 2 +-
migration/rdma.c | 2 +-
target-s390x/kvm.c | 2 +-
trace/control.c | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/dma/pl330.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
index 16cf77e..5be3df5 100644
--- a/hw/dma/pl330.c
+++ b/hw/dma/pl330.c
@@ -1566,7 +1566,7 @@ static vo
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
block/archipelago.c | 6 +++---
hw/block/nand.c | 2 +-
qemu-img.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/archipelago.c b/block/archipelago.c
index a8114b5..855655c 100644
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
numa.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/numa.c b/numa.c
index afd2866..6decd13 100644
--- a/numa.c
+++ b/numa.c
@@ -59,7 +59,7 @@ static void numa_node_parse(NumaNodeOptions *node,
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/scsi/vhost-scsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index dcb2bc5..54f916e 100644
--- a/hw/scsi/vhost-scsi.c
+++ b/hw/scsi/vhost-scsi.c
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
---
hw/vfio/common.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index c5d1551..9289389 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -201,7 +201
From: Gonglei
v2 -> v1:
- remove superfluous "" in patch 3. (Michael Tokarev)
- move qemu-img.c hunk from patch 5 to patch 1. (Markus)
- add 'R-by' tag for this patch series.
Yestoday, I found that some files have superflous '\n' charactor
around error_report/error_setg when reviewed patches.
On 2015/2/16 17:45, Michael Tokarev wrote:
> 11.02.2015 07:12, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Signed-off-by: Gonglei
>> ---
>> hw/dma/pl330.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
>> index 16cf77e..0
On 2015/2/16 20:03, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
Implement colo nic device interface configure()
add a script to configure nic devices:
${QEMU_SCRIPT_DIR}/colo-proxy-script.sh
Do you have some more documentation of the new colo-proxy? I
Nowadays, qemu has supported physical NIC hotplug for high network
throughput. but it's in conflict with live migration feature, to keep
network connectivity, we could to create bond device interface which
provides a mechanism for enslaving multiple network interfaces into a
single "bond" interface
Add a corresponding command to guest-network-set-interface.
Signed-off-by: Chen Fan
---
qga/commands-posix.c | 51 +++
qga/commands-win32.c | 6 ++
qga/qapi-schema.json | 11 +++
3 files changed, 68 insertions(+)
diff --git a/qga/comm
Nowadays, qemu has supported physical NIC hotplug for high network
throughput. but it's in conflict with live migration feature, to keep
network connectivity, we could to create bond device interface which
provides a mechanism for enslaving multiple network interfaces into a
single "bond" interface
Firstly, thank you very much for your details patient work!
And sorry, I guess, I can not finish patch v2 within this month. I shall
try to finish patch v2 within 2015-03-15.
The details reply is below, please check, thanks.
On 2/25/15 01:55, Richard Henderson wrote:
> On 02/23/2015 09:53 PM, Ch
On Mon, Feb 16, 2015 at 08:27:52AM -0600, Michael Roth wrote:
> From: Tyrel Datwyler
>
> This uses extension of existing EPOW interrupt/event mechanism
> to notify userspace tools like librtas/drmgr to handle
> in-guest configuration/cleanup operations in response to
> device_add/device_del.
>
>
On 02/25/2015 04:13 AM, Dr. David Alan Gilbert wrote:
> * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
>> This is the 3th version of COLO, it is only COLO frame part, include: VM
>> checkpoint,
>> failover, proxy API, block replication API, not include block replication.
>> The block part
On Mon, Feb 16, 2015 at 08:27:51AM -0600, Michael Roth wrote:
> This enables hotplug for PHB bridges. Upon hotplug we generate the
"PCI Host Bridge bridges" :-p
> OF-nodes required by PAPR specification and IEEE 1275-1994
> "PCI Bus Binding to Open Firmware" for the device.
>
> We associate the
On 02/24/2015 02:53 PM, Alex Williamson wrote:
>>
>> Naming it 'x-mmap' implies it is experimental and may be removed
>> someday. Is there any reason why you are not proposing it as a
>> permanent knob?
>
> I actually suggested the x- prefix to Samuel because I don't think this
> is a mode that
On 2015/2/17 23:26, Eric Blake wrote:
On 02/16/2015 08:14 PM, Michael Roth wrote:
From: zhanghailiang
Introduce three new guest commands:
guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.
Sorry for the late review, but I think guest-get-memory-block-size is
the w
> Subject: [Qemu-stable] Patch Round-up for stable 2.2.1, freeze on 2015-03-05
>
> Hi everyone,
>
> The following new patches are queued for QEMU stable v2.2.1:
>
> https://github.com/mdroth/qemu/commits/stable-2.2-staging
>
> The release is planned for 2015-03-10:
>
> http://wiki.qemu.org
On 2015/2/18 2:10, Michael Roth wrote:
Quoting Eric Blake (2015-02-17 09:26:12)
On 02/16/2015 08:14 PM, Michael Roth wrote:
From: zhanghailiang
Introduce three new guest commands:
guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.
Sorry for the late review, but I
On Tue, 02/24 15:50, Wen Congyang wrote:
> On 02/12/2015 04:44 PM, Fam Zheng wrote:
> > On Thu, 02/12 15:40, Wen Congyang wrote:
> >> On 02/12/2015 03:21 PM, Fam Zheng wrote:
> >>> Hi Congyang,
> >>>
> >>> On Thu, 02/12 11:07, Wen Congyang wrote:
> +== Workflow ==
> +The following is the
On Wed, 2015-02-18 at 15:43 +0100, Markus Armbruster wrote:
> Scott, can you review?
>
> Markus Armbruster writes:
>
> > We call ppce500_init_mpic_kvm() to create a "kvm-openpic". If it
> > fails, we call ppce500_init_mpic_qemu() to fall back to plain
> > "openpic".
> >
> > ppce500_init_mpic_kv
On 02/24/2015 05:31 AM, Max Reitz wrote:
> On 2015-02-11 at 22:07, Wen Congyang wrote:
>> The secondary qemu starts later than the primary qemu, so we
>> cannot connect to nbd server in bdrv_open().
>>
>> Signed-off-by: Wen Congyang
>> Signed-off-by: zhanghailiang
>> Signed-off-by: Gonglei
>> --
On 02/24/2015 12:04 AM, Peter Crosthwaite wrote:
> With quad Cortex-A53 CPUs.
>
> Signed-off-by: Peter Crosthwaite
> ---
> default-configs/aarch64-softmmu.mak | 2 +-
> hw/arm/Makefile.objs| 1 +
> hw/arm/xlnx-zynq-mp.c | 71
>
On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote:
> Liu Yuan writes:
>
> > From: Liu Yuan
> >
> > These functions mix up -1 and -errno in return values and would might cause
> > trouble error handling in the call chain.
> >
> > This patch let them return -errno and add some comm
On Tue, Feb 24, 2015 at 02:43:45PM -0600, Michael Roth wrote:
> Quoting David Gibson (2015-02-24 00:40:32)
> > On Mon, Feb 16, 2015 at 08:27:43AM -0600, Michael Roth wrote:
> > > This interface is used to fetch an OF device-tree nodes that describes a
> > > newly-attached device to guest. It is cal
On Tue, Feb 24, 2015 at 02:04:29PM -0600, Michael Roth wrote:
> Quoting David Gibson (2015-02-24 00:49:42)
> > On Mon, Feb 16, 2015 at 08:27:44AM -0600, Michael Roth wrote:
> > > From: Nathan Fontenot
[snip]
> > > +hdr = &pending_epow->hdr;
> > > +v6hdr = &pending_epow->v6hdr;
> > > +m
On 2/25/15 02:18, Chris Metcalf wrote:
> On 2/24/2015 12:25 PM, Chen Gang S wrote:
>> For me, if the raw integer is only used once, we needn't define a macro
>> for it (instead of, we can give a comment for it).
>
> The advantage of names even in this case is that you can group all the
> macro def
On 02/24/2015 12:59 AM, Markus Armbruster wrote:
Alexey Kardashevskiy writes:
This adds a helper to get closest bigger power-of-two value.
Signed-off-by: Alexey Kardashevskiy
---
Changes:
v2:
* s/up_pow_of_two/pow2ceil/
---
include/qemu-common.h | 2 ++
util/cutils.c | 9 +
It is only possible to retrieve the current state of an interrupt line. But
there are devices which just pulses the interrupt line. Introduce a latch
which is set by qtest and which can be cleared by the test case.
Signed-off-by: Michael Walle
---
tests/libqtest.c | 19 +++
tests
On 02/24/15 20:43, Gabriel L. Somlo wrote:
> Following up on a conversation I started a few weeks ago, regarding the
> ability to pass "environment variables" into a guest from the host, via
> the qemu command line, and without further requirements for guest- or
> host-initiated synchronization at
From: Max Reitz
The image options which can be amended are described by the .create_opts
field for every driver. This field must therefore be non-NULL so that
anything can be amended in the first place. Check that this holds true
before going into qemu_opts_create() (because if .create_opts is NU
From: Max Reitz
If a driver supports image creation, it needs to set the .create_opts
field. We can use that to make sure .create_opts for both drivers
involved is not NULL in bdrv_img_create(), which is important so that
the create_opts pointer in that function is not NULL after the
qemu_opts_ap
From: Max Reitz
If a driver supports image creation, it needs to set the .create_opts
field. We can use that to make sure .create_opts for both drivers
involved is not NULL for the target image in qemu-img convert, which is
important so that the create_opts pointer in img_convert() is not NULL
af
From: Peter Wu
'ret' was never initialized in the success path.
Signed-off-by: Peter Wu
Signed-off-by: Paolo Bonzini
(cherry picked from commit debfb917a4f9c0784772c86f110f2bcd22e5a14f)
Signed-off-by: Michael Roth
---
block/iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Check the QVIRTIO_F_ANY_LAYOUT flag before performing operations with 2
descriptor layout. This is to follow the specification strictly.
This patch depends on:
[PATCH v5 0/5] libqos: Virtio MMIO driver
Signed-off-by: Marc Marí
---
tests/virtio-blk-test.c | 98 +
From: Max Reitz
The nfs protocol driver is capable of creating images, but did not
specify any creation options. Fix it.
A way to test this issue is the following:
$ qemu-img create -f nfs nfs://127.0.0.1/foo.qcow2 64M
Without this patch, it segfaults. With this patch, it does not. However,
th
From: Fam Zheng
qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't
forget aio timer list groups.
Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all
the timergroups of this clock type, including aio tlg, but we don't fire
them, so they are never cleared,
From: Paolo Bonzini
SoundBlaster 16 emulation is very broken and consumes a lot of CPU, but a
small fix was suggested offlist and it is enough to fix some games. I
got Epic Pinball to work with the "SoundBlaster Clone" option.
The processing of the interrupt register is wrong due to two missing
From: Max Reitz
There may be NBD tests which do not create a sample image and simply
test whether wrong usage of the protocol is rejected as expected. In
this case, there will be no NBD server and trying to kill it during
clean-up will fail.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
R
From: Paolo Bonzini
In QEMU 2.2 the exception_index value was added to the migration stream
through a subsection. The default was set to 0, which is wrong and
should have been -1.
However, 2.2 does not have commit e511b4d (cpu-exec: reset exception_index
correctly, 2014-11-26), hence in 2.2 the
From: Paolo Bonzini
This had a possible deadlock that was visible with rcutorture.
qemu_event_setqemu_event_wait
cmpxchg reads FREE, writes BUSY
From: Max Reitz
Although virtually impossible right now, bdrv_find_format("qcow") may
fail. The vvfat block driver should heed that case.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
(cherry picked from commit 1bcb15cf776a57e8963072c191
From: Paolo Bonzini
superio_ioport_readb can read the 256th element of the array.
Coverity reports an out-of-bounds write in superio_ioport_writeb,
but it does not show the corresponding out-of-bounds read
because it cannot prove that it can happen. Fix the root
cause of the problem (zhanghailan
From: Zhang Haoyu
fix mc146818rtc wrong subsection name to avoid vmstate_subsection_load() fail
during incoming migration or loadvm.
Signed-off-by: Zhang Haoyu
Reviewed-by: Paolo Bonzini
Signed-off-by: Juan Quintela
(cherry picked from commit bb426311901776b95b021cece831b69dce4ef5ee)
Signed-o
From: Alex Williamson
Commit d8d95814609e added explicit object_unparent() calls for
dynamically allocated MemoryRegions. The VFIOMSIXInfo structure also
contains such a MemoryRegion, covering the mmap'd region of a PCI BAR
above the MSI-X table. This structure is freed as part of the class
exi
From: Max Reitz
We can always assume raw, file and qcow2 being available; so do not use
bdrv_find_format() to locate their BlockDriver objects but statically
reference the respective objects.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
(cherry picked from comm
From: Kevin Wolf
After reading the extension header, offset is incremented, but not
checked against end_offset any more. This way an integer overflow could
happen when checking whether the extension end is within the allowed
range, effectively disabling the check.
This patch adds the missing che
From: Vladimir Sementsov-Ogievskiy
Because of wrong return value of .save_live_pending() in
migration/block.c, migration finishes before the whole disk is
transferred. Such situation occurs when the migration process is fast
enough, for example when source and dest are on the same host.
If in th
From: "Daniel P. Berrange"
Building QEMU results in a libcacard.so that links against
practically the entire world
linux-vdso.so.1 => (0x7fff71e99000)
libssl3.so => /usr/lib64/libssl3.so (0x7f49f94b6000)
libsmime3.so => /usr/lib64/libsmime3.so (0x7f49f928e000
From: Paolo Bonzini
If the THR interrupt is disabled, there is no need to migrate thr_ipending
because LSR.THRE will be sampled again when the interrupt is enabled.
(This is the behavior that is not documented in the datasheet, but
relied on by Windows!)
Note that in this case IIR will never be
From: Dinar Valeev
When ever USB keyboard is used, e.g. '-usbdevice keyboard' pressing
caps lock key send 0x32 hid code, which is treated as backslash.
Instead it should be 0x39 code. This affects sending uppercase keys,
as they typed whith caps lock active.
While on x86 this can be workarounded
From: Paolo Bonzini
Commit d577646 (scsi: Introduce scsi_req_cancel_complete, 2014-09-25)
was supposed to have no semantic change, but it missed a case. When
r->aiocb has already been NULLed, but DMA was not complete and the
SCSI layer was waiting for scsi_req_continue, after the patch the
SCSI
From: Max Filippov
If TB ends with an opcode that crosses page boundary and the following
page is not executable then EPC1 for the code fetch exception wrongly
points at the beginning of the TB. Always treat instruction that crosses
page boundary as a separate TB.
Cc: qemu-sta...@nongnu.org
Sign
From: Paolo Bonzini
This was accessing an XMM register's low half without going through XMM_Q.
Cc: qemu-sta...@nongnu.org
Reviewed-by: Eduardo Habkost
Signed-off-by: Paolo Bonzini
(cherry picked from commit 07958082fdf39284935d38a5b8aec1fe7d020637)
Signed-off-by: Michael Roth
---
target-i386
From: Marcel Apfelbaum
After 'Machine as QOM' series the machine type input triggers
the creation of the machine class.
If the machine type is set in the configuration file, the machine
class is not updated accordingly and remains the default.
Fixed that by querying the machine options after the
From: Peter Maydell
The LDT/STT (load/store unprivileged) instruction decode was using
the wrong MMU index value. This meant that instead of these insns
being "always access as if user-mode regardless of current privilege"
they were "always access as if kernel-mode regardless of current
privilege
From: Max Reitz
There are some block drivers which are essential to QEMU and may not be
removed: These are raw, file and qcow2 (as the default non-raw format).
Make their BlockDriver objects public so they can be directly referenced
throughout the block layer without needing to call bdrv_find_for
From: Peter Maydell
The m68k signal frame setup code which writes the signal return
trampoline code to the stack was assuming that a 'long' was 32 bits;
on 64 bit systems this meant we would end up writing the 32 bit
(2 insn) trampoline sequence to retaddr+4,retaddr+6 instead of
the intended reta
On Tue, 2015-02-24 at 14:40 -0700, Eric Blake wrote:
> On 02/24/2015 01:38 PM, Samuel Pitoiset wrote:
> > Disabling MMAP support uses the slower read/write accesses but allows to
> > trace all MMIO accesses, which is not good for performance, but very
> > useful for reverse engineering PCI drivers.
From: Kevin Wolf
If a qcow2 image specifies a backing file format that doesn't correspond
to any format driver that qemu knows, we shouldn't fall back to probing,
but simply error out.
Not looking up the backing file driver in bdrv_open_backing_file(), but
just filling in the "driver" option if
From: Paolo Bonzini
What needs to be volatile is not the pointer, but the pointed-to
value!
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini
(cherry picked from commit 2cbcfb281afa041a41f6e4c4da0f5c9314084604)
Signed-off-by: Michael Roth
---
include/qemu/atomic.h | 4 ++--
1 file chang
From: Cornelia Huck
Several places check against the feature bit number instead of against
the feature bit. Fix them.
Cc: qemu-sta...@nongnu.org
Reported-by: Thomas Huth
Signed-off-by: Cornelia Huck
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
(cherry picked from commit
From: Kevin Wolf
The qcow2 specification requires that the header extension data be
padded to round up the extension size to the next multiple of 8 bytes.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Message-id: 1416935562-7760-3-git-send-email-kw...@redhat.com
Signed-off-by: Stefan Hajnoc
From: Max Reitz
The return value must be negative on error; there is one place in
raw_open_common() where errp is set, but ret remains 0. Fix it.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
(cherry picked from commit 01212d4ed68fc8daa2
From: Max Reitz
In qcow2_alloc_cluster_offset(), *num is limited to
INT_MAX >> BDRV_SECTOR_BITS by all callers. However, since remaining is
of type uint64_t, we might as well cast *num to that type before
performing the shift.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
Reviewed-by: Kev
From: Peter Maydell
When stopping an audio voice, call the audio backend's fini
method before calling audio_pcm_hw_free_resources_ rather than
afterwards. This allows backends which use helper threads (like
pulseaudio) to terminate those threads before the conv_buf or
mix_buf are freed and avoids
From: David Gibson
spapr_tce_table_finalize() can SEGV if the object was not previously
realized. In particular this can be triggered by running
qemu-system-ppc -device spapr-tce-table,?
The basic problem is that we have mismatched initialization versus
finalization: spapr_tce_table_fi
From: Paolo Bonzini
This is responsible for failure of migration from 2.2 to 2.1, because
thr_ipending is always one in practice.
serial.c is setting thr_ipending unconditionally. However, thr_ipending
is not used at all if THRI=0, and it will be overwritten again the next
time THRE or THRI cha
From: Max Reitz
bdrv_truncate() may fail and qcow2_write_compressed() should return the
error code in that case.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
(cherry picked from commit 6a69b9620ac1562a067990d87284a85552bfd61b)
Signed-of
From: Paolo Bonzini
OSes typically write 0xdd/0xdf to turn the A20 line off and on. This
has bits 2-3-6-7 on, so that the output port subsection is migrated.
Change the reset value and migration default to include those four
bits, thus avoiding that the subsection is migrated.
This strictly spe
From: Gary R Hook
Modify block_save_iterate() to return positive/zero/negative
(success/not done/failure) return status. The computation of
the blocks transferred (an int64_t) exceeds the size of an
int return value.
Signed-off-by: Gary R Hook
Reviewed-by: ChenLiang
Reviewed-by: Stefan Hajnocz
From: Paolo Bonzini
Old kernels that used high memory only allowed the initrd to be in the
first 896MB of memory. If you load the initrd above, they complain
that "initrd extends beyond end of memory".
In order to fix this, while not breaking machines with small amounts
of memory fixed by cdebe
1 - 100 of 256 matches
Mail list logo
