Re: [Qemu-devel] [PATCH V2 06/11] virtio-s390: switch to bus specific queue limit

2015-02-27 Thread Jason Wang
On Fri, Feb 27, 2015 at 5:49 PM, Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 27 Feb 2015 06:42:57 +0008 Jason Wang jasow...@redhat.com wrote: On Thu, Feb 26, 2015 at 9:05 PM, Cornelia Huck cornelia.h...@de.ibm.com wrote: On Thu, 26 Feb 2015 15:04:41 +0800 Jason Wang

Re: [Qemu-devel] [PATCH V2 04/11] virtio-ccw: introduce ccw specific queue limit

2015-02-27 Thread Jason Wang
On Fri, Feb 27, 2015 at 5:41 PM, Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 27 Feb 2015 03:46:25 +0008 Jason Wang jasow...@redhat.com wrote: On Thu, Feb 26, 2015 at 9:02 PM, Cornelia Huck cornelia.h...@de.ibm.com wrote: On Thu, 26 Feb 2015 15:04:39 +0800 Jason Wang

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

2015-02-27 Thread zhanghailiang
On 2015/2/28 1:42, Eric Blake wrote: On 02/27/2015 10:07 AM, Dr. David Alan Gilbert wrote: Rather than pollute the user-exposed enum with a state that we will never report, can we come up with some internal-only method for tracking cancelling separate from the enum? Well I guess we could

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features

2015-02-27 Thread Chris Metcalf
On 2/27/2015 9:10 PM, Chen Gang S wrote: By the way, does Gx8000 mean 8000 core count? It's marketing, so it doesn't have to mean anything. The TILE-Gx 8036 is the 36-core part, the 8072 is the 72-core part, 8009 is the 9-core part, etc. There is no 8000 chip, it's just a way of describing

Re: [Qemu-devel] [PATCH v4 05/11] block: Move BDS close notifiers into BB

2015-02-27 Thread Fam Zheng
On Fri, 02/27 11:43, Max Reitz wrote: static void virtio_scsi_hotplug(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp) { @@ -763,12 +794,26 @@ static void virtio_scsi_hotplug(HotplugHandler *hotplug_dev, DeviceState *dev, SCSIDevice *sd

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

2015-02-27 Thread zhanghailiang
On 2015/2/28 0:48, Eric Blake wrote: On 02/26/2015 11:19 PM, zhanghailiang wrote: The original 'status' is an open-coded 'str' type, convert it to use an enum type. This conversion is backwards compatible, better documented and more convenient for future extensibility. In addition, Fix a typo

Re: [Qemu-devel] [PATCH V2 03/11] virito: introduce bus specific queue limit

2015-02-27 Thread Jason Wang
On Fri, Feb 27, 2015 at 5:34 PM, Cornelia Huck cornelia.h...@de.ibm.com wrote: On Fri, 27 Feb 2015 03:42:00 +0008 Jason Wang jasow...@redhat.com wrote: On Thu, Feb 26, 2015 at 8:57 PM, Cornelia Huck cornelia.h...@de.ibm.com wrote: On Thu, 26 Feb 2015 15:04:38 +0800 Jason Wang

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features

2015-02-27 Thread Chen Gang S
On 2/28/15 10:09, Chris Metcalf wrote: On 2/27/2015 9:10 PM, Chen Gang S wrote: By the way, does Gx8000 mean 8000 core count? It's marketing, so it doesn't have to mean anything. The TILE-Gx 8036 is the 36-core part, the 8072 is the 72-core part, 8009 is the 9-core part, etc. There is

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features

2015-02-27 Thread Chen Gang S
Firstly, thank you very much for your patient work! On 2/28/15 01:36, Andreas Färber wrote: Hi, target-tilegx: Initial stub or ...support? No need to mention QEMU (spelling!) in a QEMU commit. OK, thanks. Am 22.02.2015 um 14:33 schrieb Chen Gang S: It almost likes a template for

[Qemu-devel] Announcement: Patchew server is online now

2015-02-27 Thread Fam Zheng
Hello, everyone I'm glad to announce the fresh Patchew server deployment: http://qemu.patchew.org/ The mission of this project is to help identify obvious defects (coding style, compiling, etc.) of posted patches. Follow the green passed or red failed button in the page and you'll see the

Re: [Qemu-devel] [RFC PATCH 0/7] hw/arm/virt: Add cpu-add way cpu hotplug support

2015-02-27 Thread Wei Huang
On 02/26/2015 01:32 AM, Shannon Zhao wrote: On 2015/2/19 1:19, Wei Huang wrote: Nice work. I will help review the patches. Thanks for your help :-) Other than the CPU hotplug support, we are also seeking the guest VM powerdown support via ACPI. This feature is important for management

[Qemu-devel] [Bug 1426593] [NEW] qem-user arm cortex-a8 printf out-of-memory hang

2015-02-27 Thread aaron
Public bug reported: using the latest build from git (hash 041ccc922ee474693a2869d4e3b59e920c739bc0 ) and all older versions i have tested. i am using an amd64 host with an arm chroot using qemu-user arm cortex-a8 cpu emulation to run it building coreutils hangs on checking whether printf

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features

2015-02-27 Thread Chen Gang S
On 2/28/15 05:49, Chris Metcalf wrote: On 2/27/2015 12:36 PM, Andreas Färber wrote: TILE-Gx according to http://www.tilera.com/products/?ezchip=585spage=614 - please fix wherever used in textual form. Yes, really only tilegx or TILE-Gx should be used. In type names I agree that TileGX

[Qemu-devel] [RFC PATCH v10 00/24] Deterministic replay core

2015-02-27 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. This implementation of deterministic replay can be used for deterministic debugging of guest code through gdb remote interface. These patches include only core function of the replay, excluding

[Qemu-devel] [RFC PATCH v10 02/24] replay: global variables and function stubs

2015-02-27 Thread Pavel Dovgalyuk
This patch adds global variables, defines, functions declarations, and function stubs for deterministic VM replay used by external modules. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru ---

[Qemu-devel] [RFC PATCH v10 05/24] replay: introduce mutex to protect the replay log

2015-02-27 Thread Pavel Dovgalyuk
This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [RFC PATCH v10 22/24] replay: replay blockers for devices

2015-02-27 Thread Pavel Dovgalyuk
Some devices are not supported by record/replay subsystem. This patch introduces replay blocker which denies starting record/replay if such devices are included into the configuration. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/bt/hci.c |7 +++

[Qemu-devel] [RFC PATCH v10 16/24] aio: replace stack of bottom halves with queue

2015-02-27 Thread Pavel Dovgalyuk
Bottom halves in AIO context are stored and removes in LIFO order. It makes their execution non-deterministic. This patch replaces the stack with queue to preserve the order of bottom halves processing. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- async.c | 26

Re: [Qemu-devel] [RfC PATCH 08/15] virtio-gpu-pci: virtio-1.0 adaptions [fixup]

2015-02-27 Thread Max Reitz
On 2015-02-27 at 06:18, Gerd Hoffmann wrote: Hi, This seems to be in line with the changes made in patch 1; however, I fail to see where VirtIODevice.device_id is set so that virtio_bus_get_vdev_id() returns it when called from virtio_pci_device_plugged()... Maybe I'll find it yet.

[Qemu-devel] [RFC PATCH v10 19/24] replay: thread pool

2015-02-27 Thread Pavel Dovgalyuk
This patch modifies thread pool to allow replaying asynchronous thread tasks synchronously in replay mode. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- block/raw-posix.c |6 - block/raw-win32.c |4 +++- include/block/thread-pool.h |4 +++-

[Qemu-devel] [RFC PATCH v10 04/24] replay: internal functions for replay log

2015-02-27 Thread Pavel Dovgalyuk
This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- replay/Makefile.objs |1 replay/replay-internal.c | 149

[Qemu-devel] [RFC PATCH v10 12/24] replay: recording and replaying clock ticks

2015-02-27 Thread Pavel Dovgalyuk
Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock). When replaying the execution corresponding values are read from log and transfered to the module, which wants to read

Re: [Qemu-devel] [PATCH] spapr_vio: Convert to realize()

2015-02-27 Thread Alexander Graf
On 27.02.15 11:52, Markus Armbruster wrote: Bonus fix: always set an error on failure. Some failures were silent before, except for the generic error set by device_realize(). Signed-off-by: Markus Armbruster arm...@redhat.com Thanks, applied to ppc-next. Alex

[Qemu-devel] [PATCH v4 03/11] iotests: Add test for eject under NBD server

2015-02-27 Thread Max Reitz
This patch adds a test for ejecting the BlockBackend an NBD server is connected to (the NBD server is supposed to stop). Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/096 | 90 ++ tests/qemu-iotests/096.out | 16 +

[Qemu-devel] [PATCH v4 10/11] block: Eject BDS tree from BB at bdrv_close_all()

2015-02-27 Thread Max Reitz
When bdrv_close_all() is called, instead of force-closing all root BlockDriverStates, it is better to just drop the reference from all BlockBackends and let them be closed automatically. This prevents BDS from getting closed that are still referenced by other BDS, which may result in loss of

[Qemu-devel] [PATCH v4 04/11] quorum: Fix close path

2015-02-27 Thread Max Reitz
bdrv_unref() can lead to bdrv_close(), which in turn will result in bdrv_drain_all(). This function will later be called blk_drain_all() and iterate only over the BlockBackends for which blk_is_inserted() holds true; therefore, bdrv_is_inserted() and thus quorum_is_inserted() will probably be

[Qemu-devel] [PULL v2 11/11] rocker: timestamp on the debug logs helps correlate with events in the VM

2015-02-27 Thread Stefan Hajnoczi
From: David Ahern dsah...@gmail.com Signed-off-by: David Ahern dsah...@gmail.com Signed-off-by: Scott Feldman sfel...@gmail.com Signed-off-by: Jiri Pirko j...@resnulli.us Message-id: 1424123271-7656-11-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

2015-02-27 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: On 02/26/2015 11:19 PM, zhanghailiang wrote: The original 'status' is an open-coded 'str' type, convert it to use an enum type. This conversion is backwards compatible, better documented and more convenient for future extensibility. In

Re: [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features

2015-02-27 Thread Andreas Färber
Hi, target-tilegx: Initial stub or ...support? No need to mention QEMU (spelling!) in a QEMU commit. Am 22.02.2015 um 14:33 schrieb Chen Gang S: It almost likes a template for adding an architecture target. That's a comment that's not really descriptive of what the patch does. Instead, maybe

Re: [Qemu-devel] [PATCH 4/6 v4] linux-user: Support tilegx architecture in syscall

2015-02-27 Thread Andreas Färber
Am 22.02.2015 um 14:36 schrieb Chen Gang S: Add tilegx architecture in syscall_defs.h, all related features (ioctrl, and stat) are based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- linux-user/syscall_defs.h | 38

Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore

2015-02-27 Thread Eric Blake
On 02/27/2015 08:21 AM, Cole Robinson wrote: Rather than track it in the toplevel gitignore Signed-off-by: Cole Robinson crobi...@redhat.com --- .gitignore| 1 - tests/qemu-iotests/.gitignore | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) I think that the fact

Re: [Qemu-devel] [PATCH v2 6/9] qtest/ahci: add migrate dma test

2015-02-27 Thread John Snow
On 02/27/2015 09:30 AM, Paolo Bonzini wrote: On 27/02/2015 00:50, John Snow wrote: +/* Write, migrate, then read. */ +ahci_io(src, px, CMD_WRITE_DMA, tx, bufsize, 0); +ahci_migrate(src, dst, uri); +ahci_io(dst, px, CMD_READ_DMA, rx, bufsize, 0); IIUC, tests for

[Qemu-devel] [PATCH v4 07/11] blockdev: Use blk_remove_bs() in do_drive_del()

2015-02-27 Thread Max Reitz
Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- blockdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index f198be6..e5f5ebc 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2229,11 +2229,7 @@ int

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

2015-02-27 Thread Eric Blake
On 02/26/2015 11:19 PM, zhanghailiang wrote: The original 'status' is an open-coded 'str' type, convert it to use an enum type. This conversion is backwards compatible, better documented and more convenient for future extensibility. In addition, Fix a typo for qapi-schema.json: comppleted -

[Qemu-devel] [PATCH v4 01/11] iotests: Move _filter_nbd into common.filter

2015-02-27 Thread Max Reitz
_filter_nbd can be useful for other NBD tests, too, therefore it should reside in common.filter, and it should support URLs of the nbd:// format and export names. The NBD log lines (/your/source/dir/nbd.c:function():line: error) should not be converted to empty lines but removed altogether.

[Qemu-devel] [PULL v2 05/11] rocker: add register programming guide

2015-02-27 Thread Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com This is the register programming guide for the Rocker device. It's intended for driver writers and device writers. It covers the device's PCI space, the register set, DMA interface, and interrupts. Signed-off-by: Scott Feldman sfel...@gmail.com

[Qemu-devel] [PULL v2 01/11] net: synchronize net_host_device_remove with host_net_remove_completion

2015-02-27 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com Using net_host_check_device is unnecessary. qemu_del_net_client asserts for the non-peer case that it can only process NIC type NetClientStates, and that assertion is valid for the peered case as well, so move it and use the same check in

[Qemu-devel] [PATCH 4/4] hw/mips: Do not clear BEV for MIPS malta kernel load

2015-02-27 Thread Leon Alrae
From: Matthew Fortune matthew.fort...@imgtec.com The BEV flag controls whether the boot exception vector is still in place when starting a kernel. When cleared the exception vector at EBASE (or hard coded address of 0x8000) is used instead. The early stages of the linux kernel would benefit

Re: [Qemu-devel] [PATCH v2] block/vdi: Add locking for parallel requests

2015-02-27 Thread Stefan Weil
Am 27.02.2015 um 17:57 schrieb Stefan Hajnoczi: On Fri, Feb 27, 2015 at 09:05:47AM -0500, Max Reitz wrote: Concurrently modifying the bmap does not seem to be a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Cc:

Re: [Qemu-devel] [PATCH v2] block/vdi: Add locking for parallel requests

2015-02-27 Thread Max Reitz
On 2015-02-27 at 12:25, Stefan Weil wrote: Am 27.02.2015 um 17:57 schrieb Stefan Hajnoczi: On Fri, Feb 27, 2015 at 09:05:47AM -0500, Max Reitz wrote: Concurrently modifying the bmap does not seem to be a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307

Re: [Qemu-devel] [PATCH v2] block/vdi: Add locking for parallel requests

2015-02-27 Thread Paolo Bonzini
On 27/02/2015 18:25, Stefan Weil wrote: block/vdi.c was never written for multi-threaded access, see my comment in the header of block/vdi.c: It is not using threads, only coroutines. Preemption points of coroutines are well defined, and I think that the bug could be present even in the

Re: [Qemu-devel] [PULL 08/11] linux-user: Check for cpu_init() errors

2015-02-27 Thread Eduardo Habkost
On Fri, Feb 27, 2015 at 08:23:12AM +0900, Peter Maydell wrote: On 27 February 2015 at 08:11, Eduardo Habkost ehabk...@redhat.com wrote: On Fri, Feb 27, 2015 at 08:00:25AM +0900, Peter Maydell wrote: On 27 February 2015 at 07:51, Eduardo Habkost ehabk...@redhat.com wrote: I have never seen

Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type

2015-02-27 Thread Eric Blake
On 02/27/2015 10:07 AM, Dr. David Alan Gilbert wrote: Rather than pollute the user-exposed enum with a state that we will never report, can we come up with some internal-only method for tracking cancelling separate from the enum? Well I guess we could just report it; but would that break

[Qemu-devel] [Bug 1426472] [NEW] Recent regression: segfault on startup with -snapshot

2015-02-27 Thread Andreas Gustafsson
Public bug reported: As of git revision 041ccc922ee474693a2869d4e3b59e920c739bc0, qemu segfaults on startup when I try to boot a hard disk image with the -snapshot option. To reproduce: wget http://wiki.qemu.org/download/linux-0.2.img.bz2 bunzip2 linux-0.2.img.bz2 qemu-system-i386 -hda

Re: [Qemu-devel] [PATCH] iscsi: Handle write protected case in reopen

2015-02-27 Thread Peter Lieven
Am 27.02.2015 um 15:20 schrieb Paolo Bonzini: On 25/02/2015 05:40, Fam Zheng wrote: Save the write protected flag and check before reopen. Signed-off-by: Fam Zheng f...@redhat.com --- block/iscsi.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v7 5/5] BlockConf: Call backend functions to detect geometry and blocksizes

2015-02-27 Thread Max Reitz
On 2015-02-16 at 06:47, Ekaterina Tumanova wrote: geometry: hd_geometry_guess function autodetects the drive geometry. This patch adds a block backend call, that probes the backing device geometry. If the inner driver method is implemented and succeeds (currently only for DASDs), the

[Qemu-devel] [PATCH v4 02/11] iotests: Make redirecting qemu's stderr optional

2015-02-27 Thread Max Reitz
Redirecting qemu's stderr to stdout makes working with the stderr output difficult due to the other file descriptor magic performed in _launch_qemu (ambiguous redirect). Add an option which specifies whether stderr should be redirected to stdout or not (allowing for other modes to be added in the

Re: [Qemu-devel] [patch qemu] rocker: fix 32bit build

2015-02-27 Thread Stefan Hajnoczi
On Fri, Feb 27, 2015 at 03:07:17PM +0100, Jiri Pirko wrote: For printf format of uint64_t and size_t use TARGET_FMT_plx and %zu Signed-off-by: Jiri Pirko j...@resnulli.us --- hw/net/rocker/rocker.c | 32 +--- hw/net/rocker/rocker_desc.c | 6 +++--- 2

Re: [Qemu-devel] [PATCH v2] block/vdi: Add locking for parallel requests

2015-02-27 Thread Max Reitz
On 2015-02-27 at 11:57, Stefan Hajnoczi wrote: On Fri, Feb 27, 2015 at 09:05:47AM -0500, Max Reitz wrote: Concurrently modifying the bmap does not seem to be a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Cc:

[Qemu-devel] [PATCH 3/4] target-mips: add -semihosting-arg option and implement UHI Arg* ops

2015-02-27 Thread Leon Alrae
Add new command line option -semihosting-arg. It is used for passing input arguments to the guest in semihosting mode. The option can be used multiple times. If n arguments are passed, then argument count (semihosting_argc) will be equal to n+1 as semihosting_argv[0] points at the program name.

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2015-02-27 Thread ullix
This bug still exists with Ubuntu 12.04.5 LTS as host and Ubuntu Mate 14.04.01 in the VM. Using Mate in the VM with cirrus as video driver does work, but the screen resolution is limited to 1290x104 - insufficient for some graphics work. For vga it is even worse. -- You received this bug

[Qemu-devel] [PULL v2 06/11] pci: add rocker device ID

2015-02-27 Thread Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com Signed-off-by: Scott Feldman sfel...@gmail.com Signed-off-by: Jiri Pirko j...@resnulli.us Message-id: 1424123271-7656-5-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- docs/specs/pci-ids.txt | 1 + include/hw/pci/pci.h

[Qemu-devel] [PATCH 1/4] include/softmmu-semi.h: Make semihosting support 64-bit clean

2015-02-27 Thread Leon Alrae
From: Maciej W. Rozycki ma...@codesourcery.com Correct addresses passed around in semihosting to use a data type suitable for both 32-bit and 64-bit targets. Signed-off-by: Maciej W. Rozycki ma...@codesourcery.com Signed-off-by: Leon Alrae leon.al...@imgtec.com --- Maciej, I kept the same fix

[Qemu-devel] [PULL v2 09/11] rocker: add tests

2015-02-27 Thread Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com Add some basic test for rocker to test L2/L3/L4 functionality. Requires an external test environment, simp, located here: https://github.com/scottfeldman/simp To run tests, simp environment must be installed and a suitable VM image built and installed with

Re: [Qemu-devel] [PATCH v5 07/16] spapr_rtas: add ibm, configure-connector RTAS interface

2015-02-27 Thread Michael Roth
Quoting David Gibson (2015-02-26 23:31:20) On Thu, Feb 26, 2015 at 04:21:55PM -0600, Michael Roth wrote: Quoting David Gibson (2015-02-24 18:48:23) On Tue, Feb 24, 2015 at 02:43:45PM -0600, Michael Roth wrote: Quoting David Gibson (2015-02-24 00:40:32) On Mon, Feb 16, 2015 at

[Qemu-devel] [PATCH v4 09/11] blockdev: Keep track of monitor-owned BDS

2015-02-27 Thread Max Reitz
...and release the reference on bdrv_close_all(). Signed-off-by: Max Reitz mre...@redhat.com --- block.c| 5 + blockdev.c | 18 ++ include/block/block_int.h | 4 stubs/Makefile.objs

[Qemu-devel] [PATCH v4 08/11] block: Make bdrv_close() static

2015-02-27 Thread Max Reitz
There are no users of bdrv_close() left, except for one of bdrv_open()'s failure paths, bdrv_close_all() and bdrv_delete(), and that is good. Make bdrv_close() static so nobody makes the mistake of directly using bdrv_close() again. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v2] block/vdi: Add locking for parallel requests

2015-02-27 Thread Stefan Hajnoczi
On Fri, Feb 27, 2015 at 09:05:47AM -0500, Max Reitz wrote: Concurrently modifying the bmap does not seem to be a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Cc: qemu-stable qemu-sta...@nongnu.org Signed-off-by:

[Qemu-devel] [PULL v2 03/11] net: add MAC address string printer

2015-02-27 Thread Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com We can use this in virtio-net code as well as new Rocker driver code, so up-level this. Signed-off-by: Scott Feldman sfel...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com Message-id: 1424123271-7656-2-git-send-email-sfel...@gmail.com Signed-off-by:

[Qemu-devel] [PULL v2 04/11] virtio-net: use qemu_mac_strdup_printf

2015-02-27 Thread Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com Signed-off-by: Scott Feldman sfel...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com Message-id: 1424123271-7656-3-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/net/virtio-net.c | 12 +++- 1 file

[Qemu-devel] [PATCH v2] virtio-scsi: Allocate op blocker reason before blocking

2015-02-27 Thread Max Reitz
s-blocker is really only used in hw/scsi/virtio-scsi.c; the only places where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is allocated and when it is freed. That does not make a whole lot of sense (and is actually wrong because this leads to s-blocker potentially being NULL when

[Qemu-devel] [PULL v2 10/11] MAINTAINERS: add rocker

2015-02-27 Thread Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com Signed-off-by: Scott Feldman sfel...@gmail.com Signed-off-by: Jiri Pirko j...@resnulli.us Message-id: 1424123271-7656-10-git-send-email-sfel...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- MAINTAINERS | 6 ++ 1 file changed, 6

[Qemu-devel] [PATCH 0/4] target-mips: add UHI semihosting support

2015-02-27 Thread Leon Alrae
Hi, This patch series introduces the Unified Hosting Interface [1] support to QEMU. UHI is a common bare metal semi-hosting interface for the MIPS architecture and in QEMU it comes down to reserving SDBBP 1 instruction which triggers semi-hosting syscalls. Since we are already in soft-freeze

Re: [Qemu-devel] [PATCH v2] block/vdi: Add locking for parallel requests

2015-02-27 Thread Paolo Bonzini
On 27/02/2015 15:05, Max Reitz wrote: Concurrently modifying the bmap does not seem to be a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Cc: qemu-stable qemu-sta...@nongnu.org Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v4 11/11] iotests: Add test for multiple BB on BDS tree

2015-02-27 Thread Max Reitz
This adds a test for having multiple BlockBackends in one BDS tree. In this case, there is one BB for the protocol BDS and one BB for the format BDS in a simple two-BDS tree (with the protocol BDS and BB added first). When bdrv_close_all() is executed, no cached data from any BDS should be lost;

[Qemu-devel] [PATCH v4 00/11] block: Rework bdrv_close_all()

2015-02-27 Thread Max Reitz
Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend, which can lead to data corruption (see the iotest added in the final patch of this series) and is most certainly very ugly. This series reworks bdrv_close_all() to instead eject the BDS trees from all BlockBackends and then

[Qemu-devel] [PATCH v4 05/11] block: Move BDS close notifiers into BB

2015-02-27 Thread Max Reitz
The only remaining user of the BDS close notifiers is NBD which uses them to determine when a BDS tree is being ejected. This patch removes the BDS-level close notifiers and adds a notifier list to the BlockBackend structure that is invoked whenever a BDS is removed. Symmetrically to that,

[Qemu-devel] [PATCH v4 06/11] block: Use blk_remove_bs() in blk_delete()

2015-02-27 Thread Max Reitz
Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/block-backend.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 254fde4..7e9d53a 100644 --- a/block/block-backend.c +++

[Qemu-devel] [PULL v2 07/11] pci: add network device class 'other' for network switches

2015-02-27 Thread Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com Rocker is an ethernet switch device, so add 'other' network device class as defined by PCI to cover these types of devices. Signed-off-by: Scott Feldman sfel...@gmail.com Signed-off-by: Jiri Pirko j...@resnulli.us Message-id:

[Qemu-devel] [PULL v2 00/11] Net patches

2015-02-27 Thread Stefan Hajnoczi
v2: * Squash in Jiri's fix for rocker format string specifiers [Peter] * Squash in Windows build fix [Peter] * Both build fixes are described in rocker: add new rocker switch device The following changes since commit 041ccc922ee474693a2869d4e3b59e920c739bc0: Merge remote-tracking branch

[Qemu-devel] [PULL v2 02/11] tests: rtl8139: test timers and interrupt

2015-02-27 Thread Stefan Hajnoczi
From: Frediano Ziglio fredd...@gmail.com Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio fredd...@gmail.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Message-id: 1420742303-3030-1-git-send-email-fredd...@gmail.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 2/4] target-mips: add Unified Hosting Interface (UHI) support

2015-02-27 Thread Leon Alrae
Add UHI semihosting support for MIPS. QEMU run with -semihosting option will alter the behaviour of SDBBP 1 instruction -- UHI operation will be called instead of generating a debug exception. This commit implements all UHI operations apart from Argc, Argnlen and Argn. Signed-off-by: Leon Alrae

Re: [Qemu-devel] [PATCH v2] block/vdi: Add locking for parallel requests

2015-02-27 Thread Stefan Weil
Am 27.02.2015 um 18:28 schrieb Max Reitz: On 2015-02-27 at 12:25, Stefan Weil wrote: block/vdi.c was never written for multi-threaded access, see my comment in the header of block/vdi.c: * The code is not thread safe (missing locks for changes in header and * block table, no problem with

Re: [Qemu-devel] [PATCH v2] virtio-scsi: Allocate op blocker reason before blocking

2015-02-27 Thread Eric Blake
On 02/27/2015 10:11 AM, Max Reitz wrote: s-blocker is really only used in hw/scsi/virtio-scsi.c; the only places where it is used in hw/scsi/virtio-scsi-dataplane.c is when it is allocated and when it is freed. That does not make a whole lot of sense (and is actually wrong because this leads

[Qemu-devel] [RFC PATCH v10 18/24] replay: replay aio requests

2015-02-27 Thread Pavel Dovgalyuk
This patch adds identifier to aio requests. ID is used for creating bottom halves and identifying them while replaying. The patch also introduces several functions that make possible replaying of the aio requests. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- block.c

[Qemu-devel] [RFC PATCH v10 14/24] replay: shutdown event

2015-02-27 Thread Pavel Dovgalyuk
This patch records and replays simulator shutdown event. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- replay/replay-internal.h |2 ++ replay/replay.c | 12 replay/replay.h |5 + vl.c

[Qemu-devel] [RFC PATCH v10 06/24] replay: introduce icount event

2015-02-27 Thread Pavel Dovgalyuk
This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru ---

[Qemu-devel] [RFC PATCH v10 24/24] replay: recording of the user input

2015-02-27 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 31 +

[Qemu-devel] [PATCH] virtio-pci: Convert to realize()

2015-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- Depends on my [PATCH 00/10] pci: Partial conversion to realize, which is in Michael's latest pull request. hw/virtio/virtio-pci.c | 88 -- hw/virtio/virtio-pci.h | 2 +- 2 files changed, 36

Re: [Qemu-devel] [PATCH v2 6/9] qtest/ahci: add migrate dma test

2015-02-27 Thread Paolo Bonzini
On 27/02/2015 00:50, John Snow wrote: +/* Write, migrate, then read. */ +ahci_io(src, px, CMD_WRITE_DMA, tx, bufsize, 0); +ahci_migrate(src, dst, uri); +ahci_io(dst, px, CMD_READ_DMA, rx, bufsize, 0); IIUC, tests for READ_FPDMA_QUEUED and WRITE_FPDMA_QUEUED are going to be

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 0/9] ppc: loadvm/savevm fixups for -M g3beige and -M mac99

2015-02-27 Thread Mark Cave-Ayland
On 09/02/15 22:40, Mark Cave-Ayland wrote: This patchset fixes up various bugs in loadvm/savevm for -M g3beige and -M mac99 so that it is becomes possible to save and restore image snapshots. The focus of this patchset is on -M g3beige since this matches the majority of my test images, but

[Qemu-devel] [RFC PATCH v10 01/24] i386: partial revert of interrupt poll fix

2015-02-27 Thread Pavel Dovgalyuk
Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- cpu-exec.c

[Qemu-devel] [RFC PATCH v10 17/24] replay: bottom halves

2015-02-27 Thread Pavel Dovgalyuk
This patch introduces bottom half event for replay queue. It saves the events into the queue and process them at the checkpoints and instructions execution. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- async.c | 24 +++- dma-helpers.c

[Qemu-devel] [RFC PATCH v10 21/24] replay: initialization and deinitialization

2015-02-27 Thread Pavel Dovgalyuk
This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- exec.c |1 replay/replay-internal.h |2 +

[Qemu-devel] [RFC PATCH v10 08/24] cpu: replay instructions sequence

2015-02-27 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. When replayed instructions counter is expired qemu_notify_event() function is

[Qemu-devel] [PATCH 2/2] virtio-s390: Convert to realize()

2015-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/s390x/s390-virtio-bus.c | 80 ++ hw/s390x/s390-virtio-bus.h | 2 +- 2 files changed, 47 insertions(+), 35 deletions(-) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c index

[Qemu-devel] [PATCH 0/2] virtio-s390: Convert to realize()

2015-02-27 Thread Markus Armbruster
Markus Armbruster (2): virtio-s390: s390_virtio_device_init() can't fail, simplify virtio-s390: Convert to realize() hw/s390x/s390-virtio-bus.c | 97 ++ hw/s390x/s390-virtio-bus.h | 2 +- 2 files changed, 56 insertions(+), 43 deletions(-) --

Re: [Qemu-devel] [PULL 04/11] target-i386: Rename cpu_x86_init() to cpu_x86_init_user()

2015-02-27 Thread Andreas Färber
Am 26.02.2015 um 16:59 schrieb Eduardo Habkost: On Wed, Feb 25, 2015 at 11:06:55PM +0100, Andreas Färber wrote: Am 25.02.2015 um 20:58 schrieb Eduardo Habkost: The function is used only for CONFIG_USER, so make its purpose clear. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH] pci: Convert pci_nic_init() to Error to avoid qdev_init()

2015-02-27 Thread Markus Armbruster
qdev_init() is deprecated, and will be removed when its callers have been weaned off it. Signed-off-by: Markus Armbruster arm...@redhat.com --- Depends on my [PATCH 00/10] pci: Partial conversion to realize, which is in Michael's latest pull request, and on my [PATCH v2 2/2] pci: Give a few

Re: [Qemu-devel] [RFC PATCH v9 00/23] Deterministic replay core

2015-02-27 Thread Paolo Bonzini
On 27/02/2015 10:23, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 18/02/2015 12:55, Pavel Dovgalyuk wrote: This set of patches is related to the reverse execution and deterministic replay of qemu execution. This implementation of

[Qemu-devel] [RFC PATCH v10 23/24] replay: command line options

2015-02-27 Thread Pavel Dovgalyuk
This patch introduces command line options for enabling recording or replaying virtual machine behavior. These options are added to icount command line parameter. They include 'rr' which switches between record and replay and 'rrfile' for specifying the filename for replay log. Signed-off-by:

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 0/9] ppc: loadvm/savevm fixups for -M g3beige and -M mac99

2015-02-27 Thread Alexander Graf
On 27.02.15 14:09, Mark Cave-Ayland wrote: On 09/02/15 22:40, Mark Cave-Ayland wrote: This patchset fixes up various bugs in loadvm/savevm for -M g3beige and -M mac99 so that it is becomes possible to save and restore image snapshots. The focus of this patchset is on -M g3beige since this

Re: [Qemu-devel] [PATCH] hmp: info spice: Show string channel name

2015-02-27 Thread Cole Robinson
On 02/27/2015 02:35 AM, Gerd Hoffmann wrote: On Do, 2015-02-26 at 13:48 -0700, Eric Blake wrote: On 02/26/2015 12:02 PM, Cole Robinson wrote: Useful for debugging. https://bugzilla.redhat.com/show_bug.cgi?id=822418 Signed-off-by: Cole Robinson crobi...@redhat.com --- hmp.c | 13

[Qemu-devel] [RFC PATCH v10 10/24] replay: interrupts and exceptions

2015-02-27 Thread Pavel Dovgalyuk
This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [RFC PATCH v10 03/24] sysemu: system functions for replay

2015-02-27 Thread Pavel Dovgalyuk
This patch removes static specifier from several qemu function to make them visible to the replay module. It also invents several system functions that will be used by replay. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- cpus.c

[Qemu-devel] [RFC PATCH v10 11/24] replay: asynchronous events infrastructure

2015-02-27 Thread Pavel Dovgalyuk
This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at synchronization points such as beginning of TB execution,

[Qemu-devel] [PATCH 1/2] virtio-s390: s390_virtio_device_init() can't fail, simplify

2015-02-27 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/s390x/s390-virtio-bus.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c index 39dc201..f69ff11 100644 ---

Re: [Qemu-devel] [PULL 05/11] target-i386: Eliminate cpu_init() function

2015-02-27 Thread Andreas Färber
Am 26.02.2015 um 17:03 schrieb Eduardo Habkost: On Wed, Feb 25, 2015 at 11:08:56PM +0100, Andreas Färber wrote: Am 25.02.2015 um 20:58 schrieb Eduardo Habkost: Instead of putting extra logic inside cpu.h, just do everything inside cpu_x86_init_user(). Reviewed-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH] iscsi: Handle write protected case in reopen

2015-02-27 Thread Paolo Bonzini
On 25/02/2015 05:40, Fam Zheng wrote: Save the write protected flag and check before reopen. Signed-off-by: Fam Zheng f...@redhat.com --- block/iscsi.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-27 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: If do_sd_create() fails, it first reports the error returned, then reports a another one with strerror(errno). errno is meaningless at that point. Report just one error combining the valid information from both messages. Reported-by: Eric Blake

  1   2   3   >