Re: [Qemu-devel] [RFC v3 08/10] vfio-pci: add VFIO_FEATURE_ENABLE_AER_CAP feature

2015-03-01 Thread Chen Fan
On 02/27/2015 06:18 AM, Alex Williamson wrote: On Thu, 2015-02-26 at 14:46 +0800, Chen Fan wrote: On 02/11/2015 12:39 AM, Alex Williamson wrote: On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote: add a new "aercap" feature in vfio device, for controlling whether expose aer capability. Signed

[Qemu-devel] [RFC v4 9/9] pcie: fix several trivial typos

2015-03-01 Thread Chen Fan
Signed-off-by: Chen Fan --- include/hw/pci/pci.h | 2 +- include/hw/pci/pcie_aer.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index bdee464..b82de15 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -137,7

[Qemu-devel] [RFC v4 8/9] vfio-pci: pass the aer error to guest

2015-03-01 Thread Chen Fan
when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and have the guest driver recover from the error. Signed-of

[Qemu-devel] [RFC v4 5/9] vfio: add aer support for vfio device

2015-03-01 Thread Chen Fan
Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/hw/vfio/

[Qemu-devel] [RFC v4 7/9] pcie_aer: expose pcie_aer_msg() interface

2015-03-01 Thread Chen Fan
For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 2 +- include/hw/pci/pcie_aer.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pcie_aer.c b/

[Qemu-devel] [RFC v4 3/9] vfio: add pcie extanded capability support

2015-03-01 Thread Chen Fan
For vfio pcie device, we could expose the extanded capability on PCIE bus. in order to avoid config space broken, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 83 +

[Qemu-devel] [RFC v4 4/9] aer: impove pcie_aer_init to support vfio device

2015-03-01 Thread Chen Fan
extend pcie_aer_init arguments to adjust vfio device. Signed-off-by: Chen Fan --- hw/pci-bridge/ioh3420.c| 3 ++- hw/pci-bridge/xio3130_downstream.c | 3 ++- hw/pci-bridge/xio3130_upstream.c | 3 ++- hw/pci/pcie_aer.c | 7 --- include/hw/pci/pcie_aer.h

[Qemu-devel] [RFC v4 1/9] pcie_aer: fix typos in pcie_aer_inject_error comment

2015-03-01 Thread Chen Fan
Refer to "PCI Express Base Spec3.0", this comments can't fit the description in spec, so we should fix them. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c index 1f4be16..7ca077a 100644

[Qemu-devel] [RFC v4 0/9] pass aer error to guest for vfio device

2015-03-01 Thread Chen Fan
For now, for vfio pci passthough devices when qemu receives an error from host aer report, there just terminate the guest, but usually user want to know what error occurred but stop the guest, so this patches add aer capability support for vfio device, and pass the error to guest, and have guest dr

[Qemu-devel] [RFC v4 6/9] vfio: add 'x-aer' option to disable aer capability

2015-03-01 Thread Chen Fan
add 'x-aer' option to disable aer capability if user want. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index db4ba23..5471437 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -156,6 +156,8 @@ typedef struct

[Qemu-devel] [RFC v4 2/9] aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register

2015-03-01 Thread Chen Fan
>From pcie spec, the bits attributes are RW1CS in Correctable Error Status Register, so this patch fix a wrong definition for PCI_ERR_COR_STATUS register with w1cmask type. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pc

Re: [Qemu-devel] [PATCH] Make sysbus EHCI devices ARM only by default

2015-03-01 Thread Amit Shah
On (Wed) 18 Feb 2015 [16:01:01], David Gibson wrote: > A number of ARM embedded boards include EHCI USB host controllers which > appear as directly mapped devices, rather than sitting on a PCI bus. > > At present code to emulate such devices is included whenever EHCI support > is included. This p

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

2015-03-01 Thread David Gibson
On Mon, Mar 02, 2015 at 05:46:26PM +1100, Alexey Kardashevskiy wrote: > This removes floppy disks support as it is not supported by any PPC64 > system anyway as the only way to have floppy disk on such systems would > be an ISA bus and Linux kernels seems have never had such support. > > Signed-of

Re: [Qemu-devel] [PATCH 1/3] Revert "default-configs/ppc64: add all components of i82378 SuperIO chip used by prep"

2015-03-01 Thread David Gibson
On Mon, Mar 02, 2015 at 05:46:25PM +1100, Alexey Kardashevskiy wrote: > This reverts commit 9c9984242ce46ccf8636f5c19e81d794e84aa0c7 as even when > it was applied, all supposedly new config options were already enabled. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson -- Davi

Re: [Qemu-devel] [PATCH 3/3] ppc64-softmmu: Remove duplicated OPENPIC from config

2015-03-01 Thread David Gibson
On Mon, Mar 02, 2015 at 05:46:27PM +1100, Alexey Kardashevskiy wrote: > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_

Re: [Qemu-devel] [PATCH v6 07/15] spapr_rtas: add ibm, configure-connector RTAS interface

2015-03-01 Thread David Gibson
On Thu, Feb 26, 2015 at 09:11:07PM -0600, Michael Roth wrote: > This interface is used to fetch an OF device-tree nodes that describes a > newly-attached device to guest. It is called multiple times to walk the > device-tree node and fetch individual properties into a 'workarea'/buffer > provided b

Re: [Qemu-devel] [PATCH v5 07/16] spapr_rtas: add ibm, configure-connector RTAS interface

2015-03-01 Thread David Gibson
On Fri, Feb 27, 2015 at 11:37:56AM -0600, Michael Roth wrote: > Quoting David Gibson (2015-02-26 23:31:20) > > On Thu, Feb 26, 2015 at 04:21:55PM -0600, Michael Roth wrote: > > > Quoting David Gibson (2015-02-24 18:48:23) > > > > On Tue, Feb 24, 2015 at 02:43:45PM -0600, Michael Roth wrote: > > > >

[Qemu-devel] [PATCH v3] PPC: Introduce the Virtual Time Base (VTB) SPR register

2015-03-01 Thread Cyril Bur
This patch adds basic support for the VTB. PowerISA: The Virtual Time Base (VTB) is a 64-bit incrementing counter. Virtual Time Base increments at the same rate as the Time Base until its value becomes 0x___ (2 64 - 1); at the next increment its value becomes 0x___.

[Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

2015-03-01 Thread Alexey Kardashevskiy
This removes floppy disks support as it is not supported by any PPC64 system anyway as the only way to have floppy disk on such systems would be an ISA bus and Linux kernels seems have never had such support. Signed-off-by: Alexey Kardashevskiy --- At the moment on POWERPC platform ISA bus depen

[Qemu-devel] [PATCH 3/3] ppc64-softmmu: Remove duplicated OPENPIC from config

2015-03-01 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- default-configs/ppc64-softmmu.mak | 1 - 1 file changed, 1 deletion(-) diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak index 53f5c73..90bdcd1 100644 --- a/default-configs/ppc64-softmmu.mak +++ b/default-configs/ppc64-sof

[Qemu-devel] [PATCH 0/3] ppc64-softmmu: default config cleanups

2015-03-01 Thread Alexey Kardashevskiy
Originally I just wanted to remove FDC but as we are here, let's do some more cleaning. Please comment. Thanks. Alexey Kardashevskiy (3): Revert "default-configs/ppc64: add all components of i82378 SuperIO chip used by prep" ppc64-softmmu: Remove unsupported FDC from config ppc64-softm

[Qemu-devel] [PATCH 1/3] Revert "default-configs/ppc64: add all components of i82378 SuperIO chip used by prep"

2015-03-01 Thread Alexey Kardashevskiy
This reverts commit 9c9984242ce46ccf8636f5c19e81d794e84aa0c7 as even when it was applied, all supposedly new config options were already enabled. Signed-off-by: Alexey Kardashevskiy --- default-configs/ppc64-softmmu.mak | 6 -- 1 file changed, 6 deletions(-) diff --git a/default-configs/ppc

Re: [Qemu-devel] [PATCH 1/5] migration: Remove unused functions

2015-03-01 Thread Amit Shah
On (Tue) 24 Feb 2015 [17:28:36], Thomas Huth wrote: > On Tue, 24 Feb 2015 14:58:29 +0530 > Amit Shah wrote: > > > On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote: > > > dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(), > > > migrate_rdma_pin_all(), qsb_clone() and qsb_set_length()

Re: [Qemu-devel] [PATCH 0/2] Proactive pow2floor() fix, and dead code removal

2015-03-01 Thread Amit Shah
On (Wed) 25 Feb 2015 [15:06:30], Markus Armbruster wrote: > I propose to route this through the migration tree, because that's > where pow2floor() came from, and where the dead code is removed. > > Markus Armbruster (2): > cutils: Proactively fix pow2floor(), switch to unsigned > xbzrle: Drop

Re: [Qemu-devel] [PATCH] Avoid crashing on multiple -incoming

2015-03-01 Thread Amit Shah
On (Thu) 26 Feb 2015 [14:16:06], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Passing multiple -incoming options used to crash qemu (due to > an invalid state transition incoming->incoming). Instead we now > take the last -incoming option, e.g.: > > qemu-system-x86_6

Re: [Qemu-devel] [PATCH 0/3] migrate_incoming cleanups

2015-03-01 Thread Amit Shah
On (Thu) 26 Feb 2015 [14:54:38], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This is a series of minor fixes from Markus's review: > http://lists.gnu.org/archive/html/qemu-devel/2015-02/msg04079.html > > To be applied after the exisitng set of -incoming defer > patch

Re: [Qemu-devel] [PATCH 3/3] migrate_incoming: Cleanup/clarify error messages

2015-03-01 Thread Amit Shah
On (Thu) 26 Feb 2015 [14:54:41], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Create a separate error for the case where migrate_incoming is > used after a succesful migrate_incoming. > > Reword the error in the case where '-incoming defer' is missing > to omit the co

Re: [Qemu-devel] [BUG] Balloon malfunctions with memory hotplug

2015-03-01 Thread Amit Shah
On (Fri) 27 Feb 2015 [12:09:20], zhanghailiang wrote: > On 2015/2/27 3:26, Luiz Capitulino wrote: > >Hello, > > > >Reproducer: > > > >1. Start QEMU with balloon and memory hotplug support: > > > ># qemu [...] -m 1G,slots=2,maxmem=2G -balloon virtio > > > >2. Check balloon size: > > > >(qemu) info b

Re: [Qemu-devel] migration: Fix 32 bit compiler errors

2015-03-01 Thread Amit Shah
On (Sat) 28 Feb 2015 [19:09:40], Stefan Weil wrote: > Obviously that code was never before compiled on 32 bit hosts. > The RDMA API uses lots of uint64_t values and the code casts them > to and from pointers. > > I tried to fix the compilation but did not run any runtime tests. > > I think the fi

[Qemu-devel] [PATCH] nbd: Fix overflow return value

2015-03-01 Thread Fangyi (C)
PING The value of reply.error should be the type unsigned int. Signed-off-by: Yik Fang --- nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd.c b/nbd.c index e56afbc1..30e2f3b 100644 --- a/nbd.c +++ b/nbd.c @@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)

Re: [Qemu-devel] [PATCH 2/4] target-mips: add Unified Hosting Interface (UHI) support

2015-03-01 Thread Matthew Fortune
Hi Leon, Many thanks for implementing this interface in QEMU. I haven't reviewed in great detail as I am not familiar enough with QEMU internals to do so. Overall it seems to match the UHI spec. The one potential issue is translation of errno values, I suspect some do not map 1:1. A couple of min

Re: [Qemu-devel] [PATCH 3/4] target-mips: add "-semihosting-arg" option and implement UHI Arg* ops

2015-03-01 Thread Matthew Fortune
> Add new command line option "-semihosting-arg". It is used for passing > input arguments to the guest in semihosting mode. The option can be used > multiple times. If n arguments are passed, then argument count > (semihosting_argc) will be equal to n+1 as semihosting_argv[0] points at > the progr

Re: [Qemu-devel] [PATCHv2 0/3] Add config options for some not-always-sensible devices

2015-03-01 Thread David Gibson
On Sun, Mar 01, 2015 at 05:37:35PM +0100, Michael S. Tsirkin wrote: > On Fri, Feb 27, 2015 at 05:04:34PM +1100, David Gibson wrote: > > This series adds explicit config options to control inclusion of a > > number of devices. These are generally things that could > > theoretically appear on anythi

Re: [Qemu-devel] [v5 08/12] migration: Add the core code of multi-thread compression

2015-03-01 Thread Li, Liang Z
> I thihnk this would make the code work, but not the locking. You are using > here: > > quit_comp_thread: global, and not completely clear what protects it > comp_done_lock: global > comp_done_cond: global > > param[i].busy: I would suggest renaming to pending work > param[i].mutex: > param[i]

Re: [Qemu-devel] [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-03-01 Thread Chen, Tiejun
Here I just mean when Qemu realizes IGD is passed through but without that appropriate option set, Qemu can post something to explicitly notify user that this option is needed in his case. But it may be a lazy idea. In any case I think the additions of such warnings in qemu are a separate to the

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-03-01 Thread Gonglei
On 2015/3/1 18:06, Paolo Bonzini wrote: > > > On 28/02/2015 17:47, Stefan Weil wrote: >>> Reviewed-by: Paolo Bonzini >> >> Which one of the two patch variants did you review? >> >> I suggest using Michael's version (only one g_free as early as >> possible). For that variant, my review may be add

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2015-03-01 Thread Serge Hallyn
@ullix could you please give the precise full qemu command line which is failing, and a url to a boot cd I can use for the guest? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/918791 Title: qemu-k

Re: [Qemu-devel] [RfC PATCH 06/15] virtio-gpu/2d: add virtio gpu core code

2015-03-01 Thread Dave Airlie
> > But one non-formal question: As far as I understood virtio-gpu's mode of > operation from this patch, it looks like there is one resource per scanout, > and that resource is basically the whole screen (which can be updated > partially). > > If that is the case, what do we gain from being able t

Re: [Qemu-devel] vmdk: improve streamOptimized vmdk support

2015-03-01 Thread Sunil Kumar
Any update on this Milos? Thanks. On Monday, February 23, 2015 5:50 AM, Milos Vyletel wrote: On Mon, Feb 23, 2015 at 11:57 AM, Kevin Wolf wrote: > Am 23.02.2015 um 09:10 hat Markus Armbruster geschrieben: >> Perhaps Fam (cc'ed) can help you. >> >> Sunil Kumar writes: >> >> [...] >> > Hi, >>

Re: [Qemu-devel] [PATCH v3 00/10] QEMU memory hot unplug support

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:42AM +0800, Zhu Guihua wrote: > Memory hot unplug are both asynchronous procedures. > When the unplug operation happens, unplug request cb is called first. > And when guest OS finished handling unplug, unplug cb will be called > to do the real removal of device. > > T

Re: [Qemu-devel] [PATCH v3 01/10] acpi, mem-hotplug: Use PC_DIMM_SLOT_PROP in acpi_memory_plug_cb().

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:43AM +0800, Zhu Guihua wrote: > From: Tang Chen > > Replace string "slot" in acpi_memory_plug_cb() with MACRO PC_DIMM_SLOT_PROP. Probably should be "macro". > Reviewed-by: Igor Mammedov > Signed-off-by: Tang Chen > Signed-off-by: Zhu Guihua Applied, thanks. >

Re: [Qemu-devel] [PATCH v3 02/10] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus.

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:44AM +0800, Zhu Guihua wrote: > From: Tang Chen > > Add a new API named acpi_memory_slot_status() to obtain a single memory > slot status. Doing this is because this procedure will be used by other > functions in the next coming patches. > > Signed-off-by: Tang Chen

Re: [Qemu-devel] [PATCH v3 03/10] acpi, mem-hotplug: Add acpi_send_gpe_event() to rise sci for memory hotplug.

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:45AM +0800, Zhu Guihua wrote: > From: Tang Chen > > Add a new API named acpi_send_gpe_event() to send memory hotplug SCI. > Doing this is because this procedure will be used by other functions in the > next coming patches. > > Signed-off-by: Tang Chen > Signed-off-

Re: [Qemu-devel] [PATCH v3 04/10] acpi, mem-hotplug: Add unplug request cb for memory device.

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:46AM +0800, Zhu Guihua wrote: > From: Tang Chen > > Memory hot unplug are both asynchronize procedures. asynchronous > When the unplug operation happens, unplug request cb is called first. > And when ghest guest > OS finished handling unplug, unplug cb will be ca

Re: [Qemu-devel] [PATCH v3 06/10] acpi, mem-hotplug: Add unplug cb for memory device.

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:48AM +0800, Zhu Guihua wrote: > From: Tang Chen > > Reset all memory status, and unparent the memory device. > > Signed-off-by: Tang Chen > Signed-off-by: Zhu Guihua Please, stop breaking patches up like this. You add new a function, with zero documentation, and

Re: [Qemu-devel] [PATCH v3 10/10] acpi: Add hardware implementation for memory hot unplug.

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:52AM +0800, Zhu Guihua wrote: > From: Tang Chen > > This patch adds a new bit to memory hotplug IO port indicating that > ej0 has been evaluated by guest OS. And call pc-dimm unplug cb to do > the real removal. > > Signed-off-by: Hu Tao > Signed-off-by: Tang Chen

Re: [Qemu-devel] [PATCH v3 09/10] ssdt-mem: add MEMORY_SLOT_EJECT_METHOD

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:51AM +0800, Zhu Guihua wrote: > Signed-off-by: Zhu Guihua so you add an extern method, but it's not implemented until the next patch. anyone bisecting between these patches will get ospm crashes. Please just squash this all together. Also, need to rebase this on my

Re: [Qemu-devel] [PATCH v3 08/10] qdev: make qdev_get_hotplug_handler() non-static

2015-03-01 Thread Michael S. Tsirkin
On Thu, Feb 26, 2015 at 09:16:50AM +0800, Zhu Guihua wrote: > Memory hotplug code will use qdev_get_hotplug_handler(). > > Signed-off-by: Zhu Guihua don't send patches like this pls. Just merge this with code that uses it. > --- > hw/core/qdev.c | 2 +- > include/hw/qdev-core.h | 1 + >

Re: [Qemu-devel] [PATCH] Makefile.objs: add dummy rule for .dsl files

2015-03-01 Thread Michael S. Tsirkin
On Fri, Feb 27, 2015 at 07:41:29PM +0100, Paolo Bonzini wrote: > > > On 26/02/2015 17:33, Michael S. Tsirkin wrote: > > .hex files are created from .dsl files, so > > cpp adds the dependency %.hex: %.dsl automatically, > > but fails to add a dummy rule so if .dsl > > file is missing, make will fa

Re: [Qemu-devel] [PATCHv2 0/3] Add config options for some not-always-sensible devices

2015-03-01 Thread Michael S. Tsirkin
On Fri, Feb 27, 2015 at 05:04:34PM +1100, David Gibson wrote: > This series adds explicit config options to control inclusion of a > number of devices. These are generally things that could > theoretically appear on anything (or at least a wide range of > targets), but are in practice only likely

Re: [Qemu-devel] [PATCH 0/2] virtio-s390: Convert to realize()

2015-03-01 Thread Michael S. Tsirkin
On Fri, Feb 27, 2015 at 02:55:35PM +0100, Markus Armbruster wrote: > Markus Armbruster (2): > virtio-s390: s390_virtio_device_init() can't fail, simplify > virtio-s390: Convert to realize() Acked-by: Michael S. Tsirkin But please merge this in the s390 tree. > hw/s390x/s390-virtio-bus.c

Re: [Qemu-devel] [PATCH V13 3/4] pc: add a Virtual Machine Generation ID device

2015-03-01 Thread Michael S. Tsirkin
On Wed, Feb 25, 2015 at 05:08:52PM +, Igor Mammedov wrote: > Based on Microsoft's sepecifications (paper can be dowloaded from > http://go.microsoft.com/fwlink/?LinkId=260709), add a device > description to the SSDT ACPI table and its implementation. > > The GUID is set using "vmgenid.uuid" pr

Re: [Qemu-devel] [PATCH v2] hmp: info spice: Show string channel name

2015-03-01 Thread Cole Robinson
On 02/27/2015 01:26 PM, Eric Blake wrote: > On 02/27/2015 08:36 AM, Cole Robinson wrote: >> Useful for debugging. >> >> https://bugzilla.redhat.com/show_bug.cgi?id=822418 >> Signed-off-by: Cole Robinson >> --- >> v2: >> Explicitly list spice channel mappings >> Use ARRAY_SIZE macro >> >>

[Qemu-devel] [PATCH v3] hmp: info spice: Show string channel name

2015-03-01 Thread Cole Robinson
Useful for debugging. https://bugzilla.redhat.com/show_bug.cgi?id=822418 Signed-off-by: Cole Robinson --- v3: Fix checkpatch warnings Change INPUTS string from 'input' to 'inputs' Extra check to ensure array element isn't empty v2: Explicitly list spice channel mappings Use A

[Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missing 'static' attribute

2015-03-01 Thread Stefan Weil
Warnings from the Sparse static analysis tool: disas/microblaze.c:289:3: warning: symbol 'opcodes' was not declared. Should it be static? disas/microblaze.c:570:6: warning: symbol 'register_prefix' was not declared. Should it be static? disas/microblaze.c:571:6: warning: symbol 'special_registe

[Qemu-devel] [PATCH] disas/cris: Fix warning caused by missing 'static' attribute

2015-03-01 Thread Stefan Weil
Warning from the Sparse static analysis tool: disas/cris.c:1218:26: warning: symbol 'cris_cond15s' was not declared. Should it be static? Signed-off-by: Stefan Weil --- disas/cris.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/cris.c b/disas/cris.c index 9dfb4e3

[Qemu-devel] [PATCH] disas/arm: Fix warnings caused by missing 'static' attribute

2015-03-01 Thread Stefan Weil
Warnings from the Sparse static analysis tool: disas/arm.c:1552:15: warning: symbol 'last_type' was not declared. Should it be static? disas/arm.c:1553:5: warning: symbol 'last_mapping_sym' was not declared. Should it be static? disas/arm.c:1554:9: warning: symbol 'last_mapping_addr' was not de

[Qemu-devel] [PATCH] oslib-posix: Fix compiler warning (-Wclobbered) and simplify the code

2015-03-01 Thread Stefan Weil
gcc reports this warning with -Wclobbered: util/oslib-posix.c: In function ‘os_mem_prealloc’: util/oslib-posix.c:374:49: error: argument ‘memory’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Fix this and simplify the code by using an existing macro. Signed-off-by: Stefan Weil

Re: [Qemu-devel] Fedora FC21 - Bug: 100% CPU and hangs in gettimeofday(&tp, NULL); forever

2015-03-01 Thread Gerhard Wiesinger
On 16.02.2015 16:29, Paolo Bonzini wrote: On 16/02/2015 16:09, Gerhard Wiesinger wrote: On 16.02.2015 15:18, Paolo Bonzini wrote: On 15/02/2015 09:18, Gerhard Wiesinger wrote: Can you grab some random backtraces ("thread apply all bt full") with gdb? Very low load on the machine, so I guess

Re: [Qemu-devel] [PATCH v2] e500: fix memory leak

2015-03-01 Thread Paolo Bonzini
On 28/02/2015 17:47, Stefan Weil wrote: >> Reviewed-by: Paolo Bonzini > > Which one of the two patch variants did you review? > > I suggest using Michael's version (only one g_free as early as > possible). For that variant, my review may be added: > > Reviewed-by: Stefan Weil I also referre