Re: [Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation

2015-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2015 at 11:28:22AM +0100, Igor Mammedov wrote: On Sun, 8 Mar 2015 13:16:03 +0200 Marcel Apfelbaum mar...@redhat.com wrote: The DefLEqual op does not have a target operand. Remove it. Signed-off-by: Marcel Apfelbaum mar...@redhat.com Reviewed-by: Igor Mammedov

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add jcody as blockjobs, block devices maintainer

2015-03-09 Thread Kevin Wolf
Am 06.03.2015 um 18:16 hat Jeff Cody geschrieben: The block layer maintainership is being split up into smaller, more manageable pieces. I propose that I take over / assist with the following areas: * blockjobs * archipelago * curl * gluster * nfs * rbd *

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 21:12, Leif Lindholm leif.lindh...@linaro.org wrote: Sorry for being late to the party, missed this set when it went out. You seem to be replying to an email thread which is now many months old and at a part of the conversation which was obsoleted by the subsequent discussion

Re: [Qemu-devel] [PATCH v2 1/2] elf-loader: Provide the possibility to relocate s390 ELF files

2015-03-09 Thread Christian Borntraeger
Am 09.03.2015 um 11:12 schrieb Thomas Huth: On s390, we would like to load our BIOS s390-ccw.img to the end of the RAM. Therefor we need the possibility to relocate the ELF file so that it can also run from different addresses. This patch adds the necessary code to the QEMU ELF loader

Re: [Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation

2015-03-09 Thread Igor Mammedov
On Mon, 9 Mar 2015 12:04:51 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Mar 09, 2015 at 11:28:22AM +0100, Igor Mammedov wrote: On Sun, 8 Mar 2015 13:16:03 +0200 Marcel Apfelbaum mar...@redhat.com wrote: The DefLEqual op does not have a target operand. Remove it.

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

2015-03-09 Thread Alexander Graf
On 02.03.15 00:46, Alexey Kardashevskiy wrote: This removes floppy disks support as it is not supported by any PPC64 system anyway as the only way to have floppy disk on such systems would be an ISA bus and Linux kernels seems have never had such support. Signed-off-by: Alexey

Re: [Qemu-devel] [PULL v6 0/3] pci, pc, virtio fixes and cleanups

2015-03-09 Thread Peter Maydell
On 8 March 2015 at 20:00, Michael S. Tsirkin m...@redhat.com wrote: An incremental pull update, sent to fix clang warning in v5. The following 3 patches added on top: acpi: drop unused code aml-build: comment fix acpi-build: fix typo in comment Only tested this lightly, but I

Re: [Qemu-devel] [PATCH v4 for-2.3 05/25] acpi: add aml_index() term

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 01:00 PM, Michael S. Tsirkin wrote: On Mon, Mar 09, 2015 at 11:39:57AM +0100, Igor Mammedov wrote: On Sun, 8 Mar 2015 13:16:07 +0200 Marcel Apfelbaum mar...@redhat.com wrote: Add encoding for ACPI DefIndex Opcode. Signed-off-by: Marcel Apfelbaum mar...@redhat.com ---

Re: [Qemu-devel] [PATCH] Actually block signals that have been queued by Qemu.

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 20:19, Timothy Baldwin t.e.baldwi...@members.leeds.ac.uk wrote: On 08/03/15 10:23, Peter Maydell wrote: On 8 March 2015 at 04:18, Timothy Baldwin t.e.baldwi...@members.leeds.ac.uk wrote: if (set) { -bool has_sigsegv = sigismember(set, SIGSEGV);

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2015-03-09 Thread Leif Lindholm
Sorry for being late to the party, missed this set when it went out. On Thu, Oct 30, 2014 at 05:52:44PM +, Peter Maydell wrote: On 30 October 2014 17:43, Alexander Spyridakis a.spyrida...@virtualopensystems.com wrote: Currently, the virt machine model generates Device Tree information

Re: [Qemu-devel] [PATCH v2 1/2] elf-loader: Provide the possibility to relocate s390 ELF files

2015-03-09 Thread Thomas Huth
On Mon, 09 Mar 2015 12:11:49 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: Am 09.03.2015 um 11:12 schrieb Thomas Huth: On s390, we would like to load our BIOS s390-ccw.img to the end of the RAM. Therefor we need the possibility to relocate the ELF file so that it can also run

Re: [Qemu-devel] [PATCH v2 1/2] elf-loader: Provide the possibility to relocate s390 ELF files

2015-03-09 Thread Alexander Graf
On 09.03.15 08:30, Thomas Huth wrote: On Mon, 09 Mar 2015 12:11:49 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: Am 09.03.2015 um 11:12 schrieb Thomas Huth: On s390, we would like to load our BIOS s390-ccw.img to the end of the RAM. Therefor we need the possibility to relocate

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2015-03-09 Thread Shannon Zhao
On 2015/3/9 20:28, Peter Maydell wrote: On 9 March 2015 at 21:12, Leif Lindholm leif.lindh...@linaro.org wrote: Sorry for being late to the party, missed this set when it went out. You seem to be replying to an email thread which is now many months old and at a part of the conversation which

Re: [Qemu-devel] [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-09 Thread Christoffer Dall
On Tue, Mar 03, 2015 at 11:28:21AM +, Alex Bennée wrote: Christoffer Dall christoffer.d...@linaro.org writes: Hi Alex, Seems like you accidentally sent out two copies of this patch, hopefully I'm reviewing the right one... Oops, perils of not wiping your output directory. I

Re: [Qemu-devel] [PULL 2.3 00/38] ppc patch queue 2015-03-08

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 21:30, Alexander Graf ag...@suse.de wrote: On 09.03.15 04:13, Peter Maydell wrote: On 8 March 2015 at 17:44, Alexander Graf ag...@suse.de wrote: Hi Peter, This is my current patch queue for ppc. Please pull. Alex The following changes since commit

Re: [Qemu-devel] [PULL 0/5] QMP queue

2015-03-09 Thread Luiz Capitulino
On Sun, 8 Mar 2015 23:08:04 +0900 Peter Maydell peter.mayd...@linaro.org wrote: On 5 March 2015 at 04:13, Luiz Capitulino lcapitul...@redhat.com wrote: Hi, This pull request contains two series. A balloon series and memory hotplug doc series. The balloon series is not totally QMP

Re: [Qemu-devel] [PATCH v2 5/6] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-09 Thread Christoffer Dall
On Wed, Mar 04, 2015 at 02:35:52PM +, Alex Bennée wrote: From: Christoffer Dall christoffer.d...@linaro.org The current code was negatively indexing the cpu state array and not synchronizing banked spsr register state with the current mode's spsr state, causing occasional failures with

Re: [Qemu-devel] [PULL 2.3 00/38] ppc patch queue 2015-03-08

2015-03-09 Thread Alexander Graf
On 09.03.15 08:16, Peter Maydell wrote: On 9 March 2015 at 21:30, Alexander Graf ag...@suse.de wrote: On 09.03.15 04:13, Peter Maydell wrote: On 8 March 2015 at 17:44, Alexander Graf ag...@suse.de wrote: Hi Peter, This is my current patch queue for ppc. Please pull. Alex The

Re: [Qemu-devel] [PATCH] Actually block signals that have been queued by Qemu.

2015-03-09 Thread Timothy Baldwin
On 08/03/15 10:23, Peter Maydell wrote: On 8 March 2015 at 04:18, Timothy Baldwin t.e.baldwi...@members.leeds.ac.uk wrote: From ebcb08f4f4ed90c8557cafc02593360c59e10a49 Mon Sep 17 00:00:00 2001 From: Timothy E Baldwin t.e.baldwi...@members.leeds.ac.uk Date: Sat, 7 Mar 2015 18:42:41 +

Re: [Qemu-devel] [PULL 2.3 00/38] ppc patch queue 2015-03-08

2015-03-09 Thread Alexander Graf
On 09.03.15 04:13, Peter Maydell wrote: On 8 March 2015 at 17:44, Alexander Graf ag...@suse.de wrote: Hi Peter, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 3539bbb93e944ffde31c61c369ea9eedcc5697a6: Merge remote-tracking branch

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-03-09 Thread Yi Wang
This will trigger the problem: vda has snapshot s1 with id 1, vdb doesn't have s1 but has snapshot s2 with id 1。When we want to run command virsh create s1, del_existing_snapshots() only deletes s1 in vda, and bdrv_snapshot_create() tries to create vdb's snapshot s1 with id 1, but id 1 alreay

Re: [Qemu-devel] [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 21:56, Christoffer Dall christoffer.d...@linaro.org wrote: this function, however, is not used only when migration, but should generally cover the case where you want to synchronize QEMU's state into KVM's state, right? So while it may not be harmful in currently supported

[Qemu-devel] [Bug 1429841] [NEW] error rom: requested regions overlap for NOLOAD sections

2015-03-09 Thread Roman
Public bug reported: command line: qemu-system-arm -semihosting -nographic -monitor null -serial null -no-reboot -kernel build/fw/0HNFcomSLuP1_CUNIT.elf output: rom: requested regions overlap (rom phdr #6: build/fw/0HNFcomSLuP1_CUNIT.elf. free=0x8001effc, addr=0x8001c000) rom loading failed I

[Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Wei Liu
I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references functions in libm, so the original ordering makes linking fail. This fix is to reorder $libs_softmmu and $LIBS to make -lm appear

Re: [Qemu-devel] [PATCH v2] target-tricore: Fix two helper functions (clang warnings)

2015-03-09 Thread Bastian Koppelmann
Hi Stefan, On 03/07/2015 02:43 PM, Stefan Weil wrote: clang report: target-tricore/op_helper.c:1247:24: warning: taking the absolute value of unsigned type 'uint32_t' (aka 'unsigned int') has no effect [-Wabsolute-value] target-tricore/op_helper.c:1248:25: warning: taking the absolute

Re: [Qemu-devel] [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

2015-03-09 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: On 9 March 2015 at 21:56, Christoffer Dall christoffer.d...@linaro.org wrote: this function, however, is not used only when migration, but should generally cover the case where you want to synchronize QEMU's state into KVM's state, right? So

[Qemu-devel] [PATCH] cpus: initialize cpu-memory_dispatch

2015-03-09 Thread Paolo Bonzini
This fixes a NULL pointer dereference in s390x-softmmu. On pretty much all other architectures, creating an MMIO region calls cpu_reload_memory_map. On s390, however, there are no MMIO regions and everything is done via hypercalls. Fixes: 9d82b5a792236db31a75b9db5c93af69ac07c7c5 Reported-by:

Re: [Qemu-devel] [PATCH v4 for-2.3 01/25] acpi: fix aml_equal term implementation

2015-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2015 at 01:26:40PM +0100, Igor Mammedov wrote: On Mon, 9 Mar 2015 12:04:51 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Mar 09, 2015 at 11:28:22AM +0100, Igor Mammedov wrote: On Sun, 8 Mar 2015 13:16:03 +0200 Marcel Apfelbaum mar...@redhat.com wrote:

[Qemu-devel] [PULL 72/73] iotests: add O_DIRECT alignment probing test

2015-03-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com This test case checks that image files can be opened even if I/O produces EIO errors. QEMU should not refuse opening failed disks since the guest may be configured for multipath I/O where accessing failed disks is expected. Signed-off-by: Stefan

[Qemu-devel] [PULL 68/73] Add testcase for scsi-hd devices without drive property

2015-03-09 Thread Kevin Wolf
From: Christian Borntraeger borntrae...@de.ibm.com Lets add a test for scsi devices without a drive. This was broken by a recent block patch, thus indicating that we need a testcase. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com

[Qemu-devel] [PULL 66/73] block/vdi: Add locking for parallel requests

2015-03-09 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com When allocating a new cluster, the first write to it must be the one doing the allocation, because that one pads its write request to the cluster size; if another write to that cluster is executed before it, that write will be overwritten due to the padding. See

[Qemu-devel] [PULL 00/73] Block patches

2015-03-09 Thread Kevin Wolf
Hi Peter, I hope this fixes the build problems in Stefan's pull request. I'm only posting those patches that are new compared to Stefan's version, or that have actual differences (the fixed build errors; not reposting for my added Signed-off-by). Kevin The following changes since commit

[Qemu-devel] [PULL 65/73] iotests: Drop vpc from 004's and 104's format list

2015-03-09 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Both tests require the test image to have a specific size; this cannot be guaranteed by vpc (unless tuning the test specifically for that format). It is safe to exclude vpc from 004 because what is tested there is implemented in a generic part in the block layer

Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-03-09 Thread Kevin Wolf
Am 26.02.2015 um 00:06 hat John Snow geschrieben: This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for other tests. Signed-off-by: John Snow js...@redhat.com ---

Re: [Qemu-devel] [Linaro-acpi] [RFC PATCH 0/7] hw/arm/virt: Dynamic ACPI v5.1 table generation

2015-03-09 Thread Leif Lindholm
On Mon, Mar 09, 2015 at 09:28:05PM +0900, Peter Maydell wrote: On 9 March 2015 at 21:12, Leif Lindholm leif.lindh...@linaro.org wrote: Sorry for being late to the party, missed this set when it went out. You seem to be replying to an email thread which is now many months old and at a part

Re: [Qemu-devel] gsoc idea

2015-03-09 Thread Gerd Hoffmann
Hi, is it a viable idea, or i should scrap it altogether? Sounds good, go ahead, I can mentor this. Draft added to wiki page: http://qemu-project.org/Google_Summer_of_Code_2015#QEMU_audio_backend Drop me a note when you think this needs changes. cheers, Gerd

Re: [Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 23:41, shlomo.pongr...@toganetworks.com wrote: From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported for two reasons: First the largest integer type has the size of 64 bits and

Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-03-09 Thread Kevin Wolf
Am 09.03.2015 um 17:03 hat John Snow geschrieben: On 03/09/2015 10:27 AM, Kevin Wolf wrote: Am 26.02.2015 um 00:06 hat John Snow geschrieben: +void mkimg(const char *file, const char *fmt, unsigned size_mb) +{ +gchar *cli; +bool ret; +int rc; +GError *err = NULL; +char

Re: [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-09 Thread Marcel Apfelbaum
On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that works. Going to play with that now ;) Good luck! ... and tell me what you think :) If you need any help with the command line of the pxb device, let me

Re: [Qemu-devel] [PATCH] iscsi: Fix check for username

2015-03-09 Thread Paolo Bonzini
On 07/03/2015 10:14, Stefan Weil wrote: The variable user in struct iscsi_url is a character array, not a pointer. Therefore its address will never be NULL. clang reports this error: block/iscsi.c:1329:20: warning: comparison of array 'iscsi_url-user' not equal to a null pointer is

[Qemu-devel] [PATCH] pci/shpc: fix signed integer overflow

2015-03-09 Thread Michael S. Tsirkin
clang undefined behaviour sanitizer reports: hw/pci/shpc.c:162:27: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Caused by the usual lack of a 'U' qualifier on a constant 1 being shifted left. Fix it up. Reported-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PULL 2.3 00/38] ppc patch queue 2015-03-08

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 23:02, Alexander Graf ag...@suse.de wrote: Hooray :). I've fixed up the patch, rebased and updated the tag. Updated patch is below. Applied fixed version, thanks. -- PMM

Re: [Qemu-devel] [PATCH v2 0/2] s390x: Make the s390-ccw BIOS relocatable

2015-03-09 Thread Christian Borntraeger
Am 09.03.2015 um 11:12 schrieb Thomas Huth: Currently, our s390-ccw.img sits at the fix address 126 MiB in memory. This has two big disadvantages: 1) We can not start guests with less than 128 MiB RAM and 2) if the guest uses a really huge ramdisk 126 MiB, the s390-ccw BIOS gets overwritten

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Wei Liu
On Tue, Mar 10, 2015 at 12:11:44AM +0900, Peter Maydell wrote: On 9 March 2015 at 23:54, Wei Liu wei.l...@citrix.com wrote: I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references

[Qemu-devel] [PULL 70/73] MAINTAINERS: Add jsnow as IDE maintainer

2015-03-09 Thread Kevin Wolf
From: John Snow js...@redhat.com It has been proposed that the block layer be split up into smaller, more manageable portions to help speed up the review and merging of block layer patches. As part of this process, I propose that I take over the IDE, ATA, ATAPI and FD devices. As we split out

[Qemu-devel] [PULL 73/73] MAINTAINERS: Add jcody as blockjobs, block devices maintainer

2015-03-09 Thread Kevin Wolf
From: Jeff Cody jc...@redhat.com The block layer maintainership is being split up into smaller, more manageable pieces. I propose that I take over / assist with the following areas: * blockjobs * archipelago * curl * gluster * nfs * rbd * sheepdog * ssh *

[Qemu-devel] [PULL 67/73] scsi-hd: fix property unset case

2015-03-09 Thread Kevin Wolf
From: Ekaterina Tumanova tuman...@linux.vnet.ibm.com Commit c53659f0 (BlockConf: Call backend functions to detect geometry and blocksizes) causes a segmentation fault on the invalid configuration of a scsi device without a drive. Let's check for conf.blk before calling blkconf_blocksizes. The

[Qemu-devel] [PULL 22/73] qcow2: Helper function for refcount modification

2015-03-09 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for accessing them, two helper functions are used (a getter and a setter). Those functions are

[Qemu-devel] [PULL 69/73] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-03-09 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com If do_sd_create() fails, it first reports the error returned, then reports a another one with strerror(errno). errno is meaningless at that point. Report just one error combining the valid information from both messages. Reported-by: Eric Blake

[Qemu-devel] [PULL 62/73] virtio-blk: Remove the stale FIXME comment

2015-03-09 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com By default, we have ioeventfd enabled, so the IO request processing is in IO thread; in the vcpu thread, guest mode is returned to as quickly as possible, and completion is delivered via irqfd. Therefore this comment from the initial implementation is barely

[Qemu-devel] [PULL 63/73] iotests: Fix 051's reference output

2015-03-09 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Commit c4bacafb717de55538311b80a185ce9166b8daa2 changed (improved) qdev_init_nofail()'s error reporting, which affects iotest 051. Fix the reference output. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH 0/2] kvm_stat: add man page and tui column headers

2015-03-09 Thread Paolo Bonzini
On 03/03/2015 00:29, Stefan Hajnoczi wrote: This series makes kvm_stat easier to learn for newcomers by adding a man page and text UI column headers. Stefan Hajnoczi (2): kvm_stat: add column headers to text UI kvm_stat: add kvm_stat.1 man page Makefile | 9

Re: [Qemu-devel] [PULL v6 0/3] pci, pc, virtio fixes and cleanups

2015-03-09 Thread Michael S. Tsirkin
On Mon, Mar 09, 2015 at 08:10:17PM +0900, Peter Maydell wrote: On 8 March 2015 at 20:00, Michael S. Tsirkin m...@redhat.com wrote: An incremental pull update, sent to fix clang warning in v5. The following 3 patches added on top: acpi: drop unused code aml-build: comment fix

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Peter Maydell
On 9 March 2015 at 23:54, Wei Liu wei.l...@citrix.com wrote: I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references functions in libm, so the original ordering makes linking fail.

Re: [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-09 Thread Gerd Hoffmann
Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that works. Going to play with that now ;) thanks, Gerd

[Qemu-devel] [PULL 64/73] iotests: Remove 006

2015-03-09 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com vpc does support images 127 GB if done correctly. qemu does it correctly. Remove the test pretending otherwise. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-03-09 Thread John Snow
On 03/09/2015 10:27 AM, Kevin Wolf wrote: Am 26.02.2015 um 00:06 hat John Snow geschrieben: This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for other tests. Signed-off-by: John

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

2015-03-09 Thread Alexey Kardashevskiy
On 03/09/2015 11:31 PM, Alexander Graf wrote: On 02.03.15 00:46, Alexey Kardashevskiy wrote: This removes floppy disks support as it is not supported by any PPC64 system anyway as the only way to have floppy disk on such systems would be an ISA bus and Linux kernels seems have never had such

[Qemu-devel] [PATCH v2] s390x/kvm: Guest Migration TOD clock synchronization

2015-03-09 Thread Jens Freimann
From: Jason J. Herne jjhe...@us.ibm.com Synchronizes the guest TOD clock across a migration by sending the guest TOD clock value to the destination system. If the guest TOD clock is not preserved across a migration then the guest's view of time will snap backwards if the destination host clock is

[Qemu-devel] [PULL 71/73] block/raw-posix: fix launching with failed disks

2015-03-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Since commit c25f53b06eba1575d5d0e92a0132455c97825b83 (raw: Probe required direct I/O alignment) QEMU has failed to launch if image files produce I/O errors. Previously, QEMU would launch successfully and the guest would see the errors when attempting

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Stefano Stabellini
On Mon, 9 Mar 2015, Wei Liu wrote: On Tue, Mar 10, 2015 at 12:11:44AM +0900, Peter Maydell wrote: On 9 March 2015 at 23:54, Wei Liu wei.l...@citrix.com wrote: I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Paolo Bonzini
On 09/03/2015 15:54, Wei Liu wrote: I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references functions in libm, so the original ordering makes linking fail. This fix is to reorder

[Qemu-devel] [PATCH 5/8] ioport: Remove unused functions

2015-03-09 Thread Thomas Huth
The functions portio_list_destroy() and portio_list_del() are not used anywhere, so let's remove them. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Paolo Bonzini pbonz...@redhat.com --- include/exec/ioport.h |2 -- ioport.c | 24 2 files

[Qemu-devel] Modeling a platform in QEMU for beginners

2015-03-09 Thread Arthur Krieger
Dear QEMU developers, I currently have problems getting started with the development in QEMU. What I want to know is where I start, if I want to emulate my own hardware with QEMU. It seems to me there is no real guide or tutorial for this? I started looking into the implementation of the

[Qemu-devel] [PATCH v2 3/4] scsi: Improve error reporting for invalid drive property

2015-03-09 Thread Markus Armbruster
When setting realized fails, scsi_bus_legacy_add_drive() passes the error to qerror_report_err(), then returns an unspecific Setting drive property failed error, which is reported further up the call chain. Example: $ qemu-system-x86_64 -nodefaults -S -display none \ -drive

[Qemu-devel] [PATCH v2 2/4] hw: Propagate errors through qdev_prop_set_drive()

2015-03-09 Thread Markus Armbruster
Three kinds of callers: 1. On failure, report the error and abort Passing error_abort does the job. No functional change. 2. On failure, report the error and exit() This is qdev_prop_set_drive_nofail(). Error reporting moves from qdev_prop_set_drive() to its caller. Because hiding

Re: [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-09 Thread Gerd Hoffmann
On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote: On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that works. Going to play with that now ;) Good luck! ... and tell me what you think :) If you

Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-03-09 Thread Markus Armbruster
John Snow js...@redhat.com writes: On 03/09/2015 10:27 AM, Kevin Wolf wrote: Am 26.02.2015 um 00:06 hat John Snow geschrieben: This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for

[Qemu-devel] [PATCH 6/8] usb: Remove unused functions

2015-03-09 Thread Thomas Huth
Delete set_usb_string(), usb_ep_get_ifnum(), usb_ep_get_max_packet_size() usb_ep_get_max_streams() and usb_ep_set_pipeline() since they are not used anymore. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Gerd Hoffmann kra...@redhat.com --- hw/usb/core.c| 41

[Qemu-devel] [PATCH 8/8] Remove various unused functions

2015-03-09 Thread Thomas Huth
The functions tpm_backend_thread_tpm_reset(), serial_set_frequency() and iothread_find() are completely unused, let's remove them. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com --- backends/tpm.c | 11 --- hw/char/serial.c |7 ---

[Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-09 Thread shlomo.pongratz
From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported for two reasons: First the largest integer type has the size of 64 bits and modifying essential data structures in order to support 128 cores will

[Qemu-devel] [PATCH v2 1/4] scsi: Clean up duplicated error in legacy if=scsi code

2015-03-09 Thread Markus Armbruster
Commit a818a4b changed scsi_bus_legacy_handle_cmdline() to report errors from scsi_bus_legacy_add_drive() with error_report() in addition to returning them. That's inappropriate. Two kinds of callers: 1. realize methods (devices esp, virtio-scsi-device and spapr-vscsi) The error object

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Wei Liu
On Tue, Mar 10, 2015 at 01:36:49AM +0900, Peter Maydell wrote: On 10 March 2015 at 00:23, Wei Liu wei.l...@citrix.com wrote: On Tue, Mar 10, 2015 at 12:11:44AM +0900, Peter Maydell wrote: Maybe we should actively stop configure allowing a static build of the softmmu and tools binaries,

[Qemu-devel] [PATCH 2/8] vmxnet: Remove unused function vmxnet_rx_pkt_get_num_frags()

2015-03-09 Thread Thomas Huth
The function is not used anymore and thus can be deleted. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Dmitry Fleytman dmi...@daynix.com --- hw/net/vmxnet_rx_pkt.c |7 --- hw/net/vmxnet_rx_pkt.h |9 - 2 files changed, 0 insertions(+), 16 deletions(-) diff --git

[Qemu-devel] [PATCH 4/8] monitor: Remove unused functions

2015-03-09 Thread Thomas Huth
The functions ringbuf_read_completion() and monitor_get_rs() are not used anywhere anymore, so let's remove them. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Luiz Capitulino lcapitul...@redhat.com --- hmp.h |1 - include/monitor/monitor.h |1 - monitor.c

[Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-09 Thread shlomo.pongratz
From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported for two reasons: First the largest integer type has the size of 64 bits and modifying essential data structures in order to support 128 cores will

[Qemu-devel] Modeling a platform in QEMU

2015-03-09 Thread Arthur Krieger
Dear QEMU developers, I currently have problems getting started with the development in QEMU. What I want to know is where I start, if I want to emulate my own hardware with QEMU. It seems to me there is no real guide or tutorial for this? I started looking into the implementation of the

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-09 Thread Peter Maydell
On 10 March 2015 at 00:23, Wei Liu wei.l...@citrix.com wrote: On Tue, Mar 10, 2015 at 12:11:44AM +0900, Peter Maydell wrote: Maybe we should actively stop configure allowing a static build of the softmmu and tools binaries, rather than having configs which nobody really tests? Or is there a

Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-03-09 Thread John Snow
On 03/09/2015 12:27 PM, Kevin Wolf wrote: Am 09.03.2015 um 17:03 hat John Snow geschrieben: On 03/09/2015 10:27 AM, Kevin Wolf wrote: Am 26.02.2015 um 00:06 hat John Snow geschrieben: +void mkimg(const char *file, const char *fmt, unsigned size_mb) +{ +gchar *cli; +bool ret; +

[Qemu-devel] [PATCH 1/8] migration: Remove unused functions

2015-03-09 Thread Thomas Huth
migrate_rdma_pin_all(), qsb_clone() and qsb_set_length() are completely unused and thus can be deleted. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Juan Quintela quint...@redhat.com Cc: Amit Shah amit.s...@redhat.com --- include/migration/migration.h |1 -

[Qemu-devel] [PATCH 3/8] pci: Remove unused functions

2015-03-09 Thread Thomas Huth
The functions pcie_ari_init(), pcie_cap_is_arifwd_enabled() and ich9_d2pbr_init() are completely unused and thus can be deleted. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Anthony Liguori aligu...@amazon.com --- hw/pci-bridge/i82801b11.c | 21

Re: [Qemu-devel] [PULL v6 0/3] pci, pc, virtio fixes and cleanups

2015-03-09 Thread Markus Armbruster
Michael, I noticed only now that you applied my [PATCH v2 0/2] pci: Bury dead legacy commands pci_add, pci_del *backwards*: 2/2 before 1/2. Happens to be harmless, but please check your workflow.

Re: [Qemu-devel] [PATCH 0/4] ucb: Convert remaining PCI HCDs to realize

2015-03-09 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: On Di, 2015-02-17 at 14:28 +0100, Markus Armbruster wrote: This series requires my [PATCH 00/10] pci: Partial conversion to realize and my [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err(). Markus Armbruster (4): usb: Propagate

[Qemu-devel] help parsing qemu options

2015-03-09 Thread Gabriel L. Somlo
Hi, Assuming I'm trying to add a new command line option to qemu in vl.c: ... static QemuOptsList qemu_foo_opts = { .name = foo, .implied_opt_name = name, .head = QTAILQ_HEAD_INITIALIZER(qemu_foo_opts.head), .desc = { { .name = name, .type =

[Qemu-devel] [PATCH v2 4/4] scsi: Convert remaining PCI HBAs to realize()

2015-03-09 Thread Markus Armbruster
These are am53c974, dc390, lsi53c895a, lsi53c810, megasas, megasas-gen2. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/scsi/esp-pci.c| 30 +++--- hw/scsi/lsi53c895a.c | 14 +++---

[Qemu-devel] [PATCH v2 0/4] scsi: Error reporting cleanups, realize()

2015-03-09 Thread Markus Armbruster
Applies cleanly on master now, and passes make check with my [PATCH RFC 1/1] qtest: Add generic PCI device test applied on top. v2: - Rebase: PATCH 01 loses the spapr_vscsi.c hunk, because commit 28b07e7 converted it to realize(). Commit message updated. PATCH 03 commit message updated to

[Qemu-devel] [PATCH 0/8] Remove more unused functions

2015-03-09 Thread Thomas Huth
Here are some more patches to remove completely unused functions from QEMU. Please review carefully, some of the functions might still get usefull in the future again, so if you discover one, please let me know, then I'll remove it from the patch series again. Thomas Huth (8): migration: Remove

[Qemu-devel] [PATCH 7/8] util: Remove unused functions

2015-03-09 Thread Thomas Huth
Delete the unused functions qemu_signalfd_available(), qemu_send_full() and qemu_recv_full(). Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Markus Armbruster arm...@redhat.com --- include/qemu-common.h |4 --- include/qemu/compatfd.h |1 - util/compatfd.c | 19

[Qemu-devel] [PULL 0/7] X86 patches

2015-03-09 Thread Eduardo Habkost
The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2015-03-09 14:04:14 +) are available in the git repository at: https://github.com/ehabkost/qemu.git tags/x86-pull-request

[Qemu-devel] [PULL 3/7] target-i386: Eliminate unnecessary get_cpuid_vendor() function

2015-03-09 Thread Eduardo Habkost
The function was used in only two places. In one of them, the function made the code less readable by requiring temporary te[bcd]x variables. In the other one we can simply inline the existing code. Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Eduardo Habkost ehabk...@redhat.com

[Qemu-devel] Crash when using -daemonize

2015-03-09 Thread Stefan Berger
Since an upgrade to Fedora 21, I get crashes with QEMU when using -daemonize. I noticed this since libvirt could not QMP probe QEMU. This is the command line used: x86_64-softmmu/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none -pidfile /tmp/foo -daemonize Here's the

Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

2015-03-09 Thread John Snow
On 03/09/2015 10:27 AM, Kevin Wolf wrote: Am 26.02.2015 um 00:06 hat John Snow geschrieben: This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for other tests. Signed-off-by: John

[Qemu-devel] [PULL 6/7] target-i386: Move APIC ID compatibility code to pc.c

2015-03-09 Thread Eduardo Habkost
The APIC ID compatibility code is required only for PC, and now that x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore, that code can be moved to pc.c. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 5/7] target-i386: Move CPUX86State::cpuid_apic_id to X86CPU::apic_id

2015-03-09 Thread Eduardo Habkost
The field doesn't need to be inside CPUX86State, and it is not specific for the CPUID instruction, so move and rename it. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu-qom.h | 1

[Qemu-devel] [PULL 4/7] target-i386: Remove unused APIC ID default code

2015-03-09 Thread Eduardo Habkost
The existing apic_id = cpu_index code has no visible effect: the PC code already initializes the APIC ID according to the topology on pc_new_cpu(), and linux-user memcpy()s the CPU state (including cpuid_apic_id) on cpu_copy(). Remove the dead code and simply let APIC ID to to be 0 by default.

[Qemu-devel] [PULL 7/7] target-i386: Require APIC ID to be explicitly set before CPU realize

2015-03-09 Thread Eduardo Habkost
On softmuu, instead of setting APIC ID automatically when creating a X86CPU, require the property to be set before realizing the object (which is already done by the CPU creation code on PC). Keep apic_id = 0 by default on *-user so it can simply create a new CPU object and realize it without

Re: [Qemu-devel] Crash when using -daemonize

2015-03-09 Thread Christian Borntraeger
Am 09.03.2015 um 22:03 schrieb Stefan Berger: Since an upgrade to Fedora 21, I get crashes with QEMU when using -daemonize. I noticed this since libvirt could not QMP probe QEMU. This is the command line used: x86_64-softmmu/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic

[Qemu-devel] Fix for incorrect SYSRET instruction implementation -- anyone looked at this yet?

2015-03-09 Thread Bill Paul
Nobody has commented on this yet. According to my reading of the Intel documentation, the SYSRET instruction is supposed to force the RPL bits of the %ss register to 3 when returning to user mode. The actual sequence is: SS.Selector -- (IA32_STAR[63:48]+8) OR 3; (* RPL forced to 3 *) However,

Re: [Qemu-devel] [PATCH] pci: Convert pci_nic_init() to Error to avoid qdev_init()

2015-03-09 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: qdev_init() is deprecated, and will be removed when its callers have been weaned off it. Signed-off-by: Markus Armbruster arm...@redhat.com --- Depends on my [PATCH 00/10] pci: Partial conversion to realize, which is in Michael's latest pull

Re: [Qemu-devel] [RFC v4 3/9] vfio: add pcie extanded capability support

2015-03-09 Thread Alex Williamson
On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: For vfio pcie device, we could expose the extanded capability on s/extanded/extended/ PCIE bus. in order to avoid config space broken, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space.

  1   2   3   >