Re: [Qemu-devel] [PATCH 25/27] block/parallels: add prealloc-mode and prealloc-size open paramemets

2015-04-28 Thread Roman Kagan
On Tue, Apr 28, 2015 at 10:46:58AM +0300, Denis V. Lunev wrote: This is preparational commit for tweaks in Parallels image expansion. The idea is that enlarge via truncate by one data block is slow. It would be much better to use fallocate via bdrv_write_zeroes and expand by some significant

Re: [Qemu-devel] [PATCH v6 29/36] qapi: Document 'struct' metatype

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Referring to type as both a meta-type (built-in, enum, union, alternte, or struct) and a specific type (the name that the schema uses for declaring structs) is confusing. Now that the generator accepts 'struct' as a synonym for 'type', update all

Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

2015-04-28 Thread Cornelia Huck
On Tue, 28 Apr 2015 14:47:11 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 01:39:51PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 12:55:40 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 12:40:07PM +0200, Cornelia Huck wrote: On

Re: [Qemu-devel] [PATCH v2 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-28 Thread Don Slutz
On 04/28/15 04:13, Paolo Bonzini wrote: On 28/04/2015 00:46, Don Slutz wrote: This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don

Re: [Qemu-devel] [REBASE PATCH v5 2/2] spapr: override default ram size to 1GB

2015-04-28 Thread Thomas Huth
On Tue, 28 Apr 2015 12:23:26 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c

[Qemu-devel] [PATCH 4/7] target-mips: add MTHC0 and MFHC0 instructions

2015-04-28 Thread Leon Alrae
Implement MTHC0 and MFHC0 instructions. In MIPS32 they allow to access upper word of extended to 64-bits CP0 registers. In MIPS64, when CP0 destination register specified is the EntryLo0 or EntryLo1, bits 1:0 of the GPR appear at bits 31:30 of EntryLo0 or EntryLo1. This is to compensate for RI

[Qemu-devel] [PATCH 2/7] target-mips: support Page Frame Number Extension field

2015-04-28 Thread Leon Alrae
Update tlb-PFN to contain PFN concatenated with PFNX. PFNX is 0 if large physical address is not supported. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/op_helper.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Peter Maydell
On 28 April 2015 at 12:51, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390, and virtio-*-ccw

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Peter Maydell
On 28 April 2015 at 14:13, Michael S. Tsirkin m...@redhat.com wrote: The patches look correct to me too, but I want s390 cleaned up so it does not include COMMON_FEATURES in 100 places, and I prefer merging it all together. It seems a bit harsh to ask Shannon to do s390 cleanup when he doesn't

[Qemu-devel] [PATCH v4 2/4] block: add bdrv_set_dirty()/bdrv_reset_dirty() to block_int.h

2015-04-28 Thread Stefan Hajnoczi
The dirty bitmap functions are called from the block I/O processing code. Make them visible to block_int.h users so they can be used outside block.c. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 12 include/block/block_int.h | 4 2 files

[Qemu-devel] [PATCH v4 3/4] block: extract bdrv_setup_io_funcs()

2015-04-28 Thread Stefan Hajnoczi
Move the code to install coroutine and aio emulation function pointers in a BlockDriver to its own function. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 7 ++- include/block/block_int.h | 8 2 files changed, 14 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 2/7] target-mips: support Page Frame Number Extension field

2015-04-28 Thread James Hogan
On 28/04/15 13:41, Leon Alrae wrote: Update tlb-PFN to contain PFN concatenated with PFNX. PFNX is 0 if large physical address is not supported. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/op_helper.c | 32 ++-- 1 file changed, 26

Re: [Qemu-devel] [PATCH v6 00/36] drop qapi nested structs

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: We want to eventually allow qapi defaults, by making: 'data':{'*flag':'bool'} as shorthand for something like: 'data':{'flag':{'type':'bool', 'optional':true}} so that the default can be specified: 'data':{'flag':{'type':'bool', 'optional':true,

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 03:20:54PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 15:05:47 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 01:52:40PM +0100, Peter Maydell wrote: On 28 April 2015 at 13:48, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 14:16:40 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 28 April 2015 at 14:13, Michael S. Tsirkin m...@redhat.com wrote: The patches look correct to me too, but I want s390 cleaned up so it does

Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description

2015-04-28 Thread Gal Hammer
On 27/04/2015 17:56, Eric Blake wrote: On 04/27/2015 05:19 AM, Gal Hammer wrote: Signed-off-by: Gal Hammer gham...@redhat.com --- docs/specs/vmgenid.txt | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git

[Qemu-devel] [PULL 01/22] translate-all: use glib for all page descriptor allocations

2015-04-28 Thread Paolo Bonzini
From: Emilio G. Cota c...@braap.org Since commit b7b5233a bsd-user/mmap.c: Don't try to override g_malloc/g_free the exception we make here for usermode has been unnecessary. Get rid of it. Signed-off-by: Emilio G. Cota c...@braap.org Message-Id:

[Qemu-devel] [PULL 11/22] gus: clean up MemoryRegionPortio

2015-04-28 Thread Paolo Bonzini
Remove 16-bit reads/writes, since ioport.c is able to synthesize them. Remove the two MIDI registers (0x300 and 0x301) from gus_portio_list1, and add the second MIDI register (0x301) to gus_portio_list2. Tested with Second Reality. Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PULL 02/22] exec: Atomic access to bounce buffer

2015-04-28 Thread Paolo Bonzini
From: Fam Zheng f...@redhat.com There could be a race condition when two processes call address_space_map concurrently and both want to use the bounce buffer. Add an in_use flag in BounceBuffer to sync it. Signed-off-by: Fam Zheng f...@redhat.com Message-Id:

[Qemu-devel] [PULL 00/22] Memory, TCG, NBD, build system changes for 2015-04-27

2015-04-28 Thread Paolo Bonzini
The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: Open 2.4 development tree (2015-04-25 22:05:07 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

[Qemu-devel] [PULL 13/22] ioport: remove wrong comment

2015-04-28 Thread Paolo Bonzini
ioport.c has not been using an alias since commit b40acf9 (ioport: Switch dispatching to memory core layer, 2013-06-24). Remove the obsolete comment. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- ioport.c | 4 1 file changed, 4 deletions(-) diff --git a/ioport.c b/ioport.c index

[Qemu-devel] register QEMU ACPI ID

2015-04-28 Thread Michael S. Tsirkin
Hello! Please register the ACPI Vendor ID QEMU to the qemu emulator project. Thanks! -- MST

Re: [Qemu-devel] [PATCH v4 0/4] block: move I/O request processing to block/io.c

2015-04-28 Thread Kevin Wolf
Am 28.04.2015 um 15:27 hat Stefan Hajnoczi geschrieben: Note: This series is based on my block-next branch: https://github.com/stefanha/qemu.git block-next v4: * Extracted two patches that change block.c code, now making the final block/io.c patch purely code movement [Eric] * Added

Re: [Qemu-devel] [PATCH V15 1/5] docs: vm generation id device's description

2015-04-28 Thread Gal Hammer
On 27/04/2015 16:55, Michael S. Tsirkin wrote: On Mon, Apr 27, 2015 at 02:19:47PM +0300, Gal Hammer wrote: Signed-off-by: Gal Hammer gham...@redhat.com --- docs/specs/vmgenid.txt | 35 +++ 1 file changed, 35 insertions(+) create mode 100644

Re: [Qemu-devel] [PATCH 2/7] target-mips: support Page Frame Number Extension field

2015-04-28 Thread James Hogan
On 28/04/15 14:35, James Hogan wrote: On 28/04/15 13:41, Leon Alrae wrote: Update tlb-PFN to contain PFN concatenated with PFNX. PFNX is 0 if large physical address is not supported. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/op_helper.c | 32

[Qemu-devel] [PULL 03/22] linux-user, bsd-user: Remove two calls to cpu_exec_init_all

2015-04-28 Thread Paolo Bonzini
From: Fam Zheng f...@redhat.com The function is a nop for user mode, so just remove them. Signed-off-by: Fam Zheng f...@redhat.com Message-Id: 1426496617-10702-3-git-send-email-f...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- bsd-user/main.c | 1 - linux-user/main.c | 1 -

[Qemu-devel] [PULL 10/22] sb16: remove useless mixer_write_indexw

2015-04-28 Thread Paolo Bonzini
ioport.c is already able to split a 16-bit access into two 8-bit accesses to consecutive ports. Tested with Epic Pinball. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/audio/sb16.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index

[Qemu-devel] [PULL 15/22] ioport: reserve the whole range of an I/O port in the AddressSpace

2015-04-28 Thread Paolo Bonzini
When an I/O port is more than 1 byte long, ioport.c is currently creating short regions, for example 0x1ce-0x1ce for the 16-bit Bochs index port. When I/O ports are memory mapped, and thus accessed via a subpage_ops memory region, subpage_accepts gets confused because it finds a hole at 0x1cf and

[Qemu-devel] [PULL 05/22] exec: Notify cpu_register_map_client caller if the bounce buffer is available

2015-04-28 Thread Paolo Bonzini
From: Fam Zheng f...@redhat.com The caller's workflow is like if (!address_space_map()) { ... cpu_register_map_client(); } If bounce buffer became available after address_space_map() but before cpu_register_map_client(), the caller could miss it and has to wait for the

[Qemu-devel] [PULL 18/22] milkymist: do not modify libs-softmmu

2015-04-28 Thread Paolo Bonzini
This is better and prepares for the next patch. When we copy libs_softmmu's value into LIBS with a := assignment, we cannot anymore modify libs_softmmu in the Makefiles. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/display/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 04/22] exec: Protect map_client_list with mutex

2015-04-28 Thread Paolo Bonzini
From: Fam Zheng f...@redhat.com So that accesses from multiple threads are safe. Signed-off-by: Fam Zheng f...@redhat.com Message-Id: 1426496617-10702-4-git-send-email-f...@redhat.com [Remove #if from cpu_exec_init_all. - Paolo] Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- exec.c | 22

Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 03:33:37PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 14:47:11 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 01:39:51PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 12:55:40 +0200 Michael S. Tsirkin m...@redhat.com wrote:

[Qemu-devel] [PULL 06/22] dma-helpers: Fix race condition of continue_after_map_failure and dma_aio_cancel

2015-04-28 Thread Paolo Bonzini
From: Fam Zheng f...@redhat.com If DMA's owning thread cancels the IO while the bounce buffer's owning thread is notifying the cpu client list, a use-after-free happens: continue_after_map_failure dma_aio_cancel

Re: [Qemu-devel] [PATCH V6 for-2.3 13/26] hw/pci-host: introduce TYPE_PCI_HOST_BRIDGE_SNOOPED interface

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 01:21:14PM +0300, Marcel Apfelbaum wrote: On 04/28/2015 11:43 AM, Michael S. Tsirkin wrote: On Tue, Apr 28, 2015 at 11:39:42AM +0300, Marcel Apfelbaum wrote: On 04/27/2015 05:45 PM, Michael S. Tsirkin wrote: On Mon, Apr 27, 2015 at 04:01:16PM +0300, Marcel Apfelbaum

[Qemu-devel] [PATCH] pci: Merge pci_nic_init() into pci_nic_init_nofail()

2015-04-28 Thread Thomas Huth
The error reporting in pci_nic_init() is quite erratic: Some errors are printed directly with error_report(), and some are passed back to the caller pci_nic_init_nofail() via an Error pointer. Since pci_nic_init() is only used by pci_nic_init_nofail(), the functions can be simply merged to clean

Re: [Qemu-devel] [RFC PATCH v4 00/28] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-04-28 Thread zhanghailiang
On 2015/4/24 16:35, Dr. David Alan Gilbert wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: On 04/22/2015 07:18 PM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: Hi, ping ... I will get to look at this again; but not until after next week. The

Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 12:40:07PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 10:16:04 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 10:04:15AM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 09:14:07 +0200 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH] pci: Clean up error reporting in pci_nic_init()

2015-04-28 Thread Thomas Huth
On Tue, 28 Apr 2015 10:40:09 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 09:26:47AM +0200, Thomas Huth wrote: On Mon, 27 Apr 2015 10:55:41 -0700 Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Mon, Apr 27, 2015 at 10:51 AM, Thomas Huth

Re: [Qemu-devel] [PATCH 26/27] block/parallels: optimize linear image expansion

2015-04-28 Thread Roman Kagan
On Tue, Apr 28, 2015 at 10:46:59AM +0300, Denis V. Lunev wrote: Plain image expansion spends a lot of time to update image file size. This seriously affects the performance. The following simple test qemu_img create -f parallels -o cluster_size=64k ./1.hds 64G qemu_io -n -c write -P 0x11 0

Re: [Qemu-devel] [PATCH v6 17/36] qapi: Add some expr tests

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Demonstrate that the qapi generator doesn't deal well with expressions that aren't up to par. Later patches will improve the expected results as the generator is made stricter. Only a few of the the added tests actually behaves sanely at behave

Re: [Qemu-devel] [PATCH v2] bios-tables-test: handle false-positive smbios signature matches

2015-04-28 Thread Eric Blake
On 04/28/2015 01:55 PM, Gabriel L. Somlo wrote: It has been reported that sometimes the .rodata section of SeaBIOS, containing the constant string against which the SMBIOS signature ends up being compared, also falls withing the guest f-segment. In s/withing/within/ that case, the test

[Qemu-devel] [PULL 10/10] qtest: Add assertion that required environment variable is set

2015-04-28 Thread John Snow
From: Ed Maste ema...@freebsd.org Signed-off-by: Ed Maste ema...@freebsd.org Reviewed-by: John Snow js...@redhat.com Message-id: 1427911244-22565-1-git-send-email-ema...@freebsd.org Signed-off-by: John Snow js...@redhat.com --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PULL 05/10] qtest/ahci: Allow override of default CLI options

2015-04-28 Thread John Snow
Signed-off-by: John Snow js...@redhat.com Message-id: 1426018503-821-3-git-send-email-js...@redhat.com --- tests/ahci-test.c| 67 tests/libqos/libqos-pc.c | 5 tests/libqos/libqos-pc.h | 1 + 3 files changed, 51 insertions(+), 22

[Qemu-devel] [PULL 03/10] qtest/ahci: test different disk sectors

2015-04-28 Thread John Snow
Test sector offset 0, 1, and the last sector(s) in LBA28 and LBA48 modes. Signed-off-by: John Snow js...@redhat.com Acked-by: Stefan Hajnoczi stefa...@redhat.com Message-id: 1426274523-22661-3-git-send-email-js...@redhat.com --- tests/ahci-test.c | 68

[Qemu-devel] [PULL 02/10] qtest/ahci: add qcow2 support to ahci-test

2015-04-28 Thread John Snow
This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for other tests. Signed-off-by: John Snow js...@redhat.com Acked-by: Stefan Hajnoczi stefa...@redhat.com Message-id:

[Qemu-devel] [PULL 01/10] fdc: remove sparc sun4m mutations

2015-04-28 Thread John Snow
From: Hervé Poussineau hpous...@reactos.org They were introduced in 6f7e9aec5eb5bdfa57a9e458e391b785c283a007 and 82407d1a4035e5bfefb53ffdcb270872f813b34c and lots of bug fixes were done after that. This fixes (at least) the detection of the floppy controller on Debian 4.0r9/SPARC, and SS-5's

[Qemu-devel] [PULL 08/10] libqos: add blkdebug_prepare_script

2015-04-28 Thread John Snow
Pull this helper out of ide-test and into libqos, to be shared with ahci-test. Signed-off-by: John Snow js...@redhat.com Message-id: 1426018503-821-6-git-send-email-js...@redhat.com --- tests/ide-test.c | 23 +-- tests/libqos/libqos.c | 22 ++

[Qemu-devel] [PULL 06/10] libqtest: add qmp_eventwait

2015-04-28 Thread John Snow
Allow the user to poll until a desired interrupt occurs. Signed-off-by: John Snow js...@redhat.com Message-id: 1426018503-821-4-git-send-email-js...@redhat.com --- tests/ide-test.c | 11 +-- tests/libqtest.c | 16 tests/libqtest.h | 20 3 files

[Qemu-devel] [PULL 07/10] libqtest: add qmp_async

2015-04-28 Thread John Snow
Add qmp_async, which lets us send QMP commands asynchronously. This is useful when we want to send commands that will trigger event responses, but we don't know in what order to expect them. Sometimes the event responses may arrive even before the command confirmation will show up, so it is

Re: [Qemu-devel] [REBASE PATCH v5 2/2] spapr: override default ram size to 1GB

2015-04-28 Thread David Gibson
On Tue, Apr 28, 2015 at 01:32:15PM +0200, Thomas Huth wrote: On Tue, 28 Apr 2015 12:23:26 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com Reviewed-by: Igor Mammedov imamm...@redhat.com --- hw/ppc/spapr.c | 1 + 1

Re: [Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-28 Thread David Gibson
On Tue, Apr 28, 2015 at 01:30:29PM +0200, Thomas Huth wrote: On Tue, 28 Apr 2015 12:23:25 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: [snip] Looks good to me. Reviewed-by: Thomas Huth th...@redhat.com Same here, Reviewed-by: David Gibson da...@gibson.dropbear.id.au -- David

Re: [Qemu-devel] [PATCH v8 14/16] pci: make pci_bar useable outside pci.c

2015-04-28 Thread David Gibson
On Tue, Apr 28, 2015 at 10:37:08AM +0200, Michael S. Tsirkin wrote: On Tue, Apr 28, 2015 at 05:31:03PM +1000, David Gibson wrote: On Wed, Apr 22, 2015 at 01:28:18AM -0500, Michael Roth wrote: We need to work with PCI BARs to generate OF properties during PCI hotplug for sPAPR guests.

Re: [Qemu-devel] [PATCH qemu v2] qemu-options: Add documentation about PPC64's -cpu compat option

2015-04-28 Thread David Gibson
On Tue, Apr 28, 2015 at 05:25:37PM +1000, Alexey Kardashevskiy wrote: On 04/10/2015 12:16 PM, David Gibson wrote: On Wed, Apr 08, 2015 at 07:33:21PM +1000, Alexey Kardashevskiy wrote: Since 8dfa3a5e target-ppc: Add compat CPU option (which was a part of client-architecture-support patchset)

Re: [Qemu-devel] [PULL 00/22] Memory, TCG, NBD, build system changes for 2015-04-27

2015-04-28 Thread Fam Zheng
On Tue, 04/28 16:54, Peter Maydell wrote: On 28 April 2015 at 15:40, Paolo Bonzini pbonz...@redhat.com wrote: The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: Open 2.4 development tree (2015-04-25 22:05:07 +0100) are available in the git repository at:

[Qemu-devel] [PULL 04/10] qtest/ahci: Add simple flush test

2015-04-28 Thread John Snow
Signed-off-by: John Snow js...@redhat.com Message-id: 1426018503-821-2-git-send-email-js...@redhat.com --- tests/ahci-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 6686242..4a5c788 100644 ---

[Qemu-devel] [PULL 00/10] Ide patches

2015-04-28 Thread John Snow
The following changes since commit a9392bc93c8615ad1983047e9f91ee3fa8aae75f: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2015-04-28 16:55:03 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to

Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

2015-04-28 Thread Cornelia Huck
On Tue, 28 Apr 2015 12:55:40 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 12:40:07PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 10:16:04 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 10:04:15AM +0200, Cornelia Huck wrote: On

Re: [Qemu-devel] [PATCH v6 28/36] qapi: Prefer 'struct' over 'type' in generator

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Referring to type as both a meta-type (built-in, enum, union, alternte, or struct) and a specific type (the name that the schema uses for declaring structs) is confusing. The confusion is only made worse by the fact that the generator mostly already

[Qemu-devel] [PATCH 6/7] target-mips: remove invalid comments in translate_init.c

2015-04-28 Thread Leon Alrae
Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/translate_init.c | 9 - 1 file changed, 9 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index 8e088c9..af6fb7a 100644 --- a/target-mips/translate_init.c +++

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Cornelia Huck
On Tue, 28 Apr 2015 14:16:40 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 28 April 2015 at 14:13, Michael S. Tsirkin m...@redhat.com wrote: The patches look correct to me too, but I want s390 cleaned up so it does not include COMMON_FEATURES in 100 places, and I prefer merging it

Re: [Qemu-devel] [PATCH 09/27] block/parallels: _co_writev callback for Parallels format

2015-04-28 Thread Roman Kagan
On Tue, Apr 28, 2015 at 10:46:42AM +0300, Denis V. Lunev wrote: Support write on Parallels images. The code is almost the same as one in the previous patch implemented scatter-gather IO for read. Signed-off-by: Denis V. Lunev d...@openvz.org CC: Roman Kagan rka...@parallels.com CC: Kevin

Re: [Qemu-devel] [PATCH v6 24/36] qapi: More rigourous checking of types

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Now that we know every expression is valid with regards to its keys, we can add further tests that those keys refer to valid types. With this patch, all uses of a type (the 'data': of command, type, union, alternate, and event; the 'returns': of command;

Re: [Qemu-devel] [REBASE PATCH v5 1/2] machine: add default_ram_size to machine class

2015-04-28 Thread Thomas Huth
On Tue, 28 Apr 2015 12:23:25 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Machines types can have different requirement for default ram size. Introduce a member in the machine class and set the current default_ram_size to 128MB. For QEMUMachine types override the value during

[Qemu-devel] [PATCH v4 2/2] virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi

2015-04-28 Thread shannon . zhao
From: Shannon Zhao shannon.z...@linaro.org So far virtio-scsi-device can't expose host features to guest while using virtio-mmio because it doesn't set DEFINE_VIRTIO_SCSI_FEATURES on backend or transport. The host features belong to the backends while virtio-scsi-pci, virtio-scsi-s390 and

Re: [Qemu-devel] [PATCH 3/3] vhost-user: remove superfluous '\n' around error_report()

2015-04-28 Thread Andreas Färber
Am 28.04.2015 um 11:11 schrieb arei.gong...@huawei.com: From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/virtio/vhost-user.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/virtio/vhost-user.c

[Qemu-devel] [PATCH 1/7] target-mips: extend selected CP0 registers to 64-bits in MIPS32

2015-04-28 Thread Leon Alrae
Extend EntryLo0, EntryLo1, LLAddr and TagLo from 32 to 64 bits in MIPS32. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/cpu.h | 14 +++--- target-mips/machine.c | 20 ++-- target-mips/op_helper.c | 8 target-mips/translate.c | 5 +++--

[Qemu-devel] [PATCH 3/7] target-mips: add CP0.PageGrain.ELPA support

2015-04-28 Thread Leon Alrae
CP0.PageGrain.ELPA enables support for large physical addresses. This field is encoded as follows: 0: Large physical address support is disabled. 1: Large physical address support is enabled. If this bit is a 1, the following changes occur to coprocessor 0 registers: - The PFNX field of the

[Qemu-devel] [PATCH 0/7] target-mips: add support for large physical addresses

2015-04-28 Thread Leon Alrae
Hi, This patchset adds large physical address support in MIPS, specifically: * eXtended Physical Addressing (XPA) * Large Physical Addressing (LPA) XPA and LPA are enabled in MIPS32R5-generic and MIPS64R6-generic cores respectively. The series applies on top of the Config5.FRE patches.

Re: [Qemu-devel] [PATCH v5 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-04-28 Thread Shannon Zhao
On 2015/4/28 17:54, Igor Mammedov wrote: On Tue, 28 Apr 2015 17:06:00 +0800 Shannon Zhao zhaoshengl...@huawei.com wrote: On 2015/4/28 16:47, Michael S. Tsirkin wrote: On Tue, Apr 28, 2015 at 10:42:25AM +0200, Igor Mammedov wrote: On Wed, 15 Apr 2015 21:25:08 +0800 Shannon Zhao

Re: [Qemu-devel] [PATCH v6 37/36] qapi: Support (subset of) \u escapes in strings

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: The handling of \ inside QAPI strings was less than ideal, and really only worked JSON's \/, \\, \, and our extension of \' (an obvious extension, when you realize we use '' instead of for strings). For other things, like '\n', it resulted in a literal

[Qemu-devel] [PATCH v4 0/4] block: move I/O request processing to block/io.c

2015-04-28 Thread Stefan Hajnoczi
Note: This series is based on my block-next branch: https://github.com/stefanha/qemu.git block-next v4: * Extracted two patches that change block.c code, now making the final block/io.c patch purely code movement [Eric] * Added missing block/io.c file (oops!) [Eric] This series splits

Re: [Qemu-devel] [RFC PATCH 2/2] spapr: populate ibm,loc-code

2015-04-28 Thread Nikunj A Dadhania
David Gibson da...@gibson.dropbear.id.au writes: On Wed, Apr 22, 2015 at 04:05:34PM +0530, Nikunj A Dadhania wrote: Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value

Re: [Qemu-devel] [PULL 0/1] MAINTAINERS update: NUMA

2015-04-28 Thread Peter Maydell
On 27 April 2015 at 19:02, Eduardo Habkost ehabk...@redhat.com wrote: The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9: Open 2.4 development tree (2015-04-25 22:05:07 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git

Re: [Qemu-devel] [PATCH v6 25/36] qapi: Require valid names

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Previous commits demonstrated that the generator overlooked various bad naming situations: - types, commands, and events need a valid name - enum members must be valid names, when combined with prefix - union and alternate branches cannot be marked

Re: [Qemu-devel] [PATCH 1/3] target-mips: fix memory leak

2015-04-28 Thread Leon Alrae
On 28/04/2015 10:11, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Coveristy reports that variable prom_buf/params_buf going out of scope leaks the storage it points to. Cc: Aurelien Jarno aurel...@aurel32.net Cc: Leon Alrae leon.al...@imgtec.com Signed-off-by:

Re: [Qemu-devel] [PATCH 2/3] qdev: check callback takes Object **target as third argument

2015-04-28 Thread Paolo Bonzini
On 28/04/2015 11:18, Eric Auger wrote: Check callback now takes as third argument an Object **. In object_set_link_property, we pass the property child as argument. We also assign the *child before the check call so that enhanced check can be performed in the callback. In case the check

[Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread shannon . zhao
From: Shannon Zhao shannon.z...@linaro.org The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390, and virtio-*-ccw already have the ability to forward property accesses to the

Re: [Qemu-devel] [PATCH 1/1] apic_common: improve readability of apic_reset_common

2015-04-28 Thread Andreas Färber
Am 07.04.2015 um 15:53 schrieb Denis V. Lunev: Replace call of cpu_is_bsp(s-cpu) which really returns !!(s-apicbase MSR_IA32_APICBASE_BSP) with directly collected value. Due to this the tracepoint trace_cpu_get_apic_base((uint64_t)s-apicbase); will not be hit anymore in

[Qemu-devel] [PATCH 5/7] target-mips: correct MFC0 for CP0.EntryLo in MIPS64

2015-04-28 Thread Leon Alrae
Since PFNX is now supported the bits 31:30 have to be cleared. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/translate.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index f95b655..a41fc98

[Qemu-devel] [PATCH 7/7] target-mips: enable XPA and LPA features

2015-04-28 Thread Leon Alrae
Enable XPA in MIPS32R5-generic and LPA in MIPS64R6-generic. Signed-off-by: Leon Alrae leon.al...@imgtec.com --- target-mips/translate_init.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the performance is low. The virtio-*-pci, virtio-*-s390,

Re: [Qemu-devel] KVM call agenda for 2015-04-24

2015-04-28 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. As there are no topics for Today call, call got cancelled. Thanks, Juan. Call details: By popular demand, a google calendar public entry with it

Re: [Qemu-devel] [PATCH V7 08/16] virtio: introduce bus specific queue limit

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 01:39:51PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 12:55:40 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 12:40:07PM +0200, Cornelia Huck wrote: On Tue, 28 Apr 2015 10:16:04 +0200 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH] vmdk: Widen before shifting 32 bit header field

2015-04-28 Thread Kevin Wolf
Am 27.04.2015 um 19:07 hat John Snow geschrieben: On 04/27/2015 10:23 AM, Fam Zheng wrote: Coverity spotted this. The field is 32 bits, but if it's possible to overflow in 32 bit left shift. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Cornelia Huck
On Tue, 28 Apr 2015 15:05:47 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 01:52:40PM +0100, Peter Maydell wrote: On 28 April 2015 at 13:48, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: From:

[Qemu-devel] [PATCH v4 1/4] block: replace bdrv_states iteration with bdrv_next()

2015-04-28 Thread Stefan Hajnoczi
The bdrv_states list is a static variable in block.c. bdrv_drain_all() and bdrv_flush_all() use this variable to iterate over all drives. The next patch will move bdrv_drain_all() and bdrv_flush_all() out of block.c so it's necessary to switch to the public bdrv_next() interface. Reviewed-by:

Re: [Qemu-devel] [RFC PATCH 1/2] spapr: enumerate and add PCI device tree

2015-04-28 Thread Nikunj A Dadhania
David Gibson da...@gibson.dropbear.id.au writes: On Wed, Apr 22, 2015 at 04:05:33PM +0530, Nikunj A Dadhania wrote: All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the

Re: [Qemu-devel] [PATCH] pci: Merge pci_nic_init() into pci_nic_init_nofail()

2015-04-28 Thread Paolo Bonzini
On 28/04/2015 12:50, Thomas Huth wrote: The error reporting in pci_nic_init() is quite erratic: Some errors are printed directly with error_report(), and some are passed back to the caller pci_nic_init_nofail() via an Error pointer. Since pci_nic_init() is only used by pci_nic_init_nofail(),

Re: [Qemu-devel] [PATCH v6 30/36] qapi: Use 'struct' instead of 'type' in schema

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Referring to type as both a meta-type (built-in, enum, union, alternte, or struct) and a specific type (the name that the schema uses for declaring structs) is confusing. Finish up the conversion to using struct in qapi schema by coverting all users,

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 02:06:35PM +0100, Peter Maydell wrote: On 28 April 2015 at 12:51, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org The reason to do this is that the virtio-net-device can't expose host features to guest while using virtio-mmio. So the

[Qemu-devel] [PATCH v4 1/2] virtio-net: Move DEFINE_VIRTIO_NET_FEATURES to virtio-net

2015-04-28 Thread shannon . zhao
From: Shannon Zhao shannon.z...@linaro.org So far virtio-net-device can't expose host features to guest while using virtio-mmio because it doesn't set DEFINE_VIRTIO_NET_FEATURES on backend or transport. So the performance is low. The host features belong to the backend while virtio-net-pci,

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Peter Maydell
On 28 April 2015 at 13:48, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Here we move the host features to backends, involving DEFINE_VIRTIO_NET_FEATURES,

Re: [Qemu-devel] [PATCH v6 32/36] qapi: Drop tests for inline nested structs

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: A future patch will be using a 'name':{dictionary} entry in the QAPI schema to specify a default value for an optional argument; but existing use of inline nested structs conflicts with that goal. More precisely, a definition in the QAPI schema associates

Re: [Qemu-devel] [PATCH v6 38/36] qapi: Check for member name conflicts with a base class

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Our type inheritance for both 'struct' and for flat 'union' merges key/value pairs from the base class with those from the type in question. Although the C code currently boxes things so that there is a distinction between which member is referred to, the

Re: [Qemu-devel] [PATCH v6 31/36] qapi: Merge UserDefTwo and UserDefNested in tests

2015-04-28 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: In the testsuite, UserDefTwo and UserDefNested were identical structs other than the member names. Reduce code duplication by having just one type, and choose names that also favor reuse. This will also make it easier for a later patch to get rid of

Re: [Qemu-devel] [PULL v2 0/6] X86 patches

2015-04-28 Thread Peter Maydell
On 27 April 2015 at 19:45, Eduardo Habkost ehabk...@redhat.com wrote: Changes in v2: * Rebase to 0d81cdddaa40a1988b24657aeac19959cfad0fde * Rewrote commit message of 'target-i386: Make level and xlevel properties static', to mention it fixes a bug (missing check for realized device)

Re: [Qemu-devel] [PATCH v4 0/2] virtio: Move host features to backends

2015-04-28 Thread Michael S. Tsirkin
On Tue, Apr 28, 2015 at 01:52:40PM +0100, Peter Maydell wrote: On 28 April 2015 at 13:48, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 28, 2015 at 07:51:11PM +0800, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Here we move the host features to backends,

Re: [Qemu-devel] [PATCH v6 07/36] qapi: Better error messages for bad enums

2015-04-28 Thread Eric Blake
On 04/04/2015 10:07 PM, Eric Blake wrote: The previous commit demonstrated that the generator had several flaws with less-than-perfect enums: +++ b/tests/qapi-schema/enum-max-member.json @@ -1,3 +1,3 @@ -# FIXME: we should either reject user-supplied 'max', or munge the implicit -# max

[Qemu-devel] [PULL 09/10] qtest/ahci: add flush retry test

2015-04-28 Thread John Snow
Signed-off-by: John Snow js...@redhat.com Message-id: 1426018503-821-7-git-send-email-js...@redhat.com --- tests/ahci-test.c | 44 1 file changed, 44 insertions(+) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index cd7d2ce..7c23bb2 100644 ---

[Qemu-devel] [PULL 19/22] Makefile.target: prepend $libs_softmmu to $LIBS

2015-04-28 Thread Paolo Bonzini
From: Wei Liu wei.l...@citrix.com I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references functions in libm, so the original ordering makes linking fail. This fix is to reorder

  1   2   3   4   >