From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Andreas Färber
Signed-off-by: Michael Tokarev
---
hw/virtio/vhost-user.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index aefe0bb..e7ab829 100644
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Michael Tokarev
---
ui/input-legacy.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/ui/input-legacy.c b/ui/input-legacy.c
index 2d4ca19..3e9bb38 100644
--- a/ui/input-legacy.c
+++ b/ui/input-legacy.c
@@ -57,8 +57,6 @@ s
From: Peter Crosthwaite
Theres no difference in defconfig. Going forward microblazeel should
superset microblaze so use an include.
Signed-off-by: Peter Crosthwaite
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Michael Tokarev
---
default-configs/microblazeel-softmmu.mak | 10 +-
1 f
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Michael Tokarev
---
cpus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpus.c b/cpus.c
index e6dcae3..62d157a 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1016,7 +1016,7 @@ static void *qemu_tcg_cpu_thread_fn(v
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Michael Tokarev
---
linux-user/elfload.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 399c021..0ba9706 100644
--- a/linux-user/elfload.c
+++ b/linux-us
After removal of EXCP_NMI there's a gap in EXCP_*
numbering. Let's remove it.
Signed-off-by: Michael Tokarev
Reviewed-by: Edgar E. Iglesias
---
target-microblaze/cpu.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.
Subject: s|bus/bridge/|bus/bridge|
Am 30.04.2015 um 03:33 schrieb Zhu Guihua:
> From: Chen Fan
>
> ICC bus was invented only to provide hotplug capability to
> CPU and APIC because at the time being hotplug was available only for
> BUS attached devices.
>
> Now this patch is to drop ICC bus imp
From: Peter Crosthwaite
This function is not used by anything. Remove.
Signed-off-by: Peter Crosthwaite
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Michael Tokarev
---
target-microblaze/cpu.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/target-microblaze/cpu.h b/target-microblaz
From: Peter Crosthwaite
No code uses the cpu_pc_from_tb() function. Delete from tricore and
arm which each provide an unused implementation. Update the comment
in tcg.h to reflect that this is obsoleted by synchronize_from_tb.
Signed-off-by: Peter Crosthwaite
Signed-off-by: Michael Tokarev
---
From: Thomas Huth
Delete set_usb_string(), usb_ep_get_ifnum(), usb_ep_get_max_packet_size()
usb_ep_get_max_streams() and usb_ep_set_pipeline() since they are
not used anymore.
Signed-off-by: Thomas Huth
Reviewed-by: Gerd Hoffmann
Signed-off-by: Michael Tokarev
---
hw/usb/core.c| 41 -
From: Gonglei
When not assign a -dtb argument, the variable dtb_filename
storage returned from qemu_find_file(), which should be freed
after use. Alternatively we define a local variable filename,
with 'char *' type, free after use.
Signed-off-by: Gonglei
Reviewed-by: Peter Crosthwaite
Reviewe
From: Peter Crosthwaite
This is not implemented or used.
Signed-off-by: Peter Crosthwaite
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Michael Tokarev
---
target-microblaze/mmu.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/target-microblaze/mmu.h b/target-microblaze/mmu.h
index 3f74d
From: Thomas Huth
The functions ringbuf_read_completion() and monitor_get_rs()
are not used anywhere anymore, so let's remove them.
Signed-off-by: Thomas Huth
Cc: Luiz Capitulino
Signed-off-by: Michael Tokarev
---
hmp.h | 1 -
include/monitor/monitor.h | 1 -
monitor.c
Am 30.04.2015 um 03:33 schrieb Zhu Guihua:
> Use DEVICE() casts to avoid accessing ICCDevice's qdev field
> directly.
>
> Signed-off-by: Zhu Guihua
> ---
> hw/intc/apic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/intc/apic.c b/hw/intc/apic.c
> index 0f97b
From: Peter Crosthwaite
These CP accessor function prototypes are unused. Remove them.
Signed-off-by: Peter Crosthwaite
Signed-off-by: Michael Tokarev
---
target-arm/cpu.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index d63d9b2..8df0b6a 100644
Signed-off-by: Michael Tokarev
Reviewed-by: Eric Blake
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 319d971..ec356f6 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3106,7 +3106,7 @@ executed often has litt
From: Gonglei
Coveristy reports that variable prom_buf/params_buf going
out of scope leaks the storage it points to.
Cc: Aurelien Jarno
Cc: Leon Alrae
Signed-off-by: Gonglei
Reviewed-by: Leon Alrae
Signed-off-by: Michael Tokarev
---
hw/mips/mips_fulong2e.c | 1 +
hw/mips/mips_malta.c|
From: Stefan Berger
Cast 64bit variables to int when used in DPRINTF. They only contain
32bit of data.
Signed-off-by: Stefan Berger
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
hw/tpm/tpm_tis.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/tpm/t
From: Thomas Huth
valgrind complains here about uninitialized bytes with the following message:
==17814== Syscall param ioctl(generic) points to uninitialised byte(s)
==17814==at 0x466A780: ioctl (in /usr/lib64/power8/libc-2.17.so)
==17814==by 0x100735B7: kvm_vm_ioctl (kvm-all.c:1920)
==
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Michael Tokarev
---
dma-helpers.c | 1 -
hw/acpi/pcihp.c | 1 -
hw/i386/acpi-build.c | 1 -
include/hw/i386/ich9.h| 1 -
include/hw/pci-host/q35.h | 1 -
5 files changed, 5 deletions(-)
diff --git a
From: Chih-Min Chao
Signed-off-by: Chih-Min Chao
Reviewed-by: Gerd Hoffmann
Signed-off-by: Michael Tokarev
---
hw/display/qxl.c | 2 +-
ui/spice-display.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index b6d65b9..0cd314c 10
From: Thomas Huth
The function is not used anymore and thus can be deleted.
Signed-off-by: Thomas Huth
Cc: Dmitry Fleytman
Signed-off-by: Michael Tokarev
---
hw/net/vmxnet_rx_pkt.c | 7 ---
hw/net/vmxnet_rx_pkt.h | 9 -
2 files changed, 16 deletions(-)
diff --git a/hw/net/vmxnet
From: Thomas Huth
Delete the unused functions qemu_signalfd_available(),
qemu_send_full() and qemu_recv_full().
Signed-off-by: Thomas Huth
Signed-off-by: Michael Tokarev
---
include/qemu-common.h | 4 ---
include/qemu/compatfd.h | 1 -
util/compatfd.c | 19 --
util/osd
From: Peter Crosthwaite
This function is unused. Remove.
Signed-off-by: Peter Crosthwaite
Signed-off-by: Michael Tokarev
---
target-microblaze/cpu.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h
index d389597..4ea04ac 100644
--- a/ta
From: Peter Crosthwaite
tricore was out of alphabetical order in the target list. Fix.
Signed-off-by: Peter Crosthwaite
Acked-by: Bastian Koppelmann
Signed-off-by: Michael Tokarev
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
inde
From: Peter Crosthwaite
This enum is not used by anything. Remove.
Signed-off-by: Peter Crosthwaite
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Michael Tokarev
---
target-microblaze/cpu.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/target-microblaze/cpu.h b/target-microblaze/c
From: Chih-Min Chao
don't mix tab and space. The rule is 4 spaces
Signed-off-by: Chih-Min Chao
Reviewed-by: Gerd Hoffmann
Signed-off-by: Michael Tokarev
---
include/qemu/bitops.h | 61 ++-
1 file changed, 31 insertions(+), 30 deletions(-)
From: Stefan Berger
Modify DPRINTF to always enable -Wformat checking.
Signed-off-by: Stefan Berger
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
hw/tpm/tpm_passthrough.c | 16 +++-
hw/tpm/tpm_tis.c | 14 ++
2 files changed, 13 insertions(+), 17 d
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Michael Tokarev
---
util/qemu-config.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/util/qemu-config.c b/util/qemu-config.c
index a393a3d..30d6dcf 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -3,10 +3,8 @@
From: Chih-Min Chao
Signed-off-by: Chih-Min Chao
Reviewed-by: Gerd Hoffmann
Signed-off-by: Michael Tokarev
---
ui/vnc-auth-vencrypt.c | 4 ++--
ui/vnc-tls.c | 10 +-
ui/vnc-ws.c| 4 ++--
ui/vnc.c | 2 +-
4 files changed, 10 insertions(+), 10 dele
Hello.
This is the first pull request for trivial-patches tree since 2.3 has
been released. During the freeze many patches has been accumulated,
and even more has been received after 2.4 developmnent has been opened.
So here we have 42 trivial patches, which is kinda too much, but that's
what we
From: Jan Kiszka
The subtle difference between "property not found" and "property not
set" is already confusing enough.
Signed-off-by: Jan Kiszka
Reviewed-by: Peter Crosthwaite
Signed-off-by: Michael Tokarev
---
backends/hostmem-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
There's a bug open in qemu bugtracker for several years
already, https://bugs.launchpad.net/qemu/+bug/1038136 .
The solution appears to be trivial (see also some background
at http://blog.nielshorn.net/2011/03/qemu-and-brazilian-keyboards/ ),
but the problem is definitely still here.
Maybe it's a
Hi Paolo,
Paolo Bonzini writes:
> On 29/04/2015 11:06, Nikunj A Dadhania wrote:
>> > so David can push both patches.
>> >
>> > But isn't 1G a bit too much? At least on x86 you can easily boot with
>> > 512M.
>>
>> I understood this number as not the _minimum memory_ to boot the
>> VM. And thi
On Wed, Apr 22, 2015 at 01:28:04AM -0500, Michael Roth wrote:
> These patches are based on spapr-next, and can also be obtained
> from:
Thanks Michael.
I've made a few small conflict fixes and merged this into spapr-next.
Could you please:
a) Pull the new spapr-next and test that your code st
On 04/30/2015 05:01 AM, Thomas Huth wrote:
hw_error() is designed for printing CPU-related error messages
(e.g. it also prints a full CPU register dump). For error messages
that are not directly related to CPU problems, a function like
error_report() should be used instead.
Signed-off-by: Thomas
On 04/30/2015 01:32 AM, Alex Williamson wrote:
On Wed, 2015-04-29 at 16:48 +0800, Chen Fan wrote:
add host secondary bus reset for vfio when AER occurs, if reset failed,
we should stop vm.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 151 +-
On 04/02/2015 01:31 PM, Eric Blake wrote:
> We document that in QMP, the client may send any json-value
> for the optional "id" key, and then return that same value
> on reply (both success and failures, insofar as the failure
> happened after parsing the id). [Note that the output may
> not be id
On Thu, 2015-04-30 at 11:07 +0800, Chen Fan wrote:
> On 04/30/2015 01:32 AM, Alex Williamson wrote:
> > On Wed, 2015-04-29 at 16:48 +0800, Chen Fan wrote:
> >> add host secondary bus reset for vfio when AER occurs, if reset failed,
> >> we should stop vm.
> >>
> >> Signed-off-by: Chen Fan
> >> ---
On Wed, Apr 29, 2015 at 09:01:06PM +0200, Thomas Huth wrote:
> While loading alternate slof.bin images with the "-bios" option
> of qemu-softmmu-ppc64, I noticed that the error message is
> wrong when trying to load an non-existing file. Also, the
> error message is printed with hw_error() which re
On Wed, Apr 29, 2015 at 01:11:52AM -0500, Michael Roth wrote:
> Quoting David Gibson (2015-04-28 02:25:51)
> > On Wed, Apr 22, 2015 at 01:28:15AM -0500, Michael Roth wrote:
> > > Initially this is identifical to pseries-2.3. Subsequent patches will
> > > use it to mask new 2.4 features by default.
From: Chen Fan
ICC bus was invented only to provide hotplug capability to
CPU and APIC because at the time being hotplug was available only for
BUS attached devices.
Now this patch is to drop ICC bus impl, and switch to bus-less
CPU+APIC hotplug, handling them in the same manner as pc-dimm.
and
From: Chen Fan
Due to local apic address is in view of CPU's address space,
so able to move apic mapping to each apic realizefn.
Signed-off-by: Chen Fan
Signed-off-by: Zhu Guihua
---
exec.c| 5 +
hw/i386/pc.c | 7 ---
hw/intc/apic_common.c | 14 -
Use DEVICE() casts to avoid accessing ICCDevice's qdev field
directly.
Signed-off-by: Zhu Guihua
---
hw/intc/apic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/intc/apic.c b/hw/intc/apic.c
index 0f97b47..00ae0ec 100644
--- a/hw/intc/apic.c
+++ b/hw/intc/apic.c
@@
ICC bus impl has been droped, so all icc related files are not useful
any more; delete them.
Signed-off-by: Zhu Guihua
---
default-configs/i386-softmmu.mak | 1 -
default-configs/x86_64-softmmu.mak | 1 -
hw/cpu/Makefile.objs | 1 -
hw/cpu/icc_bus.c | 118
ICC Bus was used for providing a hotpluggable bus for APIC and CPU,
but now we use HotplugHandler to make hotplug. So ICC Bus is
unnecessary.
This code has passed the new pc-cpu-test.
And I have tested with kvm along with kernel_irqchip=on/off,
it works fine.
This patch series is rebased on the l
> * Li, Liang Z (liang.z...@intel.com) wrote:
> > Hi David,
> >
> > I have tired your v6 postcopy patches and found it doesn't work. When
> > I tried to start the postcopy in live migration, some errors were printed. I
> just did the following things:
> >
> > On destination side, started the qemu l
This is a feature that should be very easy to add on top of the existing
incremental feature, since it's just a difference in how the bitmap is
treated:
Incremental
- Links to the last incremental (managed by libvirt)
- Clears the bitmap after creation
Differential:
- Links to the last full ba
On Wed, Apr 22, 2015 at 07:38:27PM +1000, Alexey Kardashevskiy wrote:
> On 04/22/2015 03:53 PM, David Gibson wrote:
> >On Sat, Apr 11, 2015 at 01:24:36AM +1000, Alexey Kardashevskiy wrote:
> >>This makes use of the new "memory registering" feature. The idea is
> >>to provide the userspace ability t
From: Markus Armbruster
QTYPE_NONE is a sentinel value. No QObject has this type code.
Document it properly.
Fix dump_qobject() to abort() on QTYPE_NONE, just like for any other
invalid type code.
Fix to_json() to abort() on all invalid type codes, not just
QTYPE_MAX.
Clean up Property member
We document that in QMP, the client may send any json-value
for the optional "id" key, and then return that same value
on reply (both success and failures, insofar as the failure
happened after parsing the id). [Note that the output may
not be identical to the input, as whitespace may change and
s
Here's my attempt to merge the best points of Markus' approach [1]
(patches 16-18 of that series - benefit of smaller patches and fewer
malloc calls) and my approach [2] (benefit of a testsuite addition
and more detailed commit messages), while fixing the typos that both
of us had in v1.
[1]https:
From: Markus Armbruster
I'm going to fix the JSON parser to recognize null. The obvious
representation of JSON null as (QObject *)NULL doesn't work, because
the parser already uses it as an error value. Perhaps we should
change it to free NULL for null, but that's more than I can do right
now.
On Wed, Apr 29, 2015 at 09:49:53PM +0200, Christian Borntraeger wrote:
> Am 29.04.2015 um 20:35 schrieb Michael S. Tsirkin:
> > On Wed, Apr 29, 2015 at 04:43:19PM +0200, Christian Borntraeger wrote:
> >> Am 29.04.2015 um 12:32 schrieb Michael S. Tsirkin:
> >>> On Wed, Apr 29, 2015 at 10:52:15AM +02
On 04/29/2015 03:25 PM, Eric Blake wrote:
On 04/29/2015 01:14 PM, John Snow wrote:
This includes support for [] expressions, single-quotes in
QMP expressions (which is not strictly a part of JSON), and
the ability to use "True", "False" and "None" literals instead
of JSON's equivalent true, fa
Am 29.04.2015 um 20:35 schrieb Michael S. Tsirkin:
> On Wed, Apr 29, 2015 at 04:43:19PM +0200, Christian Borntraeger wrote:
>> Am 29.04.2015 um 12:32 schrieb Michael S. Tsirkin:
>>> On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote:
On Wed, 29 Apr 2015 10:17:55 +0200
Christian
On 04/29/2015 01:14 PM, John Snow wrote:
> Add a verbose flag that shows the QMP command that was
> constructed, to allow for later copy/pasting, reference,
> debugging, etc.
>
> The QMP is converted from a Python literal to JSON first,
> to ensure that it is viable input to the actual QMP parser.
On 04/29/2015 01:14 PM, John Snow wrote:
> Add a special processing mode to craft transactions.
>
> By entering "transaction(" the shell will enter a special
> mode where each subsequent command will be saved as a transaction
> instead of executed as an individual command.
>
> The transaction can
On Wed, 2015-04-29 at 15:51 +0100, Eric Auger wrote:
> Minimal VFIO platform implementation supporting register space
> user mapping but not IRQ assignment.
>
> Signed-off-by: Kim Phillips
> Signed-off-by: Eric Auger
>
> ---
> v13 -> v14:
> - fix ENAMETOOLONG error path sign
>
> v12 -> v13:
>
Since we route hotplugged PHBs to their DR connector using their
PHB.index value, we align the number of DR connectors with the
maximum index value: SPAPR_PCI_MAX_INDEX.
Signed-off-by: Michael Roth
---
hw/ppc/spapr.c | 28
1 file changed, 28 insertions(+)
diff --git
On 04/29/2015 01:14 PM, John Snow wrote:
> This includes support for [] expressions, single-quotes in
> QMP expressions (which is not strictly a part of JSON), and
> the ability to use "True", "False" and "None" literals instead
> of JSON's equivalent true, false, and null literals.
>
> qmp-shell
To support PHB hotplug we need to clean up lingering references,
memory, child properties, etc. prior to the PHB object being
finalized. Generally this will be called as a result of calling
object_unref() on the PHB object, which in turn would normally
be called as the result of an unplug() operati
Prior to this patch 'index' is purely a shorthand for specifying
MMIO windows, BUIDs, and other configuration values for a PHB.
With the addition of PHB hotplug, we have a static number of DRCs
that can be used to handle hotplug/unplug operations on our PHBs,
and need a consistent way to map PHBs
Introduce an sPAPRMachineClass sub-class of MachineClass to
handle sPAPR-specific machine configuration properties.
The 'dr_phb_enabled' field of that class can be set as
part of machine-specific init code, and is then propagated
to sPAPREnvironment to conditionally enable creation of DRC
objects
DRC objects attach themselves to an owner as a child
property. unref afterward to allow them to be finalized
when their owner is finalized.
Signed-off-by: Michael Roth
---
hw/ppc/spapr_drc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 48bf193
Hotplugging PHBs is a machine-level operation, but PHBs reside on the
main system bus, so we register spapr machine as the handler for the
main system bus. The entry point for plug/unplug is shared by all
such machine-level hotplug operations (memory, CPU, PHB, etc), and
from there we branch off to
This adds cleanup counterparts to pci_register_bus(),
pci_bus_new(), and pci_bus_irqs().
These cleanup routines are needed in the case of hotpluggable
PCIHostBridge implementations. Currently we can rely on the
object_unparent()'ing of the PCIHostState recursively unparenting
and cleaning up it's
DRC objects attach themselves to an owner as a child
property. unref afterward to allow them to be finalized
when their owner is finalized.
Signed-off-by: Michael Roth
---
hw/ppc/spapr_iommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index a
Certain devices types, like memory/CPU, are now being handled using a
hotplug interface provided by a top-level MachineClass. Hotpluggable
host bridges are another such device where it makes sense to use a
machine-level hotplug handler. However, unlike those devices,
host-bridges have a parent bus
device_unparent(dev, ...) is called when a device is unparented,
either directly, or as a result of a parent device being
finalized, and handles some final cleanup for the device. Part
of this includes emiting a DEVICE_DELETED QMP event to notify
management, which includes the device's path in the
This is needed to denote a boot-time PHB as being hot-pluggable.
Signed-off-by: Michael Roth
---
hw/ppc/spapr_pci.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 66fe85f..91dfd96 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pc
From: Nathan Fontenot
This add entries to the root OF node to advertise our PHBs as being
DR-capable in accordance with PAPR specification.
Signed-off-by: Nathan Fontenot
Signed-off-by: Michael Roth
---
hw/ppc/spapr.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/ppc/spapr.c
PHB hotplug re-uses PHB device tree generation code and passes
it to a guest via RTAS. Doing this requires knowledge of where
exactly in the device tree the node describing the PHB begins.
Provide this via a new optional pointer that can be used to
store the PHB node's start offset.
Signed-off-by
This is mostly a shim patch to base more easily on CPU/MEM patches.
In that case it can most likely be dropped, otherwise it should be
squashed into actual hotplug handler implementation that will follow.
Signed-off-by: Michael Roth
---
hw/ppc/spapr.c | 24
1 file change
These patches are based on latest spapr-hotplug-pci patches, and
can also be obtained from:
https://github.com/mdroth/qemu/commits/spapr-hotplug-phb
These patches implement support for hotplug/unplug of PCI host-bridges.
The main use cases are:
- allowing for VFIO PCI hotplug for host kernels
Extend the existing EPOW event format we use for PCI
devices to emit PHB plug/unplug events.
Signed-off-by: Michael Roth
---
hw/ppc/spapr_events.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
index be82815..5d7cfac 100644
--- a/hw/ppc/spa
On 27/04/2015 19:23, Eduardo Habkost wrote:
> Also, why do we have two JSON writers in QEMU? And why do they have
> exactly the same name?
qobject/qjson.c could use qjson.c... but then qjson.c probably should be
changed 1) to not use QOM 2) to use GString instead of QString, just
like most other
Add a verbose flag that shows the QMP command that was
constructed, to allow for later copy/pasting, reference,
debugging, etc.
The QMP is converted from a Python literal to JSON first,
to ensure that it is viable input to the actual QMP parser.
As a side-effect, this JSON output will helpfully s
Refactor the qmp-shell command line processing function
into two components. This will be used to allow sub-expressions,
which will assist us in adding transactional support to qmp-shell.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
---
scripts/qmp/qmp-shell | 24 +---
1
This includes support for [] expressions, single-quotes in
QMP expressions (which is not strictly a part of JSON), and
the ability to use "True", "False" and "None" literals instead
of JSON's equivalent true, false, and null literals.
qmp-shell currently allows you to describe values as
JSON expre
The qmp-shell is a little rudimentary, but it can be hacked
to give us some transactional support without too much difficulty.
(1) Prep.
(2) Add support for serializing json arrays and
improve the robustness of QMP parsing
(3) Add a special transaction( ... ) syntax that lets users
build u
Add a special processing mode to craft transactions.
By entering "transaction(" the shell will enter a special
mode where each subsequent command will be saved as a transaction
instead of executed as an individual command.
The transaction can be submitted by entering ")" on a line by itself.
Exa
When specifying a non-existing file with the "-bios" parameter, QEMU
complained that it "could not find LPAR rtas". That's obviously a
copy-n-paste bug from the code which loads the spapr-rtas.bin, it
should complain about a missing firmware file instead.
Additionally the error message was printed
While loading alternate slof.bin images with the "-bios" option
of qemu-softmmu-ppc64, I noticed that the error message is
wrong when trying to load an non-existing file. Also, the
error message is printed with hw_error() which results in a
huge CPU register dump - something you don't expect when y
hw_error() is designed for printing CPU-related error messages
(e.g. it also prints a full CPU register dump). For error messages
that are not directly related to CPU problems, a function like
error_report() should be used instead.
Signed-off-by: Thomas Huth
---
hw/ppc/spapr.c | 12 ++--
On Wed, Apr 29, 2015 at 04:43:19PM +0200, Christian Borntraeger wrote:
> Am 29.04.2015 um 12:32 schrieb Michael S. Tsirkin:
> > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote:
> >> On Wed, 29 Apr 2015 10:17:55 +0200
> >> Christian Borntraeger wrote:
> >>
> >>> Am 28.04.2015 um 20:32
On Wed, Apr 29, 2015 at 04:33:44PM +0200, Cornelia Huck wrote:
> On Wed, 29 Apr 2015 12:32:04 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote:
>
> > > And (surprise, surprise) virtio-blk now works - but it also works when
> > > I back out t
On Wed, 2015-04-29 at 16:48 +0800, Chen Fan wrote:
> add host secondary bus reset for vfio when AER occurs, if reset failed,
> we should stop vm.
>
> Signed-off-by: Chen Fan
> ---
> hw/vfio/pci.c | 151
> +-
> 1 file changed, 138 insertion
* Li, Liang Z (liang.z...@intel.com) wrote:
> Hi David,
>
> I have tired your v6 postcopy patches and found it doesn't work. When I tried
> to start the
> postcopy in live migration, some errors were printed. I just did the
> following things:
>
> On destination side, started the qemu like thi
05.03.2015 06:05, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> When not assign a -dtb argument, the variable dtb_filename
> storage returned from qemu_find_file(), which should be freed
> after use. Alternatively we define a local variable filename,
> with 'char *' type, free after use.
Ac
On Wed, Mar 4, 2015 at 7:05 PM, wrote:
> From: Gonglei
>
> When not assign a -dtb argument, the variable dtb_filename
> storage returned from qemu_find_file(), which should be freed
> after use. Alternatively we define a local variable filename,
> with 'char *' type, free after use.
>
> Cc: Mich
On 04/29/2015 11:03 AM, Cole Robinson wrote:
> Consider this case:
>
> $ ls -ld ~/root-owned/
> drwx--x--x. 2 root root 4096 Apr 29 12:55 /home/crobinso/root-owned/
> $ ls -l ~/root-owned/foo.sock
> -rwxrwxrwx. 1 crobinso crobinso 0 Apr 29 12:55
> /home/crobinso/root-owned/foo.sock
>
> $ qemu-sy
Consider this case:
$ ls -ld ~/root-owned/
drwx--x--x. 2 root root 4096 Apr 29 12:55 /home/crobinso/root-owned/
$ ls -l ~/root-owned/foo.sock
-rwxrwxrwx. 1 crobinso crobinso 0 Apr 29 12:55
/home/crobinso/root-owned/foo.sock
$ qemu-system-x86_64 -vnc unix:~/root-owned/foo.sock
qemu-system-x86_64:
On 04/29/2015 10:37 AM, Cole Robinson wrote:
> Minor fixes for unix socket error handling, see patches for details
>
> Cole Robinson (3):
> vnc: Don't assert if opening unix socket fails
> vnc: Tweak error when init fails
> qemu-sockets: Report explicit error if unlink fails
Reviewed-by: Er
On 04/29/2015 05:06 AM, Igor Mammedov wrote:
On Wed, 22 Apr 2015 14:18:55 -0400
Stefan Berger wrote:
On 04/22/2015 03:00 AM, Igor Mammedov wrote:
On Thu, 16 Apr 2015 10:05:35 -0400
Stefan Berger wrote:
On 04/16/2015 09:35 AM, Igor Mammedov wrote:
On Wed, 15 Apr 2015 18:38:43 -0400
[...]
On 29/04/2015 17:24, Shannon Zhao wrote:
> The private qdev properties of virtio devices are only used by
> themselves. As Peter suggested and like what virtio-blk has done, we
> should move the private qdev properties into devices and don't expose
> them to avoid wrongly use.
>
> This patchset
Reproducer:
$ qemu-system-x86_64 -display vnc=unix:/root/i-cant-access-you.sock
qemu-system-x86_64: iohandler.c:60: qemu_set_fd_handler2: Assertion `fd >= 0'
failed.
Aborted (core dumped)
Signed-off-by: Cole Robinson
---
ui/vnc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/vnc.c b
Minor fixes for unix socket error handling, see patches for details
Cole Robinson (3):
vnc: Don't assert if opening unix socket fails
vnc: Tweak error when init fails
qemu-sockets: Report explicit error if unlink fails
ui/vnc.c| 5 +++--
util/qemu-sockets.c | 6 +-
2 files
Before:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC
server on `(null)': Failed to bind socket to /root/foo.sock: Permission denied
After:
qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC
server: Failed to bind socket to /root/foo.sock: Permi
It's possible via libvirt for a user to request an explicit socket path
that qemu lacks permissions to unlink, but the error that's reported
is from bind(2), 'Address already in use'
bind(2) will fail if the unix socket path already exists, so we need to
unlink first. But we should report the unli
1 - 100 of 283 matches
Mail list logo
