Eric Blake writes:
> On 04/02/2015 11:28 AM, Markus Armbruster wrote:
>> c_fun() maps '.' to '_', c_var() doesn't. Nothing prevents '.' in
>> QAPI names that get passed to c_var().
>>
>> Which QAPI names get passed to c_fun(), to c_var(), or to both is not
>> obvious. Names of command paramete
Eric Blake writes:
> On 04/02/2015 11:28 AM, Markus Armbruster wrote:
>> Mandatory option is silly, and the error handling is missing: the
>> programs crash when -i isn't supplied. Make it an argument, and check
>> it properly.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> Makefile
Eric Blake writes:
> On 04/02/2015 11:29 AM, Markus Armbruster wrote:
>> I'm going to fix the JSON parser to recognize null. The obvious
>> representation of JSON null as (QObject *)NULL doesn't work, because
>> the parser already uses it as an error value. Perhaps we should
>> change it to fre
On 2015/4/29 14:48, Michael Tokarev wrote:
> 28.04.2015 12:11, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Value from xfer->packet.ep is assigned to ep here, but that
>> stored value is not used before it is overwritten. Remove it.
>>
>> Cc: Gerd Hoffmann
>> Signed-off-by: Gonglei
>> -
Alt-gr seems to be pressed in VM, but when pressing for example AltGr +
e, then the altgr-button is released just before e is pressed. When e is
released, altgr is pressed again.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https:/
Hi Peter,
On 04/28/2015 08:21 PM, Peter Crosthwaite wrote:
> On Tue, Apr 28, 2015 at 2:18 AM, Eric Auger wrote:
>> The VFIO platform device gets connected to the platform bus
>> on a machine init done notifier. Only at that point irqfd can be
>> setup. An irq connect notifier would be helpful to d
From: Max Reitz
Reproducable with:
$ x86_64-softmmu/qemu-system-x86_64 \
-kernel $vmlinuz_of_your_choice \
-append vga=0x313 -sdl
Signed-off-by: Max Reitz
Signed-off-by: Gerd Hoffmann
---
include/ui/console.h | 5 +
ui/sdl2-2d.c | 15 +--
2 files changed, 18
perl script to transform shader programs into c include files with
static string constands containing the shader programs, so we can
easily embed them into qemu. Also some Makefile logic for them.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Max Reitz
---
Makefile | 14 +++
Helper functions to compile, link and run opengl shader programs.
Signed-off-by: Gerd Hoffmann
---
include/ui/shader.h | 9 +
ui/Makefile.objs| 5 +++
ui/shader.c | 95 +
3 files changed, 109 insertions(+)
create mode 100644
Hi,
This series adds some opengl bits and puts them into use for sdl2.
No major changes since the last post (somewhen during early 2.3
freeze). I've coded up opengl support for other UIs on top of this
and the code has seen some minor refactorings due to this. opengl
shader handling moved to i
Signed-off-by: Gerd Hoffmann
Reviewed-by: Max Reitz
---
include/ui/sdl2.h | 6 ++
ui/sdl2-2d.c | 6 --
ui/sdl2-input.c | 6 --
ui/sdl2.c | 6 --
4 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
index 51fff2e..e21
Signed-off-by: Gerd Hoffmann
Reviewed-by: Max Reitz
---
Makefile| 3 +
configure | 2 +-
include/ui/console.h| 31
include/ui/shader.h | 2 +
ui/Makefile.objs| 1 +
ui/console-gl.c | 168 +
No code uses the cpu_pc_from_tb() function. Delete from tricore and
arm which each provide an unused implementation. Update the comment
in tcg.h to reflect that this is obsoleted by synchronize_from_tb.
Signed-off-by: Peter Crosthwaite
---
target-arm/cpu.h | 9 -
target-tricore/cpu.h
Add new sdl2-gl.c file, with display
rendering functions using opengl.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Max Reitz
---
include/ui/console.h | 1 +
include/ui/sdl2.h| 11 +
ui/Makefile.objs | 3 ++
ui/sdl.c | 10 +
ui/sdl2-2d.c | 7
ui/sdl
When doing some more digging, it doesn't seem to be a QEMU issue as the
client releases altgr when pressing a key-combination.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://
The patch series creates PCI DT nodes in QEMU. The new
hotplug code needs the device node creation in Qemu. While during
boot, nodes were created in SLOF. It makes more sense to consolidate
the code to one place for better maintainability.
Based on sPAPR PCI Hotplug patches by Michael Roth
https
All the PCI enumeration and device node creation was off-loaded to
SLOF. With PCI hotplug support, code needed to be added to add device
node. This creates multiple copy of the code one in SLOF and other in
hotplug code. To unify this, the patch adds the pci device node
creation in Qemu. For backwa
Each hardware instance has a platform unique location code. The OF
device tree that describes a part of a hardware entity must include
the “ibm,loc-code” property with a value that represents the location
code for that hardware entity.
Populate ibm,loc-code.
1) PCI passthru devices need to identi
29.04.2015 10:52, Peter Crosthwaite wrote:
> No code uses the cpu_pc_from_tb() function. Delete from tricore and
> arm which each provide an unused implementation. Update the comment
> in tcg.h to reflect that this is obsoleted by synchronize_from_tb.
This one looks much better! Thank you, applie
Hi Paolo,
David Gibson writes:
> On Tue, Apr 28, 2015 at 01:30:29PM +0200, Thomas Huth wrote:
>> On Tue, 28 Apr 2015 12:23:25 +0530
>> Nikunj A Dadhania wrote:
> [snip]
>> Looks good to me.
>>
>> Reviewed-by: Thomas Huth
>
> Same here,
>
> Reviewed-by: David Gibson
Can you push this patch v
On 29/04/2015 03:53, Fam Zheng wrote:
> On Tue, 04/28 16:54, Peter Maydell wrote:
>> On 28 April 2015 at 15:40, Paolo Bonzini wrote:
>>> The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:
>>>
>>> Open 2.4 development tree (2015-04-25 22:05:07 +0100)
>>>
>>> are availa
Am 28.04.2015 um 20:32 schrieb Michael S. Tsirkin:
> On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote:
>> On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote:
>>> On Tue, Apr 28, 2015 at 03:24:19PM +0200, Cornelia Huck wrote:
On Tue, 28 Apr 2015 14:16:40 +0100
On Wed, Apr 29, 2015 at 08:40:01AM +0300, Michael Tokarev wrote:
> After removal of EXCP_NMI there's a gap in EXCP_*
> numbering. Let's remove it.
Reviewed-by: Edgar E. Iglesias
>
> Signed-off-by: Michael Tokarev
> ---
> Since I applied Peter's series already, without renumbering,
> b/c he w
On 28/04/2015 18:51, Eric Auger wrote:
> -prop->check(obj, name, new_target, &local_err);
> +object_ref(new_target);
> +*child = new_target;
> +
> +prop->check(obj, name, child, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> +*child = o
On 29/04/2015 10:14, Nikunj A Dadhania wrote:
>
> Hi Paolo,
>
> David Gibson writes:
>> On Tue, Apr 28, 2015 at 01:30:29PM +0200, Thomas Huth wrote:
>>> On Tue, 28 Apr 2015 12:23:25 +0530
>>> Nikunj A Dadhania wrote:
>> [snip]
>>> Looks good to me.
>>>
>>> Reviewed-by: Thomas Huth
>>
>> Same
The following changes since commit e1a5476354d396773e4c555f126d752d4ae58fa9:
Open 2.4 development tree (2015-04-25 22:05:07 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to d064d9f381b00538e41f14104b88a1ae85d78
From: Fam Zheng
This adds "--enable-tcmalloc" and "--disable-tcmalloc" to allow linking
to libtcmalloc from gperftools.
tcmalloc is a malloc implementation that works well with threads and is
fast, so it is good for performance.
It is disabled by default, because the MALLOC_PERTURB_ flag we use
On 04/29/2015 10:22 AM, Paolo Bonzini wrote:
>
>
> On 28/04/2015 18:51, Eric Auger wrote:
>> -prop->check(obj, name, new_target, &local_err);
>> +object_ref(new_target);
>> +*child = new_target;
>> +
>> +prop->check(obj, name, child, &local_err);
>> if (local_err) {
>>
Eric Blake writes:
> On 04/02/2015 11:29 AM, Markus Armbruster wrote:
>> Caution, rough edges.
>>
>> qapi/introspect.json defines the introspection schema. It should do
>> for uses other than QMP.
>
> That is, QGA should also be able to reuse it for introspection.
>
>> FIXME it's almost entirel
On Wed, 29 Apr 2015 11:12:04 +0800
Shannon Zhao wrote:
> On 2015/4/28 23:54, Michael S. Tsirkin wrote:
> > On Tue, Apr 28, 2015 at 05:13:10PM +0200, Igor Mammedov wrote:
> >>> Here I need to set the value of buffer to 1 or 0, we could
> >>> createbitfield, but if we want to set the value to non o
add host secondary bus reset for vfio when AER occurs, if reset failed,
we should stop vm.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 151 +-
1 file changed, 138 insertions(+), 13 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
in
pcie_aer_init was used to emulate an aer capability for pcie device,
but for vfio device, the aer config space size is mutable and is not
always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix
register required, so here we add a size argument.
Signed-off-by: Chen Fan
---
hw/pci
For vfio device, we need to propagate the aer error to
Guest OS. we use the pcie_aer_msg() to send aer error
to guest.
Signed-off-by: Chen Fan
---
hw/pci/pcie_aer.c | 2 +-
include/hw/pci/pcie_aer.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pcie_aer.c b/
For now, for vfio pci passthough devices when qemu receives
an error from host aer report, there just terminate the guest,
but usually user want to know what error occurred but stop the
guest, so this patches add aer capability support for vfio device,
and pass the error to guest, and have guest dr
For vfio pcie device, we could expose the extended capability on
PCIE bus. in order to avoid config space broken, we introduce
a copy config for parsing extended caps. and rebuild the pcie
extended config space.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 73 +
add 'aer' property to let user able to decide whether expose
the aer capability.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index cdd8f24..c306efc 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -159,6 +15
Calling pcie_aer_init to initilize aer related registers for
vfio device, then reload physical related registers to expose
device capability.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 47 ++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --gi
the function is used to get affected devices by bus reset.
so here extract it, and can used for aer soon.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 69 ---
1 file changed, 47 insertions(+), 22 deletions(-)
diff --git a/hw/vfio/pci.c b/hw
On Wed, 29 Apr 2015 10:17:55 +0200
Christian Borntraeger wrote:
> Am 28.04.2015 um 20:32 schrieb Michael S. Tsirkin:
> > On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote:
> >> On Tue, Apr 28, 2015 at 04:35:16PM +0200, Michael S. Tsirkin wrote:
> >>> On Tue, Apr 28, 2015 at 03:24
when the vfio device encounters an uncorrectable error in host,
the vfio_pci driver will signal the eventfd registered by this
vfio device, the results in the qemu eventfd handler getting
invoked.
this patch is to pass the error to guest and have the guest driver
recover from the error.
Signed-of
for piix4 chipset, we don't need to expose aer, so introduce
HW_COMPAT_2_2 to disable aercap for all lower than 2.3.
Signed-off-by: Chen Fan
---
hw/i386/pc_q35.c| 4
include/hw/compat.h | 8
2 files changed, 12 insertions(+)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
ind
when recovery AER, we always need to reset the host bus to recovery
the devices under the bus, so add pci bus callbacks to reset host bus
when vfio support AER.
Signed-off-by: Chen Fan
---
hw/pci/pci.c | 6 ++
hw/pci/pci_bridge.c | 3 +++
include/hw/pci/pci.h | 2 ++
inc
squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery.
Signed-off-by: Chen Fan
---
hw/vfio/pci.c | 75 +++
1 file changed, 44 insertions(+), 31 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index b42c2a4..060fb
On 2015/4/29 16:29, Paolo Bonzini wrote:
>
>
> On 27/04/2015 11:37, Stefan Hajnoczi wrote:
But it's only for the failover case. Quorum (or a new
block/colo.c driver or filter) is fine for normal colo
operation.
>> Perhaps this patch series should mirror the Secondary's disk to a
Am 28.04.2015 um 19:15 hat Eric Blake geschrieben:
> On 04/28/2015 09:00 AM, Kevin Wolf wrote:
> > From: Stefan Hajnoczi
> >
> > The block.c file has grown to over 6000 lines. It is time to split this
> > file so there are fewer conflicts and the code is easier to maintain.
> >
> > Extract I/O
On 18.03.15 20:10, Andrew Jones wrote:
> Introduce a new memory region flag, KVM_MEM_UNCACHED, which
> is needed by ARM. This flag informs KVM that the given memory
> region is typically mapped by the guest as uncached. KVM for
> ARM then maps that region as uncached for userspace as well,
> in o
Kevin Wolf writes:
> One question in addition to what Eric already asked:
>
> Am 02.04.2015 um 19:29 hat Markus Armbruster geschrieben:
>> +{ 'enum': 'SchemaMetaType',
>> + 'data': [ 'builtin', 'enum', 'array', 'object', 'alternate',
>> +'command', 'event' ] }
>> +
>> +{ 'type': 'Sch
Hi Paolo,
Paolo Bonzini writes:
> On 29/04/2015 10:14, Nikunj A Dadhania wrote:
>>
>> Hi Paolo,
>>
>> David Gibson writes:
>>> On Tue, Apr 28, 2015 at 01:30:29PM +0200, Thomas Huth wrote:
On Tue, 28 Apr 2015 12:23:25 +0530
Nikunj A Dadhania wrote:
>>> [snip]
Looks good to me.
On Wed, 22 Apr 2015 14:18:55 -0400
Stefan Berger wrote:
> On 04/22/2015 03:00 AM, Igor Mammedov wrote:
> > On Thu, 16 Apr 2015 10:05:35 -0400
> > Stefan Berger wrote:
> >
> >> On 04/16/2015 09:35 AM, Igor Mammedov wrote:
> >>> On Wed, 15 Apr 2015 18:38:43 -0400
[...]
> >>> Is it possible to use
On 29/04/2015 11:06, Nikunj A Dadhania wrote:
> > so David can push both patches.
> >
> > But isn't 1G a bit too much? At least on x86 you can easily boot with 512M.
>
> I understood this number as not the _minimum memory_ to boot the
> VM. And this will only come in picture when the user has n
On 27/04/2015 11:37, Stefan Hajnoczi wrote:
>>> But it's only for the failover case. Quorum (or a new
>>> block/colo.c driver or filter) is fine for normal colo
>>> operation.
> Perhaps this patch series should mirror the Secondary's disk to a
> Backup Secondary so that the system can be prot
On 29 April 2015 at 10:03, Alexander Graf wrote:
>
>
> On 18.03.15 20:10, Andrew Jones wrote:
>> Introduce a new memory region flag, KVM_MEM_UNCACHED, which
>> is needed by ARM. This flag informs KVM that the given memory
>> region is typically mapped by the guest as uncached. KVM for
>> ARM then
On 2015/4/28 21:16, Peter Maydell wrote:
> On 28 April 2015 at 14:13, Michael S. Tsirkin wrote:
>> > The patches look correct to me too, but I want s390
>> > cleaned up so it does not include COMMON_FEATURES
>> > in 100 places, and I prefer merging it all together.
> It seems a bit harsh to ask
On Wed, Apr 29, 2015 at 11:24:24AM +0800, Fam Zheng wrote:
> v4: Rebase to 2.3 and rerun tests. timerfd+epoll shows clear improvement over
> current master when the virtio-console device attaches more fds to the
> main
> loop:
>
> syscall high # of fd low # of fd
> -
On Wed, Apr 29, 2015 at 10:52:15AM +0200, Cornelia Huck wrote:
> On Wed, 29 Apr 2015 10:17:55 +0200
> Christian Borntraeger wrote:
>
> > Am 28.04.2015 um 20:32 schrieb Michael S. Tsirkin:
> > > On Tue, Apr 28, 2015 at 08:14:44PM +0200, Michael S. Tsirkin wrote:
> > >> On Tue, Apr 28, 2015 at 04:3
Am 28.04.2015 um 18:51 schrieb Eric Auger:
> This includes, among other things, VFIO platform driver and
> irqfd/arm.
>
> Signed-off-by: Eric Auger
>
> ---
>
> v12 -> v13:
> - update for 4.1-rc0 headers
If you have a chance to update the subject before the pull request, its
4.1-rc1 instead of
This carries out the mandate in the comment of qemu_set_fd_handler2 and removes
fd_read_poll from the code base, because it will make the work easier to
convert ppoll to epoll in main loop, as well as convert iohandler to GSource.
Also, the aio interface doesn't have a read poll callback, which mea
All users are converted to qemu_set_fd_handler now, drop
qemu_set_fd_handler2 and IOHandlerRecord.fd_read_poll.
Signed-off-by: Fam Zheng
---
include/block/aio.h | 2 +-
include/qemu/main-loop.h | 49 +---
iohandler.c | 26 +--
This callback is called by main loop before polling s->fd, if it returns
false, the fd will not be polled in this iteration.
This is redundant with checks inside read callback. After this patch,
the data will be sent to peer when it arrives. If the device can't
receive, it will be queued to incomi
Some qemu_set_fd_handler2 stub callers will be converted to
call qemu_set_fd_handler, add this stub for them before making the
change.
Signed-off-by: Fam Zheng
---
stubs/set-fd-handler.c | 8
1 file changed, 8 insertions(+)
diff --git a/stubs/set-fd-handler.c b/stubs/set-fd-handler.c
i
This callback is called by main loop before polling s->fd, if it returns
false, the fd will not be polled in this iteration.
This is redundant with checks inside read callback. After this patch,
the data will be copied from s->fd to s->iov when it arrives. If the
device can't receive, it will be q
This callback is called by main loop before polling s->fd, if it returns
false, the fd will not be polled in this iteration.
This is redundant with checks inside read callback. After this patch,
the data will be copied from s->fd to s->msgvec when it arrives. If the
device can't receive, it will b
On 29/04/2015 12:37, Fam Zheng wrote:
> Achieved by:
>
> - Remembering the server fd with a global variable, in order to access
> it from nbd_client_closed.
>
> - Checking nbd_can_accept() and updating server_fd handler whenever
> client connects or disconnects.
>
> Signed-off-by: Fam Zheng
This callback is called by main loop before polling s->fd, if it returns
false, the fd will not be polled in this iteration.
This is redundant with checks inside read callback. After this patch,
the data will be sent to peer when it arrives. If the device can't
receive, it will be queued to incomi
Done with following Coccinelle semantic patch, plus manual coding style
cosmetic changes in net/*.c.
@@
expression E1, E2, E3, E4;
@@
- qemu_set_fd_handler2(E1, NULL, E2, E3, E4);
+ qemu_set_fd_handler(E1, E2, E3, E4);
Signed-off-by: Fam Zheng
---
blockdev-nbd.c
Hi Justin,
On Wed, 1 Apr 2015 14:35:51 +0200
Justin Ossevoort wrote:
> The FITRIM ioctl updates the fstrim_range structure it receives. This
> way the caller can determine how many bytes were trimmed. The
> guest-fstrim logic reuses the same fstrim_range for each filesystem,
> effectively lim
Achieved by:
- Remembering the server fd with a global variable, in order to access
it from nbd_client_closed.
- Checking nbd_can_accept() and updating server_fd handler whenever
client connects or disconnects.
Signed-off-by: Fam Zheng
---
qemu-nbd.c | 21 +
1 file chan
Eric Blake writes:
> Now that the two functions are identical, we only need one of them.
>
> Signed-off-by: Eric Blake
c_var() isn't the possible best name, but it'll do.
Reviewed-by: Markus Armbruster
On 29/04/2015 12:37, Fam Zheng wrote:
> @@ -190,10 +181,13 @@ static void tap_send(void *opaque)
> TAPState *s = opaque;
> int size;
> int packets = 0;
> +bool can_send = true;
>
> -while (qemu_can_send_packet(&s->nc)) {
> +while (can_send) {
This is effectively a wh
On 28/04/2015 23:04, Emilio G. Cota wrote:
>
> commit ad45e590025c1197a7aef5164e1ae174894b0969
> Author: Emilio G. Cota
> Date: Tue Apr 28 16:54:44 2015 -0400
>
> configure: require __thread support
>
> The codebase doesn't build without __thread support.
> Formalise this re
On 29/04/2015 10:37, Eric Auger wrote:
>> > This should be an unref.
> oups yes.
>
> Thanks! Do I keep this series or do I revert to sysbus irq connect irq
> temporary patch as per Peter's last email?
I think reverting is better since you need a respin and Peter offered to
touch the code later.
On 04/29/2015 01:12 PM, Paolo Bonzini wrote:
> I think reverting is better since you need a respin and Peter offered to
> touch the code later.
OK Thanks
Eric
>
> Paolo
On 04/29/2015 12:36 PM, Christian Borntraeger wrote:
> Am 28.04.2015 um 18:51 schrieb Eric Auger:
>> This includes, among other things, VFIO platform driver and
>> irqfd/arm.
>>
>> Signed-off-by: Eric Auger
>>
>> ---
>>
>> v12 -> v13:
>> - update for 4.1-rc0 headers
>
> If you have a chance to up
On Wed, Apr 29, 2015 at 10:19:55AM +0100, Peter Maydell wrote:
> On 29 April 2015 at 10:03, Alexander Graf wrote:
> >
> >
> > On 18.03.15 20:10, Andrew Jones wrote:
> >> Introduce a new memory region flag, KVM_MEM_UNCACHED, which
> >> is needed by ARM. This flag informs KVM that the given memory
>
On Tue, Apr 28, 2015 at 01:59:56PM +0300, Roman Kagan wrote:
> On Tue, Apr 28, 2015 at 10:46:58AM +0300, Denis V. Lunev wrote:
> > This is preparational commit for tweaks in Parallels image expansion.
> > The idea is that enlarge via truncate by one data block is slow. It
> > would be much better t
Eric Blake writes:
> Now that c_var() handles '.' in downstream extension names, fix
> the generator to support such names as additional types, enums,
> members within an enum, branches of a union or alternate, and
> in arrays.
>
> Signed-off-by: Eric Blake
> ---
> scripts/qapi-commands.py | 4
Eric Blake writes:
> So that we don't regress in supporting downstream extensions, make
> sure that our testsuite covers downstream naming choices in as many
> places as possible.
>
> Signed-off-by: Eric Blake
> ---
> tests/qapi-schema/qapi-schema-test.json | 19 +++
> tests/qap
Hi James,
On 28/04/2015 16:08, James Hogan wrote:
>> diff --git a/target-mips/mips-defs.h b/target-mips/mips-defs.h
>> index 1784227..20aa87c 100644
>> --- a/target-mips/mips-defs.h
>> +++ b/target-mips/mips-defs.h
>> @@ -10,11 +10,11 @@
>>
>> #if defined(TARGET_MIPS64)
>> #define TARGET_LONG_
On 04/29/2015 12:48 AM, Markus Armbruster wrote:
> General question first: through which tree should this go?
>
> MAINTAINERS doesn't cover the QAPI generators. Closest related stanza
> is QAPI (Luiz, Michael R.). Should it cover the generators? Next
> closest is QAPI Schema (Luiz, you, myself)
On Mon, 27 Apr 2015 14:23:20 -0300
Eduardo Habkost wrote:
> On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote:
> > Am 25.04.2015 um 17:28 schrieb Eduardo Habkost:
> > > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK.
> > > There were even some functions using
On Wed, 29 Apr 2015 06:34:12 -0600
Eric Blake wrote:
> On 04/29/2015 12:48 AM, Markus Armbruster wrote:
> > General question first: through which tree should this go?
> >
> > MAINTAINERS doesn't cover the QAPI generators. Closest related stanza
> > is QAPI (Luiz, Michael R.). Should it cover t
Cornelia Huck writes:
> From: Xu Wang
>
> A new sysbus device for diag288 watchdog, it monitors the kvm guest
> status, and take corresponding actions when it detects that the guest
> is not responding.
>
> Signed-off-by: Xu Wang
> Reviewed-by: David Hildenbrand
> Signed-off-by: Cornelia Huck
On 27/04/2015 16:38, Michael S. Tsirkin wrote:
On Mon, Apr 27, 2015 at 02:19:50PM +0300, Gal Hammer wrote:
Based on Microsoft's sepecifications (paper can be dowloaded from
http://go.microsoft.com/fwlink/?LinkId=260709), add a device
description to the SSDT ACPI table and its implementation.
Th
Am 29.04.2015 um 14:38 schrieb Luiz Capitulino:
> On Mon, 27 Apr 2015 14:23:20 -0300
> Eduardo Habkost wrote:
>
>> On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote:
>>> Am 25.04.2015 um 17:28 schrieb Eduardo Habkost:
The QJSON code used casts to (QJSON*) directly, instead of OB
On Wed, 29 Apr 2015 14:46:38 +0200
Andreas Färber wrote:
> Am 29.04.2015 um 14:38 schrieb Luiz Capitulino:
> > On Mon, 27 Apr 2015 14:23:20 -0300
> > Eduardo Habkost wrote:
> >
> >> On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote:
> >>> Am 25.04.2015 um 17:28 schrieb Eduardo Habk
On Wed, Apr 29, 2015 at 08:38:02AM -0400, Luiz Capitulino wrote:
> On Mon, 27 Apr 2015 14:23:20 -0300
> Eduardo Habkost wrote:
>
> > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote:
> > > Am 25.04.2015 um 17:28 schrieb Eduardo Habkost:
> > > > The QJSON code used casts to (QJSON*)
On Wed, 29 Apr 2015 09:55:48 -0300
Eduardo Habkost wrote:
> > > Also, why do we have two JSON writers in QEMU? And why do they have
> > > exactly the same name?
> >
> > Not sure I got it, which writers?
>
> qjson.c and qobject/qjson.c:to_json().
Hmm, yeah, you're right.
None of the existing QMP or QGA interfaces uses a union with a
base type but no discriminator; it is easier to avoid this in the
generator to save room for other future extensions more likely to
be useful. An earlier commit added a union-base-no-discriminator
test to ensure that we eventually give
Demonstrate that the qapi generator doesn't deal well with enums
that aren't up to par. Later patches will update the expected
results as the generator is made stricter.
Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
---
v7: tweak comments in enum-max-member test
---
tests/Makefile
There was some redundancy between builtin_types[] and
builtin_type_qtypes{}. Merge them into one.
Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
---
scripts/qapi-types.py | 10 +-
scripts/qapi-visit.py | 6 +++---
scripts/qapi.py | 8 +---
3 files changed, 9 inser
This patch widens the scope of a try block (with the attending
reindentation required by Python) in preparation for a future
patch adding more instances of QAPIExprError inside the block.
It's easier to separate indentation from semantic changes, so
this patch has no real behavior change.
Signed-o
Go into more details about the various types of valid expressions
in a qapi schema, including tweaks to document fixes being done
later in the current patch series. Also fix some stale and missing
documentation in the QMP specification.
Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
The next patch will quit special-casing "'union':'Foo',
'discriminator':{}" and instead use "'alternate':'Foo'".
Separating docs from implementation makes it easier to focus
on wording without holding up code. In particular, making
alternate a separate type makes for a nice type hierarchy:
For a few QMP commands, we are forced to pass an arbitrary type
without tracking it properly in QAPI. Among the existing clients,
this unnamed type was spelled 'dict', 'visitor', and '**'; this
patch standardizes on '**', matching the documentation changes
earlier in the series.
Meanwhile, for bo
Previous commits demonstrated that the generator had several
flaws with less-than-perfect unions:
- a simple union that listed the same branch twice (or two variant
names that map to the same C enumerator, including the implicit
MAX sentinel) ended up generating invalid C code
- an anonymous union
Now that we have a way to validate every type, we can also be
stricter about enforcing that callers that want to bypass
type safety in generated code. Prior to this patch, it didn't
matter what value was associated with the key 'gen', but it
looked odd that 'gen':'yes' could result in bypassing th
Reduce churn in the future patch that replaces anonymous unions
with a new metatype 'alternate' by changing 'AnonUnion' to
'Alternate'.
Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
---
tests/qapi-schema/qapi-schema-test.json | 2 +-
tests/qapi-schema/qapi-schema-test.out | 4 ++--
...or an array of dictionaries. Although we have to cater to
existing commands, returning a non-dictionary means the command
is not extensible (no new name/value pairs can be added if more
information must be returned in parallel). By making the
whitelist explicit, any new command that falls foul
Demonstrate that the qapi generator doesn't deal very well with
redefined expressions. At the parse level, they are silently
accepted; and while the testsuite just stops at parsing, I've
further tested that many of them cause generator crashes or
invalid C code if they were appended to qapi-schema
Special-casing 'discriminator == {}' for handling anonymous unions
is getting awkward; since this particular type is not always a
dictionary on the wire, it is easier to treat it as a completely
different class of type, "alternate", so that if a type is listed
in the union_types array, we know it i
1 - 100 of 283 matches
Mail list logo
