Re: [Qemu-devel] blkdebug and VMDK (iotests 033 failure on monolithicFlat)

2015-05-06 Thread Max Reitz
On 06.05.2015 16:38, Fam Zheng wrote: On Wed, 05/06 16:12, Max Reitz wrote: On 06.05.2015 15:59, Fam Zheng wrote: On Wed, 05/06 15:45, Max Reitz wrote: On 05.05.2015 12:44, Fam Zheng wrote: Max, Since you once fixed VMDK with the json descriptor filename, could you take a look at the error:

Re: [Qemu-devel] [RFC PATCH v13 15/21] bottom halves: introduce bh call function

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 16:04, Pavel Dovgalyuk wrote: > This patch introduces aio_bh_call function. It is used to execute > bottom halves as callbacks without adding them to the queue. > > Signed-off-by: Pavel Dovgalyuk > --- > async.c |8 +++- > include/block/aio.h |5 + > 2

Re: [Qemu-devel] blkdebug and VMDK (iotests 033 failure on monolithicFlat)

2015-05-06 Thread Fam Zheng
On Wed, 05/06 16:12, Max Reitz wrote: > On 06.05.2015 15:59, Fam Zheng wrote: > >On Wed, 05/06 15:45, Max Reitz wrote: > >>On 05.05.2015 12:44, Fam Zheng wrote: > >>>Max, > >>> > >>>Since you once fixed VMDK with the json descriptor filename, could you > >>>take a > >>>look at the error: > >>> > >

Re: [Qemu-devel] [PATCH] rules.mak: Force CFLAGS for all objects in DSO

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 16:23, Fam Zheng wrote: >>> > > + $(eval $($v:%.mo=%$(DSOSUF)) $($v) $(foreach >>> > > o,$($v),$($o-objs)) .PHONY: CFLAGS += -fPIC -DBUILD_DSO) > ^ ^^ >^ >

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Stefano Stabellini
On Wed, 6 May 2015, Paolo Bonzini wrote: > On 06/05/2015 16:12, Richard Henderson wrote: > >> Can > >> > we rely on the env/CPUState always being up to date during > >> > target_disas (which happens at translate time?) or will we need to go > >> > field by field to make sure any env updates explici

Re: [Qemu-devel] [PATCH] rules.mak: Force CFLAGS for all objects in DSO

2015-05-06 Thread Fam Zheng
On Wed, 05/06 16:07, Paolo Bonzini wrote: > > > On 06/05/2015 15:46, Fam Zheng wrote: > > Because of the trick of process-archive-undefs, all .mo objects, even > > with --enable-modules, are dependencies of executables. > > > > This breaks CFLAGS propogation because the compiling of module objec

Re: [Qemu-devel] [RFC PATCH 3/7] block: Add op blocker notifier list

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 13:23, Fam Zheng wrote: > void bdrv_op_block(BlockDriverState *bs, BlockOpType op, Error *reason) > { > BdrvOpBlocker *blocker; > assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX); > > +bdrv_op_blocker_notify(bs, op, reason, true); > blocker = g_new0(BdrvOpBlock

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Richard Henderson
On 05/06/2015 12:06 AM, Peter Crosthwaite wrote: > Can > we rely on the env/CPUState always being up to date during > target_disas (which happens at translate time?) or will we need to go > field by field to make sure any env updates explicitly occur before > target_disas? I *think* so, but it's a

Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 14:20, Fam Zheng wrote: >> > >> > Does non-dataplane need to do anything, since it uses iohandlers rather >> > than aio_set_event_notifier_handler? > I guess it's not for this specific bug. See this as an attempt on a general > purpose "pause" mechanism to the device in investment

Re: [Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 13:57, Yossi Hindin wrote: > The second version of commits's set take into account Paolo Bonzini remarks. > > Typo in WXS file fixed, QEMU GA-related CLI options renamed, > '--enable-guest-agent-msi'/ > '--disable-guest-agent-msi' processing logic changed so that MSI build is > c

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 16:12, Richard Henderson wrote: >> Can >> > we rely on the env/CPUState always being up to date during >> > target_disas (which happens at translate time?) or will we need to go >> > field by field to make sure any env updates explicitly occur before >> > target_disas? > I *think* s

[Qemu-devel] [RFC PATCH v13 19/21] replay: replay blockers for devices

2015-05-06 Thread Pavel Dovgalyuk
Some devices are not supported by record/replay subsystem. This patch introduces replay blocker which denies starting record/replay if such devices are included into the configuration. Signed-off-by: Pavel Dovgalyuk --- hw/bt/hci.c |7 +++ include/qapi/qmp/qerror.h |3 +

Re: [Qemu-devel] [RFC] ARM/ARM64: KVM: Implement KVM_FLUSH_DCACHE_GPA ioctl

2015-05-06 Thread Christoffer Dall
Hi Jérémy, On Tue, May 05, 2015 at 11:13:11AM +0200, Jérémy Fanguède wrote: > To maintain cache coherency on ARM, we may need a mechanism to flush > the data cache. In addition to generally just making this functionality available (see below), do you have an actual use case in mind for this? To

[Qemu-devel] [RFC PATCH v13 18/21] replay: initialization and deinitialization

2015-05-06 Thread Pavel Dovgalyuk
This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- exec.c |1 replay/replay-internal.h |2 + replay/replay.c | 134 +++

Re: [Qemu-devel] blkdebug and VMDK (iotests 033 failure on monolithicFlat)

2015-05-06 Thread Max Reitz
On 06.05.2015 15:59, Fam Zheng wrote: On Wed, 05/06 15:45, Max Reitz wrote: On 05.05.2015 12:44, Fam Zheng wrote: Max, Since you once fixed VMDK with the json descriptor filename, could you take a look at the error: $ ./check -vmdk -o "subformat=monolithicFlat" 033 033 - output misma

[Qemu-devel] [RFC PATCH v13 17/21] typedef: add typedef for QemuOpts

2015-05-06 Thread Pavel Dovgalyuk
This patch moves typedefs for QemuOpts and related types to qemu/typedefs.h file. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- include/qemu/option.h |5 + include/qemu/typedefs.h |3 +++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/qemu/

Re: [Qemu-devel] [PATCH] rules.mak: Force CFLAGS for all objects in DSO

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 15:46, Fam Zheng wrote: > Because of the trick of process-archive-undefs, all .mo objects, even > with --enable-modules, are dependencies of executables. > > This breaks CFLAGS propogation because the compiling of module object > will happen too early before building for DSO. > >

[Qemu-devel] [RFC PATCH v13 20/21] replay: command line options

2015-05-06 Thread Pavel Dovgalyuk
This patch introduces command line options for enabling recording or replaying virtual machine behavior. These options are added to icount command line parameter. They include 'rr' which switches between record and replay and 'rrfile' for specifying the filename for replay log. Signed-off-by: Pave

[Qemu-devel] [RFC PATCH v13 12/21] replay: recording and replaying clock ticks

2015-05-06 Thread Pavel Dovgalyuk
Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock). When replaying the execution corresponding values are read from log and transfered to the module, which wants to read

Re: [Qemu-devel] [PATCH v3 4/5] qtest: precompute hex nibs

2015-05-06 Thread John Snow
On 05/06/2015 02:25 AM, Markus Armbruster wrote: > John Snow writes: > >> Instead of letting printf and friends do this for us >> one byte at a time, fill a buffer ourselves and then >> send the entire buffer in one go. >> >> This gives a moderate speed improvement over the old >> method. > >

[Qemu-devel] [RFC PATCH v13 16/21] replay: ptimer

2015-05-06 Thread Pavel Dovgalyuk
This patch adds deterministic replay for hardware periodic countdown timers. Signed-off-by: Pavel Dovgalyuk --- hw/core/ptimer.c |7 ++- replay/replay-events.c | 17 + replay/replay-internal.h |1 + replay/replay.h |2 ++ 4 files changed, 26 i

[Qemu-devel] [RFC PATCH v13 09/21] i386: interrupt poll processing

2015-05-06 Thread Pavel Dovgalyuk
This patch updates x86_cpu_exec_interrupt function. It can process two interrupt request at a time (poll and another one). This makes its execution non-deterministic. Determinism is requred for recorded icount execution. Signed-off-by: Pavel Dovgalyuk --- target-i386/seg_helper.c |3 +++ 1 f

[Qemu-devel] [RFC PATCH v13 21/21] replay: recording of the user input

2015-05-06 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 31 + replay/replay-input.c| 159 +++

[Qemu-devel] [RFC PATCH v13 14/21] replay: checkpoints

2015-05-06 Thread Pavel Dovgalyuk
This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk --- cpus.c |5 + main-loop.c |6 ++ qemu-timer.c

Re: [Qemu-devel] [RFC 5/5] arm: Simplify cycle counter

2015-05-06 Thread Peter Crosthwaite
On Fri, May 1, 2015 at 7:35 AM, Christopher Covington wrote: > On Thu, Apr 30, 2015 at 9:24 PM, Peter Crosthwaite > wrote: >> On Thu, Apr 30, 2015 at 11:14 AM, Christopher Covington >> wrote: >>> Present a system with an instructions per cycle of exactly one. >>> This makes it less likely a user

[Qemu-devel] [RFC PATCH v13 13/21] replay: shutdown event

2015-05-06 Thread Pavel Dovgalyuk
This patch records and replays simulator shutdown event. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.h |2 ++ replay/replay.c | 14 ++ replay/replay.h |5 + vl.c |1 + 4 files changed,

[Qemu-devel] [RFC PATCH v13 08/21] cpu: replay instructions sequence

2015-05-06 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. When replayed instructions counter is expired qemu_notify_event() function is ca

[Qemu-devel] [RFC PATCH v13 06/21] replay: introduce icount event

2015-05-06 Thread Pavel Dovgalyuk
This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 24 re

[Qemu-devel] [RFC PATCH v13 11/21] replay: asynchronous events infrastructure

2015-05-06 Thread Pavel Dovgalyuk
This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at synchronization points such as beginning of TB execution,

[Qemu-devel] [RFC PATCH v13 07/21] cpu-exec: allow temporary disabling icount

2015-05-06 Thread Pavel Dovgalyuk
This patch is required for deterministic replay to generate an exception by trying executing an instruction without changing icount. It adds new flag to TB for disabling icount while translating it. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c |7

[Qemu-devel] [RFC PATCH v13 15/21] bottom halves: introduce bh call function

2015-05-06 Thread Pavel Dovgalyuk
This patch introduces aio_bh_call function. It is used to execute bottom halves as callbacks without adding them to the queue. Signed-off-by: Pavel Dovgalyuk --- async.c |8 +++- include/block/aio.h |5 + 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a

[Qemu-devel] [RFC PATCH v13 04/21] replay: internal functions for replay log

2015-05-06 Thread Pavel Dovgalyuk
This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/Makefile.objs |1 replay/replay-internal.c | 149 ++ replay/replay-internal.h | 46 ++

[Qemu-devel] [RFC PATCH v13 02/21] replay: global variables and function stubs

2015-05-06 Thread Pavel Dovgalyuk
This patch adds global variables, defines, function declarations, and function stubs for deterministic VM replay used by external modules. Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Pavel Dovgalyuk --- Makefile.target |1 docs/replay.txt | 167 ++

[Qemu-devel] [RFC PATCH v13 05/21] replay: introduce mutex to protect the replay log

2015-05-06 Thread Pavel Dovgalyuk
This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 27 +

[Qemu-devel] [RFC PATCH v13 10/21] replay: interrupts and exceptions

2015-05-06 Thread Pavel Dovgalyuk
This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [RFC PATCH v13 00/21] Deterministic replay core

2015-05-06 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. This implementation of deterministic replay can be used for deterministic debugging of guest code through gdb remote interface. Core set of patches does not include support for reverse debugging c

[Qemu-devel] [RFC PATCH v13 03/21] sysemu: system functions for replay

2015-05-06 Thread Pavel Dovgalyuk
This patch removes "static" specifier from several qemu function to make them visible to the replay module. It also invents several system functions that will be used by replay. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpus.c |2 +- include/exec/exec-a

[Qemu-devel] [RFC PATCH v13 01/21] i386: partial revert of interrupt poll fix

2015-05-06 Thread Pavel Dovgalyuk
Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c|6 ++ target-i386/cpu.c | 10 ++--

Re: [Qemu-devel] blkdebug and VMDK (iotests 033 failure on monolithicFlat)

2015-05-06 Thread Fam Zheng
On Wed, 05/06 15:45, Max Reitz wrote: > On 05.05.2015 12:44, Fam Zheng wrote: > >Max, > > > >Since you once fixed VMDK with the json descriptor filename, could you take a > >look at the error: > > > >$ ./check -vmdk -o "subformat=monolithicFlat" 033 > > > >033 - output mismatch (see 033.out

Re: [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics

2015-05-06 Thread Richard Henderson
On 05/05/2015 11:57 PM, Peter Crosthwaite wrote: > So I have made a start on this. The ARM, MB and CRIS in this patch > series is rather easy. Its X86 im having trouble with but your example > here looks like most of the work ... > >> Indeed, the flags setup becomes less obscure when, instead of >

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 6:16 AM, Peter Maydell wrote: > On 6 May 2015 at 14:08, Peter Crosthwaite > wrote: >> Ergh, I have to backpeddle again (sry for the noise), patches still >> doesnt work for me (serves me right for not looking at the year of >> submission dates). Latest patches I have from

Re: [Qemu-devel] blkdebug and VMDK (iotests 033 failure on monolithicFlat)

2015-05-06 Thread Max Reitz
On 05.05.2015 12:44, Fam Zheng wrote: Max, Since you once fixed VMDK with the json descriptor filename, could you take a look at the error: $ ./check -vmdk -o "subformat=monolithicFlat" 033 033 - output mismatch (see 033.out.bad) --- /home/fam/qemu/tests/qemu-iotests/033.out 2015-05-

[Qemu-devel] [PATCH] rules.mak: Force CFLAGS for all objects in DSO

2015-05-06 Thread Fam Zheng
Because of the trick of process-archive-undefs, all .mo objects, even with --enable-modules, are dependencies of executables. This breaks CFLAGS propogation because the compiling of module object will happen too early before building for DSO. With GCC 5, the linking would fail because .o doesn't

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Michael Mueller
On Wed, 6 May 2015 10:33:55 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 08:59:56AM -0400, Luiz Capitulino wrote: > > On Wed, 6 May 2015 07:38:53 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote: > > > > On Tue, 5 May 2015 10:1

[Qemu-devel] [PATCH 1/7] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-06 Thread Alberto Garcia
The qcow2 L2/refcount cache contains one separate table for each cache entry. Doing one allocation per table adds unnecessary overhead and it also requires us to store the address of each table separately. Since the size of the cache is constant during its lifetime, it's better to have an array th

[Qemu-devel] [PATCH 3/7] qcow2: use an LRU algorithm to replace entries from the L2 cache

2015-05-06 Thread Alberto Garcia
The current algorithm to evict entries from the cache gives always preference to those in the lowest positions. As the size of the cache increases, the chances of the later elements of being removed decrease exponentially. In a scenario with random I/O and lots of cache misses, entries in position

[Qemu-devel] [PATCH 2/7] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty()

2015-05-06 Thread Alberto Garcia
Since all tables are now stored together, it is possible to obtain the position of a particular table directly from its address, so the operation becomes O(1). Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 32 +++- 1 file changed, 15 insertions(+), 17 deleti

[Qemu-devel] [PATCH v2 0/7] qcow2 L2/refcount cache improvements

2015-05-06 Thread Alberto Garcia
New version of the qcow2 cache patches: v2: - Don't do pointer arithmetic on void * - Rename table_addr() to qcow2_cache_get_table_addr() - Add qcow2_cache_get_table_idx() - Cast cache size to size_t to prevent overflows - Make qcow2_cache_put() a void function - Don't store the cluster size in th

[Qemu-devel] [PATCH 5/7] qcow2: use a hash to look for entries in the L2 cache

2015-05-06 Thread Alberto Garcia
The current cache algorithm traverses the array starting always from the beginning, so the average number of comparisons needed to perform a lookup is proportional to the size of the array. By using a hash of the offset as the starting point, lookups are faster and independent from the array size.

[Qemu-devel] [PATCH 4/7] qcow2: remove qcow2_cache_find_entry_to_replace()

2015-05-06 Thread Alberto Garcia
A cache miss means that the whole array was traversed and the entry we were looking for was not found, so there's no need to traverse it again in order to select an entry to replace. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 45 - 1 file

[Qemu-devel] [PATCH 7/7] qcow2: style fixes in qcow2-cache.c

2015-05-06 Thread Alberto Garcia
Fix pointer declaration to make it consistent with the rest of the code. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index 0f629c4..bea43c1 100644 --- a/block/qcow2-cache

[Qemu-devel] [PATCH 6/7] qcow2: make qcow2_cache_put() a void function

2015-05-06 Thread Alberto Garcia
This function never receives an invalid table pointer, so we can make it void and remove all the error checking code. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c| 7 +-- block/qcow2-cluster.c | 50 ++ block/qcow2-refcount.c | 29

[Qemu-devel] [Bug 1452062] Re: qemu-img will fail to convert images in 2.3.0

2015-05-06 Thread David Hill
I rolled back QEMU to 2.2.1 and it succeeded converting the image ... I'll try to see if I can re-upgrade QEMU without breaking again the CI we have here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Eduardo Habkost
On Wed, May 06, 2015 at 08:59:56AM -0400, Luiz Capitulino wrote: > On Wed, 6 May 2015 07:38:53 -0300 > Eduardo Habkost wrote: > > > On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote: > > > On Tue, 5 May 2015 10:14:32 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Apr 27,

Re: [Qemu-devel] [PATCH] qcow2: Flush pending discards before allocating cluster

2015-05-06 Thread Max Reitz
On 06.05.2015 13:29, Kevin Wolf wrote: Before a freed cluster can be reused, pending discards for this cluster must be processed. The original assumption was that this was not a problem because discards are only cached during discard/write zeroes operations, which are synchronous so that no conc

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 6:26 AM, Peter Maydell wrote: > On 6 May 2015 at 14:21, Peter Crosthwaite > wrote: >> On Wed, May 6, 2015 at 6:18 AM, Peter Maydell >> wrote: >>> On 6 May 2015 at 14:02, Peter Crosthwaite >>> wrote: Actually NVM. I got it working on a diff machine. Did you have an

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Maydell
On 6 May 2015 at 14:21, Peter Crosthwaite wrote: > On Wed, May 6, 2015 at 6:18 AM, Peter Maydell > wrote: >> On 6 May 2015 at 14:02, Peter Crosthwaite >> wrote: >>> Actually NVM. I got it working on a diff machine. Did you have any >>> thoughts on the GICC mirror issue while I respin? >> >> Yo

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 6:18 AM, Peter Maydell wrote: > On 6 May 2015 at 14:02, Peter Crosthwaite > wrote: >> Actually NVM. I got it working on a diff machine. Did you have any >> thoughts on the GICC mirror issue while I respin? > > You mean the thing where the GICC might not be at the bottom of

Re: [Qemu-devel] [PATCH v4 16/17] qapi: Expose new qcow2 overlap check options

2015-05-06 Thread Max Reitz
On 04.05.2015 21:39, Eric Blake wrote: On 05/04/2015 01:15 PM, Max Reitz wrote: Expose the two new options for controlling the memory usage of the overlap check implementation via QAPI. Signed-off-by: Max Reitz --- qapi/block-core.json | 37 + 1 file chan

[Qemu-devel] [Bug 1452230] [NEW] Qemu 2.3.0 failes to compile with GCC 5.1.0 and -flto

2015-05-06 Thread Steffen Hau
Public bug reported: Compiling Qemu 2.3.0 failes with the following error: x86_64-pc-linux-gnu-g++ -I/usr/include/pixman-1 -fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-s

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Maydell
On 6 May 2015 at 14:02, Peter Crosthwaite wrote: > Actually NVM. I got it working on a diff machine. Did you have any > thoughts on the GICC mirror issue while I respin? You mean the thing where the GICC might not be at the bottom of a 64K page? Just map it wherever it lives in the hardware you'r

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Maydell
On 6 May 2015 at 14:08, Peter Crosthwaite wrote: > Ergh, I have to backpeddle again (sry for the noise), patches still > doesnt work for me (serves me right for not looking at the year of > submission dates). Latest patches I have from > > http://wiki.qemu.org/patches/patches.json > > is: > > Mess

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 6:02 AM, Peter Crosthwaite wrote: > On Wed, May 6, 2015 at 5:14 AM, Peter Maydell > wrote: >> On 1 May 2015 at 18:25, Peter Crosthwaite >> wrote: >>> Ping! >>> >>> On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite >>> wrote: Hi Peter and all, Xilinx's ne

[Qemu-devel] [PATCH 02/14] usb: usb-audio QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-audio.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c index 67deffe..f092bb8 100644 --- a/hw/usb/dev-audio.c +++ b/hw/usb/dev-audio.c @@ -361,6 +361,9 @@ t

Re: [Qemu-devel] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols

2015-05-06 Thread Max Reitz
On 05.05.2015 11:46, Stefan Hajnoczi wrote: On Thu, Mar 19, 2015 at 03:03:18PM -0400, Max Reitz wrote: Some image formats (e.g. qcow2) require the underlying file to grow on write accesses, but this is in fact not supported by all protocols (e.g. nbd does not). If such a format requiring file gr

Re: [Qemu-devel] [PATCH v4 13/17] qcow2/overlaps: Add "memory limit reached" event

2015-05-06 Thread Max Reitz
On 04.05.2015 21:32, Eric Blake wrote: On 05/04/2015 01:15 PM, Max Reitz wrote: Later, a mechanism to set a limit on how much memory may be used for the overlap prevention structures will be introduced. If that limit is about to be exceeded, a QMP event should be emitted. This very event is spec

[Qemu-devel] [PATCH 14/14] usb: usb-serial QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-serial.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 67c2072..6ca3da9 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-seria

[Qemu-devel] [PATCH 08/14] usb: usb-net QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-network.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 1866991..5f2ffd0 100644 --- a/hw/usb/dev-network.c +++ b/hw/usb/dev-network.c @@ -648,6 +648,9 @@ typed

[Qemu-devel] [PATCH 05/14] usb: usb-hub QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-hub.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c index 0482f58..c8c6855 100644 --- a/hw/usb/dev-hub.c +++ b/hw/usb/dev-hub.c @@ -41,6 +41,9 @@ typedef struct USBHubState

[Qemu-devel] [PATCH 07/14] usb-mtp: fix segmentation fault

2015-05-06 Thread arei.gonglei
From: Gonglei When x-root property not be configured, will cause segfault because of null pointer accessing. Add a check for s->root property avoid segfault. Signed-off-by: Gonglei --- hw/usb/dev-mtp.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c

[Qemu-devel] [PATCH 13/14] usb: usb-redir QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/redirect.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 2416de8..242a654 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -130,6 +130,9 @@ stru

[Qemu-devel] [PATCH 11/14] usb: usb-uas QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-uas.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 04fc515..38b26c5 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -127,6 +127,9 @@ struct UASDevice {

[Qemu-devel] [PATCH 10/14] usb: usb-storage QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-storage.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index ae8d40d..abe0e1d 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@

[Qemu-devel] [PATCH 04/14] usb: usb-hid QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-hid.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 507c966..9623e72 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c @@ -51,6 +51,9 @@ ty

[Qemu-devel] [PATCH 00/14] usb: QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Because DO_UPCAST() is long deprecated, let me do some cleanup work for usb sub-system, which I have said in previous conversation of a bugfix. Patch 7 is a bugfix. Please review, thanks :) Gonglei (14): uhci: QOMify usb: usb-audio QOMify usb: usb-bt QOMify usb: usb-hi

[Qemu-devel] [PATCH 09/14] usb: usb-ccid QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-smartcard-reader.c | 50 --- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 78ce681..2d29367 100644 --- a/hw/usb/dev-s

[Qemu-devel] [PATCH 03/14] usb: usb-bt QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-bluetooth.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/usb/dev-bluetooth.c b/hw/usb/dev-bluetooth.c index 9bf6730..b19ec76 100644 --- a/hw/usb/dev-bluetooth.c +++ b/hw/usb/dev-bluetooth.c @@ -49,6 +49,

[Qemu-devel] [PATCH 12/14] usb: usb-wacom-tablet QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-wacom.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c index 844eafa..c2450e7 100644 --- a/hw/usb/dev-wacom.c +++ b/hw/usb/dev-wacom.c @@ -56,6 +56,9 @@ typedef struct USBWa

[Qemu-devel] [PATCH 06/14] usb: usb-mtp QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/usb/dev-mtp.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 108ece8..c9c1f32 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -130,6 +130,9 @@ struct MTPState { QT

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 5:14 AM, Peter Maydell wrote: > On 1 May 2015 at 18:25, Peter Crosthwaite > wrote: >> Ping! >> >> On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite >> wrote: >>> Hi Peter and all, >>> >>> Xilinx's next gen SoC has been announced. This series adds a SoC and >>> board. > >

[Qemu-devel] [PATCH 01/14] uhci: QOMify

2015-05-06 Thread arei.gonglei
From: Gonglei Cc: Gerd Hoffmann Signed-off-by: Gonglei --- hw/usb/hcd-uhci.c | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 327f26d..64a7d87 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/us

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Luiz Capitulino
On Wed, 6 May 2015 07:38:53 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 10:14:32 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > > > The HMP command info cp

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Crosthwaite
On Wed, May 6, 2015 at 5:14 AM, Peter Maydell wrote: > On 1 May 2015 at 18:25, Peter Crosthwaite > wrote: >> Ping! >> >> On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite >> wrote: >>> Hi Peter and all, >>> >>> Xilinx's next gen SoC has been announced. This series adds a SoC and >>> board. > >

Re: [Qemu-devel] [PATCH v6 05/17] Add optional parameters to QMP command query-cpu-definitions

2015-05-06 Thread Eduardo Habkost
On Mon, Apr 27, 2015 at 04:53:19PM +0200, Michael Mueller wrote: [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index 215a7bc..285b2d3 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2536,21 +2536,43 @@ > # > # @name: the name of the CPU definition > # > +# @default: #

Re: [Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-05-06 Thread Eduardo Habkost
On Mon, Apr 27, 2015 at 04:53:29PM +0200, Michael Mueller wrote: [...] > #ifndef CONFIG_USER_ONLY > +static CpuDefinitionInfoList *qmp_query_cpu_definition_host(void) > +{ > +CpuDefinitionInfoList *host = NULL; > +CpuDefinitionInfo *info; > + > +info = g_try_new0(CpuDefinitionInfo, 1);

[Qemu-devel] [PATCH] vmdk: Fix next_cluster_sector for compressed write

2015-05-06 Thread Fam Zheng
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster allocation). Sometimes, write_len could be larger than cluster size, because it contains both data and marker. We must advance next_cluster_sector in this case, otherwise the image gets corrupted. Reported-by: Antoni Villalo

Re: [Qemu-devel] [PATCH v6 12/17] target-s390x: Add S390 CPU class initialization routines

2015-05-06 Thread Eduardo Habkost
On Wed, May 06, 2015 at 10:02:22AM +0200, Michael Mueller wrote: > On Tue, 5 May 2015 11:34:06 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 27, 2015 at 04:53:26PM +0200, Michael Mueller wrote: > > > This patch provides routines to dynamically update the previously defined > > > S390 CPU class

Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-06 Thread Fam Zheng
On Wed, 05/06 14:07, Paolo Bonzini wrote: > > > On 06/05/2015 13:23, Fam Zheng wrote: > > virtio-blk now listens to op blocker change of the associated block > > backend. > > > > Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO: > > > > non-dataplane: > >1) Set VirtIOBlock.paused > >

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-06 Thread Peter Maydell
On 1 May 2015 at 18:25, Peter Crosthwaite wrote: > Ping! > > On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite > wrote: >> Hi Peter and all, >> >> Xilinx's next gen SoC has been announced. This series adds a SoC and >> board. Neither patchwork nor patches seem to have the complete set of these

[Qemu-devel] [PATCH RFC 7/7] vhost_net: re-enable when cross endian

2015-05-06 Thread Greg Kurz
From: Cédric Le Goater Cross-endianness is now checked by the core vhost code. revert 371df9f5e0f1 "vhost-net: disable when cross-endian" Signed-off-by: Cédric Le Goater [ added commit message, Greg Kurz ] Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 19 --- 1 file ch

[Qemu-devel] [PATCH RFC 4/7] vhost: set vring endianness for legacy virtio

2015-05-06 Thread Greg Kurz
Legacy virtio is native endian: if the guest and host endianness differ, we have to tell vhost so it can swap bytes where appropriate. This is done through a vhost ring ioctl. Signed-off-by: Greg Kurz --- hw/virtio/vhost.c | 50 +- 1 file changed

[Qemu-devel] [PATCH RFC 3/7] virtio: introduce virtio_legacy_is_cross_endian()

2015-05-06 Thread Greg Kurz
This helper will be used by vhost and tap to detect cross-endianness in the legacy virtio case. Signed-off-by: Greg Kurz --- include/hw/virtio/virtio-access.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-access

[Qemu-devel] [PATCH RFC 5/7] tap: add VNET_LE/VNET_BE operations

2015-05-06 Thread Greg Kurz
The linux tap and macvtap backends can be told to parse vnet headers according to little or big endian. This is done through the TUNSETVNETLE and TUNSETVNETBE ioctls. This patch brings all the plumbing for QEMU to use these APIs. Signed-off-by: Greg Kurz --- include/net/net.h |6 ++ net

[Qemu-devel] [PATCH RFC 1/7] virtio: relax feature check

2015-05-06 Thread Greg Kurz
Unlike with add and clear, there is no valid reason to abort when checking for a feature. It makes more sense to return false (i.e. the feature bit isn't set). This is exactly what __virtio_has_feature() does if fbit >= 32. This allows to introduce code that is aware about new 64-bit features like

[Qemu-devel] [PATCH RFC 6/7] vhost-net: tell tap backend about the vnet endianness

2015-05-06 Thread Greg Kurz
The default behaviour for TAP/MACVTAP is to consider vnet as native endian. This patch handles the cases when this is not true: - virtio 1.0: always little-endian - legacy cross-endian Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 33 - 1 file changed, 32 i

[Qemu-devel] [PATCH RFC 2/7] linux-headers: sync vhost.h

2015-05-06 Thread Greg Kurz
This patch brings the cross-endian vhost API to QEMU. Signed-off-by: Greg Kurz --- linux-headers/linux/vhost.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/linux-headers/linux/vhost.h b/linux-headers/linux/vhost.h index c656f61..ead86db 100644 --- a/linux-headers/linux/v

Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker

2015-05-06 Thread Paolo Bonzini
On 06/05/2015 13:23, Fam Zheng wrote: > virtio-blk now listens to op blocker change of the associated block > backend. > > Up on setting op blocker on BLOCK_OP_TYPE_DEVICE_IO: > > non-dataplane: >1) Set VirtIOBlock.paused >2) In virtio_blk_handle_output, do nothing if VirtIOBlock.paus

[Qemu-devel] [PATCH RFC 0/7] vhost: cross-endian support (vhost-net only)

2015-05-06 Thread Greg Kurz
Hi, This series allows QEMU to use vhost with legacy virtio devices when host and target don't have the same endianness. Only network devices are covered for the moment. I had already posted a series some monthes ago but it never got reviewed. Moreover, the underlying kernel support was entirely

Re: [Qemu-devel] qemu-img convert (vmdk)

2015-05-06 Thread Fam Zheng
On Wed, 05/06 10:15, Antoni Villalonga wrote: > > Hi again, it seems to be related to the subformat option. With the default > option seems to work fine. > > I think StreamOptimized is mantatory for 'ova' files. I guess I see the problem now - the data is corrupted due to a wrong cluster allocat

Re: [Qemu-devel] [PATCH v2] libcacard: stop including qemu-common.h

2015-05-06 Thread Laurent Desnogues
On Wed, May 6, 2015 at 12:05 PM, Michael Tokarev wrote: > 06.05.2015 12:23, Laurent Desnogues wrote: >> Hello, >> >> On Mon, Apr 27, 2015 at 3:27 PM, Michael Tokarev wrote: >>> From: Paolo Bonzini >>> >>> This is a small step towards making libcacard standalone. >> >> on my system the removal of

<    1   2   3   4   >