Building the QEMU tools fails if we #define DEBUG_BLOCK inside
block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
a simple DPRINTF().
Signed-off-by: Dimitris Aragiorgis dim...@arrikto.com
---
block/raw-posix.c
Stefan Berger stef...@linux.vnet.ibm.com wrote on 05/08/2015 12:15:17
PM:
From: Stefan Berger stef...@linux.vnet.ibm.com
To: qemu-devel@nongnu.org, m...@redhat.com
Cc: imamm...@redhat.com, quan...@intel.com, Stefan Berger/Watson/
IBM@IBMUS, ke...@koconnor.net, Stefan Berger
On Wed, May 06, 2015 at 17:38:02 +0200, Alvise Rigo wrote:
This patch series provides an infrastructure for atomic
instruction implementation in QEMU, paving the way for TCG multi-threading.
The adopted design does not rely on host atomic
instructions and is intended to propose a 'legacy'
During migration, QEMU uses fsync()/fdatasync() on the open file
descriptor for read-write block devices to flush data just before
stopping the VM.
However, fsync() on a scsi-generic device returns -EINVAL which
causes the migration to fail. This patch skips flushing data in case
of an SG device,
Hi all,
These four patches make slight changes to the way QEMU handles SCSI
generic devices to fix a number of small problems.
I am sending them against the master branch, since I don't know if they
can be considered bugfixes.
Thanks,
dimara
v2:
* remove duplicate check for sg inside
Until now, an SG device was identified only by checking if its path
started with /dev/sg. Then, hdev_open() set bs-sg accordingly.
This is very fragile, e.g. it fails with symlinks or relative paths.
We should rely on the actual properties of the device instead of the
specified file path.
Test
Get rid of several #ifdef DEBUG_FLOPPY and substitute them with
DPRINTF.
Signed-off-by: Dimitris Aragiorgis dim...@arrikto.com
---
block/raw-posix.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index
This will allow clients to query additional information directly using
qom-get on the CPU objects.
Reviewed-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Andreas Färber afaer...@suse.de
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v1 - v2:
* Renamed field from
On 05/08/2015 10:22 AM, John Snow wrote:
I'm a bit surprised - making a function call per byte generally executes
more instructions than open-coding the conversion (albeit the branch
prediction in the hardware probably does fairly well over long strings,
since it is a tight and predictable
On 05/07/2015 07:12 PM, Wen Congyang wrote:
The function bdrv_clear_dirty_bitmap() is updated to use
faster hbitmap_reset_all() call.
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Am 08.05.2015 um 15:55 schrieb Kevin Wolf:
Am 08.05.2015 um 15:14 hat Max Reitz geschrieben:
On 07.05.2015 17:16, Zhe Qiu wrote:
In reference to b0ad5a45...078a458e, metadata writes to
qcow2/cow/qcow/vpc/vmdk are all synced prior to succeeding writes.
Only when write is successful that
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
In the block layer functions that determine options for a child block
device, it's a common pattern to either copy options from the parent's
options or to set a default string if the option isn't explicitly set
yet for the child. Provide convenience
Hi all,
These are patches I've been working on for some time now.
Since emulation of atomic instructions is recently getting
attention([1], [2]), I'm submitting them for comment.
[1] http://thread.gmane.org/gmane.comp.emulators.qemu/314406
[2]
Having the physical address in the TLB entry will allow us
to portably obtain the physical address of a memory access,
which will prove useful when implementing a scalable emulation
of atomic instructions.
Signed-off-by: Emilio G. Cota c...@braap.org
---
cputlb.c| 1 +
This will be used by the atomic instruction emulation code.
Signed-off-by: Emilio G. Cota c...@braap.org
---
include/qemu/tiny_set.h | 90 +
1 file changed, 90 insertions(+)
create mode 100644 include/qemu/tiny_set.h
diff --git
Signed-off-by: Emilio G. Cota c...@braap.org
---
aie-helper.c | 179 ++
include/exec/cpu-defs.h | 5 ++
include/qemu/aie-helper.h | 21 ++
3 files changed, 205 insertions(+)
create mode 100644 aie-helper.c
create mode 100644
Signed-off-by: Emilio G. Cota c...@braap.org
---
Makefile.target| 1 +
aie.c | 52
include/qemu/aie.h | 48
translate-all.c| 2 ++
4 files changed, 103 insertions(+)
This will be used by atomic instruction emulation code.
Signed-off-by: Emilio G. Cota c...@braap.org
---
include/qemu/radix-tree.h | 29 ++
util/Makefile.objs| 2 +-
util/radix-tree.c | 77 +++
3 files changed, 107
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf kw...@redhat.com
---
Might want to include mention of what it will be used for in the commit
body.
include/qapi/qmp/qdict.h | 1 +
qobject/qdict.c | 68
+---
2 files
Signed-off-by: Emilio G. Cota c...@braap.org
---
linux-user/main.c | 89 -
target-arm/helper.c| 2 +
target-arm/helper.h| 2 +
target-arm/op_helper.c | 5 ++
target-arm/translate.c | 172 ++---
5 files
This will be used by the atomic instruction emulation code.
Signed-off-by: Emilio G. Cota c...@braap.org
---
softmmu_template.h | 48
tcg/tcg.h | 5 +
2 files changed, 53 insertions(+)
diff --git a/softmmu_template.h
Signed-off-by: Emilio G. Cota c...@braap.org
---
target-i386/helper.h | 6 +-
target-i386/mem_helper.c | 19 +++--
target-i386/translate.c | 176 ---
3 files changed, 122 insertions(+), 79 deletions(-)
diff --git a/target-i386/helper.h
On 05/08/2015 11:47 AM, Dimitris Aragiorgis wrote:
Building the QEMU tools fails if we #define DEBUG_BLOCK inside
block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
a simple DPRINTF().
Signed-off-by:
On 05/08/2015 11:10 AM, Andreas Färber wrote:
Hi Daniel/Paolo,
Am 01.05.2015 um 12:30 schrieb Daniel P. Berrange:
It is reasonably common to want to create an object, set a
number of properties, register it in the hierarchy and then
mark it as complete (if a user creatable type). This
On 05/08/2015 02:06 PM, Eric Blake wrote:
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf kw...@redhat.com
---
Might want to include mention of what it will be used for in the commit
body.
include/qapi/qmp/qdict.h | 1 +
qobject/qdict.c | 68
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Besides standardising on a single interface for opening child nodes,
this simplifies the .bdrv_open() implementation of the quorum block
driver by using block layer functionality for handling BlockdevRefs.
Signed-off-by: Kevin Wolf kw...@redhat.com
Right now, NBD includes potentially platform-specific error values in
the wire protocol.
Luckily, most common error values are more or less universal: in
particular, of all errno values = 34 (up to ERANGE), they are all the
same on supported platforms except for 11 (which is EAGAIN on Windows and
The following changes since commit 498147529d1f8e902e6528a0115143b53475791e:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150430' into
staging (2015-04-30 14:15:56 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to
From: Denis V. Lunev d...@openvz.org
Replace call of cpu_is_bsp(s-cpu) which really returns
!!(s-apicbase MSR_IA32_APICBASE_BSP)
with directly collected value. Due to this the tracepoint
trace_cpu_get_apic_base((uint64_t)s-apicbase);
will not be hit anymore in apic_reset_common.
Let kvm_arch_post_run convert fields in the kvm_run struct to MemTxAttrs.
These are then passed to address_space_rw.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/sysemu/kvm.h | 3 ++-
kvm-all.c| 21 -
target-arm/kvm.c | 4 +++-
From: Emilio G. Cota c...@braap.org
The codebase doesn't build without __thread support.
Formalise this requirement by adding a check for it in the
configure script.
Signed-off-by: Emilio G. Cota c...@braap.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
configure | 11 +++
1
From: Thomas Huth th...@redhat.com
valgrind complains here about uninitialized bytes with the following message:
==17814== Syscall param ioctl(generic) points to uninitialised byte(s)
==17814==at 0x466A780: ioctl (in /usr/lib64/power8/libc-2.17.so)
==17814==by 0x100735B7: kvm_vm_ioctl
From: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
memory.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/memory.c b/memory.c
index 0f6cb81..8fe6d79 100644
--- a/memory.c
+++
Once address_space_translate will be called outside the BQL, the returned
MemoryRegion might disappear as soon as the RCU read-side critical section
ends. Avoid this by moving the critical section to the callers.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Message-Id:
Am 08.05.2015 um 14:48 schrieb Paolo Bonzini:
From: Denis V. Lunev d...@openvz.org
Replace call of cpu_is_bsp(s-cpu) which really returns
!!(s-apicbase MSR_IA32_APICBASE_BSP)
with directly collected value. Due to this the tracepoint
trace_cpu_get_apic_base((uint64_t)s-apicbase);
From: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
memory.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/memory.c b/memory.c
index 8fe6d79..03c536b 100644
--- a/memory.c
+++
I tested it on host-btrfs, guest-ext4, (connected to guest via virtualized
IDE) with 1G VDI image, testing with dbench 10:
synced:
Writeback: 39.4852M/s 326.812ms
Unsafe: 432.72M/s 1029.313ms
normal:
Writeback: 39.1884M/s 311.383ms
Unsafe: 413.592M/s 280.951ms
Although I hear that dbench is not
On 08/05/2015 14:38, Max Reitz wrote:
Two things follow: First, our implementation will behave differently
from nbd-server. Second, even if we don't care, werror=enospc will only
work with qemu-nbd, and not when using nbd-server.
I've sent a patch to fix this for nbd-server too.
However,
On 08.05.2015 12:08, Kevin Wolf wrote:
Am 07.05.2015 um 16:50 hat Paolo Bonzini geschrieben:
On 07/05/2015 16:34, Kevin Wolf wrote:
Am 07.05.2015 um 16:16 hat Paolo Bonzini geschrieben:
On 07/05/2015 16:07, Kevin Wolf wrote:
This is not right for two reasons: The first is that this is
If anyone feels like adding himself to the list, just sent me a patch.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration/ram.c| 4
migration/savevm.c | 4
2 files changed, 8 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 38ebf6d..61150a5 100644
---
On 08.05.2015 14:45, Max Reitz wrote:
On 07.05.2015 17:26, Paolo Bonzini wrote:
Right now, NBD includes potentially platform-specific error values in
the wire protocol.
Luckily, most common error values are more or less universal: in
particular, of all errno values = 34 (up to ERANGE), they
On 05/08/2015 06:41 AM, Paolo Bonzini wrote:
On 08/05/2015 14:40, Eric Blake wrote:
On 05/08/2015 03:50 AM, Paolo Bonzini wrote:
Right now, NBD includes potentially platform-specific error values in
the wire protocol.
Do we also want to handle case 0: return 0; on either conversion, or
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 08/05/2015 15:02, Eric Blake wrote:
Do we also want to handle case 0: return 0; on either
conversion, or even case 0: abort(); to ensure that
callers are using these helpers correctly?
Yes, it's much better that way.
Thinking about it a
I would like to offer this, slightly improved implementation. The key thing is
a new
kernel_irqchip_type member in Machine class. Currently it it used only by virt
machine for
its internal purposes, however in future it is to be passed to KVM in
kvm_irqchip_create(). The variable is defined as
On 07.05.2015 06:04, Zhe Qiu wrote:
From: phoeagon phoea...@gmail.com
In reference to
b0ad5a455d7e5352d4c86ba945112011dbeadfb8~078a458e077d6b0db262c4b05fee51d01de2d1d2,
metadata writes to qcow2/cow/qcow/vpc/vmdk are all synced prior to succeeding
writes.
Only when write is successful that
On Thu, May 07, 2015 at 01:22:26PM -0400, John Snow wrote:
On 05/07/2015 10:54 AM, Stefan Hajnoczi wrote:
On Wed, Apr 22, 2015 at 08:04:44PM -0400, John Snow wrote:
+static void block_dirty_bitmap_clear_prepare(BlkTransactionState
*common, +
On 07.05.2015 17:16, Zhe Qiu wrote:
In reference to b0ad5a45...078a458e, metadata writes to
qcow2/cow/qcow/vpc/vmdk are all synced prior to succeeding writes.
Only when write is successful that bdrv_flush is called.
Signed-off-by: Zhe Qiu phoea...@gmail.com
---
block/vdi.c | 3 +++
1 file
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Instead of manually parsing options and then deleting them from the
options QDict, just use QemuOpts like most other places that deal with
block device options.
More options will be added there and then QemuOpts is a lot more
managable than
On 05/08/2015 02:02 PM, Emilio G. Cota wrote:
-#if HOST_LONG_BITS == 32 TARGET_LONG_BITS == 32
-#define CPU_TLB_ENTRY_BITS 4
-#else
+#if TARGET_LONG_BITS == 32
#define CPU_TLB_ENTRY_BITS 5
+#else
+#define CPU_TLB_ENTRY_BITS 6
#endif
Ouch. 24 of 64 wasted bytes for 64-bit?
I wonder if
From: Thomas Huth h...@tuxfamily.org
The functions tpm_backend_thread_tpm_reset() and iothread_find()
are completely unused, let's remove them.
Signed-off-by: Thomas Huth h...@tuxfamily.org
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Besides standardising on a single interface for opening child nodes,
this patch allows the user to specify options to individual extent
nodes. Overriding file names isn't possible with this yet, so it's of
limited usefulness, but still a step forward.
From: Gonglei arei.gong...@huawei.com
Value from xfer-packet.ep is assigned to ep here, but that
stored value is not used before it is overwritten. Remove it.
Cc: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
Change abandoned by Mike Perez (thin...@gmail.com) on branch: master
Review: https://review.openstack.org/143575
Reason: No activity for over a month.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On 5/8/15 11:14, Peter Maydell wrote:
On 7 May 2015 at 22:05, Chen Gang xili_gchen_5...@hotmail.com wrote:
Since no response, I assume that it is not suitable to send patches
before finish printing hello world successfully (when sending patches,
we should be sure of the patches are valuable
Here's a next trivial-patches tree pull request. There aren't many patches
this time, but one of them (replacing assert with g_assert) is a build fix.
Please consider applying.
Thanks,
/mjt
The following changes since commit f8340b360b9bc29d48716ba8aca79df2b9544979:
hw/ptimer: Do not
include/glib-compat.h defines a bunch of functions based on glib primitives,
and uses assert() without including assert.h. Replace assert() with
g_assert() to make the file more self-contained, and to fix compilation
breakage after 28507a415a9b1e.
Reported-by: Laurent Desnogues
From: Alberto Garcia be...@igalia.com
Label the size and offset fields in BLOCK_IMAGE_CORRUPTED as
optional, and clarify that the latter refers to the host's offset into
the image.
Signed-off-by: Alberto Garcia be...@igalia.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Michael
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Instead of letting every caller of bdrv_open() determine the right flags
for its child node manually and pass them to the function, pass the
parent node and the role of the newly opened child (like backing file,
protocol layer, etc.).
Signed-off-by:
From: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
block/sheepdog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/sheepdog.c
On Fri, May 08, 2015 at 17:02:11 -0400, Emilio G. Cota wrote:
+++ b/aie.c
(snip)
+static inline void *aie_entry_init(unsigned long index)
+{
+AIEEntry *entry;
+
+entry = qemu_memalign(64, sizeof(*entry));
+tiny_set_init(entry-ts);
+qemu_mutex_init(entry-lock);
+return
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf kw...@redhat.com
---
blockdev.c| 24
include/block/block.h | 8
2 files changed, 20 insertions(+), 12 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
This allows iterating over all children of a given BDS, not only
including bs-file and bs-backing_hd, but also driver-specific
ones like VMDK extents or Quorum children.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 27
Am 08.05.2015 um 14:07 schrieb Paolo Bonzini:
The following changes since commit 498147529d1f8e902e6528a0115143b53475791e:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150430' into
staging (2015-04-30 14:15:56 +0100)
are available in the git repository at:
Am 08.05.2015 um 14:07 schrieb Paolo Bonzini:
From: Denis V. Lunev d...@openvz.org
Replace call of cpu_is_bsp(s-cpu) which really returns
!!(s-apicbase MSR_IA32_APICBASE_BSP)
with directly collected value. Due to this the tracepoint
trace_cpu_get_apic_base((uint64_t)s-apicbase);
On 05/05/2015 17:37, Andreas Färber wrote:
Thanks, queued for 2.4.
Objection. None of the QOM patches have been reviewed by me and you knew
I would be back today.
No, I didn't. I didn't even know you were away, I thought you were
simply busy with something else.
Paolo
Hi Paolo,
Thanks for your reply. I just check whether I need to respin this
patchset. I will look at the virtio-balloon.
Thanks,
Shannon
On 2015/5/8 14:53, Paolo Bonzini wrote:
No, he is on vacation this week. Sorry for the delay!
Of you are doing cleanups in virtio, perhaps you can look
On Fri, May 08, 2015 at 02:29:01PM +0200, Andreas Färber wrote:
Am 08.05.2015 um 14:07 schrieb Paolo Bonzini:
The following changes since commit 498147529d1f8e902e6528a0115143b53475791e:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150430' into
staging (2015-04-30
Am 08.05.2015 um 14:31 schrieb Paolo Bonzini:
On 05/05/2015 17:37, Andreas Färber wrote:
Thanks, queued for 2.4.
Objection. None of the QOM patches have been reviewed by me and you knew
I would be back today.
No, I didn't. I didn't even know you were away, I thought you were
simply busy
On 05/08/2015 04:27 AM, Paolo Bonzini wrote:
On 08/05/2015 12:12, Markus Armbruster wrote:
The corresponding patch to the NBD protocol description can be found at
http://article.gmane.org/gmane.linux.drivers.nbd.general/3154.
[...]
- EFBIG is part of the universal set of errors, but
On 08.05.2015 12:21, Paolo Bonzini wrote:
This ensures that werror=enospc works fine for NBD-backed devices.
Recovery can be done through live snapshots even if the NBD server
does not support online resizing.
Suggested-by: Kevin Wolf kw...@redhat.com
Cc: qemu-sta...@nongnu.org
Signed-off-by:
To all 'patches' tool users,
The patches database at the official URL is now being updated again:
$ patches fetch http://wiki.qemu.org/patches/patches.json
For the past year or so I published the patches database on my
personal domain. This sometimes caused confusion since the official
QEMU URL
Am 08.05.2015 um 14:34 schrieb Daniel P. Berrange:
On Fri, May 08, 2015 at 02:29:01PM +0200, Andreas Färber wrote:
Am 08.05.2015 um 14:07 schrieb Paolo Bonzini:
The following changes since commit 498147529d1f8e902e6528a0115143b53475791e:
Merge remote-tracking branch
Currently, it exits until each error, so if you are installing on a new
machine, it requires lots of configure runs until you get all the
dependencies that you need. With this change, it shows all the errors
with the selected configured options.
Signed-off-by: Juan Quintela quint...@redhat.com
On Fri, May 08, 2015 at 02:39:57PM +0200, Andreas Färber wrote:
Am 08.05.2015 um 14:34 schrieb Daniel P. Berrange:
On Fri, May 08, 2015 at 02:29:01PM +0200, Andreas Färber wrote:
Am 08.05.2015 um 14:07 schrieb Paolo Bonzini:
The following changes since commit
On 05/08/2015 03:50 AM, Paolo Bonzini wrote:
Right now, NBD includes potentially platform-specific error values in
the wire protocol.
Luckily, most common error values are more or less universal: in
particular, of all errno values = 34 (up to ERANGE), they are all the
same on supported
To make changes easier, with the copy, I maintained almost all include
files. Now I remove the not needed ones on this patch. This complies
on linux x64 with all architecutes configured, and cross-compile for
windows 32 and 64 bits.#
Signed-off-by: Juan Quintela quint...@redhat.com
---
Now, everything is in place.
Signed-off-by: Juan Quintela quint...@redhat.com
---
MAINTAINERS| 1 -
Makefile.target| 4 ++--
savevm.c = migration/savevm.c | 0
trace-events | 2 +-
4 files changed, 3 insertions(+), 4 deletions(-)
rename
On 07.05.2015 17:26, Paolo Bonzini wrote:
This is consistent with the handling of writes.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
nbd.c | 6 ++
1 file changed, 6 insertions(+)
Reviewed-by: Max Reitz mre...@redhat.com
Hi
This do:
- split ram migration bits from arch_init.c into migration/ram.c
- move savevm.c into migration/
- add myself to the copyright list of that files
if you feel your name should be there, jsut sent one patch
- to spot changes easily, I reduce the include mess for arch_init.c
and
Add new arg sub-argument to the --semihosting-config allowing to pass
multiple input argument separately. It is required for example by UHI
semihosting to construct argc and argv.
Signed-off-by: Leon Alrae leon.al...@imgtec.com
---
include/exec/semihost.h | 12
qemu-options.hx
Hi,
This patch series adds arg= sub-option to --semihosting-config group. It
allows building up a list of input arguments as it can appear multiple
times in the command line. This is a flexible solution for creating
argc/argv for the guest program (needed by UHI semihosting for example).
RFC
On 08/05/2015 13:38, Dimitris Aragiorgis wrote:
Building the QEMU tools fails if we #define DEBUG_BLOCK inside
block/raw-posix.c. This happens because qemu-log.o is missing from
block-obj-y, which causes the link to fail. Fix this.
Signed-off-by: Dimitris Aragiorgis dim...@arrikto.com
Remove semihosting_enabled and semihosting_target and replace them with
SemihostingConfig structure containing equivalent fields. The structure
is defined in vl.c where it is actually set.
Also introduce separate header file include/exec/semihost.h allowing to
access semihosting config related
On 08/05/2015 13:38, Dimitris Aragiorgis wrote:
Until now, an SG device was identified only by checking if its path
started with /dev/sg. Then, hdev_open() set bs-sg accordingly.
This is very fragile, e.g. it fails with symlinks or relative paths.
We should rely on the actual properties of
On 08/05/2015 13:38, Dimitris Aragiorgis wrote:
During migration, QEMU uses fsync()/fdatasync() on the open file
descriptor for read-write block devices to flush data just before
stopping the VM.
However, fsync() on a scsi-generic device returns -EINVAL which
causes the migration to fail.
This makes xhci generate multiple short packet events in case of
multi-trb transfers. Which is wrong. We need to fix this in a
different way.
This reverts commit aa6857891df614c620e6e9fc4bc4af6e0e49cafd.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 15 +++
When we find a IOC bit set on a setup trb and therefore queue an event,
that should not stop events being generated for following data trbs.
So clear the 'reported' flag.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 8
1 file changed, 8 insertions(+)
diff
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index ba15ae0..2af3dd6 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2224,6 +2224,8 @@ static void xhci_kick_ep(XHCIState
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/dev-bluetooth.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/usb/dev-bluetooth.c b/hw/usb/dev-bluetooth.c
index
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/dev-wacom.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c
index 844eafa..c2450e7
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/dev-smartcard-reader.c | 50 ---
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git
From: Gonglei arei.gong...@huawei.com
Cc: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-uhci.c | 43 +++
1 file changed, 31 insertions(+), 12 deletions(-)
diff
On Fri 08 May 2015 11:47:00 AM CEST, Kevin Wolf wrote:
There's also the problem that with a single chunk of memory for all
cache tables it's not so easy to free individual entries.
That's one of the reasons why I suggested to fix the problem by using
mmap() for the individual entries rather
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/dev-mtp.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 108ece8..c9c1f32
From: Gonglei arei.gong...@huawei.com
When x-root property not be configured, will cause segfault
because of null pointer accessing. Add a check for s-root
property avoid segfault.
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/dev-mtp.c
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/dev-serial.c | 43 +++
1 file changed, 27 insertions(+), 16 deletions(-)
diff --git a/hw/usb/dev-serial.c
Allow ui code to check whenever the emulated
display supports display change notifications.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
include/ui/console.h | 1 +
ui/console.c | 7 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/ui/console.h
Move various gtk bits (includes, data structures) to a header file.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
include/ui/gtk.h | 76
ui/gtk.c | 73 ++---
2 files changed, 78
From: Thomas Huth th...@redhat.com
valgrind complains here about uninitialized bytes with the following message:
==17814== Syscall param ioctl(generic) points to uninitialised byte(s)
==17814==at 0x466A780: ioctl (in /usr/lib64/power8/libc-2.17.so)
==17814==by 0x100735B7: kvm_vm_ioctl
From: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
memory.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/memory.c b/memory.c
index 8fe6d79..03c536b 100644
--- a/memory.c
+++
201 - 300 of 343 matches
Mail list logo
