[Qemu-devel] [RFC v1 2/3] target-microblaze: Allow the stack protection to be disabled

2015-05-13 Thread Alistair Francis
Microblaze stack protection is configurable and isn't always enabled. This patch allows the stack protection to be disabled from the CPU properties. Signed-off-by: Alistair Francis --- target-microblaze/cpu-qom.h |5 + target-microblaze/cpu.c |2 ++ target-microblaze/op_help

[Qemu-devel] [RFC v1 1/3] target-microblaze: Fix up indentation

2015-05-13 Thread Alistair Francis
Fix up the incorrect indentation level in the helper_stackprot() function. Signed-off-by: Alistair Francis --- target-microblaze/op_helper.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-microblaze/op_helper.c b/target-microblaze/op_helper.c index a4c8

Re: [Qemu-devel] [PATCH v2 0/5] virtio-test: Test case update

2015-05-13 Thread Fam Zheng
Ping?

Re: [Qemu-devel] [PATCH v3 0/6] block: Mirror discarded sectors

2015-05-13 Thread Fam Zheng
On Tue, 05/12 19:48, Fam Zheng wrote: > This fixes the mirror assert failure reported by wangxiaolong: > > https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg04458.html > Cc: qemu-sta...@nongnu.org

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-13 Thread Michael S. Tsirkin
On Wed, May 13, 2015 at 10:29:42AM -0700, Sean O. Stalley wrote: > On Wed, May 13, 2015 at 08:09:46AM +0200, Michael S. Tsirkin wrote: > > On Tue, May 12, 2015 at 02:23:07PM -0700, Sean O. Stalley wrote: > > > On Tue, May 12, 2015 at 11:33:49AM +0200, Michael S. Tsirkin wrote: > > > > On Mon, May 1

[Qemu-devel] [PATCH 3/4] rocker: bring link up/down on PHY enable/disable

2015-05-13 Thread sfeldma
From: Scott Feldman When the OS driver enables/disables the port, go ahead and set the port's link status to up/down in response to the change. This more closely emulates real hardware when the PHY for the port is brought up/down and the PHY negotiates carrier (link status) with link partner. I

[Qemu-devel] [PATCH 4/4] qmp/hmp: add rocker device support

2015-05-13 Thread sfeldma
From: Scott Feldman Add QMP/HMP support for rocker devices. This is mostly for debugging purposes to see inside the device's tables and port configurations. Some examples: (qemu) info rocker sw1 name: sw1 id: 0x013512005452 ports: 4 (qemu) info rocker-ports sw1 ena/speed/

[Qemu-devel] [PATCH 1/4] rocker: Add support for phys name

2015-05-13 Thread sfeldma
From: David Ahern Add ROCKER_TLV_CMD_PORT_SETTINGS_PHYS_NAME to port settings. This attribute exports the port name to the guest OS allowing it to name interfaces with sensible defaults. Mostly done by Scott for phys_id support; adapted to phys_name by David. Signed-off-by: Scott Feldman Signe

[Qemu-devel] [PATCH 2/4] rocker: update tests using hw-derived interface names

2015-05-13 Thread sfeldma
From: Scott Feldman With previous patch to support phy name attribute for each port, the OS can name port interfaces using the hw-derived name. So update rocker tests to use the new hw-derived interface names. Signed-off-by: Scott Feldman --- tests/rocker/bridge | 25 ++

[Qemu-devel] [PATCH 0/4] rocker device updates

2015-05-13 Thread sfeldma
From: Scott Feldman Some rocker device updates we've been holding onto waiting for base rocker device to be pulled into 2.4. David added support for the device to return the physical port name, which in turn can be used by the OS to name the interface. I added a small change the bringe link up/d

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Michael S. Tsirkin
On Thu, May 14, 2015 at 06:38:24AM +0200, Stefan Weil wrote: > Am 13.05.2015 um 20:15 schrieb Stefano Stabellini: > >On Wed, 13 May 2015, Daniel P. Berrange wrote: > >>On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > >>>Do not emulate a floppy drive if no drives are supposed to

Re: [Qemu-devel] [PATCH v2 02/11] block: Add op blocker notifier list

2015-05-13 Thread Fam Zheng
On Wed, 05/13 17:28, Fam Zheng wrote: > +static void bdrv_op_blocker_notify(BlockDriverState *bs, BlockOpType op, > + Error *reason, bool blocking) > +{ > +BlockOpEvent event = (BlockOpEvent) { > +op = op, > +reason = reason, > +blocking

Re: [Qemu-devel] [RFC PATCH v2 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2

2015-05-13 Thread Fam Zheng
On Thu, 05/14 11:34, Fam Zheng wrote: > Patch 1 adds a stub for qemu_set_fd_handler which will be referenced in coming > patches. > > Patch 2 converts qemu-nbd which compares two global numbers in the > fd_read_poll > callback. > > Patches 2~5 converts the four net devices, all of which checks >

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Stefan Weil
Am 13.05.2015 um 20:15 schrieb Stefano Stabellini: On Wed, 13 May 2015, Daniel P. Berrange wrote: On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: Do not emulate a floppy drive if no drives are supposed to be present. This fixes the behavior of -nodefaults, that should remov

Re: [Qemu-devel] [RFC PATCH v2 13/13] iohandler: Use AioContext internally

2015-05-13 Thread Fam Zheng
On Thu, 05/14 11:34, Fam Zheng wrote: > AioContext and iohandler share the same concept except that AioContext > is more generalized - it runs on an AioContext which could be on the > main thread or an iothread. Similar to the relation of qemu_bh_new and > aio_bh_new, the iohandler is the special c

Re: [Qemu-devel] [PATCH 4/8] introduce dpcd module.

2015-05-13 Thread Peter Crosthwaite
On Wed, May 13, 2015 at 12:12 PM, wrote: > From: KONRAD Frederic > > This introduces a DPCD modules. It wires on a aux-bus and can be accessed by > driver to get lane-speed, etc. > > Signed-off-by: KONRAD Frederic > --- > hw/display/Makefile.objs | 1 + > hw/display/dpcd.c| 139 > ++

Re: [Qemu-devel] [PATCH 2/8] i2c: implement broadcast write.

2015-05-13 Thread Peter Crosthwaite
On Wed, May 13, 2015 at 12:12 PM, wrote: > From: KONRAD Frederic > > This does a write to every slaves when the I2C bus get a write to address 0. > "slave" > Signed-off-by: KONRAD Frederic > --- > hw/i2c/core.c | 46 +- > 1 file changed, 45 inserti

Re: [Qemu-devel] [PATCH v3 08/14] qapi: Make c_type() consistently convert qapi names

2015-05-13 Thread Eric Blake
On 05/07/2015 01:39 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Continuing the string of cleanups for supporting downstream names >> containing '.', this patch focuses on ensuring c_type() can >> handle a downstream name. This patch alone does not fix the >> places where generator out

[Qemu-devel] [RFC PATCH v2 13/13] iohandler: Use AioContext internally

2015-05-13 Thread Fam Zheng
AioContext and iohandler share the same concept except that AioContext is more generalized - it runs on an AioContext which could be on the main thread or an iothread. Similar to the relation of qemu_bh_new and aio_bh_new, the iohandler is the special case of AioContext which happens to run on the

[Qemu-devel] [RFC PATCH v2 11/13] xen_backend: Remove unused error handling of qemu_set_fd_handler

2015-05-13 Thread Fam Zheng
The function cannot fail, so the check is superfluous. Signed-off-by: Fam Zheng --- hw/xen/xen_backend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index b2cb22b..2510e2e 100644 --- a/hw/xen/xen_backend.c +++ b/hw/xen/xen_ba

[Qemu-devel] [RFC PATCH v2 08/13] main-loop: Drop qemu_set_fd_handler2

2015-05-13 Thread Fam Zheng
All users are converted to qemu_set_fd_handler now, drop qemu_set_fd_handler2 and IOHandlerRecord.fd_read_poll. Signed-off-by: Fam Zheng --- include/block/aio.h | 2 +- include/qemu/main-loop.h | 49 +--- iohandler.c | 26 +--

[Qemu-devel] [RFC PATCH v2 12/13] event-notifier: Always return 0 for posix implementation

2015-05-13 Thread Fam Zheng
qemu_set_fd_handler cannot fail, let's always return 0. Signed-off-by: Fam Zheng --- util/event_notifier-posix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c index 8442c6e..ed4ca2b 100644 --- a/util/event_notifier

[Qemu-devel] [RFC PATCH v2 09/13] alsaaudio: Remove unused error handling of qemu_set_fd_handler

2015-05-13 Thread Fam Zheng
The function cannot fail, so the check is superfluous. Signed-off-by: Fam Zheng --- audio/alsaaudio.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 74ead97..ed7655d 100644 --- a/audio/alsaaudio.c +++ b/audio/alsa

[Qemu-devel] [RFC PATCH v2 10/13] oss: Remove unused error handling of qemu_set_fd_handler

2015-05-13 Thread Fam Zheng
The function cannot fail, so the check is superfluous. Signed-off-by: Fam Zheng --- audio/ossaudio.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index 4db2ca6..b9c6b30 100644 --- a/audio/ossaudio.c +++ b/audio/ossaudio.c

[Qemu-devel] [RFC PATCH v2 07/13] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler

2015-05-13 Thread Fam Zheng
Done with following Coccinelle semantic patch, plus manual cosmetic changes in net/*.c. @@ expression E1, E2, E3, E4; @@ - qemu_set_fd_handler2(E1, NULL, E2, E3, E4); + qemu_set_fd_handler(E1, E2, E3, E4); Signed-off-by: Fam Zheng --- blockdev-nbd.c | 4 ++-- ma

[Qemu-devel] [RFC PATCH v2 03/13] l2tpv3: Drop l2tpv3_can_send

2015-05-13 Thread Fam Zheng
This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration. This is redundant with checks inside read callback. After this patch, the data will be copied from s->fd to s->msgvec when it arrives. If the device can't receive, it will b

[Qemu-devel] [RFC PATCH v2 06/13] tap: Drop tap_can_send

2015-05-13 Thread Fam Zheng
This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration. This is redundant with checks inside read callback. After this patch, the data will be sent to peer when it arrives. If the device can't receive, it will be queued to incomi

[Qemu-devel] [RFC PATCH v2 04/13] netmap: Drop netmap_can_send

2015-05-13 Thread Fam Zheng
This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration. This is redundant with checks inside read callback. After this patch, the data will be copied from s->fd to s->iov when it arrives. If the device can't receive, it will be q

[Qemu-devel] [RFC PATCH v2 02/13] qemu-nbd: Switch to qemu_set_fd_handler

2015-05-13 Thread Fam Zheng
Achieved by: - Remembering the server fd with a global variable, in order to access it from nbd_client_closed. - Checking nbd_can_accept() and updating server_fd handler whenever client connects or disconnects. Signed-off-by: Fam Zheng Reviewed-by: Paolo Bonzini --- qemu-nbd.c | 21 ++

[Qemu-devel] [RFC PATCH v2 05/13] net/socket: Drop net_socket_can_send

2015-05-13 Thread Fam Zheng
This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration. This is redundant with checks inside read callback. After this patch, the data will be sent to peer when it arrives. If the device can't receive, it will be queued to incomi

[Qemu-devel] [RFC PATCH v2 01/13] stubs: Add qemu_set_fd_handler

2015-05-13 Thread Fam Zheng
Some qemu_set_fd_handler2 stub callers will be converted to call qemu_set_fd_handler, add this stub for them before making the change. Signed-off-by: Fam Zheng --- stubs/set-fd-handler.c | 8 1 file changed, 8 insertions(+) diff --git a/stubs/set-fd-handler.c b/stubs/set-fd-handler.c i

[Qemu-devel] [RFC PATCH v2 00/13] main-loop: Get rid of fd_read_poll and qemu_set_fd_handler2

2015-05-13 Thread Fam Zheng
v2: Add Paolo's rev-by in patch 2. Remove local "can_send" in patch 6. (Paolo) This carries out the mandate in the comment of qemu_set_fd_handler2 and removes fd_read_poll from the code base, because it will make the work easier to convert ppoll to epoll in main loop, as well as convert iohand

Re: [Qemu-devel] [PATCH 8/8] arm: xlnx-zynqmp: Add DisplayPort and DPDMA.

2015-05-13 Thread Peter Crosthwaite
On Wed, May 13, 2015 at 12:12 PM, wrote: > From: KONRAD Frederic > > This adds the DP and the DPDMA to the Zynq MP. > > Signed-off-by: KONRAD Frederic > --- > hw/arm/xlnx-zynqmp.c | 23 +++ > include/hw/arm/xlnx-zynqmp.h | 4 > 2 files changed, 27 insertions(+

Re: [Qemu-devel] [PATCH v2 11/11] block: Block "device IO" during bdrv_drain and bdrv_drain_all

2015-05-13 Thread Fam Zheng
On Wed, 05/13 17:25, Paolo Bonzini wrote: > > > On 13/05/2015 17:17, Fam Zheng wrote: > >> > > >> > It can be the topic of a separate series. But this patch brings a > >> > false sense of security (either the blocker is unnecessary, or it > >> > needs to last after bdrv_drain returns), so I thi

Re: [Qemu-devel] [PATCH v2 01/11] block: Add op blocker type "device IO"

2015-05-13 Thread Fam Zheng
On Wed, 05/13 17:09, Paolo Bonzini wrote: > > > On 13/05/2015 17:02, Fam Zheng wrote: > >> > For example, SCSI requests can result in many consecutive I/Os: > >> > > >> > (1) FUA requests are split in write+flush > >> > > >> > (2) adapters that do not use QEMUSGList-based I/O only read 128K at

Re: [Qemu-devel] [PATCH] block: Let bdrv_drain_all() to call aio_poll() for each AioContext

2015-05-13 Thread Fam Zheng
On Wed, 05/13 19:34, Alexander Yarygin wrote: > Paolo Bonzini writes: > > > On 13/05/2015 17:18, Alexander Yarygin wrote: > >> After the commit 9b536adc ("block: acquire AioContext in > >> bdrv_drain_all()") the aio_poll() function got called for every > >> BlockDriverState, in assumption that ev

Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction

2015-05-13 Thread Fam Zheng
On Thu, 05/14 09:12, Wen Congyang wrote: > We will use bdrv_op_block_all() in the job, and don't unblock > BLOCK_OP_TYPE_DEVICE_IO. > Is it OK? Good question and you're right, it's broken in this series. I will fix it. Fam

Re: [Qemu-devel] [PATCH v2 10/11] blockdev: Block device IO during blockdev-backup transaction

2015-05-13 Thread Wen Congyang
On 05/13/2015 08:55 PM, Fam Zheng wrote: > On Wed, 05/13 19:22, Wen Congyang wrote: >> On 05/14/2015 01:28 AM, Fam Zheng wrote: >>> Signed-off-by: Fam Zheng >>> --- >>> blockdev.c | 10 +- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/blockdev.c b/blockdev.c >>>

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Maciej W. Rozycki
On Wed, 13 May 2015, Richard Henderson wrote: > >> I believe the problem is that MSA vector register's size is 16-bytes > >> (this DATA_SIZE isn't supported in softmmu_template) and MSA load/store > >> is supposed to be atomic. > > > > Not really AFAICT. Here's what the specification says[1]: >

[Qemu-devel] virtio: Question on VRING_DESC_F_WRITE flag

2015-05-13 Thread Subhashini Venkataraman
Hi, I have a question on VRING_DESC_F_WRITE flag. As per the specifications, if this flag is set, then the corresponding buffer pointed by the descriptor is Write only, otherwise Read Only. I am trying to understand why there is no READ_AND_WRITE option, i.e. a buffer could be Read by device

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-13 Thread Michael S. Tsirkin
On Wed, May 13, 2015 at 08:57:00PM +0200, Christian Borntraeger wrote: > Am 13.05.2015 um 18:14 schrieb Michael S. Tsirkin: > >> - AFAICS, there's no easy way to add transport-specific subsections - > >> and simply adding config_vector in ccw would break compatibility > > > > subsections break c

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread John Snow
On 05/13/2015 02:15 PM, Stefano Stabellini wrote: > On Wed, 13 May 2015, Daniel P. Berrange wrote: >> On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: >>> Do not emulate a floppy drive if no drives are supposed to be present. >>> >>> This fixes the behavior of -nodefaults, that

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Michael S. Tsirkin
On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > Do not emulate a floppy drive if no drives are supposed to be present. > > This fixes the behavior of -nodefaults, that should remove the floppy > drive (see docs/qdev-device-use.txt:Default Devices), but actually > doesn't. >

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Richard Henderson
On 05/13/2015 02:21 PM, Maciej W. Rozycki wrote: > On Wed, 13 May 2015, Leon Alrae wrote: > >>> Certainly we do. It's all in softmmu_template.h. >> >> I believe the problem is that MSA vector register's size is 16-bytes >> (this DATA_SIZE isn't supported in softmmu_template) and MSA load/store >>

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Richard Henderson
On 05/13/2015 01:59 PM, Leon Alrae wrote: > On 13/05/15 20:58, Richard Henderson wrote: >> On 05/13/2015 12:56 PM, Maciej W. Rozycki wrote: >>> We must have a way to deal with memory access operations issued by a >>> single machine instruction crossing a page boundary already as this is >>> what

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Maciej W. Rozycki
On Wed, 13 May 2015, Leon Alrae wrote: > > Certainly we do. It's all in softmmu_template.h. > > I believe the problem is that MSA vector register's size is 16-bytes > (this DATA_SIZE isn't supported in softmmu_template) and MSA load/store > is supposed to be atomic. Not really AFAICT. Here's

Re: [Qemu-devel] [PATCH 3/3] tcg: Add MO_ALIGN, MO_UNALN

2015-05-13 Thread Richard Henderson
On 05/13/2015 02:15 PM, Peter Maydell wrote: > On 13 May 2015 at 22:08, Richard Henderson wrote: >>> Are unaligned accesses always slow-path, by the way? > > Would it be in theory possible to fast-path MO_UNALN > unaligned accesses if the host CPU supported unaligned > accesses for whatever load/

Re: [Qemu-devel] [PATCH 3/3] tcg: Add MO_ALIGN, MO_UNALN

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 22:08, Richard Henderson wrote: >> Are unaligned accesses always slow-path, by the way? Would it be in theory possible to fast-path MO_UNALN unaligned accesses if the host CPU supported unaligned accesses for whatever load/store insn we use in the TLB hit case? -- PMM

Re: [Qemu-devel] [PATCH 2/3] tcg: Push merged memop+mmu_idx parameter to softmmu routines

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 22:06, Richard Henderson wrote: > On 05/13/2015 01:54 PM, Peter Maydell wrote: >> We don't seem to be very consistent about what type we're using for >> mmu_idx. In the TCG backends changed in patch 1 (and in the >> prototype of this helper which we've just removed) we used 'int'

Re: [Qemu-devel] [PATCH 3/3] tcg: Add MO_ALIGN, MO_UNALN

2015-05-13 Thread Richard Henderson
> /* MO_UNALN accesses are never checked for alignment; MO_ALIGN > * accesses will result in a call to the CPU's do_unaligned_access > * hook if the guest address is not aligned. The default depends > * on whether the target CPU defines ALIGNED_ONLY. > */ Fair enough. > Ar

[Qemu-devel] [PATCH] monitor: suggest running "help" for command errors

2015-05-13 Thread Bandan Das
When a command fails due to incorrect syntax or input, suggest using the "help" command to get more information about the command. This is only applicable for HMP. Before: (qemu) drive_add usb_flash_drive drive_add: string expected After: (qemu) drive_add usb_flash_drive drive_add: string expecte

Re: [Qemu-devel] [PATCH 2/3] tcg: Push merged memop+mmu_idx parameter to softmmu routines

2015-05-13 Thread Richard Henderson
On 05/13/2015 01:54 PM, Peter Maydell wrote: >> @@ -168,10 +168,11 @@ static inline DATA_TYPE glue(io_read, >> SUFFIX)(CPUArchState *env, >> #ifdef SOFTMMU_CODE_ACCESS >> static __attribute__((unused)) >> #endif >> -WORD_TYPE helper_le_ld_name(CPUArchState *env, target_ulong addr, int >> mmu_i

Re: [Qemu-devel] [PATCH 3/3] tcg: Add MO_ALIGN, MO_UNALN

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 20:10, Richard Henderson wrote: > These modifiers control, on a per-memory-op basis, whether > unaligned memory accesses are allowed. The default setting > reflects the target's definition of ALIGNED_ONLY. > > Signed-off-by: Richard Henderson > diff --git a/tcg/tcg.h b/tcg/tcg

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Leon Alrae
On 13/05/15 20:58, Richard Henderson wrote: > On 05/13/2015 12:56 PM, Maciej W. Rozycki wrote: >> We must have a way to deal with memory access operations issued by a >> single machine instruction crossing a page boundary already as this is >> what MIPS16 SAVE and RESTORE instructions as well as

Re: [Qemu-devel] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread John Snow
On 05/13/2015 02:51 PM, Stefan Weil wrote: > Hi, > > I just noticed this patch because my provider told me that my KVM based > server > needs a reboot because of a CVE (see this German news: > http://www.heise.de/newsticker/meldung/Venom-Schwachstelle-Aus-Hypervisor-ausbrechen-und-VMs-ausspionie

Re: [Qemu-devel] [PATCH 2/3] tcg: Push merged memop+mmu_idx parameter to softmmu routines

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 20:09, Richard Henderson wrote: > The extra information is not yet used but it is now available. > This requires minor changes through all of the tcg backends. > > Signed-off-by: Richard Henderson > --- > softmmu_template.h | 50 > +++-

Re: [Qemu-devel] [PATCH 1/3] tcg: Merge memop and mmu_idx parameters to qemu_ld/st

2015-05-13 Thread Richard Henderson
On 05/13/2015 01:46 PM, Peter Maydell wrote: > Don't you also need a corresponding change in tci.c to make > it only read one argument and split it into memop/mmu_idx ? Yes, I unintentionally folded this into patch 2. r~

Re: [Qemu-devel] [PATCH] monitor: print help for command errors

2015-05-13 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > >> Unlike machines, humans will be (mostly) appreciative on seeing >> help output when a command fails due to incorrect syntax or input. >> By default, print output of help_cmd() to the monitor in such cases. >> The only exceptions are if a comman

Re: [Qemu-devel] [PATCH 1/3] tcg: Merge memop and mmu_idx parameters to qemu_ld/st

2015-05-13 Thread Peter Maydell
On 13 May 2015 at 20:09, Richard Henderson wrote: > At the tcg opcode level, not at the tcg-op.h generator level. > This requires minor changes through all of the tcg backends, > but none of the cpu translators. > > Signed-off-by: Richard Henderson > diff --git a/tcg/tci/tcg-target.c b/tcg/tci/t

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Peter Lieven
Am 13.05.2015 um 22:03 schrieb John Snow: > > On 05/13/2015 04:02 PM, Peter Lieven wrote: >> Am 13.05.2015 um 21:52 schrieb Markus Armbruster: >>> Peter Lieven writes: >>> Am 13.05.2015 um 21:09 schrieb Stefan Priebe: > Am 13.05.2015 um 21:05 schrieb Stefan Weil: >> Am 13.05.2015 um 2

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread John Snow
On 05/13/2015 04:02 PM, Peter Lieven wrote: > Am 13.05.2015 um 21:52 schrieb Markus Armbruster: >> Peter Lieven writes: >> >>> Am 13.05.2015 um 21:09 schrieb Stefan Priebe: Am 13.05.2015 um 21:05 schrieb Stefan Weil: > Am 13.05.2015 um 20:59 schrieb Stefan Priebe: >> Am 13.05.2015 u

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Peter Lieven
Am 13.05.2015 um 21:52 schrieb Markus Armbruster: > Peter Lieven writes: > >> Am 13.05.2015 um 21:09 schrieb Stefan Priebe: >>> Am 13.05.2015 um 21:05 schrieb Stefan Weil: Am 13.05.2015 um 20:59 schrieb Stefan Priebe: > Am 13.05.2015 um 20:51 schrieb Stefan Weil: >> Hi, >> >>

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Richard Henderson
On 05/13/2015 12:56 PM, Maciej W. Rozycki wrote: > We must have a way to deal with memory access operations issued by a > single machine instruction crossing a page boundary already as this is > what MIPS16 SAVE and RESTORE instructions as well as microMIPS SWP, SDP, > SWM, SDM, LWP, LDP, LWM a

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Maciej W. Rozycki
On Wed, 13 May 2015, Richard Henderson wrote: > > +static inline void ensure_atomic_msa_block_access(CPUMIPSState *env, > > + target_ulong addr, > > + int rw, > > +

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Markus Armbruster
Peter Lieven writes: > Am 13.05.2015 um 21:09 schrieb Stefan Priebe: >> Am 13.05.2015 um 21:05 schrieb Stefan Weil: >>> Am 13.05.2015 um 20:59 schrieb Stefan Priebe: Am 13.05.2015 um 20:51 schrieb Stefan Weil: > Hi, > > I just noticed this patch because my provider told me t

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Peter Lieven
Am 13.05.2015 um 21:09 schrieb Stefan Priebe: > Am 13.05.2015 um 21:05 schrieb Stefan Weil: >> Am 13.05.2015 um 20:59 schrieb Stefan Priebe: >>> >>> Am 13.05.2015 um 20:51 schrieb Stefan Weil: Hi, I just noticed this patch because my provider told me that my KVM based server >>>

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-13 Thread Richard Henderson
On 05/13/2015 08:37 AM, Yongbok Kim wrote: > +static inline void ensure_atomic_msa_block_access(CPUMIPSState *env, > + target_ulong addr, > + int rw, > +

[Qemu-devel] [PATCH 7/8] Introduce xilinx dp.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DisplayPort. It has an aux-bus to access dpcd and edid needed for the driver to complete. Graphic plane is connected to the channel 3. Video plane is connected to the channel 0. Audio stream are connected to the channels 4 and 5. Signed-o

[Qemu-devel] [PATCH 6/8] Introduce xilinx dpdma.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic --- hw/dma/Makefile.objs |1 + hw/dma/xilinx_dpdma.c | 1149 + hw/dma/xilinx_dpdma.h | 71 +++ 3 files changed, 1221 insertions(+) create mode 1

[Qemu-devel] [PATCH 5/8] hw/i2c-ddc.c: Implement DDC I2C slave

2015-05-13 Thread fred . konrad
From: Peter Maydell Implement an I2C slave which implements DDC and returns the EDID data for an attached monitor. Signed-off-by: Peter Maydell - Rebased on the current master. - Modified for QOM. Signed-off-by: KONRAD Frederic --- hw/i2c/Makefile.objs | 2 +- hw/i2c/i2c-ddc.c | 2

[Qemu-devel] [PATCH 4/8] introduce dpcd module.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This introduces a DPCD modules. It wires on a aux-bus and can be accessed by driver to get lane-speed, etc. Signed-off-by: KONRAD Frederic --- hw/display/Makefile.objs | 1 + hw/display/dpcd.c| 139 +++ hw/display/dpcd

[Qemu-devel] [PATCH 2/8] i2c: implement broadcast write.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This does a write to every slaves when the I2C bus get a write to address 0. Signed-off-by: KONRAD Frederic --- hw/i2c/core.c | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c i

[Qemu-devel] [PATCH 1/8] Introduce AUX bus.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This introduces a new bus: aux-bus. It contains an address space for aux slaves devices and a bridge to an I2C bus for I2C through AUX transactions. Signed-off-by: KONRAD Frederic --- hw/misc/Makefile.objs | 1 + hw/misc/aux.c | 421

[Qemu-devel] [PATCH 8/8] arm: xlnx-zynqmp: Add DisplayPort and DPDMA.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP. Signed-off-by: KONRAD Frederic --- hw/arm/xlnx-zynqmp.c | 23 +++ include/hw/arm/xlnx-zynqmp.h | 4 2 files changed, 27 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c

[Qemu-devel] [PATCH 3/8] console: add qemu_alloc_display_format.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This allows to create a surface with a different format than xrgb. Signed-off-by: KONRAD Frederic Cc: Gerd Hoffmann --- include/ui/console.h | 2 ++ ui/console.c | 25 ++--- 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/

[Qemu-devel] [PATCH 3/3] tcg: Add MO_ALIGN, MO_UNALN

2015-05-13 Thread Richard Henderson
These modifiers control, on a per-memory-op basis, whether unaligned memory accesses are allowed. The default setting reflects the target's definition of ALIGNED_ONLY. Signed-off-by: Richard Henderson --- softmmu_template.h | 72 -- tcg/tcg.h

[Qemu-devel] [PATCH 0/8] Xilinx DisplayPort.

2015-05-13 Thread fred . konrad
From: KONRAD Frederic This is the implementation of the Xilinx DisplayPort and DPDMA This patch-set is rebased on Peter Crosthwaite patch-set currently on the list: http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg01302.html Details of the DPDMA part: * DPDMA is implemented as a QEMU

[Qemu-devel] [PATCH 2/3] tcg: Push merged memop+mmu_idx parameter to softmmu routines

2015-05-13 Thread Richard Henderson
The extra information is not yet used but it is now available. This requires minor changes through all of the tcg backends. Signed-off-by: Richard Henderson --- softmmu_template.h | 50 +++- tcg/aarch64/tcg-target.c | 35 +

[Qemu-devel] [PATCH 1/3] tcg: Merge memop and mmu_idx parameters to qemu_ld/st

2015-05-13 Thread Richard Henderson
At the tcg opcode level, not at the tcg-op.h generator level. This requires minor changes through all of the tcg backends, but none of the cpu translators. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 12 tcg/arm/tcg-target.c | 12 tcg/i386/tcg-ta

[Qemu-devel] [RFC 0/3] Per-memory-op alignment checks

2015-05-13 Thread Richard Henderson
For your consideration, as requested by Peter in response to Yongbok Kim's target-mips misalignment patch set. Build tested on aarch64, arm, ppc64, i386, x86_64, sparc. I'm not able to test mips, ia64, or s390 hosts at the moment. r~ Richard Henderson (3): tcg: Merge memop and mmu_idx parame

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Stefan Priebe
Am 13.05.2015 um 21:05 schrieb Stefan Weil: Am 13.05.2015 um 20:59 schrieb Stefan Priebe: Am 13.05.2015 um 20:51 schrieb Stefan Weil: Hi, I just noticed this patch because my provider told me that my KVM based server needs a reboot because of a CVE (see this German news: http://www.heise.de/n

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Stefan Priebe
Am 13.05.2015 um 21:04 schrieb John Snow: On 05/13/2015 02:59 PM, Stefan Priebe wrote: Am 13.05.2015 um 20:51 schrieb Stefan Weil: Hi, I just noticed this patch because my provider told me that my KVM based server needs a reboot because of a CVE (see this German news: http://www.heise.de/n

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Stefan Weil
Am 13.05.2015 um 20:59 schrieb Stefan Priebe: Am 13.05.2015 um 20:51 schrieb Stefan Weil: Hi, I just noticed this patch because my provider told me that my KVM based server needs a reboot because of a CVE (see this German news: http://www.heise.de/newsticker/meldung/Venom-Schwachstelle-Aus-Hyp

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread John Snow
On 05/13/2015 02:59 PM, Stefan Priebe wrote: > > Am 13.05.2015 um 20:51 schrieb Stefan Weil: >> Hi, >> >> I just noticed this patch because my provider told me that my KVM based >> server >> needs a reboot because of a CVE (see this German news: >> http://www.heise.de/newsticker/meldung/Venom-Sc

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Stefan Priebe
Am 13.05.2015 um 20:51 schrieb Stefan Weil: Hi, I just noticed this patch because my provider told me that my KVM based server needs a reboot because of a CVE (see this German news: http://www.heise.de/newsticker/meldung/Venom-Schwachstelle-Aus-Hypervisor-ausbrechen-und-VMs-ausspionieren-264961

Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector

2015-05-13 Thread Christian Borntraeger
Am 13.05.2015 um 18:14 schrieb Michael S. Tsirkin: >> - AFAICS, there's no easy way to add transport-specific subsections - >> and simply adding config_vector in ccw would break compatibility > > subsections break compatibility too. The only way around that is to set > a flag to skip migrating

Re: [Qemu-devel] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Stefan Weil
Hi, I just noticed this patch because my provider told me that my KVM based server needs a reboot because of a CVE (see this German news: http://www.heise.de/newsticker/meldung/Venom-Schwachstelle-Aus-Hypervisor-ausbrechen-und-VMs-ausspionieren-2649614.html) Am 13.05.2015 um 16:33 schrieb Joh

Re: [Qemu-devel] [PATCH] block: Let bdrv_drain_all() to call aio_poll() for each AioContext

2015-05-13 Thread Alexander Yarygin
Paolo Bonzini writes: > On 13/05/2015 17:18, Alexander Yarygin wrote: >> After the commit 9b536adc ("block: acquire AioContext in >> bdrv_drain_all()") the aio_poll() function got called for every >> BlockDriverState, in assumption that every device may have its own >> AioContext. The bdrv_drain_

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Let bdrv_drain_all() to call aio_poll() for each AioContext

2015-05-13 Thread Alexander Yarygin
Alberto Garcia writes: > On Wed 13 May 2015 05:18:31 PM CEST, Alexander Yarygin > wrote: > >> +if (!aio_ctxs || !g_list_find(aio_ctxs, aio_context)) { >> +busy |= aio_poll(aio_context, busy); >> +aio_ctxs = g_list_append(aio_ctxs, aio_context); >> +

[Qemu-devel] [PATCH] block: Let bdrv_drain_all() to call aio_poll() for each AioContext

2015-05-13 Thread Alexander Yarygin
After the commit 9b536adc ("block: acquire AioContext in bdrv_drain_all()") the aio_poll() function got called for every BlockDriverState, in assumption that every device may have its own AioContext. The bdrv_drain_all() function is called in each virtio_reset() call, which in turn is called for ev

Re: [Qemu-devel] [PATCH] util: socket: Add missing localaddr and localport option for DGRAM socket

2015-05-13 Thread Markus Armbruster
Peter Krempa writes: > The 'socket_optslist' structure does not contain the 'localaddr' and > 'localport' options that are parsed in case you are creating a > 'connect' type UDP character device. This causes abort of qemu after > commit: > > commit f43e47dbf6de24db20ec9b588bb6cc762093dd69 > Autho

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Stefano Stabellini
On Wed, 13 May 2015, Daniel P. Berrange wrote: > On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > > Do not emulate a floppy drive if no drives are supposed to be present. > > > > This fixes the behavior of -nodefaults, that should remove the floppy > > drive (see docs/qdev-dev

Re: [Qemu-devel] [RFC PATCH v0] numa: API to lookup NUMA node by address

2015-05-13 Thread Eduardo Habkost
On Thu, May 07, 2015 at 12:34:24PM +0530, Bharata B Rao wrote: > Keep track of start and end address of each NUMA node in numa_info > structure so that lookup of node by address becomes easier. Add > an API numa_get_node() to lookup a node by address. > > This is needed by sPAPR PowerPC to support

Re: [Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Daniel P. Berrange
On Wed, May 13, 2015 at 06:29:46PM +0100, Stefano Stabellini wrote: > Do not emulate a floppy drive if no drives are supposed to be present. > > This fixes the behavior of -nodefaults, that should remove the floppy > drive (see docs/qdev-device-use.txt:Default Devices), but actually > doesn't. Te

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-13 Thread Sean O. Stalley
On Wed, May 13, 2015 at 08:09:46AM +0200, Michael S. Tsirkin wrote: > On Tue, May 12, 2015 at 02:23:07PM -0700, Sean O. Stalley wrote: > > On Tue, May 12, 2015 at 11:33:49AM +0200, Michael S. Tsirkin wrote: > > > On Mon, May 11, 2015 at 01:08:05PM -0700, Sean O. Stalley wrote: > > > > On Mon, May 1

[Qemu-devel] [PATCH] Do not emulate a floppy drive when -nodefaults

2015-05-13 Thread Stefano Stabellini
Do not emulate a floppy drive if no drives are supposed to be present. This fixes the behavior of -nodefaults, that should remove the floppy drive (see docs/qdev-device-use.txt:Default Devices), but actually doesn't. Signed-off-by: Stefano Stabellini diff --git a/hw/i386/pc.c b/hw/i386/pc.c ind

Re: [Qemu-devel] [PATCH v1 RFC 08/34] crypto: introduce new module for computing hash digests

2015-05-13 Thread Daniel P. Berrange
On Wed, May 13, 2015 at 07:12:32PM +0200, Paolo Bonzini wrote: > > > On 13/05/2015 19:04, Daniel P. Berrange wrote: > > I'm thinking perhaps a better approach could be for the crypto related > > APIs to call qcrypto_init() on an as-needed basis. The downside would > > be that this could delay the

Re: [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign

2015-05-13 Thread Denis V. Lunev
On 13/05/15 18:43, Stefan Hajnoczi wrote: On Tue, May 12, 2015 at 12:46:57PM +0200, Paolo Bonzini wrote: On 12/05/2015 12:19, Denis V. Lunev wrote: hades /vol $ strace -f -e pwrite -e raw=write,pwrite qemu-io -n -c "write -P 0x11 0 64M" ./1.img Process 19326 attached [pid 19326] pwrite(0x6,

Re: [Qemu-devel] [PATCH v1 RFC 08/34] crypto: introduce new module for computing hash digests

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 19:04, Daniel P. Berrange wrote: > I'm thinking perhaps a better approach could be for the crypto related > APIs to call qcrypto_init() on an as-needed basis. The downside would > be that this could delay the point at which the user sees a gnutls > initialization failure to only aft

[Qemu-devel] Ping [PATCH 1/1] xen-hvm: Add trace to ioreq

2015-05-13 Thread Don Slutz
On 04/30/15 14:27, Don Slutz wrote: > Signed-off-by: Don Slutz > (cherry picked from commit b72adbe7510d0a30053d32334665ee887bec9e43) > --- > trace-events | 7 +++ > xen-hvm.c| 21 + > 2 files changed, 28 insertions(+) > > diff --git a/trace-events b/trace-events > i

  1   2   3   4   >