Re: [Qemu-devel] [PATCH v2 2/5] target-microblaze: Preserve the pvr registers during reset

2015-05-27 Thread Edgar E. Iglesias
On Thu, May 28, 2015 at 03:37:03PM +1000, Alistair Francis wrote: > Move the Microblaze PVR registers to the end of the CPUMBState > and preserve them during reset. This is similar to what the > QEMU ARM model does with some of it's registers. > > This allows the Microblaze PVR registers to only b

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/28/2015 02:28 PM, Michal Privoznik wrote: > On 28.05.2015 05:36, Jason Wang wrote: >> >> On 05/28/2015 11:21 AM, Jason Wang wrote: >>> On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: >> On 05/27/2015 02:26 PM, Pankaj Gup

Re: [Qemu-devel] [PATCH v2 1/5] target-microblaze: Fix up indentation

2015-05-27 Thread Edgar E. Iglesias
On Thu, May 28, 2015 at 03:36:25PM +1000, Alistair Francis wrote: > Fix up the incorrect indentation level in the helper_stackprot() function. > > Signed-off-by: Alistair Francis > Reviewed-by: Peter Crosthwaite Reviewed-by: Edgar E. Iglesias > --- > > target-microblaze/op_helper.c | 10

Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr

2015-05-27 Thread Pavel Fedin
Hi! > IIUC, your implementation also uses 8 cpus per cluster which is not > consistent with CPU spec. Yes, i have inherited the value from Shlomo's implementation. To tell the truth i don't have time to read through all the docs. And i don't know in which PDF i should look for this info. But,

Re: [Qemu-devel] [PATCH v2 5/5] target-microblaze: Convert use-fpu to a CPU property

2015-05-27 Thread Edgar E. Iglesias
On Thu, May 28, 2015 at 03:38:59PM +1000, Alistair Francis wrote: > Originally the use-fpu PVR bits were manually set for each machine. This > is a hassle and difficult to read, instead set them based on the CPU > properties. > > Signed-off-by: Alistair Francis > Reviewed-by: Peter Crosthwaite >

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Michal Privoznik
On 28.05.2015 05:36, Jason Wang wrote: > > > On 05/28/2015 11:21 AM, Jason Wang wrote: >> >> On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: >>> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: > > On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >>> Ping. >>> >>> Can

Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

2015-05-27 Thread Gerd Hoffmann
Hi, > For EVDEV_KPCOMMA it maps to XT KBD code 126 (0x7e in decimal) which > does not match your patch. I'm not sure where I got that mapping > from originally - probably from the Linux kernel's XT <-> evdev > keymapping tables. Did some more testing, 0x7e seems to be the correct one. Everyth

Re: [Qemu-devel] [PATCH v2 3/5] target-microblaze: Allow the stack protection to be disabled/enabled

2015-05-27 Thread Edgar E. Iglesias
On Thu, May 28, 2015 at 03:37:42PM +1000, Alistair Francis wrote: > Microblaze stack protection is configurable and isn't always enabled. > This patch allows the stack protection to be disabled/enabled from the > CPU properties. > > The stack protection is disabled by default as by default the Mic

Re: [Qemu-devel] [PATCH 14/14] target-arm: Add WFx instruction trap support

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:34PM +0100, Peter Maydell wrote: > From: Greg Bellows > > Add support for trapping WFI and WFE instructions to the proper EL when > SCTLR/SCR/HCR settings apply. > > Signed-off-by: Greg Bellows > [PMM: removed unnecessary tweaking of syn_wfx() prototype; > use rai

Re: [Qemu-devel] [PATCH 13/14] target-arm: Don't halt on WFI unless we don't have any work

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:33PM +0100, Peter Maydell wrote: > Just NOP the WFI instruction if we have work to do. > This doesn't make much difference currently (though it does avoid > jumping out to the top level loop and immediately restarting), > but the distinction between "halt" and "don't h

Re: [Qemu-devel] [PATCH 12/14] target-arm: Move TB flags down to fill gap

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:32PM +0100, Peter Maydell wrote: > Deleting the now-unused ARM_TBFLAG_CPACR_FPEN left a gap in the > bit usage; move the following ARM_TBFLAG_XSCALE_CPAR and > ARM_TBFLAG_NS_SHIFT down 3 bits to fill the gap. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Ig

Re: [Qemu-devel] [PATCH 10/14] target-arm: Make singlestate TB flags common between AArch32/64

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:30PM +0100, Peter Maydell wrote: > Currently we keep the TB flags PSTATE_SS and SS_ACTIVE in different > bit positions for AArch64 and AArch32. Replace these separate > definitions with a single common flag in the upper part of the > flags word. > > Signed-off-by: Pet

Re: [Qemu-devel] [PATCH 06/14] target-arm: Make raise_exception() take syndrome and target EL

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:26PM +0100, Peter Maydell wrote: > Rather than making every caller of raise_exception set the > syndrome and target EL by hand, make these arguments to > raise_exception() and have that do the job. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias >

Re: [Qemu-devel] [PATCH 05/14] target-arm: Set exception target EL in tlb_fill

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:25PM +0100, Peter Maydell wrote: > Set the exception target EL for MMU faults in tlb_fill. > > Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias > --- > target-arm/op_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target-arm/op_help

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Add CNTHCTL_EL2

2015-05-27 Thread Edgar E. Iglesias
On Wed, May 27, 2015 at 05:27:36PM +1000, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" Hi, I just realized I forgot to do the update to use CP_ACCESS_TRAP_ELX instead of setting exception.target_el... Will fix for v3... Cheers, Edgar > > Signed-off-by: Edgar E. Iglesias > --- > t

[Qemu-devel] [PATCH v2 5/5] target-microblaze: Convert use-fpu to a CPU property

2015-05-27 Thread Alistair Francis
Originally the use-fpu PVR bits were manually set for each machine. This is a hassle and difficult to read, instead set them based on the CPU properties. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V2: - Remove unnecessary declaration of r Changes since RFC: - Tidy up th

[Qemu-devel] [PATCH v2 4/5] target-microblaze: Tidy up the base-vectors property

2015-05-27 Thread Alistair Francis
Rename the "xlnx.base-vectors" string to "base-vectors" and move the base_vectors variable into the cfg struct. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- target-microblaze/cpu-qom.h |3 ++- target-microblaze/cpu.c |4 ++-- target-microblaze/helper.c |8

[Qemu-devel] [PATCH v2 3/5] target-microblaze: Allow the stack protection to be disabled/enabled

2015-05-27 Thread Alistair Francis
Microblaze stack protection is configurable and isn't always enabled. This patch allows the stack protection to be disabled/enabled from the CPU properties. The stack protection is disabled by default as by default the Microblaze machines enable the MMU and stack protection can't be enabled if the

[Qemu-devel] [PATCH v2 2/5] target-microblaze: Preserve the pvr registers during reset

2015-05-27 Thread Alistair Francis
Move the Microblaze PVR registers to the end of the CPUMBState and preserve them during reset. This is similar to what the QEMU ARM model does with some of it's registers. This allows the Microblaze PVR registers to only be set once at realise instead of constantly at reset. Signed-off-by: Alista

[Qemu-devel] [PATCH v2 1/5] target-microblaze: Fix up indentation

2015-05-27 Thread Alistair Francis
Fix up the incorrect indentation level in the helper_stackprot() function. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- target-microblaze/op_helper.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-microblaze/op_helper.c b/target-m

Re: [Qemu-devel] [PATCH 04/14] target-arm: Move setting of exception info into tlb_fill

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:24PM +0100, Peter Maydell wrote: > Move the code which sets exception information out of > arm_cpu_handle_mmu_fault and into tlb_fill. tlb_fill > is the only caller which wants to raise_exception() > so it makes more sense for it to handle the whole of > the exception

[Qemu-devel] [PATCH v2 0/5] Add Microblaze configuration options

2015-05-27 Thread Alistair Francis
Firstly this patch series tidies up some code and removes a "xlnx." prefix. Then it moves the Microblaze PVR registers to the end of the CPUMBState to preserve them during reset. This allows most of the operations on them to be moved from the reset to the realise. Except for the machine specific o

[Qemu-devel] [PATCH v6 6/8] qemu-iotests: Make block job methods common

2015-05-27 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Paolo Bonzini --- tests/qemu-iotests/041| 66 ++- tests/qemu-iotests/iotests.py | 28 ++ 2 files changed, 43 insertions(+), 51 deletions(-) diff --git a/tests/qemu-iotes

Re: [Qemu-devel] [PATCH 03/14] target-arm: Set correct syndrome for faults on MSR DAIF*, imm

2015-05-27 Thread Edgar E. Iglesias
On Tue, May 19, 2015 at 07:33:23PM +0100, Peter Maydell wrote: > If the SCTLR.UMA trap bit is set then attempts by EL0 to update > the PSTATE DAIF bits via "MSR DAIFSet, imm" and "MSR DAIFClr, imm" > instructions will raise an exception. We were failing to set > the syndrome information for this ex

[Qemu-devel] [PATCH v6 8/8] iotests: Use event_wait in wait_ready

2015-05-27 Thread Fam Zheng
Only poll the specific type of event we are interested in, to avoid stealing events that should be consumed by someone else. Suggested-by: John Snow Signed-off-by: Fam Zheng Reviewed-by: John Snow --- tests/qemu-iotests/iotests.py | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH v6 4/8] block: Fix dirty bitmap in bdrv_co_discard

2015-05-27 Thread Fam Zheng
Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destination side to make sure that the guest sees the same data. Calling bdrv_reset_dirty also troubles mirror job because the

[Qemu-devel] [PATCH v6 7/8] qemu-iotests: Add test case for mirror with unmap

2015-05-27 Thread Fam Zheng
This checks that the discard on mirror source that effectively zeroes data is also reflected by the data of target. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- tests/qemu-iotests/132 | 59 ++ tests/qemu-iotests/132.out | 5 tests/qem

[Qemu-devel] [PATCH v6 2/8] qmp: Add optional bool "unmap" to drive-mirror

2015-05-27 Thread Fam Zheng
If specified as "true", it allows discarding on target sectors where source is not allocated. Signed-off-by: Fam Zheng --- block/mirror.c| 7 +-- blockdev.c| 5 + hmp.c | 2 +- include/block/block_int.h | 2 ++ qapi/block-core.json | 8

[Qemu-devel] [PATCH v6 3/8] mirror: Do zero write on target if sectors not allocated

2015-05-27 Thread Fam Zheng
If guest discards a source cluster, mirroring with bdrv_aio_readv is overkill. Some protocols do zero upon discard, where it's best to use bdrv_aio_write_zeroes, otherwise, bdrv_aio_discard will be enough. Signed-off-by: Fam Zheng --- block/mirror.c | 20 ++-- 1 file changed, 18

[Qemu-devel] [PATCH v6 5/8] block: Remove bdrv_reset_dirty

2015-05-27 Thread Fam Zheng
Using this function would always be wrong because a dirty bitmap must have a specific owner that consumes the dirty bits and calls bdrv_reset_dirty_bitmap(). Remove the unused function to avoid future misuse. Reviewed-by: Eric Blake Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block.c

[Qemu-devel] [PATCH v6 1/8] block: Add bdrv_get_block_status_above

2015-05-27 Thread Fam Zheng
Like bdrv_is_allocated_above, this function follows the backing chain until seeing BDRV_BLOCK_ALLOCATED. Base is not included. Reimplement bdrv_is_allocated on top. Signed-off-by: Fam Zheng --- block/io.c| 56 +-- include/block/block

[Qemu-devel] [PATCH v6 0/8] block: Mirror discarded sectors

2015-05-27 Thread Fam Zheng
v6: Fix pnum in bdrv_get_block_status_above. [Paolo] v5: Rewrite patch 1. Address Eric's comments on patch 3. Add Eric's rev-by to patches 2 & 4. Check BDRV_BLOCK_DATA in patch 3. [Paolo] This fixes the mirror assert failure reported by wangxiaolong: https://lists.gnu.org/archive/htm

Re: [Qemu-devel] [PATCH COLO-Block v5 00/15] Block replication for continuous checkpoints

2015-05-27 Thread Wen Congyang
Ping... On 05/21/2015 12:52 PM, Wen Congyang wrote: > Block replication is a very important feature which is used for > continuous checkpoints(for example: COLO). > > Usage: > Please refer to docs/block-replication.txt > > You can get the patch here: > https://github.com/wencongyang/qemu-colo/co

Re: [Qemu-devel] [PATCH RFC v9 0/7] Update tests/qemu-iotests failing cases for the s390 platform

2015-05-27 Thread tu bo
Hi Kevin: On 05/26/2015 07:55 PM, Kevin Wolf wrote: Am 25.05.2015 um 05:30 hat Bo Tu geschrieben: Bo Tu (3): qemu-iotests: s390x: fix test 049 qemu-iotests: s390x: fix test 051 qemu-iotests: s390x: fix test 130 Xiao Guang Chen (4): qemu-iotests: qemu machine type support qemu-io

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/28/2015 11:21 AM, Jason Wang wrote: > > On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: >> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >> Ping. >> >> Can I get any suggestions on this patch. >> >> Be

Re: [Qemu-devel] [PATCH 2/4] iotests: Add dependency info to groups list

2015-05-27 Thread Fam Zheng
On Fri, 05/22 16:17, John Snow wrote: > Add a few external dependency groups to the iotests groups list, > such as "qemu", "nbd", and "scm". > > This will assist us in knowing which tests need to be re-run > when those dependencies are updated, or by helping us to avoid > tests that we know are br

Re: [Qemu-devel] [PATCH 3/4] iotests: add timestamp skip feature

2015-05-27 Thread Fam Zheng
On Fri, 05/22 16:17, John Snow wrote: > Like a makefile, try to skip tests if we know they have already been > executed using the current set of external dependencies. > > If a user passes the -ts option to ./check, if a test or its output > or its dependencies (qemu, qemu-nbd, qemu-io, qemu-img,

Re: [Qemu-devel] [PATCH 4/4] iotests: clarify help text

2015-05-27 Thread Fam Zheng
On Fri, 05/22 16:17, John Snow wrote: > Split the help text to highlight the groups of options > a little better, carving out a clear "format" and > "protocols" section. > > Signed-off-by: John Snow Reviewed-by: Fam Zheng > --- > tests/qemu-iotests/common | 6 +- > 1 file changed, 5 inser

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: > On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: >> > >> > >> > On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >>> > > Ping. >>> > > >>> > > Can I get any suggestions on this patch. >>> > > >>> > > Best regards, >>> > > Pankaj >>> > >

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"

2015-05-27 Thread Fam Zheng
On Wed, 05/27 12:43, Paolo Bonzini wrote: > > > On 27/05/2015 12:10, Kevin Wolf wrote: > > Am 27.05.2015 um 11:50 hat Paolo Bonzini geschrieben: > >> > >> > >> On 27/05/2015 11:07, Kevin Wolf wrote: > >>> This is the first part of what's troubling me with this series, as it > >>> makes me doubtfu

Re: [Qemu-devel] [PATCH v3 23/29] bitmap: add atomic set functions

2015-05-27 Thread Fam Zheng
On Tue, 05/26 18:54, Paolo Bonzini wrote: > From: Stefan Hajnoczi > > Use atomic_or() for atomic bitmaps where several threads may set bits at > the same time. This avoids the race condition between threads loading > an element, bitwise ORing, and then storing the element. > > When setting all

Re: [Qemu-devel] [RESEND PATCH v4] acpi: add acpi_send_gpe_event() to rise sci for hotplug

2015-05-27 Thread Zhu Guihua
This patch has been reviewed. Could it be merged? Thanks, Zhu On 05/16/2015 12:18 AM, Igor Mammedov wrote: On Wed, 13 May 2015 17:21:36 +0800 Zhu Guihua wrote: Add a new API named acpi_send_gpe_event() to send hotplug SCI. This API can be used by pci, cpu and memory hotplug. This patch is r

Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction

2015-05-27 Thread Alexander Graf
> Am 27.05.2015 um 17:57 schrieb Aurelien Jarno : > >> On 2015-05-27 07:31, Richard Henderson wrote: >>> On 05/26/2015 03:03 PM, Aurelien Jarno wrote: >>> Ok, I understand now. That said I don't see how implementing STFLE will >>> break that. I think it will actually improve things by enabling m

Re: [Qemu-devel] [RFC PATCH 0/4] aio: Don't poll ioeventfd in nested aio_poll()

2015-05-27 Thread Fam Zheng
On Wed, 05/27 11:38, Paolo Bonzini wrote: > > > On 27/05/2015 09:19, Fam Zheng wrote: > > This series looks at the other side of the broken "qmp transaction" problem > > with dataplane [1] - the event loop. > > > > Before, an ioeventfd of a non-dataplane device is registered via > > qemu_set_fd_

Re: [Qemu-devel] [RFC PATCH 4/4] vhost-user: Add new option to specify vhost-user backend supports

2015-05-27 Thread Tetsuya Mukawa
On 2015/05/26 21:52, Eric Blake wrote: > On 05/25/2015 10:29 PM, Tetsuya Mukawa wrote: > > { 'struct': 'NetdevTapOptions', > @@ -2259,7 +2261,8 @@ > '*vhostfd':'str', > '*vhostfds': 'str', > '*vhostforce': 'bool', > -'*queues': 'uint32'} } >

[Qemu-devel] [PATCH v5] vhost-user: add multi queue support

2015-05-27 Thread Ouyang Changchun
Based on patch by Nikolay Nikolaev: Vhost-user will implement the multi queue support in a similar way to what vhost already has - a separate thread for each queue. To enable the multi queue functionality - a new command line parameter "queues" is introduced for the vhost-user netdev. Signed-off-b

Re: [Qemu-devel] [PATCH RESEND v1 5/5] target-microblaze: Convert use-fpu to a CPU property

2015-05-27 Thread Alistair Francis
On Mon, May 25, 2015 at 2:34 PM, Peter Crosthwaite wrote: > On Mon, May 18, 2015 at 4:14 PM, Alistair Francis > wrote: >> Originally the use-fpu PVR bits were manually set for each machine. This >> is a hassle and difficult to read, instead set them based on the CPU >> properties. >> >> Signed-of

Re: [Qemu-devel] [PATCH 11/34] block: Allow references for backing files

2015-05-27 Thread Wen Congyang
On 05/27/2015 08:31 PM, Kevin Wolf wrote: > Am 21.05.2015 um 07:47 hat Wen Congyang geschrieben: >> On 05/09/2015 01:21 AM, Kevin Wolf wrote: >>> For bs->file, using references to existing BDSes has been possible for a >>> while already. This patch enables the same for bs->backing_hd. >> >> 1. We r

Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr

2015-05-27 Thread Shannon Zhao
On 2015/5/28 2:03, Pavel Fedin wrote: > Hello! > >> I think encoding should be CPU type specific i.e. not defined by what >> GIC can support and once we add CPU type with 8 cores, it would provide >> it's own version of mpidr_read since it would be defined by spec >> how to encode aff0. > > I

Re: [Qemu-devel] [PATCH RESEND v1 2/5] target-microblaze: Preserve the pvr registers during reset

2015-05-27 Thread Alistair Francis
On Mon, May 25, 2015 at 1:53 PM, Peter Crosthwaite wrote: > On Mon, May 18, 2015 at 4:13 PM, Alistair Francis > wrote: >> Move the Microblaze PVR registers to the end of the CPUMBState >> and preserve them during reset. This is similar to what the >> QEMU ARM model does with some of it's register

Re: [Qemu-devel] [PATCH RESEND v1 1/5] target-microblaze: Fix up indentation

2015-05-27 Thread Alistair Francis
On Mon, May 25, 2015 at 1:44 PM, Peter Crosthwaite wrote: > On Mon, May 18, 2015 at 4:12 PM, Alistair Francis > wrote: >> Fix up the incorrect indentation level in the helper_stackprot() function. >> >> Signed-off-by: Alistair Francis > > Reviewed-by: Peter Crosthwaite Thanks Alistair > >> -

[Qemu-devel] [PATCH v3 2/2] When a command fails due to incorrect syntax or input, suggest using the "help" command to get more information about the command. This is only applicable for HMP.

2015-05-27 Thread Bandan Das
Before: (qemu) drive_add usb_flash_drive drive_add: string expected After: (qemu) drive_add usb_flash_drive drive_add: string expected Try "help drive_add" for more information Reviewed-by: Markus Armbruster Signed-off-by: Bandan Das --- monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff -

[Qemu-devel] [PATCH v3 0/2] monitor: suggest running "help" for command errors

2015-05-27 Thread Bandan Das
Hi Markus, It seems we can directly use cmdline to track current location when parsing. It's not being reused anywhere else and my unit tests didn't show any problems. Am I missing something ? Once everything looks ok, I can rebase this on top of your patches. Thanks for taking the time to review

[Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-27 Thread Bandan Das
There's too much going on in monitor_parse_command(). Split up the arguments parsing bits into a separate function monitor_parse_arguments(). Let the original function check for command validity and sub-commands if any and return data (*cmd) that the newly introduced function can process and return

Re: [Qemu-devel] [RFC v8.1 12/13] vfio-pci: pass the aer error to guest

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > when the vfio device encounters an uncorrectable error in host, > the vfio_pci driver will signal the eventfd registered by this > vfio device, the results in the qemu eventfd handler getting > invoked. > > this patch is to pass the error to gue

Re: [Qemu-devel] [RFC v8.1 10/13] vfio: do hot bus reset when do virtual secondary bus reset

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > when do virtual secondary bus reset, the vfio device under > this bus need to do host bus reset to reset the device. > so add this case. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 75 >

Re: [Qemu-devel] [RFC v8.1 07/13] vfio: add check for vfio devices which enable aer should support bus reset

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 5934fd7..91ad9ad 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c

Re: [Qemu-devel] [RFC v8.1 09/13] vfio: add sec_bus_reset notifier to notify physical bus reset is needed

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 91ad9ad..a8c5988 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -156,6 +15

Re: [Qemu-devel] [RFC v8.1 06/13] vfio: add check host bus reset is support or not

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > we introduce a has_bus_reset capability to sign the vfio > devices if support host bus reset. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 123 > ++ > 1 file changed, 123 insertio

Re: [Qemu-devel] [RFC v8.1 05/13] vfio: add aer support for vfio device

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > Calling pcie_aer_init to initilize aer related registers for > vfio device, then reload physical related registers to expose > device capability. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 83 > +++

Re: [Qemu-devel] [RFC v8.1 03/13] vfio: add pcie extanded capability support

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > For vfio pcie device, we could expose the extended capability on > PCIE bus. in order to avoid config space broken, we introduce > a copy config for parsing extended caps. and rebuild the pcie > extended config space. > > Signed-off-by: Chen Fan

Re: [Qemu-devel] [RFC v8.1 01/13] vfio: extract vfio_get_hot_reset_info as a single function

2015-05-27 Thread Alex Williamson
On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: > the function is used to get affected devices by bus reset. > so here extract it, and can used for aer soon. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 67 > +++ > 1 file changed

[Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

2015-05-27 Thread Laszlo Ersek
It is Very annoying to carry forward an outdatEd coNtroller with a mOdern Machine type. Hence, let us not instantiate the FDC when all of the following apply: - the machine type is pc-q35-2.4 or later, - "-device isa-fdc" is not passed on the command line (nor in the config file), - no "-drive i

Re: [Qemu-devel] [PATCH 1/3] ich9: add TCO interface emulation

2015-05-27 Thread Paulo Alcantara
On Wed, 27 May 2015 13:58:57 +0200 Paolo Bonzini wrote: > the main issue here is lack of migration support. You need to add a > new subsection to vmstate_ich9_pm that is migrated if the registers > are different from the default values. Hrm - OK. I didn't even take that into account. I'll do it

Re: [Qemu-devel] [PATCH 2/3] target-i386: reserve RCRB mmio space in ACPI DSDT table

2015-05-27 Thread Paulo Alcantara
On Wed, 27 May 2015 14:03:59 +0200 Paolo Bonzini wrote: > > > On 27/05/2015 02:29, Paulo Alcantara wrote: > > Signed-off-by: Paulo Alcantara > > --- > > hw/i386/acpi-dsdt-pdrc.dsl| 46 > > ++ > > Why pdrc and not e.g. ccr (chipset configuration reg

Re: [Qemu-devel] [PATCH 5/5] net: simplify net_client_init1()

2015-05-27 Thread Thomas Huth
On Wed, 27 May 2015 17:16:52 +0100 Stefan Hajnoczi wrote: > Drop the union and move the hubport creation into the !is_netdev case. > > Signed-off-by: Stefan Hajnoczi > --- > net/net.c | 38 -- > 1 file changed, 16 insertions(+), 22 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH 4/5] net: drop if expression that is always true

2015-05-27 Thread Thomas Huth
On Wed, 27 May 2015 17:16:51 +0100 Stefan Hajnoczi wrote: > Both is_netdev and !is_netdev paths already check that > net_client_init_func[opts->kind] is non-NULL so there is no need for the > if statement. > > Signed-off-by: Stefan Hajnoczi > --- > net/net.c | 31 ++

Re: [Qemu-devel] [PATCH 3/5] net: raise an error if -net type is invalid

2015-05-27 Thread Thomas Huth
On Wed, 27 May 2015 17:16:50 +0100 Stefan Hajnoczi wrote: > When a -net type is used that was not compiled into the binary there > should be an error message. > > Note the special case for -net none, which is a no-op. > > Signed-off-by: Stefan Hajnoczi > --- > net/net.c | 11 +++ > 1

Re: [Qemu-devel] [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

2015-05-27 Thread Joao Luis Meloni Assirati
On 27-05-2015 11:32, Gerd Hoffmann wrote: On Mi, 2015-05-27 at 06:27 -0300, Joao Luis Meloni Assirati wrote: On 26-05-2015 10:58, Gerd Hoffmann wrote: This patch adds the two extra brazilian keys to the evdev keymap for X11. This patch gets the two keys going with the gtk and sdl1 UIs. With v

[Qemu-devel] [PULL v2 09/12] qom: Add object_new_with_props() / object_new_withpropv() helpers

2015-05-27 Thread Andreas Färber
From: "Daniel P. Berrange" It is reasonably common to want to create an object, set a number of properties, register it in the hierarchy and then mark it as complete (if a user creatable type). This requires quite a lot of error prone, verbose, boilerplate code to achieve. First a pair of functi

[Qemu-devel] [PULL v2 06/12] doc: Document user creatable object types in help text

2015-05-27 Thread Andreas Färber
From: "Daniel P. Berrange" The QEMU help for -object is essentially useless, just giving users the generic syntax. Move it down into its own section and introduce a nested table where each user creatable object can be documented. The existing memory-backend-file, rng-random and rng-egd object typ

[Qemu-devel] [PULL v2 11/12] qom: Add an object_property_add_enum() helper function

2015-05-27 Thread Andreas Färber
From: "Daniel P. Berrange" A QOM property can be parsed as enum using the visit_type_enum() helper function, but this forces callers to use the more complex generic object_property_add() method when registering it. It also requires that users of that object have access to the string map when they

[Qemu-devel] [PULL v2 12/12] qom: Add object_property_add_const_link()

2015-05-27 Thread Andreas Färber
From: Paolo Bonzini This helper adds a read-only link<> property. Suggested-by: Eduardo Habkost Signed-off-by: Paolo Bonzini Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- include/qom/object.h | 18 ++ qom/object.c | 16 2 files chang

[Qemu-devel] [PULL v2 10/12] qom: Make enum string tables const-correct

2015-05-27 Thread Andreas Färber
From: "Daniel P. Berrange" The enum string table parameters in various QOM/QAPI methods are declared 'const char *strings[]'. This results in const warnings if passed a variable that was declared as static const char * const strings[] = { }; Add the extra const annotation to the paramet

[Qemu-devel] [PULL v2 08/12] qom: Add helper method for getting user objects root

2015-05-27 Thread Andreas Färber
From: "Daniel P. Berrange" Add object_get_objects_root() method which is a convience for obtaining the Object * located at /objects in the object composition tree. Convert existing code over to use the new API where appropriate. Signed-off-by: Daniel P. Berrange Signed-off-by: Andreas Färber -

[Qemu-devel] [PULL v2 03/12] tests: Use qtest_add_data_func() consistently

2015-05-27 Thread Andreas Färber
Replace uses of g_test_add_data_func() for QTest test cases. It is still valid to use it for any non-QTest test cases, which are not run for multiple target binaries. Suggested-by: John Snow Reviewed-by: John Snow Signed-off-by: Andreas Färber --- tests/ahci-test.c | 9 ++--- tests

[Qemu-devel] [PULL v2 07/12] vl: Create (most) objects before creating chardev backends

2015-05-27 Thread Andreas Färber
From: "Daniel P. Berrange" Some types of object must be created before chardevs, other types of object must be created after chardevs. As such there is no option but to create objects in two phases. This takes the decision to create as many object types as possible right away before anyother bac

[Qemu-devel] [PULL v2 02/12] qdev: Free property names after registering gpio aliases

2015-05-27 Thread Andreas Färber
From: Eduardo Habkost Now that object_property_add_alias() strdup()s target_name, we can free the property names in qdev_pass_gpios(). Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- hw/core/qdev.c | 2 ++ 1 file chang

[Qemu-devel] [PULL v2 04/12] scripts: Add support for path as argument of qom-tree

2015-05-27 Thread Andreas Färber
From: Martin Cerveny Add processing of optional argument path as "tree base". Signed-off-by: Martin Cerveny Signed-off-by: Andreas Färber --- scripts/qmp/qom-tree | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qom-tree b/scripts/qmp/qom-tree index aea

[Qemu-devel] [PULL v2 05/12] backends: Fix typename of 'policy' enum property in hostmem obj

2015-05-27 Thread Andreas Färber
From: "Daniel P. Berrange" The 'policy' property was being registered with a typename of 'str', but it is in fact an enum of the 'HostMemPolicy' type. Signed-off-by: Daniel P. Berrange Reviewed-by: Paolo Bonzini Signed-off-by: Andreas Färber --- backends/hostmem.c | 2 +- 1 file changed, 1 i

[Qemu-devel] [PULL v2 00/12] QOM devices patch queue 2015-05-27

2015-05-27 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. v2 contains changes that hopefully fix warnings on gcc 4.7. Regards, Andreas Cc: Peter Maydell Cc: Eduardo Habkost Cc: Paolo Bonzini Cc: Daniel P. Berrange The following changes since commit 0915aed5842bd4dbe396b92d4f3b846ae29

[Qemu-devel] [PULL v2 01/12] qom: strdup() target property name on object_property_add_alias()

2015-05-27 Thread Andreas Färber
From: Eduardo Habkost With this, object_property_add_alias() callers can safely free the target property name, like what already happens with the 'name' argument to all object_property_add*() functions. Signed-off-by: Eduardo Habkost Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Sig

Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20

2015-05-27 Thread Andreas Färber
Am 21.05.2015 um 13:53 schrieb Daniel P. Berrange: > On Thu, May 21, 2015 at 12:18:30PM +0100, Peter Maydell wrote: >> On 20 May 2015 at 16:51, Andreas Färber wrote: >>> Hello Peter, >>> >>> This is my QOM (devices) patch queue. Please pull. >>> >>> Regards, >>> Andreas >>> >>> Cc: Peter Maydell

Re: [Qemu-devel] [PATCH RFC V2 1/4] Use Aff1 with mpidr

2015-05-27 Thread Pavel Fedin
Hello! > I think encoding should be CPU type specific i.e. not defined by what > GIC can support and once we add CPU type with 8 cores, it would provide > it's own version of mpidr_read since it would be defined by spec > how to encode aff0. I have redone this thing from scratch: https://lists.

[Qemu-devel] [PATCH 3/3] acpi: Simplify printing to dynamic string

2015-05-27 Thread Markus Armbruster
build_append_namestringv() and aml_string() first calculate the resulting string's length with vsnprintf(NULL, ...), then allocate, then print for real. Simply use g_strdup_vprintf() or g_vasprintf() instead. Signed-off-by: Markus Armbruster --- hw/acpi/aml-build.c | 27 +---

[Qemu-devel] [PATCH 1/3] Revert "aml-build: fix build for glib < 2.22"

2015-05-27 Thread Markus Armbruster
Since we now require GLib 2.22+ (commit f40685c), we don't have to work around lack of g_ptr_array_new_with_free_func() anymore. This reverts commit 2e5feadbf8133b9b108919a2f576943b448a1a06. Signed-off-by: Markus Armbruster --- hw/acpi/aml-build.c | 5 ++--- 1 file changed, 2 insertions(+), 3 d

[Qemu-devel] [PATCH 0/3] acpi: Clean up some GLib compatibility cruft

2015-05-27 Thread Markus Armbruster
Markus Armbruster (3): Revert "aml-build: fix build for glib < 2.22" acpi: Drop superfluous GLIB_CHECK_VERSION() acpi: Simplify printing to dynamic string hw/acpi/aml-build.c | 34 +++--- 1 file changed, 7 insertions(+), 27 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH 2/3] acpi: Drop superfluous GLIB_CHECK_VERSION()

2015-05-27 Thread Markus Armbruster
The version check is always true since we require GLib 2.22+ (commit f40685c). It dates back to commit 8b9c3b8 "acpi-build: fix build on glib < 2.22", amended in commit fd8f5e3 "acpi-build: fix build on glib < 2.14". I guess we could revert both of them now, but I'm not sure it's worth the churn,

[Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"

2015-05-27 Thread Markus Armbruster
Since we now require GLib 2.22+ (commit f40685c), we don't have to work around lack of g_strcmp0() anymore. This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1. Conflicts: qemu-ga.c Signed-off-by: Markus Armbruster --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Qemu-devel] [PATCH] Revert "hw/ppc/spapr_pci.c: Avoid functions not in glib 2.12 (g_hash_table_iter_*)"

2015-05-27 Thread Markus Armbruster
Since we now require GLib 2.22+ (commit f40685c), we don't have to work around lack of g_hash_table_iter_init() & friends anymore. This reverts commit f8833a37c0c6b22ddd57b45e48cfb0f97dbd5af4. Signed-off-by: Markus Armbruster --- hw/ppc/spapr_pci.c | 28 +++- 1 file chan

[Qemu-devel] [PATCH] Revert "target-arm: Avoid g_hash_table_get_keys()"

2015-05-27 Thread Markus Armbruster
Since we now require GLib 2.22+ (commit f40685c), we don't have to work around lack of g_hash_table_get_keys() anymore. This reverts commit 82a3a11897308b606120f7235001e87809708f85. Signed-off-by: Markus Armbruster --- target-arm/helper.c | 12 ++-- 1 file changed, 2 insertions(+), 10 d

Re: [Qemu-devel] [PATCH 2/5] net: replace net_client_init1() netdev whitelist with blacklist

2015-05-27 Thread Thomas Huth
On Wed, 27 May 2015 17:16:49 +0100 Stefan Hajnoczi wrote: > It's cumbersome to keep the whitelist up-to-date. New netdev backends > should most likely be allowed so a blacklist makes more sense than a > whitelist. > > Signed-off-by: Stefan Hajnoczi > --- > net/net.c | 28 +++--

Re: [Qemu-devel] [PATCH 1/5] net: add missing "netmap" to host_net_devices[]

2015-05-27 Thread Thomas Huth
On Wed, 27 May 2015 17:16:48 +0100 Stefan Hajnoczi wrote: > Although hmp-commands.hx lists "netmap" as a valid host_net_add type, > the command rejects it because it's missing from the list. > > Signed-off-by: Stefan Hajnoczi > --- > net/net.c | 3 +++ > 1 file changed, 3 insertions(+) > > di

[Qemu-devel] need to create a qemu account

2015-05-27 Thread Yaelan Wong
Hi:  Can someone help me to create my account in Qemu? Thanks. -ywong Sent from [ProtonMail](https://protonmail.ch), encrypted email based in Switzerland.

[Qemu-devel] [PATCH] pc: acpi: keep pvpanic backward compatible

2015-05-27 Thread Radim Krčmář
In the old times, we always had pvpanic in ACPI and a _STA function told the guest not to use it. Now, we only include pvpanic in ACPI if it is enabled, so the _STA function is useless from qemu's point of view, but guests still want to query availability. Make them happy. This patch extends e

[Qemu-devel] [Bug 1458239] Re: Use qed instead of qcow2 for "-snapshot" functionality

2015-05-27 Thread Коренберг Марк
Huge thanks for detailed explanation. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1458239 Title: Use qed instead of qcow2 for "-snapshot" functionality Status in QEMU: Invalid Bug description

Re: [Qemu-devel] Announcing qboot, a minimal x86 firmware for QEMU

2015-05-27 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 26/05/2015 23:25, Christopher Covington wrote: > > On 05/25/2015 08:53 AM, Paolo Bonzini wrote: > >> > >> On 22/05/2015 13:12, Daniel P. Berrange wrote: > >>> In > >>> particular I don't see why we need to have a SATA controller and ISA/LPC >

[Qemu-devel] [PATCH 3/5] net: raise an error if -net type is invalid

2015-05-27 Thread Stefan Hajnoczi
When a -net type is used that was not compiled into the binary there should be an error message. Note the special case for -net none, which is a no-op. Signed-off-by: Stefan Hajnoczi --- net/net.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/net/net.c b/net/net.c index 3352b

[Qemu-devel] [PATCH 2/5] net: replace net_client_init1() netdev whitelist with blacklist

2015-05-27 Thread Stefan Hajnoczi
It's cumbersome to keep the whitelist up-to-date. New netdev backends should most likely be allowed so a blacklist makes more sense than a whitelist. Signed-off-by: Stefan Hajnoczi --- net/net.c | 28 +++- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH 5/5] net: simplify net_client_init1()

2015-05-27 Thread Stefan Hajnoczi
Drop the union and move the hubport creation into the !is_netdev case. Signed-off-by: Stefan Hajnoczi --- net/net.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/net/net.c b/net/net.c index cc1793c..e57a089 100644 --- a/net/net.c +++

  1   2   3   4   >