Re: [Qemu-devel] fw cfg files cross-version migration races

2015-06-02 Thread Laszlo Ersek
(resending, with Paolo's address corrected) On 06/01/15 22:31, Gabriel L. Somlo wrote: > On Mon, Jun 01, 2015 at 02:00:22PM -0400, Gabriel L. Somlo wrote: >> On Mon, Jun 01, 2015 at 05:44:47PM +0200, Michael S. Tsirkin wrote: > Shouldn't we migrate the fw cfg data that the source host generate

Re: [Qemu-devel] fw cfg files cross-version migration races

2015-06-02 Thread Gerd Hoffmann
Hi, > I guess the only reason this isn't a problem is that nobody currently > attempts to access fw_cfg after a migration ? :) Accessing fw_cfg after migration is fine. Problem is this ... (1) read directory (2) migrate (3) read file ... in case the file ordering happens to be differen

Re: [Qemu-devel] [PATCH 0/4] macio: change DMA methods over to offset/len implementation

2015-06-02 Thread Laurent Vivier
- Original Message - > From: "Mark Cave-Ayland" > To: "John Snow" , ag...@suse.de, qemu-devel@nongnu.org, > qemu-...@nongnu.org > Sent: Tuesday, June 2, 2015 1:18:42 AM > Subject: Re: [Qemu-devel] [PATCH 0/4] macio: change DMA methods over to > offset/len implementation > > On 02/06/1

Re: [Qemu-devel] [PATCH] virtio-input: const_le16 and const_le32 not build time constant

2015-06-02 Thread Christian Borntraeger
Am 01.06.2015 um 15:51 schrieb Michael Mueller: > As the implementation of const_le16 and const_le32 is not build time constant > on big endian systems this need to be fixed. > > CChw/input/virtio-input-hid.o > hw/input/virtio-input-hid.c:340:13: error: initializer element is not constant >

Re: [Qemu-devel] [PATCH 03/13] target-s390x: rename BRXHLE instruction into BRXLG

2015-06-02 Thread Aurelien Jarno
On 2015-06-01 18:33, Richard Henderson wrote: > On 06/01/2015 02:24 PM, Aurelien Jarno wrote: > > D(0x8400, BRXH,RSI, Z, 0, 0, 0, 0, bx32, 0, 0) > > D(0x8500, BRXLE, RSI, Z, 0, 0, 0, 0, bx32, 0, 1) > > D(0xec44, BRXHG, RIE_e, Z, 0, 0, 0, 0, bx64, 0, 0) > >-D(0xe

Re: [Qemu-devel] [PATCH 07/13] target-s390x: implement LOAD FP INTEGER instructions

2015-06-02 Thread Aurelien Jarno
On 2015-06-01 20:07, Richard Henderson wrote: > On 06/01/2015 02:24 PM, Aurelien Jarno wrote: > >+/* LOAD FP INTEGER */ > >+C(0xb357, FIEBR, RRF_e, Z, 0, e2, new, e1, fieb, 0) > >+C(0xb35f, FIDBR, RRF_e, Z, 0, f2_o, f1, 0, fidb, 0) > >+C(0xb347, FIXBR, RRF_e, Z, 0, f2_o, x1,

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-02 Thread Gerd Hoffmann
On Mo, 2015-06-01 at 14:43 +0200, Paolo Bonzini wrote: > > On 01/06/2015 14:41, Michael S. Tsirkin wrote: > > On Mon, Jun 01, 2015 at 02:39:17PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 01/06/2015 14:38, Michael S. Tsirkin wrote: > >>> I'm sorry - I don't understand. It's easy to do the right

Re: [Qemu-devel] [PATCH 01/10] crypto: introduce new module for computing hash digests

2015-06-02 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, May 28, 2015 at 09:28:20PM +0800, Gonglei wrote: >> On 2015/5/21 18:56, Daniel P. Berrange wrote: >> > Introduce a new crypto/ directory that will (eventually) contain >> > all the cryptographic related code. This initially defines a >> > wrapper for initial

Re: [Qemu-devel] [edk2] NVMe question

2015-06-02 Thread Laszlo Ersek
On 06/02/15 09:19, Tian, Feng wrote: > Thanks for the info. > > > > I didn’t test it on NVMe-Qemu, I just run the change on a real > production. I will do bigger scope test to see if it’s valuable to add > it back. This email thread is a perfect example why top-posting is a horrible practice.

Re: [Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in

2015-06-02 Thread Gerd Hoffmann
Hi, > -static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as) > +static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as, > + void *drv_opaque) > { > ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw; > struct alsa_params_req req; > @@ -827,6 +828,8 @

Re: [Qemu-devel] [RFC v8.1 06/13] vfio: add check host bus reset is support or not

2015-06-02 Thread Chen Fan
On 05/28/2015 05:32 AM, Alex Williamson wrote: On Wed, 2015-05-27 at 10:46 +0800, Chen Fan wrote: we introduce a has_bus_reset capability to sign the vfio devices if support host bus reset. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 123 +

Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O

2015-06-02 Thread Alex Bennée
Michael Tokarev writes: > 29.05.2015 19:29, Paolo Bonzini wrote: >> On 29/05/2015 16:14, Alex Bennée wrote: >>> You mean just do: >>> >>> diff --git a/configure b/configure >>> index b707429..f13831a 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -353,7 +353,7 @@ for opt do >>>;; >>>

Re: [Qemu-devel] [PATCH COLO-Frame v5 00/29] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service

2015-06-02 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 05/29/2015 12:24 AM, Dr. David Alan Gilbert wrote: > > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >> This is the 5th version of COLO, here is only COLO frame part, include: VM > >> checkpoint, > >> failover, proxy API, block replicat

[Qemu-devel] [PATCH] arm: Fix invalid assert logic in op_helper.c

2015-06-02 Thread Martin Kletzander
Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it according to the comment above as currently the build fails with gcc-5.1.0. Signed-off-by: Martin Kletzander --- target-arm/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/op_helper.c

Re: [Qemu-devel] [PATCH v2 0/2] monitor+disas: Remove uses of ENV_GET_CPU

2015-06-02 Thread Peter Crosthwaite
Ping! So there was some uncertainty around maintainerships earlier (on some follow up work to this one) and I wonder what the target queue is for this stuff. Can the monitor people perhaps ack/nack P1? Regards, Peter On Sun, May 24, 2015 at 2:20 PM, Peter Crosthwaite wrote: > Neither the monit

Re: [Qemu-devel] [PULL v2 00/60] pc, pci, tpm, virtio, vhost enhancements and fixes

2015-06-02 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Mon, Jun 01, 2015 at 05:33:24PM +0100, Peter Maydell wrote: >> On 1 June 2015 at 13:22, Michael S. Tsirkin wrote: >> > The following changes since commit >> > 97af820f539efe80b87615a04f9de11ea585f725: >> > >> > Merge remote-tracking branch >> > 'remotes/pmay

Re: [Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-02 Thread Gerd Hoffmann
On Mo, 2015-06-01 at 16:38 +0300, Michael Tokarev wrote: > 01.06.2015 16:23, Kővágó, Zoltán wrote: > > This series of patch removes the following audio backends: > > esd, fmod, sdl, winwave. > > Why do you remove sdl backend? > > This is my preferred backend so far, it works better > than all oth

Re: [Qemu-devel] [PATCH] arm: Fix invalid assert logic in op_helper.c

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 09:05, Martin Kletzander wrote: > Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it > according to the comment above as currently the build fails with > gcc-5.1.0. > > Signed-off-by: Martin Kletzander > --- > target-arm/op_helper.c | 2 +- > 1 file changed,

[Qemu-devel] [PULL 06/21] monitor: Use traditional command interface for HMP device_add

2015-06-02 Thread Markus Armbruster
All QMP commands use the "new" handler interface (mhandler.cmd_new). Most HMP commands still use the traditional interface (mhandler.cmd), but a few use the "new" one. Complicates handle_user_command() for no gain, so I'm converting these to the traditional interface. For device_add, that's easy:

[Qemu-devel] [PULL 00/21] Monitor patches

2015-06-02 Thread Markus Armbruster
These change the monitor core, shared by HMP (maintained by Luiz) and QMP (maintained by myself). Luiz reviewed and asked me to take them through my tree. This is v3 with the (reviewed!) one-line amend to PATCH 14 squashed in, and trivially rebased. The following changes since commit b821cbe274c

[Qemu-devel] [PULL 02/21] monitor: Clean up after previous commit

2015-06-02 Thread Markus Armbruster
Inline qmp_call_cmd() along with its helper handler_audit() into its only caller handle_qmp_command(), and simplify the result. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 40 +++- 1 file changed, 11

[Qemu-devel] [PULL 12/21] monitor: Wean monitor_protocol_emitter() off mon->error

2015-06-02 Thread Markus Armbruster
Move mon->error handling to its caller handle_qmp_command(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index d336b8f..56564d5 100644

[Qemu-devel] [PULL 08/21] monitor: Drop unused "new" HMP command interface

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/monitor.c b/monitor.c index 85bb71e..9403c2c 100644 --- a/monitor.c +++ b/monitor.c @@ -123,7 +123,6 @@

[Qemu-devel] [PULL 03/21] monitor: Improve and document client_migrate_info protocol error

2015-06-02 Thread Markus Armbruster
Protocol must be spice, vnc isn't implemented. Fix up documentation. Attempts to use vnc or any other unknown protocol yield the misleading error message "Invalid parameter 'protocol'". Improve it to "Parameter 'protocol' expects spice". Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster Revi

[Qemu-devel] [PULL 09/21] monitor: Propagate errors through qmp_check_client_args()

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 65 --- 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/monitor.c b/monitor.c index 9403c2c..0afcf60 100644 --- a/mon

[Qemu-devel] [PULL 05/21] monitor: Use traditional command interface for HMP drive_del

2015-06-02 Thread Markus Armbruster
All QMP commands use the "new" handler interface (mhandler.cmd_new). Most HMP commands still use the traditional interface (mhandler.cmd), but a few use the "new" one. Complicates handle_user_command() for no gain, so I'm converting these to the traditional interface. For drive_del, that's easy:

[Qemu-devel] [PULL 11/21] monitor: Propagate errors through invalid_qmp_mode()

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Luiz Capitulino --- monitor.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/monitor.c b/monitor.c index 61ea346..d336b8f 100644 --- a/monitor.c +++ b/monitor.c @@ -4708,19 +4708,20 @@ static int monitor_can_r

[Qemu-devel] [PULL 01/21] monitor: Drop broken, unused asynchronous command interface

2015-06-02 Thread Markus Armbruster
The asynchronous monitor command interface goes back to commit 940cc30 (Jan 2010). Added a third case to command execution. The hope back then according to the commit message was that all commands get converted to the asynchronous interface, killing off the other two cases. Didn't happen. The i

[Qemu-devel] [PULL 07/21] monitor: Use trad. command interface for HMP pcie_aer_inject_error

2015-06-02 Thread Markus Armbruster
All QMP commands use the "new" handler interface (mhandler.cmd_new). Most HMP commands still use the traditional interface (mhandler.cmd), but a few use the "new" one. Complicates handle_user_command() for no gain, so I'm converting these to the traditional interface. pcie_aer_inject_error's impl

[Qemu-devel] [PULL 18/21] monitor: Drop do_qmp_capabilities()'s superfluous QMP check

2015-06-02 Thread Markus Armbruster
Superfluous since commit 30f5041 removed it from HMP. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index f20e918..daba98f 100644 --- a/monitor.c

[Qemu-devel] [PULL 20/21] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp()

2015-06-02 Thread Markus Armbruster
... and change return type to bool. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 0550283..be18ac1 100644 --- a/monitor.c +++ b/m

[Qemu-devel] [PULL 14/21] monitor: Limit QError use to command handlers

2015-06-02 Thread Markus Armbruster
The previous commits narrowed use of QError to handle_qmp_command() and its helpers monitor_protocol_emitter(), build_qmp_error_dict(). Narrow it further to just the command handler call: instead of converting Error to QError throughout handle_qmp_command(), convert the QError gotten from the comma

[Qemu-devel] [PULL 04/21] monitor: Convert client_migrate_info to QAPI

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- hmp-commands.hx | 3 +-- hmp.c| 17 + hmp.h| 1 + monitor.c| 42 ++ qapi-schema.json | 19 +++ qmp

[Qemu-devel] [PULL 19/21] monitor: Turn int command_mode into bool in_command_mode

2015-06-02 Thread Markus Armbruster
While there, inline the pointless qmp_cmd_mode() wrapper. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/monitor.c b/monitor.c index daba98f..05502

Re: [Qemu-devel] [PATCH V1] cadence_gem: Fix Rx buffer size field mask

2015-06-02 Thread Michael Tokarev
01.06.2015 05:51, Peter Crosthwaite wrote: > On Thu, May 28, 2015 at 11:22 PM, Sai Pavan Boddu > wrote: >> This patch corrects the Rx buffer size field mask to mask bits 23 to 16 >> >> Signed-off-by: Sai Pavan Boddu >> Reviewed-by: Alistair Francis > > Matches Xilinx UG585 documentation. > > R

[Qemu-devel] [PULL 16/21] monitor: Rename monitor_control_read(), monitor_control_event()

2015-06-02 Thread Markus Armbruster
... to monitor_qmp_read(), monitor_qmp_event(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/monitor.c b/monitor.c index a39cd6c..5c2aa27 100644 --- a/moni

[Qemu-devel] [PULL 13/21] monitor: Inline monitor_has_error() into its only caller

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 56564d5..91f8a4e 100644 --- a/monitor.c +++ b/monitor.c @@ -377,11 +377,6 @@ static int GCC_F

[Qemu-devel] [PULL 15/21] monitor: Rename handle_user_command() to handle_hmp_command()

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 888d771..a39cd6c 100644 --- a/monitor.c +++ b/monitor.c @@ -574,7 +574,7 @@ static int d

[Qemu-devel] [PULL 21/21] monitor: Change return type of monitor_cur_is_qmp() to bool

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- include/monitor/monitor.h | 2 +- monitor.c | 6 -- stubs/mon-is-qmp.c| 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/monitor/monitor.h b/includ

[Qemu-devel] [PULL 10/21] monitor: Propagate errors through qmp_check_input_obj()

2015-06-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 0afcf60..61ea346 100644 --- a/monitor.c +++ b/monitor.c @@ -4929,14 +4929,14 @

[Qemu-devel] [PULL 17/21] monitor: Unbox Monitor member mc and rename to qmp

2015-06-02 Thread Markus Armbruster
While there, rename its type as well, from MonitorControl to MonitorQMP. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino --- monitor.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/monitor.c b/monit

[Qemu-devel] [PULL 0/2] virtio-input: two fixes

2015-06-02 Thread Gerd Hoffmann
ommit b821cbe274c5a5cacf1a7b28360d869ae1e6e0c3: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-06-01 15:22:46 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-input-20150602-1 for you to fetch changes up to e63d114b8a81e22ff9295674ba64b21255d589ee:

Re: [Qemu-devel] [PULL fixup] acpi: add missing ssdt

2015-06-02 Thread Daniel P. Berrange
On Mon, Jun 01, 2015 at 09:42:10PM +0200, Michael S. Tsirkin wrote: > commit 5cb18b3d7bff2a83275ee98af2a14eb9e21c93ab > TPM2 ACPI table support > > was missing a file, so build with iasl fails > (build without iasl works since it uses the generated > hex files). > > Reported-by: "Daniel P. B

[Qemu-devel] [PULL 2/2] virtio-input: make virtio devices follow usual naming convention

2015-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-input.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/virtio/virtio-input.h b/include/hw/virtio/virtio-input.h index bcee355..8134178 100644 --- a/include/hw/virtio/virtio-input.h +++ b/include/hw/v

[Qemu-devel] [PULL 1/2] virtio-input: const_le16 and const_le32 not build time constant

2015-06-02 Thread Gerd Hoffmann
From: Michael Mueller As the implementation of const_le16 and const_le32 is not build time constant on big endian systems this need to be fixed. CChw/input/virtio-input-hid.o hw/input/virtio-input-hid.c:340:13: error: initializer element is not constant hw/input/virtio-input-hid.c:340:13:

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2015 at 09:37:13AM +0200, Gerd Hoffmann wrote: > On Mo, 2015-06-01 at 14:43 +0200, Paolo Bonzini wrote: > > > > On 01/06/2015 14:41, Michael S. Tsirkin wrote: > > > On Mon, Jun 01, 2015 at 02:39:17PM +0200, Paolo Bonzini wrote: > > >> > > >> > > >> On 01/06/2015 14:38, Michael S. T

Re: [Qemu-devel] [PATCH 01/10] crypto: introduce new module for computing hash digests

2015-06-02 Thread Daniel P. Berrange
On Tue, Jun 02, 2015 at 09:43:18AM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, May 28, 2015 at 09:28:20PM +0800, Gonglei wrote: > >> On 2015/5/21 18:56, Daniel P. Berrange wrote: > >> > Introduce a new crypto/ directory that will (eventually) contain > >> > all th

Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object

2015-06-02 Thread Markus Armbruster
Eric Blake writes: > On 05/28/2015 06:21 AM, Markus Armbruster wrote: >> Failure to create a -object is a fatal error. However, we delay the > > s/a -object/an -object/ ? (depends on whether you pronounce '-object' as > "object" or "dash-object") I'll use "to create an object with -object". >>

[Qemu-devel] [PATCH v2] target-arm: use extended address bits from supersection short descriptor

2015-06-02 Thread Sergey Fedorov
Since ARMv7 with LPAE support, a supersection short translation table descriptor has had extended base address fields which hold bits 39:32 of translated address. These fields are IMPDEF in ARMv6 and ARMv7 without LPAE support. Signed-off-by: Sergey Fedorov --- target-arm/helper.c | 2 ++ 1 file

Re: [Qemu-devel] [PATCH] arm: Fix invalid assert logic in op_helper.c

2015-06-02 Thread Martin Kletzander
On Tue, Jun 02, 2015 at 09:10:23AM +0100, Peter Maydell wrote: On 2 June 2015 at 09:05, Martin Kletzander wrote: Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it according to the comment above as currently the build fails with gcc-5.1.0. Signed-off-by: Martin Kletzander -

Re: [Qemu-devel] [PATCH 4/9] QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure

2015-06-02 Thread Markus Armbruster
Eric Blake writes: > On 05/28/2015 06:21 AM, Markus Armbruster wrote: >> When the argument is non-zero, qemus_opt_foreach() stops on callback > > s/qemus_opt/qemu_opts/ Wonder what got my fingers into *that* tangle. Fixing... >> returning non-zero, and returns that value. >> >> When the argum

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arm: Fix invalid assert logic in op_helper.c

2015-06-02 Thread Michael Tokarev
02.06.2015 11:10, Peter Maydell wrote: > On 2 June 2015 at 09:05, Martin Kletzander wrote: >> Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it >> according to the comment above as currently the build fails with >> gcc-5.1.0. >> >> Signed-off-by: Martin Kletzander >> --- >> t

[Qemu-devel] [Bug 1460523] Re: target-arm/op_helper.c:424: bad assert

2015-06-02 Thread Michael Tokarev
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1460523 Title: target-arm/op_helper.c:424: bad assert Status in QEMU: In Progress Bug descrip

Re: [Qemu-devel] [PATCH] target-arm: use extended address bits from supersection short descriptor

2015-06-02 Thread Sergey Fedorov
On 01.06.2015 21:41, Peter Crosthwaite wrote: > On Thu, May 28, 2015 at 4:00 AM, Sergey Fedorov wrote: >> --- >> target-arm/helper.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/target-arm/helper.c b/target-arm/helper.c >> index 5d0f011..fc3f192 100644 >> --- a/target-arm/helper.

[Qemu-devel] [PATCH v3] target-arm: use extended address bits from supersection short descriptor

2015-06-02 Thread Sergey Fedorov
Since ARMv7 with LPAE support, a supersection short translation table descriptor has had extended base address fields which hold bits 39:32 of translated address. These fields are IMPDEF in ARMv6 and ARMv7 without LPAE support. Signed-off-by: Sergey Fedorov --- v3: * needless parenthesis remove

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arm: Fix invalid assert logic in op_helper.c

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 09:52, Michael Tokarev wrote: > 02.06.2015 11:10, Peter Maydell wrote: >> On 2 June 2015 at 09:05, Martin Kletzander wrote: >>> Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it >>> according to the comment above as currently the build fails with >>> gcc-5.1.

Re: [Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-02 Thread Michael Tokarev
02.06.2015 11:08, Gerd Hoffmann wrote: > On Mo, 2015-06-01 at 16:38 +0300, Michael Tokarev wrote: >> 01.06.2015 16:23, Kővágó, Zoltán wrote: >>> This series of patch removes the following audio backends: >>> esd, fmod, sdl, winwave. >> >> Why do you remove sdl backend? >> >> This is my preferred ba

Re: [Qemu-devel] [PATCH] linux-user: Use abi_ulong for TARGET_ELF_PAGESTART

2015-06-02 Thread Yongbok Kim
ping! On 20/04/2015 16:15, Yongbok Kim wrote: > TARGET_ELF_PAGESTART is required to use abi_ulong to correctly handle > addresses for different target bits width. > This patch fixes a problem when running a 64-bit user mode application > on 32-bit host machines. > > Signed-off-by: Yongbok Kim >

Re: [Qemu-devel] [PATCH v3 3/6] Support Physical Presence Interface Spec

2015-06-02 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 11:11:26PM -0400, Stefan Berger wrote: > On 05/31/2015 02:11 PM, Michael S. Tsirkin wrote: > >On Tue, May 26, 2015 at 05:33:41PM -0400, Stefan Berger wrote: > >>For automated management of a TPM device, implement the TCG Physical > >>Presence > >>Interface Specification tha

Re: [Qemu-devel] [v7][PATCH 03/10] piix: create host bridge to passthrough

2015-06-02 Thread Michael S. Tsirkin
On Tue, Jun 02, 2015 at 08:50:58AM +0800, Chen, Tiejun wrote: > On 2015/6/1 2:11, Michael S. Tsirkin wrote: > >On Thu, Mar 19, 2015 at 09:01:27AM +0800, Chen, Tiejun wrote: > >>On 2015/3/18 18:21, Gerd Hoffmann wrote: > >>>On Mi, 2015-03-18 at 17:06 +0800, Tiejun Chen wrote: > Implement a pci h

[Qemu-devel] [PATCH v7 1/3] sysbus: register reset handler for main_system_bus when created

2015-06-02 Thread Zhu Guihua
Since icc bus will be droped and apic reset should be after bus reset in x86, this patch moves reset handler for main_system_bus from vl.c to sysbus.c Signed-off-by: Zhu Guihua --- hw/core/sysbus.c | 4 vl.c | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a

[Qemu-devel] [PATCH v7 3/3] icc_bus: drop the unused files

2015-06-02 Thread Zhu Guihua
ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Zhu Guihua --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/cpu/Makefile.objs | 1 - hw/cpu/icc_bus.c | 118

[Qemu-devel] [PATCH v7 2/3] cpu/apic: drop icc bus/bridge

2015-06-02 Thread Zhu Guihua
From: Chen Fan After CPU hotplug has been converted to BUS-less hot-plug infrastructure, the only function ICC bus performs is to propagate reset to LAPICs. However LAPIC could be reset by registering its reset handler after all device are initialized. Do so and drop ~200LOC of not needed anymore

[Qemu-devel] [PATCH v7 0/3] remove icc bus/bridge

2015-06-02 Thread Zhu Guihua
ICC Bus was used for providing a hotpluggable bus for APIC and CPU, but now we use HotplugHandler to make hotplug. So ICC Bus is unnecessary. This code has passed the new pc-cpu-test. And I have tested with kvm along with kernel_irqchip=on/off, it works fine. This patch series is based on Eduardo

Re: [Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-02 Thread Gerd Hoffmann
Hi, > Yes, I use sdl audio with sdl ui, sdl1 version (since > sdl2 had its shortcomings in qemu, not all functionality > worked). Does it work equally well with the gtk ui? Possibly it makes sense to use keep sdl audio and default to it only in case sdl ui is active (simliar to how spice audio

Re: [Qemu-devel] [PATCH target-arm v1 3/9] target-arm/helper.c: define MPUIR register

2015-06-02 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 11:50 AM, Peter Maydell wrote: > On 1 June 2015 at 19:04, Peter Crosthwaite > wrote: >> Just hardcoded to 16way unified MPU. >> >> Signed-off-by: Peter Crosthwaite >> --- >> target-arm/cpu.h| 2 ++ >> target-arm/helper.c | 4 >> 2 files changed, 6 insertions(+)

Re: [Qemu-devel] [PATCH target-arm v1 1/9] target-arm: Prepare support for Cortex-R5

2015-06-02 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 11:44 AM, Peter Maydell wrote: > On 1 June 2015 at 19:04, Peter Crosthwaite > wrote: >> Introduce a CPU model for the Cortex R5 processor. ARMv7 with MPU, >> and both thumb and ARM div instructions. >> >> Signed-off-by: Peter Crosthwaite > > This patch needs to go last, n

Re: [Qemu-devel] [PATCH 0/3] qcow2: Fix MIN_L2_CACHE_SIZE

2015-06-02 Thread Kevin Wolf
Am 01.06.2015 um 18:09 hat Max Reitz geschrieben: > This series fixes MIN_L2_CACHE_SIZE (which should not be 1, but 2 > (clusters)), and introduces a new constant, DEFAULT_L2_CACHE_CLUSTERS, > so the default cache size is no longer always a fixed size in bytes but > is also guaranteed to be able to

[Qemu-devel] [PATCH] sheepdog: Fix error message if failed to load vmstate

2015-06-02 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/sheepdog.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index bd7cbed..a22f838 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -2556,7 +2556,11 @@ static int do_load_save_vmstate(BDRVSheepdo

Re: [Qemu-devel] [RFC v2 03/34] Makefile.target: Introduce arch-obj

2015-06-02 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 12:10 PM, Richard Henderson wrote: > On 05/30/2015 11:11 PM, Peter Crosthwaite wrote: >> # >> # cpu emulator library >> -obj-y = exec.o translate-all.o cpu-exec.o >> -obj-y += tcg/tcg.o tcg/tcg-op.o tcg/optimize.o >>

Re: [Qemu-devel] [PATCH target-arm v1 1/9] target-arm: Prepare support for Cortex-R5

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 10:25, Peter Crosthwaite wrote: > On Mon, Jun 1, 2015 at 11:44 AM, Peter Maydell > wrote: >>> +static void cortex_r5_initfn(Object *obj) >>> +{ >>> +ARMCPU *cpu = ARM_CPU(obj); >>> + >>> +set_feature(&cpu->env, ARM_FEATURE_V7); >>> +set_feature(&cpu->env, ARM_FEATUR

Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-06-02 Thread Gerd Hoffmann
Hi, > > I can't see a strong reasons to change things. The docs clearly > > recommend to use opt/ prefix to avoid conflicts. That is fine IMHO. > > > > I don't feel like enforcing that in code, being able to use something > > else can be useful for debugging/testing purposes. For example the

Re: [Qemu-devel] [RFC v2 11/34] include/exec: Move cputlb exec.c defs out

2015-06-02 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 12:56 AM, Paolo Bonzini wrote: > > > On 31/05/2015 08:11, Peter Crosthwaite wrote: >> Move the architecture agnostic function prototypes for exec.c out of >> cputlb.h to exec-all.h. This allows hiding of the arch specific >> cputlb.h from exec.c which should be getting close

Re: [Qemu-devel] [PATCH] sheepdog: Fix error message if failed to load vmstate

2015-06-02 Thread Kevin Wolf
[ CC to Sheepdog maintainers ] Am 02.06.2015 um 11:32 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > --- > block/sheepdog.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index bd7cbed..a22f838 100644 > --- a/block/sh

Re: [Qemu-devel] [PATCH v7 0/3] target-mips: Add support for misaligned accesses

2015-06-02 Thread Leon Alrae
On 01/06/2015 12:13, Yongbok Kim wrote: > This patch set adds support for misaligned memory accesses in MIPS > architecture > Release 6 and MIPS SIMD Architecture. > > The behaviour, semantics, and architecture specifications of misaligned memory > accesses are described in: > MIPS Architecture F

Re: [Qemu-devel] [PATCH target-arm v1 3/9] target-arm/helper.c: define MPUIR register

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 10:29, Peter Crosthwaite wrote: > On Mon, Jun 1, 2015 at 11:50 AM, Peter Maydell > wrote: >> On 1 June 2015 at 19:04, Peter Crosthwaite >> wrote: >>> Just hardcoded to 16way unified MPU. >>> >>> Signed-off-by: Peter Crosthwaite >>> --- >>> target-arm/cpu.h| 2 ++ >>> ta

Re: [Qemu-devel] [RFC v2 21/34] core: virtualise CPU interfaces completely

2015-06-02 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 1:11 AM, Paolo Bonzini wrote: > > > On 31/05/2015 08:11, Peter Crosthwaite wrote: >> } >> -ret = cpu_exec(cpu); >> +ret = cpu->cpu_exec(cpu); > > Perhaps a > > #ifdef TARGET_MULTI > #define MULTI_CPU_HOOK(cpu, fn) (cpu->fn) > #else > #define MULTI_CPU_HOOK(cpu,

Re: [Qemu-devel] [RFC v2 21/34] core: virtualise CPU interfaces completely

2015-06-02 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 12:53 PM, Richard Henderson wrote: > On 05/30/2015 11:11 PM, Peter Crosthwaite wrote: >> The tcg_ctx global is tricky. It needs to become part of the cpu state. >> This is done via a pointer. > > Why does it need to be virtualized? We already have one for each arch-obj-y. >

Re: [Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in

2015-06-02 Thread Kővágó Zoltán
2015-06-02 09:56 keltezéssel, Gerd Hoffmann írta: -static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as) +static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as, + void *drv_opaque) { ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw; struct alsa_

Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()

2015-06-02 Thread Kevin Wolf
Am 29.05.2015 um 11:24 hat Alberto Garcia geschrieben: > After having emptied the cache, the data in the cache tables is no > longer useful, so we can tell the kernel that we are done with it. In > Linux this frees the resources associated with it. > > The effect of this can be seen in the HMP com

Re: [Qemu-devel] [RFC v2 10/34] include/exec: Split target_long def to new header

2015-06-02 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 1:32 PM, Richard Henderson wrote: > On 06/01/2015 12:51 PM, Paolo Bonzini wrote: >> >> >> >> On 01/06/2015 21:24, Richard Henderson wrote: >>> >>> On 05/30/2015 11:11 PM, Peter Crosthwaite wrote: This is currently provided by cpu-defs and is a target specific

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-06-02 Thread Liviu Ionescu
> On 01 Jun 2015, at 01:59, Liviu Ionescu wrote: > > >> On 01 Jun 2015, at 01:10, Peter Crosthwaite >> wrote: >> >> ... If >> there is an ARM doc specifying this (separate from ARM ARM M profile >> doc) then let me know, cause this will very easily justify the change >> you just made. That s

Re: [Qemu-devel] [PATCH] sheepdog: Fix error message if failed to load vmstate

2015-06-02 Thread Michael Tokarev
02.06.2015 12:32, Fam Zheng wrote: > if (ret < 0) { > -error_report("failed to save vmstate %s", strerror(errno)); > +if (load) { > +error_report("failed to load vmstate %s", strerror(errno)); > +} else { > +error_report("

Re: [Qemu-devel] [PATCH] sheepdog: Fix error message if failed to load vmstate

2015-06-02 Thread Fam Zheng
On Tue, 06/02 11:45, Kevin Wolf wrote: > [ CC to Sheepdog maintainers ] > > Am 02.06.2015 um 11:32 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > --- > > block/sheepdog.c | 6 +- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/block/sheepdog.c b/block/sh

Re: [Qemu-devel] [PULL fixup] pc build fix

2015-06-02 Thread Peter Maydell
On 1 June 2015 at 20:42, Michael S. Tsirkin wrote: > The following changes since commit 830d70db692e374b5f4407f96a1ceefdcc97: > > vhost-user: add multi queue support (2015-06-01 14:18:55 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.g

Re: [Qemu-devel] [PATCH] sheepdog: Fix error message if failed to load vmstate

2015-06-02 Thread Fam Zheng
On Tue, 06/02 13:16, Michael Tokarev wrote: > 02.06.2015 12:32, Fam Zheng wrote: > > if (ret < 0) { > > -error_report("failed to save vmstate %s", strerror(errno)); > > +if (load) { > > +error_report("failed to load vmstate %s", strerror(errno)); > >

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-06-02 Thread Peter Crosthwaite
On Tue, Jun 2, 2015 at 3:15 AM, Liviu Ionescu wrote: > >> On 01 Jun 2015, at 01:59, Liviu Ionescu wrote: >> >> >>> On 01 Jun 2015, at 01:10, Peter Crosthwaite >>> wrote: >>> >>> ... If >>> there is an ARM doc specifying this (separate from ARM ARM M profile >>> doc) then let me know, cause this

Re: [Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-02 Thread Paolo Bonzini
On 02/06/2015 11:28, Gerd Hoffmann wrote: > > SDL audio has been the default in Debian for at least two > > debian releases because of that, we explicitly used > > --audio-drv-list=sdl,... to list sdl first. Now we have > > pa first, but I don't really remember why we changed it. > > Useful data

Re: [Qemu-devel] [PATCH 1/1] net: fix queue's purge on VM stop

2015-06-02 Thread Stefan Hajnoczi
On Fri, May 29, 2015 at 04:28:48PM +0200, Thibaut Collet wrote: > I agree that virtio-net NIC never enqueues packet to vhost-user > but qemu_announce_self function (savevm.c file) can do it through > the qemu_announce_self_iter / qemu_send_packet_raw sequence. Does vhost-user support live migratio

Re: [Qemu-devel] [RFC v2 03/34] Makefile.target: Introduce arch-obj

2015-06-02 Thread Paolo Bonzini
On 02/06/2015 11:40, Peter Crosthwaite wrote: > > Is arch-obj-n added to obj-y somewhere I'm missing? Such an inclusion would > > seem to tidy some of the lines above... > > No it's not. I didn't even know that was ok. Indeed it's not a great idea, because such objects would be split between ar

Re: [Qemu-devel] [RFC v2 11/34] include/exec: Move cputlb exec.c defs out

2015-06-02 Thread Paolo Bonzini
On 02/06/2015 11:44, Peter Crosthwaite wrote: > On Mon, Jun 1, 2015 at 12:56 AM, Paolo Bonzini wrote: >> >> >> On 31/05/2015 08:11, Peter Crosthwaite wrote: >>> Move the architecture agnostic function prototypes for exec.c out of >>> cputlb.h to exec-all.h. This allows hiding of the arch specifi

Re: [Qemu-devel] [RFC v2 21/34] core: virtualise CPU interfaces completely

2015-06-02 Thread Paolo Bonzini
On 02/06/2015 11:52, Peter Crosthwaite wrote: > > to devirtualize the functions in the common case? > > Yes. Can we make it briefer though as CPU_HOOK? I don't think we need > to references to MULTI through the core code. Goes without saying. :) Paolo

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 11:32, Peter Crosthwaite wrote: > On Tue, Jun 2, 2015 at 3:15 AM, Liviu Ionescu wrote: >> similar content is also present in Table B3-1 "ARMv7-M address map", in ARM >> DDI 0403D, "ARMv7-M Architecture Reference Manual". >> >> 0x-0x1FFF | Code | Typically ROM or fla

Re: [Qemu-devel] [PATCH 00/12] Audio backend cleanup

2015-06-02 Thread Peter Maydell
On 2 June 2015 at 10:12, Michael Tokarev wrote: > I also tried alsa, oss and pa, with these audio was more > distorted than with sdl. Sdl version sounds cleanly, while > alsa and pa, at least in the past, and at least if memory > serves me right, sounded like a if a good portion of noize > has be

Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()

2015-06-02 Thread Alberto Garcia
On Tue 02 Jun 2015 12:05:59 PM CEST, Kevin Wolf wrote: >> +#include >> #include "block/block_int.h" >> #include "qemu-common.h" >> +#include "qemu/osdep.h" >> #include "qcow2.h" >> #include "trace.h" > > This breaks the mingw build: > > /mnt/qemu/block/qcow2-cache.c:25:22: fatal error: sys/m

Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()

2015-06-02 Thread Kevin Wolf
Am 02.06.2015 um 12:50 hat Alberto Garcia geschrieben: > On Tue 02 Jun 2015 12:05:59 PM CEST, Kevin Wolf wrote: > > >> +#include > >> #include "block/block_int.h" > >> #include "qemu-common.h" > >> +#include "qemu/osdep.h" > >> #include "qcow2.h" > >> #include "trace.h" > > > > This breaks t

Re: [Qemu-devel] [RFC] extensions to the -m memory option

2015-06-02 Thread Liviu Ionescu
> On 02 Jun 2015, at 13:42, Peter Maydell wrote: > > On 2 June 2015 at 11:32, Peter Crosthwaite > wrote: >> On Tue, Jun 2, 2015 at 3:15 AM, Liviu Ionescu wrote: >>> similar content is also present in Table B3-1 "ARMv7-M address map", in ARM >>> DDI 0403D, "ARMv7-M Architecture Reference Manu

Re: [Qemu-devel] [PATCH v2 01/17] mips jazz: compile only in 64 bit little endian

2015-06-02 Thread Aurelien Jarno
On 2015-05-27 14:19, Hervé Poussineau wrote: > Remove now useless device models from other MIPS configurations > > We're now compiling 18 files less than before. > > Signed-off-by: Hervé Poussineau > --- > default-configs/mips-softmmu.mak | 5 - > default-configs/mips64-softmmu.mak |

Re: [Qemu-devel] [PATCH v2 02/17] dma/rc4030: create custom DMA address space

2015-06-02 Thread Aurelien Jarno
On 2015-05-27 14:19, Hervé Poussineau wrote: > Add a new memory region in system address space where DMA address space > definition (the 'translation table') belongs, so we can update on the fly > the DMA address space. > > Signed-off-by: Hervé Poussineau > --- > Cc: Paolo Bonzini > hw/dma/rc40

Re: [Qemu-devel] [PATCH v2 04/17] dma/rc4030: do not use old_mmio accesses

2015-06-02 Thread Aurelien Jarno
On 2015-05-27 14:19, Hervé Poussineau wrote: > Signed-off-by: Hervé Poussineau > --- > hw/dma/rc4030.c | 112 > > 1 file changed, 16 insertions(+), 96 deletions(-) > > diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c > index a0b617f..96f796

  1   2   3   4   5   >