[Qemu-devel] [PATCH v2 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Shannon Zhao
The private qdev properties of virtio devices are only used by themselves. As Peter suggested and like what virtio-blk has done, we should move the private qdev properties into devices and don't expose them to avoid wrongly use. changes since v1: * address Cornelia's comments, fix the indentatio

Re: [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-10 Thread Eric Blake
On 06/10/2015 07:43 AM, Kevin Wolf wrote: > >>> Let's stay away from such magic, as much as we can. libvirt can just >>> specify a node-name for the protocol layer and use that. >> >> Okay, I'll probably abandon this patch, then, but still work on >> something to make node names easier for libvir

Re: [Qemu-devel] [PULL 0/1] CVE-2015-3209 pcnet tx buffer fix patches

2015-06-10 Thread Peter Maydell
On 10 June 2015 at 15:04, Stefan Hajnoczi wrote: > This is a security fix for CVE-2015-3209. Please see the patch for details. > > The following changes since commit b0411142f482df92717f8b4a3b746081a62b724f: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150609' into > staging (

Re: [Qemu-devel] [Qemu-stable] [PATCH] spice-display: fix segfault in qemu_spice_create_update

2015-06-10 Thread Cole Robinson
On 06/10/2015 05:24 AM, Gerd Hoffmann wrote: > Although it is pretty unusual the stride for the guest image and the > mirror image maintained by spice-display can be different. So use > separate variables for them. > > Cc: qemu-sta...@nongnu.org > Reported-by: perrier vincent > Signed-off-by: Ge

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Shannon Zhao
On 2015/6/10 22:36, Michael S. Tsirkin wrote: On Wed, Jun 10, 2015 at 10:28:21PM +0800, Shannon Zhao wrote: On 2015/6/10 22:01, Michael S. Tsirkin wrote: On Wed, Jun 10, 2015 at 09:38:24PM +0800, Shannon Zhao wrote: On 2015/6/10 21:21, Michael S. Tsirkin wrote: On Wed, Jun 10, 2015 at 0

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 10:28:21PM +0800, Shannon Zhao wrote: > > > On 2015/6/10 22:01, Michael S. Tsirkin wrote: > >On Wed, Jun 10, 2015 at 09:38:24PM +0800, Shannon Zhao wrote: > >> > >> > >>On 2015/6/10 21:21, Michael S. Tsirkin wrote: > >>>On Wed, Jun 10, 2015 at 09:18:27PM +0800, Shannon Zha

Re: [Qemu-devel] [PATCH 2/8] qcow2: add dirty-bitmaps feature

2015-06-10 Thread Stefan Hajnoczi
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy wrote: I noticed a corner case, it's probably not a problem in practice: Since the dirty bitmap is stored with the help of a BlockDriverState (and its bs->file), it's possible that writing the bitmap will cause bits in the bit

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Shannon Zhao
On 2015/6/10 22:01, Michael S. Tsirkin wrote: On Wed, Jun 10, 2015 at 09:38:24PM +0800, Shannon Zhao wrote: On 2015/6/10 21:21, Michael S. Tsirkin wrote: On Wed, Jun 10, 2015 at 09:18:27PM +0800, Shannon Zhao wrote: Ping? Have these patches been missed? I see them upstream. See e.g. da3e

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 04:22:10PM +0200, Thibaut Collet wrote: > I am not sure to understand your comments. > > Could you confirm that the useless warning is: > +        fprintf(stderr, > +                "Warning: Guest with no VIRTIO_NET_F_GUEST_ANNOUNCE support. > RARP must be sent by vhost-us

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Thibaut Collet
I am not sure to understand your comments. Could you confirm that the useless warning is: +fprintf(stderr, +"Warning: Guest with no VIRTIO_NET_F_GUEST_ANNOUNCE support. RARP must be sent by vhost-user backend\n"); > Can you move this out to vhost-user? It's not a generic f

[Qemu-devel] [RFC PATCH] qemu-log: Open file for logging when specified

2015-06-10 Thread Pranith Kumar
qemu-log defaults to stderr when there is no '-D' option mentioned on command line. When '-D' option is specified, we also need to specify '-d' option for it to use the specified logfile. When using monitor to enable logging this is troublesome since there will be no '-d' option because of which mo

[Qemu-devel] [PULL 0/1] CVE-2015-3209 pcnet tx buffer fix patches

2015-06-10 Thread Stefan Hajnoczi
This is a security fix for CVE-2015-3209. Please see the patch for details. The following changes since commit b0411142f482df92717f8b4a3b746081a62b724f: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150609' into staging (2015-06-09 15:29:34 +0100) are available in the git reposit

[Qemu-devel] [PULL 1/1] pcnet: force the buffer access to be in bounds during tx

2015-06-10 Thread Stefan Hajnoczi
From: Petr Matousek 4096 is the maximum length per TMD and it is also currently the size of the relay buffer pcnet driver uses for sending the packet data to QEMU for further processing. With packet spanning multiple TMDs it can happen that the overall packet size will be bigger than sizeof(buffe

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-10 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 09.06.2015 20:03, Stefan Hajnoczi wrote: > >On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: > >>@@ -166,6 +167,19 @@ the header extension data. Each entry look like this: > >>

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 09:38:24PM +0800, Shannon Zhao wrote: > > > On 2015/6/10 21:21, Michael S. Tsirkin wrote: > >On Wed, Jun 10, 2015 at 09:18:27PM +0800, Shannon Zhao wrote: > >>Ping? > >>Have these patches been missed? > > > >I see them upstream. See e.g. da3e8a23492dbc13c4b70d90b6ae4297062

[Qemu-devel] [PATCH v2 03/13] check-qdict: Test cases for new functions

2015-06-10 Thread Kevin Wolf
This adds test cases for the following new QDict functions: * qdict_array_entries() * qdict_set_default_str() * qdict_copy_default() Signed-off-by: Kevin Wolf --- tests/check-qdict.c | 67 + 1 file changed, 67 insertions(+) diff --git a/tests

Re: [Qemu-devel] [PATCH 08/34] block: Add list of children to BlockDriverState

2015-06-10 Thread Max Reitz
On 10.06.2015 14:09, Kevin Wolf wrote: Am 11.05.2015 um 17:45 hat Max Reitz geschrieben: On 08.05.2015 19:21, Kevin Wolf wrote: This allows iterating over all children of a given BDS, not only including bs->file and bs->backing_hd, but also driver-specific ones like VMDK extents or Quorum child

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 03:43:02PM +0200, Thibaut Collet wrote: > Some vhost client/backend are able to support live migration. > To provide this service the following features must be added: > 1. GARP from guest after live migration: >the VIRTIO_NET_F_GUEST_ANNOUNCE capability is added to vhos

[Qemu-devel] [PATCH v2 11/13] block: Add list of children to BlockDriverState

2015-06-10 Thread Kevin Wolf
This allows iterating over all children of a given BDS, not only including bs->file and bs->backing_hd, but also driver-specific ones like VMDK extents or Quorum children. For bdrv_swap(), the list of children of the swapped BDS stays at that BDS (because that's where the pointers stay as well). T

[Qemu-devel] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common()

2015-06-10 Thread Kevin Wolf
Instead of manually parsing options and then deleting them from the options QDict, just use QemuOpts like most other places that deal with block device options. More options will be added there and then QemuOpts is a lot more managable than open-coding everything. Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH v2 01/13] qdict: Add qdict_array_entries()

2015-06-10 Thread Kevin Wolf
This counts the entries in a flattened array in a QDict without actually splitting the QDict into a QList. bdrv_open_image() doesn't take a QList, but rather a QDict and a key prefix string, so this is more convenient for block drivers which have a dynamically sized list of child nodes (e.g. Quoru

[Qemu-devel] [PATCH v2 08/13] block: Move flag inheritance to bdrv_open_inherit()

2015-06-10 Thread Kevin Wolf
Instead of letting every caller of bdrv_open() determine the right flags for its child node manually and pass them to the function, pass the parent node and the role of the newly opened child (like backing file, protocol layer, etc.). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by

[Qemu-devel] [PATCH v2 00/13] bdrv_reopen() overhaul, part 1

2015-06-10 Thread Kevin Wolf
This is v2 of the first part of the series "[PATCH 00/34] block: Cache mode for children, reopen overhaul and more". Review of v1 turned up some larger issues that need to be addressed as a prerequisite for some patches (essentially bdrv_swap() removal is needed), so I decided to split the series i

[Qemu-devel] [PATCH v2 10/13] queue.h: Add QLIST_FIX_HEAD_PTR()

2015-06-10 Thread Kevin Wolf
If the head of a list has been moved to a different memory location, the le_prev link in the first list entry has to be fixed up. Provide a macro that implements this fixup. Signed-off-by: Kevin Wolf --- include/qemu/queue.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/qemu/

[Qemu-devel] [PATCH v2 12/13] block: Add BlockDriverState.inherits_from

2015-06-10 Thread Kevin Wolf
Currently, the block layer assumes that any block node can have only one parent, and if it has a parent, that it inherits some options/flags from this parent. This is not true any more: With references used in block device creation, a single node can be used by multiple parents, or it can be creat

[Qemu-devel] [PATCH v2 09/13] block: Drain requests before swapping nodes in bdrv_swap()

2015-06-10 Thread Kevin Wolf
bdrv_swap() requires that there are no requests in flight on either of the two devices. The request coroutine would work on the wrong BlockDriverState object (with bs->opaque even being interpreted as a different type potentially) and all sorts of bad things would result from this. The currently e

[Qemu-devel] [PATCH v2 05/13] vmdk: Use bdrv_open_image()

2015-06-10 Thread Kevin Wolf
Besides standardising on a single interface for opening child nodes, this patch allows the user to specify options to individual extent nodes. Overriding file names isn't possible with this yet, so it's of limited usefulness, but still a step forward. Signed-off-by: Kevin Wolf Reviewed-by: Eric B

[Qemu-devel] [PATCH v2 04/13] quorum: Use bdrv_open_image()

2015-06-10 Thread Kevin Wolf
Besides standardising on a single interface for opening child nodes, this simplifies the .bdrv_open() implementation of the quorum block driver by using block layer functionality for handling BlockdevRefs. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Jef

[Qemu-devel] [PATCH v2 13/13] block: Fix reopen flag inheritance

2015-06-10 Thread Kevin Wolf
When reopening an image, the block layer already takes care to reopen bs->file as well with recalculated inherited flags. The same must happen for any other child (most notably missing before this patch: backing files). If bs->file (or any other child) didn't originally inherit from bs, e.g. becau

[Qemu-devel] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default()

2015-06-10 Thread Kevin Wolf
In the block layer functions that determine options for a child block device, it's a common pattern to either copy options from the parent's options or to set a default string if the option isn't explicitly set yet for the child. Provide convenience functions so that it becomes a one-liner for each

[Qemu-devel] [PATCH v2 06/13] block: Use macro for cache option names

2015-06-10 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Jeff Cody Reviewed-by: Alberto Garcia --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/blockdev.c

[Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-10 Thread Thibaut Collet
In case of live migration with legacy guest (without VIRTIO_NET_F_GUEST_ANNOUNCE) a message is added between QEMU and the vhost client/backend. This message provides the RARP content, prepared by QEMU, to the vhost client/backend. The vhost client/backend is responsible to send the RARP. Signed-o

[Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Thibaut Collet
Some vhost client/backend are able to support live migration. To provide this service the following features must be added: 1. GARP from guest after live migration: the VIRTIO_NET_F_GUEST_ANNOUNCE capability is added to vhost-net when netdev backend is vhost-user to let virtio-net NIC manages

[Qemu-devel] [PATCH v3 0/2] Add live migration for vhost user

2015-06-10 Thread Thibaut Collet
This patch is an update of [PATCH v2] net: Add support of VIRTIO_NET_F_GUEST_ANNOUNCE for vhost-net/vhost-user v2->v3 Define a receive function to vhost-user to manage RARP packet send after a live migration. If the guest supports VIRTIO_NET_F_GUEST_ANNOUNCE the packet is discarded (GARP request i

Re: [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-10 Thread Kevin Wolf
Am 10.06.2015 um 15:07 hat Eric Blake geschrieben: > On 06/10/2015 01:57 AM, Kevin Wolf wrote: > > >> > >> The statistic I'm interested in is the allocation of the block device > >> (the host offset, aka wr_highest_offset 72482304 above), and NOT the > >> usage pattern of the guest (the qcow2 prot

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Shannon Zhao
On 2015/6/10 21:21, Michael S. Tsirkin wrote: On Wed, Jun 10, 2015 at 09:18:27PM +0800, Shannon Zhao wrote: Ping? Have these patches been missed? I see them upstream. See e.g. da3e8a23492dbc13c4b70d90b6ae42970624e63a. What's missing? da3e8a23492dbc13c4b70d90b6ae42970624e63a is "virtio-net

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 01:06:27PM +0100, Jan Beulich wrote: > >>> On 10.06.15 at 13:43, wrote: > > On Wed, Jun 10, 2015 at 08:00:55AM +0100, Jan Beulich wrote: > >> >>> On 08.06.15 at 13:28, wrote: > >> > On Mon, Jun 08, 2015 at 11:55:22AM +0100, Jan Beulich wrote: > >> >> while function 0 has >

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-10 Thread Denis V. Lunev
On 10/06/15 16:13, Michael S. Tsirkin wrote: On Wed, Jun 10, 2015 at 03:02:21PM +0300, Denis V. Lunev wrote: On 09/06/15 13:37, Christian Borntraeger wrote: Am 09.06.2015 um 12:19 schrieb Denis V. Lunev: Excessive virtio_balloon inflation can cause invocation of OOM-killer, when Linux is under

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 09:18:27PM +0800, Shannon Zhao wrote: > Ping? > Have these patches been missed? I see them upstream. See e.g. da3e8a23492dbc13c4b70d90b6ae42970624e63a. What's missing?

Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

2015-06-10 Thread Shannon Zhao
Ping? Have these patches been missed? On 2015/4/29 23:24, Shannon Zhao wrote: The private qdev properties of virtio devices are only used by themselves. As Peter suggested and like what virtio-blk has done, we should move the private qdev properties into devices and don't expose them to avoid wr

Re: [Qemu-devel] [PATCH v3 1/3] ich9: add TCO interface emulation

2015-06-10 Thread Paulo Alcantara
On Mon, June 1, 2015 8:48 pm, Paulo Alcantara wrote: > This interface provides some registers within a 32-byte range and can be > acessed through PCI-to-LPC bridge interface (PMBASE + 0x60). > > It's commonly used as a watchdog timer to detect system lockups through > SMIs that are generated -- if

Re: [Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2015-06-10 Thread wzis
I'm running qemu 2.3.0 on a RHEL5.3/x86 box, 1.5.3 on a CentOS6.6/x86 box. > Date: Wed, 10 Jun 2015 12:25:22 + > From: dgilb...@redhat.com > To: w...@hotmail.com > Subject: [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk > corruption > > Hi, > Can you add some details about yo

Re: [Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2015-06-10 Thread wzis
I'm using: qemu-system-ppc64 -hda ppcrhel5.img -cpu POWER7 -machine type=pseries,usb=off -m 768 -nographic -net nic -net tap,ifname=tap0,script=no It's on local disk. same as on qemu 1.5.3. > Date: Wed, 10 Jun 2015 12:29:56 + > From: dgilb...@redhat.com > To: w...@hotmail.com > Subject: [Bug 1

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 03:02:21PM +0300, Denis V. Lunev wrote: > On 09/06/15 13:37, Christian Borntraeger wrote: > >Am 09.06.2015 um 12:19 schrieb Denis V. Lunev: > >>Excessive virtio_balloon inflation can cause invocation of OOM-killer, > >>when Linux is under severe memory pressure. Various mech

Re: [Qemu-devel] [PATCH] block: allow write-threshold on device name

2015-06-10 Thread Eric Blake
On 06/10/2015 01:57 AM, Kevin Wolf wrote: >> >> The statistic I'm interested in is the allocation of the block device >> (the host offset, aka wr_highest_offset 72482304 above), and NOT the >> usage pattern of the guest (the qcow2 protocol, wr_highest_offset >> 9129332224). But bdrv_lookup_bs() f

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-10 Thread Eric Blake
On 06/10/2015 02:19 AM, Vladimir Sementsov-Ogievskiy wrote: >>> +Dirty bitmaps is an optional header extension. It provides a >>> possibility of >>> +storing dirty bitmaps in qcow2 image. The fields are: >>> + >>> + 0 - 3: nb_dirty_bitmaps >>> + Number of dirty bitmaps

[Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2015-06-10 Thread wzis
2.3.0 running RHEL7,1 little-endian version no problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1463812 Title: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption Status in QEMU: New Bu

Re: [Qemu-devel] [RFC PATCH v0] numa: API to lookup NUMA node by address

2015-06-10 Thread Bharata B Rao
On Wed, Jun 10, 2015 at 11:43:19AM +0200, Igor Mammedov wrote: > On Tue, 9 Jun 2015 09:40:54 -0300 > Eduardo Habkost wrote: > > > On Tue, Jun 09, 2015 at 11:23:19AM +0200, Igor Mammedov wrote: > > > On Mon, 8 Jun 2015 12:51:39 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Jun 08, 201

Re: [Qemu-devel] [PATCH 00/33] virtio 1.0 patch series rebased

2015-06-10 Thread Michael S. Tsirkin
On Thu, Jun 04, 2015 at 12:34:09PM +0200, Gerd Hoffmann wrote: > Hi, > > Here comes the virtio 1.0 patch series, rebased to latest master. > Patches 1-23 are based on the old branch by cornelia & mst. > Patches 24-30 are virtio-pci bits on top of that. > Patches 31-33 add virtio-pci support for

[Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2015-06-10 Thread Dr. David Alan Gilbert
Hi, Can you add some details about your host and guest please: 1) What's your host system? (ppc64 or x86? which os?) 2) What's the guest disk image format - raw or qcow2? 3) could you try some of the versions in between 2.3.0 and 1.5.3 ? 4) Is it just the 5.9 image that has proble

[Qemu-devel] [Bug 1463812] Re: qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2015-06-10 Thread Dr. David Alan Gilbert
Oh and: 5) What's your disk image stored on - local disk or network? 6) WHat's the command line you're using for your guest -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1463812 Title: qemu-s

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Daniel Gutson
El 10/6/2015 7:45, "Peter Maydell" escribió: > > On 10 June 2015 at 10:58, Liviu Ionescu wrote: > > > >> On 29 May 2015, at 22:16, Martin Galvan < martin.gal...@tallertechnologies.com> wrote: > >> > >> > >> ... I think Peter M is the maintainer for Target-ARM. > >> > >> Peter, is this OK to commi

[Qemu-devel] [Bug 1463812] [NEW] qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption

2015-06-10 Thread wzis
Public bug reported: copied the RHEL5.9 power disk image from qemu 1.5.3, run it under qemu 2.3.0, corrupted; copied again, run, corrupted again. Run the image on qemu 1.5.3, no problem. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification beca

Re: [Qemu-devel] [RFC PATCH v0] numa: API to lookup NUMA node by address

2015-06-10 Thread Eduardo Habkost
On Wed, Jun 10, 2015 at 11:43:19AM +0200, Igor Mammedov wrote: > On Tue, 9 Jun 2015 09:40:54 -0300 > Eduardo Habkost wrote: > > > On Tue, Jun 09, 2015 at 11:23:19AM +0200, Igor Mammedov wrote: > > > On Mon, 8 Jun 2015 12:51:39 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Jun 08, 201

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-10 Thread Jan Beulich
>>> On 10.06.15 at 13:46, wrote: > I don't really know. The idea would be that device > is not designed for memory to be disabled when it's > active, and starts behaving in broken ways. But you recall that we know the origin of the offending write is in the hypervisor, and we also know that the d

Re: [Qemu-devel] [PATCH 08/34] block: Add list of children to BlockDriverState

2015-06-10 Thread Kevin Wolf
Am 11.05.2015 um 17:45 hat Max Reitz geschrieben: > On 08.05.2015 19:21, Kevin Wolf wrote: > >This allows iterating over all children of a given BDS, not only > >including bs->file and bs->backing_hd, but also driver-specific > >ones like VMDK extents or Quorum children. > > > >Signed-off-by: Kevin

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-10 Thread Jan Beulich
>>> On 10.06.15 at 13:43, wrote: > On Wed, Jun 10, 2015 at 08:00:55AM +0100, Jan Beulich wrote: >> >>> On 08.06.15 at 13:28, wrote: >> > On Mon, Jun 08, 2015 at 11:55:22AM +0100, Jan Beulich wrote: >> >> while function 0 has >> >> >> >> 0x10: Base Address Register 0 = 0xca23000c (Memory space,

[Qemu-devel] [PATCH 3/3] virtio-vga: add '-vga virtio' support

2015-06-10 Thread Gerd Hoffmann
Some convinience fluff: Add support for '-vga virtio', also add virtio-vga to the list of vga cards so '-device virtio-vga' will turn off the default vga. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- hw/isa/isa-bus.c| 3 +++ hw

[Qemu-devel] [PATCH 0/3] virtio-gpu: pci support bits.

2015-06-10 Thread Gerd Hoffmann
Hi, Here is the code to add virtio-pci support for the virtio-gpu. This series depends on the vga pull request sent earlier today the the virtio-1.0 patch series sent last week. vgabios support is not included yet as this depends on not-yet merged changes in seabios. This series with dependenc

Re: [Qemu-devel] PXB fixes for QEMU, and extra root buses for OVMF

2015-06-10 Thread Laszlo Ersek
On 06/10/15 13:55, Marcel Apfelbaum wrote: > On 06/10/2015 02:04 PM, Laszlo Ersek wrote: >> On 06/10/15 11:09, Marcel Apfelbaum wrote: >>> On 06/06/2015 02:45 AM, Laszlo Ersek wrote: >> (7) At least one issue remains to be solved (designed) in QEMU, for both SeaBIOS's and OVMF'

[Qemu-devel] [PATCH 2/3] virtio-vga: add virtio gpu device with vga compatibility

2015-06-10 Thread Gerd Hoffmann
This patch adds a virtio-vga device. It is simliar to virtio-gpu-pci, but it also adds in vga compatibility, so guests without native virtio-gpu support can drive the device in vga mode. It is compatible with stdvga. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-o

[Qemu-devel] [PATCH 1/3] virtio-gpu-pci: add virtio pci support

2015-06-10 Thread Gerd Hoffmann
This patch adds virtio-gpu-pci, which is the pci proxy for the virtio gpu device. With this patch in place virtio-gpu is functional. You need a linux guest with a virtio-gpu driver though, and output will appear pretty late in boot, once the kernel initialized drm and fbcon. Written by Dave Airl

Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface

2015-06-10 Thread Jason J. Herne
On 06/10/2015 04:45 AM, Dr. David Alan Gilbert wrote: * Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: On 06/09/2015 04:06 AM, Dr. David Alan Gilbert wrote: * Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: On 06/03/2015 02:11 PM, Jason J. Herne wrote: On 06/03/2015 02:03 PM, Dr. David

Re: [Qemu-devel] [PATCH 1/1] balloon: add a feature bit to let Guest OS deflate balloon on oom

2015-06-10 Thread Denis V. Lunev
On 09/06/15 13:37, Christian Borntraeger wrote: Am 09.06.2015 um 12:19 schrieb Denis V. Lunev: Excessive virtio_balloon inflation can cause invocation of OOM-killer, when Linux is under severe memory pressure. Various mechanisms are responsible for correct virtio_balloon memory management. Never

Re: [Qemu-devel] [PATCH v3 16/16] [RFC] dma/rc4030: do multiple calls to address_space_rw when doing DMA transfers

2015-06-10 Thread Leon Alrae
Hi Hervé, On 03/06/2015 21:45, Hervé Poussineau wrote: > This fixes Windows NT 4.0/MIPS, which was always bugchecking with > IRQL_NOT_LESS_OR_EQUAL. > > Signed-off-by: Hervé Poussineau > --- > hw/dma/rc4030.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --gi

[Qemu-devel] [PATCH] spice: ui_info tweaks

2015-06-10 Thread Gerd Hoffmann
Use the new dpy_ui_info_supported function. Clarifies the control flow. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 4e6356a..cc4a6ce 100644 --- a/ui/spice-d

Re: [Qemu-devel] PXB fixes for QEMU, and extra root buses for OVMF

2015-06-10 Thread Marcel Apfelbaum
On 06/10/2015 02:04 PM, Laszlo Ersek wrote: On 06/10/15 11:09, Marcel Apfelbaum wrote: On 06/06/2015 02:45 AM, Laszlo Ersek wrote: (7) At least one issue remains to be solved (designed) in QEMU, for both SeaBIOS's and OVMF's sake: booting off devices that are located on the PXB. T

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 08:08:37AM +0100, Jan Beulich wrote: > >>> On 08.06.15 at 11:30, wrote: > > What happens if you disable SERR# in the command register > > of 83:00.1? > > We've just been told that with SERR not enabled in any of the > sibling endpoints the NMI still occurs. Not really surp

Re: [Qemu-devel] [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 08:00:55AM +0100, Jan Beulich wrote: > >>> On 08.06.15 at 13:28, wrote: > > On Mon, Jun 08, 2015 at 11:55:22AM +0100, Jan Beulich wrote: > >> while function 0 has > >> > >> 0x10: Base Address Register 0 = 0xca23000c (Memory space, 64-bit access, > >> prefetchable) > >> 0

Re: [Qemu-devel] I/O accounting overhaul

2015-06-10 Thread Alberto Garcia
On Mon 08 Jun 2015 03:21:19 PM CEST, Stefan Hajnoczi wrote: > Please structure the patches so that each statistic or group of > statistics has its own patch. Yes, that's the plan. >> uint64_t queue_depth[BLOCK_MAX_IOTYPE]; >> >>Average number of requests. Similar to the previous one. It w

[Qemu-devel] [PATCH 3/3] block: Let bdrv_drain_all() to call aio_poll() for each AioContext

2015-06-10 Thread Alexander Yarygin
After the commit 9b536adc ("block: acquire AioContext in bdrv_drain_all()") the aio_poll() function got called for every BlockDriverState, in assumption that every device may have its own AioContext. If we have thousands of disks attached, there are a lot of BlockDriverStates but only a few AioCont

[Qemu-devel] [PATCH 1/3] block-backend: Introduce blk_drain()

2015-06-10 Thread Alexander Yarygin
This patch introduces the blk_drain() function which allows to replace blk_drain_all() when only one BlockDriverState needs to be drained. Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Stefan Hajnoczi Signed-off-by: Alexander Yarygin Reviewed-by: Paolo Bonz

[Qemu-devel] [PATCH 2/3] virtio-blk: Use blk_drain() to drain IO requests

2015-06-10 Thread Alexander Yarygin
Each call of the virtio_blk_reset() function calls blk_drain_all(), which works for all existing BlockDriverStates, while draining only one is needed. This patch replaces blk_drain_all() by blk_drain() in virtio_blk_reset(). Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Kevin Wolf Cc: Paolo

[Qemu-devel] [PATCH RFC v2 0/3] Fix slow startup with many disks

2015-06-10 Thread Alexander Yarygin
Changes in v2: - Patch "block-backend: Introduce blk_drain() and replace blk_drain_all()" splitted to two. - blk_drain() moved to above virtio_blk_data_plane_stop(). During reset the aio_poll() function is called at least amount_of_disks^2 times: for_each disk virtio_blk_reset()

Re: [Qemu-devel] should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?

2015-06-10 Thread Radim
2015-06-10 11:31+0100, Marc Zyngier: >On 10/06/15 10:54, Igor Mammedov wrote: >> On Tue, 09 Jun 2015 15:35:21 +0100 >> Marc Zyngier wrote: >>> Indeed. I also missed the step that says "kernel is able to convert >>> arbitrary MPIDR to vcpu_id in an efficient manner...". GICv3 is >>> definitely goin

Re: [Qemu-devel] [virtio] when is VIRTIO_CONFIG_S_DRIVER_OK set?

2015-06-10 Thread Catalin Vasile
The problem was that my device started having activity before the backend was finished to be set up. On Wed, Jun 10, 2015 at 12:26 PM, Catalin Vasile wrote: > When is VIRTIO_CONFIG_S_DRIVER_OK set? > I've seen in vhost-scsi from qemu, that it sets it's own set_status() > member function for a vir

Re: [Qemu-devel] [PATCH 4/4] i386/acpi-build: build_crs(): fetch BAR from PCI config space directly

2015-06-10 Thread Laszlo Ersek
On 06/10/15 12:06, Marcel Apfelbaum wrote: > On 06/09/2015 11:34 PM, Laszlo Ersek wrote: >> On 06/07/15 11:23, Michael S. Tsirkin wrote: >>> On Sat, Jun 06, 2015 at 01:46:29AM +0200, Laszlo Ersek wrote: OVMF downloads the ACPI linker/loader script from QEMU when the edk2 PCI Bus driv

Re: [Qemu-devel] PXB fixes for QEMU, and extra root buses for OVMF

2015-06-10 Thread Laszlo Ersek
On 06/10/15 11:09, Marcel Apfelbaum wrote: > On 06/06/2015 02:45 AM, Laszlo Ersek wrote: >> (7) At least one issue remains to be solved (designed) in QEMU, for both >> SeaBIOS's and OVMF's sake: booting off devices that are located on >> the PXB. The problem is with the "bootorder" fw_cf

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Peter Maydell
On 10 June 2015 at 11:49, Daniel Gutson wrote: > El 10/6/2015 7:45, "Peter Maydell" escribió: >> No; as Peter C suggested, Martin split it into two patches. >> Those patches then got code review, but I don't think Martin >> has sent out a revised series yet. > > Aurelio is the primary author of t

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Peter Maydell
On 10 June 2015 at 10:58, Liviu Ionescu wrote: > >> On 29 May 2015, at 22:16, Martin Galvan >> wrote: >> >> >> ... I think Peter M is the maintainer for Target-ARM. >> >> Peter, is this OK to commit? > > was this patch accepted? No; as Peter C suggested, Martin split it into two patches. Those

Re: [Qemu-devel] "iothread: release iothread around aio_poll" causes random hangs at startup

2015-06-10 Thread Christian Borntraeger
Am 10.06.2015 um 11:34 schrieb Fam Zheng: > On Wed, 06/10 11:18, Christian Borntraeger wrote: >> Am 10.06.2015 um 04:12 schrieb Fam Zheng: >>> On Tue, 06/09 11:01, Christian Borntraeger wrote: Am 09.06.2015 um 04:28 schrieb Fam Zheng: > On Tue, 06/02 16:36, Christian Borntraeger wrote: >>>

Re: [Qemu-devel] should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?

2015-06-10 Thread Marc Zyngier
On 10/06/15 10:54, Igor Mammedov wrote: > On Tue, 09 Jun 2015 15:35:21 +0100 > Marc Zyngier wrote: > >> On 09/06/15 15:01, Peter Maydell wrote: >>> On 9 June 2015 at 15:00, Marc Zyngier wrote: Yeah, what I had in mind was something along the lines of: - kernel computes its "defaul

[Qemu-devel] [PATCH v3 1/2] xen: separate the xenstore_record_dm_state calls for pv and hvm machines

2015-06-10 Thread Stefano Stabellini
The following patch will introduce a new option to restrict the privilege of the xenstore connection. In that case, we do not want to use multiple xenstore connections, but just the one, with lower privileges. For this reason, split the xenstore_record_dm_state calls for pv and hvm machines, so th

Re: [Qemu-devel] [PATCH 1/2] block-backend: Introduce blk_drain() and replace blk_drain_all()

2015-06-10 Thread Fam Zheng
On Wed, 06/03 16:46, Alexander Yarygin wrote: > Each call of the virtio_blk_reset() function calls blk_drain_all(), > which works for all existing BlockDriverStates, while only one > BlockDriverState needs to be drained. > > This patch introduces the blk_drain() function and replaces > blk_drain_a

Re: [Qemu-devel] [PATCH 4/4] i386/acpi-build: build_crs(): fetch BAR from PCI config space directly

2015-06-10 Thread Marcel Apfelbaum
On 06/09/2015 11:34 PM, Laszlo Ersek wrote: On 06/07/15 11:23, Michael S. Tsirkin wrote: On Sat, Jun 06, 2015 at 01:46:29AM +0200, Laszlo Ersek wrote: OVMF downloads the ACPI linker/loader script from QEMU when the edk2 PCI Bus driver globally signals the firmware that PCI enumeration and resou

[Qemu-devel] [PATCH v3 2/2] xen: introduce xsrestrict and emulator_id

2015-06-10 Thread Stefano Stabellini
Introduce a new command line option "xenopts" with two suboptions: xsrestrict (boolean) and emulator_id (numeric). When xsrestrict=on is passed, QEMU will restrict the xenstore connection calling xs_restrict. Also it won't initialize the pv backends as they require higher privileges. The emulator_i

[Qemu-devel] [PATCH v3 0/2] restrict the privilege of the xenstore connection

2015-06-10 Thread Stefano Stabellini
Hi all, this patch series introduces a new command line option to restrict the privilege of the xenstore connection. Used together with -runas, can help secure the execution of QEMU in Dom0. Changes in v3: - introduce emulator_id and use in the xenstore path - move qemu_xen_opts to xen-common.c

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Liviu Ionescu
> On 29 May 2015, at 22:16, Martin Galvan > wrote: > > > ... I think Peter M is the maintainer for Target-ARM. > > Peter, is this OK to commit? was this patch accepted? if so, where can I get it from? regards, Liviu

Re: [Qemu-devel] should KVM or userspace be the one which decides what MIPIDR/affinity values to assign to vcpus?

2015-06-10 Thread Igor Mammedov
On Tue, 09 Jun 2015 15:35:21 +0100 Marc Zyngier wrote: > On 09/06/15 15:01, Peter Maydell wrote: > > On 9 June 2015 at 15:00, Marc Zyngier wrote: > >> > >> Yeah, what I had in mind was something along the lines of: > >> - kernel computes its "default MPDIR" > >> - kernel exposes a new capability

[Qemu-devel] [PATCH v3 2/2] hw/arm/virt-acpi-build: Add SPCR table

2015-06-10 Thread Andrew Jones
Signed-off-by: Andrew Jones Tested-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index a9373ccaca6cb..d5a8b9c0178ea 100644 --- a/hw/

[Qemu-devel] [PATCH v3 1/2] ACPI: Add definitions for the SPCR table

2015-06-10 Thread Andrew Jones
SPCR is the Serial Port Console Redirection Table. See the document linked from http://uefi.org/acpi. For serial port types, "Interface Type", see the documentation for the Debug Port Table 2 (DBG2). Signed-off-by: Andrew Jones Tested-by: Shannon Zhao --- include/hw/acpi/acpi-defs.h | 32 ++

[Qemu-devel] [PATCH v3 0/2] ACPI: ARM: add SPCR table

2015-06-10 Thread Andrew Jones
Adding this table allows the guest to boot without the console= parameter added to the kernel command line. And anyway, kernel doc Documentation/arm64/acpi_object_usage.txt says it's a required table for arm64. v3: - no enums, document struct and value in build_spcr [mst] - document earliest spec

Re: [Qemu-devel] [RFC PATCH v0] numa: API to lookup NUMA node by address

2015-06-10 Thread Igor Mammedov
On Tue, 9 Jun 2015 09:40:54 -0300 Eduardo Habkost wrote: > On Tue, Jun 09, 2015 at 11:23:19AM +0200, Igor Mammedov wrote: > > On Mon, 8 Jun 2015 12:51:39 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Jun 08, 2015 at 11:51:03AM +0200, Igor Mammedov wrote: > > > > On Mon, 8 Jun 2015 11:28:18

Re: [Qemu-devel] "iothread: release iothread around aio_poll" causes random hangs at startup

2015-06-10 Thread Fam Zheng
On Wed, 06/10 11:18, Christian Borntraeger wrote: > Am 10.06.2015 um 04:12 schrieb Fam Zheng: > > On Tue, 06/09 11:01, Christian Borntraeger wrote: > >> Am 09.06.2015 um 04:28 schrieb Fam Zheng: > >>> On Tue, 06/02 16:36, Christian Borntraeger wrote: > Paolo, > > I bisected > c

[Qemu-devel] [virtio] when is VIRTIO_CONFIG_S_DRIVER_OK set?

2015-06-10 Thread Catalin Vasile
When is VIRTIO_CONFIG_S_DRIVER_OK set? I've seen in vhost-scsi from qemu, that it sets it's own set_status() member function for a virtio object, which checks for VIRTIO_CONFIG_S_DRIVER_OK (from a status variable received as a parameter) so it knows if it has to call vhost_scsi_start(), vhost_scsi_

[Qemu-devel] [PATCH] spice-display: fix segfault in qemu_spice_create_update

2015-06-10 Thread Gerd Hoffmann
Although it is pretty unusual the stride for the guest image and the mirror image maintained by spice-display can be different. So use separate variables for them. Cc: qemu-sta...@nongnu.org Reported-by: perrier vincent Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 9 + 1 file

Re: [Qemu-devel] [PATCH v2 1/3] block: Extrace bdrv_parse_detect_zeroes_flags

2015-06-10 Thread Fam Zheng
On Wed, 06/10 17:11, Fam Zheng wrote: > On Mon, 06/08 16:53, Paolo Bonzini wrote: > > > > > > On 08/06/2015 16:17, Eric Blake wrote: > > >> > + > > >> > +if (detect_zeroes == BLOCKDEV_DETECT_ZEROES_OPTIONS_UNMAP && > > >> > +!(bdrv_flags & BDRV_O_UNMAP)) { > > >> > +error_setg

[Qemu-devel] [PULL 1/5] stdvga: fix offset in pci_vga_ioport_read

2015-06-10 Thread Gerd Hoffmann
Simliar to pci_vga_ioport_write. Signed-off-by: Gerd Hoffmann --- hw/display/vga-pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index ff5dfb2..93c8b5d 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -81,

[Qemu-devel] [PULL 4/5] virtio: update headers, add virtio-gpu (2d)

2015-06-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/virtio_gpu.h | 204 include/standard-headers/linux/virtio_ids.h | 1 + 2 files changed, 205 insertions(+) create mode 100644 include/standard-headers/linux/virtio_gpu.h diff --git a/include/standard-h

[Qemu-devel] [PULL 5/5] virtio-gpu/2d: add virtio gpu core code

2015-06-10 Thread Gerd Hoffmann
This patch adds the core code for virtio gpu emulation, covering 2d support. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie Signed-off-by: Gerd Hoffmann --- hw/display/Makefile.objs | 2 + hw/display/virtio-gpu.c| 918 ++

<    1   2   3   >