Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Laszlo Ersek
On 06/11/15 15:37, Marcel Apfelbaum wrote: > The fixes solves the following issue: > The PXB device exposes a new pci root bridge with the > fw path: /pci-root@4/..., in which 4 is the root bus number. > Before this patch the fw path was wrongly computed: > /pci-root@1/pci@i0cf8/... > Fix the

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Stefan Hajnoczi
On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 10.06.2015 16:24, Stefan Hajnoczi wrote: > >On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: > >>On 09.06.2015 20:03, Stefan Hajnoczi wrote: > >>>On Mon, Jun 08, 2015 at 06:21:19PM +0300,

[Qemu-devel] [PATCH 2/4] MAINTAINERS: update email address

2015-06-11 Thread Josh Durgin
The old one still works for now, but will not work indefinitely. Signed-off-by: Josh Durgin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ed8215..34eeb88 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1135,7 +1135,7 @@ S: Sup

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: replace g_malloc0_n by g_new0

2015-06-11 Thread Peter Maydell
On 11 June 2015 at 14:21, Alex Williamson wrote: > On Thu, 2015-06-11 at 14:00 +0100, Peter Maydell wrote: >> On 11 June 2015 at 09:44, Eric Auger wrote: >> > g_malloc0_n() is introduced since glib-2.24 while QEMU currently >> > requires glib-2.22. This may cause a link error on some distribution

[Qemu-devel] [PATCH 1/4] rbd: remove unused constants and fields

2015-06-11 Thread Josh Durgin
RBDAIOCB.status was only used for cancel, which was removed in 7691e24dbebb46658e89b3f950fda6ec78bbb823. RBDAIOCB.sector_num was never used. RADOSCB.done and rcbid were never used. RBD_FD* are obsolete since the pipe was removed in e04fb07fd1676e9facd7f3f878c1bbe03bccd26b. Signed-off-by: Josh D

[Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Marcel Apfelbaum
The fixes solves the following issue: The PXB device exposes a new pci root bridge with the fw path: /pci-root@4/..., in which 4 is the root bus number. Before this patch the fw path was wrongly computed: /pci-root@1/pci@i0cf8/... Fix the above issues: Correct the bus number and remove the ex

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: replace g_malloc0_n by g_new0

2015-06-11 Thread Alex Williamson
On Thu, 2015-06-11 at 14:00 +0100, Peter Maydell wrote: > On 11 June 2015 at 09:44, Eric Auger wrote: > > g_malloc0_n() is introduced since glib-2.24 while QEMU currently > > requires glib-2.22. This may cause a link error on some distributions. > > > > Signed-off-by: Eric Auger > > > > --- > > >

[Qemu-devel] [PATCH 2/2] Check value for invalid negative values

2015-06-11 Thread Frediano Ziglio
In qxl_v2n check that value is not negative. Signed-off-by: Frediano Ziglio --- hw/display/qxl-logger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl-logger.c b/hw/display/qxl-logger.c index d944d3f..faed869 100644 --- a/hw/display/qxl-logger.c +++ b/hw/displ

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: replace g_malloc0_n by g_new0

2015-06-11 Thread Gonglei
On 2015/6/11 21:00, Peter Maydell wrote: > On 11 June 2015 at 09:44, Eric Auger wrote: >> g_malloc0_n() is introduced since glib-2.24 while QEMU currently >> requires glib-2.22. This may cause a link error on some distributions. >> >> Signed-off-by: Eric Auger >> >> --- >> >> v1 -> v2: >> - repla

[Qemu-devel] [PATCH 2/2] qemu/kvm: kvm guest crash event handling

2015-06-11 Thread Denis V. Lunev
From: Andrey Smetanin KVM Hyper-V based guests can notify hypervisor about occurred guest crash. This patch does handling of KVM crash event by sending to libvirt guest panic event that allows to gather guest crash dump by QEMU/LIBVIRT. The idea is to provide functionality equal to pvpanic devic

[Qemu-devel] [PATCH 0/2] HyperV equivalent of pvpanic driver

2015-06-11 Thread Denis V. Lunev
Windows 2012 guests can notify hypervisor about occurred guest crash (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does handling of this MSR's by KVM and sending notification to user space that allows to gather Windows guest crash dump by QEMU/LIBVIRT. The idea is to provid

Re: [Qemu-devel] CPU hot unplug support for x86_64

2015-06-11 Thread Fahri Cihan Demirci
On Tue, Jun 09, 2015 at 05:44:15PM +0200, Eduardo Otubo wrote: > Hello all, > > I'm a little confused by all the email traffic I've seen on this list > lately so I guess asking doesn't hurt: How's the current status > regarding CPU hot unplug for x86_64? If there's any task left hanging > for test

[Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling

2015-06-11 Thread Denis V. Lunev
From: Andrey Smetanin Windows 2012 guests can notify hypervisor about occurred guest crash (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does handling of this MSR's by KVM and sending notification to user space that allows to gather Windows guest crash dump by QEMU/LIBVIRT

Re: [Qemu-devel] [PATCH v2 RFC 0/8] block: persistent dirty bitmaps

2015-06-11 Thread Stefan Hajnoczi
On Thu, Jun 11, 2015 at 02:22:35PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 10.06.2015 18:27, Stefan Hajnoczi wrote: > >On Mon, Jun 08, 2015 at 06:21:18PM +0300, Vladimir Sementsov-Ogievskiy wrote: > >>QCow2 header is extended by fields 'nb_dirty_bitmaps' and > >>'dirty_bitmaps_offset' like

[Qemu-devel] [PATCH] hw/vfio: Use g_new0() where that makes obvious sense

2015-06-11 Thread Eric Auger
Replace g_malloc0 occurences by g_new0 where that makes obvious sense. This looks to be the best practice bringing extra compile-time checking and integer overflow protection. Signed-off-by: Eric Auger --- hw/vfio/common.c | 8 hw/vfio/pci.c | 24 hw/vfi

Re: [Qemu-devel] Qemu-Libgfapi: periodical shutdown of virtual machines.

2015-06-11 Thread Stefan Hajnoczi
On Tue, Jun 09, 2015 at 02:07:47PM +0300, Igor Yakovlev wrote: > Would you so kind to help me with my problem concerning libgfapi. > > My host operating system is Ubuntu 14.04 LTS, version of glusterfs is > 3.6.2, and version of qemu is 2.0.0. We use libfgapi library to connect to > glusterfs. >

[Qemu-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver

2015-06-11 Thread Frediano Ziglio
This patch allow to limit number of heads using qxl driver. By default qxl driver is not limited on any kind on head use so can decide to use as much heads. libvirt has this as a video card parameter (actually set to 1 but not used). This parameter will allow to limit setting a use can do (which c

[Qemu-devel] [PATCH 4/4] rbd: fix ceph settings precedence

2015-06-11 Thread Josh Durgin
Apply the ceph settings from a config file before any ceph settings from the command line. Since the ceph config file location may be specified on the command line, parse it once to read the config file, and do a second pass to apply the rest of the command line ceph options. Signed-off-by: Josh D

Re: [Qemu-devel] [PATCH] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Laszlo Ersek
On 06/11/15 14:51, Marcel Apfelbaum wrote: > On 06/11/2015 03:45 PM, Michael S. Tsirkin wrote: >> On Thu, Jun 11, 2015 at 03:41:35PM +0300, Marcel Apfelbaum wrote: >>> The PXB device exposes a new pci root bridge with the >>> fw path: /pci-root@4/..., in which 4 is the root bus number. >>> Before

[Qemu-devel] [PATCH 3/4] rbd: make qemu's cache setting override any ceph setting

2015-06-11 Thread Josh Durgin
To be safe, when cache=none is used ceph settings should not be able to override it to turn on caching. This was previously possible with rbd_cache=true in the rbd device configuration or a ceph configuration file. Similarly, rbd settings could have turned off caching when qemu requested it, althou

[Qemu-devel] [PATCH 0/4] rbd cleanup and settings precedence fixes

2015-06-11 Thread Josh Durgin
Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of cache options and ceph settings. The cache option precedence in particular is important due to the potential for misconfigurations (ceph.conf setting rbd_cache=true, qemu setting cache=none) to accidentally put data at risk. Josh D

Re: [Qemu-devel] [PATCH] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 03:45 PM, Michael S. Tsirkin wrote: On Thu, Jun 11, 2015 at 03:41:35PM +0300, Marcel Apfelbaum wrote: The PXB device exposes a new pci root bridge with the fw path: /pci-root@4/..., in which 4 is the root bus number. Before this patch the fw path was wrongly computed: /pci-ro

Re: [Qemu-devel] Chrome version Release!

2015-06-11 Thread Stefan Hajnoczi
On Thu, Jun 11, 2015 at 05:07:45AM +0900, IdleTime wrote: > I have released the Chrome version of QEMU. > > https://chrome.google.com/webstore/detail/pnacl-qemu/mogglnfmfhjnjmeehdjppldblehpniom > > Sorry, my english is very poor. > I would like if possible to link the URL above > http://wiki.qemu

Re: [Qemu-devel] [PATCH] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2015 at 03:41:35PM +0300, Marcel Apfelbaum wrote: > The PXB device exposes a new pci root bridge with the > fw path: /pci-root@4/..., in which 4 is the root bus number. > Before this patch the fw path was wrongly computed: > /pci-root@1/pci@i0cf8/... > Fix the above issues: Cor

[Qemu-devel] [PATCH] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Marcel Apfelbaum
The PXB device exposes a new pci root bridge with the fw path: /pci-root@4/..., in which 4 is the root bus number. Before this patch the fw path was wrongly computed: /pci-root@1/pci@i0cf8/... Fix the above issues: Correct the bus number and remove the extra host bridge description. Signed-of

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-11 Thread Thibaut Collet
Ok. backend is able to know when the eventfd is kick the first time and then can send a rarp for legacy guest. With this backend modification the issue point by Jason is no more a QEMU problem. Full support of live migration for vhost user: - Need my first patch. - For legacy guest the backend

[Qemu-devel] [PULL 19/42] virtio-pci: change & document virtio pci bar layout.

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann This patch adds variables for the pci bars (to get rid of the magic numbers in the code) and moves the modern virtio bar to region 4 so regions 2+3 are kept free. virtio-vga wants use them. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[Qemu-devel] [PULL 26/42] virtio-pci: add virtio_pci_modern_region_map()

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Add function to map modern virtio regions. Add offset to VirtIOPCIRegion. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 1 + hw/virtio/virtio-pci.c | 25 +++-- 2 files chang

[Qemu-devel] [PULL 20/42] virtio-pci: make modern bar 64bit + prefetchable

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c

Re: [Qemu-devel] [Qemu-block] NVMe volatile write cache fixes

2015-06-11 Thread Eric Blake
On 06/11/2015 04:01 AM, Christoph Hellwig wrote: > The first patch ensures that flush actually flushes data so that > data integrity is preserved, the second fixe up WCE reporting. > Cover letter is missing a diffstat and also a 0/2 designation, which makes it harder to see up front what it touch

Re: [Qemu-devel] [PULL 0/2] spice patch queue

2015-06-11 Thread Peter Maydell
> > Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20150610-1' into > staging (2015-06-10 18:13:58 +0100) > > are available in the git repository at: > > > git://anongit.freedesktop.org/spice/qemu tags/pull-spice-20150611-1 > > for you to fetch

[Qemu-devel] [PULL 42/42] i386/acpi-build: fix PXB workarounds for unsupported BIOSes

2015-06-11 Thread Michael S. Tsirkin
From: Laszlo Ersek The patch apci: fix PXB behaviour if used with unsupported BIOS uses the following condition to see if a "PXB mem/IO chunk" has *not* been configured by the BIOS: (!range_base || range_base > range_limit) When this condition evaluates to true, said patch *omits* the cor

[Qemu-devel] [PULL 39/42] virtio-9p-device: move qdev properties into virtio-9p-device.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-9p-device.c uses DEFINE_VIRTIO_9P_PROPERTIES, there is no need to expose it. Inline it into virtio-9p-device.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Revie

[Qemu-devel] [PULL 01/42] vhost: put log correctly in vhost_dev_start()

2015-06-11 Thread Michael S. Tsirkin
From: Jason Wang We allocate an dummy log even if the size is zero. So we should put it unconditionally too. Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 37/42] virtio-rng: move qdev properties into virtio-rng.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-rng.c uses DEFINE_VIRTIO_RNG_PROPERTIES, there is no need to expose it. Inline it into virtio-rng.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Reviewed-by: Mic

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2015 at 02:10:48PM +0200, Thibaut Collet wrote: > I am not sure to understand your remark: > > > It needs to be sent when backend is activated by guest kick > > (in case of virtio 1, it's possible to use DRIVER_OK for this). > > This does not happen when VM still runs on source. >

[Qemu-devel] [PULL 00/42] pc, acpi, virtio

2015-06-11 Thread Michael S. Tsirkin
The following changes since commit 309750fad51f17d1ec6195c5d8ad7d741596ddb6: vhost: logs sharing (2015-06-04 12:44:49 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 4ebc736e9938a7e88ecc785734

[Qemu-devel] [PULL 21/42] virtio-pci: correctly set host notifiers for modern bar

2015-06-11 Thread Michael S. Tsirkin
From: Jason Wang Currently, during host notifier set. We only add eventfd for legacy bar, this is not correct since: - Non-transitional device does not have legacy bar, so qemu will crash since proxy->bar was not initialized. - Modern device uses modern bar and notify cap to notify the device,

[Qemu-devel] [PULL 38/42] virtio-serial-bus: move qdev properties into virtio-serial-bus.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-serial-bus.c uses DEFINE_VIRTIO_SERIAL_PROPERTIES, there is no need to expose it. Inline it into virtio-serial-bus.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck

[Qemu-devel] [PULL 34/42] virtio-net: move qdev properties into virtio-net.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-net.c uses DEFINE_VIRTIO_NET_FEATURES, there is no need to expose it. Inline it into virtio-net.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-11 Thread Thibaut Collet
I am not sure to understand your remark: > It needs to be sent when backend is activated by guest kick > (in case of virtio 1, it's possible to use DRIVER_OK for this). > This does not happen when VM still runs on source. Could you confirm rarp can be sent by backend when the VHOST_USER_SET_VRING

[Qemu-devel] [PULL 32/42] virtio-input: core code & base class [pci]

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann This patch adds the virtio-pci support bits for virtio-input-device. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 14 ++ hw/virtio/virtio-pci.c | 36

[Qemu-devel] [PULL 30/42] virtio-pci: fill VirtIOPCIRegions early.

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Initialize the modern bar and the VirtIOPCIRegion fields early, in realize. Also add a size field to VirtIOPCIRegion and variables for pci bars to VirtIOPCIProxy. This allows virtio-pci subclasses to change things before the device_plugged callback applies them. virtio-vga

[Qemu-devel] [PULL 40/42] vhost-scsi: move qdev properties into vhost-scsi.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in vhost-scsi.c uses DEFINE_VHOST_SCSI_PROPERTIES, there is no need to expose it. Inline it into vhost-scsi.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Reviewed-by: Mic

[Qemu-devel] [PULL 41/42] i386/acpi-build: more traditional _UID and _HID for PXB root buses

2015-06-11 Thread Michael S. Tsirkin
From: Laszlo Ersek The ACPI specification permits the _HID and _UID objects to evaluate to strings. (See "6.1.5 _HID (Hardware ID)" and "6.1.12 _UID (Unique ID)" in the ACPI v6.0 spec.) With regard to related standards, the UEFI specification can also express a device address composed from strin

[Qemu-devel] [PULL 25/42] virtio-pci: add virtio_pci_modern_regions_init()

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Add init function for the modern pci regions, move over the init code. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 117 + 1 file changed, 59 ins

[Qemu-devel] [PULL 36/42] virtio-scsi: move qdev properties into virtio-scsi.c

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao As only one place in virtio-scsi.c uses DEFINE_VIRTIO_SCSI_PROPERTIES and DEFINE_VIRTIO_SCSI_FEATURES, there is no need to expose them. Inline them into virtio-scsi.c to avoid wrongly use. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Ac

[Qemu-devel] [PULL 23/42] virtio-balloon: switch to virtio_add_feature

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck This was missed during the conversion of feature bit manipulation. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Qemu-devel] [PULL 24/42] virtio-pci: add struct VirtIOPCIRegion for virtio-1 regions

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann For now just place the MemoryRegion there, following patches will add more. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 12 hw/virtio/virtio-pci.c | 20 +++- 2 fil

[Qemu-devel] [PULL 35/42] virtio-net.h: Remove unsed DEFINE_VIRTIO_NET_PROPERTIES

2015-06-11 Thread Michael S. Tsirkin
From: Shannon Zhao Remove unsed DEFINE_VIRTIO_NET_PROPERTIES in virtio-net.h and delete a space typo. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Reviewed-by: Paolo Bonzini Acked-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw

[Qemu-devel] [PULL 33/42] virtio-input: emulated devices [pci]

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann This patch adds virtio-pci support for the emulated virtio-input devices. Using them is as simple as adding "-device virtio-tablet-pci" to your command line. If you want add multiple devices but don't want waste a pci slot for each you can compose a multifunction device this

[Qemu-devel] [PULL 31/42] pci: add PCI_CLASS_INPUT_*

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci_ids.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h index c6de710..49c062b 100644 --- a/in

[Qemu-devel] [PULL 03/42] virtio: allow virtio-1 queue layout

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck For virtio-1 devices, we allow a more complex queue layout that doesn't require descriptor table and rings on a physically-contigous memory area: add virtio_queue_set_rings() to allow transports to set this up. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Si

[Qemu-devel] [PULL 22/42] virtio_balloon: header update

2015-06-11 Thread Michael S. Tsirkin
add modern header Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio-balloon.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h index 4ab8f54..346a9fd 100644 --- a/inclu

[Qemu-devel] [PULL 29/42] virtio-pci: drop identical virtio_pci_cap

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Now the three struct virtio_pci_caps are identical, lets drop two of them ;) Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-)

[Qemu-devel] [PULL 11/42] vhost: 64 bit features

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Make sure that all vhost interfaces use 64 bit features, as the virtio core does, and make sure to use ULL everywhere possible to be on the safe side. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsi

[Qemu-devel] [PULL 28/42] virtio-pci: move cap type to VirtIOPCIRegion

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.h | 1 + hw/virtio/virtio-pci.c | 9 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-p

[Qemu-devel] [PULL 18/42] virtio-pci: make QEMU_VIRTIO_PCI_QUEUE_MEM_MULT smaller

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index

[Qemu-devel] [PULL 07/42] virtio-net: no writeable mac for virtio-1

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Devices operating as virtio 1.0 may not allow writes to the mac address in config space. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insert

[Qemu-devel] [PULL 16/42] virtio-pci: switch to modern accessors for 1.0

2015-06-11 Thread Michael S. Tsirkin
virtio 1.0 config space is in LE format for all devices, use modern wrappers when accessed through the 1.0 BAR. Reported-by: Rusty Russell Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

[Qemu-devel] [PULL 17/42] virtio-pci: add flags to enable/disable legacy/modern

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Add VIRTIO_PCI_FLAG_DISABLE_LEGACY and VIRTIO_PCI_FLAG_DISABLE_MODERN for VirtIOPCIProxy->flags. Also add properties for them. They can be used to disable modern (virtio 1.0) or legacy (virtio 0.9) modes. By default only legacy is advertized, modern will be turned on by def

[Qemu-devel] [PULL 27/42] virtio-pci: move virtio_pci_add_mem_cap call to virtio_pci_modern_region_map

2015-06-11 Thread Michael S. Tsirkin
From: Gerd Hoffmann Also fill offset and length automatically, from VirtIOPCIRegion->offset and region size. Signed-off-by: Gerd Hoffmann Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 28 ++-- 1 file changed, 10 inserti

[Qemu-devel] [PULL 06/42] virtio: allow to fail setting status

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck virtio-1 allow setting of the FEATURES_OK status bit to fail if the negotiated feature bits are inconsistent: let's fail virtio_set_status() in that case and update virtio-ccw to post an error to the guest. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed

[Qemu-devel] [PULL 13/42] virtio-pci: initial virtio 1.0 support

2015-06-11 Thread Michael S. Tsirkin
This is somewhat functional. With this, and linux driver from my tree, I was able to use virtio net as virtio 1.0 device for light browsing. At the moment, dataplane and vhost code is still missing. Based on Cornelia's virtio 1.0 patchset: Date: Thu, 11 Dec 2014 14:25:02 +0100 From: Corn

[Qemu-devel] [PULL 02/42] virtio: endianness checks for virtio 1.0 devices

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Add code that checks for the VERSION_1 feature bit in order to make decisions about the device's endianness. This allows us to support transitional devices. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael

[Qemu-devel] [PULL 15/42] virtio: add modern config accessors

2015-06-11 Thread Michael S. Tsirkin
virtio 1.0 defines config space as LE, as opposed to pre-1.0 which was native endian. Add API for transports to execute word/dword accesses in little endian format - will be useful for mmio and pci (byte access is also wrapped, for completeness). For simplicity, we still keep config in host nativ

[Qemu-devel] [PULL 04/42] dataplane: allow virtio-1 devices

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck Handle endianness conversion for virtio-1 virtqueues correctly. Note that dataplane now needs to be built per-target. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/virtio/dataplane/v

[Qemu-devel] [PULL 14/42] virtio: generation counter support

2015-06-11 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- include/hw/virtio/virtio.h | 1 + hw/virtio/virtio-pci.c | 2 +- hw/virtio/virtio.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index

[Qemu-devel] [PULL 09/42] virtio-net: enable virtio 1.0

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck virtio-net (non-vhost) now should have everything in place to support virtio 1.0: let's enable the feature bit for it. Note that VIRTIO_F_VERSION_1 is technically a transport feature; once every device is ready for virtio 1.0, we can move setting this feature bit out of the i

[Qemu-devel] [PULL 08/42] virtio-net: support longer header

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck virtio-1 devices always use num_buffers in the header, even if mergeable rx buffers have not been negotiated. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 21 +

[Qemu-devel] [PULL 12/42] linux-headers: add virtio_pci

2015-06-11 Thread Michael S. Tsirkin
Easier than duplicating code. Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- linux-headers/linux/virtio_pci.h | 192 +++ hw/virtio/virtio-pci.c | 2 + 2 files changed, 194 insertions(+) create mode 100644 linux-headers/linu

[Qemu-devel] [PULL 05/42] virtio: disallow late feature changes for virtio-1

2015-06-11 Thread Michael S. Tsirkin
From: Cornelia Huck For virtio-1 devices, the driver must not attempt to set feature bits after it set FEATURES_OK in the device status. Simply reject it in that case. Signed-off-by: Cornelia Huck Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirki

[Qemu-devel] [PULL 10/42] vhost_net: add version_1 feature

2015-06-11 Thread Michael S. Tsirkin
Add VERSION_1 to list of features that we should test at the backend. Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/net/vhost_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 426b23e..dc48ece 100644 --- a/hw/net

Re: [Qemu-devel] [PATCH v2] net:Enable vhost with vhostforce, vhost options for guests without MSI-X support

2015-06-11 Thread Pankaj Gupta
> > On 06/05/2015 10:32 PM, Pankaj Gupta wrote: > > We use vhostforce to enable vhost even if Guests don't have MSI-X > > support > > and we fall back to QEMU virtio-net. This patch will enable vhost > > unconditionally > > whenever we have vhostforce='ON' or vhost='ON'. > > > > Initially

[Qemu-devel] [PATCH v7 4/6] spapr_pci: set device node unit address as hex

2015-06-11 Thread Nikunj A Dadhania
Device node names should encode the unit address as hex, while the code was encodind it as integers. Also, use FDT_NAME_MAX macro for allocating and composing the name. Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- hw/ppc/spapr_pci.c | 12 +++- 1 file changed, 7 inserti

Re: [Qemu-devel] [PATCH v2 RFC 0/8] block: persistent dirty bitmaps

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 18:27, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:18PM +0300, Vladimir Sementsov-Ogievskiy wrote: QCow2 header is extended by fields 'nb_dirty_bitmaps' and 'dirty_bitmaps_offset' like with snapshots. Proposed command line syntax is the following: -dirty-bitmap [option1=

[Qemu-devel] [PATCH v7 3/6] spapr_pci: enumerate and add PCI device tree

2015-06-11 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa

[Qemu-devel] [PATCH v7 1/6] spapr_pci: encode missing 64-bit memory address space

2015-06-11 Thread Nikunj A Dadhania
The properties reg/assigned-resources need to encode 64-bit memory address space as part of phys.hi dword. 00 if configuration space 01 if IO region, 10 if 32-bit MEM region 11 if 64-bit MEM region Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- hw/ppc/spapr_pci.c | 10 ++

[Qemu-devel] [PATCH v7 5/6] spapr_pci: populate ibm,loc-code

2015-06-11 Thread Nikunj A Dadhania
Each hardware instance has a platform unique location code. The OF device tree that describes a part of a hardware entity must include the “ibm,loc-code” property with a value that represents the location code for that hardware entity. Populate ibm,loc-code. 1) PCI passthru devices need to ident

[Qemu-devel] [PATCH v7 6/6] spapr_pci: drop redundant args in spapr_populate_pci_child_dt

2015-06-11 Thread Nikunj A Dadhania
* phb_index is not being used and if required can be obtained from sphb * use helper to get drc_index in this function Suggested-by: Alexey Kardashevskiy Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_pci.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/p

Re: [Qemu-devel] [PULL 0/1] gtk patch queue

2015-06-11 Thread Peter Maydell
axel/tags/pull-vga-20150610-1' into > staging (2015-06-10 18:13:58 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-gtk-20150611-1 > > for you to fetch changes up to 060ab76356fff6a420bc881a574c40a5dda086af: > > g

Re: [Qemu-devel] [PATCH] hw/vfio/platform: replace g_malloc0_n by g_malloc0

2015-06-11 Thread Markus Armbruster
Eric Auger writes: > g_malloc0_n() is introduced since glib-2.24 while QEMU currently > requires glib-2.22. This may cause a link error on some distributions. > > Signed-off-by: Eric Auger > --- > hw/vfio/platform.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/v

[Qemu-devel] [PATCH v7 0/6] spapr_pci: DT field fixes and PCI DT node creation in QEMU

2015-06-11 Thread Nikunj A Dadhania
The patch series creates PCI device tree(DT) nodes in QEMU. The new hotplug code needs the device node creation in QEMU. While during boot, nodes were created in SLOF. It makes more sense to consolidate the code to one place for better maintainability. Based on David's spapr-next https://github.c

[Qemu-devel] [PATCH v7 2/6] spapr_pci: encode class code including Prog IF register

2015-06-11 Thread Nikunj A Dadhania
Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type. For example: USB controllers use the PROG IF for denoting: USB FullSpeed, HighSpeed or SuperSpeed. Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 01:45 PM, Laszlo Ersek wrote: On 06/11/15 12:29, Marcel Apfelbaum wrote: On 06/11/2015 01:26 PM, Laszlo Ersek wrote: On 06/11/15 12:21, Marcel Apfelbaum wrote: On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off

[Qemu-devel] [PATCH] target-arm/cpu.h: remove pending_exception

2015-06-11 Thread Alex Bennée
This isn't used by any of the code. In fact it looks like it was never used as it came in with ARMv7 support. Signed-off-by: Alex Bennée --- target-arm/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 21b5b8e..7c1d95c 100644 --- a/target-arm/cpu.

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 11.06.2015 02:42, John Snow wrote: On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 5 + block/qcow2.c | 13 +++-- block/qcow2.h

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Laszlo Ersek
On 06/11/15 12:29, Marcel Apfelbaum wrote: > On 06/11/2015 01:26 PM, Laszlo Ersek wrote: >> On 06/11/15 12:21, Marcel Apfelbaum wrote: >>> On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off devices behind the PXB. This h

Re: [Qemu-devel] [PATCH 4/8] block: add bdrv_load_dirty_bitmap

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 11.06.2015 01:33, John Snow wrote: On 06/09/2015 12:01 PM, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: +BdrvDirtyBitmap *bdrv_load_dirty_bitmap(BlockDriverState *bs, +BlockDriverState *file, +

Re: [Qemu-devel] [PATCH v3 2/2] vhost user: Add RARP injection for legacy guest

2015-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2015 at 01:54:22PM +0800, Jason Wang wrote: > > > On 06/11/2015 01:49 PM, Thibaut Collet wrote: > > > Yes, but still need a mechanism to notify the backend of migration > > > completion from qemu side if GUEST_ANNOUNCE is not negotiated. > > > > backend is aware of a connection wi

Re: [Qemu-devel] [PATCH 00/33] virtio 1.0 patch series rebased

2015-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2015 at 10:26:12AM +0200, Gerd Hoffmann wrote: > Hi, > > > Here's an incomplete todo for spec compliance: note that it does not > > have to block this patchset: > > - complete other devices besides net, balloon > > need to disable a bunch of features > >

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 01:26 PM, Laszlo Ersek wrote: On 06/11/15 12:21, Marcel Apfelbaum wrote: On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off devices behind the PXB. This happens because the sysbus_get_fw_dev_path() function in "h

Re: [Qemu-devel] virt-test broken by 'gtk: add opengl support, using egl' 97edf3bd5

2015-06-11 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > Hi, > I've just bisected a virt-test breakage down to: This is fixed by the just posted 'gtk: don't exit early in case gtk init fails' Dave > > 97edf3bd5 'gtk: add opengl support, using egl' > > I think the problem is that it's trying t

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Laszlo Ersek
On 06/11/15 12:21, Marcel Apfelbaum wrote: > On 06/11/2015 03:38 AM, Laszlo Ersek wrote: >> The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot >> off devices behind the PXB. This happens because the >> sysbus_get_fw_dev_path() function in "hw/core/sysbus.c" doesn't have >> enou

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other dri

Re: [Qemu-devel] [PATCH v3 6/6] hw/pci-bridge: set explicit OFW unit address for TYPE_PXB_HOST

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 03:38 AM, Laszlo Ersek wrote: The PXB implementation doesn't allow firmware (SeaBIOS or OVMF) to boot off devices behind the PXB. This happens because the sysbus_get_fw_dev_path() function in "hw/core/sysbus.c" doesn't have enough information to format a unique identifier for the PX

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 16:24, Stefan Hajnoczi wrote: On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -166,6 +167,19 @@ the header extension data. Ea

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread Vladimir Sementsov-Ogievskiy
On 10.06.2015 16:00, Eric Blake wrote: On 06/10/2015 02:19 AM, Vladimir Sementsov-Ogievskiy wrote: +Dirty bitmaps is an optional header extension. It provides a possibility of +storing dirty bitmaps in qcow2 image. The fields are: + + 0 - 3: nb_dirty_bitmaps + Numbe

Re: [Qemu-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver

2015-06-11 Thread Gerd Hoffmann
On Do, 2015-06-11 at 10:38 +0100, Frediano Ziglio wrote: > libvirt has this as a video card parameter (actually set to 1 but not > used). This parameter will allow to limit setting a use can do (which > could be confusing). Hmm. So heads is '1' by default but ignored today. When this starts to b

[Qemu-devel] [PULL 1/1] gtk: don't exit early in case gtk init fails

2015-06-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange --- ui/gtk.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 126326a..df2a79e 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1917,12 +1917,19 @@ static void gd_set_keycode_type(GtkD

<    1   2   3   >