Re: [Qemu-devel] [Qemu-discuss] GRO not happening in VM with VxLAN

2015-06-29 Thread Santosh R
On Mon, Jun 29, 2015 at 9:24 PM, Santosh R wrote: > > On Mon, Jun 29, 2015 at 9:04 PM, Vlad Yasevich > wrote: > >> On 06/29/2015 01:46 AM, Santosh R wrote: >> > All, >> > >> >I am testing VxLAN performance in VM. For this I am using below >> command >> > to bring up the VM. >> > # qemu-syste

[Qemu-devel] [PATCH pic32 7/7] Get rid of "WARNING: Image format was not specified" message for -sd option.

2015-06-29 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 69ad90c..56d02c6 100644 --- a/vl.c +++ b/vl.c @@ -1109,7 +1109,7 @@ static int cleanup_add_fd(void *opaque, QemuOpts *opts, Error **errp) #define FD_OPTS "" #define PFLA

[Qemu-devel] [PATCH pic32 4/7] Added support for external interrupt controller (EIC) mode.

2015-06-29 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- hw/mips/cputimer.c | 17 +++-- hw/mips/mips_int.c | 11 +-- target-mips/cpu.h| 9 - target-mips/helper.c | 20 ++-- 4 files changed, 46 insertions(+), 11 deletions(-) diff --git a/hw/mips/cputimer.c b/hw/mips

[Qemu-devel] [PATCH pic32 5/7] Two new processor variants: M4K and microAptivP.

2015-06-29 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- target-mips/cpu.h| 2 ++ target-mips/translate_init.c | 46 2 files changed, 48 insertions(+) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index ab830ee..9f5890c 100644 --- a/target-mips/cpu.h +++

[Qemu-devel] [PATCH pic32 3/7] Fixed random index generation for TLBWR instruction. It was not quite random and did not skip Wired entries.

2015-06-29 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- hw/mips/cputimer.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/mips/cputimer.c b/hw/mips/cputimer.c index 3d23c1b..ec0cffa 100644 --- a/hw/mips/cputimer.c +++ b/hw/mips/cputimer.c @@ -25,21 +25,13 @@ #include "qemu

[Qemu-devel] [PATCH pic32 2/7] Stop simulation when processor is suspended forever by WAIT instruction with interrupts disabled.

2015-06-29 Thread Serge Vakulenko
Signed-off-by: Serge Vakulenko --- target-mips/op_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 2a9ddff..1b7caeb 100644 --- a/target-mips/op_helper.c +++ b/target-mips/op_helper.c @@ -22,6 +22,7 @@ #include "exec/helpe

[Qemu-devel] [PATCH pic32 1/7] Speed of MIPS CPU timer made configurable per platform.

2015-06-29 Thread Serge Vakulenko
Please find below a set of patches, which allow to simulate Microchip PIC32 microcontrollers on QEMU. For examples of real PIC32 applications running on QEMU, see page: https://github.com/sergev/qemu/wiki (1) Make the CPU clock frequency configurable per platform. Currently the clock rate for all

Re: [Qemu-devel] [RESEND PATCH v8 2/4] hw: add a wrapper for registering reset handler

2015-06-29 Thread Zhu Guihua
On 06/26/2015 01:28 AM, Andreas Färber wrote: Am 25.06.2015 um 19:00 schrieb Paolo Bonzini: On 25/06/2015 04:17, Zhu Guihua wrote: Add a wrapper to specify reset order when registering reset handler, instead of non-obvious initiazation code ordering. Signed-off-by: Zhu Guihua I'm sorry, thi

Re: [Qemu-devel] [SeaBIOS] [PATCH 03/18] virtio: add struct vp_device

2015-06-29 Thread Gerd Hoffmann
Hi, > > Is there a reason to make this a pointer as opposed to just placing > > the vp_device struct directly in struct virtiodrive_s? > > That'll work too, both blk and scsi have a struct where we can place > vp_device inside. I'll change it for v2. Oops, wrong. For virtio-blk it works, but

Re: [Qemu-devel] [PATCH for-2.4] net-hub: Drop can_receive

2015-06-29 Thread Thomas Huth
On Tue, 30 Jun 2015 10:29:20 +0800 Fam Zheng wrote: > It returns true as long as there is another attached port. This is not > strictly necessary because even if there is only one port (the sender), > net_hub_port_receive could succeed with a NOP. So always deliver the > packets, instead of queui

Re: [Qemu-devel] [PATCH v2 1/1] KVM s390 pci infrastructure modelling

2015-06-29 Thread Hong Bo Li
On 6/29/2015 18:01, Michael S. Tsirkin wrote: On Mon, Jun 29, 2015 at 05:24:53PM +0800, Hong Bo Li wrote: This patch introduce a new facility(and bus) to hold devices representing information actually provided by s390 firmware and I/O configuration. usage example: -device s390-pcihost -device v

[Qemu-devel] [PATCH] gdbstub:Return non-zero value for thread-id in user mode

2015-06-29 Thread Bhushan Attarde
When client requests the stop information by sending ? packet, the gdbstub replies with stop info packet which includes thread-id of the stopped thread. In user mode this thread-id is given by cpu->host_tid, which could be zero. Some clients treats thread-id zero as invalid thread-id. This patch e

Re: [Qemu-devel] [PATCH] target-s390x: fix CONVERT TO BINARY (CVD, CVDY)

2015-06-29 Thread Richard Henderson
On 06/29/2015 09:24 PM, Aurelien Jarno wrote: On 2015-06-29 10:28, Richard Henderson wrote: On 06/25/2015 08:16 PM, Aurelien Jarno wrote: for (shift = 4; (shift < 64) && bin; shift += 4) { -int current_number = bin % 10; - -dec |= (current_number) << shift; +dec |=

Re: [Qemu-devel] [PATCH 0/4] hw/net: fix m68/ColdFire ethernet fec support

2015-06-29 Thread Greg Ungerer
Hi Stefan, On 26/06/15 20:12, Stefan Hajnoczi wrote: > On Fri, Jun 26, 2015 at 03:27:12PM +1000, g...@uclinux.org wrote: >> >> The following set of patches fixes the emulated ColdFire ethernet fec >> driver. There is primarily two problems that need to be fixed. >> >> 1. The emulated driver needs

[Qemu-devel] (no subject)

2015-06-29 Thread Scott Feldman
Hi Fam, Stefan, I'm running a test with rocker device using UDP sockets connections and I'm seeing the socket s->read_poll stay disabled if the device receives a packet when the device's can_receive returns false. Receive is stuck after that; nothing ever re-enables s->read_poll. I see the first

Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out

2015-06-29 Thread David Gibson
On Tue, Jun 30, 2015 at 01:44:10PM +1000, David Gibson wrote: > On Mon, Jun 29, 2015 at 12:26:50PM +0200, Andreas Färber wrote: > > Am 29.06.2015 um 07:36 schrieb David Gibson: > > > Currently, the code to handle the legacy ISA bus is always included in > > > qemu. However there are lots of platfo

Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 12:12:01PM +0200, Andreas Färber wrote: > Am 29.06.2015 um 07:36 schrieb David Gibson: > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by

Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 11:35:23AM +0100, Peter Maydell wrote: > On 29 June 2015 at 06:36, David Gibson wrote: > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled b

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-06-29 Thread Li Chengyuan
Ryan, Our Hypervisors are running in the internal network which can't access to Launchpad, # apport-collect 1465935 ERROR: connecting to Launchpad failed: [Errno 110] Connection timed out We saw this qemu crash on 18 Hypervisor nodes. So far all our hypervisors are ubuntu 12.04, qemu-2.0.0+dfsg

Re: [Qemu-devel] [PATCH 2/4] Allow ISA bus to be configured out

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 12:26:50PM +0200, Andreas Färber wrote: > Am 29.06.2015 um 07:36 schrieb David Gibson: > > Currently, the code to handle the legacy ISA bus is always included in > > qemu. However there are lots of platforms that don't include ISA legacy > > devies, and quite a few that hav

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-06-29 Thread Li Chengyuan
http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg00822.html Seems that the latest version code has answered maintainers questions. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1465935 Title:

[Qemu-devel] [Bug 1469946] [NEW] guest can't get IP when create guest with bridge.

2015-06-29 Thread chao zhou
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):linux kvm.git Commit:aefbef10e3ae6e2c6e3c54f906f10b34c73a2c66 qemu.git Commit:dc1e1350f8061021df765b396295329797d66933 Host Kernel Version:4.1.0 Hardware:Iv

[Qemu-devel] [Bug 1469946] Re: guest can't get IP when create guest with bridge.

2015-06-29 Thread chao zhou
the first bad commit is commit a90a7425cf592a3afeff3eaf32f543b83050ee5c Author: Fam Zheng Date: Thu Jun 4 14:45:17 2015 +0800 tap: Drop tap_can_send This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration.

[Qemu-devel] [Bug 1469924] [NEW] qemu-kvm crash when guest os is booting

2015-06-29 Thread Lidong Chen
Public bug reported: this is the command line of qemu. 2015-06-30 01:52:59.508+: starting up LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin QEMU_AUDIO_DRV=none /usr/bin/qemu-kvm -name rhel7 -S -machine pc-i440fx-2.1,accel=kvm,usb=off -cpu SandyBridge -m 2048 -realtime mloc

Re: [Qemu-devel] [PATCH v6 0/6] Memory hotplug for PowerPC sPAPR guests

2015-06-29 Thread Bharata B Rao
On Tue, Jun 30, 2015 at 01:26:39PM +1000, David Gibson wrote: > On Mon, Jun 29, 2015 at 02:14:26PM +0530, Bharata B Rao wrote: > > Hi, > > > > This is v5 of memory hotplug support patchset for PowerPC > > sPAPR guests. > > > > This patchset applies on spapr-next branch of David Gibson's tree with

[Qemu-devel] [PATCH COLO-BLOCK v7 17/17] Implement new driver for block replication

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/Makefile.objs | 1 + block/replication.c | 443 2 files changed, 444 insertions(+) create mode 100644 block/replication.c diff --git a/block/Makefil

Re: [Qemu-devel] [PATCH qemu v8 03/14] spapr_pci_vfio: Enable multiple groups per container

2015-06-29 Thread Alexey Kardashevskiy
On 06/26/2015 05:59 AM, Alex Williamson wrote: On Thu, 2015-06-18 at 21:37 +1000, Alexey Kardashevskiy wrote: This enables multiple IOMMU groups in one VFIO container which means that multiple devices from different groups can share the same IOMMU table (or tables if DDW). This removes a group

[Qemu-devel] [PATCH COLO-BLOCK v7 13/17] docs: block replication's description

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: Yang Hongyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 179 + 1 file changed, 179 insertions(+) create mode 100644 docs/block-replication.txt diff --git a/docs/b

Re: [Qemu-devel] [PATCH v6 5/6] spapr: Memory hotplug support

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 02:14:31PM +0530, Bharata B Rao wrote: > Make use of pc-dimm infrastructure to support memory hotplug > for PowerPC. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.

[Qemu-devel] [PATCH COLO-BLOCK v7 14/17] Add new block driver interfaces to control block replication

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino Cc: Michael Roth Reviewed-by: Paolo Bonzini --- block.c | 40 include/block/block.h | 5 + include/block/block_int.h | 14 ++

[Qemu-devel] [PATCH COLO-BLOCK v7 02/17] quorum: implement block driver interfaces add/delete a BDS's child

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Alberto Garcia --- block/quorum.c | 72 -- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/block/quorum.c b/block/quorum.c index a7df17c..4

[Qemu-devel] [PATCH COLO-BLOCK v7 16/17] quorum: implement block driver interfaces for block replication

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Alberto Garcia --- block/quorum.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 6774d4c..bafa774 100644 --

[Qemu-devel] [PATCH COLO-BLOCK v7 10/17] allow writing to the backing file

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 7619981..12efd21 100644 --- a/block.c +++ b/block.c @@ -747,6 +747,15

[Qemu-devel] [PATCH COLO-BLOCK v7 15/17] skip nbd_target when starting block replication

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 12 1 file changed, 12 insertions(+) diff --git a/block.c b/block.c index 1cfbbf9..7371c5a 100644 --- a/block.c +++ b/block.c @@ -4347,6 +4347,10 @@ void bdrv_start_replication(BlockDrive

Re: [Qemu-devel] [PATCH v6 0/6] Memory hotplug for PowerPC sPAPR guests

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 02:14:26PM +0530, Bharata B Rao wrote: > Hi, > > This is v5 of memory hotplug support patchset for PowerPC > sPAPR guests. > > This patchset applies on spapr-next branch of David Gibson's tree with > pc_dimm_pug reorg+NUMA node lookup patchset v4: > http://lists.nongnu.org

[Qemu-devel] [PATCH COLO-BLOCK v7 09/17] Backup: clear all bitmap when doing block checkpoint

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Jeff Cody --- block/backup.c | 13 + blockjob.c | 10 ++ include/block/blockjob.h | 12 3 files changed, 35 insertions(+) diff --git a/block/backup.c b/

[Qemu-devel] [PATCH COLO-BLOCK v7 12/17] block: Allow references for backing files

2015-06-29 Thread Wen Congyang
Usage: -drive file=xxx,id=Y, \ -drive file=,id=X,backing.backing_reference=Y It will create such backing chain: {virtio-blk dev 'Y'} {virtio-blk dev 'X'} | | | |

[Qemu-devel] [PATCH COLO-BLOCK v7 11/17] Allow creating backup jobs when opening BDS

2015-06-29 Thread Wen Congyang
When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Jeff Cody Reviewed-by: Stefan Hajnoczi --- block/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/Mak

Re: [Qemu-devel] [PATCH v6 2/6] spapr: Add LMB DR connectors

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 02:14:28PM +0530, Bharata B Rao wrote: > Enable memory hotplug for pseries 2.4 and add LMB DR connectors. > With memory hotplug, enforce RAM size, NUMA node memory size and maxmem > to be a multiple of SPAPR_MEMORY_BLOCK_SIZE (256M) since that's the > granularity in which LM

[Qemu-devel] [PATCH COLO-BLOCK v7 06/17] introduce a new API to enable/disable attach device model

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang --- block/block-backend.c | 24 include/sysemu/block-backend.h | 2 ++ 2 files changed, 26 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index aee8a12..72d8b2c 100644 --- a/block/block-backend.c +++ b/block

[Qemu-devel] [PATCH COLO-BLOCK v7 07/17] introduce a new API to check if blk is attached

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang --- block.c| 4 ++-- block/block-backend.c | 9 + include/sysemu/block-backend.h | 1 + 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 617e431..dbbba5d 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH COLO-BLOCK v7 03/17] hmp: add monitor command to add/remove a child

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- blockdev.c| 53 +++ hmp-commands.hx | 28 + include/sysemu/blockdev.h | 2 ++ 3 files changed, 83 insertions(+) dif

[Qemu-devel] [PATCH COLO-BLOCK v7 08/17] block: make bdrv_put_ref_bh_schedule() as a public API

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang --- block.c | 25 + blockdev.c| 37 ++--- include/block/block.h | 1 + 3 files changed, 32 insertions(+), 31 deletions(-) diff --git a/block.c b/block.c index dbbba5d..7619981 100644 --

[Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-06-29 Thread Wen Congyang
Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer to docs/block-replication.txt You can get the patch here: https://github.com/wencongyang/qemu-colo/commits/block-replication-v7 You can get ths patch with framework here

[Qemu-devel] [PATCH COLO-BLOCK v7 05/17] quorum: allow ignoring child errors

2015-06-29 Thread Wen Congyang
If the child is not ready, read/write/getlength/flush will return -errno. It is not critical error, and can be ignored: 1. read/write: Just not report the error event. 2. getlength: just ignore it. If all children's getlength return -errno, and be ignored, return -EIO. 3. flush: Just ig

[Qemu-devel] [PATCH COLO-BLOCK v7 01/17] Add new block driver interface to add/delete a BDS's child

2015-06-29 Thread Wen Congyang
In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 39 +++ include/block/block.h | 4 include/block/b

[Qemu-devel] [PATCH COLO-BLOCK v7 04/17] introduce a new API qemu_opts_absorb_qdict_by_index()

2015-06-29 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- include/qemu/option.h | 2 ++ util/qemu-option.c| 44 2 files changed, 46 insertions(+) diff --git a/include/qemu/option.h b/include/qemu/option.h index 57e51c9

[Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive

2015-06-29 Thread Fam Zheng
virtio_net_receive still does the check by calling virtio_net_can_receive, if the device or driver is not ready, the packet is dropped. This is necessary because returning false from can_receive complicates things: the peer would disable sending until we explicitly flush the queue. Signed-off-by:

Re: [Qemu-devel] [PATCH v4 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 01:50:23PM +0530, Bharata B Rao wrote: > pc_dimm_plug() has code that will be needed for memory plug handlers > in other archs too. Extract code from pc_dimm_plug() into a generic > routine pc_dimm_memory_plug() that resides in pc-dimm.c. Also > correspondingly refactor re-u

Re: [Qemu-devel] [PATCH v4 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 01:50:25PM +0530, Bharata B Rao wrote: > Start storing the (start_addr, end_addr) of the pc-dimm memory > in corresponding numa_info[node] so that this information can be used > to lookup node by address. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson -- Da

Re: [Qemu-devel] [PATCH v4 6/6] numa: API to lookup NUMA node by address

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 01:50:27PM +0530, Bharata B Rao wrote: > Introduce an API numa_get_node(ram_addr_t addr, Error **errp) that > returns the NUMA node to which the given address belongs to. This > API works uniformly for both boot time as well as hotplugged memory. > > This API is needed by s

Re: [Qemu-devel] [PATCH v4 5/6] numa: Store boot memory address range in node_info

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 01:50:26PM +0530, Bharata B Rao wrote: > Store memory address range information of boot memory in address > range list of numa_info. > > This helps to have a common NUMA node lookup by address function that > works for both boot-time memory and hotplugged memory. > > Sign

Re: [Qemu-devel] [PATCH v4 3/6] pc: Abort if HotplugHandlerClass::plug() fails

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 01:50:24PM +0530, Bharata B Rao wrote: > HotplugHandlerClass::plug() shouldn't fail and hence use error_abort > to abort if it fails. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson -- David Gibson| I'll have my music baroque, and my code

[Qemu-devel] Resource leaking in gen_intermediate_code_internal ?

2015-06-29 Thread Jun Koi
Hello, In function gen_intermediate_code_internal() of target-i386/translate.c, we have this code: cpu_T[0] = tcg_temp_new(); cpu_T[1] = tcg_temp_new(); cpu_A0 = tcg_temp_new(); I cannot see anywhere cpu_T & cpu_A0 are freed, so each time this function is called, it allocates new va

[Qemu-devel] [PATCH] xen: Drop net_rx_ok

2015-06-29 Thread Fam Zheng
This is necessary because once we return false from .can_receive, we need to flush the queue when the .can_receive conditions become true again, (for example when more buffer is available). We can rely on net_rx_packet (which checks the same conditions) to drop the packet if the device is not read

[Qemu-devel] [PATCH for-2.4] net-hub: Drop can_receive

2015-06-29 Thread Fam Zheng
It returns true as long as there is another attached port. This is not strictly necessary because even if there is only one port (the sender), net_hub_port_receive could succeed with a NOP. So always deliver the packets, instead of queuing them. This fixes the possible hanging issue after net laye

Re: [Qemu-devel] [PATCH v2] trivial: remove trailing newline from error_report

2015-06-29 Thread Gonglei
On 2015/6/30 4:56, John Snow wrote: > Minor cleanup. > > Signed-off-by: John Snow > --- > hw/ide/ahci.c | 2 +- > hw/vfio/platform.c | 2 +- > net/tap-linux.c| 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Gonglei

Re: [Qemu-devel] [PATCH 4/4] Disable "info irq" and "info pic" for target-ppc

2015-06-29 Thread David Gibson
On Mon, Jun 29, 2015 at 01:02:50PM +0200, Alexander Graf wrote: > On 06/29/15 12:43, Andreas Färber wrote: > >Am 29.06.2015 um 12:36 schrieb Andreas Färber: > >>Am 29.06.2015 um 12:22 schrieb Laurent Vivier: > >>>On 29/06/2015 12:06, Andreas Färber wrote: > Am 29.06.2015 um 11:55 schrieb Lauren

Re: [Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-06-29 Thread John Snow
On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > Join the transaction when the backup block job is in incremental backup > mode. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > incremental backup wit

Re: [Qemu-devel] [PATCH 05/10] block: add block job transactions

2015-06-29 Thread John Snow
On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > Sometimes block jobs must execute as a transaction group. Finishing > jobs wait until all other jobs are ready to complete successfully. > Failure or cancellation of one job cancels the other jobs in the group. > > Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 06/10] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-06-29 Thread John Snow
On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > Provide a BlockJobTxn to actions executed in a qmp 'transaction' > command. This allows actions to make their block jobs either complete > as a group or fail/cancel together. > > The next patch adds the first user. > > Signed-off-by: Stefan Hajn

Re: [Qemu-devel] [PATCH 04/10] block: keep bitmap if incremental backup job is cancelled

2015-06-29 Thread John Snow
On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > Reclaim the dirty bitmap if an incremental backup block job is > cancelled. The ret variable may be 0 when the job is cancelled so it's > not enough to check ret < 0. > > Signed-off-by: Stefan Hajnoczi > --- > block/backup.c | 2 +- > 1 file ch

Re: [Qemu-devel] [PATCH 30/39] contrib: add ivshmem client and server

2015-06-29 Thread Marc-André Lureau
Hi Andrew On Fri, Jun 26, 2015 at 6:25 PM, Andrew Jones wrote: > This is only true with glibc < 2.19, > see glibc commit b20de2c3d9d751eb259c321426188eefc64fcbe9, "Properly > handle shm_open validation. Fixes bug 16274." > > Thanks, I made a patch to solve this on ivshmem-server side (This prob

Re: [Qemu-devel] [PULL 0/3] m68k queue

2015-06-29 Thread Laurent Vivier
Le 29/06/2015 19:00, Peter Maydell a écrit : > On 29 June 2015 at 16:44, Laurent Vivier wrote: >> The following changes since commit 2b464e13f0d30e6c0b8f69ec908fceab30aea986: >> >> Merge remote-tracking branch >> 'remotes/bkoppelmann/tags/pull-tricore-20

Re: [Qemu-devel] [PATCH v2 0/4] ahci: misc fixes/tests for 2.4

2015-06-29 Thread John Snow
final ping: I'll pull this as a pre-requisite for the NCQ fixes (part 1) series that has been reviewed unless there are objections to this series. --js On 06/16/2015 12:02 PM, John Snow wrote: > This is a small handful of fixes for the ahci-tests/ahci device, > alongside two new tests. I have a

Re: [Qemu-devel] QEMU to generate host binary

2015-06-29 Thread Ayaz Akram
Thanks for your answers. The thing that i still do not get is once we have host assembly code (output assembly log generated for compiled TBs ), should we still worry about problems like self modifying code and other dynamic conditions? Moreover, assuming static linking, will not this code be enoug

[Qemu-devel] [PATCH RFC 1 1/8] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

2015-06-29 Thread Konrad Rzeszutek Wilk
During init time we treat the dev.config area as a cache of the host view. However during execution time we treat it as guest view (by the generic PCI API). We need to sync Xen's code to the generic PCI API view. This is the first step by replacing all of the code that uses dev.config or pci_get_[b

[Qemu-devel] [PATCH RFC 1 7/8] xen/pt: Move bulk of xen_pt_unregister_device in its own routine.

2015-06-29 Thread Konrad Rzeszutek Wilk
This way we can call it if we fail during init. This code movement introduces no changes. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt.c | 119 +--- 1 file changed, 62 insertions(+), 57 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw

[Qemu-devel] [PATCH RFC 1 2/8] xen/pt: Sync up the dev.config and data values.

2015-06-29 Thread Konrad Rzeszutek Wilk
For a passthrough device we maintain a state of emulated registers value contained within d->config. We also consult the host registers (and apply ro and write masks) whenever the guest access the registers. This is done in xen_pt_pci_write_config and xen_pt_pci_read_config. Also in this picture w

[Qemu-devel] [PATCH RFC 1 3/8] xen/pt: Check if reg->init is past the reg->size

2015-06-29 Thread Konrad Rzeszutek Wilk
It should never happen, but in case it does we want to report. The code will only write up to reg->size so there is no runtime danger. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt_config_init.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_co

[Qemu-devel] [PATCH RFC 1 8/8] xen/pt: Check for return values for xen_host_pci_[get|set] in init

2015-06-29 Thread Konrad Rzeszutek Wilk
and if we have failures we call xen_pt_destroy introduced in 'xen/pt: Move bulk of xen_pt_unregister_device in its own routine.' and free all of the allocated structures. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt.c | 32 +--- 1 file changed, 21 insertions

[Qemu-devel] [PATCH RFC 1 5/8] xen/pt: Log xen_host_pci_get/set errors in MSI code.

2015-06-29 Thread Konrad Rzeszutek Wilk
We seem to only use these functions when de-activating the MSI - so just log errors. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt_msi.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt_msi.c b/hw/xen/xen_pt_msi.c index 5822df5..e3d71

[Qemu-devel] [PATCH RFC 1 4/8] xen/pt: Log xen_host_pci_get in two init functions

2015-06-29 Thread Konrad Rzeszutek Wilk
To help with troubleshooting in the field. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt_config_init.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index bc871c9..62b6a7b 100644 --- a/hw/xen/xen_pt_config_init.c +

[Qemu-devel] [PATCH RFC v1] Sync dev.config with XenPTReg->data field.

2015-06-29 Thread Konrad Rzeszutek Wilk
Hey, This patchset is dependent on http://lists.xen.org/archives/html/xen-devel/2015-06/msg04812.html (Cleanups + various fixes due to libxl ABI + more logging on errors.). During the discussion of http://lists.xen.org/archives/html/xen-devel/2015-06/msg01504.html "[PATCH QEMU-XEN] xen/pt: Sta

[Qemu-devel] [PATCH RFC 1 6/8] xen/pt: Make xen_pt_unregister_device idempotent

2015-06-29 Thread Konrad Rzeszutek Wilk
To deal with xen_host_pci_[set|get]_ functions returning error values and clearing ourselves in the init function we should make the .exit (xen_pt_unregister_device) function be idempotent in case the generic code starts calling .exit (or for fun does it before calling .init!). Signed-off-by: Konr

[Qemu-devel] [PATCH v2] trivial: remove trailing newline from error_report

2015-06-29 Thread John Snow
Minor cleanup. Signed-off-by: John Snow --- hw/ide/ahci.c | 2 +- hw/vfio/platform.c | 2 +- net/tap-linux.c| 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index b4b65c1..8478d25 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -88

Re: [Qemu-devel] [PATCH] trivial: remove trailing newline from error_report

2015-06-29 Thread John Snow
On 06/29/2015 04:25 PM, John Snow wrote: > Minor cleanup. > > Signed-off-by: John Snow > --- > hw/vfio/platform.c | 2 +- > net/tap-linux.c| 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c > index 5c678b9..932d631 100644

Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Programmingkid
On Jun 29, 2015, at 4:43 PM, Laurent Vivier wrote: > > > On 29/06/2015 20:37, Programmingkid wrote: >> >> On Jun 29, 2015, at 2:16 PM, Peter Maydell wrote: >> >>> On 29 June 2015 at 19:04, Programmingkid >> > wrote: On Jun 29, 2015, at 1:11 PM, Pet

Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Laurent Vivier
On 29/06/2015 20:37, Programmingkid wrote: > > On Jun 29, 2015, at 2:16 PM, Peter Maydell wrote: > >> On 29 June 2015 at 19:04, Programmingkid > > wrote: >>> >>> On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote: >>> On 29 June 2015 at 17:54, Programmingkid

[Qemu-devel] [PATCH] trivial: remove trailing newline from error_report

2015-06-29 Thread John Snow
Minor cleanup. Signed-off-by: John Snow --- hw/vfio/platform.c | 2 +- net/tap-linux.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index 5c678b9..932d631 100644 --- a/hw/vfio/platform.c +++ b/hw/vfio/platform.c @@ -225,7 +22

Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it to be used on non-x86 architectures

2015-06-29 Thread Paul Moore
On Monday, June 29, 2015 07:47:29 PM Andrew Jones wrote: > On Mon, Jun 29, 2015 at 10:53:14AM -0400, Paul Moore wrote: > > On Monday, June 29, 2015 09:50:17 AM Andrew Jones wrote: > > > On Fri, Jun 26, 2015 at 04:26:22PM -0400, Paul Moore wrote: > > > > Perhaps a stupid question, but you did verify

Re: [Qemu-devel] [PATCH] target-s390x: fix CONVERT TO BINARY (CVD, CVDY)

2015-06-29 Thread Aurelien Jarno
On 2015-06-29 10:28, Richard Henderson wrote: > On 06/25/2015 08:16 PM, Aurelien Jarno wrote: > > for (shift = 4; (shift < 64) && bin; shift += 4) { > >-int current_number = bin % 10; > >- > >-dec |= (current_number) << shift; > >+dec |= (bin % 10) << shift; > >

Re: [Qemu-devel] [PATCH v3] target-i386: emulate CPUID level of real hardware

2015-06-29 Thread Eduardo Habkost
On Mon, Jun 22, 2015 at 01:08:02PM +0200, Radim Krčmář wrote: > W10 insider has a bug where it ignores CPUID level and interprets > CPUID.(EAX=07H, ECX=0H) incorrectly, because CPUID in fact returned > CPUID.(EAX=04H, ECX=0H); this resulted in execution of unsupported > instructions. > > While it

[Qemu-devel] [PATCH v8 08/11] i.MX: Add I2C controller emulator

2015-06-29 Thread Jean-Christophe Dubois
The slave mode is not implemented. Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * none Changes since v2: * use QOM cast * reworked debug printf * use CamelCase for state type * warn with qemu_log_mask(LOG_GUEST_ERROR) or qemu_lo

Re: [Qemu-devel] [RFC] ide: fix bmdma underflow code

2015-06-29 Thread John Snow
On 06/29/2015 04:16 PM, John Snow wrote: > This RFC requires my ahci-ncq-s2 patchset and all of its dependencies. > > Fix the BMDMA underflow code to acknowledge the new 'limit' parameter, > without breaking or modifying the existing ide-tests. > > This approach uses s->io_buffer_size as a retu

[Qemu-devel] [PATCH v8 09/11] i.MX25: Add the i.MX25 SOC support

2015-06-29 Thread Jean-Christophe Dubois
For now we do support the foolowing devices: * GPT timers (from i.MX31) * EPIT timers (from i.MX31) * CCM (from i.MX31) * AVIC (from i.MX31) * UART (from i.MX31) * Ethernet FEC port * I2C controller Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1

[Qemu-devel] [PATCH v8 10/11] i.MX25: Add support for the i.MX25 PDK 3DS

2015-06-29 Thread Jean-Christophe Dubois
This just adds the required memory arround the i.MX25 SOC. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Added a ds1338 I2C device for qtest purpose. Changes since v2: * none Changes since v3: * Rework GPL header * use I2C constructor helper. Changes

[Qemu-devel] [PATCH v8 11/11] i.MX: Add qtest support for I2C device emulator.

2015-06-29 Thread Jean-Christophe Dubois
This is using a ds1338 RTC chip on the I2C bus. This RTC chip is not present on the real board. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * use a common header file for I2C regs definition Changes since v3: * rework GPL heade

[Qemu-devel] [PATCH v8 07/11] i.MX: Add FEC Ethernet Emulator

2015-06-29 Thread Jean-Christophe Dubois
This is based on mcf_fec.c FEC implementation for Coldfire * A generic PHY was added (borrowwed from LAN9118) * The buffer management is also modified as buffers are slightly different between Coldfire and i.MX Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Ch

[Qemu-devel] [PATCH v8 04/11] i.MX: Split the i.MX EPIT emulator into a header file and a source file.

2015-06-29 Thread Jean-Christophe Dubois
This is to prepare to accomodate the SOC requirements. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not

[Qemu-devel] [PATCH v8 05/11] i.MX: Split the i.MX GPT emulator into a header file and a source file.

2015-06-29 Thread Jean-Christophe Dubois
This is to prepare to accomodate the SOC requirements. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not

[Qemu-devel] [PATCH v8 06/11] kzm: Use modified i.MX emulators.

2015-06-29 Thread Jean-Christophe Dubois
Use modified AVIC, CCM, UART, GPT, EPIT emultors. Tested by booting Linux one KZM emulator. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not pres

[Qemu-devel] [PATCH v8 03/11] i.MX: Split the i.MX CCM emulator into a header file and a source file.

2015-06-29 Thread Jean-Christophe Dubois
This is to prepare to accomodate the SOC requirements. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not

[Qemu-devel] [PATCH v8 02/11] i.MX: Split the i.MX AVIC emulator into a header file and a source file

2015-06-29 Thread Jean-Christophe Dubois
This is to prepare to accomodate the SOC requirements. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not

[Qemu-devel] [PATCH v8 00/11] i.MX: Add i.MX25 support through the 3DS evaluation board.

2015-06-29 Thread Jean-Christophe Dubois
This series of patches add the support for the i.MX25 processor through the Freescale 3DS evaluation board. For now a limited set of devices are supported. * GPT timers (from i.MX31) * EPIT timers (from i.MX31) * Serial ports (from i.MX31) * Ethernet FEC port * I2C controller

[Qemu-devel] [PATCH v8 01/11] i.MX: Split the i.MX serial driver into a header file and a source file

2015-06-29 Thread Jean-Christophe Dubois
Also adding a "realise" callback. This is to prepare to accomodate the SOC requirements. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-06-29 Thread Ryan Harper
It appears that the latest version of the patch is here: http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg00822.html However, this hasn't yet be accepted upstream. The most recent discussion requires the submitter to respond to the maintainers questions here: http://lists.gnu.org/archive

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-06-29 Thread Ryan Harper
Have you be able to reproduce this issue on a wily host? What about a different guest? Or is only RHEL6.3 affected? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1465935 Title: kvm_irqchip_commit

[Qemu-devel] [PATCH RFC 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

2015-06-29 Thread Konrad Rzeszutek Wilk
However the init routines assume that on errors the return code is -1 (as the libxc API is) - while those xen_host_* routines follow another paradigm - negative errno on return, 0 on success. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Qemu-devel] [PATCH RFC v1] Cleanups + various fixes due to libxl ABI + more logging on errors.

2015-06-29 Thread Konrad Rzeszutek Wilk
As I am in the process of syncing the 'dev.config' and Xen's internal cache of the PCI config space I noticed that some oddities in the code and figured that having them in would be easier for me (so I don't have to handle 20 odd patches). These: [PATCH RFC 1/6] xen/pt: Update comments with prope

  1   2   3   >