[Qemu-devel] [PULL 17/26] migration: create new section to store global state

2015-07-01 Thread Juan Quintela
This includes a new section that for now just stores the current qemu state. Right now, there are only one way to control what is the state of the target after migration. - If you run the target qemu with -S, it would start stopped. - If you run the target qemu without -S, it would run just

[Qemu-devel] [PULL 13/26] Fail more cleanly in mismatched RAM cases

2015-07-01 Thread Juan Quintela
From: Dr. David Alan Gilbert dgilb...@redhat.com If the number of RAMBlocks was different on the source from the destination, QEMU would hang waiting for a disconnect on the source and wouldn't release from that hang until the destination was manually killed. Mark the stream as being in error,

[Qemu-devel] [PATCH 01/12] qga: misc spelling

2015-07-01 Thread Marc-André Lureau
--- qga/qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index b446dc7..fbf983c 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -755,7 +755,7 @@ # scheme. Refer to the documentation of the guest

[Qemu-devel] [PATCH 10/12] qga: add --dump-conf option

2015-07-01 Thread Marc-André Lureau
This new option allows to review the agent configuration, and ease the task of writing a configuration file. Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- qga/main.c | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v15 05/21] replay: introduce mutex to protect the replay log

2015-07-01 Thread Pavel Dovgalyuk
This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [PATCH v15 00/21] Deterministic replay core

2015-07-01 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. This implementation of deterministic replay can be used for deterministic debugging of guest code through gdb remote interface. Core set of patches does not include support for reverse debugging

Re: [Qemu-devel] [PATCH 1/1] s390x/migration: Introduce 2.4 machine

2015-07-01 Thread Cornelia Huck
On Wed, 1 Jul 2015 11:16:57 +0200 Christian Borntraeger borntrae...@de.ibm.com wrote: The section footer changes commit f68945d42bab (Add a protective section footer) and commit 37fb569c0198 (Disable section footers on older machine types) broke migration for any non-versioned machines.

Re: [Qemu-devel] [PATCH v7 14/42] Return path: Send responses from destination to source

2015-07-01 Thread Juan Quintela
Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Juan Quintela (quint...@redhat.com) wrote: Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Add migrate_send_rp_message to send a message from destination to source along the

Re: [Qemu-devel] [PATCH 08/12] migration: ensure we start in NONE state

2015-07-01 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- migration/migration.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index cfcc227..c5b778b 100644 ---

Re: [Qemu-devel] [PATCH 04/12] global_state: Make section optional

2015-07-01 Thread Yang Hongyang
On 07/01/2015 04:51 PM, Juan Quintela wrote: This section would be sent: a- for all new machine types b- for old achine types if section state is different form {running,paused} s/achine/machine/ that were the only giving us troubles. So, in new qemus: it is alwasy there. In old

Re: [Qemu-devel] [PATCH 09/12] migration: Use always helper to set state

2015-07-01 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: There were three places that were not using the migrate_set_state() helper, just fix that. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- migration/migration.c | 6 +++--- 1 file

Re: [Qemu-devel] [PATCH 1/1] s390x/migration: Introduce 2.4 machine

2015-07-01 Thread Juan Quintela
Christian Borntraeger borntrae...@de.ibm.com wrote: Am 01.07.2015 um 11:56 schrieb Juan Quintela: Christian Borntraeger borntrae...@de.ibm.com wrote: First of all Reviewed-by: Juan Quintela quint...@redhat.com For the patch. But one said that, I don't agree with the commint text.

Re: [Qemu-devel] [PATCH v2 00/22] virtio: add version 1.0 support

2015-07-01 Thread Michael S. Tsirkin
On Tue, Jun 30, 2015 at 10:38:51AM +0200, Gerd Hoffmann wrote: Hi, This patch series adds virtio 1.0 support to the virtio blk and scsi drivers in seabios. With this series applied seabios happily boots in virtio 1.0 mode from both transitional and modern devices. Tested with Fedora 22

[Qemu-devel] [PATCH 06/12] qga: move option parsing to seperate function

2015-07-01 Thread Marc-André Lureau
Move option parsing out of giant main(). Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- qga/main.c | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/qga/main.c b/qga/main.c index b776d16..b965f61 100644 ---

Re: [Qemu-devel] [PATCH v2 07/22] virtio: find version 1.0 virtio capabilities

2015-07-01 Thread Gerd Hoffmann
Hi, Hmm this seems to violate this rule in the spec: The driver SHOULD use the first instance of each virtio structure type they can support. can support here means that bios was able to allocate it during enumeration. For example there could be both IO and memory, in

[Qemu-devel] Monitoring write to memory

2015-07-01 Thread Jun Koi
Hello, I am trying to monitor all the memory writing events inside Qemu by instrumenting tcg_gen_qemu_st8, tcg_gen_qemu_st16, tcg_gen_qemu_st32, tcg_gen_qemu_st64, as followings: // in tcg-op.h void helper_checkmem(int64_t data, int64_t address); // this is declared elsewhere static inline

[Qemu-devel] [PATCH] gdbstub: Implement Xfer:auxv:read

2015-07-01 Thread Bhushan Attarde
Implementation of Xfer:auxv:read to provide auxiliary vector information to clients which relies on it. For example: AT_ENTRY in auxiliary vector provides the entry point information. Client can use this information to compare it with entry point mentioned in executable to calculate load offset

Re: [Qemu-devel] [PATCH v2 07/22] virtio: find version 1.0 virtio capabilities

2015-07-01 Thread Michael S. Tsirkin
On Tue, Jun 30, 2015 at 10:38:58AM +0200, Gerd Hoffmann wrote: virtio 1.0 specifies the location of the various virtio regions using pci capabilities. Look them up and store the results. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 55

[Qemu-devel] [PATCH 05/12] qga: copy argument strings

2015-07-01 Thread Marc-André Lureau
A following patch will return allocated string. Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- qga/main.c | 57 +++-- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/qga/main.c b/qga/main.c index

[Qemu-devel] [PATCH 03/12] qga: move string split in seperate function

2015-07-01 Thread Marc-André Lureau
The function is going to be reused in a later patch. Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- qga/main.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/qga/main.c b/qga/main.c index af93992..0c455f8 100644 ---

[Qemu-devel] [PATCH 09/12] qga: free a bit more

2015-07-01 Thread Marc-André Lureau
Now that main() has a single exit point, we can free a few more allocations. Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- qga/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qga/main.c b/qga/main.c index aaf0e10..bd87050 100644 --- a/qga/main.c

[Qemu-devel] [PATCH v15 19/21] replay: replay blockers for devices

2015-07-01 Thread Pavel Dovgalyuk
Some devices are not supported by record/replay subsystem. This patch introduces replay blocker which denies starting record/replay if such devices are included into the configuration. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/bt/hci.c |7 +++

[Qemu-devel] [PATCH v15 08/21] cpu: replay instructions sequence

2015-07-01 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. When replayed instructions counter is expired qemu_notify_event() function is

[Qemu-devel] [PATCH v3 05/25] virtio: add version 1.0 structs and #defines

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.h | 61 src/hw/virtio-ring.h | 5 + 2 files changed, 66 insertions(+) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 85e623f..83ebcda 100644 ---

[Qemu-devel] [PATCH v3 03/25] virtio: add struct vp_device

2015-07-01 Thread Gerd Hoffmann
For virtio 1.0 support we will need more state than just the (legacy mode) ioaddr for each virtio-pci device. Prepare for that by adding a new struct for it. For now it carries the ioaddr only. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-blk.c | 19 +--

[Qemu-devel] [PATCH v3 09/25] virtio: add read/write functions and macros

2015-07-01 Thread Gerd Hoffmann
Add macros to read/write virtio registers. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.h | 86 + 1 file changed, 86 insertions(+) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 147e529..f7510f2 100644 ---

[Qemu-devel] [PATCH v3 07/25] virtio: find version 1.0 virtio capabilities

2015-07-01 Thread Gerd Hoffmann
virtio 1.0 specifies the location of the various virtio regions using pci capabilities. Look them up and store the results. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 56 + src/hw/virtio-pci.h | 8 2

[Qemu-devel] [PATCH v3 22/25] virtio-blk: 32bit cleanup

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-blk.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index c3052bb..29bc4a5 100644 --- a/src/hw/virtio-blk.c +++ b/src/hw/virtio-blk.c @@ -33,7 +33,7 @@

Re: [Qemu-devel] [PATCH] refresh filename after the node is replaced

2015-07-01 Thread Max Reitz
On 01.07.2015 03:08, Wen Congyang wrote: On 06/30/2015 09:17 PM, Max Reitz wrote: On 29.06.2015 03:16, Wen Congyang wrote: On 06/26/2015 11:16 PM, Max Reitz wrote: I see two solutions to this issue: Either, we do it right and that means, if there is a change in the BDS graph (e.g. because of

Re: [Qemu-devel] [SeaBIOS] [PATCH v3 00/25] virtio: add version 1.0 support, move to 32bit

2015-07-01 Thread Kevin O'Connor
On Wed, Jul 01, 2015 at 04:40:45PM +0200, Gerd Hoffmann wrote: Hi, This patch series adds virtio 1.0 support to the virtio blk and scsi drivers in seabios. With this series applied seabios happily boots in virtio 1.0 mode from both transitional and modern devices. This series also moves

Re: [Qemu-devel] [v8][RESEND][PATCH 08/10] xen, gfx passthrough: register a isa bridge

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: Currently we just register this isa bridge when we use IGD passthrough in Xen side. Signed-off-by: Tiejun Chen tiejun.c...@intel.com --- hw/xen/xen_pt.c | 18 ++ include/hw/xen/xen.h | 1 + 2 files changed, 19 insertions(+)

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Peter Hornyack
If userspace is controlling the crash capabilities then HV_X64_MSR_CRASH_CTL_CONTENTS is not needed. On Wed, Jul 1, 2015 at 8:53 AM, Denis V. Lunev d...@openvz.org wrote: On 01/07/15 18:00, Paolo Bonzini wrote: On 30/06/2015 13:33, Denis V. Lunev wrote: +#define HV_X64_MSR_CRASH_CTL_NOTIFY

Re: [Qemu-devel] [PATCH] move QemuOpts from qemu/option.h to qemu/typedefs.h

2015-07-01 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: On Di, 2015-06-30 at 10:15 +0100, Peter Maydell wrote: On 30 June 2015 at 10:09, Gerd Hoffmann kra...@redhat.com wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/qemu/option.h | 2 +- include/qemu/typedefs.h | 1 + 2 files

[Qemu-devel] [PATCH v3 02/25] virtio: run drivers in 32bit mode

2015-07-01 Thread Gerd Hoffmann
virtio version 1.0 registers can (and actually do in the qemu implementation) live in mmio space. So we must run the blk and scsi virtio drivers in 32bit mode, otherwise we can't access them. This also allows to drop a bunch of GET_LOWFLAT calls from the virtio code in the following patches.

[Qemu-devel] [PATCH v3 17/25] virtio-scsi: fix initialization for version 1.0

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-scsi.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index 8073c77..89dcb8d 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@

[Qemu-devel] [PATCH v3 15/25] virtio: remove unused vp_del_vq

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 3054a13..1b5c61d 100644 --- a/src/hw/virtio-pci.h +++ b/src/hw/virtio-pci.h @@ -234,17 +234,6 @@ void

[Qemu-devel] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-07-01 Thread Stefan Hajnoczi
If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2) EINVAL failures may be encountered. It is possible to trigger this by setting granularity to a low value like 8192. This patch stops appending chunks once IOV_MAX is reached. The spurious EINVAL failure can be reproduced with a

Re: [Qemu-devel] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-07-01 Thread Paolo Bonzini
On 01/07/2015 16:45, Stefan Hajnoczi wrote: If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2) EINVAL failures may be encountered. It is possible to trigger this by setting granularity to a low value like 8192. This patch stops appending chunks once IOV_MAX is reached.

[Qemu-devel] [PATCH v3 19/25] virtio: use version 1.0 if available (flip the big switch)

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index dcbf6d7..5cb0e73 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c @@ -260,16

[Qemu-devel] [PATCH 08/16] nvdimm: init backend memory mapping and config data area

2015-07-01 Thread Xiao Guangrong
The parameter @file is used as backed memory for NVDIMM which is divided into two parts: - first parts is (0, size - 128K], which is used as PMEM (Persistent Memory) - 128K at the end of the file, which is used as Config Data Area, it's used to store Label namespace data The @file supports

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Paolo Bonzini
On 30/06/2015 13:33, Denis V. Lunev wrote: +#define HV_X64_MSR_CRASH_CTL_NOTIFY (1ULL 63) +#define HV_X64_MSR_CRASH_CTL_CONTENTS\ + (HV_X64_MSR_CRASH_CTL_NOTIFY) Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed? Can I just remove it? Paolo

[Qemu-devel] [PATCH 16/16] nvdimm: support NFIT_CMD_SET_CONFIG_DATA

2015-07-01 Thread Xiao Guangrong
Function 6 is used to set Namespace Label Data Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/mem/pc-nvdimm.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/mem/pc-nvdimm.c b/hw/mem/pc-nvdimm.c index 0498de3..0d2d9fb 100644 ---

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-07-01 Thread Stefan Hajnoczi
On Wed, Jul 1, 2015 at 3:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 01/07/2015 16:45, Stefan Hajnoczi wrote: If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2) EINVAL failures may be encountered. It is possible to trigger this by setting granularity to a low value

Re: [Qemu-devel] [PATCH for-2.4 1/2] qom: Do not reuse errp after a possible error

2015-07-01 Thread Daniel P. Berrange
On Wed, Jul 01, 2015 at 05:47:03PM +0200, Markus Armbruster wrote: The argument for an Error **errp parameter must point to a null pointer. If it doesn't, and an error happens, error_set() fails its assertion. Instead of foo(foos, errp); bar(bars, errp); you need to do

[Qemu-devel] [PATCH v3 23/25] virtio-scsi: 32bit cleanup

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-scsi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/hw/virtio-scsi.c b/src/hw/virtio-scsi.c index 6b4ed1a..cb825d4 100644 --- a/src/hw/virtio-scsi.c +++ b/src/hw/virtio-scsi.c @@ -53,10 +53,10

[Qemu-devel] [PATCH v3 01/25] pci: allow to loop over capabilities

2015-07-01 Thread Gerd Hoffmann
Add a parameter to pci_find_capability, to specify the start point. This allows to find multiple capabilities of the same type, by calling pci_find_capability again with the offset of the last capability found. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/fw/pciinit.c | 4 ++--

[Qemu-devel] [PATCH v3 00/25] virtio: add version 1.0 support, move to 32bit

2015-07-01 Thread Gerd Hoffmann
Hi, This patch series adds virtio 1.0 support to the virtio blk and scsi drivers in seabios. With this series applied seabios happily boots in virtio 1.0 mode from both transitional and modern devices. This series also moves all virtio code to 32bit. Tested with Fedora 22 guest, booting from

[Qemu-devel] [PATCH v3 16/25] virtio: add version 1.0 support to vp_find_vq

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 58 +++-- 1 file changed, 43 insertions(+), 15 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 240cd2f..dcbf6d7 100644 --- a/src/hw/virtio-pci.c +++

[Qemu-devel] [PATCH 09/16] nvdimm: build ACPI NFIT table

2015-07-01 Thread Xiao Guangrong
NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 tables: - SPA table, define the PMEM region info - MEM DEV table, it has the @handle which is used to associate specified ACPI NVDIMM device we will introduce in

[Qemu-devel] [PATCH 01/16] acpi: allow aml_operation_region() working on 64 bit offset

2015-07-01 Thread Xiao Guangrong
Currently, the offset in OperationRegion is limited to 32 bit, extend it to 64 bit so that we can switch SSDT to 64 bit in later patch Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/acpi/aml-build.c | 2 +- include/hw/acpi/aml-build.h | 2 +- 2 files changed, 2

[Qemu-devel] [PATCH 05/16] acpi: add aml_create_field

2015-07-01 Thread Xiao Guangrong
Implement CreateField term which are used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/acpi/aml-build.c | 14 ++ include/hw/acpi/aml-build.h | 1 + 2 files changed, 15 insertions(+) diff --git a/hw/acpi/aml-build.c

[Qemu-devel] [PATCH 12/16] nvdimm: save arg3 for NVDIMM device _DSM method

2015-07-01 Thread Xiao Guangrong
Check if the function (Arg2) has additional input info (arg3) and save the info if needed We only do the save on NVDIMM device since we are not going to support any function on root device Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/mem/pc-nvdimm.c | 73

[Qemu-devel] [PATCH 06/16] pc: implement NVDIMM device abstract

2015-07-01 Thread Xiao Guangrong
Introduce pc-nvdimm device and it only has one parameter, @file, which is the backed memory file for NVDIMM device We can use -device pc-nvdimm,file=/dev/pmem in the Qemu command to create NVDIMM device for the guest Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com ---

[Qemu-devel] [PATCH 14/16] nvdimm: support NFIT_CMD_GET_CONFIG_SIZE function

2015-07-01 Thread Xiao Guangrong
Function 4 is used to get Namespace lable size Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/mem/pc-nvdimm.c | 87 ++ 1 file changed, 87 insertions(+) diff --git a/hw/mem/pc-nvdimm.c b/hw/mem/pc-nvdimm.c index

[Qemu-devel] [Bug 1470536] Re: qemu-img incorrectly prints qemu-img: Host floppy pass-through is deprecated

2015-07-01 Thread Richard Jones
I sent a patch to qemu-devel which should fix this. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1470536 Title: qemu-img incorrectly prints qemu-img: Host floppy pass-through is deprecated

[Qemu-devel] [PATCH 15/16] nvdimm: support NFIT_CMD_GET_CONFIG_DATA

2015-07-01 Thread Xiao Guangrong
Function 5 is used to get Namespace Label Data Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/mem/pc-nvdimm.c | 33 + 1 file changed, 33 insertions(+) diff --git a/hw/mem/pc-nvdimm.c b/hw/mem/pc-nvdimm.c index 7e5446c..0498de3 100644 ---

[Qemu-devel] [PATCH for-2.4 1/2] qom: Do not reuse errp after a possible error

2015-07-01 Thread Markus Armbruster
The argument for an Error **errp parameter must point to a null pointer. If it doesn't, and an error happens, error_set() fails its assertion. Instead of foo(foos, errp); bar(bars, errp); you need to do something like Error *err = NULL; foo(foos, err); if (err) {

Re: [Qemu-devel] [v8][RESEND][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: Just register that pci host bridge specific to passthrough. Signed-off-by: Tiejun Chen tiejun.c...@intel.com --- hw/i386/pc_piix.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c

Re: [Qemu-devel] [v8][RESEND][PATCH 00/10] xen: add Intel IGD passthrough

2015-07-01 Thread Stefano Stabellini
Aside from a couple of really minor stylistic issues, I think the patch series can go in from my point of view. However it looks like you are still missing a few acked-by/reviewed-by on the non-xen patches. On Wed, 1 Jul 2015, Chen, Tiejun wrote: Ping... Thanks Tiejun On 2015/6/5 16:44,

[Qemu-devel] [PATCH v3 21/25] virtio: legacy cleanup

2015-07-01 Thread Gerd Hoffmann
Now that all code is switched over to use vp_read/write we can drop the ioaddr field from vp_device and the offset #defines. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 1 - src/hw/virtio-pci.h | 33 + 2 files changed, 1 insertion(+),

[Qemu-devel] [PATCH v3 13/25] virtio: add version 1.0 support to vp_reset

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 11 +++ src/hw/virtio-pci.h | 9 + 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 2f0bb40..bd51d8a 100644 --- a/src/hw/virtio-pci.c +++

[Qemu-devel] [PATCH v3 24/25] virtio-ring: 32bit cleanup

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-ring.c | 61 ++-- 1 file changed, 30 insertions(+), 31 deletions(-) diff --git a/src/hw/virtio-ring.c b/src/hw/virtio-ring.c index 6c86c38..7205a0a 100644 --- a/src/hw/virtio-ring.c

[Qemu-devel] [PATCH 07/16] nvdimm: reserve address range for NVDIMM

2015-07-01 Thread Xiao Guangrong
NVDIMM reserves all the free range above 4G to do: - Persistent Memory (PMEM) mapping - implement NVDIMM ACPI device _DSM method Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/i386/pc.c | 11 +-- hw/mem/pc-nvdimm.c | 13 +

[Qemu-devel] [Bug 1470536] [NEW] qemu-img incorrectly prints qemu-img: Host floppy pass-through is deprecated

2015-07-01 Thread Richard Jones
Public bug reported: qemu-img incorrectly prints this warning when you use /dev/fd/NN to pass in file descriptors. A simple way to demonstrate this uses bash process substitution, so the following will only work if you are using bash as your shell: $ qemu-img info ( cat /dev/null ) qemu-img:

Re: [Qemu-devel] [PATCH] block/raw-posix: Don't think /dev/fd/NN is a floppy drive.

2015-07-01 Thread Markus Armbruster
Richard W.M. Jones rjo...@redhat.com writes: In libguestfs we use /dev/fd/NN to pass pre-opened file descriptors to qemu-img. Lately I've discovered that although this works, qemu believes that these are floppy disk images. That in itself isn't much of a problem, but now qemu prints a

[Qemu-devel] [PATCH v3 04/25] virtio: pass struct pci_device to vp_init_simple

2015-07-01 Thread Gerd Hoffmann
... instead of the bdf only. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-blk.c | 2 +- src/hw/virtio-pci.c | 6 +++--- src/hw/virtio-pci.h | 3 ++- src/hw/virtio-scsi.c | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/hw/virtio-blk.c

[Qemu-devel] [PATCH v3 08/25] virtio: create vp_cap struct for legacy bar

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 5 - src/hw/virtio-pci.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 58f3d39..3c8fb7b 100644 --- a/src/hw/virtio-pci.c +++ b/src/hw/virtio-pci.c

[Qemu-devel] [PATCH v3 11/25] virtio: add version 1.0 support to vp_{get, set}_status

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 20 src/hw/virtio-pci.h | 13 ++--- 2 files changed, 22 insertions(+), 11 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 5ae6a76..c9c79b3 100644 ---

[Qemu-devel] [PATCH 00/16] implement vNVDIMM

2015-07-01 Thread Xiao Guangrong
== Background == NVDIMM (A Non-Volatile Dual In-line Memory Module) is going to be supported on Intel's platform. They are discovered via ACPI and configured by _DSM method of NVDIMM device in ACPI. There has some supporting documents which can be found at: ACPI 6:

[Qemu-devel] [PATCH 03/16] acpi: add aml_derefof

2015-07-01 Thread Xiao Guangrong
Implement DeRefOf term which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-07-01 Thread Paolo Bonzini
On 01/07/2015 16:59, Stefan Hajnoczi wrote: I found it annoying to write it backwards too, but it's for consistency: if (s-buf_free_count nb_chunks + added_chunks) { trace_mirror_break_buf_busy(s, nb_chunks, s-in_flight); break; } if (IOV_MAX nb_chunks + added_chunks)

Re: [Qemu-devel] [PATCH 9/9] qemu/kvm: kvm hyper-v based guest crash event handling

2015-07-01 Thread Paolo Bonzini
On 30/06/2015 13:33, Denis V. Lunev wrote: +static int kvm_arch_handle_hv_crash(CPUState *cs) +{ +X86CPU *cpu = X86_CPU(cs); +CPUX86State *env = cpu-env; + +/* Mark that Hyper-v guest crash occurred */ +env-hv_crash_occurred = 1; This need not be a hv crash. You can

Re: [Qemu-devel] [PATCH 8/9] kvm/x86: add sending hyper-v crash notification to user space

2015-07-01 Thread Paolo Bonzini
On 30/06/2015 13:33, Denis V. Lunev wrote: From: Andrey Smetanin asmeta...@virtuozzo.com Sending of notification is done by exiting vcpu to user space if KVM_REQ_HV_CRASH is enabled for vcpu. kvm_run structure will contains system_event with type KVM_SYSTEM_EVENT_CRASH and flag

Re: [Qemu-devel] [v8][RESEND][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: basic gfx passthrough support: - add a vga type for gfx passthrough - register/unregister legacy VGA I/O ports and MMIOs for passthrough GFX Signed-off-by: Tiejun Chen tiejun.c...@intel.com Signed-off-by: Yang Zhang yang.z.zh...@intel.com Acked-by:

[Qemu-devel] [PATCH for-2.4 2/2] qom: Fix invalid error check in property_get_str()

2015-07-01 Thread Markus Armbruster
When a function returns a null pointer on error and only on error, you can do if (!foo(foos, errp)) { ... handle error ... } instead of the more cumbersome Error *err = NULL; if (!foo(foos, err)) { error_propagate(errp, err); ... handle error ... }

[Qemu-devel] [PATCH for-2.4 0/2] qom: Fix misuse of Error API

2015-07-01 Thread Markus Armbruster
Most of the bugs are fairly old, and we may decide to let sleeping dogs lie this close to a release. Maintainer's discretion, tagging for-2.4 just to make sure the fixes are considered. Markus Armbruster (2): qom: Do not reuse errp after a possible error qom: Fix invalid error check in

Re: [Qemu-devel] [PATCH v3 0/9] HyperV equivalent of pvpanic driver

2015-07-01 Thread Denis V. Lunev
On 01/07/15 17:09, Paolo Bonzini wrote: On 30/06/2015 13:33, Denis V. Lunev wrote: Windows 2012 guests can notify hypervisor about occurred guest crash (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does handling of this MSR's by KVM and sending notification to user

[Qemu-devel] [PATCH v3 06/25] virtio: add version 0.9.5 struct

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/hw/virtio-pci.h b/src/hw/virtio-pci.h index 83ebcda..42e2b7f 100644 --- a/src/hw/virtio-pci.h +++ b/src/hw/virtio-pci.h @@ -40,6 +40,20 @@ /* Virtio ABI

[Qemu-devel] [PATCH v3 10/25] virtio: make features 64bit, support version 1.0 features

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-blk.c | 2 +- src/hw/virtio-pci.c | 33 + src/hw/virtio-pci.h | 12 +++- 3 files changed, 37 insertions(+), 10 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index

[Qemu-devel] [PATCH v3 20/25] virtio: also probe version 1.0 pci ids

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/pci_ids.h | 8 ++-- src/hw/virtio-blk.c | 5 +++-- src/hw/virtio-scsi.c | 5 +++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/hw/pci_ids.h b/src/hw/pci_ids.h index 1cd4f72..cdf9b3c 100644 ---

[Qemu-devel] [PATCH v3 14/25] virtio: add version 1.0 support to vp_notify

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 22 +- src/hw/virtio-pci.h | 7 ++- src/hw/virtio-ring.c | 2 +- src/hw/virtio-ring.h | 1 + 4 files changed, 25 insertions(+), 7 deletions(-) diff --git a/src/hw/virtio-pci.c

[Qemu-devel] [PATCH 10/16] nvdimm: init the address region used by _DSM method

2015-07-01 Thread Xiao Guangrong
This memory range is used to transfer data between ACPI in guest and Qemu, it occupies two pages: - one is RAM-based used to save the input info of _DSM method and Qemu reuse it store output info - another one is MMIO-based, ACPI write data to this page to transfer the control to Qemu

[Qemu-devel] [PATCH 02/16] i386/acpi-build: allow SSDT to operate on 64 bit

2015-07-01 Thread Xiao Guangrong
Only 512M is left for MMIO below 4G and that are used by PCI, BIOS etc. Other components also reserve regions from their internal usage, e.g, [0xFED0, 0xFED0 + 0x400) is reserved for HPET Switch SSDT to 64 bit to use the huge free room above 4G. In the later patches, we will dynamical

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

2015-07-01 Thread Zavadovsky Yan
Ping. Patchwork: http://patchwork.ozlabs.org/patch/488073/ v1 discussion: http://lists.nongnu.org/archive/html/qemu-devel/2015-06/msg05791.html and patchworks: http://patchwork.ozlabs.org/patch/487438/ http://patchwork.ozlabs.org/patch/487566/ On Wed, Jun 24, 2015 at 3:25 PM, Zavadovsky Yan

[Qemu-devel] [PATCH] block/raw-posix: Don't think /dev/fd/NN is a floppy drive.

2015-07-01 Thread Richard W.M. Jones
In libguestfs we use /dev/fd/NN to pass pre-opened file descriptors to qemu-img. Lately I've discovered that although this works, qemu believes that these are floppy disk images. That in itself isn't much of a problem, but now qemu prints a warning about host floppy pass-thru being deprecated.

[Qemu-devel] [PATCH v3 12/25] virtio: add version 1.0 support to vp_get_isr

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 9 + src/hw/virtio-pci.h | 6 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index c9c79b3..2f0bb40 100644 --- a/src/hw/virtio-pci.c +++

[Qemu-devel] [PATCH v3 25/25] virtio-pci: use high memory for rings

2015-07-01 Thread Gerd Hoffmann
That way we should be able to manage *alot* more devices. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c index 8e7ea46..6df5194 100644 --- a/src/hw/virtio-pci.c

[Qemu-devel] [PATCH v3 18/25] virtio-blk: fix initialization for version 1.0

2015-07-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- src/hw/virtio-blk.c | 84 + src/hw/virtio-pci.h | 13 - 2 files changed, 72 insertions(+), 25 deletions(-) diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c index 8378a34..703b147

[Qemu-devel] [PATCH 13/16] nvdimm: support NFIT_CMD_IMPLEMENTED function

2015-07-01 Thread Xiao Guangrong
__DSM is defined in ACPI 6.0: 9.14.1 _DSM (Device Specific Method) Function 0 is a query function. We do not support any function on root device and only 3 functions are support for NVDIMM device, NFIT_CMD_GET_CONFIG_SIZE, NFIT_CMD_GET_CONFIG_DATA and NFIT_CMD_SET_CONFIG_DATA, that means we

[Qemu-devel] [PATCH 04/16] acpi: add aml_sizeof

2015-07-01 Thread Xiao Guangrong
Implement SizeOf term which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong guangrong.x...@linux.intel.com --- hw/acpi/aml-build.c | 8 include/hw/acpi/aml-build.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/acpi/aml-build.c

[Qemu-devel] [PATCH 11/16] nvdimm: build ACPI nvdimm devices

2015-07-01 Thread Xiao Guangrong
NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices This is a root device under \_SB and specified NVDIMM device are under the root device. Each NVDIMM device has _ADR which return its handle used to associate MEMDEV table in NFIT We reserve handle 0 for root device. In this patch, we save

Re: [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests

2015-07-01 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: On Mon, Jun 29, 2015 at 08:10:20AM +0200, Markus Armbruster wrote: Alexander Yarygin yary...@linux.vnet.ibm.com writes: Markus Armbruster arm...@redhat.com writes: * Ignorant answer: I was told that the bdrv_drain_all()'s comment is obsolete

Re: [Qemu-devel] [v8][RESEND][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: Now we retrieve VGA bios like kvm stuff in qemu but we need to fix Device Identification in case if its not matched with the real IGD device since Seabios is always trying to compare this ID to work out VGA BIOS. Signed-off-by: Tiejun Chen

Re: [Qemu-devel] [PATCH 3/9] kvm: add hyper-v crash msrs values

2015-07-01 Thread Denis V. Lunev
On 01/07/15 18:00, Paolo Bonzini wrote: On 30/06/2015 13:33, Denis V. Lunev wrote: +#define HV_X64_MSR_CRASH_CTL_NOTIFY(1ULL 63) +#define HV_X64_MSR_CRASH_CTL_CONTENTS \ + (HV_X64_MSR_CRASH_CTL_NOTIFY) Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed? Can I just remove

Re: [Qemu-devel] [v8][RESEND][PATCH 10/10] xen, gfx passthrough: add opregion mapping

2015-07-01 Thread Stefano Stabellini
On Fri, 5 Jun 2015, Tiejun Chen wrote: The OpRegion shouldn't be mapped 1:1 because the address in the host can't be used in the guest directly. This patch traps read and write access to the opregion of the Intel GPU config space (offset 0xfc). The original patch is from Jean Guyader

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-07-01 Thread Stefan Hajnoczi
On Wed, Jul 1, 2015 at 4:03 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 01/07/2015 16:59, Stefan Hajnoczi wrote: I found it annoying to write it backwards too, but it's for consistency: if (s-buf_free_count nb_chunks + added_chunks) { trace_mirror_break_buf_busy(s, nb_chunks,

Re: [Qemu-devel] [PATCH 1/1] block: update BlockDriverState's children in bdrv_set_backing_hd()

2015-07-01 Thread Max Reitz
On 01.07.2015 16:21, Alberto Garcia wrote: When a backing image is opened using bdrv_open_inherit(), it is added to the parent image's list of children. However there's no way to remove it from there. In particular, changing a BlockDriverState's backing image does not add the new one to the

Re: [Qemu-devel] [Qemu-discuss] GRO not happening in VM with VxLAN

2015-07-01 Thread Vlad Yasevich
On 07/01/2015 02:50 PM, Santosh R wrote: Since the vxlan UDP header checksum is 0, udp_tunnel_gro_complete (called via vxlan_gro_complete) is setting SKB_GSO_UDP_TUNNEL in skb_shinfo(skb)-gso_type. Later when bridge interface tries to forward this packet to tap interface

Re: [Qemu-devel] [Qemu-discuss] GRO not happening in VM with VxLAN

2015-07-01 Thread Santosh R
I am using 3.18 kernel. #uname -a Linux Indra.asicdesigners.com 3.18.0 #11 SMP Wed Jul 1 21:49:44 IST 2015 x86_64 x86_64 x86_64 GNU/Linux #cat /etc/issue Red Hat Enterprise Linux Server release 6.5 (Santiago) Kernel \r on an \m As mentioned in my initial post, this is how I am starting the VM.

Re: [Qemu-devel] [PATCH] linux-user: Avoid compilation error with --disable-guest-base

2015-07-01 Thread Aurelien Jarno
On 2015-07-01 20:21, Laurent Vivier wrote: Le 01/07/2015 15:15, Aurelien Jarno a écrit : On 2015-07-01 01:58, Laurent Vivier wrote: Le 30/06/2015 19:20, Peter Maydell a écrit : On 30 June 2015 at 18:13, Laurent Vivier laur...@vivier.eu wrote: Le 30/06/2015 18:45, Peter Maydell

<    1   2   3   4   5   >