Re: [Qemu-devel] [PATCH qemu v10 10/14] spapr_pci: Enable vfio-pci hotplug

2015-07-11 Thread Alexey Kardashevskiy
On 07/11/2015 07:33 AM, Michael Roth wrote: Quoting Alexey Kardashevskiy (2015-07-05 21:11:06) sPAPR IOMMU is managing two copies of an TCE table: 1) a guest view of the table - this is what emulated devices use and this is where H_GET_TCE reads from; 2) a hardware TCE table - only present if th

[Qemu-devel] [PATCH 8/8] disas: alpha: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() alpha specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. This also makes monitor_disas() consistent with target_disas(), as monitor_disas() was missing a set of the BFD (This was an omission from commit b9bec75

[Qemu-devel] [PATCH 2/8] disas: moxie: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() moxie specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. Cc: Anthony Green Signed-off-by: Peter Crosthwaite --- I don't have any easy way to test this. Is there a simple binary image somewhere I can pass in t

[Qemu-devel] [PATCH 5/8] disas: lm32: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() lm32 specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. Cc: Michael Walle Signed-off-by: Peter Crosthwaite --- Testing: $ ./lm32-softmmu/qemu-system-lm32 -kernel ./random_code -S -d in_asm -nographic QEMU 2.3

[Qemu-devel] [PATCH 6/8] disas: sh4: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() sh4 specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. Cc: Aurelien Jarno Signed-off-by: Peter Crosthwaite --- Testing: $ ../../qemu/sh4-softmmu/qemu-system-sh4 -M r2d -kernel zImage \ -hda sh-linux-mini.

[Qemu-devel] [PATCH 1/8] disas: s390x: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() s390 specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. Cc: Richard Henderson Cc: Alexander Graf Signed-off-by: Peter Crosthwaite --- Testing: $ ./s390x-softmmu/qemu-system-s390x -nographic -d in_asm -S 2> e

[Qemu-devel] [PATCH 4/8] disas: sparc: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() sparc specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. Cc: Mark Cave-Ayland Signed-off-by: Peter Crosthwaite --- Testing: $ ./sparc64-softmmu/qemu-system-sparc64 -nographic 2> er -d in_asm -S QEMU 2.3.90 mo

[Qemu-devel] [PATCH 0/8] Disas QOMification, round 2

2015-07-11 Thread Peter Crosthwaite
Continue QOMifying target-specific disassembly. Convert all arches except for X86 and PPC. They will be round 3 and are non-trivial. This brings us close to no arch-specific code in disas.c allow conversion to common-obj and preparing these arches for inclusion in multi-arch. Tested to various de

[Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() m68k specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. Cc: Greg Ungerer Cc: Laurent Vivier Signed-off-by: Peter Crosthwaite --- Testing: I cant find binaries for this arch easily, but I got this from execut

[Qemu-devel] [PATCH 7/8] disas: mips: QOMify target specific disas setup

2015-07-11 Thread Peter Crosthwaite
From: Peter Crosthwaite Move the target_disas() mips specifics to the QOM disas_set_info hook and delete the #ifdef specific code in disas.c. Cc: Aurelien Jarno Cc: Leon Alrae Signed-off-by: Peter Crosthwaite --- Testing: mips-test$ ./run-qemu -d in_asm -S 2> err QEMU 2.3.90 monitor - type 'h

Re: [Qemu-devel] Semantics of tcg_enabled() and what it means for multi-arch

2015-07-11 Thread Peter Crosthwaite
On Sat, Jul 11, 2015 at 3:23 PM, Paolo Bonzini wrote: > > > On 11/07/2015 22:46, Peter Crosthwaite wrote: >> include/exec/ram_addr.h:if (tcg_enabled()) { >> include/exec/ram_addr.h:uint8_t clients = tcg_enabled() ? >> DIRTY_CLIENTS_ALL : DIRTY_CLIENTS_NOCODE; >> memory.c:

Re: [Qemu-devel] Semantics of tcg_enabled() and what it means for multi-arch

2015-07-11 Thread Paolo Bonzini
On 11/07/2015 22:46, Peter Crosthwaite wrote: > include/exec/ram_addr.h:if (tcg_enabled()) { > include/exec/ram_addr.h:uint8_t clients = tcg_enabled() ? > DIRTY_CLIENTS_ALL : DIRTY_CLIENTS_NOCODE; > memory.c:mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE)

[Qemu-devel] Semantics of tcg_enabled() and what it means for multi-arch

2015-07-11 Thread Peter Crosthwaite
Hi Paolo, Richard and all, What is the exact semantic of tcg_enabled() supposed to be and is it ill-defined in multi-arch? Currently, tcg_enabled is defined as: bool tcg_enabled(void) { return tcg_ctx.code_gen_buffer != NULL; } In the multi-arch work, the tcg_ctx is now multiple per-arch. S

Re: [Qemu-devel] [RFC v2 15/34] HACK: monitor: Comment out TCG profile ops

2015-07-11 Thread Peter Crosthwaite
On Mon, Jun 1, 2015 at 1:03 AM, Paolo Bonzini wrote: > > > On 31/05/2015 08:11, Peter Crosthwaite wrote: >> Not dealing with this problem as of this RFC, but comments on how >> to solve it welcome. The approach adopted by this series is to >> implement multi-arch as multiple translators, so a sing

Re: [Qemu-devel] [PATCH for-2.4] pc: fix machine options for pc-i440fx-2.3 and below

2015-07-11 Thread Eduardo Habkost
On Thu, Jul 09, 2015 at 03:28:22PM -0500, Michael Roth wrote: > Commit fddd179 introduced a mechanical change that initialized default > machine options using functions instead of macros. Prior to the change > options for pc-i440fx-2.3 were defined as: > > #define PC_I440FX_MACHINE_OPTIONS \ >

[Qemu-devel] selecting VIRTIO_INPUT and VIRTIO_VGA

2015-07-11 Thread Paolo Bonzini
Hi Gerd, are there any reasons why virtio-input is only compiled on Linux, and virtio-vga is only compiled on 64-bit Intel? Paolo

[Qemu-devel] Modifying qemu-option.hx

2015-07-11 Thread Chris Johnson
Hello, I am in the process of writing my own back-end driver and am trying to figure out how to get this driver to work with qemu. I have found this link that mentions editing the qemu-option.hx file and rebuilding QEMU: http://stackoverflow.com/questions/29158244/how-to-add-a-new-type-of-virt

Re: [Qemu-devel] [RFC PATCH] target-arm: kvm: Differentiate registers based on write-back levels

2015-07-11 Thread Christoffer Dall
On Fri, Jul 10, 2015 at 12:22:31PM +0100, Peter Maydell wrote: > On 10 July 2015 at 12:00, Christoffer Dall > wrote: > > Some registers like the CNTVCT register should only be written to the > > kernel as part of machine initialization or on vmload operations, but > > never during runtime, as thi

Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals

2015-07-11 Thread Peter Crosthwaite
On Wed, Jun 24, 2015 at 2:50 AM, Paolo Bonzini wrote: > > > On 24/06/2015 06:22, Peter Crosthwaite wrote: >> For a summary here is the review state of the multi-arch patch queue. >> I have too many reviewed-but-unapplied patches I have stopped working >> on the feature until I get some of this alr

Re: [Qemu-devel] [PATCH v2 2/3] crypto: avoid undefined behavior in nettle calls

2015-07-11 Thread Radim Krčmář
2015-07-10 19:18+0200, Radim Krčmář: > diff --git a/crypto/cipher-nettle.c b/crypto/cipher-nettle.c > +void aes_encrypt_wrapper(cipher_ctx_t ctx, cipher_length_t length, > + uint8_t *dst, const uint8_t *src) Wrappers should be static (rushed posting). I'll send v3 on Wed/T

Re: [Qemu-devel] [RFC v2 05/34] translate: Listify tcg_exec_init

2015-07-11 Thread Peter Crosthwaite
On Fri, Jul 10, 2015 at 3:15 AM, Peter Crosthwaite wrote: > On Sat, May 30, 2015 at 11:11 PM, Peter Crosthwaite > wrote: >> Create a global list of tcg_exec_init functions that is populated at >> startup. Multiple translation engines can register an init function >> and all will be called on the

Re: [Qemu-devel] [PATCH for-2.4] i.MX: Fix UART driver to work with unitialized "chardev" device

2015-07-11 Thread Peter Crosthwaite
On Thu, Jul 9, 2015 at 2:29 AM, Jean-Christophe Dubois wrote: > The "chardev" property initialisation might failed (for example because > there is not enough chardev handled by Qemu). > > The serial device emulator need to be able to "work" with an uninitialized > (NULL) "chardev" device pointer.

Re: [Qemu-devel] [PATCH 3/4] arm/xlnx-zynqmp: fix memory leak

2015-07-11 Thread Peter Crosthwaite
On Thu, Jul 9, 2015 at 5:51 PM, wrote: > From: Gonglei > > fix CID 1311372. > > Signed-off-by: Gonglei > --- > hw/arm/xlnx-zynqmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index 5e72078..00c5943 100644 > --- a/h

Re: [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Connect the four OCM banks

2015-07-11 Thread Peter Crosthwaite
On Fri, Jul 10, 2015 at 11:11 AM, Alistair Francis wrote: > The Xilinx EP108 has four separate OCM banks which are located > adjacent to each other. This patch adds the four banks to > the ZynqMP SoC. > > Signed-off-by: Alistair Francis > --- > > hw/arm/xlnx-zynqmp.c | 13 +

Re: [Qemu-devel] [PATCH for-2.4] tci: Fix regression with INDEX_op_qemu_st_i32, INDEX_op_qemu_st_i64

2015-07-11 Thread Richard Henderson
On 07/10/2015 08:22 PM, Stefan Weil wrote: Commit 59227d5d45bb3c31dc2118011691c35b3c00879c did not update the code in tcg/tci/tcg-target.c for those two cases. Signed-off-by: Stefan Weil --- Peter, could you please apply this patch directly (after Richard's review)? Maybe this is simpler than