[Qemu-devel] [PULL 2/3] virtio-input: move sys/ioctl.h include

2015-07-16 Thread Gerd Hoffmann
Drop from include/standard-headers/linux/input.h Add to hw/input/virtio-input-host.c instead. That allows to build virtio-input (except pass-through) on windows. Signed-off-by: Gerd Hoffmann --- hw/input/virtio-input-host.c | 1 + include/standard-headers/linux/input.h | 1 - scripts/

[Qemu-devel] net: Next steps to deprecate -net (was: [RFC PATCH] Enable vlans and dump for -netdev, too)

2015-07-16 Thread Thomas Huth
On 05/26/2015 04:29 PM, Markus Armbruster wrote: > Stefan Hajnoczi writes: [...] >> We thought the QEMU "vlan" concept would be dropped completely in the >> future, so it was never added to -netdev. No patches to do that have >> been posted over the years, so I think it was more of a conceptual g

[Qemu-devel] [PULL 3/3] hid: clarify hid_keyboard_process_keycode

2015-07-16 Thread Gerd Hoffmann
From: Paolo Bonzini Coverity thinks the fallthroughs are smelly. They are correct, but everything else in this function is like "wut?". Refer explicitly to bits 8 and 9 of hs->kbd.modifiers instead of shifting right first and using (1 << 7). Document what the scancode is when hid_code is 0xe0.

[Qemu-devel] [PULL v2 for-2.4 0/3] input: fixes for 2.4

2015-07-16 Thread Gerd Hoffmann
Hi, Dropped the patch to enable virtio-input for non-linux systems. Otherwise unmodified. please pull, Gerd The following changes since commit 2d5ee9e7a7dd495d233cf9613a865f63f88e3375: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150716' into staging (2015-07-1

[Qemu-devel] [PULL 1/3] virtio-input: fix segfault in virtio_input_hid_properties

2015-07-16 Thread Gerd Hoffmann
From: Lin Ma commit 5cce173 introduced virtio-input segfault, This patch fixes it. Signed-off-by: Lin Ma Signed-off-by: Gerd Hoffmann --- hw/input/virtio-input-hid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c index 616a815..4d

Re: [Qemu-devel] [PULL for-2.4 0/4] input: fixes for 2.4

2015-07-16 Thread Gerd Hoffmann
Hi, > I'm afraid this doesn't build for Windows: > > In file included from > /home/petmay01/linaro/qemu-for-merges/hw/input/virtio-input.c:13: > /home/petmay01/linaro/qemu-for-merges/include/standard-headers/linux/input.h:890:1: > error: "SW_MAX" redefined > In file included from > /usr/lib/gcc

Re: [Qemu-devel] [PATCH RFC 9/9] tcg: update README about size changing ops

2015-07-16 Thread Richard Henderson
On 07/15/2015 12:03 PM, Aurelien Jarno wrote: +These ops are all optional in that case they are implemented as mov. +This is to allow some optimizations if the target maintains registers +zero or sign extended. For example a MIPS64 CPU requires that all +32-bit values are stored sign-extended in

Re: [Qemu-devel] [PATCH RFC 8/9] tcg/optimize: do not simplify size changing moves

2015-07-16 Thread Richard Henderson
On 07/15/2015 12:03 PM, Aurelien Jarno wrote: Now that we have real size changing ops, we don't need to marked high bits of the destination as garbage. The goal of the optimizer is to predict the value of the temps (and not of the registers) and do simplifications when possible. The problem there

Re: [Qemu-devel] [virtio guest] vring_need_event() from virtqueue_kick_prepare()

2015-07-16 Thread Catalin Vasile
Do you mean vhost_net - old kernel, qemu - latest, guest - latest? On Thu, Jul 16, 2015 at 7:33 PM, Stefan Hajnoczi wrote: > On Thu, Jul 16, 2015 at 1:54 PM, Catalin Vasile > wrote: >> Both. The compiled kernel was common for both. > > Does vhost_net work with the old kernel + new QEMU combo? >

Re: [Qemu-devel] [PATCH RFC 7/9] tcg: replace ext/u_i32_i64 by a mov when not implemented

2015-07-16 Thread Richard Henderson
On 07/15/2015 12:03 PM, Aurelien Jarno wrote: When ext_i32_i64 and extu_i32_i64 ops are not implemented, this means that the register is already properly zero/sign extended, so we can simply replace it by a mov. In practice it means at least one of the two ops should always be implemented on 64-

Re: [Qemu-devel] [PATCH RFC 4/9] tcg/optimize: add optimizations for ext_i32_i64 and extu_i32_i64 ops

2015-07-16 Thread Richard Henderson
On 07/15/2015 12:03 PM, Aurelien Jarno wrote: They behave the same as ext32s_i64 and ext32u_i64 from the constant folding and zero propagation point of view, except that they can't be replaced by a mov, so we don't compute the affected value. Cc: Paolo Bonzini Cc: Richard Henderson Signed-off-by

Re: [Qemu-devel] [PATCH RFC 3/9] tcg: implement real ext_i32_i64 and extu_i32_i64 ops

2015-07-16 Thread Richard Henderson
On 07/15/2015 12:03 PM, Aurelien Jarno wrote: Implement optional but real ext_i32_i64 and extu_i32_i64 ops. When implemented, these ensure that a 32-bit value is always converted to a 64-bit value and not propagated through the register allocator or the optimizer. Cc: Paolo Bonzini Cc: Richard H

Re: [Qemu-devel] [PATCH RFC 2/9] tcg: don't abuse TCG type in tcg_gen_trunc_shr_i64_i32

2015-07-16 Thread Richard Henderson
On 07/15/2015 12:03 PM, Aurelien Jarno wrote: The tcg_gen_trunc_shr_i64_i32 function takes a 64-bit argument and returns a 32-bit value. Directly call tcg_gen_op3 with the correct types instead of calling tcg_gen_op3i_i32 and abusing the TCG types. Cc: Paolo Bonzini Cc: Richard Henderson Signed-

Re: [Qemu-devel] [PATCH RFC 1/9] tcg: rename trunc_shr_i32 into trunc_shr_i64_i32

2015-07-16 Thread Richard Henderson
On 07/15/2015 12:03 PM, Aurelien Jarno wrote: The op is sometimes named trunc_shr_i32 and sometimes trunc_shr_i64_i32, and the name in the README doesn't match the name offered to the frontends. Always use the long name to make it clear it is a size changing op. Cc: Paolo Bonzini Cc: Richard He

Re: [Qemu-devel] [PATCH 2/2] tcg/i386: Reserve register for guest_base if a segment isn't available

2015-07-16 Thread Richard Henderson
On 07/17/2015 02:33 AM, Peter Maydell wrote: On 16 July 2015 at 22:25, Richard Henderson wrote: This saves 2 insns and 10 bytes from the implementation of each memory operation. Do we have an idea of which platforms/configs don't let us have a segment register for guest_base? We've only bot

Re: [Qemu-devel] [RFC PATCH qemu v3 4/4] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-07-16 Thread David Gibson
On Thu, Jul 16, 2015 at 08:44:59AM -0600, Alex Williamson wrote: > On Thu, 2015-07-16 at 15:11 +1000, David Gibson wrote: > > On Tue, Jul 14, 2015 at 10:21:54PM +1000, Alexey Kardashevskiy wrote: > > > This makes use of the new "memory registering" feature. The idea is > > > to provide the userspac

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-16 Thread Paolo Bonzini
On 16/07/2015 21:05, Richard W.M. Jones wrote: > > Sorry to spoil things, but I'm still seeing this bug, although it is > now a lot less frequent with your patch. I would estimate it happens > more often than 1 in 5 runs with qemu.git, and probably 1 in 200 runs > with qemu.git + the v2 patch s

Re: [Qemu-devel] [PATCH v2 3/3] AioContext: fix broken ctx->dispatching optimization

2015-07-16 Thread Paolo Bonzini
On 16/07/2015 11:56, Paolo Bonzini wrote: > @@ -286,13 +283,15 @@ bool aio_poll(AioContext *ctx, bool blocking) > npfd = 0; > ctx->walking_handlers--; > > +if (blocking) { > +atomic_sub(&ctx->notify_me, 2); > +} > + I kept this place for subtracting notify_me because

Re: [Qemu-devel] [PATCH v2 3/3] AioContext: fix broken ctx->dispatching optimization

2015-07-16 Thread Paolo Bonzini
On 17/07/2015 04:25, Fam Zheng wrote: > What if aio_notify happens after the previous aio_dispatch() but before the > next necessary atomic_add? The aio_notify would still skip the > event_notifier_set(), and the next ppoll() will not return. For example: > > Thread A

Re: [Qemu-devel] [PATCH v4 1/1] vhost user: add support of live migration

2015-07-16 Thread Paolo Bonzini
On 17/07/2015 02:19, Marc-André Lureau wrote: >>> >> How does vhost-user do this? I can see this patch providing enough >>> >> support for *non*live migration. However, it cannot be enough for live >>> >> migration unless I'm missing something obvious. >>> >> >>> >> Paolo >> > >> > Agree. vhost

Re: [Qemu-devel] [PATCH v2 3/3] AioContext: fix broken ctx->dispatching optimization

2015-07-16 Thread Fam Zheng
On Thu, 07/16 11:56, Paolo Bonzini wrote: > diff --git a/aio-posix.c b/aio-posix.c > index 4abec38..268d14d 100644 > --- a/aio-posix.c > +++ b/aio-posix.c > @@ -233,26 +233,23 @@ static void add_pollfd(AioHandler *node) > bool aio_poll(AioContext *ctx, bool blocking) > { > AioHandler *node;

Re: [Qemu-devel] Commit 812c1057f, Handle G_IO_HUP in tcp_chr_read for tcp chardev, broke CloudStack

2015-07-16 Thread Paolo Bonzini
On 17/07/2015 00:51, Nils Carlson wrote: > > The commit 812c1057f, Handle G_IO_HUP in tcp_chr_read for tcp chardev, > broke CloudStack. CloudStack was relying on fire-and-forget style > messaging across a unix socket to the VM. Because the host "fires" the > message and then closes the socket a

[Qemu-devel] [PATCH v3] more check for replaced node

2015-07-16 Thread Wen Congyang
We use mirror+replace to fix quorum's broken child. bs/s->common.bs is quorum, and to_replace is the broken child. The new child is target_bs. Without this patch, the replace node can be any node, and it can be top BDS with BB, or another quorum's child. We just check if the broken child is part of

Re: [Qemu-devel] [PATCH 2/2] tcg/i386: Reserve register for guest_base if a segment isn't available

2015-07-16 Thread Peter Maydell
On 16 July 2015 at 22:25, Richard Henderson wrote: > This saves 2 insns and 10 bytes from the implementation of > each memory operation. Do we have an idea of which platforms/configs don't let us have a segment register for guest_base? thanks -- PMM

Re: [Qemu-devel] [PATCH v2] more check for replaced node

2015-07-16 Thread Wen Congyang
On 07/15/2015 11:05 AM, Fam Zheng wrote: > On Wed, 07/15 09:41, Wen Congyang wrote: >> We use mirror+replace to fix quorum's broken child. bs/s->common.bs >> is quorum, and to_replace is the broken child. The new child is target_bs. >> Without this patch, the replace node can be any node, and it ca

Re: [Qemu-devel] [PATCH v2] more check for replaced node

2015-07-16 Thread Wen Congyang
On 07/16/2015 09:36 PM, Stefan Hajnoczi wrote: > On Wed, Jul 15, 2015 at 11:22:52AM +0800, Wen Congyang wrote: >> On 07/15/2015 11:05 AM, Fam Zheng wrote: >>> On Wed, 07/15 09:41, Wen Congyang wrote: We use mirror+replace to fix quorum's broken child. bs/s->common.bs is quorum, and to_rep

[Qemu-devel] [ANNOUNCE] QEMU 2.4.0-rc1 is now available

2015-07-16 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 2.4 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.4.0-rc1.tar.bz2 You can help imp

Re: [Qemu-devel] [PATCH v4 0/1] Add live migration for vhost user

2015-07-16 Thread Marc-André Lureau
Hi Thibaut On Fri, Jun 26, 2015 at 11:22 AM, Thibaut Collet wrote: > v3->v4 > 1. The first patch is updated by: >- removing the warning trace >- setting the error trace inside a static bool flag to only print this once >- removing the vhost_net_inject_rarp function (no more useful) >

Re: [Qemu-devel] [PATCH v4 1/1] vhost user: add support of live migration

2015-07-16 Thread Marc-André Lureau
Hi On Mon, Jul 13, 2015 at 4:27 AM, Linhaifeng wrote: >> When a packet is received by vhost-user, the vhost-user writes the >> packet in guest memory. QEMU must then copy that page of guest memory >> from source to destination; it uses a dirty bitmap for this purpose. >> >> How does vhost-user d

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-16 Thread Paolo Bonzini
On 17/07/2015 00:06, Paolo Bonzini wrote: > > > On 16/07/2015 21:05, Richard W.M. Jones wrote: >> Sorry to spoil things, but I'm still seeing this bug, although it is >> now a lot less frequent with your patch. I would estimate it happens >> more often than 1 in 5 runs with qemu.git, and proba

[Qemu-devel] Commit 812c1057f, Handle G_IO_HUP in tcp_chr_read for tcp chardev, broke CloudStack

2015-07-16 Thread Nils Carlson
Hi, The commit 812c1057f, Handle G_IO_HUP in tcp_chr_read for tcp chardev, broke CloudStack. CloudStack was relying on fire-and-forget style messaging across a unix socket to the VM. Because the host "fires" the message and then closes the socket a HUP is present on the line when the VM start

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-16 Thread Paolo Bonzini
On 16/07/2015 21:05, Richard W.M. Jones wrote: > Sorry to spoil things, but I'm still seeing this bug, although it is > now a lot less frequent with your patch. I would estimate it happens > more often than 1 in 5 runs with qemu.git, and probably 1 in 200 runs > with qemu.git + the v2 patch seri

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2015-07-16 Thread Brendan Dolan-Gavitt
The initial bluescreen is caused because of unsupported CPU feature bits (the DE flag, specifically). The experimental patch Clemens mentioned is here: http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg01412.html Past that, however, there is a bug in QEMU's self-modifying code support that

Re: [Qemu-devel] [PATCH v2 00/13] tcg/sparc v8plus code generation

2015-07-16 Thread Richard Henderson
On 07/15/2015 09:54 PM, Aurelien Jarno wrote: While I understand why we need the new trunc_shr_i32 opcode for MIPS64 (the 32-bit values must be kept sign-extended), I currently fail to see why it is needed for SPARC. As far as I recall, it improves code for extracting high parts of 64-bit quan

[Qemu-devel] [PATCH v13 18/19] i.MX: Add qtest support for I2C device emulator.

2015-07-16 Thread Jean-Christophe Dubois
This is using a ds1338 RTC chip on the I2C bus. This RTC chip is not present on the real 3DS PDK board. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * use a common header file for I2C regs definition Changes since v3: * rework GP

[Qemu-devel] [PATCH 1/2] tcg/i386: Extend addresses for 32-bit guests

2015-07-16 Thread Richard Henderson
Removing the ??? comment explaining why it (mostly) worked. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 105 +++--- 1 file changed, 65 insertions(+), 40 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index ff4

[Qemu-devel] [PATCH for-2.4 0/2] tcg/i386 address zero-extension

2015-07-16 Thread Richard Henderson
This is an alternative to the patch that Aurelien posted yesterday. r~ Richard Henderson (2): tcg/i386: Extend addresses for 32-bit guests tcg/i386: Reserve register for guest_base if a segment isn't available tcg/i386/tcg-target.c | 163 --

[Qemu-devel] [PATCH v13 13/19] i.MX: KZM now uses the standalone i.MX31 SOC support

2015-07-16 Thread Jean-Christophe Dubois
Tested by booting a minimal Linux system on the emulated platform Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4

[Qemu-devel] [PATCH v13 14/19] i.MX: Add I2C controller emulator

2015-07-16 Thread Jean-Christophe Dubois
The slave mode is not implemented. Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * none Changes since v2: * use QOM cast * reworked debug printf * use CamelCase for state type * warn with qemu_log_mask(LOG_GUEST_ERROR) or qemu_l

[Qemu-devel] [PATCH v13 15/19] i.MX: Add FEC Ethernet Emulator

2015-07-16 Thread Jean-Christophe Dubois
This is based on mcf_fec.c FEC implementation for Coldfire * A generic PHY was added (borrowwed from LAN9118) * The buffer management is also modified as buffers are slightly different between Coldfire and i.MX Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Ch

[Qemu-devel] [PATCH v13 12/19] i.MX: Add SOC support for i.MX31

2015-07-16 Thread Jean-Christophe Dubois
For now we support the following devices: * CPU: ARM1136 * Interrupt Controller: AVIC * CCM * UART x 2 * EPIT x 2 * GPT Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Ch

Re: [Qemu-devel] [PATCH for-2.4] tcg/i386: ignore high bits for user mode 32-bit qemu_ld/st

2015-07-16 Thread Richard Henderson
On 07/15/2015 02:55 PM, Aurelien Jarno wrote: Fix that by either using the ADDR32 prefix (in case GUEST_BASE == 0 or a segment register is in use), or by doing an explicit zero-extension. The zero-extension can be done in place as we know the registers holds a 32-bit value. I'd prefer not to do

[Qemu-devel] [PATCH v13 07/19] i.MX: Fix Coding style for CCM emulator

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present

[Qemu-devel] [PATCH 2/2] tcg/i386: Reserve register for guest_base if a segment isn't available

2015-07-16 Thread Richard Henderson
This saves 2 insns and 10 bytes from the implementation of each memory operation. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 120 +++--- 1 file changed, 56 insertions(+), 64 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/

[Qemu-devel] [PATCH v13 16/19] i.MX: Add SOC support for i.MX25

2015-07-16 Thread Jean-Christophe Dubois
For now we support the following devices: * CPU: ARM926 * Interrupt Controller: AVIC * CCM * UART x 5 * EPIT x 2 * GPT x 4 * FEC * I2C x 3 Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2:

[Qemu-devel] [PATCH v13 11/19] i.MX: Fix Coding style for GPT emulator

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Cha

[Qemu-devel] [PATCH v13 09/19] i.MX: Fix Coding style for EPIT emulator

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5

[Qemu-devel] [PATCH v13 19/19] i.MX: Adding i2C devices to i.MX31 SOC

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Changes since v6: * not pre

[Qemu-devel] [PATCH v13 05/19] i.MX: Fix Coding style for AVIC emulator.

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5

[Qemu-devel] [PATCH v13 17/19] i.MX: Add the i.MX25 PDK plateform

2015-07-16 Thread Jean-Christophe Dubois
Tested by booting a minimal Linux system on the emulated platform Tested by booting the Xvisor hyprvisor on the emulated platform Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Added a ds1338 I2C device for qtest purpose. Changes since v2: * none Changes since v3

[Qemu-devel] [PATCH v13 04/19] i.MX: Split AVIC emulator in a header file and a source file

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5

[Qemu-devel] [PATCH v13 08/19] i.MX: Split EPIT emulator in a header file and a source file

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not pre

[Qemu-devel] [PATCH v13 06/19] i.MX: Split CCM emulator in a header file and a source file

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5

[Qemu-devel] [PATCH v13 10/19] i.MX: Split GPT emulator in a header file and a source file

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5 Ch

[Qemu-devel] [PATCH v13 02/19] i.MX: Move serial initialization to init/realize of DeviceClass.

2015-07-16 Thread Jean-Christophe Dubois
Move constructor to DeviceClass methods * imx_serial_init * imx_serial_realize imx32_serial_properties is renamed to imx_serial_properties. Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not pres

[Qemu-devel] [PATCH v13 01/19] i.MX: Split UART emulator in a header file and a source file

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5

[Qemu-devel] [PATCH v13 03/19] i.MX:Fix Coding style for UART emulator.

2015-07-16 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * not present on v1 Changes since v2: * not present on v2 Changes since v3: * not present on v3 Changes since v4: * not present on v4 Changes since v5: * not present on v5

[Qemu-devel] [PATCH v13 00/19] i.MX: Add i.MX25 support through the PDK evaluation board

2015-07-16 Thread Jean-Christophe Dubois
This series of patches add the support for the i.MX25 processor through the Freescale PDK evaluation board. For now a limited set of devices is supported. * GPT timers (from i.MX31) * EPIT timers (from i.MX31) * Serial ports (from i.MX31) * Ethernet FEC port * I2C controller I

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2015-07-16 Thread Nenad Cuturic
I used Rob Schultz's binary to convert the image-files and it is working now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1354167 Title: On VM restart: Could not open 'poppy.qcow2': Could not rea

Re: [Qemu-devel] [PATCH] hostmem: Fix qemu_opt_get_bool() crash in host_memory_backend_init()

2015-07-16 Thread Igor Mammedov
On Thu, 16 Jul 2015 17:39:17 -0300 Eduardo Habkost wrote: > This fixes the following crash, introduced by commit > 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6: > > $ gdb --args qemu-system-x86_64 -machine pc,mem-merge=off -object > memory-backend-ram,id=ram-node0,size=1024 [...] > Program recei

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2015-07-16 Thread Nenad Cuturic
I've got the same problem again while release-upgrading to 14.04.2 but this time I was careful to shutdown vm's and disable autostart prior to release-upgrade to prevent anything happening in background. Nevertheless after the upgrade one vm is not starting. I'll repeat the procedure about conve

[Qemu-devel] [PATCH v2] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-16 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. This patch fixes that issue by testing each physical device first before using it in QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuck

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-16 Thread Gabriel L. Somlo
On Thu, Jul 16, 2015 at 01:27:15PM -0600, Eric Blake wrote: > On 07/15/2015 06:43 PM, Gabriel L. Somlo wrote: > > > > > OK, so I replaced my port i/o with mmio equivalents: > > > > -#define FW_CFG_PORT_CTL 0x510 > > +#define FW_CFG_PORT_CTL (void *)0x09020008 > > > > -#define FW_CFG_PORT_DATA

[Qemu-devel] [PATCH] hostmem: Fix qemu_opt_get_bool() crash in host_memory_backend_init()

2015-07-16 Thread Eduardo Habkost
This fixes the following crash, introduced by commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6: $ gdb --args qemu-system-x86_64 -machine pc,mem-merge=off -object memory-backend-ram,id=ram-node0,size=1024 [...] Program received signal SIGABRT, Aborted. (gdb) bt #0 0x7253b8c7 in r

Re: [Qemu-devel] [RFC v3 0/8] Fix QEMU crash during memory hotplug with vhost=on

2015-07-16 Thread Andrey Korolyov
On Wed, Jul 15, 2015 at 7:46 PM, Andrey Korolyov wrote: > On Wed, Jul 15, 2015 at 7:08 PM, Michael S. Tsirkin wrote: >> On Wed, Jul 15, 2015 at 06:26:03PM +0300, Andrey Korolyov wrote: >>> On Wed, Jul 15, 2015 at 6:18 PM, Igor Mammedov wrote: >>> > On Thu, 9 Jul 2015 20:04:35 +0300 >>> > Andrey

[Qemu-devel] [PATCH v1 1/2] MAINTAINERS: Update Xilinx Maintainership

2015-07-16 Thread Alistair Francis
Peter C is leaving Xilinx, so update the maintainer list to point to Alistair and Edgar from Xilinx and Peter's personal email address. Signed-off-by: Alistair Francis --- MAINTAINERS | 19 ++- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINT

[Qemu-devel] [PATCH v1 0/2] MAINTAINERS: Update the MAINTAINERS file

2015-07-16 Thread Alistair Francis
Two simple patches that update the Xilinx related contacts in the maintainer file and add ZynqMP to the file. Alistair Francis (2): MAINTAINERS: Update Xilinx Maintainership MAINTAINERS: Add ZynqMP to MAINTAINERS file MAINTAINERS | 27 ++- 1 files changed, 22 insert

[Qemu-devel] [PATCH v1 2/2] MAINTAINERS: Add ZynqMP to MAINTAINERS file

2015-07-16 Thread Alistair Francis
Add the Xilinx ZynqMP SoC and EP108 machine to the maintainers file. Signed-off-by: Alistair Francis --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8e644c7..a4aa6f4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -35

[Qemu-devel] [PATCH v2 4/6] hw/cpu/{a15mpcore, a9mpcore}: enable TrustZone in GIC if it is enabled in CPUs

2015-07-16 Thread Peter Maydell
If the A9 and A15 CPUs which we're creating the peripherals for have TrustZone (EL3) enabled, then also enable it in the GIC we create. Signed-off-by: Peter Maydell --- hw/cpu/a15mpcore.c | 13 + hw/cpu/a9mpcore.c | 11 +++ 2 files changed, 24 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH v2 1/6] qom: Add recursive version of object_child_for_each

2015-07-16 Thread Peter Maydell
From: Peter Crosthwaite Useful for iterating through an entire QOM subtree. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- include/qom/object.h | 15 +++ qom/object.c | 25 ++--- 2 files changed, 37 inserti

[Qemu-devel] [PATCH v2 3/6] hw/intc/arm_gic_common: Configure IRQs as NS if doing direct NS kernel boot

2015-07-16 Thread Peter Maydell
If we directly boot a kernel in NonSecure on a system where the GIC supports the security extensions then we must cause the GIC to configure its interrupts into group 1 (NonSecure) rather than the usual group 0, and with their initial priority set to the highest NonSecure priority rather than the u

[Qemu-devel] [PATCH v2 2/6] hw/arm: new interface for devices which need to behave differently for kernel boot

2015-07-16 Thread Peter Maydell
For ARM we have a little minimalist bootloader in hw/arm/boot.c which takes the place of firmware if we're directly booting a Linux kernel. Unfortunately a few devices need special case handling in this situation to do the initialization which on real hardware would be done by firmware. (In particu

[Qemu-devel] [PATCH v2 6/6] hw/arm/virt: Enable TZ extensions on the GIC if we are using them

2015-07-16 Thread Peter Maydell
If we're creating a board with support for TrustZone, then enable it on the GIC model as well as on the CPUs. Signed-off-by: Peter Maydell --- hw/arm/virt.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 2bcf565..fdfa91b 100644 ---

[Qemu-devel] [PATCH v2 5/6] hw/arm/virt: Default to not providing TrustZone support

2015-07-16 Thread Peter Maydell
Switch the default for the 'virt' board to not providing TrustZone support in either the CPU or the GIC. This is primarily for the benefit of UEFI, which currently assumes there is no TrustZone support, and does not set the GIC up correctly if it is TZ-aware. It also means the board is consistent a

[Qemu-devel] [PATCH v2 0/6] ARM: enable TZ in the GIC

2015-07-16 Thread Peter Maydell
This patchset enables the TZ support in the GIC for the systems where we enable TZ support in the CPU. In practice that means just the "virt" and "vexpress" boards, since all the others disable the CPU TZ support. Andreas: I've cc'd you because of Peter C's patch to add object_child_foreach_recurs

Re: [Qemu-devel] [Qemu-block] [PATCH] raw-posix.c: Make physical devices usable in QEMU

2015-07-16 Thread Programmingkid
On Jul 16, 2015, at 3:43 PM, Stefan Hajnoczi wrote: > On Thu, Jul 16, 2015 at 6:26 PM, Programmingkid > wrote: >> >> On Jul 16, 2015, at 9:19 AM, Stefan Hajnoczi wrote: >> >>> On Thu, Jul 09, 2015 at 10:02:26AM -0400, Programmingkid wrote: On Jul 9, 2015, at 6:52 AM, Stefan Hajnoczi

Re: [Qemu-devel] [Qemu-block] [PATCH] raw-posix.c: Make physical devices usable in QEMU

2015-07-16 Thread Stefan Hajnoczi
On Thu, Jul 16, 2015 at 6:26 PM, Programmingkid wrote: > > On Jul 16, 2015, at 9:19 AM, Stefan Hajnoczi wrote: > >> On Thu, Jul 09, 2015 at 10:02:26AM -0400, Programmingkid wrote: >>> >>> On Jul 9, 2015, at 6:52 AM, Stefan Hajnoczi wrote: >>> On Tue, Jul 07, 2015 at 01:33:23PM -0400, Programm

Re: [Qemu-devel] [PULL v2 0/8] KVM, memory API, crypto, Coverity fixes for 2.4.0-rc1

2015-07-16 Thread Peter Maydell
On 16 July 2015 at 19:02, Paolo Bonzini wrote: > The following changes since commit 2d5ee9e7a7dd495d233cf9613a865f63f88e3375: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150716' into > staging (2015-07-16 10:40:23 +0100) > > are available in the

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-16 Thread Eric Blake
On 07/15/2015 06:43 PM, Gabriel L. Somlo wrote: > > OK, so I replaced my port i/o with mmio equivalents: > > -#define FW_CFG_PORT_CTL 0x510 > +#define FW_CFG_PORT_CTL (void *)0x09020008 > > -#define FW_CFG_PORT_DATA 0x511 > +#define FW_CFG_PORT_DATA (void *)0x0902 Under-parenthesized; yo

Re: [Qemu-devel] [PULL 00/11] RCU, KVM, memory API, crypto, Coverity fixes for 2.4.0-rc1

2015-07-16 Thread Peter Maydell
On 16 July 2015 at 18:44, Peter Maydell wrote: > On 16 July 2015 at 17:55, Paolo Bonzini wrote: >> The following changes since commit 6169b60285fe1ff730d840a49527e721bfb30899: >> >> Update version for v2.4.0-rc0 release (2015-07-09 17:56:56 +0100) >> >> are available in the git repository at: >

Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me

2015-07-16 Thread Richard W.M. Jones
Sorry to spoil things, but I'm still seeing this bug, although it is now a lot less frequent with your patch. I would estimate it happens more often than 1 in 5 runs with qemu.git, and probably 1 in 200 runs with qemu.git + the v2 patch series. It's the exact same hang in both cases. Is it poss

[Qemu-devel] [PATCH 1/1] virtio-mmio: return the max queue num of virtio-mmio with initial value

2015-07-16 Thread Wei Huang
Recently we found that virtio-console devices consumes lots AArch64 guest memory, roughly 1GB with 8 devices. After debugging, it turns out that lots of factors contribute to this problem: i) guest PAGE_SIZE=64KB, ii) virtio-mmio based devices, and iii) virtio-console device. Here is the detailed a

[Qemu-devel] [PULL 7/8] crypto: fix build with nettle >= 3.0.0

2015-07-16 Thread Paolo Bonzini
From: Radim Krčmář In nettle 3, cbc_encrypt() accepts 'nettle_cipher_func' instead of 'nettle_crypt_func' and these two differ in 'const' qualifier of the first argument. The build fails with: In file included from crypto/cipher.c:71:0: ./crypto/cipher-nettle.c: In function ‘qcrypto_cipher_

[Qemu-devel] [PULL 4/8] arm/xlnx-zynqmp: fix memory leak

2015-07-16 Thread Paolo Bonzini
From: Gonglei fix CID 1311372. Signed-off-by: Gonglei Message-Id: <1436489490-236-4-git-send-email-arei.gong...@huawei.com> Signed-off-by: Paolo Bonzini --- hw/arm/xlnx-zynqmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 5e72078..62

[Qemu-devel] [PULL 6/8] memory: fix refcount leak in memory_region_present

2015-07-16 Thread Paolo Bonzini
memory_region_present() leaks a reference to a MemoryRegion in the case "mr == container". While fixing it, avoid reference counting altogether for memory_region_present(), by using RCU only. The return value could in principle be already invalid immediately after memory_region_present returns, b

[Qemu-devel] [PULL 3/8] ppc/spapr_drc: fix memory leak

2015-07-16 Thread Paolo Bonzini
From: Gonglei fix CID 1311373. Signed-off-by: Gonglei Message-Id: <1436489490-236-3-git-send-email-arei.gong...@huawei.com> Signed-off-by: Paolo Bonzini --- hw/ppc/spapr_drc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index ef98538..ee87432 10

[Qemu-devel] [PULL 2/8] mips/kvm: Sign extend registers written to KVM

2015-07-16 Thread Paolo Bonzini
From: James Hogan In case we're running on a 64-bit host, be sure to sign extend the general purpose registers and hi/lo/pc before writing them to KVM, so as to take advantage of MIPS32/MIPS64 compatibility. Signed-off-by: James Hogan Cc: Paolo Bonzini Cc: Leon Alrae Cc: Aurelien Jarno Cc: k

[Qemu-devel] [PULL 8/8] crypto: avoid undefined behavior in nettle calls

2015-07-16 Thread Paolo Bonzini
From: Radim Krčmář Calling a function pointer that was cast from an incompatible function results in undefined behavior. 'void *' isn't compatible with 'struct XXX *', so we can't cast to nettle_cipher_func, but have to provide a wrapper. (Conversion from 'void *' to 'struct XXX *' might requir

[Qemu-devel] [PULL 5/8] RDMA: Fix error exits

2015-07-16 Thread Paolo Bonzini
From: "Dr. David Alan Gilbert" The error checks I added used 'break' after the error, but I'm in a switch inside the while loop, so they need to be 'goto out'. Spotted by coverity; entries 1311368 and 1311369 Fixes: afcddefd Signed-off-by: Dr. David Alan Gilbert Message-Id: <1436555332-19076-

[Qemu-devel] [PULL v2 0/8] KVM, memory API, crypto, Coverity fixes for 2.4.0-rc1

2015-07-16 Thread Paolo Bonzini
The following changes since commit 2d5ee9e7a7dd495d233cf9613a865f63f88e3375: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150716' into staging (2015-07-16 10:40:23 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[Qemu-devel] [PULL 1/8] mips/kvm: Fix Big endian 32-bit register access

2015-07-16 Thread Paolo Bonzini
From: James Hogan Fix access to 32-bit registers on big endian targets. The pointer passed to the kernel must be for the actual 32-bit value, not a temporary 64-bit value, otherwise on big endian systems the kernel will only interpret the upper half. Signed-off-by: James Hogan Cc: Paolo Bonzini

Re: [Qemu-devel] [PATCH 3/3] PAM: make PAM emulation closer to documentation

2015-07-16 Thread Paolo Bonzini
On 16/07/2015 16:41, Ефимов Василий wrote: > The main problem is rendering memory tree to FlatView. I don't believe it's necessary to render a memory tree to the FlatView. You can use existing AddressSpaces. >> +/* Read from RAM and write to PCI */ >> +memory_region_init_io(&pam->regio

Re: [Qemu-devel] [PULL 00/11] RCU, KVM, memory API, crypto, Coverity fixes for 2.4.0-rc1

2015-07-16 Thread Peter Maydell
On 16 July 2015 at 17:55, Paolo Bonzini wrote: > The following changes since commit 6169b60285fe1ff730d840a49527e721bfb30899: > > Update version for v2.4.0-rc0 release (2015-07-09 17:56:56 +0100) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstrea

Re: [Qemu-devel] [PULL for-2.4 0/4] input: fixes for 2.4

2015-07-16 Thread Peter Maydell
On 16 July 2015 at 16:38, Gerd Hoffmann wrote: > Hi, > > A few input fixes for 2.4. Also enable virtio-input builds on > non-linux hosts after fixing up the ioctl include. > > please pull, > Gerd > > The following changes since commit f3a1b5068cea303a55e2a21a97e66d057eaae638: > > Merge remo

Re: [Qemu-devel] [PULL for-2.4 0/1] qxl: allow to specify head limit to qxl driver

2015-07-16 Thread Peter Maydell
95d233cf9613a865f63f88e3375: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150716' into > staging (2015-07-16 10:40:23 +0100) > > are available in the git repository at: > > > git://anongit.freedesktop.org/spice/qemu

Re: [Qemu-devel] [Qemu-block] [PATCH] raw-posix.c: Make physical devices usable in QEMU

2015-07-16 Thread Programmingkid
On Jul 16, 2015, at 9:19 AM, Stefan Hajnoczi wrote: > On Thu, Jul 09, 2015 at 10:02:26AM -0400, Programmingkid wrote: >> >> On Jul 9, 2015, at 6:52 AM, Stefan Hajnoczi wrote: >> >>> On Tue, Jul 07, 2015 at 01:33:23PM -0400, Programmingkid wrote: Make physical devices like a USB flash drive

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-16 Thread Paolo Bonzini
On 16/07/2015 14:47, Michael S. Tsirkin wrote: > I think for 2.4 it's a good idea to avoid enabling modern interface > by default. Therefore, for 2.4 we can keep scsi enabled unless modern > is requested by user. I agree. > I am also fine with just doing > > if (modern && scsi) >

[Qemu-devel] [PULL 10/11] crypto: fix build with nettle >= 3.0.0

2015-07-16 Thread Paolo Bonzini
From: Radim Krčmář In nettle 3, cbc_encrypt() accepts 'nettle_cipher_func' instead of 'nettle_crypt_func' and these two differ in 'const' qualifier of the first argument. The build fails with: In file included from crypto/cipher.c:71:0: ./crypto/cipher-nettle.c: In function ‘qcrypto_cipher_

[Qemu-devel] [PULL 07/11] rcu: actually register threads that have RCU read-side critical sections

2015-07-16 Thread Paolo Bonzini
Otherwise, grace periods are detected too early! Signed-off-by: Paolo Bonzini --- cpus.c| 6 ++ iothread.c| 3 +++ migration/migration.c | 3 +++ tests/test-rcu-list.c | 2 ++ util/rcu.c| 2 ++ 5 files changed, 16 insertions(+) diff --git a/cpus.c b/c

[Qemu-devel] [PULL 09/11] memory: fix refcount leak in memory_region_present

2015-07-16 Thread Paolo Bonzini
memory_region_present() leaks a reference to a MemoryRegion in the case "mr == container". While fixing it, avoid reference counting altogether for memory_region_present(), by using RCU only. The return value could in principle be already invalid immediately after memory_region_present returns, b

  1   2   3   >