Re: [Qemu-devel] [PATCH for-2.5 05/10] tcg: rename trunc_shr_i32 into trunc_shr_i64_i32

2015-07-30 Thread Alex Bennée
Aurelien Jarno writes: > The op is sometimes named trunc_shr_i32 and sometimes trunc_shr_i64_i32, > and the name in the README doesn't match the name offered to the > frontends. I was tempted to suggest just naming it shr_i64_i32 as the truncation is implicit and the slightly shorter name doesn

Re: [Qemu-devel] [ARM SMBIOS V1 PATCH 6/6] smbios: implement smbios support for mach-virt

2015-07-30 Thread Wei Huang
On 07/30/2015 09:11 PM, Shannon Zhao wrote: > > > On 2015/7/28 14:00, Wei Huang wrote: >> This patch generates smbios tables for ARM mach-virt. Also add >> CONFIG_SMBIOS=y for ARM default config. >> >> Signed-off-by: Wei Huang >> --- >> default-configs/arm-softmmu.mak | 1 + >> hw/arm/virt.

Re: [Qemu-devel] [PATCH v2 8/9] netfilter: add a netbuffer filter

2015-07-30 Thread Jason Wang
On 07/31/2015 12:13 PM, Yang Hongyang wrote: > This filter is to buffer/release packets, this feature can be used > when using MicroCheckpointing, or other Remus like VM FT solutions, you > can also use it to simulate the network delay. > It has an interval option, if supplied, this filter will r

Re: [Qemu-devel] [PATCH v2 5/9] netfilter: hook packets before net queue send

2015-07-30 Thread Jason Wang
On 07/31/2015 12:13 PM, Yang Hongyang wrote: > Capture packets that will be sent. > > Signed-off-by: Yang Hongyang > --- > include/net/filter.h | 8 +++ > net/filter.c | 1 + > net/net.c| 67 > +++- > 3 files changed, 75

Re: [Qemu-devel] [PATCH v2 0/9] For QEMU 2.5: Add a netfilter object and netbuffer filter

2015-07-30 Thread Jason Wang
On 07/31/2015 12:13 PM, Yang Hongyang wrote: > This patch add a new object netfilter, capture all network packets. > Also implement a netbuffer based on this object. > the "buffer" netfilter could be used by VM FT solutions like > MicroCheckpointing, to buffer/release packets. Or to simulate > pa

[Qemu-devel] [PATCH v2 5/9] netfilter: hook packets before net queue send

2015-07-30 Thread Yang Hongyang
Capture packets that will be sent. Signed-off-by: Yang Hongyang --- include/net/filter.h | 8 +++ net/filter.c | 1 + net/net.c| 67 +++- 3 files changed, 75 insertions(+), 1 deletion(-) diff --git a/include/net/filter.h

[Qemu-devel] [PATCH v2 8/9] netfilter: add a netbuffer filter

2015-07-30 Thread Yang Hongyang
This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solutions, you can also use it to simulate the network delay. It has an interval option, if supplied, this filter will release packets by interval. Usage: -netdev tap,id=bn0

[Qemu-devel] [PATCH v2 9/9] filter/buffer: update command description and help

2015-07-30 Thread Yang Hongyang
now that we have a buffer netfilter, update the command description and help. Signed-off-by: Yang Hongyang CC: Luiz Capitulino CC: Markus Armbruster --- hmp-commands.hx | 2 +- qemu-options.hx | 5 - qmp-commands.hx | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hmp

[Qemu-devel] [PATCH v2 7/9] move out net queue structs define

2015-07-30 Thread Yang Hongyang
Signed-off-by: Yang Hongyang --- include/net/queue.h | 19 +++ net/queue.c | 19 --- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/include/net/queue.h b/include/net/queue.h index f10fab0..e139cc7 100644 --- a/include/net/queue.h +++ b/inc

[Qemu-devel] [PATCH v2 3/9] netfilter: add netfilter_{add|del} commands

2015-07-30 Thread Yang Hongyang
add netfilter_{add|del} commands This is mostly the same with netdev_{add|del} commands. Signed-off-by: Yang Hongyang CC: Luiz Capitulino CC: Markus Armbruster CC: Eric Blake --- hmp-commands.hx | 30 + hmp.c| 29 hmp.h

[Qemu-devel] [PATCH v2 6/9] net/queue: export qemu_net_queue_append_iov

2015-07-30 Thread Yang Hongyang
Signed-off-by: Yang Hongyang --- include/net/queue.h | 7 +++ net/queue.c | 12 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/net/queue.h b/include/net/queue.h index fc02b33..f10fab0 100644 --- a/include/net/queue.h +++ b/include/net/queue.h @@

[Qemu-devel] [PATCH v2 1/9] net: add a new object netfilter

2015-07-30 Thread Yang Hongyang
Add the framework for a new netfilter object and a new -netfilter CLI option as a basis for the following patches. Signed-off-by: Yang Hongyang CC: Paolo Bonzini CC: Eric Blake Reviewed-by: Thomas Huth --- include/net/filter.h| 15 +++ include/sysemu/sysemu.h | 1 + net/Makef

[Qemu-devel] [PATCH v2 4/9] net: add/remove filters from network backend

2015-07-30 Thread Yang Hongyang
add/remove filters from network backend Signed-off-by: Yang Hongyang --- include/net/net.h | 8 net/filter.c | 4 ++-- net/net.c | 38 ++ 3 files changed, 48 insertions(+), 2 deletions(-) diff --git a/include/net/net.h b/include/net/ne

[Qemu-devel] [PATCH v2 2/9] init/cleanup of netfilter object

2015-07-30 Thread Yang Hongyang
This is mostly the same with init/cleanup of netdev object. Signed-off-by: Yang Hongyang --- include/net/filter.h| 30 ++ include/qemu/typedefs.h | 1 + net/filter.c| 147 qapi-schema.json| 37 4 fi

[Qemu-devel] [PATCH v2 0/9] For QEMU 2.5: Add a netfilter object and netbuffer filter

2015-07-30 Thread Yang Hongyang
This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the "buffer" netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/release packets. Or to simulate packet delay. Most of the changes of v2 are from Jason's c

Re: [Qemu-devel] [ARM SMBIOS V1 PATCH 6/6] smbios: implement smbios support for mach-virt

2015-07-30 Thread Shannon Zhao
On 2015/7/28 14:00, Wei Huang wrote: > This patch generates smbios tables for ARM mach-virt. Also add > CONFIG_SMBIOS=y for ARM default config. > > Signed-off-by: Wei Huang > --- > default-configs/arm-softmmu.mak | 1 + > hw/arm/virt.c| 24 > incl

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread Yang Hongyang
On 07/31/2015 09:28 AM, zhanghailiang wrote: On 2015/7/31 9:08, Yang Hongyang wrote: On 07/31/2015 01:53 AM, Dr. David Alan Gilbert wrote: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: On 07/30/2015 09:59 PM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com)

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread zhanghailiang
On 2015/7/31 9:08, Yang Hongyang wrote: On 07/31/2015 01:53 AM, Dr. David Alan Gilbert wrote: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: On 07/30/2015 09:59 PM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/7/30 20:30, Dr. David Alan Gil

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread zhanghailiang
On 2015/7/31 1:53, Dr. David Alan Gilbert wrote: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: On 07/30/2015 09:59 PM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/7/30 20:30, Dr. David Alan Gilbert wrote: * Gonglei (arei.gong...@huawei.com)

Re: [Qemu-devel] [PATCH v5] hmp: add info iothreads command

2015-07-30 Thread Ting Wang
On 2015-7-31 0:05, Luiz Capitulino wrote: > On Fri, 26 Jun 2015 16:07:13 +0800 > Ting Wang wrote: > >> Make "info iothreads" available on the HMP monitor. >> >> For example, the results are as follows when executing qemu >> command with "-object iothread,id=iothread-1 -object >> iothread,id=ioth

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread Yang Hongyang
On 07/31/2015 01:53 AM, Dr. David Alan Gilbert wrote: * Yang Hongyang (yan...@cn.fujitsu.com) wrote: On 07/30/2015 09:59 PM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/7/30 20:30, Dr. David Alan Gilbert wrote: * Gonglei (arei.gong...@huaw

Re: [Qemu-devel] [PATCH RFC v2 07/47] qapi: Generate a nicer struct for flat unions

2015-07-30 Thread Eric Blake
On 07/30/2015 09:44 AM, Markus Armbruster wrote: which means that if we name any of the branches 'data' (that is, if 'data' is a member of the enum discriminator), things fail to compile. We could probably fix that by naming our dummy branch '_data'. >>> >>> I wonder whether member

[Qemu-devel] [RFC PATCH 12.6/47] qapi: Document shortcoming with union 'data' branch

2015-07-30 Thread Eric Blake
Add a FIXME to remind us to fully audit whether removing the 'void *data' branch of each qapi union type can be done safely. Signed-off-by: Eric Blake --- Another potential doc FIXME patch, this time based on 7/47 (https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg06101.html) scripts/qa

Re: [Qemu-devel] [PATCH RFC v2 29/47] qapi: Replace dirty is_c_ptr() by method c_null()

2015-07-30 Thread Eric Blake
On 07/30/2015 09:57 AM, Markus Armbruster wrote: >> For qmp_FOO(), this is a reasonable contract. But our very own >> generated code does not follow these rules: visit_type_FOO() can assign >> into *obj even when setting an error, if it encounters a parse error >> halfway through the struct, leavi

Re: [Qemu-devel] [PATCH] hw/pci-host/bonito: Avoid buffer overrun for bad LDMA/COP accesses

2015-07-30 Thread Peter Maydell
On 30 July 2015 at 23:02, Aurelien Jarno wrote: > On 2015-07-30 16:33, Peter Maydell wrote: >> The LDMA and COP memory regions represent four 32 bit registers >> each, but the memory regions themselves are 0x100 bytes large. >> Add guards to the read and write accessors so that bogus accesses >> b

[Qemu-devel] [RFC PATCH 12.5/47] qapi: Document that input visitor semantics are prone to leaks

2015-07-30 Thread Eric Blake
Most functions that can return a pointer or set an Error ** value are decent enough to guarantee a NULL return when reporting an error. Not so with our generated qapi visitor functions. If the caller is not careful to clean up partially-allocated objects on error, then the caller suffers a memory

Re: [Qemu-devel] [PATCH v13 00/19] i.MX: Add i.MX25 support through the PDK evaluation board

2015-07-30 Thread Peter Maydell
On 30 July 2015 at 22:36, Jean-Christophe DUBOIS wrote: > Is there any more work needed on this series? I was expecting Peter C to review this, but he might be busy just now, and I see he already reviewed most of the patches in the set anyway. It's on my todo list; I'll try to get to it tomorrow

[Qemu-devel] [PATCH 1/3] tcg/mips: fix TLB loading for BE host with 32-bit guests

2015-07-30 Thread Aurelien Jarno
For 32-bit guest, we load a 32-bit address from the TLB, so there is no need to compensate for the low or high part. This fixes 32-bit guests on big-endian hosts. Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/mips/tcg-target.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

[Qemu-devel] [PATCH 3/3] tcg/s390x: Mask TCGMemOp appropriately for indexing

2015-07-30 Thread Aurelien Jarno
Commit 2b7ec66f fixed TCGMemOp masking following the MO_AMASK addition, but two cases were forgotten in the TCG S390 backend. Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/s390/tcg-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/s390/tcg-target

[Qemu-devel] [PATCH 0/3] tcg: fixes for MIPS and S390 hosts

2015-07-30 Thread Aurelien Jarno
These are small fixes for MIPS and S390 hosts, found by testing various guests on these hosts. Aurelien Jarno (3): tcg/mips: fix TLB loading for BE host with 32-bit guests tcg/mips: Mask TCGMemOp appropriately for indexing tcg/s390x: Mask TCGMemOp appropriately for indexing tcg/mips/tcg-ta

[Qemu-devel] [PATCH 2/3] tcg/mips: Mask TCGMemOp appropriately for indexing

2015-07-30 Thread Aurelien Jarno
Commit 2b7ec66f fixed TCGMemOp masking following the MO_AMASK addition, but two cases were forgotten in the TCG MIPS backend. Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/mips/tcg-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/mips/tcg-target

Re: [Qemu-devel] [PATCH] hw/pci-host/bonito: Avoid buffer overrun for bad LDMA/COP accesses

2015-07-30 Thread Aurelien Jarno
On 2015-07-30 16:33, Peter Maydell wrote: > The LDMA and COP memory regions represent four 32 bit registers > each, but the memory regions themselves are 0x100 bytes large. > Add guards to the read and write accessors so that bogus accesses > beyond the four defined registers don't just run off the

Re: [Qemu-devel] The QEMU project has joined Software Freedom Conservancy

2015-07-30 Thread Bradley M. Kuhn
> On Thu, Jul 23, 2015 at 9:11 PM, Peter Maydell > wrote: >> I'm happy to be able to announce that the QEMU project >> has joined Software Freedom Conservancy. Stefan Hajnoczi wrote on Friday, 24 July: > I added a wiki page listing the Leadership Committee members and > explaining the relationsh

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-30 Thread Eric Blake
On 07/30/2015 10:36 AM, Eric Blake wrote: > On 07/30/2015 09:53 AM, Markus Armbruster wrote: > >>> Or, we could ditch the qtypes lookup altogether, and merely create the >>> alternate enum as a non-consecutive QTYPE mapping, for one less level of >>> indirection, as in: >>> >>> typedef enum Blockd

[Qemu-devel] [RFC PATCH 6/2] qapi: Fix alternates that accept 'number' but not 'int'

2015-07-30 Thread Eric Blake
The QMP input visitor allows integral values to be assigned by promotion to a QTYPE_QFLOAT. However, when parsing an alternate, we did not take this into account, such that an alternate that accepts 'number' but not 'int' would reject integral values. With this patch, we now have the following de

[Qemu-devel] [RFC PATCH 5/2] qapi: Simplify visiting of alternate types

2015-07-30 Thread Eric Blake
Previously, working with alternates required two enums, and some indirection: for type Foo, we created Foo_qtypes[] which maps each qtype to a member of FooKind_lookup[], then use FooKind_lookup[] like we do for other union types. This has a subtle bug: since the values of FooKind_lookup start at

[Qemu-devel] [RFC PATCH 4/2] qapi: Test use of 'number' within alternates

2015-07-30 Thread Eric Blake
Add some testsuite exposure for use of a 'number' as part of an alternate. The current state of the tree has a few bugs exposed by this: our input parser depends on the ordering of how the qapi schema declared the alternate, and the parser does not accept integers for a 'number' in an alternate ev

Re: [Qemu-devel] [PATCH v13 00/19] i.MX: Add i.MX25 support through the PDK evaluation board

2015-07-30 Thread Jean-Christophe DUBOIS
Hi, Is there any more work needed on this series? Regards JC Le 16/07/2015 23:21, Jean-Christophe Dubois a écrit : This series of patches add the support for the i.MX25 processor through the Freescale PDK evaluation board. For now a limited set of devices is supported. * GPT timers (fro

[Qemu-devel] [Bug 1465935] Re: kvm_irqchip_commit_routes: Assertion `ret == 0' failed

2015-07-30 Thread Li Chengyuan
Bader, Sorry to response late. We patch our QEMU 2.0 and running on ubuntu 12.04, and shall keep it running for a while. I'll let you know if this problem is gone after weeks. Regards, CY. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

Re: [Qemu-devel] [PATCH] ahci: fix ICC mask definition

2015-07-30 Thread Peter Maydell
On 30 July 2015 at 19:41, John Snow wrote: > Peter: I assume you still want this for 2.4 to fix the clang warnings, yes? Yeah, it's safe enough. (I don't actually require these clang warnings all fixed for 2.4; but it's a nice-to-have.) thanks -- PMM

Re: [Qemu-devel] [PATCH v2 0/1] Add support for PCI Enhanced Allocation "BARs"

2015-07-30 Thread Stalley, Sean
Ping ping > -Original Message- > From: Stalley, Sean > Sent: Wednesday, July 15, 2015 9:38 AM > To: qemu-devel@nongnu.org; Michael S. Tsirkin (m...@redhat.com) > Subject: RE: [PATCH v2 0/1] Add support for PCI Enhanced Allocation > "BARs" > > ping > > > -Original Message- > > Fro

[Qemu-devel] [PATCH 1/4] target-arm: Add missing MAIR_EL3 and TPIDR_EL3 registers

2015-07-30 Thread Peter Maydell
Add the AArch64 registers MAIR_EL3 and TPIDR_EL3, which are the only two which we had implemented the 32-bit Secure equivalents of but not the 64-bit Secure versions. Signed-off-by: Peter Maydell --- target-arm/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target-arm/helpe

[Qemu-devel] [PATCH 0/4] target-arm: Implement missing EL3 (and EL2) registers

2015-07-30 Thread Peter Maydell
This series adds a handful of EL3 system registers that we were missing. It also includes the EL2 flavours where there were obvious easy parallels. I think this means we now have all the EL3 sysregs we care about. (A previous series added missing address translation operations; I still have to do t

[Qemu-devel] [PATCH 3/4] target-arm: Implement missing AFSR registers

2015-07-30 Thread Peter Maydell
The AFSR registers are implementation dependent auxiliary fault status registers. We already implemented a RAZ/WI AFSR0_EL1 and AFSR_EL1; add the missing AFSR{0,1}_EL{2,3} for consistency. Signed-off-by: Peter Maydell --- target-arm/helper.c | 24 1 file changed, 24 inse

[Qemu-devel] [PATCH 4/4] target-arm: Implement missing ACTLR registers

2015-07-30 Thread Peter Maydell
We already implemented ACTLR_EL1; add the missing ACTLR_EL2 and ACTLR_EL3, for consistency. Since we don't currently have any CPUs that need the EL2/EL3 versions to reset to non-zero values, implement as RAZ/WI. Signed-off-by: Peter Maydell --- target-arm/helper.c | 21 +++-- 1

Re: [Qemu-devel] [PATCH] ahci: fix ICC mask definition

2015-07-30 Thread John Snow
Peter: I assume you still want this for 2.4 to fix the clang warnings, yes? On 07/21/2015 02:02 PM, John Snow wrote: > There are likely others that could be updated, but we'll > go with a light touch for 2.4 for now. > > Without the Unsigned specifier, this shifts bits into the > signed bit, whic

[Qemu-devel] [PATCH 2/4] target-arm: Implement missing AMAIR registers

2015-07-30 Thread Peter Maydell
The AMAIR registers are for providing auxiliary implementation defined memory attributes. We already implemented a RAZ/WI AMAIR_EL1; add the EL2 and EL3 versions for consistency. Signed-off-by: Peter Maydell --- target-arm/helper.c | 21 + 1 file changed, 21 insertions(+) di

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-07-30 Thread Dennis Luehring
Am 30.07.2015 um 12:09 schrieb Aurelien Jarno: I am using Debian SPARC64 from debian-ports. But it's not really ready-to-use and often broken. the current 6.5.1 NetBSD is available for SPARC and SPARC64 - with SPARC using 32bit Kernel/Userland and SPARC64 with 64bit Kernel/Userland and accor

Re: [Qemu-devel] [PATCH] sdhci: Pass drive parameter to sdhci-pci via qdev property

2015-07-30 Thread Kevin O'Connor
On Wed, Jul 29, 2015 at 10:01:03AM +0100, Stefan Hajnoczi wrote: > On Tue, Jul 28, 2015 at 12:22:43PM -0400, Kevin O'Connor wrote: > > Commit 19109131 disabled the sdhci-pci support because it used > > drive_get_next(). This patch reenables sdhci-pci and changes it to > > pass the drive via a qdev

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread Dr. David Alan Gilbert
* Yang Hongyang (yan...@cn.fujitsu.com) wrote: > > > On 07/30/2015 09:59 PM, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>On 2015/7/30 20:30, Dr. David Alan Gilbert wrote: > >>>* Gonglei (arei.gong...@huawei.com) wrote: > On 2015/7/30 19:56, Dr.

Re: [Qemu-devel] [aswg] request for ACPI ID for QEMU

2015-07-30 Thread Doran, Mark
That's OK, Michael, I've been called a lot worse :) I'm back in the office today. I don't know where this is, let me see where it is in the queue with the admins for update on the site. Please note: I replied to you and the public list only...we try not to mix up postings to the UEFI mailing

Re: [Qemu-devel] [PATCH v5] hmp: add info iothreads command

2015-07-30 Thread Amos Jianjun Kong
On Fri, Jul 31, 2015 at 1:07 AM, Paolo Bonzini wrote: > > > On 30/07/2015 18:51, Amos Jianjun Kong wrote: >>> > +void hmp_info_iothreads(Monitor *mon, const QDict *qdict) >>> > +{ >>> > +IOThreadInfoList *info_list = qmp_query_iothreads(NULL); >>> > +IOThreadInfoList *info; >>> > + >>> > +

Re: [Qemu-devel] [PATCH v5] hmp: add info iothreads command

2015-07-30 Thread Paolo Bonzini
On 30/07/2015 18:51, Amos Jianjun Kong wrote: >> > +void hmp_info_iothreads(Monitor *mon, const QDict *qdict) >> > +{ >> > +IOThreadInfoList *info_list = qmp_query_iothreads(NULL); >> > +IOThreadInfoList *info; >> > + >> > +for (info = info_list; info; info = info->next) { >> > +

Re: [Qemu-devel] [PATCH v7 5/6] Initial implementation of vGICv3

2015-07-30 Thread Peter Maydell
Hi. I have been reading the GIC specs over the last few days and I think I'm getting closer to understanding what we need to do with this series to get it to a committable state (without tying it up with GICv3 emulation). I'll send some mail about that tomorrow probably, when I've figured out the d

Re: [Qemu-devel] [PATCH v5] hmp: add info iothreads command

2015-07-30 Thread Amos Jianjun Kong
On Fri, Jun 26, 2015 at 4:07 PM, Ting Wang wrote: > Make "info iothreads" available on the HMP monitor. > > For example, the results are as follows when executing qemu > command with "-object iothread,id=iothread-1 -object > iothread,id=iothread-2". > (qemu) info iothreads > iothread-1: thread_id=

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-30 Thread Eric Blake
On 07/30/2015 09:53 AM, Markus Armbruster wrote: >> Or, we could ditch the qtypes lookup altogether, and merely create the >> alternate enum as a non-consecutive QTYPE mapping, for one less level of >> indirection, as in: >> >> typedef enum BlockdevRefKind { >> BLOCKDEV_REF_DEFINITION = QTYPE_

Re: [Qemu-devel] [PATCH v5] hmp: add info iothreads command

2015-07-30 Thread Luiz Capitulino
On Fri, 26 Jun 2015 16:07:13 +0800 Ting Wang wrote: > Make "info iothreads" available on the HMP monitor. > > For example, the results are as follows when executing qemu > command with "-object iothread,id=iothread-1 -object > iothread,id=iothread-2". > (qemu) info iothreads > iothread-1: threa

Re: [Qemu-devel] [PATCH RFC v2 29/47] qapi: Replace dirty is_c_ptr() by method c_null()

2015-07-30 Thread Markus Armbruster
Eric Blake writes: > On 07/29/2015 11:22 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 07/29/2015 02:32 AM, Markus Armbruster wrote: >>> >> 2. We can leak retval only when qmp_FOO() returns non-null and local_err >>is non-null. This must not happen, because: >> >

Re: [Qemu-devel] [PATCH for-2.4 v2 0/2] vhost: check if vhost has capacity for hotplugged memory

2015-07-30 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 11:17:41AM +0200, Igor Mammedov wrote: > On Thu, 30 Jul 2015 10:58:23 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 30, 2015 at 09:31:34AM +0200, Igor Mammedov wrote: > > > On Thu, 30 Jul 2015 09:29:56 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-30 Thread Markus Armbruster
Eric Blake writes: > On 07/30/2015 12:42 AM, Markus Armbruster wrote: > >>> But what happens if the 0th branch is mapped to a different parser, as >>> would be the case if one of the alternate's branches is 'number'? In >>> particular, qmp_input_type_number() accepts BOTH QFloat and QInt types.

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] vhost: add vhost_has_free_slot() interface

2015-07-30 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 05:45:33PM +0200, Igor Mammedov wrote: > On Thu, 30 Jul 2015 18:28:05 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jul 30, 2015 at 12:11:57PM +0200, Igor Mammedov wrote: > > > it will allow for other parts of QEMU check if it's safe > > > to map memory region during h

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-07-30 Thread Aurelien Jarno
On 2015-07-30 10:55, Aurelien Jarno wrote: > On 2015-07-30 10:16, Dennis Luehring wrote: > > Am 30.07.2015 um 09:52 schrieb Aurelien Jarno: > > >On 2015-07-30 05:52, Dennis Luehring wrote: > > >> Am 29.07.2015 um 17:01 schrieb Aurelien Jarno: > > >> >The point is that emulation has a cost, and it's

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] vhost: add vhost_has_free_slot() interface

2015-07-30 Thread Igor Mammedov
On Thu, 30 Jul 2015 18:28:05 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jul 30, 2015 at 12:11:57PM +0200, Igor Mammedov wrote: > > it will allow for other parts of QEMU check if it's safe > > to map memory region during hotplug/runtime. > > That way hotplug path will have a chance to cancel > >

Re: [Qemu-devel] [PATCH RFC v2 07/47] qapi: Generate a nicer struct for flat unions

2015-07-30 Thread Markus Armbruster
Eric Blake writes: > On 07/30/2015 01:11 AM, Markus Armbruster wrote: > >>> Another name collision bug: our code generates flat unions as: >>> >>> struct BlockdevOptions { >>> BlockdevDriver driver; >>> ... >>> /* End fields inherited from BlockdevOptionsBase. */ >>> /* union tag is B

[Qemu-devel] [PATCH] hw/pci-host/bonito: Avoid buffer overrun for bad LDMA/COP accesses

2015-07-30 Thread Peter Maydell
The LDMA and COP memory regions represent four 32 bit registers each, but the memory regions themselves are 0x100 bytes large. Add guards to the read and write accessors so that bogus accesses beyond the four defined registers don't just run off the end of the bonldma and boncop structs and into wh

Re: [Qemu-devel] [PATCH for-2.4 v3 3/3] vhost: fail backend intialization if memslots number is more than its supported limit

2015-07-30 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 12:11:59PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/virtio/vhost.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index bcbad48..48fbac1 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] vhost: add vhost_has_free_slot() interface

2015-07-30 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 12:11:57PM +0200, Igor Mammedov wrote: > it will allow for other parts of QEMU check if it's safe > to map memory region during hotplug/runtime. > That way hotplug path will have a chance to cancel > hotplug operation instead of crashing in vhost_commit(). > > Signed-off-by

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread Yang Hongyang
On 07/30/2015 09:59 PM, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: On 2015/7/30 20:30, Dr. David Alan Gilbert wrote: * Gonglei (arei.gong...@huawei.com) wrote: On 2015/7/30 19:56, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wro

Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-07-30 Thread Thomas Huth
On 30/07/15 17:00, Jason J. Herne wrote: > On 07/21/2015 06:37 AM, David Hildenbrand wrote: >>> >>> So if I've got this code right, you send here a "header" that announces >>> a packet with all pages ... >>> +while (handled_count < total_count) { +cur_count = MIN(total_count -

Re: [Qemu-devel] [PATCH 01/12] qga: misc spelling

2015-07-30 Thread Eric Blake
On 07/01/2015 05:47 AM, Marc-André Lureau wrote: > --- > qga/qapi-schema.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake As a doc change, it's trivial enough for inclusion if we wanted it, but now we're late enough that it's probably also fine to wait for 2.

Re: [Qemu-devel] Call Trace for QEMU functions

2015-07-30 Thread Alex Bennée
Peter Maydell writes: > On 30 July 2015 at 13:20, Naman patel wrote: >> Hi, >> >> I have compiled QEMU (2.0) for x86_64 on Fedora 22 with tracing enabled >> and the tracing option I chose was dtrace. I have this script called >> callTrace.stp in which I try and get the Call Trace of the fu

Re: [Qemu-devel] [PATCH v2] arm: change vendor ID for virtio-mmio

2015-07-30 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 10:24:11AM +0100, Peter Maydell wrote: > On 30 July 2015 at 09:04, Michael S. Tsirkin wrote: > > On Thu, Jul 30, 2015 at 09:23:20AM +0800, Shannon Zhao wrote: > >> > >> Why do we drop the previous way using "QEMU"? Something I missed? > > > > So that guests that bind to

Re: [Qemu-devel] [PATCH v2] arm: change vendor ID for virtio-mmio

2015-07-30 Thread Michael S. Tsirkin
On Thu, Jul 30, 2015 at 05:21:51PM +0800, Shannon Zhao wrote: > > > On 2015/7/30 16:04, Michael S. Tsirkin wrote: > > On Thu, Jul 30, 2015 at 09:23:20AM +0800, Shannon Zhao wrote: > >> > >> > >> On 2015/7/30 3:16, Michael S. Tsirkin wrote: > >>> ACPI spec 5.0 allows the use of PCI vendor IDs. > >

Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-07-30 Thread Jason J. Herne
On 07/21/2015 06:37 AM, David Hildenbrand wrote: So if I've got this code right, you send here a "header" that announces a packet with all pages ... +while (handled_count < total_count) { +cur_count = MIN(total_count - handled_count, S390_SKEYS_BUFFER_SIZE); + +ret = skeycl

Re: [Qemu-devel] [PATCH 09/12] netfilter: add a netbuffer filter

2015-07-30 Thread Yang Hongyang
On 07/30/2015 10:16 PM, Thomas Huth wrote: On 30/07/15 12:28, Yang Hongyang wrote: On 07/30/2015 06:14 PM, Jason Wang wrote: On 07/30/2015 05:49 PM, Yang Hongyang wrote: On 07/30/2015 05:33 PM, Jason Wang wrote: [...] I see, so the reason is you are using qemu_deliver_packet() for both e

[Qemu-devel] [RFC PATCH] spapr: Provide an error message when migration fails due to htab_shift mismatch

2015-07-30 Thread Bharata B Rao
Include an error message when migration fails due to mismatch in htab_shift values at source and target. This should provide a bit more verbose message in addition to the current migration failure message that reads like: qemu-system-ppc64: error while loading state for instance 0x0 of device 'sp

Re: [Qemu-devel] [PATCH] qmp-shell: add documentation

2015-07-30 Thread Luiz Capitulino
On Thu, 23 Jul 2015 09:36:38 +0200 Markus Armbruster wrote: > John Snow writes: > > > On 07/02/2015 11:31 AM, Luiz Capitulino wrote: > >> On Wed, 1 Jul 2015 14:25:49 -0400 > >> John Snow wrote: > >> > >>> I should probably document the changes that were made. > > John, what do you mean here

Re: [Qemu-devel] help attach pci device to virtio bus

2015-07-30 Thread Stefan Hajnoczi
This thread is a duplicate.

Re: [Qemu-devel] [PATCH RFC v2 29/47] qapi: Replace dirty is_c_ptr() by method c_null()

2015-07-30 Thread Eric Blake
On 07/29/2015 11:22 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 07/29/2015 02:32 AM, Markus Armbruster wrote: >> > 2. We can leak retval only when qmp_FOO() returns non-null and local_err >is non-null. This must not happen, because: > >a. local_err must be n

Re: [Qemu-devel] [PATCH 09/12] netfilter: add a netbuffer filter

2015-07-30 Thread Thomas Huth
On 30/07/15 12:28, Yang Hongyang wrote: > On 07/30/2015 06:14 PM, Jason Wang wrote: >> >> >> On 07/30/2015 05:49 PM, Yang Hongyang wrote: >>> On 07/30/2015 05:33 PM, Jason Wang wrote: [...] I see, so the reason is you are using qemu_deliver_packet() for both enqueuing packet to filter and

Re: [Qemu-devel] [PATCH RFC v2 07/47] qapi: Generate a nicer struct for flat unions

2015-07-30 Thread Eric Blake
On 07/30/2015 01:11 AM, Markus Armbruster wrote: >> Another name collision bug: our code generates flat unions as: >> >> struct BlockdevOptions { >> BlockdevDriver driver; >> ... >> /* End fields inherited from BlockdevOptionsBase. */ >> /* union tag is BlockdevDriver driver */ >>

Re: [Qemu-devel] help

2015-07-30 Thread Stefan Hajnoczi
On Thu, Jul 30, 2015 at 11:17 AM, Serigne Baytir DIENG wrote: > I am new into this qemu, but i have a pretty good understanding of how it > works. What i am trying to do is to attach a new pci device into the virtio > pci bus. I don't know much what files need to be changed or how could i > achiev

Re: [Qemu-devel] Call Trace for QEMU functions

2015-07-30 Thread Peter Maydell
On 30 July 2015 at 13:20, Naman patel wrote: > Hi, > > I have compiled QEMU (2.0) for x86_64 on Fedora 22 with tracing enabled > and the tracing option I chose was dtrace. I have this script called > callTrace.stp in which I try and get the Call Trace of the function > helper_invlpg and later

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/7/30 20:30, Dr. David Alan Gilbert wrote: > >* Gonglei (arei.gong...@huawei.com) wrote: > >>On 2015/7/30 19:56, Dr. David Alan Gilbert wrote: > >>>* Jason Wang (jasow...@redhat.com) wrote: > > > On 07/30/2015 04:03 PM,

Re: [Qemu-devel] [PATCH] vhost/scsi: call vhost_dev_cleanup() at unrealize() time

2015-07-30 Thread Paolo Bonzini
On 30/07/2015 15:29, Igor Mammedov wrote: > vhost-scsi calls vhost_dev_init() at realize() time > but forgets to call it's counterpart vhost_dev_cleanup() > at unrealize() time. > > Calling it should fix leaking of memory table and > mem_sections table in vhost device. And also unregister > vhos

[Qemu-devel] simulate SMI in Qemu

2015-07-30 Thread Yu-Cheng Liu
hello, Does QEMU support SMI/SMM implementation? I use Qemu and coreboot to trace the procedure of the SMI/SMM ,the program return in SMM initial function ,the reason is the value return from "pci_read_word" ,the function always return 0, whatever the address I give. I want to simulate the board

[Qemu-devel] help

2015-07-30 Thread Serigne Baytir DIENG
Hi all, I am new into this qemu, but i have a pretty good understanding of how it works. What i am trying to do is to attach a new pci device into the virtio pci bus. I don't know much what files need to be changed or how could i achieved that. Anyone can help?

[Qemu-devel] help attach pci device to virtio bus

2015-07-30 Thread Serigne Baytir DIENG
Hi all, I am new into this qemu, but i have a pretty good understanding of how it works. What i am trying to do is to attach a new pci device into the virtio pci bus. I don't know much what files need to be changed or how could i achieved that. Anyone can help?

[Qemu-devel] [PATCH] vhost/scsi: call vhost_dev_cleanup() at unrealize() time

2015-07-30 Thread Igor Mammedov
vhost-scsi calls vhost_dev_init() at realize() time but forgets to call it's counterpart vhost_dev_cleanup() at unrealize() time. Calling it should fix leaking of memory table and mem_sections table in vhost device. And also unregister vhost's memory listerner to prevent access from memory core to

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: fix overlapping metadata update

2015-07-30 Thread Jeff Cody
On Thu, Jul 30, 2015 at 09:41:08AM +0300, Vasiliy Tolstov wrote: > 2015-07-29 12:31 GMT+03:00 Liu Yuan : > > Technically, it won't affect the performance because index updates are not > > range > > but concrete in terms of underlying 4M block size. Only 2 or 3 indexes in a > > range will be update

Re: [Qemu-devel] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-07-30 Thread Paolo Bonzini
On 30/07/2015 03:35, Fam Zheng wrote: > block.cbdrv_create > block/curl.c curl_init_state > block/io.c bdrv_drain > block/io.c bdrv_drain_all > block/io.c bdrv_prwv_co > block/io.c bdrv_get_block_status_above > block/io.c

Re: [Qemu-devel] [PATCH for-2.4 0/3] scsi: fixes for failed requests

2015-07-30 Thread Paolo Bonzini
On 30/07/2015 15:16, Stefan Hajnoczi wrote: > When requests fail the error policy (-drive rerror=,werror=) determines what > happens. The 'stop' policy pauses the guest and waits for the administrator > to > resolve the storage problem. It is possible to live migrate during this time > and the

[Qemu-devel] [PATCH for-2.4 2/3] scsi-disk: fix cmd.mode field typo

2015-07-30 Thread Stefan Hajnoczi
The cmd.xfer field is the data length. The cmd.mode field is the data transfer direction. scsi_handle_rw_error() was using the wrong error policy for read requests. Signed-off-by: Stefan Hajnoczi --- hw/scsi/scsi-disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scs

[Qemu-devel] [PATCH for-2.4 3/3] tests: virtio-scsi: clear unit attention after reset

2015-07-30 Thread Stefan Hajnoczi
The unit attention after reset (power on) prevents normal commands from running. The unaligned WRITE SAME test never executed its command! Signed-off-by: Stefan Hajnoczi --- tests/virtio-scsi-test.c | 90 +--- 1 file changed, 54 insertions(+), 36 dele

[Qemu-devel] [PATCH for-2.4 1/3] virtio-scsi: use virtqueue_map_sg() when loading requests

2015-07-30 Thread Stefan Hajnoczi
The VirtQueueElement struct is serialized during migration but the in_sg[]/out_sg[] iovec arrays are not usable on the destination host because the pointers are meaningless. Use virtqueue_map_sg() to refresh in_sg[]/out_sg[] to valid pointers based on in_addr[]/out_addr[] hwaddrs. Cc: Paolo Bonzi

[Qemu-devel] [PATCH for-2.4 0/3] scsi: fixes for failed requests

2015-07-30 Thread Stefan Hajnoczi
When requests fail the error policy (-drive rerror=,werror=) determines what happens. The 'stop' policy pauses the guest and waits for the administrator to resolve the storage problem. It is possible to live migrate during this time and the failed requests can be restarted on the destination host

Re: [Qemu-devel] [PATCH v2 06/45] ivshmem: remove unnecessary dup()

2015-07-30 Thread Marc-André Lureau
hi On Wed, Jul 29, 2015 at 9:10 PM, Eric Blake wrote: > On 07/27/2015 06:32 PM, Marc-André Lureau wrote: >> From: Marc-André Lureau >> >> qemu_chr_fe_get_msgfd() transfer ownership, there is no need to dup the fd. > > s/transfer/transfers/ > >> >> Signed-off-by: Marc-André Lureau > > Interestin

Re: [Qemu-devel] [PATCH] bsd-user: Fix operand to cpu_x86_exec

2015-07-30 Thread Peter Maydell
On 29 July 2015 at 22:22, Peter Maydell wrote: > On 29 July 2015 at 19:40, Richard Henderson wrote: >> Signed-off-by: Richard Henderson >> --- >> This buglet, from whenever we re-orged the parameters, means >> that all x86-bsd-user invocations die instantly. >> >> >> r~ >> --- >> bsd-user/main.

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-30 Thread Eric Blake
On 07/30/2015 12:42 AM, Markus Armbruster wrote: >> But what happens if the 0th branch is mapped to a different parser, as >> would be the case if one of the alternate's branches is 'number'? In >> particular, qmp_input_type_number() accepts BOTH QFloat and QInt types. >> So, if we have this qap

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-30 Thread zhanghailiang
On 2015/7/30 20:30, Dr. David Alan Gilbert wrote: * Gonglei (arei.gong...@huawei.com) wrote: On 2015/7/30 19:56, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 07/30/2015 04:03 PM, Dr. David Alan Gilbert wrote: * Dong, Eddie (eddie.d...@intel.com) wrote: A quest

  1   2   3   >