Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 0/2] SMBIOS Support for ARM

2015-08-20 Thread Peter Maydell
On 13 August 2015 at 18:09, Wei Huang wrote: > SMBIOS tables present userful system hardware info to management > applications, such as DMI tools. Even though SMBIOS was originally > developed for Intel x86, it has been extended to both Itanium and > ARM (32bit & 64bit). More and more ARM server r

Re: [Qemu-devel] [PATCH v5 3/4] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-20 Thread Gavin Shan
On Wed, Aug 19, 2015 at 09:15:26AM -0700, Thomas Huth wrote: >On 18/08/15 18:15, David Gibson wrote: >> On Wed, Aug 19, 2015 at 09:52:00AM +1000, Gavin Shan wrote: >>> On Tue, Aug 18, 2015 at 10:32:13AM -0700, Thomas Huth wrote: On 17/08/15 18:47, Gavin Shan wrote: > The patch supports RTA

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2015-08-20 Thread Nehal J Wani
Comment No. 23 by Manuel Baesler worked for me in Windows 10. lsusb gave me: Bus 001 Device 040: ID 8564:1000 Transcend Information, Inc. JetFlash Qemu Flags used: -device usb-ehci,id=usb,bus=pci.0,addr=0x4 -device usb-host,vendorid=0x8564,productid=0x1000,id=hostdev0,bus=usb.0 -- You received t

Re: [Qemu-devel] [PATCH 11/25] audio: reduce glob_audio_state usage

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Signed-off-by: Kővágó, Zoltán Fill a bit the commit message, to say simply use AudioState instead. Also explain why you add AudioState *s in struct although it's not used in that commit, saying simply it's going to be used in later comm

Re: [Qemu-devel] [PATCH 9/9] target-arm: Wire up HLT 0xf000 as the A64 semihosting instruction

2015-08-20 Thread Christopher Covington
On Aug 13, 2015 9:35 AM, "Peter Maydell" wrote: > > For the A64 instruction set, the semihosting call instruction > is 'HLT 0xf000'. Wire this up to call do_arm_semihosting() > if semihosting is enabled. > > Signed-off-by: Peter Maydell Reviewed-by: Christopher Covington

Re: [Qemu-devel] [PATCH v2 0/3] SysFS driver for QEMU fw_cfg device

2015-08-20 Thread Ard Biesheuvel
On 19 August 2015 at 22:49, Gabriel L. Somlo wrote: > Hi Ard, > > On Wed, Aug 19, 2015 at 11:42:02AM +0200, Ard Biesheuvel wrote: >> (missed some cc's) >> >> On 19 August 2015 at 11:38, Ard Biesheuvel wrote: >> > From: "Gabriel L. Somlo" >> >> Several different architectures supported by QEMU ar

[Qemu-devel] [PATCH 09/16] target-tilegx: Generate tcg instructions to finish "Hello world"

2015-08-20 Thread gchen gchen
Generate related tcg instructions, and qemu tilegx can finish running "Hello world". The elf64 binary can be static or shared. Signed-off-by: Chen Gang --- target-tilegx/translate.c | 2966 + 1 file changed, 2966 insertions(+) create mode 100644 target-t

[Qemu-devel] [PATCH RFC 3/5] qapi: Merge generation of per-member visits

2015-08-20 Thread Eric Blake
Consolidate the code between visit and command marshalling that iterates over the members of a struct. It reduces code duplication in the generator, with no change to generated marshal code, and slightly more verbose (but no semantic change) in the generated visit code: | visit_optional(v, &(

[Qemu-devel] [PATCH v5 1/1] s390x: pci infrastructure modeling

2015-08-20 Thread Yi Min Zhao
From: Yi Min Zhao This patch introduce a new facility(and bus) to hold devices representing information actually provided by s390 firmware and I/O configuration. usage example: -device s390-pcihost,index=1 -device zpci,fid=2,uid=5,pci_id=vpci1,id=zpci1 -device vfio-pci,host=:00:00.0,id=vpci1

Re: [Qemu-devel] [PATCH 00/19] multi-arch+linux-user: Cleanup ELF_MACHINE

2015-08-20 Thread Riku Voipio
On Sat, Aug 15, 2015 at 04:28:10PM -0700, Peter Crosthwaite wrote: > Peter Crosthwaite (19): > linux_user: elfload: Default ELF_MACHINE to ELF_ARCH > linux-user: elfload: Provide default for elf_check_arch > arm: Remove ELF_MACHINE from cpu.h > mb: Remove ELF_MACHINE from cpu.h > m68k: Re

Re: [Qemu-devel] [PATCH 16/25] paaudio: properly disconnect streams in fini_*

2015-08-20 Thread Marc-André Lureau
Reviewed-by: Marc-André Lureau On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Currently this needs a workaround due to bug #74624 in pulseaudio. > > Signed-off-by: Kővágó, Zoltán > --- > audio/paaudio.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] quorum: validate vote threshold against num_children even if read-pattern is fifo

2015-08-20 Thread Kevin Wolf
Am 19.08.2015 um 04:53 hat Wen Congyang geschrieben: > Ping... It might have helped to... a) CC the qemu-block mailing list b) CC the subsystem maintainer that should apply the patch (according to scripts/get_maintainer.pl that's me with Berto's Acked-by) c) include the "PATCH" keyword in the

Re: [Qemu-devel] [PATCH 17/25] audio: remove gcc specific audio_MIN, audio_MAX

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Currently the gcc specific version only evaluates the arguments once, > while the generic version evaluates one argument twice, which can cause > debugging headaches when an argument has a side effect. This patch at > least provides cons

Re: [Qemu-devel] [PATCH] qemu-img: Fix crash in amend invocation

2015-08-20 Thread Eric Blake
On 08/18/2015 05:03 PM, Max Reitz wrote: > Example: > $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M > $ ./qemu-img amend -f qcow2 -o backing_file=/tmp/t.qcow2, -o help \ > /tmp/t.qcow2 > > This should not crash. This actually is tested by iotest 082, but not > caught due to the segmentation fa

Re: [Qemu-devel] [PATCH 18/25] audio: do not run each backend in audio_run

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > audio_run is called manually by alsa and oss backends when polling. > In this case only the requesting backend should be run, not all of them. > > Signed-off-by: Kővágó, Zoltán > --- > audio/alsaaudio.c | 7 +-- > audio/audio.c

Re: [Qemu-devel] [PATCH 07/25] qapi: qapi for audio backends

2015-08-20 Thread Marc-André Lureau
On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment variables base

[Qemu-devel] [PATCH v3] hmp: Allow for error message hints on HMP

2015-08-20 Thread Eric Blake
Commits 7216ae3d and d2828429 disabled some error message hints, all because a change to use modern error reporting meant that the hint would be output prior to the actual error. Fix this by making hints a first-class member of Error. For example, we are now back to the pleasant: $ qemu-system-

Re: [Qemu-devel] [kvm-s390] qemu-system-s390x: cannot use stdio by multiple character devices

2015-08-20 Thread tu bo
Hi Alex: Ping you again just in case you did not get my mail :-) On 08/13/2015 03:52 PM, tu bo wrote: Hi Alex: I added one disk device for test case 068(qemu/tests/qemu-iotests/068, which is for for loading a saved VM state from a qcow2 image ), and got the same problem for s390-virtio-ccw.

Re: [Qemu-devel] [PATCH 08/25] qapi: support nested structs in OptsVisitor

2015-08-20 Thread Kővágó Zoltán
Hi, 2015-08-20 17:55 keltezéssel, Marc-André Lureau írta: [snip] +static void +sum_strlen(gpointer data, gpointer user_data) +{ +const char *str = data; +size_t *sum_len = user_data; + +if (str) { /* skip NULLs */ +*sum_len += strlen(str) + 1; +} +} + +static void +append

Re: [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets activated

2015-08-20 Thread Fam Zheng
On Tue, 08/18 14:25, Shmulik Ladkani wrote: > As of a90a7425cf592a3afeff3eaf32f543b83050ee5c 'tap: Drop tap_can_send' > vmxnet3 (with tap networking) can no longer receive once device is > deactivated. > Alas, as the device is initially "inactive", this brakes vmxnet3 > receive functionality. > >

[Qemu-devel] [PATCH 00/16 v1] tilegx: Firstly add tilegx target for linux-user

2015-08-20 Thread Chen Gang
After the implementation, it can let normal tilegx program working (e.g. sh, vi, cp, mv ...). And the known left issues are: - At present, it can not pass gcc testsuite (it causes some programs pending). - The floating point implementation is not included, since at present, it is only the

[Qemu-devel] [PATCH 04/16 v1] target-tilegx: Add opcode basic implementation from Tilera Corporation

2015-08-20 Thread Chen Gang
It is copied from Linux kernel "arch/tile/include/uapi/arch/ opcode_tilegx.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/opcode_tilegx.h | 1406 + 1 file changed, 1406 insertions(+) create mode 100644 target-tilegx/opcode_tile

[Qemu-devel] [PATCH 09/16 v1] target-tilegx: Generate tcg instructions to finish "Hello world"

2015-08-20 Thread Chen Gang
Generate related tcg instructions, and qemu tilegx can finish running "Hello world". The elf64 binary can be static or shared. Signed-off-by: Chen Gang --- target-tilegx/translate.c | 2966 + 1 file changed, 2966 insertions(+) create mode 100644 targe

[Qemu-devel] [PATCH 15/16 v1] tilegx: Match with the latest qemu master tree

2015-08-20 Thread Chen Gang
The interface of cpu_exec and cpu_exec_init are changed, so qemu tilegx should match with them. Signed-off-by: Chen Gang --- linux-user/main.c | 2 +- target-tilegx/cpu.c | 2 +- target-tilegx/cpu.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/main.c b/linu

[Qemu-devel] [PATCH 08/16] target-tilegx: Add several helpers for instructions translation

2015-08-20 Thread gchen gchen
The related instructions are exception, cntlz, cnttz, shufflebytes, and add_saturate. Signed-off-by: Chen Gang --- target-tilegx/helper.c | 83 ++ target-tilegx/helper.h | 5 +++ 2 files changed, 88 insertions(+) create mode 100644 target-tilegx/helpe

[Qemu-devel] [PATCH 02/10] vexpress: Don't set name on abstract class

2015-08-20 Thread Eduardo Habkost
The MachineClass::name field won't be ever be used on TYPE_VEXPRESS, as it is an abstract class and the machine class lookup code explicitly skips abstract classes. We can remove it to make the code simpler. Cc: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/arm/vexpress.c | 1 - 1 file ch

[Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix

2015-08-20 Thread Eduardo Habkost
The machine class names in QEMU are not consistent today. Some of them use the "-machine" suffix, but some use completely different naming conventions. This makes it difficult to implement machine class lookup without iterating through the whole list of machine classes. This series changes all mac

[Qemu-devel] [PATCH 05/10] pseries: Rename machine class names to use MACHINE_TYPE_NAME

2015-08-20 Thread Eduardo Habkost
Machine class names should use the "-machine" suffix to allow class-name-based machine class lookup to work. Rename the the pseries machine classes using the MACHINE_TYPE_NAME macro. Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Eduardo Habkost --- hw/ppc/spapr.c | 8 1 fil

[Qemu-devel] [PATCH 01/10] machine: MACHINE_TYPE_NAME macro

2015-08-20 Thread Eduardo Habkost
The macro will be useful to ensure the machine class names follow the right format to make machine class lookup by class name work correctly. Signed-off-by: Eduardo Habkost --- include/hw/boards.h | 6 ++ vl.c| 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 09/10] machine: Ensure all TYPE_MACHINE subclasses have the right suffix

2015-08-20 Thread Eduardo Habkost
Now that all non-abstract TYPE_MACHINE subclasses have the -machine suffix, add an assert to ensure this will be always true. Signed-off-by: Eduardo Habkost --- hw/core/machine.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index ac4654e..e50

[Qemu-devel] [PATCH 08/10] mac99: Use MACHINE_TYPE_NAME to encode class name

2015-08-20 Thread Eduardo Habkost
It will result in exactly the same class name, but it will make the code consistent with the other classes. Cc: Alexander Graf Cc: qemu-...@nongnu.org Signed-off-by: Eduardo Habkost --- hw/ppc/mac_newworld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/mac_newworld

[Qemu-devel] [PATCH 07/10] s390: Rename s390-ccw-virtio-2.4 class name to use MACHINE_TYPE_NAME

2015-08-20 Thread Eduardo Habkost
Machine class names should use the "-machine" suffix to allow class-name-based machine class lookup to work. Rename the s390-ccw-virtio-2.4 machine class using the MACHINE_TYPE_NAME macro. Cc: Alexander Graf Cc: Cornelia Huck Cc: Christian Borntraeger Cc: Richard Henderson Signed-off-by: Eduar

Re: [Qemu-devel] [PATCH 19/25] paaudio: fix playback glitches

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Pulseaudio normally assumes that when the server wants it, the client > can generate the audio samples and send it right away. Unfortunately > this is not the case with QEMU -- it's up to the emulated system when > does it generate the s

[Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name automatically

2015-08-20 Thread Eduardo Habkost
Now all TYPE_MACHINE subclasses use MACHINE_TYPE_NAME to generate the class name. So instead of requiring each subclass to set MachineClass::name manually, we can now set it automatically at the TYPE_MACHINE class_base_init() function. Signed-off-by: Eduardo Habkost --- hw/arm/vexpress.c |

Re: [Qemu-devel] [PATCH 20/25] audio: remove mixeng specific code from backends

2015-08-20 Thread Marc-André Lureau
Hi This commit fails to compile with errors such as: audio/audio.c: In function ‘audio_pcm_hw_run_in’: audio/audio.c:1143:41: error: ‘struct audio_pcm_info’ has no member named ‘bytes_per_frame’ size_t size = samples * hw->info.bytes_per_frame;

Re: [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer based outputs

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > > -decr = rate_get_samples(&hw->info, &out->rate); > -decr = audio_MIN(out->fsize - out->fpos, decr); > - > -*size = decr << 2; > +*size = audio_rate_get_bytes(&hw->info, &out->rate, > + (ou

Re: [Qemu-devel] [PATCH 05/25] qapi: change Netdev into a flat union

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Except qapi-schema.json, this patch was geenrated by: generated > +# Captures the commopn configuration of a network device. common -- Marc-André Lureau

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-20 Thread Artyom Tarasenko
On Thu, Aug 20, 2015 at 7:22 AM, Dennis Luehring wrote: > Am 19.08.2015 um 16:41 schrieb Artyom Tarasenko: >> >> And if I completely disable optimizer (// #define >> USE_TCG_OPTIMIZATIONS in tcg.c), it's still quite faster: >> >> real14m17.668s >> user14m10.241s >> sys 0m6.060s > > > m

Re: [Qemu-devel] [PATCH 17/25] audio: remove gcc specific audio_MIN, audio_MAX

2015-08-20 Thread Peter Maydell
On 19 August 2015 at 19:17, Gerd Hoffmann wrote: > On Do, 2015-08-06 at 20:28 +0200, Kővágó, Zoltán wrote: >> Currently the gcc specific version only evaluates the arguments once, >> while the generic version evaluates one argument twice, which can cause >> debugging headaches when an argument has

Re: [Qemu-devel] [PATCH 22/25] audio: add mixeng option (documentation)

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > This will allow us to disable mixeng when we use a decent backend. > > Disabling mixeng have a few advantages: > * we no longer convert the audio output from one format to another, when > the underlying audio system would just convert i

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-20 Thread Richard Henderson
On 08/19/2015 07:41 AM, Artyom Tarasenko wrote: Without the patch: time g++ -DHAVE_CONFIG_H -I. -I../binutils-gdb/gold -I../binutils-gdb/gold -I../binutils-gdb/gold/../include -I../binutils-gdb/gold/../elfcpp -DLOCALEDIR="\"/usr/local/share/locale\"" -DBINDIR="\"/usr/local/bin\"" -DTOOLBINDIR=

[Qemu-devel] [PATCH 06/10] s390-virtio: Rename machine class name to use MACHINE_TYPE_NAME

2015-08-20 Thread Eduardo Habkost
Machine class names should use the "-machine" suffix to allow class-name-based machine class lookup to work. Rename the s390-virtio machine class using the MACHINE_TYPE_NAME macro. Cc: Alexander Graf Cc: Richard Henderson Signed-off-by: Eduardo Habkost --- hw/s390x/s390-virtio.c | 5 +++-- 1 f

Re: [Qemu-devel] [PATCH 12/25] audio: basic support for multi backend audio

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Audio functions no longer access glob_audio_state, instead they get an > AudioState as a parameter. This is required in order to support > multiple backends. > > glob_audio_state is also gone, and replaced with a tailq so we can store >

Re: [Qemu-devel] [PATCH 23/25] audio: make mixeng optional

2015-08-20 Thread Marc-André Lureau
Fails to compile: audio/audio.c: In function ‘audio_run_out’: audio/audio.c:1058:32: error: ‘struct audio_pcm_ops’ has no member named ‘enable_out’ if (hw->pcm_ops->enable_out) {

[Qemu-devel] [PATCH v2] qemu-img: Fix crash in amend invocation

2015-08-20 Thread Max Reitz
Example: $ ./qemu-img create -f qcow2 /tmp/t.qcow2 64M $ ./qemu-img amend -f qcow2 -o backing_file=/tmp/t.qcow2, -o help \ /tmp/t.qcow2 This should not crash. This actually is tested by iotest 082, but not caught due to the segmentation fault being silent (which is something that needs to be f

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-20 Thread Dennis Luehring
Am 19.08.2015 um 16:41 schrieb Artyom Tarasenko: And if I completely disable optimizer (// #define USE_TCG_OPTIMIZATIONS in tcg.c), it's still quite faster: real14m17.668s user14m10.241s sys 0m6.060s my tests also without USE_TCG_OPTIMIZATIONS qemu 2.4.50, netbsd 6.1.5 SPARC64 wi

Re: [Qemu-devel] [PATCH 25/25] audio: split ctl_* functions into enable_* and volume_*

2015-08-20 Thread Marc-André Lureau
nice! :) Looks good, I'll check more thoroughly when you will have an updated series.

[Qemu-devel] [PATCH] vhost: remove unnecessary code

2015-08-20 Thread Yuanhan Liu
We won't reference var 'i' anymore; there is no need to assign a value to it. cc: Michael S. Tsirkin Signed-off-by: Yuanhan Liu --- hw/virtio/vhost.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 2712c6f..86ea26f 100644 --- a/hw/virtio/vhost.c ++

Re: [Qemu-devel] [PATCH v2] hmp: Allow for error message hints on HMP

2015-08-20 Thread Paolo Bonzini
On 18/08/2015 14:48, Eric Blake wrote: > Commits 7216ae3d and d2828429 disabled some error message hints, > all because a change to use modern error reporting meant that the > hint would be output prior to the actual error. Fix this by making > hints a first-class member of Error. > > For examp

[Qemu-devel] [PATCH v5 0/1] s390 pci infrastructure modeling

2015-08-20 Thread Yi Min Zhao
From: Yi Min Zhao This patch extends the current s390 pci implementation to provide more flexibility in configuration of s390 specific device handling. For each vfio pci device, I create a zpci device to store s390 specific informations. And attach all of these special zpci devices to the s390

[Qemu-devel] [PATCH 07/16] target-tilegx: Add cpu basic features for linux-user

2015-08-20 Thread gchen gchen
It implements minimized cpu features for linux-user. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/cpu.c | 143 ++ target-tilegx/cpu.h | 175 2 files changed, 318 insertions(+) crea

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Shannon Zhao
On 2015/8/20 8:24, Peter Maydell wrote: > On 6 August 2015 at 14:25, Andrew Jones wrote: >> On Thu, Aug 06, 2015 at 01:55:14PM +0100, Leif Lindholm wrote: >>> On Thu, Aug 06, 2015 at 02:28:03PM +0200, Andrew Jones wrote: In the least I wouldn't want to get burned twice, so I'd prefer to >>>

[Qemu-devel] [PATCH RFC 1/5] qapi: Reuse code for flat union base validation

2015-08-20 Thread Eric Blake
Rather than open-code the check for a valid base type, we should reuse the common functionality. This allows for consistent error messages, and also makes it easier for a later patch to turn on support for inline anonymous base structures. Test flat-union-inline is updated to test only one feature

Re: [Qemu-devel] [PATCH v2] virtio: avoid leading underscores for helpers

2015-08-20 Thread Thomas Huth
On 17/08/15 02:48, Cornelia Huck wrote: > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > feature checking helpers") introduced a helper __virtio_has_feature. > We don't want to use reserved identifiers, though, so let's > rename __virtio_has_feature to virtio_has_feature and virtio

[Qemu-devel] [PATCH] imx_serial: Generate interrupt on tx empty if enabled

2015-08-20 Thread Guenter Roeck
Generate an interrupt if the tx buffer is empty and the tx empty interrupt is enabled. This fixes a problem seen when running a Linux image since Linux commit 55c3cb1358e ("serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()"). Linux now waits for the tx empty interrupt before st

[Qemu-devel] [PATCH 16/16 v1] target-tilegx: Implement additional instructions in normal working flow

2015-08-20 Thread Chen Gang
They are vectors, pcnt, revbytes, icoh, and drain. Signed-off-by: Chen Gang --- target-tilegx/helper.c| 12 +- target-tilegx/helper.h| 4 +- target-tilegx/translate.c | 431 ++ 3 files changed, 331 insertions(+), 116 deletions(-) diff --git

[Qemu-devel] [PATCH 11/16 v1] target-tilegx: Add related feature to support iret instruction

2015-08-20 Thread Chen Gang
In fact, iret itself needs nothing, but the related previous and next instructions need to be implemented. SPR_EX_CONTEXT_0_0 and SPR_EX_CONTEXT_0_1 are related with iret, so let them in a patch. Signed-off-by: Chen Gang --- target-tilegx/cpu.h | 2 ++ target-tilegx/translate.c | 86

Re: [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print

2015-08-20 Thread Marc-André Lureau
On Tue, Jul 7, 2015 at 4:42 PM, Kővágó, Zoltán wrote: > This will let us print options in a format that the user would actually > write it on the command line (foo=bar,baz=asd,etc=def), without > prepending a spurious comma at the beginning of the list, or quoting > values unnecessarily. This pat

[Qemu-devel] [Bug 1329956] Re: multi-core FreeBSD guest hangs after warm reboot

2015-08-20 Thread Venkateswara Rao Dokku
Can you please tell me whether the issue is fixed with the latest kernel? If so, what version has the fix? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1329956 Title: multi-core FreeBSD guest hang

[Qemu-devel] [PATCH 03/10] vexpress: Rename machine classes to use MACHINE_TYPE_NAME

2015-08-20 Thread Eduardo Habkost
Machine class names should use the "-machine" suffix to allow class-name-based machine class lookup to work. Rename the vexpress machine classes using the MACHINE_TYPE_NAME macro. Cc: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/arm/vexpress.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PATCH 02/16] linux-user: Support tilegx architecture in linux-user

2015-08-20 Thread gchen gchen
Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- include/elf.h | 2 + linux-user/elfload.c | 23 linux-user/main.c | 295 +

Re: [Qemu-devel] [PATCH 09/25] audio: use qapi AudioFormat instead of audfmt_e

2015-08-20 Thread Marc-André Lureau
looks good, Reviewed-by: Marc-André Lureau -- Marc-André Lureau

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Shannon Zhao
On 2015/8/20 18:48, G Gregory wrote: On 20 August 2015 at 11:18, Leif Lindholm wrote: On Thu, Aug 20, 2015 at 01:24:39AM +0100, Peter Maydell wrote: On 6 August 2015 at 14:25, Andrew Jones wrote: On Thu, Aug 06, 2015 at 01:55:14PM +0100, Leif Lindholm wrote: On Thu, Aug 06, 2015 at 02:28:

[Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

2015-08-20 Thread gchen gchen
They are based on Linux kernel tilegx architecture for 64 bit binary, and also based on tilegx ABI reference document, and also reference from other targets implementations. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- linux-user/tilegx/syscall.h | 40 + linux-user/tilegx/syscall_n

[Qemu-devel] [PATCH 14/16 v1] linux-user: main: Use negative qemu errno for syscall return errno

2015-08-20 Thread Chen Gang
The qemu errno is negative of normal errno, so revert it before return from syscall, or the related user mode checking will fail, e.g. cp/mv will call stat64 and check errno ENOENT (not -ENOENT). Signed-of-by Chen Gang --- linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 10/25] audio: -audiodev command line option

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > This patch adds an -audiodev command line option, and deprecates the > QEMU_* environment variables for audio backend configuration. It's "its" or simply "the" > syntax is similar to existing options (-netdev, -device, etc): -audiodev

Re: [Qemu-devel] [PATCH v2 1/6] cputlb: Add functions for flushing TLB for a single MMU index

2015-08-20 Thread Edgar E. Iglesias
On Fri, Aug 14, 2015 at 11:41:14AM +0100, Peter Maydell wrote: > Guest CPU TLB maintenance operations may be sufficiently > specialized to only need to flush TLB entries corresponding > to a particular MMU index. Implement cputlb functions for > this, to avoid the inefficiency of flushing TLB entri

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Leif Lindholm
On Thu, Aug 20, 2015 at 01:24:39AM +0100, Peter Maydell wrote: > On 6 August 2015 at 14:25, Andrew Jones wrote: > > On Thu, Aug 06, 2015 at 01:55:14PM +0100, Leif Lindholm wrote: > >> On Thu, Aug 06, 2015 at 02:28:03PM +0200, Andrew Jones wrote: > >> > In the least I wouldn't want to get burned tw

[Qemu-devel] [PATCH 07/16 v1] target-tilegx: Add cpu basic features for linux-user

2015-08-20 Thread Chen Gang
It implements minimized cpu features for linux-user. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/cpu.c | 143 ++ target-tilegx/cpu.h | 175 2 files changed, 318 insertions(+)

[Qemu-devel] [PATCH 02/16 v1] linux-user: Support tilegx architecture in linux-user

2015-08-20 Thread Chen Gang
Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- include/elf.h | 2 + linux-user/elfload.c | 23 linux-user

Re: [Qemu-devel] [PATCH v6 02/10] init/cleanup of netfilter object

2015-08-20 Thread Yang Hongyang
On 08/10/2015 05:18 PM, Jason Wang wrote: On 08/07/2015 10:46 AM, Yang Hongyang wrote: QTAILQ_ENTRY global_list but used by filter layer, so that we can manage all filters together. QTAILQ_ENTRY next used by netdev, filter belongs to the specific netdev is in this queue. This is mostly the s

[Qemu-devel] [PATCH RFC 5/5] qapi: Allow anonymous base for flat union

2015-08-20 Thread Eric Blake
Rather than requiring all flat unions to explicitly create a separate base struct, we want to allow the qapi schema to specify the common fields via an inline dictionary. This is similar to how commands can specify inline types for the arguments. Now that the feature is legal, we can drop the form

Re: [Qemu-devel] [PATCH 14/25] audio: audiodev= parameters no longer optional when -audiodev present

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Signed-off-by: Kővágó, Zoltán > --- > audio/audio.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/audio/audio.c b/audio/audio.c > index 10b9871..7468b94 100644 > --- a/audio/audio.c > +++ b/audio

[Qemu-devel] [PATCH RFC 2/5] qapi: Generate consistent variable names

2015-08-20 Thread Eric Blake
Code consolidation is easier if similar code uses the same variable naming conventions. Prefer 'err' over 'local_err' in the command and event marshallers, and prefer 'v' over 'm' as the name of the Visitor object in the visitor code. The resulting changes have no impact to compiled code behavior

Re: [Qemu-devel] [PATCH 00/16] tilegx: Firstly add tilegx target for linux-user

2015-08-20 Thread gchen gchen
Oh, sorry, my hotmail seems has issues, I shall try to send all patches again after fix it tomorrow. On 8/21/15 01:04, gchen gchen wrote: > Hello All: > > After the implementation, it can let normal tilegx program working (e.g. > sh, vi, cp, mv ...). And the known left issues are: > > - At prese

[Qemu-devel] [PATCH 00/16] tilegx: Firstly add tilegx target for linux-user

2015-08-20 Thread gchen gchen
Hello All: After the implementation, it can let normal tilegx program working (e.g. sh, vi, cp, mv ...). And the known left issues are: - At present, it can not pass gcc testsuite (it causes some programs pending). - The floating point implementation is not included, since at present, it is only

Re: [Qemu-devel] [Bug 1329956] Re: multi-core FreeBSD guest hangs after warm reboot

2015-08-20 Thread John Nielsen
Yes it is. Not sure what version first fixed it but I know 4.1 works. > On Aug 20, 2015, at 2:30 AM, Venkateswara Rao Dokku > wrote: > > Can you please tell me whether the issue is fixed with the latest > kernel? If so, what version has the fix? > > -- > You received this bug notification bec

[Qemu-devel] [PATCH 06/16 v1] target-tilegx: Add special register information from Tilera Corporation

2015-08-20 Thread Chen Gang
The related copy is from Linux kernel "arch/tile/include/uapi/arch/ spr_def_64.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- target-tilegx/spr_def_64.h | 216 + 1 file changed, 216 insertions(+) create mode 100644 target-tilegx/spr_def_

Re: [Qemu-devel] [PATCH v2 0/3] SysFS driver for QEMU fw_cfg device

2015-08-20 Thread Gabriel L. Somlo
Hi Ard, On Wed, Aug 19, 2015 at 11:42:02AM +0200, Ard Biesheuvel wrote: > (missed some cc's) > > On 19 August 2015 at 11:38, Ard Biesheuvel wrote: > > From: "Gabriel L. Somlo" > >> Several different architectures supported by QEMU are set up with a > >> "firmware configuration" (fw_cfg) device,

[Qemu-devel] [PATCH 01/16 v1] linux-user: tilegx: Firstly add architecture related features

2015-08-20 Thread Chen Gang
They are based on Linux kernel tilegx architecture for 64 bit binary, and also based on tilegx ABI reference document, and also reference from other targets implementations. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell --- linux-user/tilegx/syscall.h| 40 + linux-user/tilegx

[Qemu-devel] [PATCH RFC 4/5] qapi: Simplify visits of optional fields

2015-08-20 Thread Eric Blake
None of the visitor callbacks would set an error when testing if an optional field was present; make this part of the interface contract by eliminating the errp argument. Then, for less code, reflect the determined boolean value back to the caller instead of making the caller read the boolean afte

Re: [Qemu-devel] [PATCH v5 4/4] sPAPR: Support RTAS call ibm, errinjct

2015-08-20 Thread Gavin Shan
On Wed, Aug 19, 2015 at 08:48:20AM -0700, Thomas Huth wrote: >On 18/08/15 17:26, Gavin Shan wrote: >> On Tue, Aug 18, 2015 at 11:04:59AM -0700, Thomas Huth wrote: >>> On 17/08/15 18:47, Gavin Shan wrote: The patch supports RTAS call "ibm,errinjct" to allow injecting EEH errors to VFIO PCI

Re: [Qemu-devel] [PATCH 13/25] audio: add audiodev properties to frontends

2015-08-20 Thread Marc-André Lureau
looks good, Reviewed-by: Marc-André Lureau On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Finally add audiodev= options to audio frontends so users can specify > which backend to use when multiple backends exist. Not specifying an > audiodev= option currently causes the first audiode

Re: [Qemu-devel] [PATCH] target-s390x: Mask the SIGP order_code to 8bit.

2015-08-20 Thread Thomas Huth
On 18/08/15 04:50, Philipp Kern wrote: > According to "CPU Signaling and Response", "Signal-Processor Orders", > the order field is bit position 56-63. Without this, the Linux > guest kernel is sometimes unable to stop emulation and enters > an infinite loop of "XXX unknown sigp: 0x0005

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Andrew Jones
On Thu, Aug 20, 2015 at 12:21:31PM +0100, Leif Lindholm wrote: > On Thu, Aug 20, 2015 at 07:09:57PM +0800, Shannon Zhao wrote: > > >>>Could somebody who understands ACPI and the ramifications > > >>>here let me know if I should apply this patch, please? > > >>>(since we're now post-2.4) > > >> > >

[Qemu-devel] [PATCH 08/16 v1] target-tilegx: Add several helpers for instructions translation

2015-08-20 Thread Chen Gang
The related instructions are exception, cntlz, cnttz, shufflebytes, and add_saturate. Signed-off-by: Chen Gang --- target-tilegx/helper.c | 83 ++ target-tilegx/helper.h | 5 +++ 2 files changed, 88 insertions(+) create mode 100644 target-tilegx/

Re: [Qemu-devel] [PATCH 0/5] audio: multi channel audio support

2015-08-20 Thread Gerd Hoffmann
Hi, > Currently you have to specify the number of channels you want to use > when creating the usb-audio device, see the last commit for details. > To do this I currently dynamically allocate the whole USBDesc structure, > which looks ugly. If there's a better way, please let me know! You can

Re: [Qemu-devel] [kvm-s390] qemu-system-s390x: cannot use stdio by multiple character devices

2015-08-20 Thread Alexander Graf
On 20.08.15 01:20, tu bo wrote: > Hi Alex: > > Ping you again just in case you did not get my mail :-) > > On 08/13/2015 03:52 PM, tu bo wrote: >> Hi Alex: >> >> I added one disk device for test case 068(qemu/tests/qemu-iotests/068, >> which is for for loading a saved VM state from a qcow2 ima

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR

2015-08-20 Thread Peter Maydell
On 6 August 2015 at 14:25, Andrew Jones wrote: > On Thu, Aug 06, 2015 at 01:55:14PM +0100, Leif Lindholm wrote: >> On Thu, Aug 06, 2015 at 02:28:03PM +0200, Andrew Jones wrote: >> > In the least I wouldn't want to get burned twice, so I'd prefer to >> > see the SPCR code actually get into Linux fi

[Qemu-devel] [PATCH 1/2] block/io: allow AIOCB without callback

2015-08-20 Thread Peter Lieven
If the backend storage is unresponsive and we cancel a request due to a timeout we cannot immediately destroy the AIOCB because the storage might complete the original request laster if it is responsive again. For this purpose allow to set the callback to NULL and ignore it in this case. Signed-of

Re: [Qemu-devel] [PATCH 08/25] qapi: support nested structs in OptsVisitor

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > The current OptsVisitor flattens the whole structure, if there are same > named fields under different paths (like `in' and `out' in `Audiodev'), > the current visitor can't cope with them (for example setting > `frequency=44100' will set

Re: [Qemu-devel] [PATCH 4/7] machine: DEFINE_MACHINE macro

2015-08-20 Thread Eduardo Habkost
On Tue, Aug 18, 2015 at 12:08:51PM -0700, Eduardo Habkost wrote: > The macro will allow easy registration of a TYPE_MACHINE subclass, using > only the machine name and a MachineClass initialization function as > parameter. > > Signed-off-by: Eduardo Habkost I will need to redo this patch after s

Re: [Qemu-devel] [PATCH] configure: Don't permit SDL or GTK on OSX

2015-08-20 Thread Peter Maydell
On 14 August 2015 at 16:10, Peter Maydell wrote: > The cocoa GUI frontend assumes it is the only GUI (it redefines > main() so it always gets control before the rest of QEMU), so > it does not play well with other UIs like SDL or GTK. (Mostly > people building QEMU on OSX don't have the necessary

Re: [Qemu-devel] [PATCH 6/9] target-arm/arm-semi.c: Support widening APIs to 64 bits

2015-08-20 Thread Christopher Covington
On Thu, Aug 13, 2015 at 9:35 AM, Peter Maydell wrote: > The 64-bit A64 semihosting API has some pervasive changes from > the 32-bit version: > * all parameter blocks are arrays of 64-bit values, not 32-bit > * the semihosting call number is passed in W0 > * the return value is a 64-bit value in

[Qemu-devel] [PATCH 2/2] ide/atapi: partially avoid deadlock if the storage backend is dead

2015-08-20 Thread Peter Lieven
the blk_drain_all() that is executed if the guest issues a DMA cancel leads to a stuck main loop if the storage backend (e.g. a NFS share) is unresponsive. This scenario is a common case for CDROM images mounted from an NFS share. In this case a broken NFS server can take down the whole VM even if

[Qemu-devel] [PATCH 0/2] ide/atapi: partially avoid deadlock if the storage backend is dead

2015-08-20 Thread Peter Lieven
the blk_drain_all() that is executed if the guest issues a DMA cancel leads to a stuck main loop if the storage backend (e.g. a NFS share) is unresponsive. This scenario is a common case for CDROM images mounted from an NFS share. In this case a broken NFS server can take down the whole VM even if

Re: [Qemu-devel] [PATCH] Block: don't do copy-on-read in before_write_notifier

2015-08-20 Thread Wen Congyang
On 08/20/2015 01:02 AM, Jeff Cody wrote: > On Wed, Aug 19, 2015 at 01:43:41PM +0800, Wen Congyang wrote: >> On 08/19/2015 01:41 PM, Paolo Bonzini wrote: >>> On 18/08/2015 19:54, Wen Congyang wrote: We will copy data in before_write_notifier to do backup. It is a nested I/O request, so we

Re: [Qemu-devel] [PATCH v2] hmp: Allow for error message hints on HMP

2015-08-20 Thread Eric Blake
On 08/18/2015 02:48 PM, Eric Blake wrote: > Commits 7216ae3d and d2828429 disabled some error message hints, > all because a change to use modern error reporting meant that the > hint would be output prior to the actual error. Fix this by making > hints a first-class member of Error. > > For exam

[Qemu-devel] [PATCH 04/10] arm: Rename virt machine class to use MACHINE_TYPE_NAME

2015-08-20 Thread Eduardo Habkost
Machine class names should use the "-machine" suffix to allow class-name-based machine class lookup to work. Rename the arm virt machine class using the MACHINE_TYPE_NAME macro. Cc: Peter Maydell Signed-off-by: Eduardo Habkost --- hw/arm/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 dele

Re: [Qemu-devel] [PATCH 01/12] hbitmap: serialization

2015-08-20 Thread Stefan Hajnoczi
On Fri, Aug 07, 2015 at 12:32:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: > +/** > + * hbitmap_serialize_part > + * @hb: HBitmap to oprate on. s/oprate/operate/ > + * @buf: Buffer to store serialized bitmap. > + * @start: First bit to store. > + * @count: Number of bits to store. > + * > + *

  1   2   >