Re: [Qemu-devel] [PATCH 2/6] ppc: spapr: introduce 2.5 machine type

2015-08-21 Thread David Gibson
On Fri, Aug 21, 2015 at 05:05:46PM +0800, Jason Wang wrote: > This will be used by virtio 1.0 virtio-pci virtqueue migration > backward compatibility. > > Cc: David Gibson > Cc: Alexander Graf > Cc: qemu-...@nongnu.org > Signed-off-by: Jason Wang There's already a more or less equivalent patch

Re: [Qemu-devel] [PATCH RFC 5/5] qapi: Allow anonymous base for flat union

2015-08-21 Thread Eric Blake
On 08/19/2015 05:04 PM, Eric Blake wrote: > Rather than requiring all flat unions to explicitly create > a separate base struct, we want to allow the qapi schema > to specify the common fields via an inline dictionary. This > is similar to how commands can specify inline types for the > arguments.

Re: [Qemu-devel] [PATCHv2] macio: handle non-block ATAPI DMA transfers the same as block DMA transfers

2015-08-21 Thread Mark Cave-Ayland
On 21/08/15 20:04, John Snow wrote: (lots cut) > Do you want to resend the V3 here directly to the ML with Aurelien > Jarno's R-B? I was actually looking at this yesterday, and it seems with some more testing that only the DBDMA flush part is required. It could be that fixing the flush semantics

Re: [Qemu-devel] [PATCH v2 03/49] qapi: convert NumaOptions into a flat union

2015-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2015 at 05:36:59PM +0200, Kővágó, Zoltán wrote: > Signed-off-by: Kővágó, Zoltán I don't understand QAPI enough to understand why exactly this is needed (so I would like to get feedback from somebody who actually understands QAPI unions), but I have one comment below. [...] > ##

Re: [Qemu-devel] [RESEND PATCH v9 2/4] x86: use new method to correct reset sequence

2015-08-21 Thread Eduardo Habkost
On Wed, Aug 19, 2015 at 05:36:30PM +0800, Zhu Guihua wrote: > Something must be occur during reset of the X86 platform in a specific > order. For example, the apic reset should be after some devices (such > as hpet, rtc) reset, so that the apic register could be set to default > values. Can you ex

Re: [Qemu-devel] [RESEND PATCH v9 1/4] apic: map APIC's MMIO region at each CPU's address space

2015-08-21 Thread Eduardo Habkost
On Wed, Aug 19, 2015 at 05:36:29PM +0800, Zhu Guihua wrote: > From: Chen Fan > > Replace mapping APIC at global system address space with > mapping it at per-CPU address spaces. Can you improve the commit message by explaining not just what is being done, but why this is needed? > > Signed-off

Re: [Qemu-devel] [PATCH v2 6/7] [RFC] Use DEFINE_MACHINE to register all machines

2015-08-21 Thread Eduardo Habkost
On Wed, Aug 19, 2015 at 10:25:34AM +0200, Michael Walle wrote: [...] > >-static void lm32_machine_init(void) > >+static void lm32_evr_machine_machine_init(MachineClass *mc) > > { > >-qemu_register_machine(&lm32_uclinux_machine); > >-qemu_register_machine(&lm32_evr_machine); > >+mc->desc

[Qemu-devel] [PATCH 2/2] rtl8139: correctly track full receive buffer in standard mode

2015-08-21 Thread Vladislav Yasevich
In standard operation mode, when the receive ring buffer is full, the buffer actually appears empty to the driver since the RxBufAddr (the location we wirte new data to) and RxBufPtr (the location guest would stat reading from) are the same. As a result, the call to rtl8139_RxBufferEmpty ends up re

[Qemu-devel] [PATCH 1/2] rtl8139: Do not consume the packet during overflow in standard mode.

2015-08-21 Thread Vladislav Yasevich
When operation in standard mode, we currently return the size of packet during buffer overflow. This consumes the overflow packet. Return 0 instead so we can re-process the overflow packet when we have room. This fixes issues with lost/dropped fragments of large messages. Signed-off-by: Vladisl

[Qemu-devel] [PATCH 0/2] rtl8139: Fix buffer overflow in standard mode

2015-08-21 Thread Vladislav Yasevich
When rtl8139 card is running in standard mode, it is very easy to overlflow and the receive buffer and get into a siutation where all packets are dropped. Simply reproduction case is to ping the guest from the host with 6500 byte packets. There are actually 2 problems here. 1) When the rtl8129

Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

2015-08-21 Thread gchen gchen
On 8/21/15 14:38, Eric Blake wrote: > On 08/20/2015 11:30 PM, Eric Blake wrote: >> On 08/20/2015 10:09 AM, gchen gchen wrote: > ^^^ > >> >> In the subject line, >> s/Firstly add/Add/ >> >> ('Firstly' is seldom used in English, and certainly not in the context >> you were trying to use it) >

Re: [Qemu-devel] [PATCH v13r 00/14] Revised tilegx-linux-user decoding

2015-08-21 Thread gchen gchen
On 8/21/15 13:32, Richard Henderson wrote: > Patches 1-9 & 11 are your already reviewed non-decoding patches, > with the fixes for application to mainline folded in. > > Patch 10 is a new framework for decoding the tilegx bundle > that doesn't have nearly so much redundant code. The patch > is stil

Re: [Qemu-devel] [PATCH 00/16 v1] tilegx: Firstly add tilegx target for linux-user

2015-08-21 Thread gchen gchen
On 8/21/15 13:15, Richard Henderson wrote: > First off, this isn't v1. The previous patch set you posted was v12. > > On 08/20/2015 02:32 PM, Chen Gang wrote: >> Chen Gang (16): >> linux-user: tilegx: Firstly add architecture related features >> linux-user: Support tilegx architecture in linux-user

[Qemu-devel] [PATCH v2 0/9] audio: multi channel audio support

2015-08-21 Thread Kővágó, Zoltán
This patch series adds support to more than two channels of audio (5.1, 7.1, etc.). Currently only usb-audio frontend and alsa and pa backends are updated. Using more than two channels requires turning off mixeng (-audiodev backend,id=foo,out.mixeng=off,...). For backward compatibility reasons,

[Qemu-devel] [PATCH v2 7/9] paaudio: channel-map option

2015-08-21 Thread Kővágó, Zoltán
Add an option to change the channel map used by pulseaudio. If not specified, falls back to an OSS compatible channel map. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 18 ++ qapi/audio.json | 5 - qemu-options.hx | 9 + 3 files changed, 27 insertions(+), 5

[Qemu-devel] [PATCH v2 5/9] audio: replace shift in audio_pcm_info with bytes_per_frame

2015-08-21 Thread Kővágó, Zoltán
The bit shifting trick worked because the number of bytes per frame was always a power-of-two (since QEMU only supports mono, stereo and 8, 16 and 32 bit samples). But if we want to add support for surround sound, this no longer holds true. Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c

[Qemu-devel] [PATCH v2 6/9] audio: basic support for multichannel audio

2015-08-21 Thread Kővágó, Zoltán
Which currently only means removing some checks. Old code won't require more than two channels, but new code will need it. Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 7 --- audio/audio.c | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/audio/alsaaudio.c b

[Qemu-devel] [PATCH v2 2/9] audio: make mixeng optional

2015-08-21 Thread Kővágó, Zoltán
Implementation of the previously added mixeng option. Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 70 +- audio/audio_template.h | 22 +++- 2 files changed, 79 insertions(+), 13 deletions(-) diff --git a/audio/audio.c b/a

[Qemu-devel] [PATCH v2 8/9] usb-audio: do not count on avail bytes actually available

2015-08-21 Thread Kővágó, Zoltán
This assumption is no longer true when mixeng is turned off. Signed-off-by: Kővágó, Zoltán --- hw/usb/dev-audio.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c index 48ac992..ddd80e0 100644 --- a/hw/us

[Qemu-devel] [PATCH v2 3/9] paaudio: get/put_buffer functions

2015-08-21 Thread Kővágó, Zoltán
This lets us avoid some buffer copying when using mixeng. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 83 + 1 file changed, 83 insertions(+) diff --git a/audio/paaudio.c b/audio/paaudio.c index 14bf258..8f19995 100644 --- a/audio/p

[Qemu-devel] [PATCH v2 1/9] audio: add mixeng option (documentation)

2015-08-21 Thread Kővágó, Zoltán
This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when the underlying audio system would just convert it to a third format. We no longer convert, only the underlying sys

[Qemu-devel] [PATCH v2 4/9] audio: support more than two channels in volume setting

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 28 audio/audio.h | 10 ++ audio/audio_int.h | 4 ++-- audio/paaudio.c| 20 audio/spiceaudio.c | 14 -- 5 files changed, 52 insertions(+), 24 deletions(-) diff

Re: [Qemu-devel] [PATCHv2] macio: handle non-block ATAPI DMA transfers the same as block DMA transfers

2015-08-21 Thread John Snow
On 08/13/2015 03:03 PM, Mark Cave-Ayland wrote: > On 01/08/15 19:33, Aurelien Jarno wrote: > >> On 2015-08-01 17:54, Mark Cave-Ayland wrote: >>> The existing code incorrectly changes the dma_active flag when a non-block >>> transfer has completed leading to a hang on newer versions of Linux beca

[Qemu-devel] [PATCH] vnc: fix memory corruption (CVE-2015-5225)

2015-08-21 Thread Gerd Hoffmann
The _cmp_bytes variable added by commit "bea60dd ui/vnc: fix potential memory corruption issues" can become negative. Result is (possibly exploitable) memory corruption. Reason for that is it uses the stride instead of bytes per scanline to apply limits. For the server surface is is actually fin

Re: [Qemu-devel] [PATCH] block/nfs: cache allocated filesize for read-only files

2015-08-21 Thread Max Reitz
On 2015-08-21 at 11:11, Peter Lieven wrote: Am 21.08.2015 um 18:46 schrieb Max Reitz: On 2015-08-21 at 00:49, Peter Lieven wrote: If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor

Re: [Qemu-devel] [PATCH] block/nfs: cache allocated filesize for read-only files

2015-08-21 Thread Peter Lieven
Am 21.08.2015 um 18:46 schrieb Max Reitz: > On 2015-08-21 at 00:49, Peter Lieven wrote: >> If the file is readonly its not expected to grow so >> save the blocking call to nfs_fstat_async and use >> the value saved at connection time. Also important >> the monitor (and thus the main loop) will not

[Qemu-devel] [PATCH 1/1] MAINTAINERS: add responsible person for Parallels format driver

2015-08-21 Thread Denis V. Lunev
Denis has spent 6 years working with this format in Parallels and QEMU code was rewritten almost completely by his. Thus it would be quite natural to add him as a maintainer and point of contact. Patches are going to flow though Stefan's tree. Signed-off-by: Denis V. Lunev CC: Stefan Hajnoczi -

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-21 Thread Laszlo Ersek
On 08/19/15 01:11, Eduardo Habkost wrote: > Migration with q35 was not possible before commit > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates > an ich9-ahci device, that was marked as unmigratable. So all q35 machines > before pc-q35-2.4 were unmigratable, and there'

Re: [Qemu-devel] [PATCH] block/nfs: cache allocated filesize for read-only files

2015-08-21 Thread Max Reitz
On 2015-08-21 at 00:49, Peter Lieven wrote: If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-21 Thread Dennis Luehring
Am 21.08.2015 um 17:47 schrieb Richard Henderson: On 08/20/2015 11:05 PM, Dennis Luehring wrote: >> > g++ src/pugixml.cpp -g -Wall -Wextra -Werror -pedantic -std=c++0x -c -MMD -MP >> > >> > tcg-indirect: ~2:46.5 >> > qemu.org-git: ~2:51.2 (worst result) >> > without-optimization: ~2:14.1 (best r

Re: [Qemu-devel] [PATCH] block/nfs: fix calculation of allocated file size

2015-08-21 Thread Max Reitz
On 2015-08-20 at 03:46, Peter Lieven wrote: st.st_blocks is always counted in 512 byte units. Do not use st.st_blksize as multiplicator which may be larger. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- block/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [Qemu-devel] [PATCH] cpu: introduce CpuTopoInfo structure for argument simplification

2015-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2015 at 05:34:45PM +0800, Zhu Guihua wrote: > From: Chen Fan > > In order to simplify arguments of function, introduce a new struct > named X86CPUTopoInfo. > > Originally, this patch was in the patchset "cpu: add device_add > foo-x86_64-cpu support". Now put it into a separate pa

[Qemu-devel] [Bug 1487264] [NEW] Windows 8.1/10 Crashes during upgrade - SYSTEM_THREAD_EXCEPTION_NOT_HANDLED

2015-08-21 Thread ShawnStarr
Public bug reported: Ever since Windows 8.x, 10 I cannot upgrade or upgrade to tech builds within Windows 10 without hard shutting off the VM. Physical hardware: Intel(R) Core(TM) i7-4910MQ CPU @ 2.90GHz [Haswell] QEMU 2.1-2.3.x seem all broken, I am using Q35 chipset w/ BIOS mode. Launch comma

[Qemu-devel] [Bug 1486768] [NEW] BlackMagic USB3 video capture returns only blank frames in Windows (xHCI issue)

2015-08-21 Thread Steinar H. Gunderson
Public bug reported: Hi, I've got an Intensity Shuttle USB3; it's a HDMI video capture card. It doesn't have any Linux drivers, so I'm trying to get it to work in a Windows 10 guest inside QEMU. I'm running latest git as of today (2015-08-20). I use this command line: sudo x86_64-softmmu/qemu-sy

Re: [Qemu-devel] [PATCH] i386: keep cpu_model field in MachineState uptodate

2015-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2015 at 05:29:55PM +0800, Zhu Guihua wrote: > Update cpu_model in MachineState for i386, so that the field can be used > for cpu hotplug, instead of using a static variable. > > Signed-off-by: Zhu Guihua [...] > -void pc_cpus_init(const char *cpu_model, DeviceState *icc_bridge) >

[Qemu-devel] Reset register configuration in embedde device

2015-08-21 Thread mar.krzeminski
Hello, I am new here, so sorry for dummy question... The problem: I have an embedded arm board simulation, I want to add a device simulating quite complicated reset cause logic. This logic is used in boot process. The goal is to have possibility to set proper register values before virtual mac

[Qemu-devel] [Bug 1486911] [NEW] Error compilation qemu 2.3.1 on raspberry pi (RASPBIAN(debian))

2015-08-21 Thread dima333750
Public bug reported: When compiling from source occurs to me incomprehensible error. Operation ./configure runs without problems, but among the logs make see this:   CP i386-softmmu / hw / i386 / acpi-dsdt.hex   CP i386-softmmu / hw / i386 / q35-acpi-dsdt.hex   CP i386-softmmu / hw / i386 / ssdt-t

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-21 Thread Aurelien Jarno
On 2015-08-21 08:47, Richard Henderson wrote: > On 08/20/2015 11:05 PM, Dennis Luehring wrote: > >> > g++ src/pugixml.cpp -g -Wall -Wextra -Werror -pedantic -std=c++0x -c > >> > -MMD -MP > >> > > >> > tcg-indirect: ~2:46.5 > >> > qemu.org-git: ~2:51.2 (worst result) > >> > without-optimization: ~2

[Qemu-devel] [PATCH v2 49/49] audio: split ctl_* functions into enable_* and volume_*

2015-08-21 Thread Kővágó, Zoltán
This way we no longer need vararg functions, improving compile time error detection. Also now it's possible to check actually what commands are supported, without needing to manually update ctl_caps. Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 56 +- audio/au

Re: [Qemu-devel] [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions

2015-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2015 at 01:05:12PM +0800, Xiao Guangrong wrote: > These instructions are used by NVDIMM drivers and the specification > locates at: > https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf > > Let them be enabled on Broadwell on default > > Signed-off-by: Xiao

Re: [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix

2015-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2015 at 12:23:01PM +0200, Cornelia Huck wrote: > On Thu, 20 Aug 2015 14:54:26 -0700 > Eduardo Habkost wrote: > > > The machine class names in QEMU are not consistent today. Some of them use > > the > > "-machine" suffix, but some use completely different naming conventions. > >

[Qemu-devel] [PATCH v2 36/49] alsaaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 306 +++--- 1 file changed, 81 insertions(+), 225 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index 8199b71..c64bbc6 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@

[Qemu-devel] [PATCH v2 40/49] ossaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/ossaudio.c | 289 --- 1 file changed, 104 insertions(+), 185 deletions(-) diff --git a/audio/ossaudio.c b/audio/ossaudio.c index a4a9a5a..420f984 100644 --- a/audio/ossaudio.c +++ b/audio/ossaudio.c @@ -4

[Qemu-devel] [PATCH v2 48/49] audio: common rate control code for timer based outputs

2015-08-21 Thread Kővágó, Zoltán
This commit removes the ad-hoc rate-limiting code from noaudio and wavaudio, and replaces them with a (slightly modified) code from spiceaudio. This way multiple write calls (for example when the circular buffer wraps around) do not cause problems. Signed-off-by: Kővágó, Zoltán --- audio/audio.

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-21 Thread Richard Henderson
On 08/20/2015 11:05 PM, Dennis Luehring wrote: >> > g++ src/pugixml.cpp -g -Wall -Wextra -Werror -pedantic -std=c++0x -c -MMD >> > -MP >> > >> > tcg-indirect: ~2:46.5 >> > qemu.org-git: ~2:51.2 (worst result) >> > without-optimization: ~2:14.1 (best result) >> >> No compiler optimization? I would

[Qemu-devel] [PATCH v2 34/49] audio: use size_t where makes sense

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 8 +-- audio/audio.c | 163 - audio/audio.h | 4 +- audio/audio_int.h | 22 +++ audio/audio_template.h | 6 +- audio/mixeng.h | 11 ++-- audio/ossa

[Qemu-devel] [PATCH v2 45/49] audio: remove remains of the old backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 42 ++ audio/audio_int.h | 7 --- 2 files changed, 6 insertions(+), 43 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index f24d0a1..584400c 100644 --- a/audio/audio.c +++ b/audio/audio.c

[Qemu-devel] [PATCH v2 39/49] noaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/noaudio.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 28c72d5..c7e47ae 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@ -38,10 +38,9 @@ typedef st

Re: [Qemu-devel] [PATCH 1/6] pc: introduce 2.5 machine type

2015-08-21 Thread Eduardo Habkost
On Fri, Aug 21, 2015 at 05:05:45PM +0800, Jason Wang wrote: [...] > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index a896624..2a7b7d9 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -304,9 +304,15 @@ static void pc_init1(MachineState *machine) > } > } > > +static v

[Qemu-devel] [PATCH v2 37/49] coreaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/coreaudio.c | 130 +- 1 file changed, 69 insertions(+), 61 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index a5229f2..b9c6d90 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@

[Qemu-devel] [PATCH v2 42/49] sdlaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/sdlaudio.c | 102 ++- 1 file changed, 41 insertions(+), 61 deletions(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index 26538c8..183ecdd 100644 --- a/audio/sdlaudio.c +++ b/audio/sdlaudio.c @@ -39,

[Qemu-devel] [PATCH v2 29/49] paaudio: properly disconnect streams in fini_*

2015-08-21 Thread Kővágó, Zoltán
Currently this needs a workaround due to bug #74624 in pulseaudio. Reviewed-by: Marc-André Lureau Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 17e8992..3e561

[Qemu-devel] [PATCH v2 47/49] audio: remove hw->samples, buffer_size_in/out pcm_ops

2015-08-21 Thread Kővágó, Zoltán
This patch removes the samples member from HWVoiceIn and HWVoiceOut. Backends can specify buffer size via the newly added buffer_size_in and buffer_size_out functions in audio_pcm_ops. They are optional, if not defined qemu will fall back to some built-in constant. Signed-off-by: Kővágó, Zoltán

[Qemu-devel] [PATCH v2 35/49] audio: api for mixeng code free backends

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 209 - audio/audio_int.h | 41 -- audio/audio_template.h | 1 + 3 files changed, 241 insertions(+), 10 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 013d980.

[Qemu-devel] [PATCH v2 18/49] paaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 11 audio/paaudio.c | 80 +++- 2 files changed, 40 insertions(+), 51 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 3d9f212..3eab2b9 100644 --- a/au

[Qemu-devel] [PATCH v2 38/49] dsoundaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/dsound_template.h | 45 +++ audio/dsoundaudio.c | 328 2 files changed, 102 insertions(+), 271 deletions(-) diff --git a/audio/dsound_template.h b/audio/dsound_template.h index 96181ef..ff5a1f8 1006

[Qemu-devel] [PATCH v2 46/49] audio: unify input and output mixeng buffer management

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 123 +++-- audio/audio_int.h | 12 +++-- audio/audio_template.h | 18 +++- 3 files changed, 71 insertions(+), 82 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 584400c

[Qemu-devel] [PATCH v2 30/49] audio: remove audio_MIN, audio_MAX

2015-08-21 Thread Kővágó, Zoltán
There's already a MIN and MAX macro in include/qemu/osdep.h, use them instead. Signed-off-by: Kővágó, Zoltán --- Changes from v1: * removed audio_MIN, audio_MAX macros audio/alsaaudio.c | 6 +++--- audio/audio.c | 20 ++-- audio/audio.h | 17 --

[Qemu-devel] [PATCH v2 23/49] audio: reduce glob_audio_state usage

2015-08-21 Thread Kővágó, Zoltán
Remove glob_audio_state from functions, where possible without breaking the API. This means that most static functions in audio.c now take an AudioState pointer instead of implicitly using glob_audio_state. Also included a pointer in SWVoice*, HWVoice* structs, so that functions dealing them can

[Qemu-devel] [PATCH v2 33/49] audio: remove read and write pcm_ops

2015-08-21 Thread Kővágó, Zoltán
They just called audio_pcm_sw_read/write anyway, so it makes no sense to have them too. (The noaudio's read is the only exception, but it should work with the generic code too.) Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 12 audio/audio.c | 14 -- aud

[Qemu-devel] [PATCH v2 31/49] audio: do not run each backend in audio_run

2015-08-21 Thread Kővágó, Zoltán
audio_run is called manually by alsa and oss backends when polling. In this case only the requesting backend should be run, not all of them. Reviewed-by: Marc-André Lureau Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c | 7 +-- audio/audio.c | 17 +++-- audio/audio_int

[Qemu-devel] [PATCH v2 41/49] paaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/Makefile.objs | 1 - audio/audio_pt_int.c | 173 --- audio/audio_pt_int.h | 22 --- audio/paaudio.c | 378 +++ configure| 5 - 5 files changed, 47 insertions(+), 532

[Qemu-devel] [PATCH v2 21/49] wavaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 10 + audio/wavaudio.c | 58 2 files changed, 19 insertions(+), 49 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 4d8e2b9..2004097 100644 --- a/a

[Qemu-devel] [PATCH v2 32/49] paaudio: fix playback glitches

2015-08-21 Thread Kővágó, Zoltán
Pulseaudio normally assumes that when the server wants it, the client can generate the audio samples and send it right away. Unfortunately this is not the case with QEMU -- it's up to the emulated system when does it generate the samples. Buffering the samples and sending them from a background t

[Qemu-devel] [PATCH v2 28/49] paaudio: do not move stream when sink/source name is specified

2015-08-21 Thread Kővágó, Zoltán
Unless we disable stream moving, pulseaudio can easily move the stream on connect, effectively ignoring the source/sink specified by the user. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/audio/paaudio.c b/audio/paaudio.c index c375d8

[Qemu-devel] [PATCH v2 17/49] ossaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 17 ++ audio/ossaudio.c | 153 ++- 2 files changed, 59 insertions(+), 111 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index bcf87ff..3d9f212 100644 --- a/au

[Qemu-devel] [PATCH v2 44/49] wavaudio: port to the new audio backend api

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/wavaudio.c | 55 +-- 1 file changed, 9 insertions(+), 46 deletions(-) diff --git a/audio/wavaudio.c b/audio/wavaudio.c index edc78d5..e905911 100644 --- a/audio/wavaudio.c +++ b/audio/wavaudio.c @@ -33,52

[Qemu-devel] [PATCH v2 12/49] audio: -audiodev command line option basic implementation

2015-08-21 Thread Kővágó, Zoltán
Audio drivers now get an Audiodev * as config paramters, instead of the global audio_option structs. There is some code in audio/audio_legacy.c that converts the old environment variables to audiodev options (this way backends do not have to worry about legacy options). It also contains a replace

[Qemu-devel] [PATCH v2 27/49] paaudio: do not create multiple connections to the same server

2015-08-21 Thread Kővágó, Zoltán
Reviewed-by: Marc-André Lureau Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 297 1 file changed, 171 insertions(+), 126 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index a53aaf6..c375d80 100644 --- a/audio/paaudio.c

[Qemu-devel] [PATCH v2 26/49] audio: audiodev= parameters no longer optional when -audiodev present

2015-08-21 Thread Kővágó, Zoltán
Reviewed-by: Marc-André Lureau Signed-off-by: Kővágó, Zoltán --- Changes from v1: * (probably) more clear error messages audio/audio.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 88e04bf..d7e0533 100644 --- a/aud

[Qemu-devel] [PATCH v2 20/49] spiceaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/spiceaudio.c | 5 - 1 file changed, 5 deletions(-) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index e6da29a..a9b9a1d 100644 --- a/audio/spiceaudio.c +++ b/audio/spiceaudio.c @@ -371,10 +371,6 @@ static int line_in_ctl (HWVoiceIn *hw, int cmd,

[Qemu-devel] [PATCH v2 06/49] qapi: change Netdev into a flat union

2015-08-21 Thread Kővágó, Zoltán
Except qapi-schema.json, this patch was generated by: find . -name .git -prune -o -type f \! -name '*~' -print0 | \ xargs -0 sed -i \ -e 's/NetClientOptionsKind/NetClientDriver/g' \ -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \ -e 's/netdev->opts/netdev/g' Signed-off-by: Kő

[Qemu-devel] [PATCH v2 24/49] audio: basic support for multi backend audio

2015-08-21 Thread Kővágó, Zoltán
Audio functions no longer access glob_audio_state, instead they get an AudioState as a parameter. This is required in order to support multiple backends. glob_audio_state is also gone, and replaced with a tailq so we can store more than one states. Signed-off-by: Kővágó, Zoltán --- audio/audio

[Qemu-devel] [PATCH v2 25/49] audio: add audiodev properties to frontends

2015-08-21 Thread Kővágó, Zoltán
Finally add audiodev= options to audio frontends so users can specify which backend to use when multiple backends exist. Not specifying an audiodev= option currently causes the first audiodev to be used, this is fixed in the next commit. Example usage: -audiodev pa,id=foo -device AC97,audiodev=fo

[Qemu-devel] [PATCH v2 14/49] coreaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 10 ++ audio/coreaudio.c| 47 ++- 2 files changed, 20 insertions(+), 37 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index bc830c5..4be972e 100644 --- a/audio

[Qemu-devel] [PATCH v2 22/49] audio: -audiodev command line option: cleanup

2015-08-21 Thread Kővágó, Zoltán
Remove no longer needed codes. Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 202 ++ audio/audio_int.h | 17 - 2 files changed, 4 insertions(+), 215 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 76643ed..a8269b5 10

[Qemu-devel] [PATCH v2 19/49] sdlaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c | 7 +++ audio/sdlaudio.c | 22 -- 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy.c index 3eab2b9..4d8e2b9 100644 --- a/audio/audio_legacy.c +++ b/audio/

[Qemu-devel] [PATCH v2 04/49] net: remove NetLegacy struct

2015-08-21 Thread Kővágó, Zoltán
NetLegacy is just Netdev with some extra fields (name, vlan) and an optional id. This patch merges the two structs, and net_client_init1 got some extra checks to make sure only accept valid -netdev command lines. This is some extra work, but allows us to uniformly manage both legacy -net and non-

[Qemu-devel] [PATCH v2 09/49] qapi: support nested structs in OptsVisitor

2015-08-21 Thread Kővágó, Zoltán
The current OptsVisitor flattens the whole structure, if there are same named fields under different paths (like `in' and `out' in `Audiodev'), the current visitor can't cope with them (for example setting `frequency=44100' will set the in's frequency to 44100 and leave out's frequency unspecified)

[Qemu-devel] [PATCH v2 08/49] qapi: qapi for audio backends

2015-08-21 Thread Kővágó, Zoltán
This patch adds structures into qapi to replace the existing configuration structures used by audio backends currently. This qapi will be the base of the -audiodev command line parameter (that replaces the old environment variables based config). This is not a 1:1 translation of the old options, I

[Qemu-devel] [PATCH v2 13/49] alsaaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/alsaaudio.c| 310 ++- audio/audio_legacy.c | 64 +++ 2 files changed, 148 insertions(+), 226 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index e545766..9c5dd80 100644 --- a/au

[Qemu-devel] [PATCH v2 10/49] audio: use qapi AudioFormat instead of audfmt_e

2015-08-21 Thread Kővágó, Zoltán
I had to include an enum for audio sampling formats into qapi, but that meant duplicating the audfmt_e enum. This patch replaces audfmt_e and associated values with the qapi generated AudioFormat enum. This patch is mostly a search-and-replace, except for switches where the qapi generated AUDIO_F

[Qemu-devel] [PATCH v2 00/49] audio: -audiodev option, multiple options

2015-08-21 Thread Kővágó, Zoltán
This patch series adds support to multiple audio backends. Afterwards I add support to multiple backends. Audio fronteds gain a new audiodev option to specify the id of the audiodev to use. The audiodev= option is required, unless you use the old environment variable based configuration, in that

[Qemu-devel] [PATCH v2 05/49] net: use Netdev instead of NetClientOptions in client init

2015-08-21 Thread Kővágó, Zoltán
This way we no longer need NetClientOptions and can convert Netdev into a flat union. Signed-off-by: Kővágó, Zoltán --- net/clients.h| 20 ++-- net/dump.c | 6 +++--- net/hub.c| 6 +++--- net/l2tpv3.c | 6 +++--- net/net.c| 29 ++--

[Qemu-devel] [PATCH v2 01/49] opts: produce valid command line in qemu_opts_print

2015-08-21 Thread Kővágó, Zoltán
This will let us print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list, or quoting values unnecessarily. This patch provides the following changes: * write id=, if the option h

[Qemu-devel] [PATCH v2 07/49] qapi: reorder NetdevBase and Netdev

2015-08-21 Thread Kővágó, Zoltán
Probably more logical if NetdevBase comes before Netdev. No schematic changes. Signed-off-by: Kővágó, Zoltán --- qapi-schema.json | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index efc91db

[Qemu-devel] [PATCH v2 15/49] dsoundaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio_legacy.c| 12 ++ audio/dsound_template.h | 6 ++--- audio/dsoundaudio.c | 59 ++--- 3 files changed, 32 insertions(+), 45 deletions(-) diff --git a/audio/audio_legacy.c b/audio/audio_legacy

[Qemu-devel] [PATCH v2 16/49] noaudio: port to -audiodev config

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/noaudio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 108b02d..4c94a26 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@ -161,7 +161,6 @@ static struct audio_pcm_ops no_pcm_ops = { struct audio_driver no_a

[Qemu-devel] [PATCH v2 11/49] audio: -audiodev command line option: documentation

2015-08-21 Thread Kővágó, Zoltán
This patch adds documentation of an -audiodev command line option, that deprecates the old QEMU_* environment variables for audio backend configuration. It's syntax is similar to existing options (-netdev, -device, etc): -audiodev driver_name,property=value,... Although now it's possible to sp

[Qemu-devel] [PATCH v2 02/49] qapi: support implicit structs in OptsVisitor

2015-08-21 Thread Kővágó, Zoltán
They are required for flat unions (you still have to allocate the structs). Signed-off-by: Kővágó, Zoltán --- qapi/opts-visitor.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 7ae33b3..aa68814 100644 --- a/qapi/opts-visitor.c

[Qemu-devel] [PATCH v2 03/49] qapi: convert NumaOptions into a flat union

2015-08-21 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- numa.c | 2 +- qapi-schema.json | 47 --- 2 files changed, 37 insertions(+), 12 deletions(-) diff --git a/numa.c b/numa.c index 402804b..376f990 100644 --- a/numa.c +++ b/numa.c @@ -227,7 +227,7 @@ static in

Re: [Qemu-devel] [PATCH 15/25] paaudio: do not create multiple connections to the same server

2015-08-21 Thread Marc-André Lureau
On Fri, Aug 21, 2015 at 2:41 PM, Kővágó Zoltán wrote: > True, I will remove it from this commit. But not sure if I want to remove > it completely, because it looks like pulseaudio has a tendency to > automatically move the stream on connect, even if you explicitly specify a > sink/source when con

Re: [Qemu-devel] [PATCH 12/25] audio: basic support for multi backend audio

2015-08-21 Thread Marc-André Lureau
Hi On Fri, Aug 21, 2015 at 2:23 PM, Kővágó Zoltán wrote: > Hmm. Maybe it would make more sense, but it's not how the audio system > works. The situation cyrrently (before my patch) is the following: > VNC/spice/wavcapture attaches a capture to the global AudioState and starts > recording/transm

Re: [Qemu-devel] [PATCH 22/25] audio: add mixeng option (documentation)

2015-08-21 Thread Kővágó Zoltán
2015-08-21 00:49 keltezéssel, Marc-André Lureau írta: Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: This will allow us to disable mixeng when we use a decent backend. Disabling mixeng have a few advantages: * we no longer convert the audio output from one format to another, when

Re: [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer based outputs

2015-08-21 Thread Kővágó Zoltán
Hi, 2015-08-21 00:37 keltezéssel, Marc-André Lureau írta: Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: -decr = rate_get_samples(&hw->info, &out->rate); -decr = audio_MIN(out->fsize - out->fpos, decr); - -*size = decr << 2; +*size = audio_rate_get_bytes(&hw->info,

Re: [Qemu-devel] [PATCH 19/25] paaudio: fix playback glitches

2015-08-21 Thread Kővágó Zoltán
2015-08-21 00:08 keltezéssel, Marc-André Lureau írta: Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: Pulseaudio normally assumes that when the server wants it, the client can generate the audio samples and send it right away. Unfortunately this is not the case with QEMU -- it's up t

Re: [Qemu-devel] [PATCH 18/25] audio: do not run each backend in audio_run

2015-08-21 Thread Kővágó Zoltán
Hi 2015-08-20 22:49 keltezéssel, Marc-André Lureau írta: Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: audio_run is called manually by alsa and oss backends when polling. In this case only the requesting backend should be run, not all of them. Signed-off-by: Kővágó, Zoltán ---

Re: [Qemu-devel] [PATCH 15/25] paaudio: do not create multiple connections to the same server

2015-08-21 Thread Kővágó Zoltán
Hi, 2015-08-20 21:38 keltezéssel, Marc-André Lureau írta: [snip] +flags = +PA_STREAM_INTERPOLATE_TIMING +#ifdef PA_STREAM_ADJUST_LATENCY +|PA_STREAM_ADJUST_LATENCY +#endif +|PA_STREAM_AUTO_TIMING_UPDATE; +if (dev) { +/* don't move the stream if the user sp

Re: [Qemu-devel] [PATCH] e500 ATMU register reads broken

2015-08-21 Thread Rudolf Marek
Hi all, Ping? Thanks Rudolf Dne 14.8.2015 v 13:49 Rudolf Marek napsal(a): Hi all, I noticed that ATMU register reads on E500 are broken. Due to the wrong mask, some registers cannot be read and instead some other registers are read. Please see attached patch which fixes the problem. I also n

Re: [Qemu-devel] [PATCH 12/25] audio: basic support for multi backend audio

2015-08-21 Thread Kővágó Zoltán
Hi 2015-08-20 20:01 keltezéssel, Marc-André Lureau írta: [snip] diff --git a/qemu-options.hx b/qemu-options.hx index efd57e6..60a3563 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1538,6 +1538,11 @@ everybody else. 'ignore' completely ignores the shared flag and allows everybody con

  1   2   >