Re: [Qemu-devel] [PATCH v2 for 2.5 0/3] Move target- and device specific code from monitor

2015-08-27 Thread Denis V. Lunev
On 08/27/2015 03:13 PM, Peter Maydell wrote: On 27 August 2015 at 12:27, Denis V. Lunev d...@openvz.org wrote: On 08/25/2015 12:54 PM, Denis V. Lunev wrote: On 08/12/2015 02:50 PM, Denis V. Lunev wrote: The monivation of this set is simple. Recently we have proposed patch to monitor.c with

Re: [Qemu-devel] [PATCH 2/8] qcow2: add dirty-bitmaps feature

2015-08-27 Thread Vladimir Sementsov-Ogievskiy
I've made this similar to snapshots, but now I think... Why should we maintain dirty bitmap directory in ram? This only gives us saving of one extra bdrv_read of header on loading bitmap, but is doesn't matter in comparison with reading the whole bitmap to memory. Also, the bitmap should not

Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies

2015-08-27 Thread Michael Roth
Quoting Marc-André Lureau (2015-08-27 07:49:19) Hi On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: +qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(QGA_VSS_PROVIDER) + $(call LINK, $(filter-out %.tlb %.dll, $^)) Strictly this is not

Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as protocol

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote: diff --git a/include/block/aio.h b/include/block/aio.h index bd1d44b..d02ddfa 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx); bool aio_dispatch(AioContext *ctx);

Re: [Qemu-devel] [Qemu-block] [PATCH v2 04/11] nbd: Mark fd handlers client type as nbd server

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:07PM +0800, Fam Zheng wrote: So we could distinguish it from protocol to avoid handling in nested aio polls. Signed-off-by: Fam Zheng f...@redhat.com --- include/block/aio.h | 1 + nbd.c | 4 ++-- 2 files changed, 3 insertions(+), 2

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Jeff Cody
On Thu, Aug 27, 2015 at 08:01:12AM -0600, Eric Blake wrote: On 08/27/2015 07:51 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote: Better still might be fixing things to where we add a global command line option that outright fails any attempt to

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 10:01 AM, Eric Blake wrote: On 08/27/2015 07:51 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote: Better still might be fixing things to where we add a global command line option that outright fails any attempt to create an

Re: [Qemu-devel] [PATCH 1/4] configure: qemu-ga: move MSI installer probe after qga probe

2015-08-27 Thread Marc-André Lureau
On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: MSI probe assumes that qemu-ga support has been probed already, but in cases where --enable-guest-agent/--disable-guest-agent have not been passed to configure, qemu-ga support may end up getting enabled later, as

Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies

2015-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: +qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(QGA_VSS_PROVIDER) + $(call LINK, $(filter-out %.tlb %.dll, $^)) Strictly this is not so great, but that makes sense: so perhaps a small

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Eric Blake
On 08/27/2015 07:56 AM, Programmingkid wrote: If we did have auto-generated names, we would need to come up with a scheme that is not going to clash with any existing naming that users of QEMU may already be doing, otherwise we risk causing a regression. Something as simple as what you

Re: [Qemu-devel] Should we auto-generate IDs? (was: [PATCH] qdev-monitor.c: Add device id generation)

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 9:54 AM, Daniel P. Berrange wrote: On Wed, Aug 26, 2015 at 02:01:41PM -0400, Programmingkid wrote: If a user is talking to the QEMU monitor directly there are plenty of ways to go wrong, of which forgetting to provide an ID is a really minor one. What other problems did

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-08-27 Thread Laszlo Ersek
On 06/09/15 16:05, Michael S. Tsirkin wrote: On Tue, Jun 09, 2015 at 04:02:08PM +0200, Laszlo Ersek wrote: On 06/09/15 11:49, Michael S. Tsirkin wrote: On Tue, Jun 09, 2015 at 02:02:31AM -0400, Paolo Bonzini wrote: I would just patch OVMF to ignore the RSDT if there is an XSDT.

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 10:02 AM, Eric Blake wrote: On 08/27/2015 07:56 AM, Programmingkid wrote: If we did have auto-generated names, we would need to come up with a scheme that is not going to clash with any existing naming that users of QEMU may already be doing, otherwise we risk causing a

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 10:34:05AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:02 AM, Eric Blake wrote: On 08/27/2015 07:56 AM, Programmingkid wrote: If we did have auto-generated names, we would need to come up with a scheme that is not going to clash with any existing

Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed

2015-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2015 at 3:42 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: If we keep the $enabled != no logic all the way through, $enabled, unless explicitly turned off or missing dependencies, will be undefined when the configure options are summarized via: configure: qemu-ga:

Re: [Qemu-devel] [PATCH v8 07/11] netfilter: print filter info associate with the netdev

2015-08-27 Thread Thomas Huth
On 26/08/15 11:59, Yang Hongyang wrote: From: Yang Hongyang bur...@gmail.com When execute info network, print filter info also. current info printed is simple, can add more info later. Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- v7: initial patch --- include/net/filter.h |

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-08-27 Thread Michael S. Tsirkin
On Tue, Aug 25, 2015 at 03:25:54AM +, Ouyang, Changchun wrote: Hi Michael, -Original Message- From: snabb-de...@googlegroups.com [mailto:snabb- de...@googlegroups.com] On Behalf Of Michael S. Tsirkin Sent: Thursday, August 13, 2015 5:19 PM To: Ouyang, Changchun Cc:

Re: [Qemu-devel] [PATCH v16 00/21] Deterministic replay core

2015-08-27 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini unfortunately I do have some more review comments; that can happen when going back to the code after a few months, and it's also a good thing because it means that the code _is_ actually getting cleaner. Thanks

Re: [Qemu-devel] [PATCH v4 04/13] qga: make split_list() return allocated strings

2015-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2015 at 11:17 AM, Denis V. Lunev d...@openvz.org wrote: why not to __str = g_strsplit(str, delim, -1); +strv = g_strsplit(str, delim, -1); +for (i = 0; strv[i]; i++) { +list = g_list_prepend(list, strv[i]); } +g_free(strv); g_free(__str);

Re: [Qemu-devel] [PATCH v5 7/9] crypto: introduce new module for handling TLS sessions

2015-08-27 Thread Eric Blake
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote: Introduce a QCryptoTLSSession object that will encapsulate all the code for setting up and using a client/sever TLS session. This isolates the code which depends on the gnutls library, avoiding #ifdefs in the rest of the codebase, as well as

Re: [Qemu-devel] [PATCH v8 05/11] move out net queue structs define

2015-08-27 Thread Thomas Huth
Maybe add a short comment why/where this is needed later? On 26/08/15 11:59, Yang Hongyang wrote: Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/queue.h | 19 +++ net/queue.c | 19 --- 2 files changed, 19 insertions(+), 19

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:17, Michael S. Tsirkin m...@redhat.com wrote: Basically the point is that ABI is extended to make ioeventfd with len = 0 mean any

Re: [Qemu-devel] KVM guest gets aborted if blockcommit is called

2015-08-27 Thread Jeff Cody
On Thu, Aug 27, 2015 at 11:26:13AM +0200, Christian Rößner wrote: Am 26.08.2015 um 15:25 schrieb Jeff Cody jc...@redhat.com: On Wed, Aug 26, 2015 at 10:08:26AM +0200, Christian Rößner wrote: Am 25.08.2015 um 08:02 schrieb Christian Rößner c...@roessner.co: Hello, I wrote

Re: [Qemu-devel] [PATCH COLO-Frame v8 08/34] COLO: Implement colo checkpoint protocol

2015-08-27 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: Hi Dave, On 2015/8/27 18:40, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 02:05:49PM +0300, Michael S. Tsirkin wrote: On Thu, Aug 27, 2015 at 12:01:17PM +0100, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: On Mon, Aug 24,

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 9:00 AM, Eric Blake wrote: On 08/27/2015 06:32 AM, Jeff Cody wrote: (Added Eric back in to the CC list. Looks like he got dropped somewhere along the way) No thanks to mailman's inept behavior that thinks that it is okay to rewrite cc's to drop anyone that doesn't

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote: On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote: On the generation scheme proposed above: I understand that something you desire is an ID that is easier to type. If we wanted to make it shorter, perhaps we could

Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies

2015-08-27 Thread Marc-André Lureau
On Thu, Aug 27, 2015 at 3:46 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: Will add a comment either way, but perhaps something like: thanks qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(QGA_VSS_PROVIDER) $(call LINK, $(filter-out $(QGA_VSS_PROVIDER), $^)) would be

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 09:56:47AM -0400, Programmingkid wrote: On Aug 27, 2015, at 9:49 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote: On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote: On the generation scheme proposed above: I

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Jeff Cody
On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote: On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote: [snip] I'm not married to the ID generation scheme I proposed. What I am trying to do, however, is have a technical discussion on generating an ID in a well-formed

Re: [Qemu-devel] [PATCH v8 04/11] netfilter: hook packets before net queue send

2015-08-27 Thread Thomas Huth
On 26/08/15 11:59, Yang Hongyang wrote: Capture packets that will be sent. Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- v5: do not check ret against iov_size pass sent_cb to filters --- net/net.c | 66 +++ 1

Re: [Qemu-devel] [PATCH 2/4] vnc: allow the Buffer to shrink again

2015-08-27 Thread Peter Lieven
Am 27.08.2015 um 12:39 schrieb Daniel P. Berrange: On Thu, Aug 27, 2015 at 12:18:52PM +0200, Peter Lieven wrote: currently the Buffer can only grow. This increases Qemu memory footprint dramatically since normally the biggest VNC updates are at connection time. But also after a VNC session has

Re: [Qemu-devel] [PATCH 4/4] Makefile: qemu-ga: fix msi target error message

2015-08-27 Thread Marc-André Lureau
On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: + @echo MSI build not configured or dependency resolution failed (reconfigure with --enable-guest-agent-msi option) Reviewed-by: Marc-André Lureau marcandre.lur...@redhat.com -- Marc-André Lureau

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Eric Blake
On 08/27/2015 06:32 AM, Jeff Cody wrote: (Added Eric back in to the CC list. Looks like he got dropped somewhere along the way) No thanks to mailman's inept behavior that thinks that it is okay to rewrite cc's to drop anyone that doesn't want duplicate email. But don't worry about it; I have

Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed

2015-08-27 Thread Michael Roth
Quoting Marc-André Lureau (2015-08-27 07:41:17) Hi On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: This makes it easier to report on whether or not MSI support was enabled via probe by looking at the ./configure summary. Sorry I don't get what that

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:17, Michael S. Tsirkin m...@redhat.com wrote: Basically the point is

Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed

2015-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: This makes it easier to report on whether or not MSI support was enabled via probe by looking at the ./configure summary. Sorry I don't get what that really changes. Otherwise the patch looks fine. --

Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/11] aio: Introduce type in aio_set_fd_handler and aio_set_event_notifier

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:04PM +0800, Fam Zheng wrote: The parameter is added but not used. The callers are converted with following coccinelle semantic patch: @@ expression E1, E2, E3, E4, E5; @@ ( -aio_set_event_notifier(E1, E2, E3)

Re: [Qemu-devel] [Qemu-block] [PATCH v2 02/11] aio: Save type to AioHandler

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:05PM +0800, Fam Zheng wrote: So it can be used by aio_poll later. Signed-off-by: Fam Zheng f...@redhat.com --- aio-posix.c | 2 ++ aio-win32.c | 3 +++ 2 files changed, 5 insertions(+) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote: Better still might be fixing things to where we add a global command line option that outright fails any attempt to create an unnamed object. The option would be off by default for back-compat. But management apps like

Re: [Qemu-devel] Should we auto-generate IDs? (was: [PATCH] qdev-monitor.c: Add device id generation)

2015-08-27 Thread Daniel P. Berrange
On Wed, Aug 26, 2015 at 02:01:41PM -0400, Programmingkid wrote: If a user is talking to the QEMU monitor directly there are plenty of ways to go wrong, of which forgetting to provide an ID is a really minor one. What other problems did you have in mind? That's why it is generally left

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 9:49 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote: On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote: On the generation scheme proposed above: I understand that something you desire is an ID that is easier to type. If

Re: [Qemu-devel] add multiple times opening support to a virtserialport

2015-08-27 Thread Christopher Covington
On 07/24/2015 08:00 AM, Matt Ma wrote: Hi all, Linaro has developed the foundation for the new Android Emulator code base based on a fairly recent upstream QEMU code base, when we re-based the code, we updated the device model to be more virtio based (for example the drives are now virtio

Re: [Qemu-devel] [PULL 0/1] tci queue

2015-08-27 Thread Peter Maydell
On 26 August 2015 at 20:08, Stefan Weil s...@weilnetz.de wrote: The following changes since commit 47c9dfee808f9455d732aea7c4390ad0972bbd84: Merge remote-tracking branch 'remotes/kraxel/tags/pull-cve-2015-5225-20150826-1' into staging (2015-08-26 17:45:09 +0100) are available in the git

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:17, Michael S. Tsirkin m...@redhat.com wrote: Basically the point is that ABI is extended to make ioeventfd with len = 0 mean any length. 0 is thus not meaningless anymore. But how can you do

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Jeff Cody
(Added Eric back in to the CC list. Looks like he got dropped somewhere along the way) On Wed, Aug 26, 2015 at 11:22:08PM -0400, Programmingkid wrote: On Aug 26, 2015, at 6:01 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote: On Aug 26, 2015, at

[Qemu-devel] [PATCH] vnc: allow fall back to RAW encoding

2015-08-27 Thread Peter Lieven
I have observed that depending on the contents and the encoding it happens that sending data as RAW sometimes would take less space than the encoded data. This is especially the case for small updates or areas with high color images. If sending RAW encoded data is beneficial allow a fall back to

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Greg Kurz
On Thu, 27 Aug 2015 15:30:55 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: On 27 August 2015 at 13:25, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell wrote: On 27 August

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote: (Added Eric back in to the CC list. Looks like he got dropped somewhere along the way) On Wed, Aug 26, 2015 at 11:22:08PM -0400, Programmingkid wrote: On Aug 26, 2015, at 6:01 PM, Jeff Cody wrote: On Wed, Aug 26, 2015 at 02:17:17PM -0400,

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 9:51 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote: Better still might be fixing things to where we add a global command line option that outright fails any attempt to create an unnamed object. The option would be off by

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Eric Blake
On 08/27/2015 07:51 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:39:10AM -0400, Programmingkid wrote: Better still might be fixing things to where we add a global command line option that outright fails any attempt to create an unnamed object. The option would be off by default

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-27 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 03:50:02PM -0600, Chris Friesen wrote: The only limit I see in the whole call chain from virtio_blk_handle_request() on down is the call to bdrv_io_limits_intercept() in bdrv_co_do_writev(). However, that doesn't provide any limit on the absolute number of inflight

Re: [Qemu-devel] [PATCH] target-arm: Break the TB after IC invalidation to execute self-modified code correctly

2015-08-27 Thread Peter Maydell
On 26 August 2015 at 12:36, Sergey Sorokin afaral...@yandex.ru wrote: If any store instruction writes the code inside the same TB after this store insn, the execution of the TB must be stopped to execute new code correctly. As described in ARMv8 manual D3.4.6 a self-modified code need to do

[Qemu-devel] [PATCH, RFC v2] Use help sub-sections to create sub-help options

2015-08-27 Thread Laurent Vivier
As '-help' output is 400 lines long it is not easy to find information, but generally we know from which area we want the information. As subsections already exist in the help description, add some command options to only display the wanted subsection. As more is better, this patch adds 13 lines

Re: [Qemu-devel] [PATCH 1/3] hmp-commands-info: move info_cmds content out of monitor.c

2015-08-27 Thread Peter Maydell
On 12 August 2015 at 12:50, Denis V. Lunev d...@openvz.org wrote: From: Pavel Butsykin pbutsy...@virtuozzo.com For moving target- and device-specific code from monitor.c, to beginning we move info_cmds content to hmp-commands-info.hx Signed-off-by: Pavel Butsykin pbutsy...@virtuozzo.com

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Eduardo Habkost
On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: John Snow js...@redhat.com writes: On 08/19/2015 02:55 AM, Dr. David Alan Gilbert

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-27 Thread Richard Henderson
On 08/26/2015 10:54 PM, Dennis Luehring wrote: Am 26.08.2015 um 21:47 schrieb Richard Henderson: Anyway, this sort of setup is exactly what I did for Alpha. The PALcode (hypervisor-ish) layer used for qemu looks nothing like the PALcode layer used for real hardware. can post your qemu

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 12:03:38PM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:55 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 11:22:58AM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:19 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 11:13:25AM -0400,

Re: [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

2015-08-27 Thread John Snow
On 08/27/2015 11:29 AM, Eric Blake wrote: On 08/27/2015 09:17 AM, Peter Maydell wrote: I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse files. In particular, OSX's HFS+

Re: [Qemu-devel] [PATCH 3/3] monitor: added generation of documentation for hmp-commands-info.hx

2015-08-27 Thread Peter Maydell
On 12 August 2015 at 12:50, Denis V. Lunev d...@openvz.org wrote: From: Pavel Butsykin pbutsy...@virtuozzo.com It will be easier if you need to add info-commands to edit only hmp-commands-info.hx, before this had to edit monitor.c and hmp-commands.hx Signed-off-by: Pavel Butsykin

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-08-27 Thread Peter Maydell
On 23 August 2015 at 00:47, Stefan Brüns stefan.bru...@rwth-aachen.de wrote: Instead of creating a temporary copy for the whole environment and the arguments, directly copy everything to the target stack. For this to work, we have to change the order of stack creation and copying the

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 12:22 PM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 12:08:25PM -0400, Programmingkid wrote: On Aug 27, 2015, at 12:02 PM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 11:58:22AM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:40 AM, Jeff Cody wrote:

Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/11] aio: Mark ctx-notifier's client type as context

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:08PM +0800, Fam Zheng wrote: It is important to include this for any blocking poll, on the other hand it is also OK to exclude it otherwise. Signed-off-by: Fam Zheng f...@redhat.com --- async.c | 4 ++-- include/block/aio.h | 1 + 2 files

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-27 Thread Peter Maydell
On 12 August 2015 at 12:50, Denis V. Lunev d...@openvz.org wrote: From: Pavel Butsykin pbutsy...@virtuozzo.com Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The solution is quite simple, but solves the issue of

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 04:27:00PM +0200, Laszlo Ersek wrote: On 06/09/15 16:05, Michael S. Tsirkin wrote: On Tue, Jun 09, 2015 at 04:02:08PM +0200, Laszlo Ersek wrote: On 06/09/15 11:49, Michael S. Tsirkin wrote: On Tue, Jun 09, 2015 at 02:02:31AM -0400, Paolo Bonzini wrote: I would just

Re: [Qemu-devel] Lockups with 4.2-rc kernels and qemu

2015-08-27 Thread Ken Moffat
On Thu, Aug 27, 2015 at 12:59:14PM +0100, Ken Moffat wrote: On Tue, Aug 25, 2015 at 12:40:15AM +0100, Ken Moffat wrote: (Cc'ing qemu-devel, please keep me in the Cc). TL;DR - qemu locks up my machine when I use 4.2-rc kernels. Previous mail, or at least the copy to qemu, archived at

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-27 Thread Stefan Hajnoczi
On Thu, Aug 27, 2015 at 5:48 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Aug 25, 2014 at 03:50:02PM -0600, Chris Friesen wrote: On 08/23/2014 01:56 AM, Benoît Canet wrote: The Friday 22 Aug 2014 à 18:59:38 (-0600), Chris Friesen wrote : On 07/21/2014 10:10 AM, Benoît Canet wrote:

Re: [Qemu-devel] [PATCH v2 07/11] aio-posix: introduce aio_{disable, enable}_clients

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:10PM +0800, Fam Zheng wrote: +void aio_disable_enable_clients(AioContext *ctx, int clients_mask, +bool is_disable) +{ +AioHandler *node; +aio_context_acquire(ctx); + +QLIST_FOREACH(node, ctx-aio_handlers, node) { +

Re: [Qemu-devel] [PATCH v2] monitor: allow object_del device_del to accept QOM paths

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 12:13 PM, Daniel P. Berrange wrote: Currently both object_del and device_del require that the client provide the object/device short ID. While user creatable objects require an ID to be provided at time of creation, qdev devices may be created without giving an ID. The

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-27 Thread Denis V. Lunev
On 08/27/2015 08:31 PM, Peter Maydell wrote: On 12 August 2015 at 12:50, Denis V. Lunev d...@openvz.org wrote: From: Pavel Butsykin pbutsy...@virtuozzo.com Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The

Re: [Qemu-devel] [PATCH] linux-user: fix host_to_target_cmsg in case of multiple headers

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 15:50, Jonathan Neuschäfer j.neuschae...@gmx.net wrote: In the current implementation, __target_cmsg_nxthdr compares a pointer derived from target_cmsg against the msg_control field of target_msgh (through subtraction). This failed for me when emulating i386 code under

Re: [Qemu-devel] [Qemu-block] [PATCH v2 06/11] dataplane: Mark host notifiers' client type as dataplane

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:09PM +0800, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- hw/block/dataplane/virtio-blk.c | 4 ++-- hw/scsi/virtio-scsi-dataplane.c | 16 include/block/aio.h | 1 + 3 files changed, 11 insertions(+), 10

Re: [Qemu-devel] [Qemu-block] [PATCH v2 09/11] block: Introduce bdrv_aio_poll

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:12PM +0800, Fam Zheng wrote: This call is introduced simply as a wrapper of aio_poll, but it makes it is easy to change the polled client types. Signed-off-by: Fam Zheng f...@redhat.com --- block/io.c| 8 include/block/aio.h | 2 +-

Re: [Qemu-devel] [PATCH v3] i386: keep cpu_model field in MachineState uptodate

2015-08-27 Thread Eduardo Habkost
On Thu, Aug 27, 2015 at 05:27:05PM +0800, Zhu Guihua wrote: Update cpu_model in MachineState for i386, so that the field can be used for cpu hotplug, instead of using a static variable. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com --

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 10:42 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 10:34:05AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:02 AM, Eric Blake wrote: On 08/27/2015 07:56 AM, Programmingkid wrote: If we did have auto-generated names, we would need to come up with a

Re: [Qemu-devel] [PATCH, RFC] Use help sub-sections to create sub-help options

2015-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2015 at 5:20 PM, Laurent Vivier lviv...@redhat.com wrote: As '-help' output is 400 lines long it is not easy to find information, but generally we know from which area we want the information. As subsections already exist in the help description, add some command options

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 12:02 PM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 11:58:22AM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:40 AM, Jeff Cody wrote: On Thu, Aug 27, 2015 at 11:20:20AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:42 AM, Daniel P. Berrange wrote:

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 11:58:22AM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:40 AM, Jeff Cody wrote: On Thu, Aug 27, 2015 at 11:20:20AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:42 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 10:34:05AM -0400,

Re: [Qemu-devel] [PATCH v2] monitor: allow object_del device_del to accept QOM paths

2015-08-27 Thread Eric Blake
On 08/27/2015 10:13 AM, Daniel P. Berrange wrote: Currently both object_del and device_del require that the client provide the object/device short ID. While user creatable objects require an ID to be provided at time of creation, qdev devices may be created without giving an ID. The only

Re: [Qemu-devel] [PATCH v8 06/11] netfilter: add an API to pass the packet to next filter

2015-08-27 Thread Thomas Huth
On 26/08/15 11:59, Yang Hongyang wrote: add an API qemu_netfilter_pass_to_next() to pass the packet to next filter. Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- v5: fold params to NetPacket struct --- include/net/filter.h | 3 +++ net/filter.c | 33

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 11:19 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 11:13:25AM -0400, Programmingkid wrote: What is wrong with having a predictable ID? As Daniel and Eric have noted, it could be nice to have a predictable ID. My concern with a predictable ID is that it

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 1:39 AM, Markus Armbruster wrote: Programmingkid programmingk...@gmail.com writes: On Aug 26, 2015, at 6:08 PM, John Snow wrote: On 08/26/2015 05:48 PM, Programmingkid wrote: On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote: On 26 August 2015 at 18:16,

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Jeff Cody
On Thu, Aug 27, 2015 at 11:20:20AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:42 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 10:34:05AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:02 AM, Eric Blake wrote: On 08/27/2015 07:56 AM, Programmingkid wrote:

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 11:22:58AM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:19 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 11:13:25AM -0400, Programmingkid wrote: What is wrong with having a predictable ID? As Daniel and Eric have noted, it could be nice to

Re: [Qemu-devel] [PATCH v14 0/8] i.MX: Add i.MX25 support through the PDK evaluation board

2015-08-27 Thread Peter Maydell
On 10 August 2015 at 23:02, Jean-Christophe Dubois j...@tribudubois.net wrote: This series of patches is generated against Peter Maydell GIT tree: https://git.linaro.org/people/peter.maydell/qemu-arm.git branch target-arm-post-2.4 This series of patches add the support for the i.MX25

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 12:08:25PM -0400, Programmingkid wrote: On Aug 27, 2015, at 12:02 PM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 11:58:22AM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:40 AM, Jeff Cody wrote: On Thu, Aug 27, 2015 at 11:20:20AM -0400,

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-08-27 Thread Stefan Bruens
On Sunday 23 August 2015 01:47:52 Stefan Brüns wrote: Instead of creating a temporary copy for the whole environment and the arguments, directly copy everything to the target stack. For this to work, we have to change the order of stack creation and copying the arguments. Signed-off-by:

Re: [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file

2015-08-27 Thread Denis V. Lunev
On 08/27/2015 02:34 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Hi, The following patches for the qemu agent add support for an optionnal configuration file, and a man page. v3-v4: - some spelling fixes - add a patch to allocate in split_list() -

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 10:07 AM, Jeff Cody wrote: On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote: On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote: [snip] I'm not married to the ID generation scheme I proposed. What I am trying to do, however, is have a technical

[Qemu-devel] [PATCH] linux-user: fix host_to_target_cmsg in case of multiple headers

2015-08-27 Thread Jonathan Neuschäfer
In the current implementation, __target_cmsg_nxthdr compares a pointer derived from target_cmsg against the msg_control field of target_msgh (through subtraction). This failed for me when emulating i386 code under x86_64, because pointers in the host address space and pointers in the guest

Re: [Qemu-devel] coroutine pool memory usage

2015-08-27 Thread Paolo Bonzini
i was debugging increased memory footprint of qemu over the past time and found that the coroutine pool heap usage can grow up to 70MB by just booting an Ubuntu Live CD. And those 70MB are never freed. Is this expected? Wouldn't it make sense to asynchronically throw some coroutines (or at

Re: [Qemu-devel] hd-geo-test creates 4GB files on FSes that don't support sparse images, doesn't delete them on error

2015-08-27 Thread Eric Blake
On 08/27/2015 09:17 AM, Peter Maydell wrote: I've noticed recently that tests/hd-geo-test.c creates test disk images which are 4GB in size, which is a problem if the filesystem on the host doesn't support sparse files. In particular, OSX's HFS+ doesn't have sparse file support, and Windows

Re: [Qemu-devel] coroutine pool memory usage

2015-08-27 Thread Peter Lieven
Am 27.08.2015 um 17:23 schrieb Paolo Bonzini: i was debugging increased memory footprint of qemu over the past time and found that the coroutine pool heap usage can grow up to 70MB by just booting an Ubuntu Live CD. And those 70MB are never freed. Is this expected? Wouldn't it make sense to

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 11:40 AM, Jeff Cody wrote: On Thu, Aug 27, 2015 at 11:20:20AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:42 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 10:34:05AM -0400, Programmingkid wrote: On Aug 27, 2015, at 10:02 AM, Eric Blake wrote: On

Re: [Qemu-devel] [PATCH] monitor: allow object_del device_del to accept QOM paths

2015-08-27 Thread Eric Blake
On 08/27/2015 09:37 AM, Daniel P. Berrange wrote: Currently both object_del and device_del require that the client provide the object/device short ID. While user creatable objects require an ID to be provided at time of creation, qdev devices may be created without giving an ID. The only

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 10:06 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:56:47AM -0400, Programmingkid wrote: On Aug 27, 2015, at 9:49 AM, Daniel P. Berrange wrote: On Thu, Aug 27, 2015 at 09:33:42AM -0400, Programmingkid wrote: On Aug 27, 2015, at 8:32 AM, Jeff Cody wrote:

Re: [Qemu-devel] [PATCH v8 08/11] net/queue: export qemu_net_queue_append_iov

2015-08-27 Thread Thomas Huth
Maybe add a short description why/where this will be needed? On 26/08/15 11:59, Yang Hongyang wrote: Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/queue.h | 7 +++ net/queue.c | 12 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-27 Thread Artyom Tarasenko
On Tue, Jul 28, 2015 at 9:52 AM, Dennis Luehring dl.so...@gmx.net wrote: (i've posted the question already on qemu-disc...@nongnu.org but was toled to better use this mailing list) i've prepared an Debian 7.8.0 image for SPARC64/qemu emulation for C/C++ development before-real-hardware

[Qemu-devel] [PATCH] monitor: allow object_del device_del to accept QOM paths

2015-08-27 Thread Daniel P. Berrange
Currently both object_del and device_del require that the client provide the object/device short ID. While user creatable objects require an ID to be provided at time of creation, qdev devices may be created without giving an ID. The only unique identifier they would then have is the QOM object

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-27 Thread Artyom Tarasenko
On Wed, Aug 26, 2015 at 9:47 PM, Richard Henderson r...@twiddle.net wrote: On 08/26/2015 09:17 AM, Artyom Tarasenko wrote: After some debugging I think it's caused by memory faults. On every MMU miss / access fault TB is re-translated multiple times till the faulting instruction is found.

  1   2   3   >