Re: [Qemu-devel] [RFC PATCH v4 07/11] spapr: Enable CPU hotplug for pseries-2.5 and add CPU DRC DT entries

2015-09-04 Thread David Gibson
On Thu, Aug 06, 2015 at 10:57:13AM +0530, Bharata B Rao wrote: > Start supporting CPU hotplug from pseries-2.5 onwards. Add CPU > DRC (Dynamic Resource Connector) device tree entries. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson -- David Gibson| I'll have my

Re: [Qemu-devel] [RFC PATCH v4 08/11] spapr: CPU hotplug support

2015-09-04 Thread David Gibson
On Thu, Aug 06, 2015 at 10:57:14AM +0530, Bharata B Rao wrote: > Support CPU hotplug via device-add command. Set up device tree > entries for the hotplugged CPU core and use the exising EPOW event > infrastructure to send CPU hotplug notification to the guest. > > Create only cores explicitly from

Re: [Qemu-devel] [PATCH RFC v4 02/32] qapi: New QAPISchema intermediate reperesentation

2015-09-04 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Sep 03, 2015 at 04:29:53PM +0200, Markus Armbruster wrote: >> The QAPI code generators work with a syntax tree (nested dictionaries) >> plus a few symbol tables (also dictionaries) on the side. >> >> They have clearly outgrown these simple data structures.

Re: [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets activated

2015-09-04 Thread Shmulik Ladkani
Hi Stefan, On Wed, 2 Sep 2015 14:48:57 +0100 Stefan Hajnoczi wrote: > On Thu, Aug 20, 2015 at 02:45:47AM +0800, Fam Zheng wrote: > > Looks like the previous patch to fix this fell between the cracks and never > > made it to qemu.git? > > > > http://patchwork.ozlabs.org/patch/489847/ > > > > Ste

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-09-04 Thread Pavel Fedin
Hi! > Something in your patch submission path seems to be wrapping long > lines. It would be nice if you could fix it -- I couldn't apply this > patch without manually editing it first. Damn, stupid Outlook... I already set maximum width to ~100, ok, will increase it further. > We should add

Re: [Qemu-devel] [PATCH RFC v4 29/32] qapi: Pseudo-type '**' is now unused, drop it

2015-09-04 Thread Markus Armbruster
Eric Blake writes: > On 09/03/2015 08:30 AM, Markus Armbruster wrote: >> 'gen': false needs to stay for now, because netdev_add is still using >> it. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- > >> +++ b/tests/Makefile >> @@ -228,7 +228,7 @@ check-qapi-schema-y :=

Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection

2015-09-04 Thread Markus Armbruster
Michael Roth writes: > Quoting Eric Blake (2015-09-03 15:50:16) >> On 09/03/2015 08:30 AM, Markus Armbruster wrote: >> > qapi/introspect.json defines the introspection schema. It's designed >> > for QMP introspection, but should do for similar uses, such as QGA. >> >> [review to follow in separ

Re: [Qemu-devel] [RFC PATCH v4 09/11] spapr: Support topologies with unfilled cores

2015-09-04 Thread David Gibson
On Thu, Aug 06, 2015 at 10:57:15AM +0530, Bharata B Rao wrote: > QEMU currently supports CPU topologies where there can be cores > which are not completely filled with all the threads as per the > specifed SMT mode. > > Restore support for such topologies (Eg -smp 15,cores=4,threads=4) > The last

Re: [Qemu-devel] [RFC PATCH v0 3/3] spapr: Memory hot-unplug support

2015-09-04 Thread David Gibson
On Wed, Aug 19, 2015 at 12:26:11PM +0530, Bharata B Rao wrote: > Add support to hot remove pc-dimm memory devices. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 114 > - > hw/ppc/spapr_drc.c | 21 + > include/hw/pp

Re: [Qemu-devel] [RFC PATCH v0 2/3] spapr-rtas: Enable rtas_set_indicator() to return correct error

2015-09-04 Thread David Gibson
On Wed, Aug 19, 2015 at 12:26:10PM +0530, Bharata B Rao wrote: > drck->set_isolation_state() can return error. For such a case ensure > correct error is returned by rtas_set_indicator() instead of always > returning success. > > TODO: rtas_st(, , uint32 val) => the return value uint32, but > drck-

Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine

2015-09-04 Thread Pavel Fedin
Hello! > Why have separate ITS_CONTROL and ITS_TRANSLATION entries, given > that the ITS pages are architecturally required to be contiguous > and the dt binding doesn't require you to specify the two addresses > separately? It is more convenient for ITS implementation. I already have the code

Re: [Qemu-devel] QEMU+Aarch64: in_asm log skips instructions of loop-programs

2015-09-04 Thread Sergey Smolov
03.09.2015 19:35, Peter Maydell пишет: On 3 September 2015 at 15:31, Sergey Smolov wrote: Do you think it is possible to implement another QEMU logger which will make a record for every executed block, Yes (this would just need to disable the TB linking optimisation, which we've discussed pr

[Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/

2015-09-04 Thread Sai Pavan Boddu
For a easy creation of device directly form sdhci, without building a wrapper around. Signed-off-by: Sai Pavan Boddu --- hw/sd/sdhci.c | 2 +- {hw/sd => include/hw}/sdhci.h | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename {hw/sd => include/hw}/sdhci.h (100%) diff --g

[Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Alex Bennée
Hi, At KVM Forum I sat down with Paolo and Frederic and we came up with the current outstanding tasks on MTTCG. This is not comprehensive but hopefully covers the big areas. They are sorted in rough order we'd like to get them up-streamed. * linux-user patches (Paolo) Paolo has already grabbed a

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Frederic Konrad
Hi Alex, On 04/09/2015 09:49, Alex Bennée wrote: Hi, At KVM Forum I sat down with Paolo and Frederic and we came up with the current outstanding tasks on MTTCG. This is not comprehensive but hopefully covers the big areas. They are sorted in rough order we'd like to get them up-streamed. * lin

Re: [Qemu-devel] [PATCH] cpus.c: qemu_mutex_lock_iothread fix race condition at cpu thread init

2015-09-04 Thread Paolo Bonzini
On 03/09/2015 22:48, Aníbal Limón wrote: > When QEMU starts the RCU thread executes qemu_mutex_lock_thread > causing error "qemu:qemu_cpu_kick_thread: No such process" and exits. > > This isn't occur frequently but in glibc the thread id can exist and > this not guarantee that the thread is on a

Re: [Qemu-devel] [RFC PATCH v4 09/11] spapr: Support topologies with unfilled cores

2015-09-04 Thread Thomas Huth
On 04/09/15 09:01, David Gibson wrote: > On Thu, Aug 06, 2015 at 10:57:15AM +0530, Bharata B Rao wrote: >> QEMU currently supports CPU topologies where there can be cores >> which are not completely filled with all the threads as per the >> specifed SMT mode. >> >> Restore support for such topologi

Re: [Qemu-devel] [PATCH v12 2/5] intc/gic: Extract some reusable vGIC code

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 07:54, Pavel Fedin wrote: > Hello! > >> > + >> > +#define kvm_gicd_access(s, offset, cpu, val, write) \ >> > +kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_DIST_REGS, \ >> > + KVM_VGIC_ATTR(offset, cpu), val, write) >> > + >> > +#define kvm_gicc

Re: [Qemu-devel] [RFC 26/38] cpu: protect tb_jmp_cache with seqlock

2015-09-04 Thread Paolo Bonzini
On 24/08/2015 02:23, Emilio G. Cota wrote: > This paves the way for a lockless tb_find_fast. Having now reviewed the patch, I think we can do better. The idea is: - only the CPU thread can set cpu->tb_jmp_cache[] - other threads can, under seqlock protection, _clear_ cpu->tb_jmp_cache[] - th

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 08:13, Pavel Fedin wrote: >> We should add a note to QEMU's changelog to mention that if >> they have a 32-bit kernel on the virt board and the PCI has >> stopped working then they need to use this option. >> (http://wiki.qemu.org/ChangeLog/2.5) > > I tried to, but "log in"

Re: [Qemu-devel] [PATCH RFC v4 02/32] qapi: New QAPISchema intermediate reperesentation

2015-09-04 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 09:12:09AM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, Sep 03, 2015 at 04:29:53PM +0200, Markus Armbruster wrote: > > Python has a nice tool called pep8 which can apply a > > configurable bunch of style checks, it is probably > > worth som

Re: [Qemu-devel] [PATCH 07/10] s390: Rename s390-ccw-virtio-2.4 class name to use MACHINE_TYPE_NAME

2015-09-04 Thread Christian Borntraeger
Am 20.08.2015 um 23:54 schrieb Eduardo Habkost: > Machine class names should use the "-machine" suffix to allow > class-name-based machine class lookup to work. Rename the > s390-ccw-virtio-2.4 machine class using the MACHINE_TYPE_NAME macro. > > Cc: Alexander Graf > Cc: Cornelia Huck > Cc: Chri

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-09-04 Thread Pavel Fedin
Hi! > Yeah, we only let people with accounts create new ones, to > avoid spam. If you tell me what username you'd like I'll > create an account for you. p.fedin or pfedin, depending on whether dots are allowed or not. > Can you test this reasonably soon, please? Otherwise > I'll have to drop i

Re: [Qemu-devel] [sheepdog] [PATCH 2/2] sheepdog: refine discard support

2015-09-04 Thread Hitoshi Mitake
On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov wrote: > 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake : >> This patch refines discard support of the sheepdog driver. The >> existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, which >> was introduced before fine grained reference counting o

Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 08:26, Pavel Fedin wrote: > Hello! > >> Why have separate ITS_CONTROL and ITS_TRANSLATION entries, given >> that the ITS pages are architecturally required to be contiguous >> and the dt binding doesn't require you to specify the two addresses >> separately? > > It is more

[Qemu-devel] [PATCH 1/4] virtio: ring sizes vs. reset

2015-09-04 Thread Cornelia Huck
We allow guests to change the size of the virtqueue rings by supplying a number of buffers that is different from the number of buffers the device was initialized with. Current code has some problems, however, since reset does not reset the ringsizes to the default values (as this is not saved anyw

[Qemu-devel] [PATCH 0/4] virtio-1/virtio-ccw related patches

2015-09-04 Thread Cornelia Huck
Hi, here's a set of patches for virtio-core and virtio-ccw, fixing a common code issue and finally enabling virtio-1 for ccw devices. The first issue was noted by Jason: We need to care about changed ring sizes. We also want to support different ring sizes in ccw for virtio-1 devices (existing co

[Qemu-devel] [PATCH 4/4] virtio-ccw: enable virtio-1

2015-09-04 Thread Cornelia Huck
Let's enable revision 1 for virtio-ccw devices. We can always offer VERSION_1 as drivers in legacy mode won't be able to see it anyway. We have to introduce a way to set a lower maximum revision for a device to accommodate the following cases: - compat machines (to enforce legacy only) - virtio-bl

[Qemu-devel] [PATCH 2/4] virtio-ccw: support ring size changes

2015-09-04 Thread Cornelia Huck
Wire up changing the ring size for virtio-1 devices. Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index d36373e..85e2a5d 100644 --- a/hw/s390x/virtio-ccw.c +

Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection

2015-09-04 Thread Markus Armbruster
Michael Roth writes: > Quoting Markus Armbruster (2015-09-03 09:30:21) >> qapi/introspect.json defines the introspection schema. It's designed >> for QMP introspection, but should do for similar uses, such as QGA. >> >> The introspection schema does not reflect all the rules and >> restrictions

[Qemu-devel] [PATCH 3/4] virtio-ccw: feature bits > 31 handling

2015-09-04 Thread Cornelia Huck
We currently switch off the VERSION_1 feature bit if the guest has not negotiated at least revision 1. As no feature bits beyond 31 are valid however unless VERSION_1 has been negotiated, make sure that legacy guests never see a feature bit beyond 31. Signed-off-by: Cornelia Huck --- hw/s390x/vi

Re: [Qemu-devel] [PATCH V4 6/8] Introduce xilinx dpdma.

2015-09-04 Thread Frederic Konrad
On 04/09/2015 01:34, Alistair Francis wrote: On Thu, Sep 3, 2015 at 12:28 AM, Frederic Konrad wrote: On 02/09/2015 23:39, Alistair Francis wrote: On Tue, Jul 21, 2015 at 10:17 AM, wrote: From: KONRAD Frederic This is the implementation of the DPDMA. Signed-off-by: KONRAD Frederic ---

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Paolo Bonzini
On 04/09/2015 09:49, Alex Bennée wrote: > * Signal free qemu_cpu_kick (Paolo) > > I don't know much about this patch set but I assume this avoids the need > to catch signals and longjmp about just to wake up? It was part of Fred's patches, so I've extracted it to its own series. Removing 150 li

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-09-04 Thread Pavel Fedin
Hello! > Can you test this reasonably soon, please? Otherwise > I'll have to drop it from target-arm again. Tested, confirm, the problem persists with Linux v4.1.4, LPAE disabled: --- cut --- PCI host bridge /pcie@1000 ranges: IO 0x3eff..0x3eff -> 0x MEM 0x1000..0x3

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Edgar E. Iglesias
On Fri, Sep 04, 2015 at 11:25:33AM +0200, Paolo Bonzini wrote: > > > On 04/09/2015 09:49, Alex Bennée wrote: > > * Signal free qemu_cpu_kick (Paolo) > > > > I don't know much about this patch set but I assume this avoids the need > > to catch signals and longjmp about just to wake up? > > It wa

Re: [Qemu-devel] [PATCH v15 01/33] linux-user: tilegx: Firstly add architecture related features

2015-09-04 Thread Chen Gang
On 9/3/15 22:53, Eric Blake wrote: > On 09/02/2015 07:30 PM, Richard Henderson wrote: >> From: Chen Gang > > s/Firstly add/Add/ in the subject line > Thank you for your careful notification. :-) I guess, it will be modified by RTH, before the patches v15 (or v16) are integrated into qemu master

Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection

2015-09-04 Thread Markus Armbruster
Eric Blake writes: > On 09/03/2015 08:30 AM, Markus Armbruster wrote: >> qapi/introspect.json defines the introspection schema. It's designed >> for QMP introspection, but should do for similar uses, such as QGA. > > [review in this sub-thread; for comments on 'int' munging or other > followups,

Re: [Qemu-devel] [sheepdog] [PATCH 2/2] sheepdog: refine discard support

2015-09-04 Thread Hitoshi Mitake
On Fri, Sep 4, 2015 at 5:51 PM, Hitoshi Mitake wrote: > On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov wrote: >> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake : >>> This patch refines discard support of the sheepdog driver. The >>> existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, whic

Re: [Qemu-devel] [RFC 26/38] cpu: protect tb_jmp_cache with seqlock

2015-09-04 Thread Paolo Bonzini
On 04/09/2015 10:50, Paolo Bonzini wrote: > Having now reviewed the patch, I think we can do better. > > The idea is: > > - only the CPU thread can set cpu->tb_jmp_cache[] > > - other threads can, under seqlock protection, _clear_ cpu->tb_jmp_cache[] > > - the seqlock can be protected by tb_l

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Mark Burton
> On 4 Sep 2015, at 11:41, Edgar E. Iglesias wrote: > > On Fri, Sep 04, 2015 at 11:25:33AM +0200, Paolo Bonzini wrote: >> >> >> On 04/09/2015 09:49, Alex Bennée wrote: >>> * Signal free qemu_cpu_kick (Paolo) >>> >>> I don't know much about this patch set but I assume this avoids the need >>>

[Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-04 Thread Richard Purdie
We're seeing repeated segfaults in qemu-system-arm when we heavily use the network. I have a coredump backtrace: Reading symbols from /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm-lsb/build/build/tmp/sysroots/x86_64-linux/usr/bin/qemu-system-arm...done. [New LWP 4536] [New LWP 4534]

Re: [Qemu-devel] [sheepdog] [PATCH 2/2] sheepdog: refine discard support

2015-09-04 Thread Vasiliy Tolstov
04 сент. 2015 г. 12:57 пользователь "Hitoshi Mitake" < mitake.hito...@gmail.com> написал: > > On Fri, Sep 4, 2015 at 5:51 PM, Hitoshi Mitake wrote: > > On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov wrote: > >> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake : > >>> This patch refines discard support o

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

2015-09-04 Thread Stefan Hajnoczi
On Thu, Sep 03, 2015 at 12:18:18AM +0800, Yang Hongyang wrote: > > > On 09/02/2015 09:02 PM, Stefan Hajnoczi wrote: > >On Wed, Sep 02, 2015 at 09:49:18AM +0800, Yang Hongyang wrote: > >>On 09/01/2015 10:43 PM, Stefan Hajnoczi wrote: > >>>On Tue, Sep 01, 2015 at 05:06:18PM +0800, Yang Hongyang wro

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 11:25, Richard Purdie wrote: > We're seeing repeated segfaults in qemu-system-arm when we heavily use > the network. I have a coredump backtrace: > (gdb) print s->tx_fifo_done > $1 = {99614720, 99614720, 99614720, 99614720} > (gdb) print s->tx_fifo_done_len > $2 = 99614719

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

2015-09-04 Thread Andrew Jones
On Wed, Sep 02, 2015 at 11:25:26AM +0200, Alexander Spyridakis wrote: > Properly clean any generated object and binary files after a 'make clean', > this fixes an issue when trying to reconfigure between arm and arm64. Are you also running configure (with the opposite arch selected) after 'make cl

Re: [Qemu-devel] [PATCH v2 2/2] target-mips: Use tcg_gen_extrh_i64_i32

2015-09-04 Thread Leon Alrae
On 02/09/2015 23:50, Richard Henderson wrote: > We can tidy gen_load_fpr32h, as well as introduce a helper > to cleanup the MACC instructions. > > Signed-off-by: Richard Henderson > --- > target-mips/translate.c | 48 ++-- > 1 file changed, 22 insertio

Re: [Qemu-devel] [PATCH RFC v4 02/32] qapi: New QAPISchema intermediate reperesentation

2015-09-04 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Sep 04, 2015 at 09:12:09AM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > On Thu, Sep 03, 2015 at 04:29:53PM +0200, Markus Armbruster wrote: >> > Python has a nice tool called pep8 which can apply a >> > configurable bunch of styl

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-04 Thread Richard Purdie
On Fri, 2015-09-04 at 11:45 +0100, Peter Maydell wrote: > On 4 September 2015 at 11:25, Richard Purdie > wrote: > > We're seeing repeated segfaults in qemu-system-arm when we heavily use > > the network. I have a coredump backtrace: > > > (gdb) print s->tx_fifo_done > > $1 = {99614720, 99614720,

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 12:24, Richard Purdie wrote: > So just based on that, yes, seems that the rx_fifo looks to be > overrunning. I can add the asserts but I think it would just confirm > this. Yes, the point of adding assertions is to confirm a hypothesis. >> Also, do you have a more specific

[Qemu-devel] [PATCH 1/2] target-arm: Refactor CPU affinity handling

2015-09-04 Thread Pavel Fedin
Introduces reusable definitions for CPU affinity masks/shifts and gets rid of hardcoded magic numbers. Signed-off-by: Pavel Fedin --- target-arm/cpu-qom.h | 12 target-arm/cpu.c | 2 +- target-arm/kvm32.c | 3 +-- target-arm/kvm64.c | 3 +-- 4 files changed, 15 insertions

[Qemu-devel] [PATCH 0/2] arm/virt: Add full-sized CPU affinity handling

2015-09-04 Thread Pavel Fedin
This small patchset is actually a small extraction from vGICv3 support, as it was suggested in https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00921.html. Initially i wanted to just make a check, but ended up full implementation which is not more difficult. Since we don't make any assumpti

[Qemu-devel] [PATCH 2/2] arm/virt: Add full-sized CPU affinity handling

2015-09-04 Thread Pavel Fedin
At least with KVM, currently there's no reason why qemu would not be capable of handling Aff3 != 0. This commit fixes up FDT creation in such a case. Signed-off-by: Pavel Fedin --- hw/arm/virt.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM

2015-09-04 Thread Igor Mammedov
On Fri, 14 Aug 2015 22:52:00 +0800 Xiao Guangrong wrote: > NVDIMM reserves all the free range above 4G to do: > - Persistent Memory (PMEM) mapping > - implement NVDIMM ACPI device _DSM method > > Signed-off-by: Xiao Guangrong > --- > hw/i386/pc.c | 12 ++-- > hw/mem/nvdim

[Qemu-devel] Minutes of QEMU Summit 2015 (2015-08-18, Seattle)

2015-09-04 Thread Peter Maydell
This is a brief writeup of what we discussed at the QEMU Summit 2015 at KVM Forum last month. * Participants Markus Armbruster Paolo Bonzini Luiz Capitulino Andreas Färber Alexander Graf Eduardo Habkost Stefan Hajnoczi Richard Henderson Gerd Hoffmann Edgar E. Iglesias Bastian Koppelmann Peter May

Re: [Qemu-devel] [PATCH RFC v4 02/32] qapi: New QAPISchema intermediate reperesentation

2015-09-04 Thread Eric Blake
On 09/03/2015 08:29 AM, Markus Armbruster wrote: > The QAPI code generators work with a syntax tree (nested dictionaries) > plus a few symbol tables (also dictionaries) on the side. > > + > +class QAPISchemaArrayType(QAPISchemaType): > +def __init__(self, name, info, element_type): > +

[Qemu-devel] [PATCH v2 1/2] block: rename BlockdevSnapshot to BlockdevSnapshotSync

2015-09-04 Thread Alberto Garcia
We will introduce the 'blockdev-snapshot' command that will require its own struct for the parameters, so we need to rename this one in order to avoid name clashes. Signed-off-by: Alberto Garcia --- blockdev.c | 2 +- qapi-schema.json | 2 +- qapi/block-core.json | 8 3 fi

[Qemu-devel] [PATCH v2 2/2] block: add a 'blockdev-snapshot' QMP command

2015-09-04 Thread Alberto Garcia
One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap b

[Qemu-devel] [PATCH v2 0/2] Add 'blockdev-snapshot' command

2015-09-04 Thread Alberto Garcia
Previous attempt to extend blockdev-snapshot-sync: https://lists.gnu.org/archive/html/qemu-block/2015-08/msg00236.html As discussed in the previous thread, this adds a new command called 'blockdev-snapshot', that simply takes references to two existing block devices. I decided to share most of

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Lluís Vilanova
dovgaluk writes: > Hi! > Alex Bennée писал 2015-09-04 10:49: >> * What to do about icount? >> >> What is the impact of multi-thread on icount? Do we need to disable it >> for MTTCG or can it be correct per-cpu? Can it be updated lock-step? > Why can't we have separate icount for each CPU? > The

Re: [Qemu-devel] Minutes of QEMU Summit 2015 (2015-08-18, Seattle)

2015-09-04 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 01:24:11PM +0100, Peter Maydell wrote: > This is a brief writeup of what we discussed at the QEMU Summit 2015 > at KVM Forum last month. > * Continous integration > * Another perennial issue :-) > * Buildbot is broken and unmaintained: will probably go down soon > * The

Re: [Qemu-devel] Segfault using qemu-system-arm in smc91c111

2015-09-04 Thread Richard Purdie
On Fri, 2015-09-04 at 12:31 +0100, Peter Maydell wrote: > On 4 September 2015 at 12:24, Richard Purdie > wrote: > > So just based on that, yes, seems that the rx_fifo looks to be > > overrunning. I can add the asserts but I think it would just confirm > > this. > > Yes, the point of adding assert

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Mark Burton
> On 4 Sep 2015, at 14:38, Lluís Vilanova wrote: > > dovgaluk writes: > >> Hi! >> Alex Bennée писал 2015-09-04 10:49: >>> * What to do about icount? >>> >>> What is the impact of multi-thread on icount? Do we need to disable it >>> for MTTCG or can it be correct per-cpu? Can it be updated loc

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-04 Thread Peter Maydell
On 3 September 2015 at 06:27, Jonathan Neuschäfer wrote: > Currently, __target_cmsg_nxthdr compares a pointer derived from > target_cmsg against the msg_control field of target_msgh (through > subtraction). This failed for me when emulating i386 code under x86_64, > because pointers in the host a

[Qemu-devel] checkpatch.pl Perl 5.22 deprecation

2015-09-04 Thread Bastian Koppelmann
Hi, Perl 5.22 has deprecated unescaped { inside a regexp, which leads to very annoying warnings. Since we use checkpatch from the Linux kernel, I found a corresponding patch [1] that fixes it. Do we just get the new checkpatch from the kernel, or do we integrate the patch ourself? [1] https:

Re: [Qemu-devel] [PATCH RFC v4 00/32] qapi: QMP introspection

2015-09-04 Thread Marc-André Lureau
Hi Markus On Thu, Sep 3, 2015 at 4:29 PM, Markus Armbruster wrote: > Series is based on "[PATCH 00/26] qapi: Another round of fixes and > cleanups" (which actually has 33 patches now). It also needs my > "[PATCH for-2.4 0/2] qom: Fix misuse of Error API" to pass tests. > > You can fetch it from

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread Lluís Vilanova
Mark Burton writes: [...] * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? We need some input from the guys that use icount the most. >>> >>> That m

Re: [Qemu-devel] [PATCH 06/17] target-openrisc: Put SR[OVE] in TB flags

2015-09-04 Thread Bastian Koppelmann
On 09/03/2015 02:17 AM, Richard Henderson wrote: { /* Sync the tb dependent flag between translate and runtime. */ -if (dc->tb_flags != dc->synced_flags) { -tcg_gen_movi_tl(env_flags, dc->tb_flags); +if ((dc->tb_flags ^ dc->synced_flags) & D_FLAG) { +tcg_gen_mov

Re: [Qemu-devel] [PATCH 02/17] target-openrisc: Streamline arithmetic and OVE

2015-09-04 Thread Bastian Koppelmann
On 09/03/2015 04:44 PM, Richard Henderson wrote: That's patch 7/17. ;-) Woops , I just realized ;-) R0 is not an *architectural* zero. It's a software convention. The spec is fairly clear on this point. I agree that there ought to be some special-casing of the software convention, but

Re: [Qemu-devel] [Patch V1 2/3] xen/usb: add capability for passing through isoc jobs to host devices

2015-09-04 Thread Gerd Hoffmann
On Do, 2015-09-03 at 12:45 +0200, Juergen Gross wrote: > When Xen is using the qemu usb framework for pure passthrough of I/Os > to host devices the handling of isoc jobs is rather complicated if > multiple isoc frames are transferred with one call. > > Instead of calling the framework with each f

Re: [Qemu-devel] [PATCH 07/17] target-openrisc: Keep SR_CY and SR_OV in a separate variables

2015-09-04 Thread Bastian Koppelmann
On 09/03/2015 02:17 AM, Richard Henderson wrote: - -uint32_t HELPER(mul32)(CPUOpenRISCState *env, - uint32_t ra, uint32_t rb) -{ -uint64_t result; -uint32_t high, cy; - -OpenRISCCPU *cpu = openrisc_env_get_cpu(env); - -result = (uint64_t)ra * rb; -/* re

Re: [Qemu-devel] [PATCH v2] linux-user: add signalfd/signalfd4 syscalls

2015-09-04 Thread Peter Maydell
On 3 September 2015 at 00:58, Laurent Vivier wrote: > This patch introduces a system very similar to the one used in the kernel > to attach specific functions to a given file descriptor. > > In this case, we attach a specific "host_to_target()" translator to the fd > returned by signalfd() to be a

Re: [Qemu-devel] [PATCH v6 4/4] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP

2015-09-04 Thread Peter Maydell
On 31 August 2015 at 22:28, Alistair Francis wrote: > On Mon, Aug 31, 2015 at 1:54 PM, John Snow wrote: >> For some reason, this patch never made it to the qemu-devel archives for >> either v5 or v6. I only received a direct copy to my inbox, but the >> mailer daemon seems to have dropped this pa

Re: [Qemu-devel] [PATCH v2] linux-user: add name_to_handle_at/open_by_handle_at

2015-09-04 Thread Peter Maydell
On 1 September 2015 at 21:27, Laurent Vivier wrote: > This patch allows to run example given by open_by_handle_at(2): > > The following shell session demonstrates the use of these two programs: > >$ echo 'Can you please think about it?' > cecilia.txt >$ ./t_name_to_ha

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

2015-09-04 Thread Alexander Spyridakis
On 4 September 2015 at 12:48, Andrew Jones wrote: > Are you also running configure (with the opposite arch selected) after > 'make clean'? If not, then that could be the source of your problems. > Anyway, please describe the issues you're seeing because I don't see > what this patch is doing that

Re: [Qemu-devel] [PATCH] target-arm: Fix arm_excp_unmasked() function

2015-09-04 Thread Peter Maydell
On 2 September 2015 at 16:53, Sergey Sorokin wrote: > There is an error in arm_excp_unmasked() function: > bitwise operator & is used with integer and bool operands > causing an incorrect zeroed result. > The patch fixes it. > > Signed-off-by: Sergey Sorokin Applied to target-arm.next, thanks.

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

2015-09-04 Thread Alexander Spyridakis
On 4 September 2015 at 12:48, Andrew Jones wrote: > The lines this > patch adds are already there. See the arm_clean target in > config/config-arm-common.mak. I see your point now. Maybe then "arm_clean" should be changed in "arch_clean" in config-arm-common.mak? Regards.

Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection

2015-09-04 Thread Eric Blake
On 09/04/2015 03:55 AM, Markus Armbruster wrote: >>> + >>> +query-schema returns a JSON array of SchemaInfo objects. These >>> +objects together describe the wire ABI, as defined in the QAPI schema. >> >> Maybe an additional sentence here, perhaps along the lines of: >> >> Note that the wire form

Re: [Qemu-devel] [PATCH 08/17] target-openrisc: Set flags on helpers

2015-09-04 Thread Bastian Koppelmann
On 09/03/2015 02:17 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target-openrisc/helper.h | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Bastian Koppelmann

Re: [Qemu-devel] [PATCH v2] target-arm: Break the TB after ISB to execute self-modified code correctly

2015-09-04 Thread Peter Maydell
On 2 September 2015 at 11:03, Sergey Sorokin wrote: > If any store instruction writes the code inside the same TB > after this store insn, the execution of the TB must be stopped > to execute new code correctly. > As described in ARMv8 manual D3.4.6 a self-modified code need to do > IC invalidatio

Re: [Qemu-devel] [PATCH 09/17] target-openrisc: Implement ff1 and fl1 for 64-bit

2015-09-04 Thread Bastian Koppelmann
On 09/03/2015 02:17 AM, Richard Henderson wrote: True, this is unused so far, but commented out is worse than actually implemented properly. Signed-off-by: Richard Henderson --- target-openrisc/int_helper.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) R

Re: [Qemu-devel] [PATCH RFC v4 31/32] qapi-introspect: Map all integer types to 'int'

2015-09-04 Thread Eric Blake
On 09/03/2015 08:30 AM, Markus Armbruster wrote: > How many bits we use internally is an implementation detail. It could > be pressed into external interface service as very approximate range > information, but that's probably a bad idea. If we need range > information, we better do it properly.

Re: [Qemu-devel] [PATCH] Added specific ARM_FEATURE for Thumb-exception enable bit

2015-09-04 Thread Mike Haben
On 03/09/15 17:58, Peter Crosthwaite wrote: Hi Mike, On Thu, Sep 3, 2015 at 2:27 AM, GitNoviceMikeH wrote: From: GitNoviceMikeH Most ARM cores switch unconditionally to ARM mode when an exception occurs; a few (Cortex) variants have a "Thumb-exception enable" bit in the system control regist

[Qemu-devel] [PATCH] target-mips: Fix RDHWR on CP0.Count

2015-09-04 Thread Alex Smith
For RDHWR on the CP0.Count register, env->CP0_Count was being returned. This value is a delta against the QEMU_CLOCK_VIRTUAL clock, not the correct current value of CP0.Count. Use cpu_mips_get_count() instead. Signed-off-by: Alex Smith Cc: Aurelien Jarno Cc: Leon Alrae --- target-mips/op_helpe

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread dovgaluk
Hi! Alex Bennée писал 2015-09-04 10:49: * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? Why can't we have separate icount for each CPU? Then virtual timer will be assigned to

Re: [Qemu-devel] MTTCG Tasks (kvmforum summary)

2015-09-04 Thread dovgaluk
Lluís Vilanova писал 2015-09-04 16:00: Mark Burton writes: [...] * What to do about icount? What is the impact of multi-thread on icount? Do we need to disable it for MTTCG or can it be correct per-cpu? Can it be updated lock-step? We need some input from the guys that use icount the most.

Re: [Qemu-devel] [PATCH RFC v4 32/32] qapi-introspect: Hide type names

2015-09-04 Thread Eric Blake
On 09/03/2015 08:30 AM, Markus Armbruster wrote: > To eliminate the temptation for clients to look up types by name > (which are not ABI), replace all type names by meaningless strings. > > Reduces output of query-schema by 13 out of 85KiB. > > As a debugging aid, provide option -u to suppress th

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

2015-09-04 Thread Andrew Jones
On Fri, Sep 04, 2015 at 03:48:35PM +0200, Alexander Spyridakis wrote: > On 4 September 2015 at 12:48, Andrew Jones wrote: > > Are you also running configure (with the opposite arch selected) after > > 'make clean'? If not, then that could be the source of your problems. > > Anyway, please describe

Re: [Qemu-devel] PING: [PATCH v2 0/2] cpu_arm: Implement irqchip property for ARM CPU

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 07:49, Pavel Fedin wrote: > Hi! This message is mainly for Peter. I say you reviewed my major sets, but > looks like missed this > one. If it is OK, we could apply it, and i could successfully bring back the > missing part in > vGICv3-enabled hw/arm/virt.c which attaches

Re: [Qemu-devel] [PATCH RFC v4 00/32] qapi: QMP introspection

2015-09-04 Thread Eric Blake
On 09/04/2015 06:57 AM, Marc-André Lureau wrote: > Hi Markus > > On Thu, Sep 3, 2015 at 4:29 PM, Markus Armbruster wrote: >> Series is based on "[PATCH 00/26] qapi: Another round of fixes and >> cleanups" (which actually has 33 patches now). It also needs my >> "[PATCH for-2.4 0/2] qom: Fix misu

Re: [Qemu-devel] [PATCH 0/2] arm/virt: Add full-sized CPU affinity handling

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 12:39, Pavel Fedin wrote: > This small patchset is actually a small extraction from vGICv3 support, > as it was suggested in > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00921.html. > Initially i wanted to just make a check, but ended up full implementation > w

Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

2015-09-04 Thread Peter Maydell
On 4 September 2015 at 15:05, Andrew Jones wrote: > But anyway I would suggest you do your 'make clean' or even a > 'make distclean' *before* running configure the second time. > Otherwise you'll leave old object files around from the previously > configured arch. I.e. you want 'make clean' to app

Re: [Qemu-devel] [PATCH v12 5/5] hw/arm/virt: Add gic-version option to virt machine

2015-09-04 Thread Pavel Fedin
Hello! > I think we need to leave enough space for all of GICC/GICV/GICH > (that's 2 pages for GICC, 2 for GICV, 1 for GICH). They're optional > in a GICv3, but we may want them for emulation later on and if we > haven't left ourselves enough space we'll be a bit stuck. Do we really need this?

[Qemu-devel] [PULL 04/33] qapi-event: Clean up how name of enum QAPIEvent is made

2015-09-04 Thread Markus Armbruster
Use c_name() instead of ad hoc code. Doesn't upcase the -p prefix, which is an improvement in my book. Unbreaks prefix containing '.', but other funny characters remain broken. To be fixed next. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 8

[Qemu-devel] [PULL 07/33] qapi: Fix generated code when flat union has member 'kind'

2015-09-04 Thread Markus Armbruster
A flat union's tag member gets renamed to 'kind' in the generated code. Breaks when another member named 'kind' exists. Example, adapted from qapi-schema-test.json: { 'struct': 'UserDefUnionBase', 'data': { 'kind': 'str', 'enum1': 'EnumOne' } } We generate: struct UserDefFlatUnio

[Qemu-devel] [PULL 05/33] qapi: Reject -p arguments that break qapi-event.py

2015-09-04 Thread Markus Armbruster
qapi-event.py breaks when you ask for a funny prefix like '@'. Protect it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index ba11c54..bc3f4d3 100644 --- a/scripts/qapi.py

[Qemu-devel] [PULL 06/33] qapi: Drop unused and useless parameters and variables

2015-09-04 Thread Markus Armbruster
gen_sync_call()'s parameter indent is useless: gen_sync_call() uses it only as optional argument for push_indent() and pop_indent(), their default is four, and gen_sync_call()'s only caller passes four. Drop the parameter. gen_visitor_input_containers_decl()'s parameter obj is always "QOBJECT(arg

[Qemu-devel] [PULL 00/33] qapi: Another round of fixes and cleanups

2015-09-04 Thread Markus Armbruster
The following changes since commit b041066421e8dcc7d080dfcfd83551c9c9f24ade: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2015-09-03 16:17:28 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-09-04

[Qemu-devel] [PULL 13/33] tests/qapi-schema: Document events with base don't work

2015-09-04 Thread Markus Armbruster
When event FOO's 'data' is a struct with a base, we consider only the struct's direct members, and ignore its base. The generated qapi_event_send_foo() doesn't take arguments for base members. No such events currently exist in the QMP schema. Signed-off-by: Markus Armbruster Reviewed-by: Eric B

[Qemu-devel] [PULL 03/33] qapi: Simplify guardname()

2015-09-04 Thread Markus Armbruster
The guards around built-in declarations lose their _H. It never made much sense anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index e656beb..b

[Qemu-devel] [PULL 12/33] tests/qapi-schema: Document alternate's enum lacks visit function

2015-09-04 Thread Markus Armbruster
We generate a declaration, but no definition. The QMP schema has two: Qcow2OverlapChecks and BlockdevRef. Neither visit_type_Qcow2OverlapChecksKind() nor visit_type_BlockdevRefKind() is actually used. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-t

  1   2   3   4   >