Re: [Qemu-devel] [FIX PATCH] spapr_drc: Return correct state for logical DR in entity_sense()

2015-09-09 Thread David Gibson
On Wed, Sep 09, 2015 at 09:32:32AM +0530, Bharata B Rao wrote: > On Tue, Sep 08, 2015 at 05:03:25PM -0500, Michael Roth wrote: > > Quoting Michael Roth (2015-09-08 16:03:56) > > > Quoting David Gibson (2015-09-07 20:22:50) > > > > On Mon, Sep 07, 2015 at 11:37:04AM +0530, Bharata B Rao wrote: > > >

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-09 Thread Michael S. Tsirkin
On Mon, Sep 07, 2015 at 02:38:34PM +0200, Claudio Fontana wrote: > Coming late to the party, > > On 31.08.2015 16:11, Michael S. Tsirkin wrote: > > Hello! > > During the KVM forum, we discussed supporting virtio on top > > of ivshmem. I have considered it, and came up with an alternative > > that

Re: [Qemu-devel] PING: [PATCH v2 0/2] cpu_arm: Implement irqchip property for ARM CPU

2015-09-09 Thread Pavel Fedin
Hello! > As far as I remember Peter suggested that with the GICv3 support the routine > define_arm_cp_regs_with_opaque should be used, where the "opaque" is the gic > object. > This "opaque" is later accessed from the register info "opaque" member. I > assume the idea is to take hw/arm/pxa2xx.

Re: [Qemu-devel] Aspirant for AMD IOMMU emulation project for Outreachy

2015-09-09 Thread Valentine Sinitsyn
On 09.09.2015 11:54, David kiarie wrote: ...snip... Most recent work is here http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg02759.html . Most the code is Qemu device boilerplate(so there are a ton of things to add but I wanted to have the existing work merged first). The IOMMU just of

Re: [Qemu-devel] [PATCH v3 1/3] i.MX: Add GPIO device

2015-09-09 Thread Peter Crosthwaite
On Tue, Sep 8, 2015 at 5:38 PM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since V1: > * added "has-edge-sel" property > * use extract64() and deposit64() in read/write icr access > * set "number of GPIO pin" as a #define > * reorganize functio

Re: [Qemu-devel] [PATCH qemu] vfio_pci: Allow disabling quirks

2015-09-09 Thread Alexey Kardashevskiy
On 07/20/2015 12:40 PM, Alexey Kardashevskiy wrote: On 07/20/2015 03:15 AM, Alex Williamson wrote: On Sun, 2015-07-19 at 06:50 -0600, Alex Williamson wrote: On Sun, 2015-07-19 at 18:19 +1000, Alexey Kardashevskiy wrote: The existing quirks aim config space and MSIX BAR accesses interception. T

Re: [Qemu-devel] [PATCH] spapr: Reduce advertised max LUNs for spapr_vscsi

2015-09-09 Thread David Gibson
On Wed, Sep 09, 2015 at 08:25:34AM +0200, Thomas Huth wrote: > On 09/09/15 03:22, David Gibson wrote: > > The implementation of the PAPR paravirtual SCSI adapter currently > > allows up to 32 LUNs (max_lun == 31). However the adapter isn't really > > designed to support lots of devices - the Power

[Qemu-devel] [PATCH v10 02/10] init/cleanup of netfilter object

2015-09-09 Thread Yang Hongyang
Add a netfilter object based on QOM. A netfilter is attached to a netdev, captures all network packets that pass through the netdev. When we delete the netdev, we also delete the netfilter object attached to it, because if the netdev is removed, the filter which attached to it is useless. QTAILQ_

[Qemu-devel] [PATCH v10 04/10] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-09-09 Thread Yang Hongyang
qemu_deliver_packet_iov already have the compat delivery, we can drop qemu_deliver_packet. Signed-off-by: Yang Hongyang --- include/net/net.h | 5 - net/net.c | 40 +++- net/queue.c | 6 +- 3 files changed, 12 insertions(+), 39 deletion

[Qemu-devel] [PATCH v10 01/10] qmp: delete qemu opts when delete an object

2015-09-09 Thread Yang Hongyang
When delete an object, we need to delete the associated qemu opts, otherwise, we can not add another object with the same name using object_add. The case happens when we start qemu with: -object xxx,id=aa then we delete this object with: object_del aa then add the object with: object_add xxx,id=aa

[Qemu-devel] [PATCH v10 10/10] tests: add test cases for netfilter object

2015-09-09 Thread Yang Hongyang
Using qtest qmp interface to implement following cases: 1) add/remove netfilter 2) add a netfilter then delete the netdev 3) add/remove more than one netfilters 4) add more than one netfilters and then delete the netdev Signed-off-by: Yang Hongyang --- v10: qmp command based on qom change v9: qmp

[Qemu-devel] [PATCH v10 03/10] netfilter: hook packets before net queue send

2015-09-09 Thread Yang Hongyang
Capture packets that will be sent. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- v10: adjust due to QOM v5: do not check ret against iov_size pass sent_cb to filters --- net/net.c | 67 +++ 1 file changed, 67 insertions

[Qemu-devel] [PATCH v10 06/10] netfilter: add an API to pass the packet to next filter

2015-09-09 Thread Yang Hongyang
add an API qemu_netfilter_pass_to_next() to pass the packet to next filter. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- v10: adjust as a NetQueueDeliverFunc v9: fix a bug when curr filter chain is all v5: fold params to NetPacket struct --- include/net/filter.h | 7 ++ net/fi

[Qemu-devel] [PATCH v10 08/10] net/queue: export qemu_net_queue_append_iov

2015-09-09 Thread Yang Hongyang
This will be used by buffer filter implementation later to queue packets. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- include/net/queue.h | 7 +++ net/queue.c | 12 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/net/queue.h b/incl

[Qemu-devel] [PATCH v10 00/10] Add a netfilter object and netbuffer filter

2015-09-09 Thread Yang Hongyang
This patch add an netfilter abstract object, captures all network packets on associated netdev. Also implement a concrete filter buffer based on this abstract object. the "buffer" netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/release packets. Or to simulate packet de

[Qemu-devel] [PATCH v10 05/10] net/queue: introduce NetQueueDeliverFunc

2015-09-09 Thread Yang Hongyang
net/queue.c has logic to send/queue/flush packets but a qemu_deliver_packet_iov() call is hardcoded. Abstract this func so that we can use our own deliver function in netfilter. Signed-off-by: Yang Hongyang Cc: Stefan Hajnoczi --- include/net/queue.h | 13 - net/net.c | 2

Re: [Qemu-devel] [PATCH] spapr: Reduce advertised max LUNs for spapr_vscsi

2015-09-09 Thread Thomas Huth
On 09/09/15 09:19, David Gibson wrote: > On Wed, Sep 09, 2015 at 08:25:34AM +0200, Thomas Huth wrote: >> On 09/09/15 03:22, David Gibson wrote: >>> The implementation of the PAPR paravirtual SCSI adapter currently >>> allows up to 32 LUNs (max_lun == 31). However the adapter isn't really >>> desig

[Qemu-devel] [PATCH v10 07/10] netfilter: print filter info associate with the netdev

2015-09-09 Thread Yang Hongyang
From: Yang Hongyang When execute "info network", print filter info also. add a info_str member to NetFilterState, store specific filters info. Signed-off-by: Yang Hongyang --- v10: add a info_str member to NetFilterState v9: tiny cleanup according to Tomas's comment. v7: initial patch --- incl

Re: [Qemu-devel] [PATCH 01/18] iothread: release iothread around aio_poll

2015-09-09 Thread Paolo Bonzini
On 09/09/2015 08:06, Fam Zheng wrote: > This patch will probably go in before aio_disable_clients, Actually I think it's blocked by aio_disable_clients. > if any, but I'm not > quite confident about the interface yet: listing a precise set of clients from > monitor is an ugly coupling between m

[Qemu-devel] [PATCH v10 09/10] netfilter: add a netbuffer filter

2015-09-09 Thread Yang Hongyang
This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solutions, you can also use it to simulate the network delay. It has an interval option, if supplied, this filter will release packets by interval. Usage: -netdev tap,id=bn0

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread David kiarie
On Mon, Sep 7, 2015 at 3:46 PM, Valentine Sinitsyn wrote: > Hi David, > > Sorry for the long silence. I've skimmed through your patch, below are some > thoughts. Please remember I'm looking for IOMMU implementation details, not > how it is integrated with QEMU. > > On 25.08.2015 04:19, David Kiari

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-09 Thread Markus Armbruster
Programmingkid writes: > On Sep 8, 2015, at 2:46 PM, Markus Armbruster wrote: > >> Programmingkid writes: >> >>> On Sep 8, 2015, at 12:17 PM, Peter Maydell wrote: >>> On 2 September 2015 at 01:56, Programmingkid wrote: > Add "Mount Image File..." and a "Eject Image File" menu it

Re: [Qemu-devel] [PATCH v2 2/2] Add dynamic generation of module_block.h

2015-09-09 Thread Marc Marí
On Wed, 9 Sep 2015 10:27:13 +0800 Fam Zheng wrote: > On Tue, 09/08 15:53, Marc Marí wrote: > > diff --git a/include/qemu/module_block.h > > b/include/qemu/module_block.h deleted file mode 100644 > > index d725db8..000 > > --- a/include/qemu/module_block.h > > +++ /dev/null > > @@ -1,90 +0,0 @

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-09-09 Thread Zhu Guihua
On 09/09/2015 01:52 PM, Bharata B Rao wrote: On Fri, Sep 04, 2015 at 03:31:24PM +1000, David Gibson wrote: On Thu, Aug 06, 2015 at 10:57:07AM +0530, Bharata B Rao wrote: CPUState *cpu gets added to the cpus list during cpu_exec_init(). It should be removed from cpu_exec_exit(). cpu_exec_init(

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread Valentine Sinitsyn
On 09.09.2015 12:30, David kiarie wrote: ...snip... +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) +{ +unsigned type; +uint8_t cmd[IOMMU_COMMAND_SIZE]; + +IOMMU_DPRINTF(COMMAND, ""); +memset(cmd, 0, IOMMU_COMMAND_SIZE); + +if(dma_memory_read(&address_space_memory, s->cm

Re: [Qemu-devel] [PATCH RFC v5 02/32] qapi: New QAPISchema intermediate reperesentation

2015-09-09 Thread Markus Armbruster
Eric Blake writes: > On 09/07/2015 04:16 AM, Markus Armbruster wrote: >> The QAPI code generators work with a syntax tree (nested dictionaries) >> plus a few symbol tables (also dictionaries) on the side. >> >> They have clearly outgrown these simple data structures. There's lots >> of rummagin

[Qemu-devel] [PATCH v14 3/5] arm_kvm: Do not assume particular GIC type in kvm_arch_irqchip_create()

2015-09-09 Thread Pavel Fedin
This allows us to use different GIC types from v2. There are no kernels which could advertise KVM_CAP_DEVICE_CTRL without the actual ability to create GIC with it. GIC version probe code moved to kvm_arm_vgic_probe() which will be used later. Signed-off-by: Pavel Fedin Reviewed-by: Eric Auger T

[Qemu-devel] [PATCH v14 0/5] vGICv3 support

2015-09-09 Thread Pavel Fedin
This series introduces support for GICv3 by KVM. Software emulation is currently not supported. v13 => v14 - Rebased on the latest master, fixed conflicts in hw/arm/virt.c v12 => v13 - Many stylistic fixes - Fixed up ACPI data for virt machine - Added gic-version=host value which probes for best

[Qemu-devel] [PATCH v14 4/5] hw/intc: Initial implementation of vGICv3

2015-09-09 Thread Pavel Fedin
This is the initial version of KVM-accelerated GICv3 support. State load and save are not yet supported, live migration is not possible. In order to get correct class name in a simpler way, gicv3_class_name() function is implemented, similar to gic_class_name(). Signed-off-by: Pavel Fedin Review

[Qemu-devel] [PATCH v14 1/5] hw/intc: Implement GIC-500 base class

2015-09-09 Thread Pavel Fedin
From: Shlomo Pongratz This class is to be used by both software and KVM implementations of GICv3 Currently it is mostly a placeholder, but in future it is supposed to hold qemu's representation of GICv3 state, which is necessary for migration. The interface of this class is fully compatible wit

[Qemu-devel] [PATCH v14 2/5] intc/gic: Extract some reusable vGIC code

2015-09-09 Thread Pavel Fedin
Some functions previously used only by vGICv2 are useful also for vGICv3 implementation. Untie them from GICState and make accessible from within other modules: - kvm_arm_gic_set_irq() - kvm_gic_supports_attr() - moved to common code and renamed to kvm_device_check_attr() - kvm_gic_access() - tur

[Qemu-devel] [PATCH v14 5/5] hw/arm/virt: Add gic-version option to virt machine

2015-09-09 Thread Pavel Fedin
Add gic_version to VirtMachineState, set it to value of the option and pass it around where necessary. Instantiate devices and fdt nodes according to the choice. max_cpus for virt machine increased to 123 (calculated from redistributor space available in the memory map). GICv2 compatibility check

Re: [Qemu-devel] [RFC PATCH v4 01/11] exec: Remove cpu from cpus list during cpu_exec_exit()

2015-09-09 Thread Bharata B Rao
On Wed, Sep 09, 2015 at 03:41:30PM +0800, Zhu Guihua wrote: > > On 09/09/2015 01:52 PM, Bharata B Rao wrote: > >On Fri, Sep 04, 2015 at 03:31:24PM +1000, David Gibson wrote: > >>On Thu, Aug 06, 2015 at 10:57:07AM +0530, Bharata B Rao wrote: > >>>CPUState *cpu gets added to the cpus list during cpu

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread David kiarie
On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn wrote: > On 09.09.2015 12:30, David kiarie wrote: > ...snip... > > +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) +{ +unsigned type; +uint8_t cmd[IOMMU_COMMAND_SIZE]; + +IOMMU_DPRINTF(COMMAND, "");

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread Michael S. Tsirkin
On Wed, Sep 09, 2015 at 12:45:10PM +0500, Valentine Sinitsyn wrote: > On 09.09.2015 12:30, David kiarie wrote: > ...snip... > > >>>+static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) > >>>+{ > >>>+unsigned type; > >>>+uint8_t cmd[IOMMU_COMMAND_SIZE]; > >>>+ > >>>+IOMMU_DPRINTF(COMMAND

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread Valentine Sinitsyn
On 09.09.2015 12:59, Michael S. Tsirkin wrote: On Wed, Sep 09, 2015 at 12:45:10PM +0500, Valentine Sinitsyn wrote: On 09.09.2015 12:30, David kiarie wrote: ...snip... +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) +{ +unsigned type; +uint8_t cmd[IOMMU_COMMAND_SIZE]; + +IOMMU_

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Ouyang, Changchun
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Tuesday, September 8, 2015 3:39 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Ouyang, Changchun; Yuanhan Liu > Subject: [PATCH 6/7] vhost-user: add multiple queue support > > From: Ouyang Changc

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread Valentine Sinitsyn
On 09.09.2015 12:59, David kiarie wrote: On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn wrote: On 09.09.2015 12:30, David kiarie wrote: ...snip... +static void amd_iommu_cmdbuf_exec(AMDIOMMUState *s) +{ +unsigned type; +uint8_t cmd[IOMMU_COMMAND_SIZE]; + +IOMMU_DPRINTF(COMMA

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Yuanhan Liu
On Wed, Sep 09, 2015 at 08:05:11AM +, Ouyang, Changchun wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Tuesday, September 8, 2015 3:39 PM > > To: qemu-devel@nongnu.org > > Cc: m...@redhat.com; Ouyang, Changchun; Yuanhan Liu > > S

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread David kiarie
I wrote something basic on the cover letter http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg02759.html On Wed, Sep 9, 2015 at 11:07 AM, Valentine Sinitsyn wrote: > On 09.09.2015 12:59, David kiarie wrote: >> >> On Wed, Sep 9, 2015 at 10:45 AM, Valentine Sinitsyn >> wrote: >>> >>> On 0

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread Valentine Sinitsyn
Oops, that was a long ago. Sorry & thanks. Valentine On 09.09.2015 13:12, David kiarie wrote: I wrote something basic on the cover letter http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg02759.html On Wed, Sep 9, 2015 at 11:07 AM, Valentine Sinitsyn wrote: On 09.09.2015 12:59, Davi

Re: [Qemu-devel] Target vs architecture for QEMU binary

2015-09-09 Thread Andrea Bolognani
On Tue, 2015-09-08 at 16:47 +0100, Daniel P. Berrange wrote: > > Or we could just query everything that looks like a QEMU > > binary and then lookup the correct one for the guest based > > on the query results, couldn't we? Again, assuming such > > interface even exists. > > I'd prefer libvirt to

Re: [Qemu-devel] [PATCH 10/16] docs: block replication's description

2015-09-09 Thread Wen Congyang
On 09/03/2015 04:41 AM, Eric Blake wrote: > On 09/02/2015 02:51 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: Yang Hongyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> docs/block-replication.txt | 183 >> ++

Re: [Qemu-devel] [PATCH 15/16] support replication driver in blockdev-add

2015-09-09 Thread Wen Congyang
On 09/03/2015 12:36 AM, Eric Blake wrote: > On 09/02/2015 02:51 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> --- >> qapi/block-core.json | 18 -- >> 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> inde

Re: [Qemu-devel] [RFC 2/4] hw/i386: Introduce AMD IOMMU

2015-09-09 Thread David kiarie
On Wed, Sep 9, 2015 at 11:14 AM, Valentine Sinitsyn wrote: > Oops, that was a long ago. Sorry & thanks. No problem. Will fix all other comments. > > Valentine > > > On 09.09.2015 13:12, David kiarie wrote: >> >> I wrote something basic on the cover letter >> http://lists.nongnu.org/archive/html/

Re: [Qemu-devel] [opnfv-tech-discuss] rfc: vhost user enhancements for vm2vm communication

2015-09-09 Thread Claudio Fontana
On 09.09.2015 08:40, Zhang, Yang Z wrote: > Claudio Fontana wrote on 2015-09-07: >> Coming late to the party, >> >> On 31.08.2015 16:11, Michael S. Tsirkin wrote: >>> Hello! >>> During the KVM forum, we discussed supporting virtio on top >>> of ivshmem. I have considered it, and came up with an alt

Re: [Qemu-devel] [PATCH 1/2] qcow2: Make size_to_clusters() return int64_t

2015-09-09 Thread Kevin Wolf
Am 08.09.2015 um 22:09 hat Max Reitz geschrieben: > Sadly, some images may have more clusters than what can be represented > using a plain int. We should be prepared for that case (in > qcow2_check_refcounts() we actually were trying to catch that case, but > since size_to_clusters() truncated the

Re: [Qemu-devel] [PATCH 03/18] qemu-thread: introduce QemuLockCnt

2015-09-09 Thread Fam Zheng
On Thu, 08/06 15:36, Paolo Bonzini wrote: > +QemuLockCnt usage > +- > + > +The typical pattern for QemuLockCnt functions is as follows. > + > +qemu_lockcnt_inc(&xyz_lockcnt); > +if (xyz) { > +... access xyz ... > +} > + > +if (qemu_lockcnt_dec_and_lock(&xyz_l

Re: [Qemu-devel] [PATCH 04/16] block: Allow references for backing files

2015-09-09 Thread Wen Congyang
On 09/03/2015 02:50 AM, Eric Blake wrote: > On 09/02/2015 02:51 AM, Wen Congyang wrote: >> Usage: >> -drive file=xxx,id=Y, \ >> -drive file=,id=X,backing.backing_reference=Y >> >> It will create such backing chain: >>{virtio-blk dev 'Y'} {virtio-blk dev 'X'} >>

Re: [Qemu-devel] OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Laszlo Ersek
On 08/10/15 18:24, Laszlo Ersek wrote: > Hi. > > Let's do an OVMF BoF at this year's KVM Forum too. Here's a preliminary task list, after some off-list discussion (I tried to incorporate comments): - create GPL'd fork called "ovmf" for expediting virt development (OvmfPkg, ArmVirtPkg) - mayb

Re: [Qemu-devel] [RFC PATCH v0] spapr: Disable memory hotplug when HTAB size is insufficient

2015-09-09 Thread Anshuman Khandual
On 09/04/2015 09:42 PM, Michael Roth wrote: > Quoting Nathan Fontenot (2015-09-04 10:49:18) >> On 09/04/2015 10:33 AM, Michael Roth wrote: >>> Quoting Nathan Fontenot (2015-09-03 13:50:59) On 09/01/2015 10:28 PM, Bharata B Rao wrote: > On Mon, Aug 24, 2015 at 09:01:51AM +0530, Bharata B Ra

Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 11:04:47AM +0200, Thomas Huth wrote: > On 04/09/15 18:21, Stefan Hajnoczi wrote: > > From: P J P > > > > While processing transmit descriptors, it could lead to an infinite > > loop if 'bytes' was to become zero; Add a check to avoid it. > > > > [The guest can force 'byte

Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-09 Thread Stefan Hajnoczi
On Fri, Sep 04, 2015 at 05:21:06PM +0100, Stefan Hajnoczi wrote: > From: P J P > > While processing transmit descriptors, it could lead to an infinite > loop if 'bytes' was to become zero; Add a check to avoid it. > > [The guest can force 'bytes' to 0 by setting the hdr_len and mss > descriptor

Re: [Qemu-devel] [PATCH 03/18] qemu-thread: introduce QemuLockCnt

2015-09-09 Thread Paolo Bonzini
On 09/09/2015 10:49, Fam Zheng wrote: >> > +qemu_lockcnt_inc(&io_handlers_lockcnt); >> > +QLIST_FOREACH_RCU(ioh, &io_handlers, pioh) { >> > +if (ioh->revents & G_IO_OUT) { >> > +ioh->fd_write(ioh->opaque); >> > +} >> > +} > I'm confused, the comment of QLIS

Re: [Qemu-devel] wav output sounds good - what does this mean?

2015-09-09 Thread Stefan Hajnoczi
On Sun, Sep 06, 2015 at 04:53:29PM -0400, Programmingkid wrote: > I have been working on making the sound output from the USB sound card > actually sound good. When the audio is sent to CoreAudio, the sound is not > very good. But when I use the wav file output option, the sound in the wave > fi

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 11:53:03AM +0200, Paolo Bonzini wrote: > Mostly change severity levels, but some tests can also be adjusted to refer > to QEMU APIs or data structures. > > Signed-off-by: Paolo Bonzini > --- > scripts/checkpatch.pl | 141 > +---

Re: [Qemu-devel] [PATCH 11/16] Add new block driver interfaces to control block replication

2015-09-09 Thread Wen Congyang
On 09/03/2015 12:33 AM, Eric Blake wrote: > On 09/02/2015 02:51 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> Cc: Luiz Capitulino >> Cc: Michael Roth >> Reviewed-by: Paolo Bonzini >> --- >> block.c | 43 +

Re: [Qemu-devel] Proposed 2.5 release schedule

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 11:50:11AM +0100, Peter Maydell wrote: > Here's a suggested 2.5 release schedule, constructed fairly arbitrarily > by putting a week's margin for slippage in before everybody leaves for > Christmas, and having a four week softfreeze and four week hardfreeze: > > Softfreeze

[Qemu-devel] [PATCH 0/6] gtk: tweak grab handling, misc fixes.

2015-09-09 Thread Gerd Hoffmann
Hi, While doing some virgl testing I've trapped into a bunch of issues with input grabs, especially in fullscreen mode. So here is a series of mostly grab-related patches: Cleanups, improve tracing, don't grab when entering fullscreen. Also a small zoom fix, and the setlocale change discussed

[Qemu-devel] [PATCH 1/6] gtk: check for existing grabs in gd_grab_{pointer, keyboard}

2015-09-09 Thread Gerd Hoffmann
If a grab is already active for our window, do nothing. If a grab is already active for another window, release it. Cleanup some checks and ungrab calls in the code which are not needed any more. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 25 - 1 file changed, 20 insert

[Qemu-devel] [PATCH 4/6] gtk: set free_scale when setting zoom_fit

2015-09-09 Thread Gerd Hoffmann
free_scale field tracks zoom-fit menu toggle state, so we should keep them in sync ... Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/gtk.c b/ui/gtk.c index 322d112..2629d97 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1782,6 +1782,7 @@ static GSList

[Qemu-devel] [PATCH 6/6] gtk: setlocale for LC_MESSAGES only

2015-09-09 Thread Gerd Hoffmann
Setting other LC_* affects printf behavior and breaks QMP. We don't have much beside menu item strings localized, so restrict the locale setting to LC_MESSAGES. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index

Re: [Qemu-devel] [PATCH] iohandler: Use aio API

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 11:28:58AM +0800, Fam Zheng wrote: > iohandler.c shares the same interface with aio, but with duplicated > code. It's better to rebase iohandler, also because that aio is a > more friendly interface to multi-threads. > > Create a global AioContext instance and let its GSour

[Qemu-devel] [PATCH 5/6] gtk: don't grab input when entering fullscreen.

2015-09-09 Thread Gerd Hoffmann
Kick off all grabbing logic from fullscreen mode. In the current state it seems to create more problems than it solves though. Try running qemu/gtk fullscreen on one head of a multihead host for example ... There probably was a reason the grab-on-fullscreen logic was added in the first place. S

[Qemu-devel] [PATCH 2/6] gtk: move gd_update_caption calls to gd_{grab, ungrab}_{pointer, keyboard}

2015-09-09 Thread Gerd Hoffmann
Then we don't have to pair the grab/ungrab calls with update_caption calls any more because things happen automatically ;) Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 24a1edb..5f87475 100644 ---

Re: [Qemu-devel] [PATCH v5] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 01:33:56PM +0200, Pierre Morel wrote: > Let dataplane allocate different region for the desc/avail/used > ring regions. > Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail > rings accordingly. > > Signed-off-by: Pierre Morel > (changed __virtio16 into ui

[Qemu-devel] [PATCH 3/6] gtk: trace input grab reason

2015-09-09 Thread Gerd Hoffmann
Add a reason to grab calls and trace points, so it is easier to debug grab related ui issues. Signed-off-by: Gerd Hoffmann --- trace-events | 3 ++- ui/gtk.c | 26 +- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/trace-events b/trace-events index 0

Re: [Qemu-devel] [RFC 08/38] rcu: init rcu_registry_lock after fork

2015-09-09 Thread Alex Bennée
Emilio G. Cota writes: > On Tue, Sep 08, 2015 at 18:34:38 +0100, Alex Bennée wrote: >> Emilio G. Cota writes: > (snip) >> > +static void rcu_init_child(void) >> > +{ >> > +qemu_mutex_init(&rcu_registry_lock); >> > +} >> > #endif >> > >> > void rcu_after_fork(void) >> > @@ -346,7 +351,7

Re: [Qemu-devel] [RFC V2 2/2] sdhci: Move sdhci.h to include/

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 07:28:39PM +0530, Sai Pavan Boddu wrote: > Move sdhci.h to include/hw/sd/. Which makes easy creation of device > using object_initialize. > > Signed-off-by: Sai Pavan Boddu > --- > Changes for V2: >Create new area in includes for sd. And move sdhci.h to same. > --- >

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Rename BDRVQcowState to BDRVQcow2State

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 05:14:55PM +0200, Kevin Wolf wrote: > BDRVQcowState is already used by qcow1, and gdb is always confused which > one to use. Rename the qcow2 one so they can be distinguished. > > Signed-off-by: Kevin Wolf > --- > block/qcow2-cache.c| 14 - > block/qcow2-clust

Re: [Qemu-devel] [PATCH v7 1/5] cpu: Provide vcpu throttling interface

2015-09-09 Thread Paolo Bonzini
On 08/09/2015 19:12, Jason J. Herne wrote: > Provide a method to throttle guest cpu execution. CPUState is augmented with > timeout controls and throttle start/stop functions. To throttle the guest cpu > the caller simply has to call the throttle set function and provide a > percentage > of thro

Re: [Qemu-devel] [PATCH] build: qemu-ga: add 'qemu-ga' build target for w32

2015-09-09 Thread Paolo Bonzini
On 08/09/2015 17:47, Michael Roth wrote: > Currently POSIX builds rely on 'qemu-ga' target to do qga-only > distributable build. On w32, as with most standalone binary targets, > we rely on 'qemu-ga.exe' target. > > Unlike with POSIX, qemu-ga for w32 has a number of related targets > such as VSS

Re: [Qemu-devel] [RFC V2 2/2] sdhci: Move sdhci.h to include/

2015-09-09 Thread Sai Pavan Boddu
Hi Stefan, > -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Wednesday, September 09, 2015 3:08 PM > To: Sai Pavan Boddu > Cc: qemu-devel@nongnu.org; crosthwaitepe...@gmail.com; > ebl...@redhat.com; peter.mayd...@linaro.org; Sai Pavan Boddu; Edgar > Iglesias;

Re: [Qemu-devel] [PATCH 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-09 Thread Stefan Hajnoczi
On Tue, Sep 08, 2015 at 08:40:58PM +0530, Deepak Shetty wrote: > On Tue, Sep 8, 2015 at 8:32 PM, Daniel P. Berrange > wrote: > > > On Tue, Sep 08, 2015 at 06:34:09PM +0530, Prasanna Kumar Kalever wrote: > > > This patch adds a way to specify multiple backup volfile servers to the > > gluster > >

Re: [Qemu-devel] [PATCH 6/6] gtk: setlocale for LC_MESSAGES only

2015-09-09 Thread Paolo Bonzini
On 09/09/2015 11:28, Gerd Hoffmann wrote: > Setting other LC_* affects printf behavior and breaks QMP. > We don't have much beside menu item strings localized, so > restrict the locale setting to LC_MESSAGES. > > Signed-off-by: Gerd Hoffmann Cc: qemu-sta...@nongnu.org > --- > ui/gtk.c | 2 +-

Re: [Qemu-devel] [PATCH v2] add macro file for coccinelle

2015-09-09 Thread Paolo Bonzini
On 08/09/2015 20:35, Markus Armbruster wrote: >> > Having not used Coccinelle yet, what happens if any of these functions >> > become desynchronized ? > Coccinelle transforms C to C. Problem: if you parse C the normal way > (first run preprocessor, then the parser proper), you have to unparse >

Re: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor

2015-09-09 Thread pjp
Hello Stefan, > On Wednesday, 9 September 2015 2:40 PM, Stefan Hajnoczi wrote: > P J P probably chose this approach because it is the smallest > change. True. > On Wednesday, 9 September 2015 2:40 PM, Stefan Hajnoczi wrote: >> hw/net/e1000.c | 3 ++- >> 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH 1/4] CODING_STYLE: update mixed declaration rules

2015-09-09 Thread Stefan Hajnoczi
On Mon, Sep 07, 2015 at 11:53:01AM +0200, Paolo Bonzini wrote: > Mixed declarations also do exist at the top of #ifdef blocks. > Reluctantly allow this particular usage and suggest an alternative. > > Signed-off-by: Paolo Bonzini > --- > CODING_STYLE | 13 + > 1 file changed, 9 inser

Re: [Qemu-devel] [PATCH v4 29/38] blockdev: Add blockdev-insert-medium

2015-09-09 Thread Wen Congyang
On 09/09/2015 05:20 AM, Max Reitz wrote: > On 08.09.2015 11:13, Wen Congyang wrote: >> On 07/21/2015 01:45 AM, Max Reitz wrote: >>> And a helper function for that, which directly takes a pointer to the >>> BDS to be inserted instead of its node-name (which will be used for >>> implementing 'change'

Re: [Qemu-devel] [PATCH 03/16] allow writing to the backing file

2015-09-09 Thread Wen Congyang
On 09/03/2015 12:06 AM, Eric Blake wrote: > On 09/02/2015 02:51 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei > > Not much description in the commit message. I really want an > explanation of why this patch is necessary. After

Re: [Qemu-devel] [RFC 23/38] cpu-exec: grab iothread lock during interrupt handling

2015-09-09 Thread Paolo Bonzini
On 24/08/2015 02:23, Emilio G. Cota wrote: > Signed-off-by: Emilio G. Cota > --- > cpu-exec.c| 34 -- > include/qom/cpu.h | 1 + > 2 files changed, 29 insertions(+), 6 deletions(-) > > diff --git a/cpu-exec.c b/cpu-exec.c > index fd57b9c..a1700ac 100644

[Qemu-devel] Who wants to mentor for Outreachy Dec-Mar?

2015-09-09 Thread Stefan Hajnoczi
We are now looking for mentors for the next round of Outreachy running from December 7, 2015 to March 7, 2016. I have set up a wiki page here: http://qemu-project.org/Outreachy_2015_DecemberMarch Our communities have participated in previous years to mentor people from underrepresented groups and

Re: [Qemu-devel] [PATCH 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-09 Thread Kevin Wolf
Am 09.09.2015 um 11:46 hat Stefan Hajnoczi geschrieben: > On Tue, Sep 08, 2015 at 08:40:58PM +0530, Deepak Shetty wrote: > > On Tue, Sep 8, 2015 at 8:32 PM, Daniel P. Berrange > > wrote: > > > > > On Tue, Sep 08, 2015 at 06:34:09PM +0530, Prasanna Kumar Kalever wrote: > > > > This patch adds a wa

Re: [Qemu-devel] [PATCH v7 1/5] cpu: Provide vcpu throttling interface

2015-09-09 Thread Juan Quintela
"Jason J. Herne" wrote: > Provide a method to throttle guest cpu execution. CPUState is augmented with > timeout controls and throttle start/stop functions. To throttle the guest cpu > the caller simply has to call the throttle set function and provide a > percentage > of throttle time. > > Signe

Re: [Qemu-devel] [PATCH v7 2/5] migration: Parameters for auto-converge cpu throttling

2015-09-09 Thread Juan Quintela
"Jason J. Herne" wrote: > Add migration parameters to allow the user to adjust the parameters > that control cpu throttling when auto-converge is in effect. The added > parameters are as follows: > > x-cpu-throttle-initial : Initial percantage of time guest cpus are throttled > when migration auto

Re: [Qemu-devel] [PATCH 1/4] CODING_STYLE: update mixed declaration rules

2015-09-09 Thread Alex Bennée
Paolo Bonzini writes: > Mixed declarations also do exist at the top of #ifdef blocks. > Reluctantly allow this particular usage and suggest an alternative. > > Signed-off-by: Paolo Bonzini > --- > CODING_STYLE | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v7 3/5] migration: Dynamic cpu throttling for auto-converge

2015-09-09 Thread Juan Quintela
"Jason J. Herne" wrote: > Remove traditional auto-converge static 30ms throttling code and replace it > with a dynamic throttling algorithm. > > Additionally, be more aggressive when deciding when to start throttling. > Previously we waited until four unproductive memory passes. Now we begin > thr

Re: [Qemu-devel] [PATCH v7 5/5] migration: Disambiguate MAX_THROTTLE

2015-09-09 Thread Juan Quintela
"Jason J. Herne" wrote: > Migration has a define for MAX_THROTTLE. Update comment to clarify that this > is > used for throttling transfer speed. Hopefully this will prevent it from being > confused with a guest cpu throttling entity. > > Signed-off-by: Jason J. Herne > Reviewed-by: Dr. David Al

Re: [Qemu-devel] [PATCH 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-09 Thread Michael S. Tsirkin
On Tue, Sep 08, 2015 at 03:38:47PM +0800, Yuanhan Liu wrote: > From: Changchun Ouyang > > Add a new message, VHOST_USER_SET_VRING_FLAG, to enable and disable > a specific virt queue, which is similar to attach/detach queue for > tap device. > > virtio driver on guest doesn't have to use max virt

[Qemu-devel] What is the meaning of "Device automatic Partial to Slumber transitions"?

2015-09-09 Thread Peter Teoh
I am trying to compare the difference between hdparm running inside qemu (as checkout from latest development git tree) and running on native. My /dev/sdb is an Intel SSD harddisk. So running this: sudo qemu-system-x86_64 -m 1024 -boot c -enable-kvm -net nic -net user \ -device virtio-scsi-pci

Re: [Qemu-devel] [PATCH v7 1/5] cpu: Provide vcpu throttling interface

2015-09-09 Thread Paolo Bonzini
On 09/09/2015 12:41, Juan Quintela wrote: >> > +qemu_mutex_unlock_iothread(); >> > +atomic_set(&cpu->throttle_thread_scheduled, 0); >> > +g_usleep(sleeptime_ns / 1000); /* Convert ns to us for usleep call */ >> > +qemu_mutex_lock_iothread(); > > Why is this thread safe? > > qemu

Re: [Qemu-devel] [PATCH v7 1/5] cpu: Provide vcpu throttling interface

2015-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > On 08/09/2015 19:12, Jason J. Herne wrote: >> Provide a method to throttle guest cpu execution. CPUState is augmented with >> timeout controls and throttle start/stop functions. To throttle the guest cpu >> the caller simply has to call the throttle set function and provide

[Qemu-devel] KVM call for agenda for 2015-09-15

2015-09-09 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH v7 4/5] qmp/hmp: Add throttle ratio to query-migrate and info migrate

2015-09-09 Thread Juan Quintela
"Jason J. Herne" wrote: > Report throttle percentage in info migrate and query-migrate responses when > cpu throttling is active. > > Signed-off-by: Jason J. Herne > Reviewed-by: Dr. David Alan Gilbert I will have printed it always, with a value of zero if throotling is not enabled, but I don't

Re: [Qemu-devel] [Xen-devel] [Patch V1 1/3] xen: introduce dummy system device

2015-09-09 Thread Juergen Gross
On 09/07/2015 05:29 PM, Stefano Stabellini wrote: On Thu, 3 Sep 2015, Juergen Gross wrote: Introduce a new dummy system device serving as parent for virtual buses. This will enable new pv backends to introduce virtual buses which are removable again opposed to system buses which are meant to sta

Re: [Qemu-devel] [PATCH v7 1/5] cpu: Provide vcpu throttling interface

2015-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > On 09/09/2015 12:41, Juan Quintela wrote: >>> > +qemu_mutex_unlock_iothread(); >>> > +atomic_set(&cpu->throttle_thread_scheduled, 0); >>> > +g_usleep(sleeptime_ns / 1000); /* Convert ns to us for usleep call */ >>> > +qemu_mutex_lock_iothread(); >> >> Why is

Re: [Qemu-devel] [Qemu-discuss] compile qemu.git failed on RHEL6

2015-09-09 Thread Peter Maydell
On 9 September 2015 at 07:59, Zheng, Di wrote: > Compile qemu.git failed on RHEL6 while succeed on RHEL7. > GEN x86_64-softmmu/config-devices.mak > > GEN config-all-devices.mak > > Traceback (most recent call last): > > File "/root/cathy/qemu.git/scripts/qapi-visit.py", line 467, in > >

[Qemu-devel] [PATCH 4/9] virtio-gpu: update headers for virgl/3d

2015-09-09 Thread Gerd Hoffmann
Sync with linux kernel headers with virgl/3d patches applied. Signed-off-by: Gerd Hoffmann --- include/standard-headers/linux/virtio_gpu.h | 112 +++- 1 file changed, 111 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/linux/virtio_gpu.h b/include/sta

[Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once

2015-09-09 Thread Gerd Hoffmann
Create a buffer for the vertex data and place vertexes there at initialization time. Then just use the buffer for each texture blit. Signed-off-by: Gerd Hoffmann --- include/ui/shader.h | 4 +++- ui/console-gl.c | 7 ++- ui/shader.c | 32 +++- 3 fil

[Qemu-devel] [PATCH 0/9] add virgl rendering support.

2015-09-09 Thread Gerd Hoffmann
Hi, This patch series adds infrastructure for opengl rendering (context management, define scanout textures), adds support for this to sdl2 and gtk user interfaces and adds virgl/3d mode to virtio-gpu by hooking up the virglrenderer library. please review, Gerd Gerd Hoffmann (9): shaders:

  1   2   3   4   >