Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Cornelia Huck
On Wed, 9 Sep 2015 18:34:01 +0200 Paolo Bonzini wrote: > The Hyper-V definitions are an industry standard and can be used > from code that is not KVM-specific. > > The changes to scripts/update-linux-headers.sh are required because there > is both an asm-x86/hyperv.h and a

[Qemu-devel] [PULL 1/7] pci: Fix pci_device_iommu_address_space() bus propagation

2015-09-10 Thread Michael S. Tsirkin
From: Benjamin Herrenschmidt he current code walks up the bus tree for an iommu, however it passes to the iommu_fn() callback the bus/devfn of the immediate child of the level where the callback was found, rather than the original bus/devfn where the search started

[Qemu-devel] [PULL 2/7] pc: Remove redundant arguments from xen_hvm_init()

2015-09-10 Thread Michael S. Tsirkin
From: Eduardo Habkost Remove arguments that can be found in PCMachineState. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/xen/xen.h | 4 ++--

[Qemu-devel] [PULL 0/7] virtio,pc,acpi fixes, cleanups

2015-09-10 Thread Michael S. Tsirkin
The following changes since commit fc04a730b7e60f4a62d6260d4eb9c537d1d3643f: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150908' into staging (2015-09-08 18:02:36 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-10 Thread Chen Gang
From: peter.mayd...@linaro.org > Date: Thu, 10 Sep 2015 10:02:27 +0100 > > On 10 September 2015 at 06:43, wrote: >> From: Chen Gang >> >> If qemu sets interp_prfix via command line '-L' instead of environments >> variable QEMU_LD_PREFIX, it

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 11:25, Michael S. Tsirkin wrote: > > It is needed because kvm headers include and you don't > > want to pick the system version. > > I see. Makes sense. Then maybe don't bother with kvm.c either? > Keeps it consistent ... kvm.c keeps it consistent between target-i386/kvm.c and

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:28:03AM +0200, Paolo Bonzini wrote: > > > On 10/09/2015 11:25, Michael S. Tsirkin wrote: > > > It is needed because kvm headers include and you don't > > > want to pick the system version. > > > > I see. Makes sense. Then maybe don't bother with kvm.c either? > >

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > was set by configure. That won't be the case on OSX or Windows, where > > the Xen headers don't exist. > > > > Okay. This actually shouldn't be enabled on Windows so what about

Re: [Qemu-devel] [PULL 7/7] hw/pci: fix pci_update_mappings() trace events

2015-09-10 Thread Laszlo Ersek
Hi, On 09/10/15 11:27, Michael S. Tsirkin wrote: > From: Laszlo Ersek > > The current trace prototypes and (matching) trace calls lead to > "unorthodox" PCI BDF notation in at least the stderr trace backend. For > example, the four BARs of a QXL video card at 00:01.0 (bus 0,

Re: [Qemu-devel] [PATCH v3 4/4] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:39:38AM +0200, Paolo Bonzini wrote: > The Hyper-V definitions are an industry standard and can be used > from code that is not KVM-specific. > > Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin > --- >

[Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-10 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- blockdev.c | 47 ++ qapi/block-core.json | 34

[Qemu-devel] [PATCH v3 5/5] hmp: add monitor command to add/remove a child

2015-09-10 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino --- hmp-commands.hx | 28 hmp.c | 20

[Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-10 Thread Wen Congyang
The NBD driver needs: filename, path or (host, port, exportname). It checks which key exists and decides use unix or inet socket. It doesn't recognize the key type, so we can't use union, and can't reuse InetSocketAddress. Signed-off-by: Wen Congyang Signed-off-by:

Re: [Qemu-devel] [PATCH v11 0/5] remove icc bus/bridge

2015-09-10 Thread Zhu Guihua
ping ... On 09/02/2015 05:36 PM, Zhu Guihua wrote: ICC Bus was used for providing a hotpluggable bus for APIC and CPU, but now we use HotplugHandler to make hotplug. So ICC Bus is unnecessary. This code has passed the new pc-cpu-test. And I have tested with kvm along with

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Michael S. Tsirkin
On Wed, Sep 09, 2015 at 06:34:01PM +0200, Paolo Bonzini wrote: > The Hyper-V definitions are an industry standard and can be used > from code that is not KVM-specific. > > The changes to scripts/update-linux-headers.sh are required because there > is both an asm-x86/hyperv.h and a linux/hyperv.h

Re: [Qemu-devel] [PATCH v3] qemu-char: Do not disconnect when there's data for reading

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:04:05AM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 10:24:44AM +0200, Markus Armbruster wrote: > > MAINTAINERS points to Anthony, and you duly cc'ed him, but he's > > effectively retired. Cc'ing recent committers include Paolo and Peter. > > > > Zifei

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Cornelia Huck
On Thu, 10 Sep 2015 10:42:31 +0300 "Michael S. Tsirkin" wrote: > On Wed, Sep 09, 2015 at 06:34:01PM +0200, Paolo Bonzini wrote: > > The Hyper-V definitions are an industry standard and can be used > > from code that is not KVM-specific. > > > > The changes to

[Qemu-devel] [PATCH v3] linux-user/main.c: Set environments variables from command line options

2015-09-10 Thread gang . chen . 5i5j
From: Chen Gang When qemu execute execve() system call, the related command line options can not be passed to the second qemu process, which causes the second process fail. Signed-off-by: Chen Gang --- linux-user/main.c | 5 + 1 file

[Qemu-devel] [PATCH v3 2/4] update Linux headers to 4.2

2015-09-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/standard-headers/linux/pci_regs.h| 381 --- include/standard-headers/linux/virtio_ring.h | 3 +- linux-headers/asm-x86/hyperv.h | 2 + linux-headers/asm-x86/kvm.h | 4 +-

Re: [Qemu-devel] [PATCH v3 3/4] update-linux-headers: copy standard-headers files one by one

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:39:37AM +0200, Paolo Bonzini wrote: > cp_virtio is called for both the asm-s390/ and linux/ directories, > so it looks for pci_regs.h and input.h files in asm-s390/ too. This > makes little sense. In the next patch we will have the opposite > problem; we want to add

Re: [Qemu-devel] [PATCH v3 2/4] update Linux headers to 4.2

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:39:36AM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin > --- > include/standard-headers/linux/pci_regs.h| 381 > --- >

Re: [Qemu-devel] [PATCH 3/4] ide-test: add cdrom pio test

2015-09-10 Thread Markus Armbruster
John Snow writes: > Add a simple read test for ATAPI devices, > using the PIO mechanism. > > Signed-off-by: John Snow > --- > tests/ide-test.c | 144 > +++ > 1 file changed, 144 insertions(+) > > diff

Re: [Qemu-devel] [PATCH 4/4] virtio-ccw: enable virtio-1

2015-09-10 Thread Cornelia Huck
On Thu, 10 Sep 2015 12:22:42 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 10, 2015 at 11:11:20AM +0200, Cornelia Huck wrote: > > On Thu, 10 Sep 2015 12:07:18 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Sep 04, 2015 at 10:54:29AM +0200, Cornelia

Re: [Qemu-devel] [PULL 7/7] hw/pci: fix pci_update_mappings() trace events

2015-09-10 Thread Laszlo Ersek
On 09/10/15 11:54, Michael S. Tsirkin wrote: > On Thu, Sep 10, 2015 at 11:45:01AM +0200, Laszlo Ersek wrote: >> Hi, >> >> On 09/10/15 11:27, Michael S. Tsirkin wrote: >>> From: Laszlo Ersek >>> >>> The current trace prototypes and (matching) trace calls lead to >>> "unorthodox"

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-10 Thread Markus Armbruster
Programmingkid writes: > On Sep 9, 2015, at 6:25 PM, Eric Blake wrote: > >> On 09/09/2015 03:37 PM, Programmingkid wrote: >> >>> >>> Thank you very much for caring. I appreciate all the help I can >>> receive. I so like my idea of >>> sending a command to QEMU as if

Re: [Qemu-devel] [RFC PATCH] spapr: Reduce creation of LMB DR connectors from O(n^3) to O(n^2)

2015-09-10 Thread Peter Crosthwaite
On Wed, Sep 9, 2015 at 11:28 PM, David Gibson wrote: > The dynamic reconfiguration (hotplug) code for the pseries machine type > uses a "DR connector" QOM object for each resource it will be possible > to hotplug. Each of these is added to its owner using >

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Peter Maydell
On 10 September 2015 at 02:21, Chen, Tiejun wrote: > On 9/10/2015 12:10 AM, Stefano Stabellini wrote: >> I found another issue introduced by the gfx passthrough series on >> Windows: >> >> ../hw/pci-host/piix.o: In function `host_pci_config_read': >>

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-10 Thread Peter Maydell
On 10 September 2015 at 06:43, wrote: > From: Chen Gang > > If qemu sets interp_prfix via command line '-L' instead of environments > variable QEMU_LD_PREFIX, it will cause syscall execve() failed. Because > the 2nd qemu has no command line

Re: [Qemu-devel] [PATCH 1/4] virtio: ring sizes vs. reset

2015-09-10 Thread Michael S. Tsirkin
On Fri, Sep 04, 2015 at 10:54:26AM +0200, Cornelia Huck wrote: > We allow guests to change the size of the virtqueue rings by supplying > a number of buffers that is different from the number of buffers the > device was initialized with. Current code has some problems, however, > since reset does

Re: [Qemu-devel] [PATCH 3/5] disk_deadlines: add disk-deadlines option per drive

2015-09-10 Thread Stefan Hajnoczi
On Tue, Sep 08, 2015 at 11:00:26AM +0300, Denis V. Lunev wrote: > diff --git a/blockdev.c b/blockdev.c > index 6b48be6..6cd9c6e 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -361,6 +361,7 @@ static BlockBackend *blockdev_init(const char *file, > QDict *bs_opts, > ThrottleConfig cfg; >

[Qemu-devel] [PATCH v3 2/5] Add new block driver interface to add/delete a BDS's child

2015-09-10 Thread Wen Congyang
In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 52

Re: [Qemu-devel] [PATCH v3 4/4] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Cornelia Huck
On Thu, 10 Sep 2015 11:39:38 +0200 Paolo Bonzini wrote: > The Hyper-V definitions are an industry standard and can be used > from code that is not KVM-specific. > > Signed-off-by: Paolo Bonzini > --- > .../standard-headers}/asm-x86/hyperv.h

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-10 Thread Igor Mammedov
On Tue, 8 Sep 2015 21:38:17 +0800 Xiao Guangrong wrote: > > > On 09/07/2015 10:11 PM, Igor Mammedov wrote: > > On Fri, 14 Aug 2015 22:52:01 +0800 > > Xiao Guangrong wrote: > > > >> The parameter @file is used as backed memory for

Re: [Qemu-devel] [PATCH v3 2/4] update Linux headers to 4.2

2015-09-10 Thread Cornelia Huck
On Thu, 10 Sep 2015 11:39:36 +0200 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > include/standard-headers/linux/pci_regs.h| 381 > --- > include/standard-headers/linux/virtio_ring.h | 3 +- >

Re: [Qemu-devel] [PATCH v3 3/4] update-linux-headers: copy standard-headers files one by one

2015-09-10 Thread Cornelia Huck
On Thu, 10 Sep 2015 11:39:37 +0200 Paolo Bonzini wrote: > cp_virtio is called for both the asm-s390/ and linux/ directories, > so it looks for pci_regs.h and input.h files in asm-s390/ too. This > makes little sense. In the next patch we will have the opposite > problem;

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Dennis Luehring
Am 10.09.2015 um 11:54 schrieb Artyom Tarasenko: On Thu, Sep 10, 2015 at 11:32 AM, Dennis Luehring wrote: >Am 10.09.2015 um 09:00 schrieb Artyom Tarasenko: >>> >>> >strangly your branch doesn't changed anything for pure SPARC64 in my >>> >tests - >>> >i've always completely

Re: [Qemu-devel] [PATCH 1/2] ACPI: Add definitions for the DBG2 table

2015-09-10 Thread Michael S. Tsirkin
On Mon, Sep 07, 2015 at 05:51:50PM +0200, Andrew Jones wrote: > On Mon, Sep 07, 2015 at 03:23:45PM +0100, Leif Lindholm wrote: > > The DBG2 table can be considered a "companion" to SPCR - it points out > > debug consoles available in the system. > > > > Signed-off-by: Leif Lindholm

Re: [Qemu-devel] [PATCH 1/5] add QEMU style defines for __sync_add_and_fetch

2015-09-10 Thread Stefan Hajnoczi
On Tue, Sep 08, 2015 at 11:00:24AM +0300, Denis V. Lunev wrote: > From: Raushaniya Maksudova > > Signed-off-by: Raushaniya Maksudova > Signed-off-by: Denis V. Lunev > CC: Stefan Hajnoczi > CC: Kevin Wolf

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Peter Maydell
On 10 September 2015 at 02:12, Chen, Tiejun wrote: > On 9/9/2015 9:06 PM, Stefano Stabellini wrote: >> >> On Tue, 8 Sep 2015, Peter Maydell wrote: >>> >>> On 8 September 2015 at 18:21, Stefano Stabellini >>> wrote: >>> > The following

Re: [Qemu-devel] [PATCH 4/4] virtio-ccw: enable virtio-1

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:11:20AM +0200, Cornelia Huck wrote: > On Thu, 10 Sep 2015 12:07:18 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Sep 04, 2015 at 10:54:29AM +0200, Cornelia Huck wrote: > > > Let's enable revision 1 for virtio-ccw devices. We can always offer > > >

Re: [Qemu-devel] [PATCH 2/4] qtest/ahci: export generate_pattern

2015-09-10 Thread Markus Armbruster
John Snow writes: > Share the pattern function for ide and ahci test. > > Signed-off-by: John Snow > --- > tests/ahci-test.c | 26 -- > tests/libqos/libqos.c | 26 ++ > tests/libqos/libqos.h | 1 + > 3

Re: [Qemu-devel] [PATCH 1/4] virtio: ring sizes vs. reset

2015-09-10 Thread Cornelia Huck
On Thu, 10 Sep 2015 12:02:44 +0300 "Michael S. Tsirkin" wrote: > On Fri, Sep 04, 2015 at 10:54:26AM +0200, Cornelia Huck wrote: > > We allow guests to change the size of the virtqueue rings by supplying > > a number of buffers that is different from the number of buffers the > >

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-10 Thread Jason Wang
On 09/10/2015 02:18 PM, Yuanhan Liu wrote: > On Thu, Sep 10, 2015 at 01:52:30PM +0800, Jason Wang wrote: >> >> On 09/10/2015 01:17 PM, Yuanhan Liu wrote: >>> On Thu, Sep 10, 2015 at 12:46:00PM +0800, Jason Wang wrote: > > On 09/10/2015 11:57 AM, Yuanhan Liu wrote: >>> On Thu, Sep 10,

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-10 Thread Yuanhan Liu
On Thu, Sep 10, 2015 at 02:54:02PM +0800, Jason Wang wrote: > > > On 09/10/2015 02:18 PM, Yuanhan Liu wrote: > > On Thu, Sep 10, 2015 at 01:52:30PM +0800, Jason Wang wrote: > >> > >> On 09/10/2015 01:17 PM, Yuanhan Liu wrote: > >>> On Thu, Sep 10, 2015 at 12:46:00PM +0800, Jason Wang wrote: >

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-10 Thread Chen Gang
Oh, this issue may be for all command lines (e.g. -d option), I  guess, we need process them all in main() when process command line options. > Subject: Re: [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when > interp_prefix is changed > To:

[Qemu-devel] [PATCH] cutils: work around platform differences in strto{l, ul, ll, ull}

2015-09-10 Thread Paolo Bonzini
Linux returns 0 if no conversion was made, while OS X and presumably the BSDs return EINVAL. The OS X convention rejects more invalid inputs, so convert to it and adjust the test case. Windows returns 1 from strtoul and strtoull (instead of -1) for negative out-of-range input; fix it up.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-char: Do not disconnect when there's data for reading

2015-09-10 Thread Michael S. Tsirkin
On Wed, Sep 24, 2014 at 11:52:37AM +0400, Michael Tokarev wrote: > 16.09.2014 09:31, Zifei Tong wrote: > > Friendly ping. > > > > Also CC to qemu-trivial. > > There was at least 2 subsequent versions of this down the line, > a v2 and a v3. (Just to show why I haven't applied it to -trivial). >

Re: [Qemu-devel] [PATCH 2/5] disk_deadlines: add request to resume Virtual Machine

2015-09-10 Thread Stefan Hajnoczi
On Tue, Sep 08, 2015 at 11:00:25AM +0300, Denis V. Lunev wrote: > From: Raushaniya Maksudova > > In some cases one needs to pause and resume a Virtual Machine from inside > of Qemu. Currently there are request functions to pause VM (vmstop), but > there are no

[Qemu-devel] [PULL 6/7] pc: memhotplug: keep reserved-memory-end broken on 2.4 and earlier machines

2015-09-10 Thread Michael S. Tsirkin
From: Igor Mammedov it will prevent guests on old machines from seeing inconsistent memory mapping in firmware/ACPI views. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 7/7] hw/pci: fix pci_update_mappings() trace events

2015-09-10 Thread Michael S. Tsirkin
From: Laszlo Ersek The current trace prototypes and (matching) trace calls lead to "unorthodox" PCI BDF notation in at least the stderr trace backend. For example, the four BARs of a QXL video card at 00:01.0 (bus 0, slot 1, function 0) are traced like this (PID and timestamps

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Chen, Tiejun
As you see this short log, "hw/pci-assign: split pci-assign.c", so this means I just extract something from the original hw/i386/kvm/pci-assign.c, and here so I just keep those original head files residing hw/i386/kvm/pci-assign.c, and I didn't introduce anything new. hw/i386/kvm/pci-assign.c

[Qemu-devel] [PATCH v3 4/4] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Paolo Bonzini
The Hyper-V definitions are an industry standard and can be used from code that is not KVM-specific. Signed-off-by: Paolo Bonzini --- .../standard-headers}/asm-x86/hyperv.h | 10 +- linux-headers/asm-x86/hyperv.h | 253 +

[Qemu-devel] [PATCH v3 1/4] pci: remove Link Training error from AER error list

2015-09-10 Thread Paolo Bonzini
The spec says: Undefined – The value read from this bit is undefined. In previous versions of this specification, this bit was used to indicate a Link Training Error. System software must ignore the value read from this bit. System software is permitted to write any value to this bit. Do not

[Qemu-devel] [PATCH v3 3/4] update-linux-headers: copy standard-headers files one by one

2015-09-10 Thread Paolo Bonzini
cp_virtio is called for both the asm-s390/ and linux/ directories, so it looks for pci_regs.h and input.h files in asm-s390/ too. This makes little sense. In the next patch we will have the opposite problem; we want to add asm-x86/hyperv.h, and there's also a linux/hyperv.h file with unwanted

Re: [Qemu-devel] [PATCH 4/5] disk_deadlines: add control of requests time expiration

2015-09-10 Thread Stefan Hajnoczi
On Tue, Sep 08, 2015 at 04:48:24PM +0200, Kevin Wolf wrote: > Am 08.09.2015 um 16:23 hat Denis V. Lunev geschrieben: > > On 09/08/2015 04:05 PM, Kevin Wolf wrote: > > >Am 08.09.2015 um 13:27 hat Denis V. Lunev geschrieben: > > >>interesting point. Yes, it flushes all requests and most likely > >

Re: [Qemu-devel] [PATCH] spapr: Reduce advertised max LUNs for spapr_vscsi

2015-09-10 Thread David Gibson
On Thu, Sep 10, 2015 at 08:12:47AM +0200, Thomas Huth wrote: > On 10/09/15 03:24, David Gibson wrote: > > On Wed, Sep 09, 2015 at 09:29:18AM +0200, Thomas Huth wrote: > >> On 09/09/15 09:19, David Gibson wrote: > >>> On Wed, Sep 09, 2015 at 08:25:34AM +0200, Thomas Huth wrote: > On 09/09/15

Re: [Qemu-devel] qmp_device_add() ret_data argument

2015-09-10 Thread Markus Armbruster
Programmingkid writes: > What does the function qmp_device_add() have a ret_data argument if it > isn't used? This function is located in qdev-monitor.c. QMP command handlers all implement the same interface: void (*cmd_new)(QDict *params, QObject **ret_data,

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 09:42, Michael S. Tsirkin wrote: > On Wed, Sep 09, 2015 at 06:34:01PM +0200, Paolo Bonzini wrote: >> The Hyper-V definitions are an industry standard and can be used >> from code that is not KVM-specific. >> >> The changes to scripts/update-linux-headers.sh are required because

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Chen, Tiejun
xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH was set by configure. That won't be the case on OSX or Windows, where the Xen headers don't exist. Okay. This actually shouldn't be enabled on Windows so what about this? diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Dennis Luehring
Am 10.09.2015 um 09:00 schrieb Artyom Tarasenko: >strangly your branch doesn't changed anything for pure SPARC64 in my tests - >i've always completely removed the qemu folder and cleanly rebuild >(all based on stable shell-scripts) Can you please show "perf top" of the qemu-system-sparc64

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > As you see this short log, "hw/pci-assign: split pci-assign.c", so this > > > means I just extract something from the original hw/i386/kvm/pci-assign.c, > > > and here so I just keep those original head files residing > > > hw/i386/kvm/pci-assign.c,

Re: [Qemu-devel] [PATCH 1/2] ACPI: Add definitions for the DBG2 table

2015-09-10 Thread Igor Mammedov
On Thu, 10 Sep 2015 11:19:09 +0300 "Michael S. Tsirkin" wrote: > On Mon, Sep 07, 2015 at 05:51:50PM +0200, Andrew Jones wrote: > > On Mon, Sep 07, 2015 at 03:23:45PM +0100, Leif Lindholm wrote: > > > The DBG2 table can be considered a "companion" to SPCR - it points out > > >

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-10 Thread Markus Armbruster
Programmingkid writes: > Does this look about right? > > QDict *qdict; > Error *errp; > QObject **ret_data; > static int counter; > char *idString, *fileName; > > // The file variable is objective-c, left that code out > > fileName =

Re: [Qemu-devel] [PATCH v2 1/2] update Linux headers to 4.2

2015-09-10 Thread Michael S. Tsirkin
On Wed, Sep 09, 2015 at 06:34:00PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/pci/pcie_aer.c| 4 +- > include/standard-headers/linux/pci_regs.h| 381 > --- >

[Qemu-devel] [PULL 3/7] virtio: avoid leading underscores for helpers

2015-09-10 Thread Michael S. Tsirkin
From: Cornelia Huck Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add feature checking helpers") introduced a helper __virtio_has_feature. We don't want to use reserved identifiers, though, so let's rename __virtio_has_feature to virtio_has_feature and

[Qemu-devel] [PULL 4/7] acpi: Remove unused definition.

2015-09-10 Thread Michael S. Tsirkin
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH V2 0/8] virtio 1.0 pci optimizations and fixes

2015-09-10 Thread Michael S. Tsirkin
On Wed, Sep 02, 2015 at 11:25:17AM +0800, Jason Wang wrote: > Hi all: > > This series tries to fix the following issues: > > - qemu abort when trying to adjust endianness for zero length eventfd, > this prevent fast mmio eventfd from being used in ppc. Fixing by > skip the endianness

[Qemu-devel] [PULL 5/7] pc: memhotplug: fix incorrectly set reserved-memory-end

2015-09-10 Thread Michael S. Tsirkin
From: Igor Mammedov reserved-memory-end tells firmware address from which it could start treating memory as PCI address space and map PCI BARs after it to avoid collisions with RAM. Currently it is incorrectly pointing to address where hotplugged memory range starts which

Re: [Qemu-devel] [PATCH 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-10 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 11:12:46AM +0530, Deepak Shetty wrote: > [snip] > > On Wed, Sep 9, 2015 at 10:37 PM, Raghavendra Talur > wrote: > > > > > > > From QEMU's perspective, it would be better to use separate fields > > > >> (that have type information) than to encode

Re: [Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-10 Thread Michael S. Tsirkin
On Tue, Sep 08, 2015 at 03:27:59PM +0800, Jason Wang wrote: > > > On 09/07/2015 04:21 PM, Cornelia Huck wrote: > > On Mon, 7 Sep 2015 15:39:59 +0800 > > Jason Wang wrote: > > > >> > On 09/02/2015 07:06 PM, Cornelia Huck wrote: > >>> > > On Wed, 2 Sep 2015 11:25:21 +0800 >

[Qemu-devel] [PATCH v3 0/2] update-linux-headers changes

2015-09-10 Thread Paolo Bonzini
Patches 1 and 2 updates the Linux headers, which required an unexpected change to hw/pci/pcie_aer.c. Patches 3 and 4 modify the update-linux-headers script so that asm-x86/hyperv.h can be moved to standard-headers. This is required by the Hyper-V crash MSR patches, which use a Hyper-V define in

Re: [Qemu-devel] [PATCH v3 1/4] pci: remove Link Training error from AER error list

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:39:35AM +0200, Paolo Bonzini wrote: > The spec says: > > Undefined – The value read from this bit is > undefined. In previous versions of this > specification, this bit was used to indicate a Link > Training Error. System software must ignore the > value read from this

Re: [Qemu-devel] [PATCH 0/4] ide: simple ATAPI tests

2015-09-10 Thread Markus Armbruster
John Snow writes: > On 09/09/2015 01:00 PM, Paolo Bonzini wrote: >> >> >> On 09/09/2015 18:37, John Snow wrote: >>> Ping -- apologies. :) >>> >>> I'll take a simple ACK before I merge it into my tree. >> >> I don't think you need one. :) >> >> Paolo >> > > I guess

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-10 Thread Wen Congyang
On 09/10/2015 06:04 PM, Daniel P. Berrange wrote: > On Thu, Sep 10, 2015 at 05:55:04PM +0800, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >>

[Qemu-devel] [PATCH v2] linux-user/main.c: Set environments variables from command line options

2015-09-10 Thread gang . chen . 5i5j
From: Chen Gang When qemu execute execve() system call, the related command line options can not be passed to the second qemu process, which causes the second process fail. Signed-off-by: Chen Gang --- linux-user/main.c | 4 1 file

Re: [Qemu-devel] [PATCH 1/3] monitor: split MonitorQAPIEventState

2015-09-10 Thread Daniel P. Berrange
On Wed, Sep 02, 2015 at 01:09:41PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Create a separate pending event structure MonitorQAPIEventPending. > Use a MonitorQAPIEventDelay callback to handle the delaying. This > allows other

Re: [Qemu-devel] [PATCH 2/3] monitor: throttle QAPI_EVENT_VSERPORT_CHANGE by "id"

2015-09-10 Thread Daniel P. Berrange
On Wed, Sep 02, 2015 at 01:09:42PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use a hash table to lookup the pending event corresponding to the "id" > field. The hash table may grow without limit here, the following patch > will add some

Re: [Qemu-devel] Confused by QOM: /machine/unattached/device[5]/dr-connector[255]/fdt

2015-09-10 Thread Markus Armbruster
TL;DR: Andreas, there's one question specifically for you, search for "QOM:". Andreas Färber writes: > Am 09.09.2015 um 17:22 schrieb Markus Armbruster: >> Andreas Färber writes: >>> Am 09.09.2015 um 16:38 schrieb Markus Armbruster: I ran into this:

Re: [Qemu-devel] [PATCH 4/4] virtio-ccw: enable virtio-1

2015-09-10 Thread Michael S. Tsirkin
On Fri, Sep 04, 2015 at 10:54:29AM +0200, Cornelia Huck wrote: > Let's enable revision 1 for virtio-ccw devices. We can always offer > VERSION_1 as drivers in legacy mode won't be able to see it anyway. > > We have to introduce a way to set a lower maximum revision for a device > to accommodate

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 08:57, Sharma Bhupesh wrote: > So based on my limited understanding, can't the OVMF driver which > uses features from some GPL based code, carry a dual license (GPL + > x11 [MIT]), No, that would require agreement from the original copyright holder, which you are not going to get.

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Daniel P. Berrange
On Wed, Sep 09, 2015 at 05:41:59PM -0700, Jordan Justen wrote: > On 2015-09-09 16:05:20, Andrew Fish wrote: > > > > > On Sep 9, 2015, at 3:24 PM, Jordan Justen > > > wrot> > > FWIW, I don't mind if the consensus is that GplDriverPkg must > > > live in > > > a

Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

2015-09-10 Thread Igor Mammedov
On Tue, 8 Sep 2015 22:03:01 +0800 Xiao Guangrong wrote: > > > On 09/07/2015 09:40 PM, Igor Mammedov wrote: > > On Sun, 6 Sep 2015 14:07:21 +0800 > > Xiao Guangrong wrote: > > > >> > >> > >> On 09/02/2015 07:31 PM, Igor Mammedov

[Qemu-devel] [PATCH v3 0/5] qapi: child add/delete support

2015-09-10 Thread Wen Congyang
If quorum's child is broken, we can use mirror job to replace it. But sometimes, the user only need to remove the broken child, and add it later when the problem is fixed. ChangLog: v3: 1. Don't open BDS in bdrv_add_child(). Use the existing BDS which is created by the QMP command

Re: [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end

2015-09-10 Thread Igor Mammedov
On Wed, 9 Sep 2015 17:03:56 -0300 Eduardo Habkost wrote: > On Mon, Sep 07, 2015 at 01:55:31PM +0200, Igor Mammedov wrote: > > reserved-memory-end tells firmware address from which > > it could start treating memory as PCI address space > > and map PCI BARs after it to avoid

[Qemu-devel] [PATCH v3 3/5] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-09-10 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 6 ++--- block/quorum.c| 72 +--

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Artyom Tarasenko
On Thu, Sep 10, 2015 at 8:07 AM, Dennis Luehring wrote: > Am 08.09.2015 um 21:00 schrieb Richard Henderson: >> >> Anyway, I've just fixed the sparc problem and re-pushed the tree to >> >>git://github.com/rth7680/qemu.git tcg-search-2 >> >> for anyone who wants to do any

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-10 Thread Thomas Huth
On 09/09/15 23:10, Thomas Huth wrote: > On 08/09/15 07:15, David Gibson wrote: ... >> At this point rather than just implementing them as discrete machine >> options, I suspect it will be more maintainable to split out the >> h-random implementation as a pseudo-device with its own qdev and so >>

Re: [Qemu-devel] [PATCH v3] qemu-char: Do not disconnect when there's data for reading

2015-09-10 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 10:24:44AM +0200, Markus Armbruster wrote: > MAINTAINERS points to Anthony, and you duly cc'ed him, but he's > effectively retired. Cc'ing recent committers include Paolo and Peter. > > Zifei Tong writes: I merged the patch that broke this, so I'll

Re: [Qemu-devel] [PATCH v2] linux-user/main.c: Set environments variables from command line options

2015-09-10 Thread Chen Gang
Oh, very sorry! The patch v2 did not process simple options (e.g. -strace). I should send patch v3 for it. Thanks. > From: gang.chen.5...@gmail.com > To: riku.voi...@iki.fi > CC: r...@twiddle.net; peter.mayd...@linaro.org; xili_gchen_5...@hotmail.com; >

Re: [Qemu-devel] [PATCH 3/3] monitor: remove old entries from event hash table

2015-09-10 Thread Daniel P. Berrange
On Wed, Sep 02, 2015 at 01:09:43PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not let the hash table grow without limit, schedule a cleanup for > outdated event. > > Signed-off-by: Marc-André Lureau > ---

Re: [Qemu-devel] [PATCH 4/4] virtio-ccw: enable virtio-1

2015-09-10 Thread Cornelia Huck
On Thu, 10 Sep 2015 12:07:18 +0300 "Michael S. Tsirkin" wrote: > On Fri, Sep 04, 2015 at 10:54:29AM +0200, Cornelia Huck wrote: > > Let's enable revision 1 for virtio-ccw devices. We can always offer > > VERSION_1 as drivers in legacy mode won't be able to see it anyway. > > >

Re: [Qemu-devel] [PATCH v4 2/4] iotests: Add dependency info to groups list

2015-09-10 Thread Fam Zheng
On Wed, 09/09 12:35, John Snow wrote: > Ping -- Fam? Well, it's not a particularly interesting patch to review, but since you caught me ... > > On 08/25/2015 07:02 PM, John Snow wrote: > > Add a few external dependency groups to the iotests groups list, > > such as "qemu", "nbd", and "scm". > >

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:19:48AM +0200, Paolo Bonzini wrote: > > > On 10/09/2015 09:42, Michael S. Tsirkin wrote: > > On Wed, Sep 09, 2015 at 06:34:01PM +0200, Paolo Bonzini wrote: > >> The Hyper-V definitions are an industry standard and can be used > >> from code that is not KVM-specific. >

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 11:32, Michael S. Tsirkin wrote: > > kvm.c keeps it consistent between target-i386/kvm.c and > > target-i386/cpu.h (which will include standard-headers/asm-x86/hyperv.h > > in Denis's patch). > > Yes but kvm_para.h uses asm/hyperv.h > MAybe do the same everywhere? Unfortunately

Re: [Qemu-devel] [PULL 7/7] hw/pci: fix pci_update_mappings() trace events

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:45:01AM +0200, Laszlo Ersek wrote: > Hi, > > On 09/10/15 11:27, Michael S. Tsirkin wrote: > > From: Laszlo Ersek > > > > The current trace prototypes and (matching) trace calls lead to > > "unorthodox" PCI BDF notation in at least the stderr trace

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-10 Thread Artyom Tarasenko
On Thu, Sep 10, 2015 at 11:32 AM, Dennis Luehring wrote: > Am 10.09.2015 um 09:00 schrieb Artyom Tarasenko: >>> >>> >strangly your branch doesn't changed anything for pure SPARC64 in my >>> > tests - >>> >i've always completely removed the qemu folder and cleanly rebuild >>>

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Laszlo Ersek
On 09/10/15 08:19, Alexander Graf wrote: > > >> Am 10.09.2015 um 07:32 schrieb Jordan Justen : >> Laszlo's email raised the GPL question, but I was not sure what the >> EDK II community would accept with regards to GPL. Thus ... I asked. I >> guess I'm getting a

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-10 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 05:55:04PM +0800, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > blockdev.c | 47

Re: [Qemu-devel] [PATCH] spapr: Reduce advertised max LUNs for spapr_vscsi

2015-09-10 Thread Laurent Vivier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/09/2015 08:48, David Gibson wrote: > On Thu, Sep 10, 2015 at 08:12:47AM +0200, Thomas Huth wrote: >> On 10/09/15 03:24, David Gibson wrote: >>> On Wed, Sep 09, 2015 at 09:29:18AM +0200, Thomas Huth wrote: On 09/09/15 09:19, David Gibson

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
CC Michael On Thu, 10 Sep 2015, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > > was set by configure. That won't be the case on OSX or Windows, where > > > the Xen headers don't exist. > > > > >

  1   2   3   4   >