Re: [Qemu-devel] [PATCH v5 01/14] qapi: Add transaction support to block-dirty-bitmap operations

2015-09-11 Thread Eric Blake
On 09/07/2015 01:34 AM, Fam Zheng wrote: > From: John Snow > > This adds two qmp commands to transactions. > > block-dirty-bitmap-add allows you to create a bitmap simultaneously > alongside a new full backup to accomplish a clean synchronization > point. > >

[Qemu-devel] [PATCH v6 23/26] qapi-schema: Fix up misleading specification of netdev_add

2015-09-11 Thread Markus Armbruster
It doesn't take a 'props' argument, let alone one in the format "NAME=VALUE,..." The bogus arguments specification doesn't matter due to 'gen': false. Clean it up to be incomplete rather than wrong, and document the incompleteness. While there, improve netdev_add usage example in the manual: add

[Qemu-devel] [PATCH v6 00/26] qapi: QMP introspection

2015-09-11 Thread Markus Armbruster
Series needs my "[PATCH for-2.4 0/2] qom: Fix misuse of Error API" to pass tests. It's in Andreas's qom-next (currently at commit de1da05), so I based on that. You can fetch it from my git://repo.or.cz/qemu/armbru.git branch qapi-introspect. * PATCH 01-18 basically replace the intermediate

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-11 Thread Markus Armbruster
Eduardo Habkost writes: > Ping? > > So, what's the reason we are still keeping those old machines in the > code? Inertia?

[Qemu-devel] [PATCH 0/4] target-i386: Don't try to enable unsupported TCG features by default

2015-09-11 Thread Eduardo Habkost
This series makes QEMU stop trying to enable an unsupported feature by default in TCG mode, avoiding the warnings shown by the (now enabled by default) "check" mode. To do that, I cchanged the kvm_default_features code to be based on QOM properties, and added a new "type" field to allow

[Qemu-devel] [PULL 13/23] qcow2: Move rest of option handling to qcow2_update_options()

2015-09-11 Thread Kevin Wolf
With this commit, the handling of driver-specific options in qcow2_open() is completely separated out into qcow2_update_options(). Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/qcow2.c | 134

[Qemu-devel] [PULL 17/23] qcow2: Support updating driver-specific options in reopen

2015-09-11 Thread Kevin Wolf
For updating the cache sizes, disabling lazy refcounts and updating the clean_cache_timer there is a bit more to do than just changing the variables, but otherwise we're all set for changing options during bdrv_reopen(). Just implement the missing pieces and hook the functions up in

Re: [Qemu-devel] [PATCH 0/4] target-i386: Don't try to enable unsupported TCG features by default

2015-09-11 Thread Eduardo Habkost
On Fri, Sep 11, 2015 at 12:32:35PM -0700, Richard Henderson wrote: > On 09/11/2015 12:25 PM, Eduardo Habkost wrote: > > This series makes QEMU stop trying to enable an unsupported feature by > > default > > in TCG mode, avoiding the warnings shown by the (now enabled by default) > > "check" mode.

Re: [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function

2015-09-11 Thread Eric Blake
On 09/07/2015 01:34 AM, Fam Zheng wrote: > This will be reused by the coming new transactional completion code. > > Signed-off-by: Fam Zheng > Reviewed-by: John Snow > --- > block/backup.c | 26 -- > 1 file changed, 16 insertions(+),

[Qemu-devel] [PULL 03/23] block: Drop drv parameter from bdrv_open_inherit()

2015-09-11 Thread Kevin Wolf
From: Max Reitz Now that this parameter is effectively unused, we can drop it and just pass NULL to bdrv_fill_options(). Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block.c | 17

[Qemu-devel] [PULL 04/23] block: Drop drv parameter from bdrv_fill_options()

2015-09-11 Thread Kevin Wolf
From: Max Reitz Now that this parameter is effectively unused, we can drop it and change the function accordingly. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block.c | 59

[Qemu-devel] [PATCH v2 1/4] qga: add QGA_CONF environment variable

2015-09-11 Thread marcandre . lureau
From: Marc-André Lureau Having a environment variable allows to override default configuration path, useful for testing. Note that this can't easily be an argument, since loading config is done before parsing the arguments. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v2 3/4] qtest: add a few fd-level qmp helpers

2015-09-11 Thread marcandre . lureau
From: Marc-André Lureau Add a few functions to interact with qmp via a simple fd. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- tests/libqtest.c | 45

[Qemu-devel] [PATCH v6 01/26] qapi: Rename class QAPISchema to QAPISchemaParser

2015-09-11 Thread Markus Armbruster
I want to name a new class QAPISchema. While there, make it a new-style class. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- scripts/qapi.py | 8 1 file changed, 4

[Qemu-devel] [PATCH v6 03/26] qapi: QAPISchema code generation helper methods

2015-09-11 Thread Markus Armbruster
New methods c_name(), c_type(), c_null(), json_type(), alternate_qtype(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- scripts/qapi.py | 93

[Qemu-devel] [PATCH v6 20/26] qapi: Fix output visitor to return qnull() instead of NULL

2015-09-11 Thread Markus Armbruster
Before commit 1d10b44, it crashed. Since then, it returns NULL, with a FIXME comment. The FIXME is valid: code that assumes QObject * can't be null exists. I'm not aware of a way to feed this problematic return value to code that actually chokes on null in the current code, but the next few

[Qemu-devel] [PATCH v6 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add

2015-09-11 Thread Markus Armbruster
With the previous commit, the generated marshalers just work, and save us a bit of handwritten code. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/monitor/monitor.h | 3 --- qapi-schema.json | 9 +++-- qmp-commands.hx

Re: [Qemu-devel] [PATCH 0/4] target-i386: Don't try to enable unsupported TCG features by default

2015-09-11 Thread Richard Henderson
On 09/11/2015 12:25 PM, Eduardo Habkost wrote: > This series makes QEMU stop trying to enable an unsupported feature by default > in TCG mode, avoiding the warnings shown by the (now enabled by default) > "check" mode. > > To do that, I cchanged the kvm_default_features code to be based on QOM >

[Qemu-devel] [PATCH 2/4] target-i386: Convert kvm_default_*features to property/value pairs

2015-09-11 Thread Eduardo Habkost
Convert the kvm_default_features and kvm_default_unset_features arrays into a simple list of property/value pairs that will be applied to X86CPU objects when using KVM. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 8 ++--- hw/i386/pc_q35.c | 4 +--

[Qemu-devel] [PULL 06/23] qcow2: Rename BDRVQcowState to BDRVQcow2State

2015-09-11 Thread Kevin Wolf
BDRVQcowState is already used by qcow1, and gdb is always confused which one to use. Rename the qcow2 one so they can be distinguished. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto

Re: [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions

2015-09-11 Thread Eric Blake
On 09/07/2015 01:34 AM, Fam Zheng wrote: > Sometimes block jobs must execute as a transaction group. Finishing > jobs wait until all other jobs are ready to complete successfully. > Failure or cancellation of one job cancels the other jobs in the group. > > Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v2 2/3] q35: Move options common to all classes to pc_i440fx_machine_options()

2015-09-11 Thread Eduardo Habkost
The existing default_machine_opts and default_display settings will still apply to future machine classes. So it makes sense to move them to pc_i440fx_machine_options() instead of keeping them in a version-specific machine_options function. Signed-off-by: Eduardo Habkost ---

[Qemu-devel] [PATCH v2 3/3] pc: Introduce pc-*-2.5 machine classes

2015-09-11 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 14 +- hw/i386/pc_q35.c | 12 +++- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 4 4 files changed, 31 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c

[Qemu-devel] [PULL 11/23] qcow2: Factor out qcow2_update_options()

2015-09-11 Thread Kevin Wolf
Eventually we want to be able to change options at runtime. As a first step towards that goal, separate some option handling code from the general initialisation code in qcow2_open(). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH v6 20/26] qapi: Fix output visitor to return qnull() instead of NULL

2015-09-11 Thread Eric Blake
On 09/11/2015 01:18 PM, Markus Armbruster wrote: > Before commit 1d10b44, it crashed. Since then, it returns NULL, with > a FIXME comment. The FIXME is valid: code that assumes QObject * > can't be null exists. I'm not aware of a way to feed this problematic > return value to code that actually

Re: [Qemu-devel] [PATCH v6 20/26] qapi: Fix output visitor to return qnull() instead of NULL

2015-09-11 Thread Eric Blake
On 09/11/2015 02:43 PM, Eric Blake wrote: >> +++ b/tests/test-qmp-output-visitor.c >> @@ -485,7 +485,7 @@ static void test_visitor_out_empty(TestOutputVisitorData >> *data, >> QObject *arg; >> >> arg = qmp_output_get_qobject(data->qov); >> -g_assert(!arg); >> +

Re: [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions

2015-09-11 Thread Max Reitz
On 07.09.2015 09:34, Fam Zheng wrote: > Sometimes block jobs must execute as a transaction group. Finishing > jobs wait until all other jobs are ready to complete successfully. > Failure or cancellation of one job cancels the other jobs in the group. > > Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH v6 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-09-11 Thread Markus Armbruster
Fixes flat unions to get the base's base members. Test case is from commit 2fc0043, in qapi-schema-test.json: { 'union': 'UserDefFlatUnion', 'base': 'UserDefUnionBase', 'discriminator': 'enum1', 'data': { 'value1' : 'UserDefA', 'value2' : 'UserDefB',

[Qemu-devel] [PATCH v6 18/26] qapi-commands: De-duplicate output marshaling functions

2015-09-11 Thread Markus Armbruster
gen_marshal_output() uses its parameter name only for name of the generated function. Name it after the type being marshaled instead of its caller, and drop duplicates. Saves 7 copies of qmp_marshal_output_int() in qemu-ga, and one copy of qmp_marshal_output_str() in qemu-system-*.

[Qemu-devel] [PATCH v6 21/26] qapi: Introduce a first class 'any' type

2015-09-11 Thread Markus Armbruster
It's first class, because unlike '**', it actually works, i.e. doesn't require 'gen': false. '**' will go away next. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 1 +

[Qemu-devel] [PATCH v6 17/26] qapi: De-duplicate parameter list generation

2015-09-11 Thread Markus Armbruster
Generated qapi-event.[ch] lose line breaks. No change otherwise. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 11 ++- scripts/qapi-event.py| 18 +++--- scripts/qapi.py | 16

[Qemu-devel] [PATCH 4/4] target-i386: Disable DE on qemu64 & qemu32 on TCG

2015-09-11 Thread Eduardo Habkost
We don't want to make QEMU show CPUID feature warnings by default when running in TCG mode, so disable the flag in the default qemu32 and qemu64 CPU models, and add it to kvm_default_props so it gets enabled when running KVM. We don't need any compat code for this because: * DE was already

[Qemu-devel] [PULL 05/23] block: Drop bdrv_find_whitelisted_format()

2015-09-11 Thread Kevin Wolf
From: Max Reitz It is unused by now, so we can drop it. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block.c | 7 --- include/block/block.h | 2 -- 2 files

[Qemu-devel] [PULL 02/23] block: Drop drv parameter from bdrv_open()

2015-09-11 Thread Kevin Wolf
From: Max Reitz Now that this parameter is effectively unused, we can drop it and just pass NULL on to bdrv_open_inherit(). Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block.c

[Qemu-devel] [PULL 00/23] Block layer patches

2015-09-11 Thread Kevin Wolf
The following changes since commit 30c38c90bd3f1bb105ebc069ac1821067c980b7c: scripts/qemu-gdb: Add brief comment describing usage (2015-09-11 17:14:50 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to

[Qemu-devel] [PULL 16/23] qcow2: Make qcow2_update_options() suitable for transactions

2015-09-11 Thread Kevin Wolf
Before we can allow updating options at runtime with bdrv_reopen(), we need to split the function into prepare/commit/abort parts. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/qcow2.c | 113

[Qemu-devel] [PULL 23/23] qcow2: Make qcow2_alloc_bytes() more explicit

2015-09-11 Thread Kevin Wolf
From: Max Reitz In case of -EAGAIN returned by update_refcount(), we should discard the cluster offset we were trying to allocate and request a new one, because in theory that old offset might now be taken by a refcount block. In practice, this was not the case due to

[Qemu-devel] [PULL 12/23] qcow2: Move qcow2_update_options() call up

2015-09-11 Thread Kevin Wolf
qcow2_update_options() only updates some variables in BDRVQcowState and doesn't really depend on other parts of it being initialised yet, so it can be moved so that it immediately follows the other half of option handling code in qcow2_open(). Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v6 10/26] qapi-event: Eliminate global variable event_enum_value

2015-09-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-event.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py index aed45d6..537da17 100644 --- a/scripts/qapi-event.py

[Qemu-devel] [PATCH v6 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-09-11 Thread Markus Armbruster
Fixes flat unions to visit the base's base members (the previous commit merely added them to the struct). Same test case. Patch's effect on visit_type_UserDefFlatUnion(): static void visit_type_UserDefFlatUnion_fields(Visitor *m, UserDefFlatUnion **obj, Error **errp) { Error

[Qemu-devel] [PATCH v6 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

2015-09-11 Thread Markus Armbruster
Generate just 'FOO' instead of 'struct FOO' when possible. Drop helper functions that are now unused. Make pep8 and pylint reasonably happy. Rename generate_FOO() functions to gen_FOO() for consistency. Use more consistent and sensible variable names. Consistently use c_ for mapping keys when

[Qemu-devel] [PATCH 3/4] target-i386: Add optional class name to kvm_default_props

2015-09-11 Thread Eduardo Habkost
This will allow us to define class-specific KVM defaults, instead of defaults that apply to all CPU models. If this table is starting to look like the global properties tables, that's not a coincidence: in the future, we might convert this to accelerator-specific code that simply register global

[Qemu-devel] [PULL 07/23] block: Allow specifying driver-specific options to reopen

2015-09-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 42 +++--- block/commit.c| 4 ++-- include/block/block.h | 4 +++- 3 files changed, 44 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PULL 10/23] qcow2: Improve error message

2015-09-11 Thread Kevin Wolf
Eric says that "any" sounds better than "either", and my non-native feeling says the same, so let's change it. Suggested-by: Eric Blake Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/qcow2.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 08/23] qemu-io: Remove duplicate 'open' error message

2015-09-11 Thread Kevin Wolf
qemu_opts_parse_noisily() already prints an error message with the exact reason why the parsing failed. No need to add another less specific one. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qemu-io.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Qemu-devel] [PULL 14/23] qcow2: Leave s unchanged on qcow2_update_options() failure

2015-09-11 Thread Kevin Wolf
On return, either all new options should be applied to BDRVQcowState (on success), or all of the old settings should be preserved (on failure). Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block/qcow2.c | 57

[Qemu-devel] [PULL 19/23] qemu-iotests: More qcow2 reopen tests

2015-09-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/137 | 145 + tests/qemu-iotests/137.out | 42 + tests/qemu-iotests/group | 1 + 3 files changed, 188 insertions(+)

[Qemu-devel] [PATCH v2 0/3] pc-*-2.5 machine-types

2015-09-11 Thread Eduardo Habkost
This introduces the pc-q35-2.5 and pc-i440fx-2.5 machine-types. Changes v1 -> v2: * Trivial rebase on top of latest qemu.git master Eduardo Habkost (3): q35: Move options common to all classes to pc_q35_machine_options() q35: Move options common to all classes to pc_i440fx_machine_options()

[Qemu-devel] [PATCH v2 1/3] q35: Move options common to all classes to pc_q35_machine_options()

2015-09-11 Thread Eduardo Habkost
The existing default_machine_opts, default_display, no_floppy, and no_tco settings will still apply to future machine classes. So it makes sense to move them to pc_q35_machine_options() instead of keeping them in a version-specific machine_options function. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 01/23] block: Always pass NULL as drv for bdrv_open()

2015-09-11 Thread Kevin Wolf
From: Max Reitz Change all callers of bdrv_open() to pass the driver name in the options QDict instead of passing its BlockDriver pointer. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 15/23] qcow2: Fix memory leak in qcow2_update_options() error path

2015-09-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block/qcow2.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index c61d996..374a56d 100644 ---

[Qemu-devel] [PATCH v2 4/4] tests: add a local test for guest agent

2015-09-11 Thread marcandre . lureau
From: Marc-André Lureau Add some local guest agent tests (as it is better than nothing) only when CONFIG_LINUX. They can be run inside or outside a VM, when run inside a VM, they will do a bit more side effects, such as freezing/thawing the FS or changing the time.

[Qemu-devel] [PATCH v2 2/4] qga: do not override configuration verbosity

2015-09-11 Thread marcandre . lureau
From: Marc-André Lureau Move the default verbosity settings before loading the configuration file, or it will overwrite it. Found thanks to writing qga tests :) Signed-off-by: Marc-André Lureau --- qga/main.c | 4 ++-- 1 file changed,

[Qemu-devel] [PATCH v2 0/4] qga: add local tests on linux

2015-09-11 Thread marcandre . lureau
From: Marc-André Lureau v1->v2: - do not loop forever when connection to qga (Michael Roth) - add some config file tests - fix config verbosity - swallow virt-what stderr - only compile and check on Linux Marc-André Lureau (4): qga: add QGA_CONF environment

Re: [Qemu-devel] [PATCH 19/23] userfaultfd: activate syscall

2015-09-11 Thread Dr. David Alan Gilbert
* Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > (cc trimmed since this looks like an issue that is contained within QEMU) > > On Tue, Sep 08, 2015 at 03:13:56PM +0100, Dr. David Alan Gilbert wrote: > > * Bharata B Rao (bhar...@linux.vnet.ibm.com) wrote: > > > On Tue, Sep 08, 2015 at

[Qemu-devel] [PATCH v6 02/26] qapi: New QAPISchema intermediate reperesentation

2015-09-11 Thread Markus Armbruster
The QAPI code generators work with a syntax tree (nested dictionaries) plus a few symbol tables (also dictionaries) on the side. They have clearly outgrown these simple data structures. There's lots of rummaging around in dictionaries, and information is recomputed on the fly. For the work I'm

[Qemu-devel] [PATCH v6 12/26] qapi: Replace dirty is_c_ptr() by method c_null()

2015-09-11 Thread Markus Armbruster
is_c_ptr() looks whether the end of the C text for the type looks like a pointer. Works, but is fragile. We now have a better tool: use QAPISchemaType method c_null(). The initializers for non-pointers become prettier: 0, false or the enumeration constant with the value 0 instead of {0}.

[Qemu-devel] [PATCH v6 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-09-11 Thread Markus Armbruster
The old code prints the result of parsing (list of expression dictionaries), and partial results of semantic analysis (list of enum dictionaries, list of struct dictionaries). The new code prints a trace of a schema visit, i.e. what the back-ends are going to use. Built-in and array types are

[Qemu-devel] [PATCH v6 24/26] qapi: Pseudo-type '**' is now unused, drop it

2015-09-11 Thread Markus Armbruster
'gen': false needs to stay for now, because netdev_add is still using it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt| 18 ++ scripts/qapi.py | 20

[Qemu-devel] [PATCH v6 14/26] qapi-visit: Rearrange code a bit

2015-09-11 Thread Markus Armbruster
Move gen_visit_decl() to a better place. Inline generate_visit_struct_body(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-visit.py | 50 -- 1 file changed, 20 insertions(+), 30

[Qemu-devel] [PATCH v6 26/26] qapi-introspect: Hide type names

2015-09-11 Thread Markus Armbruster
To eliminate the temptation for clients to look up types by name (which are not ABI), replace all type names by meaningless strings. Reduces output of query-schema by 13 out of 85KiB. As a debugging aid, provide option -u to suppress the hiding. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH v6 25/26] qapi: New QMP command query-qmp-schema for QMP introspection

2015-09-11 Thread Markus Armbruster
qapi/introspect.json defines the introspection schema. It's designed for QMP introspection, but should do for similar uses, such as QGA. The introspection schema does not reflect all the rules and restrictions that apply to QAPI schemata. A valid QAPI schema has an introspection value

[Qemu-devel] [PATCH v6 11/26] qapi-event: Convert to QAPISchemaVisitor, fixing data with base

2015-09-11 Thread Markus Armbruster
Fixes events whose data is struct with base to include the struct's base members. Test case is qapi-schema-test.json's event __org.qemu_x-command: { 'event': '__ORG.QEMU_X-EVENT', 'data': '__org.qemu_x-Struct' } { 'struct': '__org.qemu_x-Struct', 'base': '__org.qemu_x-Base',

[Qemu-devel] [PULL 21/23] iotests: Add test for checking large image files

2015-09-11 Thread Kevin Wolf
From: Max Reitz Add a test for checking a qcow2 file with a multiple of 2^32 clusters. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/qemu-iotests/138 | 73

[Qemu-devel] [PULL 18/23] qemu-iotests: Reopen qcow2 with lazy-refcounts change

2015-09-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/039 | 27 +++ tests/qemu-iotests/039.out | 18 ++ 2 files changed, 45 insertions(+) diff --git a/tests/qemu-iotests/039

Re: [Qemu-devel] [PATCH qemu v2 2/2] spapr_pci: Remove constraints about VFIO-PCI devices

2015-09-11 Thread Alex Williamson
On Wed, 2015-09-09 at 20:43 -0600, Alex Williamson wrote: > On Thu, 2015-09-03 at 14:40 +1000, Alexey Kardashevskiy wrote: > > So far there were 2 limitations enforced on an emulated PHB > > regarding VFIO: > > 1) only one IOMMU group per IOMMU container was allowed and > > the

[Qemu-devel] [PATCH v6 09/26] qapi: De-duplicate enum code generation

2015-09-11 Thread Markus Armbruster
Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but that's no excuse. Move the helpers from qapi-types.py to qapi.py, and replace the duplicates in qapi-event.py. The generated event enumeration type's lookup table becomes const-correct (see commit 2e4450f), and uses explicit

[Qemu-devel] [PATCH v6 04/26] qapi: New QAPISchemaVisitor

2015-09-11 Thread Markus Armbruster
The visitor will help keeping the code generation code simple and reasonably separated from QAPISchema details. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrange --- scripts/qapi.py | 63

[Qemu-devel] [PATCH v6 16/26] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO()

2015-09-11 Thread Markus Armbruster
These functions marshal both input and output. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt| 4 +- docs/writing-qmp-commands.txt | 8 +- monitor.c | 2 +- qmp-commands.hx

[Qemu-devel] [PATCH v6 15/26] qapi-commands: Rearrange code

2015-09-11 Thread Markus Armbruster
Rename gen_marshal_input() to gen_marshal(), because the generated function marshals both arguments and results. Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and move the other variable declarations there, too. Rename gen_visitor_input_block() to gen_marshal_input_visit(),

[Qemu-devel] [PATCH v6 08/26] qapi-commands: Convert to QAPISchemaVisitor

2015-09-11 Thread Markus Armbruster
Output unchanged apart from reordering and white-space. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 159 +++ scripts/qapi.py | 2 +- 2 files changed, 91

[Qemu-devel] [PATCH 1/4] target-i386: Expand PPRO_FEATURES on qemu64/qemu32 definitions

2015-09-11 Thread Eduardo Habkost
The qemu64 and qemu32 CPU models won't be Pentium Pro supersets anymore because the DE feature will be removed. Copy PPRO_FEATURES into their definitions so we can change the CPU models later. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 10 -- 1 file

[Qemu-devel] [PATCH v6 19/26] qapi: Improve built-in type documentation

2015-09-11 Thread Markus Armbruster
Clarify how they map to JSON. Add how they map to C. Fix the reference to StringInputVisitor. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 29 ++--- 1 file changed, 18 insertions(+), 11

[Qemu-devel] [PULL 22/23] vmdk: Fix next_cluster_sector for compressed write

2015-09-11 Thread Kevin Wolf
From: Radoslav Gerganov When the VMDK is streamOptimized (or compressed), the next_cluster_sector must not be incremented by a fixed number of sectors. Instead of this, it must be rounded up to the next consecutive sector. Fixing this results in much smaller compressed

[Qemu-devel] [PULL 09/23] qemu-io: Add command 'reopen'

2015-09-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- qemu-io-cmds.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 53477e1..d6572a8 100644 ---

[Qemu-devel] [PULL 20/23] qcow2: Make size_to_clusters() return uint64_t

2015-09-11 Thread Kevin Wolf
From: Max Reitz Sadly, some images may have more clusters than what can be represented using a plain int. We should be prepared for that case (in qcow2_check_refcounts() we actually were trying to catch that case, but since size_to_clusters() truncated the returned value, that

[Qemu-devel] [PATCH] pulseaudio: reduce 24s recording latency

2015-09-11 Thread Volker Rümelin
Current code doesn't provide pulseaudio buffer attributes for recording. Without buffer attributes pulseaudio uses a default buffer of 4MB. 4MB is approximately 24s 16bit stereo audio data at 44.1kHz. This patch fixes bug #1492649 |Signed-off-by: Volker Rümelin | ---

Re: [Qemu-devel] [PATCH] pulseaudio: reduce 24s recording latency

2015-09-11 Thread Marc-André Lureau
Hi On Fri, Sep 11, 2015 at 9:03 PM, Volker Rümelin wrote: > Current code doesn't provide pulseaudio buffer attributes for > recording. Without buffer attributes pulseaudio uses a default > buffer of 4MB. 4MB is approximately 24s 16bit stereo audio > data at 44.1kHz. Why

Re: [Qemu-devel] [PATCH v5 11/14] block/backup: support block job transactions

2015-09-11 Thread Eric Blake
On 09/07/2015 01:34 AM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This

Re: [Qemu-devel] [PATCH v4 16/38] block: Add BlockBackendRootState

2015-09-11 Thread Eric Blake
On 07/20/2015 11:45 AM, Max Reitz wrote: > This structure will store some of the state of the root BDS if the BDS > tree is removed, so that state can be restored once a new BDS tree is > inserted. > > Signed-off-by: Max Reitz > --- > block/block-backend.c | 37

Re: [Qemu-devel] [PATCH] Add a few argument filters to the seccomp sandbox

2015-09-11 Thread Namsun Ch'o
> On Thursday, September 10, 2015 03:48:52 PM Daniel P. Berrange wrote: > > On Wed, Sep 09, 2015 at 09:55:33PM -0400, namn...@safe-mail.net wrote: > > > + > > > +/* shmget */ > > > +rc = seccomp_rule_add(ctx, SCMP_ACT_ALLOW, SCMP_SYS(shmget), 2, > > > +SCMP_A0(SCMP_CMP_EQ,

Re: [Qemu-devel] [PATCH] Add a few argument filters to the seccomp sandbox

2015-09-11 Thread Paul Moore
On Thursday, September 10, 2015 03:48:52 PM Daniel P. Berrange wrote: > On Wed, Sep 09, 2015 at 09:55:33PM -0400, namn...@safe-mail.net wrote: > > + > > +/* shmget */ > > +rc = seccomp_rule_add(ctx, SCMP_ACT_ALLOW, SCMP_SYS(shmget), 2, > > +SCMP_A0(SCMP_CMP_EQ, IPC_PRIVATE), > > +

[Qemu-devel] I want to recover my QEMU password.

2015-09-11 Thread SkyKiDS
Hi, there! Long long time ago, in 2010, I am a member of QEMU wiki, just had an account, and contributed some news or corrected mis-spells. But now, I forgot my password of the site, so hope to recover my password. Anyone can help me? My account is SkyKiDS . my registered email maybe

[Qemu-devel] [PATCH V1] sdhci: Fix hostctl2 write logic.

2015-09-11 Thread Sai Pavan Boddu
From: Peter Crosthwaite This should be a shifted MASKED_WRITE like all other instances of non-word aligned registers. Signed-off-by: Peter Crosthwaite --- hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 13/34] linux-user: Fix signal before blocking system calls race and SA_RESTART

2015-09-11 Thread Peter Maydell
On 6 September 2015 at 00:57, Timothy E Baldwin wrote: > If a signal is delivered immediately before a blocking system calls the > handler will only be called after the system call returns, which may be a > long time later or never. > > This is fixed by using a

[Qemu-devel] [PULL 01/26] Update language files for QEMU 2.4.0

2015-09-11 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- po/de_DE.po| 36 ++-- po/fr_FR.po| 36 ++-- po/hu.po | 50

[Qemu-devel] [PULL 00/26] Trivial patches for 2015-09-11

2015-09-11 Thread Michael Tokarev
Here's a next trivial-patches pull request after more than one month delay. Hopefully this one is okay... The following changes since commit 7b9c09f7d486647784c605739d69b708a7249c9b: Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-09-10-tag' into staging (2015-09-10 18:25:52

[Qemu-devel] [PULL 05/26] maint: remove / fix many doubled words

2015-09-11 Thread Michael Tokarev
From: "Daniel P. Berrange" Many source files have doubled words (eg "the the", "to to", and so on). Most of these can simply be removed, but a couple were actual mis-spellings (eg "to to" instead of "to do"). There was even one triple word score "to to to" :-)

Re: [Qemu-devel] [PATCH] checkpatch: Escape left braces in regex

2015-09-11 Thread Peter Maydell
On 11 September 2015 at 12:07, Fam Zheng wrote: > Latest perl now deprecates "{" literal in regex and print warnings like > "unescaped left brace in regex is deprecated". Add escape to keep it > happy. > > Signed-off-by: Fam Zheng Looks like

Re: [Qemu-devel] [Qemu-block] [PATCH v2 11/11] block: Only poll block layer fds in bdrv_aio_poll

2015-09-11 Thread Fam Zheng
On Fri, 09/11 13:02, Paolo Bonzini wrote: > > > On 11/09/2015 13:01, Fam Zheng wrote: > > On Fri, 09/11 12:46, Paolo Bonzini wrote: > >> > >> > >> On 11/09/2015 12:40, Fam Zheng wrote: > >>> On Fri, 09/11 11:54, Paolo Bonzini wrote: > > > On 11/09/2015 11:44, Fam Zheng wrote: >

[Qemu-devel] [PULL 07/26] maint: remove unused include for dirent.h

2015-09-11 Thread Michael Tokarev
From: "Daniel P. Berrange" A number of files were including dirent.h but not using any of the functions it provides Signed-off-by: Daniel P. Berrange Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev

[Qemu-devel] [PULL 23/26] hw/virtio/virtio-pci: Remove meaningless blank Property

2015-09-11 Thread Michael Tokarev
From: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Signed-off-by: Michael Tokarev --- hw/virtio/virtio-pci.c | 5 - 1 file changed, 5 deletions(-) diff --git

[Qemu-devel] [PULL 18/26] help: dd missing newline

2015-09-11 Thread Michael Tokarev
From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx

[Qemu-devel] [PULL 16/26] baum: Fix build with debugging enabled

2015-09-11 Thread Michael Tokarev
From: Samuel Thibault cur and buf are pointers, so the difference is a ptrdiff_t Signed-off-by: Samuel Thibault Reviewed-by: Stefan Weil Signed-off-by: Michael Tokarev --- backends/baum.c | 2 +- 1

Re: [Qemu-devel] [PATCH RFC v5 30/32] qapi: New QMP command query-qmp-schema for QMP introspection

2015-09-11 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Sep 11, 2015 at 09:02:15AM +0200, Markus Armbruster wrote: >> Michael Roth writes: >> >> > Quoting Markus Armbruster (2015-09-07 05:16:41) >> >> A new test-qmp-input-visitor test case feeds its result for

Re: [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()

2015-09-11 Thread Andreas Färber
Am 11.09.2015 um 10:21 schrieb Michael Tokarev: > 12.05.2015 05:25, shannon.z...@linaro.org wrote: >> From: Shannon Zhao > [] >> -DEFINE_PROP_END_OF_LIST() >> +DEFINE_PROP_END_OF_LIST(), > [] > > I don't see a reason doing this. Yeah, "end of list" means nothing

[Qemu-devel] [PATCH RFC 0/1] virtio_ccw: new status accessor in driver

2015-09-11 Thread Cornelia Huck
This patch (on top of "virtio/s390: handle failures of READ_VQ_CONF ccw") implements the guest side of the new status ccw. Pierre Morel (1): virtio/s390: support READ_STATUS command for virtio-ccw drivers/s390/virtio/virtio_ccw.c | 25 + 1 file changed, 25

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-09-11 Thread Andreas Färber
Michael, Am 11.09.2015 um 10:00 schrieb Michael Tokarev: > Applied (finally!) to -trivial, without already fixed -net and -scsi bits. > Thanks! Can you please tweak the subjects? I found "blank Property" a very troubling thing to read. In fact it's an empty Property[] array. Thanks, Andreas --

[Qemu-devel] [PATCH RFC 1/1] virtio/s390: support READ_STATUS command for virtio-ccw

2015-09-11 Thread Cornelia Huck
From: Pierre Morel As virtio-1 introduced the possibility of the device manipulating the status byte, revision 2 of the virtio-ccw transport introduced a means of getting the status byte from the device via READ_STATUS. Let's wire it up for revisions >= 2 and fall back

[Qemu-devel] [PATCH RFC 0/2] virtio-ccw: new status accessor in device

2015-09-11 Thread Cornelia Huck
These patches implement the new read status command in qemu and bump the revision to 2 (as this ccw is currently the only thing new with that revision). Patches are on top of v2 of "virtio-1/virtio-ccw related patches". Pierre Morel (2): s390x/virtio-ccw: respond to READ_STATUS command

<    1   2   3   4   >