Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present

2015-09-30 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 29/09/2015 10:39, Kevin Wolf wrote: > bdrv_has_zero_init() takes care of that, in theory. The "problem" > here is that the target is opened with BDRV_O_NO_BACKING, so the > block layer doesn't consider this an image with a backing file. I

[Qemu-devel] [PATCH v3 1/2] memhp: extend address auto assignment to support gaps

2015-09-30 Thread Igor Mammedov
setting gap to TRUE will make sparse DIMM address auto allocation, leaving gaps between a new DIMM address and preceeding existing DIMM. Signed-off-by: Igor Mammedov --- v2: * make 'gap' boolean and just add 1 byte gap when calculating new_addr for DIMM. ---

[Qemu-devel] [PATCH v3 2/2] pc: memhp: force gaps between DIMM's GPA

2015-09-30 Thread Igor Mammedov
mapping DIMMs non contiguously allows to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html in this case guest kernel doesn't allocate buffers that can cross DIMM boundary keeping each buffer local to a DIMM. Suggested-by: Michael S.

[Qemu-devel] [PATCH v3 0/2] pc: memhp: enforce gaps between DIMMs

2015-09-30 Thread Igor Mammedov
v3: - use pc_machine_class_init() for default. (Eduardo) - make 'gap' boolean and just add 1 byte gap when calculating new_addr for DIMM. v2: make inter_dimm_gap a boolean and inster gap in 1 byte instead of 2Mb, due to alignment that gap would be extended up to natural backend

Re: [Qemu-devel] [PATCH v6 12/16] qapi: Consistent generated code: prefer common labels

2015-09-30 Thread Eric Blake
On 09/29/2015 07:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We had some pointless differences in the generated code for visit, >> command marshalling, and events; unifying them makes it easier for >> future patches to consolidate to common helper functions. >>

Re: [Qemu-devel] [PATCH v5 11/21] vhost: only use shared log if in use by backend

2015-09-30 Thread Michael S. Tsirkin
On Thu, Sep 24, 2015 at 06:22:11PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not allocate a shared log if the backend doesn't support it. > > Signed-off-by: Marc-André Lureau So squash this in the

Re: [Qemu-devel] [PATCH v5 00/21] vhost-user: add migration support

2015-09-30 Thread Michael S. Tsirkin
On Thu, Sep 24, 2015 at 06:22:00PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The following series implement shareable log for vhost-user to support > memory tracking during live migration. On qemu-side, the solution is > fairly

Re: [Qemu-devel] [PATCH v4 40/47] tests: add ivshmem qtest

2015-09-30 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Adds 4 ivshmemtests: > - single qemu instance and basic IO > - pair of instances, check memory sharing > - pair of instances with server, and MSIX > - hot plug/unplug > > A

Re: [Qemu-devel] [PATCH v3 03/16] util: add memfd helpers

2015-09-30 Thread Michael S. Tsirkin
On Thu, Aug 06, 2015 at 02:40:39PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add qemu_memfd_alloc/free() helpers. > > The function helps to allocate and seal a memfd, and implements an > open/unlink/mmap fallback for system that do not

Re: [Qemu-devel] [PATCH v6 14/16] qapi: Consistent generated code: minimize push_indent() usage

2015-09-30 Thread Eric Blake
On 09/29/2015 08:10 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We had some pointless differences in the generated code for visit, >> command marshalling, and events; unifying them makes it easier for >> future patches to consolidate to common helper functions. >>

Re: [Qemu-devel] [PATCH v4 40/47] tests: add ivshmem qtest

2015-09-30 Thread Marc-André Lureau
- Original Message - > On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Adds 4 ivshmemtests: > > - single qemu instance and basic IO > > - pair of instances, check memory sharing > > - pair of instances with

Re: [Qemu-devel] [PATCH v3 03/16] util: add memfd helpers

2015-09-30 Thread Marc-André Lureau
- Original Message - > On Thu, Aug 06, 2015 at 02:40:39PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Add qemu_memfd_alloc/free() helpers. > > > > The function helps to allocate and seal a memfd, and implements an > >

Re: [Qemu-devel] [PATCH v3] Add argument filters to the seccomp sandbox

2015-09-30 Thread Eduardo Otubo
On Fri, Sep 25, 2015 at 12=50=36AM -0400, Namsun Ch'o wrote: > Here's the v3 patch. I applied it and compiled QEMU, and it worked fine. > > Changes so far: > v1 > - Created argument filters for the madvise, shmget, and shmctl syscalls. > v1 -> v2 > - Added 5 new madvise flags which were present

Re: [Qemu-devel] [PATCH v4 5/7] qmp: Fix device-list-properties not to crash for abstract device

2015-09-30 Thread Andreas Färber
Am 29.09.2015 um 08:50 schrieb Thomas Huth: > On 28/09/15 22:08, Markus Armbruster wrote: >> Broken in commit f4eb32b "qmp: show QOM properties in >> device-list-properties", v2.1. >> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v6 04/24] util: add linux-only memfd fallback

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Implement memfd_create() fallback if not available in system libc. memfd_create() is still not included in glibc today, atlhough it's been available since Linux 3.17 in Oct 2014. memfd has numerous advantages over traditional shm/mmap for ipc

Re: [Qemu-devel] [PATCH 1/1] migration: fix deadlock

2015-09-30 Thread Igor Redko
On 25.09.2015 11:23, Wen Congyang wrote: On 09/25/2015 04:03 PM, Denis V. Lunev wrote: On 09/25/2015 04:21 AM, Wen Congyang wrote: On 09/24/2015 08:53 PM, Denis V. Lunev wrote: From: Igor Redko Release qemu global mutex before call synchronize_rcu(). synchronize_rcu()

Re: [Qemu-devel] [PATCH v4 6/7] qdev: Protect device-list-properties against broken devices

2015-09-30 Thread Andreas Färber
Am 28.09.2015 um 22:08 schrieb Markus Armbruster: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs to create a

[Qemu-devel] [PATCH v6 08/24] vhost: add vhost_set_log_base op

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Split VHOST_SET_LOG_BASE call in a seperate function callback, so that type safety works and more arguments can be added in the next patches. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-backend.c

[Qemu-devel] [PATCH v6 06/24] memfd: add fallback for memfd

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Add an open/unlink/mmap fallback for system that do not support memfd. This patch may require additional SELinux policies to work for enforced systems, but should gracefully fail nonetheless. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v6 03/24] linux-headers: add unistd.h

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau New syscalls are not yet widely distributed. Add them to qemu linux-headers include directory. Update based on v4.3-rc3 kernel headers. Exclude mips for now, which is more problematic due to extra header inclusion and probably unnecessary

[Qemu-devel] [PATCH v6 07/24] vhost: document log resizing

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- hw/virtio/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index c0ed5b2..67e09fe 100644 --- a/hw/virtio/vhost.c +++

[Qemu-devel] [PATCH v6 23/24] vhost-user-test: check ownership during migration

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Check that backend source and destination do not have simultaneous ownership during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 38 ++ 1 file

[Qemu-devel] [PATCH v6 18/24] vhost-user-test: move wait_for_fds() out

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau This function is a precondition for most vhost-user tests. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH v6 20/24] vhost-user-test: wrap server in TestServer struct

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau In the coming patches, a test will use several servers simultaneously. Wrap the server in a struct, out of the global scope. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 146

Re: [Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

2015-09-30 Thread Sergey Fedorov
On 29.09.2015 12:33, Peter Maydell wrote: > On 28 September 2015 at 11:37, Sergey Fedorov wrote: >> Signed-off-by: Sergey Fedorov >> --- >> >> This patch is a prerequisite for a debug exception routing patch: >>

Re: [Qemu-devel] [PATCH v4 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-30 Thread Gabriel L. Somlo
On Tue, Sep 29, 2015 at 03:59:28PM +0200, Laszlo Ersek wrote: > On 09/29/15 12:27, Michael S. Tsirkin wrote: > > On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote: > >> New since v3: > >> > >>- rebased to work on top of 87e896ab (introducing pc-*-25 classes), > >> inserting

Re: [Qemu-devel] [PATCH v4 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-30 Thread Gabriel L. Somlo
On Tue, Sep 29, 2015 at 01:27:38PM +0300, Michael S. Tsirkin wrote: > On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote: > > New since v3: > > > > - rebased to work on top of 87e896ab (introducing pc-*-25 classes), > > inserting fw_cfg acpi node only for machines >= 2.5.

[Qemu-devel] [PATCH v7 02/18] qapi: Improve 'include' error message

2015-09-30 Thread Eric Blake
Use of '"...%s" % include' to print non-strings can lead to ugly messages, such as this (if the .json change is applied without the qapi.py change): Expected a file name (string), got: OrderedDict() Better is to just omit the actual non-string value in the message. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v7 09/18] qapi: Reuse code for flat union base validation

2015-09-30 Thread Eric Blake
Rather than open-code the check for a valid base type, we should reuse the common functionality. This allows for consistent error messages, and also makes it easier for a later patch to turn on support for inline anonymous base structures. Test flat-union-inline is updated to test only one

Re: [Qemu-devel] [PATCH] ui/cocoa.m: run custom script menu item

2015-09-30 Thread Programmingkid
On Sep 29, 2015, at 2:00 PM, Peter Maydell wrote: > On 29 September 2015 at 18:53, Programmingkid > wrote: >> >> On Sep 29, 2015, at 1:18 PM, Peter Maydell wrote: >> >>> On 29 September 2015 at 18:03, Programmingkid >>> wrote:

[Qemu-devel] [PATCH v7 06/18] qapi: Avoid assertion failure on union 'type' collision

2015-09-30 Thread Eric Blake
The previous commit added two tests that triggered an assertion failure. It's fairly straightforward to avoid the failure by just outright forbidding the collision between a union's tag values and its discriminator name (including the implicit name 'kind' supplied for simple unions [*]).

[Qemu-devel] [PATCH v1 2/3] xilinx_spips: Seperate the state struct into a header

2015-09-30 Thread Alistair Francis
Seperate out the XilinxSPIPS struct into a seperate header file. Signed-off-by: Alistair Francis --- hw/ssi/xilinx_spips.c | 104 +--- include/hw/ssi/xilinx_spips.h | 134 ++ 2 files

Re: [Qemu-devel] [PATCH v8 23/54] Add migration-capability boolean for postcopy-ram.

2015-09-30 Thread Eric Blake
On 09/29/2015 02:37 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The 'postcopy ram' capability allows postcopy migration of RAM; > note that the migration starts off in precopy mode until > postcopy mode is triggered (see the

Re: [Qemu-devel] [PATCH v4 41/47] ivshmem: do not keep shm_fd open

2015-09-30 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Remove shm_fd from device state, closing it as early as possible to avoid > leaks. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c |

Re: [Qemu-devel] [PATCH v4 45/47] ivshmem: rename MSI eventfd_table

2015-09-30 Thread Claudio Fontana
On 24.09.2015 13:37, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The array is used to have vector specific data, so use a more > descriptive name. > > Signed-off-by: Marc-André Lureau > --- > hw/misc/ivshmem.c | 18

Re: [Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain()

2015-09-30 Thread Kevin Wolf
Am 23.09.2015 um 19:08 hat Max Reitz geschrieben: > On 17.09.2015 15:48, Kevin Wolf wrote: > > This cleans up the mess we left behind in the mirror code after the > > previous patch. Instead of using bdrv_swap(), just change pointers. > > > > The interface change of the mirror job that callers

Re: [Qemu-devel] [PATCH v4 0/7] Fix device introspection regressions

2015-09-30 Thread Markus Armbruster
Markus Armbruster writes: > QMP command device-list-properties regressed in 2.1: it can crash or > leave dangling pointers behind. > > -device FOO,help regressed in 2.2: it no longer works for > non-pluggable devices. I tried to fix that some time ago[*], but my > fix failed

Re: [Qemu-devel] [PATCH v4 1/7] tests: Fix how qom-test is run

2015-09-30 Thread Andreas Färber
Am 28.09.2015 um 22:08 schrieb Markus Armbruster: > We want to run qom-test for every architecture, without having to > manually add it to every architecture's list of tests. Commit 3687d53 > accomplished this by adding it to every architecture's list > automatically. > > However, some

[Qemu-devel] [PATCH v6 13/24] vhost: use a function for each call

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Replace the generic vhost_call() by specific functions for each function call to help with type safety and changing arguments. While doing this, I found that "unsigned long long" and "uint64_t" were used interchangeably and causing

Re: [Qemu-devel] [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

2015-09-30 Thread Eduardo Habkost
On Tue, Sep 29, 2015 at 11:43:34AM +0800, Haozhong Zhang wrote: > On Mon, Sep 28, 2015 at 01:37:34PM -0300, Eduardo Habkost wrote: > > On Mon, Sep 28, 2015 at 01:38:31PM +0800, Haozhong Zhang wrote: [...] > > > static void do_kvm_cpu_synchronize_post_init(void *arg) > > > { > > > CPUState

[Qemu-devel] [PATCH v6 11/24] vhost-user: send log shm fd along with log_base

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Send the shm for the dirty pages logging if the backend supports VHOST_USER_PROTOCOL_F_LOG_SHMFD. Wait for a reply to make sure the old log is no longer used. Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

2015-09-30 Thread Peter Maydell
On 29 September 2015 at 18:14, Sergey Fedorov wrote: > On 29.09.2015 12:33, Peter Maydell wrote: >> On 28 September 2015 at 11:37, Sergey Fedorov wrote: >> This field should be named mdcr_el2 if we have it, but: >> the reset value for this register is

[Qemu-devel] [PATCH] ui/cocoa.m: run custom script menu item

2015-09-30 Thread Programmingkid
Allow the user the ability to run a custom script file. This patch adds a menu item called "Run Custom Script". When the user selects it, a open-file dialog has the user select a text file with the custom scripts to run. This allows for virtually unlimited expandability. All monitor commands

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-30 Thread Gabriel L. Somlo
On Tue, Sep 29, 2015 at 12:33:40PM +0200, Laszlo Ersek wrote: > On 09/27/15 23:29, Gabriel L. Somlo wrote: > > Add a fw_cfg device node to the ACPI SSDT, on machine types > > pc-*-2.5 and up. While the guest-side BIOS can't utilize > > this information (since it has to access the hard-coded > >

Re: [Qemu-devel] [PATCH] ui/cocoa.m: run custom script menu item

2015-09-30 Thread Peter Maydell
On 29 September 2015 at 18:03, Programmingkid wrote: > Allow the user the ability to run a custom script file. > This patch adds a menu item called "Run Custom Script". > When the user selects it, a open-file dialog has the > user select a text file with the custom

[Qemu-devel] [PATCH v7 04/18] qapi: Clean up qapi.py per pep8

2015-09-30 Thread Eric Blake
Silence pep8, and make pylint a bit happier. Just style cleanups, plus killing a useless comment in camel_to_upper(); no semantic changes. Signed-off-by: Eric Blake --- v7: drop useless (), avoid non-mechanical conversion of lookup within two sets v6: split off non-style

Re: [Qemu-devel] [PATCH v4 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-30 Thread Gabriel L. Somlo
On Tue, Sep 29, 2015 at 05:15:25PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 29, 2015 at 03:59:28PM +0200, Laszlo Ersek wrote: > > On 09/29/15 12:27, Michael S. Tsirkin wrote: > > > On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote: > > >> New since v3: > > >> > > >> - rebased

[Qemu-devel] [PATCH 2/2] target-i386: Don't left shift negative constant

2015-09-30 Thread Eduardo Habkost
Left shift of negative values is undefined behavior. Detected by clang: qemu/target-i386/translate.c:2423:26: runtime error: left shift of negative value -8 This changes the code to reverse the sign after the left shift. Signed-off-by: Eduardo Habkost ---

Re: [Qemu-devel] [PATCH v4 0/5] add ACPI node for fw_cfg on pc and arm

2015-09-30 Thread Laszlo Ersek
On 09/29/15 21:04, Gabriel L. Somlo wrote: > On Tue, Sep 29, 2015 at 05:15:25PM +0300, Michael S. Tsirkin wrote: >> On Tue, Sep 29, 2015 at 03:59:28PM +0200, Laszlo Ersek wrote: >>> On 09/29/15 12:27, Michael S. Tsirkin wrote: On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote:

[Qemu-devel] [RFC PATCH v7 17/18] qapi: Simplify gen_visit_fields() error handling

2015-09-30 Thread Eric Blake
Since we have consolidated all generated code to use 'err' as the name of the local variable for error detection, we can simplify the decision on whether to skip error detection (useful for deallocation paths) to be a boolean. This requires the python 2.5 ternary syntax. Signed-off-by: Eric

[Qemu-devel] [PATCH v7 15/18] qapi: Share gen_err_check()

2015-09-30 Thread Eric Blake
qapi-commands has a nice helper gen_err_check(), but did not use it everywhere. In fact, using it in more places makes it easier to reduce the lines of code used for generating error checks. This in turn will make it easier for later patches to consolidate another common pattern among the

[Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest

2015-09-30 Thread Christopher Covington
Signed-off-by: Christopher Covington --- arm/selftest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arm/selftest.c b/arm/selftest.c index fc9ec60..aa16a91 100644 --- a/arm/selftest.c +++ b/arm/selftest.c @@ -376,6 +376,8 @@ int main(int argc, char **argv)

[Qemu-devel] [PATCH v6 02/24] configure: probe for memfd

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Check if memfd_create() is part of system libc. Signed-off-by: Marc-André Lureau --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure b/configure index

[Qemu-devel] [PATCH v6 14/24] vhost-user: document migration log

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/specs/vhost-user.txt | 48 +-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/docs/specs/vhost-user.txt

[Qemu-devel] [Bug 1500935] [NEW] Qemu / KVM always wants to be on top

2015-09-30 Thread AlainKnaff
Public bug reported: Whenever I pass with the mouse over the KVM (qemu) window, it automatically raises on top, obscuring other windows on the same desktop, which is rather intrusive... No other application does this. > dpkg -l qemu-kvm Desired=Unknown/Install/Remove/Purge/Hold |

[Qemu-devel] [PATCH v6 01/24] vhost-user: unit test for new messages

2015-09-30 Thread marcandre . lureau
From: "Michael S. Tsirkin" Data is empty for now, but do make sure master sets the new feature bit flag. Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[Qemu-devel] [PATCH v6 19/24] vhost-user-test: remove useless static check

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 88714ff..6662ca9 100644 ---

Re: [Qemu-devel] [PATCH] ui/cocoa.m: run custom script menu item

2015-09-30 Thread Programmingkid
On Sep 29, 2015, at 1:18 PM, Peter Maydell wrote: > On 29 September 2015 at 18:03, Programmingkid > wrote: >> Allow the user the ability to run a custom script file. >> This patch adds a menu item called "Run Custom Script". >> When the user selects it, a open-file

[Qemu-devel] [PATCH v6 10/24] vhost: alloc shareable log

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau If the backend is requires it, allocate shareable memory. vhost_log_get() now uses 2 globals "vhost_log" and "vhost_log_shm", that way there is a common non-shareable log and a common shareable one. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v6 05/24] util: add memfd helpers

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Add qemu_memfd_alloc/free() helpers. The function helps to allocate and seal a memfd. Signed-off-by: Marc-André Lureau --- include/qemu/memfd.h | 4 util/memfd.c | 59

Re: [Qemu-devel] [PULL 0/7] X86 queue, 2015-09-28

2015-09-30 Thread Peter Maydell
On 29 September 2015 at 19:22, Eduardo Habkost wrote: > On Tue, Sep 29, 2015 at 12:28:15PM +0100, Peter Maydell wrote: >> I get a bunch of new warnings in the course of 'make check' now: >> >> warning: TCG doesn't support requested feature: CPUID.01H:EDX.de [bit 2] >> >>

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-30 Thread Laszlo Ersek
On 09/29/15 18:46, Gabriel L. Somlo wrote: > On Tue, Sep 29, 2015 at 12:33:40PM +0200, Laszlo Ersek wrote: >> On 09/27/15 23:29, Gabriel L. Somlo wrote: >>> Add a fw_cfg device node to the ACPI SSDT, on machine types >>> pc-*-2.5 and up. While the guest-side BIOS can't utilize >>> this information

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-30 Thread Gabriel L. Somlo
On Tue, Sep 29, 2015 at 06:55:01PM +0200, Laszlo Ersek wrote: > On 09/29/15 18:46, Gabriel L. Somlo wrote: > > On Tue, Sep 29, 2015 at 12:33:40PM +0200, Laszlo Ersek wrote: > >> On 09/27/15 23:29, Gabriel L. Somlo wrote: > >>> Add a fw_cfg device node to the ACPI SSDT, on machine types > >>>

[Qemu-devel] [RFC PATCH v7 18/18] qapi: Use gen_err_check() in more places

2015-09-30 Thread Eric Blake
Controversial: find all remaining patterns that generate a goto statement due to 'err', and convert them to use gen_err_check(). The bulk of these replacements actually lead to code duplication (extra mcgen() calls with common parameterization), so I will probably drop this patch. Signed-off-by:

[Qemu-devel] [PATCH v7 00/18] post-introspection cleanups, subset A

2015-09-30 Thread Eric Blake
Patch 17 is marked RFC because it has a prerequisite: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01277.html Patch 18 is marked RFC because it is probably worth discarding. Otherwise, this series addresses the review comments on v6. Also available as a tag at this location: git fetch

Re: [Qemu-devel] [PATCH 3/3] target-xtensa: xtfpga: support noMMU cores

2015-09-30 Thread Peter Crosthwaite
On Tue, Sep 29, 2015 at 3:34 AM, Max Filippov wrote: > On Mon, Sep 28, 2015 at 12:59 AM, Peter Crosthwaite > wrote: >> On Sun, Sep 27, 2015 at 2:48 PM, Max Filippov wrote: >>> On Mon, Sep 28, 2015 at 12:28 AM, Peter Crosthwaite

Re: [Qemu-devel] [PULL 0/7] X86 queue, 2015-09-28

2015-09-30 Thread Eduardo Habkost
On Tue, Sep 29, 2015 at 12:28:15PM +0100, Peter Maydell wrote: > On 28 September 2015 at 18:31, Eduardo Habkost wrote: > > The following changes since commit 9e071429e649346c14b2dc76902f84f8352d2333: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream'

[Qemu-devel] [PATCH v7 07/18] qapi: Add tests for empty unions

2015-09-30 Thread Eric Blake
The documentation claims that alternates are useful for allowing two or more types, although nothing enforces this. Meanwhile, it is silent on whether empty unions are allowed. In practice, the generated code will compile, in part because we have a 'void *data' branch; but attempting to visit such

Re: [Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest

2015-09-30 Thread Andrew Jones
On Tue, Sep 29, 2015 at 11:08:27AM -0400, Christopher Covington wrote: > Signed-off-by: Christopher Covington > --- > arm/selftest.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arm/selftest.c b/arm/selftest.c > index fc9ec60..aa16a91 100644 > ---

[Qemu-devel] [PATCH v6 17/24] vhost user: add rarp sending after live migration for legacy guest

2015-09-30 Thread marcandre . lureau
From: Thibaut Collet A new vhost user message is added to allow QEMU to ask to vhost user backend to broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE capability. This new message is sent only if the backend supports the new

[Qemu-devel] [PATCH v6 00/24] vhost-user: add migration support

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following series implement shareable log for vhost-user to support memory tracking during live migration. On qemu-side, the solution is fairly straightfoward since vhost already supports the dirty log, only vhost-user couldn't access

[Qemu-devel] [PATCH v6 15/24] net: add trace_vhost_user_event

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Replace error_report() and use tracing instead. It's not an error to get a connection or a disconnection, so silence this and trace it instead. Signed-off-by: Marc-André Lureau --- net/vhost-user.c | 4 ++--

[Qemu-devel] [PATCH] block/raw-posix: Open file descriptor O_RDWR to work around glibc posix_fallocate emulation issue.

2015-09-30 Thread Richard W.M. Jones
https://bugzilla.redhat.com/show_bug.cgi?id=1265196 The following command fails on an NFS mountpoint: $ qemu-img create -f qcow2 -o preallocation=falloc disk.img 262144 Formatting 'disk.img', fmt=qcow2 size=262144 encryption=off cluster_size=65536 preallocation='falloc' lazy_refcounts=off

Re: [Qemu-devel] [PATCH v4 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-30 Thread Laszlo Ersek
On 09/29/15 20:26, Gabriel L. Somlo wrote: > On Tue, Sep 29, 2015 at 12:40:16PM +0200, Laszlo Ersek wrote: >> On 09/27/15 23:29, Gabriel L. Somlo wrote: >>> Add a fw_cfg device node to the ACPI DSDT. This is mostly >>> informational, as the authoritative fw_cfg MMIO region(s) >>> are listed in the

Re: [Qemu-devel] [PATCH v4 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-30 Thread Laszlo Ersek
On 09/29/15 19:19, Gabriel L. Somlo wrote: > On Tue, Sep 29, 2015 at 06:55:01PM +0200, Laszlo Ersek wrote: >> On 09/29/15 18:46, Gabriel L. Somlo wrote: >>> On Tue, Sep 29, 2015 at 12:33:40PM +0200, Laszlo Ersek wrote: On 09/27/15 23:29, Gabriel L. Somlo wrote: > Add a fw_cfg device node

Re: [Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

2015-09-30 Thread Sergey Fedorov
On 29.09.2015 20:19, Peter Maydell wrote: > On 29 September 2015 at 18:14, Sergey Fedorov wrote: >> On 29.09.2015 12:33, Peter Maydell wrote: >>> On 28 September 2015 at 11:37, Sergey Fedorov wrote: >>> This field should be named mdcr_el2 if we have

Re: [Qemu-devel] [PATCH] ui/cocoa.m: run custom script menu item

2015-09-30 Thread Peter Maydell
On 29 September 2015 at 18:53, Programmingkid wrote: > > On Sep 29, 2015, at 1:18 PM, Peter Maydell wrote: > >> On 29 September 2015 at 18:03, Programmingkid >> wrote: >>> Allow the user the ability to run a custom script file. >>> This

Re: [Qemu-devel] [PATCH v5 11/21] vhost: only use shared log if in use by backend

2015-09-30 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Sep 24, 2015 at 06:22:11PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Do not allocate a shared log if the backend doesn't support it. > > > > Signed-off-by: Marc-André Lureau

[Qemu-devel] [PATCH v4] fw_cfg: insert string blobs via qemu cmdline

2015-09-30 Thread Gabriel L. Somlo
Allow users to provide custom fw_cfg blobs with ascii string payloads specified directly on the qemu command line. Suggested-by: Jordan Justen Suggested-by: Laszlo Ersek Signed-off-by: Gabriel Somlo Reviewd-by: Laszlo Ersek

[Qemu-devel] [PATCH v6 21/24] vhost-user-test: learn to tweak various qemu arguments

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Add a new macro to make the qemu command line with other values of memory size, and specific chardev id. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 14 +- 1 file changed, 9

[Qemu-devel] [PATCH v6 12/24] vhost-user: add a migration blocker

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau If VHOST_USER_PROTOCOL_F_LOG_SHMFD is not announced, block vhost-user migration. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] block: disable I/O limits at the beginning of bdrv_close()

2015-09-30 Thread Andrey Korolyov
On Mon, Sep 28, 2015 at 12:04 PM, Alberto Garcia wrote: > On Mon 28 Sep 2015 02:18:33 AM CEST, Fam Zheng wrote: > >>> > Can this be abused? If I have a guest running in a cloud where the >>> > cloud provider has put severe throttling limits on me, but lets me

Re: [Qemu-devel] [PATCH v6 08/16] qapi: Test use of 'number' within alternates

2015-09-30 Thread Eric Blake
On 09/29/2015 07:38 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Add some testsuite exposure for use of a 'number' as part of >> an alternate. The current state of the tree has a few bugs >> exposed by this: our input parser depends on the ordering of >> how the

Re: [Qemu-devel] [PATCH v6 15/16] qapi: Share gen_err_check()

2015-09-30 Thread Eric Blake
On 09/29/2015 08:31 AM, Markus Armbruster wrote: > > To really cut the verbosity, I figure we'd have to do something more > radical, like having cgen() recognize a (short!) pattern and replace it > with a full-blown error check. Not sure that's actually a good idea, > though :) Another radical

[Qemu-devel] [PATCH v7 01/18] qapi: Sort qapi-schema tests

2015-09-30 Thread Eric Blake
Recent changes to qapi have provided quite a bit of churn in the makefile, because we are inconsistent on what order test names appear in, and on whether to re-wrap the list of tests or just add arbitrary line lengths. Writing the list in a sorted fashion, one test per line, will make future

[Qemu-devel] [PATCH v7 13/18] qapi: Consistent generated code: prefer common indentation

2015-09-30 Thread Eric Blake
We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is one patch of a series to clean up these differences. This patch adjusts gen_visit_union() to use

Re: [Qemu-devel] [PATCH v6 15/16] qapi: Share gen_err_check()

2015-09-30 Thread Eric Blake
On 09/29/2015 08:31 AM, Markus Armbruster wrote: > Eric Blake writes: > >> qapi-commands had a nice helper gen_err_check(), but did not > > In fact, it still has :) > >> use it everywhere. In fact, using it in more places makes it >> easier to reduce the lines of code used

Re: [Qemu-devel] [PATCH v2] Add argument filters to the seccomp sandbox

2015-09-30 Thread Eduardo Otubo
(I'm not sure what happens to your emails that all of them does not relate to the same thread/Message-ID, making a pain to follow through out the volume of email on the list, please pay attention to that) On Mon, Sep 28, 2015 at 11=14=42PM -0400, Namsun Ch'o wrote: > > My understanding of the

Re: [Qemu-devel] [PATCH v3 03/16] util: add memfd helpers

2015-09-30 Thread Michael S. Tsirkin
On Tue, Sep 29, 2015 at 11:25:04AM -0400, Marc-André Lureau wrote: > > > - Original Message - > > On Thu, Aug 06, 2015 at 02:40:39PM +0200, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Add qemu_memfd_alloc/free() helpers. > >

[Qemu-devel] [PATCH v6 22/24] vhost-user-test: add live-migration test

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau This test checks that the log fd is given to the migration source, and mark dirty pages during migration. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 171

[Qemu-devel] [PATCH v6 09/24] vhost-user: add vhost_user_requires_shm_log()

2015-09-30 Thread marcandre . lureau
From: Marc-André Lureau Check if the backend has VHOST_USER_PROTOCOL_F_LOG_SHMFD feature and require a shared log. Signed-off-by: Marc-André Lureau --- hw/virtio/vhost-user.c| 14 --

[Qemu-devel] [PATCH v6 16/24] vhost user: add support of live migration

2015-09-30 Thread marcandre . lureau
From: Thibaut Collet Some vhost user backends are able to support live migration. To provide this service the following features must be added: 1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev backend is vhost-user. 2. Provide a nop receive

[Qemu-devel] [PATCH v6 24/24] vhost-user: use an enum helper for features mask

2015-09-30 Thread marcandre . lureau
From: Thibaut Collet The VHOST_USER_PROTOCOL_FEATURE_MASK will be automatically updated when adding new features to the enum. Signed-off-by: Thibaut Collet [Adapted from mailing list discussion - Marc-André] Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 1/3] target-i386: add a subsection of vcpu's TSC rate in vmstate_x86_cpu

2015-09-30 Thread Dr. David Alan Gilbert
* Haozhong Zhang (haozhong.zh...@intel.com) wrote: > The newly added subsection 'vmstate_tsc_khz' in this patch results in > vcpu's TSC rate being saved on the source machine and loaded on the > target machine during the migration. > > Signed-off-by: Haozhong Zhang Hi,

Re: [Qemu-devel] [PATCH] target-tilegx: Support iret instruction and related special registers

2015-09-30 Thread Chen Gang
On 9/29/15 14:34, Richard Henderson wrote: > On 09/28/2015 03:06 PM, gang.chen.5...@gmail.com wrote: >> From: Chen Gang >> >> Acording to the __longjmp tilegx libc implementation, and reference from >> tilegx ISA document, we can left iret instruction empty. The related

Re: [Qemu-devel] [PATCH v4 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-30 Thread Gabriel L. Somlo
On Tue, Sep 29, 2015 at 12:40:16PM +0200, Laszlo Ersek wrote: > On 09/27/15 23:29, Gabriel L. Somlo wrote: > > Add a fw_cfg device node to the ACPI DSDT. This is mostly > > informational, as the authoritative fw_cfg MMIO region(s) > > are listed in the Device Tree. However, since we are building >

Re: [Qemu-devel] [PATCH 3/3] target-xtensa: xtfpga: support noMMU cores

2015-09-30 Thread Peter Maydell
On 29 September 2015 at 11:34, Max Filippov wrote: > On Mon, Sep 28, 2015 at 12:59 AM, Peter Crosthwaite > wrote: >> On Sun, Sep 27, 2015 at 2:48 PM, Max Filippov wrote: >>> On Mon, Sep 28, 2015 at 12:28 AM, Peter Crosthwaite

Re: [Qemu-devel] [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

2015-09-30 Thread Haozhong Zhang
On Tue, Sep 29, 2015 at 03:02:07PM -0300, Eduardo Habkost wrote: > On Tue, Sep 29, 2015 at 11:43:34AM +0800, Haozhong Zhang wrote: > > On Mon, Sep 28, 2015 at 01:37:34PM -0300, Eduardo Habkost wrote: > > > On Mon, Sep 28, 2015 at 01:38:31PM +0800, Haozhong Zhang wrote: > [...] > > > > static void

Re: [Qemu-devel] [PATCH] configure: Require Python 2.6

2015-09-30 Thread Eric Blake
ping On 09/04/2015 04:44 PM, Peter Maydell wrote: > On 4 September 2015 at 20:53, Markus Armbruster wrote: >> RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back >> to 10.6. >> >> Signed-off-by: Markus Armbruster > > Reviewed-by: Peter

[Qemu-devel] [PATCH] target-tilegx: Fix a typo for mnemonic about "ld_add"

2015-09-30 Thread gang . chen . 5i5j
From: Chen Gang Signed-off-by: Chen Gang --- target-tilegx/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index d2b2b6e..251b254 100644 ---

  1   2   3   >