We can now restore state without retranslation.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 1 +
tcg/tcg.c | 40 -
tcg/tcg.h | 4 +-
translate-all.c | 150
On Wed, Sep 16, 2015 at 08:52:23AM +0200, Gerd Hoffmann wrote:
> On Mi, 2015-09-16 at 07:08 +1000, Benjamin Herrenschmidt wrote:
> > On Tue, 2015-09-15 at 11:19 +0200, Gerd Hoffmann wrote:
> > > On Di, 2015-09-15 at 15:51 +1000, Benjamin Herrenschmidt wrote:
> > > > It works fine with the Linux dri
Since jump_pc[1] is always npc + 4, we can infer after incrementing
that jump_pc[1] == pc + 4. Because of that, we can encode the branch
destination into a single word, and store that in npc.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-sp
As it's only caller, this tidies things a bit.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 2 -
translate-all.c | 131 ++--
2 files changed, 59 insertions(+), 74 dele
Unify three copies of this code from different
branch types. Fix the case when npc == DYNAMIC_PC,
i.e. a branch within a delay slot.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 55 --
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-arm/cpu.h | 1 +
target-arm/translate-a64.c | 2 +-
target-arm/translate.c | 3 ++-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
On Fri, Sep 25, 2015 at 10:42:21AM -0400, Christopher Covington wrote:
> This should help clarify the purpose of the function that returns
> the host system's CPU cycle count.
>
> Signed-off-by: Christopher Covington
ppc portion
Acked-by: David Gibson
> ---
> bsd-user/main.c | 2 +
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-sparc/cpu.h | 1 +
target-sparc/translate.c | 7 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h
index 053edd5..c68e480 100644
-
This perhaps isn't ideal in terms of (ab)using the "pc" field
to encode both pc and ppc + delay branch state, as one has to
be aware of this when examining opcode dumps.
But it preserves existing logic, which will be good for bisection,
and it certainly does save storage space.
Reviewed-by: Aurel
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-mips/cpu.h | 1 +
target-mips/translate.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-mips/cpu.h b/target-mips/cpu.h
index ec5f991..532b39e 100644
--- a/tar
This symbol no longer exists.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-alpha/cpu.h | 1 -
target-arm/cpu.h| 1 -
target-cris/cpu.h | 1 -
target-i386/cpu.h | 1 -
target-lm32/cpu.h | 1 -
target-m68k/cpu.h
With an eye toward having this data replace the gen_opc_* arrays
that each target collects in order to enable restore_state_from_tb.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
tcg/tcg-op.h | 52 --
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-sh4/cpu.h | 1 +
target-sh4/translate.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/target-sh4/cpu.h b/target-sh4/cpu.h
index 6fb6321..145e5df 100644
--- a/target-s
We always pass pc2 == dc->npc and r_cond == cpu_cond,
and always set is_br afterward. Infer all of that.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-sparc/translate.c | 21 ++---
1 file changed, 10 insertions(+), 11 deleti
This does tidy the icount test common to all targets.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-alpha/translate.c | 4 ++--
target-arm/translate-a64.c| 6 +++---
target-arm/translate.c| 7 ---
target-cris/translate.c
Reduce the boilerplate required for each target. At the same time,
move the test for breakpoint after calling tcg_gen_insn_start.
Note that arm and aarch64 do not use cpu_breakpoint_test, but still
move the inline test down after tcg_gen_insn_start.
Reviewed-by: Peter Maydell
Signed-off-by: Ric
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-i386/cpu.h | 1 +
target-i386/translate.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 034fab6..c10b673 100644
--- a/targ
Version 4:
* Typos noticed by pmm during round 3.
* RB's collected during round 3.
* Reduce the number of TBs allocated.
I believe the only patch left without an RB is 24; and of
course 26 which is new.
r~
Richard Henderson (26):
tcg: Rename debug_insn_start to insn_start
target-*: U
While we're at it, emit the opcode adjacent to where we currently
record data for search_pc. This puts gen_io_start et al on the
"correct" side of the marker.
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-alpha/translate.c | 6 ++
Reviewed-by: Aurelien Jarno
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target-s390x/cpu.h | 1 +
target-s390x/translate.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index 5acd54c..b927c66 100644
--- a/
On 29/09/2015 15:23, Dr. David Alan Gilbert wrote:
> Yeh, I'm not sure how easily that'll be to glue into the monitor,
> because the monitor has a parser that's fed somehow from the chardev.
See how qmp_human_monitor_command is implemented. It basically bypasses
the chardev part of the monitor.
Am 30.09.2015 um 04:40 schrieb Richard Henderson:
On 09/27/2015 05:02 PM, Dennis Luehring wrote:
> git master clone from 09/27/2015, 8:07
> git rev-parse HEAD
> 9e071429e649346c14b2dc76902f84f8352d2333
>
> if i try to start qemu-system-alpha with option -nographic while installing
> debian lenny
The current vfio core code assumes that the host IOMMU is capable of
mapping any IOVA the guest wants to use to where we need. However, real
IOMMUs generally only support translating a certain range of IOVAs (the
"DMA window") not a full 64-bit address space.
The common x86 IOMMUs support a wide
Because of the way non-VFIO guest IOMMU operations are KVM accelerated, not
all TCE tables (guest IOMMU contexts) can support VFIO devices. Currently,
this is decided at creation time.
To support hotplug of VFIO devices, we need to allow a TCE table which
previously didn't allow VFIO devices to b
Previously, qapi-types and qapi-visit filtered an object visit
to bypass implicit types by inspecting whether 'info' was passed
in (since implicit objects do not [yet] have associated info);
meanwhile qapi-introspect filtered by returning a python type
from visit_begin() in order to exclude all typ
On 09/24/2015 06:32 PM, Alvise Rigo wrote:
+if (unlikely(!(te->addr_write & TLB_MMIO) && (te->addr_write & TLB_EXCL)))
{
+/* We are removing an exclusive entry, set the page to dirty. This
+ * is not be necessary if the vCPU has performed both SC and LL. */
+hwaddr hw
On 09/24/2015 06:32 PM, Alvise Rigo wrote:
The new helpers rely on the legacy ones to perform the actual read/write.
The LoadLink helper (helper_ldlink_name) prepares the way for the
following SC operation. It sets the linked address and the size of the
access.
These helper also update the TLB e
At present, VFIO PCI devices attached to an spapr-pci-host-bridge
device (the regular PCI host bridge for the pseries machine type)
won't quite work properly.
I've recently posted some extensions to VFIO that are almost enough to
allow these to work - this series contains the final necessary chang
The Enhanced Error Handling (EEH) interface in PAPR operates on units of a
Partitionable Endpoint (PE). For VFIO devices, the PE boundaries the guest
sees must match the PE (i.e. IOMMU group) boundaries on the host. To
implement this it will need to discover from VFIO which group a given
device b
Currently the VFIOContainer iommu_data field contains a union with
different information for different host iommu types. However:
* It only actually contains information for the x86-like "Type1" iommu
* Because we have a common listener the Type1 fields are actually used
on all IOMMU types,
Connect the SPI devices to Xilinx's ZynqMP.
I also need to make some changes to the actual SPI device to
imporove the fuctionality, but for the time being this works.
Alistair Francis (3):
ssi: Move ssi.h into a seperate directory
xilinx_spips: Seperate the state struct into a header
xlnx-z
If a DMA mapping operation fails in vfio_listener_region_add() it
checks to see if we've already completed initial setup of the
container. If so it reports an error so the setup code can fail
gracefully, otherwise throws a hw_error().
There are other potential failure cases in vfio_listener_regio
On 29 September 2015 at 23:40, Alistair Francis wrote:
> On Thu, Sep 24, 2015 at 11:58 AM, mar.krzeminski
> wrote:
>>
>>
>> W dniu 24.09.2015 o 20:38, Peter Crosthwaite pisze:
>>
>>> On Thu, Sep 24, 2015 at 10:14 AM, mar.krzeminski
>>> wrote:
Today I stacked on other interesting think - and
Hi,
Thank you so much for your reply. Yes, I cannot use gmail directly for it's
blocked by the GFW, and I used the Tencent mail(@qq.com) to receive mails in
gmail. It's my first time to send a patch, I will read the link you provide
and improve my future patches.
As for BOOL and bool, are som
On 29 September 2015 at 22:35, Eric Blake wrote:
> ping
>
> On 09/04/2015 04:44 PM, Peter Maydell wrote:
>> On 4 September 2015 at 20:53, Markus Armbruster wrote:
>>> RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back
>>> to 10.6.
>>>
>>> Signed-off-by: Markus Armbruster
>>
>>
Consolidate the code between visit, command marshalling, and
event generation that iterates over the members of a struct.
It reduces code duplication in the generator, so that a future
patch can reduce the size of generated code while touching only
one instead of three locations.
There are no chan
Move the ssi.h include file into the ssi directory.
Signed-off-by: Alistair Francis
---
hw/arm/pxa2xx.c | 2 +-
hw/arm/spitz.c | 2 +-
hw/arm/stellaris.c | 2 +-
hw/arm/strongarm.c | 2 +-
hw/arm/tosa.c
On Tue, Sep 29, 2015 at 10:37:31AM +0200, Laurent Vivier wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
>
>
> On 29/09/2015 07:18, David Gibson wrote:
> > On Thu, Sep 24, 2015 at 12:27:39PM +0200, Laurent Vivier wrote:
> >> When DT node names for PCI devices are generated by SLOF,
We had some pointless differences in the generated code for visit,
command marshalling, and events; unifying them makes it easier for
future patches to consolidate to common helper functions.
This is one patch of a series to clean up these differences.
This patch names the goto labels 'out' (not '
On Monday, September 28, 2015 11:14:42 PM Namsun Ch'o wrote:
> > My understanding of the config file you proposed is that it would allow
> > the
> > configuration of a whitelist, so changes to the config very could result
> > in
> > *less* strict of a filter, not always more.
>
> No. Any time an a
On Thu, Sep 24, 2015 at 11:58 AM, mar.krzeminski
wrote:
>
>
> W dniu 24.09.2015 o 20:38, Peter Crosthwaite pisze:
>
>> On Thu, Sep 24, 2015 at 10:14 AM, mar.krzeminski
>> wrote:
>>>
>>>
>>> W dniu 24.09.2015 o 05:07, Peter Crosthwaite pisze:
>>>
>>> On Wed, Sep 23, 2015 at 8:06 PM, Peter Crosthwa
On 09/24/2015 06:32 PM, Alvise Rigo wrote:
Introduce a set of new runtime helpers do handle exclusive instructions.
This helpers are used as hooks to call the respective LL/SC helpers in
softmmu_llsc_template.h from TCG code.
Suggested-by: Jani Kokkonen
Suggested-by: Claudio Fontana
Signed-off
We had some pointless differences in the generated code for visit,
command marshalling, and events; unifying them makes it easier for
future patches to consolidate to common helper functions.
This is one patch of a series to clean up these differences.
This patch reduces the number of push_indent(
The core VFIO infrastructure more or less allows VFIO devices to work
on any normal guest PCI host bridge (PHB) without extra logic.
However, the "spapr-pci-host-bridge" device (as opposed to the special
"spapr-pci-vfio-host-bridge" device) breaks this by using a partially
KVM accelerated implement
We had some pointless differences in the generated code for visit,
command marshalling, and events; unifying them makes it easier for
future patches to consolidate to common helper functions.
This is one patch of a series to clean up these differences.
This patch names the local visitor variable '
On 24/09/2015 10:32, Alvise Rigo wrote:
> The implementation heavily uses the software TLB together with a new
> bitmap that has been added to the ram_list structure which flags, on a
> per-CPU basis, all the memory pages that are in the middle of a LoadLink
> (LL), StoreConditional (SC) operatio
At present the PCI host bridge (PHB) for the pseries machine type has a
fixed DMA window from 0..1GB (in PCI address space) which is mapped to real
memory via the PAPR paravirtualized IOMMU.
For better support of VFIO devices, we're going to want to allow for
different configurations of the DMA wi
On 09/24/2015 06:32 PM, Alvise Rigo wrote:
Use the new slow path for atomic instruction translation when the
softmmu is enabled.
Um... why? TCG_USE_LDST_EXCL would appear to be 100% redundant with SOFTMMU.
r~
Expose some weaknesses in the generator: we don't always forbid
the generation of structs that contain multiple members that map
to the same C or QMP name. This has already been marked FIXME in
qapi.py in commit d90675f, but having more tests will make sure
future patches produce desired behavior;
On 09/27/2015 05:02 PM, Dennis Luehring wrote:
git master clone from 09/27/2015, 8:07
git rev-parse HEAD
9e071429e649346c14b2dc76902f84f8352d2333
if i try to start qemu-system-alpha with option -nographic while installing
debian lenny 5.0.10 for alpha
i get this output and qemu hangs - without u
The vfio_accel parameter used when creating a new TCE table (guest IOMMU
context) has a confusing name. What it really means is whether we need the
TCE table created to be able to support VFIO devices.
VFIO is relevant, because when available we use in-kernel acceleration of
the TCE table, but th
We had some pointless differences in the generated code for visit,
command marshalling, and events; unifying them makes it easier for
future patches to consolidate to common helper functions.
This is one patch of a series to clean up these differences.
This patch consistently names the local error
Fix undefined behavior detected by clang runtime check:
qemu/target-i386/cpu.c:1494:15: runtime error:
left shift of 1 by 31 places cannot be represented in type 'int'
While doing that, add extra parenthesis for clarity.
Reported-by: Peter Maydell
Signed-off-by: Eduardo Habkost
---
targ
On Tue, Sep 29, 2015 at 09:15:58AM +0200, Paolo Bonzini wrote:
>
>
> On 29/09/2015 05:30, David Gibson wrote:
> >> Maybe... The only issue is the "granularity" argument, which is
> >> not in memory_region_register_iommu_notifier. That makes me
> >> wonder if the replay and registration make se
Add some testsuite exposure for use of a 'number' as part of
an alternate. The current state of the tree has a few bugs
exposed by this: our input parser depends on the ordering of
how the qapi schema declared the alternate, and the parser
does not accept integers for a 'number' in an alternate ev
Hi Alex,
Here are the parts of my recent series to allow VFIO devices on the
spapr-pci-host-bridge device which affect the core VFIO code. They've
been revised according to the comments from yourself and others.
There's also one patch for the memory subsystem.
Note that while these are motivate
When we have guest visible IOMMUs, we allow notifiers to be registered
which will be informed of all changes to IOMMU mappings. This is used by
vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings.
However, unlike with a memory region listener, an iommu notifier won't be
told ab
pylint recommends that every exception class should explicitly
invoke the superclass __init__, even though things seem to work
fine without it.
Signed-off-by: Eric Blake
---
v6: split off of 2/26
---
scripts/qapi.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi.py b/scripts
This fixes two errors detected by clang:
target-i386/cpu.c:1494:15: runtime error: left shift of 1 by 31 places cannot
be represented in type 'int'
target-i386/translate.c:2423:26: runtime error: left shift of negative value
-8
Eduardo Habkost (2):
target-i386: Use 1UL for bit shift
tar
Depending on the host IOMMU type we determine and record the available page
sizes for IOMMU translation. We'll need this for other validation in
future patches.
Signed-off-by: David Gibson
Reviewed-by: Thomas Huth
Reviewed-by: Laurent Vivier
---
hw/vfio/common.c | 13
On Tue, Sep 29, 2015 at 08:00:13PM +0100, Dr. David Alan Gilbert wrote:
> * Haozhong Zhang (haozhong.zh...@intel.com) wrote:
> > The newly added subsection 'vmstate_tsc_khz' in this patch results in
> > vcpu's TSC rate being saved on the source machine and loaded on the
> > target machine during th
If a migration is already in progress and somebody attempts
to add a migration blocker, this should rightly fail.
Add an errp parameter and a retcode return value to migrate_add_blocker.
This is part one of two for a solution to prohibit e.g. block jobs
from running concurrently with migration.
At present the memory listener used by vfio to keep host IOMMU mappings
in sync with the guest memory image assumes that if a guest IOMMU
appears, then it has no existing mappings.
This may not be true if a VFIO device is hotplugged onto a guest bus
which didn't previously include a VFIO device, a
From: Chen Gang
Signed-off-by: Chen Gang
---
target-tilegx/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
index d2b2b6e..251b254 100644
--- a/target-tilegx/translate.c
+++ b/target-tilegx/translate.c
@@ -1500
On Tue, Sep 29, 2015 at 07:28:39PM +0200, Laszlo Ersek wrote:
> On 09/29/15 19:19, Gabriel L. Somlo wrote:
> > On Tue, Sep 29, 2015 at 06:55:01PM +0200, Laszlo Ersek wrote:
> >> On 09/29/15 18:46, Gabriel L. Somlo wrote:
> >>> On Tue, Sep 29, 2015 at 12:33:40PM +0200, Laszlo Ersek wrote:
> On
On Tue, Sep 29, 2015 at 08:21:49PM +0100, Peter Maydell wrote:
> On 29 September 2015 at 19:22, Eduardo Habkost wrote:
> > On Tue, Sep 29, 2015 at 12:28:15PM +0100, Peter Maydell wrote:
> >> I get a bunch of new warnings in the course of 'make check' now:
> >>
> >> warning: TCG doesn't support req
ping
On 09/04/2015 04:44 PM, Peter Maydell wrote:
> On 4 September 2015 at 20:53, Markus Armbruster wrote:
>> RHEL-6 and SLES-11 provide Python 2.6. It'll also work on OS X back
>> to 10.6.
>>
>> Signed-off-by: Markus Armbruster
>
> Reviewed-by: Peter Maydell
>
> I wonder if we're ever going
qapi-commands has a nice helper gen_err_check(), but did not
use it everywhere. In fact, using it in more places makes it
easier to reduce the lines of code used for generating error
checks. This in turn will make it easier for later patches
to consolidate another common pattern among the generato
We had some pointless differences in the generated code for visit,
command marshalling, and events; unifying them makes it easier for
future patches to consolidate to common helper functions.
This is one patch of a series to clean up these differences.
This patch adjusts gen_visit_union() to use t
On 29 September 2015 at 11:34, Max Filippov wrote:
> On Mon, Sep 28, 2015 at 12:59 AM, Peter Crosthwaite
> wrote:
>> On Sun, Sep 27, 2015 at 2:48 PM, Max Filippov wrote:
>>> On Mon, Sep 28, 2015 at 12:28 AM, Peter Crosthwaite
>>> wrote:
To clarify, can you tell me the QEMU command line dif
On Tue, Sep 29, 2015 at 03:02:07PM -0300, Eduardo Habkost wrote:
> On Tue, Sep 29, 2015 at 11:43:34AM +0800, Haozhong Zhang wrote:
> > On Mon, Sep 28, 2015 at 01:37:34PM -0300, Eduardo Habkost wrote:
> > > On Mon, Sep 28, 2015 at 01:38:31PM +0800, Haozhong Zhang wrote:
> [...]
> > > > static void
The documentation claims that alternates are useful for
allowing two or more types, although nothing enforces this.
Meanwhile, it is silent on whether empty unions are allowed.
In practice, the generated code will compile, in part because
we have a 'void *data' branch; but attempting to visit such
Seperate out the XilinxSPIPS struct into a seperate header
file.
Signed-off-by: Alistair Francis
---
hw/ssi/xilinx_spips.c | 104 +---
include/hw/ssi/xilinx_spips.h | 134 ++
2 files changed, 135 insertions(+), 103 dele
The previous commit added two tests that triggered an assertion
failure. It's fairly straightforward to avoid the failure by
just outright forbidding the collision between a union's tag
values and its discriminator name (including the implicit name
'kind' supplied for simple unions [*]). Ultimatel
On 09/29/2015 02:37 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> The 'postcopy ram' capability allows postcopy migration of RAM;
> note that the migration starts off in precopy mode until
> postcopy mode is triggered (see the migrate_start_postcopy
> patch later in
On Tue, Sep 29, 2015 at 12:40:16PM +0200, Laszlo Ersek wrote:
> On 09/27/15 23:29, Gabriel L. Somlo wrote:
> > Add a fw_cfg device node to the ACPI DSDT. This is mostly
> > informational, as the authoritative fw_cfg MMIO region(s)
> > are listed in the Device Tree. However, since we are building
>
Patch 17 is marked RFC because it has a prerequisite:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01277.html
Patch 18 is marked RFC because it is probably worth discarding.
Otherwise, this series addresses the review comments on v6.
Also available as a tag at this location:
git fetch
Controversial: find all remaining patterns that generate a
goto statement due to 'err', and convert them to use
gen_err_check(). The bulk of these replacements actually
lead to code duplication (extra mcgen() calls with common
parameterization), so I will probably drop this patch.
Signed-off-by:
On Tue, Sep 29, 2015 at 3:34 AM, Max Filippov wrote:
> On Mon, Sep 28, 2015 at 12:59 AM, Peter Crosthwaite
> wrote:
>> On Sun, Sep 27, 2015 at 2:48 PM, Max Filippov wrote:
>>> On Mon, Sep 28, 2015 at 12:28 AM, Peter Crosthwaite
>>> wrote:
To clarify, can you tell me the QEMU command line d
On Tue, Sep 29, 2015 at 12:28:15PM +0100, Peter Maydell wrote:
> On 28 September 2015 at 18:31, Eduardo Habkost wrote:
> > The following changes since commit 9e071429e649346c14b2dc76902f84f8352d2333:
> >
> > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> > staging (2015
Since we have consolidated all generated code to use 'err' as
the name of the local variable for error detection, we can
simplify the decision on whether to skip error detection (useful
for deallocation paths) to be a boolean.
This requires the python 2.5 ternary syntax.
Signed-off-by: Eric Blake
On 09/29/15 21:04, Gabriel L. Somlo wrote:
> On Tue, Sep 29, 2015 at 05:15:25PM +0300, Michael S. Tsirkin wrote:
>> On Tue, Sep 29, 2015 at 03:59:28PM +0200, Laszlo Ersek wrote:
>>> On 09/29/15 12:27, Michael S. Tsirkin wrote:
On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote:
>
Recent changes to qapi have provided quite a bit of churn in
the makefile, because we are inconsistent on what order test
names appear in, and on whether to re-wrap the list of tests or
just add arbitrary line lengths. Writing the list in a sorted
fashion, one test per line, will make future patch
On Sep 29, 2015, at 2:00 PM, Peter Maydell wrote:
> On 29 September 2015 at 18:53, Programmingkid
> wrote:
>>
>> On Sep 29, 2015, at 1:18 PM, Peter Maydell wrote:
>>
>>> On 29 September 2015 at 18:03, Programmingkid
>>> wrote:
Allow the user the ability to run a custom script file.
>>>
Rather than open-code the check for a valid base type, we
should reuse the common functionality. This allows for
consistent error messages, and also makes it easier for a
later patch to turn on support for inline anonymous base
structures.
Test flat-union-inline is updated to test only one feature
On 29 September 2015 at 18:53, Programmingkid wrote:
>
> On Sep 29, 2015, at 1:18 PM, Peter Maydell wrote:
>
>> On 29 September 2015 at 18:03, Programmingkid
>> wrote:
>>> Allow the user the ability to run a custom script file.
>>> This patch adds a menu item called "Run Custom Script".
>>> When
On Tue, Sep 29, 2015 at 05:15:25PM +0300, Michael S. Tsirkin wrote:
> On Tue, Sep 29, 2015 at 03:59:28PM +0200, Laszlo Ersek wrote:
> > On 09/29/15 12:27, Michael S. Tsirkin wrote:
> > > On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote:
> > >> New since v3:
> > >>
> > >> - rebased
Silence pep8, and make pylint a bit happier. Just style cleanups,
plus killing a useless comment in camel_to_upper(); no semantic
changes.
Signed-off-by: Eric Blake
---
v7: drop useless (), avoid non-mechanical conversion of lookup within
two sets
v6: split off non-style changes, add in ordered
Left shift of negative values is undefined behavior. Detected by clang:
qemu/target-i386/translate.c:2423:26: runtime error:
left shift of negative value -8
This changes the code to reverse the sign after the left shift.
Signed-off-by: Eduardo Habkost
---
target-i386/translate.c | 2 +-
1
On 09/29/2015 08:31 AM, Markus Armbruster wrote:
>
> To really cut the verbosity, I figure we'd have to do something more
> radical, like having cgen() recognize a (short!) pattern and replace it
> with a full-blown error check. Not sure that's actually a good idea,
> though :)
Another radical i
Use of '"...%s" % include' to print non-strings can lead to
ugly messages, such as this (if the .json change is applied
without the qapi.py change):
Expected a file name (string), got: OrderedDict()
Better is to just omit the actual non-string value in the
message.
Signed-off-by: Eric Blake
--
On Tue, Sep 29, 2015 at 03:59:28PM +0200, Laszlo Ersek wrote:
> On 09/29/15 12:27, Michael S. Tsirkin wrote:
> > On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote:
> >> New since v3:
> >>
> >>- rebased to work on top of 87e896ab (introducing pc-*-25 classes),
> >> inserting
On Tue, Sep 29, 2015 at 01:27:38PM +0300, Michael S. Tsirkin wrote:
> On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote:
> > New since v3:
> >
> > - rebased to work on top of 87e896ab (introducing pc-*-25 classes),
> > inserting fw_cfg acpi node only for machines >= 2.5.
>
On Tue, Sep 29, 2015 at 06:55:01PM +0200, Laszlo Ersek wrote:
> On 09/29/15 18:46, Gabriel L. Somlo wrote:
> > On Tue, Sep 29, 2015 at 12:33:40PM +0200, Laszlo Ersek wrote:
> >> On 09/27/15 23:29, Gabriel L. Somlo wrote:
> >>> Add a fw_cfg device node to the ACPI SSDT, on machine types
> >>> pc-*-2
On 9/29/15 14:34, Richard Henderson wrote:
> On 09/28/2015 03:06 PM, gang.chen.5...@gmail.com wrote:
>> From: Chen Gang
>>
>> Acording to the __longjmp tilegx libc implementation, and reference from
>> tilegx ISA document, we can left iret instruction empty. The related
>> code is below:
>>
>>
* Haozhong Zhang (haozhong.zh...@intel.com) wrote:
> The newly added subsection 'vmstate_tsc_khz' in this patch results in
> vcpu's TSC rate being saved on the source machine and loaded on the
> target machine during the migration.
>
> Signed-off-by: Haozhong Zhang
Hi,
I'd appreciate it if you
On 29 September 2015 at 18:03, Programmingkid wrote:
> Allow the user the ability to run a custom script file.
> This patch adds a menu item called "Run Custom Script".
> When the user selects it, a open-file dialog has the
> user select a text file with the custom scripts to run.
> This allows fo
On 09/29/2015 07:38 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Add some testsuite exposure for use of a 'number' as part of
>> an alternate. The current state of the tree has a few bugs
>> exposed by this: our input parser depends on the ordering of
>> how the qapi schema declared th
On 09/29/15 18:46, Gabriel L. Somlo wrote:
> On Tue, Sep 29, 2015 at 12:33:40PM +0200, Laszlo Ersek wrote:
>> On 09/27/15 23:29, Gabriel L. Somlo wrote:
>>> Add a fw_cfg device node to the ACPI SSDT, on machine types
>>> pc-*-2.5 and up. While the guest-side BIOS can't utilize
>>> this information
On 29.09.2015 20:19, Peter Maydell wrote:
> On 29 September 2015 at 18:14, Sergey Fedorov wrote:
>> On 29.09.2015 12:33, Peter Maydell wrote:
>>> On 28 September 2015 at 11:37, Sergey Fedorov wrote:
>>> This field should be named mdcr_el2 if we have it, but:
>>> the reset value for this register
101 - 200 of 294 matches
Mail list logo
