Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

Gerd Hoffmann writes: >> > Also you don't need a init function, you can simply init the array with >> > c99 initializers: >> > >> > chtype vga_to_curses[256] = { >> > [0x04] = ACS_DIAMOND, >> > [ ... ] >> > }; >> >> This is not possible, because ACS_* is not constant

Re: [Qemu-devel] [PATCH v4 2/3] hw/pci: Introduce pci_requester_id()

On Thu, Oct 15, 2015 at 12:42:06PM +0300, Pavel Fedin wrote: > Hello! > > > Then I realized it's actually the PCI requester ID. > > That, in turn, means it can just be a generic PCI API, > > e.g. it's also used for assigning pci-x devices. > > Ok. So, will it be good if i place it in

[Qemu-devel] [Bug 1494350] Re: QEMU: causes vCPU steal time overflow on live migration

Hi, I've seen the same issue with debian jessie. Compiled 4.2.3 from kernel.org with "make localyesconfig", no problem any more -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1494350 Title: QEMU:

Re: [Qemu-devel] [PATCH 2/3] block: make bdrv_find_node() static

On Wed 14 Oct 2015 03:16:01 PM CEST, Jeff Cody wrote: > This patch does two things: it moves bdrv_find_node() up before the > first usage in block.c, and it makes the function static so that it > is only internal to block.c. > > Signed-off-by: Jeff Cody Reviewed-by: Alberto

[Qemu-devel] [PATCH] tests: re-enable vhost-user-test

From: Marc-André Lureau Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, since CONFIG_VHOST_NET is a per-target config variable. CONFIG_VHOST_NET_USED is the host config, actually unused since 1322629b4f2. But it was set whenever vhost_net was

[Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supported

Currently, if the kernel does not have live migration API, the migration will still be attempted, but vGIC save/restore functions will just not do anything. This will result in a broken machine state. This patch fixes the problem by patching vmstate_gic.unmigratable flag in runtine.

Re: [Qemu-devel] [Bug 1494350] Re: QEMU: causes vCPU steal time overflow on live migration

>>Hi, Hi >> >>I've seen the same issue with debian jessie. >> >>Compiled 4.2.3 from kernel.org with "make localyesconfig", >>no problem any more host kernel or guest kernel ? - Mail original - De: "Markus Breitegger" <1494...@bugs.launchpad.net> À: "qemu-devel"

[Qemu-devel] [Bug 1494350] Re: QEMU: causes vCPU steal time overflow on live migration

Sorry but I think I've pasted my answer to the wrong bugreport. Sorry about that! I'm not using live migration. https://lists.debian.org/debian-kernel/2014/11/msg00093.html but seems something Debian related. Following scenario: Host Ubuntu 14.04 Guest Debian Jessie Debian with 3.16.0-4-amd64

Re: [Qemu-devel] [PATCH 1/3] block: Use bdrv_lookup_bs() instead of bdrv_find_node()

On Wed 14 Oct 2015 03:16:00 PM CEST, Jeff Cody wrote: > This is a precursor to making bdrv_find_node() static, and internal > to block.c > > To find a BlockDriverState interface, it can be done via blk_by_name(), > bdrv_find_node(), and bdrv_lookup_bs(). The latter can take the

Re: [Qemu-devel] [PATCH v5 2/3] hw/pci: Introduce pci_requester_id()

On Thu, Oct 15, 2015 at 02:05:16PM +0300, Pavel Fedin wrote: > For GICv3 ITS implementation we are going to use requester IDs in KVM IRQ > routing code. This patch introduces reusable convenient way to obtain this > ID from the device pointer. The new function is now used in some places, > where

[Qemu-devel] [PATCH] vmxnet3: Do not fill stats if device is inactive

From: Shmulik Ladkani Guest OS may issue VMXNET3_CMD_GET_STATS even before device was activated (for example in linux, after insmod but prior net-dev open). Accessing shared descriptors prior device activation is illegal as the VMXNET3State structures have

[Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI routing functions

In-kernel ITS emulation on ARM64 will require to supply requester IDs. These IDs can now be retrieved from the device pointer using new pci_requester_id() function. This patch adds pci_dev pointer to KVM GSI routing functions and makes callers passing it. x86 architecture does not use requester

[Qemu-devel] [PATCH v5 1/3] kvm: Make KVM_CAP_SIGNAL_MSI globally available

This capability is useful to determine whether we can use KVM ITS emulation on ARM Signed-off-by: Pavel Fedin --- include/sysemu/kvm.h | 9 + kvm-all.c| 10 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/include/sysemu/kvm.h

[Qemu-devel] [PATCH v5 0/3] Make KVM/MSI code device-ID-aware

On ARM architecture ITS (Interrupt Translation Service), additionally to normal MSI data, uses also side-band device IDs. This series prepares the infrastructure to handling them. This small series is actually an extraction from vITS support RFC

[Qemu-devel] [PATCH v5 2/3] hw/pci: Introduce pci_requester_id()

For GICv3 ITS implementation we are going to use requester IDs in KVM IRQ routing code. This patch introduces reusable convenient way to obtain this ID from the device pointer. The new function is now used in some places, where the same calculation was used. MemTxAttrs.stream_id also renamed to

Re: [Qemu-devel] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree

Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: > Most of the options which blockdev_init() parses for both the > BlockBackend and the root BDS are valid for just the root BDS as well > (e.g. read-only). This patch allows specifying these options even if not > creating a BlockBackend. > >

[Qemu-devel] [PATCH 2/2] qga: set file descriptors in qmp_guest_file_open non-blocking on Win32

From: Olga Krishtal Set fd non-blocking to avoid common use cases (like reading from a named pipe) from hanging the agent. This was missed in the original code. Restore compatibility with Posix implementation. The patch adds Win32 specific implementation of

[Qemu-devel] [PATCH 1/2] qga: drop hand-made guest_file_toggle_flags helper

We'd better use generic qemu_set_nonblock directly. Signed-off-by: Denis V. Lunev Reviewed-by: Yuri Pudgorodskiy Reviewed-by: Eric Blake CC: Michael Roth --- qga/commands-posix.c | 27

[Qemu-devel] [PATCH v4] ui/curses: Support line graphics chars on -curses mode

This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h |9 ++-- ui/console.c | 13

Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI routing functions

Hello! > Should the pci_dev be passed to kvm_arch_fixup_msi_route() as well? > Currently, the only implementer of this function (s390x) does not need > it; but it shouldn't hurt? Yes, it shouldn't. I didn't pass it there exactly because of this reason. However, is also passed to this

Re: [Qemu-devel] [PATCH v2 06/22] block: Add "supports_stats" field to BlockStats

On Tue 13 Oct 2015 05:38:30 PM CEST, Stefan Hajnoczi wrote: >> query-blockstats always returns a BlockDeviceStats structure for each >> BDS, regardless of whether it implements accounting or not. Since the >> field is mandatory there's no way to tell that from the values alone. >> >> This field

Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI routing functions

On Thu, 15 Oct 2015 14:05:17 +0300 Pavel Fedin wrote: > In-kernel ITS emulation on ARM64 will require to supply requester IDs. > These IDs can now be retrieved from the device pointer using new > pci_requester_id() function. > > This patch adds pci_dev pointer to KVM GSI

[Qemu-devel] [PULL 2/3] migration: announce VM's new home just before VM is runnable

From: Amit Shah We were announcing the dest host's IP as our new IP a bit too soon -- if there were errors detected after this announcement was done, the migration is failed and the VM could continue running on the src host -- causing problems later. Move around the

[Qemu-devel] [PATCH 1/3] log: improve performance of qemu_log and qemu_log_mask if disabled

The patch is intended to avoid to perform any operation including calculation of log function arguments when the log is not enabled due to various reasons. Functions qemu_log and qemu_log_mask are replaced with variadic macros. Unfortunately the code is not C99 compatible and we can not use

[Qemu-devel] [PATCH 3/3] log: adds a timestamp to each log entry

From: Pavel Butsykin This patch is written as an addition to the previous one with logging of QPM commands. This information (the moment of the event) is very useful to match guest problems with actions performing by management software. example: 2015-10-14 17:15:25.644

[Qemu-devel] [PULL 05/12] qapi: Move empty-enum to compile-time test

From: Eric Blake Rather than just asserting that we can parse an empty enum, let's also make sure we can compile it, by including it in qapi-schema-test. Signed-off-by: Eric Blake Message-Id: <1444710158-8723-5-git-send-email-ebl...@redhat.com>

[Qemu-devel] [PULL 08/12] qapi: Drop redundant args-member-array test

From: Eric Blake qapi-schema-test already ensures that we can correctly compile an array of enums (__org.qemu_x-command), an array of builtins (UserDefNativeListUnion), and an array of structs (again __org.qemu_x-command). That means args-member-array is not adding any

[Qemu-devel] [PULL 10/12] qapi: Lazy creation of array types

From: Eric Blake Commit ac88219a had several TODO markers about whether we needed to automatically create the corresponding array type alongside any other type. It turns out that most of the time, we don't! There are a few exceptions: 1) We have a few situations where we use

[Qemu-devel] [PULL 04/04] Add syscalls for -runas and -chroot to the seccomp sandbox

From: Namsun Ch'o The seccomp sandbox doesn't whitelist setuid, setgid, or setgroups, which are needed for -runas to work. It also doesn't whitelist chroot, which is needed for the -chroot option. Unfortunately, QEMU enables seccomp before it drops privileges or chroots,

[Qemu-devel] [PULL 01/04] libseccomp: add cacheflush to whitelist

From: Andrew Jones cacheflush is an arm-specific syscall that qemu built for arm uses. Add it to the whitelist. Signed-off-by: Andrew Jones Acked-by: Eduardo Otubo --- qemu-seccomp.c | 3 ++- 1 file changed, 2

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

Hi, > From this call paths, graphic_hw_text_update() => console_write_ch() => > ->text_update() path is only used for -curses mode. What do you think? Oh, right, text mode curses update and text mode framebuffer rendering take completely separate code paths. Completely forgot that, I rarely

Re: [Qemu-devel] Connecting netdev to emulated nics.

On 10/15/2015 02:36 PM, sai pavan wrote: > Hi, > > I am debugging an issue, where through one of the nics I am not able > to connect to dtcp. > So to dig in deep, i was going thought net.c files, and ended-up > understanding little. > > So can i know how does a netdev connects to nic. > >

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

> > Also you don't need a init function, you can simply init the array with > > c99 initializers: > > > > chtype vga_to_curses[256] = { > > [0x04] = ACS_DIAMOND, > > [ ... ] > > }; > > This is not possible, because ACS_* is not constant (initialized by > reading from termcap or such).

Re: [Qemu-devel] [PATCH v7 1/1] block/gluster: add support for multiple gluster backup volfile servers

On Wed, Oct 14, 2015 at 12:36:58 +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currenly VM Image on gluster volume is specified like

[Qemu-devel] [PATCH QEMU] target-arm: Add support for SPSR_(ABT|UND|IRQ|FIQ)

Signed-off-by: Soren Brinkmann --- Hi, I recently came across some code that caused undefined instruction exceptions when executing instructions 'mrs x11, spsr_abt' and the like. I'm not sure I get the full picture, but it seems QEMU already keeps the state for

[Qemu-devel] [PULL 01/12] qapi: Fix regression with '-netdev help'

From: Eric Blake Commit e36c714e causes 'qemu -netdev help' to dump core, because the call to visit_end_union() is no longer conditional on whether *obj was allocated. Reported by Marc-André Lureau Signed-off-by: Eric Blake

[Qemu-devel] [PULL 03/12] qapi: Prepare for errors during check()

From: Eric Blake The next few patches will start migrating error checking from ad hoc parse methods into the QAPISchema*.check() methods. But for an error message to display, we first have to fix the overall 'try' to catch those errors. We also want to enable a few more

[Qemu-devel] [PULL 09/12] qapi: Don't use info as witness of implicit object type

From: Eric Blake A future patch will enable error reporting from the various QAPISchema*.check() methods. But to report an error related to an implicit type, we'll need to associate a location with the type (the same location as the top-level entity that is causing the

[Qemu-devel] [PULL 03/04] Add argument filters to the seccomp sandbox

From: Namsun Ch'o Here's the v3 patch. I applied it and compiled QEMU, and it worked fine. Changes so far: v1 - Created argument filters for the madvise, shmget, and shmctl syscalls. v1 -> v2 - Added 5 new madvise flags which were present in the source code but not in

[Qemu-devel] [PULL 12/12] qapi: Track location that created an implicit type

From: Eric Blake A future patch will move some error checking from the parser to the various QAPISchema*.check() methods, which run only after parsing completes. It will thus be possible to create a python instance representing an implicit QAPI type that parses fine but will

Re: [Qemu-devel] [PATCH] hw/mips_malta: Fix KVM PC initialisation

On 2015-10-12 17:54, James Hogan wrote: > Commit 71c199c81d29 ("mips_malta: provide ememsize env variable to > kernels") changed the meaning of loaderparams.ram_size to be the whole > of RAM rather than just the low part below where the boot code is placed > for KVM, but it didn't update the PC

[Qemu-devel] [PULL 02/04] configure: arm/aarch64: allow enable-seccomp

From: Andrew Jones This is a revert of ae6e8ef11e6cb, but with a bit of refactoring, and also specifically adding arm/aarch64, rather than all architectures. Currently, libseccomp code appears to also support mips, ppc, and s390. We could therefore allow qemu to enable

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

Gerd Hoffmann writes: >> (E.g. qemu is going to extend to use this for other purpose?) > > Unlikely. In theory other ui frontends could support vga text mode that > way. But text mode is a dying relic, people use either graphics or a > serial console these days, so I don't

[Qemu-devel] Connecting netdev to emulated nics.

Hi, I am debugging an issue, where through one of the nics I am not able to connect to dtcp. So to dig in deep, i was going thought net.c files, and ended-up understanding little. So can i know how does a netdev connects to nic. nd_table[] has some pointers for netdev devices. Where are this

[Qemu-devel] [PULL 04/12] qapi: Drop redundant alternate-good test

From: Eric Blake The alternate-good.json test was already covered by qapi-schema-test.json. As future commits will be tweaking how alternates are laid out, removing the duplicate test now reduces churn. Signed-off-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 00/12] QAPI patches

The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-10-15

[Qemu-devel] [PULL 02/12] qapi: Use predicate callback to determine visit filtering

From: Eric Blake Previously, qapi-types and qapi-visit filtered out implicit objects during visit_object_type() by using 'info' (works since implicit objects do not [yet] have associated info); meanwhile qapi-introspect filtered out all schema types on the first pass by

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

On (Thu) 15 Oct 2015 [08:36:49], Juan Quintela wrote: > Amit Shah wrote: > > On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: > >> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > >> > Amit Shah wrote: > >> > > We were

Re: [Qemu-devel] [PATCH v4 2/3] hw/pci: Introduce pci_requester_id()

On Thu, Oct 15, 2015 at 11:54:57AM +0300, Pavel Fedin wrote: > Hello! > > > > diff --git a/stubs/pci.c b/stubs/pci.c > > > new file mode 100644 > > > index 000..3b13000 > > > --- /dev/null > > > +++ b/stubs/pci.c > > > @@ -0,0 +1,16 @@ > > > +/* > > > + * QEMU architecture-specific PCI

[Qemu-devel] [PATCH 2/3] log: report hmp/qmp command and qmp event

From: Pavel Butsykin This log would be very welcome for long-term diagnostics of the system in the production. This log is at least necessary to understand what has been happened on the system and to identify issues at higher-level subsystems (libvirt, etc).

[Qemu-devel] [PATCH 0/3] QEMU logging improvements

The following is done: - QMP/HMP events are now logged - timestamp is added to the log message - arguments of qemu_log/qemu_log_mask are not calculated now if the log is disabled These patches are sent in the hope that it is not too late for QEMU 2.5. Logging subsystem in QEMU looks

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

On Thu, Oct 15, 2015 at 01:34:10PM +0530, Amit Shah wrote: > On (Thu) 15 Oct 2015 [08:36:49], Juan Quintela wrote: > > Amit Shah wrote: > > > On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: > > >> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: > >

[Qemu-devel] [PULL 1/3] Migration: Generate the completed event only when we complete

From: "Dr. David Alan Gilbert" The current migration-completed event is generated a bit too early, which means that an eager libvirt that's ready to go as soon as it sees the event ends up racing with the actual end of migration. This corresponds to RH bug:

[Qemu-devel] [PULL 0/3] Migration pull

) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20151015 for you to fetch changes up to 60be6340796e66b5ac8aac2d98dde5c79336a89c: migration: fix deadlock (2015-10-15 08:14:13 +0200

[Qemu-devel] [PULL 3/3] migration: fix deadlock

From: "Denis V. Lunev" Release qemu global mutex before call synchronize_rcu(). synchronize_rcu() waiting for all readers to finish their critical sections. There is at least one critical section in which we try to get QGM (critical section is in address_space_rw() and

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

Gerd Hoffmann writes: >> vga_to_curses[] is filled by curses_setup(). So if no -curses option, I >> think it should have no change to behavior. (BTW, there is no common >> section like kernel in qemu build, right? i.e. no need initializer to >> global value.) > > Ok, curses

Re: [Qemu-devel] [PATCH v4 2/3] hw/pci: Introduce pci_requester_id()

Hello! > > diff --git a/stubs/pci.c b/stubs/pci.c > > new file mode 100644 > > index 000..3b13000 > > --- /dev/null > > +++ b/stubs/pci.c > > @@ -0,0 +1,16 @@ > > +/* > > + * QEMU architecture-specific PCI functions > > + * > > + * Copyright (c) 2015 Samsung Electronics Co., Ltd. > > + *

[Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

The tcx_initfn() function is already supplied with an Object *obj pointer, so there is no need to cast the state pointer back to an Object pointer all over the place. And while we're at it, also remove the superfluous "return;" statement in this function. Signed-off-by: Thomas Huth

Re: [Qemu-devel] [PATCH v4] fw_cfg: insert string blobs via qemu cmdline

On Mi, 2015-10-14 at 16:22 +0200, Laszlo Ersek wrote: > Paolo, > > On 09/29/15 18:29, Gabriel L. Somlo wrote: > > Allow users to provide custom fw_cfg blobs with ascii string > > payloads specified directly on the qemu command line. > > > > Suggested-by: Jordan Justen

Re: [Qemu-devel] [PATCH v4 2/3] hw/pci: Introduce pci_requester_id()

Hello! > Then I realized it's actually the PCI requester ID. > That, in turn, means it can just be a generic PCI API, > e.g. it's also used for assigning pci-x devices. Ok. So, will it be good if i place it in includes/hw/pci.h as static inline, similar to how it was done in v1? Kind

Re: [Qemu-devel] [PATCH v2] qapi: Fix regression with '-netdev ?'

Eric Blake writes: > Commit e36c714e causes 'qemu -netdev ?' to dump core, because the > call to visit_end_union() is no longer conditional on whether > *obj was allocated. > > Reported by Marc-André Lureau > Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH 1/1] migration: announce VM's new home just before VM is runnable

Amit Shah wrote: > On (Wed) 14 Oct 2015 [17:12:44], Michael S. Tsirkin wrote: >> On Wed, Oct 14, 2015 at 03:21:15PM +0200, Juan Quintela wrote: >> > Amit Shah wrote: >> > > We were announcing the dest host's IP as our new IP a bit too soon -- if >> > >

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

On Do, 2015-10-15 at 08:58 +0900, OGAWA Hirofumi wrote: > Gerd Hoffmann writes: > > > On Mi, 2015-10-14 at 20:37 +0900, OGAWA Hirofumi wrote: > >> This converts vga code to curses code in console_write_bh(). > >> > >> With this changes, we can see line graphics (for example,

[Qemu-devel] [PULL 11/12] qapi: Create simple union type member earlier

From: Eric Blake For simple unions, we were creating the implicit 'type' tag member during the QAPISchemaObjectTypeVariants constructor. This is different from every other implicit QAPISchemaEntity object, which get created by QAPISchema methods. Hoist the creation to the

Re: [Qemu-devel] [PATCH v2] target-arm: Add MDCR_EL2

On 14.10.2015 22:34, Peter Maydell wrote: > On 14 October 2015 at 10:35, Sergey Fedorov wrote: >> On 13.10.2015 20:27, Peter Maydell wrote: >>> On 9 October 2015 at 10:43, Sergey Fedorov wrote: Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH v3] ui/curses: Support line graphics chars on -curses mode

This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h |9 ++-- ui/console.c | 13

[Qemu-devel] [PULL 06/12] qapi: Drop redundant returns-int test

From: Eric Blake qapi-schema-test was already testing that we could have a command returning int, but burned a command name in the whitelist. Merge the redundant positive test returns-int, and pick a name that reduces the whitelist size. Signed-off-by: Eric Blake

[Qemu-devel] [PULL 07/12] qapi: Drop redundant flat-union-reverse-define test

From: Eric Blake As of commit 8c3f8e77, we test compilation of forward references for a struct base type (UserDefOne), flat union base type (UserDefUnionBase), and flat union branch type (UserDefFlatUnion2). The only remaining forward reference being tested for parsing in

[Qemu-devel] [PULL 00/04] seccomp branch queue

The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100) are available in the git repository at: git://github.com/otubo/qemu.git tags/pull-seccomp-20151015

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

OGAWA Hirofumi writes: >> Ok, curses and gtk can't be active at the same time. But for curses and >> vnc it is possible (qemu -curses -vnc :$display), and you probably get a >> dissorted vga text mode over vnc then. >> >> I think the mapping should happen in the

[Qemu-devel] [PATCH 0/6] qobject: Make conversion from QObject * accept null

The qobject_to_FOO() crash on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Throw in a patch to drop QObject_HEAD. Luiz, I'm happy to take this through my tree, since got a QMP series based on it (to be posted shortly). Markus Armbruster (6): qobject:

[Qemu-devel] [PATCH 0/7] Throttle event VSERPORT_CHANGE separately by "id"

VSERPORT_CHANGE is emitted when the guest opens or closes a virtio-serial port. The event's member "id" identifies the port. When several events arrive quickly, throttling drops all but the last of them. Because of that, a QMP client must assume that *any* port may have changed state when it

Re: [Qemu-devel] [PATCH 3/6] qdict: Make conversion from QObject * accept null

On 10/15/2015 08:15 AM, Markus Armbruster wrote: > qobject_to_qdict() crashes on null, which is a trap for the unwary. > Return null instead, and simplify a few callers. > > Signed-off-by: Markus Armbruster > --- > qga/main.c | 11 +++ > qobject/qdict.c | 6

Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

On Wed, Oct 14, 2015 at 10:50:40PM +0800, Xiao Guangrong wrote: > On 10/14/2015 05:40 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > >>+out = (dsm_out *)in; > >>+ > >>+revision = in->arg1; > >>+function = in->arg2; > >>+handle =

[Qemu-devel] [PATCH 1/7] monitor: Reduce casting of QAPI event QDict

Make the variables holding the event QDict instead of QObject. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- monitor.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/monitor.c

Re: [Qemu-devel] [PATCH 0/3] QEMU logging improvements

On Thu, Oct 15, 2015 at 06:18:31PM +0300, Pavel Butsykin wrote: > > On 15.10.2015 17:49, Kashyap Chamarthy wrote: > >On Thu, Oct 15, 2015 at 10:30:21AM +0300, Denis V. Lunev wrote: > >>The following is done: > >>- QMP/HMP events are now logged > > > >I applied this patch series locally, and tried

Re: [Qemu-devel] [PATCH 2/6] qbool: Make conversion from QObject * accept null

On 10/15/2015 08:15 AM, Markus Armbruster wrote: > qobject_to_qbool() crashes on null, which is a trap for the unwary. > Return null instead, and simplify a few callers. > > Signed-off-by: Markus Armbruster > --- > qapi/qmp-input-visitor.c | 6 +++--- > qobject/qbool.c

[Qemu-devel] [PATCH 10/12] qga: handle possible SIGPIPE in guest-file-write

From: "Denis V. Lunev" qemu-ga should not exit on guest-file-write to pipe without read end but proper error code should be returned. The behavior of the spawned process should be default thus SIGPIPE processing should be reset to default after fork() but before exec().

Re: [Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

Thomas Huth writes: > The tcx_initfn() function is already supplied with an > Object *obj pointer, so there is no need to cast the > state pointer back to an Object pointer all over the > place. And while we're at it, also remove the superfluous > "return;" statement in this

[Qemu-devel] [PATCH 06/12] glib-compat: add 2.38/2.40/2.46 asserts

From: Marc-André Lureau Those are mostly useful for writing tests. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana Signed-off-by: Michael Roth ---

[Qemu-devel] [PATCH 4/7] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState

In preparation of turning monitor_qapi_event_state[] into a hash table for finer grained throttling. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- monitor.c | 80 ++- 1 file

[Qemu-devel] [PATCH 7/7] docs: Document QMP event rate limiting

Signed-off-by: Markus Armbruster --- docs/qmp-events.txt | 12 docs/qmp-spec.txt | 5 + 2 files changed, 17 insertions(+) diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt index d92cc48..d2f1ce4 100644 --- a/docs/qmp-events.txt +++

Re: [Qemu-devel] [PATCH v2 2/5] qdev: add the HotUnpluggable handler

On Thu, 15 Oct 2015 17:14:36 +0200 Cornelia Huck wrote: > On Mon, 12 Oct 2015 11:00:13 +0200 > Greg Kurz wrote: > > > This handler allows to ask a device instance if it can be hot-unplugged. It > > is to be defined in device classes where

Re: [Qemu-devel] [PATCH v2 06/22] block: Add "supports_stats" field to BlockStats

On Thu, Oct 15, 2015 at 03:06:19PM +0200, Alberto Garcia wrote: > On Tue 13 Oct 2015 05:38:30 PM CEST, Stefan Hajnoczi wrote: > > >> query-blockstats always returns a BlockDeviceStats structure for each > >> BDS, regardless of whether it implements accounting or not. Since the > >> field is

Re: [Qemu-devel] [PATCH] Revert "blockdev: add note that block_job_cb() must be thread-safe"

On Wed, Oct 14, 2015 at 10:51:27PM -0400, Fam Zheng wrote: > > > - Original Message - > > On Tue, Oct 13, 2015 at 06:16:15PM +0800, Fam Zheng wrote: > > > This reverts commit 723c5d93c51bdb3adbc238ce90195c0864aa6cd5. > > > > > > block_job_cb is called by block_job_completed, which is

Re: [Qemu-devel] [Qemu-block] [PATCH v10 08/10] Implement new driver for block replication

On Thu, Oct 15, 2015 at 10:19:17AM +0800, Wen Congyang wrote: > On 10/14/2015 10:27 PM, Stefan Hajnoczi wrote: > > On Tue, Oct 13, 2015 at 05:08:17PM +0800, Wen Congyang wrote: > >> On 10/13/2015 12:27 AM, Stefan Hajnoczi wrote: > >>> On Fri, Sep 25, 2015 at 02:17:36PM +0800, Wen Congyang wrote: >

Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function

On Wed, Oct 14, 2015 at 10:52:15PM +0800, Xiao Guangrong wrote: > On 10/14/2015 05:41 PM, Stefan Hajnoczi wrote: > >On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote: > >>+out->len = sizeof(out->status); > > > >out->len is uint16_t, it needs cpu_to_le16(). There may be other >

Re: [Qemu-devel] [PATCH v4] fw_cfg: insert string blobs via qemu cmdline

On 10/15/15 11:24, Gerd Hoffmann wrote: > On Mi, 2015-10-14 at 16:22 +0200, Laszlo Ersek wrote: >> Paolo, >> >> On 09/29/15 18:29, Gabriel L. Somlo wrote: >>> Allow users to provide custom fw_cfg blobs with ascii string >>> payloads specified directly on the qemu command line. >>> >>>

[Qemu-devel] [PATCH 02/12] qga: Use g_new() & friends where that makes obvious sense

From: Markus Armbruster g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches

[Qemu-devel] [PULL v2 00/12] qemu-ga patch queue

Hi Peter, Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical, but let me know if you'd prefer a re-send/re-base later. The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:

[Qemu-devel] [PATCH 09/12] qga: guest exec functionality

From: Yuri Pudgorodskiy Guest-exec rewritten in platform-independent style with glib spawn. Child process is spawn asynchronously and exit status can later be picked up by guest-exec-status command. stdin/stdout/stderr of the child now is redirected to /dev/null Later we

[Qemu-devel] [PATCH 5/7] monitor: Turn monitor_qapi_event_state[] into a hash table

In preparation of finer grained throttling. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- monitor.c | 55 ++- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/monitor.c

[Qemu-devel] [PATCH 08/12] qga: drop guest_file_init helper and replace it with static initializers

From: "Denis V. Lunev" This just makes code shorter and better. Signed-off-by: Denis V. Lunev Signed-off-by: Yuri Pudgorodskiy Reviewed-by: Michael Roth Signed-off-by: Denis V. Lunev

Re: [Qemu-devel] [PULL 1/3] Migration: Generate the completed event only when we complete

Am 15.10.2015 um 08:27 schrieb Juan Quintela: > From: "Dr. David Alan Gilbert" > > The current migration-completed event is generated a bit too early, > which means that an eager libvirt that's ready to go as soon > as it sees the event ends up racing with the actual end of

Re: [Qemu-devel] [PATCH 0/3] QEMU logging improvements

On 15.10.2015 17:49, Kashyap Chamarthy wrote: On Thu, Oct 15, 2015 at 10:30:21AM +0300, Denis V. Lunev wrote: The following is done: - QMP/HMP events are now logged I applied this patch series locally, and tried to test it the below way: Launch a minimal QEMU instance: $

[Qemu-devel] [PATCH 3/7] monitor: Switch from timer_new() to timer_new_ns()

We don't actually care for the scale, so we can just as well use the simpler interface. Signed-off-by: Markus Armbruster --- monitor.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index ca201fd..baffd76 100644 ---

[Qemu-devel] [PATCH] block: fix memory leak in early exit

The stream block job has two early exit code paths. They do not free s->backing_file_str. Also, the early exits rely on the fact that the coroutine hasn't yielded yet and was launched from the main thread. Therefore the coroutine is guaranteed to be running in the main thread where

[Qemu-devel] [PATCH 11/12] qga: handle G_IO_STATUS_AGAIN in ga_channel_write_all()

From: Yuri Pudgorodskiy glib may return G_IO_STATUS_AGAIN which is actually not an error. Also fixed a bug when on incomplete write buf pointer was not adjusted. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev

Re: [Qemu-devel] [PATCH 1/6] qobject: Drop QObject_HEAD

On 10/15/2015 08:15 AM, Markus Armbruster wrote: > QObject_HEAD is a macro expanding into the common part of structs that > are sub-types of QObject. It's always been just QObject base, and > unlikely to change. Drop the macro, because the code is clearer with > out it. > > Signed-off-by:

[Qemu-devel] [PATCH 01/12] build: qemu-ga: add 'qemu-ga' build target for w32

Currently POSIX builds rely on 'qemu-ga' target to do qga-only distributable build. On w32, as with most standalone binary targets, we rely on 'qemu-ga.exe' target. Unlike with POSIX, qemu-ga for w32 has a number of related targets such as VSS DLL and MSI package. We can do the full distributable

  1   2   >