[Qemu-devel] [PATCH 2/2] block: test 'blockdev-snapshot' using a file BDS as the overlay

Signed-off-by: Alberto Garcia --- tests/qemu-iotests/085 | 12 +++- tests/qemu-iotests/085.out | 4 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 index 9484117..ccde2ae 100755 ---

[Qemu-devel] [PATCH 0/2] Don't allow snapshots if the overlay has parent nodes

There are several sanity checks for the 'blockdev-snapshot' command, but none covers the use of a file BDS as the overlay node. { 'execute': 'blockdev-add', 'arguments': { 'options': { 'driver': 'qcow2', 'node-name': 'new0', 'file': {

[Qemu-devel] [PATCH 1/2] block: Don't allow snapshots if the overlay has parent nodes

This addresses scenarios where the overlay node of the 'blockdev-snapshot' parameter is a child of an existing node, such as this one: { 'execute': 'blockdev-add', 'arguments': { 'options': { 'driver': 'qcow2', 'node-name': 'new0', 'file': { 'driver':

[Qemu-devel] [PATCH 0/4] json-streamer: Fix up code to limit nesting and size

We limit nesting depth and input size to defend against input triggering excessive heap or stack memory use (commit 29c75dd json-streamer: limit the maximum recursion depth and maximum token count). This limiting is flawed in multiple ways. Fix it up some. Not yet fixed: this JSON parser is an

[Qemu-devel] [PATCH 4/4] json-streamer: Limit number of tokens in addition to total size

Commit 29c75dd "json-streamer: limit the maximum recursion depth and maximum token count" attempts to guard against excessive heap usage by limiting total token size (it says "token count", but that's a lie). Total token size is a rather imprecise predictor of heap usage: many small tokens use

[Qemu-devel] [PATCH 1/4] json-streamer: Apply nesting limit more sanely

The nesting limit from commit 29c75dd "json-streamer: limit the maximum recursion depth and maximum token count" applies separately to braces and brackets. This makes no sense. Apply it to their sum, because that's actually a measure of recursion depth. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH 2/4] json-streamer: Don't crash when input exceeds nesting limit

We limit nesting depth and input size to defend against input triggering excessive heap or stack memory use (commit 29c75dd json-streamer: limit the maximum recursion depth and maximum token count). However, when the nesting limit is exceeded, parser_context_peek_token()'s assertion fails.

Re: [Qemu-devel] [PULL v2 00/14] QMP and QObject patches

Eric Blake writes: > On 10/28/2015 09:07 AM, Peter Maydell wrote: > >>> glib: add compatibility interface for g_hash_table_add() >>> monitor: Turn monitor_qapi_event_state[] into a hash table > >> >> CCqga/commands-posix.o >> In file included from

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

Pavel Fedin wrote: > Hello! > >> Power people have a similar problem with its hashed page tables, they >> integrated their own save_live implementation because they are too big >> for the last stage. You can look there for inspiration. > > I examined their code.

Re: [Qemu-devel] [PATCH] vhost user: fix documentation of log atomic elements

After looking into linux driver code at hw/virtio/vhost.c, I see that the driver does what spec says. Thus spec the should remain as is, and QEMU need to be fixed on big-endian machines by changing the code in hw/virtio/vhost.c --Victor - Original Message - From: "Victor Kaplansky"

[Qemu-devel] [PATCH 3/4] check-qjson: Add test for JSON nesting depth limit

This would have prevented the regression mentioned in the previous commit. Signed-off-by: Markus Armbruster --- tests/check-qjson.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/check-qjson.c b/tests/check-qjson.c index

Re: [Qemu-devel] proposal: new qemu-arm mailing list

On 27 October 2015 at 10:15, Peter Maydell wrote: > Hi; it's been suggested to me that it would be helpful to have a > qemu-arm mailing list, along the lines of the existing qemu-ppc > and qemu-block lists. The idea would be to get people to cc the > list with their ARM

[Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root Complex as Integrated Endpoints remain PCI. Signed-off-by: Marcel Apfelbaum --- v2 -> v3: - Addressed

[Qemu-devel] [PATCH v2 1/1] qemu-iotests: fix cleanup of background processes

Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash subshell, in order to catch segfaults. Unfortunately, this means the process PID cannot be captured via '$!'. We stopped killing qemu and qemu-nbd processes, leaving a lot of orphaned, running qemu processes after executing

Re: [Qemu-devel] [PULL v2 11/14] glib: add compatibility interface for g_hash_table_add()

Markus Armbruster writes: > The next commit will use it. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > include/glib-compat.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/glib-compat.h

Re: [Qemu-devel] [PATCH v5 28/33] nvdimm acpi: support Get Namespace Label Size function

On Thu, Oct 29, 2015 at 10:16:14AM +0800, Xiao Guangrong wrote: > > > On 10/29/2015 12:41 AM, Stefan Hajnoczi wrote: > >On Wed, Oct 28, 2015 at 10:26:26PM +, Xiao Guangrong wrote: > >>+struct nvdimm_func_in_get_label_data { > >>+uint32_t offset; /* the offset in the namespace label data

Re: [Qemu-devel] [PATCH 28/34] block: Introduce bs->explicit_options

Am 15.05.2015 um 19:47 hat Max Reitz geschrieben: > 3) In bdrv_open(): > The QDict is just the one given to bdrv_open(). > > 3a) bdrv_open() call from bdrv_append_temp_snapshot(): > "file.driver" and "file.filename" are set, and these are the only > options in the whole QDict. Well... I'd argue

[Qemu-devel] [PATCH v2 0/1] qemu-iotests: fix cleanup of background processes

Changes from v1: * use 'read' instead of 'cat' (thanks Eric) * quote variable in variable test (thanks Eric) Jeff Cody (1): qemu-iotests: fix cleanup of background processes tests/qemu-iotests/common.config | 14 -- tests/qemu-iotests/common.qemu | 17 +++--

Re: [Qemu-devel] [PATCH v2] pc: memhp: enforce minimal 128Mb alignment for pc-dimm

On Tue, 27 Oct 2015 14:36:35 -0200 Eduardo Habkost wrote: > On Tue, Oct 27, 2015 at 10:14:56AM +0100, Igor Mammedov wrote: > > On Tue, 27 Oct 2015 10:53:08 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Oct 27, 2015 at 09:48:37AM +0100, Igor

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

Hello! > ok, your problem here is that you modify ram. Could you take a look at > how vhost manage this? It is done at migration_bitmap_sync(), and it > just marks the pages that are dirty. Hm, interesting... I see it hooks into memory_region_sync_dirty_bitmap(). Sorry for maybe lame

[Qemu-devel] [PATCH for-2.5] MAINTAINERS: Add new qemu-arm mailing list to ARM related entries

We now have a qemu-arm mailing list for ARM patches and discussion, so add an L: entry for it to the various ARM related entries in MAINTAINERS. Signed-off-by: Peter Maydell --- I basically just added an L: entry for everything that was vaguely ARM-ish...it's a shame

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Wed, Oct 28, 2015 at 09:59:32AM -0400, Programmingkid wrote: > > On Oct 28, 2015, at 6:58 AM, Stefan Hajnoczi wrote: > > > On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: > >>> So this change would make real-time audio feel laggy. > >> > >> That is secondary if the sound

[Qemu-devel] [PATCH v2] target-mips: add SIGRIE instruction

Add SIGRIE (Signal Reserved Instruction Exception) for both MIPS and microMIPS. The instruction allows to use the 16-bit code field for software use. This instruction is introduced by and required as of Release 6. Signed-off-by: Yongbok Kim --- target-mips/translate.c |

[Qemu-devel] [PATCH v3] target-mips: fix updating XContext on mmu exception

Correct updating XContext.Region field on mmu exceptions. If Config3.CTXTC = 0 then the R field of XContext has to be updated with the value of bits 63..62 of the virtual address upon a TLB exception. Also fixed the below line which overs 80 characters. Signed-off-by: Yongbok Kim

Re: [Qemu-devel] [PATCH 2/2] checkpatch: Eliminate false positive in case of space before square bracket in a definition

On 10/29/2015 03:48 AM, Leonid Bloch wrote: > Now, macro definition such as "#define abc(x) [x] = y" should pass > without an error. Do we even have macros like that? Without context, it seems like that macro definition is under-parenthesized, and that you wouldn't want to use abc(x) in an

Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error

Luiz Capitulino writes: > On Thu, 29 Oct 2015 12:15:09 +0100 > Markus Armbruster wrote: > >> Leak introduced in commit 8a4f501..710aec9, v2.4.0. >> >> Signed-off-by: Markus Armbruster > > Reviewed-by: Luiz Capitulino

Re: [Qemu-devel] [PATCH] configure: disallow ccache during compile tests

John Snow writes: > On 10/29/2015 02:17 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> If the user is using CCACHE during the configuration step, >>> it may interfere with some of the configuration tests, >>> particularly the "Is CCACHE interfering

[Qemu-devel] [PATCH v2 3/8] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table

Add power button device in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/arm/virt-acpi-build.c

Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error

On 10/29/2015 05:15 AM, Markus Armbruster wrote: > Leak introduced in commit 8a4f501..710aec9, v2.4.0. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake > > diff --git a/monitor.c

Re: [Qemu-devel] [PATCH v7 1/2] hw/ptimer: Fix issues caused by artificially limited timer timeout

29.10.2015 04:39, Peter Crosthwaite пишет: On Tue, Oct 27, 2015 at 2:26 PM, Dmitry Osipenko > wrote: 25.10.2015 20:39, Peter Crosthwaite пишет: On Sun, Oct 25, 2015 at 6:23 AM, Dmitry Osipenko

[Qemu-devel] [PULL v3 02/14] qbool: Make conversion from QObject * accept null

qobject_to_qbool() crashes on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-3-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz

[Qemu-devel] [PULL v3 08/14] monitor: Simplify event throttling

The event throttling state machine is hard to understand. I'm not sure it's entirely correct. Rewrite it in a more straightforward manner: State 1: No event sent recently (less than evconf->rate ns ago) Invariant: evstate->timer is not pending, evstate->qdict is null On event: send

[Qemu-devel] [PATCH v2 7/8] hw/arm/virt: Add QEMU powerdown notifier and hook it to GPIO Pin 3

Currently mach-virt model doesn't support powerdown request. Guest VM doesn't react to system_powerdown from monitor console (or QMP) because there is no communication mechanism for such requests. This patch registers GPIO Pin 3 with powerdown notification. So guest VM can receive notification

[Qemu-devel] [PULL v3 05/14] qlist: Make conversion from QObject * accept null

qobject_to_qlist() crashes on null, which is a trap for the unwary. Return null instead. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-6-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino

[Qemu-devel] [PULL v3 10/14] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState

In preparation of turning monitor_qapi_event_state[] into a hash table for finer grained throttling. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1444921716-9511-5-git-send-email-arm...@redhat.com> --- monitor.c | 80

[Qemu-devel] [PULL v3 13/14] monitor: Throttle event VSERPORT_CHANGE separately by "id"

VSERPORT_CHANGE is emitted when the guest opens or closes a virtio-serial port. The event's member "id" identifies the port. When several events arrive quickly, throttling drops all but the last of them. Because of that, a QMP client must assume that *any* port may have changed state when it

[Qemu-devel] [PULL v3 14/14] docs: Document QMP event rate limiting

Signed-off-by: Markus Armbruster Message-Id: <1444921716-9511-8-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- docs/qmp-events.txt | 12 docs/qmp-spec.txt | 5 + 2 files changed, 17 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 1/2] iotests: Do not suppress segfaults in bash tests

Am 31.08.2015 um 21:05 hat Max Reitz geschrieben: > Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a > segmentation fault, that message is invisible in most cases since the > output is generally filtered and bash suppresses the segmentation fault > notice for any but the last

[Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Add GICC ACPI subtable for GICv3

When booting VM with GICv3, the kernel needs GICC ACPI subtable to initialize the CPUs, e.g. MPIDR information. This adds GICC ACPI subtable for GICv3, but set GICC base address only when gic_version == 2 since it donesn't need GICC base address for GICv3. Signed-off-by: Shannon Zhao

[Qemu-devel] [PATCH v2 0/4] ui audio qxl usb: Use g_new() & friends where that makes obvious sense

v2: * Trivially rebased Markus Armbruster (4): ui: Use g_new() & friends where that makes obvious sense audio: Use g_new() & friends where that makes obvious sense qxl: Use g_new() & friends where that makes obvious sense usb: Use g_new() & friends where that makes obvious sense

Re: [Qemu-devel] [PATCH] vfio: Use g_new() & friends where that makes obvious sense

On Thu, 2015-10-29 at 16:46 +0100, Markus Armbruster wrote: > g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, > for two reasons. One, it catches multiplication overflowing size_t. > Two, it returns T * rather than void *, which lets the compiler catch > more type errors. >

[Qemu-devel] [PATCH v2 1/4] ui: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

[Qemu-devel] [PATCH v2 4/8] hw/acpi/aml-build: Add GPIO Connection Descriptor

Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 61 + include/hw/acpi/aml-build.h | 20 +++ 2 files changed, 81 insertions(+) diff --git

[Qemu-devel] [PATCH v2 0/8] Add system_powerdown support on ARM for ACPI and DT

ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced platforms(like ARM). It uses GPIO pin to trigger an event to the guest. For QEMU, here we add PL061 GPIO controller and use PIN 3 for system_powerdown, reserving PIN 0, 1, 2 for PCI hotplug, CPU hotplug and memory hotplug. This

[Qemu-devel] [PATCH v2 1/8] hw/arm/virt: Add a GPIO controller

ACPI 5.0 supports GPIO-signaled ACPI Events. This can be used for powerdown, hotplug evnets. Add a GPIO controller in machine virt, to support powerdown, maybe can be used for cpu hotplug. And here we use pl061. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao

[Qemu-devel] [PULL v3 01/14] qobject: Drop QObject_HEAD

QObject_HEAD is a macro expanding into the common part of structs that are sub-types of QObject. It's always been just QObject base, and unlikely to change. Drop the macro, because the code is clearer with out it. Signed-off-by: Markus Armbruster Message-Id:

Re: [Qemu-devel] [PATCH for-2.5 2/2] target-arm: Report S/NS status in the CPU debug logs

Peter Maydell writes: > If this CPU supports EL3, enhance the printing of the current > CPU mode in debug logging to distinguish S from NS modes as > appropriate. > > Signed-off-by: Peter Maydell > --- > target-arm/translate-a64.c | 11

Re: [Qemu-devel] [PATCH 2/2] trace: add make dependencies on tracetool source

Stefan Hajnoczi writes: > Patches that change tracetool can break the build if old build output > files are lying around. > This happens because the Makefile does not specify dependencies on > tracetool. The build will use old object files that do not match the > current source code. >

Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error

On Thu, 29 Oct 2015 12:15:09 +0100 Markus Armbruster wrote: > Leak introduced in commit 8a4f501..710aec9, v2.4.0. > > Signed-off-by: Markus Armbruster Reviewed-by: Luiz Capitulino I think this can go through your tree? > --- >

Re: [Qemu-devel] [PATCH for-2.5 2/2] target-arm: Report S/NS status in the CPU debug logs

On 29 October 2015 at 15:15, Alex Bennée wrote: > > Peter Maydell writes: > >> If this CPU supports EL3, enhance the printing of the current >> CPU mode in debug logging to distinguish S from NS modes as >> appropriate. >> >> Signed-off-by: Peter

Re: [Qemu-devel] [PATCH] configure: disallow ccache during compile tests

On 10/29/2015 02:17 AM, Markus Armbruster wrote: > John Snow writes: > >> If the user is using CCACHE during the configuration step, >> it may interfere with some of the configuration tests, >> particularly the "Is CCACHE interfering with macro analysis" step, >> which is a

Re: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect

On Oct 29, 2015, at 11:08 AM, Stefan Hajnoczi wrote: > On Wed, Oct 28, 2015 at 09:59:32AM -0400, Programmingkid wrote: >> >> On Oct 28, 2015, at 6:58 AM, Stefan Hajnoczi wrote: >> >>> On Mon, Oct 26, 2015 at 01:24:00PM +0100, Gerd Hoffmann wrote: > So this change would make real-time audio

[Qemu-devel] [PULL v3 09/14] monitor: Switch from timer_new() to timer_new_ns()

We don't actually care for the scale, so we can just as well use the simpler interface. Signed-off-by: Markus Armbruster Message-Id: <1444921716-9511-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- monitor.c | 7 +++ 1 file changed, 3

[Qemu-devel] [PATCH v2 8/8] hw/arm/virt: Add gpio-keys node for Poweroff using DT

Add a gpio-keys node. This is used for Poweroff for the systems which use DT not ACPI. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/virt.c

[Qemu-devel] [PATCH v2 5/8] hw/acpi/aml-build: Add a wrapper for GPIO Interrupt Connection

Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 18 ++ include/hw/acpi/aml-build.h | 6 ++ 2 files changed, 24 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c

Re: [Qemu-devel] [PATCH 1/4] json-streamer: Apply nesting limit more sanely

On 10/29/2015 06:44 AM, Markus Armbruster wrote: > The nesting limit from commit 29c75dd "json-streamer: limit the > maximum recursion depth and maximum token count" applies separately to > braces and brackets. This makes no sense. Apply it to their sum, > because that's actually a measure of

[Qemu-devel] [PULL v3 12/14] monitor: Turn monitor_qapi_event_state[] into a hash table

In preparation of finer grained throttling. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1444921716-9511-6-git-send-email-arm...@redhat.com> --- monitor.c | 55 ++- 1 file

[Qemu-devel] [PULL v3 07/14] monitor: Reduce casting of QAPI event QDict

Make the variables holding the event QDict instead of QObject. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1444921716-9511-2-git-send-email-arm...@redhat.com> --- monitor.c | 38 +++--- 1 file

[Qemu-devel] [PULL v3 11/14] glib: add compatibility interface for g_hash_table_add()

The next commit will use it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/glib-compat.h | 8 1 file changed, 8 insertions(+) diff --git a/include/glib-compat.h b/include/glib-compat.h index fb25f43..e75dd96 100644 ---

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

Pavel Fedin wrote: > Hello! > >> ok, your problem here is that you modify ram. Could you take a look at >> how vhost manage this? It is done at migration_bitmap_sync(), and it >> just marks the pages that are dirty. > > Hm, interesting... I see it hooks into >

Re: [Qemu-devel] proposal: new qemu-arm mailing list

Andrew Jones writes: > On Tue, Oct 27, 2015 at 10:15:32AM +, Peter Maydell wrote: >> Hi; it's been suggested to me that it would be helpful to have a >> qemu-arm mailing list, along the lines of the existing qemu-ppc >> and qemu-block lists. The idea would be to get

[Qemu-devel] [PATCH v2] target-mips: fix updating XContext on mmu exception

Correct updating XContext.Region field on mmu exceptions. If Config3.CTXTC = 0 then the R field of XContext has to be updated with the value of bits 63..62 of the virtual address upon a TLB exception. Also fixed the below line which overs 80 characters. Signed-off-by: Yongbok Kim

Re: [Qemu-devel] [PATCH 1/2] trace: fix make foo-timestamp rules

Stefan Hajnoczi writes: > The Makefile uses intermediate timestamp files to avoid rebuilding if > tracetool output is unchanged. > Timestamps are implemented incorrectly. This was fixed for rules.mak in > commit 4b25966ab976f3a7fd9008193b2defcc82f8f04d ("rules.mak: cleanup > config generation

Re: [Qemu-devel] [PATCH for-2.5 v2 3/4] mips: add Global Interrupt Controller

On 27/10/15 17:12, Yongbok Kim wrote: > +static uint64_t gic_read(void *opaque, hwaddr addr, unsigned size) > +{ > +MIPSGICState *gic = (MIPSGICState *) opaque; > +uint32_t vp_index = gic_get_current_vp(gic); > +uint64_t ret = 0; > +int i, base, irq_src; > +uint32_t

Re: [Qemu-devel] [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On 10/29/2015 01:33 AM, Lan Tianyu wrote: On 2015年10月29日 14:58, Alexander Duyck wrote: Your code was having to do a bunch of shuffling in order to get things set up so that you could bring the interface back up. I would argue that it may actually be faster at least on the bring-up to just drop

[Qemu-devel] [PULL v3 06/14] qstring: Make conversion from QObject * accept null

qobject_to_qstring() crashes on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-7-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by:

[Qemu-devel] [PATCH] vfio: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

Re: [Qemu-devel] [PATCH 01/11] trace: fix documentation

Am 28.10.2015 um 16:15 schrieb Denis V. Lunev: > On 10/26/2015 11:05 PM, Christian Borntraeger wrote: >> Am 26.10.2015 um 18:10 schrieb Denis V. Lunev: >>> From: Paolo Bonzini >>> >>> Mention the ftrace backend too. >>> >>> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL v3 04/14] qfloat qint: Make conversion from QObject * accept null

qobject_to_qfloat() and qobject_to_qint() crash on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-5-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v2 6/8] hw/arm/virt-acpi-build: Add _E03 for Power Button

Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 13 + 1 file changed, 13 insertions(+) diff --git

[Qemu-devel] [PULL v3 03/14] qdict: Make conversion from QObject * accept null

qobject_to_qdict() crashes on null, which is a trap for the unwary. Return null instead, and simplify a few callers. Signed-off-by: Markus Armbruster Message-Id: <1444918537-18107-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Luiz

[Qemu-devel] [PULL v3 00/14] QMP and QObject patches

The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-29 09:49:52 +) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-29 for you

Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

On Wed, 21 Oct 2015 21:32:38 +0800 Xiao Guangrong wrote: > > > On 10/21/2015 06:49 PM, Stefan Hajnoczi wrote: > > On Wed, Oct 21, 2015 at 12:26:35AM +0800, Xiao Guangrong wrote: > >> > >> > >> On 10/20/2015 11:51 PM, Stefan Hajnoczi wrote: > >>> On Mon, Oct 19,

Re: [Qemu-devel] [PATCH for-2.5 1/2] target-arm: Bring AArch64 debug CPU display of PSTATE into line with AArch32

Peter Maydell writes: > The AArch64 debug CPU display of PSTATE as "PSTATE=23c5 (flags --C-)" > on the end of the same line as the last of the general purpose registers > is unnecessarily different from the AArch32 display of PSR as > "PSR=21d3 --C- A svc32" on

Re: [Qemu-devel] arm mptimer implementation - why prescaler is multiply by 10?

29.10.2015 10:00, Krzeminski, Marcin (Nokia - PL/Wroclaw) пишет: *From:*EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] *Sent:* Tuesday, October 27, 2015 7:23 PM *To:* Peter Maydell *Cc:* Dmitry Osipenko ; Krzeminski, Marcin (Nokia -

[Qemu-devel] [PATCH v2 4/4] usb: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

[Qemu-devel] [PATCH v2 2/4] audio: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

[Qemu-devel] [PATCH v2 2/8] hw/arm/virt-acpi-build: Add GPIO controller in ACPI DSDT table

Add GPIO controller in ACPI DSDT table. It can be used for gpio event. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[Qemu-devel] [PATCH v2] target-mips: add PC, XNP reg numbers to RDHWR

Add Performance Counter (4) and XNP (5) register numbers to RDHWR. Add check_hwrena() to simplify access control checkings. Add RDHWR support to microMIPS R6. Signed-off-by: Yongbok Kim --- target-mips/cpu.h |1 + target-mips/helper.h|2 +

Re: [Qemu-devel] [PATCH V5 2/8] introduce aux-bus

On 18/10/2015 19:17, Peter Crosthwaite wrote: > On Fri, Oct 16, 2015 at 6:41 AM, wrote: >> From: KONRAD Frederic >> >> This introduces a new bus: aux-bus. >> >> It contains an address space for aux slaves devices and a bridge to an I2C >>

[Qemu-devel] [PATCH v2 3/4] qxl: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form

Re: [Qemu-devel] [PATCH 01/11] trace: fix documentation

On Wed, Oct 28, 2015 at 06:15:05PM +0300, Denis V. Lunev wrote: > On 10/26/2015 11:05 PM, Christian Borntraeger wrote: > >Am 26.10.2015 um 18:10 schrieb Denis V. Lunev: > >>From: Paolo Bonzini > >> > >>Mention the ftrace backend too. > >> > >>Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3] target-mips: fix updating XContext on mmu exception

> +/* BadVPN2 */ (extract64(address, 13, env->SEGBITS - 14) << 4); it has to be env->SEGBITS - 13. I will resend this patch. Regards, Yongbok

Re: [Qemu-devel] [PATCH v2 00/11] simplify usage of tracepoints, and connect them to logging

On Mon, Oct 26, 2015 at 12:10:17PM +0300, Denis V. Lunev wrote: > This series does three things: > > 1) add a "-trace [enable=]foo" option to enable one or more trace > events, and a "-trace help" option to show the list of tracepoints > (patches 4-5) > > 2) change the stderr tracing backend so

Re: [Qemu-devel] [PATCH v2 01/16] vl.c: Replace fprintf(stderr) with error_report()

On Thu, Oct 29, 2015 at 06:34:48PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Replace most fprintf(stderr) calls on vl.c with error_report(). > > > > Minimal changes were made in the error messages. Only the trailing > > newlines, "qemu:" and "error:"

Re: [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends

On 10/29/2015 08:23 PM, Stefan Hajnoczi wrote: On Mon, Oct 26, 2015 at 12:10:20PM +0300, Denis V. Lunev wrote: From: Paolo Bonzini This is cleaner, and improves error reporting with -daemonize. Signed-off-by: Paolo Bonzini Signed-off-by: Denis V.

[Qemu-devel] [PULL 12/12] block: Consider all child nodes in bdrv_requests_pending()

From: Kevin Wolf The function manually recursed into bs->file and bs->backing to check whether there were any requests pending, but it ignored other children. There's no need to special case file and backing here, so just replace these two explicit recursions by a loop

[Qemu-devel] [PULL 03/12] qemu-gdb: add $qemu_coroutine_sp and $qemu_coroutine_pc

From: Paolo Bonzini These can be useful to manually get a stack trace of a coroutine inside a core dump. Signed-off-by: Paolo Bonzini Message-id: 1444636974-19950-4-git-send-email-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 08/12] virtio: sync the dataplane vring state to the virtqueue before virtio_save

From: Pavel Butsykin When creating snapshot with the dataplane enabled, the snapshot file gets not the actual state of virtqueue, because the current state is stored in VirtIOBlockDataPlane. Therefore, before saving snapshot need to sync the dataplane vring state to the

Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/2] aio: Use epoll in aio_poll()

On Mon, Oct 26, 2015 at 02:39:40PM +0800, Fam Zheng wrote: > v3: Remove the redundant check in aio_epoll_try_enable. [Stefan] > > v2: Merge aio-epoll.c into aio-posix.c. [Paolo] > Capture some benchmark data in commit log. > > This series adds the ability to use epoll in aio_poll() on Linux.

[Qemu-devel] [PATCH v4] target-mips: fix updating XContext on mmu exception

Correct updating XContext.Region field on mmu exceptions. If Config3.CTXTC = 0 then the R field of XContext has to be updated with the value of bits 63..62 of the virtual address upon a TLB exception. Also fixed the below line which overs 80 characters. Signed-off-by: Yongbok Kim

Re: [Qemu-devel] [PATCH v2 10/16] vl.c: Convert error sentences to simpler phrases

Eduardo Habkost writes: > Simplify some error messages by making them simple phrases instead of > full sentences. > > Suggested-by: Andrew Jones > Signed-off-by: Eduardo Habkost > --- > vl.c | 14 +++--- > 1 file changed, 7

Re: [Qemu-devel] [PATCH 3/4] check-qjson: Add test for JSON nesting depth limit

On 10/29/2015 06:44 AM, Markus Armbruster wrote: > This would have prevented the regression mentioned in the previous > commit. > > Signed-off-by: Markus Armbruster > --- > tests/check-qjson.c | 29 + > 1 file changed, 29 insertions(+) Better late

Re: [Qemu-devel] [PATCH v3 0/2] aio: Use epoll in aio_poll()

On Mon, Oct 26, 2015 at 02:39:40PM +0800, Fam Zheng wrote: > v3: Remove the redundant check in aio_epoll_try_enable. [Stefan] > > v2: Merge aio-epoll.c into aio-posix.c. [Paolo] > Capture some benchmark data in commit log. > > This series adds the ability to use epoll in aio_poll() on Linux.

Re: [Qemu-devel] [PATCH v3 4/5] xlnx-zynqmp: Connect the SPI devices

On Thu, Oct 29, 2015 at 1:27 AM, Frederic Konrad wrote: > On 29/10/2015 03:00, Peter Crosthwaite wrote: >> On Wed, Oct 28, 2015 at 10:32 AM, Alistair Francis < >> alistair.fran...@xilinx.com> wrote: >> >>> Connect the Xilinx SPI device to the ZynqMP model. >>> >>> >>

Re: [Qemu-devel] [RFC 0/4] AHCI patches + Allwinner SATA

On Mon, Oct 26, 2015 at 8:25 AM, John Snow wrote: > > > On 10/11/2015 12:21 PM, Peter Crosthwaite wrote: >> Hi John and Beniamino, >> >> This patch series adds bear-minimum Allwinner SATA support. >> >> P1 is a trivial to help debug AHCI. >> >> Regards, >> Peter >> >> Peter

Re: [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends

On Mon, Oct 26, 2015 at 12:10:20PM +0300, Denis V. Lunev wrote: > From: Paolo Bonzini > > This is cleaner, and improves error reporting with -daemonize. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Denis V. Lunev > Reviewed-by:

[Qemu-devel] [PULL 07/12] gdb command: qemu handlers

From: "Dr. David Alan Gilbert" A new gdb commands are added: qemu handlers That dumps an AioContext list (by default qemu_aio_context) possibly including a backtrace for cases it knows about (with the verbose option). Intended to help find why something

Re: [Qemu-devel] [PATCH v3 4/5] xlnx-zynqmp: Connect the SPI devices

On Thu, Oct 29, 2015 at 10:45 AM, Alistair Francis wrote: > On Thu, Oct 29, 2015 at 1:27 AM, Frederic Konrad > wrote: >> On 29/10/2015 03:00, Peter Crosthwaite wrote: >>> On Wed, Oct 28, 2015 at 10:32 AM, Alistair Francis < >>>

Re: [Qemu-devel] [PATCH v3 2/5] ssi: Move ssi.h into a separate directory

On Wed, Oct 28, 2015 at 6:44 PM, Peter Crosthwaite wrote: > > > On Wed, Oct 28, 2015 at 10:32 AM, Alistair Francis > wrote: >> >> Move the ssi.h include file into the ssi directory. >> > > Needs a note about the typedef changes. You can

  1   2   3   >