Re: [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name

On 11/05/2015 10:55 AM, Greg Kurz wrote: On Wed, 4 Nov 2015 20:19:33 +0300 "Denis V. Lunev" wrote: this will make code better in the next patch This changelog is not very useful. IMHO this calls for squashing this patch into the next one: then we clearly see how the return

Re: [Qemu-devel] [PULL 00/14] Misc changes for QEMU 2.4-rc1

On 5 November 2015 at 04:58, Fam Zheng wrote: > On Wed, 11/04 16:34, Peter Maydell wrote: >> On 4 November 2015 at 16:18, Paolo Bonzini wrote: >> > The following changes since commit >> > 7bc8e0c967a4ef77657174d28af775691e18b4ce: >> > >> > Merge

Re: [Qemu-devel] [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

On 11/05/15 09:05, Christian Borntraeger wrote: > Am 02.11.2015 um 10:40 schrieb James Hogan: > > On Mon, Nov 02, 2015 at 05:26:42PM +0800, Haozhong Zhang wrote: > >> The value of the migrated vcpu's TSC rate is determined as below. > >> 1. If a TSC rate is specified by the cpu option 'tsc-freq',

[Qemu-devel] [PATCH] vnc: fix mismerge

Commit "4d77b1f vnc: fix bug: vnc server can't start when 'to' is specified" was rebased incorrectly, fix it. Reported-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c

Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix

On 05/11/2015 00:36, Mark Cave-Ayland wrote: > On 04/11/15 11:05, Richard Henderson wrote: > >> On 11/04/2015 11:45 AM, Paolo Bonzini wrote: >int32_t src = rs2 >> (word * 32); > -int64_t scaled = src << scale; > +int64_t scaled = (int64_t)src

Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix

On 05/11/2015 10:28, Richard Henderson wrote: > On 11/05/2015 10:25 AM, Paolo Bonzini wrote: >> >> >> On 05/11/2015 10:20, Richard Henderson wrote: >>> /* Ugly code */ int64_t scaled = (uint64_t)(int64_t)src << scale; >>> >>> You mean >>> >>>int64_t scaled =

Re: [Qemu-devel] [PATCH v7 3/8] mirror: Do zero write on target if sectors not allocated

Am 05.11.2015 um 06:42 hat Fam Zheng geschrieben: > On Wed, 11/04 19:35, Kevin Wolf wrote: > > Am 08.06.2015 um 07:56 hat Fam Zheng geschrieben: > > > If guest discards a source cluster, mirroring with bdrv_aio_readv is > > > overkill. > > > Some protocols do zero upon discard, where it's best to

Re: [Qemu-devel] [PATCH 01/11] snapshot: create helper to test that block drivers supports snapshots

On 11/05/2015 09:26 AM, Greg Kurz wrote: On Wed, 4 Nov 2015 20:19:32 +0300 "Denis V. Lunev" wrote: The patch enforces proper locking for this operation. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v9 19/27] qapi: Check for qapi collisions of flat union branches

Eric Blake writes: > On 11/04/2015 04:11 PM, Eric Blake wrote: >> On 11/04/2015 12:01 PM, Markus Armbruster wrote: >>> Eric Blake writes: >>> Right now, our ad hoc parser ensures that we cannot have a flat union that introduces any qapi member

Re: [Qemu-devel] [PULL 6/6] vnc: fix bug: vnc server can't start when 'to' is specified

Gerd Hoffmann writes: > From: Yang Hongyang > > commit e0d03b8ceb52 converted VNC startup to use SocketAddress, > the interface socket_listen don't have a port_offset param, so > we need to add the port offset (5900) to both 'port' and 'to' opts. >

Re: [Qemu-devel] Should 'qemu-img commit' sparsify the backing file?

On Thu, Nov 05, 2015 at 03:14:49PM +0800, Fam Zheng wrote: > I don't think this the purpose of "qemu-img commit". Committing > "new" data in overlay.qcow2 has little to do with discarding backing > image's fragments where there are only explict zeroes. In that case, why didn't this step sparsify

Re: [Qemu-devel] [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On Mon, 2 Nov 2015 17:13:27 +0800 Xiao Guangrong wrote: > A page staring from 0xFF0 and IO port 0x0a18 - 0xa1b in guest are ^^ missing one 0??? > reserved for NVDIMM ACPI emulation, refer to docs/specs/acpi_nvdimm.txt > for

Re: [Qemu-devel] [PATCH 3/3] usb-mtp: add support for basic mtp events

On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: > -.wMaxPacketSize= 8, > +.wMaxPacketSize= 64, This is a guest-visible change, so strictly speaking this needs be tied to the machine type. I think we can be a bit sloppy here though as usb-mtp does not

Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region

On 03.11.2015 17:47, Xiao Guangrong wrote: On 11/03/2015 12:16 AM, Vladimir Sementsov-Ogievskiy wrote: On 02.11.2015 18:06, Xiao Guangrong wrote: On 11/02/2015 10:26 PM, Vladimir Sementsov-Ogievskiy wrote: On 02.11.2015 16:08, Xiao Guangrong wrote: On 11/02/2015 08:19 PM, Vladimir

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

On 11/05/2015 03:43 PM, zhanghailiang wrote: > Hi Jason, > > On 2015/11/4 10:56, Jason Wang wrote: >> >> >> On 11/03/2015 07:56 PM, zhanghailiang wrote: >>> Signed-off-by: zhanghailiang >>> Cc: Jason Wang >> >> Commit log please. >> >>> ---

Re: [Qemu-devel] [PATCH 04/11] snapshot: create bdrv_all_goto_snapshot helper

On Wed, 4 Nov 2015 20:19:35 +0300 "Denis V. Lunev" wrote: > to switch to snapshot on all loaded block drivers. > > The patch also ensures proper locking. > > Signed-off-by: Denis V. Lunev > CC: Juan Quintela > CC: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

On 11/05/2015 03:43 PM, zhanghailiang wrote: > Hi Jason, > > On 2015/11/4 10:56, Jason Wang wrote: >> >> >> On 11/03/2015 07:56 PM, zhanghailiang wrote: >>> Signed-off-by: zhanghailiang >>> Cc: Jason Wang >> >> Commit log please. >> >>> ---

Re: [Qemu-devel] [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

Am 02.11.2015 um 10:40 schrieb James Hogan: > On Mon, Nov 02, 2015 at 05:26:42PM +0800, Haozhong Zhang wrote: >> The value of the migrated vcpu's TSC rate is determined as below. >> 1. If a TSC rate is specified by the cpu option 'tsc-freq', then this >> user-specified value will be used. >>

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

On 11/05/2015 04:52 PM, Wen Congyang wrote: > On 11/05/2015 03:43 PM, zhanghailiang wrote: >> > Hi Jason, >> > >> > On 2015/11/4 10:56, Jason Wang wrote: >>> >> >>> >> >>> >> On 11/03/2015 07:56 PM, zhanghailiang wrote: >>> Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix

On 11/05/2015 10:25 AM, Paolo Bonzini wrote: On 05/11/2015 10:20, Richard Henderson wrote: /* Ugly code */ int64_t scaled = (uint64_t)(int64_t)src << scale; You mean int64_t scaled = (int64_t)((uint64_t)src << scale); No, that also looks like a typo. I mean: -

[Qemu-devel] [PATCH 2/2] net: netmap: use error_setg_errno() in place of error_report()

This update was required to align netmap backend to the other net backends in terms of error reporting. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/net/netmap.c b/net/netmap.c index

[Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

Reorganization of struct NetClientOptions caused a compilation failure of the netmap backend. This patch fixes the issue by properly accessing the union field. Signed-off-by: Vincenzo Maffione --- net/netmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH] vnc: fix mismerge

Gerd Hoffmann writes: > Commit "4d77b1f vnc: fix bug: vnc server can't start when 'to' is > specified" was rebased incorrectly, fix it. > > Reported-by: Markus Armbruster > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 2 -- > 1 file

Re: [Qemu-devel] [PATCH 1/3] usb-mtp: use a list for keeping track of children

> static void usb_mtp_object_free(MTPState *s, MTPObject *o) > { > -int i; > +MTPObject *iter; > + > +if (o) { > +trace_usb_mtp_object_free(s->dev.addr, o->handle, o->path); That also makes usb_mtp_object_free callable with o == NULL. Makes sense, but also makes this patch

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

> +#include What happens on non-linux systems? I guess we need some #ifdefs to not break the build there, or enable mtp only for CONFIG_LINUX=y instead of CONFIG_POSIX=y. > +enum inotify_event_type { > +CREATE = 1, > +DELETE = 2, > +MODIFY = 3, > +}; Patch #3 removes this, I'd

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: > +/* Add a new watch asap so as to not lose events > */ This comment sounds like there is a race ("asap"). There isn't one, correct ordering (adding the watch before reading the directory) is enough to make sure you don't

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: > +case IN_DELETE: > +/* > + * The kernel issues a IN_IGNORED event > + * when a dir containing a watchpoint is > + * deleted > + */ Wrong place for the

Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix

On 04/11/2015 18:53, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 04/11/2015 15:07, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> On 04/11/2015 12:05, Richard Henderson wrote: > On 11/04/2015 11:45 AM, Paolo Bonzini

Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix

On 11/05/2015 10:12 AM, Paolo Bonzini wrote: /* Ugly code */ int64_t scaled = (uint64_t)(int64_t)src << scale; You mean int64_t scaled = (int64_t)((uint64_t)src << scale); r~

Re: [Qemu-devel] [PATCH] target-sparc: fix 32-bit truncation in fpackfix

On 05/11/2015 10:20, Richard Henderson wrote: > >> /* Ugly code */ >> int64_t scaled = (uint64_t)(int64_t)src << scale; > > You mean > > int64_t scaled = (int64_t)((uint64_t)src << scale); No, that also looks like a typo. I mean: - unnecessary cast to int64_t to get the sign

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

On 11/05/2015 05:21 PM, Jason Wang wrote: > > > On 11/05/2015 04:52 PM, Wen Congyang wrote: >> On 11/05/2015 03:43 PM, zhanghailiang wrote: Hi Jason, On 2015/11/4 10:56, Jason Wang wrote: >> >> >> On 11/03/2015 07:56 PM, zhanghailiang wrote: Signed-off-by:

[Qemu-devel] [PATCH 0/2] Fix compilation of netmap backend

This patch series adds some fixes to the netmap net backend. It contains two changes: (1) Fix compilation issue of netmap.c introduced by the reorganization of struct NetClientOptions (2) Address the FIXME comment that was asking to use error_setg() in place of

Re: [Qemu-devel] Should 'qemu-img commit' sparsify the backing file?

On Thu, 11/05 08:56, Richard W.M. Jones wrote: > On Thu, Nov 05, 2015 at 03:14:49PM +0800, Fam Zheng wrote: > > I don't think this the purpose of "qemu-img commit". Committing > > "new" data in overlay.qcow2 has little to do with discarding backing > > image's fragments where there are only

[Qemu-devel] [PULL 16/16] iscsi: Translate scsi sense into error code

From: Fam Zheng Previously we return -EIO blindly when anything goes wrong. Add a helper function to parse sense fields and try to make the return code more meaningful. This also fixes the default werror configuration (enospc) when we're using qcow2 on an iscsi lun. The old

[Qemu-devel] [PULL v3 00/16] Misc changes for 2.5-rc1

The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-29 09:49:52 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next

On 5 November 2015 at 14:01, Paolo Bonzini wrote: > On 05/11/2015 14:44, Peter Maydell wrote: >> We used to have 3 month releases, but I think we found that these >> were too short: If you have about a month hardfreeze and a month >> softfreeze then you only have a month of

[Qemu-devel] [PATCH v5 0/6] fw_cfg: spec update, misc. cleanup, optimize read

New since v4: - Patch 5: Protect against (undefined) left-shifting a uint64_t by 64 bits - Patches 4 & 5: Reworked comment and commit blurb wording Laszlo, thanks again for the thorough review (and the "C master class") :) Regards, --Gabriel >New since v3: > >

[Qemu-devel] [PATCH v5 6/6] fw_cfg: replace ioport data read with generic method

IOPort read access is limited to one byte at a time by fw_cfg_comb_valid(). As such, fw_cfg_comb_read() may safely ignore its size argument (which will always be 1), and simply call its fw_cfg_read() helper function once, returning 8 bits via the least significant byte of a 64-bit return value.

[Qemu-devel] [PATCH v5 2/6] fw_cfg: amend callback behavior spec to once per select

Currently, the fw_cfg internal API specifies that if an item was set up with a read callback, the callback must be run each time a byte is read from the item. This behavior is both wasteful (most items do not have a read callback set), and impractical for bulk transfers (e.g., DMA read). At the

[Qemu-devel] [PATCH v5 4/6] fw_cfg: avoid calculating invalid current entry pointer

When calculating a pointer to the currently selected fw_cfg item, the following is used: FWCfgEntry *e = >entries[arch][s->cur_entry & FW_CFG_ENTRY_MASK]; When s->cur_entry is FW_CFG_INVALID, we are calculating the address of a non-existent element in s->entries[arch][...], which is undefined.

[Qemu-devel] [PATCH v5 3/6] fw_cfg: remove offset argument from callback prototype

Read callbacks are now only invoked at item selection, before any data is read. As such, the value of the offset argument passed to the callback will always be 0. Also, the two callback instances currently in use both leave their offset argument unused. This patch removes the offset argument from

[Qemu-devel] [PATCH v5 5/6] fw_cfg: add generic non-DMA read method

Introduce fw_cfg_data_read(), a generic read method which works on all access widths (1 through 8 bytes, inclusive), and can be used during both IOPort and MMIO read accesses. To maintain legibility, only fw_cfg_data_mem_read() (the MMIO data read method) is replaced by this patch. The new method

[Qemu-devel] [PATCH v5 1/6] fw_cfg: move internal function call docs to header file

Move documentation for fw_cfg functions internal to qemufrom docs/specs/fw_cfg.txt to the fw_cfg.h header file, next to their prototype declarations, formatted as doc-comments. NOTE: Documentation for fw_cfg_add_callback() is completely dropped by this patch, as that function has been eliminated

Re: [Qemu-devel] [PATCH v4 5/6] fw_cfg: add generic non-DMA read method

On 11/04/15 17:35, Gabriel L. Somlo wrote: > On Wed, Nov 04, 2015 at 04:04:09PM +0100, Laszlo Ersek wrote: >> On 11/03/15 22:40, Gabriel L. Somlo wrote: >>> Introduce fw_cfg_data_read(), a generic read method which works >>> on all access widths (1 through 8 bytes, inclusive), and can be >>> used

[Qemu-devel] [PULL 17/18] replay: command line options

From: Pavel Dovgalyuk This patch introduces command line options for enabling recording or replaying virtual machine behavior. These options are added to icount command line parameter. They include 'rr' which switches between record and replay and 'rrfile' for

[Qemu-devel] [PATCH v2] target-arm: Fix non-CPU breakpoint handling in arm_debug_excp_handler()

Do not raise a CPU exception if no CPU breakpoint has fired, since singlestep is also done by generating a debug internal exception. This fixes a bug with singlestepping in gdbstub. Signed-off-by: Sergey Fedorov --- This is a v2 of 'target-arm: Fix arm_debug_excp_handler()

Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next

On 5 November 2015 at 12:13, Gerd Hoffmann wrote: >> etc, because all the virtio_gpu definitions disappear from >> include/standard-headers/linux/virtio_gpu.h. > > Updates not yet in mainline, they are sitting in drm-next and should > land during the merge window (i.e. 4.4-rc1

[Qemu-devel] [PATCH RFC 0/3] block/gluster: add support for multiple gluster servers

Prasanna Kumar Kalever (3): block/gluster: rename [server, volname, image] -> [host, volume, path] block/gluster: code cleanup block/gluster: add support for multiple gluster servers block/gluster.c | 582 --- qapi/block-core.json | 64

[Qemu-devel] [PATCH 3/3] block/gluster: add support for multiple gluster servers

This patch adds a way to specify multiple volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currently VM Image on gluster volume is specified like this: file=gluster[+tcp]://host[:port]/testvol/a.img Assuming we have three hosts

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

Paolo Bonzini writes: > On 05/11/2015 13:06, Andreas Färber wrote: >> > 1. Wouldn't it be cleaner to delete dev-opts *before* sending >> >DEVICE_DELETED? Like this: >> > >> > +++ b/hw/core/qdev.c >> > @@ -1244,6 +1244,9 @@ static void device_unparent(Object

Re: [Qemu-devel] [PATCH v4 5/6] fw_cfg: add generic non-DMA read method

Laszlo Ersek writes: > On 11/04/15 17:35, Gabriel L. Somlo wrote: [...] >> +assert(size > 0 && size <= sizeof(value)); > > It's a matter of taste, and I won't insist at all, just mention that I > didn't write those two assert()s as separate statements :) > > Namely, with a

Re: [Qemu-devel] [PATCH 1/2] net: netmap: Fix compilation issue

Vincenzo Maffione writes: > Reorganization of struct NetClientOptions caused a compilation failure > of the netmap backend. This patch fixes the issue by properly accessing the > union field. > > Signed-off-by: Vincenzo Maffione > --- > net/netmap.c

Re: [Qemu-devel] [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On Thu, 5 Nov 2015 18:15:31 +0800 Xiao Guangrong wrote: > > > On 11/05/2015 05:58 PM, Igor Mammedov wrote: > > On Mon, 2 Nov 2015 17:13:27 +0800 > > Xiao Guangrong wrote: > > > >> A page staring from 0xFF0 and IO port 0x0a18

Re: [Qemu-devel] [PATCH 2/2] net: netmap: use error_setg_errno() in place of error_report()

Vincenzo Maffione writes: > This update was required to align netmap backend to the other > net backends in terms of error reporting. Thank you very much for helping to complete this job! Recommend to point to commit a30ecde in your commit message. > Signed-off-by:

Re: [Qemu-devel] [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On 11/05/2015 05:58 PM, Igor Mammedov wrote: On Mon, 2 Nov 2015 17:13:27 +0800 Xiao Guangrong wrote: A page staring from 0xFF0 and IO port 0x0a18 - 0xa1b in guest are ^^ missing one 0??? reserved for NVDIMM ACPI

Re: [Qemu-devel] [v2 0/2] Optimize the env->tsc update operation

On 05/11/2015 04:51, Liang Li wrote: > This patch set aims for reducing the live migration downtime. It > updates the env->tsc when stopping kvmclock with a new function. > Rather than using 'cpu_synchronize_all_states()', which updates the > whole CPU context just for updating the env->tsc. >

Re: [Qemu-devel] [PATCH v3] iscsi: Translate scsi sense into error code

On 05/11/2015 06:00, Fam Zheng wrote: > Previously we return -EIO blindly when anything goes wrong. Add a helper > function to parse sense fields and try to make the return code more > meaningful. > > This also fixes the default werror configuration (enospc) when we're > using qcow2 on an iscsi

Re: [Qemu-devel] [PATCH v3 0/3] Disallow snapshots if the overlay doesn't support backing files

Am 03.11.2015 um 11:32 hat Alberto Garcia geschrieben: > We are currently allowing snapshots in cases like this one: > >{ 'execute': 'blockdev-add', 'arguments': > { 'options': { 'driver': 'qcow2', > 'node-name': 'new0', > 'file': {

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

On Tue, Nov 03, 2015 at 12:27:19PM -0500, John Snow wrote: > > > On 11/03/2015 10:17 AM, Stefan Hajnoczi wrote: > > On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: > >> @@ -1732,6 +1757,10 @@ static void > >> block_dirty_bitmap_add_prepare(BlkActionState *common, > >>

[Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next

I tried to do a linux headers update against kvm/next (commit 197a4f4b063e4) with update-linux-headers.sh, but the result gives a virtio-gpu that doesn't compile: make: Entering directory `/home/petmay01/linaro/qemu-from-laptop/qemu/build/all-debug' CCaarch64-softmmu/hw/display/virtio-gpu.o

Re: [Qemu-devel] [PULL for-2.5 0/3] qemu-ga patch queue

On 4 November 2015 at 20:12, Michael Roth wrote: > The following changes since commit 79cf9fad341e6e7bd6b55395b71d5c5727d7f5b0: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20151103' into staging (2015-11-03 > 14:54:40 +) > > are

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

Am 04.11.2015 um 19:34 schrieb Markus Armbruster: > Paolo Bonzini writes: > >> Otherwise there is a race where the DEVICE_DELETED event has been sent but >> attempts to reuse the ID will fail. >> >> Reported-by: Michael S. Tsirkin >> Signed-off-by: Paolo

[Qemu-devel] [PULL 03/18] replay: introduce mutex to protect the replay log

From: Pavel Dovgalyuk This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Reviewed-by: Paolo Bonzini

[Qemu-devel] [PULL 09/18] replay: recording and replaying clock ticks

From: Pavel Dovgalyuk Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock). When replaying the execution corresponding values are read from log

Re: [Qemu-devel] Should 'qemu-img commit' sparsify the backing file?

On Thu, Nov 05, 2015 at 05:46:01PM +0800, Fam Zheng wrote: > Does virt-sparsify work if there is no file system present (e.g. the disk is > fully filled with zeroes) on the device? It doesn't do anything bad, but it doesn't currently do that. You could do that using: guestfish

Re: [Qemu-devel] [PULL v2 00/16] Misc patches for QEMU 2.5-rc1

On 5 November 2015 at 10:33, Paolo Bonzini wrote: > The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-10-29 09:49:52 +) > > are available in the git

Re: [Qemu-devel] [PATCH 3/3] block/gluster: add support for multiple gluster servers

On Thursday, November 5, 2015 6:07:06 PM, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currently VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH v9 03/27] qapi: Plug leaks in test-qmp-*

On 11/04/2015 10:44 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/04/2015 01:19 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> Make valgrind happy with the current state of the tests, so that tests/test-qmp-input-strict.c

Re: [Qemu-devel] [PATCH 0/2] Minor throttling updates

Am 04.11.2015 um 14:15 hat Alberto Garcia geschrieben: > Here's a couple of patches for the throttling code. I think the commit > messages are clear enough, but if you have any comments or questions > I'll be glad to hear them. Thanks, applied to the block branch. Kevin

[Qemu-devel] [PULL 15/16] Revert "Introduce cpu_clean_all_dirty"

From: Liang Li This reverts commit de9d61e83d43be9069e6646fa9d57a3f47779d28. Now 'cpu_clean_all_dirty' is useless, we can revert the related code. Conflicts: include/sysemu/kvm.h Signed-off-by: Liang Li Message-Id:

[Qemu-devel] [PULL v2 00/16] Misc patches for QEMU 2.5-rc1

The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-29 09:49:52 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

Re: [Qemu-devel] [PULL 0/5] Migration pull request

On 4 November 2015 at 12:48, Juan Quintela wrote: > Hi > > This is the pull request for migration, it includes: > > - Liang Li series for improving migration downtime > - Mark Cave-Ayland fix to analyze-migration script > > Please, apply > > The following changes since commit

Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next

On 05/11/2015 12:42, Peter Maydell wrote: > I tried to do a linux headers update against kvm/next (commit > 197a4f4b063e4) with update-linux-headers.sh, but the result gives > a virtio-gpu that doesn't compile: > > make: Entering directory >

[Qemu-devel] [PULL 00/18] Record/replay core for 2.5-rc1

The following changes since commit 6c5f30cad290c745f910481d0e890b3f4fad1f00: Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20151104' into staging (2015-11-05 10:10:57 +) are available in the git repository at: git://github.com/bonzini/qemu.git

[Qemu-devel] [PULL 06/18] cpu: replay instructions sequence

From: Pavel Dovgalyuk This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. When replayed instructions

[Qemu-devel] [PULL 16/18] replay: replay blockers for devices

From: Pavel Dovgalyuk Some devices are not supported by record/replay subsystem. This patch introduces replay blocker which denies starting record/replay if such devices are included into the configuration. Signed-off-by: Pavel Dovgalyuk

Re: [Qemu-devel] [PULL 0/7] vl.c: Error message rework

On 3 November 2015 at 18:37, Markus Armbruster wrote: > The following changes since commit 3d861a01093f8eedfac9889746ccafcfd32039b7: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-11-02' > into staging (2015-11-02 11:11:39 +) > > are available in

Re: [Qemu-devel] [PATCH] vnc: fix mismerge

On 2015年11月05日 17:12, Gerd Hoffmann wrote: Commit "4d77b1f vnc: fix bug: vnc server can't start when 'to' is specified" was rebased incorrectly, fix it. Reported-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 2 -- 1 file changed,

Re: [Qemu-devel] [GIT PULL qemu v2] pseries: Update SLOF firmware image to qemu-slof-20151103

On 11/05/2015 10:47 PM, Peter Maydell wrote: On 5 November 2015 at 04:30, Alexey Kardashevskiy wrote: Hi! This is a SLOF update which is 700k and therefore too big to be posted as a patch so here is a pull request. Changes: v2: * rebuilt with gcc 4.8, v1 was build with 5.2.1

[Qemu-devel] [PULL 01/18] replay: global variables and function stubs

From: Pavel Dovgalyuk This patch adds global variables, defines, function declarations, and function stubs for deterministic VM replay used by external modules. Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by:

[Qemu-devel] [PULL 05/18] cpu-exec: allow temporary disabling icount

From: Pavel Dovgalyuk This patch is required for deterministic replay to generate an exception by trying executing an instruction without changing icount. It adds new flag to TB for disabling icount while translating it. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 04/18] replay: introduce icount event

From: Pavel Dovgalyuk This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel

[Qemu-devel] [PULL 12/18] replay: checkpoints

From: Pavel Dovgalyuk This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk Message-Id:

[Qemu-devel] [PULL 08/18] replay: asynchronous events infrastructure

From: Pavel Dovgalyuk This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at

[Qemu-devel] [PULL 14/16] kvmclock: add a new function to update env->tsc.

From: Liang Li The commit 317b0a6d8 fixed an issue which caused by the outdated env->tsc value, but the fix lead to 'cpu_synchronize_all_states()' called twice during live migration. The 'cpu_synchronize_all_states()' takes about 130us for a VM which has 4 vcpus, it's a bit

[Qemu-devel] [PULL 16/16] iscsi: Translate scsi sense into error code

From: Fam Zheng Previously we return -EIO blindly when anything goes wrong. Add a helper function to parse sense fields and try to make the return code more meaningful. This also fixes the default werror configuration (enospc) when we're using qcow2 on an iscsi lun. The old

Re: [Qemu-devel] [PULL 00/18] Record/replay core for QEMU 2.4-rc1

On 4 November 2015 at 16:17, Paolo Bonzini wrote: > The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-10-29 09:49:52 +) > > are available in the git

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

On 2015/11/5 17:19, Jason Wang wrote: On 11/05/2015 03:43 PM, zhanghailiang wrote: Hi Jason, On 2015/11/4 10:56, Jason Wang wrote: On 11/03/2015 07:56 PM, zhanghailiang wrote: Signed-off-by: zhanghailiang Cc: Jason Wang Commit log

Re: [Qemu-devel] [PULL 12/22] vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE

On 3 October 2015 at 17:33, Michael S. Tsirkin wrote: > On Fri, Oct 02, 2015 at 06:18:51PM +0200, Paolo Bonzini wrote: >> >> >> On 24/09/2015 15:20, Michael S. Tsirkin wrote: >> > From: Yuanhan Liu >> > >> > Quote from Michael: >> > >> > We

Re: [Qemu-devel] virtio-gpu doesn't build if you do a linux-headers update from kvm/next

Hi, > etc, because all the virtio_gpu definitions disappear from > include/standard-headers/linux/virtio_gpu.h. Updates not yet in mainline, they are sitting in drm-next and should land during the merge window (i.e. 4.4-rc1 should have them). I'd suggest to exclude virtio_gpu.h changes when

[Qemu-devel] [PULL 15/18] replay: initialization and deinitialization

From: Pavel Dovgalyuk This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id:

[Qemu-devel] [PULL 07/18] replay: interrupts and exceptions

From: Pavel Dovgalyuk This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is

[Qemu-devel] [PULL 11/18] icount: improve counting for record/replay

From: Pavel Dovgalyuk icount_warp_rt function is called by qemu_clock_warp and as callback of icount_warp timer. This patch adds call to qemu_clock_warp into main_loop_wait function, because icount warp may be missed in record/replay mode, when CPU is sleeping. This

Re: [Qemu-devel] [PULL 00/18] Record/replay core for QEMU 2.4-rc1

On 05/11/2015 11:52, Peter Maydell wrote: > On 4 November 2015 at 16:17, Paolo Bonzini wrote: >> The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce: >> >> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging >> (2015-10-29

Re: [Qemu-devel] [GIT PULL qemu v2] pseries: Update SLOF firmware image to qemu-slof-20151103

On 5 November 2015 at 04:30, Alexey Kardashevskiy wrote: > Hi! > > This is a SLOF update which is 700k and therefore too big to be posted > as a patch so here is a pull request. > > Changes: > v2: > * rebuilt with gcc 4.8, v1 was build with 5.2.1 by mistake > > > The following

[Qemu-devel] [PULL 02/18] replay: internal functions for replay log

From: Pavel Dovgalyuk This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id:

[Qemu-devel] [PULL 14/18] replay: ptimer

From: Pavel Dovgalyuk This patch adds deterministic replay for hardware periodic countdown timers. ptimer uses bottom halves layer to execute such an asynchronous callback. We put this callback into the replay queue instead of bottom halves one. When checkpoint is met

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

On 05/11/2015 13:06, Andreas Färber wrote: > > 1. Wouldn't it be cleaner to delete dev-opts *before* sending > >DEVICE_DELETED? Like this: > > > > +++ b/hw/core/qdev.c > > @@ -1244,6 +1244,9 @@ static void device_unparent(Object *obj) > > dev->parent_bus = NULL; > >

[Qemu-devel] [PULL 13/18] bottom halves: introduce bh call function

From: Pavel Dovgalyuk This patch introduces aio_bh_call function. It is used to execute bottom halves as callbacks without adding them to the queue. Signed-off-by: Pavel Dovgalyuk Message-Id:

[Qemu-devel] [PULL 10/18] replay: shutdown event

From: Pavel Dovgalyuk This patch records and replays simulator shutdown event. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id: <20150917162433.8676.32262.st...@pasha-isp.def.inno> Signed-off-by:

  1   2   3   4   >