Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Aravinda Prasad
On Thursday 12 November 2015 01:39 PM, Thomas Huth wrote: > On 11/11/15 18:16, Aravinda Prasad wrote: >> Memory error such as bit flips that cannot be corrected >> by hardware are passed on to the kernel for handling. >> If the memory address in error belongs to guest then >> guest kernel is resp

[Qemu-devel] [PATCH for-2.5] error: Document chained error handling

2015-11-12 Thread Eric Blake
The current output of the qapi code generator includes some chained error handling, which looks like: |visit_start_struct(v, (void **)obj, "foo", name, sizeof(FOO), &err); |if (!err) { |if (*obj) { |visit_type_FOO_fields(v, obj, errp); |} |

Re: [Qemu-devel] [PATCH 3/3] virtio: optimize virtio_access_is_big_endian() for little-endian targets

2015-11-12 Thread Cornelia Huck
On Mon, 09 Nov 2015 18:58:34 +0100 Greg Kurz wrote: > When adding cross-endian support, we introduced the TARGET_IS_BIENDIAN macro > and the virtio_access_is_big_endian() helper to have a branchless fast path > in the virtio memory accessors for targets that don't switch endian. > > This was con

Re: [Qemu-devel] [PULL v3 00/43] Block layer patches (Stefan's tree)

2015-11-12 Thread Peter Maydell
On 12 November 2015 at 15:37, Kevin Wolf wrote: > The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2015-11-12 14:15:32 +) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PATCH 3/4] spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2015-11-12 Thread Aravinda Prasad
On Thursday 12 November 2015 09:32 AM, David Gibson wrote: > On Wed, Nov 11, 2015 at 10:45:44PM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The machine check notification address is saved when the >> OS

Re: [Qemu-devel] [PATCH for-2.5 v4 1/1] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-12 Thread Peter Crosthwaite
On Thu, Nov 12, 2015 at 8:13 AM, Peter Maydell wrote: > On 10 November 2015 at 18:00, Peter Maydell wrote: >> On 9 November 2015 at 07:07, Peter Crosthwaite >> wrote: >>> From: Guenter Roeck >>> >>> Add support for the Xilinx XADC core used in Zynq 7000. >>> >>> References: >>> - Zynq-7000 All

Re: [Qemu-devel] [PATCH 2/3] vhost: move virtio 1.0 check to cross-endian helper

2015-11-12 Thread Cornelia Huck
On Mon, 09 Nov 2015 18:58:25 +0100 Greg Kurz wrote: > Indeed vhost doesn't need to ask for vring endian fixing if the device is > virtio 1.0, since it is already handled by the in-kernel vhost driver. This > patch simply consolidates the logic into the existing helper. > > Signed-off-by: Greg Ku

Re: [Qemu-devel] [PATCH 1/3] virtio: move cross-endian helper to vhost

2015-11-12 Thread Cornelia Huck
On Mon, 09 Nov 2015 18:58:16 +0100 Greg Kurz wrote: > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > indeed returns the runtime state of the virtio device. However, it returns > false unconditionally in the general case. This sounds a bit strange > given the name of th

Re: [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos

2015-11-12 Thread Andreas Färber
Am 06.11.2015 um 13:43 schrieb Michael Tokarev: > From: Cao jin > > Also change the misleading definition of macro OBJECT_CLASS_CHECK > > Signed-off-by: Cao jin > Signed-off-by: Michael Tokarev Michael, please *STOP* queuing QOM patches! You merged the unfixed version now - it's supposed to h

Re: [Qemu-devel] [PATCH v2 1/2] virtio-net: use the backend cross-endian capabilities

2015-11-12 Thread Cornelia Huck
On Mon, 09 Nov 2015 18:41:33 +0100 Greg Kurz wrote: > When running a fully emulated device in cross-endian conditions, including > a virtio 1.0 device offered to a big endian guest, we need to fix the vnet > headers. This is currently handled by the virtio_net_hdr_swap() function > in the core vi

Re: [Qemu-devel] [PATCH] include/hw: field 'offset' in struct Property should be ptrdiff_t as int causes overflow

2015-11-12 Thread Andreas Färber
Am 11.11.2015 um 09:54 schrieb Markus Armbruster: > Peter Maydell writes: >> On 25 August 2015 at 15:17, Markus Armbruster wrote: >>> Stumbled over this while throwing away old mail. Andreas, what do you >>> think? >> >> Seems right to me -- I suspect the original properties code was >> written

Re: [Qemu-devel] [PATCH v2] tests/vhost-user-bridge: implement logging of dirty pages

2015-11-12 Thread Victor Kaplansky
On Thu, Nov 12, 2015 at 04:38:51PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 12, 2015 at 02:34:56PM +0200, Victor Kaplansky wrote: > > /* Based on qemu/hw/virtio/vhost-user.c */ > > @@ -173,6 +180,9 @@ typedef struct VubrVirtq { > > #define VHOST_MEMORY_MAX_NREGIONS8 > > #define VHOST_U

[Qemu-devel] [PATCH 1/2] osdep: Change default value of qemu_hw_version() to "2.5+"

2015-11-12 Thread Eduardo Habkost
There are two issues with qemu_hw_version() today: 1) If a machine has hw_version set, the value returned by it is not very useful, because it is not the actual QEMU version. 2) If a machine does't set hw_version, the return value of qemu_hw_version() is broken, because it will change when

[Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on every machine

2015-11-12 Thread Eduardo Habkost
This changes the qemu_hw_version() default to "2.5+" so we don't make every machine class broken by default unless they set hw_version. For reference, these are the current users of qemu_hw_version(): hw/arm/nseries.c:pstrcat((void *) w, 12, qemu_hw_version()); /* char version[12] */ hw/ide/

[Qemu-devel] [PATCH 2/2] pc: Don't set hw_version on pc-*-2.5

2015-11-12 Thread Eduardo Habkost
Now that qemu_hw_version() returns a fixed "2.5+" string instead of QEMU_VERSION, we don't need to set hw_version on pc-*-2.5 explicitly. Suggested-by: Michael S. Tsirkin Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 1 - hw/i386/pc_q35.c | 1 - 2 files changed, 2 deletions(-) diff -

Re: [Qemu-devel] [PATCH v2 1/1] migrate-start-postcopy: Improve text

2015-11-12 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 11/12/2015 04:34 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Improve the text in both the qapi-schema and hmp help to point out > > you need to set the postcopy-ram capability prior to issuing > > migrate-start-po

[Qemu-devel] [PULL 6/6] migration_init: Fix lock initialisation/make it explicit

2015-11-12 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Peter reported a lock error on MacOS after my a82d593b patch. migrate_get_current does one-time initialisation of a bunch of variables. migrate_init does reinitialisation even on a 2nd migrate after a cancel. The problem here was that I'd initialised the mutex in

[Qemu-devel] [PULL 2/6] migration: Make 32bit linux compile with RDMA

2015-11-12 Thread Juan Quintela
Rest of the file already use that trick. 64bit offsets make no sense in 32bit archs, but that is ram_addr_t for you. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migra

[Qemu-devel] [PULL 5/6] migrate-start-postcopy: Improve text

2015-11-12 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Improve the text in both the qapi-schema and hmp help to point out you need to set the postcopy-ram capability prior to issuing migrate-start-postcopy. Also fix the text of the migrate_start_postcopy error that deals with capabilities. Signed-off-by: Dr. David Ala

[Qemu-devel] [PULL 4/6] Postcopy: Fix TP!=HP zero case

2015-11-12 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Where the target page size is different from the host page we special case it, but I messed up on the zero case check. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/ram.c | 2 +- 1 file changed, 1 in

[Qemu-devel] [PULL 3/6] Finish non-postcopiable iterative devices before package

2015-11-12 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Where we have iterable, but non-postcopiable devices (e.g. htab or block migration), complete them before forming the 'package' but with the CPUs stopped. This stops them filling up the package. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Si

[Qemu-devel] [PULL 0/6] Migration pull request

2015-11-12 Thread Juan Quintela
() (2015-11-12 16:16:02 +) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20151112 for you to fetch changes up to 389775d1f67b2c8f44f9473b1e5363735972e389: migration_init: Fix lock initialisation/make it explicit (2015-11-12 17:55:27 +0100

[Qemu-devel] [PULL 1/6] migration: print ram_addr_t as RAM_ADDR_FMT not %zx

2015-11-12 Thread Juan Quintela
Not all the wold is 64bits (yet). Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 62cf42b..d8d5a50 100644 --- a/migration/ram.c +++ b/migration/r

Re: [Qemu-devel] [PATCH 1/1] migration_init: Fix lock initialisation/make it explicit

2015-11-12 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Peter reported a lock error on MacOS after my a82d593b > patch. > > migrate_get_current does one-time initialisation of > a bunch of variables. > migrate_init does reinitialisation even on a 2nd > migrate after a cancel. >

Re: [Qemu-devel] [PULL 02/10] qtest/ahci: add qcow2 support to ahci-test

2015-11-12 Thread John Snow
On 11/12/2015 05:59 AM, Peter Maydell wrote: > On 29 April 2015 at 00:25, John Snow wrote: >> This will enable the testing of high offsets without >> wasting a lot of disk space, and does not impact the >> previous tests. >> >> mkimg and mkqcow2 are added to libqos for other tests. > > >> +

Re: [Qemu-devel] [PATCH] configure: check for $cxx before use

2015-11-12 Thread Peter Maydell
On 12 November 2015 at 16:29, John Snow wrote: > I broke this when adding checks for clang++. > > Reported-by: Laurent Vivier > Signed-off-by: John Snow > > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 46fd8bd..f75df4b

Re: [Qemu-devel] [PULL 0/2] target-arm queue

2015-11-12 Thread Peter Maydell
' into > staging (2015-11-12 14:15:32 +) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20151112 > > for you to fetch changes up to a7df81a503ce0dd38fe400c9a37fe95ee07b51f0: > >

Re: [Qemu-devel] [PATCH] configure: check for $cxx before use

2015-11-12 Thread Laurent Vivier
On 12/11/2015 17:29, John Snow wrote: > I broke this when adding checks for clang++. > > Reported-by: Laurent Vivier > Signed-off-by: John Snow > > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 46fd8bd..f75df4b 10075

Re: [Qemu-devel] -cpu check, rdtscp and AMD KVM

2015-11-12 Thread Eduardo Habkost
(CCing libvir-list) On Thu, Nov 12, 2015 at 05:35:59PM +0100, Paolo Bonzini wrote: > On 12/11/2015 17:27, Eduardo Habkost wrote: > >> > > To simply remove rdtscp from all Opteron_G* models? > > > > > > Not sure this is the right thing to do... Real hardware has it, and > > > going forward KVM wi

Re: [Qemu-devel] [PATCH v2 1/1] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

2015-11-12 Thread Nishanth Aravamudan
On 12.11.2015 [15:47:15 +1100], David Gibson wrote: > On Wed, Nov 11, 2015 at 02:10:48PM -0800, Nishanth Aravamudan wrote: > > On 11.11.2015 [12:41:26 +1100], David Gibson wrote: > > > On Tue, Nov 10, 2015 at 04:56:38PM -0800, Nishanth Aravamudan wrote: > > > > On 11.11.2015 [11:17:58 +1100], David

Re: [Qemu-devel] [PATCH 1/4] target-tilegx: Add fpu header file

2015-11-12 Thread Chen Gang
On 11/13/15 00:10, Peter Maydell wrote: > On 12 November 2015 at 16:04, Chen Gang wrote: >> On 11/12/15 22:34, Richard Henderson wrote: >>> On 11/08/2015 06:43 AM, Chen Gang wrote: >>> +#if !defined(HOST_WORDS_BIGENDIAN) +/* According to float(uns)sisf2 and float(uns)sidf2 in gcc til

[Qemu-devel] [PATCH V4 0/6] ide: avoid main-loop hang on CDROM/NFS failure

2015-11-12 Thread Peter Lieven
This series aims at avoiding a hanging main-loop if a vserver has a CDROM image mounted from a NFS share and that NFS share goes down. Typical situation is that users mount an CDROM ISO to install something and then forget to eject that CDROM afterwards. As a consequence this mounted CD is able to

[Qemu-devel] [PATCH V4 1/6] ide/atapi: make PIO read requests async

2015-11-12 Thread Peter Lieven
PIO read requests on the ATAPI interface used to be sync blk requests. This has two significant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not complete (e.g. due to an unresponsive storage) Qemu hangs completely. Note: Due to possible

Re: [Qemu-devel] -cpu check, rdtscp and AMD KVM

2015-11-12 Thread Paolo Bonzini
On 12/11/2015 17:27, Eduardo Habkost wrote: >> > > To simply remove rdtscp from all Opteron_G* models? > > > > Not sure this is the right thing to do... Real hardware has it, and > > going forward KVM will provide it. > > Do you see any alternative? Live with the warning, and document it in t

[Qemu-devel] [PATCH V4 6/6] ide: enable buffered requests for PIO read requests

2015-11-12 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 7ca67bc..b9b531c 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -677,8 +677,8 @@ static void ide_sector_read(IDEState *s) block_acct_

Re: [Qemu-devel] [OpenBIOS] CUDA has problems with Mac OS 10.4

2015-11-12 Thread Programmingkid
On Nov 11, 2015, at 6:14 PM, BALATON Zoltan wrote: > On Wed, 11 Nov 2015, Programmingkid wrote: >> On Nov 11, 2015, at 4:32 PM, Andreas Tobler wrote: It looks like you are saying you wish to keep the CUDA device. Mac OS 9 is most likely hard coded to expect via-pmu instead of via-

[Qemu-devel] [PATCH V4 2/6] block: add blk_abort_aio_request

2015-11-12 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/block-backend.c | 17 + include/sysemu/block-backend.h | 3 +++ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index 6f9309f..701234e 100644 --- a/block/block-backend.c +

[Qemu-devel] [PATCH V4 3/6] ide: add support for IDEBufferedRequest

2015-11-12 Thread Peter Lieven
this patch adds a new aio readv compatible function which copies all data through a bounce buffer. These buffered requests can be flagged as orphaned which means that their original callback has already been invoked and the request has just not been completed by the backend storage. The bounce buff

[Qemu-devel] [PATCH V4 5/6] ide: enable buffered requests for ATAPI devices

2015-11-12 Thread Peter Lieven
Signed-off-by: Peter Lieven --- hw/ide/atapi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index cfd2d63..d1eaa29 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -190,8 +190,8 @@ static int cd_read_sector(IDEState *s) blo

[Qemu-devel] [PATCH V4 4/6] ide: orphan all buffered requests on DMA cancel

2015-11-12 Thread Peter Lieven
If the guests canceles a DMA request we can prematurely invoke all callbacks of buffered requests and flag all them as orphaned. Ideally this avoids the need for draining all requests. For CDROM devices this works in 100% of all cases. Signed-off-by: Peter Lieven --- hw/ide/pci.c | 19 ++

[Qemu-devel] [PATCH] configure: check for $cxx before use

2015-11-12 Thread John Snow
I broke this when adding checks for clang++. Reported-by: Laurent Vivier Signed-off-by: John Snow --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 46fd8bd..f75df4b 100755 --- a/configure +++ b/configure @@ -4435,7 +4435,8 @@ fi if

Re: [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single floating point

2015-11-12 Thread Chen Gang
On 11/13/15 00:18, Richard Henderson wrote: > On 11/12/2015 05:12 PM, Chen Gang wrote: >> On 11/12/15 22:36, Richard Henderson wrote: +if (sfmt.calc == TILEGX_F_CALC_CVT) { +if (sfmt.sign) +f.f = int32_to_float32(0 - sfmt.mantissa, fp_status); +el

Re: [Qemu-devel] [Qemu-block] [PULL v3 00/43] Block layer patches (Stefan's tree)

2015-11-12 Thread Alberto Garcia
On Thu, Nov 12, 2015 at 04:37:08PM +0100, Kevin Wolf wrote: > The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2015-11-12 14:15:32 +) > > are available in the git repositor

Re: [Qemu-devel] -cpu check, rdtscp and AMD KVM

2015-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2015 at 04:58:37PM +0100, Paolo Bonzini wrote: > On 12/11/2015 16:25, Eduardo Habkost wrote: > > On Thu, Nov 12, 2015 at 11:53:44AM +0100, Paolo Bonzini wrote: > >> Eduardo, > >> > >> running QEMU 2.5 on SVM causes a warning because rdtscp is not supported > >> by KVM. While I can

Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Jeff Cody
On Thu, Nov 12, 2015 at 05:04:02AM -0500, Prasanna Kumar Kalever wrote: > On Tuesday, November 10, 2015 9:37:20 PM, Eric Blake wrote: > > > > On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > > > This patch adds a way to specify multiple volfile servers to the gluster > > > block backend of

[Qemu-devel] [PATCH v9 2/6] target-arm: kvm - implement software breakpoints

2015-11-12 Thread Alex Bennée
These don't involve messing around with debug registers, just setting the breakpoint instruction in memory. GDB will not use this mechanism if it can't access the memory to write the breakpoint. All the kernel has to do is ensure the hypervisor traps the breakpoint exceptions and returns to usersp

[Qemu-devel] [PATCH v9 1/6] target-arm: kvm64 - introduce kvm_arm_init_debug()

2015-11-12 Thread Alex Bennée
As we haven't always had guest debug support we need to probe for it. Additionally we don't do this in the start-up capability code so we don't fall over on old kernels. Signed-off-by: Alex Bennée --- target-arm/kvm64.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/targ

[Qemu-devel] [PATCH v9 5/6] target-arm: kvm - re-inject guest debug exceptions

2015-11-12 Thread Alex Bennée
From: Alex Bennée If we can't find details for the debug exception in our debug state then we can assume the exception is due to debugging inside the guest. To inject the exception into the guest state we re-use the TCG exception code (do_interupt). However while guest debugging is in effect we

[Qemu-devel] [PATCH v9 3/6] target-arm: kvm - support for single step

2015-11-12 Thread Alex Bennée
This adds support for single-step. There isn't much to do on the QEMU side as after we set-up the request for single step via the debug ioctl it is all handled within the kernel. Signed-off-by: Alex Bennée --- v2 - convert to using HSR_EC v3 - use internals.h definitions --- target-arm/kvm.

[Qemu-devel] [PATCH v9 6/6] tests/guest-debug: introduce basic gdbstub tests

2015-11-12 Thread Alex Bennée
From: Alex Bennée The aim of these tests is to combine with an appropriate kernel image (with symbol-file vmlinux) and check it behaves as it should. Given a kernel it checks: - single step - software breakpoint - hardware breakpoint - access, read and write watchpoints On success it re

[Qemu-devel] [PATCH v9 0/6] QEMU support for KVM Guest Debug on arm64

2015-11-12 Thread Alex Bennée
Hi, Here is the latest patch set to support debugging of KVM guests on arm64. The main changes since the last post are that the kernel patches have now been mainlined. As the recent master has synced up headers they are no longer needed for this series. I've add a GDB Python based test into tests

[Qemu-devel] [PATCH v9 4/6] target-arm: kvm - add support for HW assisted debug

2015-11-12 Thread Alex Bennée
This adds basic support for HW assisted debug. The ioctl interface to KVM allows us to pass an implementation defined number of break and watch point registers. When KVM_GUESTDBG_USE_HW is specified these debug registers will be installed in place on the world switch into the guest. The hardware i

Re: [Qemu-devel] [PATCH v11 25/28] qapi: Simplify visits of optional fields

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > On 11/12/2015 08:11 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> None of the visitor callbacks would set an error when testing >>> if an optional field was present; make this part of the interface >>> contract by eliminating the errp argument. Then, for less c

Re: [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single floating point

2015-11-12 Thread Richard Henderson
On 11/12/2015 05:12 PM, Chen Gang wrote: On 11/12/15 22:36, Richard Henderson wrote: +if (sfmt.calc == TILEGX_F_CALC_CVT) { +if (sfmt.sign) +f.f = int32_to_float32(0 - sfmt.mantissa, fp_status); +else +f.f = uint32_to_float32(sfmt.mantissa, fp_status);

Re: [Qemu-devel] Attempt at Mac OS X acceleration using "Hypervisor.Framwork"

2015-11-12 Thread Paolo Bonzini
On 12/11/2015 15:39, Peter Maydell wrote: > I think it would be nice to be able to support hardware acceleration > on OSX hosts, and I think the official Apple hypervisor APIs for this > are the right way to do that. The questions I have are: > * how much code are we going to end up with in QEMU

Re: [Qemu-devel] [PATCH for-2.5 v4 1/1] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-12 Thread Peter Maydell
On 10 November 2015 at 18:00, Peter Maydell wrote: > On 9 November 2015 at 07:07, Peter Crosthwaite > wrote: >> From: Guenter Roeck >> >> Add support for the Xilinx XADC core used in Zynq 7000. >> >> References: >> - Zynq-7000 All Programmable SoC Technical Reference Manual >> - 7 Series FPGAs a

Re: [Qemu-devel] [PATCH v2 1/1] configure: use appropriate code fragment for -fstack-protector checks

2015-11-12 Thread Markus Armbruster
Rodrigo Rebello writes: > The check for stack-protector support consisted in compiling and linking > the test program below (output by function write_c_skeleton()) with the > compiler flag -fstack-protector-strong first and then with > -fstack-protector-all if the first one failed to work: > >

Re: [Qemu-devel] [PATCH 1/4] target-tilegx: Add fpu header file

2015-11-12 Thread Peter Maydell
On 12 November 2015 at 16:04, Chen Gang wrote: > On 11/12/15 22:34, Richard Henderson wrote: >> On 11/08/2015 06:43 AM, Chen Gang wrote: >> >>> +#if !defined(HOST_WORDS_BIGENDIAN) >>> +/* According to float(uns)sisf2 and float(uns)sidf2 in gcc tilegx.md */ >>> +uint64_t exp : 8;

Re: [Qemu-devel] [PATCH 2/4] target-tilegx: Implement fpu single floating point

2015-11-12 Thread Chen Gang
On 11/12/15 22:36, Richard Henderson wrote: >> +if (sfmt.calc == TILEGX_F_CALC_CVT) { >> +if (sfmt.sign) >> +f.f = int32_to_float32(0 - sfmt.mantissa, fp_status); >> +else >> +f.f = uint32_to_float32(sfmt.mantissa, fp_status); >> +} else { > > Format

Re: [Qemu-devel] [PATCH v11 27/28] qapi: Move duplicate enum value checks to schema check()

2015-11-12 Thread Eric Blake
On 11/12/2015 08:46 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Similar to the previous commit, move the detection of a collision >> in enum values from parse time to QAPISchemaEnumType.check(). >> This happens to also detect collisions in union branch names >> mapping to the same enum

Re: [Qemu-devel] [PATCH] virtio-9p: add savem handlers

2015-11-12 Thread Greg Kurz
On Thu, 12 Nov 2015 15:39:02 +0100 Cornelia Huck wrote: > On Thu, 12 Nov 2015 15:25:33 +0100 > Greg Kurz wrote: > > > On Thu, 12 Nov 2015 13:50:20 +0100 > > Cornelia Huck wrote: > > > > > On Thu, 12 Nov 2015 09:28:21 +0100 > > > Greg Kurz wrote: > > > > > > > On Thu, 22 Oct 2015 19:38:42 +0

Re: [Qemu-devel] [PATCH v11 28/28] qapi: Detect base class loops

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > It should be fairly obvious that qapi base classes need to > form an acyclic graph, since QMP cannot specify the same > key more than once, while base classes are included as flat > members alongside other members added by the child. But the > old check_member_clash() parser

Re: [Qemu-devel] [PULL 00/11] virtio, vhost: fixes for 2.5

2015-11-12 Thread Peter Maydell
On 12 November 2015 at 15:09, Michael S. Tsirkin wrote: > The following changes since commit fd717e789010012c5f0537269df19ef19d469baf: > > Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-11-11-tag' > into staging (2015-11-12 13:11:06 +) > > are available in the git repositor

Re: [Qemu-devel] [PATCH 1/4] target-tilegx: Add fpu header file

2015-11-12 Thread Chen Gang
On 11/12/15 22:34, Richard Henderson wrote: > On 11/08/2015 06:43 AM, Chen Gang wrote: > >> +#if !defined(HOST_WORDS_BIGENDIAN) >> +/* According to float(uns)sisf2 and float(uns)sidf2 in gcc tilegx.md */ >> +uint64_t exp : 8; /* exp, 0x9e: 31 + TILEGX_F_EXP_FZERO */ >> +uin

Re: [Qemu-devel] -cpu check, rdtscp and AMD KVM

2015-11-12 Thread Paolo Bonzini
On 12/11/2015 16:25, Eduardo Habkost wrote: > On Thu, Nov 12, 2015 at 11:53:44AM +0100, Paolo Bonzini wrote: >> Eduardo, >> >> running QEMU 2.5 on SVM causes a warning because rdtscp is not supported >> by KVM. While I can fix it, that leaves a warning on all existing kernels. > > You mean when

Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue

2015-11-12 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > >> On 12 November 2015 at 13:18, Peter Maydell > >> wrote: > >> > On 12 November 2015 at 13:08, Dr. David Alan Gilbert > >> > wrote: > >> >> OK, can you try a s

Re: [Qemu-devel] [PATCH v11 22/28] qapi: Simplify visiting of alternate types

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > Previously, working with alternates required two lookup arrays > and some indirection: for type Foo, we created Foo_qtypes[] > which maps each qtype to a value of the generated FooKind enum, > then look up that value in FooKind_lookup[] like we do for other > union types. [..

Re: [Qemu-devel] [PATCH v11 27/28] qapi: Move duplicate enum value checks to schema check()

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > Similar to the previous commit, move the detection of a collision > in enum values from parse time to QAPISchemaEnumType.check(). > This happens to also detect collisions in union branch names > mapping to the same enum value, even when the names do not > collide case-wise.

[Qemu-devel] [PATCH 1/1] migration_init: Fix lock initialisation/make it explicit

2015-11-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Peter reported a lock error on MacOS after my a82d593b patch. migrate_get_current does one-time initialisation of a bunch of variables. migrate_init does reinitialisation even on a 2nd migrate after a cancel. The problem here was that I'd initialised the mutex in

[Qemu-devel] [PULL v3 00/43] Block layer patches (Stefan's tree)

2015-11-12 Thread Kevin Wolf
The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2015-11-12 14:15:32 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH] vfio: Fix handling VFIO_IOMMU_GET_INFO results

2015-11-12 Thread Alex Williamson
On Thu, 2015-11-12 at 17:35 +0300, Pavel Fedin wrote: > Hello! > > > > Kernel headers define VFIO_IOMMU_INFO_PGSIZES flag, however it has > > > actually been never used, probably by mistake which now became a part > > > of the ABI. The kernel always sets info.flags to 0: > > > > I don't see how

Re: [Qemu-devel] [PATCH v11 25/28] qapi: Simplify visits of optional fields

2015-11-12 Thread Eric Blake
On 11/12/2015 08:11 AM, Markus Armbruster wrote: > Eric Blake writes: > >> None of the visitor callbacks would set an error when testing >> if an optional field was present; make this part of the interface >> contract by eliminating the errp argument. Then, for less code, >> reflect the determin

Re: [Qemu-devel] [PATCH for-2.5] configure: Don't disable optimization for non-fortify builds

2015-11-12 Thread Laurent Vivier
On 09/11/2015 17:58, Peter Maydell wrote: > On 9 November 2015 at 15:33, Paolo Bonzini wrote: >> You're right. The two are the same then, preference is of course >> subjective. Feel free to commit yours! > > Applied to master, thanks. > > -- PMM When I run configure now, I've the following

Re: [Qemu-devel] [PATCH] migration/ram: fix build on 32 bit hosts

2015-11-12 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > ram_addr_t must be printed with RAM_ADDR_FMT not %z. > Also, change size print to %zx to match what RAM_ADDR_FMT does. > > Signed-off-by: Michael S. Tsirkin Equivalent patch on queue and will be send with another couple of fixes later Today. Thanks. > --- > m

Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue

2015-11-12 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 12 November 2015 at 13:18, Peter Maydell wrote: >> > On 12 November 2015 at 13:08, Dr. David Alan Gilbert >> > wrote: >> >> OK, can you try a simple migration by hand outside of the test harness; >> >> just

Re: [Qemu-devel] -cpu check, rdtscp and AMD KVM

2015-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2015 at 11:53:44AM +0100, Paolo Bonzini wrote: > Eduardo, > > running QEMU 2.5 on SVM causes a warning because rdtscp is not supported > by KVM. While I can fix it, that leaves a warning on all existing kernels. You mean when using Opteron_G2 or newer, right? qemu64 and kvm64 don

[Qemu-devel] [PULL 2/2] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-11-12 Thread Peter Maydell
From: Guenter Roeck Add support for the Xilinx XADC core used in Zynq 7000. References: - Zynq-7000 All Programmable SoC Technical Reference Manual - 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC Dual 12-Bit 1 MSPS Analog-to-Digital Converter Tested with Linux using QEMU machine xili

[Qemu-devel] [PULL 1/2] target-arm: Update PC before calling gen_helper_check_breakpoints()

2015-11-12 Thread Peter Maydell
From: Sergey Fedorov PC should be updated in the CPU state before calling check_breakpoints() helper. Otherwise, the helper would not see the correct PC in the CPU state if it is not at the start of a TB. Signed-off-by: Sergey Fedorov Message-id: 1447176222-16401-1-git-send-email-serge.f...@gma

[Qemu-devel] [PULL 0/2] target-arm queue

2015-11-12 Thread Peter Maydell
t: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20151112 for you to fetch changes up to a7df81a503ce0dd38fe400c9a37fe95ee07b51f0: hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 15:1

Re: [Qemu-devel] [RFC] ide: Don't use qemu_hw_version() for firmware revision

2015-11-12 Thread Eduardo Habkost
On Thu, Nov 12, 2015 at 09:27:56AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > The IDEState.version field is used for firmware version > > information returned to the guest. Updating firmware information > > on QEMU upgrade is supposed to be acceptable, so IDE doesn't need > >

Re: [Qemu-devel] [PATCH v2 1/1] migrate-start-postcopy: Improve text

2015-11-12 Thread Eric Blake
On 11/12/2015 04:34 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Improve the text in both the qapi-schema and hmp help to point out > you need to set the postcopy-ram capability prior to issuing > migrate-start-postcopy. > > Also fix the text of the migrate_start_

[Qemu-devel] [PATCH 3/4] hw/pc: query both q35 and i440fx bus

2015-11-12 Thread Marcel Apfelbaum
Look for pxb devices on both i386 machines. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 3 +-- hw/i386/pc.c | 2 +- hw/pci-host/q35.c| 8 include/hw/i386/pc.h | 9 + 4 files changed, 19 insertions(+), 3 deletions(-) diff --git a/hw/i386/acpi-build.c b

[Qemu-devel] [PATCH 0/4] hw/pcie: Multi-root support for Q35

2015-11-12 Thread Marcel Apfelbaum
The PXB host bridge provides a way to have multiple PCI hierarchies (PCI root buses). This series is porting the PXB device to Q35 machines by: - removing the internal pci-bridge - make the PXB bus PCIe for Q35, while it remains PCI for i440fx. This approach works because the Root Complexes are

Re: [Qemu-devel] [PATCH v11 25/28] qapi: Simplify visits of optional fields

2015-11-12 Thread Markus Armbruster
Eric Blake writes: > None of the visitor callbacks would set an error when testing > if an optional field was present; make this part of the interface > contract by eliminating the errp argument. Then, for less code, > reflect the determined boolean value back to the caller instead > of making t

[Qemu-devel] [PATCH 1/4] hw/pxb: remove the built-in pci bridge

2015-11-12 Thread Marcel Apfelbaum
As part of porting the pxb device to Q35 remove the internal pci-2-pci bridge. The only way to hot-pug devices on the extra PCI root buses is by adding a pci-2-pci to the pxb before the firmware assign the IO/mem resources. Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/pci_expander_bridge.c

[Qemu-devel] [PATCH 4/4] hw/pxb: add support for PCIe

2015-11-12 Thread Marcel Apfelbaum
The PXB internal bus type is created in conformance with the primary root bus (bus 0). Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/pci_expander_bridge.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-

[Qemu-devel] [PULL 09/11] vhost: send SET_VRING_ENABLE at start/stop

2015-11-12 Thread Michael S. Tsirkin
From: Yuanhan Liu Send SET_VRING_ENABLE at start/stop, to give the backend an explicit sign of our state. Signed-off-by: Yuanhan Liu Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/virtio/

[Qemu-devel] [PATCH 2/4] hw/acpi: merge pxb adjacent memory/IO ranges

2015-11-12 Thread Marcel Apfelbaum
Since the PXB has no longer a built-in PCI bridge, the ACPI will include IO/MEM ranges per device. Try to merge adjacent resources to reduce the ACPI tables length. Signed-off-by: Marcel Apfelbaum --- hw/i386/acpi-build.c | 123 +++ 1 file changed,

[Qemu-devel] [PULL 11/11] virtio-9p: add savem handlers

2015-11-12 Thread Michael S. Tsirkin
From: Greg Kurz We don't support migration of mounted 9p shares. This is handled by a migration blocker. One would expect, however, to be able to migrate if the share is unmounted. Unfortunately virtio-9p-device does not register savevm handlers at all ! Migration succeeds and leaves the guest w

[Qemu-devel] [PULL 08/11] vhost: rename RESET_DEVICE backto RESET_OWNER

2015-11-12 Thread Michael S. Tsirkin
From: Yuanhan Liu This patch basically reverts commit d1f8b30e. It turned out that it breaks stuff, so revert it: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html CC: "Michael S. Tsirkin" Reported-by: Paolo Bonzini Signed-off-by: Yuanhan Liu Reviewed-by: Michael S. T

[Qemu-devel] [PULL 05/11] virtio-pci: introduce pio notification capability for modern device

2015-11-12 Thread Michael S. Tsirkin
From: Jason Wang We used to use mmio for notification. This could be slow on some arch (e.g on x86 without EPT). So this patch introduces pio bar and a pio notification cap for modern device. This ability is enabled through property "modern-pio-notify" for virtio pci devices and was disabled by d

[Qemu-devel] [PULL 10/11] hw/virtio: Add PCIe capability to virtio devices

2015-11-12 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root Complex as Integrated Endpoints remain PCI. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsi

[Qemu-devel] [PULL 03/11] KVM: add support for any length io eventfd

2015-11-12 Thread Michael S. Tsirkin
From: Jason Wang Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Paolo Bonzini --- include/sysemu/kvm.h | 8 kvm-all.c| 4 kvm-stub.c | 1 + 3 files changed, 13 insertions(+) diff --git a/include/sysem

[Qemu-devel] [PULL 07/11] vhost-user: modify SET_LOG_BASE to pass mmap size and offset

2015-11-12 Thread Michael S. Tsirkin
From: Victor Kaplansky Unlike the kernel, vhost-user application accesses log table by mmaping it to its user space. This change adds two new fields to VhostUserMsg payload: mmap_size, and mmap_offset and make QEMU to pass the to vhost-user application in VHOST_USER_SET_LOG_BASE request. Signed-

[Qemu-devel] [PULL 02/11] memory: don't try to adjust endianness for zero length eventfd

2015-11-12 Thread Michael S. Tsirkin
From: Jason Wang There's no need to adjust endianness for zero length eventfd since the data wrote was actually ignored by kernel. So skip the adjust in this case to fix a possible crash when trying to use wildcard mmio eventfd in ppc. Cc: Greg Kurz Cc: Peter Maydell Cc: Paolo Bonzini Acked-b

[Qemu-devel] [PULL 06/11] virtio-pci: unbreak queue_enable read

2015-11-12 Thread Michael S. Tsirkin
From: Jason Wang Guest always get zero when reading queue_enable. This violates spec. Fixing this by setting the queue_enable to true during any guest writing and setting it to zero during reset. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang Reviewed-by: Michael S. Tsirkin Signed-off-by: M

[Qemu-devel] [PULL 01/11] virtio-pci: fix 1.0 virtqueue migration

2015-11-12 Thread Michael S. Tsirkin
From: Jason Wang We don't migrate the followings fields for virtio-pci: uint32_t dfselect; uint32_t gfselect; uint32_t guest_features[2]; struct { uint16_t num; bool enabled; uint32_t desc[2]; uint32_t avail[2]; uint32_t used[2]; } vqs[VIRTIO_QUEUE_MAX]; This will confuse dr

[Qemu-devel] [PULL 04/11] virtio-pci: use zero length mmio eventfd for 1.0 notification cap when possible

2015-11-12 Thread Michael S. Tsirkin
From: Jason Wang We use data match eventfd for 1.0 notification currently. This could be slow since software decoding is needed for mmio exit. To speed this up, we can switch to use zero length mmio eventfd for 1.0 notification since we can examine the queue index directly from the writing addres

[Qemu-devel] [PULL 00/11] virtio, vhost: fixes for 2.5

2015-11-12 Thread Michael S. Tsirkin
The following changes since commit fd717e789010012c5f0537269df19ef19d469baf: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2015-11-11-tag' into staging (2015-11-12 13:11:06 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/fo

Re: [Qemu-devel] [PATCH 1/2] vl: Table-based select_vgahw()

2015-11-12 Thread Eduardo Habkost
On Wed, Nov 11, 2015 at 03:05:07PM -0700, Eric Blake wrote: > On 11/11/2015 02:27 PM, Eduardo Habkost wrote: > > Instead of implementing separate check functions for each vga > > interface type, add a table enumerating the possible VGA > > interfaces. > > > > Signed-off-by: Eduardo Habkost > > --

<    1   2   3   4   >