[Qemu-devel] KVM/Qemu migration under fast network stress

Hi, When doing live migration with iperf running on the migrated VM over PV/virtio interface -- it doesn't end when the number of threads > 1 :( nor when we run an IO (fio) benchmark which gets high-throughput. None of these tests run over the network the migration is carried out. We get this

Re: [Qemu-devel] [PATCH v3 2/3] i.MX: Split the CCM class into an abstact base class and a concrete class.

Le 24/11/2015 23:04, Peter Crosthwaite a écrit : On Thu, Nov 19, 2015 at 12:40 PM, Jean-Christophe Dubois wrote: The IMX_CCM class is now the base abstract class that is used by EPIT and GPT timer implementation. IMX31_CCM class is the concrete class implementing CCM for

[Qemu-devel] [PATCH v2 1/6] qapi-schema: dump-guest-memory: Improve text

dump-guest-memory is supported by more than just x86, however the paging option is not. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by: Eric Blake --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/6] target-arm: enable qmp-dump-guest-memory

This series brings qmp-dump-guest-memory to arm and aarch64 targets. I've detailed my testing and the results in the following table. v2: changes thanks to Peter's review questions - Threw in the FP registers. Can view them with gdb on elf formatted dumps. - Added comments stating where the

[Qemu-devel] [PATCH v2 2/6] dump: qemunotes aren't commonly needed

Only one of three architectures implementing qmp-dump-guest-memory write qemu notes. And, another architecture (arm/aarch64) is coming, which won't use them either. Make the common implementation truly common. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by:

[Qemu-devel] [PATCH v2 4/6] dump: allow target to set the physical base

crash assumes the physical base in the kdump subheader of makedumpfile formatted dumps is correct. Zero is not correct for all architectures, so allow it to be changed. (No functional change.) Signed-off-by: Andrew Jones --- dump.c | 4 ++--

[Qemu-devel] [PATCH v2 5/6] target-arm: support QMP dump-guest-memory

Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Signed-off-by: Andrew Jones --- target-arm/Makefile.objs | 3 +- target-arm/arch_dump.c | 230 +++ target-arm/cpu-qom.h |

[Qemu-devel] [PATCH v2 3/6] dump: allow target to set the page size

This is necessary for targets that don't have TARGET_PAGE_SIZE == real-target-page-size. The target should set the page size to the correct one, if known, or, if not known, to the maximum page size it supports. (No functional change.) Signed-off-by: Andrew Jones --- dump.c

[Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

Also refactors note init code to avoid code duplication. Signed-off-by: Andrew Jones --- target-arm/arch_dump.c | 161 ++--- 1 file changed, 139 insertions(+), 22 deletions(-) diff --git a/target-arm/arch_dump.c

Re: [Qemu-devel] [PATCH for-2.5 1/1] vhost-user: do not send SET_VRING_ENABLE at start

On Tue, Nov 24, 2015 at 11:23:34PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 24, 2015 at 10:05:27PM +0100, Thibaut Collet wrote: > > On Tue, Nov 24, 2015 at 9:52 PM, Michael S. Tsirkin wrote: > > > On Tue, Nov 24, 2015 at 05:10:36PM +0100, Thibaut Collet wrote: > > >> This

Re: [Qemu-devel] make check failed: rcutorture error

On 2015/11/24 19:54, Paolo Bonzini wrote: > > > On 24/11/2015 12:45, Yijun Zhu wrote: >> Hi all, >> >>I got an error when doing "make check" on qemu code both stable-2.4 and >> master branch, after updating binutils to 2.24-33. >> >>Qemu compiled successfully with following configure

Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpoint

On 11/19/2015 06:52 PM, Shmulik Ladkani wrote: > Report the 'express endpoint' capability if on a PCIE bus. > > Signed-off-by: Shmulik Ladkani > --- > hw/net/vmxnet3.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/net/vmxnet3.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] PCI Trivial: remove superfluous code

On 11/25/2015 02:30 AM, Marcel Apfelbaum wrote: On 11/23/2015 03:19 PM, Cao jin wrote: remove superfluous code in do_pci_register_device(). See its caller: pci_qdev_realize() Signed-off-by: Cao jin --- hw/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 2/4] vmxnet3: Change offsets of PCI capabilities

On 11/19/2015 06:52 PM, Shmulik Ladkani wrote: > Place device reported PCI capabilities at the same offsets as placed by > the VMware virtual hardware: > Express Endpoint at [48], MSI at [84], MSI-X at [9c]. > > Signed-off-by: Shmulik Ladkani > --- >

Re: [Qemu-devel] [PATCH v5 4/4] devicetree: update documentation for fw_cfg ARM bindings

On Mon, Nov 23, 2015 at 10:57:44AM -0500, Gabriel L. Somlo wrote: > From: Gabriel Somlo > > Remove fw_cfg hardware interface details from > Documentation/devicetree/bindings/arm/fw-cfg.txt, > and replace them with a pointer to the authoritative > documentation in the QEMU source

Re: [Qemu-devel] [PATCH 3/4] vmxnet3: Change the offset of the MSIX PBA table

On 11/19/2015 06:52 PM, Shmulik Ladkani wrote: > Place the PBA table at 0x1000, as placed by VMware virtual hardware. > > Signed-off-by: Shmulik Ladkani > --- > hw/net/vmxnet3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

On Tue, 11/24 06:49, Eric Blake wrote: > On 11/24/2015 04:37 AM, Fam Zheng wrote: > > >> I think the patch should be dropped, and periodic progress reports > >> should be emitted from within the dump loops that do the heavy lifting. > >> > >> For the ELF format dumps, that loop appears to reside

Re: [Qemu-devel] [PATCH for 2.6 2/3] block: Hide HBitmap in block dirty bitmap interface

On Tue, 11/24 12:12, Vladimir Sementsov-Ogievskiy wrote: > On 24.11.2015 05:28, Fam Zheng wrote: > >On Mon, 11/23 16:34, John Snow wrote: > >>Hmm, what's the idea, here? > >> > >>This patch does a lot more than just hide hbitmap details from callers > >>of block_dirty_bitmap functions. > >> > >>So

Re: [Qemu-devel] [PATCH v2 0/2] net/tap-win32 bugfixes

On 11/25/2015 07:36 AM, Andrew Baumann wrote: > Ping? > > Jason, I know you planned to leave this for a few days... I just wanted to > make sure it isn't forgotten :) > > Thanks, > Andrew Thanks for working on this. I would expect Stefan to review v2 (since he reviewed v1). Stefan, could you

Re: [Qemu-devel] [PATCH for-2.5] eepro100: Prevent two endless loops

On 11/20/2015 07:27 PM, P J P wrote: > +-- On Fri, 20 Nov 2015, Stefan Weil wrote --+ > | include/hw/pci/pci.h:static inline uint##_bits##_t > | ld##_l##_pci_dma(PCIDevice *dev, \ > >I see. > > | Is there an ideal count? If it is too low, it might break some use cases. > | If it

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On 2015年11月24日 22:20, Alexander Duyck wrote: > I'm still not a fan of this approach. I really feel like this is > something that should be resolved by extending the existing PCI hot-plug > rather than trying to instrument this per driver. Then you will get the > goodness for multiple drivers and

Re: [Qemu-devel] [PATCH v6] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On Nov 24, 2015, at 9:38 AM, Kevin Wolf wrote: > > >> +/* If using a physical device */ >> +if (strstart(filename, "/dev/", NULL)) { >> +char bsdPath[MAXPATHLEN]; >> + >> +/* If the physical device is a cdrom */ >> +if (strcmp(filename, "/dev/cdrom") == 0) { > >

[Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6

v3: Split patch 2. [Vladimir] v2: bitmap_set -> set_bit. [Congyang, Paolo, John] Add John Snow's rev-by with that change. This makes a cleaner base for more dirty bitmap work. "granularity" appearing with different representations have always been mind twisting, remove it from HBitmap to

[Qemu-devel] [PATCH v3 3/4] block: Manage granularity in BdrvDirtyBitmap

BdrvDirtyBitmap has to know about granularity because it's in the API, but currently the logic is in HBitmap. Because HBitmap has a delicate implementation that has a multi-layer array of arrays of different granularities, handling the "bit granularity" there only makes it harder to understand.

[Qemu-devel] [PATCH v3 4/4] hbitmap: Drop "granularity"

Now all callers except the test code use zero, drop the parameter to make the interface cleaner and more intuitive. Test code of hbitmap granularity is removed together. Signed-off-by: Fam Zheng --- block.c| 4 +- include/qemu/hbitmap.h | 20 +

[Qemu-devel] [PATCH v3 1/4] backup: Use Bitmap to replace "s->bitmap"

"s->bitmap" tracks done sectors, we only check bit states without using any iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and more memory efficient. Meanwhile, rename it to done_bitmap, to reflect the intention. Signed-off-by: Fam Zheng Reviewed-by:

[Qemu-devel] [PATCH v3 2/4] block: Hide HBitmap in block dirty bitmap interface

HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitmapIter must be

Re: [Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

On 11/25/2015 10:46 AM, Fam Zheng wrote: > On Tue, 11/24 06:49, Eric Blake wrote: >> On 11/24/2015 04:37 AM, Fam Zheng wrote: >> I think the patch should be dropped, and periodic progress reports should be emitted from within the dump loops that do the heavy lifting. For the

Re: [Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

On Wed, 11/25 12:48, Peter Xu wrote: > > > On 11/25/2015 10:46 AM, Fam Zheng wrote: > > On Tue, 11/24 06:49, Eric Blake wrote: > >> On 11/24/2015 04:37 AM, Fam Zheng wrote: > >> > I think the patch should be dropped, and periodic progress reports > should be emitted from within the

Re: [Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

On 11/24/2015 08:05 PM, Paolo Bonzini wrote: > > > On 24/11/2015 04:10, Fam Zheng wrote: >> What about all the hot-plug commands that changes the memory layout? > > If the guest is stopped, they shouldn't. device_add does not enable new > BARs for example, the guest does that after it

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

On Tue, Nov 24, 2015 at 7:18 PM, Lan Tianyu wrote: > On 2015年11月24日 22:20, Alexander Duyck wrote: >> I'm still not a fan of this approach. I really feel like this is >> something that should be resolved by extending the existing PCI hot-plug >> rather than trying to

Re: [Qemu-devel] [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

On Tue, Nov 24, 2015 at 1:20 PM, Michael S. Tsirkin wrote: > On Tue, Nov 24, 2015 at 09:38:18PM +0800, Lan Tianyu wrote: >> This patch is to add migration support for ixgbevf driver. Using >> faked PCI migration capability table communicates with Qemu to >> share migration status

[Qemu-devel] [PATCH] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

Re: [Qemu-devel] [PATCH v3 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

On Thu, Nov 19, 2015 at 12:40 PM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois > --- > > Changes since v1: > * rework loging to match other i.MX drivers > > Changes since v2: > * We moved to an inheritance QOM scheme > >

Re: [Qemu-devel] [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

On 2015年11月25日 05:20, Michael S. Tsirkin wrote: > I have to say, I was much more interested in the idea > of tracking dirty memory. I have some thoughts about > that one - did you give up on it then? No, our finial target is to keep VF active before doing migration and tracking dirty memory is

Re: [Qemu-devel] RFC: raspberry pi / pi2 / Windows-on-ARM support

On Tue, Nov 24, 2015 at 4:00 PM, Andrew Baumann wrote: > Hi Peter (et al), > > I am working on refactoring the Pi support code as you suggested. I have > split the Pi SOCs into separate objects (bcm2835 and bcm2836) which both > instantiate a third common

Re: [Qemu-devel] [PATCH v2 0/2] net/tap-win32 bugfixes

Am 25.11.2015 um 04:01 schrieb Jason Wang: > > > On 11/25/2015 07:36 AM, Andrew Baumann wrote: >> Ping? >> >> Jason, I know you planned to leave this for a few days... I just wanted to >> make sure it isn't forgotten :) >> >> Thanks, >> Andrew > > Thanks for working on this. I would expect

Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpoint

Thanks Jason, On Wed, 25 Nov 2015 10:38:51 +0800, jasow...@redhat.com wrote: > > @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class, > > void *data) > > c->class_id = PCI_CLASS_NETWORK_ETHERNET; > > c->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE; > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

David, Alexey, Any comments on this patch? Suka Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() | call in qemu. This call returns the processor module (socket), chip and core | information as specified in

Re: [Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Add support for high DDR memory regions

On Mon, Nov 23, 2015 at 9:00 PM, Alistair Francis wrote: > The Xilinx EP108 supports three memory regions: > - A 2GB region starting at 0 > - A 32GB region starting at 32GB > - A 256GB region starting at 768GB > > This patch adds support for the middle memory

Re: [Qemu-devel] [PATCH COLO-Frame v11 07/39] migration: Integrate COLO checkpoint process into loadvm

On 2015/11/25 2:14, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: Switch from normal migration loadvm process into COLO checkpoint process if COLO mode is enabled. We add three new members to struct MigrationIncomingState, 'have_colo_incoming_thread' and

Re: [Qemu-devel] [PATCH COLO-Frame v11 08/39] migration: Rename the'file' member of MigrationState

On 2015/11/25 2:26, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: Rename the 'file' member of MigrationState to 'to_dst_file'. Signed-off-by: zhanghailiang Cc: Dr. David Alan Gilbert --- v11: - Only

Re: [Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6

Hmm, stop. Very bad thing (sorry, that I didn't realize it before): This breaks my dirty bitmap migration series with its meta bitmaps. Meta bitmap is an additional HBitmap in BdrvDirtyBitmap, which tracks dirtiness of this BdrvDirtyBitmap. And it (meta bitmap) have its own granularity of

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

Hello! > There are a number of different interesting page sizes here: > * the host kernel page size > * the target CPU architecture's worst-case smallest page size > * the page size the guest kernel is actually using at the moment >(consider a 4K-page guest kernel on a 64K-page host

[Qemu-devel] [Bug 1519037] Re: qemu-i386 32-bit segfault

It seems this crash only happens in xterm (and not normal console). Having compared the respective environment vars the culprit turned out to be: TERM=xterm-color You're welcome. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH v3 2/3] i.MX: Split the CCM class into an abstact base class and a concrete class.

On Tue, Nov 24, 2015 at 3:17 PM, Jean-Christophe DUBOIS wrote: > Le 24/11/2015 23:04, Peter Crosthwaite a écrit : >> >> On Thu, Nov 19, 2015 at 12:40 PM, Jean-Christophe Dubois >> wrote: >>> >>> The IMX_CCM class is now the base abstract class that is

Re: [Qemu-devel] KVM/Qemu migration under fast network stress

On Wed, Nov 25, 2015 at 1:44 AM, Or Gerlitz wrote: > Hi, > > When doing live migration with iperf running on the migrated VM > over PV/virtio interface -- it doesn't end when the number of threads > 1 :( > nor when we run an IO (fio) benchmark which gets high-throughput.

Re: [Qemu-devel] [PATCH v3 2/3] i.MX: Split the CCM class into an abstact base class and a concrete class.

On Thu, Nov 19, 2015 at 12:40 PM, Jean-Christophe Dubois wrote: > The IMX_CCM class is now the base abstract class that is used by EPIT and GPT > timer implementation. > > IMX31_CCM class is the concrete class implementing CCM for i.MX31 SOC. > > For now the i.MX25 continues

[Qemu-devel] [trivial for-2.6] util/id: fully allocate names table

Trivial: this array should be allocated to have ID_MAX entries always. Otherwise if someone were to forget to expand this table, the assertion in the id generator won't actually trigger; it will read junk data. Signed-off-by: John Snow --- util/id.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 0/2] net/tap-win32 bugfixes

Ping? Jason, I know you planned to leave this for a few days... I just wanted to make sure it isn't forgotten :) Thanks, Andrew > -Original Message- > From: Andrew Baumann > Sent: Wednesday, 18 November 2015 11:45 > To: qemu-devel@nongnu.org > Cc: Jason Wang ;

Re: [Qemu-devel] RFC: raspberry pi / pi2 / Windows-on-ARM support

Hi Peter (et al), I am working on refactoring the Pi support code as you suggested. I have split the Pi SOCs into separate objects (bcm2835 and bcm2836) which both instantiate a third common bcm2835_peripherals device that in turn contains all the common devices. I have also switched the code

Re: [Qemu-devel] [PATCH v4 0/4] usb-mtp events support

Gerd Hoffmann writes: > On Mo, 2015-11-23 at 16:37 -0500, Bandan Das wrote: >> This series adds support for mtp events that are piggybacked on >> top of the Linux provided inotify mechanism. It performs well with some >> light unit testing in a linux guest. The mtp share is

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

On Sat, Nov 21, 2015 at 10:05:37AM -0500, Andrew Jones wrote: > On Fri, Nov 20, 2015 at 04:41:21PM -0500, Andrew Jones wrote: > > On Fri, Nov 20, 2015 at 06:19:14PM +, Peter Maydell wrote: > > > On 19 November 2015 at 14:53, Andrew Jones wrote: > > > > + > > > > +if

Re: [Qemu-devel] [PATCH for-2.5 1/1] vhost-user: do not send SET_VRING_ENABLE at start

On Tue, Nov 24, 2015 at 05:10:36PM +0100, Thibaut Collet wrote: > This patch reverts partially commit 3a12f32229a. > > In case of live migration several queues can be enabled and not only the first > one. So inform backend that only the first queue is enabled is wrong. > > Since commit

Re: [Qemu-devel] [RFC PATCH V2 09/10] Qemu/VFIO: Add SRIOV VF migration support

On Tue, Nov 24, 2015 at 09:35:26PM +0800, Lan Tianyu wrote: > This patch is to add SRIOV VF migration support. > Create new device type "vfio-sriov" and add faked PCI migration capability > to the type device. > > The purpose of the new capability > 1) sync migration status with VF driver in the

Re: [Qemu-devel] [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

On Tue, Nov 24, 2015 at 09:38:18PM +0800, Lan Tianyu wrote: > This patch is to add migration support for ixgbevf driver. Using > faked PCI migration capability table communicates with Qemu to > share migration status and mailbox irq vector index. > > Qemu will notify VF via sending MSIX msg to

Re: [Qemu-devel] [PATCH v2 2/2] tests: add file-write-read test

On 11/24/2015 11:04 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This test exhibits a POSIX behaviour regarding switching between write > and read. It's undefined result if the application doesn't ensure a > flush between the two operations

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

On 24 November 2015 at 21:45, Andrew Jones wrote: > On Tue, Nov 24, 2015 at 09:08:29PM +, Peter Maydell wrote: >> Also, if we're currently executing a 32-bit guest when we take >> the core dump, you probably need to call aarch64_sync_32_to_64() >> somewhere. > > I think

Re: [Qemu-devel] [PATCH v4 03/17] ipmi: Add a local BMC simulation

On 11/24/2015 07:31 AM, Cédric Le Goater wrote: > A few comments below, Thanks a bunch for the review. As you probably have guessed, this was not really intended as a fully functional BMC, though it has most of the trappings of what you would need to implement one. I assume you are working on

Re: [Qemu-devel] [PATCH for-2.5] qga: Better mapping of SEEK_* in guest-file-seek

Hi On Tue, Nov 24, 2015 at 8:09 PM, Eric Blake wrote: > On 11/24/2015 11:57 AM, Eric Blake wrote: >> Exposing OS-specific SEEK_ constants in our qapi was a mistake >> (if the host has SEEK_CUR as 1, but the guest has it as 2, then >> the semantics are unclear what should

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

On 24 November 2015 at 20:52, Andrew Jones wrote: > > I've pulled a v2 together that I'll be testing and posting soon. Here's > what I decided to do > > 1) Throw the fp registers in. Why not? > 2) No linux-headers update, as we'd also need >include/uapi/linux/elfcore.h and

Re: [Qemu-devel] [PATCH for-2.5 1/1] vhost-user: do not send SET_VRING_ENABLE at start

On Tue, Nov 24, 2015 at 10:05:27PM +0100, Thibaut Collet wrote: > On Tue, Nov 24, 2015 at 9:52 PM, Michael S. Tsirkin wrote: > > On Tue, Nov 24, 2015 at 05:10:36PM +0100, Thibaut Collet wrote: > >> This patch reverts partially commit 3a12f32229a. > >> > >> In case of live

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

Dear Max, Max Reitz writes: > OK, so it is expected for s390x; however, this is strictly speaking not > the output file for s390x but for any platform but PC. That's why I'd > rather not have it in this “generic” reference output. > > This patch already assumes that the

Re: [Qemu-devel] [PATCH 5/5] target-arm: support QMP dump-guest-memory

On Tue, Nov 24, 2015 at 09:08:29PM +, Peter Maydell wrote: > On 24 November 2015 at 20:52, Andrew Jones wrote: > > > > I've pulled a v2 together that I'll be testing and posting soon. Here's > > what I decided to do > > > > 1) Throw the fp registers in. Why not? > > 2) No

Re: [Qemu-devel] [PATCH for-2.5 v2 0/2] qga: flush explicitly when needed

On 11/24/2015 11:04 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Without this change, a write() followed by a read() may lose the > previously written content, as shown in the following test. > > v1->v2: > - replace guchar with unsigned char

Re: [Qemu-devel] [PATCH v2 1/2] qga: flush explicitly when needed

On 11/24/2015 11:04 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > According to the specification: > http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html > > "the application shall ensure that output is not directly followed by

Re: [Qemu-devel] [PATCH for-2.5 1/1] vhost-user: do not send SET_VRING_ENABLE at start

On Tue, Nov 24, 2015 at 9:52 PM, Michael S. Tsirkin wrote: > On Tue, Nov 24, 2015 at 05:10:36PM +0100, Thibaut Collet wrote: >> This patch reverts partially commit 3a12f32229a. >> >> In case of live migration several queues can be enabled and not only the >> first >> one. So

Re: [Qemu-devel] [PATCH v2 0/1] ide-test: tidy up after pio race fix

On 11/24/2015 02:36 PM, John Snow wrote: > Post-rc1 cleanup of the ATAPI tests that were problematic during the > rc0 testing window. This set does two things: > > (1) Fix the timeouts to be more deterministic, and > (2) Finish tidying up the PIO loop. > > v2: > - Clarify the commit message

Re: [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME

- Original Message - > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> Marc-André Lureau writes: > >> > >> > - Original Message - > >> >> Signed-off-by: Markus Armbruster > >> >> --- > >>

Re: [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address

On Tue, Nov 17, 2015 at 04:37:48PM -0800, Hollis Blanchard wrote: > On 11/13/2015 02:23 AM, Stefan Hajnoczi wrote: > >On Wed, Nov 11, 2015 at 05:09:58PM -0800, Hollis Blanchard wrote: > >>Recording the MemoryRegion pointers isn't helpful, especially since no trace > >>data allows us to correlate

Re: [Qemu-devel] [RFC v1] virtio-crypto specification

Hello Varun, > -Original Message- > From: Varun Sethi [mailto:varun.se...@freescale.com] > Sent: Wednesday, November 25, 2015 3:08 AM > Subject: RE: [RFC v1] virtio-crypto specification > > Hi Gonglei, > We have been working on the virtio-ipsec look-aside accelerator device >

[Qemu-devel] [PATCH v2 08/14] sheepdog: Assign bs to file in sd_co_get_block_status

Signed-off-by: Fam Zheng --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0f6789e..d5e7ff8 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -2740,6 +2740,9 @@ sd_co_get_block_status(BlockDriverState *bs,

[Qemu-devel] [PATCH v2 10/14] vpc: Assign bs->file->bs to file in vpc_co_get_block_status

Signed-off-by: Fam Zheng --- block/vpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index 912f5d0..412ff41 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -588,6 +588,7 @@ static int64_t coroutine_fn vpc_co_get_block_status(BlockDriverState

[Qemu-devel] [PATCH v2 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status

Signed-off-by: Fam Zheng --- block/qed.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qed.c b/block/qed.c index a6bbd8b..03af9c1 100644 --- a/block/qed.c +++ b/block/qed.c @@ -692,6 +692,7 @@ typedef struct { uint64_t pos; int64_t status; int

[Qemu-devel] [PATCH v2 13/14] qemu-img: Use QAPI visitor to generate JSON

A visible improvement is that "filename" is now included in the output if it's valid. Signed-off-by: Fam Zheng --- qemu-img.c | 39 --- tests/qemu-iotests/122.out | 96 ++ 2 files changed, 79

Re: [Qemu-devel] QEMU versus Facebook's Infer static analysis tool

On Sat, Nov 14, 2015 at 09:53:44PM +, Peter Maydell wrote: > So I tried out Facebook's Infer static analysis tool (http://fbinfer.com/) > on QEMU this evening, just to see whether it would be able to handle our > codebase and if it would report anything interesting. > > The good news is it

[Qemu-devel] [PATCH v2 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status

Signed-off-by: Fam Zheng --- block/parallels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels.c b/block/parallels.c index d1146f1..6552f32 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -273,6 +273,7 @@ static int64_t coroutine_fn

[Qemu-devel] [PATCH v2 04/14] raw: Assign bs to file in raw_co_get_block_status

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- block/raw-posix.c | 1 + block/raw_bsd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 2cd7d68..9988aa4 100644 --- a/block/raw-posix.c +++

[Qemu-devel] [PATCH v2 12/14] qemu-img: Make MapEntry a QAPI struct

The "flags" bit mask is expanded to two booleans, "data" and "zero"; "bs" is replaced with "filename" string. Signed-off-by: Fam Zheng --- qapi/block-core.json | 28 qemu-img.c | 48 ++-- 2 files

[Qemu-devel] [PATCH v2 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 2d1e230..8c7f1b3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -625,6 +625,9 @@ out: if

[Qemu-devel] [PATCH v2 11/14] vmdk: Return extent's file in bdrv_get_block_status

Signed-off-by: Fam Zheng --- block/vmdk.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index f5a56fd..b60a5af 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1265,6 +1265,7 @@ static int64_t coroutine_fn

[Qemu-devel] [PATCH v2 09/14] vdi: Assign bs->file->bs to file in vdi_co_get_block_status

Signed-off-by: Fam Zheng --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 2199fd3..6b1a57b 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -550,6 +550,7 @@ static int64_t coroutine_fn vdi_co_get_block_status(BlockDriverState *bs,

[Qemu-devel] [PATCH] target-mips/cpu.h: Fix spell error

CP0IntCtl_IPPC1, the last letter should be 'i', not 'one'. Signed-off-by: Dongxue Zhang --- target-mips/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 89c01f7..17817c3 100644 --- a/target-mips/cpu.h +++

[Qemu-devel] [PATCH for-2.5] vnc: fix segfault

Commit "c7628bf vnc: only alloc server surface with clients connected" missed one rarely used codepath (cirrus with guest drivers using 2d accel) where we have to check for the server surface being present, to avoid qemu crashing with a NULL pointer dereference. Add the check. Reported-by:

[Qemu-devel] [PATCH v2 01/14] block: Add "file" output parameter to block status query functions

The added parameter can be used to return the BDS pointer which the valid offset is referring to. It's value should be ignored unless BDRV_BLOCK_OFFSET_VALID in ret is set. Until block drivers fill in the right value, let's clear it explicitly right before calling .bdrv_get_block_status.

[Qemu-devel] [PATCH v2 02/14] qcow: Assign bs->file->bs to file in qcow_co_get_block_status

Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- block/qcow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow.c b/block/qcow.c index 558f443..b59383f 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -509,6 +509,7 @@ static int64_t

[Qemu-devel] [PATCH v2 00/14] qemu-img map: Allow driver to return file of the allocated block

v2: Add Eric's rev-by in patches 2, 4, 5. 01: Refering -> referring in commit message. [Eric] Recurse to "file" for sensible "zero" flag. [Paolo] 12: New. Make MapEntry a QAPI struct. [Paolo, Markus] I stumbled upon this when looking at external bitmap formats. Current "qemu-img

[Qemu-devel] [PATCH v2 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status

Signed-off-by: Fam Zheng --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 836888c..7634c42 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1302,6 +1302,7 @@ static int64_t coroutine_fn

[Qemu-devel] [PATCH v2 14/14] iotests: Add "qemu-img map" test for VMDK extents

Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 10 ++ tests/qemu-iotests/059.out | 38 ++ 2 files changed, 48 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index 0ded0c3..261d8b0 100755 ---

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Implement 'REPORT TARGET PORT GROUPS'

On Mon, Nov 16, 2015 at 03:36:58PM +0100, Hannes Reinecke wrote: > +/* Enable TGPS bit */ > +if (s->wwn) > +outbuf[4] = 1; QEMU coding style: Please always use curly braces, even if the if statement body is just one line. > +static void

Re: [Qemu-devel] [OpenBIOS] [Qemu-ppc] CUDA has problems with Mac OS 10.4

On Tue, Nov 24, 2015 at 12:06 AM, Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > On 24/11/15 05:23, Alfonso Gamboa wrote: > > > Here are some links I packaged for the emaculation forum, included is an > > image with macsbug installed already. I had success booting to desktop. > > > >

Re: [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME

Marc-André Lureau writes: > - Original Message - >> Signed-off-by: Markus Armbruster >> --- >> hw/misc/ivshmem.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c >> index 83d7bd3..a6bfdde 100644 >>

Re: [Qemu-devel] [PATCH COLO-Frame v11 04/39] migration: Export migrate_set_state()

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Fix the first parameter of migrate_set_state(), and export it. > We will use it in later. > > Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert > --- > v11: > - New

Re: [Qemu-devel] [PULL 0/2] target-mips queue

et> > > The following changes since commit 5522a841cab5f15ac0f8d207b320c21755a7a1a5: > > Merge remote-tracking branch 'remotes/ehabkost/tags/numa-pull-request' into > staging (2015-11-23 16:07:49 +) > > are available in the git repository at: > > git://githu

Re: [Qemu-devel] [PATCH v5 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

On 11/24/2015 09:55 AM, Gabriel L. Somlo wrote: > On Tue, Nov 24, 2015 at 04:14:50AM +0800, kbuild test robot wrote: >> >>drivers/firmware/qemu_fw_cfg.c: In function 'fw_cfg_cmdline_set': drivers/firmware/qemu_fw_cfg.c:510:7: warning: format '%lli' expects argument of type 'long

Re: [Qemu-devel] [PATCH for-2.5 5/5] ivshmem: Rename property memdev to x-memdev for 2.5

- Original Message - > The device's guest interface and its QEMU user interface are > flawed^Whotly debated. We'll resolve that in the next development > cycle, probably by deprecating the device in favour of a cleaned up, > but not quite compatible revision. > > To avoid adding more

Re: [Qemu-devel] [PATCH 1/2] ide-test: fix timeouts

On 11/24/2015 10:40 AM, Kevin Wolf wrote: > Am 20.11.2015 um 23:53 hat John Snow geschrieben: >> Use explicit timeouts instead of trying to fudge >> it by counting nsleep calls. >> >> Signed-off-by: John Snow > > Isn't wrapping lines at 50 characters a bit extreme? > Yes.

Re: [Qemu-devel] [PATCH for-2.5 5/5] ivshmem: Rename property memdev to x-memdev for 2.5

Forgot to include the doc update. Need to squash in: diff --git a/qemu-doc.texi b/qemu-doc.texi index 460ab71..45d37e5 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -1300,7 +1300,7 @@ a memory backend that has hugepage support: @example qemu-system-i386 -object

Re: [Qemu-devel] [PATCH 2/2] tests: add file-write-read test

On 11/24/2015 09:34 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This test exhibits a POSIX behaviour regarding switching between write > and read. It's undefined result if the application doesn't ensure a > flush between the two operations

[Qemu-devel] Bug: QEMU segfault within vnc

Hi, QEMU segfault while running a Xen guest, the guest is a WinXP. To reproduce, I start the guest, I don't connect to vnc, and after about 2min, QEMU segv. I think it's around the time it take for windows to boot and reach the desktop. The first commit where this happen is: vnc: fix local

  1   2   3   4   5   >