Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

Alexander Graf wrote: > On 26.11.15 16:31, Dr. David Alan Gilbert wrote: >> * Alexander Graf (ag...@suse.de) wrote: >>> >>> >>> On 30.10.15 17:50, Mark Cave-Ayland wrote: On 26/10/15 09:48, Mark Cave-Ayland wrote: > On 06/09/15 12:54, Mark Cave-Ayland wrote: >

Re: [Qemu-devel] RFC: raspberry pi / pi2 / Windows-on-ARM support

> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Thursday, 26 November 2015 11:39 > So I am looking at some recent news, and there is the RPi Zero which reuses > the bcm2835 as a different board. Can't find the schematic yet, but from > what I can see, this is a raw SoC (no

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Add /system-id

On Thu, Nov 26, 2015 at 03:29:07PM +1100, Alexey Kardashevskiy wrote: > On 11/26/2015 11:49 AM, David Gibson wrote: > >On Wed, Nov 25, 2015 at 04:15:01PM +0100, Alexander Graf wrote: > >> > >> > >>On 18.11.15 11:49, David Gibson wrote: > >>>On Wed, Nov 18, 2015 at 06:45:39PM +1100, Alexey

Re: [Qemu-devel] [PATCH v4 2/3] i.MX: Split the CCM class into an abstact base class and a concrete class.

On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: > The IMX_CCM class is now the base abstract class that is used by EPIT and GPT > timer implementation. > > IMX31_CCM class is the concrete class implementing CCM for i.MX31 SOC. > > For now the i.MX25 continues

Re: [Qemu-devel] [PATCH v4 1/3] i.MX: rename i.MX CCM get_clock() function and CLK ID enum names

On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: > This is to prepare for CCM code refactoring. > > This is just a bit of function and enum values renaming. > > We also remove some useless intermediate variables. > > Signed-off-by: Jean-Christophe Dubois

Re: [Qemu-devel] [PATCH v4 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

On Wed, Nov 25, 2015 at 11:16 PM, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois This seems to slow down boot performance for i.MX25 Linux. Admittedly, the issue looks to be in timeout code for an unmodelled periph (NAND):

[Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

This patch is only adding the QMP/HMP interface for "dump-query" command, but not implementing them. This command could be used to query background dump status. Please refer to the next patch to see how dump status are defined. Currently, only fake results are returned. Signed-off-by: Peter Xu

[Qemu-devel] [PATCH v2 6/8] dump-query: implement "status" of "dump-query" command.

This patch implements the status changes inside dump process. When query dump status, three possible results could be: 1. never started dump: { "status": "NOT_STARTED", "percentage": "N/A" } 2. one dump is running in background: { "status": "IN_PROGRESS", "percentage": "{0..100}%" } 3. no dump

[Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

Sorry that this v2 series cannot be aligned with the v1 series. One patch is added at the begining of the series to do some code cleanups (also fix potential memory leak). Meanwhile, several new patches are appended to the v1 series. Please see the change log for more info. v2 changes: - fixed

[Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

It might be a little bit confusing to do dump_cleanup() in these two functions (and error prone, please see section below). A better way is to do dump_cleanup() before dump finish, no matter whether dump has succeeded or not. Meanwhile, this patch will also fix the potential memory leaks that

Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

Hi, all, Sorry that I forgot to CC reviewers and maintainers when posting the patch set. :( Please review! Thanks. Peter On 11/27/2015 10:48 AM, Peter Xu wrote: > Sorry that this v2 series cannot be aligned with the v1 series. One > patch is added at the begining of the series to do some code

[Qemu-devel] [PULL for-2.5 3/3] tap-win32: disable broken async write path

From: Andrew Baumann The code under the TUN_ASYNCHRONOUS_WRITES path makes two incorrect assumptions about the behaviour of the WriteFile API for overlapped file handles. First, WriteFile does not update the lpNumberOfBytesWritten parameter when the write completes

[Qemu-devel] [PULL for-2.5 1/3] eepro100: Prevent two endless loops

From: Stefan Weil http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg04592.html shows an example how an endless loop in function action_command can be achieved. During my code review, I noticed a 2nd case which can result in an endless loop. Reported-by: Qinghao Tang

[Qemu-devel] [PULL for-2.5 0/3] Net patches for 2.5

The following changes since commit b04fc428356a540fdb9065fa8c3c71ee476c2031: Update version for v2.5.0-rc2 release (2015-11-26 17:50:12 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to

[Qemu-devel] [PULL for-2.5 2/3] tap-win32: skip unexpected nodes during registry enumeration

From: Andrew Baumann In order to find a named tap device, get_device_guid() enumerates children of HKLM\SYSTEM\CCS\Control\Network\{4D36E972-E325-11CE-BFC1-08002BE10318} (aka NETWORK_CONNECTIONS_KEY). For each child, it then looks for a "Connection" subkey, but if

Re: [Qemu-devel] [PATCH v3 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

On Wed, Nov 25, 2015 at 11:14 PM, Jean-Christophe DUBOIS wrote: > Le 25/11/2015 06:51, Peter Crosthwaite a écrit : >> >> On Thu, Nov 19, 2015 at 12:40 PM, Jean-Christophe Dubois >> wrote: >>> >>> Signed-off-by: Jean-Christophe Dubois

[Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

This patch only adds the interfaces, but not implements them. "detach" parameter is made optional, to make sure that all the old dump-guest-memory requests will still be able to work. Signed-off-by: Peter Xu --- dump.c | 5 +++-- hmp-commands.hx | 5 +++-- hmp.c

[Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

To get aligned with QMP interface, one new QMP event DUMP_COMPLETED is added. It is used when user specified "detach" in dump, and triggered when the dump finishes. Error message will be appended to this event if the dump has failed. Signed-off-by: Peter Xu ---

[Qemu-devel] [PATCH v2 8/8] dump-query: make the percentage accurate.

By calculating the total_size and written_size of memory, we could get relatively accurate percentage of finished dump. Signed-off-by: Peter Xu --- dump.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 65bd5fb..0fcad28 100644

Re: [Qemu-devel] [PATCH v6 3/3] target-i386: add support to migrate vcpu's TSC rate

On 11/26/15 12:19, Eduardo Habkost wrote: > On Tue, Nov 24, 2015 at 11:33:57AM +0800, Haozhong Zhang wrote: > > This patch enables migrating vcpu's TSC rate. If KVM on the destination > > machine supports TSC scaling, guest programs will observe a consistent > > TSC rate across the migration. > >

Re: [Qemu-devel] [iGVT-g] XenGT for PV guest

On 11/27/2015 01:10 AM, Oleksii Kurochko wrote: Hello all, Do you have any ideas about previously mentioned question? With best regards, Oleksii On Tue, Nov 24, 2015 at 6:48 PM, Oleksii Kurochko > wrote: Hi

[Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

This patch implements "detach" for "dump-guest-memory" command. When specified, one background thread is created to do the dump work. When there is a dump running in background, the commands "stop", "cont" and "dump-guest-memory" will fail directly, with a hint telling user: "there is a dump in

[Qemu-devel] [PATCH v2 7/8] DumpState: adding total_size and written_size fields

Here, total_size is the size in bytes to be dumped (raw data, which means before compression), while written_size are bytes handled (raw size too). These two fields could be used when do "dump-query". With these information, we could get a very accurate percentage of finished work.

Re: [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

On Fri, 11/27 10:48, Peter Xu wrote: > It might be a little bit confusing to do dump_cleanup() in these two > functions (and error prone, please see section below). A better way > is to do dump_cleanup() before dump finish, no matter whether dump > has succeeded or not. > > Meanwhile, this patch

Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

On Fri, 11/27 10:48, Peter Xu wrote: > This patch implements "detach" for "dump-guest-memory" command. When > specified, one background thread is created to do the dump work. > > When there is a dump running in background, the commands "stop", > "cont" and "dump-guest-memory" will fail directly,

Re: [Qemu-devel] [PATCH COLO-Frame v11 18/39] COLO: Flush PVM's cached RAM into SVM's memory

On 11/24/2015 05:25 PM, zhanghailiang wrote: During the time of VM's running, PVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM cache will always be some with PVM's memory after

[Qemu-devel] [Patch v12 05/10] docs: block replication's description

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 227 + 1 file changed, 227 insertions(+) create mode

Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

On 11/27/2015 01:14 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> This patch implements "detach" for "dump-guest-memory" command. When >> specified, one background thread is created to do the dump work. >> >> When there is a dump running in background, the commands "stop", >>

Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

On 11/27/2015 01:19 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp) >> static void *dump_thread(void *data) >> { >> GlobalDumpState *global = (GlobalDumpState *)data; >> -

[Qemu-devel] [PATCH for 2.5 1/1] e1000: fix hang of win2k12 shutdown with flood ping

e1000 driver in Win2k12 is really well rotten. It 100% hangs on shutdown of UP VM under flood ping. The guest checks card state and reinjects itself interrupt in a loop. This is fatal for UP machine. There is no good way to fix this misbehavior but to kludge it. The emulation has interrupt

Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb

On Do, 2015-11-26 at 17:35 +0100, Tim Sander wrote: > Hi > > Below is a patch implementing the i2c-tiny-usb device. Is there a specification for this kind of device? Or does it mimic existing hardware? Please add that into to the comment at the head of the file. > +#ifdef DEBUG_USBI2C >

Re: [Qemu-devel] [PATCH v2 1/8] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

On 11/27/2015 12:28 PM, Fam Zheng wrote: > I think when write_dump_header() returns a failure, it does call > dump_cleanup(), in create_header{32,64}. > > But the changes of code in this patch look sane to me, and the new error > handling is definitely looking better. Yes, you are right. I

Re: [Qemu-devel] [PATCH for 2.5 1/1] e1000: fix hang of win2k12 shutdown with flood ping

On 11/27/2015 09:48 AM, Denis V. Lunev wrote: e1000 driver in Win2k12 is really well rotten. It 100% hangs on shutdown of UP VM under flood ping. The guest checks card state and reinjects itself interrupt in a loop. This is fatal for UP machine. There is no good way to fix this misbehavior but

Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

On Fri, 11/27 10:48, Peter Xu wrote: > This patch only adds the interfaces, but not implements them. > "detach" parameter is made optional, to make sure that all the old > dump-guest-memory requests will still be able to work. > > Signed-off-by: Peter Xu > --- > dump.c

Re: [Qemu-devel] [PATCH] Revert "vhost: send SET_VRING_ENABLE at start/stop"

On Thu, Nov 26, 2015 at 06:52:56PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 26, 2015 at 09:46:08AM +0800, Yuanhan Liu wrote: > > On Wed, Nov 25, 2015 at 02:42:05PM +0200, Michael S. Tsirkin wrote: > > > This reverts commit 3a12f32229a046f4d4ab0a3a52fb01d2d5a1ab76. > > > > > > In case of

Re: [Qemu-devel] [PATCH COLO-Frame v11 32/39] COLO: Separate the process of saving/loading ram and device state

On 11/24/2015 05:25 PM, zhanghailiang wrote: We separate the process of saving/loading ram and device state when do checkpoint, we add new helpers for save/load ram/device. With this change, we can directly transfer ram from master to slave without using QEMUSizeBuffer as assistant, which also

Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

On Fri, 11/27 10:48, Peter Xu wrote: > Sorry that this v2 series cannot be aligned with the v1 series. One > patch is added at the begining of the series to do some code > cleanups (also fix potential memory leak). Meanwhile, several new > patches are appended to the v1 series. Please see the

Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

On 11/27/2015 12:31 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> This patch only adds the interfaces, but not implements them. >> "detach" parameter is made optional, to make sure that all the old >> dump-guest-memory requests will still be able to work. >> >> Signed-off-by:

[Qemu-devel] [Patch v12 06/10] Add new block driver interfaces to control block replication

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino Cc: Michael Roth Reviewed-by: Paolo Bonzini

[Qemu-devel] [Patch v12 01/10] unblock backup operations in backing file

Signed-off-by: Wen Congyang --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index bfc2be8..eaf479a 100644 --- a/block.c +++ b/block.c @@ -1275,6 +1275,24 @@ void bdrv_set_backing_hd(BlockDriverState *bs,

[Qemu-devel] [Patch v12 02/10] Store parent BDS in BdrvChild

We need to access the parent BDS to get the root BDS. Signed-off-by: Wen Congyang --- block.c | 1 + include/block/block_int.h | 1 + 2 files changed, 2 insertions(+) diff --git a/block.c b/block.c index eaf479a..0a0468f 100644 --- a/block.c +++

[Qemu-devel] [Patch v12 03/10] Backup: clear all bitmap when doing block checkpoint

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Jeff Cody --- block/backup.c | 14 ++ blockjob.c | 11 +++

Re: [Qemu-devel] [PATCH v3 2/2] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

On Fri, Nov 13, 2015 at 06:13:08PM -0800, Sukadev Bhattiprolu wrote: > Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter to rtas_get_sysparm() > call in qemu. This call returns the processor module (socket), chip and core > information as specified in section 7.3.16.17 of LoPAPR v2.7. > > We

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/2] target-ppc: Implement rtas_get_sysparm(PROCESSOR_MODULE_INFO)

On Tue, Nov 24, 2015 at 10:30:31PM -0800, Sukadev Bhattiprolu wrote: > David, Alexey, > > Any comments on this patch? Sorry, I've been busy, I've sent comments now. > > Suka > > Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: > | Implement RTAS_SYSPARM_PROCESSOR_MODULE_INFO parameter

Re: [Qemu-devel] [PATCH v13 03/14] qapi: Convert QType into QAPI built-in enum type

On 11/26/2015 07:51 AM, Markus Armbruster wrote: > Eric Blake writes: > >> What's more meta than using qapi to define qapi? :) >> >> Convert QType into a full-fledged[*] builtin qapi enum type, so >> that a subsequent patch can then use it as the discriminator >> type of qapi

Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support.

On Fri, 11/27 13:14, Fam Zheng wrote: > But what I really wonder is why a single boolean is not enough: the DumpState > pointer can be passed to dump_thread, so it doesn't need to be global, then > you > don't need the mutex. Never mind, it's useful in later patches. Fam

Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

On Fri, 11/27 10:48, Peter Xu wrote: > @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp) > static void *dump_thread(void *data) > { > GlobalDumpState *global = (GlobalDumpState *)data; > -dump_process(global->gds_cur, NULL); > +Error *local_err = NULL; > +

Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

On Fri, 11/27 10:48, Peter Xu wrote: > This patch is only adding the QMP/HMP interface for "dump-query" > command, but not implementing them. This command could be used to > query background dump status. Please refer to the next patch to see > how dump status are defined. > > Currently, only fake

[Qemu-devel] [Patch v8 3/3] qmp: add monitor command to add/remove a child

The new QMP command name is x-blockdev-change. It's just for adding/removing quorum's child now, and doesn't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang

[Qemu-devel] [Patch v8 1/3] Add new block driver interface to add/delete a BDS's child

In some cases, we want to take a quorum child offline, and take another child online. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake

[Qemu-devel] [Patch v8 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 8 ++-- block/quorum.c| 124 +-

[Qemu-devel] [Patch v8 0/3] qapi: child add/delete support

If quorum's child is broken, we can use mirror job to replace it. But sometimes, the user only need to remove the broken child, and add it later when the problem is fixed. It is based on the Kevin's child name related patch: http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg04949.html

[Qemu-devel] [Patch v12 04/10] Allow creating backup jobs when opening BDS

When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Stefan Hajnoczi Reviewed-by:

[Qemu-devel] [Patch v12 07/10] quorum: implement block driver interfaces for block replication

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Alberto Garcia --- block/quorum.c | 78 ++ 1

[Qemu-devel] [Patch v12 00/10] Block replication for continuous checkpoints

Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). You can get the detailed information about block replication from here: http://wiki.qemu.org/Features/BlockReplication Usage: Please refer to docs/block-replication.txt This patch series

Re: [Qemu-devel] [PATCH] Fix memory leak on error

On 2015/11/26 20:33, Markus Armbruster wrote: > Stefano Dong (董兴水) writes: > >> hw/ppc/spapr.c: Fix memory leak on error, it was introduced in bc09e0611 >> hw/acpi/memory_hotplug.c: Fix memory leak on error, it was introduced in >> 34f2af3d >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

On 11/27/2015 01:28 PM, Fam Zheng wrote: > Looks good overall! I've replied patches with a few questions. Thanks! > > Fam Thanks! Will wait for more comments and post v3 later. Peter

Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

On 11/27/2015 01:25 PM, Fam Zheng wrote: > On Fri, 11/27 10:48, Peter Xu wrote: >> This patch is only adding the QMP/HMP interface for "dump-query" >> command, but not implementing them. This command could be used to >> query background dump status. Please refer to the next patch to see >> how

Re: [Qemu-devel] [PATCH v2 1/1] parallels: add format spec

On Mon, Nov 23, 2015 at 04:32:37PM +0300, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy > > This specifies Parallels image format as implemented in Parallels Cloud > Server 6.10 > > Signed-off-by: Vladimir Sementsov-Ogievskiy >

Re: [Qemu-devel] [PATCH v3 for-2.5 05/12] qjson: Give each of the six structural chars its own token type

Eric Blake writes: > On 11/25/2015 02:23 PM, Markus Armbruster wrote: >> Simplifies things, because we always check for a specific one. >> >> Signed-off-by: Markus Armbruster >> --- >> include/qapi/qmp/json-lexer.h | 7 ++- >> qobject/json-lexer.c

Re: [Qemu-devel] [PATCH v3 for-2.5 06/12] qjson: Inline token_is_keyword() and simplify

Eric Blake writes: > On 11/25/2015 02:23 PM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> qobject/json-parser.c | 20 +++- >> 1 file changed, 7 insertions(+), 13 deletions(-) >> > >> >> -if

Re: [Qemu-devel] [PATCH v3 for-2.5 07/12] qjson: Inline token_is_escape() and simplify

Eric Blake writes: > On 11/25/2015 02:23 PM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> qobject/json-parser.c | 32 +++- >> 1 file changed, 15 insertions(+), 17 deletions(-) >> > >> +if

Re: [Qemu-devel] [PATCH v1 0/7] KVM: Hyper-V SynIC timers

On 11/26/2015 08:28 AM, Wanpeng Li wrote: 2015-11-25 23:20 GMT+08:00 Andrey Smetanin : Per Hyper-V specification (and as required by Hyper-V-aware guests), SynIC provides 4 per-vCPU timers. Each timer is programmed via a pair of MSRs, and signals expiration by

Re: [Qemu-devel] [PATCH v3 for-2.5 09/12] qjson: Convert to parser to recursive descent

Eric Blake writes: > On 11/25/2015 02:23 PM, Markus Armbruster wrote: >> We backtrack in parse_value(), even though JSON is LL(1) and thus can >> be parsed by straightforward recursive descent. Do exactly that. >> >> Based on an almost-correct patch from Paolo Bonzini. >>

Re: [Qemu-devel] [PATCH for-2.5] Avoid memory leak

On 2015/11/26 11:43, Eric Blake wrote: > On 11/25/2015 06:30 PM, dongxingshui wrote: >> monitor.c: Avoid memory leak >> >> When send a wrong qmp command, a memory leak occurs. Fix it. > > Looks like the leak was introduced in 710aec9; would be worth amending > the commit message to mention

Re: [Qemu-devel] [PATCH for-2.5] Avoid memory leak

stefano writes: > On 2015/11/26 11:43, Eric Blake wrote: >> On 11/25/2015 06:30 PM, dongxingshui wrote: >>> monitor.c: Avoid memory leak >>> >>> When send a wrong qmp command, a memory leak occurs. Fix it. >> >> Looks like the leak was introduced in 710aec9; would be

Re: [Qemu-devel] [PATCH v1 0/7] KVM: Hyper-V SynIC timers

2015-11-26 16:34 GMT+08:00 Andrey Smetanin : > > > On 11/26/2015 08:28 AM, Wanpeng Li wrote: >> >> 2015-11-25 23:20 GMT+08:00 Andrey Smetanin : >>> >>> Per Hyper-V specification (and as required by Hyper-V-aware guests), >>> SynIC provides 4

Re: [Qemu-devel] [PATCH v1 6/7] kvm/x86: Hyper-V SynIC message slot pending clearing at SINT ack

On 11/25/2015 08:14 PM, Paolo Bonzini wrote: On 25/11/2015 17:55, Andrey Smetanin wrote: +gpa = synic->msg_page & PAGE_MASK; +page = kvm_vcpu_gfn_to_page(vcpu, gpa >> PAGE_SHIFT); +if (is_error_page(page)) { +vcpu_err(vcpu, "Hyper-V SynIC can't get msg page, gpa

Re: [Qemu-devel] [PATCH v3 for-2.5 09/12] qjson: Convert to parser to recursive descent

Markus Armbruster writes: > We backtrack in parse_value(), even though JSON is LL(1) and thus can > be parsed by straightforward recursive descent. Do exactly that. > > Based on an almost-correct patch from Paolo Bonzini. > > Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized

Am 25.11.2015 um 17:16 schrieb Paolo Bonzini: On 25/11/2015 16:48, David Engraf wrote: Indeed, TLS handling is broken. The address of iothread_locked is always the same between threads and I can see that a different thread sets iothread_locked to false, thus my current thread uses an invalid

Re: [Qemu-devel] [RFC PATCH 00/40] Sneak peek of virtio and dataplane changes for 2.6

On 11/24/2015 07:00 PM, Paolo Bonzini wrote: > This large series is basically all that I would like to get into 2.6. > It is a combination of several pieces of work on dataplane and > multithreaded block layer. > > It's also a large part of why I would like someone else to look at > miscellaneous

Re: [Qemu-devel] [RFC PATCH 00/40] Sneak peek of virtio and dataplane changes for 2.6

On 11/26/2015 10:36 AM, Christian Borntraeger wrote: > On 11/24/2015 07:00 PM, Paolo Bonzini wrote: >> This large series is basically all that I would like to get into 2.6. >> It is a combination of several pieces of work on dataplane and >> multithreaded block layer. >> >> It's also a large part

Re: [Qemu-devel] [PULL 0/2] Migration pull request

On 25 November 2015 at 14:32, Juan Quintela wrote: > Hi > > This series: > - Ignore madvise return value (david) > > As there is no way to diferentiate an error because the kernel don't > understand HUGE_PAGES and anything else > > - Limit memory usage for block migraiton

Re: [Qemu-devel] [PULL 0/9] Misc patches for QEMU 2.5-rc2 (2015-11-25)

On 25 November 2015 at 17:19, Paolo Bonzini wrote: > The following changes since commit 4b6eda626fdb8bf90472c6868d502a2ac09abeeb: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20151124' into > staging (2015-11-24 17:05:06 +) > > are available in the git

[Qemu-devel] [PATCH v3 0/3] Update tests/qemu-iotests failing cases for the s390 platform

From: Bo Tu v3: 1. Remove patch for test 120 because Fam Zheng upstreamed same fix for test 119 and 120 2. Rename 051.out to 051.s390.out, add rule in Makefile to generate 051.s390-ccw-virtio.out 3. Remove superfluous quotation marks in common.config 4. Add "Acked-by:

[Qemu-devel] [PATCH v3 3/3] qemu-iotests: s390x: fix test 068

From: Bo Tu Now, s390-virtio-ccw is default machine and s390-ccw.img is default boot loader. If the s390-virtio-ccw machine finds no device to load from and errors out, then emits a panic and exits the vm. This breaks test cases 068 for s390x. Adding the parameter of

[Qemu-devel] [PATCH v3 1/3] qemu-iotests: refine common.config

From: Bo Tu Replacing awk with sed, then it's easier to read. Replacing "[ ! -z "$default_alias_machine" ]" with "[[ $default_alias_machine ]]", then it's slightly shorter. Reviewed-by: Max Reitz Suggested-By: Sascha Silbe

[Qemu-devel] [PULL 1/1] vnc: fix segfault

Commit "c7628bf vnc: only alloc server surface with clients connected" missed one rarely used codepath (cirrus with guest drivers using 2d accel) where we have to check for the server surface being present, to avoid qemu crashing with a NULL pointer dereference. Add the check. Reported-by:

[Qemu-devel] [PULL for-2.5 0/1] vnc: fix segfault

repository at: git://git.kraxel.org/qemu tags/pull-vnc-20151126-1 for you to fetch changes up to 7fe4a41c262e2529dc79f77f6fe63c5309fa2fd9: vnc: fix segfault (2015-11-26 08:32:11 +0100) vnc: fix segfault

Re: [Qemu-devel] [PATCH v2 1/1] parallels: add format spec

On 26.11.2015 11:17, Stefan Hajnoczi wrote: On Mon, Nov 23, 2015 at 04:32:37PM +0300, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy This specifies Parallels image format as implemented in Parallels Cloud Server 6.10 Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v2 2/4] qemu-iotests: s390x: fix test 051

Hi Max: On 11/25/2015 11:41 PM, Max Reitz wrote: On 24.11.2015 22:17, Sascha Silbe wrote: This PC/s390x-only hunk looks like an oversight to me. Not really, see http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg01906.html and

Re: [Qemu-devel] [PULL 0/4] Ide patches

On 25 November 2015 at 20:25, John Snow wrote: > The following changes since commit 4b6eda626fdb8bf90472c6868d502a2ac09abeeb: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20151124' into > staging (2015-11-24 17:05:06 +) > > are available in the git

Re: [Qemu-devel] [PATCH RFC 00/14] vhost-user: shutdown and reconnection

On Wed, Sep 09, 2015 at 01:09:52AM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > In a previous series "Add feature to start QEMU without vhost-user > backend", Tetsuya Mukawa proposed to allow the vhost-user backend to > disconnect and

Re: [Qemu-devel] [RFC PATCH 00/40] Sneak peek of virtio and dataplane changes for 2.6

On 26/11/2015 10:36, Christian Borntraeger wrote: > For some unknown reason, this seems to be slightly slower than 2.5-rc1 on my > old z196. (have not net tested the z13) > > your branch is certainly better regarding malloc, but worse regarding others. Thanks for taking the time to test this!

Re: [Qemu-devel] [PULL 0/9] Misc patches for QEMU 2.5-rc2 (2015-11-25)

On 26/11/2015 10:46, Peter Maydell wrote: > On 25 November 2015 at 17:19, Paolo Bonzini wrote: >> The following changes since commit 4b6eda626fdb8bf90472c6868d502a2ac09abeeb: >> >> Merge remote-tracking branch 'remotes/lalrae/tags/mips-20151124' into >> staging

Re: [Qemu-devel] [PATCH v2 1/2] utils: Add warning messages

Lluís Vilanova writes: > Adds a special error object that transforms error messages into > immediately reported warnings. Before I dive into details: my fundamental objection is that _warn is new infrastructure without a use. The new "this is how you should do warnings"

Re: [Qemu-devel] [PATCH v7 12/24] virtio-blk: Functions for op blocker management

Am 26.11.2015 um 08:48 hat Stefan Hajnoczi geschrieben: > On Wed, Nov 25, 2015 at 05:26:02PM +0100, Max Reitz wrote: > > On 25.11.2015 17:18, Kevin Wolf wrote: > > > Am 25.11.2015 um 17:03 hat Max Reitz geschrieben: > > >> On 25.11.2015 16:57, Kevin Wolf wrote: > > >>> Am 09.11.2015 um 23:39 hat

Re: [Qemu-devel] [PULL 0/9] Misc patches for QEMU 2.5-rc2 (2015-11-25)

On 26 November 2015 at 10:40, Paolo Bonzini wrote: > > > On 26/11/2015 10:46, Peter Maydell wrote: >> I definitely don't think we should apply the -fwrapv patch yet; >> would you mind respinning this pullrequest without it? > > In what way does that patch make that thing

Re: [Qemu-devel] [RESEND RFC 2/6] device_tree: introduce load_device_tree_from_sysfs

On 19/11/15 16:22, Eric Auger wrote: > This function returns the host device tree blob from sysfs > (/sys/firmware/devicetree/base). > > This has a runtime dependency on the dtc binary. This functionality > is useful for platform device passthrough where the host device tree > needs to be parsed

Re: [Qemu-devel] [PULL v2 for-2.5 0/6] qemu-ga patch queue for 2.5

On 26 November 2015 at 00:01, Michael Roth wrote: > The following changes since commit 1a4dab849d5d06191ab5e5850f6b8bfcad8ceb47: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-11-25 14:47:06 +) > > are available in the git

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Add /system-id

On Thu, 26 Nov 2015 15:29:07 +1100 Alexey Kardashevskiy wrote: > On 11/26/2015 11:49 AM, David Gibson wrote: > > On Wed, Nov 25, 2015 at 04:15:01PM +0100, Alexander Graf wrote: > >> > >> > >> On 18.11.15 11:49, David Gibson wrote: > >>> On Wed, Nov 18, 2015 at 06:45:39PM +1100,

[Qemu-devel] [PATCH for-2.5] w32: Use gcc option -mthreads

QEMU uses threads / coroutines, therefore support for thread local storage and thread safe libraries (-D_MT) must be enabled by using -mthreads. Reported-by: David Engraf Signed-off-by: Stefan Weil --- configure | 2 ++ 1 file changed, 2 insertions(+)

Re: [Qemu-devel] [PULL 0/9] Misc patches for QEMU 2.5-rc2 (2015-11-25)

On 26/11/2015 11:56, Peter Maydell wrote: > On 26 November 2015 at 10:40, Paolo Bonzini wrote: >> >> >> On 26/11/2015 10:46, Peter Maydell wrote: >>> I definitely don't think we should apply the -fwrapv patch yet; >>> would you mind respinning this pullrequest without it?

Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized

Am 26.11.2015 um 10:12 schrieb David Engraf: > Am 25.11.2015 um 17:16 schrieb Paolo Bonzini: >> >> >> On 25/11/2015 16:48, David Engraf wrote: >>> >>> Indeed, TLS handling is broken. The address of iothread_locked is >>> always >>> the same between threads and I can see that a different thread

Re: [Qemu-devel] [PULL 00/15] vhost, pc: fixes for 2.5

On 19 November 2015 at 13:35, Michael S. Tsirkin wrote: > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PULL 0/9] Misc patches for QEMU 2.5-rc2 (2015-11-25)

On 26 November 2015 at 11:23, Paolo Bonzini wrote: > On 26/11/2015 11:56, Peter Maydell wrote: >> It makes a claim about the semantics that the compiler >> guarantees us which isn't currently valid. (Or >> alternatively, it's implicitly claiming that clang isn't >> a

Re: [Qemu-devel] [PULL for-2.5 0/1] vnc: fix segfault

mote-tracking branch 'remotes/lalrae/tags/mips-20151124' into > staging (2015-11-24 17:05:06 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-vnc-20151126-1 > > for you to fetch changes up to 7fe4a41c262e2529dc79f77f6fe63c53

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: Prevent activation clicks from going to guest

On 26 November 2015 at 01:14, Programmingkid wrote: > When QEMU is brought to the foreground, the click event that activates QEMU > should not go to the guest. Accidents happen when they do go to the guest > without giving the user a change to handle them. Buttons are

[Qemu-devel] [PATCH] Fix memory leak on error

hw/ppc/spapr.c: Fix memory leak on error, it was introduced in bc09e0611 hw/acpi/memory_hotplug.c: Fix memory leak on error, it was introduced in 34f2af3d Signed-off-by: Stefano Dong (董兴水) --- hw/acpi/memory_hotplug.c | 1 + hw/ppc/spapr.c | 1 + 2 files

Re: [Qemu-devel] [RESEND RFC 3/6] device_tree: introduce qemu_fdt_node_path

Eric Auger writes: > This new helper routine returns the node path of a device > referred to by its name and compat string. > > Signed-off-by: Eric Auger > --- > device_tree.c| 40 >

  1   2   3   >