Re: [Qemu-devel] [PATCH v7 14/31] qapi: Drop unused error argument for list and implicit struct

2015-12-08 Thread David Gibson
On Mon, Dec 07, 2015 at 08:55:04PM -0700, Eric Blake wrote: > No backend was setting an error when ending the visit of a list > or implicit struct. Make the callers a bit easier to follow by > making this a part of the contract, and removing the errp > argument - callers can then unconditionally

Re: [Qemu-devel] [PATCH v7 13/31] qapi: Drop unused 'kind' for struct/enum visit

2015-12-08 Thread David Gibson
On Mon, Dec 07, 2015 at 08:55:03PM -0700, Eric Blake wrote: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.5.0-rc3 is now available

2015-12-08 Thread Peter Maydell
On 8 December 2015 at 00:16, Michael Roth wrote: > Hello, > > On behalf of the QEMU Team, I'd like to announce the availability of the > fourth release candidate for the QEMU 2.5 release. This release is meant > for testing purposes and should not be used in a

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.5?] qcow2: always initialize specific image info

2015-12-08 Thread Kevin Wolf
Am 07.12.2015 um 20:44 hat Max Reitz geschrieben: > I'd be completely fine with adding an "else { abort(); }" branch to > qcow2_get_specific_info(). This is actually what I was going to suggest, too. Of course, it's not supposed to fix anything now, but defensive coding has never hurt. Kevin

[Qemu-devel] QEMU/KVM performance gets worser - high load - high interrupts - high context switches

2015-12-08 Thread Gerhard Wiesinger
Hello, Yesterday I looked at my munin statistics on my KVM host and I swar that performance gets worser: load is getting higher, interrupts are getting higher and are high as well as context switches. VMs and applications didn't change that way. You can find graphics at:

Re: [Qemu-devel] [PATCH] virtio-blk: Drop x-data-plane option

2015-12-08 Thread Cornelia Huck
On Tue, 8 Dec 2015 09:56:14 +0800 Fam Zheng wrote: > On Mon, 12/07 21:02, Fam Zheng wrote: > > On Mon, 12/07 12:29, Cornelia Huck wrote: > > > No general objection to removing x-data-plane; but this probably wants > > > a mention on the changelog as x-data-plane has been

Re: [Qemu-devel] [PATCH v7 31/31] RFC: qapi: Adjust layout of FooList types

2015-12-08 Thread David Gibson
On Mon, Dec 07, 2015 at 08:55:21PM -0700, Eric Blake wrote: > By sticking the next pointer first, we don't need a union with > 64-bit padding for smaller types. On 32-bit platforms, this > can reduce the size of uint8List from 16 bytes (or 12, depending > on whether 64-bit ints can tolerate

Re: [Qemu-devel] [PATCH v7 20/31] spapr_drc: Expose 'null' in qom-get when there is no fdt

2015-12-08 Thread David Gibson
On Mon, Dec 07, 2015 at 08:55:10PM -0700, Eric Blake wrote: > Now that the QMP output visitor supports an explicit null > output, we should utilize it to make it easier to diagnose > the difference between a missing fdt vs. a present-but-empty > one. > > (Note that this reverts the behavior of

Re: [Qemu-devel] [PATCH v7 28/31] qapi: Split visit_end_struct() into pieces

2015-12-08 Thread David Gibson
On Mon, Dec 07, 2015 at 08:55:18PM -0700, Eric Blake wrote: > As mentioned in previous patches, we want to call visit_end_struct() > functions unconditionally, so that visitors can release resources > tied up since the matching visit_start_struct() without also having > to worry about error

Re: [Qemu-devel] [PATCH v7 29/31] qapi: Simplify semantics of visit_next_list()

2015-12-08 Thread David Gibson
On Mon, Dec 07, 2015 at 08:55:19PM -0700, Eric Blake wrote: > We have two uses of list visits in the entire code base: one in > spapr_drc (which completely avoids visit_next_list(), feeding in > integers from a different source than uint8List), and one in > qapi-visit.py (that is, all other list

Re: [Qemu-devel] [PATCH v9 6/6] tests/guest-debug: introduce basic gdbstub tests

2015-12-08 Thread Alex Bennée
Peter Maydell writes: > On 12 November 2015 at 16:20, Alex Bennée wrote: >> From: Alex Bennée >> >> The aim of these tests is to combine with an appropriate kernel >> image (with symbol-file vmlinux) and check it behaves as it

[Qemu-devel] [v3 1/3] cutils: add avx2 instruction optimization

2015-12-08 Thread Liang Li
buffer_find_nonzero_offset() is a hot function during live migration. Now it use SSE2 intructions for optimization. For platform supports AVX2 instructions, use the AVX2 instructions for optimization can help to improve the performance about 30% comparing to SSE2. Zero page check can be faster

[Qemu-devel] [v3 3/3] configure: add options to config avx2

2015-12-08 Thread Liang Li
Add the '--enable-avx2' & '--disable-avx2' option so as to config the AVX2 instruction optimization. If '--disable-avx2' is not set, configure will detect if the compiler can support AVX2 option, if yes, AVX2 optimization is eabled, else disabled. Signed-off-by: Liang Li

[Qemu-devel] [v3 2/3] configure: detect ifunc attribute

2015-12-08 Thread Liang Li
Detect if the compiler can support the ifunc attribute, the avx2 optimization depends on ifunc attribute. Signed-off-by: Liang Li --- configure | 20 1 file changed, 20 insertions(+) diff --git a/configure b/configure index b9552fd..394db3b 100755 ---

Re: [Qemu-devel] tcg: improve MAX_CODE_GEN_BUFFER_SIZE for arm

2015-12-08 Thread Laurent Desnogues
Hello, On Tue, Dec 8, 2015 at 11:39 AM, Aurelien Jarno wrote: [...] > I already posted a patch a long time ago to remove the 16MB limit on ARM > hosts: > > http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg01684.html > > However as you can see in the thread, it has

Re: [Qemu-devel] [PATCH v9 3/6] target-arm: kvm - support for single step

2015-12-08 Thread Alex Bennée
Peter Maydell writes: > On 12 November 2015 at 16:20, Alex Bennée wrote: >> This adds support for single-step. There isn't much to do on the QEMU >> side as after we set-up the request for single step via the debug ioctl >> it is all handled

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

2015-12-08 Thread P J P
Hello Jason, +-- On Fri, 4 Dec 2015, Jason Wang wrote --+ | Better with "git send-email". Okay. | What if guest deactivate the device before re-activate the device? |Looks like it could be done through methods: | |1) VMXNET3_CMD_QUIESCE_DEV IIUC, it is used to pause the device when the

Re: [Qemu-devel] tcg: improve MAX_CODE_GEN_BUFFER_SIZE for arm

2015-12-08 Thread Aurelien Jarno
On 2015-12-08 10:43, TeLeMan wrote: > I know MAX_CODE_GEN_BUFFER_SIZE is limited by the host direct branch > instructions.But the arm's MAX_CODE_GEN_BUFFER_SIZE is so small.I > tried improving MAX_CODE_GEN_BUFFER_SIZE.I wrote some check codes for > the overflow offset in tcg_out_b(), tcg_out_bl(),

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Kevin Wolf
Am 07.12.2015 um 17:42 hat Cornelia Huck geschrieben: > On Mon, 7 Dec 2015 11:02:51 +0100 > Cornelia Huck wrote: > > > On Thu, 3 Dec 2015 13:00:00 +0800 > > Stefan Hajnoczi wrote: > > > > > From: Fam Zheng > > > > > > The

Re: [Qemu-devel] tcg: improve MAX_CODE_GEN_BUFFER_SIZE for arm

2015-12-08 Thread Aurelien Jarno
On 2015-12-08 11:51, Laurent Desnogues wrote: > Hello, > > On Tue, Dec 8, 2015 at 11:39 AM, Aurelien Jarno wrote: > [...] > > I already posted a patch a long time ago to remove the 16MB limit on ARM > > hosts: > > > >

Re: [Qemu-devel] [v3 3/3] configure: add options to config avx2

2015-12-08 Thread Peter Maydell
On 8 December 2015 at 12:08, Liang Li wrote: > Add the '--enable-avx2' & '--disable-avx2' option so as to config > the AVX2 instruction optimization. > > If '--disable-avx2' is not set, configure will detect if the compiler > can support AVX2 option, if yes, AVX2

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Christian Borntraeger
On 12/08/2015 01:30 PM, Christian Borntraeger wrote: > On 12/08/2015 01:00 PM, Cornelia Huck wrote: >> On Tue, 8 Dec 2015 10:59:54 +0100 >> Kevin Wolf wrote: >> >>> Am 07.12.2015 um 17:42 hat Cornelia Huck geschrieben: On Mon, 7 Dec 2015 11:02:51 +0100 Cornelia Huck

Re: [Qemu-devel] [PATCH v2 1/4] xen/MSI-X: latch MSI-X table writes

2015-12-08 Thread Stefano Stabellini
On Mon, 7 Dec 2015, Jan Beulich wrote: > >>> On 07.12.15 at 13:41, wrote: > > I know that in your opinion is superfluous, nonetheless could you please > > add 2-3 lines of in-code comment right here, to explain what you are > > doing with the check? Something

[Qemu-devel] [PATCH v3 1/4] xen/MSI-X: latch MSI-X table writes

2015-12-08 Thread Jan Beulich
The remaining log message in pci_msix_write() is wrong, as there guest behavior may only appear to be wrong: For one, the old logic didn't take the mask-all bit into account. And then this shouldn't depend on host device state (i.e. the host may have masked the entry without the guest having done

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Christian Borntraeger
On 12/08/2015 01:00 PM, Cornelia Huck wrote: > On Tue, 8 Dec 2015 10:59:54 +0100 > Kevin Wolf wrote: > >> Am 07.12.2015 um 17:42 hat Cornelia Huck geschrieben: >>> On Mon, 7 Dec 2015 11:02:51 +0100 >>> Cornelia Huck wrote: >>> On Thu, 3 Dec 2015

Re: [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-08 Thread Cao jin
Hi Markus, I have to say, you really did a amazing review for this "trivial "patch, thanks a lot & really appreciate it:) On 12/07/2015 05:59 PM, Markus Armbruster wrote: Cao jin writes: msi_init() is a supporting function in PCI device initialization, in

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Cornelia Huck
On Tue, 8 Dec 2015 10:59:54 +0100 Kevin Wolf wrote: > Am 07.12.2015 um 17:42 hat Cornelia Huck geschrieben: > > On Mon, 7 Dec 2015 11:02:51 +0100 > > Cornelia Huck wrote: > > > > > On Thu, 3 Dec 2015 13:00:00 +0800 > > > Stefan Hajnoczi

[Qemu-devel] [v3 0/3] add avx2 instruction optimization

2015-12-08 Thread Liang Li
buffer_find_nonzero_offset() is a hot function during live migration. Now it use SSE2 intructions for optimization. For platform supports AVX2 instructions, use the AVX2 instructions for optimization can help to improve the performance about 30% comparing to SSE2. Zero page check can be faster

[Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-08 Thread Gerd Hoffmann
rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, use it for both xen and non-xen init. Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index

[Qemu-devel] [PATCH 0/7] igd passthrough chipset tweaks

2015-12-08 Thread Gerd Hoffmann
Hi, We have some code in our tree to support pci passthrough of intel graphics devices (igd) on xen, which requires some chipset tweaks for (a) the host bridge and (b) the lpc/isa-bridge to meat the expectations of the guest driver. For kvm we need pretty much the same, also the requirements

[Qemu-devel] [PATCH 2/7] pc: move igd support code to igd.c

2015-12-08 Thread Gerd Hoffmann
Pure code motion, except for dropping instance_size for TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set, we can inherit it from TYPE_I440FX_PCI_DEVICE). Signed-off-by: Gerd Hoffmann --- hw/pci-host/Makefile.objs | 3 ++ hw/pci-host/igd.c | 96

[Qemu-devel] FD passing for chardevs and chardev backend multiplexing

2015-12-08 Thread Daniel P. Berrange
Historically libvirt has connected stdout & stderr from QEMU directly to a plain file (/var/log/libvirt/qemu/$GUESTNAME.log). This has worked well enough in general, but is susceptible to a guest denial of service if the guest can cause QEMU to spew messages to stderr. There are enough places in

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Christian Borntraeger
On 12/08/2015 03:10 PM, Kevin Wolf wrote: [...] Not a compiler bug. gcc uses a floating point register 8 to spill the pointer of blk (which is call saved) submit_request will later on call qemu_coroutine_enter and after returning from qemu_coroutine_enter, the fpr8 contains

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Kevin Wolf
Am 08.12.2015 um 14:28 hat Christian Borntraeger geschrieben: > On 12/08/2015 01:30 PM, Christian Borntraeger wrote: > > On 12/08/2015 01:00 PM, Cornelia Huck wrote: > >> On Tue, 8 Dec 2015 10:59:54 +0100 > >> Kevin Wolf wrote: > >> > >>> Am 07.12.2015 um 17:42 hat Cornelia Huck

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Christian Borntraeger
On 12/08/2015 02:45 PM, Kevin Wolf wrote: > Am 08.12.2015 um 14:28 hat Christian Borntraeger geschrieben: >> On 12/08/2015 01:30 PM, Christian Borntraeger wrote: >>> On 12/08/2015 01:00 PM, Cornelia Huck wrote: On Tue, 8 Dec 2015 10:59:54 +0100 Kevin Wolf wrote:

[Qemu-devel] [PATCH 3/7] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2015-12-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ef0273b..d1eeafb 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,7 +53,7 @@ out:

[Qemu-devel] [PATCH 5/7] igd: use defines for standard pci config space offsets

2015-12-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 6f52ab1..0784128 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -10,9 +10,9 @@ typedef struct {

Re: [Qemu-devel] Error handling in realize() methods

2015-12-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > In general, code running withing a realize() method should not exit() on > error. Instad, errors should be propagated through the realize() > method. Additionally, the realize() method should fail cleanly, > i.e. carefully undo its side effects

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Cornelia Huck
On Tue, 8 Dec 2015 15:24:29 +0100 Christian Borntraeger wrote: > On 12/08/2015 03:10 PM, Kevin Wolf wrote: > > So this might be a libc bug on s390 then. > > Fixed with > https://sourceware.org/ml/libc-alpha/2013-01/msg00853.html OK, so I need to upgrade that system; no

[Qemu-devel] Error handling in realize() methods

2015-12-08 Thread Markus Armbruster
In general, code running withing a realize() method should not exit() on error. Instad, errors should be propagated through the realize() method. Additionally, the realize() method should fail cleanly, i.e. carefully undo its side effects such as wiring of interrupts, mapping of memory, and so

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Kevin Wolf
Am 08.12.2015 um 14:58 hat Christian Borntraeger geschrieben: > On 12/08/2015 02:45 PM, Kevin Wolf wrote: > > Am 08.12.2015 um 14:28 hat Christian Borntraeger geschrieben: > >> On 12/08/2015 01:30 PM, Christian Borntraeger wrote: > >>> On 12/08/2015 01:00 PM, Cornelia Huck wrote: > On Tue, 8

[Qemu-devel] [PATCH 4/7] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2015-12-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index d1eeafb..6f52ab1 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,12 +53,20 @@ out: return ret; }

Re: [Qemu-devel] Qemu Crashing

2015-12-08 Thread Peter Maydell
On 8 December 2015 at 07:43, Saqib Khan wrote: > I compiled Qemu with following command: > > ./configure --target-list=x86_64-softmmu --enable-debug > > Then I started up my VM using following command : > >

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Christian Borntraeger
On 12/08/2015 02:58 PM, Christian Borntraeger wrote: [...9 >>> >>> Not a compiler bug. gcc uses a floating point register 8 to spill >>> the pointer of blk (which is call saved) submit_request will later >>> on call qemu_coroutine_enter and after returning from >>> qemu_coroutine_enter, the fpr8

Re: [Qemu-devel] [v3 3/3] configure: add options to config avx2

2015-12-08 Thread Li, Liang Z
> On 8 December 2015 at 12:08, Liang Li wrote: > > Add the '--enable-avx2' & '--disable-avx2' option so as to config the > > AVX2 instruction optimization. > > > > If '--disable-avx2' is not set, configure will detect if the compiler > > can support AVX2 option, if yes, AVX2

Re: [Qemu-devel] [PATCH 1/2] Add param Error** to msi_init() & modify the callers

2015-12-08 Thread Markus Armbruster
Cao jin writes: > Hi Markus, > I have to say, you really did a amazing review for this "trivial > "patch, thanks a lot & really appreciate it:) Thanks! I'm afraid the problem you picked isn't trivial, but I hope it's still simple enough to be a useful exercise to

[Qemu-devel] [PATCH 6/7] igd: revamp host config read

2015-12-08 Thread Gerd Hoffmann
Move all work to the host_pci_config_copy helper function, which we can easily reuse when adding q35 support. Open sysfs file only once for all values. Use pread. Proper error handling. Fix bugs: * Don't throw away results (like old host_pci_config_read did because val was passed by value

[Qemu-devel] [PATCH 7/7] igd: add q35 support

2015-12-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 41 - hw/pci-host/q35.c | 6 +- 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ec48875..f6e3f7a 100644 ---

Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests

2015-12-08 Thread Peter Maydell
On 8 December 2015 at 13:45, Kevin Wolf wrote: > Coroutines don't save the FPU state, so you're not supposed to use > floating point operations inside coroutines. That the compiler spills > some integer value into a floating point register is a bit nasty... The compiler will

Re: [Qemu-devel] [PATCH v9 00/10] qcow2: Support refcount order amendment

2015-12-08 Thread Kevin Wolf
Am 27.07.2015 um 17:51 hat Max Reitz geschrieben: > (v1..v7 were named "qcow2: Support refcount orders != 4") > > This series contains the final 10 patches of my qcow2 refcount order > series, which add refcount order amendment functionality to qemu-img. Thanks, applied to block-next (after some

Re: [Qemu-devel] FD passing for chardevs and chardev backend multiplexing

2015-12-08 Thread Eric Blake
On 12/08/2015 07:59 AM, Daniel P. Berrange wrote: > So for this my plan is to stop using the QEMU 'file' backend for char > devs and instead pass across a pre-opened file descriptor, connected > to virtlogd. There is no "officially documented" way to pass in a > file descriptor to QEMU chardevs,

Re: [Qemu-devel] [PATCH] qom: change object property iterator API contract

2015-12-08 Thread Eric Blake
On 11/27/2015 08:27 AM, Daniel P. Berrange wrote: > Currently the object property iterator API works as follows > > ObjectPropertyIterator *iter; > > iter = object_property_iter_init(obj); > while ((prop = object_property_iter_next(iter))) { > ... > } >

Re: [Qemu-devel] [PATCH v3 4/5] crypto: add QCryptoSecret object class for password/key handling

2015-12-08 Thread Eric Blake
On 11/27/2015 09:30 AM, Daniel P. Berrange wrote: > Introduce a new QCryptoSecret object class which will be used > for providing passwords and keys to other objects which need > sensitive credentials. > > More examples are shown in the updated docs. > > Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [iGVT-g] [PATCH 6/7] igd: revamp host config read

2015-12-08 Thread Jike Song
On 12/08/2015 10:07 PM, Gerd Hoffmann wrote: Move all work to the host_pci_config_copy helper function, which we can easily reuse when adding q35 support. Open sysfs file only once for all values. Use pread. Proper error handling. Fix bugs: * Don't throw away results (like old

[Qemu-devel] [PATCH for-2.5] virtio-9p-device: add minimal unrealize handler

2015-12-08 Thread Greg Kurz
Since commit 4652f1640e029e1f2433fa77ba6af285 "virtio-9p: add savevm handlers", if the user hot-unplugs a quiescent 9p device and live migrates, the source QEMU crashes before migration completetion... This happens because virtio-9p devices have a realize handler which calls virtio_init() and

[Qemu-devel] [PATCH v2 1/3] lib/x86: Make free_page() available to call

2015-12-08 Thread Andrey Smetanin
This will be used to release allocated pages by Hyper-V SynIC timers test. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzini CC: Marcelo Tosatti CC: Roman Kagan

Re: [Qemu-devel] [v3 1/3] cutils: add avx2 instruction optimization

2015-12-08 Thread Richard Henderson
On 12/08/2015 04:08 AM, Liang Li wrote: > +++ b/util/buffer-zero-avx2.c > @@ -0,0 +1,54 @@ > +#include "qemu-common.h" > + > +#if defined CONFIG_IFUNC && defined CONFIG_AVX2 > +#include > +#define AVX2_VECTYPE__m256i > +#define AVX2_SPLAT(p) _mm256_set1_epi8(*(p)) > +#define

Re: [Qemu-devel] [PATCH for-2.5] virtio-9p-device: add minimal unrealize handler

2015-12-08 Thread Michael S. Tsirkin
On Tue, Dec 08, 2015 at 04:54:57PM +0100, Greg Kurz wrote: > Since commit 4652f1640e029e1f2433fa77ba6af285 "virtio-9p: add savevm > handlers", > if the user hot-unplugs a quiescent 9p device and live migrates, the source > QEMU crashes before migration completetion... This happens because

Re: [Qemu-devel] [PATCH v3 1/5] util: add base64 decoding function

2015-12-08 Thread Eric Blake
On 11/27/2015 09:30 AM, Daniel P. Berrange wrote: > The standard glib provided g_base64_decode doesn't provide any > kind of sensible error checking on its input. Add a QEMU custom > wrapper qbase64_decode which can be used with untrustworthy > input that can contain invalid base64 characters,

[Qemu-devel] [PATCH v2 0/3] KVM-UNIT-TESTS: Hyper-V SynIC timers test

2015-12-08 Thread Andrey Smetanin
The test checks Hyper-V SynIC timers functionality. The test runs on every vCPU and performs start/stop of periodic/one-shot timers (with period=1ms) and checks validity of received expiration messages in appropriate ISR's. Changes v2: * Share generic Hyper-V tests code * Hyper-V SynIC timers

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 18/19] [RFC] hw/arm/virt: add secure memory region and UART

2015-12-08 Thread Peter Maydell
On 16 November 2015 at 14:05, Peter Maydell wrote: > Add a secure memory region to the virt board, which is the > same as the nonsecure memory region except that it also has > a secure-only UART in it. This is only created if the > board is started with the '-machine

[Qemu-devel] [PATCH v2 2/3] x86/hyperv: Move Hyper-V generic code into hyperv.h/hyperv.c

2015-12-08 Thread Andrey Smetanin
This code will be used as shared between hyperv_synic and hyperv_stimer tests. Signed-off-by: Andrey Smetanin CC: Paolo Bonzini CC: Marcelo Tosatti CC: Roman Kagan CC: Denis V. Lunev CC:

[Qemu-devel] [PATCH v2 3/3] x86: Hyper-V SynIC timers test

2015-12-08 Thread Andrey Smetanin
The test checks Hyper-V SynIC timers functionality. The test runs on every vCPU and performs start/stop of periodic/one-shot timers (with period=1ms) and checks validity of received expiration messages in appropriate ISR's. Changes v2: * reorg code to use generic hyperv.h * split timer test into

Re: [Qemu-devel] [PATCH 06/16] acpi: Save PCMachineState on AcpiBuildState

2015-12-08 Thread Eduardo Habkost
On Mon, Dec 07, 2015 at 05:39:29PM +0200, Marcel Apfelbaum wrote: > On 12/02/2015 03:47 AM, Eduardo Habkost wrote: > >PCMachineState will be used in some of the steps of ACPI table > >building. > > > >Signed-off-by: Eduardo Habkost > >--- > > hw/i386/acpi-build.c | 8

[Qemu-devel] [PATCH v10 4/6] target-arm: kvm - add support for HW assisted debug

2015-12-08 Thread Alex Bennée
This adds basic support for HW assisted debug. The ioctl interface to KVM allows us to pass an implementation defined number of break and watch point registers. When KVM_GUESTDBG_USE_HW is specified these debug registers will be installed in place on the world switch into the guest. The hardware

[Qemu-devel] [PATCH v10 6/6] tests/guest-debug: introduce basic gdbstub tests

2015-12-08 Thread Alex Bennée
The aim of these tests is to combine with an appropriate kernel image (with symbol-file vmlinux) and check it behaves as it should. Given a kernel it checks: - single step - software breakpoint - hardware breakpoint - access, read and write watchpoints On success it returns 0 to the

[Qemu-devel] [PATCH v10 0/6] QEMU support for KVM Guest Debug on arm64

2015-12-08 Thread Alex Bennée
Hi, Here is the latest patch set to support debugging of KVM guests on arm64. The main changes are fixing arm32 compiles (mostly with stubs for the upcomming arm32 debug) and the usual bunch of minor tweaks and clarifications following review. I've kept the GDB Python based test in

[Qemu-devel] [PATCH v10 3/6] target-arm: kvm - support for single step

2015-12-08 Thread Alex Bennée
This adds support for single-step. There isn't much to do on the QEMU side as after we set-up the request for single step via the debug ioctl it is all handled within the kernel. The actual setting of the KVM_GUESTDBG_SINGLESTEP flag is already in the common code. If the kernel doesn't support

Re: [Qemu-devel] [PATCH 00/16] pc: Eliminate struct PcGuestInfo

2015-12-08 Thread Eduardo Habkost
On Mon, Dec 07, 2015 at 08:57:03PM +0200, Marcel Apfelbaum wrote: > On 12/02/2015 03:46 AM, Eduardo Habkost wrote: > >This moves all data from PcGuestInfo to either PCMachineState or > >PCMachineClass. > > > >This series depends on other two series: > >* [PATCH v3 0/6] pc: Initialization and

Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-08 Thread Marcel Apfelbaum
On 12/08/2015 04:07 PM, Gerd Hoffmann wrote: rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, use it for both xen and non-xen init. Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 04/16] acpi: Make acpi_setup() get PCMachineState as argument

2015-12-08 Thread Eduardo Habkost
On Mon, Dec 07, 2015 at 05:24:27PM +0200, Marcel Apfelbaum wrote: > On 12/02/2015 03:46 AM, Eduardo Habkost wrote: > >Lots of PcGuestInfo fields are duplicates of PCMachineClass or > >PCMachineState fields. Pass PCMachineState as argument to > >acpi_setup(), so we can simply let the ACPI code use

[Qemu-devel] [Bug 1308341] Re: Multiple CPUs causes blue screen on Windows guest (14.04 regression)

2015-12-08 Thread Serge Hallyn
*** This bug is a duplicate of bug 1346917 *** https://bugs.launchpad.net/bugs/1346917 Hi, could you please file a new bug with debugging information as per https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1346917/comments/11 ? -- You received this bug notification because you are a

[Qemu-devel] [PATCH v10 5/6] target-arm: kvm - re-inject guest debug exceptions

2015-12-08 Thread Alex Bennée
If we can't find details for the debug exception in our debug state then we can assume the exception is due to debugging inside the guest. To inject the exception into the guest state we re-use the TCG exception code (do_interrupt). However while guest debugging is in effect we currently can't

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

2015-12-08 Thread John Snow
On 12/07/2015 04:23 PM, Boris Schrijver wrote: > Hi all, > Hi! > I was testing out the "qemu-img info/convert" options in combination with > "http/https" when I stumbled upon this issue. When "qemu-img info/convert" > tries > to collect the file info it will first try to fetch the

Re: [Qemu-devel] [PATCH 06/16] acpi: Save PCMachineState on AcpiBuildState

2015-12-08 Thread Marcel Apfelbaum
On 12/08/2015 07:59 PM, Eduardo Habkost wrote: On Mon, Dec 07, 2015 at 05:39:29PM +0200, Marcel Apfelbaum wrote: On 12/02/2015 03:47 AM, Eduardo Habkost wrote: PCMachineState will be used in some of the steps of ACPI table building. Signed-off-by: Eduardo Habkost ---

Re: [Qemu-devel] [Qemu-block] QEMU being able to use audio cdroms

2015-12-08 Thread John Snow
On 11/25/2015 03:44 PM, Programmingkid wrote: > Is there any platform where a guest in QEMU can play an audio cd? If not, is > this a feature that you would allow into QEMU? > I haven't tested it, nobody has ever asked. I wouldn't reject patches for such a feature, but I likely wouldn't make

[Qemu-devel] [PATCH v10 2/6] target-arm: kvm - implement software breakpoints

2015-12-08 Thread Alex Bennée
These don't involve messing around with debug registers, just setting the breakpoint instruction in memory. GDB will not use this mechanism if it can't access the memory to write the breakpoint. All the kernel has to do is ensure the hypervisor traps the breakpoint exceptions and returns to

[Qemu-devel] [PATCH v10 1/6] target-arm: kvm64 - introduce kvm_arm_init_debug()

2015-12-08 Thread Alex Bennée
As we haven't always had guest debug support we need to probe for it. Additionally we don't do this in the start-up capability code so we don't fall over on old kernels. Signed-off-by: Alex Bennée --- target-arm/kvm64.c | 18 ++ 1 file changed, 18

Re: [Qemu-devel] [Qemu-block] QEMU being able to use audio cdroms

2015-12-08 Thread Programmingkid
On Dec 8, 2015, at 1:49 PM, John Snow wrote: > > > On 11/25/2015 03:44 PM, Programmingkid wrote: >> Is there any platform where a guest in QEMU can play an audio cd? If not, is >> this a feature that you would allow into QEMU? >> > > I haven't tested it, nobody has ever asked. I wouldn't

Re: [Qemu-devel] [PATCH] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

2015-12-08 Thread Michael Tokarev
08.12.2015 00:23, Boris Schrijver wrote: [] > It's is therefore better to use only the GET request method, and discard the > body at the first call. Nooo! Please N! Fetching a large file once might be too long already. Fetching it twice is twice as long. Oh well!.. Thanks, /mjt

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

2015-12-08 Thread Boris Schrijver
See inline! Thanks for your response! --  Met vriendelijke groet / Kind regards, Boris Schrijver PCextreme B.V. http://www.pcextreme.nl/contact Tel direct: +31 (0) 118 700 215 > On December 8, 2015 at 8:40 PM John Snow wrote: > > > > > On 12/07/2015 04:23 PM, Boris

[Qemu-devel] [PATCH for-2.5] sparc: allow CASA with ASI 0xa from user space

2015-12-08 Thread Richard Henderson
On 12/04/2015 07:01 AM, Alex Zuepke wrote: > LEON3 allows the CASA instruction to be used from user space > if the ASI is set to 0xa (user data). > > Signed-off-by: Alex Zuepke > --- > target-sparc/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

2015-12-08 Thread Boris Schrijver
Hi! To clarify: The body of the response is the maximum size defined by MTU network policies, so by default around ~1500 bytes. After that is received, the header is parsed and the connection is dropped! So no whole file transfers!!! Please test and see for your self! --  Met vriendelijke

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-08 Thread Peter Crosthwaite
On Tue, Dec 8, 2015 at 10:19 PM, Andrew Baumann wrote: >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] >> Sent: Saturday, 5 December 2015 21:26 >> Is this IP just SDHCI? We already model SDHCI in QEMU, see >> hw/sd/sdhci.c. If there are RPi specific

Re: [Qemu-devel] [PATCH] virtio-blk: Drop x-data-plane option

2015-12-08 Thread Stefan Hajnoczi
On Mon, Dec 07, 2015 at 05:10:26PM +, Peter Maydell wrote: > On 7 December 2015 at 15:19, Paolo Bonzini wrote: > > > > > > On 07/12/2015 14:02, Fam Zheng wrote: > >> On Mon, 12/07 12:29, Cornelia Huck wrote: > >>> On Mon, 7 Dec 2015 18:59:27 +0800 > >>> Fam Zheng

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

2015-12-08 Thread Alex Williamson
On Mon, 2015-12-07 at 11:20 +, Peter Maydell wrote: > On 7 December 2015 at 10:53, Pavel Fedin wrote: > >> TAGET_PAGE_ALIGN tells us that it *could* be a valid DMA target though. > >> The VM model is capable of using that as a page size, which means we > >> assume it is

Re: [Qemu-devel] tcg: improve MAX_CODE_GEN_BUFFER_SIZE for arm

2015-12-08 Thread TeLeMan
On Tue, Dec 8, 2015 at 7:21 PM, Aurelien Jarno wrote: > On 2015-12-08 11:51, Laurent Desnogues wrote: >> Hello, >> >> On Tue, Dec 8, 2015 at 11:39 AM, Aurelien Jarno wrote: >> [...] >> > I already posted a patch a long time ago to remove the 16MB limit

[Qemu-devel] [PATCH] xen_pt: fix failure of attaching & detaching a PCI device to VM repeatedly

2015-12-08 Thread Jianzhong,Chang
Add pci = [ '$VF_BDF1', '$VF_BDF2', '$VF_BDF3'] in hvm guest configuration file. After the guest boot up, detach the VFs in sequence by "xl pci-detach $DOMID $VF_BDF", reattach the VFs by "xl pci-attach $VF_BDF" in sequence. An error message will be reported like this: "libxl: error:

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 07/10] pseries: DEFINE_SPAPR_MACHINE

2015-12-08 Thread Alexey Kardashevskiy
On 12/08/2015 01:38 PM, Sam Bobroff wrote: On Mon, Dec 07, 2015 at 02:34:37PM +1100, David Gibson wrote: At the moment all the class_init functions and TypeInfo structures for the various versioned pseries machine types are open-coded. As more versions are created this is getting increasingly

Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-08 Thread Gerd Hoffmann
> Hi Gerd, > > A quick question, does IGD_PASSTHROUGH makes sense for compat machine types? Unlikely to be used in practice, but I don't feel like creating different initialization code paths because of that ... > On the same topic, does machine->igd_gfx_passthru makes sense for all machine >

[Qemu-devel] [PATCH v6 00/11] Add basic "detach" support for dump-guest-memory

2015-12-08 Thread Peter Xu
v6 changes: - patch 10 - English error fix [Fam] - patch 11 - remove useless var: "not_used" [me] - all - move patch 8 to the end to be patch 11 (v5 patches 9-11 become v6 patches 8-10) [Eric] v5 changes: - patch 1 - comment English fix [Fam] - patch 2 - pass has_detach=true always in

Re: [Qemu-devel] [Qemu-ppc] [PATCHv2 07/10] pseries: DEFINE_SPAPR_MACHINE

2015-12-08 Thread Alexey Kardashevskiy
On 12/09/2015 02:30 PM, Alexey Kardashevskiy wrote: On 12/08/2015 01:38 PM, Sam Bobroff wrote: On Mon, Dec 07, 2015 at 02:34:37PM +1100, David Gibson wrote: At the moment all the class_init functions and TypeInfo structures for the various versioned pseries machine types are open-coded. As

Re: [Qemu-devel] [PATCHv2 09/10] pseries: Improve setting of default machine version

2015-12-08 Thread Alexey Kardashevskiy
On 12/07/2015 02:34 PM, David Gibson wrote: This tweaks the way the default machine version is controlled, so that there will be a bit less churn when each new version is introduced. Signed-off-by: David Gibson --- hw/ppc/spapr.c | 20 ++-- 1

Re: [Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

2015-12-08 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Saturday, 5 December 2015 21:26 > Is this IP just SDHCI? We already model SDHCI in QEMU, see > hw/sd/sdhci.c. If there are RPi specific features to the SDHCI > implementation they should be added as optional extensions

[Qemu-devel] [PATCH v6 01/11] dump-guest-memory: cleanup: removing dump_{error|cleanup}().

2015-12-08 Thread Peter Xu
It might be a little bit confusing and error prone to do dump_cleanup() in these two functions. A better way is to do dump_cleanup() before dump finish, no matter whether dump has succeeded or not. Signed-off-by: Peter Xu Reviewed-by: Fam Zheng --- dump.c |

[Qemu-devel] [PATCH v6 05/11] dump-guest-memory: introduce dump_process() helper function.

2015-12-08 Thread Peter Xu
No functional change. Cleanup only. Signed-off-by: Peter Xu Reviewed-by: Fam Zheng --- dump.c| 31 +-- include/sysemu/dump.h | 3 +++ 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/dump.c

[Qemu-devel] [PATCH v6 10/11] Dump: add hmp command "info dump"

2015-12-08 Thread Peter Xu
It will calculate percentage of finished work from completed and total. Signed-off-by: Peter Xu --- hmp-commands-info.hx | 14 ++ hmp.c| 17 + hmp.h| 1 + 3 files changed, 32 insertions(+) diff --git

[Qemu-devel] [PATCH v6 06/11] dump-guest-memory: disable dump when in INMIGRATE state

2015-12-08 Thread Peter Xu
Signed-off-by: Peter Xu Reviewed-by: Fam Zheng --- dump.c | 5 + 1 file changed, 5 insertions(+) diff --git a/dump.c b/dump.c index f0ee9a8..aa9d1f8 100644 --- a/dump.c +++ b/dump.c @@ -1625,6 +1625,11 @@ void qmp_dump_guest_memory(bool paging, const

[Qemu-devel] [PATCH v6 02/11] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-12-08 Thread Peter Xu
This patch only adds the interfaces, but does not implement them. "detach" parameter is made optional, to make sure that all the old dump-guest-memory requests will still be able to work. Signed-off-by: Peter Xu Reviewed-by: Fam Zheng --- dump.c |

Re: [Qemu-devel] tcg: booting Windows on arm

2015-12-08 Thread Ya Ho
Hi all, I am trying to boot Windows 8 (x86) on arm host using qemu dynamic translation. It is not successfull but Windows xp boots fine. Any suggest for this issue? On Wednesday, December 9, 2015, wrote: > Send Qemu-devel mailing list submissions to >

  1   2   >