[Qemu-devel] [ANNOUNCE] QEMU 2.5.0-rc4 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.5 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.5.0-rc4.tar.bz2 You can help

Re: [Qemu-devel] [Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On Thu, Dec 10, 2015 at 09:39:51AM -0500, Programmingkid wrote: > https://patchwork.ozlabs.org/patch/550295/ > > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message

[Qemu-devel] [PATCH v2 3/4] qemu-img: abort when full_backing_filename not present

...But only if we have the backing_filename. It means something Scary happened and we can't really be quite exactly sure if we can trust the backing_filename. Signed-off-by: John Snow --- qemu-img.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 2/4] block/qapi: always report full_backing_filename

Always report full_backing_filename, even if it's the same as backing_filename. In the next patch, full_backing_filename may be omitted if it cannot be generated instead of allowing e.g. drive_query to abort if it runs into this scenario. The presence or absence of the "full" field becomes useful

[Qemu-devel] [PATCH v2 1/4] block/qapi: do not redundantly print "actual path"

If it happens to match the backing path, that was the actual path. Signed-off-by: John Snow --- block/qapi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/qapi.c b/block/qapi.c index 267f147..01569da 100644 --- a/block/qapi.c +++ b/block/qapi.c

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.5?] qemu-iotests: Reduce racy output in 028

On 12/10/2015 10:27 PM, Eric Blake wrote: > On my machine, './check -qcow2 028' was failing about 80% of the > time, due to a race in how many times the repeated attempts > to run 'info block-jobs' could occur before the job was done, > showing up as a failure of fewer '(qemu) ' prompts than in

Re: [Qemu-devel] [PATCH v3 3/4] target-tilegx: Add double floating point implementation

On 12/12/15 08:41, Richard Henderson wrote: > On 12/11/2015 03:38 PM, Chen Gang wrote: >> >> On 12/11/15 05:17, Richard Henderson wrote: >>> On 12/10/2015 06:15 AM, Chen Gang wrote: +#define TILEGX_F_MAN_HBIT (1ULL << 59) >>> ... +static uint64_t fr_to_man(float64 d) +{ +

[Qemu-devel] [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD and DVD media. Signed-off-by: John

[Qemu-devel] [PATCH v2 4/4] block/qapi: allow best-effort query

For more complex BDS trees that can be created under normal circumstances, we lose the ability to issue query commands because of our inability to re-construct the absolute filename. Instead, omit this field when it is a problem and present as much information as we can. This will change the

[Qemu-devel] [PATCH v2 0/4] block: allow partial info-block query

Max: Did you have in mind something like this? v2: - Fix qemu-img from now choking when it gets a partial response. For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch

Re: [Qemu-devel] [PATCH v3 3/4] target-tilegx: Add double floating point implementation

On 12/11/2015 03:38 PM, Chen Gang wrote: On 12/11/15 05:17, Richard Henderson wrote: On 12/10/2015 06:15 AM, Chen Gang wrote: +#define TILEGX_F_MAN_HBIT (1ULL << 59) ... +static uint64_t fr_to_man(float64 d) +{ +uint64_t val = get_f64_man(d) << 7; + +if (get_f64_exp(d)) { +

Re: [Qemu-devel] [PATCH 07/18] slirp: Make udp_attach IPv6 compatible

On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > A sa_family_t is now passed in argument to udp_attach instead of using a > hardcoded "AF_INET" to call qemu_socket(). > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel

Re: [Qemu-devel] [PATCH 06/11] pseries: Improve error handling in find_unknown_sysbus_device()

On 12/10/2015 05:11 PM, David Gibson wrote: > Use error_setg() to return an error instead of using an explicit exit(). > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > +++ b/hw/ppc/spapr.c

Re: [Qemu-devel] [PATCH COLO-Frame v11 24/39] COLO: Implement failover work for Secondary VM

On 2015/12/11 2:50, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If users require SVM to takeover work, colo incoming thread should exit from loop while failover BH helps backing to migration incoming coroutine. Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

On Fri, Dec 11, 2015 at 5:41 AM, David Gibson wrote: > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > all errors with error_setg(_abort, ...). That's correct for > spapr_reset_htab() - if anything goes wrong there, there's really nothing >

Re: [Qemu-devel] [PATCH 02/11] pseries: Cleanup error handling of spapr_cpu_init()

On Fri, Dec 11, 2015 at 5:41 AM, David Gibson wrote: > Currently spapr_cpu_init() is hardcoded to handle any errors as fatal. > That works for now, since it's only called from initial setup where an > error here means we really can't proceed. > > However, we'll want

Re: [Qemu-devel] [PATCH 04/11] pseries: Clean up error handling in spapr_validate_node_memory()

On Fri, Dec 11, 2015 at 5:41 AM, David Gibson wrote: > Use error_setg() and return an error, rather than using an explicit exit(). > > Also improve messages, and be more explicit about which constraint failed. > > Signed-off-by: David Gibson

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

On 12/09/2015 11:28 PM, P J P wrote: >Hello Jason, Dmitry, > > +-- On Tue, 8 Dec 2015, P J P wrote --+ > | |1) VMXNET3_CMD_QUIESCE_DEV > | > | IIUC, it is used to pause the device when the receiver end is unable to > | keee-up with the incoming flow. After a brief period, the operation

Re: [Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat()

On 11/12/15 01:11, David Gibson wrote: > Current ppc_set_compat() returns -1 for errors, and also (unconditionally) > reports an error message. The caller in h_client_architecture_support() > may then report it again using an outdated fprintf(). > > Clean this up by using the modern error

Re: [Qemu-devel] [PATCH COLO-Frame v11 27/39] COLO failover: Shutdown related socket fd when do failover

* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/12/11 4:03, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>If the net connection between COLO's two sides is broken while colo/colo > >>incoming > >>thread is blocked in 'read'/'write'

Re: [Qemu-devel] [PATCH COLO-Frame v11 23/39] COLO: Implement failover work for Primary VM

* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: > On 2015/12/11 2:34, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >>For PVM, if there is failover request from users. > >>The colo thread will exit the loop while the failover BH does the >

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

Samuel Thibault, on Fri 11 Dec 2015 20:29:44 +0100, wrote: > Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > > On 11/12/15 01:15, Samuel Thibault wrote: > > > From: Guillaume Subiron > > > > > > This patch makes solookup() compatible with varying address families.

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > I'll however have a look at introducing the optimizations etc. first, so > that both making solookup use sockaddr and introducing sockaddr_equal > looks natural. Yes, it seems to be working very nicely. Samuel

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

Samuel Thibault, on Fri 11 Dec 2015 20:51:02 +0100, wrote: > Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > > I'll however have a look at introducing the optimizations etc. first, so > > that both making solookup use sockaddr and introducing sockaddr_equal > > looks natural. > >

Re: [Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile

On 12/11/2015 05:41 AM, Peter Maydell wrote: Hi; I noticed while grepping through code that the version of tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS won't compile because it's still referring to the no-longer-existent TCGContext::gen_opc_buf. Oops. Richard, I

[Qemu-devel] [PATCH] tcg: Remove lingering references to gen_opc_buf

Three in comments and one in code in the stub tcg_liveness_analysis. Signed-off-by: Richard Henderson --- target-arm/translate.c | 3 +-- target-i386/translate.c | 3 +-- target-unicore32/translate.c | 3 +-- tcg/tcg.c| 3 +-- 4 files changed, 4

[Qemu-devel] An RDMA race?

Hi Michael, I think I've got an RDMA race condition, but I'm being a little cautious at the moment and wondered if you agree with the following diagnosis. It's showing up in a world of mine that's sending more control messages from the destination->source and I'm seeing the following. We

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 12/11/15 17:17, Eric Blake wrote: > On 12/11/2015 08:40 AM, Laszlo Ersek wrote: >> meta >> >> On 12/11/15 16:09, Thomas Huth wrote: >>> On 11/12/15 15:55, Samuel Thibault wrote: Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: > So maybe it's better to do smaller steps instead:

Re: [Qemu-devel] QEMU/KVM performance gets worser - high load - high interrupts - high context switches

Any comments? Ciao, Gerhard On 08.12.2015 10:39, Gerhard Wiesinger wrote: Hello, Yesterday I looked at my munin statistics on my KVM host and I swar that performance gets worser: load is getting higher, interrupts are getting higher and are high as well as context switches. VMs and

Re: [Qemu-devel] [PATCH COLO-Frame v11 23/39] COLO: Implement failover work for Primary VM

On 2015/12/11 2:34, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: For PVM, if there is failover request from users. The colo thread will exit the loop while the failover BH does the cleanup work and resumes VM. Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH 4/4] hw/s390x: Rename local variables Error *l_err to just err

> > static Property s390_ipl_properties[] = { > diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c > index a061b49..9a117c9 100644 > --- a/hw/s390x/sclp.c > +++ b/hw/s390x/sclp.c > @@ -456,29 +456,29 @@ static void sclp_realize(DeviceState *dev, Error **errp) > { > MachineState *machine =

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 11/12/15 14:47, Samuel Thibault wrote: > Thomas Huth, on Fri 11 Dec 2015 14:43:42 +0100, wrote: >> Anyway, it's IMHO a somewhat strange way to structure a patch ... maybe >> it would be nicer to do it in one go instead (after splitting off the >> arp_requested renaming)? > > Please discuss

[Qemu-devel] [PATCH v2 00/14] pc: Eliminate struct PcGuestInfo

This moves all data from PcGuestInfo to either PCMachineState or PCMachineClass. This series depends on other two series: * [PATCH v3 0/6] pc: Initialization and compat function cleanup * [PATCH V3 0/3] hw/pcie: Multi-root support for Q35 For reference, there's a git tree containing this series

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > On 11/12/15 01:15, Samuel Thibault wrote: > > From: Guillaume Subiron > > > > This patch makes solookup() compatible with varying address families. Also, > > this function was only compatible with TCP. Having the

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote: > Also, I'd prefer if you could split this patch into two: One for > renaming the "arp_requested" field, and one for adding the additional > logic with the switch statement (since there are two different kind of > changes). Ok, at least it's

Re: [Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions

On 12/11/2015 09:52 AM, Jason J. Herne wrote: We don't want newlines embedded in error messages. This seems to be a common problem with new code so let's try to catch it with checkpatch. This does not catch the newline when it is in a multiline statement. This is quite a bit more difficult and

[Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions

We don't want newlines embedded in error messages. This seems to be a common problem with new code so let's try to catch it with checkpatch. This will not catch cases where newlines are inserted into the middle of an existing multi-line statement. But those cases should be rare. Signed-off-by:

[Qemu-devel] [PATCH v2 01/14] q35: Remove MCHPCIState.guest_info field

The field is not used for anything. Signed-off-by: Eduardo Habkost --- hw/i386/pc_q35.c | 1 - include/hw/pci-host/q35.h | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 9da751b..43ee8bb 100644 --- a/hw/i386/pc_q35.c

[Qemu-devel] [PATCH v2 02/14] pc: Group and document related PCMachineState/PCMachineclass fields

Group related PCMachineState and PCMachineClass fields into sections, and move existing field descriptions to doc comments. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 48 1 file changed, 36 insertions(+), 12

[Qemu-devel] [PATCH v2 04/14] pc: Eliminate struct PcGuestInfoState

Instead of allocating a new struct just for PcGuestInfo and the mchine_done Notifier, place them inside PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 27 ++- include/hw/i386/pc.h | 2 ++ 2 files changed, 12 insertions(+),

[Qemu-devel] [PATCH v2 03/14] pc: Move PcGuestInfo declaration to top of file

The struct will be used inside PCMachineState. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 9503dbb..84bc88f

[Qemu-devel] [PATCH v2 13/14] pc: Move APIC and NUMA data from PcGuestInfo to PCMachineState

Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 22 +- hw/i386/pc.c | 20 ++-- include/hw/i386/pc.h | 14 +- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/hw/i386/acpi-build.c

[Qemu-devel] [PATCH v2 05/14] pc: Simplify pc_memory_init() signature

We can get the PcGuestInfo struct directly from PCMachineState, and the return value is not needed at all. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 11 +-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 9

[Qemu-devel] [PATCH v2 09/14] pc: Remove compat fields from PcGuestInfo

Remove the fields: legacy_acpi_table_size, has_acpi_build, has_reserved_memory, and rsdp_in_ram from PcGuestInfo, and let the existing code use the PCMachineClass fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 10 ++ hw/i386/pc.c

[Qemu-devel] [PATCH v2 08/14] acpi: Don't save PcGuestInfo on AcpiBuildState

We don't need to save the pointer on AcpiBuildState, as it is not used anymore. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 92d25c9..82d55bb 100644 ---

Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: > Update the SDHCI code to use the new SDBus APIs. > > This commit introduces the new command line options required > to connect a disk to sdhci-pci: > > -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive I can't

[Qemu-devel] [PATCH v2 06/14] pc: Simplify xen_load_linux() signature

We can get the PcGuestInfo struct directly from PCMachineState, and the return value is not needed at all. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 5 ++--- hw/i386/pc_piix.c| 2 +- include/hw/i386/pc.h | 3 +-- 3 files changed, 4 insertions(+), 6

[Qemu-devel] [PATCH v2 10/14] pc: Remove RAM size fields from PcGuestInfo

The ACPI code can use the PCMachineState fields directly. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 10 +- hw/i386/pc.c | 2 -- include/hw/i386/pc.h | 1 - 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/i386/acpi-build.c

[Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions

We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get guest_info. Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 35 +-- hw/i386/acpi-build.h | 2 +- hw/i386/pc.c | 2 +- 3 files changed, 23 insertions(+), 16

[Qemu-devel] [PATCH v2 14/14] pc: Eliminate PcGuestInfo struct

The struct is not used for anything, now. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 4 +--- include/hw/i386/pc.h | 7 +-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 43a25a0..f78b877 100644 ---

[Qemu-devel] [PATCH v2 11/14] pc: Remove PcGuestInfo.isapc_ram_fw field

The code can use the PCMachineClass.pci_enabled field directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 2 +- hw/i386/pc_piix.c| 5 + hw/i386/pc_q35.c | 4 +--- include/hw/i386/pc.h | 1 - 4 files changed, 3 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PATCH v2 12/14] pc: Move PcGuestInfo.fw_cfg to PCMachineState

Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 7 +++ hw/i386/pc.c | 10 -- include/hw/i386/pc.h | 2 +- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 9598eac..43d8166 100644

Re: [Qemu-devel] [PATCH COLO-Frame v11 27/39] COLO failover: Shutdown related socket fd when do failover

On 2015/12/11 4:03, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If the net connection between COLO's two sides is broken while colo/colo incoming thread is blocked in 'read'/'write' socket fd. It will not detect this error until connect timeout. It

Re: [Qemu-devel] [PATCH 1/4] error: Strip trailing '\n' from error string arguments (again)

On 2015/12/11 2:16, Cornelia Huck wrote: On Thu, 10 Dec 2015 18:23:49 +0100 Markus Armbruster wrote: Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they keep coming back. Tracked down with the Coccinelle semantic patch from commit 312fd5f. Cc: Fam Zheng

Re: [Qemu-devel] An RDMA race?

David, Thanks for including my email directly. It helps a lot. Below, I'm going to assume that only "dest" is calling qemu_rdma_exchange_recv() and only src is calling qemu_rdma_exchange_send(), since you didn't specify who is sending and who is receiving. If that assumption is wrong, please

Re: [Qemu-devel] [Patch V2 2/2] x86, mce: Need to translate GPA to HPA to inject error in guest.

Hi, Ashok Please add " original author by Huang Ying " at some place. Thanks. > -Original Message- > From: Raj, Ashok > Sent: Friday, December 11, 2015 3:41 AM > To: k...@vger.kernel.org > Cc: Chen, Gong; Gleb Natapov; Paolo Bonzini; qemu-devel@nongnu.org; >

<    1   2