Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

On Tue, 22 Dec 2015 16:47:18 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 22, 2015 at 03:38:24PM +0100, Igor Mammedov wrote: > > On Tue, 22 Dec 2015 11:37:40 +0200 > > "Michael S. Tsirkin" wrote: > > > > [...] > > > > > > +for (i = 4; i <= 0xF; i++)

Re: [Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

On Tue, Dec 22, 2015 at 05:07:16PM +0200, Michael S. Tsirkin wrote: > On Fri, Dec 18, 2015 at 10:32:29PM +0300, Roman Kagan wrote: > > On x86-based systems Linux determines the presence and the type of > > floppy drives via a query of a CMOS field. So does SeaBIOS when > > populating the return

Re: [Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

On Fri, Dec 18, 2015 at 10:32:29PM +0300, Roman Kagan wrote: > On x86-based systems Linux determines the presence and the type of > floppy drives via a query of a CMOS field. So does SeaBIOS when > populating the return data for int 0x13 function 0x08. > > Windows doesn't; instead, it requests

Re: [Qemu-devel] [PATCH v2 26/74] pc: acpi: memhp: move MHPD._STA method into SSDT

On Mon, Dec 21, 2015 at 06:31:40PM +0100, Igor Mammedov wrote: > On Sun, 20 Dec 2015 15:41:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Dec 16, 2015 at 03:47:35PM +0100, Igor Mammedov wrote: > [...] > > > +method = aml_method("_STA", 0, AML_NOTSERIALIZED); > > >

Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs

On Thu, Dec 10, 2015 at 12:41:18AM +0100, Igor Mammedov wrote: > ASL Interrupt() macro translates to Extended Interrupt Descriptor > which supports variable number of IRQs. It will be used for > conversion of ASL code for pc/q35 machines that use it for > returning several IRQs in _PSR object. >

Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

On Thu, Dec 10, 2015 at 12:40:55AM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 6d37332..50678b5 100644

Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs

On Tue, 22 Dec 2015 17:17:33 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 10, 2015 at 12:41:18AM +0100, Igor Mammedov wrote: > > ASL Interrupt() macro translates to Extended Interrupt Descriptor > > which supports variable number of IRQs. It will be used for > > conversion of

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

On Tue, Dec 22, 2015 at 03:15:26AM +, Xulei (Stone) wrote: > Hi, Kevin, > Can you tell how to reset/reboot this VM, if it goes to the handle_hwpic1() > on its booting procedure? I mean, usually, SeaBIOS would not go to > handle_hwpic routine. But in my test case, SeaBIOS calls handle_hwpic

Re: [Qemu-devel] [PATCH v2 26/74] pc: acpi: memhp: move MHPD._STA method into SSDT

On Tue, 22 Dec 2015 17:11:46 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 21, 2015 at 06:31:40PM +0100, Igor Mammedov wrote: > > On Sun, 20 Dec 2015 15:41:22 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Dec 16, 2015 at 03:47:35PM +0100, Igor

Re: [Qemu-devel] [PATCH v2] qemu-char: add logfile facility to all chardev backends

On 12/22/2015 11:17 AM, Daniel P. Berrange wrote: > Typically a UNIX guest OS will log boot messages to a serial > port in addition to any graphical console. An admin user > may also wish to use the serial port for an interactive > console. A virtualization management system may wish to > collect

Re: [Qemu-devel] [PATCH v2 1/4] net/vmxnet3: return 1 on device activation failure

On Tue, 22 Dec 2015 22:41:34 +0200 Shmulik Ladkani wrote: > Could it be that various other error codes might be returned from ESXi > for a VMXNET3_CMD_ACTIVATE_DEV read, depending on device condition? Thinking this over, the commit takes us one step into a

Re: [Qemu-devel] [PATCH 2/2] io: fix stack allocation when sending of file descriptors

On 12/21/2015 09:23 AM, Daniel P. Berrange wrote: > When sending file descriptors over a socket, we have to > allocate a data buffer to hold the FDs in the scmsghdr. > Unfortunately we allocated the buffer on the stack inside > an if () {} block, but called sendmsg() outside the block. > So the

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

The only way to see my iPhone (or any USB device) in the Windows guest is to have it redirected via "Spice", not with libvirt xml capture elements. Select Redirect USB device in virt-viewer and it just works. I have upgraded to Qemu 2.4, libvirt 1.2.21 and upgraded the qemu machine to "q35" as

[Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

Hello Paolo, all Please see an updated patch below, as per suggestion in -> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04057.html === From 344a487d637be20b3fb110bec36cb703e7f6ecaa Mon Sep 17 00:00:00 2001 From: Prasad J Pandit Date: Wed, 23 Dec 2015

Re: [Qemu-devel] [PATCH 07/10] qcow2: Implement .bdrv_inactivate

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > The callback has to ensure that closing or flushing the image afterwards > wouldn't cause a write access to the image files. This means that just > the caches have to be written out, which is part of the existing > .bdrv_close implementation. > >

Re: [Qemu-devel] [PATCH 1/2] io: fix setting of QIO_CHANNEL_FEATURE_FD_PASS on server connections

On 12/21/2015 09:23 AM, Daniel P. Berrange wrote: > The QIO_CHANNEL_FEATURE_FD_PASS feature flag is set in the > qio_channel_socket_set_fd() method, however, this only deals > with client side connections. > > To ensure server side connections also have the feature flag > set, we must set it in

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

On Thu, 17 Dec 2015 18:10:59 +0530 (IST) P J P wrote: >Hello, > > An OOB write issue was reported by Mr Ling Liu, CC'd here. It occurs while > processing the 'sendkey' command, if the command argument was longer than > the 'keyname_buf[16]' buffer. Markus, are you

Re: [Qemu-devel] [PATCH 09/10] qcow2: Make image inaccessible after failed qcow2_invalidate_cache()

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > If qcow2_invalidate_cache() fails, we are in a state where qcow2_close() > has already been completed, but the image hasn't been reopened yet. > Calling into any qcow2 function for an image in this state will cause > crashes. > > The real solution would

Re: [Qemu-devel] [PATCH v2 1/4] net/vmxnet3: return 1 on device activation failure

Hi, On Mon, 21 Dec 2015 22:18:21 -0800 Miao Yan wrote: > When reading device status, 0 means device is successfully > activated and 1 means error. > > This behavior can be observed by the following steps: > > 1) run a Linux distro on esxi server > 2) modify vmxnet3 Linux

Re: [Qemu-devel] [PATCH v2 3/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO

Hi, On Mon, 21 Dec 2015 22:18:23 -0800 Miao Yan wrote: > VMXNET3_CMD_GET_DEV_EXTRA_INFO should return 0 for emulation > mode > > This behavior can be observed by the following steps: > > 1) run a Linux distro on esxi server > 2) modify vmxnet3 Linux driver to read the

Re: [Qemu-devel] [PATCH 08/10] qcow2: Fix BDRV_O_INCOMING handling in qcow2_invalidate_cache()

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > What qcow2_invalidate_cache() should do is closing the image with > BDRV_O_INCOMING set and reopening it with the flag cleared. In fact, it Might read better with s/closing/close/, s/reopening/reopen/ > used to do exactly the opposite: qcow2_close()

Re: [Qemu-devel] [PATCH v2] qemu-char: add logfile facility to all chardev backends

On 12/22/2015 11:17 AM, Daniel P. Berrange wrote: > Typically a UNIX guest OS will log boot messages to a serial > port in addition to any graphical console. An admin user > may also wish to use the serial port for an interactive > console. A virtualization management system may wish to > collect

Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

On Tue, Dec 22, 2015 at 06:22:08PM +0100, Igor Mammedov wrote: > On Tue, 22 Dec 2015 18:59:30 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 22, 2015 at 04:54:06PM +0100, Igor Mammedov wrote: > > > On Tue, 22 Dec 2015 17:28:42 +0200 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH 03/10] block: Assert no write requests under BDRV_O_INCOMING

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > As long as BDRV_O_INCOMING is set, the image file is only opened so we > have a file descriptor for it. We're definitely not supposed to modify > the image, it's still owned by the migration source. > > Signed-off-by: Kevin Wolf > ---

Re: [Qemu-devel] [PATCH 04/10] block: Fix error path in bdrv_invalidate_cache()

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > We can only clear BDRV_O_INCOMING if the caches were actually > invalidated. > > Signed-off-by: Kevin Wolf > --- > block.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Eric Blake -- Eric Blake

Re: [Qemu-devel] [PATCH 01/10] qcow2: Write feature table only for v3 images

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > Version 2 images don't have feature bits, so writing a feature table to > those images is kind of pointless. Fortunately, it is also harmless; even the v2 spec allowed for unknown extension headers. > > Signed-off-by: Kevin Wolf >

Re: [Qemu-devel] [PATCH v2 2/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command

Hi, On Mon, 21 Dec 2015 22:18:22 -0800 Miao Yan wrote: > VMXNET3_CMD_GET_DID_LO should return PCI ID of the device > and VMXNET3_CMD_GET_DID_HI should return vmxnet3 revision ID. > > This behavior can be observed by the following steps: > > 1) run a Linux distro on esxi

Re: [Qemu-devel] [PATCH 06/10] qemu-img: Prepare for locked images

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > This patch extends qemu-img for working with locked images. It prints a > helpful error message when trying to access a locked image read-write, > and adds a 'qemu-img force-unlock' command as well as a 'qemu-img check > -r all --force' option in order

Re: [Qemu-devel] [PATCH 06/12] 4byte address mode support added.

On Tue, Dec 22, 2015 at 10:41 AM, Cédric Le Goater wrote: > Hello Marcin, > > > On 12/16/2015 01:57 PM, marcin.krzemin...@nokia.com wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Marcin Krzeminski >> --- >>

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

On 22 December 2015 at 19:24, P J P wrote: > Hello Paolo, all > > Please see an updated patch below, as per suggestion in > -> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04057.html Could you submit patches in the usual git send-email format, please? It's

Re: [Qemu-devel] [PATCH COLO-Frame v12 25/38] qmp event: Add event notification for COLO error

On 12/19/2015 06:02 PM, Markus Armbruster wrote: > Copying qemu-block because this seems related to generalising block jobs > to background jobs. > > zhanghailiang writes: > >> If some errors happen during VM's COLO FT stage, it's important to notify >> the

Re: [Qemu-devel] [PATCH 0/3] correct some register return values for vxmnet3

2015-12-23 10:15 GMT+08:00 Jason Wang : > > > On 12/22/2015 03:05 PM, Dmitry Fleytman wrote: >> >>> On 22 Dec 2015, at 04:44 AM, Miao Yan >> > wrote: >>> >>> Hi Dmitry, >>> >>> 2015-12-22 1:19 GMT+08:00 Dmitry Fleytman

[Qemu-devel] [Bug 1528718] [NEW] Initial monitor does not output anything on Windows (MSYS2 binary)

Public bug reported: When running on Windows error messages before the UI is started are not showing up. For example when I run: qemu-system-i386.exe -L /mingw32/etc/qemu/ -m 20G It should display "ram size too large", according to gdb: Breakpoint 1, error_report (fmt=fmt@entry=0x71bdf6

Re: [Qemu-devel] [PATCH 10/12] Support for quad commands.

On Tue, Dec 22, 2015 at 1:40 PM, Peter Crosthwaite wrote: > On Wed, Dec 16, 2015 at 4:57 AM, wrote: >> From: Marcin Krzeminski >> >> Signed-off-by: Pawel Lenkow >> --- >>

Re: [Qemu-devel] [PATCH COLO-Frame v12 00/38] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

On 2015/12/18 23:47, Dr. David Alan Gilbert wrote: * Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: On 2015/12/17 18:52, Dr. David Alan Gilbert wrote: * Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: On 2015/12/15 20:14, Dr. David Alan Gilbert wrote: * zhanghailiang

Re: [Qemu-devel] [PATCH COLO-Frame v12 25/38] qmp event: Add event notification for COLO error

On 2015/12/19 0:03, Eric Blake wrote: On 12/15/2015 01:22 AM, zhanghailiang wrote: If some errors happen during VM's COLO FT stage, it's important to notify the users of this event. Together with 'colo_lost_heartbeat', users can intervene in COLO's failover work immediately. If users don't

Re: [Qemu-devel] [PATCH 0/3] correct some register return values for vxmnet3

On 12/22/2015 03:05 PM, Dmitry Fleytman wrote: > >> On 22 Dec 2015, at 04:44 AM, Miao Yan > > wrote: >> >> Hi Dmitry, >> >> 2015-12-22 1:19 GMT+08:00 Dmitry Fleytman > >: >>> Hello Miao, >>> >>>

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Frame v12 25/38] qmp event: Add event notification for COLO error

On 2015/12/22 5:14, John Snow wrote: On 12/19/2015 05:02 AM, Markus Armbruster wrote: Copying qemu-block because this seems related to generalising block jobs to background jobs. zhanghailiang writes: If some errors happen during VM's COLO FT stage, it's

Re: [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking

On Tue, 12/22 17:46, Kevin Wolf wrote: > Enough innocent images have died because users called 'qemu-img snapshot' > while > the VM was still running. Educating the users doesn't seem to be a working > strategy, so this series adds locking to qcow2 that refuses to access the > image > read-write

Re: [Qemu-devel] [PATCH v2 2/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command

2015-12-23 4:49 GMT+08:00 Shmulik Ladkani : > Hi, > > On Mon, 21 Dec 2015 22:18:22 -0800 Miao Yan wrote: >> VMXNET3_CMD_GET_DID_LO should return PCI ID of the device >> and VMXNET3_CMD_GET_DID_HI should return vmxnet3 revision ID. >> >>

Re: [Qemu-devel] [PATCH COLO-Frame v12 25/38] qmp event: Add event notification for COLO error

On 2015/12/19 18:02, Markus Armbruster wrote: Copying qemu-block because this seems related to generalising block jobs to background jobs. Er, this event just used to help users to know what happened to VM with COLO FT on. If users get this event, they can make further check what's wrong, and

[Qemu-devel] [PATCH v2] qemu-char: add logfile facility to all chardev backends

Typically a UNIX guest OS will log boot messages to a serial port in addition to any graphical console. An admin user may also wish to use the serial port for an interactive console. A virtualization management system may wish to collect system boot messages by logging the serial port, but also

Re: [Qemu-devel] [PATCH 06/12] 4byte address mode support added.

Hello Marcin, On 12/16/2015 01:57 PM, marcin.krzemin...@nokia.com wrote: > From: Marcin Krzeminski > > Signed-off-by: Marcin Krzeminski > --- > hw/block/m25p80.c | 31 --- > 1 file changed, 28

Re: [Qemu-devel] [PATCH v2 2/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command

On Mon, 21 Dec 2015 22:18:22 -0800 Miao Yan wrote: > Signed-off-by: Miao Yan Reviewed-by: Shmulik Ladkani

Re: [Qemu-devel] [PATCH 10/12] Support for quad commands.

On Wed, Dec 16, 2015 at 4:57 AM, wrote: > From: Marcin Krzeminski > > Signed-off-by: Pawel Lenkow > --- > hw/block/m25p80.c | 38 -- > 1 file changed, 36 insertions(+), 2

Re: [Qemu-devel] [PATCH 10/10] qcow2: Add image locking

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > People have been keeping destroying their qcow2 images by using Any of these sound better: People have kept on destroying People have been destroying People keep on destroying > 'qemu-img snapshot' on images that were in use by a VM. This patch adds >

Re: [Qemu-devel] [PATCH v3 2/4] target-tilegx: Add single floating point implementation

On 12/11/15 06:15, Chen Gang wrote: > > On 12/11/15 04:18, Richard Henderson wrote: >> On 12/10/2015 09:15 AM, Richard Henderson wrote: >>> d = (uint64_t)sign << 63; >>> d = deposit64(d, 53, 11, exp); >>> d = deposit64(d, 21, 32, man); >>> return float64_to_float32(d, fp_status); >> >>

Re: [Qemu-devel] [PATCH] net: rocker: fix an incorrect array bounds check

+-- On Tue, 22 Dec 2015, Paolo Bonzini wrote --+ | > === | > diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c | > index c57f1a6..2e77e50 100644 | > --- a/hw/net/rocker/rocker.c | > +++ b/hw/net/rocker/rocker.c | > @@ -232,6 +232,9 @@ static int tx_consume(Rocker *r, DescInfo *info) | >

Re: [Qemu-devel] [PATCH 02/10] qcow2: Write full header on image creation

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > When creating a qcow2 image, we didn't necessarily call > qcow2_update_header(), but could end up with the basic header that > qcow2_create2() created manually. One thing that this basic header > lacks is the feature table. Let's make sure that it's

Re: [Qemu-devel] [PATCH 05/10] block: Inactivate BDS when migration completes

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > So far, live migration with shared storage meant that the image is in a > not-really-ready don't-touch-me state on the destination while the > source is still actively using it, but after completing the migration, > the image was fully opened on both

Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args

On Tue, Dec 22, 2015 at 10:50:19AM -0700, Eric Blake wrote: > On 12/22/2015 10:42 AM, Daniel P. Berrange wrote: > > >> Overall, I'm left wondering whether requiring '--source FOO' vs. > >> positional 'FOO', and manually enforcing mutual exclusion between the > >> two, is necessary, or if we could

Re: [Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args

On 12/22/2015 11:07 AM, Daniel P. Berrange wrote: > A third option would be to keep using positional arguments, but > add a '--source-opts' *boolean* flag to indicate how to interpret > the positional arguments. ie without --source-opts we use the > historic syntax, but with --source-opts, we

Re: [Qemu-devel] [PATCH] net: rocker: fix an incorrect array bounds check

On 22/12/2015 18:26, P J P wrote: > +-- On Tue, 22 Dec 2015, Paolo Bonzini wrote --+ > | > -if (++iovcnt > ROCKER_TX_FRAGS_MAX) { > | > +if (++iovcnt >= ROCKER_TX_FRAGS_MAX) { > | > | Doesn't this forbid some valid ROCKER_TX_FRAGS_MAX-element iovecs? > > forbid..? Sorry, I

Re: [Qemu-devel] [PATCH 06/10] qemu-img: Prepare for locked images

On 12/22/2015 09:46 AM, Kevin Wolf wrote: > This patch extends qemu-img for working with locked images. It prints a > helpful error message when trying to access a locked image read-write, > and adds a 'qemu-img force-unlock' command as well as a 'qemu-img check > -r all --force' option in order

Re: [Qemu-devel] Block I/O Tracing

On Wed, Dec 16, 2015 at 12:37:39PM -0500, Luis Pabón wrote: > I am really interested in the following feature: > http://wiki.qemu.org/Features/Block/Todo#Trace_guest_block_I.2FO.2C_replay_with_qemu-io > . Is there any more information about this feature? Hi Luis, It's a useful idea but

Re: [Qemu-devel] [PATCH v6 1/2] mirror: Rewrite mirror_iteration

On Fri, 12/18 17:41, Max Reitz wrote: > On 20.11.2015 11:12, Fam Zheng wrote: > > The "pnum < nb_sectors" condition in deciding whether to actually copy > > data is unnecessarily strict, and the qiov initialization is > > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > > >

Re: [Qemu-devel] [PATCH] trace: fix PRIx64 constants in trace-events

On Sat, Dec 19, 2015 at 11:08:42PM +, Mark Cave-Ayland wrote: > Commit c8ee0a4 introduced new events containing PRIx64 constants without > including the % prefix in the preceding string. This results in a compile > error during build if --enable-trace-backends is passed to configure. > >

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

+-- On Tue, 22 Dec 2015, Peter Maydell wrote --+ | Could you submit patches in the usual git send-email format, | please? It's easier for maintainers to process them if they're | not in an odd arrangement that requires manual intervention. | (In particular, comments that aren't intended to go in

[Qemu-devel] [PATCH v3 1/5] net/vmxnet3: return 1 on device activation failure

When reading device status, 0 means device is successfully activated and 1 means error. This behavior can be observed by the following steps: 1) run a Linux distro on esxi server (5.5+) 2) modify vmxnet3 Linux driver to give it an invalid address to 'adapter->shared_pa' which is the shared

[Qemu-devel] [PATCH v3 5/5] net/vmxnet3: rename VMXNET3_DEVICE_VERSION to VMXNET3_UPT_REVISION

VMXNET3_DEVICE_VERSION is used as return value for accessing UPT Revision Report and Selection register. So rename it to VMXNET3_UPT_REVISION. Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 4/5] net/vmxnet3: return 0 on unknown command

Return 0 on unknown command, this is what esxi (5.x+) behaves. Signed-off-by: Miao Yan --- Changes in v3: - mention esxi version in commit message hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c

[Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. Signed-off-by: Fam Zheng ---

[Qemu-devel] [PATCH v7 2/2] mirror: Add mirror_wait_for_io

The three lines are duplicated a number of times now, refactor a function. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/mirror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/mirror.c

[Qemu-devel] [PATCH v3 5/5] iotests: Add test cases for blockdev-mirror

Signed-off-by: Fam Zheng --- tests/qemu-iotests/041 | 100 ++--- tests/qemu-iotests/041.out | 4 +- 2 files changed, 79 insertions(+), 25 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index

[Qemu-devel] [PATCH] iotests: 086: Add raw format

Raw is as qualified as qcow2 for this test case, add it for more coverage. Signed-off-by: Fam Zheng --- tests/qemu-iotests/086 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/086 b/tests/qemu-iotests/086 index 234eb9a..5527e86 100755 ---

Re: [Qemu-devel] [PATCH v2] iov: avoid memcpy for "simple" iov_from_buf/iov_to_buf

On Tue, Dec 22, 2015 at 12:03:33PM +0100, Paolo Bonzini wrote: > memcpy can take a large amount of time for small reads and writes. > For virtio it is a common case that the first iovec can satisfy the > whole read or write. In that case, and if bytes is a constant to > avoid excessive growth of

Re: [Qemu-devel] [PATCH v3 0/5] correct some register return values for vxmnet3

Reviewed-by: Dmitry Fleytman > On 23 Dec 2015, at 08:06 AM, Miao Yan wrote: > > Qemu vmxnet3 emulation doesn't recognize VMXNET3_CMD_GET_DID_LO, > VMXNET3_CMD_GET_DID_HI and VMXNET3_CMD_GET_DEV_EXTRA_INFO command and > returns -1 on all of them. > >

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

> -Original Message- > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Tuesday, December 22, 2015 11:51 PM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org; Radim Krcmar > Subject: Re: [Qemu-devel]

Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

On 12/22/2015 02:49 AM, Denis V. Lunev wrote: > commit 31e38a22a0c5a25646f966f001e1f5513d5a186d > Author: Olga Krishtal > Date: Fri Dec 4 09:42:04 2015 +0300 > > qemu-char: append opt to stop truncation of serial file > > has added the option to

Re: [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules

On Mon, Dec 21, 2015 at 09:32:42AM -0700, Eric Blake wrote: > On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > > The rebuild of qapi-types.c/h is not correctly triggered > > when qapi/crypto.json is changed because it was missing > > from the list of files in the qapi-modules variable. > > > >

Re: [Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

On Fri, 18 Dec 2015 22:32:29 +0300 Roman Kagan wrote: > On x86-based systems Linux determines the presence and the type of > floppy drives via a query of a CMOS field. So does SeaBIOS when > populating the return data for int 0x13 function 0x08. > > Windows doesn't;

Re: [Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatable_del methods

On 12/22/2015 04:06 AM, Daniel P. Berrange wrote: > The QMP monitor code has two helper methods object_add > and qmp_object_del that are called from several places > in the code (QMP, HMP and main emulator startup). > > We soon need to use this code from qemu-img, qemu-io > and qemu-nbd too, but

Re: [Qemu-devel] [Qemu-block] Jobs 2.0 QAPI [RFC]

On 12/22/2015 11:19 AM, Alberto Garcia wrote: > On Mon 21 Dec 2015 08:40:26 PM CET, John Snow wrote: >> However, better flexibility also plays a part. Say we have two devices: >> >> [drive0]: [X] --> [Y] --> [Z] >> [drive1]: [A] --> [B] >> >> In theory, we should be able to

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

On Fri, Dec 18, 2015 at 10:32:30PM +0300, Roman Kagan wrote: > Update the expected SSDTs to reflect the changes introduced in the > previous patch. > > Signed-off-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Michael S. Tsirkin >

Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs

On Tue, Dec 22, 2015 at 05:19:02PM +0100, Igor Mammedov wrote: > On Tue, 22 Dec 2015 17:58:41 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 22, 2015 at 04:37:11PM +0100, Igor Mammedov wrote: > > > On Tue, 22 Dec 2015 17:17:33 +0200 > > > "Michael S. Tsirkin"

[Qemu-devel] [PATCH 04/10] block: Fix error path in bdrv_invalidate_cache()

We can only clear BDRV_O_INCOMING if the caches were actually invalidated. Signed-off-by: Kevin Wolf --- block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block.c b/block.c index 411edbf..554ed64 100644 --- a/block.c +++ b/block.c @@ -3273,12 +3273,14 @@ void

[Qemu-devel] [PATCH 08/10] qcow2: Fix BDRV_O_INCOMING handling in qcow2_invalidate_cache()

What qcow2_invalidate_cache() should do is closing the image with BDRV_O_INCOMING set and reopening it with the flag cleared. In fact, it used to do exactly the opposite: qcow2_close() relied on bs->open_flags, which is already updated to have cleared BDRV_O_INCOMING at this point, whereas

[Qemu-devel] [PATCH 07/10] qcow2: Implement .bdrv_inactivate

The callback has to ensure that closing or flushing the image afterwards wouldn't cause a write access to the image files. This means that just the caches have to be written out, which is part of the existing .bdrv_close implementation. Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH 03/10] block: Assert no write requests under BDRV_O_INCOMING

As long as BDRV_O_INCOMING is set, the image file is only opened so we have a file descriptor for it. We're definitely not supposed to modify the image, it's still owned by the migration source. Signed-off-by: Kevin Wolf --- block/io.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

On 12/22/2015 01:26 PM, Daniel P. Berrange wrote: On Tue, Dec 22, 2015 at 12:49:09PM +0300, Denis V. Lunev wrote: commit 31e38a22a0c5a25646f966f001e1f5513d5a186d Author: Olga Krishtal Date: Fri Dec 4 09:42:04 2015 +0300 qemu-char: append opt

[Qemu-devel] [PATCH v2] iov: avoid memcpy for "simple" iov_from_buf/iov_to_buf

memcpy can take a large amount of time for small reads and writes. For virtio it is a common case that the first iovec can satisfy the whole read or write. In that case, and if bytes is a constant to avoid excessive growth of code, inline the first iteration into the caller. Signed-off-by: Paolo

[Qemu-devel] [PATCH 7/7] qemu-img: allow specifying image as a set of options args

Currently qemu-img allows an image filename to be passed on the command line, but does not have a way to set any options except the format eg qemu-img info https://127.0.0.1/images/centos7.iso This adds a --source arg (that is mutually exclusive with a positional filename arg and -f arg) that

[Qemu-devel] [PATCH 4/7] qemu-io: add support for --object command line arg

Allow creation of user creatable object types with qemu-io via a --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # echo -n letmein > mypasswd.txt # qemu-io --object

[Qemu-devel] [PATCH 5/7] qemu-io: allow specifying image as a set of options args

Currently qemu-io allows an image filename to be passed on the command line, but does not have a way to set any options except the format eg qemu-io https://127.0.0.1/images/centos7.iso qemu-io /home/berrange/demo.qcow2 This adds a --source arg (that is mutually exclusive with a positional

[Qemu-devel] [PATCH 3/7] qemu-nbd: add support for --object command line arg

Allow creation of user creatable object types with qemu-nbd via a --object command line arg. This will be used to supply passwords and/or encryption keys to the various block driver backends via the recently added 'secret' object type. # echo -n letmein > mypasswd.txt # qemu-nbd --object

Re: [Qemu-devel] [PATCH v3 0/3] sdhci patches to enable Raspberry Pi

On Mon, Dec 21, 2015 at 02:47:46PM -0800, Andrew Baumann wrote: > This is a series of three tweaks needed to enable the generic sdhci > controller to emulate Raspberry Pi (bcm2835/2836), and boot Linux and > Windows. > > There was some discussion of these changes in the following thread: >

Re: [Qemu-devel] [PATCH] iov: avoid memcpy for "simple" iov_from_buf/iov_to_buf

On Fri, Dec 18, 2015 at 01:08:43PM +0800, Stefan Hajnoczi wrote: > On Wed, Dec 16, 2015 at 11:57:33AM +0100, Paolo Bonzini wrote: > > memcpy can take a large amount of time for small reads and writes. > > For virtio it is a common case that the first iovec can satisfy the > > whole read or write.

[Qemu-devel] [PULL 03/10] block-backend: add blk_get_max_iov()

Add a function to query BlockLimits.max_iov. Signed-off-by: Stefan Hajnoczi --- block/block-backend.c | 5 + include/sysemu/block-backend.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block/block-backend.c b/block/block-backend.c index

[Qemu-devel] [PULL 06/10] parallels: add format spec

From: Vladimir Sementsov-Ogievskiy This specifies Parallels image format as implemented in Parallels Cloud Server 6.10 Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Message-id:

[Qemu-devel] [PULL 04/10] block: replace IOV_MAX with BlockLimits.max_iov

Request merging must not result in a huge request that exceeds the maximum number of iovec elements. Use BlockLimits.max_iov instead of hardcoding IOV_MAX. Signed-off-by: Stefan Hajnoczi --- block/io.c| 3 ++- hw/block/virtio-blk.c | 2 +- 2 files changed, 3

[Qemu-devel] [PULL 05/10] block/mirror: replace IOV_MAX with blk_get_max_iov()

Use blk_get_max_iov() instead of hardcoding IOV_MAX, which may not apply to all BlockDrivers. Signed-off-by: Stefan Hajnoczi --- block/mirror.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index fc34a9c..f201f2b

[Qemu-devel] [PULL 07/10] scripts/gdb: Fix a python exception in mtree.py

From: Yang Wei The following exception is threw: Python Exception name 'long' is not defined: Error occurred in Python command: name 'long' is not defined Python 2.4+, int()/long() have been unified, so replace long with int. Signed-off-by: Yang Wei

Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure

> On 22 Dec 2015, at 11:26 AM, Miao Yan wrote: > > 2015-12-22 17:06 GMT+08:00 P J P : >> +-- On Tue, 22 Dec 2015, Miao Yan wrote --+ >> | > If '1' indicates the error, the 'default:' case in the same switch needs >> to be >> | > updated too. >> | >> |

Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()

On 12/22/2015 11:16 AM, Cao jin wrote: On 12/22/2015 03:34 PM, Marcel Apfelbaum wrote: On 12/22/2015 05:58 AM, Cao jin wrote: On 12/21/2015 11:49 PM, Paolo Bonzini wrote: On 20/12/2015 12:38, Cao jin wrote: +object_unref(OBJECT(ds)); +object_unref(OBJECT(bds)); +

Re: [Qemu-devel] [PATCH 54/74] pc: acpi: move remaining GPE handlers into SSDT

On Mon, Dec 21, 2015 at 04:35:23PM +0100, Igor Mammedov wrote: > On Sat, 19 Dec 2015 22:34:55 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Dec 10, 2015 at 12:41:48AM +0100, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > >

[Qemu-devel] [PATCH 1/1] doc: document chardev option 'append'

commit 31e38a22a0c5a25646f966f001e1f5513d5a186d Author: Olga Krishtal Date: Fri Dec 4 09:42:04 2015 +0300 qemu-char: append opt to stop truncation of serial file has added the option to the runtime but does not added it to -help output. This blocks

[Qemu-devel] [PATCH] block/qapi: Clear err for further error

Since a5002d5 (block/qapi: allow best-effort query) we don't return at this error, however err must be cleared before passing to bdrv_query_snapshot_info_list below, as required by error API. Signed-off-by: Fam Zheng --- block/qapi.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [PATCH v2 1/1] doc: document chardev option 'append'

On Tue, Dec 22, 2015 at 12:49:09PM +0300, Denis V. Lunev wrote: > commit 31e38a22a0c5a25646f966f001e1f5513d5a186d > Author: Olga Krishtal > Date: Fri Dec 4 09:42:04 2015 +0300 > > qemu-char: append opt to stop truncation of serial file > > has

[Qemu-devel] [PATCH 1/7] qom: add user_creatable_add & user_creatable_del methods

The QMP monitor code has two helper methods object_add and qmp_object_del that are called from several places in the code (QMP, HMP and main emulator startup). We soon need to use this code from qemu-img, qemu-io and qemu-nbd too, but don't want those to depend on the monitor. To avoid this,

[Qemu-devel] [PATCH 6/7] qemu-nbd: allow specifying image as a set of options args

Currently qemu-nbd allows an image filename to be passed on the command line, but does not have a way to set any options except the format eg qemu-nbd https://127.0.0.1/images/centos7.iso qemu-nbd /home/berrange/demo.qcow2 This adds a --source arg (that is mutually exclusive with a

  1   2   3   >