Re: [Qemu-devel] [PATCH v4 2/4] target-tilegx: Add single floating point implementation

2015-12-27 Thread Chen Gang
On 12/24/15 23:52, Chen Gang wrote: > On 12/24/15 07:07, Richard Henderson wrote: > >> Moreover, I thought we agreed to do away with that CALC bit. >> After check again, I guess, we can stil reserve CALC bit: - Then we can remove float32_to_sfmt (use high 32-bit to save float32 directly).

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-27 Thread Michael S. Tsirkin
On Fri, Dec 25, 2015 at 02:31:14PM -0800, Alexander Duyck wrote: > The PCI hot-plug specification calls out that the OS can optionally > implement a "pause" mechanism which is meant to be used for high > availability type environments. What I am proposing is basically > extending the standard

Re: [Qemu-devel] [PATCH v2 05/26] armv7m: add armv7m_excp_running_prio()

2015-12-27 Thread Michael Davidsaver
On 12/17/2015 09:36 AM, Peter Maydell wrote: > On 3 December 2015 at 00:18, Michael Davidsaver wrote: >> Implements v7m exception priority algorithm >> using FAULTMASK, PRIMASK, BASEPRI, and the highest >> priority active exception. >> >> The number returned is the current

[Qemu-devel] [PATCH v2 3/4] Add Error **errp for xen_pt_config_init()

2015-12-27 Thread Cao jin
To catch the error msg. Also modify the caller Signed-off-by: Cao jin --- hw/xen/xen_pt.c | 7 --- hw/xen/xen_pt.h | 2 +- hw/xen/xen_pt_config_init.c | 48 ++--- 3 files changed, 29 insertions(+),

[Qemu-devel] [PATCH v2 0/4] Convert to realize()

2015-12-27 Thread Cao jin
v2 changelog: 1. separate every supporting function into a single patch 2. Change supporting function type to void, for consistency 3. other fixes as per Stefano`s review @Stefano: the last patch build failure you feedback: qemu/hw/xen/xen_pt_config_init.c: In function ‘xen_pt_config_init’:

[Qemu-devel] [PATCH v2 1/4] Add Error **errp for xen_host_pci_device_get()

2015-12-27 Thread Cao jin
To catch the error msg. Also modify the caller Signed-off-by: Cao jin --- hw/xen/xen-host-pci-device.c | 102 --- hw/xen/xen-host-pci-device.h | 5 ++- hw/xen/xen_pt.c | 12 ++--- 3 files changed, 67

[Qemu-devel] [PATCH v2 2/4] Add Error **errp for xen_pt_setup_vga()

2015-12-27 Thread Cao jin
To catch the error msg. Also modify the caller Signed-off-by: Cao jin --- hw/xen/xen_pt.c | 5 - hw/xen/xen_pt.h | 3 ++- hw/xen/xen_pt_graphics.c | 11 ++- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/xen/xen_pt.c

Re: [Qemu-devel] [PATCH v2 02/26] armv7m: Undo armv7m.hack

2015-12-27 Thread Michael Davidsaver
On 12/17/2015 10:38 AM, Peter Maydell wrote: > On 3 December 2015 at 00:18, Michael Davidsaver wrote: >> Add CPU unassigned access handler in place of special >> MemoryRegion to catch exception returns. >> >> The unassigned handler will signal other faults as either >>

Re: [Qemu-devel] [PATCH v2 03/26] armv7m: Explicit error for bad vector table

2015-12-27 Thread Michael Davidsaver
On 12/17/2015 08:25 AM, Peter Maydell wrote: > On 3 December 2015 at 00:18, Michael Davidsaver wrote: >> ... >> +static >> +uint32_t arm_v7m_load_vector(ARMCPU *cpu) >> + >> +{ >> +CPUState *cs = >parent_obj; > This isn't the right way to cast to the base class of a QOM

[Qemu-devel] [PATCH v2 4/4] Xen PCI passthru: convert to realize()

2015-12-27 Thread Cao jin
Signed-off-by: Cao jin --- hw/xen/xen_pt.c | 53 - 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 3787c26..b058f61 100644 --- a/hw/xen/xen_pt.c +++

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-27 Thread Alexander Duyck
On Sun, Dec 27, 2015 at 1:21 AM, Michael S. Tsirkin wrote: > On Fri, Dec 25, 2015 at 02:31:14PM -0800, Alexander Duyck wrote: >> The PCI hot-plug specification calls out that the OS can optionally >> implement a "pause" mechanism which is meant to be used for high >> availability

Re: [Qemu-devel] [PATCH v2 06/26] armv7m: fix I and F flag handling

2015-12-27 Thread Michael Davidsaver
On 12/17/2015 10:18 AM, Peter Maydell wrote: > On 17 December 2015 at 14:39, Peter Maydell wrote: >> On 3 December 2015 at 00:18, Michael Davidsaver >> wrote: >>> Despite having the same notation, these bits >>> have completely different meaning

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-27 Thread Dong, Eddie
> > > > Even if the device driver doesn't support migration, you still want to > > migrate VM? That maybe risk and we should add the "bad path" for the > > driver at least. > > At a minimum we should have support for hot-plug if we are expecting to > support migration. You would simply have to

Re: [Qemu-devel] [PATCH COLO-Frame v12 31/38] COLO: Separate the process of saving/loading ram and device state

2015-12-27 Thread Hailiang Zhang
On 2015/12/18 18:53, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We separate the process of saving/loading ram and device state when do checkpoint, we add new helpers for save/load ram/device. With this change, we can directly transfer ram from master

[Qemu-devel] [PATCH] bugfix: passing reference instead of value

2015-12-27 Thread Cao jin
Fix the bug introduced by 595a4f07. Function host_pci_config_read() should be passed by a reference, not a value, for the later pci_default_write_config(). Signed-off-by: Cao jin --- Separated from previous "igd-passthru convert to realize" patch. Since these two don`t

Re: [Qemu-devel] live migration vs device assignment (motivation)

2015-12-27 Thread Alexander Duyck
On Sun, Dec 27, 2015 at 7:20 PM, Dong, Eddie wrote: >> > >> > Even if the device driver doesn't support migration, you still want to >> > migrate VM? That maybe risk and we should add the "bad path" for the >> > driver at least. >> >> At a minimum we should have support for

Re: [Qemu-devel] [PATCH v4 0/7] vmxnet3: Fine-tune device capabilities

2015-12-27 Thread Jason Wang
On 12/24/2015 03:17 PM, Shmulik Ladkani wrote: > Various fixes to what the vmxnet3 device reports in its PCI > configuration space, in order to be aligned with VMware virtual hardware > exposed by ESXi/Workstation. > > Since v3: Place back-compat flags into HW_COMPAT_2_5 > Since v2: Introduce

[Qemu-devel] [PATCH v2] bugfix: passing reference instead of value

2015-12-27 Thread Cao jin
Fix the bug introduced by 595a4f07: Function host_pci_config_read() should be passed by a reference, not a value, for the later pci_default_write_config(). And because value in PCI config space are little-endian, use cpu_to_le32() to ensure it when write config. Signed-off-by: Cao jin

Re: [Qemu-devel] [PATCH v2 02/26] armv7m: Undo armv7m.hack

2015-12-27 Thread Michael Davidsaver
On 12/17/2015 10:38 AM, Peter Maydell wrote: > We could use a comment here (a) explaining what we're doing and (b) > mentioning that this isn't architecturally correct -- ideally we should > catch these exception exits on execution of the jump insn, not by > letting the jump execute and then

[Qemu-devel] How to reserve guest physical region for ACPI

2015-12-27 Thread Xiao Guangrong
Hi Michael, Paolo, Now it is the time to return to the challenge that how to reserve guest physical region internally used by ACPI. Igor suggested that: | An alternative place to allocate reserve from could be high memory. | For pc we have "reserved-memory-end" which currently makes sure |

[Qemu-devel] [Bug 1529187] Re: vfio passtrhough fails at 'No available IOMMU models' on Intel BDW-EP platform

2015-12-27 Thread Robert Hu
You're right. After I manually load vfio_iommu_type1, the error is gone. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1529187 Title: vfio

Re: [Qemu-devel] [PATCH v2] net: rocker: fix an incorrect array bounds check

2015-12-27 Thread Jason Wang
On 12/23/2015 01:14 PM, P J P wrote: > +-- On Tue, 22 Dec 2015, Peter Maydell wrote --+ > | Could you submit patches in the usual git send-email format, > | please? It's easier for maintainers to process them if they're > | not in an odd arrangement that requires manual intervention. > | (In

Re: [Qemu-devel] [PATCH] spapr: Introduce SPAPR_COMPAT_2_5

2015-12-27 Thread David Gibson
On Thu, Dec 24, 2015 at 12:44:59PM +0200, Shmulik Ladkani wrote: > Hi, > > On Thu, 24 Dec 2015 19:25:27 +1100, da...@gibson.dropbear.id.au wrote: > > On Wed, Dec 23, 2015 at 09:33:35PM +0200, Shmulik Ladkani wrote: > > > In 240240d5 'pc: Add pc-*-2.6 machine classes' HW_COMPAT_2_5 and > > >

Re: [Qemu-devel] [PATCH COLO-Frame v12 10/38] COLO: Implement colo checkpoint protocol

2015-12-27 Thread Hailiang Zhang
On 2015/12/18 22:52, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We need communications protocol of user-defined to control the checkpoint process. The new checkpoint request is started by Primary VM, and the interactive process like below: Checkpoint

Re: [Qemu-devel] [PATCH COLO-Frame v12 23/38] COLO: Implement failover work for Primary VM

2015-12-27 Thread Hailiang Zhang
On 2015/12/18 23:35, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: For PVM, if there is failover request from users. The colo thread will exit the loop while the failover BH does the cleanup work and resumes VM. Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH COLO-Frame v12 32/38] COLO: Split qemu_savevm_state_begin out of checkpoint process

2015-12-27 Thread Hailiang Zhang
On 2015/12/18 20:01, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: It is unnecessary to call qemu_savevm_state_begin() in every checkponit process. It mainly sets up devices and does the first device state pass. These data will not change during the later