Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

> On 12 Jan 2016, at 09:23 AM, Miao Yan wrote: > > Hi Dmitry, > > 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman : >> >>> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: >>> >>> Turning debug printfs to trace points for register access >> >> Hello Miao! >> >> While I’m into adding trace points I

Re: [Qemu-devel] [PATCH v1] kvm/x86: Hyper-V tsc page setup

ping On 12/24/2015 12:33 PM, Andrey Smetanin wrote: Lately tsc page was implemented but filled with empty values. This patch setup tsc page scale and offset based on vcpu tsc, tsc_khz and HV_X64_MSR_TIME_REF_COUNT value. The valid tsc page drops HV_X64_MSR_TIME_REF_COUNT msr reads count to zero

Re: [Qemu-devel] [PATCH 2/8] ipmi: add get and set SENSOR_TYPE commands

On 01/08/2016 09:23 PM, Corey Minyard wrote: > Acked-by: Corey Minyard > > I agree with Greg's comments, too. Me also. I will rework the code to use ARRAY_SIZE or something similar. Thanks, C. > -corey > > On 01/05/2016 11:29 AM, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH 5/8] ipmi: add ACPI power and GUID commands

On 01/08/2016 08:46 PM, Corey Minyard wrote: > On 01/05/2016 11:29 AM, Cédric Le Goater wrote: >> Signed-off-by: Cédric Le Goater >> --- >> hw/ipmi/ipmi_bmc_sim.c | 55 >> ++ >> 1 file changed, 55 insertions(+) >> >> diff --git a/hw/ipmi/ipmi_bmc

Re: [Qemu-devel] [PATCH 4/8] ipmi: add FRU support

Hello, On 01/08/2016 08:41 PM, Corey Minyard wrote: > On 01/05/2016 11:29 AM, Cédric Le Goater wrote: >> This patch provides a simplistic FRU support for the IPMI BMC >> simulator. The FRU area contains 32 entries * 256 bytes which should >> be enough to start some simulation. >> >> Signed-off-by

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/11/2016 08:59 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: On 01/08/2016 07:19 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: From: zhangchen Hi,all This patch add an colo-proxy object, COLO-Proxy is a

Re: [Qemu-devel] [PATCH] block: Fix .bdrv_open flags

On 01/11/2016 07:32 PM, Kevin Wolf wrote: > bdrv_common_open() modified bs->open_flags after inferring the set of > options to pass to the driver's .bdrv_open callback. This means that the > cache options were correctly set in bs->open_flags (and therefore > correctly displayed in 'info block'), bu

Re: [Qemu-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

On 12.01.2016 04:42, Jason Wang wrote: > > On 01/11/2016 11:55 PM, Thomas Huth wrote: >> On 15.12.2015 09:35, Thomas Huth wrote: >>> We don't want to support the legacy -tftp, -bootp, -smb and >>> -net channel options forever. So let's start telling the users >>> that they will go away in a future

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

Hi Dmitry, 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman : > >> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: >> >> Turning debug printfs to trace points for register access > > Hello Miao! > > While I’m into adding trace points I don’t really like the decrease of logs > usability introduced by this

Re: [Qemu-devel] [PATCH] PCI: add param check for api

Thanks for your time. I almost forget this one... On 01/11/2016 05:20 PM, Paolo Bonzini wrote: On 11/01/2016 09:32, Michael Tokarev wrote: +assert(size > 0); +assert(offset >= PCI_CONFIG_HEADER_SIZE || !offset); + I'd like to see some ACKs/Reviews for this one, in particular why siz

Re: [Qemu-devel] [PATCH v6 06/11] cpu: Add a sync version of cpu_remove()

On Tue, Jan 12, 2016 at 03:16:15PM +1100, David Gibson wrote: > On Fri, Jan 08, 2016 at 12:25:14PM +0530, Bharata B Rao wrote: > > This sync API will be used by the CPU hotplug code to wait for the CPU to > > completely get removed before flagging the failure to the device_add > > command. > > > >

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

> On 12 Jan 2016, at 04:38 AM, Miao Yan wrote: > > Turning debug printfs to trace points for register access Hello Miao! While I’m into adding trace points I don’t really like the decrease of logs usability introduced by this patch. Current code produces clear human readable log that allows t

Re: [Qemu-devel] [PATCH] PCI: add param check for api

On 01/11/2016 04:32 PM, Michael Tokarev wrote: 21.11.2015 10:45, Cao jin wrote: add param check for pci_add_capability2, as it is a public API. Signed-off-by: Cao jin --- hw/pci/pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 168b9cc..6938f64

Re: [Qemu-devel] [PATCH 1/2] create ga_run_program() helper for guest-set-user-password

On 01/11/2016 03:08 PM, Yuriy Pudgorodskiy wrote: On 1/6/2016 4:50 PM, Denis V. Lunev wrote: hmmm Yur, it seems that you have re-invented the wheel with gboolean g_spawn_sync (/|const gchar

[Qemu-devel] [PATCH 16/25] 9pfs: factor out pdu_push_and_notify

From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 6d32b81faa25..e97adc8ba3f2 100644 --- a/hw/9pfs/virtio-9p.c +++ b/

[Qemu-devel] [PATCH 14/25] 9pfs: make pdu_{, un}marshal proper functions

From: Wei Liu Factor out v9fs_iov_v{,un}marshal. Implement pdu_{,un}marshal with those functions. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- fsdev/9p-iov-marshal.c | 42 ++ fsdev/9p-iov-marshal.h | 5 + hw/9pfs/virtio-9p.c| 26 +

[Qemu-devel] [PULL 00/25] VirtFS update

The following changes since commit a7e00e2536941a6e570b45b7ab4afec4505ff67e: petalogix-ml605: Set the MicroBlaze CPU version to 8.10.a (2016-01-07 14:57:26 +0100) are available in the git repository at: https://github.com/kvaneesh/qemu.git tags/for-upstream-signed for you to fetch changes

[Qemu-devel] [PATCH 07/25] 9pfs: rename virtio-9p-xattr{, -user}.{c, h} to 9p-xattr{, -user}.{c, h}

From: Wei Liu These three files are not virtio specific. Rename them to generic names. Fix comments and header inclusion in various files. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/9p-handle.c | 2 +- hw/9pfs/9p-local.c

[Qemu-devel] [PATCH 20/25] 9pfs: export pdu_{submit,alloc,free}

From: Wei Liu They will be used in later patches. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/9p.h| 3 +++ hw/9pfs/virtio-9p.c | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h index 9aeb8745cf20..b62c9a885a45

[Qemu-devel] [PATCH 02/25] 9pfs: rename virtio-9p-handle.c to 9p-handle.c

From: Wei Liu This file is not virtio specific. Rename it to use generic name. Fix comment and remove unneeded inclusion of virtio.h. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/{virtio-9p-handle.c => 9p-handle.c} | 3 +-- hw/9pfs/Makefile.objs |

[Qemu-devel] [PATCH 23/25] 9pfs: rename virtio-9p.c to 9p.c

From: Wei Liu Now that file only contains generic code. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/{virtio-9p.c => 9p.c} | 0 hw/9pfs/Makefile.objs | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename hw/9pfs/{virtio-9p.c => 9p.c} (100%) diff --git a

[Qemu-devel] [PATCH 17/25] 9pfs: break out virtio_init_iov_from_pdu

From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c | 12 hw/9pfs/virtio-9p.c| 8 +--- hw/9pfs/virtio-9p.h| 2 ++ 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9

[Qemu-devel] [PATCH 18/25] 9pfs: break out 9p.h from virtio-9p.h

From: Wei Liu Move out generic definitions from virtio-9p.h to 9p.h. Fix header inclusions. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/9p-handle.c | 2 +- hw/9pfs/9p-local.c | 2 +- hw/9pfs/9p-posix-acl.c | 2 +- hw/9pfs/9p-proxy.c | 2 +- hw/9pf

[Qemu-devel] [PATCH 19/25] 9pfs: factor out virtio_9p_push_and_notify

From: Wei Liu The new function resides in virtio specific file. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c | 11 +++ hw/9pfs/virtio-9p.c| 8 +--- hw/9pfs/virtio-9p.h| 2 ++ 3 files changed, 14 insertions(+), 7 deletions(

[Qemu-devel] [PATCH 24/25] 9pfs: factor out v9fs_device_{, un}realize_common

From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/9p.c | 95 ++ hw/9pfs/9p.h | 2 + hw/9pfs/virtio-9p-device.c | 90 --- 3 files changed, 104 insertio

[Qemu-devel] [PATCH 06/25] 9pfs: rename virtio-9p-synth.{c, h} to 9p-synth.{c, h}

From: Wei Liu These two files are not virtio specific. Rename them to use generic names. Fix includes in various C files. Change define guards and comments in header files. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/{virtio-9p-synth.c => 9p-synth.c} | 2 +- hw/9pfs/{v

[Qemu-devel] [PATCH 03/25] 9pfs: rename virtio-9p-local.c to 9p-local.c

From: Wei Liu This file is not virtio specific. Rename it to use generic name. Fix comment and remove unneeded inclusion of virtio.h. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/{virtio-9p-local.c => 9p-local.c} | 3 +-- hw/9pfs/Makefile.objs | 2 +-

[Qemu-devel] [PATCH 10/25] fsdev: break out 9p-marshal.{c, h} from virtio-9p-marshal.{c, h}

From: Wei Liu Break out some generic functions for marshaling 9p state. Pure code motion plus minor fixes for build system. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- Makefile | 2 +- fsdev/9p-marshal.c| 56 +++ fsdev/9p-ma

[Qemu-devel] [PATCH 21/25] 9pfs: move handle_9p_output and make it static function

From: Wei Liu It's only used in virtio device. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c | 34 ++ hw/9pfs/virtio-9p.c| 33 - hw/9pfs/virtio-9p.h| 1 - 3 files changed,

[Qemu-devel] [PATCH 11/25] fsdev: rename virtio-9p-marshal.{c, h} to 9p-iov-marshal.{c, h}

From: Wei Liu And rename v9fs_marshal to v9fs_iov_marshal, v9fs_unmarshal to v9fs_iov_unmarshal. The rationale behind this change is that, this marshalling interface is used both by virtio and proxy helper. Renaming files and functions to reflect the true nature of this interface. Xen transport

[Qemu-devel] [PATCH 09/25] 9pfs: remove dead code

From: Wei Liu Some structures in virtio-9p.h have been unused since 2011 when relevant functions switched to use coroutines. The declaration of pdu_packunpack and function do_pdu_unpack are useless. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.h | 68 -

[Qemu-devel] [PATCH 25/25] 9pfs: introduce V9fsVirtioState

From: Wei Liu V9fsState now only contains generic fields. Introduce V9fsVirtioState for virtio transport. Change virtio-pci and virtio-ccw to use V9fsVirtioState. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/9p.c | 11 +-- hw/9pfs/9p.h |

[Qemu-devel] [PATCH 01/25] 9pfs: rename virtio-9p-coth.{c, h} to coth.{c, h}

From: Wei Liu Those two files are not virtio specific. Rename them to use generic names. Fix includes in various C files. Change define guards and comments in header files. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/Makefile.objs| 2 +- hw/9pfs/codir.c

[Qemu-devel] [PATCH 15/25] 9pfs: factor out virtio_pdu_{, un}marshal

From: Wei Liu Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c | 14 ++ hw/9pfs/virtio-9p.c| 6 ++ hw/9pfs/virtio-9p.h| 5 + 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/h

[Qemu-devel] [PATCH 12/25] 9pfs: PDU processing functions don't need to take V9fsState as argument

From: Wei Liu V9fsState can be referenced by pdu->s. Initialise that in device realization function. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c | 1 + hw/9pfs/virtio-9p.c| 98 +- 2 files changed, 4

[Qemu-devel] [PATCH 08/25] 9pfs: merge hw/virtio/virtio-9p.h into hw/9pfs/virtio-9p.h

From: Wei Liu The deleted file only contained V9fsConf which wasn't virtio specific. Merge that to the general header of 9pfs. Fixed header inclusions as I went along. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-device.c| 1 - hw/9pfs/virtio-9p.h

[Qemu-devel] [PATCH 04/25] 9pfs: rename virtio-9p-posix-acl.c to 9p-posix-acl.c

From: Wei Liu This file is not virtio specific. Rename it to use generic name. Fix comment and remove unneeded inclusion of virtio.h. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/{virtio-9p-posix-acl.c => 9p-posix-acl.c} | 3 +-- hw/9pfs/Makefile.objs

[Qemu-devel] [PATCH 22/25] 9pfs: rename virtio_9p_set_fd_limit to use v9fs_ prefix

From: Wei Liu It's not virtio specific. Signed-off-by: Wei Liu --- hw/9pfs/virtio-9p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 7fb05240987e..379fdcb2fe86 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -3

[Qemu-devel] [PATCH 13/25] 9pfs: PDU processing functions should start pdu_ prefix

From: Wei Liu This matches naming convention of pdu_marshal and pdu_unmarshal. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 88 ++--- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/hw/9pfs/vir

[Qemu-devel] [PATCH 05/25] 9pfs: rename virtio-9p-proxy.{c, h} to 9p-proxy.{c, h}

From: Wei Liu Those two files are not virtio specific. Rename them to use generic names. Fix includes in various C files. Change define guards and comments in header files. Signed-off-by: Wei Liu Signed-off-by: Aneesh Kumar K.V --- fsdev/virtfs-proxy-helper.c | 2 +- hw/9pfs/{v

Re: [Qemu-devel] [PATCH v6 11/11] spapr: CPU hot unplug support

On Fri, Jan 08, 2016 at 12:25:19PM +0530, Bharata B Rao wrote: > Remove the CPU core device by removing the underlying CPU thread devices. > Support hot removal of CPU for sPAPR guests by sending the hot unplug > notification to the guest via EPOW interrupt. Release the vCPU object > after CPU hot

Re: [Qemu-devel] [PATCH v6 10/11] spapr: CPU hotplug support

On Fri, Jan 08, 2016 at 12:25:18PM +0530, Bharata B Rao wrote: > Support CPU hotplug via device-add command like this: > > (qemu) device_add powerpc64-cpu-core,id=core2 > > In response to device_add, CPU core device will be created. CPU core > device creates and realizes CPU thread devices. If th

Re: [Qemu-devel] [PATCH v6 09/11] spapr: Enable CPU hotplug for pseries-2.6 and add CPU DRC DT entries

On Fri, Jan 08, 2016 at 12:25:17PM +0530, Bharata B Rao wrote: > Start supporting CPU hotplug from pseries-2.6 onwards. Add CPU > DRC (Dynamic Resource Connector) device tree entries. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson > --- > hw/ppc/spapr.c | 23 ++

[Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

There is a long-long story. OVMF VMs can not be snapsotted using 'virsh snapshot' as they have "pflash" device which is configured as "raw" image. There was a discussion in the past about that. Good description has been provided on topic by Laszlo Ersek, see below: "It is true that a pflash drive

Re: [Qemu-devel] [PATCH] block: Fix .bdrv_open flags

On 01/11/2016 09:32 PM, Kevin Wolf wrote: bdrv_common_open() modified bs->open_flags after inferring the set of options to pass to the driver's .bdrv_open callback. This means that the cache options were correctly set in bs->open_flags (and therefore correctly displayed in 'info block'), but the

Re: [Qemu-devel] [PATCH 2/2] ppc: Allow 64kiB pages for POWER8 in TCG

On 01/12/2016 03:33 PM, David Gibson wrote: On Tue, Jan 12, 2016 at 03:30:33PM +1100, Alexey Kardashevskiy wrote: On 01/12/2016 11:26 AM, David Gibson wrote: On Fri, Jan 08, 2016 at 02:56:02PM +1100, Alexey Kardashevskiy wrote: On 12/21/2015 01:41 PM, David Gibson wrote: Now that the spapr co

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

On 01/11/2016 08:31 PM, Kevin Wolf wrote: Am 23.12.2015 um 08:46 hat Denis V. Lunev geschrieben: From: Olga Krishtal While opening the image we want to be sure that we are the one who works with image, anf if it is not true - opening the image for writing should fail. There are 2 ways at the

Re: [Qemu-devel] [PATCH] SPARC ebus: QOMify

ping? On 01/06/2016 09:40 PM, Cao jin wrote: Signed-off-by: Cao jin --- hw/sparc64/sun4u.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index d6b929c..07f74fe 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -9

Re: [Qemu-devel] [PATCH v2 7/7] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check

On Mon, Jan 11, 2016 at 12:18:59PM +0100, Eric Auger wrote: > Hi David, > On 01/11/2016 03:45 AM, David Gibson wrote: > > On Wed, Jan 06, 2016 at 03:13:25PM +, Eric Auger wrote: > >> qemu_fdt_setprop self-exists in case of error hence no need to check > >> the returned value. > >> > >> Signed-o

Re: [Qemu-devel] [PATCH v6 08/11] target-ppc: Introduce PowerPC specific CPU core device

On Fri, Jan 08, 2016 at 12:25:16PM +0530, Bharata B Rao wrote: > CPU core device is a container of CPU thread devices. CPU hotplug is > performed at the granularity of CPU core device. When hotplugged, CPU core > creates CPU thread devices. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gi

Re: [Qemu-devel] [PATCH v6 01/11] machine: Don't allow CPU toplogies with partially filled cores

On Fri, Jan 08, 2016 at 12:25:09PM +0530, Bharata B Rao wrote: > Prevent guests from booting with CPU topologies that have partially > filled CPU cores or can result in partially filled CPU cores after > CPU hotplug like > > -smp 15,sockets=1,cores=4,threads=4,maxcpus=16 or > -smp 15,sockets=1,cor

Re: [Qemu-devel] [PATCH v6 06/11] cpu: Add a sync version of cpu_remove()

On Fri, Jan 08, 2016 at 12:25:14PM +0530, Bharata B Rao wrote: > This sync API will be used by the CPU hotplug code to wait for the CPU to > completely get removed before flagging the failure to the device_add > command. > > Sync version of this call is needed to correctly recover from CPU > reali

Re: [Qemu-devel] [PATCH 2/2] ppc: Allow 64kiB pages for POWER8 in TCG

On Tue, Jan 12, 2016 at 03:30:33PM +1100, Alexey Kardashevskiy wrote: > On 01/12/2016 11:26 AM, David Gibson wrote: > >On Fri, Jan 08, 2016 at 02:56:02PM +1100, Alexey Kardashevskiy wrote: > >>On 12/21/2015 01:41 PM, David Gibson wrote: > >>>Now that the spapr code has been extended to support 64ki

Re: [Qemu-devel] [PATCH v6 07/11] xics, xics_kvm: Handle CPU unplug correctly

On Fri, Jan 08, 2016 at 12:25:15PM +0530, Bharata B Rao wrote: > XICS is setup for each CPU during initialization. Provide a routine > to undo the same when CPU is unplugged. While here, move ss->cs management > into xics from xics_kvm since there is nothing KVM specific in it. > Also ensure xics r

Re: [Qemu-devel] [PATCH v6 05/11] cpu: Reclaim vCPU objects

On Fri, Jan 08, 2016 at 12:25:13PM +0530, Bharata B Rao wrote: > From: Gu Zheng > > In order to deal well with the kvm vcpus (which can not be removed without any > protection), we do not close KVM vcpu fd, just record and mark it as stopped > into a list, so that we can reuse it for the appendin

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

On Wed, Dec 16, 2015 at 06:22:20PM +0100, Igor Mammedov wrote: > On Wed, 16 Dec 2015 16:57:54 +0100 > Andreas Färber wrote: > > > Am 16.12.2015 um 16:44 schrieb Igor Mammedov: > > > On Wed, 16 Dec 2015 16:19:06 +0100 > > > Andreas Färber wrote: > > > > > >> Am 10.12.2015 um 07:15 schrieb Bharat

Re: [Qemu-devel] [PATCH v2 3/7] device_tree: introduce qemu_fdt_node_path

On Mon, Jan 11, 2016 at 11:35:50AM +0100, Eric Auger wrote: > Hi David, > On 01/11/2016 03:38 AM, David Gibson wrote: > > On Wed, Jan 06, 2016 at 03:13:21PM +, Eric Auger wrote: > >> This new helper routine returns the node path of a device > >> referred to by its node name and compat string. >

Re: [Qemu-devel] [PATCH v6 04/11] cpu: Don't realize CPU from cpu_generic_init()

On Fri, Jan 08, 2016 at 12:25:12PM +0530, Bharata B Rao wrote: > Don't do CPU realization from cpu_generic_init(). With this > cpu_generic_init() will be used to just create CPU threads and they > should be realized separately from realizefn call. > > Convert the existing callers to do explicit re

Re: [Qemu-devel] [PATCH v6 02/11] exec: Remove cpu from cpus list during cpu_exec_exit()

On Fri, Jan 08, 2016 at 12:25:10PM +0530, Bharata B Rao wrote: > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It > should be removed from cpu_exec_exit(). > > cpu_exec_init() is called from generic CPU::instance_finalize and some > archs like PowerPC call it from CPU unrealize

Re: [Qemu-devel] [PATCH 2/2] ppc: Allow 64kiB pages for POWER8 in TCG

On 01/12/2016 11:26 AM, David Gibson wrote: On Fri, Jan 08, 2016 at 02:56:02PM +1100, Alexey Kardashevskiy wrote: On 12/21/2015 01:41 PM, David Gibson wrote: Now that the spapr code has been extended to support 64kiB pages, we can allow guests to use 64kiB pages on an emulated POWER8 by adding

Re: [Qemu-devel] [PATCH] ivshmem: Store file descriptor for vhost-user negotiation

On 2016/01/12 4:20, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> On Fri, Dec 4, 2015 at 3:55 PM, Tetsuya Mukawa wrote: What's the use case or test case? >>> One of example is userspace device driver like DPDK PMD. >>> Actually, I've found this fd related behavior using

Re: [Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode

On 01/12/2016 10:22 AM, Hailiang Zhang wrote: > Hi, > > It seems that, Jan Kiszka is maintaining SLIRP (From MAINTAINERS file), > Maybe he could make a help to merge this series. > > TO: J. Kiszka > > Thanks, > Hailiang Right, and I can take this series in my tree if Jan doesn't have time to do

Re: [Qemu-devel] [PATCH v10 5/7] hw/ptimer: Legalize running with delta = load = 0

On Sat, Jan 09, 2016 at 08:39:53PM +0300, Dmitry Osipenko wrote: > Currently ptimer would print error message and clear enable flag for an > arming timer that has delta = load = 0. That actually could be a valid case > for some hardware, like instant IRQ trigger for oneshot timer or continuous > in

Re: [Qemu-devel] [PATCH v10 6/7] hw/ptimer: Introduce ptimer_get_limit

On Sat, Jan 09, 2016 at 08:39:54PM +0300, Dmitry Osipenko wrote: > Currently ptimer users are used to store copy of the limit value, because > ptimer doesn't provide facility to retrieve the limit. Let's provide it. > > Signed-off-by: Dmitry Osipenko Fair call. One less piece of duped state for

Re: [Qemu-devel] [PATCH v4 5/8] device_tree: qemu_fdt_getprop_cell converted to use the error API

On Fri, Jan 08, 2016 at 09:32:02AM +, Eric Auger wrote: > This patch aligns the prototype with qemu_fdt_getprop. The caller > can choose whether the function self-asserts on error (passing > &error_fatal as Error ** argument, corresponding to the legacy behavior), > or behaves differently such

Re: [Qemu-devel] [PATCH v4 4/8] device_tree: qemu_fdt_getprop converted to use the error API

On Fri, Jan 08, 2016 at 09:32:01AM +, Eric Auger wrote: > Current qemu_fdt_getprop exits if the property is not found. It is > sometimes needed to read an optional property, in which case we do > not wish to exit but simply returns a null value. > > This patch converts qemu_fdt_getprop to acce

Re: [Qemu-devel] [PATCH v3 7/7] raspi: add raspberry pi 2 machine

On Thu, Dec 31, 2015 at 04:31:34PM -0800, Andrew Baumann wrote: > bcm2835/Pi1 requires more peripherals, and will be added in a later > patch series. > > Signed-off-by: Andrew Baumann > --- > > Notes: > v3: > * fix board setup to remain Pi1 compatible > * pass ram property > > hw

Re: [Qemu-devel] [PATCH v3 6/7] bcm2836: add bcm2836 soc device

On Thu, Dec 31, 2015 at 04:31:33PM -0800, Andrew Baumann wrote: > This is the SoC for Raspberry Pi 2. > > Signed-off-by: Andrew Baumann > --- > The use of smp_cpus is dubious here. Ideally it should be passed as a > property from the board, but I found that simply initialising (and not > later re

Re: [Qemu-devel] [PATCH v3 5/7] bcm2836_control: add bcm2836 ARM control logic

On Thu, Dec 31, 2015 at 04:31:32PM -0800, Andrew Baumann wrote: > This module is specific to the bcm2836 (Pi2). It implements the top > level interrupt controller, and mailboxes used for inter-processor > synchronisation. > > Signed-off-by: Andrew Baumann > --- > > Notes: > v3: > * uint

Re: [Qemu-devel] [PATCH v3 2/7] bcm2835_property: add bcm2835 property channel

On Thu, Dec 31, 2015 at 04:31:29PM -0800, Andrew Baumann wrote: > This sits behind the mailbox interface, and implements > request/response queries for system properties. The > framebuffer-related properties will be added in a later patch. > > Signed-off-by: Andrew Baumann > --- > hw/misc/Makefi

Re: [Qemu-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

On 01/11/2016 11:55 PM, Thomas Huth wrote: > On 15.12.2015 09:35, Thomas Huth wrote: >> We don't want to support the legacy -tftp, -bootp, -smb and >> -net channel options forever. So let's start telling the users >> that they will go away in a future version. >> >> Signed-off-by: Thomas Huth >>

Re: [Qemu-devel] [PATCH v2 1/2] dec: convert to realize()

On 01/12/2016 03:07 AM, Markus Armbruster wrote: Cao jin writes: [...] Correct because pci_bridge_initfn() can't fail. Suggest to mention that in the commit message. Ok, thanks for suggestion:) -- Yours Sincerely, Cao jin

[Qemu-devel] [PATCH v16 09/14] add check reset mechanism when hotplug vfio device

From: Chen Fan Since we support multi-function hotplug. the function 0 indicate the closure of the slot, so we have the chance to do the check. Signed-off-by: Chen Fan --- hw/pci/pci.c | 29 + hw/vfio/pci.c| 19 +++ hw/vfio/pc

Re: [Qemu-devel] [PATCH 4/4] target-ppc: ensure we include the decrementer value during migration

On Mon, Jan 11, 2016 at 07:43:54AM +, Mark Cave-Ayland wrote: > On 11/01/16 04:55, David Gibson wrote: > > > On Mon, Jan 11, 2016 at 12:18:31PM +1100, Alexey Kardashevskiy wrote: > >> On 01/09/2016 01:21 AM, Mark Cave-Ayland wrote: > >>> On 08/01/16 02:47, Alexey Kardashevskiy wrote: > >>> > >

[Qemu-devel] [PATCH v16 07/14] vfio: add aer support for vfio device

From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 81 --- hw/vfio/pci.h | 3 +++ 2 fil

[Qemu-devel] [PATCH v16 11/14] vfio: introduce last reset sequence id

From: Chen Fan avoid multi-reset host bus, we introduce sequence id to secify which bus is resetting. and if one of the dependent devices has been do reset. the others should skip. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 15 +++ hw/vfio/pci.h | 3 +++ 2 files changed, 18 inser

[Qemu-devel] [PATCH v16 13/14] vfio-pci: pass the aer error to guest

From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting invoked. this patch is to pass the error to guest and have the guest driver recover from the

[Qemu-devel] [PATCH v16 08/14] vfio: add check host bus reset is support or not

From: Chen Fan when init vfio devices done, we should test all the devices supported aer whether conflict with others. For each one, get the hot reset info for the affected device list. For each affected device, all should attach to the VM and on/below the same bus. also, we should test all of t

[Qemu-devel] [PATCH v16 10/14] pci: introduce pci bus pre reset

From: Chen Fan avoid repeat bus reset, here introduce a sequence ID for each time bus hot reset, so each vfio device could know whether they've already been reset for that sequence ID. Signed-off-by: Chen Fan --- hw/pci/pci.c | 13 + hw/pci/pci_bridge.c | 3 +++ i

[Qemu-devel] [PATCH v16 14/14] vfio: add 'aer' property to expose aercap

From: Chen Fan add 'aer' property to let user able to decide whether expose the aer capability. by default we should disable aer feature, because it needs configuration restrictions. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio/pci.c b

[Qemu-devel] [PATCH v16 05/14] vfio: add pcie extanded capability support

From: Chen Fan For vfio pcie device, we could expose the extended capability on PCIE bus. in order to avoid config space broken, we introduce a copy config for parsing extended caps. and rebuild the pcie extended config space. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 70

[Qemu-devel] [PATCH v16 03/14] pcie: modify the capability size assert

From: Chen Fan Device's Offset and size can reach PCIE_CONFIG_SPACE_SIZE, fix the corresponding assert. Signed-off-by: Chen Fan Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c

[Qemu-devel] [PATCH v16 06/14] aer: impove pcie_aer_init to support vfio device

From: Chen Fan pcie_aer_init was used to emulate an aer capability for pcie device, but for vfio device, the aer config space size is mutable and is not always equal to PCI_ERR_SIZEOF(0x48). it depends on where the TLP Prefix register required, so here we add a size argument. Signed-off-by: Chen

[Qemu-devel] [PATCH v16 02/14] vfio: squeeze out vfio_pci_do_hot_reset for support bus reset

From: Chen Fan squeeze out vfio_pci_do_hot_reset to do host bus reset when AER recovery. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 75 +++ 1 file changed, 44 insertions(+), 31 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c ind

[Qemu-devel] [PATCH v16 12/14] pcie_aer: expose pcie_aer_msg() interface

From: Chen Fan For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan Reviewed-by: Michael S. Tsirkin --- hw/pci/pcie_aer.c | 2 +- include/hw/pci/pcie_aer.h | 1 + 2 files changed, 2 insertions(+)

[Qemu-devel] [PATCH v16 00/14] vfio-pci: pass the aer error to guest

From: Chen Fan For now, for vfio pci passthough devices when qemu receives an error from host aer report, currentlly just terminate the guest, but usually user want to know what error occurred but stopping the guest, so this patches add aer capability support for vfio device, and pass the error t

[Qemu-devel] [PATCH v16 04/14] vfio: make the 4 bytes aligned for capability size

From: Chen Fan this function search the capability from the end, the last size should 0x100 - pos, not 0xff - pos. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index a63cf85..288f2c7 100644 --- a/h

[Qemu-devel] [PATCH v16 01/14] vfio: extract vfio_get_hot_reset_info as a single function

From: Chen Fan the function is used to get affected devices by bus reset. so here extract it, and can used for aer soon. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 66 +++ 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/h

[Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

Turning debug printfs to trace points for register access Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 68 +--- trace-events | 6 + 2 files changed, 16 insertions(+), 58 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

I used 6bb9ead762bf749af11ea225fc2a74db1b93c105 yesterday, this version don't include commit 349a3b1cc. Thanks, -Xudong > -Original Message- > From: Cao jin [mailto:caoj.f...@cn.fujitsu.com] > Sent: Tuesday, January 12, 2016 10:01 AM > To: Hao, Xudong ; Stefano Stabellini > > Cc: Lars

Re: [Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode

Hi, It seems that, Jan Kiszka is maintaining SLIRP (From MAINTAINERS file), Maybe he could make a help to merge this series. TO: J. Kiszka Thanks, Hailiang On 2016/1/11 23:04, Samuel Thibault wrote: Hello, Samuel Thibault, on Sat 19 Dec 2015 22:24:40 +0100, wrote: This is another respin of

Re: [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: convert to realize()

On 01/11/2016 10:32 PM, Markus Armbruster wrote: Cao jin writes: [...] Ok...will change the error msg to strerror(errno) There's also error_setg_file_open(), not sure it fits here, but check it out. Thanks for reminding. Gerd Hoffmann has whole patchset(http://lists.nongnu.org/archi

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

Hi On 01/11/2016 05:53 PM, Hao, Xudong wrote: Stefano, Patch http://marc.info/?l=qemu-devel&m=145137863501079 don't works for qemu at all, some conflict when git apply. Patch http://marc.info/?l=qemu-devel&m=145137863501079 is based on patch http://marc.info/?l=qemu-devel&m=145172165010604, r

Re: [Qemu-devel] [RFC PATCH v2 02/10] Jhash: add linux kernel jhashtable in qemu

On 01/11/2016 08:50 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: On 01/08/2016 08:08 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: From: zhangchen Jhash used by colo-proxy to save and lookup net connection in

Re: [Qemu-devel] [PATCH 2/2] ppc: Allow 64kiB pages for POWER8 in TCG

On Fri, Jan 08, 2016 at 02:56:02PM +1100, Alexey Kardashevskiy wrote: > On 12/21/2015 01:41 PM, David Gibson wrote: > >Now that the spapr code has been extended to support 64kiB pages, we can > >allow guests to use 64kiB pages on an emulated POWER8 by adding it to the > >"segment_page_sizes" struct

Re: [Qemu-devel] [v15 12/15] vfio: add bus in reset flag

On 01/07/2016 12:44 AM, Alex Williamson wrote: On Wed, 2016-01-06 at 10:13 +0800, Chen Fan wrote: On 01/06/2016 03:58 AM, Alex Williamson wrote: On Tue, 2016-01-05 at 09:20 +0800, Cao jin wrote: From: Chen Fan mark the host bus be in reset. avoid multiple devices trigger the host bus reset

[Qemu-devel] [PATCH v2] sdhci: add quirk property for card insert interrupt status on Raspberry Pi

This quirk is a workaround for the following hardware behaviour, on which UEFI (specifically, the bootloader for Windows on Pi2) depends: 1. at boot with an SD card present, the interrupt status/enable registers are initially zero 2. upon enabling it in the interrupt enable register, the card i

[Qemu-devel] [PATCH 3/5] block: allow backup_start to return job references

backup_start picks up a reference to return the job it created to a caller. callers are updated to put down the reference when they are finished. This is particularly interesting for transactions where backup jobs pick up an implicit reference to the job. Previously, we check to see if the job sti

[Qemu-devel] [PATCH 5/5] blockjob: add Job parameter to BlockCompletionFunc

It will no longer be sufficient to rely on the opaque parameter containing a BDS, and there's no way to reliably include a self-reference to the job we're creating, so always pass the Job object forward to any callbacks. Signed-off-by: John Snow --- block/backup.c| 2 +- block/commi

[Qemu-devel] [PATCH 1/5] block: Allow mirror_start to return job references

Pick up an extra reference in mirror_start_job to allow callers of mirror_start and commit_active_start to get a reference to the job they have created. Phase out callers from fishing the job out of bs->job -- use the return value instead. Callers of mirror_start_job and commit_active_start are no

  1   2   3   4   5   >