Re: [Qemu-devel] [PATCH v6 10/11] spapr: CPU hotplug support

2016-01-12 Thread Bharata B Rao
On Tue, Jan 12, 2016 at 04:58:44PM +1100, David Gibson wrote: > On Fri, Jan 08, 2016 at 12:25:18PM +0530, Bharata B Rao wrote: > > > > +static int spapr_core_attach(Object *obj, void *opaque) > > +{ > > +sPAPRMachineClass *smc = SPAPR_MACHINE_GET_CLASS(qdev_get_machine()); > > +

Re: [Qemu-devel] [Avocado-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

2016-01-12 Thread Markus Armbruster
Jason Wang writes: > On 01/13/2016 10:58 AM, Jason Wang wrote: >> >> On 01/12/2016 07:45 PM, Cleber Rosa wrote: >>> - Original Message - From: "Thomas Huth" To: "Jason Wang" , "Jan Kiszka"

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-12 Thread Hao, Xudong
> -Original Message- > From: qemu-devel-bounces+xudong.hao=intel@nongnu.org [mailto:qemu- > devel-bounces+xudong.hao=intel@nongnu.org] On Behalf Of Gerd > Hoffmann > Sent: Tuesday, January 12, 2016 6:25 PM > To: Hao, Xudong > Cc: Lars Kurth

Re: [Qemu-devel] [Avocado-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

2016-01-12 Thread Jason Wang
On 01/13/2016 10:58 AM, Jason Wang wrote: > > On 01/12/2016 07:45 PM, Cleber Rosa wrote: >> - Original Message - >>> From: "Thomas Huth" >>> To: "Jason Wang" , "Jan Kiszka" >>> , qemu-devel@nongnu.org >>> Cc: "Paolo

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

2016-01-12 Thread Prem Mallappa
On 10/25/2015 10:30 PM, Leonid Bloch wrote: Hello qemu-devel, This patch series is an RFC for the new networking device emulation we're developing for QEMU. Thanks for the patch /Prem Tested By: Prem Mallappa

[Qemu-devel] [PATCH v10 0/2] mirror: Improve zero write and discard

2016-01-12 Thread Fam Zheng
v10: Fix and simplify mirror_cow_align. [Max] v9: Fix the one bug Max found: "shrink *= chunk_sectors". v8: Rebase onto master (didn't pick up Max's rev-by due to non-trivial code change). The conflict is around removed lines about "max_iov" and "IOV_MAX" due to commit

Re: [Qemu-devel] [PATCH v6 11/11] spapr: CPU hot unplug support

2016-01-12 Thread David Gibson
On Wed, Jan 13, 2016 at 09:40:54AM +0530, Bharata B Rao wrote: > On Tue, Jan 12, 2016 at 05:06:34PM +1100, David Gibson wrote: > > On Fri, Jan 08, 2016 at 12:25:19PM +0530, Bharata B Rao wrote: > > > Remove the CPU core device by removing the underlying CPU thread devices. > > > Support hot

Re: [Qemu-devel] [Avocado-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

2016-01-12 Thread Paolo Bonzini
On 13/01/2016 04:13, Jason Wang wrote: > Rethinking about this. I'm not quite sure we can remove those > especially "-net user". Google qemu "-net user" gives about 15,900 > results (and the first link is qemu wiki). Maybe we can replace "will be > removed in a future version." with something

Re: [Qemu-devel] [PATCH v6 08/11] target-ppc: Introduce PowerPC specific CPU core device

2016-01-12 Thread Bharata B Rao
On Wed, Jan 13, 2016 at 10:44:07AM +1100, Alexey Kardashevskiy wrote: > On 01/08/2016 05:55 PM, Bharata B Rao wrote: > >CPU core device is a container of CPU thread devices. CPU hotplug is > >performed at the granularity of CPU core device. When hotplugged, CPU core > >creates CPU thread devices.

Re: [Qemu-devel] [PATCH v6 06/11] cpu: Add a sync version of cpu_remove()

2016-01-12 Thread David Gibson
On Tue, Jan 12, 2016 at 12:23:03PM +0530, Bharata B Rao wrote: > On Tue, Jan 12, 2016 at 03:16:15PM +1100, David Gibson wrote: > > On Fri, Jan 08, 2016 at 12:25:14PM +0530, Bharata B Rao wrote: > > > This sync API will be used by the CPU hotplug code to wait for the CPU to > > > completely get

[Qemu-devel] [PATCH v10 1/2] mirror: Rewrite mirror_iteration

2016-01-12 Thread Fam Zheng
The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. The output of iotests 109 is updated because we now report

[Qemu-devel] [PATCH v10 2/2] mirror: Add mirror_wait_for_io

2016-01-12 Thread Fam Zheng
The three lines are duplicated a number of times now, refactor a function. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/mirror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/mirror.c

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-01-12 Thread Jan
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the

Re: [Qemu-devel] [PATCH v6 11/11] spapr: CPU hot unplug support

2016-01-12 Thread Bharata B Rao
On Wed, Jan 13, 2016 at 03:57:00PM +1100, David Gibson wrote: > On Wed, Jan 13, 2016 at 09:40:54AM +0530, Bharata B Rao wrote: > > On Tue, Jan 12, 2016 at 05:06:34PM +1100, David Gibson wrote: > > > On Fri, Jan 08, 2016 at 12:25:19PM +0530, Bharata B Rao wrote: > > > > Remove the CPU core device

Re: [Qemu-devel] [PATCH v2 3/7] device_tree: introduce qemu_fdt_node_path

2016-01-12 Thread David Gibson
On Tue, Jan 12, 2016 at 06:02:00PM +0100, Eric Auger wrote: > Hi David, > On 01/12/2016 05:28 AM, David Gibson wrote: > > On Mon, Jan 11, 2016 at 11:35:50AM +0100, Eric Auger wrote: > >> Hi David, > >> On 01/11/2016 03:38 AM, David Gibson wrote: > >>> On Wed, Jan 06, 2016 at 03:13:21PM +, Eric

Re: [Qemu-devel] [PATCH v1 01/15] crypto: add cryptographic random byte source

2016-01-12 Thread Fam Zheng
On Tue, 01/12 18:56, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > crypto/Makefile.objs| 1 + > crypto/random.c | 50 > + > include/crypto/random.h | 43

Re: [Qemu-devel] [PATCH v6 10/11] spapr: CPU hotplug support

2016-01-12 Thread Bharata B Rao
On Wed, Jan 13, 2016 at 10:58:06AM +1100, Alexey Kardashevskiy wrote: > On 01/08/2016 05:55 PM, Bharata B Rao wrote: > >Support CPU hotplug via device-add command like this: > > > >(qemu) device_add powerpc64-cpu-core,id=core2 > > > >In response to device_add, CPU core device will be created. CPU

Re: [Qemu-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

2016-01-12 Thread Jason Wang
On 01/12/2016 07:45 PM, Cleber Rosa wrote: > > - Original Message - >> From: "Thomas Huth" >> To: "Jason Wang" , "Jan Kiszka" >> , qemu-devel@nongnu.org >> Cc: "Paolo Bonzini" ,

Re: [Qemu-devel] [PATCH v6 11/11] spapr: CPU hot unplug support

2016-01-12 Thread Bharata B Rao
On Tue, Jan 12, 2016 at 05:06:34PM +1100, David Gibson wrote: > On Fri, Jan 08, 2016 at 12:25:19PM +0530, Bharata B Rao wrote: > > Remove the CPU core device by removing the underlying CPU thread devices. > > Support hot removal of CPU for sPAPR guests by sending the hot unplug > > notification to

Re: [Qemu-devel] [PATCH v1 02/15] crypto: add support for PBKDF2 algorithm

2016-01-12 Thread Fam Zheng
On Tue, 01/12 18:56, Daniel P. Berrange wrote: > +#if defined CONFIG_NETTLE > +#include "crypto/pbkdf-nettle.c" > +#elif defined CONFIG_GCRYPT > +#include "crypto/pbkdf-gcrypt.c" > +#else /* ! CONFIG_GCRYPT */ > +#include "crypto/pbkdf-stub.c" > +#endif /* ! CONFIG_GCRYPT */ I think the

Re: [Qemu-devel] [Avocado-devel] [PATCH] net/slirp: Tell the users when they are using deprecated options

2016-01-12 Thread Thomas Huth
On 13.01.2016 04:13, Jason Wang wrote: > > > On 01/13/2016 10:58 AM, Jason Wang wrote: >> >> On 01/12/2016 07:45 PM, Cleber Rosa wrote: >>> - Original Message - From: "Thomas Huth" To: "Jason Wang" , "Jan Kiszka"

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2016-01-12 Thread Vladimir Sementsov-Ogievskiy
On 11.01.2016 20:07, John Snow wrote: On 01/11/2016 07:20 AM, Vladimir Sementsov-Ogievskiy wrote: Are you sure? What about creation\last change dates, file links, user data, etc? For now, formally, current "For now, as no extra data is defined, extra_data_size is reserved and must be zero." is

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

2016-01-12 Thread Markus Armbruster
Wolfgang Bumiller writes: > On Sun, Jan 10, 2016 at 10:56:55AM +0300, Michael Tokarev wrote: >> So, what's the status of this issue now? >> (it is CVE-2015-8619 btw, maybe worth to mention this in the commit message) > > Seems we concluded it's best to keep keyname_len

Re: [Qemu-devel] [RFC PATCH v2 02/10] Jhash: add linux kernel jhashtable in qemu

2016-01-12 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > > > On 01/11/2016 08:50 PM, Dr. David Alan Gilbert wrote: > >* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > >> > >>On 01/08/2016 08:08 PM, Dr. David Alan Gilbert wrote: > >>>* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: >

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-12 Thread Hao, Xudong
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Monday, January 11, 2016 6:46 PM > To: Hao, Xudong > Cc: Stefano Stabellini ; Lars Kurth > ; Lars Kurth

Re: [Qemu-devel] [Bug 1529449] [NEW] serial is required for -device nvme

2016-01-12 Thread Markus Armbruster
Keith Busch writes: > On Mon, Jan 11, 2016 at 05:35:50PM +0100, Markus Armbruster wrote: >> Tom Yan writes: >> > Public bug reported: >> > >> > I am not exactly sure if this is a bug, but I don't see why the option >> > "serial" should be required for

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 06:38 hat Denis V. Lunev geschrieben: > On 01/11/2016 08:31 PM, Kevin Wolf wrote: > >Am 23.12.2015 um 08:46 hat Denis V. Lunev geschrieben: > >>From: Olga Krishtal > >> > >>While opening the image we want to be sure that we are the > >>one who works with

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-12 Thread Michael S. Tsirkin
OK - it's possible that this patch commit 349a3b1cc9023f67f8fa336cb3c4a8f21a4aaaf3 Author: Cao jin Date: Sat Jan 2 16:02:20 2016 +0800 igd-passthrough: fix use of host_pci_config_read is required for older guests. This patch just

Re: [Qemu-devel] [PATCH v4 1/1] xlnx-zynqmp: Add support for high DDR memory regions

2016-01-12 Thread Peter Maydell
On 12 January 2016 at 00:24, Alistair Francis wrote: > On Mon, Jan 11, 2016 at 8:04 AM, Peter Maydell > wrote: >> There are a couple of problems you're running into: >> >> (1) machine->ram_size is a ram_addr_t so might be 32 bit; you >> can

Re: [Qemu-devel] [PATCH 1/8] ipmi: fix SDR length value

2016-01-12 Thread Cédric Le Goater
On 01/08/2016 09:20 PM, Corey Minyard wrote: > On 01/06/2016 02:14 AM, Cédric Le Goater wrote: >> On 01/05/2016 08:59 PM, Eric Blake wrote: >>> On 01/05/2016 10:29 AM, Cédric Le Goater wrote: >>> >>> [meta-comment] Your messages were not marked in-reply-to: the 0/8 cover >>> letter, but came

[Qemu-devel] [RFC PATCH] vhost: fix lost interrupts from slow reacting back-end

2016-01-12 Thread Victor Kaplansky
This RFC PATCH tries to solve the problem of lost interrupts from a slow back-end. Didier could you test it? Thanks, Victor When interrupts are unmasked, it could take some undefined time to the back-end to start routing events to guest_notifier. Till that the events will continue flow to

Re: [Qemu-devel] [PATCH 06/13] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-12 Thread Vladimir Sementsov-Ogievskiy
On 11.01.2016 21:56, John Snow wrote: On 01/11/2016 10:40 AM, Vladimir Sementsov-Ogievskiy wrote: On 04.01.2016 13:27, Fam Zheng wrote: Upon each bit toggle, the corresponding bit in the meta bitmap will be set. Signed-off-by: Fam Zheng --- include/qemu/hbitmap.h | 8

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-12 Thread Paolo Bonzini
On 12/01/2016 01:36, John Snow wrote: > Instead of relying on peeking at bs->job, we want to explicitly get > a reference to the job that was involved in this notifier callback. > > Extend the Notifier to include a job pointer, and include a reference > to the job registering the callback. This

Re: [Qemu-devel] [PATCH] net/vmxnet3: trace support for register access

2016-01-12 Thread Miao Yan
2016-01-12 15:57 GMT+08:00 Dmitry Fleytman : > >> On 12 Jan 2016, at 09:23 AM, Miao Yan wrote: >> >> Hi Dmitry, >> >> 2016-01-12 14:43 GMT+08:00 Dmitry Fleytman : >>> On 12 Jan 2016, at 04:38 AM, Miao Yan

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

2016-01-12 Thread Wolfgang Bumiller
> On January 12, 2016 at 9:45 AM Markus Armbruster wrote: > > Wolfgang Bumiller writes: > > > When processing 'sendkey' command, hmp_sendkey routine null > > terminates the 'keyname_buf' array. This results in an OOB > > Well, it technically doesn't

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-12 Thread Hao, Xudong
With latest qemu 7b8a354d4716, RHEL7.2 (with default kernel) VM still can't boot up with IGD. Thanks, -Xudong > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, January 12, 2016 4:48 PM > To: Hao, Xudong > Cc: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v2 4/5] vhost: move virtio 1.0 check to cross-endian helper

2016-01-12 Thread Greg Kurz
On Tue, 12 Jan 2016 01:23:56 +0100 Laurent Vivier wrote: > On 11/01/2016 17:13, Greg Kurz wrote: > > Indeed vhost doesn't need to ask for vring endian fixing if the device is > > virtio 1.0, since it is already handled by the in-kernel vhost driver. This > > patch simply

Re: [Qemu-devel] x-input-send-event marked as experimental

2016-01-12 Thread Markus Armbruster
Marcelo Tosatti writes: > On Fri, Dec 18, 2015 at 09:01:33PM +0100, Markus Armbruster wrote: >> Marcelo Tosatti writes: >> >> > Gerd, >> > >> > commit df5b2adb7398d71016ee469f71e52075ed95e04e >> > Author: Gerd Hoffmann >> > Date:

Re: [Qemu-devel] [PATCH 7/8] ipmi: introduce an ipmi_bmc_init_sensor() API

2016-01-12 Thread Cédric Le Goater
On 01/08/2016 09:18 PM, Corey Minyard wrote: > The way the SDR and sensors are handled currently in the code I wrote > is far from ideal, it's not scalable. In my mind, the BMC in qemu would > never be a very elaborate one, you would use an external BMC for that. Yes. I agree. It is a

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

2016-01-12 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 17 Dec 2015 18:10:59 +0530 (IST) > P J P wrote: > >>Hello, >> >> An OOB write issue was reported by Mr Ling Liu, CC'd here. It occurs while >> processing the 'sendkey' command, if the command argument was longer

Re: [Qemu-devel] [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-12 Thread Hao, Xudong
Yes, Linux VM update to a 3.18 kernel. The RHEL7.2 default kernel (should be 3.10) VM don't boot up with IGD pass-through, and Windows can't boot up either. Thanks, -Xudong > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, January 11, 2016 6:32 PM >

Re: [Qemu-devel] live migration between different qemu versions

2016-01-12 Thread Dr. David Alan Gilbert
* Alexey (aluka...@alukardd.org) wrote: > Hi David. > > On 2016-01-11 22:51, Dr. David Alan Gilbert wrote: > >* Alexey (aluka...@alukardd.org) wrote: > >>Hello. > > > >Hi, > > > >>I have two servers between which I need have live migration. > >> > >>First server have QEMU emulator version 2.3.0 >

Re: [Qemu-devel] live migration between different qemu versions

2016-01-12 Thread Alexey
Hello, On 2016-01-12 12:19, Dr. David Alan Gilbert wrote: * Alexey (aluka...@alukardd.org) wrote: Hi David. On 2016-01-11 22:51, Dr. David Alan Gilbert wrote: >* Alexey (aluka...@alukardd.org) wrote: >>Hello. > >Hi, > >>I have two servers between which I need have live migration. >> >>First

Re: [Qemu-devel] live migration between different qemu versions

2016-01-12 Thread Dr. David Alan Gilbert
* Alexey (aluka...@alukardd.org) wrote: > Hello, > > On 2016-01-12 12:19, Dr. David Alan Gilbert wrote: > >* Alexey (aluka...@alukardd.org) wrote: > >>Hi David. > >> > >>On 2016-01-11 22:51, Dr. David Alan Gilbert wrote: > >>>* Alexey (aluka...@alukardd.org) wrote: > Hello. > >>> > >>>Hi, >

[Qemu-devel] [Bug 1533141] [NEW] qemu/disas/libvixl/vixl/invalset.h: 2 * sanity check after use ?

2016-01-12 Thread dcb
Public bug reported: 1. [qemu/disas/libvixl/vixl/invalset.h:442]: (style) Array index 'low' is used before limits check. while (!IsValid(elements[low]) && (low < high)) ++low; 2. [qemu/disas/libvixl/vixl/invalset.h:450]: (style) Array index 'middle' is used before limits check. while

Re: [Qemu-devel] Possible reference leak in device_set_realized(...)

2016-01-12 Thread Knut Omang
On Fri, 2016-01-01 at 23:37 +0100, Paolo Bonzini wrote: > > On 31/12/2015 19:13, Ilya Lesokhin wrote: > > I was able to overcome this issue by calling object_unparent on my > > device but I’m not sure that the correct way of fixing it. > > Yes, it's definitely the right way to fix it. Sorry for

[Qemu-devel] [PATCH v1 2/5] drivers/hv: Move VMBus hypercall codes into Hyper-V UAPI header

2016-01-12 Thread Andrey Smetanin
VMBus hypercall codes inside Hyper-V UAPI header will be used by QEMU to implement VMBus host devices support. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini CC:

[Qemu-devel] [PATCH v1 0/5] KVM: Hyper-V VMBus hypercalls

2016-01-12 Thread Andrey Smetanin
The patch implements userspace exit 'KVM_EXIT_HYPERV_HCALL' for Hyper-V VMBus hypercalls(postmsg, signalevent) to handle these hypercalls by QEMU. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo

[Qemu-devel] [PATCH v1 4/5] kvm/x86: Hyper-V VMBus hypercall userspace exit

2016-01-12 Thread Andrey Smetanin
The patch implements KVM_EXIT_HV_HCALL functionality for Hyper-V VMBus hypercalls: HV_X64_HCALL_POST_MESSAGE, HV_X64_HCALL_SIGNAL_EVENT. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini

[Qemu-devel] [Bug 1533141] Re: qemu/disas/libvixl/vixl/invalset.h: 2 * sanity check after use ?

2016-01-12 Thread Peter Maydell
libvixl is not part of QEMU proper, but is an upstream library which we use (as documented in disas/libvixl/README). If you want to suggest coding style changes to it I would recommend reporting them to the upstream project: https://github.com/armvixl/vixl . QEMU just takes the most recent

[Qemu-devel] [PATCH v1 10/22] migration: convert tcp socket protocol to use QIOChannel

2016-01-12 Thread Daniel P. Berrange
Convert the tcp socket migration protocol driver to use QIOChannel and QEMUFileChannel, instead of plain sockets APIs. While this now looks pretty similar to the migration/unix.c file from the previous patch, it was decided not to merge the two, because when TLS is added to the TCP impl later,

[Qemu-devel] [PATCH v1 09/22] migration: convert unix socket protocol to use QIOChannel

2016-01-12 Thread Daniel P. Berrange
Convert the unix socket migration protocol driver to use QIOChannel and QEMUFileChannel, instead of plain sockets APIs. It can be unconditionally built, since the socket impl of QIOChannel will report a suitable error on platforms where UNIX sockets are unavailable. Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v1 11/22] migration: convert fd socket protocol to use QIOChannel

2016-01-12 Thread Daniel P. Berrange
Convert the fd socket migration protocol driver to use QIOChannel and QEMUFileChannel, instead of plain sockets APIs. It can be unconditionally built because the QIOChannel APIs it uses will take care to report suitable error messages if needed. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PATCH v1 07/22] migration: introduce a new QEMUFile impl based on QIOChannel

2016-01-12 Thread Daniel P. Berrange
Introduce a new QEMUFile implementation that is based on the QIOChannel objects. This impl is different from existing impls in that there is no file descriptor that can be made available, as some channels may be based on higher level protocols such as TLS. Although the QIOChannel based

Re: [Qemu-devel] Possible reference leak in device_set_realized(...)

2016-01-12 Thread Paolo Bonzini
On 12/01/2016 11:44, Knut Omang wrote: > On Fri, 2016-01-01 at 23:37 +0100, Paolo Bonzini wrote: >> >> On 31/12/2015 19:13, Ilya Lesokhin wrote: >>> I was able to overcome this issue by calling object_unparent on my >>> device but I’m not sure that the correct way of fixing it. >> >> Yes, it's

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 12:33 hat Fam Zheng geschrieben: > On Tue, 01/12 11:10, Kevin Wolf wrote: > > > > The problem is that libvirt already takes a lock, as Dan mentioned in > > another reply in this thread, so we can't enable locking in qemu by > > default. It would always fail when run under

[Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

2016-01-12 Thread Daniel P. Berrange
The s390 skeys monitor command needs to write out a plain text file. Currently it is using the QEMUFile class for this, but work is ongoing to refactor QEMUFile and eliminate much code related to it. The only feature qemu_fopen() gives over fopen() is support for QEMU FD passing, but this can be

Re: [Qemu-devel] x-input-send-event marked as experimental

2016-01-12 Thread Gerd Hoffmann
Hi, > Where "the latter" refers to "IIRC the question was [whether] we'll > leave it as-is (console=), or [whether] we'll do something like > display=,head= instead." Oh joy, third addressing scheme. No, that isn't a third, that is what the command line actually uses, and '' is the qdev id of

Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation

2016-01-12 Thread Michael S. Tsirkin
On Fri, Jan 08, 2016 at 10:05:44AM +0100, Paolo Bonzini wrote: > > > On 22/12/2015 17:53, Michael S. Tsirkin wrote: > > +{ > > +if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) { > > Off by one. The check should be >=, not >. > > Paolo Corey, can you look into this

[Qemu-devel] [PATCH v1 2/2] target-i386/kvm: Hyper-V VMBus hypercalls blank handlers

2016-01-12 Thread Andrey Smetanin
Add Hyper-V VMBus hypercalls blank handlers which just returns error code - HV_STATUS_INVALID_HYPERCALL_CODE. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Paolo Bonzini CC: Richard Henderson

[Qemu-devel] [PATCH v1 20/22] migration: support TLS encryption with TCP migration backend

2016-01-12 Thread Daniel P. Berrange
This extends the TCP migration backend so that it can make use of QIOChannelTLS to provide transparent TLS encryption. To trigger enablement the URI on the incoming and outgoing sides should have 'tls-creds=ID' appended, eg tcp:$HOST:$PORT,tls-creds=ID where ID is the object identifier of a

[Qemu-devel] [PATCH v1 08/22] migration: convert post-copy to use QIOChannelBuffer

2016-01-12 Thread Daniel P. Berrange
The post-copy code does some I/O to/from an intermediate in-memory buffer rather than direct to the underlying I/O channel. Switch this code to use QIOChannelBuffer instead of QEMUSizedBuffer. Signed-off-by: Daniel P. Berrange --- docs/migration.txt | 4 ++--

[Qemu-devel] [PATCH v1 02/22] migration: remove use of qemu_bufopen from vmstate tests

2016-01-12 Thread Daniel P. Berrange
Some of the test-vmstate.c test cases use a temporary file while others use a memory buffer. To facilitate the future removal of the qemu_bufopen() function, convert all the tests to use a temporary file. Signed-off-by: Daniel P. Berrange --- tests/Makefile | 2 +-

[Qemu-devel] [PATCH v1 06/22] migration: force QEMUFile to blocking mode for outgoing migration

2016-01-12 Thread Daniel P. Berrange
Instead of relying on the default QEMUFile I/O blocking flag state, explicitly turn on blocking I/O for outgoing migration since it takes place in a background thread. Signed-off-by: Daniel P. Berrange --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff

[Qemu-devel] [PATCH v1 05/22] migration: introduce set_blocking function in QEMUFileOps

2016-01-12 Thread Daniel P. Berrange
Remove the assumption that every QEMUFile implementation has a file descriptor available by introducing a new function in QEMUFileOps to change the blocking state of a QEMUFile. If not set, it will fallback to the original code using the get_fd method. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH v1 00/22] Convert migration to QIOChannel & support TLS

2016-01-12 Thread Daniel P. Berrange
BTW, also available at https://github.com/berrange/qemu/tree/io-channel-migration-1 On Tue, Jan 12, 2016 at 11:43:54AM +, Daniel P. Berrange wrote: > This is a formal posting of patches that were previously > previewed at: > > FYI:

[Qemu-devel] [PATCH] config.status: Pass extra parameters

2016-01-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This allows you to do: ./config.status --the-option-you-forgot Signed-off-by: Dr. David Alan Gilbert --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH v1 01/22] s390: use FILE instead of QEMUFile for creating text file

2016-01-12 Thread Cornelia Huck
On Tue, 12 Jan 2016 11:43:55 + "Daniel P. Berrange" wrote: > The s390 skeys monitor command needs to write out a plain text > file. Currently it is using the QEMUFile class for this. There > is no real benefit to this, and the downside is that it needs to > snprintf via

Re: [Qemu-devel] [PATCH v9 1/2] mirror: Rewrite mirror_iteration

2016-01-12 Thread Fam Zheng
On Wed, 01/06 18:53, Max Reitz wrote: > On 05.01.2016 09:46, Fam Zheng wrote: > > The "pnum < nb_sectors" condition in deciding whether to actually copy > > data is unnecessarily strict, and the qiov initialization is > > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > > >

[Qemu-devel] [PATCH v1 13/22] migration: convert RDMA to use QIOChannel interface

2016-01-12 Thread Daniel P. Berrange
This converts the RDMA code to provide a subclass of QIOChannel that uses RDMA for the data transport. The RDMA code would be much better off it it could be split up in a generic RDMA layer, a QIOChannel impl based on RMDA, and then the RMDA migration glue. This is left as a future exercise for

[Qemu-devel] [PATCH 5/7] qapi: rename input buttons

2016-01-12 Thread Gerd Hoffmann
All lowercase, use-dash instead of CamelCase. Signed-off-by: Gerd Hoffmann --- hw/input/hid.c | 4 ++-- hw/input/ps2.c | 4 ++-- hw/input/virtio-input-hid.c | 4 ++-- monitor.c | 2 +- qapi-schema.json| 5 +

[Qemu-devel] [PATCH 4/7] qapi: switch x-input-send-event from console to device+head

2016-01-12 Thread Gerd Hoffmann
Use display device qdev id and head number instead of console index to specify the QemuConsole. This makes things consistent with input devices (for input routing) and vnc server configuration, which both use display and head too. Signed-off-by: Gerd Hoffmann ---

Re: [Qemu-devel] [PATCH 3/7] console: use qemu_console_lookup_by_device_name in vnc_display_open

2016-01-12 Thread Daniel P. Berrange
On Tue, Jan 12, 2016 at 01:29:35PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |:

Re: [Qemu-devel] [PATCH 2/7] console: use qemu_console_lookup_by_device_name in qemu_input_handler_bind

2016-01-12 Thread Daniel P. Berrange
On Tue, Jan 12, 2016 at 01:29:34PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > ui/input.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |:

[Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Wolfgang Bumiller
This pointer should be cleared in vnc_display_close() otherwise a use-after-free can happen when when using the old style 'x509' and 'tls' options rather than a persistent tls-creds -object, by issuing monitor commands to change the vnc server like so: Start with: -vnc unix:test.socket,x509,tls

[Qemu-devel] [PATCH 2/6] fpu: Replace uint64 typedef with uint64_t

2016-01-12 Thread Peter Maydell
Replace the uint64 softfloat-specific typedef with uint64_t. This change was made with find include fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\buint64\b/uint64_t/g' together with manual removal of the typedef definition, and manual undoing of some mis-hits where macro arguments were

[Qemu-devel] [PATCH 4/6] fpu: Replace uint32 typedef with uint32_t

2016-01-12 Thread Peter Maydell
Replace the uint32 softfloat-specific typedef with uint32_t. This change was made with find include hw fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\buint32\b/uint32_t/g' together with manual removal of the typedef definition, manual undoing of various mis-hits, and another couple of fixes

[Qemu-devel] [PATCH 0/6] Get rid of confusing softfloat-specific integer types

2016-01-12 Thread Peter Maydell
This patchset removes the confusing softfloat-specific integer types int8, uint8, int32, uint32, int64 and uint64, replacing them with the standard _t types that they were typedef'd as. These frequently got accidentally used outside the softfloat code as a simple typo for the standard types (as

Re: [Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Daniel P. Berrange
On Tue, Jan 12, 2016 at 01:52:39PM +0100, Wolfgang Bumiller wrote: > This pointer should be cleared in vnc_display_close() > otherwise a use-after-free can happen when when using the > old style 'x509' and 'tls' options rather than a persistent > tls-creds -object, by issuing monitor commands to

[Qemu-devel] [PATCH 5/6] fpu: Replace int8 typedef with int8_t

2016-01-12 Thread Peter Maydell
Replace the int8 softfloat-specific typedef with int8_t. This change was made with find include hw fpu target-* -name '*.[ch]' | xargs sed -i -e 's/\bint8\b/int8_t/g' together with manual removal of the typedef definition, and manual undoing of various mis-hits. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 10/25] target-sparc: Add UA2011 defines to asi.h

2016-01-12 Thread Artyom Tarasenko
I have a weak suggestion we call them UA2005 defines, because all of them are already described in UA2005 and the commit message can make it easier to distinguish what ASIs have to be implemented for UST1+ and what on UST4+ only). Otherwise, Reviewed-By: Artyom Tarasenko

[Qemu-devel] [PATCH] man: virtfs-proxy-helper: Fix 'capbilities' typo

2016-01-12 Thread Christophe Fergeau
Signed-off-by: Christophe Fergeau --- fsdev/virtfs-proxy-helper.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsdev/virtfs-proxy-helper.texi b/fsdev/virtfs-proxy-helper.texi index e60e3b9..1b905a0 100644 --- a/fsdev/virtfs-proxy-helper.texi +++

Re: [Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Wolfgang Bumiller
Ah I forgot to --signoff, sorry > On January 12, 2016 at 1:52 PM Wolfgang Bumiller > wrote: > > > This pointer should be cleared in vnc_display_close() > otherwise a use-after-free can happen when when using the > old style 'x509' and 'tls' options rather than a

Re: [Qemu-devel] usb-storage assertions

2016-01-12 Thread Gerd Hoffmann
On Sa, 2016-01-09 at 20:34 +0300, Andrey Korolyov wrote: > Hello, > > during regular operations within linux guest with USB EHCI frontend I > am seeing process crashes with an assert during regular operations > like dpkg install: > > hw/usb/dev-storage.c:334: usb_msd_handle_reset: Assertion

Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-12 Thread Gerd Hoffmann
On Di, 2016-01-12 at 15:08 +0100, Christophe Fergeau wrote: > Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting > QEMU with SPICE but no SASL, and at the same time VNC with SASL, then > spice_server_init() will get called without a previous call to >

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2016-01-12 Thread Daniel P. Berrange
On Tue, Jan 12, 2016 at 09:17:51PM +0800, Fam Zheng wrote: > On Tue, 01/12 13:28, Kevin Wolf wrote: > > Am 12.01.2016 um 12:33 hat Fam Zheng geschrieben: > > > On Tue, 01/12 11:10, Kevin Wolf wrote: > > > > > > > > The problem is that libvirt already takes a lock, as Dan mentioned in > > > >

Re: [Qemu-devel] [RFC 0/2] tcg-icount: Add and use tcg_set_insn_param to update tcg insn params

2016-01-12 Thread Edgar E. Iglesias
On Tue, Jan 12, 2016 at 01:12:29PM +0100, Lluís Vilanova wrote: > Peter Maydell writes: > > > On 11 January 2016 at 20:16, Lluís Vilanova wrote: > >> Great! I implemented a similar thing long time ago. In my case the > >> machinery is > >> completely hidden under the

Re: [Qemu-devel] [PATCH 0/1] Fixup for DASD geometry detection

2016-01-12 Thread Kevin Wolf
Am 14.12.2015 um 16:41 hat Christian Borntraeger geschrieben: > Kevin, > > here is a fixup for the geometry detection. We tried to be overly > clever and calculate the cyclinder size for devices > 64k cyls. Now > this is wrong for the cyls parameter as the interface only has > 16bit. Large DASD

Re: [Qemu-devel] [PATCH] vnc: clear vs->tlscreds after unparenting it

2016-01-12 Thread Gerd Hoffmann
On Di, 2016-01-12 at 13:52 +0100, Wolfgang Bumiller wrote: > This pointer should be cleared in vnc_display_close() > otherwise a use-after-free can happen when when using the > old style 'x509' and 'tls' options rather than a persistent > tls-creds -object, by issuing monitor commands to change >

Re: [Qemu-devel] [PATCH 2/6] fpu: Replace uint64 typedef with uint64_t

2016-01-12 Thread James Hogan
On Tue, Jan 12, 2016 at 12:55:11PM +, Peter Maydell wrote: > Replace the uint64 softfloat-specific typedef with uint64_t. > This change was made with > > find include fpu target-* -name '*.[ch]' | xargs sed -i -e > 's/\buint64\b/uint64_t/g' > > together with manual removal of the typedef

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2016-01-12 Thread Fam Zheng
On Tue, 01/12 13:28, Kevin Wolf wrote: > Am 12.01.2016 um 12:33 hat Fam Zheng geschrieben: > > On Tue, 01/12 11:10, Kevin Wolf wrote: > > > > > > The problem is that libvirt already takes a lock, as Dan mentioned in > > > another reply in this thread, so we can't enable locking in qemu by > > >

Re: [Qemu-devel] [PATCH v2 3/9] s390x: remove s390-virtio devices

2016-01-12 Thread Pierre Morel
On 01/11/2016 07:45 PM, Cornelia Huck wrote: On Mon, 11 Jan 2016 18:12:27 +0100 Thomas Huth wrote: Happy new year! To you as well :) On 07.01.2016 14:36, Cornelia Huck wrote: From: Pierre Morel The s390-virtio machine has been removed;

Re: [Qemu-devel] [PATCH v2 00/19] Add support for multiple address spaces per CPU and use it for ARM TrustZone

2016-01-12 Thread Edgar E. Iglesias
On Mon, Jan 11, 2016 at 01:04:29PM +, Peter Maydell wrote: > Ping again (though I know Paolo said on IRC he'd put this on > his list to look at). I have a rebased branch at > https://git.linaro.org/people/peter.maydell/qemu-arm.git multi-ases-2 > but the only differences are some minor fixes

[Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-12 Thread Christophe Fergeau
Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting QEMU with SPICE but no SASL, and at the same time VNC with SASL, then spice_server_init() will get called without a previous call to spice_server_set_sasl_appname(), which will cause cyrus-sasl to try to use

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 07:03 hat Denis V. Lunev geschrieben: > There is a long-long story. OVMF VMs can not be snapsotted using > 'virsh snapshot' as they have "pflash" device which is configured as > "raw" image. There was a discussion in the past about that. > > Good description has been provided on

Re: [Qemu-devel] [PATCH 1/1] blk: do not select PFLASH device for internal snapshot

2016-01-12 Thread Kevin Wolf
Am 12.01.2016 um 18:40 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.01.2016 um 17:35 hat Denis V. Lunev geschrieben: > >> On 01/12/2016 06:47 PM, Denis V. Lunev wrote: > >> >On 01/12/2016 06:20 PM, Kevin Wolf wrote: > >> >>Am 12.01.2016 um 15:59 hat Paolo

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

2016-01-12 Thread John Snow
On 01/12/2016 03:46 AM, Paolo Bonzini wrote: > > > On 12/01/2016 01:36, John Snow wrote: >> Instead of relying on peeking at bs->job, we want to explicitly get >> a reference to the job that was involved in this notifier callback. >> >> Extend the Notifier to include a job pointer, and include

Re: [Qemu-devel] [PULL 00/25] VirtFS update

2016-01-12 Thread Peter Maydell
On 12 January 2016 at 06:08, Aneesh Kumar K.V wrote: > The following changes since commit a7e00e2536941a6e570b45b7ab4afec4505ff67e: > > petalogix-ml605: Set the MicroBlaze CPU version to 8.10.a (2016-01-07 > 14:57:26 +0100) > > are available in the git

[Qemu-devel] [PATCH v2 00/11] NVDIMM ACPI: introduce the framework of QEMU emulated

2016-01-12 Thread Xiao Guangrong
This patchset is against commit 8a1be662a69 (virtio: fix error message for number of queues) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/qemu.git nvdimm-acpi-v2 Changelog: These changes are based on Igor's comments: - drop ssdt.rev2 support as the

[Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

2016-01-12 Thread Daniel P. Berrange
Add a generic framework for support different block encryption formats. Upon instantiating a QCryptoBlock object, it will read the encryption header and extract the encryption keys. It is then possible to call methods to encrypt/decrypt data buffers. There is also a mode whereby it will

  1   2   3   >