[Qemu-devel] [PATCH v5 4/8] device_tree: qemu_fdt_getprop converted to use the error API

Current qemu_fdt_getprop exits if the property is not found. It is sometimes needed to read an optional property, in which case we do not wish to exit but simply returns a null value. This patch converts qemu_fdt_getprop to accept an Error **, and existing users are converted to pass &error_fatal.

[Qemu-devel] [PATCH v5 1/8] hw/vfio/platform: amd-xgbe device

This patch introduces the amd-xgbe VFIO platform device. It allows the guest to do passthrough on a device exposing an "amd,xgbe-seattle-v1a" compat string. Signed-off-by: Eric Auger Reviewed-by: Alex Bennée --- RFC -> v1: - add Alex' R-b --- hw/vfio/Makefile.objs | 1 + hw/vfio/amd

[Qemu-devel] [PATCH v5 5/8] device_tree: qemu_fdt_getprop_cell converted to use the error API

This patch aligns the prototype with qemu_fdt_getprop. The caller can choose whether the function self-asserts on error (passing &error_fatal as Error ** argument, corresponding to the legacy behavior), or behaves differently such as simply output a message. In this later case the caller can use t

[Qemu-devel] [PATCH v5 2/8] device_tree: introduce load_device_tree_from_sysfs

This function returns the host device tree blob from sysfs (/proc/device-tree). It uses a recursive function inspired from dtc read_fstree. Signed-off-by: Eric Auger --- v1 -> v2: - do not implement/expose read_fstree and load_device_tree_from_sysfs if CONFIG_LINUX is not defined (lstat is not

[Qemu-devel] [PATCH v5 0/8] AMD XGBE KVM platform passthrough

This series allows to set up AMD XGBE passthrough. This was tested on AMD Seattle. The first upstreamed device supporting KVM platform passthrough was the Calxeda Midway XGMAC. Compared to this latter, the XGBE XGMAC exposes a much more complex device tree node. - First There are 2 device tree no

Re: [Qemu-devel] [PATCH] hw/misc: slavepci_passthru driver

Hi - Original Message - > Hi there, > > I'd like to submit this new pci driver ( hw/misc )for inclusion, > if you think it could be useful to other as well as ourself. > > The driver "worked for our needs" BUT we haven't done extensive > testing and this is our first attempt to submit a

Re: [Qemu-devel] defining VIXL_DEBUG?

On 18/01/2016 12:04, Peter Maydell wrote: >> > >> > where the '1x' encodings of bits 22:23 (marked as reserved in the ARMv8 >> > ARM) would cause an abort as far as I can see. > Isn't this handled by Decoder::DecodeAddSubImmediate(), which checks > bit 23? Yes, that's right. Paolo > In any ca

[Qemu-devel] [PATCH] add MAINTAINERS entry for qemu socket code

Cc: Daniel P. Berrange Cc: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8f44dca..bc753fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1260,6 +1260,14 @@ F: io/ F: include/io/ F: tests/t

[Qemu-devel] [PATCH 2/2] fsdev: use error_report() instead of fprintf(stderr)

Only fix the code that gets built into QEMU. Signed-off-by: Greg Kurz --- fsdev/qemu-fsdev.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c index ccfec139ab2b..55e2f7a0fb58 100644 --- a/fsdev/qemu-fsdev.c +++ b/fsdev/qemu-fsd

[Qemu-devel] [PATCH 1/2] 9pfs: use error_report() instead of fprintf(stderr)

Signed-off-by: Greg Kurz --- hw/9pfs/9p-handle.c |5 +++-- hw/9pfs/9p-local.c | 15 --- hw/9pfs/9p-proxy.c | 12 ++-- hw/9pfs/9p.c|2 +- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c index 58b77

[Qemu-devel] [PATCH 0/2] 9pfs: fsdev: use error_report() instead of fprintf(stderr)

Hi, This series moves all the 9pfs/fsdev code to use error_report(), with the notable exception of virtfs-proxy-helper, which doesn't need it. Markus, Should this patches go through your tree ? Or can they go through my 9p tree if you ack them ? Cheers. -- Greg --- Greg Kurz (2): 9pfs:

Re: [Qemu-devel] [PULL 5/5] hw/arm/virt: Support legacy -nic command line syntax

On 01/18/2016 03:14 PM, Peter Maydell wrote: > On 18 January 2016 at 13:57, Eric Auger wrote: >> Hi Peter, >> On 01/18/2016 02:34 PM, Peter Maydell wrote: >>> Hmm, I guess this is changing things in that we now will have a >>> virtio PCI device appearing if you use the default (-net nic -net user)

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

On Mon, Jan 18, 2016 at 10:59:00AM +0100, Marc Marí wrote: > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 459260b..00339fa 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -1007,8 +1007,13 @@ static void load_linux(PCMachineState *pcms, > fw_cfg_add_i32(fw_cfg, FW_CFG_SETUP_SIZE, setu

Re: [Qemu-devel] CMSG_SPACE() causing compile time error on Mac OS X

On Jan 18, 2016, at 4:58 AM, Daniel P. Berrange wrote: > On Sun, Jan 17, 2016 at 05:23:44PM -0500, Programmingkid wrote: >> I was wondering if you had problems compiling QEMU on Mac OS X recently. On >> my system, the channel-socket.c file causes this error: >> >> io/channel-socket.c: In functi

Re: [Qemu-devel] [PATCH 4/5] block/backup: Add subclassed notifier

Am 12.01.2016 um 19:02 hat John Snow geschrieben: > > > On 01/12/2016 01:01 PM, Paolo Bonzini wrote: > > > > > > On 12/01/2016 18:57, John Snow wrote: > >> > >> > >> On 01/12/2016 03:46 AM, Paolo Bonzini wrote: > >>> > >>> > >>> On 12/01/2016 01:36, John Snow wrote: > Instead of relying on

Re: [Qemu-devel] [PATCH 5/5] blockjob: add Job parameter to BlockCompletionFunc

Am 12.01.2016 um 01:36 hat John Snow geschrieben: > It will no longer be sufficient to rely on the opaque parameter > containing a BDS, and there's no way to reliably include a > self-reference to the job we're creating, so always pass the Job > object forward to any callbacks. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

Wolfgang Bumiller writes: > On Mon, Jan 18, 2016 at 02:02:07PM +0100, Markus Armbruster wrote: >> Wolfgang Bumiller writes: >> >> > On Tue, Jan 12, 2016 at 05:52:38PM +0100, Markus Armbruster wrote: >> >> Wolfgang Bumiller writes: >> >> >> > while (1) { >> > separator = strchr(k

[Qemu-devel] [PATCH v2 4/4] pc: set the OEM fields in the RSDT and the FADT from the SLIC

The Microsoft spec about the SLIC and MSDM ACPI tables at requires the OEM ID and OEM Table ID fields to be consistent between the SLIC and the RSDT/XSDT. That further affects the FADT, because a similar match between the FADT and the RSDT/XSDT is r

Re: [Qemu-devel] [PULL 5/5] hw/arm/virt: Support legacy -nic command line syntax

On 18 January 2016 at 13:57, Eric Auger wrote: > Hi Peter, > On 01/18/2016 02:34 PM, Peter Maydell wrote: >> Hmm, I guess this is changing things in that we now will have a >> virtio PCI device appearing if you use the default (-net nic -net user) >> settings. But I don't see why that would partic

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

On Mo, 2016-01-18 at 11:47 +, Jonathan Scruggs wrote: > Hi Gerd, > > Would there be a way to add repeating keys back in that doesn't cause > issues? Maybe slow down the repeat cycle? Or is this strictly a issue > with how the actual event drivers or the buffers work and would need > changing t

[Qemu-devel] [PATCH v2 3/4] acpi: add function to extract oem_id and oem_table_id from the user's SLIC

The acpi_get_slic_oem() function stores pointers to these fields in the (first) SLIC table that the user passes in with the -acpitable switch. Cc: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) Cc: Igor Mammedov (supporter:ACPI/SMBIOS) Cc: Richard W.M. Jones Cc: Aleksei Kovura Cc: Michael Tokare

[Qemu-devel] [PATCH v2 1/4] acpi: take oem_id in build_header(), optionally

This patch is the continuation of commit 8870ca0e94f2 ("acpi: support specified oem table id for build_header"). It will allow us to control the OEM ID field too in the SDT header. Cc: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) Cc: Igor Mammedov (supporter:ACPI/SMBIOS) Cc: Xiao Guangrong (mai

[Qemu-devel] [PATCH v2 2/4] acpi: expose oem_id and oem_table_id in build_rsdt()

Since build_rsdt() is implemented as common utility code (in "hw/acpi/aml-build.c"), it should expose -- and forward -- the oem_id and oem_table_id parameters between board code and the generic build_header() function. Cc: "Michael S. Tsirkin" (supporter:ACPI/SMBIOS) Cc: Igor Mammedov (supporter

[Qemu-devel] [PATCH v2 0/4] set the OEM fields in the RSDT and the FADT from the SLIC

This is version 2 of . Changes in v2 (also annotated per patch): - introduce acpi_get_slic_oem() [MST], - drop machine property that disables the SLIC-based override [MST]. Cc: "Michael S. Tsirkin" Cc: Aleksei Kovura Cc: Igor Mammedov C

[Qemu-devel] how to setup a watchdog?

apologies I bother devel, but.. I tried to get help on libvirt mailing list but not luck, then qemu, still nothing I hope maybe somebody here? I'm trying Qemu's watchdog. My understanding was that hardware (here qemu's watchdog) would take action, eg. cold reboot the system if there is no ping

Re: [Qemu-devel] [PULL 5/5] hw/arm/virt: Support legacy -nic command line syntax

Hi Peter, On 01/18/2016 02:34 PM, Peter Maydell wrote: > On 18 January 2016 at 13:29, Eric Auger wrote: >> How is it supposed to live with Passthrough'ed NIC? Current way to >> instantiate a VFIO platform NIC looks like: >> >> -device vfio-amd-xgbe,host=e090.xgmac >> where vfio-amd-xgbe is the

Re: [Qemu-devel] usb-storage assertions

Hi, > > ok. Had no trouble with freebsd, will go fetch netbsd images. What > > arch is this? i386? x86_64? > > i386 7.0 for the reference, but I`m sure that this wouldn`t matter in > any way. 7.0 trace: [ ... ] 12417@1453119296.506252:usb_ehci_opreg_write wr mmio 0020 [USBCMD] = 0 12417@1

Re: [Qemu-devel] [PATCH v3] qmp: return err msg when powerdown a vm when it isn't in running state

Qinghua Jin writes: > When send system_powerdown to QMP when the vm isn't in RUN_STATE_RUNNING, > it will be ignored by system. So reply a err msg with the situation. > > Signed-off-by: Qinghua Jin > --- > > This is an update of the patch as per Fam Zheng's suggestion: > http://lists.gnu.org/a

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

On Mon, Jan 18, 2016 at 02:02:07PM +0100, Markus Armbruster wrote: > Wolfgang Bumiller writes: > > > On Tue, Jan 12, 2016 at 05:52:38PM +0100, Markus Armbruster wrote: > >> Wolfgang Bumiller writes: > >> > > while (1) { > > separator = strchr(keys, '-'); > > keyname_len =

Re: [Qemu-devel] [PULL] qemu-sparc update

On 16 January 2016 at 12:41, Mark Cave-Ayland wrote: > Hi Peter, > > This is simply your VMStateDescription patchset for SPARC with appropriate > SoBs added. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 5a57acb66f19ee52723aa05b8afbbc41c3e9ec99: > > Merge remote-trac

Re: [Qemu-devel] [PULL 5/5] hw/arm/virt: Support legacy -nic command line syntax

On 18 January 2016 at 13:29, Eric Auger wrote: > How is it supposed to live with Passthrough'ed NIC? Current way to > instantiate a VFIO platform NIC looks like: > > -device vfio-amd-xgbe,host=e090.xgmac > where vfio-amd-xgbe is the name of the VFIO AMD XGBE platform QEMU > device and e090

Re: [Qemu-devel] [PATCH] qemu-img: Speed up comparing empty/zero images

Am 13.01.2016 um 09:37 hat Fam Zheng geschrieben: > Two empty raw files are always compared by actually reading data even if > there is no data, because BDRV_BLOCK_ZERO is considered "allocated" in > bdrv_is_allocated_above(). That is inefficient. > > Use bdrv_get_block_status_above() for more in

Re: [Qemu-devel] [PULL 5/5] hw/arm/virt: Support legacy -nic command line syntax

Hi, How is it supposed to live with Passthrough'ed NIC? Current way to instantiate a VFIO platform NIC looks like: -device vfio-amd-xgbe,host=e090.xgmac where vfio-amd-xgbe is the name of the VFIO AMD XGBE platform QEMU device and e090.xgmac is the name of the device in /sys/bus/platform/

[Qemu-devel] [PATCH v2] monitor: spelling fix

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster Reviewed-by: Luiz Capitulino --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index c53a453..baa89cb 100644 --- a/monitor.c +++ b/monitor.c @@ -311,7

Re: [Qemu-devel] [PATCH RFC 0/4] ARM SMMUv3 Emulation

On Mon, Jan 18, 2016 at 06:11:35AM +, Prem (Premachandra) Mallappa wrote: > > Edgar has done all of the SMMU work for Xilinx, he knows it the best. > > I'll let him comment on it. > > > > For anyone interested you can see our implementation at: > > https://github.com/Xilinx/qemu/blob/master/hw

Re: [Qemu-devel] [PATCH 1/1] HMP: Add equivalent to x-blockdev-change

* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > x-blockdev-change has no HMP equivalent, so add x_block_change. > > Uh, I can find neither QMP command x-blockdev-change nor > qmp_x_blockdev_change() in master.

Re: [Qemu-devel] [PATCH] misc: spelling

Michael Tokarev writes: > 18.12.2015 13:06, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau > > This patch does not have a required Signed-off-By tag, sorry. Marc-André, please reply with your S-o-B to unblock this patch.

Re: [Qemu-devel] [PATCH 1/1] HMP: Add equivalent to x-blockdev-change

"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > x-blockdev-change has no HMP equivalent, so add x_block_change. Uh, I can find neither QMP command x-blockdev-change nor qmp_x_blockdev_change() in master. > Example useages are: > x_block_change foo -a bah >to ad

Re: [Qemu-devel] [PATCH] hmp: avoid redundant null termination of buffer

Wolfgang Bumiller writes: > On Tue, Jan 12, 2016 at 05:52:38PM +0100, Markus Armbruster wrote: >> Wolfgang Bumiller writes: >> >> >> On January 12, 2016 at 5:00 PM Markus Armbruster >> >> wrote: >> >> Will you prepare a revised patch? >> > >> > Can do that tomorrow, but which option is the pr

Re: [Qemu-devel] [PATCH 5/8] ipmi: add ACPI power and GUID commands

On 01/17/2016 01:08 PM, Marcel Apfelbaum wrote: > On 01/17/2016 02:04 PM, Marcel Apfelbaum wrote: >> On 01/05/2016 07:29 PM, Cédric Le Goater wrote: >>> Signed-off-by: Cédric Le Goater >>> --- >>> hw/ipmi/ipmi_bmc_sim.c | 55 >>> ++ >>> 1 file ch

Re: [Qemu-devel] [PATCH v4 8/9] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

Paolo Bonzini writes: > On 15/01/2016 17:38, Lluís Vilanova wrote: >> Each event with the 'vcpu' property gets a per-vCPU dynamic tracing state. >> >> The set of enabled events with the 'vcpu' and 'tcg' properties is used >> to select a per-vCPU physical TB cache. The number of events with both

Re: [Qemu-devel] [PATCH] Propagate OEM ID info into other tables when using SLIC

On 01/18/16 06:38, Xiao Guangrong wrote: > Hi, > > Is this you wanted? > https://www.mail-archive.com/qemu-devel@nongnu.org/msg345911.html Right, there's now some renewed interest in this issue; I guess probably because of . We have a long-standing RHB

Re: [Qemu-devel] [vfio-users] [PATCH v2 1/3] input: add qemu_input_qcode_to_linux + qemu_input_linux_to_qcode

Hi Gerd, Would there be a way to add repeating keys back in that doesn't cause issues? Maybe slow down the repeat cycle? Or is this strictly a issue with how the actual event drivers or the buffers work and would need changing to that on the host side? In my mind it seams fairly straightforward in

[Qemu-devel] [PATCH 1/1] nvdimm: disable balloon

From: Vladimir Sementsov-Ogievskiy NVDIMM for now is planned to use as a backing store for DAX filesystem in the guest and thus this memory is excluded from guest memory management and LRUs. In this case libvirt running QEMU along with configured ballon almost immediately inflates balloon and ef

Re: [Qemu-devel] [Qemu-arm] [PATCH] misc: zynq-xadc: Fix off-by-one

On 18 January 2016 at 07:22, Peter Crosthwaite wrote: > This bounds check was off-by-one. Fix. > > Reported-by: Paolo Bonzini > Signed-off-by: Peter Crosthwaite > --- > hw/misc/zynq-xadc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/misc/zynq-xadc.c b/hw/misc/zyn

Re: [Qemu-devel] [PATCH v7 0/6] Connect the SPI devices to Xilinx's ZynqMP.

On 15 January 2016 at 22:38, Alistair Francis wrote: > I also need to make some changes to the actual SPI device to > improve the functionality, but for the time being this works. > > V7 > - Use g_strdup_printf() for the bus names > V6 (From Peter C): > - Allow use of QOM paths for referencing q

Re: [Qemu-devel] [PATCH v7 6/6] xlnx-ep108: Connect the SPI Flash

On 15 January 2016 at 22:38, Alistair Francis wrote: > Connect the sst25wf080 SPI flash to the EP108 board. > > Signed-off-by: Alistair Francis > Reviewed-by: Peter Crosthwaite > Signed-off-by: Peter Crosthwaite > --- > hw/arm/xlnx-ep108.c | 15 +++ > 1 file changed, 15 insertions(

Re: [Qemu-devel] [PATCH v7 5/6] xlnx-zynqmp: Connect the SPI devices

This patch in this series never made it to the list for some reason; replying to it here as the easiest way to get it recorded. -- PMM On 15 January 2016 at 22:38, Alistair Francis wrote: > Connect the Xilinx SPI devices to the ZynqMP model. > > Signed-off-by: Alistair Francis > Reviewed-by: Pe

Re: [Qemu-devel] Regarding Intel IGD passthru support for QEMU/KVM

On So, 2016-01-17 at 18:15 -0800, Raghavan Santhanam wrote: > Hi, > > > Based on the Intel IGD passthru support that has been added to > Qemu/Xen code base, > is there any way to use/reuse the same logic currently to have a > successful passthru of an Intel > IGD with Qemu/KVM on a Linux host(Ubu

[Qemu-devel] [PATCH v3] s390: use FILE instead of QEMUFile for creating text file

The s390 skeys monitor command needs to write out a plain text file. Currently it is using the QEMUFile class for this, but work is ongoing to refactor QEMUFile and eliminate much code related to it. The only feature qemu_fopen() gives over fopen() is support for QEMU FD passing, but this can be ac

Re: [Qemu-devel] defining VIXL_DEBUG?

On 18 January 2016 at 10:57, Paolo Bonzini wrote: > One issue I have found after posting is that I'm not sure whether bad > instructions (aka reserved encodings) are handled properly by libvixl. > See for example this: > > case 'A': { // IAddSub. > VIXL_ASSERT(instr->ShiftAddSub() <= 1)

Re: [Qemu-devel] [PATCH v16 09/14] add check reset mechanism when hotplug vfio device

On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Since we support multi-function hotplug. the function 0 indicate I think you wanted , instead of ., also I would suggest "..., function 0 indicates..." the closure of the slot, so we have the chance to do the check. Signed-off-by: Chen

Re: [Qemu-devel] defining VIXL_DEBUG?

On 18/01/2016 11:51, Peter Maydell wrote: >> The actual code in the function is >> > >> > default: VIXL_UNREACHABLE(); return 0; >> > >> > so this is obviously a false positive. Defining VIXL_DEBUG would cause >> > VIXL_UNREACHABLE() to call abort(). Any opinion about whether/where to >> >

Re: [Qemu-devel] [Qemu-block] [PATCH 4/4] block/qapi: Emit tray_open only if there is a tray

On Tue 12 Jan 2016 04:47:54 PM CET, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > block/qapi.c | 2 +- > tests/qemu-iotests/067.out | 4 > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/block/qapi.c b/block/qapi.c > index 58d3975..12a0f25 100644 > --- a

Re: [Qemu-devel] defining VIXL_DEBUG?

On 18 January 2016 at 10:21, Paolo Bonzini wrote: > I've gotten four new Coverity reports in libvixl. All of them are > caused by Coverity assuming that LaneSizeInBitsFromFormat can return 0. Yeah, I fed these back to upstream. (There are also some others do do with integer overflow etc which I

Re: [Qemu-devel] [PATCH v4 8/9] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

On 15/01/2016 17:38, Lluís Vilanova wrote: > Each event with the 'vcpu' property gets a per-vCPU dynamic tracing state. > > The set of enabled events with the 'vcpu' and 'tcg' properties is used > to select a per-vCPU physical TB cache. The number of events with both > properties is used to sel

Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] blockdev: Fix 'change' for slot devices

On Tue 12 Jan 2016 04:47:52 PM CET, Max Reitz wrote: > 'change' and related operations did not work when used on guest devices > featuring removable media but no actual tray, because > blk_dev_is_tray_open() always returned false for them and the > blockdev-{insert,remove}-medium commands required

Re: [Qemu-devel] [PATCH v16 14/14] vfio: add 'aer' property to expose aercap

On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan add 'aer' property to let user able to decide whether expose the aer capability. by default we should disable aer feature, because it needs configuration restrictions. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 2 ++ 1 file changed, 2

Re: [Qemu-devel] [PATCH v16 13/14] vfio-pci: pass the aer error to guest

On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan when the vfio device encounters an uncorrectable error in host, the vfio_pci driver will signal the eventfd registered by this vfio device, the results in the qemu eventfd handler getting Maybe "the results in" -> resulting in invoked.

Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

On Mon, Jan 18, 2016 at 11:11:42AM +0100, Gerd Hoffmann wrote: > On Fr, 2016-01-15 at 16:33 -0700, Eric Blake wrote: > > > This commit unconditionnally calls spice_server_set_sasl_appname() > > > > s/unconditionnally/unconditionally/ > > Fixed up, no need to resend. Thanks! Christophe signatu

Re: [Qemu-devel] [PATCH] qemu-char: avoid leak in qemu_chr_open_pp_fd

On Mon, Jan 18, 2016 at 11:25:51AM +0100, Paolo Bonzini wrote: > drv leaks if qemu_chr_alloc returns an error. > > Signed-off-by: Paolo Bonzini > --- > qemu-char.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http:

Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

On 18/01/2016 10:59, Marc Marí wrote: > This optionrom is based on linuxboot.S. > > Signed-off-by: Marc Marí Reviewed-by: Paolo Bonzini > --- > .gitignore| 4 + > hw/i386/pc.c | 9 +- > hw/nvram/fw_cfg.c | 2 +- > include/hw

Re: [Qemu-devel] [PATCH v4] linux-user: add signalfd/signalfd4 syscalls

Le 18/01/2016 11:30, Paolo Bonzini a écrit : > > > On 02/10/2015 14:48, Laurent Vivier wrote: >> +target_fd_trans = g_realloc(target_fd_trans, >> +target_fd_max * sizeof(TargetFdTrans)); > > This should be TargetFdTrans * (reported by Coverity). Eve

Re: [Qemu-devel] [PATCH v16 08/14] vfio: add check host bus reset is support or not

On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Hi, I think the subject should be rephrased. when init vfio devices done, we should test all the devices supported aer whether conflict with others. For each one, get the hot reset info for the affected device list. For each affected d

Re: [Qemu-devel] [PATCH v4] linux-user: add signalfd/signalfd4 syscalls

On 02/10/2015 14:48, Laurent Vivier wrote: > +target_fd_trans = g_realloc(target_fd_trans, > +target_fd_max * sizeof(TargetFdTrans)); This should be TargetFdTrans * (reported by Coverity). Even better you could use g_renew. It's harmless because size

[Qemu-devel] [PATCH] qemu-char: avoid leak in qemu_chr_open_pp_fd

drv leaks if qemu_chr_alloc returns an error. Signed-off-by: Paolo Bonzini --- qemu-char.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 9e2217b..2633b8a 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1778,18 +1778,19 @@ static Ch

Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] block: Add blk_dev_has_tray()

On Tue 12 Jan 2016 04:47:51 PM CET, Max Reitz wrote: > Pull out the check whether a block device has a tray from > blk_dev_is_tray_open() into an own function so both attributes (whether > there is a tray vs. whether that tray is open) can be queried > independently. > > Cc: qemu-stable > Signed-

Re: [Qemu-devel] [PATCHv3 3/9] pseries: Clean up hash page table allocation error handling

Thomas Huth writes: > On 18.01.2016 05:24, David Gibson wrote: >> The spapr_alloc_htab() and spapr_reset_htab() functions currently handle >> all errors with error_setg(&error_abort, ...). >> >> But really, the callers are really better placed to decide on the error >> handling. So, instead mak

[Qemu-devel] defining VIXL_DEBUG?

I've gotten four new Coverity reports in libvixl. All of them are caused by Coverity assuming that LaneSizeInBitsFromFormat can return 0. The actual code in the function is default: VIXL_UNREACHABLE(); return 0; so this is obviously a false positive. Defining VIXL_DEBUG would cause VIXL_UN

[Qemu-devel] [PATCH] ide: Correct the CHS 'cyls_max' limit to be 65535

In b7eb0c9: hw/block-common: Factor out fall back to legacy -drive cyls=... 'blkconf_geometry()' was introduced, factoring out CHS limit validation code that was repeated in ide, scsi, virtio-blk. The original IDE CHS limit prior b7eb0c9 was 65535,16,255 (as per ATA CHS addressing). However the

Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

On Fr, 2016-01-15 at 16:33 -0700, Eric Blake wrote: > > This commit unconditionnally calls spice_server_set_sasl_appname() > > s/unconditionnally/unconditionally/ Fixed up, no need to resend. cheers, Gerd signature.asc Description: This is a digitally signed message part

Re: [Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

On Mon, 18 Jan 2016 09:50:32 + "Daniel P. Berrange" wrote: > On Fri, Jan 15, 2016 at 04:29:32PM -0700, Eric Blake wrote: > > On 01/12/2016 05:59 AM, Daniel P. Berrange wrote: > > > @@ -124,8 +120,14 @@ void qmp_dump_skeys(const char *filename, Error > > > **errp) > > > return; > >

Re: [Qemu-devel] [PATCHv3 8/9] pseries: Clean up error reporting in ppc_spapr_init()

Thomas Huth writes: > On 18.01.2016 05:24, David Gibson wrote: >> This function includes a number of explicit fprintf()s for errors. >> Change these to use error_report() instead. >> >> Also replace the single exit(EXIT_FAILURE) with an explicit exit(1), since >> the latter is the more usual idi

Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow

On 18 January 2016 at 09:57, Jason Wang wrote: > Thanks for the pointer. > > In section 16.1.5, it said > > "Jumbo frames are not supported." > > So it was in fact not an unimplemented feature? I have a vague feeling from the last time I looked at something like this that what often happens is th

Re: [Qemu-devel] CMSG_SPACE() causing compile time error on Mac OS X

On Sun, Jan 17, 2016 at 05:23:44PM -0500, Programmingkid wrote: > I was wondering if you had problems compiling QEMU on Mac OS X recently. On > my system, the channel-socket.c file causes this error: > > io/channel-socket.c: In function 'qio_channel_socket_writev': > io/channel-socket.c:497:18: e

[Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version

This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 + pc-bios/optionrom/Makefile| 8 +- pc-bios/o

Re: [Qemu-devel] [PATCH] cadence_gem: fix buffer overflow

On 01/18/2016 05:08 PM, Peter Crosthwaite wrote: > On Mon, Jan 18, 2016 at 12:12 AM, Jason Wang wrote: >> >> On 01/18/2016 03:04 PM, Peter Crosthwaite wrote: >>> On Sun, Jan 17, 2016 at 10:50 PM, Jason Wang wrote: On 01/14/2016 05:43 PM, Michael S. Tsirkin wrote: > gem_receive copies a

[Qemu-devel] RFC: running the user interface in a thread ...

Hi folks, I'm starting to investigate if and how we can move the user interface code into its own thread instead of running it in the iothread and therefore avoid blocking the guest in case some UI actions take a little longer. opengl and toolkits tend to be bad at multithreading. So my idea i

Re: [Qemu-devel] bug with io/channel-socket.c - variable-sized object may not be initialized

On Fri, Jan 15, 2016 at 04:56:33PM -0700, Eric Blake wrote: > On 01/13/2016 02:19 PM, Programmingkid wrote: > > This code causes an error to occur during compiling: > > > > char control[CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)] = { 0 }; > > > > It is located at line 496 in io/channel-socket.c.

Re: [Qemu-devel] usb-storage assertions

On Mon, Jan 18, 2016 at 12:38 PM, Gerd Hoffmann wrote: > On Fr, 2016-01-15 at 21:08 +0300, Andrey Korolyov wrote: >> Just checked, Linux usb driver decided to lose a disk during a >> 'stress-test' over unpacking linux source instead of triggering an >> assertion in 2.5 (and to irreparably damage i

[Qemu-devel] [PATCH v2] man: virtfs-proxy-helper: Rework awkward sentence

There was a 'capbilities' typo in this man page. This commit reformulates the sentence the typo was in to make it easier to grasp. This is based on a suggestion from Eric Blake. Signed-off-by: Christophe Fergeau --- Changes since v1: - rather than just fixing the typo, reformulate the sentence it

Re: [Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

On Fri, Jan 15, 2016 at 04:29:32PM -0700, Eric Blake wrote: > On 01/12/2016 05:59 AM, Daniel P. Berrange wrote: > > The s390 skeys monitor command needs to write out a plain text > > file. Currently it is using the QEMUFile class for this, but > > work is ongoing to refactor QEMUFile and eliminate

Re: [Qemu-devel] [PATCH] man: virtfs-proxy-helper: Fix 'capbilities' typo

On Fri, Jan 15, 2016 at 04:31:45PM -0700, Eric Blake wrote: > On 01/12/2016 06:39 AM, Christophe Fergeau wrote: > > Signed-off-by: Christophe Fergeau > > --- > > fsdev/virtfs-proxy-helper.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fsdev/virtfs-proxy-helpe

Re: [Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

Paolo Bonzini writes: > On 15/01/2016 18:03, Andreas Färber wrote: >> Am 05.11.2015 um 13:47 schrieb Markus Armbruster: >>> Paolo Bonzini writes: On 05/11/2015 13:06, Andreas Färber wrote: >> 1. Wouldn't it be cleaner to delete dev-opts *before* sending >>DEVICE_DELETED? Like t

Re: [Qemu-devel] Using directory as initrd

Hi Kasper, The normal approach is to use git send email to send your patch on the list instead of attaching the patch to the email so people can do inline comment. You can use scripts/checkpatch.pl to check the coding style before sending. (eg: you miss the signed off line and the description in

Re: [Qemu-devel] usb-storage assertions

On Fr, 2016-01-15 at 21:08 +0300, Andrey Korolyov wrote: > Just checked, Linux usb driver decided to lose a disk during a > 'stress-test' over unpacking linux source instead of triggering an > assertion in 2.5 (and to irreparably damage its ext4 as well), Ok, so behavior changed here from 2.2 -> 2

Re: [Qemu-devel] [PULL v2 00/15] NBD, chardev, SCSI patches for 2015-01-15

On 15 January 2016 at 18:00, Paolo Bonzini wrote: > The following changes since commit 5a57acb66f19ee52723aa05b8afbbc41c3e9ec99: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20160115' into staging (2016-01-15 > 15:49:43 +) > > are available in the git repositor

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

* Li, Liang Z (liang.z...@intel.com) wrote: > > * Liang Li (liang.z...@intel.com) wrote: > > > Now that VM's RAM pages are initialized to zero, (VM's RAM is allcated > > > with the mmap() and MAP_ANONYMOUS option, or mmap() without > > MAP_SHARED > > > if hugetlbfs is used.) so there is no need to

Re: [Qemu-devel] [PATCHv3 8/9] pseries: Clean up error reporting in ppc_spapr_init()

On 18.01.2016 05:24, David Gibson wrote: > This function includes a number of explicit fprintf()s for errors. > Change these to use error_report() instead. > > Also replace the single exit(EXIT_FAILURE) with an explicit exit(1), since > the latter is the more usual idiom in qemu by a large margin.

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

On 01/18/2016 03:05 PM, Zhang Chen wrote: > > > On 01/06/2016 01:16 PM, Jason Wang wrote: >> >> On 01/04/2016 07:17 PM, Zhang Chen wrote: >>> >>> On 01/04/2016 05:46 PM, Jason Wang wrote: On 01/04/2016 04:16 PM, Zhang Chen wrote: > On 01/04/2016 01:37 PM, Jason Wang wrote: >> On 12/3

Re: [Qemu-devel] [PATCHv3 7/9] pseries: Clean up error handling in xics_system_init()

On 18.01.2016 05:24, David Gibson wrote: > Use the error handling infrastructure to pass an error out from > try_create_xics() instead of assuming &error_abort - the caller is in a > better position to decide on error handling policy. > > Also change the error handling from an &error_abort to &err

Re: [Qemu-devel] [PATCHv3 6/9] pseries: Clean up error handling in spapr_rtas_register()

On 18.01.2016 05:24, David Gibson wrote: > The errors detected in this function necessarily indicate bugs in the rest > of the qemu code, rather than an external or configuration problem. > > So, a simple assert() is more appropriate than any more complex error > reporting. > > Signed-off-by: Dav

[Qemu-devel] [PATCH v6 8/8] block: allow to skip block driver in selection of one for VM state saving

Some block drives like PFLASH ones in OVFM setup are not suitable for VM state saving. Allow option to ban them in this selection. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Markus Armbruster CC: Eric Blake CC: Juan Quintela CC: Amit Shah --- Changes from v5: - added to vmstate option

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

On 2016/1/16 2:57, Dr. David Alan Gilbert wrote: * Liang Li (liang.z...@intel.com) wrote: Now that VM's RAM pages are initialized to zero, (VM's RAM is allcated with the mmap() and MAP_ANONYMOUS option, or mmap() without MAP_SHARED if hugetlbfs is used.) so there is no need to send the zero page

Re: [Qemu-devel] [PATCHv3 5/9] pseries: Cleanup error handling in spapr_vga_init()

On 18.01.2016 05:24, David Gibson wrote: > Use error_setg() to return an error rather than an explicit exit(). > Previously it was an exit(0) instead of a non-zero exit code, which was > simply a bug. Also improve the error message. > > While we're at it change the type of spapr_vga_init() to boo

Re: [Qemu-devel] [PATCHv3 4/9] pseries: Clean up error handling in spapr_validate_node_memory()

On 18.01.2016 05:24, David Gibson wrote: > Use error_setg() and return an error, rather than using an explicit exit(). > > Also improve messages, and be more explicit about which constraint failed. > > Signed-off-by: David Gibson > Reviewed-by: Bharata B Rao > --- > hw/ppc/spapr.c | 37 +++

Re: [Qemu-devel] [PATCH v16 07/14] vfio: add aer support for vfio device

On 01/12/2016 04:43 AM, Cao jin wrote: From: Chen Fan Calling pcie_aer_init to initilize aer related registers for vfio device, then reload physical related registers to expose device capability. Signed-off-by: Chen Fan --- hw/vfio/pci.c | 81

Re: [Qemu-devel] [PATCH] cadence_gem: fix buffer overflow

On Mon, Jan 18, 2016 at 12:12 AM, Jason Wang wrote: > > > On 01/18/2016 03:04 PM, Peter Crosthwaite wrote: >> On Sun, Jan 17, 2016 at 10:50 PM, Jason Wang wrote: >>> >>> On 01/14/2016 05:43 PM, Michael S. Tsirkin wrote: gem_receive copies a packet received from network into an rxbuf[2048] >>

Re: [Qemu-devel] [PATCH] migration: not send zero page header in ram bulk stage

Hi, On 2016/1/15 18:24, Li, Liang Z wrote: It seems that this patch is incorrect, if the no-zero pages are zeroed again during !ram_bulk_stage, we didn't send the new zeroed page, there will be an error. If not in ram_bulk_stage, still send the header, could you explain why it's wrong? Lian

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

On 01/18/2016 12:47 PM, Alex Williamson wrote: > Hi Jike, > > On Mon, 2016-01-18 at 10:39 +0800, Jike Song wrote: >> Hi Alex, let's continue with a new thread :) >> >> Basically we agree with you: exposing vGPU via VFIO can make >> QEMU share as much code as possible with pcidev(PF or VF) assignme

<    1   2   3   4   >