Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

2016-01-19 Thread Greg Kurz
On Wed, 20 Jan 2016 13:13:57 +1100 David Gibson wrote: > On Tue, Jan 19, 2016 at 10:59:20AM +0100, Greg Kurz wrote: > > On Mon, 18 Jan 2016 13:25:19 +1100 > > David Gibson wrote: > > > > > On Fri, Jan 15, 2016 at 04:00:38PM +0100, Greg Kurz wrote: > > > > Altivec registers are 128-bit wide.

Re: [Qemu-devel] [Qemu-block] [PATCH v4 00/12] fdc: fix 2.88mb floppy diskette support

2016-01-19 Thread Denis V. Lunev
On 01/20/2016 09:51 AM, John Snow wrote: requires: 1448895398-13465-1-git-send-email-ehabk...@redhat.com pc: Add pc-*-2.6 machine classes Yes, it's been broken for ten years. No, it's not a CVE. The problem is that QEMU doesn't have a configuration option for the type of floppy drive

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-19 Thread Wen Congyang
On 01/20/2016 02:54 PM, Jason Wang wrote: > > > On 01/20/2016 11:29 AM, Zhang Chen wrote: >> >>> Sure. >>> >>> Two main comments/suggestions: >>> >>> - TCP analysis is missed in current version, maybe you point a git tree >>> (or another version of RFC) to me for a better understanding of the >>>

Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options

2016-01-19 Thread Fam Zheng
On Wed, 01/20 08:25, Markus Armbruster wrote: > Fam Zheng writes: > > > v5: Add valid value testing in iotests. [Berto] > > Add details in commit message. [Markus] > > Use "%lld" in format string. [Markus] > > Fix ")" -> "]" in error message. [Kevin] > > > > Now the negative values ar

Re: [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options

2016-01-19 Thread Markus Armbruster
Fam Zheng writes: > v5: Add valid value testing in iotests. [Berto] > Add details in commit message. [Markus] > Use "%lld" in format string. [Markus] > Fix ")" -> "]" in error message. [Kevin] > > Now the negative values are silently converted to a huge positive number > because we ar

Re: [Qemu-devel] how to setup a watchdog?

2016-01-19 Thread Philipp Hahn
Hi, Am 18.01.2016 um 12:43 schrieb lejeczek: > I'm trying Qemu's watchdog. > My understanding was that hardware (here qemu's watchdog) would take > action, eg. cold reboot the system if there is no ping from the OS > watchdog, so I > thought stopping watchdog service in VM should be a quick test,

Re: [Qemu-devel] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register()

2016-01-19 Thread Markus Armbruster
Eric Blake writes: > On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote: > >>> You could drop the redundant () while touching this, as in: >> >> >> Seriously? Why? I personally find it really annoying (but I stay silent) >> when people omit braces in cases like this. >> >> >>> assert(token >=

Re: [Qemu-devel] [PATCH COLO-Frame v13 34/39] net/filter-buffer: Add default filter-buffer for each netdev

2016-01-19 Thread Hailiang Zhang
On 2016/1/20 10:39, Jason Wang wrote: On 01/19/2016 04:39 PM, Hailiang Zhang wrote: Hi Jason, Thanks for your review. On 2016/1/19 11:19, Jason Wang wrote: On 12/29/2015 03:09 PM, zhanghailiang wrote: We add each netdev (except vhost-net) a default filter-buffer, which will be used for C

Re: [Qemu-devel] RFC: running the user interface in a thread ...

2016-01-19 Thread Gerd Hoffmann
Hi, > As a general note though, mixing GTK and threads is really not something > I'd encourage in general. Sure, thats why I think qemu should have *one* ui thread, and that one will be the only one calling into gtk (and also the only one running opengl in case that is enabled). cheers, Gerd

[Qemu-devel] [PATCH 1/2] block: fix assert in qcow2_get_specific_info

2016-01-19 Thread Denis V. Lunev
There is a possibility to hit assert qcow2_get_specific_info that s->qcow_version is undefined. This happens when VM in starting from suspended state, i.e. it processes incoming migration, and in the same time 'info block' is called. The problem is that in the qcow2_invalidate_cache closes and the

[Qemu-devel] [PATCH 0/2] fixes for bdrv_invalidate_cache

2016-01-19 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Paolo Bonzini

[Qemu-devel] [PATCH 2/2] nbd: add missed aio_context_acquire in nbd_export_new

2016-01-19 Thread Denis V. Lunev
blk_invalidate_cache() can call qcow2_invalidate_cache which performs IO inside. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Paolo Bonzini --- nbd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/nbd.c b/nbd.c index b3d9654..b271db5 100644 --- a/nbd.c +++ b/nbd.c @@ -1080,7 +1080,9

[Qemu-devel] [PULL 3/6] sockets: remove use of QemuOpts from socket_listen

2016-01-19 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The socket_listen method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_listen_opts/unix_listen_opts helper methods. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be eliminate

Re: [Qemu-devel] qxl : no mouse cursor with sdl2/gtk UI

2016-01-19 Thread Gerd Hoffmann
On Di, 2016-01-19 at 15:59 +0100, nicolas prochazka wrote: > hello, > > however it "s working perfectly under windows81 But you no tablet configured and therefore have to grab/ungrab the mouse when switching between host and guest I guess? cheers, Gerd

[Qemu-devel] [PULL 2/6] sockets: remove use of QemuOpts from header file

2016-01-19 Thread Gerd Hoffmann
From: "Daniel P. Berrange" There are no callers of the sockets methods which accept QemuOpts any more. Make all the QemuOpts related functions static to avoid new callers being added, in preparation for removal of all QemuOpts usage, in favour of QAPI SocketAddress. Reviewed-by: Eric Blake Sign

[Qemu-devel] [PULL 0/6] Convert qemu-socket to use QAPI exclusively, update MAINTAINERS

2016-01-19 Thread Gerd Hoffmann
Hi, Update for the qemu socket code, switching it over to QAPI structs. Also adds MAINTAINERS entry for qemu socket code (Dan, Paolo, /me). please pull, Gerd The following changes since commit 4aaddc2976bff1918edcd53900b647dde473dd4d: Merge remote-tracking branch 'remotes/mcayland/tags/qe

[Qemu-devel] [PULL 5/6] sockets: remove use of QemuOpts from socket_dgram

2016-01-19 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The socket_dgram method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_dgram_opts helper method. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be eliminated. This removes the

[Qemu-devel] [PATCH v4 12/12] fdc: change auto fallback drive for ISA FDC to 288

2016-01-19 Thread John Snow
The 2.88 drive is more suitable as a default because it can still read 1.44 images correctly, but the reverse is not true. Since there exist virtio-win drivers that are shipped on 2.88 floppy images, this patch will allow VMs booted without a floppy disk inserted to later insert a 2.88MB floppy an

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-19 Thread Jason Wang
On 01/20/2016 11:29 AM, Zhang Chen wrote: > >> Sure. >> >> Two main comments/suggestions: >> >> - TCP analysis is missed in current version, maybe you point a git tree >> (or another version of RFC) to me for a better understanding of the >> design. (Just a skeleton for TCP should be sufficient t

[Qemu-devel] [PATCH v4 10/12] fdc: rework pick_geometry

2016-01-19 Thread John Snow
This one is the crazy one. fd_revalidate currently uses pick_geometry to tell if the diskette geometry has changed upon an eject/insert event, but it won't allow us to insert a 1.44MB diskette into a 2.88MB drive. This is inflexible. The new algorithm applies a new heuristic to guessing disk geom

[Qemu-devel] [PATCH v4 03/12] fdc: add drive type qapi enum

2016-01-19 Thread John Snow
Change the floppy drive type to a QAPI enum type, to allow us to specify the floppy drive type from the CLI in a forthcoming patch. Signed-off-by: John Snow --- hw/block/fdc.c | 80 +- hw/i386/pc.c | 17 ++- include/hw/blo

[Qemu-devel] [PULL 6/6] vnc: distiguish between ipv4/ipv6 omitted vs set to off

2016-01-19 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The VNC code for interpreting QemuOpts does not currently distinguish between ipv4/ipv6 being omitted, and being set to 'off', because historically the 'ipv4' and 'ipv6' options were just flags which did not accept a value. The upshot is that if someone runs $QEMU -

[Qemu-devel] [PULL 1/6] add MAINTAINERS entry for qemu socket code

2016-01-19 Thread Gerd Hoffmann
Cc: Daniel P. Berrange Cc: Paolo Bonzini Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange Message-id: 1453129403-11357-1-git-send-email-kra...@redhat.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8f44dca..bc753fc 100

[Qemu-devel] [PATCH v4 05/12] fdc: Throw an assertion on misconfigured fd_formats table

2016-01-19 Thread John Snow
pick_geometry is a convoluted function that makes it difficult to tell at a glance what QEMU's current behavior for choosing a floppy drive type is when it can't quite identify the diskette. If drive type is NONE, it considers all drive types in the candidate geometry table to be a match, and save

[Qemu-devel] [PATCH v4 09/12] fdc: add physical disk sizes

2016-01-19 Thread John Snow
2.88MB capable drives can accept 1.44MB floppies, for instance. To rework the pick_geometry function, we need to know if our current drive can even accept the type of disks we're considering. NB: This allows us to distinguish between all of the "total sectors" collisions between 1.20MB and 1.44MB

[Qemu-devel] [PULL 4/6] sockets: remove use of QemuOpts from socket_connect

2016-01-19 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The socket_connect method accepts a QAPI SocketAddress object which it then turns into QemuOpts before calling the inet_connect_opts/unix_connect_opts helper methods. By converting the latter to use QAPI SocketAddress directly, the QemuOpts conversion step can be elimin

[Qemu-devel] [PATCH v4 08/12] fdc: add drive type option

2016-01-19 Thread John Snow
This patch adds a new explicit Floppy Drive Type option. The existing behavior in QEMU is to automatically guess a drive type based on the media inserted, or if a diskette is not present, arbitrarily assign one. This behavior can be described as "auto." This patch adds the option to pick an explic

[Qemu-devel] [PATCH v4 11/12] qtest/fdc: Support for 2.88MB drives

2016-01-19 Thread John Snow
The old test assumes a 1.44MB drive. Assert that the QEMU default drive is now either 1.44 or 2.88. Signed-off-by: John Snow --- tests/fdc-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index b5a4696..526d459 100644 --- a/tests/fdc-

[Qemu-devel] [PATCH v4 01/12] fdc: move pick_geometry

2016-01-19 Thread John Snow
Code motion: I want to refactor this function to work with FDrive directly, so shuffle it below that definition. Reviewed-by: Eric Blake Signed-off-by: John Snow --- hw/block/fdc.c | 90 +- 1 file changed, 45 insertions(+), 45 deletions(-)

[Qemu-devel] [PATCH v4 00/12] fdc: fix 2.88mb floppy diskette support

2016-01-19 Thread John Snow
requires: 1448895398-13465-1-git-send-email-ehabk...@redhat.com pc: Add pc-*-2.6 machine classes Yes, it's been broken for ten years. No, it's not a CVE. The problem is that QEMU doesn't have a configuration option for the type of floppy drive you want. It determines that based on the t

[Qemu-devel] [PATCH v4 06/12] fdc: add pick_drive

2016-01-19 Thread John Snow
Split apart pick_geometry by creating a pick_drive routine that will only ever called during device bring-up instead of relying on pick_geometry to be used in both cases. With this change, the drive field is changed to be 'write once'. It is not altered after the initialization routines exit. med

[Qemu-devel] [PATCH v4 07/12] fdc: Add fallback option

2016-01-19 Thread John Snow
Currently, QEMU chooses a drive type automatically based on the inserted media. If there is no disk inserted, it chooses a 1.44MB drive type. Change this behavior to be configurable, but leave it defaulted to 1.44. This is not earnestly intended to be used by a user or a management library, but r

[Qemu-devel] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments

2016-01-19 Thread John Snow
Modify this function to operate directly on FDrive objects instead of unpacking and passing all of those parameters manually. Reduces the complexity in the caller and reduces the number of args to just one. Signed-off-by: John Snow --- hw/block/fdc.c | 50

[Qemu-devel] [PATCH v4 04/12] fdc: add disk field

2016-01-19 Thread John Snow
Currently, 'drive' is used both to represent the current diskette type as well as the current drive type. This patch adds a 'disk' field that is updated explicitly to match the type of the disk. As of this patch, disk and drive are always the same, but forthcoming patches to change the behavior o

[Qemu-devel] [PATCH v2 13/13] tests: Add test code for hbitmap serialization

2016-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/test-hbitmap.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index a341803..9b89751 100644 --- a/tests/test-hbitmap.c +++ b/tests/test-hbitmap.c @@ -14,6 +14

[Qemu-devel] [PATCH v2 11/13] hbitmap: serialization

2016-01-19 Thread Fam Zheng
From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions are appropriate for dirty bit

[Qemu-devel] [PATCH v2 09/13] block: Add two dirty bitmap getters

2016-01-19 Thread Fam Zheng
For dirty bitmap users to get the size and the name of a BdrvDirtyBitmap. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/dirty-bitmap.c | 10 ++ include/block/dirty-bitmap.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bi

[Qemu-devel] [PATCH v2 10/13] block: Assert that bdrv_release_dirty_bitmap succeeded

2016-01-19 Thread Fam Zheng
This makes sure we don't leak a dirty bitmap in any case. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/dirty-bitmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index de143f1..ec13d38 100644 --- a/block/dirty-bitmap.c +++ b/block

[Qemu-devel] [PATCH v2 12/13] block: BdrvDirtyBitmap serialization interface

2016-01-19 Thread Fam Zheng
From: Vladimir Sementsov-Ogievskiy Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Signed-off-by: Vladimir Sementsov-Ogievskiy [Add the "finish" parameters. - Fam] Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 37 +++

[Qemu-devel] [PATCH v2 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-19 Thread Fam Zheng
HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitmapIter must be dyn

[Qemu-devel] [PATCH v2 07/13] tests: Add test code for meta bitmap

2016-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: John Snow --- tests/test-hbitmap.c | 116 +++ 1 file changed, 116 insertions(+) diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c index abcea0c..a341803 100644 --- a/tests/test-hbitmap.c +++ b/tests/tes

[Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-19 Thread Fam Zheng
The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng --- block/dirty-bitmap.c | 51 include/block/dirty-bitmap.h | 9 2 files changed, 60 insertions(+) diff --git a/block/d

[Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap

2016-01-19 Thread Fam Zheng
Following patches to refactor and move block dirty bitmap code could use this. Signed-off-by: Fam Zheng --- include/block/block.h | 3 +-- include/qemu/typedefs.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index c96923d..

[Qemu-devel] [PATCH v2 06/13] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-19 Thread Fam Zheng
Upon each bit toggle, the corresponding bit in the meta bitmap will be set. Signed-off-by: Fam Zheng --- include/qemu/hbitmap.h | 17 + util/hbitmap.c | 66 ++ 2 files changed, 68 insertions(+), 15 deletions(-) diff --git a/inc

[Qemu-devel] [PATCH v2 03/13] block: Move block dirty bitmap code to separate files

2016-01-19 Thread Fam Zheng
The only change is making bdrv_dirty_bitmap_truncate public. It is used in block.c. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block.c | 339 --- block/Makefile.objs | 2 +- block/dirty-bitmap.c | 366 +

[Qemu-devel] [PATCH v2 04/13] block: Remove unused typedef of BlockDriverDirtyHandler

2016-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: John Snow --- include/block/block.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index 339906b..054bf83 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -322,8 +322,6 @@ BlockDriverState

[Qemu-devel] [PATCH v2 00/13] Dirty bitmap changes for migration/persistence work

2016-01-19 Thread Fam Zheng
v2: Various changes addressing John's and Vladimir's comments: [02/13] typedefs: Add BdrvDirtyBitmap Skip HBitmapIter because we'll hide it soon. [John] [03/13] block: Move block dirty bitmap code to separate files [04/13] block: Remove unused typedef of BlockD

[Qemu-devel] [PATCH v2 01/13] backup: Use Bitmap to replace "s->bitmap"

2016-01-19 Thread Fam Zheng
"s->bitmap" tracks done sectors, we only check bit states without using any iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and more memory efficient. Meanwhile, rename it to done_bitmap, to reflect the intention. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- bloc

Re: [Qemu-devel] [PATCH 08/13] block: Support meta dirty bitmap

2016-01-19 Thread Fam Zheng
On Thu, 01/07 14:30, John Snow wrote: > > +void bdrv_release_meta_dirty_bitmap(BdrvDirtyBitmap *bitmap) > > +{ > > +assert(bitmap->meta); > > +hbitmap_free(bitmap->meta); > > This leaves a dangling pointer inside the Hbitmap, no? Yes, will fix. > > > +bitmap->meta = NULL; > > +} > >

Re: [Qemu-devel] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register()

2016-01-19 Thread Alexey Kardashevskiy
On 01/20/2016 03:53 PM, Eric Blake wrote: On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote: You could drop the redundant () while touching this, as in: Seriously? Why? I personally find it really annoying (but I stay silent) when people omit braces in cases like this. assert(token >= RT

Re: [Qemu-devel] [PATCH] spapr: Don't create ibm, dynamic-reconfiguration-memory w/o DR LMBs

2016-01-19 Thread Bharata B Rao
On Tue, Jan 19, 2016 at 04:00:25PM +1100, David Gibson wrote: > On Tue, Jan 19, 2016 at 10:09:21AM +0530, Bharata B Rao wrote: > > If guest doesn't have any dynamically reconfigurable (DR) logical memory > > blocks (LMB), then we shouldn't create ibm,dynamic-reconfiguration-memory > > device tree n

Re: [Qemu-devel] [PATCH 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-19 Thread Fam Zheng
On Tue, 01/05 18:01, John Snow wrote: > Should we skip adding the typedef for HBitmapIter if we're just going to > use this instead? Yes, we can clean this up. > > On 01/04/2016 05:27 AM, Fam Zheng wrote: > > HBitmap is an implementation detail of block dirty bitmap that should be > > hidden >

Re: [Qemu-devel] RFC: running the user interface in a thread ...

2016-01-19 Thread Eric Blake
On 01/19/2016 08:28 AM, Daniel P. Berrange wrote: > On Tue, Jan 19, 2016 at 02:01:47PM +0100, Gerd Hoffmann wrote: >> Hi, >> >>> That, and so the UI can use localization without corrupting other >>> threads that MUST use the C locale (QMP parsing/output of floating point >>> is particularly impor

Re: [Qemu-devel] [PATCH 1/1] nvdimm: disable balloon

2016-01-19 Thread Eric Blake
On 01/18/2016 04:42 AM, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy > > NVDIMM for now is planned to use as a backing store for DAX filesystem > in the guest and thus this memory is excluded from guest memory management > and LRUs. > > In this case libvirt running QEMU along with

Re: [Qemu-devel] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register()

2016-01-19 Thread Eric Blake
On 01/19/2016 05:21 PM, Alexey Kardashevskiy wrote: >> You could drop the redundant () while touching this, as in: > > > Seriously? Why? I personally find it really annoying (but I stay silent) > when people omit braces in cases like this. > > >> assert(token >= RTAS_TOKEN_BASE && token < RTAS

Re: [Qemu-devel] [PATCH RFC 0/4] ARM SMMUv3 Emulation

2016-01-19 Thread Prem (Premachandra) Mallappa
Hi Edgar, > Yes, we did SMMUv2 but I think there is opportunity to reuse quite a bit of > code. I agree > > I don't mind basing the implementation from the broadcom code but > there are a few things that could be taken from our our code or at > least re- implemented. We can collaborate in r

Re: [Qemu-devel] [PATCH] vmdk: Create streamOptimized as version 3

2016-01-19 Thread Fam Zheng
On Thu, 09/17 10:55, Kevin Wolf wrote: > Am 17.09.2015 um 07:04 hat Fam Zheng geschrieben: > > VMware products accept only version 3 for streamOptimized, let's bump > > the version. > > > > Reported-by: Radoslav Gerganov > > Signed-off-by: Fam Zheng > > Radoslav, can I have your Reviewed-by and

[Qemu-devel] [PATCH v5 2/2] iotests: Test that throttle values ranges

2016-01-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/051| 18 ++ tests/qemu-iotests/051.out| 39 +++ tests/qemu-iotests/051.pc.out | 39 +++ 3 files changed, 96 insertions(+) diff --git a/tests/qemu-io

[Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options

2016-01-19 Thread Fam Zheng
v5: Add valid value testing in iotests. [Berto] Add details in commit message. [Markus] Use "%lld" in format string. [Markus] Fix ")" -> "]" in error message. [Kevin] Now the negative values are silently converted to a huge positive number because we are doing implicit casting from uin

[Qemu-devel] [PATCH v5 1/2] blockdev: Error out on negative throttling option values

2016-01-19 Thread Fam Zheng
extract_common_blockdev_options() uses qemu_opt_get_number() to parse the bps/iops numbers to uint64_t, then converts to double and stores in ThrottleConfig. The actual parsing is done by strtoull() in parse_option_number(). Negative numbers are wrapped to large positive ones, and stored. We use

Re: [Qemu-devel] [RFC PATCH v2 00/10] Add colo-proxy based on netfilter

2016-01-19 Thread Zhang Chen
Sure. Two main comments/suggestions: - TCP analysis is missed in current version, maybe you point a git tree (or another version of RFC) to me for a better understanding of the design. (Just a skeleton for TCP should be sufficient to discuss). - I prefer to make the code as reusable as possibl

Re: [Qemu-devel] [PATCH v4 0/2] block: Reject negative values for throttling options

2016-01-19 Thread Fam Zheng
On Tue, 01/19 10:50, Markus Armbruster wrote: > Fam Zheng writes: > > > v4: Add Max's rev-by in both patches, while fixing the "maxs" typo. > > > > v3: Address comments: > > - Add test for large value; [Berto] > > - Fix typos "negative" & "caught"; [Eric, Berto] > > - Use "LL" suffix

Re: [Qemu-devel] [PATCH COLO-Frame v13 34/39] net/filter-buffer: Add default filter-buffer for each netdev

2016-01-19 Thread Jason Wang
On 01/19/2016 04:39 PM, Hailiang Zhang wrote: > Hi Jason, > > Thanks for your review. > > On 2016/1/19 11:19, Jason Wang wrote: >> >> >> On 12/29/2015 03:09 PM, zhanghailiang wrote: >>> We add each netdev (except vhost-net) a default filter-buffer, >>> which will be used for COLO or Micro-checkpo

Re: [Qemu-devel] [PATCH] .travis.yml: migrate to container builds

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 07:22:07AM +, Alex Bennée wrote: > > David Gibson writes: > > > On Fri, Jan 15, 2016 at 10:45:09AM +, Alex Bennée wrote: > >> This moves the Travis tests from their old legacy VM > >> infrastructure (which only seems to run 5-6 jobs at once) to their new > >> cont

Re: [Qemu-devel] [PATCHv4 0/8] Cleanups to error reporting on ppc and spapr

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 01:23:13PM +0100, Markus Armbruster wrote: > David Gibson writes: > > > Another spin of my patches to clean up a bunch of error reporting in > > the pseries machine type and target-ppc code, to better use the error > > API. > > > > Once reviewed, I hope to merge this into

Re: [Qemu-devel] [PATCHv4 8/8] pseries: Clean up error reporting in htab migration functions

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 01:21:34PM +0100, Markus Armbruster wrote: > David Gibson writes: > > > On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: > >> David Gibson writes: > >> > >> > The functions for migrating the hash page table on pseries machine type > >> > (htab_save_setu

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

2016-01-19 Thread David Gibson
On Tue, Jan 19, 2016 at 10:59:20AM +0100, Greg Kurz wrote: > On Mon, 18 Jan 2016 13:25:19 +1100 > David Gibson wrote: > > > On Fri, Jan 15, 2016 at 04:00:38PM +0100, Greg Kurz wrote: > > > Altivec registers are 128-bit wide. They are stored in memory as two > > > 64-bit values that must be bytesw

Re: [Qemu-devel] [PATCH v2 00/11] NVDIMM ACPI: introduce the framework of QEMU emulated

2016-01-19 Thread Xiao Guangrong
Hi Michael, Igor, Paolo, Any comment? On 01/13/2016 02:49 AM, Xiao Guangrong wrote: This patchset is against commit 8a1be662a69 (virtio: fix error message for number of queues) on pci branch of Michael's git tree and can be found at: https://github.com/xiaogr/qemu.git nvdimm-acpi-v2

Re: [Qemu-devel] [PATCH v5 0/4] Extend TPM support with a QEMU-external TPM

2016-01-19 Thread Xu, Quan
Are some CCed reviewing this patch set? Thanks. -Quan > On January 04, 2016 at 11:23pm, wrote: > The following series of patches extends TPM support with an external TPM that > offers a Linux CUSE (character device in userspace) interface. This TPM lets > each VM access its own private vTPM. > T

Re: [Qemu-devel] [PATCH v10 5/7] hw/ptimer: Legalize running with delta = load = 0

2016-01-19 Thread Dmitry Osipenko
12.01.2016 21:12, Dmitry Osipenko пишет: 12.01.2016 06:58, Peter Crosthwaite пишет: On Sat, Jan 09, 2016 at 08:39:53PM +0300, Dmitry Osipenko wrote: Currently ptimer would print error message and clear enable flag for an arming timer that has delta = load = 0. That actually could be a valid cas

Re: [Qemu-devel] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register()

2016-01-19 Thread Alexey Kardashevskiy
On 01/20/2016 09:58 AM, Eric Blake wrote: On 01/15/2016 05:00 AM, David Gibson wrote: The errors detected in this function necessarily indicate bugs in the rest of the qemu code, rather than an external or configuration problem. So, a simple assert() is more appropriate than any more complex er

Re: [Qemu-devel] [PATCH v6 2/6] Xen: use qemu_strtoul instead of strtol

2016-01-19 Thread Eric Blake
On 01/17/2016 05:13 AM, Cao jin wrote: > No need to roll our own (with slightly incorrect handling of errno), > when we can use the common version. > > Change signed parsing to unsigned, because what it read are values in > PCI config space, which are non-negative. > > Signed-off-by: Cao jin > -

Re: [Qemu-devel] [PATCH v14 7/8] Implement new driver for block replication

2016-01-19 Thread Eric Blake
On 01/13/2016 02:18 AM, Changlong Xie wrote: > From: Wen Congyang > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > --- > block/Makefile.objs | 1 + > block/replication-comm.c | 66 + > block/r

Re: [Qemu-devel] CMSG_SPACE() causing compile time error on Mac OS X

2016-01-19 Thread Programmingkid
On Jan 18, 2016, at 8:23 PM, Programmingkid wrote: > > On Jan 18, 2016, at 5:09 PM, Peter Maydell wrote: > >> On 18 January 2016 at 21:09, Programmingkid >> wrote: >>> >>> On Jan 18, 2016, at 3:49 PM, Peter Maydell wrote: Can you say what 'gcc --version' prints for you? That will t

Re: [Qemu-devel] [PATCH 07/10] pseries: Clean up error handling in spapr_rtas_register()

2016-01-19 Thread Eric Blake
On 01/15/2016 05:00 AM, David Gibson wrote: > The errors detected in this function necessarily indicate bugs in the rest > of the qemu code, rather than an external or configuration problem. > > So, a simple assert() is more appropriate than any more complex error > reporting. > > Signed-off-by:

[Qemu-devel] [PATCH v2 16/16] xlnx-zynqmp: Connect the ZynqMP IOU SLCR

2016-01-19 Thread Alistair Francis
Connect the I/O Unit System Level Control Registers device to the ZynqMP model. Unfortunatly the GPIO links can not be connected yet as the SD device is not yet attached to the ZynqMP machine. Signed-off-by: Alistair Francis --- V2: - Fix up device connection hw/arm/xlnx-zynqmp.c | 13

[Qemu-devel] [PATCH v2 14/16] register: Add GPIO API

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add GPIO functionality to the register API. This allows association and automatic connection of GPIOs to bits in registers. GPIO inputs will attach to handlers that automatically set read-only bits in registers. GPIO outputs will be updated to reflect their field value whe

[Qemu-devel] [PATCH v2 13/16] irq: Add opaque setter routine

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add a routine to set or override the opaque data of an IRQ. Qdev currently always initialises IRQ opaque as the device itself. This allows you to override to a custom opaque in the case where there is extra or different data needed. Signed-off-by: Peter Crosthwaite Sign

[Qemu-devel] [PATCH v2 11/16] qdev: Define qdev_get_gpio_out

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite An API similar to the existing qdev_get_gpio_in() except gets outputs. Useful for: 1: Implementing lightweight devices that don't want to keep pointers to their own GPIOs. They can get their GPIO pointers at runtime from QOM using this API. 2: testing or debugging code w

[Qemu-devel] [PATCH v2 09/16] dma: Add Xilinx Zynq devcfg device model

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Minimal device model for devcfg module of Zynq. DMA capabilities and interrupt generation supported. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- Changed since v4: Create device state header. Use REG/FIELD/EX macros Use register init_block32 Remo

[Qemu-devel] [PATCH v2 06/16] register: QOMify

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite QOMify registers as a child of TYPE_DEVICE. This allows registers to define GPIOs. Define an init helper that will do QOM initialisation as well as setup the r/w fast paths. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- hw/core/register.c|

[Qemu-devel] [PATCH v2 12/16] qdev: Add qdev_pass_all_gpios API

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite For passing all GPIOs of all names from a contained device to a container. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- hw/core/qdev.c | 9 + include/hw/qdev-core.h | 1 + 2 files changed, 10 insertions(+) diff --git a/hw/core/

[Qemu-devel] [PATCH v2 08/16] bitops: Add ONES macro

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Little macro that just gives you N ones (justified to LSB). Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- include/qemu/bitops.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 8164225..27

[Qemu-devel] [PATCH v2 15/16] misc: Introduce ZynqMP IOU SLCR

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite IOU = I/O Unit SLCR = System Level Control Registers This IP is a misc collections of control registers that switch various properties of system IPs. Currently the only thing implemented is the SD_SLOTTYPE control (implemented as a GPIO output). Signed-off-by: Peter Cros

[Qemu-devel] [PATCH v2 10/16] xilinx_zynq: add devcfg to machine model

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- Changed since v3: Author reset. Changed since v1: Added manual parenting of devcfg node (evil but needed for early access to canonical path by devcfgs realize fn). hw/arm/xilinx_zynq.c | 8 1

[Qemu-devel] [PATCH v2 07/16] register: Add block initialise helper

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add a helper that will scan a static RegisterAccessInfo Array and populate a container MemoryRegion with registers as defined. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- V2: - Use memory_region_add_subregion_no_print() hw/core/register.c

[Qemu-devel] [PATCH v2 04/16] register: Add support for decoding information

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Allow defining of optional address decoding information in register definitions. This is useful for clients that want to associate registers with specific addresses. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- changed since v4: Remove extraneous

[Qemu-devel] [PATCH v2 03/16] register: Add Memory API glue

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Add memory io handlers that glue the register API to the memory API. Just translation functions at this stage. Although it does allow for devices to be created without all-in-one mmio r/w handlers. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- cha

[Qemu-devel] [PATCH v2 05/16] register: Define REG and FIELD macros

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite Define some macros that can be used for defining registers and fields. The REG32 macro will define A_FOO, for the byte address of a register as well as R_FOO for the uint32_t[] register number (A_FOO / 4). The FIELD macro will define FOO_BAR_MASK, FOO_BAR_SHIFT and FOO_B

[Qemu-devel] [PATCH v2 01/16] memory: Allow subregions to not be printed by info mtree

2016-01-19 Thread Alistair Francis
Add a function called memory_region_add_subregion_no_print() that creates memory subregions that won't be printed when running the 'info mtree' command. Signed-off-by: Alistair Francis --- include/exec/memory.h | 17 + memory.c | 10 +- 2 files changed, 26 i

[Qemu-devel] [PATCH v2 02/16] register: Add Register API

2016-01-19 Thread Alistair Francis
From: Peter Crosthwaite This API provides some encapsulation of registers and factors our some common functionality to common code. Bits of device state (usually MMIO registers), often have all sorts of access restrictions and semantics associated with them. This API allow you to define what thos

[Qemu-devel] [PATCH v2 00/16] data-driven device registers

2016-01-19 Thread Alistair Francis
This patch series is based on Peter C's original register API. His original cover letter is below. I have added a new function memory_region_add_subregion_no_print() which stops memory regions from being printed by 'info mtree'. This is used to avoid evey register being printed when running 'info

Re: [Qemu-devel] [PATCH v4 8/9] trace: [tcg] Add per-vCPU tracing states for events with the 'vcpu' property

2016-01-19 Thread Eric Blake
On 01/15/2016 09:38 AM, Lluís Vilanova wrote: > Each event with the 'vcpu' property gets a per-vCPU dynamic tracing state. > > The set of enabled events with the 'vcpu' and 'tcg' properties is used > to select a per-vCPU physical TB cache. The number of events with both > properties is used to se

Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2016-01-19 Thread Edgar E. Iglesias
On 19 Jan 2016 20:52, "Alistair Francis" wrote: > > On Fri, Jan 8, 2016 at 3:05 AM, Edgar E. Iglesias > wrote: > > On Fri, Jan 08, 2016 at 10:40:28AM +, Peter Maydell wrote: > >> On 8 January 2016 at 00:39, Alistair Francis > >> wrote: > >> > On Wed, Dec 16, 2015 at 8:33 AM, Alistair Francis

Re: [Qemu-devel] [PATCH v3] s390: use FILE instead of QEMUFile for creating text file

2016-01-19 Thread Eric Blake
On 01/18/2016 04:05 AM, Daniel P. Berrange wrote: > The s390 skeys monitor command needs to write out a plain text > file. Currently it is using the QEMUFile class for this, but > work is ongoing to refactor QEMUFile and eliminate much code > related to it. The only feature qemu_fopen() gives over

Re: [Qemu-devel] [PATCH v1 1/2] tcg: Add support for constant value promises

2016-01-19 Thread Lluís Vilanova
Edgar E Iglesias writes: > On Sat, Jan 16, 2016 at 09:57:36PM +0100, Lluís Vilanova wrote: >> Richard Henderson writes: >> >> > On 01/15/2016 12:12 PM, Lluís Vilanova wrote: >> >> Richard Henderson writes: >> >> >> >>> On 01/15/2016 07:35 AM, Lluís Vilanova wrote: >> +TCGv_i64 tcg_promise_i

Re: [Qemu-devel] [PATCH v3 0/3] Use QCryptoSecret for block device passwords

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 17:46, Daniel P. Berrange wrote: > On Tue, Jan 19, 2016 at 05:32:35PM +0100, Paolo Bonzini wrote: >> >> >> On 19/01/2016 14:51, Daniel P. Berrange wrote: >>> This series was previously posted: >>> >>> v1: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html >>> v2

[Qemu-devel] [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-19 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD and DVD media. Signed-off-by: John Arbuckl

Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop

2016-01-19 Thread Richard Henderson
On 01/19/2016 10:15 AM, Peter Maydell wrote: > On 15 January 2016 at 18:15, Richard Henderson wrote: >>.../qemu/run/qemu-alpha -> .../gcc/run-cross/alphaev67-linux/sys-root >>.../qemu/run/qemu-arm -> .../gcc/run-cross/arm-linux-gnueabi/sys-root >>.../qemu/run/qemu-sparc -> .../gcc/run-

[Qemu-devel] [PATCH] usb: check page select value while processing iTD

2016-01-19 Thread P J P
From: Prasad J Pandit While processing isochronous transfer descriptors(iTD), the page select(PG) field value could lead to an OOB read access. Add check to avoid it. Reported-by: Qinghao Tang Signed-off-by: Prasad J Pandit --- hw/usb/hcd-ehci.c | 10 ++ 1 file changed, 6 insertions(+

  1   2   3   4   >