[Qemu-devel] [Bug 1542965] [NEW] Failed to set NBD socket ubuntu 15.10 & nbd client 3.10

2016-02-08 Thread Jignasha
Public bug reported: Running command to mount using nbd fails with error /build/qemu-YZq7uh/qemu-2.3+dfsg/nbd.c:nbd_init():L670: Failed to set NBD socket ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- deve

Re: [Qemu-devel] [PATCH] hw/intc: fix failure return for xics_alloc_block()

2016-02-08 Thread Greg Kurz
On Mon, 8 Feb 2016 11:45:19 +1000 David Gibson wrote: > On Fri, Feb 05, 2016 at 09:43:40AM +0100, Greg Kurz wrote: > > From: Brian W. Hart > > > > xics_alloc_block() does not return a clear error code when it > > fails to allocate a block of interrupts. Instead it returns the > > base interrupt

Re: [Qemu-devel] command line error handling broken?

2016-02-08 Thread Laszlo Ersek
On 02/07/16 11:32, Michael S. Tsirkin wrote: > ./x86_64-softmmu/qemu-system-x86_64 -M q35-1.5 -redir tcp:8022::22 > > qemu-system-x86_64: -redir tcp:8022::22: unsupported machine type > Use -machine help to list supported machines > > It should say q35-1.5 is unsupported, of course. > > Anyone k

Re: [Qemu-devel] [PATCH 0/2] error: Documentation updates

2016-02-08 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Markus Armbruster writes: >>> Lluís Vilanova writes: > Markus Armbruster writes: > >> This overlaps with parts of Lluís's "[RFC][PATCH v6 0/5] utils: >> Improve and document error reporting

Re: [Qemu-devel] [PATCH] vl.c: fixed regression of machine error message

2016-02-08 Thread Laszlo Ersek
On 02/07/16 17:24, Marcel Apfelbaum wrote: > Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config > file) > fixed the error message when the machine type was supplied inside the > config file. However now the option name is not displayed correctly if > the error happens when

Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@

2016-02-08 Thread Markus Armbruster
Stephen Warren writes: > Add an entry to MAINTAINERS that matches every patch, and requests the > user send patches to qemu-devel@nongnu.org. > > It's not 100% obvious to project newcomers that all patches should be sent > there; checkpatch doesn't say so, and since it mentions other lists to CC,

Re: [Qemu-devel] Strange monitor/stdout issue on qemu-system-sparc/qemu-system-ppc

2016-02-08 Thread Paolo Bonzini
On 31/01/2016 16:54, Mark Cave-Ayland wrote: > Aha! A quick test here shows that the patch fixes the serial port > appearing on stdout and entering the monitor, but I still see the > multiple echo problem in the GTK GUI. And this should be it; if this fixes all your problems I will submit it for

Re: [Qemu-devel] [PATCH 0/2] A couple of IPMI bugs

2016-02-08 Thread Paolo Bonzini
Michael, these were missing in your pull request, probably because you weren't CCed. Do you want me to pick them instead? Thanks, Paolo

Re: [Qemu-devel] [PATCH] vl.c: fixed regression of machine error message

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 10:58 AM, Laszlo Ersek wrote: On 02/07/16 17:24, Marcel Apfelbaum wrote: Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config file) fixed the error message when the machine type was supplied inside the config file. However now the option name is not displaye

Re: [Qemu-devel] [PATCH] os-posix: Log to logfile in case of daemonize

2016-02-08 Thread Paolo Bonzini
On 16/12/2015 17:56, Alex Pyrgiotis wrote: > + > +log = qemu_get_log_filename(); > +if (log != NULL) { > +TFR(fd = qemu_open(log, O_RDWR | O_APPEND | O_CREAT, 0640)); Here you are opening the same file twice, but the FILE* that is opened in do_qemu_set_log does not ne

[Qemu-devel] [PATCH V2] vl.c: fixed regression in machine error message

2016-02-08 Thread Marcel Apfelbaum
Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config file) fixed the error message when the machine type was supplied inside the config file. However now the option name is not displayed correctly if the error happens when the machine is specified at command line. Running

Re: [Qemu-devel] [PATCH V2] vl.c: fixed regression in machine error message

2016-02-08 Thread Laszlo Ersek
On 02/08/16 11:09, Marcel Apfelbaum wrote: > Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config > file) > fixed the error message when the machine type was supplied inside the > config file. However now the option name is not displayed correctly if > the error happens when

[Qemu-devel] [PATCHv7 8/9] slirp: Adding IPv6 address for DNS relay

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is developed using this Slirp attribute. sotranslate_in/out/accept() are also updated to manage the IPv6 case so the guest can be able to join the host using one of the Slirp addresses. For now this only po

[Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron This patch factorizes the tcpiphdr structure to put the IPv4 fields in an union, for addition of version 6 in further patch. Using some macros, retrocompatibility of the existing code is assured. This patch also fixes the SLIRP_MSIZE and margin computation in various func

[Qemu-devel] [PATCHv7 5/9] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to "switch" in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. This patch does not

[Qemu-devel] [PATCHv7 2/9] slirp: Adding ICMPv6 error sending

2016-02-08 Thread Samuel Thibault
From: Yann Bordenave Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to sen

[Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- s

[Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/ip6_input.c |

[Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron This patch adds the functions needed to handle IPv6 packets. ICMPv6 and NDP headers are implemented. Slirp is now able to send NDP Router or Neighbor Advertisement when it receives Router or Neighbor Solicitation. Using a 64bit-sized IPv6 prefix, the guest is now able to

[Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring

2016-02-08 Thread Samuel Thibault
From: Guillaume Subiron No code change. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault --- slirp/tcp_input.c | 99 +++--- slirp/tcp_output.c | 29 slirp/tcp_subr.c | 50 +-- 3 files ch

[Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode

2016-02-08 Thread Samuel Thibault
Hello, This is another respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. Difference with version 6 is: - drop second-precision timer addition - use ms precision for RA timer - Use unsigned short instead of sa_family_t - Use error_r

[Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-08 Thread Samuel Thibault
From: Yann Bordenave This patch adds parameters to manage some new options in the qemu -net command. Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in argument to the qemu command. Defaults parameters are respectively fec0::2, fec0::, /64 and fec0::3. Signed-off-by: Yann B

Re: [Qemu-devel] [PATCH 1/2] ipmi_bmc_sim: Fix off by one in check.

2016-02-08 Thread Michael S. Tsirkin
On Mon, Jan 11, 2016 at 07:32:31AM -0600, miny...@acm.org wrote: > From: Corey Minyard > > Found by Paolo. > > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Cc: Peter Maydell > Cc: Shannon Zhao > Cc: Xiao Guangrong > Cc: Stefan Hajnoczi > Signed-off-by: Corey Minyard Reviewed-by: Michael

Re: [Qemu-devel] [PATCH 2/2] ipmi_bmc_sim: Add break to correct watchdog NMI check

2016-02-08 Thread Michael S. Tsirkin
On Mon, Jan 11, 2016 at 07:32:32AM -0600, miny...@acm.org wrote: > From: Corey Minyard > > It was falling through when it should have been a break. Found by > Coverity. The logic could be simplified a bit with a fallthrough, > probably the original thought, but that would be less clear, I think

Re: [Qemu-devel] [PATCH 0/2] A couple of IPMI bugs

2016-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2016 at 10:14:14AM +0100, Paolo Bonzini wrote: > Michael, these were missing in your pull request, probably because you > weren't CCed. Do you want me to pick them instead? Sure, go ahead. Thanks! > Thanks, > > Paolo

Re: [Qemu-devel] [PATCH V2] vl.c: fixed regression in machine error message

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 12:28 PM, Laszlo Ersek wrote: On 02/08/16 11:09, Marcel Apfelbaum wrote: Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config file) fixed the error message when the machine type was supplied inside the config file. However now the option name is not displaye

Re: [Qemu-devel] [PATCH v2 03/11] acpi: add aml_create_field()

2016-02-08 Thread Igor Mammedov
On Wed, 13 Jan 2016 02:50:02 +0800 Xiao Guangrong wrote: > It will be used by nvdimm acpi > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 13 + > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/

Re: [Qemu-devel] [PATCH v2 04/11] acpi: add aml_concatenate()

2016-02-08 Thread Igor Mammedov
On Wed, 13 Jan 2016 02:50:03 +0800 Xiao Guangrong wrote: > It will be used by nvdimm acpi > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 14 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 15 insertions(+) > > diff --git a/hw/acpi/aml-build.c b

[Qemu-devel] [Bug 1543057] [NEW] Warnings are treated as errors

2016-02-08 Thread QemUser
Public bug reported: System: Ubuntu 14.04, 32bit Kernel: 3.13.0-55-generic Qemu: v. 2.2.50 Error msg: hw/acpi/pcihp.c: In function ‘acpi_pcihp_pc_no_hotplug’: hw/acpi/pcihp.c:117:34: error: ‘PCIDevice’ has no member named ‘qdev’ return (pc->is_bridge && !dev->qdev.hotplugged) || !dc->hotplu

Re: [Qemu-devel] [PATCH v2 05/11] acpi: allow using object as offset for OperationRegion

2016-02-08 Thread Igor Mammedov
On Wed, 13 Jan 2016 02:50:04 +0800 Xiao Guangrong wrote: > Extend aml_operation_region() to use object as offset Reviewed-by: Igor Mammedov > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 4 ++-- > hw/i386/acpi-build.c| 31 --- > i

Re: [Qemu-devel] [PATCH V2] vl.c: fixed regression in machine error message

2016-02-08 Thread Laszlo Ersek
On 02/08/16 11:46, Marcel Apfelbaum wrote: > On 02/08/2016 12:28 PM, Laszlo Ersek wrote: >> On 02/08/16 11:09, Marcel Apfelbaum wrote: >>> Commit e1ce0c3cb(vl.c: fix regression when reading machine type from >>> config file) >>> fixed the error message when the machine type was supplied inside the

Re: [Qemu-devel] [PATCH v2 06/11] nvdimm acpi: initialize the resource used by NVDIMM ACPI

2016-02-08 Thread Igor Mammedov
On Wed, 13 Jan 2016 02:50:05 +0800 Xiao Guangrong wrote: > 32 bits IO port starting from 0x0a18 in guest is reserved for NVDIMM > ACPI emulation. The table, NVDIMM_DSM_MEM_FILE, will be patched into > NVDIMM ACPI binary code > > OSPM uses this port to tell QEMU the final address of the DSM memor

Re: [Qemu-devel] [PATCH V2] vl.c: fixed regression in machine error message

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 01:02 PM, Laszlo Ersek wrote: On 02/08/16 11:46, Marcel Apfelbaum wrote: On 02/08/2016 12:28 PM, Laszlo Ersek wrote: On 02/08/16 11:09, Marcel Apfelbaum wrote: Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config file) fixed the error message when the machi

Re: [Qemu-devel] [PATCH RESEND] fix MSI injection on Xen

2016-02-08 Thread Stefano Stabellini
On Thu, 4 Feb 2016, Michael S. Tsirkin wrote: > On Thu, Feb 04, 2016 at 05:05:46PM +, Stefano Stabellini wrote: > > Hi Michael, > > > > do you have any comments on this? > > I dislike how it spreads xen specific stuff around, > but I don't have a better idea at the moment, so > I applied this

[Qemu-devel] [PATCH V3] vl.c: fixed regression in machine error message

2016-02-08 Thread Marcel Apfelbaum
Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config file) fixed the error message when the machine type was supplied inside the config file. However now the option name is not displayed correctly if the error happens when the machine is specified at command line. Running

Re: [Qemu-devel] [PULL 00/12] TCG patch queue

2016-02-08 Thread Peter Maydell
On 6 February 2016 at 00:09, Richard Henderson wrote: > This contains two patches from December, and the portion that > has been reviewed of my tcg-indirect-register series for sparc. > The latter is mostly cleanup to tcg.c and so is nice to have > regardless of the rest of the patch set. > > > r~

Re: [Qemu-devel] Regarding Cortex-A7 CPU definition

2016-02-08 Thread Deepak kumar Raju
copying qemu development mailing list. Thanks, Best Regards, -Deepak On Mon, Feb 8, 2016 at 2:21 PM, Deepak kumar Raju < raju.deepakku...@gmail.com> wrote: > > Hi Peter, > > I am Deepak. I have a Cortex-A7 board and I am using qemu code from Linaro. > In Qemu-linaro.git, under .../target-arm/cp

Re: [Qemu-devel] [PATCH v2 00/10] hw/sd: QOMify sd.c (and pxa2xx_mmci)

2016-02-08 Thread Peter Maydell
Ping? thanks -- PMM On 22 January 2016 at 16:16, Peter Maydell wrote: > This series attempts to QOMify sd.c (the actual SD card model), > including a proper QOM bus between the controller and the card. > > This series removes the experimental x-drive property on sdhci-pci; > the syntax for using

Re: [Qemu-devel] [PATCH V3] vl.c: fixed regression in machine error message

2016-02-08 Thread Laszlo Ersek
sorry, but: On 02/08/16 12:19, Marcel Apfelbaum wrote: > Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config > file) > fixed the error message when the machine type was supplied inside the > config file. However now the option name is not displayed correctly if > the error

[Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
Also we can use current machine properties instead of querying machine's opts. Signed-off-by: Marcel Apfelbaum --- vl.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 5873248..c03a4fe 100644 --- a/vl.c +++ b/vl.c @@ -4353,11 +4353,10 @@ int main(in

Re: [Qemu-devel] [PATCH V3] vl.c: fixed regression in machine error message

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 01:41 PM, Laszlo Ersek wrote: sorry, but: On 02/08/16 12:19, Marcel Apfelbaum wrote: Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config file) fixed the error message when the machine type was supplied inside the config file. However now the option name is

Re: [Qemu-devel] [PATCH v9 03/16] block: Add BB-BDS remove/insert notifiers

2016-02-08 Thread Alberto Garcia
On Fri 29 Jan 2016 04:36:03 PM CET, Max Reitz wrote: > bdrv_close() no longer signifies ejection of a medium, this is now done > by removing the BDS from the BB. Therefore, we want to have a notifier > for that in the BB instead of a close notifier in the BDS. The former is > added now, the latter

[Qemu-devel] [PATCH V4] vl.c: fixed regression in machine error message

2016-02-08 Thread Marcel Apfelbaum
Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config file) fixed the error message when the machine type was supplied inside the config file. However now the option name is not displayed correctly if the error happens when the machine is specified at command line. Running

Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused compat code

2016-02-08 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Feb 05, 2016 at 09:55:08AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Thu, Feb 04, 2016 at 03:16:17PM -0200, Eduardo Habkost wrote: >> >> On Thu, Feb 04, 2016 at 06:01:50PM +0200, Michael S. Tsirkin wrote: >> >> > On Sat, Ja

Re: [Qemu-devel] [PATCH V4] vl.c: fixed regression in machine error message

2016-02-08 Thread Laszlo Ersek
On 02/08/16 12:54, Marcel Apfelbaum wrote: > Commit e1ce0c3cb(vl.c: fix regression when reading machine type from config > file) > fixed the error message when the machine type was supplied inside the > config file. However now the option name is not displayed correctly if > the error happens when

Re: [Qemu-devel] Serial telnet console drops incoming characters on git master

2016-02-08 Thread Daniel P. Berrange
On Sun, Feb 07, 2016 at 06:38:56PM +, Mark Cave-Ayland wrote: > Hi Daniel, > > I found another issue where the latest set of console updates appear to > break -serial telnet on qemu-system-sparc. What I see is that while > incoming serial telnet appears fine, outgoing serial telnet traffic > c

[Qemu-devel] [PATCH V2] vl.c: remove machine_opts from main and the duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
Use current machine properties instead of querying machine's opts. Signed-off-by: Marcel Apfelbaum --- v1 -> v2: - Use the current machine also for dtb - Remove the machine_opts from main completely vl.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Laszlo Ersek
On 02/08/16 12:45, Marcel Apfelbaum wrote: > Also we can use current machine properties instead of querying machine's opts. Why? :) For me at least, you'll have to spell it out. Thanks Laszlo > > Signed-off-by: Marcel Apfelbaum > --- > vl.c | 9 - > 1 file changed, 4 insertions(+), 5

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: Also we can use current machine properties instead of querying machine's opts. Why? :) For me at least, you'll have to spell it out. The theory would be that is cleaner to call an object property than use

Re: [Qemu-devel] [PATCH 07/15] qapi: Clean up includes

2016-02-08 Thread Peter Maydell
On 29 January 2016 at 18:31, Eric Blake wrote: > Hmm - we also have generated qapi files, where the scripts/qapi*.py > files will need to output correct header information. I'll take a look > at doing that. Hi Eric; did you get time to look at updating these scripts? I started working on the "re

Re: [Qemu-devel] [PULL v2 00/45] pc and misc cleanups and fixes, virtio optimizations

2016-02-08 Thread Peter Maydell
On 6 February 2016 at 19:12, Michael S. Tsirkin wrote: > The following changes since commit 382d34ff9fcc534db32d54eb82590de7c04f9b33: > > Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' > into staging (2016-02-03 19:00:33 +) > > are available in the git repository

Re: [Qemu-devel] [PATCH v12 1/2] mirror: Rewrite mirror_iteration

2016-02-08 Thread Max Reitz
On 07.02.2016 13:46, Fam Zheng wrote: > On Sat, 02/06 14:24, Max Reitz wrote: >> On 05.02.2016 03:00, Fam Zheng wrote: >>> The "pnum < nb_sectors" condition in deciding whether to actually copy >>> data is unnecessarily strict, and the qiov initialization is >>> unnecessarily for bdrv_aio_write_zer

Re: [Qemu-devel] [PATCH v7 3/3] i386: populate floppy drive information in DSDT

2016-02-08 Thread Roman Kagan
On Sun, Feb 07, 2016 at 11:08:07AM +0200, Michael S. Tsirkin wrote: > On Tue, Jan 26, 2016 at 02:50:25PM +0100, Igor Mammedov wrote: > > From: Roman Kagan > > -static Aml *build_fdc_device_aml(void) > > +static Aml *build_fdinfo_aml(int idx, uint8_t type, uint8_t cylinders, > > +

Re: [Qemu-devel] [PATCH 2/7] target-arm: Implement MDCR_EL3 and SDCR

2016-02-08 Thread Peter Maydell
On 6 February 2016 at 18:42, Sergey Fedorov wrote: > On 03.02.2016 16:38, Peter Maydell wrote: >> --- a/target-arm/helper.c >> +++ b/target-arm/helper.c >> @@ -364,6 +364,23 @@ static CPAccessResult >> access_el3_aa32ns_aa64any(CPUARMState *env, >> return CP_ACCESS_OK; >> } >> >> +/* Some s

Re: [Qemu-devel] [PATCH 1/3] char: fix vhost-user socket full

2016-02-08 Thread Didier Pallard
On 02/04/2016 03:10 PM, Michael S. Tsirkin wrote: On Thu, Dec 03, 2015 at 10:53:17AM +0100, Didier Pallard wrote: unix_send_msgfds is used by vhost-user control socket. qemu_chr_fe_write_all is used to send a message and retries as long as EAGAIN errno is set, but write_msgfds buffer is freed af

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

2016-02-08 Thread Roman Kagan
On Fri, Feb 05, 2016 at 07:25:07PM +0100, Igor Mammedov wrote: > On Thu, 4 Feb 2016 23:54:13 +0200 > "Michael S. Tsirkin" wrote: > > -static Aml *build_fdc_device_aml(void) > > +static Aml *build_fdinfo_aml(int idx, uint8_t type, uint8_t cylinders, > > + uint8_t heads,

Re: [Qemu-devel] [PATCH v7 3/3] i386: populate floppy drive information in DSDT

2016-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2016 at 04:00:37PM +0300, Roman Kagan wrote: > On Sun, Feb 07, 2016 at 11:08:07AM +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 26, 2016 at 02:50:25PM +0100, Igor Mammedov wrote: > > > From: Roman Kagan > > > -static Aml *build_fdc_device_aml(void) > > > +static Aml *build_fdinf

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/3] target-arm: Fix IL in syndromes for FP and copro traps

2016-02-08 Thread Peter Maydell
On 5 February 2016 at 14:37, Peter Maydell wrote: > This series corrects a bug I noticed while reading the code. > > In syndrome register values, the IL bit indicates the instruction > length, and is 1 for 4-byte instructions and 0 for 2-byte > instructions. All A64 and A32 instructions are 4-byt

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/7] Fix some more EL3 things and enable EL3 for AArch64

2016-02-08 Thread Peter Maydell
On 3 February 2016 at 13:38, Peter Maydell wrote: > This series fixes a couple more minor EL3 related missing parts, > and then turns on EL3 for AArch64 CPUs. The minor fixed things are: > * implement MDCR_EL3 and SDCR > * trap Secure EL1 accesses to SCR and MVBAR to EL3 > * add EL3 support to

Re: [Qemu-devel] [PATCH 2/3] virtio-pci: add an option to bypass guest_notifier_mask

2016-02-08 Thread Didier Pallard
On 02/04/2016 02:08 PM, Michael S. Tsirkin wrote: On Thu, Dec 03, 2015 at 10:53:18AM +0100, Didier Pallard wrote: Using guest_notifier_mask function in vhost-user case may break interrupt mask paradigm, because mask/unmask is not really done when returning from guest_notifier_mask call, instead

Re: [Qemu-devel] [PATCH v7 3/3] i386: populate floppy drive information in DSDT

2016-02-08 Thread Igor Mammedov
On Tue, 26 Jan 2016 14:50:25 +0100 Igor Mammedov wrote: > From: Roman Kagan > > On x86-based systems Linux determines the presence > and the type of floppy drives via a query of a CMOS field. > So does SeaBIOS when populating the return data for > int 0x13 function 0x08. > > However Windows do

[Qemu-devel] [PATCH] char: fix repeated registration of tcp chardev I/O handlers

2016-02-08 Thread Daniel P. Berrange
In previous commit: commit f2001a7e0555b66d6db25a3ff1801540814045bb Author: Daniel P. Berrange Date: Tue Jan 19 11:14:30 2016 + char: don't assume telnet initialization will not block The code which writes the telnet initialization sequence moved to an event loop callback. If th

Re: [Qemu-devel] Serial telnet console drops incoming characters on git master

2016-02-08 Thread Daniel P. Berrange
On Mon, Feb 08, 2016 at 12:11:53PM +, Daniel P. Berrange wrote: > On Sun, Feb 07, 2016 at 06:38:56PM +, Mark Cave-Ayland wrote: > > Hi Daniel, > > > > I found another issue where the latest set of console updates appear to > > break -serial telnet on qemu-system-sparc. What I see is that w

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Include qemu/osdep.h

2016-02-08 Thread Peter Maydell
On 29 January 2016 at 16:23, Peter Maydell wrote: > Include "qemu/osdep.h". (This is a manual commit equivalent > to what the clean-includes script would do, because that > script can't handle ObjectiveC source files.) > > Signed-off-by: Peter Maydell > --- > ui/cocoa.m | 2 ++ > 1 file changed,

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add section for FPU emulation

2016-02-08 Thread Peter Maydell
On 29 January 2016 at 09:16, Aurelien Jarno wrote: > On 2016-01-26 13:27, Peter Maydell wrote: >> Add an entry to the MAINTAINERS file for our softfloat FPU >> emulation code. This code is only 'odd fixes' but it's useful to >> record who to cc on patches to it. >> >> Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH V2] vl.c: remove machine_opts from main and the duplicate call to qemu_get_machine_opts

2016-02-08 Thread Igor Mammedov
On Mon, 8 Feb 2016 14:15:59 +0200 Marcel Apfelbaum wrote: > Use current machine properties instead of querying machine's opts. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov > --- > > v1 -> v2: > - Use the current machine also for dtb > - Remove the machine_opts from main

[Qemu-devel] [PATCH 3/3] block: Update the x-blockdev-del documentation

2016-02-08 Thread Alberto Garcia
Explain what happens if the user tries to delete a BlockBackend that contains media that was added separately using blockdev-add. Signed-off-by: Alberto Garcia --- qapi/block-core.json | 5 - qmp-commands.hx | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/qapi/

[Qemu-devel] [PATCH 1/3] block: Allow x-blockdev-del on a BB with a monitor-owned BDS

2016-02-08 Thread Alberto Garcia
When x-blockdev-del is performed on a BlockBackend that has inserted media it will only succeed if the BDS doesn't have any additional references. The only problem with this is that if the BDS was created separately using blockdev-add then the backend won't be able to be destroyed unless the BDS i

[Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes in x-blockdev-del

2016-02-08 Thread Alberto Garcia
Now that we allow x-blockdev-del to work in a new scenario that previously forbidden we must update the iotests in order to reflect this change. Both testAttachMedia() and testSnapshot() are splitted in two: one version keeps the previous behavior, and a second version checks that the new function

[Qemu-devel] [PATCH 4/4] usbnet: Report link-up via interrupt endpoint in CDC-ECM mode

2016-02-08 Thread Michael Brown
Signed-off-by: Michael Brown --- hw/usb/dev-network.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 09312d4..f8e6e57 100644 --- a/hw/usb/dev-network.c +++ b/hw/usb/dev-network.c @@ -86,6 +86,8 @@

[Qemu-devel] [PATCH 0/4] usbnet: various CDC-ECM and xHCI fixes

2016-02-08 Thread Michael Brown
This patch series fixes a few minor issues discovered when attempting to use the CDC-ECM configuration for usbnet with the xHCI host controller.

[Qemu-devel] [PATCH 1/4] usbnet: Add missing usb_wakeup() call in usbnet_receive()

2016-02-08 Thread Michael Brown
usbnet_receive() does not currently wake up the USB endpoint, leading to a dead RX datapath when used with a host controller such as xHCI that relies on being woken up. Fix by adding a call to usb_wakeup() at the end of usbnet_receive(). Signed-off-by: Michael Brown --- hw/usb/dev-network.c | 3

[Qemu-devel] [PATCH 3/4] usbnet: Detect short packets as sent by the xHCI controller

2016-02-08 Thread Michael Brown
The xHCI controller will ignore the endpoint MTU and so may deliver packets of any length. Detect short packets as being any packet that has a length of zero or a length that is not a multiple of the MTU. Signed-off-by: Michael Brown --- hw/usb/dev-network.c | 2 +- 1 file changed, 1 insertion(

[Qemu-devel] [PATCH 2/4] usbnet: Accept mandatory USB_CDC_SET_ETHERNET_PACKET_FILTER request

2016-02-08 Thread Michael Brown
The USB_CDC_SET_ETHERNET_PACKET_FILTER request is mandatory for CDC-ECM devices. Accept this request, ignoring the actual filter value (to match the existing behaviour for RNDIS). Signed-off-by: Michael Brown --- hw/usb/dev-network.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH] Add support for using directory as initrd

2016-02-08 Thread Kasper Dupont
Signed-off-by: Kasper Dupont --- hw/core/loader.c| 71 + hw/i386/pc.c| 6 +++-- include/hw/loader.h | 1 + 3 files changed, 76 insertions(+), 2 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 3a57415..6047486 1

Re: [Qemu-devel] [PATCH 1/1] block: fix inability to start VM with native AIO

2016-02-08 Thread Stefan Hajnoczi
On Mon, Jan 11, 2016 at 05:26:19PM +0300, Denis V. Lunev wrote: > On 01/11/2016 04:46 PM, Christian Borntraeger wrote: > >On 12/22/2015 07:59 AM, Denis V. Lunev wrote: > >>error: Failed to start domain rhel7 > >>error: internal error: process exited while connecting to monitor: > >> 2015-12-22T

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] nbd: changes around allocating buffers for requests

2016-02-08 Thread Stefan Hajnoczi
On Thu, Jan 07, 2016 at 02:44:24PM +0100, Paolo Bonzini wrote: > Notably, patch 2 introduces blk_try_blockalign. If it is acked by > the block layer maintainers I can submit the patch myself for > inclusion. > > Paolo > > Paolo Bonzini (2): > nbd: do not check request length except for reads a

Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll

2016-02-08 Thread Stefan Hajnoczi
On Wed, Feb 03, 2016 at 10:52:38AM +0100, Paolo Bonzini wrote: > > > On 03/02/2016 10:34, Stefan Hajnoczi wrote: > > +g_usleep(50); > > Sleep? > >>> > >>> What about it? :) > > Sleep in a loop is inefficient but at least correct. > > > > A sleep outside a loop is a race cond

Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings

2016-02-08 Thread Stefan Hajnoczi
On Mon, Jan 18, 2016 at 07:28:43PM +0100, Greg Kurz wrote: > On Mon, 18 Jan 2016 20:37:58 +0300 > Michael Tokarev wrote: > > > 11.01.2016 20:30, Greg Kurz wrote: > > > > > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section > > > name: %s gpa: %"PRIx64"" > > > +virtio_balloon

[Qemu-devel] lock-free monitor?

2016-02-08 Thread Dr. David Alan Gilbert
Hi, I wondered what it would take to be able to do a lock-free monitor; i.e. one that could respond to (some) commands while the qemu big lock is held. My reason for asking is that there are cases in migration and colo where a network block device has failed and is blocking, but it fails at just

[Qemu-devel] [PATCH v3 06/11] block: m25p80: Add configuration registers

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski This patch adds both volatile and non volatile configuration registers and commands to allow modify them. It is needed for proper handling dummy cycles. Power-on initialization of those registers and flash state has been included as well. Some of this registers are used by

[Qemu-devel] [PATCH v3 01/11] block: m25p80: Removed unused variable

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index de24f42..124 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -246,8 +246,

[Qemu-devel] [PATCH v3 04/11] block: m25p80: Extend address mode

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Extend address mode allows to switch flash 16 MiB banks, allowing user to access all flash sectors. This access mode is used by u-boot. Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 27 +++ 1 file change

[Qemu-devel] [PATCH v3 03/11] block: m25p80: Widen flags variable

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Extend the width of the flags variable to support the already existing (but unused) WR_1 flag, which is above the range of 8 bits. This allows support of EEPROM emulation which requires the WR_1 feature. Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --

[Qemu-devel] [PATCH v3 10/11] block: m25p80: n25q256a/n25q512a models

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 530e3f5..ff8a2b8 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.

[Qemu-devel] [PATCH v3 07/11] block: m25p80: Dummy cycles for N25Q256/512

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski This patch handles dummy cycles. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 3949cc5..5a1abfd 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -53

[Qemu-devel] [PATCH v3 08/11] block: m25p80: Fast read and 4bytes commands

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Adds fast read and 4bytes commands family. This work is based on Pawel Lenkow patch from v1. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/hw/b

Re: [Qemu-devel] [PATCH 1/6] target-arm: correct CNTFRQ access rights

2016-02-08 Thread Sergey Fedorov
On 05.02.2016 19:44, Peter Maydell wrote: > Correct some corner cases we were getting wrong for > CNTFRQ access rights: > * should UNDEF from 32-bit Secure EL1 > * only writable from the highest implemented exception level, >which might not be EL1 now > > Signed-off-by: Peter Maydell > --- >

[Qemu-devel] [PATCH v3 02/11] block: m25p80: RESET_ENABLE and RESET_MEMORY commnads

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 124..b986df4 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p

[Qemu-devel] [PATCH v3 05/11] block: m25p80: 4byte address mode

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski This patch adds only 4byte address mode (does not cover dummy cycles). This mode is needed to access more than 16 MiB of flash. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 41 +++-- 1 file changed, 35 insertions(+), 6 del

Re: [Qemu-devel] [PATCH 1/6] target-arm: correct CNTFRQ access rights

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 15:25, Sergey Fedorov wrote: > On 05.02.2016 19:44, Peter Maydell wrote: >> Correct some corner cases we were getting wrong for >> CNTFRQ access rights: >> * should UNDEF from 32-bit Secure EL1 >> * only writable from the highest implemented exception level, >>which mig

[Qemu-devel] [PATCH v3 00/11] Support for N25Q256/512 and AT25128/256

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski V3: - Checkpatch run on patches - Renamed function V2: - Removed support for mx66u51235 and s25fl512s from this series - Corrected/implemented dummy cycles - rebased to master Marcin Krzeminski (11): block: m25p80: Removed unused variable block: m25p80: RESET_ENABLE a

Re: [Qemu-devel] trace: timestamps, core IDs, and file creation

2016-02-08 Thread Stefan Hajnoczi
On Wed, Jan 13, 2016 at 03:13:02PM -0800, Hollis Blanchard wrote: > Hi Stefan, I've been starting to use qemu tracing and found it quite useful. > I have a couple comments about the trace events in general: Sorry for the late reply. > The event timestamps are host time (get_clock()). I'm correlat

Re: [Qemu-devel] [PATCH 05/16] iothread: release AioContext around aio_poll

2016-02-08 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 05/02/2016 18:51, Stefan Hajnoczi wrote: >> Because this is a file descriptor source, there is really no >> difference between the code's behavior, no matter if aio_poll >> starts before or after the event_notifier_set. The test passes >> ev

[Qemu-devel] [PATCH v3 11/11] block: m25p80: at25128a/at25256a models

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index ff8a2b8..43ad955 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -99,6 +99,12 @@ static const Fla

[Qemu-devel] [PATCH v3 09/11] block: m25p80: Implemented FSR register

2016-02-08 Thread marcin . krzeminski
From: Marcin Krzeminski Implements FSR register, it is used for busy waits. Signed-off-by: Marcin Krzeminski --- hw/block/m25p80.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index f49578a..530e3f5 100644 --- a/hw/block/m25p80.c +++ b/

Re: [Qemu-devel] [PATCH v3 1/2] cpu: Add callback to check architectural watchpoint match

2016-02-08 Thread Peter Maydell
Andreas -- can I nudge you to say your preferences on whether QOM CPU methods should have wrapper functions, please? I think this patchset is otherwise ready to apply. thanks -- PMM On 2 February 2016 at 12:23, Peter Maydell wrote: > On 31 January 2016 at 16:15, Sergey Fedorov wrote: >> When QE

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/6] target-arm: Fix handling of SCR.SMD

2016-02-08 Thread Sergey Fedorov
On 05.02.2016 19:45, Peter Maydell wrote: > We weren't quite implementing the handling of SCR.SMD correctly. > The condition governing whether the SMD bit should apply only > for NS state is "is EL3 is AArch32", not "is the current EL AArch32". > Fix the condition, and clarify the comment both to r

[Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Eric Blake
As a followup to commit cbf2115, clean up the includes in files generated by QAPI so that osdep.h is included first in .c files, and headers which it implies are not included manually. This patch is done manually, since Coccinelle (and therefore scripts/clean-includes) doesn't see into the generat

Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings

2016-02-08 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Jan 18, 2016 at 07:28:43PM +0100, Greg Kurz wrote: >> On Mon, 18 Jan 2016 20:37:58 +0300 >> Michael Tokarev wrote: >> >> > 11.01.2016 20:30, Greg Kurz wrote: >> > >> > > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section >> > > name: %s gp

  1   2   3   >