Re: [Qemu-devel] 答复: [PATCH] net: ne2000: check ring buffer control registers

2016-02-08 Thread P J P
+-- On Fri, 5 Feb 2016, yanghongke wrote --+ | I think the important issue is that we should modify ne2000_receive | | > @@ -247,6 +247,7ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_) | > - if (index <= s->stop) | > + if (index < s->stop) That'd break the loop

Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers

2016-02-08 Thread P J P
Hello Jason, +-- On Fri, 5 Feb 2016, Jason Wang wrote --+ | I suspect this could even work. Consider after realizing, s->stop is | zero, any attempt to set STARTPG will fail? Ie after 'pci_ne2000_realize'? It does not seem to set or reset s->stop register. | This may not be sufficient, cons

[Qemu-devel] [PATCH 2/3] replay: introduce new checkpoint for icount warp

2016-02-08 Thread Pavel Dovgalyuk
qemu_clock_warp function is called to update virtual clock when CPU is sleeping. This function includes replay checkpoint to make execution deterministic in icount mode. Record/replay module flushes async event queue at checkpoints. Some of the events (e.g., block devices operations) include intera

[Qemu-devel] [PATCH 1/3] replay: character devices

2016-02-08 Thread Pavel Dovgalyuk
This patch implements record and replay of character devices. It records chardevs communication in replay mode. Recorded information include data read from backend and counter of bytes written from frontend to backend to preserve frontend internal state. If character device was configured through t

[Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-08 Thread Pavel Dovgalyuk
This patch introduces a set of functions that implement recording and replaying of block devices' operations. These functions form a thin layer between blk_aio_ functions and replay subsystem. All asynchronous block requests are added to the queue to be processed at deterministically invoked record

[Qemu-devel] [PATCH 0/3] Deterministic replay extensions

2016-02-08 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. It includes recording and replaying of serial devices and block devices operations. With these patches one can record and deterministically replay behavior of the system with connected disk drives

Re: [Qemu-devel] [PATCH V2] bcm2835_property: implement "get board revision" query

2016-02-08 Thread Andrew Baumann
> From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Tuesday, 9 February 2016 3:59 PM > > Return a valid value from the BCM2835 property mailbox query "get board > revision". This query is used by U-Boot. Implementing it fixes the first > obvious difference between qemu and real HW. > >

[Qemu-devel] [PATCH V2] bcm2835_property: implement "get board revision" query

2016-02-08 Thread Stephen Warren
Return a valid value from the BCM2835 property mailbox query "get board revision". This query is used by U-Boot. Implementing it fixes the first obvious difference between qemu and real HW. The value returned is currently hard-coded to match the RPi2 I own. Other values are legal, e.g. different b

Re: [Qemu-devel] [v10][PATCH 03/10] piix: create host bridge to passthrough

2016-02-08 Thread Alex Williamson
On Wed, 15 Jul 2015 13:37:43 +0800 Tiejun Chen wrote: > Implement a pci host bridge specific to passthrough. Actually > this just inherits the standard one. And we also just expose > a minimal real host bridge pci configuration subset. > > Signed-off-by: Tiejun Chen > Acked-by: Michael S. Tsirk

[Qemu-devel] [PATCH V2] MAINTAINERS: add all-match entry for qemu-devel@

2016-02-08 Thread Stephen Warren
Add an entry to MAINTAINERS that matches every patch, and requests the user send patches to qemu-devel@nongnu.org. It's not 100% obvious to project newcomers that all patches should be sent there; checkpatch doesn't say so, and since it mentions other lists to CC, the wording "the list" from the S

Re: [Qemu-devel] [PATCHv2 5/7] pseries: Move hash page table allocation to reset time

2016-02-08 Thread Alexey Kardashevskiy
On 02/09/2016 01:12 PM, David Gibson wrote: At the moment the size of the hash page table (HPT) is fixed based on the maximum memory allowed to the guest. As such, we allocate the table during machine construction, and just clear it at reset. However, we're planning to implement a PAPR extensio

[Qemu-devel] [PATCHv2 7/7] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-02-08 Thread David Gibson
When a Power cpu with 64-bit hash MMU has it's hash page table (HPT) pointer updated by a write to the SDR1 register we need to update some derived variables. Likewise, when the cpu is configured for an external HPT (one not in the guest memory space) some derived variables need to be updated. Cu

[Qemu-devel] [PATCHv2 3/7] pseries: Simplify handling of the hash page table fd

2016-02-08 Thread David Gibson
When migrating the 'pseries' machine type with KVM, we use a special fd to access the hash page table stored within KVM. Usually, this fd is opened at the beginning of migration, and kept open until the migration is complete. However, if there is a guest reset during the migration, the fd can bec

[Qemu-devel] [PATCHv2 0/7] Cleanups to Hash Page Table handling

2016-02-08 Thread David Gibson
This contains some assorted cleanups and small improvements to the management of the Hash Page Table for 64-bit ppc systems, and the "pseries" machine type in particular. These were devised in the context of getting hash page table resizing working, but can stand on their own. I think this is rea

[Qemu-devel] [PATCHv2 5/7] pseries: Move hash page table allocation to reset time

2016-02-08 Thread David Gibson
At the moment the size of the hash page table (HPT) is fixed based on the maximum memory allowed to the guest. As such, we allocate the table during machine construction, and just clear it at reset. However, we're planning to implement a PAPR extension allowing the hash page table to be resized a

[Qemu-devel] [PATCHv2 2/7] target-ppc: Include missing MMU models for SDR1 in info registers

2016-02-08 Thread David Gibson
The HMP command "info registers" produces somewhat different information on different ppc cpu variants. For those with a hash MMU it's supposed to include the SDR1, DAR and DSISR registers related to the MMU. However, the switch is missing a couple of MMU model variants, meaning we will miss out

[Qemu-devel] [PATCHv2 4/7] pseries: Add helper to calculate recommended hash page table size

2016-02-08 Thread David Gibson
At present we calculate the recommended hash page table (HPT) size for a pseries guest just once in ppc_spapr_init() before allocating the HPT. In future patches we're going to want this calculation in other places, so this splits it out into a helper function. While we're at it, change the calcul

[Qemu-devel] [PATCHv2 6/7] target-ppc: Remove hack for ppc_hash64_load_hpte*() with HV KVM

2016-02-08 Thread David Gibson
With HV KVM, the guest's hash page table (HPT) is managed by the kernel and not directly accessible to QEMU. This means that spapr->htab is NULL and normally env->external_htab would also be NULL for each cpu. However, that would cause ppc_hash64_load_hpte*() to do the wrong thing in the few case

[Qemu-devel] [PATCHv2 1/7] target-ppc: Remove unused kvmppc_update_sdr1() stub

2016-02-08 Thread David Gibson
This KVM stub implementation isn't used anywhere. Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy --- target-ppc/kvm_ppc.h | 5 - 1 file changed, 5 deletions(-) diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h index 62406ce..aaa828c 100644 --- a/target-ppc/kvm_ppc.h +

Re: [Qemu-devel] [PATCH v2 00/10] hw/sd: QOMify sd.c (and pxa2xx_mmci)

2016-02-08 Thread Kevin O'Connor
On Fri, Jan 22, 2016 at 04:16:32PM +, Peter Maydell wrote: > This series attempts to QOMify sd.c (the actual SD card model), > including a proper QOM bus between the controller and the card. > > This series removes the experimental x-drive property on sdhci-pci; > the syntax for using that dev

Re: [Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-08 Thread Fam Zheng
On Mon, 02/08 16:49, John Snow wrote: > > +def _guess_command(self): > > +for c in [["docker"], ["sudo", "-n", "docker"]]: > > If the sudo version fails (Say, because a password prompt shows up) we > get the unhelpful error "Cannot find working docker command." If you have previously

Re: [Qemu-devel] [PATCH V7 8/9] introduce xlnx-dp

2016-02-08 Thread Alistair Francis
On Mon, Feb 1, 2016 at 7:43 AM, wrote: > From: KONRAD Frederic > > This is the implementation of the DisplayPort. > It has an aux-bus to access dpcd and edid. > > Graphic plane is connected to the channel 3. > Video plane is connected to the channel 0. > Audio stream are connected to the channel

Re: [Qemu-devel] [PATCH V7 4/9] introduce aux-bus

2016-02-08 Thread Alistair Francis
On Mon, Feb 1, 2016 at 7:43 AM, wrote: > From: KONRAD Frederic > > This introduces a new bus: aux-bus. > > It contains an address space for aux slaves devices and a bridge to an I2C bus > for I2C through AUX transactions. > > Signed-off-by: KONRAD Frederic > Tested-By: Hyun Kwon > --- > defau

Re: [Qemu-devel] [RFC PATCH 03/16] block: Allow .bdrv_close callback to release dirty bitmaps

2016-02-08 Thread John Snow
On 01/26/2016 05:38 AM, Fam Zheng wrote: > If the driver owns some dirty bitmaps, this assertion will fail. > > The correct place to release them is in bdrv_close, so move the > assertion one line down. > > Signed-off-by: Fam Zheng > --- > block.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [RFC PATCH 02/16] block: Set dirty before doing write

2016-02-08 Thread John Snow
On 01/26/2016 05:38 AM, Fam Zheng wrote: > So that driver can write the dirty bits into persistent dirty bitmaps in > the write callback. > > Signed-off-by: Fam Zheng > --- > block/io.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/io.c b/block/io.c > inde

Re: [Qemu-devel] [RFC PATCH 01/16] doc: Add QBM format specification

2016-02-08 Thread John Snow
On 01/26/2016 12:51 PM, Eric Blake wrote: > On 01/26/2016 03:38 AM, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> --- >> docs/specs/qbm.md | 118 >> ++ >> 1 file changed, 118 insertions(+) >> create mode 100644 docs/specs/qbm.md >> >> diff

[Qemu-devel] [PATCH 3/3] trace: use addresses instead of offsets in memory tracepoints

2016-02-08 Thread Hollis Blanchard
When memory_region_ops tracepoints are enabled, calculate and record the absolute address being accessed. Otherwise, we only get offsets into the memory region instead of addresses. Signed-off-by: Hollis Blanchard --- memory.c | 44 trace-events |

[Qemu-devel] [PATCH 2/3] trace: split subpage MMIOs into their own trace events.

2016-02-08 Thread Hollis Blanchard
Previously, a single MMIO could trigger the memory_region_ops tracepoint twice: once on its way into subpage ops, then later on its way into the model's ops. Also, the fields previously called "addr" are actually offsets into the memory region. Rename them to "offset" while we're editing the trace

[Qemu-devel] [PATCH 1/3] trace: docs: "simple" backend does support strings

2016-02-08 Thread Hollis Blanchard
The simple tracing backend has supported strings for more than three years (62bab73213ba885426a781eb2741670b9f3cae36). Signed-off-by: Hollis Blanchard --- docs/tracing.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/docs/tracing.txt b/docs/tracing.txt index 3853a6a..f2f553b 100644 ---

[Qemu-devel] [PULL v2 00/13] TCG patch queue

2016-02-08 Thread Richard Henderson
This adjusts the previous pull request with a new patch (6/13) to work around a clang bug that affects -Werror. I'm not resending any of the other patches in this pull request. r~ The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd: ui/cocoa.m: Include qemu/osdep.h (

[Qemu-devel] [PULL v2 06/13] tcg: Work around clang bug wrt enum ranges

2016-02-08 Thread Richard Henderson
A subsequent patch patch will change the type of REG from int to enum TCGReg, which provokes the following bug in clang: https://llvm.org/bugs/show_bug.cgi?id=16154 Signed-off-by: Richard Henderson --- tcg/tcg.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH 6/6] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-02-08 Thread David Gibson
On Mon, Feb 08, 2016 at 04:11:13PM +1100, Alexey Kardashevskiy wrote: > On 02/05/2016 01:13 PM, David Gibson wrote: > >When a Power cpu with 64-bit hash MMU has it's hash page table (HPT) > >pointer updated by a write to the SDR1 register we need to update some > >derived variables. Likewise, when

Re: [Qemu-devel] [PATCH 4/6] pseries: Move hash page table allocation to reset time

2016-02-08 Thread David Gibson
On Mon, Feb 08, 2016 at 03:44:18PM +1100, Alexey Kardashevskiy wrote: > On 02/05/2016 01:13 PM, David Gibson wrote: > >At the moment the size of the hash page table (HPT) is fixed based on the > >maximum memory allowed to the guest. As such, we allocate the table during > >machine construction, an

Re: [Qemu-devel] [PATCH V7 3/9] i2c: Factor our send() and recv() common logic

2016-02-08 Thread Alistair Francis
On Mon, Feb 1, 2016 at 7:43 AM, wrote: > From: Peter Crosthwaite > > Most of the control flow logic between send and recv (error checking > etc) is the same. Factor this out into a common send_recv() API. > This is then usable by clients, where the control logic for send > and receive differs on

Re: [Qemu-devel] [RFC PATCH 01/16] doc: Add QBM format specification

2016-02-08 Thread John Snow
On 01/26/2016 05:38 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > docs/specs/qbm.md | 118 > ++ > 1 file changed, 118 insertions(+) > create mode 100644 docs/specs/qbm.md > > diff --git a/docs/specs/qbm.md b/docs/specs/qbm.md > ne

Re: [Qemu-devel] [PATCH v2 04/10] hw/sd: Add QOM bus which SD cards plug in to

2016-02-08 Thread Alistair Francis
On Mon, Feb 8, 2016 at 3:37 PM, Peter Maydell wrote: > On 8 February 2016 at 23:24, Alistair Francis > wrote: >> This patch doesn't compile and neither does anything after this. I get >> the following errors: >> >> In file included from hw/sd/sd.c:35:0: >> /work/alistai/master-qemu/include/hw/sd/

Re: [Qemu-devel] [PATCH v2 04/10] hw/sd: Add QOM bus which SD cards plug in to

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 23:24, Alistair Francis wrote: > This patch doesn't compile and neither does anything after this. I get > the following errors: > > In file included from hw/sd/sd.c:35:0: > /work/alistai/master-qemu/include/hw/sd/sd.h:81:5: error: unknown type > name ‘DeviceClass’ > Devi

Re: [Qemu-devel] [PATCH v2 04/10] hw/sd: Add QOM bus which SD cards plug in to

2016-02-08 Thread Alistair Francis
On Fri, Jan 22, 2016 at 8:16 AM, Peter Maydell wrote: > Add a QOM bus for SD cards to plug in to. > > Note that since sd_enable() is used only by one board and there > only as part of a broken implementation, we do not provide it in > the SDBus API (but instead add a warning comment about the old

Re: [Qemu-devel] [PULL 00/12] TCG patch queue

2016-02-08 Thread Richard Henderson
On 02/09/2016 07:24 AM, Richard Henderson wrote: On 02/08/2016 10:25 PM, Peter Maydell wrote: Hi. This doesn't compile with clang, I'm afraid: /home/petmay01/linaro/qemu-for-merges/tcg/tcg.c:2048:30: error: comparison of constant 16 with expression of type 'TCGReg' is always true [-Werror,-Wtau

Re: [Qemu-devel] [PATCH] fdc: always compile-check debug prints

2016-02-08 Thread John Snow
On 02/08/2016 06:11 PM, Eric Blake wrote: > On 02/08/2016 03:45 PM, John Snow wrote: >> Coverity noticed that some variables are only used by debug prints, and >> called them unused. Always compile the print statements. >> >> Bonus: Fix a printf I broke. > > Might be nice to mention the commit t

Re: [Qemu-devel] [PATCH] m68k: Build the opcode table only once to avoid multithreading issues

2016-02-08 Thread John Paul Adrian Glaubitz
On 02/04/2016 04:18 PM, John Paul Adrian Glaubitz wrote: > On 02/03/2016 05:11 PM, Eric Blake wrote: >> Weird. Wonder why it doesn't complain on that file? I'm >> guessing that it is due to the #define on the next line. >> Because rearranging things to put the code after the #define >> changes the

Re: [Qemu-devel] [PATCH 1/2] m68k: Fix opcode mask for fbcc instruction

2016-02-08 Thread John Paul Adrian Glaubitz
On 02/03/2016 10:38 AM, Laurent Vivier wrote: > Reviewed-by: Laurent Vivier Any chance to get this merged quickly? -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 295

Re: [Qemu-devel] [PATCH] fdc: always compile-check debug prints

2016-02-08 Thread Eric Blake
On 02/08/2016 03:45 PM, John Snow wrote: > Coverity noticed that some variables are only used by debug prints, and > called them unused. Always compile the print statements. > > Bonus: Fix a printf I broke. Might be nice to mention the commit that broke it. > > Signed-off-by: John Snow > --- >

Re: [Qemu-devel] [PATCH v10] spec: add qcow2 bitmaps extension specification

2016-02-08 Thread John Snow
On 02/05/2016 03:58 AM, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of su

Re: [Qemu-devel] [PATCH v2 02/10] hw/sd/sd.c: QOMify

2016-02-08 Thread Alistair Francis
On Fri, Jan 22, 2016 at 8:16 AM, Peter Maydell wrote: > Turn the SD card into a QOM device. > This conversion only changes the device itself; the various > functions which are effectively methods on the device are not > touched at this point. > > Signed-off-by: Peter Maydell > Reviewed-by: Peter

[Qemu-devel] [PATCH] fdc: always compile-check debug prints

2016-02-08 Thread John Snow
Coverity noticed that some variables are only used by debug prints, and called them unused. Always compile the print statements. Bonus: Fix a printf I broke. Signed-off-by: John Snow --- hw/block/fdc.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/block/

Re: [Qemu-devel] [PATCH 09/16] qemu-thread: introduce QemuLockCnt

2016-02-08 Thread Eric Blake
On 02/08/2016 09:15 AM, Paolo Bonzini wrote: > A QemuLockCnt comprises a counter and a mutex, with primitives > to increment and decrement the counter, and to take and release the > mutex. It can be used to do lock-free visits to a data structure > whenever mutexes would be too heavy-weight and th

Re: [Qemu-devel] [PATCH 04/16] aio: only call aio_poll_internal from iothread

2016-02-08 Thread Eric Blake
On 02/08/2016 09:14 AM, Paolo Bonzini wrote: > aio_poll is not thread safe; it can report progress incorrectly when > called from the main thread. The bug remains latent as long as > all of it is called within aio_context_acquire/aio_context_release, > but this will change soon. > > The details o

[Qemu-devel] [PATCH v2 9/9] i.MX: Add missing descriptions in devices.

2016-02-08 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1 hw/arm/fsl-imx25.c | 1 + hw/arm/fsl-imx31.c | 1 + hw/i2c/imx_i2c.c | 1 + hw/net/imx_fec.c | 1 + 4 files changed, 4 insertions(+) diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c index fb743bf..1fbc317

Re: [Qemu-devel] [PATCHv7 9/9] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2016-02-08 Thread Eric Blake
On 02/08/2016 03:28 AM, Samuel Thibault wrote: > From: Yann Bordenave > > This patch adds parameters to manage some new options in the qemu -net > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in > argument to the qemu command. > Defaults parameters are respecti

[Qemu-devel] [PATCH v2 8/9] i.MX: Add sabrelite i.MX6 emulation.

2016-02-08 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * output a message and exit if RAM size is unsupported. hw/arm/Makefile.objs | 2 +- hw/arm/sabrelite.c | 93 2 files changed, 94 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH v2 7/9] i.MX: Add i.MX6 SOC implementation.

2016-02-08 Thread Jean-Christophe Dubois
For now we only support the following devices: * up to 4 Cortex A9 cores * A9 MPCORE (SCU, GIC, TWD) * 5 i.MX UARTs * 2 EPIT timers * 1 GPT timer * 3 I2C controllers * 7 GPIO controllers * 6 SDHC controllers * 1 CCM device * 1 SRC device * various ROM/RAM areas. Signed-off-by: Jean-Christophe Dubo

[Qemu-devel] [PATCH v2 6/9] i.MX: Add i.MX6 System Reset Controller device.

2016-02-08 Thread Jean-Christophe Dubois
This controller is also present in i.MX5X devices but they are not yet emulated by QEMU. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Change "reset" sematic to mean full power cyvle. hw/misc/Makefile.objs | 1 + hw/misc/imx6_src.c | 353

[Qemu-devel] [PATCH v2 5/9] i.MX: Add i.MX6 CCM and ANALOG device.

2016-02-08 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * move clk computation to uint64_t to avoid overflow * added explanation on _SET, _CLR and _TOG registers * move CCM and ANALOG handling in sub memory regions. hw/misc/Makefile.objs | 1 + hw/misc/imx6_ccm.c | 773 +++

[Qemu-devel] [PATCH v2 2/9] i.MX: Rename CCM NOCLK to CLK_NONE for naming consistency.

2016-02-08 Thread Jean-Christophe Dubois
This way all CCM clock defines/enums are named CLK_XXX Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * Not present on V1 hw/misc/imx25_ccm.c | 2 +- hw/misc/imx31_ccm.c | 2 +- hw/timer/imx_epit.c | 2 +- hw/timer/imx_gpt.c| 10 +- include/hw

[Qemu-devel] [PATCH v2 4/9] i.MX: Add the CLK_IPG_HIGH clock

2016-02-08 Thread Jean-Christophe Dubois
EPIT, GPT and other i.MX timers are using "abstract" clocks among which a CLK_IPG_HIGH clock. On i.MX25 and i.MX31 CLK_IPG and CLK_IPG_HIGH are mapped to the same clock but on other SOC like i.MX6 they are mapped to distinct clocks. This patch add the CLK_IPG_HIGH to prepare for SOC where these 2

[Qemu-devel] [PATCH v2 3/9] i.MX: Remove CCM useless clock computation handling.

2016-02-08 Thread Jean-Christophe Dubois
Most clocks supported by the CCM are useless to the qemu framework. Only clocks related to timers (EPIT, GPT, PWM, WATCHDOG, ...) are usefull to QEMU code. Therefore this patch removes clock computation handling for all clocks but: * CLK_NONE, * CLK_IPG, * CLK_32k Signed-off-by: Jean-Christophe

[Qemu-devel] [PATCH v2 1/9] i.MX: Allow GPT timer to rollover.

2016-02-08 Thread Jean-Christophe Dubois
GPT timer need to rollover when it reaches 0x. It also need to reset to 0 when in "restart mode" and crossing the compare 1 register. Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * None hw/timer/imx_gpt.c | 27 +++ 1 file changed, 15 insertions(

[Qemu-devel] [PATCH v2 0/9] Add i.MX6 (Single/Dual/Quad) support

2016-02-08 Thread Jean-Christophe Dubois
This patch series adds support for the Freescale i.MX6 processor. For now we only support the following devices: * up to 4 Cortex A9 cores * A9 MPCORE (SCU, GIC, TWD) * 5 i.MX UARTs * 2 EPIT timers * 1 GPT timer * 7 GPIO controllers * 6 SDHC controllers * 1 CCM device * 1 SRC device * 3 I2C device

Re: [Qemu-devel] [PATCH] char: fix repeated registration of tcp chardev I/O handlers

2016-02-08 Thread Mark Cave-Ayland
On 08/02/16 13:55, Daniel P. Berrange wrote: > In previous commit: > > commit f2001a7e0555b66d6db25a3ff1801540814045bb > Author: Daniel P. Berrange > Date: Tue Jan 19 11:14:30 2016 + > > char: don't assume telnet initialization will not block > > The code which writes the telne

Re: [Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-08 Thread John Snow
On 02/05/2016 04:24 AM, Fam Zheng wrote: > docker_run: A wrapper for "docker run" (or "sudo -n docker run" if > necessary), which takes care of killing and removing the running > container at SIGINT. > > docker_clean: A tool to tear down all the containers including inactive > ones that are star

Re: [Qemu-devel] Strange monitor/stdout issue on qemu-system-sparc/qemu-system-ppc

2016-02-08 Thread Mark Cave-Ayland
On 08/02/16 09:08, Paolo Bonzini wrote: > On 31/01/2016 16:54, Mark Cave-Ayland wrote: >> Aha! A quick test here shows that the patch fixes the serial port >> appearing on stdout and entering the monitor, but I still see the >> multiple echo problem in the GTK GUI. > > And this should be it; if t

Re: [Qemu-devel] [PATCH v2 17/17] block: remove support for legecy AES qcow/qcow2 encryption

2016-02-08 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > Refuse to use images with the legacy AES-CBC encryption > format in the system emulators. They are still fully > supported in the qemu-img, qemu-io & qemu-nbd tools in > order to allow data to be liberated and for compatibility > with older QEMU v

Re: [Qemu-devel] [PATCH v2 16/17] block: remove all encryption handling APIs

2016-02-08 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > Now that all encryption keys must be provided upfront via > the QCryptoSecret API and associated block driver properties > there is no need for any explicit encryption handling APIs > in the block layer. Encryption can be handled transparently > w

Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 20:51, Eric Blake wrote: > On 02/08/2016 11:49 AM, Peter Maydell wrote: > >> 122 files changed, 122 insertions(+), 202 deletions(-) > > You may want to wait for other maintainers to chime in for files they > care about; but I looked through the patch and nothing jumped out a

Re: [Qemu-devel] [PATCH RFC] external backup api

2016-02-08 Thread John Snow
On 02/06/2016 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > On 05.02.2016 22:48, John Snow wrote: >> >> On 01/22/2016 12:07 PM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all. >>> >>> This is the early begin of the series which aims to add external backup >>> api. This is needed to allow backup

Re: [Qemu-devel] [PATCH v2 14/17] qcow: convert QCow to use QCryptoBlock for encryption

2016-02-08 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > This converts the qcow2 driver to make use of the QCryptoBlock s/qcow2/qcow/ > APIs for encrypting image content. This is only wired up to > permit use of the legacy QCow encryption format. Users who wish > to have the strong LUKS format should

Re: [Qemu-devel] [PATCH 2/2] tests: Clean up includes

2016-02-08 Thread Eric Blake
On 02/08/2016 11:49 AM, Peter Maydell wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Peter Maydell > --- > This deals with every .c file in tests/ e

Re: [Qemu-devel] [PATCH v2 00/10] target-i386 addressing cleanups

2016-02-08 Thread Richard Henderson
On 02/09/2016 04:04 AM, Paolo Bonzini wrote: Applied and sent out as pull request now, thanks! Thanks! r~

Re: [Qemu-devel] [PATCH 1/2] tests/i440fx-test: Don't define ARRAY_SIZE locally

2016-02-08 Thread Eric Blake
On 02/08/2016 11:49 AM, Peter Maydell wrote: > Don't define ARRAY_SIZE locally; instead include osdep.h for it. > > Signed-off-by: Peter Maydell > --- > tests/i440fx-test.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Eric Blake > > diff --git a/tests/i440fx-test.c

Re: [Qemu-devel] [PATCH v2 13/17] qcow: make encrypt_sectors encrypt in place

2016-02-08 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > Instead of requiring separate input/output buffers for > encrypting data, change encrypt_sectors() to assume > use of a single buffer, encrypting in place. One current > caller all uses the same buffer for input/output already > and the other two

Re: [Qemu-devel] [PULL 00/12] TCG patch queue

2016-02-08 Thread Richard Henderson
On 02/08/2016 10:25 PM, Peter Maydell wrote: Hi. This doesn't compile with clang, I'm afraid: /home/petmay01/linaro/qemu-for-merges/tcg/tcg.c:2048:30: error: comparison of constant 16 with expression of type 'TCGReg' is always true [-Werror,-Wtautological-constant-out-of-range-compare]

Re: [Qemu-devel] [PATCH v2 10/17] block: add generic full disk encryption driver

2016-02-08 Thread Eric Blake
On 02/08/2016 09:28 AM, Daniel P. Berrange wrote: >> My vote: do the same as we do for qcow2 or any other format. Make the >> size requested by the user as the size visible to the guest, and a >> fully-allocated image will take more space on the host than what the >> guest is using (that is, a fu

Re: [Qemu-devel] [PULL 48/49] i386: populate floppy drive information in DSDT

2016-02-08 Thread John Snow
On 02/08/2016 08:14 AM, Roman Kagan wrote: > On Fri, Feb 05, 2016 at 07:25:07PM +0100, Igor Mammedov wrote: >> On Thu, 4 Feb 2016 23:54:13 +0200 >> "Michael S. Tsirkin" wrote: >>> -static Aml *build_fdc_device_aml(void) >>> +static Aml *build_fdinfo_aml(int idx, uint8_t type, uint8_t cylinders,

Re: [Qemu-devel] [PATCH] trace: only create simple backend trace files when an event is emitted.

2016-02-08 Thread Alex Bennée
Hollis Blanchard writes: > Previously, trace record files (created by st_set_trace_file_enabled(true)) > were created by the simple backend at initialization time, even if no events > were actually enabled. > > As a consequence, the working directory would become littered with trace-PID > files

Re: [Qemu-devel] sda abort with virtio-scsi

2016-02-08 Thread Jim Minter
Again FWIW: No recurrence of the SCSI abort notices since increasing the timeout, but still getting guest userspace lockups. Guest kernel logs show RCU "detected stalls" messages and triggering NMIs across the CPUs. These consistently indicate CPU 2 sitting in the CFS scheduler via the timer

Re: [Qemu-devel] trace: timestamps, core IDs, and file creation

2016-02-08 Thread Hollis Blanchard
On 02/08/2016 07:30 AM, Stefan Hajnoczi wrote: On Wed, Jan 13, 2016 at 03:13:02PM -0800, Hollis Blanchard wrote: The event timestamps are host time (get_clock()). I'm correlating qemu events with other logs (using icount), so host time is unhelpful. Could we use cpu_get_clock() instead? (Trace e

Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@

2016-02-08 Thread Paolo Bonzini
On 08/02/2016 20:15, Peter Maydell wrote: > That difference from the kernel script's behaviour is deliberate, because > the attempt to list recent contributors tends to list a whole lot of > irrelevant people. So if there's a documented maintainer we prefer to > just list them, and not all the ra

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 1/2] trace: Add support for vCPU pointers in trace events

2016-02-08 Thread Alex Bennée
Lluís Vilanova writes: > The tracing infrastructure later needs to differentiate between regular > pointers and pointers to vCPUs. > > Also changes all targets to use the new 'TCGv_cpu' type instead of the > generic 'TCGv_ptr'. As of now, the change is merely cosmetic ('TCGv_cpu' > translates in

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 1/2] trace: Add support for vCPU pointers in trace events

2016-02-08 Thread Alex Bennée
Lluís Vilanova writes: > The tracing infrastructure later needs to differentiate between regular > pointers and pointers to vCPUs. > > Also changes all targets to use the new 'TCGv_cpu' type instead of the > generic 'TCGv_ptr'. As of now, the change is merely cosmetic ('TCGv_cpu' > translates in

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 09:23 PM, Laszlo Ersek wrote: On 02/08/16 19:59, Marcel Apfelbaum wrote: On 02/08/2016 06:47 PM, Laszlo Ersek wrote: On 02/08/16 13:27, Marcel Apfelbaum wrote: On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: Also we can use current machine

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Laszlo Ersek
On 02/08/16 19:59, Marcel Apfelbaum wrote: > On 02/08/2016 06:47 PM, Laszlo Ersek wrote: >> On 02/08/16 13:27, Marcel Apfelbaum wrote: >>> On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: > Also we can use current machine properties instead of querying

Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 19:04, Stephen Warren wrote: > qemu's get_maintainers.pl must be doing something different to the Linux > kernel's version then, since IIRC the Linux kernel version always prints out > recent contributors irrespective of whether maintainers were found, rather > than as an alt

Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@

2016-02-08 Thread Stephen Warren
On 02/08/2016 11:52 AM, John Snow wrote: On 02/08/2016 04:05 AM, Markus Armbruster wrote: Stephen Warren writes: Add an entry to MAINTAINERS that matches every patch, and requests the user send patches to qemu-devel@nongnu.org. It's not 100% obvious to project newcomers that all patches sh

Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts

2016-02-08 Thread Marcel Apfelbaum
On 02/08/2016 06:47 PM, Laszlo Ersek wrote: On 02/08/16 13:27, Marcel Apfelbaum wrote: On 02/08/2016 02:22 PM, Laszlo Ersek wrote: On 02/08/16 12:45, Marcel Apfelbaum wrote: Also we can use current machine properties instead of querying machine's opts. Why? :) For me at least, you'll have to

[Qemu-devel] [PATCH] trace: only create simple backend trace files when an event is emitted.

2016-02-08 Thread Hollis Blanchard
Previously, trace record files (created by st_set_trace_file_enabled(true)) were created by the simple backend at initialization time, even if no events were actually enabled. As a consequence, the working directory would become littered with trace-PID files just by enabling the simple backend at

[Qemu-devel] [PATCH 1/2] tests/i440fx-test: Don't define ARRAY_SIZE locally

2016-02-08 Thread Peter Maydell
Don't define ARRAY_SIZE locally; instead include osdep.h for it. Signed-off-by: Peter Maydell --- tests/i440fx-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/i440fx-test.c b/tests/i440fx-test.c index 7fa1709..0665caf 100644 --- a/tests/i440fx-test.c +++ b/test

[Qemu-devel] [PATCH 0/2] tests: clean includes

2016-02-08 Thread Peter Maydell
This patchset runs clean-includes on all the .c files in tests/, except those in tests/tcg, which I think are all intended as standalone test programs for the guest. The first patch handles i440fx-test.c manually since otherwise compilation would fail due to the redefinition of ARRAY_SIZE. The sec

Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@

2016-02-08 Thread John Snow
On 02/08/2016 04:05 AM, Markus Armbruster wrote: > Stephen Warren writes: > >> Add an entry to MAINTAINERS that matches every patch, and requests the >> user send patches to qemu-devel@nongnu.org. >> >> It's not 100% obvious to project newcomers that all patches should be sent >> there; checkpa

[Qemu-devel] [PATCH 2/2] tests: Clean up includes

2016-02-08 Thread Peter Maydell
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Peter Maydell --- This deals with every .c file in tests/ except those in tests/tcg which I think are all standalone pro

Re: [Qemu-devel] [PULL 05/13] trace: split trace_init_file out of trace_init_backends

2016-02-08 Thread Alex Bennée
Stefan Hajnoczi writes: > From: Paolo Bonzini > > This is cleaner, and improves error reporting with -daemonize. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Denis V. Lunev > Acked-by: Christian Borntraeger > Message-id: 1452174932-28657-4-git-send-email-...@openvz.org > Signed-off-by:

Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 18:25, Markus Armbruster wrote: > With "make check" fixed: > Reviewed-by: Markus Armbruster > > I'm happy to take it through my tree when it's ready (tell me then), but > it might be easier to take it along whatever fixes "make check". OK; I'm currently doing the testing bi

Re: [Qemu-devel] trace: timestamps, core IDs, and file creation

2016-02-08 Thread Alex Bennée
Alex Bennée writes: > Hollis Blanchard writes: > >> Hi Stefan, I've been starting to use qemu tracing and found it quite >> useful. I have a couple comments about the trace events in general: >> > >> Right now, the simple tracepoint backend creates a trace file even when >> no events are activ

Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Markus Armbruster
Peter Maydell writes: > On 8 February 2016 at 17:39, Markus Armbruster wrote: >> Eric Blake writes: >> >>> As a followup to commit cbf2115, clean up the includes in files >>> generated by QAPI so that osdep.h is included first in .c files, >>> and headers which it implies are not included manua

Re: [Qemu-devel] [PATCH v2 12/17] qcow2: convert QCow2 to use QCryptoBlock for encryption

2016-02-08 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > This converts the qcow2 driver to make use of the QCryptoBlock > APIs for encrypting image content. As well as continued support > for the legacy QCow2 encryption format, the appealing benefit > is that it enables support for the LUKS format insid

Re: [Qemu-devel] trace: timestamps, core IDs, and file creation

2016-02-08 Thread Alex Bennée
Hollis Blanchard writes: > Hi Stefan, I've been starting to use qemu tracing and found it quite > useful. I have a couple comments about the trace events in general: > > Right now, the simple tracepoint backend creates a trace file even when > no events are active and no -trace options are pres

Re: [Qemu-devel] [PATCH] docs/memory.txt: Improve list of different memory regions

2016-02-08 Thread Paolo Bonzini
On 28/01/2016 19:54, Peter Maydell wrote: > Improve the part of the memory region documentation which describes > the various different kinds of memory region: > * add the missing types ROM, IOMMU and reservation > * mention the functions used to initialize each type, as a hint >for finding t

Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Peter Maydell
On 8 February 2016 at 17:39, Markus Armbruster wrote: > Eric Blake writes: > >> As a followup to commit cbf2115, clean up the includes in files >> generated by QAPI so that osdep.h is included first in .c files, >> and headers which it implies are not included manually. This >> patch is done man

Re: [Qemu-devel] [PATCH] qapi: Clean up includes in generated files

2016-02-08 Thread Markus Armbruster
Eric Blake writes: > As a followup to commit cbf2115, clean up the includes in files > generated by QAPI so that osdep.h is included first in .c files, > and headers which it implies are not included manually. This > patch is done manually, since Coccinelle (and therefore > scripts/clean-include

[Qemu-devel] [PULL 25/28] target-i386: Deconstruct the cpu_T array

2016-02-08 Thread Paolo Bonzini
From: Richard Henderson All references to cpu_T are done with a constant index. It aids readability to decompose the array into two scalar variables. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <1436426122-12276-11-git-send-email-...@twiddle.net> Signed-off-by: Pao

  1   2   3   >