Re: [Qemu-devel] drive-backup

2016-02-24 Thread Stefan Priebe - Profihost AG
Am 22.02.2016 um 23:08 schrieb John Snow: > > > On 02/22/2016 03:21 PM, Stefan Priebe wrote: >> Hello, >> >> is there any chance or hack to work with a bigger cluster size for the >> drive backup job? >> >> See: >> http://git.qemu.org/?p=qemu.git;a=blob;f=block/backup.c;h=16105d40b193be9bb403460

Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list()

2016-02-24 Thread Vladimir Sementsov-Ogievskiy
Stop! Hey, stubs/pc_dimm.c disappeared from this patch: === from [PATCH v7 0/5] don't use NVDIMM for balooning/[PATCH 3/5] pc-dimm: add pc_dimm_build_list() === diff --git a/stubs/pc_dimm.c b/stubs/pc_dimm.c new file mode 100644 index 000..5312f50 --- /dev/null +++

Re: [Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

2016-02-24 Thread Denis V. Lunev
On 02/24/2016 06:43 PM, Eric Blake wrote: On 02/24/2016 07:31 AM, Michael S. Tsirkin wrote: One of the benefits is forward compatibility, so that counters that have graduated into supported ones and have got their own number and name, can be made to work with qemu that doesn't yet recognize them

[Qemu-devel] [PATCH v6 2/3] qmp event: Refactor QUORUM_REPORT_BAD

2016-02-24 Thread Changlong Xie
Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible with it. Cc: Dr. David Alan Gilbert Cc: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/quorum.c | 17 - docs/qmp-events.txt | 11 ++- qapi/block.json | 16 ++

[Qemu-devel] [PATCH v6 3/3] quorum: modify vote rules for flush operation

2016-02-24 Thread Changlong Xie
Keep flush interface the same logic as quorum read/write, Otherwise in following scenario, we'll encounter unexpected errors. Quorum has two children(A, B). A do flush sucessfully, but B flush failed. This cause the filesystem of guest become read-only with following errors: end_request: I/O erro

[Qemu-devel] [PATCH v6 0/3] modify vote rules for flush operation

2016-02-24 Thread Changlong Xie
ChangLog: v6: 1. Make "type" mandatory for [PATCH 2/3] v5: 1. Fix invalid node name in docs/qmp-events.txt 2. Address comments from Eric, drop QUORUM_FLUSH_ERROR. Instead of reworking QUORUM_REPORT_BAD to make it compatible with quorum read/write/flush operations v4: 1. Introduce QUORUM_FLUSH_ERRO

[Qemu-devel] [PATCH v6 1/3] docs: fix invalid node name in qmp event

2016-02-24 Thread Changlong Xie
Cc: Dr. David Alan Gilbert Cc: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Reviewed-by: Alberto Garcia --- docs/qmp-events.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/qmp-events.txt b/docs/qmp-events.txt index b6e8937..afb5e20 100644

Re: [Qemu-devel] [PATCH qemu] migration/vmstate: document VMStateFlags

2016-02-24 Thread Amit Shah
On (Thu) 21 Jan 2016 [21:39:27], Sascha Silbe wrote: > The VMState API is rather sparsely documented. Start by describing the > meaning of all VMStateFlags. > > Signed-off-by: Sascha Silbe > --- > Since I had to dive into the code for debugging the migration breakage > anyway, I figured I could j

Re: [Qemu-devel] [Qemu-ppc] Migrating decrementer

2016-02-24 Thread Mark Cave-Ayland
On 25/02/16 04:33, Mark Cave-Ayland wrote: > cpu_start/resume(): > cpu->tb_env->tb_offset = > qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) * tb_env->tb_freq + > cpu->tb_env->tb_offset - > qemu_clock_get_ns(QEMU_CLOCK_HOST) Actually just realised this is slightly wrong and

Re: [Qemu-devel] Migrating decrementer

2016-02-24 Thread Mark Cave-Ayland
On 24/02/16 12:31, Juan Quintela wrote: >> I don't really understand the question. Migration has no equivalent >> in real hardware, so there's no "real" behaviour to mimic. If we >> freeze the TB during migration, then the guest's clock will get out of >> sync with wall clock time, and in a produ

[Qemu-devel] [PATCH] filter/fiter-buffer: Add a 'status' property for filter object

2016-02-24 Thread zhanghailiang
With this property, users can control if this filter is 'enable' or 'disable'. The default behavior for filter is enabled. For buffer filter, we need to release all the buffered packets while disabled it. Here we use the 'disable' callback of NetFilterClass to realize this capability. We register

[Qemu-devel] [PATCH v3 1/2] qemu-file: Fix qemu_put_compression_data flaw

2016-02-24 Thread Liang Li
Current qemu_put_compression_data can only work with no writable QEMUFile, and can't work with the writable QEMUFile. But it does not provide any measure to prevent users from using it with a writable QEMUFile. We should fix this flaw to make it works with writable QEMUFile. Suggested-by: Juan Qu

[Qemu-devel] [PATCH v3 0/2] Fix flaw of qemu_put_compression_data

2016-02-24 Thread Liang Li
The implementation of qemu_put_compression_data only consider the case QEMUFile is writable, it can't work with a writable QEMUFile and does not provide any measure to prevent users from using it with a writable QEMUFile. For safety, it should be improved to avoid some issues. ram_save_compressed_

[Qemu-devel] [PATCH v3 2/2] migration: refine ram_save_compressed_page

2016-02-24 Thread Liang Li
Use qemu_put_compression_data to do the compression directly instead of using do_compress_ram_page, avoid some data copy. very small improvement, at the same time, add code to check if the compression is successful. Signed-off-by: Liang Li --- migration/ram.c | 28 +---

[Qemu-devel] [PULL 2/5] hw/ppc/spapr: Implement the h_page_init hypercall

2016-02-24 Thread David Gibson
From: Thomas Huth This hypercall either initializes a page with zeros, or copies another page. According to LoPAPR, the i-cache of the page should also be flushed if using H_ICACHE_INVALIDATE or H_ICACHE_SYNCHRONIZE, and the d-cache should be synchronized to the RAM if the H_ICACHE_SYNCHRONIZE fl

[Qemu-devel] [PULL 3/5] spapr: initialize local Error pointer

2016-02-24 Thread David Gibson
From: Greg Kurz This fixes a crash in the target QEMU during migration. Broken in commit c5f54f3. Signed-off-by: Greg Kurz Reviewed-by: Markus Armbruster [reworded commit message] Signed-off-by: David Gibson --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[Qemu-devel] [PULL 4/5] ppc/kvm: Use error_report() instead of cpu_abort() for user-triggerable errors

2016-02-24 Thread David Gibson
From: Thomas Huth Setting the KVM_CAP_PPC_PAPR capability can fail if either the KVM kernel module does not support it, or if the specified vCPU type is not a 64-bit Book3-S CPU type. For example, the user can trigger it easily with "-M pseries -cpu G2leLS" when using the kvm-pr kernel module. So

[Qemu-devel] [PULL 0/5] ppc-for-2.6 queue 20160225

2016-02-24 Thread David Gibson
The following changes since commit 1b1624092d1f1f746adea6e1237a07f6788c2e3d: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20160223-1' into staging (2016-02-23 16:14:17 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160225

[Qemu-devel] [PULL 5/5] ppc/kvm: Tell the user what might be wrong when using bad CPU types with kvm-hv

2016-02-24 Thread David Gibson
From: Thomas Huth Using a CPU type that does not match the host is not possible when using the kvm-hv kernel module - the PVR is checked in the kernel function kvm_arch_vcpu_ioctl_set_sregs_hv() and rejected with -EINVAL if it does not match the host. However, when the user tries to specify a non

Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD

2016-02-24 Thread Changlong Xie
On 02/24/2016 08:35 PM, Alberto Garcia wrote: On Wed 24 Feb 2016 11:11:54 AM CET, Changlong Xie wrote: -static void quorum_report_bad(QuorumAIOCB *acb, char *node_name, int ret) +static void quorum_report_bad(QuorumOpType type, QuorumAIOCB *acb, + char *node_name, in

Re: [Qemu-devel] [GIT PULL] pseries: Update SLOF firmware image to 20160223

2016-02-24 Thread David Gibson
On Tue, Feb 23, 2016 at 07:25:13PM +1100, Alexey Kardashevskiy wrote: > > This is expected to go via the powerpc tree at > git://github.com/dgibson/qemu.git > > > The following changes since commit 8eb779e4223a18db9838a49ece1bc72cfdfb7761: > > Merge remote-tracking branch 'remotes/kevin/tags

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-24 Thread David Gibson
On Wed, Feb 24, 2016 at 03:17:54PM +0100, Igor Mammedov wrote: > On Wed, 24 Feb 2016 12:54:17 +1100 > David Gibson wrote: > > > On Tue, Feb 23, 2016 at 10:46:45AM +0100, Igor Mammedov wrote: > > > On Mon, 22 Feb 2016 13:54:32 +1100 > > > David Gibson wrote: > > > > > > > On Fri, Feb 19, 2016

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-24 Thread David Gibson
On Wed, Feb 24, 2016 at 12:03:41PM +0100, Igor Mammedov wrote: > On Wed, 24 Feb 2016 21:51:19 +1100 > David Gibson wrote: > > > On Wed, Feb 24, 2016 at 09:42:10AM +0100, Markus Armbruster wrote: > > > David Gibson writes: > > > > > > > On Mon, Feb 22, 2016 at 10:05:54AM +0100, Markus Armbrust

Re: [Qemu-devel] [RFC] QMP: add query-hotpluggable-cpus

2016-02-24 Thread David Gibson
On Wed, Feb 24, 2016 at 03:42:18PM +0100, Igor Mammedov wrote: > On Tue, 23 Feb 2016 18:26:20 -0300 > Eduardo Habkost wrote: > > > On Tue, Feb 23, 2016 at 10:46:45AM +0100, Igor Mammedov wrote: > > > On Mon, 22 Feb 2016 13:54:32 +1100 > > > David Gibson wrote: > > [...] > > > > This is why Edu

Re: [Qemu-devel] [PATCH RESEND v2 1/2] qemu-file: Fix qemu_put_compression_data flaw

2016-02-24 Thread Li, Liang Z
> Nice Template answer without insntantiate the content O:-) > :-), forgot to remove it. > > > > Liang > > > > > >> -Original Message- > >> From: qemu-devel-bounces+liang.z.li=intel@nongnu.org > >> [mailto:qemu- > >> devel-bounces+liang.z.li=intel@nongnu.org] On Behalf Of Jua

Re: [Qemu-devel] [PATCH v3] qga: Support enum names in guest-file-seek

2016-02-24 Thread Michael Roth
Quoting Eric Blake (2016-02-09 15:27:16) > Magic constants are a pain to use, especially when we run the > risk that our choice of '1' for QGA_SEEK_CUR might differ from > the host or guest's choice of SEEK_CUR. Better is to use an > enum value, via a qapi alternate type for back-compatibility. >

Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue

2016-02-24 Thread Michael Roth
Quoting Leonid Bloch (2016-01-11 03:12:41) > With automatically generated GUID, on minor version changes, an error > occurred, stating that there is a problem with the installer. > Now, a notification is shown, warning the user that another version of > this product is already installed, and that c

Re: [Qemu-devel] [PATCH] qga: implement the guest-set-vcpus for windows

2016-02-24 Thread Michael Roth
Quoting Gal Hammer (2015-11-02 08:49:48) > Signed-off-by: Gal Hammer Thanks, applied to qga tree with minor fix-ups: https://github.com/mdroth/qemu/commits/qga > --- > qga/commands-win32.c | 66 > ++-- > 1 file changed, 64 insertions(+), 2 del

Re: [Qemu-devel] [PATCH 0/5] qga: win32 guest-set-user-password improvements

2016-02-24 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2016-02-17 10:47:50) > From: Marc-André Lureau > > Hi, > > Laszlo Ersek pointed out a few worthy improvements to the win32 > guest-set-user-password command. > > Marc-André Lureau (5): > qga: use more idiomatic qemu-style eol operators > qga: use size_t

Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD

2016-02-24 Thread Changlong Xie
On 02/25/2016 09:12 AM, Eric Blake wrote: On 02/24/2016 05:50 PM, Wen Congyang wrote: +- "type": Quorum operation type (json-string, optional) I don't think 'type' needs to be optional, after all. Just always output it. If we output read/write type, old libvirt will ignore the rea

Re: [Qemu-devel] [PATCH v4 0/2] move qcow2_invalidate_cache() out of coroutine context

2016-02-24 Thread Fam Zheng
On Wed, 02/24 11:53, Denis V. Lunev wrote: > There is a possibility to hit an assert in qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The

Re: [Qemu-devel] [PATCH] qga: fix w32 breakage due to missing osdep.h includes

2016-02-24 Thread Eric Blake
On 02/24/2016 06:01 PM, Michael Roth wrote: > requester.h relied on qemu/compiler.h definitions to > handle GCC_FMT_ATTR() stub, but this include was removed as part > of scripted clean-ups via 30456d5: > > all: Clean up includes > > under the assumption that all C files would have included it

Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD

2016-02-24 Thread Eric Blake
On 02/24/2016 05:50 PM, Wen Congyang wrote: >>> +- "type": Quorum operation type (json-string, optional) >> >> I don't think 'type' needs to be optional, after all. Just always >> output it. > > If we output read/write type, old libvirt will ignore the read/write error > events? The Q

[Qemu-devel] [PATCH] qga: fix w32 breakage due to missing osdep.h includes

2016-02-24 Thread Michael Roth
requester.h relied on qemu/compiler.h definitions to handle GCC_FMT_ATTR() stub, but this include was removed as part of scripted clean-ups via 30456d5: all: Clean up includes under the assumption that all C files would have included it via qemu/osdep.h at that point. requester.cpp was likely m

Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD

2016-02-24 Thread Wen Congyang
On 02/25/2016 12:59 AM, Eric Blake wrote: > On 02/24/2016 03:11 AM, Changlong Xie wrote: >> Introduce QuorumOpType, and make QUORUM_REPORT_BAD compatible >> with it. >> >> Cc: Dr. David Alan Gilbert >> Cc: Wen Congyang >> Signed-off-by: Wen Congyang >> Signed-off-by: Changlong Xie >> --- > >>

[Qemu-devel] [PATCH v2] replace fixed str limit by g_strdup_printf

2016-02-24 Thread Neo Jia
A trivial change to remove string limit by using g_strdup_printf Tested-by: Neo Jia Signed-off-by: Neo Jia Signed-off-by: Kirti Wankhede --- hw/vfio/pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 30eb945a4fc1..d091d8cf0e6e 100

Re: [Qemu-devel] Migrating decrementer

2016-02-24 Thread David Gibson
On Wed, Feb 24, 2016 at 01:31:05PM +0100, Juan Quintela wrote: > David Gibson wrote: > > On Tue, Feb 23, 2016 at 09:27:09PM +, Mark Cave-Ayland wrote: > >> On 03/02/16 04:59, David Gibson wrote: > >> > >> >> Going back to your earlier email you suggested that the host timebase is > >> >> alwa

Re: [Qemu-devel] PCI Passthrough KVM with vfio-pci giving EINVAL on PCI Probe

2016-02-24 Thread Nicholas Andre
No, I was under the impression that since they were in the IOMMU group that they must be attached together. I will try it without (not sure if the driver for some reason requires both to be present on the guest system; I'm not particularly savvy with PCI bus programming). On Wed, Feb 24, 2016 at 5

Re: [Qemu-devel] [PATCH v2 0/6] external backup api

2016-02-24 Thread John Snow
On 02/19/2016 03:51 AM, Markus Armbruster wrote: > Fam Zheng writes: > >> On Thu, 02/18 16:41, Stefan Hajnoczi wrote: >>> On Thu, Feb 18, 2016 at 12:11:14PM +, Daniel P. Berrange wrote: On Wed, Feb 17, 2016 at 08:47:11PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 16.02.2

[Qemu-devel] [PATCH v3 0/2] sdhci: pending insert quirk for raspberry pi

2016-02-24 Thread Andrew Baumann
This is a small series to correctly implement a quirk modelling the behaviour of the card insert interrupt bit on Raspberry Pi, and on which Windows' UEFI loader sadly depends. This should be the last change required to support Windows on Pi2, outside of adding devices and enabling the quirk, whic

Re: [Qemu-devel] [PATCH v8 3/4] fdc: add function to determine drive chs limits

2016-02-24 Thread John Snow
On 02/18/2016 05:01 AM, Michael S. Tsirkin wrote: > On Thu, Feb 18, 2016 at 12:50:51PM +0300, Roman Kagan wrote: >> On Wed, Feb 17, 2016 at 10:15:32PM +0200, Michael S. Tsirkin wrote: >>> On Wed, Feb 17, 2016 at 09:25:32PM +0300, Roman Kagan wrote: When populating ACPI objects for floppy dri

[Qemu-devel] [PATCH v3 1/2] sdhci: Revert "add optional quirk property to disable card insertion/removal interrupts"

2016-02-24 Thread Andrew Baumann
This reverts commit 723697551a7e926abe7d3c7f2966012b8075143d. This change was poorly tested on my part. It squelched card insertion interrupts on reset, but that was not necessary because sdhci_reset() clears all the registers (via the call to memset), so the subsequent sdhci_insert_eject_cb() cal

[Qemu-devel] [PATCH v3 2/2] sdhci: add quirk property for card insert interrupt status on Raspberry Pi

2016-02-24 Thread Andrew Baumann
This quirk is a workaround for the following hardware behaviour, on which UEFI (specifically, the bootloader for Windows on Pi2) depends: 1. at boot with an SD card present, the interrupt status/enable registers are initially zero 2. upon enabling it in the interrupt enable register, the card i

Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs

2016-02-24 Thread Peter Maydell
On 24 February 2016 at 18:58, Thomas Huth wrote: > On 23.02.2016 15:18, Peter Maydell wrote: >> After automatic cleanup to remove unnecessary #includes of headers that >> osdep.h provides, slirp.h has a few now unnecessary #ifdef/#endif pairs; >> remove them. >> >> Signed-off-by: Peter Maydell >>

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-24 Thread Wei Huang
On 02/20/2016 04:53 AM, Shannon Zhao wrote: > Hi Wei, > > On 2016/2/10 6:59, Wei Huang wrote: >> >> On 02/04/2016 12:51 AM, Shannon Zhao wrote: >>> >>> >>> On 2016/2/4 14:10, Wei Huang wrote: On 02/03/2016 07:44 PM, Shannon Zhao wrote: >> >> >> I reversed the order of edge pullin

Re: [Qemu-devel] PCI Passthrough KVM with vfio-pci giving EINVAL on PCI Probe

2016-02-24 Thread Alex Williamson
On Wed, 24 Feb 2016 20:04:08 + Nicholas Andre wrote: > I am attempting to attach PCIe devices in passthrough to my KVM domain. I > have two devices in one IOMMU group (#28): > > 03:00.0 PCI bridge: Texas Instruments XIO2001 PCI Express-to-PCI Bridge > 04:00.0 Multimedia audio controller: Tex

[Qemu-devel] [PATCH] raspi: fix SD card with recent sdhci changes

2016-02-24 Thread Andrew Baumann
Recent changes to sdhci broke SD on raspi. This change mirrors the logic to create the SD card device at the board level. Signed-off-by: Andrew Baumann --- The relevant change to other boards was: https://github.com/qemu/qemu/commit/eb4f566bbbe195b2475e8fa5d9ed29ca56a18b02 hw/arm/bcm2835_periph

Re: [Qemu-devel] [Bug 1548170] [NEW] qemu-kvm-spice spice server locks up when large user image is set

2016-02-24 Thread John Snow
On 02/21/2016 11:06 PM, Christopher Snowhill wrote: > Public bug reported: > > QEMU emulator version 2.0.0 (Debian 2.0.0+dfsg-2ubuntu1.22), Copyright > (c) 2003-2008 Fabrice Bellard > > I have QEMU kvm spice installed, running a Windows 10 1511, freshly > installed this morning, using VirtIO ro

Re: [Qemu-devel] [PATCH 3/4] block/vpc: give option to force the current_size field in .bdrv_create

2016-02-24 Thread Jeff Cody
On Wed, Feb 24, 2016 at 08:28:20PM +0100, Peter Lieven wrote: > Am 24.02.2016 um 14:40 schrieb Jeff Cody: > > On Wed, Feb 24, 2016 at 02:07:18PM +0100, Kevin Wolf wrote: > >> Am 24.02.2016 um 13:44 hat Peter Lieven geschrieben: > >>> if the size is forced I would set the chs values to max. this way

[Qemu-devel] [Bug 1516446] Re: Migration always causes guest freeze in one direction.

2016-02-24 Thread Magnus Boden
Is this the correct place to file qemu bug reports? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1516446 Title: Migration always causes guest freeze in one direction. Status in QEMU: New Bug d

[Qemu-devel] [PULL 22/23] q35: Remove unused q35-acpi-dsdt.aml file

2016-02-24 Thread Michael S. Tsirkin
From: Eduardo Habkost The file was used only by older machine-types, and it is not needed anymore. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Reviewed-by: Markus Armbruster Reviewed-by: Igor Mammedov --- Makef

[Qemu-devel] [PULL 19/23] q35: Remove old machine versions

2016-02-24 Thread Michael S. Tsirkin
From: Eduardo Habkost Migration with q35 was not possible before commit 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates an ich9-ahci device, that was marked as unmigratable. So all q35 machine classes before pc-q35-2.4 were not migratable, so there's no point in keep

[Qemu-devel] [PULL 20/23] machine: Remove no_tco field

2016-02-24 Thread Michael S. Tsirkin
From: Eduardo Habkost The field is always set to zero, so it is not necessary anymore. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Reviewed-by: Markus Armbruster Reviewed-by: Igor Mammedov --- include/hw/boards

[Qemu-devel] [PULL 08/23] pci core: function pci_host_bus_register() cleanup

2016-02-24 Thread Michael S. Tsirkin
From: Cao jin remove unused param, and rename the other to a meaningful one. Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Eduardo Habkost --- hw/pci/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pc

[Qemu-devel] [PULL 09/23] pci core: function pci_bus_init() cleanup

2016-02-24 Thread Michael S. Tsirkin
From: Cao jin remove unused param Signed-off-by: Cao jin Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Eduardo Habkost --- hw/pci/pci.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index b071361..e676

[Qemu-devel] [PULL 21/23] ich9: Remove enable_tco arguments from init functions

2016-02-24 Thread Michael S. Tsirkin
From: Eduardo Habkost The enable_tco arguments are always true, so they are not needed anymore. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Reviewed-by: Markus Armbruster Reviewed-by: Igor Mammedov --- include/

[Qemu-devel] [PULL 18/23] tests/vhost-user-bridge: fix build on 32 bit systems

2016-02-24 Thread Michael S. Tsirkin
Mainly casts between void * and uint64_t, and wrong format for size_t. Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-bridge.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index f2b6c67..0779ba2 1

[Qemu-devel] [PULL 15/23] virtio-blk: do not use vring in dataplane

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Fam Zheng Acked-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.h | 1 + include/hw/virtio/virtio-blk.h | 3 -- hw/block/dataplane/virtio-blk.c | 112 ++

[Qemu-devel] [PULL 17/23] vring: remove

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Fam Zheng Acked-by: Stefan Hajnoczi --- include/hw/virtio/dataplane/vring-accessors.h | 75 include/hw/virtio/dataplane/vring.h | 51 --- hw/virti

[Qemu-devel] [PULL 16/23] virtio-scsi: do not use vring in dataplane

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Stefan Hajnoczi --- include/hw/virtio/virtio-scsi.h | 21 + hw/scsi/virtio-scsi-dataplane.c | 196 +--- hw/scsi/virtio-scsi.c

[Qemu-devel] [PULL 23/23] q35: No need to check gigabyte_align

2016-02-24 Thread Michael S. Tsirkin
From: Eduardo Habkost gigabyte_align is always true on q35, so we don't need the !gigabyte_align compat code anymore. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek Reviewed-by: Markus Armbruster Reviewed-by: Igor M

[Qemu-devel] [PULL 14/23] virtio-blk: fix "disabled data plane" mode

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini In disabled mode, virtio-blk dataplane seems to be enabled, but flow actually goes through the normal virtio path. This patch simplifies a bit the handling of disabled mode. In disabled mode, virtio_blk_handle_output might be called even if s->dataplane is not NULL. This is

[Qemu-devel] [PULL 10/23] block-migration: acquire AioContext as necessary

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini This is needed because dataplane will run during block migration as well. The block device migration code is quite liberal in taking the iothread mutex. For simplicity, keep it the same way, even though one could actually choose between the BQL (for regular BlockDriverStates

[Qemu-devel] [PULL 12/23] virtio: add AioContext-specific function for host notifiers

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini This is used to register ioeventfd with a dataplane thread. Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Fam Zheng Acked-by: Stefan Hajnoczi --- include/hw/virtio/virtio.h | 2 ++ hw/virtio/virtio.c

[Qemu-devel] [PULL 13/23] virtio: export vring_notify as virtio_should_notify

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini Virtio dataplane needs to trigger the irq manually through the guest notifier. Export virtio_should_notify so that it can be used around event_notifier_set. Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Cornelia H

[Qemu-devel] [PULL 11/23] vring: make vring_enable_notification return void

2016-02-24 Thread Michael S. Tsirkin
From: Paolo Bonzini Make the API more similar to the regular virtqueue API. This will help when modifying the code to not use vring.c anymore. Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Acked-by: Cornelia Huck Reviewed-by: Fam Zheng Acked

[Qemu-devel] [PULL 01/23] bios-linker-loader: document+validate input

2016-02-24 Thread Michael S. Tsirkin
While guest/host ABI is documented in hw/acpi/bios-linker-loader.c, the API was left undocumented. This adds documentation for all API functions. Additionally, input is validated to make sure all pointers fall within range of provided files. To allow this validation for checksum commands, bios_l

[Qemu-devel] [PULL 07/23] balloon: Use only 'pc-dimm' type dimm for ballooning

2016-02-24 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy For now there are only two dimm's: pc-dimm and nvdimm. This patch is actually needed to disable ballooning on nvdimm. But, to avoid future bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if someone adds new dimm which should be balloon-able, then

[Qemu-devel] [PULL 02/23] vhost-user: don't merge regions with different fds

2016-02-24 Thread Michael S. Tsirkin
vhost currently merges regions with contiguious virtual and physical addresses. This breaks for vhost-user since that also needs fds to match. Add a vhost_ops entry to compare the fds for vhost-user only. Cc: qemu-sta...@nongnu.org Cc: Victor Kaplansky Signed-off-by: Michael S. Tsirkin --- in

[Qemu-devel] [PULL 06/23] virtio-balloon: rewrite get_current_ram_size()

2016-02-24 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy Use pc_dimm_built_list() instead of qmp_pc_dimm_device_list() Actually, Qapi is not related to this internal helper. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-balloon.

[Qemu-devel] [PULL 04/23] pc-dimm: rename pc_dimm_built_list()

2016-02-24 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy s/pc_dimm_built_list/pc_dimm_build_list_sorted - need for add pc_dimm_build_list (not sorted) in the next patch - fix typo (built -> build) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by

[Qemu-devel] [PULL 00/23] vhost, virtio, pci, pc

2016-02-24 Thread Michael S. Tsirkin
The following changes since commit 8eb779e4223a18db9838a49ece1bc72cfdfb7761: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-02-22 16:55:41 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

[Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list()

2016-02-24 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy Like pc_dimm_build_list_sorted but not sorted - for cases where sorting is not necessary. Add stubbed version too - for targets without CONFIG_MEM_HOTPLUG. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. T

[Qemu-devel] [PULL 03/23] move get_current_ram_size to virtio-balloon.c

2016-02-24 Thread Michael S. Tsirkin
From: Vladimir Sementsov-Ogievskiy get_current_ram_size() is used only in virtio-balloon.c This patch moves it into virtio-balloon and make it static, to allow some balloon-specific tuning. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Eric Blake Revie

[Qemu-devel] ivshmem migration restrictions and bugs

2016-02-24 Thread Markus Armbruster
TL;DR: I recommend to stay away from migration when using chardev=... ivshmem migration is messed up in several entertaining ways. = General lossage = G1. Migrating more than one peer doesn't work, but that's a (badly) documented restriction, not a bug (see documentation of property "rol

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/intc: fix failure return for xics_alloc_block()

2016-02-24 Thread Greg Kurz
On Wed, 24 Feb 2016 11:36:49 +1100 David Gibson wrote: > On Tue, Feb 23, 2016 at 06:46:44PM +0100, Greg Kurz wrote: > > On Wed, 10 Feb 2016 10:41:16 +0100 > > Greg Kurz wrote: > > > > > On Mon, 8 Feb 2016 09:31:49 +0100 > > > Greg Kurz wrote: > > > > > > > On Mon, 8 Feb 2016 11:45:19 +100

[Qemu-devel] Trying to figure out what 9 means to the escc

2016-02-24 Thread Programmingkid
With the below patch I can see that Mac OS 9.0 is having escc_mem_write() go to the SERIAL_CTRL case. Then to the W_CMD case. Then to the CMD_HI case. This then causes newreg to be set to the value 9. What I need to know is what is this value for. Does anyone know what it means? Afterwords Mac

[Qemu-devel] PCI Passthrough KVM with vfio-pci giving EINVAL on PCI Probe

2016-02-24 Thread Nicholas Andre
I am attempting to attach PCIe devices in passthrough to my KVM domain. I have two devices in one IOMMU group (#28): 03:00.0 PCI bridge: Texas Instruments XIO2001 PCI Express-to-PCI Bridge 04:00.0 Multimedia audio controller: Texas Instruments TMS320C6414 TMS320C6415 TMS320C6416 and lspci -n valu

[Qemu-devel] [PATCH 3/5] ipmi: Add SMBIOS table entry

2016-02-24 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/smbios/Makefile.objs| 2 + hw/smbios/ipmi.c | 76 +++

[Qemu-devel] [PATCH 0/5] Add ACPI and SMBIOS table entries for IPMI

2016-02-24 Thread minyard
Now that Igor has reworked things to remove the SSDT, I've updated IPMI code to work with the new format. This is functionally the same as before, just for ACPI it adds the data to the DSDT now. This will avoid a lot of "Why doesn't IPMI work when I add it?" questions, which I have already gotten

[Qemu-devel] [PATCH 1/5] smbios: Move table build tools into an include file.

2016-02-24 Thread minyard
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard --- hw/smbios/smbios.c | 70 --- hw/smbios/smbios_build.h | 77 2 files changed,

[Qemu-devel] [PATCH 4/5] acpi: Add IPMI table entries

2016-02-24 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called from build_dsdt to add an DSDT entry for IPMI if IPMI is compiled in and has registered firmware. It also adds a dummy function if IPMI is not compiled in. This conforms

[Qemu-devel] [PATCH 5/5] bios: Add tests for the IPMI ACPI and SMBIOS entries

2016-02-24 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard --- tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 0 -> 5574 bytes tests/acpi-test-data/q35/DSDT.ipmibt | Bin 0 -> 8420 bytes tests/bios-tables-test.c | 58 --- 3 files changed, 54 insertions(+), 4 delet

Re: [Qemu-devel] [PATCH] replace fixed str limit by g_strdup_printf

2016-02-24 Thread Alex Williamson
On Wed, 24 Feb 2016 00:22:02 -0800 Neo Jia wrote: > A trivial change to remove string limit by using g_strdup_printf > and g_strconcat > > Tested-by: Neo Jia > Signed-off-by: Neo Jia > Signed-off-by: Kirti Wankhede > --- > hw/vfio/pci.c | 19 --- > 1 file changed, 12 insertio

Re: [Qemu-devel] [PATCH 3/4] block/vpc: give option to force the current_size field in .bdrv_create

2016-02-24 Thread Peter Lieven
Am 24.02.2016 um 14:07 schrieb Kevin Wolf: > Am 24.02.2016 um 13:44 hat Peter Lieven geschrieben: >> if the size is forced I would set the chs values to max. this way no >> new creator String is needed and it is even backwards compatible. this >> is what disk2vhd does. > Does disk2vhd do it this wa

Re: [Qemu-devel] [PATCH 3/4] block/vpc: give option to force the current_size field in .bdrv_create

2016-02-24 Thread Peter Lieven
Am 24.02.2016 um 14:40 schrieb Jeff Cody: > On Wed, Feb 24, 2016 at 02:07:18PM +0100, Kevin Wolf wrote: >> Am 24.02.2016 um 13:44 hat Peter Lieven geschrieben: >>> if the size is forced I would set the chs values to max. this way no >>> new creator String is needed and it is even backwards compatib

[Qemu-devel] [PATCH 2/5] pc: Postpone SMBIOS table installation to post machine init

2016-02-24 Thread minyard
From: Corey Minyard This is the same place that the ACPI SSDT table gets added, so that devices can add themselves to the SMBIOS table. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c inde

Re: [Qemu-devel] [PATCH 1/4] slirp/slirp.h: Remove now-empty #ifdefs

2016-02-24 Thread Thomas Huth
On 23.02.2016 15:18, Peter Maydell wrote: > After automatic cleanup to remove unnecessary #includes of headers that > osdep.h provides, slirp.h has a few now unnecessary #ifdef/#endif pairs; > remove them. > > Signed-off-by: Peter Maydell > --- > slirp/slirp.h | 24 > 1

Re: [Qemu-devel] [Qemu-arm] help on how to emulate rasbperry pi 2

2016-02-24 Thread Andrew Baumann
> From: John Snow [mailto:js...@redhat.com] > Sent: Wednesday, 24 February 2016 10:28 AM > On 02/24/2016 01:04 PM, Andrew Baumann wrote: > >> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > >> Sent: Wednesday, 24 February 2016 9:49 AM > >> > >> On 24 February 2016 at 15:40, Mats Malmberg >

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-02-24 Thread Cole Mickens
Sounds good. I don't plan to retest unless you'd like me to; that change shouldn't affect me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490611 Title: Using qemu >=2.2.1 to convert raw->VHD (fi

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-02-24 Thread Jeff Cody
Thanks for testing! It is worth noting there is a v2 on the list now, that changes the creator app string to "qem2" from "qemu" when using the force_size option. That should only matter if you try to use your converted images on QEMU (so QEMU will know on that image to rely by default on the curr

Re: [Qemu-devel] [Qemu-arm] help on how to emulate rasbperry pi 2

2016-02-24 Thread John Snow
On 02/24/2016 01:04 PM, Andrew Baumann wrote: >> From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> Sent: Wednesday, 24 February 2016 9:49 AM >> >> On 24 February 2016 at 15:40, Mats Malmberg >> wrote: >>> >>> Hello all! >>> >>> TL;DR : Is the raspi2 machine ready to use? If yes, how do I

Re: [Qemu-devel] [PATCH 1/2] hmp: 'drive_add -n' for creating a node without BB

2016-02-24 Thread Kevin Wolf
Am 24.02.2016 um 18:50 hat Max Reitz geschrieben: > On 23.02.2016 18:16, Kevin Wolf wrote: > > This patch adds an option to the drive_add HMP command to create only a > > BlockDriverState without a BlockBackend on top. > > > > The motivation for this is that libvirt needs to specify options to a >

Re: [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB

2016-02-24 Thread Kevin Wolf
Am 24.02.2016 um 18:54 hat Max Reitz geschrieben: > On 23.02.2016 18:16, Kevin Wolf wrote: > > Now that we can use drive_add to create new nodes without a BB, we also > > want to be able to delete such nodes again. > > > > Signed-off-by: Kevin Wolf > > --- > > blockdev.c | 9 + > > 1 fil

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2016-02-24 Thread Cole Mickens
It looks like the option is "force_size" rather than "force-size". It also seems to be having the intended effect. I regenerate my nixos iso with various configurations: qemu-master + jeffcody patches + force_size = 2147484160 qemu-master + jeffcody patches (no force_size) = 2147992064 qemu-stabl

Re: [Qemu-devel] [Qemu-arm] help on how to emulate rasbperry pi 2

2016-02-24 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, 24 February 2016 9:49 AM > > On 24 February 2016 at 15:40, Mats Malmberg > wrote: > > > > Hello all! > > > > TL;DR : Is the raspi2 machine ready to use? If yes, how do I use it with > > ordinary rpi distros? If not, what i

Re: [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB

2016-02-24 Thread Max Reitz
On 23.02.2016 18:16, Kevin Wolf wrote: > Now that we can use drive_add to create new nodes without a BB, we also > want to be able to delete such nodes again. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/blockdev.c b/blockdev

Re: [Qemu-devel] [PATCH 1/2] hmp: 'drive_add -n' for creating a node without BB

2016-02-24 Thread Max Reitz
On 23.02.2016 18:16, Kevin Wolf wrote: > This patch adds an option to the drive_add HMP command to create only a > BlockDriverState without a BlockBackend on top. > > The motivation for this is that libvirt needs to specify options to a > migration target (specifically, detect-zeroes). drive-mirro

Re: [Qemu-devel] [Qemu-arm] help on how to emulate rasbperry pi 2

2016-02-24 Thread Peter Maydell
On 24 February 2016 at 15:40, Mats Malmberg wrote: > > Hello all! > > TL;DR : Is the raspi2 machine ready to use? If yes, how do I use it with > ordinary rpi distros? If not, what is the best way to emulate raspberry > pi 2 via Qemu? Hi; I've cc'd the main qemu-devel list and Andrew Baumann who c

[Qemu-devel] Making all TB invalidation asynchronous (MTTCG safe_work)?

2016-02-24 Thread Alex Bennée
Hi, So I've been working on reducing MTTCG tb_lock contention and currently have a tb_lock around the following code (in my cpu_exec): /* Note: we do it here to avoid a gcc bug on Mac OS X when doing it in tb_find_slow */ tb_lock(); if (tcg_ctx.tb_ctx.tb_invalidated_flag) {

  1   2   3   >