Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-28 Thread Kevin Wolf
Am 29.02.2016 um 08:03 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 25.02.2016 um 10:06 hat Pavel Dovgalyuk geschrieben: > > > There is one problem with flush event - callbacks for flush are called for > > > all layers and I couldn't synchronize them

Re: [Qemu-devel] [PATCH v3] net: netmap: probe netmap interface for virtio-net header

2016-02-28 Thread Jason Wang
On 02/24/2016 06:30 PM, Vincenzo Maffione wrote: > Previous implementation of has_ufo, has_vnet_hdr, has_vnet_hdr_len, etc. > did not really probe for virtio-net header support for the netmap > interface attached to the backend. These callbacks were correct for > VALE ports, but incorrect for

Re: [Qemu-devel] [PATCH v2 2/2] filter-buffer: Add status_changed callback processing

2016-02-28 Thread Hailiang Zhang
On 2016/2/29 15:27, Jason Wang wrote: On 02/29/2016 09:46 AM, zhanghailiang wrote: While the status of filter-buffer changing from 'on' to 'off', it need to release all the buffered packets, and delete the related timer, while switch from 'off' to 'on', it need to resume the release packets

Re: [Qemu-devel] [PATCH v2 1/2] filter: Add 'status' property for filter object

2016-02-28 Thread Hailiang Zhang
On 2016/2/29 15:26, Jason Wang wrote: On 02/29/2016 09:46 AM, zhanghailiang wrote: With this property, users can control if this filter is 'on' or 'off'. The default behavior for filter is 'on'. For some types of filters, they may need to react to status changing, So here, we introduced

Re: [Qemu-devel] [PATCHv2 5/7] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge

2016-02-28 Thread Alexey Kardashevskiy
On 02/29/2016 06:06 PM, David Gibson wrote: Now that the regular spapr-pci-host-bridge can handle EEH, there are only two things that spapr-pci-vfio-host-bridge does differently: 1. automatically sizes its DMA window to match the host IOMMU 2. checks if the attached VFIO container is

Re: [Qemu-devel] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks

2016-02-28 Thread Alexey Kardashevskiy
On 02/29/2016 06:06 PM, David Gibson wrote: The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the special groupid field in sPAPRPHBVFIOState. So we can simplify, removing the class specific callbacks with direct calls based on a simple spapr_phb_eeh_enabled() helper. For

Re: [Qemu-devel] [PATCHv2 4/7] spapr_pci: Allow EEH on spapr-pci-host-bridge

2016-02-28 Thread Alexey Kardashevskiy
On 02/29/2016 06:06 PM, David Gibson wrote: Now that the EEH code is independent of the special spapr-vfio-pci-host-bridge device, we can allow it on all spapr PCI host bridges instead. We do this by changing spapr_phb_eeh_available() to be based on the vfio_eeh_as_ok() call instead of the host

Re: [Qemu-devel] [PATCHv2 1/7] vfio: Start improving VFIO/EEH interface

2016-02-28 Thread Alexey Kardashevskiy
On 02/29/2016 06:06 PM, David Gibson wrote: At present the code handling IBM's Enhanced Error Handling (EEH) interface on VFIO devices operates by bypassing the usual VFIO logic with vfio_container_ioctl(). That's a poorly designed interface with unclear semantics about exactly what can be

Re: [Qemu-devel] [PATCH v2 2/2] filter-buffer: Add status_changed callback processing

2016-02-28 Thread Jason Wang
On 02/29/2016 09:46 AM, zhanghailiang wrote: > While the status of filter-buffer changing from 'on' to 'off', > it need to release all the buffered packets, and delete the related > timer, while switch from 'off' to 'on', it need to resume the release > packets timer. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 1/2] filter: Add 'status' property for filter object

2016-02-28 Thread Jason Wang
On 02/29/2016 09:46 AM, zhanghailiang wrote: > With this property, users can control if this filter is 'on' > or 'off'. The default behavior for filter is 'on'. > > For some types of filters, they may need to react to status changing, > So here, we introduced status changing callback/notifier

[Qemu-devel] An ivshmem + chardev peculiarity

2016-02-28 Thread Markus Armbruster
The ivshmem client/server protocol is one-way: only the server sends. The only way clients can communicate is by connect and close. Since the ivshmem device model uses a chardev for its connection to the server, both connect and close happen in chardev code. Example: monitor command chardev-add

Re: [Qemu-devel] [PATCH] net/filter-redirector:Add filter-redirector

2016-02-28 Thread Jason Wang
On 02/24/2016 05:03 PM, Zhang Chen wrote: > > If queue=rx, filter-redirector will get the packet that guest send, > then redirect > to outdev(if none, do nothing). but queue=rx/tx/all not related to > indev. please > look the flow chart below. queue=xxx just work for one > way(filter->outdev). >

Re: [Qemu-devel] [RFC PATCH v0 3/6] spapr: Represent boot CPUs as spapr-cpu-core devices

2016-02-28 Thread David Gibson
On Mon, Feb 29, 2016 at 11:05:32AM +0530, Bharata B Rao wrote: > On Fri, Feb 26, 2016 at 04:18:57PM +0100, Igor Mammedov wrote: > > On Thu, 25 Feb 2016 21:52:39 +0530 > > Bharata B Rao wrote: [snip] > > > @@ -2209,6 +2251,7 @@ static void > > >

[Qemu-devel] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks

2016-02-28 Thread David Gibson
The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the special groupid field in sPAPRPHBVFIOState. So we can simplify, removing the class specific callbacks with direct calls based on a simple spapr_phb_eeh_enabled() helper. For now we implement that in terms of a boolean in

[Qemu-devel] [PATCHv2 2/7] spapr_pci: Switch to vfio_eeh_as_op() interface

2016-02-28 Thread David Gibson
This switches all EEH on VFIO operations in spapr_pci_vfio.c from the broken vfio_container_ioctl() interface to the new vfio_as_eeh_op() interface. Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci_vfio.c | 50

[Qemu-devel] [PATCHv2 4/7] spapr_pci: Allow EEH on spapr-pci-host-bridge

2016-02-28 Thread David Gibson
Now that the EEH code is independent of the special spapr-vfio-pci-host-bridge device, we can allow it on all spapr PCI host bridges instead. We do this by changing spapr_phb_eeh_available() to be based on the vfio_eeh_as_ok() call instead of the host bridge class. Because the value of

[Qemu-devel] [PATCHv2 6/7] spapr_pci: Remove finish_realize hook

2016-02-28 Thread David Gibson
Now that spapr-pci-vfio-host-bridge is reduced to just a stub, there is only one implementation of the finish_realize hook in sPAPRPHBClass. So, we can fold that implementation into its (single) caller, and remove the hook. That's the last thing left in sPAPRPHBClass, so that can go away as

[Qemu-devel] [PATCHv2 1/7] vfio: Start improving VFIO/EEH interface

2016-02-28 Thread David Gibson
At present the code handling IBM's Enhanced Error Handling (EEH) interface on VFIO devices operates by bypassing the usual VFIO logic with vfio_container_ioctl(). That's a poorly designed interface with unclear semantics about exactly what can be operated on. In particular it operates on a

[Qemu-devel] [PATCHv2 5/7] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge

2016-02-28 Thread David Gibson
Now that the regular spapr-pci-host-bridge can handle EEH, there are only two things that spapr-pci-vfio-host-bridge does differently: 1. automatically sizes its DMA window to match the host IOMMU 2. checks if the attached VFIO container is backed by the VFIO_SPAPR_TCE_IOMMU type on

[Qemu-devel] [PATCHv2 7/7] vfio: Eliminate vfio_container_ioctl()

2016-02-28 Thread David Gibson
vfio_container_ioctl() was a bad interface that bypassed abstraction boundaries, had semantics that sat uneasily with its name, and was unsafe in many realistic circumstances. Now that spapr-pci-vfio-host-bridge has been folded into spapr-pci-host-bridge, there are no more users, so remove it.

[Qemu-devel] [PATCHv2 0/7] Allow EEH on spapr-pci-host-bridge devices

2016-02-28 Thread David Gibson
For historical reasons, the spapr machine type has two PCI host bridge implementations: spapr-pci-host-bridge, and spapr-vfio-pci-host-bridge. The latter was (duh) designed for VFIO devices, but later reworks mean it's not necessary for that, and VFIO can be used on the regular host bridge. The

Re: [Qemu-devel] [PATCH 3/3] replay: introduce block devices record/replay

2016-02-28 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 25.02.2016 um 10:06 hat Pavel Dovgalyuk geschrieben: > > There is one problem with flush event - callbacks for flush are called for > > all layers and I couldn't synchronize them correctly yet. > > I'll probably have to add new callback to block

[Qemu-devel] [PULL 0/8] ppc-for-2.6 queue 20160229

2016-02-28 Thread David Gibson
To probably no-one's surprise, my "hopefully last" pull request before the soft freeze has turned out not to be the last. Here are a few more patches for qemu-2.6. The following changes since commit 6e378dd214fbbae8138ff011ec3de7ddf13a445f: Merge remote-tracking branch

[Qemu-devel] [PULL 6/8] spapr: skip configuration section during migration of older machines

2016-02-28 Thread David Gibson
From: Greg Kurz Since QEMU 2.4, we have a configuration section in the migration stream. This must be skipped for older machines, like it is already done for x86. This patch fixes the migration of pseries-2.3 from/to QEMU 2.3, but it breaks migration of the same

[Qemu-devel] [PULL 1/8] spapr_rng: disable hotpluggability

2016-02-28 Thread David Gibson
From: Greg Kurz It is currently possible to hotplug a spapr_rng device but QEMU crashes when we try to hot unplug: ERROR:hw/core/qdev.c:295:qdev_unplug: assertion failed: (hotplug_ctrl) Aborted This happens because spapr_rng isn't plugged to any bus and sPAPR does not

[Qemu-devel] [PULL 2/8] spapr_pci: kill useless variable in rtas_ibm_change_msi()

2016-02-28 Thread David Gibson
From: Greg Kurz The num local variable is initialized to zero and has no writer. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PULL 3/8] spapr_pci: fix irq leak in RTAS ibm, change-msi

2016-02-28 Thread David Gibson
From: Greg Kurz This RTAS call is used to request new interrupts or to free all interrupts. If the driver has already allocated interrupts and asks again for a non-null number of irqs, then the rtas_ibm_change_msi() function will silently leak the previous interrupts.

[Qemu-devel] [PULL 8/8] xics: report errors with the QEMU Error API

2016-02-28 Thread David Gibson
From: Greg Kurz Using the return value to report errors is error prone: - xics_alloc() returns -1 on error but spapr_vio_busdev_realize() errors on 0 - xics_alloc_block() returns the unclear value of ics->offset - 1 on error but both rtas_ibm_change_msi() and

[Qemu-devel] [PULL 7/8] migration: allow machine to enforce configuration section migration

2016-02-28 Thread David Gibson
From: Greg Kurz Migration of pseries-2.3 doesn't have configuration section. Unfortunately, QEMU 2.4/2.4.1/2.5 are buggy and always stream and expect the configuration section, and break migration both ways. This patch introduces a property which allows to enforce a

[Qemu-devel] [PULL 5/8] dbdma: warn when using unassigned channel

2016-02-28 Thread David Gibson
From: Hervé Poussineau With this, it's easier to know if a guest uses an invalid and/or unimplemented DMA channel. Signed-off-by: Hervé Poussineau Reviewed-by: Thomas Huth Acked-by: Mark Cave-Ayland

[Qemu-devel] [PULL 4/8] spapr: disable vmdesc submission for old machines

2016-02-28 Thread David Gibson
From: Greg Kurz Since QEMU 2.3, we have a vmdesc section in the migration stream. This section is not mandatory but when migrating a pseries-2.2 machine from QEMU 2.2, you get a warning at the destination: qemu-system-ppc64: Expected vmdescription section, but got 0

Re: [Qemu-devel] [PATCH 04/12] spapr_pci: Fold spapr_phb_vfio_eeh_configure() into spapr_pci code

2016-02-28 Thread David Gibson
On Mon, Feb 29, 2016 at 03:25:24PM +1100, Alexey Kardashevskiy wrote: > On 02/29/2016 02:45 PM, Alexey Kardashevskiy wrote: > >On 02/29/2016 12:43 PM, Alexey Kardashevskiy wrote: > >>On 02/26/2016 10:31 PM, David Gibson wrote: > >>>Simplify the sPAPR PCI code by folding

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 12:13:39PM -0600, Michael Roth wrote: > Quoting Bharata B Rao (2016-02-25 10:22:38) > > Add sPAPR specific CPU core device that is based on generic CPU core device. > > Creating this core device will result in creation of all the CPU thread > > devices that are part of this

Re: [Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 08:58:05AM -0700, Eric Blake wrote: > On 02/25/2016 09:22 AM, Bharata B Rao wrote: > > Implement query cpu-slots that provides information about hot-plugged > > as well as hot-pluggable CPU slots that the machine supports. > > > > TODO: As Eric suggested use enum for type

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 11:46:19AM +0100, Thomas Huth wrote: > On 25.02.2016 17:22, Bharata B Rao wrote: > > Add sPAPR specific CPU core device that is based on generic CPU core device. > > Creating this core device will result in creation of all the CPU thread > > devices that are part of this

Re: [Qemu-devel] [RFC PATCH v2 1/3] vGPU Core driver

2016-02-28 Thread Tian, Kevin
> From: Kirti Wankhede > Sent: Wednesday, February 24, 2016 12:24 AM > > Design for vGPU Driver: > Main purpose of vGPU driver is to provide a common interface for vGPU > management that can be used by differnt GPU drivers. > > This module would provide a generic interface to create the device,

Re: [Qemu-devel] [RFC PATCH v0 3/6] spapr: Represent boot CPUs as spapr-cpu-core devices

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 04:18:57PM +0100, Igor Mammedov wrote: > On Thu, 25 Feb 2016 21:52:39 +0530 > Bharata B Rao wrote: > > > Initialize boot CPUs as spapr-cpu-core devices and create links from > > machine object to these core devices. These links can be

Re: [Qemu-devel] [PATCH V7 0/2] net/filter-mirror:add filter-mirror and unit test

2016-02-28 Thread Jason Wang
On 02/26/2016 04:12 PM, Zhang Chen wrote: > Filter-mirror is a netfilter plugin. > It gives qemu the ability to mirror > packets to a chardev. > > v7: > - fix mktemp() to mkstemp() > > v6: > - Address Jason's comments. > > v5: > - Address Jason's comments. > > v4: > - Address Jason's

Re: [Qemu-devel] Installing guest OS in VM

2016-02-28 Thread Fam Zheng
On Sun, 02/28 10:37, Sarah Khan wrote: > Hi, > I have been looking forward to participate in outreachy round 12.So, I was > trying to install guest OS in VM according to instructions as given on this > link: > http://wiki.qemu-project.org/Hosts/Linux but I am stuck after the > instruction which

[Qemu-devel] Installing guest OS in VM

2016-02-28 Thread Sarah Khan
Hi, I have been looking forward to participate in outreachy round 12.So, I was trying to install guest OS in VM according to instructions as given on this link: http://wiki.qemu-project.org/Hosts/Linux but I am stuck after the instruction which tells to boot PC-BIOS which is

Re: [Qemu-devel] [RFC PATCH v0 2/6] spapr: CPU core device

2016-02-28 Thread David Gibson
On Fri, Feb 26, 2016 at 12:13:39PM -0600, Michael Roth wrote: > Quoting Bharata B Rao (2016-02-25 10:22:38) > > Add sPAPR specific CPU core device that is based on generic CPU core device. > > Creating this core device will result in creation of all the CPU thread > > devices that are part of this

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2016-02-28 Thread Zack Callendish
It doesn't work on my XU4 either. The supported virtualization would probably work for ARM images but it's not something many people need. What's the holdup, dear devs? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: Switch to vfio_eeh_as_op() interface

2016-02-28 Thread David Gibson
On Mon, Feb 29, 2016 at 12:43:05PM +1100, Alexey Kardashevskiy wrote: > On 02/26/2016 10:31 PM, David Gibson wrote: > >This switches all EEH on VFIO operations in spapr_pci_vfio.c from the > >broken vfio_container_ioctl() interface to the new vfio_as_eeh_op() > >interface. > > > >Signed-off-by:

Re: [Qemu-devel] [PATCH 01/12] vfio: Start improving VFIO/EEH interface

2016-02-28 Thread David Gibson
On Mon, Feb 29, 2016 at 11:58:54AM +1100, Alexey Kardashevskiy wrote: > On 02/26/2016 10:31 PM, David Gibson wrote: > >At present the code handling IBM's Enhanced Error Handling (EEH) interface > >on VFIO devices operates by bypassing the usual VFIO logic with > >vfio_container_ioctl(). That's a

Re: [Qemu-devel] [Qemu-ppc] Migrating decrementer

2016-02-28 Thread David Gibson
On Fri, Feb 26, 2016 at 12:29:51PM +, Mark Cave-Ayland wrote: > On 26/02/16 04:35, David Gibson wrote: > > >> Sign. And let me try that again, this time after caffeine: > >> > >> cpu_start/resume(): > >> cpu->tb_env->tb_offset = > >> muldiv64(qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL),

Re: [Qemu-devel] [PATCH 10/12] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge

2016-02-28 Thread David Gibson
On Mon, Feb 29, 2016 at 12:42:28PM +1100, Alexey Kardashevskiy wrote: > On 02/26/2016 10:32 PM, David Gibson wrote: > >Now that the regular spapr-pci-host-bridge can handle EEH, there are only > >two things that spapr-pci-vfio-host-bridge does differently: > > 1. automatically sizes its DMA

Re: [Qemu-devel] [RFC PATCH v0 4/6] spapr: CPU hotplug support

2016-02-28 Thread Bharata B Rao
On Fri, Feb 26, 2016 at 02:51:41PM +1100, David Gibson wrote: > On Thu, Feb 25, 2016 at 09:52:40PM +0530, Bharata B Rao wrote: > > Set up device tree entries for the hotplugged CPU core and use the > > exising EPOW event infrastructure to send CPU hotplug notification to > > the guest. > > > >

Re: [Qemu-devel] [PATCH 04/12] spapr_pci: Fold spapr_phb_vfio_eeh_configure() into spapr_pci code

2016-02-28 Thread Alexey Kardashevskiy
On 02/29/2016 02:45 PM, Alexey Kardashevskiy wrote: On 02/29/2016 12:43 PM, Alexey Kardashevskiy wrote: On 02/26/2016 10:31 PM, David Gibson wrote: Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_configure() into rtas_ibm_configure_pe(). Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCH 04/12] spapr_pci: Fold spapr_phb_vfio_eeh_configure() into spapr_pci code

2016-02-28 Thread Alexey Kardashevskiy
On 02/29/2016 12:43 PM, Alexey Kardashevskiy wrote: On 02/26/2016 10:31 PM, David Gibson wrote: Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_configure() into rtas_ibm_configure_pe(). Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH 03/12] spapr_pci: Eliminate class callbacks

2016-02-28 Thread Alexey Kardashevskiy
On 02/29/2016 12:43 PM, Alexey Kardashevskiy wrote: On 02/26/2016 10:31 PM, David Gibson wrote: The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the special groupid field in sPAPRPHBVFIOState. So we can simplify, removing the class specific callbacks with direct calls

Re: [Qemu-devel] [PATCH] Qemu/KVM: Remove x2apic feature from CPU model when kernel_irqchip is off

2016-02-28 Thread Lan Tianyu
On 2016年02月27日 03:54, Eduardo Habkost wrote: > On Thu, Feb 25, 2016 at 11:15:12PM +0800, Lan Tianyu wrote: >> x2apic feature is in the kvm_default_props and automatically added to all >> CPU models when KVM is enabled. But userspace devices don't support x2apic >> which can't be enabled without

[Qemu-devel] [PATCH 4/6] memory: Drop MemoryRegion.ram_addr

2016-02-28 Thread Fam Zheng
All references to mr->ram_addr are replaced by memory_region_get_ram_addr(mr) (except for a few assertions that are replaced with mr->ram_block). Signed-off-by: Fam Zheng --- cputlb.c | 4 +-- exec.c| 3 ++- hw/misc/ivshmem.c | 9 ---

[Qemu-devel] [PATCH 3/6] memory: Implement memory_region_get_ram_addr with mr->ram_block

2016-02-28 Thread Fam Zheng
Signed-off-by: Fam Zheng --- include/exec/memory.h | 8 +--- memory.c | 5 + 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index d5284c2..810d2c0 100644 --- a/include/exec/memory.h +++

[Qemu-devel] [PATCH 5/6] exec: Pass RAMBlock pointer to qemu_ram_free

2016-02-28 Thread Fam Zheng
The only caller now knows exactly which RAMBlock to free, so it's not necessary to do the lookup. Signed-off-by: Fam Zheng --- exec.c | 21 +++-- include/exec/ram_addr.h | 2 +- memory.c| 4 ++-- 3 files changed, 10

[Qemu-devel] [PATCH 6/6] exec: Introduce AddressSpaceDispatch.mru_section

2016-02-28 Thread Fam Zheng
Under heavy workloads the lookup will likely end up with the same MemoryRegionSection from last time. Using a pointer to cache the result, like ram_list.mru_block, significantly reduce computation cost of address_space_translate. During address space topology update, as->dispatch will be

[Qemu-devel] [PATCH 2/6] memory: Move assignment to ram_block to memory_region_init_*

2016-02-28 Thread Fam Zheng
We don't force "const" qualifiers with pointers in QEMU, but it's still good to keep a clean function interface. Assigning to mr->ram_block is in this sense ugly - one initializer mutating its owning object's state. Move it to memory_region_init_*, where mr->ram_addr is assigned. Signed-off-by:

[Qemu-devel] [PATCH 0/6] memory: Clean up MemoryRegion.ram_addr and optimize address_space_translate

2016-02-28 Thread Fam Zheng
The first four patches drop ram_addr from MemoryRegion on top of Gonglei's optimization. The next patch simplifies qemu_ram_free a bit by passing the RAMBlock pointer. The last patch speeds up address_space_translate with a cache pointer inside the AddressSpaceDispatch. Fam Zheng (6): exec:

[Qemu-devel] [PATCH 1/6] exec: Return RAMBlock pointer from allocating functions

2016-02-28 Thread Fam Zheng
Previously we return RAMBlock.offset; now return the pointer to the whole structure. ram_block_add returns void now, error is completely passed with errp. Signed-off-by: Fam Zheng --- exec.c | 51 +

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/3] hw/timer: Add ASPEED AST2400 timer device model

2016-02-28 Thread Andrew Jeffery
On Fri, 2016-02-26 at 10:20 +, Peter Maydell wrote: > On 26 February 2016 at 03:14, Andrew Jeffery wrote: > > > > Hi Peter, > > > > On Thu, 2016-02-25 at 16:11 +, Peter Maydell wrote: > > > > > > On 16 February 2016 at 11:34, Andrew Jeffery wrote: > >

[Qemu-devel] [PATCH v2 2/2] filter-buffer: Add status_changed callback processing

2016-02-28 Thread zhanghailiang
While the status of filter-buffer changing from 'on' to 'off', it need to release all the buffered packets, and delete the related timer, while switch from 'off' to 'on', it need to resume the release packets timer. Signed-off-by: zhanghailiang Cc: Jason Wang

[Qemu-devel] [PATCH v2 0/2] Introduce 'status' property for netfilter

2016-02-28 Thread zhanghailiang
This is picked from COLO series, which is to realize the new 'status' property for filter. With this property, users can control if the filter is enabled or disabled. zhanghailiang (2): filter: Add 'status' property for filter object filter-buffer: Add status_changed callback processing

[Qemu-devel] [PATCH v2 1/2] filter: Add 'status' property for filter object

2016-02-28 Thread zhanghailiang
With this property, users can control if this filter is 'on' or 'off'. The default behavior for filter is 'on'. For some types of filters, they may need to react to status changing, So here, we introduced status changing callback/notifier for filter class. We will skip the disabled ('off')

Re: [Qemu-devel] [PATCH 09/12] spapr_pci: Allow EEH on spapr-pci-host-bridge

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:32 PM, David Gibson wrote: Now that the EEH code is independent of the special spapr-vfio-pci-host-bridge device, we can allow it on all spapr PCI host bridges instead. We do this by changing spapr_phb_eeh_available() to be based on the vfio_eeh_as_ok() call instead of the host

Re: [Qemu-devel] [PATCH 11/12] spapr_pci: Remove finish_realize hook

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:32 PM, David Gibson wrote: Now that spapr-pci-vfio-host-bridge is reduced to just a stub, there is only one implementation of the finish_realize hook in sPAPRPHBClass. So, we can fold that implementation into its (single) caller, and remove the hook. That's the last thing left

Re: [Qemu-devel] [PATCH 08/12] spapr_pci: Fold spapr_phb_vfio_reset() into spapr_pci code

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: Simplify the sPAPR PCI code by folding spapr_phb_vfio_reset() into spapr_phb_reset(). Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 13 -

Re: [Qemu-devel] [PATCH 12/12] vfio: Eliminate vfio_container_ioctl()

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:32 PM, David Gibson wrote: vfio_container_ioctl() was a bad interface that bypassed abstraction boundaries, had semantics that sat uneasily with its name, and was unsafe in many realistic circumstances. Now that spapr-pci-vfio-host-bridge has been folded into

Re: [Qemu-devel] [PATCH 07/12] spapr_pci: Fold spapr_phb_vfio_eeh_set_option() into spapr_pci code

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: Simplify the sPAPR PCI code by folding spapr_phb_eeh_set_option() into rtas_ibm_set_eeh_option(). Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 43

Re: [Qemu-devel] [PATCH 05/12] spapr_pci: Fold spapr_phb_vfio_eeh_reset() into spapr_pci code

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_reset() into rtas_ibm_set_slot_reset(). We move several functions of which it was the only caller (spapr_phb_eeh_clear_dev_msix(), spapr_phb_eeh_clear_bus_msix() and spapr_phb_eeh_pre_reset())

Re: [Qemu-devel] [PATCH 03/12] spapr_pci: Eliminate class callbacks

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the special groupid field in sPAPRPHBVFIOState. So we can simplify, removing the class specific callbacks with direct calls based on a simple spapr_phb_eeh_enabled() helper. For

Re: [Qemu-devel] [PATCH 06/12] spapr_pci: Fold spapr_phb_vfio_eeh_get_state() into spapr_pci code

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_get_state9) into rtas_ibm_read_slot_reset_state2(). Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c

Re: [Qemu-devel] [PATCH 04/12] spapr_pci: Fold spapr_phb_vfio_eeh_configure() into spapr_pci code

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: Simplify the sPAPR PCI code by folding spapr_phb_vfio_eeh_configure() into rtas_ibm_configure_pe(). Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 11

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: Switch to vfio_eeh_as_op() interface

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: This switches all EEH on VFIO operations in spapr_pci_vfio.c from the broken vfio_container_ioctl() interface to the new vfio_as_eeh_op() interface. Signed-off-by: David Gibson mak Where is that "mak" from? :)

Re: [Qemu-devel] [PATCH 10/12] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:32 PM, David Gibson wrote: Now that the regular spapr-pci-host-bridge can handle EEH, there are only two things that spapr-pci-vfio-host-bridge does differently: 1. automatically sizes its DMA window to match the host IOMMU 2. checks if the attached VFIO container is

Re: [Qemu-devel] [PATCH 01/12] vfio: Start improving VFIO/EEH interface

2016-02-28 Thread Alexey Kardashevskiy
On 02/26/2016 10:31 PM, David Gibson wrote: At present the code handling IBM's Enhanced Error Handling (EEH) interface on VFIO devices operates by bypassing the usual VFIO logic with vfio_container_ioctl(). That's a poorly designed interface with unclear semantics about exactly what can be

Re: [Qemu-devel] [PATCH v2] xics: report errors with the QEMU Error API

2016-02-28 Thread David Gibson
On Fri, Feb 26, 2016 at 10:44:07AM +0100, Greg Kurz wrote: > Using the return value to report errors is error prone: > - xics_alloc() returns -1 on error but spapr_vio_busdev_realize() errors > on 0 > - xics_alloc_block() returns the unclear value of ics->offset - 1 on error > but both

Re: [Qemu-devel] [PATCH v2 01/16] tcg-mips: Always use tcg_debug_assert

2016-02-28 Thread Aurelien Jarno
On 2016-02-15 14:42, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/mips/tcg-target.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c > index 2dc4998..ebb936d

Re: [Qemu-devel] [PATCH v2 00/16] tcg mips64 and mips r6 improvements

2016-02-28 Thread Aurelien Jarno
On 2016-02-15 14:42, Richard Henderson wrote: > Changes since v1: > * Some bugs pointed out by Mark fixed. > * Canonicalize the whole file on tcg_debug_assert. > * Switch bswap code to subroutine earlier; the first patch is > standalone for mips32, and there is no longer an intermediate

[Qemu-devel] [QEMU] Windows XP / Windows 95 / MS-DOS 6 regressions

2016-02-28 Thread Hervé Poussineau
Hi, I currently see some regressions on Microsoft operating systems. 1) Windows XP bugchecks since commit: commit 7f0b7141b4c7deab51efd8ee1e83eab2d9b7a9ea Author: Richard Henderson Date: Mon Jul 6 17:29:59 2015 +0100 target-i386: Perform set/reset_inhibit_irq inline

Re: [Qemu-devel] [PATCH v2 0/9] Add i.MX6 (Single/Dual/Quad) support

2016-02-28 Thread Jean-Christophe DUBOIS
Peter, Are you OK if I merge the 2 series (i.MX6 and SPI for i.MX6) into a single series? Thanks. JC Le 08/02/2016 23:08, Jean-Christophe Dubois a écrit : This patch series adds support for the Freescale i.MX6 processor. For now we only support the following devices: * up to 4 Cortex A9

Re: [Qemu-devel] [PATCH v1 16/17] loader: Add data swap option to load-elf

2016-02-28 Thread Peter Crosthwaite
On Sun, Feb 28, 2016 at 7:28 AM, Peter Maydell wrote: > On 27 February 2016 at 23:14, Peter Crosthwaite > wrote: >> On Tue, Jan 19, 2016 at 9:53 AM, Peter Maydell >> wrote: >>> Can we have a doc comment so we have

Re: [Qemu-devel] [PATCH v4 02/10] pc: init pcms->apic_id_limit once and use it throughout pc.c

2016-02-28 Thread Marcel Apfelbaum
On 02/26/2016 03:59 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 45 +++-- 1 file changed, 19 insertions(+), 26 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 0aeefd2..151a64c 100644 ---

Re: [Qemu-devel] [PATCH v4 04/10] pc: acpi: cleanup qdev_get_machine() calls

2016-02-28 Thread Marcel Apfelbaum
On 02/26/2016 03:59 PM, Igor Mammedov wrote: cache qdev_get_machine() result in acpi_setup/acpi_build_update time and pass it as an argument to child functions that need it. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 31 +++ 1

Re: [Qemu-devel] Can't compile QEMU 2.5.0 on Arch Linux ARM

2016-02-28 Thread XJDHDR
>> {standard input}:9097: Error: bad instruction `lock' >> {standard input}:9097: Error: bad instruction `addl $0,0(%rsp)' >> {standard input}:9412: Error: bad instruction `lock' >> {standard input}:9412: Error: bad instruction `addl $0,0(%rsp)' >>

[Qemu-devel] [Bug 1488363] Re: qemu 2.4.0 hangs using vfio for pci passthrough of graphics card

2016-02-28 Thread Peter Maloney
With seabios 1.9.1-1 and qemu 2.5.0-1 manjaro packages (which as far as I know have no patches), it seems to work now. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1488363 Title: qemu 2.4.0 hangs

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2016-02-28 Thread Peter Maydell
The "holdup" is simply that nobody who is interested in this issue has written a patch like that Paolo proposed in comment #13. (Mostly people either want to run ARM or other guest images in emulation on x86, or they're running ARM images with hardware virtualization on ARM hardware. Trying to run

Re: [Qemu-devel] [PATCH v1 16/17] loader: Add data swap option to load-elf

2016-02-28 Thread Peter Maydell
On 27 February 2016 at 23:14, Peter Crosthwaite wrote: > On Tue, Jan 19, 2016 at 9:53 AM, Peter Maydell > wrote: >> Can we have a doc comment so we have something that defines what >> values data_swab accepts? (it's not just a bool). >> > >

Re: [Qemu-devel] [PATCH] kvm: x86: q35: Add support for -machine kernel_irqchip=split for q35

2016-02-28 Thread Jan Kiszka
On 2016-02-28 12:52, Rita Sinha wrote: > The split IRQ chip mode via KVM_CAP_SPLIT_IRQCHIP was introduced with commit > 15eafc2e602ff8c37c6e132eb8c63fec8fc17175 but was broken for q35. This patch You may abbreviate hashes in logs. I usually use 10 digits, some even only 8. There is a risk of

Re: [Qemu-devel] [PATCH v2 6/9] i.MX: Add i.MX6 System Reset Controller device.

2016-02-28 Thread Jean-Christophe DUBOIS
Le 27/02/2016 18:43, Peter Maydell a écrit : On 27 February 2016 at 16:57, Jean-Christophe DUBOIS wrote: Hi Peter and Peter, I need to test that the changes I did for PSCI (factor out on/off code) do not introduce any regression. On which QEMU target should I test my

[Qemu-devel] [PATCH] kvm: x86: q35: Add support for -machine kernel_irqchip=split for q35

2016-02-28 Thread Rita Sinha
The split IRQ chip mode via KVM_CAP_SPLIT_IRQCHIP was introduced with commit 15eafc2e602ff8c37c6e132eb8c63fec8fc17175 but was broken for q35. This patch makes kernel_irqchip=split functional for q35. --- hw/i386/pc_q35.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v4 0/2] doc/memory: cleanup

2016-02-28 Thread Cao jin
see each commit message Cao jin (2): doc/memory: fix inconsistency between code and doc doc/memory: remove the stray extra '-' docs/memory.txt | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.1.0

[Qemu-devel] [PATCH v4 2/2] doc/memory: remove the stray extra '-'

2016-02-28 Thread Cao jin
Signed-off-by: Cao jin Reviewed-by: Peter Maydell --- docs/memory.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/memory.txt b/docs/memory.txt index 746d794..cd6657f 100644 --- a/docs/memory.txt +++

[Qemu-devel] [PATCH v4 1/2] doc/memory: fix inconsistency between code and doc

2016-02-28 Thread Cao jin
change ".valid.aligned" to ".valid.unaligned", and also modify its description, make the text parallel to the existing .impl.unaligned doc. Signed-off-by: Cao jin --- docs/memory.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 1/2] doc/memory: fix typo

2016-02-28 Thread Cao jin
On 02/26/2016 07:36 PM, Peter Maydell wrote: On 26 February 2016 at 11:29, Cao jin wrote: Needs to be a semicolon before the "if". Either "something something. If foo" or "something something; if foo" are correct as punctuation. Since we're aiming to follow the

[Qemu-devel] ODP: Quick folder sharing to arm quest from host

2016-02-28 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
So it seem that again it was my lack of knowledge from virtualization area. It was thta simple as adding virtio-mmio device to machine model. Now I can easy share files between host and arm quest. Thanks, Marcin Od: Krzeminski, Marcin (Nokia - PL/Wroclaw) Wysłano: