Re: [Qemu-devel] [PATCH for-2.6] nbd: Don't fail handshake on NBD_OPT_LIST descriptions

2016-04-07 Thread Alex Bligh
On 8 Apr 2016, at 02:09, Eric Blake wrote: > The NBD Protocol states that NBD_REP_SERVER may set > 'length > sizeof(namelen) + namelen'; in which case the rest > of the packet is a UTF-8 description of the export. While we > don't know of any NBD servers that send this

Re: [Qemu-devel] run qemu on windows

2016-04-07 Thread Stefan Weil
Am 07.04.2016 um 23:45 schrieb Safa Hamza: > hello > how to download qemu from source on windows7 64 bits , i needed from > source because im going to patch it , then i need to run it with > several architecture armv7 armv8 intelx64_86 intelx86 > any suggestion please > thanks Please have a

Re: [Qemu-devel] [PATCH] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

2016-04-07 Thread Changlong Xie
On 04/07/2016 07:44 PM, Paolo Bonzini wrote: Until commit 1c778ef7 ("nbd: convert to using I/O channels for actual socket I/O", 2016-02-16), nbd_wr_sync returned -EAGAIN this scenario. nbd_reply_ready required these semantics because it has two conflicting requirements: 1) if a reply can be

[Qemu-devel] [PULL 0/1] ppc-for-2.6 queue 20160408

2016-04-07 Thread David Gibson
The following changes since commit ead5268f2166101f7dde70598c9f538a90afd8ee: Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-04-07-tag' into staging (2016-04-07 18:06:14 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git

[Qemu-devel] [PULL 1/1] spapr: Fix ibm,lrdr-capacity

2016-04-07 Thread David Gibson
From: Bharata B Rao ibm,lrdr-capacity has a field to describe the maximum address in bytes and therefore, the most memory that can be allocated to this guest. We are using maxmem for this field, but instead should use the actual RAM address corresponding to the end of

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Richard Henderson
On 04/07/2016 01:37 PM, Stefan Weil wrote: I just tested a variant with tcg_debug_assert. It creates less efficient code when debugging is disabled. Here is the code size for x86_64: with normal tcg_debug_assert: text databssdechexfilename 8293

Re: [Qemu-devel] [PATCH qemu v15 15/17] spapr_pci: Get rid of dma_loibn

2016-04-07 Thread David Gibson
On Thu, Apr 07, 2016 at 05:10:53PM +1000, Alexey Kardashevskiy wrote: > On 04/07/2016 10:50 AM, David Gibson wrote: > >s/dma_loibn/dma_liobn/ in subject line. > > > >On Mon, Apr 04, 2016 at 07:33:44PM +1000, Alexey Kardashevskiy wrote: > >>We are going to have 2 DMA windows which LIOBNs are

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

2016-04-07 Thread David Gibson
On Thu, Apr 07, 2016 at 12:27:34PM +0200, Cédric Le Goater wrote: > Hello Laurent, > > On 04/07/2016 11:13 AM, Laurent Vivier wrote: > > > > > > On 05/04/2016 04:17, David Gibson wrote: > >> From: Cédric Le Goater > >> > >> From: Benjamin Herrenschmidt

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/3] ppc: Rework POWER7 & POWER8 exception model

2016-04-07 Thread David Gibson
On Thu, Apr 07, 2016 at 12:45:41PM +0200, Laurent Vivier wrote: > > > On 07/04/2016 12:27, Cédric Le Goater wrote: > > Hello Laurent, > > > > On 04/07/2016 11:13 AM, Laurent Vivier wrote: > >> > >> > >> On 05/04/2016 04:17, David Gibson wrote: > >>> From: Cédric Le Goater >

Re: [Qemu-devel] [PULL 48/48] iotests: Test qemu-img convert -S 0 behavior

2016-04-07 Thread Fam Zheng
On Thu, 04/07 16:40, Paolo Bonzini wrote: > > > On 29/03/2016 17:08, Kevin Wolf wrote: > > From: Max Reitz > > > > Passing -S 0 to qemu-img convert should result in all source data being > > copied to the output, even if that source data is known to be 0. The > > output

[Qemu-devel] [PATCH for-2.6] nbd: Don't fail handshake on NBD_OPT_LIST descriptions

2016-04-07 Thread Eric Blake
The NBD Protocol states that NBD_REP_SERVER may set 'length > sizeof(namelen) + namelen'; in which case the rest of the packet is a UTF-8 description of the export. While we don't know of any NBD servers that send this description yet, we had better consume the data so we don't choke when we

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

2016-04-07 Thread Jon Grimm
** Changed in: livecd-rootfs (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563887 Title: qemu-system-ppc64 freezes on starting image on ppc64le Status in

[Qemu-devel] run qemu on windows

2016-04-07 Thread Safa Hamza
hello how to download qemu from source on windows7 64 bits , i needed from source because im going to patch it , then i need to run it with several architecture armv7 armv8 intelx64_86 intelx86 any suggestion please thanks

Re: [Qemu-devel] [PATCHv3] Improve documentation for TLS

2016-04-07 Thread Alex Bligh
Eric, > Qemu's initial implementation of TLS in the client is binary (you either > want TLS or plaintext; there's no way to connect to a server and then > decide whether to upgrade to TLS - a plaintext client will never use TLS > of an OPTIONALTLS server). In TLS mode, the client always sends >

[Qemu-devel] [PULL for-2.6] target-xtensa fix

2016-04-07 Thread Max Filippov
Hi Peter, please pull the following fix for target-xtensa. The following changes since commit a648c137383d84bc4f95696e5293978d9541a26e: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160309-1' into staging (2016-03-10 02:51:14 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH for-2.6] nbd: Don't kill server on client that doesn't request TLS

2016-04-07 Thread Alex Bligh
On 7 Apr 2016, at 21:29, Eric Blake wrote: > Upstream NBD is documenting that servers MAY choose to operate > in a conditional mode, where it is up to the client whether to > use TLS. For qemu's case, we want to always be in FORCEDTLS > mode, because of the risk of

[Qemu-devel] [PATCH v2 03/13] seqlock: remove optional mutex

2016-04-07 Thread Emilio G. Cota
This option is unused; besides, it bloats the struct when not needed. Let's just let writers define their own locks elsewhere. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota --- cpus.c | 2 +- include/qemu/seqlock.h | 10

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

2016-04-07 Thread Richard Henderson
On 04/07/2016 10:19 AM, Emilio G. Cota wrote: We are inconsistent with the type of tb->flags: usage varies loosely between int and uint64_t. Settle to uint32_t everywhere, which is superior to both: at least one target (aarch64) uses the most significant bit in the u32, and uint64_t is wasteful.

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

2016-04-07 Thread Edgar E. Iglesias
On Thu, Apr 07, 2016 at 01:19:22PM -0400, Emilio G. Cota wrote: > We are inconsistent with the type of tb->flags: usage varies loosely > between int and uint64_t. Settle to uint32_t everywhere, which is > superior to both: at least one target (aarch64) uses the most significant > bit in the u32,

Re: [Qemu-devel] [PATCHv4] Improve documentation for TLS

2016-04-07 Thread Alex Bligh
On 7 Apr 2016, at 21:35, Eric Blake wrote: > grammar tweak: > s/ and either /, / sigh. fixed. Remembered to add your Reviewed-by: tag too. -- Alex Bligh signature.asc Description: Message signed with OpenPGP using GPGMail

[Qemu-devel] [PATCHv5] Improve documentation for TLS

2016-04-07 Thread Alex Bligh
* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a

[Qemu-devel] [PULL v2 00/15] Misc changes for QEMU 2.6.0-rc2

2016-04-07 Thread Paolo Bonzini
The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Stefan Weil
Am 07.04.2016 um 21:16 schrieb Stefan Weil: > Am 07.04.2016 um 20:15 schrieb Richard Henderson: >> On 04/07/2016 08:53 AM, Sergey Fedorov wrote: >>> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG >>> defined). >>> + * Without assertions, the interpreter runs much faster. */

[Qemu-devel] [PATCH for-2.7 1/1] block/gluster: add support for selecting debug logging level

2016-04-07 Thread Jeff Cody
This adds commandline support for the logging level of the gluster protocol driver, output to stdout. The option is 'debug', e.g.: -drive filename=gluster://192.168.15.180/gv2/test.qcow2,debug=9 Debug levels are 0-9, with 9 being the most verbose, and 0 representing no debugging output. The

Re: [Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option

2016-04-07 Thread Eric Blake
On 04/07/2016 10:50 AM, Paolo Bonzini wrote: > From: Eric Blake > > nbd-server.c currently fails to handle unsupported options properly. > If during option haggling the client sends an unknown request, the > server kills the connection instead of letting the client try to >

[Qemu-devel] [PATCH v2 00/10] tb hash improvements

2016-04-07 Thread Emilio G. Cota
See v1 for context: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg00587.html All patches in v2 are checkpatch-clean, except 05 (checkpatch should be ignored for this one) and 06, which I took unmodified (later patches fix those warnings while doing other things, anyway). Note that

Re: [Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

2016-04-07 Thread Emilio G. Cota
On Thu, Apr 07, 2016 at 13:19:22 -0400, Emilio G. Cota wrote: > We are inconsistent with the type of tb->flags: usage varies loosely > between int and uint64_t. Settle to uint32_t everywhere, which is > superior to both: at least one target (aarch64) uses the most significant > bit in the u32, and

[Qemu-devel] [PATCH v2 07/13] qemu-thread: call cpu_relax() while spinning

2016-04-07 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/qemu/thread.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/qemu/thread.h b/include/qemu/thread.h index 1aa843b..599965e 100644 --- a/include/qemu/thread.h +++ b/include/qemu/thread.h @@ -2,6 +2,7 @@

Re: [Qemu-devel] [PULL 01/15] ps2kbd: default to scancode_set 2, as with KBD_CMD_RESET

2016-04-07 Thread Peter Maydell
On 7 April 2016 at 17:50, Paolo Bonzini wrote: > From: Hervé Poussineau > > This line has been added in commit ef74679a810fe6858f625b9d52b68cc3fc61eb3d > with > other initializations. However, scancode set 0 doesn't exist (only 1, 2, 3). > This works

Re: [Qemu-devel] [PATCHv3] Improve documentation for TLS

2016-04-07 Thread Eric Blake
On 04/07/2016 12:32 PM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as

[Qemu-devel] [PATCH v2 08/13] qemu-thread: optimize spin_lock for uncontended locks

2016-04-07 Thread Emilio G. Cota
This way we can acquire the lock with xchg+test, instead of test+xchg+test. Most spinlocks should be uncontended so this should result in a ne performance gain. Before: 4ad957: eb 09 jmp4ad962 4ad959: 0f 1f 80 00 00 00 00nopl 0x0(%rax)

[Qemu-devel] [PATCH v2 02/13] compiler.h: add QEMU_ALIGNED() to enforce struct alignment

2016-04-07 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/qemu/compiler.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index 8f1cc7b..1978ddc 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -41,6 +41,8 @@ # define

[Qemu-devel] [PATCH v2 10/13] tb hash: hash phys_pc, pc, and flags with xxhash

2016-04-07 Thread Emilio G. Cota
For some workloads such as arm bootup, tb_phys_hash is performance-critical. The is due to the high frequency of accesses to the hash table, originated by (frequent) TLB flushes that wipe out the cpu-private tb_jmp_cache's. More info:

[Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock

2016-04-07 Thread Emilio G. Cota
From: Guillaume Delbergue Signed-off-by: Guillaume Delbergue [Rewritten. - Paolo] Signed-off-by: Paolo Bonzini --- include/qemu/thread.h | 31 +++ 1 file changed, 31

[Qemu-devel] [PATCH for-2.6] nbd: Don't kill server on client that doesn't request TLS

2016-04-07 Thread Eric Blake
Upstream NBD is documenting that servers MAY choose to operate in a conditional mode, where it is up to the client whether to use TLS. For qemu's case, we want to always be in FORCEDTLS mode, because of the risk of man-in-the-middle attacks, and since we never export more than one device;

[Qemu-devel] [PATCH v2 04/13] seqlock: rename write_lock/unlock to write_begin/end

2016-04-07 Thread Emilio G. Cota
It is a more appropriate name, now that the mutex embedded in the seqlock is gone. Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota --- cpus.c | 28 ++-- include/qemu/seqlock.h | 4 ++-- 2 files changed, 16

Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error

2016-04-07 Thread Sascha Silbe
Dear Max, Max Reitz writes: > On 05.04.2016 11:21, Sascha Silbe wrote: [...] [_remove_if_exists()] > Not sure about the leading underscore (it appears to be the only such > function in iotests.py besides __init__()), but I guess it's a test so > it doesn't really matter

[Qemu-devel] [PATCH v2 09/13] exec: add tb_hash_func5, derived from xxhash

2016-04-07 Thread Emilio G. Cota
This will be used by upcoming changes for hashing the tb hash. Add this into a separate file to include the copyright notice from xxhash. Signed-off-by: Emilio G. Cota --- include/exec/tb-hash-xx.h | 103 ++ 1 file changed, 103

Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO

2016-04-07 Thread Sascha Silbe
Dear Max, Max Reitz writes: > On 05.04.2016 11:21, Sascha Silbe wrote: >> On systems with fast IO, qemu-io may write more than 1 MiB before >> receiving the block-job-cancel command, causing the test case to fail. >> >> 141 is inherently racy, but we can at least reduce the

[Qemu-devel] [PULL 1/1] tci: Fix build regression

2016-04-07 Thread Stefan Weil
Commit d38ea87ac54af64ef611de434d07c12dc0399216 cleaned the include statements which resulted in a wrong order of assert.h and the definition of NDEBUG in tci.c. Normally NDEBUG modifies the definition of the assert macro, but here this definition comes too late which results in a failing build.

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Stefan Weil
Am 07.04.2016 um 20:15 schrieb Richard Henderson: > On 04/07/2016 08:53 AM, Sergey Fedorov wrote: >> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG >> defined). >> + * Without assertions, the interpreter runs much faster. */ >> +#if defined(CONFIG_DEBUG_TCG) >> +# define

[Qemu-devel] [PULL 0/1] TCI patch queue for QEMU 2.6.0-rc2

2016-04-07 Thread Stefan Weil
at: git://qemu.weilnetz.de/qemu.git tags/pull-tci-20160407 for you to fetch changes up to 3ccdbecf80a322a31dbf452d433321c67f82d534: tci: Fix build regression (2016-04-07 19:01:21 +0200) tci patch queue

Re: [Qemu-devel] [PATCH v2] fw_cfg: RFQDN rules, documentation

2016-04-07 Thread Michael S. Tsirkin
On Thu, Apr 07, 2016 at 12:55:16PM -0400, Gabriel L. Somlo wrote: ... > > > question is, I think: > > > > > > Should we allow QEMU firmware developers to create special settings, > > > to be populated manually by their end-users, that the guest kernel > > > would be prevented from seeing? >

Re: [Qemu-devel] [PATCH v3 0/7] virtio: aio handler API

2016-04-07 Thread Christian Borntraeger
On 04/06/2016 12:16 PM, Paolo Bonzini wrote: > This version removes patches 1 and 9, fixes some commit messages, and > fixes some small in the formatting issues. > > Michael S. Tsirkin (2): > virtio: add aio handler > virtio-blk: use aio handler for data plane > > Paolo Bonzini (5): >

[Qemu-devel] [PATCH v2 12/13] qht: add test program

2016-04-07 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- tests/.gitignore | 1 + tests/Makefile | 6 ++- tests/test-qht.c | 109 +++ 3 files changed, 115 insertions(+), 1 deletion(-) create mode 100644 tests/test-qht.c diff --git

Re: [Qemu-devel] [PATCHv2] Improve documentation for TLS

2016-04-07 Thread Eric Blake
On 04/07/2016 09:33 AM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as

Re: [Qemu-devel] [PATCHv4] Improve documentation for TLS

2016-04-07 Thread Eric Blake
On 04/07/2016 02:07 PM, Alex Bligh wrote: > * Call out TLS into a separate section > > * Add details of the TLS protocol itself > > * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can > be initiated from either side (as required by the TLS standard I believe > and as

[Qemu-devel] [PATCHv4] Improve documentation for TLS

2016-04-07 Thread Alex Bligh
* Call out TLS into a separate section * Add details of the TLS protocol itself * Emphasise that actual TLS session initiation (i.e. the TLS handshake) can be initiated from either side (as required by the TLS standard I believe and as actually works in practice) * Clarify what is a

[Qemu-devel] [PATCH] tb: consistently use uint32_t for tb->flags

2016-04-07 Thread Emilio G. Cota
We are inconsistent with the type of tb->flags: usage varies loosely between int and uint64_t. Settle to uint32_t everywhere, which is superior to both: at least one target (aarch64) uses the most significant bit in the u32, and uint64_t is wasteful. Compile-tested for all targets. Suggested-by:

[Qemu-devel] [PATCH v2 05/13] include/processor.h: define cpu_relax()

2016-04-07 Thread Emilio G. Cota
Taken from the linux kernel. Signed-off-by: Emilio G. Cota --- include/qemu/processor.h | 28 1 file changed, 28 insertions(+) create mode 100644 include/qemu/processor.h diff --git a/include/qemu/processor.h b/include/qemu/processor.h new file

Re: [Qemu-devel] [Qemu-block] [PATCH 1/7] qemu-iotests: check: don't place files with predictable names in /tmp

2016-04-07 Thread Sascha Silbe
Dear Max, Max Reitz writes: > You decide whether you want to drop the tmp=/tmp/$$ lines in the tests > in a dedicated (follow-up) patch or include it here. Let's land this one first; I'll address the other occurrences in a separate patch. I've put it on my todo list. Thanks

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Richard Henderson
On 04/07/2016 08:53 AM, Sergey Fedorov wrote: +/* Enable TCI assertions only when debugging TCG (and without NDEBUG defined). + * Without assertions, the interpreter runs much faster. */ +#if defined(CONFIG_DEBUG_TCG) +# define tci_assert(cond) assert(cond) +#else +# define tci_assert(cond)

[Qemu-devel] [PATCH v2] exec.c: Ensure right alignment also for file backed ram

2016-04-07 Thread Dominik Dingel
While in the anonymous ram case we already take care of the right alignment such an alignment gurantee does not exist for file backed ram allocation. Instead, pagesize is used for alignment. On s390 this is not enough for gmap, as we need to satisfy an alignment up to segments. Reported-by:

Re: [Qemu-devel] [PATCH 0/2] target-mips: Initiate IEEE 754-2008 support for Mips

2016-04-07 Thread Maciej W. Rozycki
On Thu, 7 Apr 2016, Aleksandar Markovic wrote: > This patch series is based on the original set of patches proposed by Maciej > Rozycki: http://lists.nongnu.org/archive/html/qemu-devel/2014-12/msg00968.html Please try and spell out my name in full, thank you. Maciej

Re: [Qemu-devel] [PATCH v2] fw_cfg: RFQDN rules, documentation

2016-04-07 Thread Laszlo Ersek
On 04/07/16 18:40, Michael S. Tsirkin wrote: > On Thu, Apr 07, 2016 at 06:23:24PM +0200, Laszlo Ersek wrote: >> Should we allow QEMU firmware developers to create special settings, >> to be populated manually by their end-users, that the guest kernel >> would be prevented from seeing? > >

[Qemu-devel] [PULL for-2.6 1/2] qga: fix fd leak with guest-exec i/o channels

2016-04-07 Thread Michael Roth
From: Yuriy Pudgorodskiy Signed-off-by: Yuriy Pudgorodskiy Signed-off-by: Denis V. Lunev CC: Michael Roth * squashed in g_io_channel_shutdown() to match cleanup paths for input/output Signed-off-by: Michael

Re: [Qemu-devel] [PATCH v2 0/2] Convert pxb initfn to Error

2016-04-07 Thread Michael S. Tsirkin
On Thu, Apr 07, 2016 at 07:44:17PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 07, 2016 at 06:39:10PM +0200, Markus Armbruster wrote: > > Marcel Apfelbaum writes: > > > > > On 03/23/2016 01:56 PM, Markus Armbruster wrote: > > >> Wei Jiangang

[Qemu-devel] [PULL for-2.6 0/2] qemu-ga patch queue for 2.6

2016-04-07 Thread Michael Roth
The following changes since commit e380023898479b57d38c0569c02f7bd41090181b: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2016-04-07 12:15:33 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2016-04-07-tag

Re: [Qemu-devel] [PATCH v2] fw_cfg: RFQDN rules, documentation

2016-04-07 Thread Gabriel L. Somlo
On Thu, Apr 07, 2016 at 07:40:12PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 07, 2016 at 06:23:24PM +0200, Laszlo Ersek wrote: > > On 04/07/16 17:38, Michael S. Tsirkin wrote: > > > This requires that all -fw_cfg command line users use names of the form > > > opt/RFQDN/: such names are

Re: [Qemu-devel] [PATCH] xen: piix reuse pci generic class init function

2016-04-07 Thread Stefano Stabellini
On Thu, 7 Apr 2016, John Snow wrote: > > On Wed, Apr 06, 2016 at 04:56:12PM -0700, Stefano Stabellini wrote: > >> On Sun, 3 Apr 2016, Michael S. Tsirkin wrote: > >>> piix3_ide_xen_class_init is identical to piix3_ide_class_init > >>> except it's buggy as it does not set exit and does not disable >

[Qemu-devel] [PULL 12/15] hostmem-file: fix memory leak

2016-04-07 Thread Paolo Bonzini
From: Gonglei Signed-off-by: Gonglei Message-Id: <1456998223-12356-5-git-send-email-arei.gong...@huawei.com> Signed-off-by: Paolo Bonzini --- backends/hostmem-file.c | 5 - 1 file changed, 4 insertions(+), 1

[Qemu-devel] [PULL 14/15] tests: ignore test-logging

2016-04-07 Thread Paolo Bonzini
From: Changlong Xie Commit 3514552e added a new test, but did not mark it for exclusion in .gitignore. Signed-off-by: Changlong Xie Reviewed-by: Eric Blake Message-Id:

[Qemu-devel] [PULL for-2.6 2/2] qga: Workaround for console redirection from non-interactive qemu-ga service

2016-04-07 Thread Michael Roth
From: Yuri Pudgorodskiy mingw-glib uses helper process to assist gspawn() api. There are two versions of helpers, one with main() and another with WinMain() startup routines. Whenever gspawn() detects consoleless environment (and qemu-ga is running in such environment as

[Qemu-devel] [PULL 06/15] nbd: Improve debug traces on little-endian

2016-04-07 Thread Paolo Bonzini
From: Eric Blake Print debug tracing messages while data is still in native ordering, rather than after we've potentially swapped it into network order for transmission. Also, it's nice if the server mentions what it is replying, to correlate it to with what the client says

[Qemu-devel] [PULL 13/15] translate-all: add missing fold of tb_ctx into tcg_ctx

2016-04-07 Thread Paolo Bonzini
From: "Emilio G. Cota" Since 5e5f07e08 "TCG: Move translation block variables to new context inside tcg_ctx: tb_ctx" on Feb 1 2013, compilation of usermode + TB_DEBUG_CHECK has been broken. Fix it. Signed-off-by: Emilio G. Cota Message-Id:

[Qemu-devel] [PULL 15/15] target-i386: check for PKU even for non-writable pages

2016-04-07 Thread Paolo Bonzini
Xiao Guangrong ran kvm-unit-tests on an actual machine with PKU and found that it fails: test pte.p pte.user pde.p pde.user pde.a pde.pse pkru.wd pkey=1 user write efer.nx cr4.pke: FAIL: error code 27 expected 7 Dump mapping: address: 0x1234 --L4: 2ebe007 --L3: 2ebf007 --L2:

[Qemu-devel] [PULL 05/15] nbd: Avoid bitrot in TRACE() usage

2016-04-07 Thread Paolo Bonzini
From: Eric Blake The compiler is smart enough to optimize out 'if (0)', but won't type-check our printfs if they are hidden behind #if. Signed-off-by: Eric Blake Message-Id: <1459913704-19949-3-git-send-email-ebl...@redhat.com> Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 09/15] nbd: Don't kill server when client requests unknown option

2016-04-07 Thread Paolo Bonzini
From: Eric Blake nbd-server.c currently fails to handle unsupported options properly. If during option haggling the client sends an unknown request, the server kills the connection instead of letting the client try to fall back to something older. This is precisely what

[Qemu-devel] [PULL 10/15] nbd: do not hang nbd_wr_syncv if outside a coroutine and no available data

2016-04-07 Thread Paolo Bonzini
Until commit 1c778ef7 ("nbd: convert to using I/O channels for actual socket I/O", 2016-02-16), nbd_wr_sync returned -EAGAIN this scenario. nbd_reply_ready required these semantics because it has two conflicting requirements: 1) if a reply can be received on the socket, nbd_reply_ready needs to

[Qemu-devel] [PULL 02/15] hw/timer: Revert "hpet: inverse polarity when pin above ISA_NUM_IRQS"

2016-04-07 Thread Paolo Bonzini
From: Bill Paul This reverts commit 0d63b2dd31464cfccc80bbeedc24e3863fe4c895. This change was originally intended to correct the HPET behavior in conjunction with Linux, however the behavior that it actually creates is not compatible with the ioapic.c implementation; it

[Qemu-devel] [PULL 08/15] nbd: Fix NBD unsupported options

2016-04-07 Thread Paolo Bonzini
From: Alex Bligh nbd-client.c currently fails to handle unsupported options properly. If during option haggling the server finds an option that is unsupported, it returns an NBD_REP_ERR_UNSUP reply. According to nbd's proto.md, the format for such a reply should be: S: 64

[Qemu-devel] [PULL 04/15] nbd: Return correct error for write to read-only export

2016-04-07 Thread Paolo Bonzini
From: Eric Blake The NBD Protocol requires that servers should send EPERM for attempts to write (or trim) a read-only export. We were correct for TRIM (blk_co_discard() gave EPERM); but were manually setting EROFS which then got mapped to EINVAL over the wire on writes.

[Qemu-devel] [PULL 00/15] Misc patches for QEMU 2.6.0-rc2

2016-04-07 Thread Paolo Bonzini
The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

[Qemu-devel] [PULL 11/15] spapr: fix possible Negative array index read

2016-04-07 Thread Paolo Bonzini
From: Gonglei fix CID 1351391. Signed-off-by: Gonglei Message-Id: <1456998223-12356-6-git-send-email-arei.gong...@huawei.com> Signed-off-by: Paolo Bonzini --- hw/ppc/spapr.c | 4 1 file changed, 4 insertions(+) diff

[Qemu-devel] [PULL 07/15] qemu-nbd: Document -x option

2016-04-07 Thread Paolo Bonzini
From: Eric Blake Commit 3d4b2f9c added -x to force qemu-nbd to use new-style negotiation, but while it documented it in the man page, it omitted docs in the --help output. Signed-off-by: Eric Blake Message-Id:

[Qemu-devel] [PULL 03/15] docs: fix typo in memory.txt

2016-04-07 Thread Paolo Bonzini
From: Wei Jiangang The space between 7000 and 8000 is too wide by 1 character. Also correct the range of vga-window example 0xa-0xb. Signed-off-by: Wei Jiangang Message-Id:

[Qemu-devel] [PULL 01/15] ps2kbd: default to scancode_set 2, as with KBD_CMD_RESET

2016-04-07 Thread Paolo Bonzini
From: Hervé Poussineau This line has been added in commit ef74679a810fe6858f625b9d52b68cc3fc61eb3d with other initializations. However, scancode set 0 doesn't exist (only 1, 2, 3). This works well as long as operating system is resetting keyboard, or overwriting the

Re: [Qemu-devel] [PATCH v2 0/2] Convert pxb initfn to Error

2016-04-07 Thread Michael S. Tsirkin
On Thu, Apr 07, 2016 at 06:39:10PM +0200, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > On 03/23/2016 01:56 PM, Markus Armbruster wrote: > >> Wei Jiangang writes: > >> > >>> v1 -> v2: > >>> > >>> - Extract a separate bugfix patch > >>> -

Re: [Qemu-devel] [PATCH v2] fw_cfg: RFQDN rules, documentation

2016-04-07 Thread Michael S. Tsirkin
On Thu, Apr 07, 2016 at 06:23:24PM +0200, Laszlo Ersek wrote: > On 04/07/16 17:38, Michael S. Tsirkin wrote: > > This requires that all -fw_cfg command line users use names of the form > > opt/RFQDN/: such names are compatible with QEMU 2.4 and 2.5 as well as > > future QEMU versions. > > > > As

Re: [Qemu-devel] [PATCH v2 0/2] Convert pxb initfn to Error

2016-04-07 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 03/23/2016 01:56 PM, Markus Armbruster wrote: >> Wei Jiangang writes: >> >>> v1 -> v2: >>> >>> - Extract a separate bugfix patch >>> - Squash v1 patches 1-3 together >>> - Drop the period and exclamation mark >>> -

[Qemu-devel] [PATCH v4 7/8] linux-aio: make it more type safe

2016-04-07 Thread Paolo Bonzini
Replace void* with an opaque LinuxAioState type. Signed-off-by: Paolo Bonzini --- block/linux-aio.c | 46 +- block/raw-aio.h | 15 --- block/raw-posix.c | 4 ++-- 3 files changed, 27 insertions(+), 38 deletions(-)

[Qemu-devel] [PATCH v4 6/8] block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end

2016-04-07 Thread Paolo Bonzini
Extract the handling of io_plug "depth" from linux-aio.c and let the main bdrv_drain loop do nothing but wait on I/O. Like the two newly introduced functions, bdrv_io_plug and bdrv_io_unplug now operate on all children. The visit order is now symmetrical between plug and unplug, making it

[Qemu-devel] [PATCH v4 5/8] block: introduce bdrv_no_throttling_begin/end

2016-04-07 Thread Paolo Bonzini
Extract the handling of throttling from bdrv_flush_io_queue. These new functions will soon become BdrvChildRole callbacks, as they can be generalized to "beginning of drain" and "end of drain". Reviewed-by: Alberto Garcia Signed-off-by: Paolo Bonzini ---

[Qemu-devel] [PATCH v4 1/8] block: Don't disable I/O throttling on sync requests

2016-04-07 Thread Paolo Bonzini
From: Kevin Wolf We had to disable I/O throttling with synchronous requests because we didn't use to run timers in nested event loops when the code was introduced. This isn't true any more, and throttling works just fine even when using the synchronous API. The removed code is

[Qemu-devel] [PATCH v4 2/8] block: make bdrv_start_throttled_reqs return void

2016-04-07 Thread Paolo Bonzini
The return value is unused and I am not sure why it would be useful. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- block/io.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/block/io.c b/block/io.c index

[Qemu-devel] [PATCH v4 4/8] block: extract bdrv_drain_poll/bdrv_co_yield_to_drain from bdrv_drain/bdrv_co_drain

2016-04-07 Thread Paolo Bonzini
Do not call bdrv_drain_recurse twice in bdrv_co_drain. A small tweak to the logic in Fam's patch, which is harmless since no one implements bdrv_drain anyway. But better get it right. Signed-off-by: Paolo Bonzini --- v4: new block/io.c | 35

[Qemu-devel] [PATCH v4 8/8] linux-aio: share one LinuxAioState within an AioContext

2016-04-07 Thread Paolo Bonzini
This has better performance because it executes fewer system calls and does not use a bottom half per disk. Originally proposed by Ming Lei. Signed-off-by: Paolo Bonzini --- async.c| 23 +++ block/linux-aio.c | 3 +

[Qemu-devel] [PATCH v4 0/8] bdrv_flush_io_queue removal, shared LinuxAioState

2016-04-07 Thread Paolo Bonzini
Patch 1 comes from Kevin's series to do BlockBackend throttling. Patches 2-6 are from my bdrv_drain patches. They apply on top of Fam's patch (which will be in 2.6) that introduces bdrv_co_drain. Patch 4 is new in this version, compared to v3. Patches 7-8 are new but based on Ming Lei's old

[Qemu-devel] [PATCH v4 3/8] block: move restarting of throttled reqs to block/throttle-groups.c

2016-04-07 Thread Paolo Bonzini
We want to remove throttled_reqs from block/io.c. This is the easy part---hide the handling of throttled_reqs during disable/enable of throttling within throttle-groups.c. Signed-off-by: Paolo Bonzini --- v1->v2: only restart first request after

Re: [Qemu-devel] [RFC v2 0/6] QEMU shared-memory backend

2016-04-07 Thread Markus Armbruster
Baptiste Reynal writes: > On Tue, Mar 22, 2016 at 3:14 PM, Markus Armbruster wrote: >> >> Copying Paolo, author of memory-backend-file. >> >> Baptiste Reynal writes: >> >> > A new memory backend, the shared

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.6] crypto: Avoid memory leak on failure

2016-04-07 Thread Eric Blake
On 04/07/2016 09:14 AM, Markus Armbruster wrote: > Max Reitz writes: > >> On 01.04.2016 17:57, Eric Blake wrote: >>> Commit 7836857 introduced a memory leak due to invalid use of >>> Error vs. visit_type_end(). If visiting the intermediate >>> members fails, we clear the

Re: [Qemu-devel] [PATCH v2] fw_cfg: RFQDN rules, documentation

2016-04-07 Thread Laszlo Ersek
On 04/07/16 17:38, Michael S. Tsirkin wrote: > This requires that all -fw_cfg command line users use names of the form > opt/RFQDN/: such names are compatible with QEMU 2.4 and 2.5 as well as > future QEMU versions. > > As ability to insert fw_cfg entries in QEMU root is useful for > firmware

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-07 Thread Sergey Fedorov
On 07/04/16 19:18, Cornelia Huck wrote: > On Thu, 7 Apr 2016 18:53:44 +0300 > Sergey Fedorov wrote: > >> From: Sergey Fedorov >> >> Signed-off-by: Sergey Fedorov >> Signed-off-by: Sergey Fedorov

Re: [Qemu-devel] [Nbd] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-04-07 Thread Alex Bligh
On 7 Apr 2016, at 17:10, Eric Blake wrote: > I'm also starting to think that it is worth FIRST documenting an > extension for advertising block sizes, so that we can then couch > BLOCK_STATUS in those terms (a server MUST NOT subdivide status into > finer granularity than the

Re: [Qemu-devel] [PATCH 02/11] pc-bios/s390-ccw: Use correct strip when cross-compiling

2016-04-07 Thread Cornelia Huck
On Thu, 7 Apr 2016 18:53:44 +0300 Sergey Fedorov wrote: > From: Sergey Fedorov > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov Any reason you use two different email

Re: [Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

2016-04-07 Thread Jeff Cody
On Wed, Apr 06, 2016 at 01:02:16PM +0200, Kevin Wolf wrote: > [ Adding some CCs ] > > Am 06.04.2016 um 05:29 hat Jeff Cody geschrieben: > > Upon receiving an I/O error after an fsync, by default gluster will > > dump its cache. However, QEMU will retry the fsync, which is especially > > useful

Re: [Qemu-devel] [PATCH v2] doc: Add NBD_CMD_BLOCK_STATUS extension

2016-04-07 Thread Eric Blake
On 04/07/2016 04:38 AM, Vladimir Sementsov-Ogievskiy wrote: > On 05.04.2016 16:43, Paolo Bonzini wrote: >> >> On 05/04/2016 06:05, Kevin Wolf wrote: >>> The options I can think of is adding a request field "max number of >>> descriptors" or a flag "only single descriptor" (with the assumption >>>

Re: [Qemu-devel] [PATCH V3] tap: vhost busy polling support

2016-04-07 Thread Greg Kurz
On Thu, 7 Apr 2016 12:56:24 +0800 Jason Wang wrote: > This patch add the capability of basic vhost net busy polling which is > supported by recent kernel. User could configure the maximum number of > us that could be spent on busy polling through a new property of tap >

Re: [Qemu-devel] [PATCH 10/11] tcg/mips: Make direct jump patching thread-safe

2016-04-07 Thread Sergey Fedorov
On 07/04/16 19:01, Paolo Bonzini wrote: > > On 07/04/2016 17:53, Sergey Fedorov wrote: >> Ensure direct jump patching in MIPS is atomic by using >> atomic_read()/atomic_set() for code patching. >> >> Signed-off-by: Sergey Fedorov >> Signed-off-by: Sergey Fedorov

[Qemu-devel] [PATCH 1/2] softfloat: Implement run-time-configurable meaning of signaling NaN bit

2016-04-07 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch modifies SoftFloat library so that it can be configured at run-time in relation to the meaning of signaling NaN bit, while, at the same time, strictly preserving its behavior on all existing platforms. Background: In

  1   2   3   >